rdsr commented on a change in pull request #526: Add Baseline to iceberg-parquet
URL: https://github.com/apache/incubator-iceberg/pull/526#discussion_r03586
##
File path: build.gradle
##
@@ -165,7 +165,7 @@ task deploySite(type: Exec) {
// Baseline style guide.
def
rdsr commented on issue #525: Apply Baseline to iceberg-pig
URL: https://github.com/apache/incubator-iceberg/pull/525#issuecomment-540294316
It seems there are a few more checkstyle errors being reported by
`iceberg-pig` module in the travis build
manishmalhotrawork commented on a change in pull request #524: respect
commit.manifest.min.count
URL: https://github.com/apache/incubator-iceberg/pull/524#discussion_r333281246
##
File path: core/src/main/java/org/apache/iceberg/MergingSnapshotProducer.java
##
@@ -595,6
ppadma commented on issue #491: Use relative path for manifest_path and
file_path
URL: https://github.com/apache/incubator-iceberg/pull/491#issuecomment-540242391
@rdblue @jun-ma-0 We have a use case for some complex migration scenarios
where table data could be in multiple locations. We
aokolnychyi commented on a change in pull request #524: respect
commit.manifest.min.count
URL: https://github.com/apache/incubator-iceberg/pull/524#discussion_r333245819
##
File path: core/src/main/java/org/apache/iceberg/MergingSnapshotProducer.java
##
@@ -595,6 +595,9
aokolnychyi commented on a change in pull request #524: respect
commit.manifest.min.count
URL: https://github.com/apache/incubator-iceberg/pull/524#discussion_r333245244
##
File path: core/src/main/java/org/apache/iceberg/MergingSnapshotProducer.java
##
@@ -595,6 +595,9
rdsr opened a new issue #528: Infer name mapping from expected schema
URL: https://github.com/apache/incubator-iceberg/issues/528
We can infer name mapping in certain scenarios. As per @rdblue
> 1. If there is a name mapping in table metadata, pass it in
> 1. Otherwise, if the
rdblue commented on issue #527: Update docs to Gradle 5.4.1
URL: https://github.com/apache/incubator-iceberg/pull/527#issuecomment-540183270
Thanks @Fokko!
This is an automated message from the Apache Git Service.
To respond
rdblue closed issue #167: Update gradle version in README.md
URL: https://github.com/apache/incubator-iceberg/issues/167
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
Fokko opened a new pull request #527: Update docs to Gradle 5.4.1
URL: https://github.com/apache/incubator-iceberg/pull/527
Fixes https://github.com/apache/incubator-iceberg/issues/167
This is an automated message from the
rdblue commented on issue #156: [Baseline] Apply Baseline to iceberg-data
URL:
https://github.com/apache/incubator-iceberg/issues/156#issuecomment-540175400
Fixed by #198.
This is an automated message from the Apache Git
rdblue closed issue #156: [Baseline] Apply Baseline to iceberg-data
URL: https://github.com/apache/incubator-iceberg/issues/156
This is an automated message from the Apache Git Service.
To respond to the message, please log
Fokko commented on issue #33: Add Avro support to Pig reader
URL:
https://github.com/apache/incubator-iceberg/issues/33#issuecomment-540174195
I can pick this up
This is an automated message from the Apache Git Service.
To
Fokko commented on issue #156: [Baseline] Apply Baseline to iceberg-data
URL:
https://github.com/apache/incubator-iceberg/issues/156#issuecomment-540173778
@rdsr @mccheah @rdblue I think we can close this one:
https://github.com/apache/incubator-iceberg/blob/master/build.gradle#L167
rdblue commented on issue #491: Use relative path for manifest_path and
file_path
URL: https://github.com/apache/incubator-iceberg/pull/491#issuecomment-540173189
I agree with the approach of making relative paths optional. If a path is a
full path, then use it. But if it is a relative
Fokko opened a new pull request #526: Add Baseline to iceberg-parquet
URL: https://github.com/apache/incubator-iceberg/pull/526
Fixes https://github.com/apache/incubator-iceberg/issues/155
This is an automated message from
rdblue commented on issue #514: Fix for cannot update an Iceberg dataset from a
Parquet file (#510)
URL: https://github.com/apache/incubator-iceberg/pull/514#issuecomment-540168081
This looks like a great start, but I think this should be controlled by an
option (possibly a table option
rdblue commented on issue #510: Cannot update an Iceberg dataset from a Parquet
file due to "field should be required, but is optional"
URL:
https://github.com/apache/incubator-iceberg/issues/510#issuecomment-540167159
@andrei-ionescu, sorry for the delay, I had fallen behind with
rdblue commented on a change in pull request #207: Add external schema mappings
for files written with name-based schemas #40
URL: https://github.com/apache/incubator-iceberg/pull/207#discussion_r333203489
##
File path:
rdsr commented on a change in pull request #207: Add external schema mappings
for files written with name-based schemas #40
URL: https://github.com/apache/incubator-iceberg/pull/207#discussion_r333202728
##
File path: core/src/main/java/org/apache/iceberg/avro/PruneColumns.java
rdsr commented on a change in pull request #207: Add external schema mappings
for files written with name-based schemas #40
URL: https://github.com/apache/incubator-iceberg/pull/207#discussion_r333201960
##
File path:
rdblue commented on issue #524: respect commit.manifest.min.count
URL: https://github.com/apache/incubator-iceberg/pull/524#issuecomment-540155136
@manishmalhotrawork, can you describe what this change does?
This is an
rdblue commented on issue #499: Add persistent IDs to partition fields (WIP)
URL: https://github.com/apache/incubator-iceberg/pull/499#issuecomment-540154278
It looks like this is trying to assign the same IDs for a spec each time it
is created, but I think the approach should be to assign
rdblue commented on a change in pull request #499: Add persistent IDs to
partition fields (WIP)
URL: https://github.com/apache/incubator-iceberg/pull/499#discussion_r333186407
##
File path: core/src/main/java/org/apache/iceberg/PartitionSpecParser.java
##
@@ -33,14 +33,19
rdblue commented on a change in pull request #499: Add persistent IDs to
partition fields (WIP)
URL: https://github.com/apache/incubator-iceberg/pull/499#discussion_r333186632
##
File path: core/src/main/java/org/apache/iceberg/PartitionSpecParser.java
##
@@ -125,18
Fokko opened a new pull request #525: Apply Baseline to iceberg-pig
URL: https://github.com/apache/incubator-iceberg/pull/525
Fixes https://github.com/apache/incubator-iceberg/issues/159
This is an automated message from the
rdblue commented on a change in pull request #499: Add persistent IDs to
partition fields (WIP)
URL: https://github.com/apache/incubator-iceberg/pull/499#discussion_r333162767
##
File path: api/src/main/java/org/apache/iceberg/PartitionSpec.java
##
@@ -48,23 +48,24 @@
*
manishmalhotrawork opened a new pull request #524: respect
commit.manifest.min.count
URL: https://github.com/apache/incubator-iceberg/pull/524
related to issue #490
@aokolnychyi can you please review. thanks !
This
aokolnychyi merged pull request #513: Fix concurrency issue in
HiveTableOperations when Table is reused
URL: https://github.com/apache/incubator-iceberg/pull/513
This is an automated message from the Apache Git Service.
To
rdblue commented on issue #513: Fix concurrency issue in HiveTableOperations
when Table is reused
URL: https://github.com/apache/incubator-iceberg/pull/513#issuecomment-540125233
Go for it!
This is an automated message from
rdblue commented on a change in pull request #497: Support retaining last N
snapshots
URL: https://github.com/apache/incubator-iceberg/pull/497#discussion_r333161128
##
File path: core/src/main/java/org/apache/iceberg/RemoveSnapshots.java
##
@@ -77,8 +79,34 @@ public
aokolnychyi commented on issue #513: Fix concurrency issue in
HiveTableOperations when Table is reused
URL: https://github.com/apache/incubator-iceberg/pull/513#issuecomment-540124989
@rdblue, I am going to merge this one if there are no objections.
yathindranath commented on a change in pull request #497: Support retaining
last N snapshots
URL: https://github.com/apache/incubator-iceberg/pull/497#discussion_r333158423
##
File path: core/src/main/java/org/apache/iceberg/RemoveSnapshots.java
##
@@ -77,8 +79,34 @@
rdsr commented on a change in pull request #207: Add external schema mappings
for files written with name-based schemas #40
URL: https://github.com/apache/incubator-iceberg/pull/207#discussion_r333149905
##
File path: core/src/main/java/org/apache/iceberg/avro/PruneColumns.java
rdblue commented on a change in pull request #207: Add external schema mappings
for files written with name-based schemas #40
URL: https://github.com/apache/incubator-iceberg/pull/207#discussion_r333148519
##
File path: core/src/main/java/org/apache/iceberg/avro/PruneColumns.java
rdblue commented on a change in pull request #207: Add external schema mappings
for files written with name-based schemas #40
URL: https://github.com/apache/incubator-iceberg/pull/207#discussion_r333147885
##
File path: core/src/main/java/org/apache/iceberg/avro/PruneColumns.java
rdsr commented on a change in pull request #207: Add external schema mappings
for files written with name-based schemas #40
URL: https://github.com/apache/incubator-iceberg/pull/207#discussion_r333145829
##
File path: core/src/main/java/org/apache/iceberg/avro/PruneColumns.java
rdblue commented on a change in pull request #207: Add external schema mappings
for files written with name-based schemas #40
URL: https://github.com/apache/incubator-iceberg/pull/207#discussion_r333144511
##
File path: core/src/main/java/org/apache/iceberg/avro/PruneColumns.java
rdblue commented on a change in pull request #207: Add external schema mappings
for files written with name-based schemas #40
URL: https://github.com/apache/incubator-iceberg/pull/207#discussion_r333144120
##
File path:
rdblue commented on a change in pull request #207: Add external schema mappings
for files written with name-based schemas #40
URL: https://github.com/apache/incubator-iceberg/pull/207#discussion_r333141603
##
File path: core/src/main/java/org/apache/iceberg/avro/AvroSchemaUtil.java
rdblue commented on a change in pull request #207: Add external schema mappings
for files written with name-based schemas #40
URL: https://github.com/apache/incubator-iceberg/pull/207#discussion_r333140669
##
File path: core/src/main/java/org/apache/iceberg/avro/AvroSchemaUtil.java
rdblue commented on a change in pull request #207: Add external schema mappings
for files written with name-based schemas #40
URL: https://github.com/apache/incubator-iceberg/pull/207#discussion_r333140157
##
File path: core/src/main/java/org/apache/iceberg/avro/AvroSchemaUtil.java
rdblue commented on a change in pull request #207: Add external schema mappings
for files written with name-based schemas #40
URL: https://github.com/apache/incubator-iceberg/pull/207#discussion_r333140039
##
File path: core/src/main/java/org/apache/iceberg/avro/AvroSchemaUtil.java
rdblue commented on a change in pull request #207: Add external schema mappings
for files written with name-based schemas #40
URL: https://github.com/apache/incubator-iceberg/pull/207#discussion_r333139806
##
File path: core/src/main/java/org/apache/iceberg/avro/AvroSchemaUtil.java
rdblue commented on a change in pull request #207: Add external schema mappings
for files written with name-based schemas #40
URL: https://github.com/apache/incubator-iceberg/pull/207#discussion_r333139717
##
File path: core/src/main/java/org/apache/iceberg/avro/AvroSchemaUtil.java
rdblue commented on issue #31: Add startsWith predicate
URL:
https://github.com/apache/incubator-iceberg/issues/31#issuecomment-540083687
I didn't realize that was locked down. Good to know, thanks!
This is an automated
xabriel commented on issue #31: Add startsWith predicate
URL:
https://github.com/apache/incubator-iceberg/issues/31#issuecomment-540079827
I only have comment privileges :)
This is an automated message from the Apache Git
rdblue commented on a change in pull request #512: Extend RewriteManifests with
a way to add/delete manifests
URL: https://github.com/apache/incubator-iceberg/pull/512#discussion_r333109080
##
File path: core/src/main/java/org/apache/iceberg/BaseRewriteManifests.java
##
rdblue merged pull request #511: Expose partition spec info
URL: https://github.com/apache/incubator-iceberg/pull/511
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
rdblue merged pull request #523: Fix typos in documentation.
URL: https://github.com/apache/incubator-iceberg/pull/523
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
rdblue commented on issue #523: Fix typos in documentation.
URL: https://github.com/apache/incubator-iceberg/pull/523#issuecomment-540068617
Looks good to me. Thanks for catching these!
This is an automated message from the
rdblue commented on issue #31: Add startsWith predicate
URL:
https://github.com/apache/incubator-iceberg/issues/31#issuecomment-540067535
Feel free to close issues like this. It's easy to reopen them if we need to.
This is
rdblue closed issue #31: Add startsWith predicate
URL: https://github.com/apache/incubator-iceberg/issues/31
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
prodeezy edited a comment on issue #522: Separate Arrow work into its own
sub-module in Iceberg
URL:
https://github.com/apache/incubator-iceberg/issues/522#issuecomment-539840666
@anjalinorwood isn't this same as
https://github.com/apache/incubator-iceberg/issues/311 ? I can close that
54 matches
Mail list logo
