[GitHub] [lucene-solr] interma opened a new pull request #2289: Title: add timestamp in default gc_log name

2021-02-01 Thread GitBox
interma opened a new pull request #2289: URL: https://github.com/apache/lucene-solr/pull/2289 # Description https://issues.apache.org/jira/browse/SOLR-15104 When restarting Solr, it will overwrite the gc log, this behavior is not friendly for debugging OOM issues.

[GitHub] [lucene-solr] sbeniwal12 commented on a change in pull request #2282: LUCENE-9615: Expose HnswGraphBuilder index-time hyperparameters as FieldType attributes

2021-02-01 Thread GitBox
sbeniwal12 commented on a change in pull request #2282: URL: https://github.com/apache/lucene-solr/pull/2282#discussion_r568327126 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90VectorWriter.java ## @@ -188,9 +190,29 @@ private void writeGraph(

[GitHub] [lucene-solr] zacharymorn commented on pull request #2258: LUCENE-9686: Fix read past EOF handling in DirectIODirectory

2021-02-01 Thread GitBox
zacharymorn commented on pull request #2258: URL: https://github.com/apache/lucene-solr/pull/2258#issuecomment-771322610 > Hi Zach. Sorry for belated reply. Please take a look at my comments attached to the context. I have some doubts whether EOF should leave the channel undrained. Maybe

[GitHub] [lucene-solr] zacharymorn commented on a change in pull request #2258: LUCENE-9686: Fix read past EOF handling in DirectIODirectory

2021-02-01 Thread GitBox
zacharymorn commented on a change in pull request #2258: URL: https://github.com/apache/lucene-solr/pull/2258#discussion_r568294041 ## File path: lucene/misc/src/java/org/apache/lucene/misc/store/DirectIODirectory.java ## @@ -381,17 +377,18 @@ public long length() {

[GitHub] [lucene-solr] zacharymorn commented on a change in pull request #2258: LUCENE-9686: Fix read past EOF handling in DirectIODirectory

2021-02-01 Thread GitBox
zacharymorn commented on a change in pull request #2258: URL: https://github.com/apache/lucene-solr/pull/2258#discussion_r568293170 ## File path: lucene/misc/src/java/org/apache/lucene/misc/store/DirectIODirectory.java ## @@ -381,17 +377,18 @@ public long length() {

[jira] [Commented] (LUCENE-9718) REGEX Pattern Search, character classes with quantifiers do not work

2021-02-01 Thread Michael Sokolov (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17276798#comment-17276798 ] Michael Sokolov commented on LUCENE-9718: - Thanks Brian, contributions in those areas would be

[jira] [Updated] (LUCENE-9718) REGEX Pattern Search, character classes with quantifiers do not work

2021-02-01 Thread Michael Sokolov (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Sokolov updated LUCENE-9718: Issue Type: Improvement (was: Bug) > REGEX Pattern Search, character classes with

[GitHub] [lucene-solr] jaisonbi edited a comment on pull request #2213: LUCENE-9663: Adding compression to terms dict from SortedSet/Sorted DocValues

2021-02-01 Thread GitBox
jaisonbi edited a comment on pull request #2213: URL: https://github.com/apache/lucene-solr/pull/2213#issuecomment-771296030 If I understood correctly, the route via PerFieldDocValuesFormat need to change the usage of SortedSetDocValues. The idea is adding another constructor for

[GitHub] [lucene-solr] jaisonbi commented on pull request #2213: LUCENE-9663: Adding compression to terms dict from SortedSet/Sorted DocValues

2021-02-01 Thread GitBox
jaisonbi commented on pull request #2213: URL: https://github.com/apache/lucene-solr/pull/2213#issuecomment-771296030 If I understood correctly, the route via PerFieldDocValuesFormat need to change the usage of SortedSetDocValues. The idea is adding another constructor for enabling

[jira] [Commented] (SOLR-15124) Remove node/container level admin handlers from ImplicitPlugins.json (core level).

2021-02-01 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17276789#comment-17276789 ] David Smiley commented on SOLR-15124: - {quote}Should we consider setting up redirect paths for the

[jira] [Updated] (LUCENE-9722) Aborted merge can leak readers if the output is empty

2021-02-01 Thread Nhat Nguyen (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nhat Nguyen updated LUCENE-9722: Description: We fail to close the merged readers of an aborted merge if its output segment

[jira] [Updated] (LUCENE-9722) Aborted merge can leak readers if the output is empty

2021-02-01 Thread Nhat Nguyen (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nhat Nguyen updated LUCENE-9722: Status: Patch Available (was: Open) > Aborted merge can leak readers if the output is empty >

[GitHub] [lucene-solr] dnhatn opened a new pull request #2288: LUCENE-9722: Close merged readers on abort

2021-02-01 Thread GitBox
dnhatn opened a new pull request #2288: URL: https://github.com/apache/lucene-solr/pull/2288 We fail to close merged readers if the output segment contains no document. This is an automated message from the Apache Git

[jira] [Created] (LUCENE-9722) Aborted merge can leak readers if the output is empty

2021-02-01 Thread Nhat Nguyen (Jira)
Nhat Nguyen created LUCENE-9722: --- Summary: Aborted merge can leak readers if the output is empty Key: LUCENE-9722 URL: https://issues.apache.org/jira/browse/LUCENE-9722 Project: Lucene - Core

[GitHub] [lucene-solr] zhaih commented on a change in pull request #2213: LUCENE-9663: Adding compression to terms dict from SortedSet/Sorted DocValues

2021-02-01 Thread GitBox
zhaih commented on a change in pull request #2213: URL: https://github.com/apache/lucene-solr/pull/2213#discussion_r568246420 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene80/Lucene80DocValuesConsumer.java ## @@ -736,49 +736,92 @@ private void

[GitHub] [lucene-solr] zhaih commented on pull request #2213: LUCENE-9663: Adding compression to terms dict from SortedSet/Sorted DocValues

2021-02-01 Thread GitBox
zhaih commented on pull request #2213: URL: https://github.com/apache/lucene-solr/pull/2213#issuecomment-771265310 I see, so I think for now I could test it via a customized PerFieldDocValuesFormat, I'll give PerFieldDocValuesFormat route a try then. Tho IMO I would prefer a simpler

[jira] [Commented] (SOLR-14330) Return docs with null value in expand for field when collapse has nullPolicy=collapse

2021-02-01 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17276749#comment-17276749 ] ASF subversion and git services commented on SOLR-14330: Commit

[jira] [Resolved] (SOLR-14330) Return docs with null value in expand for field when collapse has nullPolicy=collapse

2021-02-01 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris M. Hostetter resolved SOLR-14330. --- Fix Version/s: 8.9 master (9.0) Resolution: Fixed > Return

[jira] [Commented] (SOLR-14330) Return docs with null value in expand for field when collapse has nullPolicy=collapse

2021-02-01 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17276725#comment-17276725 ] ASF subversion and git services commented on SOLR-14330: Commit

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #2230: SOLR-15011: /admin/logging handler is configured logs to all nodes

2021-02-01 Thread GitBox
dsmiley commented on a change in pull request #2230: URL: https://github.com/apache/lucene-solr/pull/2230#discussion_r568204361 ## File path: solr/CHANGES.txt ## @@ -69,6 +69,8 @@ Improvements * SOLR-14949: Docker: Ability to customize the FROM image when building.

[jira] [Comment Edited] (LUCENE-9705) Move all codec formats to the o.a.l.codecs.Lucene90 package

2021-02-01 Thread Julie Tibshirani (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17276599#comment-17276599 ] Julie Tibshirani edited comment on LUCENE-9705 at 2/1/21, 11:02 PM:

[jira] [Commented] (SOLR-8393) Component for Solr resource usage planning

2021-02-01 Thread Isabelle Giguere (Jira)
[ https://issues.apache.org/jira/browse/SOLR-8393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17276715#comment-17276715 ] Isabelle Giguere commented on SOLR-8393: New patch, off current master Parameter 'sizeUnit' is

[jira] [Updated] (SOLR-8393) Component for Solr resource usage planning

2021-02-01 Thread Isabelle Giguere (Jira)
[ https://issues.apache.org/jira/browse/SOLR-8393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Isabelle Giguere updated SOLR-8393: --- Attachment: SOLR-8393.patch > Component for Solr resource usage planning >

[GitHub] [lucene-solr] dweiss commented on a change in pull request #2267: LUCENE-9707: Hunspell: check Lucene's implementation against Hunspel's test data

2021-02-01 Thread GitBox
dweiss commented on a change in pull request #2267: URL: https://github.com/apache/lucene-solr/pull/2267#discussion_r568187636 ## File path: lucene/analysis/common/src/test/org/apache/lucene/analysis/hunspell/SpellCheckerTest.java ## @@ -61,59 +61,74 @@ public void

[GitHub] [lucene-solr] dweiss commented on a change in pull request #2267: LUCENE-9707: Hunspell: check Lucene's implementation against Hunspel's test data

2021-02-01 Thread GitBox
dweiss commented on a change in pull request #2267: URL: https://github.com/apache/lucene-solr/pull/2267#discussion_r568186778 ## File path: lucene/analysis/common/src/test/org/apache/lucene/analysis/hunspell/SpellCheckerTest.java ## @@ -61,59 +61,74 @@ public void

[jira] [Updated] (SOLR-15127) All-In-One Dockerfile for building local images as well as reproducible release builds directly from (remote) git tags

2021-02-01 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris M. Hostetter updated SOLR-15127: -- Attachment: SOLR-15127.patch Status: Open (was: Open) The attached patch

[GitHub] [lucene-solr] dweiss commented on a change in pull request #2267: LUCENE-9707: Hunspell: check Lucene's implementation against Hunspel's test data

2021-02-01 Thread GitBox
dweiss commented on a change in pull request #2267: URL: https://github.com/apache/lucene-solr/pull/2267#discussion_r568176360 ## File path: lucene/analysis/common/src/test/org/apache/lucene/analysis/hunspell/TestsFromOriginalHunspellRepository.java ## @@ -0,0 +1,71 @@ +/* +

[jira] [Created] (SOLR-15127) All-In-One Dockerfile for building local images as well as reproducible release builds directly from (remote) git tags

2021-02-01 Thread Chris M. Hostetter (Jira)
Chris M. Hostetter created SOLR-15127: - Summary: All-In-One Dockerfile for building local images as well as reproducible release builds directly from (remote) git tags Key: SOLR-15127 URL:

[GitHub] [lucene-solr] dweiss commented on a change in pull request #2267: LUCENE-9707: Hunspell: check Lucene's implementation against Hunspel's test data

2021-02-01 Thread GitBox
dweiss commented on a change in pull request #2267: URL: https://github.com/apache/lucene-solr/pull/2267#discussion_r568175124 ## File path: lucene/analysis/common/src/test/org/apache/lucene/analysis/hunspell/TestsFromOriginalHunspellRepository.java ## @@ -0,0 +1,71 @@ +/* +

[jira] [Resolved] (SOLR-15125) Link to docs is brroken

2021-02-01 Thread Cassandra Targett (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cassandra Targett resolved SOLR-15125. -- Resolution: Fixed The problem has been fixed and the docs are available again. > Link

[jira] [Commented] (LUCENE-9718) REGEX Pattern Search, character classes with quantifiers do not work

2021-02-01 Thread Brian Feldman (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17276685#comment-17276685 ] Brian Feldman commented on LUCENE-9718: --- 1) User level documentation upstream in Solr or

[GitHub] [lucene-solr-operator] thelabdude commented on a change in pull request #151: Integrate with cert-manager to issue TLS certs for Solr

2021-02-01 Thread GitBox
thelabdude commented on a change in pull request #151: URL: https://github.com/apache/lucene-solr-operator/pull/151#discussion_r568152014 ## File path: main.go ## @@ -65,6 +69,7 @@ func init() { _ = solrv1beta1.AddToScheme(scheme) _ =

[GitHub] [lucene-solr] mrsoong closed pull request #1589: SOLR-13195: added check for missing shards param in SearchHandler

2021-02-01 Thread GitBox
mrsoong closed pull request #1589: URL: https://github.com/apache/lucene-solr/pull/1589 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [lucene-solr] mrsoong closed pull request #1472: SOLR-13184: Added some input validation in ValueSourceParser

2021-02-01 Thread GitBox
mrsoong closed pull request #1472: URL: https://github.com/apache/lucene-solr/pull/1472 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [lucene-solr-operator] HoustonPutman commented on a change in pull request #151: Integrate with cert-manager to issue TLS certs for Solr

2021-02-01 Thread GitBox
HoustonPutman commented on a change in pull request #151: URL: https://github.com/apache/lucene-solr-operator/pull/151#discussion_r568148914 ## File path: main.go ## @@ -65,6 +69,7 @@ func init() { _ = solrv1beta1.AddToScheme(scheme) _ =

[GitHub] [lucene-solr-operator] thelabdude commented on a change in pull request #151: Integrate with cert-manager to issue TLS certs for Solr

2021-02-01 Thread GitBox
thelabdude commented on a change in pull request #151: URL: https://github.com/apache/lucene-solr-operator/pull/151#discussion_r568141856 ## File path: main.go ## @@ -65,6 +69,7 @@ func init() { _ = solrv1beta1.AddToScheme(scheme) _ =

[GitHub] [lucene-solr] dweiss commented on a change in pull request #2258: LUCENE-9686: Fix read past EOF handling in DirectIODirectory

2021-02-01 Thread GitBox
dweiss commented on a change in pull request #2258: URL: https://github.com/apache/lucene-solr/pull/2258#discussion_r568136570 ## File path: lucene/misc/src/java/org/apache/lucene/misc/store/DirectIODirectory.java ## @@ -381,17 +377,18 @@ public long length() { @Override

[jira] [Commented] (SOLR-8319) NPE when creating pivot

2021-02-01 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-8319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17276653#comment-17276653 ] Houston Putman commented on SOLR-8319: -- The query isn't coming from QParser.parse. Instead

[jira] [Commented] (SOLR-13209) NullPointerException from call in org.apache.solr.search.SolrIndexSearcher.getDocSet

2021-02-01 Thread Isabelle Giguere (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17276644#comment-17276644 ] Isabelle Giguere commented on SOLR-13209: - [~cader.hancock] : Nothing to worry about. I get lost

[GitHub] [lucene-solr-operator] thelabdude commented on a change in pull request #151: Integrate with cert-manager to issue TLS certs for Solr

2021-02-01 Thread GitBox
thelabdude commented on a change in pull request #151: URL: https://github.com/apache/lucene-solr-operator/pull/151#discussion_r568133031 ## File path: controllers/solrcloud_controller.go ## @@ -772,3 +848,188 @@ func (r *SolrCloudReconciler)

[GitHub] [lucene-solr-operator] thelabdude commented on a change in pull request #151: Integrate with cert-manager to issue TLS certs for Solr

2021-02-01 Thread GitBox
thelabdude commented on a change in pull request #151: URL: https://github.com/apache/lucene-solr-operator/pull/151#discussion_r568132449 ## File path: controllers/solrcloud_controller.go ## @@ -772,3 +848,188 @@ func (r *SolrCloudReconciler)

[GitHub] [lucene-solr-operator] thelabdude commented on a change in pull request #151: Integrate with cert-manager to issue TLS certs for Solr

2021-02-01 Thread GitBox
thelabdude commented on a change in pull request #151: URL: https://github.com/apache/lucene-solr-operator/pull/151#discussion_r568131545 ## File path: controllers/util/common.go ## @@ -248,6 +248,11 @@ func CopyIngressFields(from, to *extv1.Ingress, logger logr.Logger) bool

[GitHub] [lucene-solr-operator] HoustonPutman commented on a change in pull request #151: Integrate with cert-manager to issue TLS certs for Solr

2021-02-01 Thread GitBox
HoustonPutman commented on a change in pull request #151: URL: https://github.com/apache/lucene-solr-operator/pull/151#discussion_r568129098 ## File path: main.go ## @@ -65,6 +69,7 @@ func init() { _ = solrv1beta1.AddToScheme(scheme) _ =

[GitHub] [lucene-solr-operator] thelabdude commented on a change in pull request #151: Integrate with cert-manager to issue TLS certs for Solr

2021-02-01 Thread GitBox
thelabdude commented on a change in pull request #151: URL: https://github.com/apache/lucene-solr-operator/pull/151#discussion_r568127921 ## File path: main.go ## @@ -65,6 +69,7 @@ func init() { _ = solrv1beta1.AddToScheme(scheme) _ =

[jira] [Comment Edited] (LUCENE-9705) Move all codec formats to the o.a.l.codecs.Lucene90 package

2021-02-01 Thread Julie Tibshirani (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17276599#comment-17276599 ] Julie Tibshirani edited comment on LUCENE-9705 at 2/1/21, 8:44 PM: ---

[GitHub] [lucene-solr-operator] thelabdude commented on a change in pull request #151: Integrate with cert-manager to issue TLS certs for Solr

2021-02-01 Thread GitBox
thelabdude commented on a change in pull request #151: URL: https://github.com/apache/lucene-solr-operator/pull/151#discussion_r568114059 ## File path: controllers/solrcloud_controller.go ## @@ -261,12 +268,77 @@ func (r *SolrCloudReconciler) Reconcile(req ctrl.Request)

[GitHub] [lucene-solr] msokolov commented on a change in pull request #2256: LUCENE-9507 Custom order for leaves in IndexReader and IndexWriter

2021-02-01 Thread GitBox
msokolov commented on a change in pull request #2256: URL: https://github.com/apache/lucene-solr/pull/2256#discussion_r568113101 ## File path: lucene/core/src/java/org/apache/lucene/index/IndexWriter.java ## @@ -941,6 +969,11 @@ public IndexWriter(Directory d,

[GitHub] [lucene-solr] msokolov commented on a change in pull request #2256: LUCENE-9507 Custom order for leaves in IndexReader and IndexWriter

2021-02-01 Thread GitBox
msokolov commented on a change in pull request #2256: URL: https://github.com/apache/lucene-solr/pull/2256#discussion_r568110673 ## File path: lucene/core/src/java/org/apache/lucene/index/IndexWriter.java ## @@ -941,6 +969,11 @@ public IndexWriter(Directory d,

[GitHub] [lucene-solr] msokolov commented on a change in pull request #2231: LUCENE-9680 - Re-add IndexWriter::getFieldNames

2021-02-01 Thread GitBox
msokolov commented on a change in pull request #2231: URL: https://github.com/apache/lucene-solr/pull/2231#discussion_r568105107 ## File path: lucene/core/src/test/org/apache/lucene/index/TestIndexWriter.java ## @@ -4600,4 +4600,49 @@ public void testIndexWriterBlocksOnStall()

[jira] [Commented] (LUCENE-9718) REGEX Pattern Search, character classes with quantifiers do not work

2021-02-01 Thread Michael Sokolov (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17276618#comment-17276618 ] Michael Sokolov commented on LUCENE-9718: - I guess we come to expect PCRE in every

[GitHub] [lucene-solr] mayya-sharipova commented on a change in pull request #2256: LUCENE-9507 Custom order for leaves in IndexReader and IndexWriter

2021-02-01 Thread GitBox
mayya-sharipova commented on a change in pull request #2256: URL: https://github.com/apache/lucene-solr/pull/2256#discussion_r568095366 ## File path: lucene/core/src/java/org/apache/lucene/index/IndexWriter.java ## @@ -933,6 +936,31 @@ protected final void ensureOpen() throws

[GitHub] [lucene-solr] mayya-sharipova commented on a change in pull request #2256: LUCENE-9507 Custom order for leaves in IndexReader and IndexWriter

2021-02-01 Thread GitBox
mayya-sharipova commented on a change in pull request #2256: URL: https://github.com/apache/lucene-solr/pull/2256#discussion_r568095174 ## File path: lucene/core/src/java/org/apache/lucene/index/IndexWriter.java ## @@ -941,6 +969,11 @@ public IndexWriter(Directory d,

[GitHub] [lucene-solr] epugh commented on a change in pull request #2275: SOLR-15123: Make all Tool option descriptions follow the same general pattern.

2021-02-01 Thread GitBox
epugh commented on a change in pull request #2275: URL: https://github.com/apache/lucene-solr/pull/2275#discussion_r568092337 ## File path: solr/core/src/java/org/apache/solr/util/ExportTool.java ## @@ -216,32 +216,32 @@ void end() throws IOException {

[jira] [Comment Edited] (LUCENE-9705) Move all codec formats to the o.a.l.codecs.Lucene90 package

2021-02-01 Thread Julie Tibshirani (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17276599#comment-17276599 ] Julie Tibshirani edited comment on LUCENE-9705 at 2/1/21, 7:44 PM: ---

[GitHub] [lucene-solr] epugh commented on a change in pull request #2275: SOLR-15123: Make all Tool option descriptions follow the same general pattern.

2021-02-01 Thread GitBox
epugh commented on a change in pull request #2275: URL: https://github.com/apache/lucene-solr/pull/2275#discussion_r568092337 ## File path: solr/core/src/java/org/apache/solr/util/ExportTool.java ## @@ -216,32 +216,32 @@ void end() throws IOException {

[GitHub] [lucene-solr] epugh commented on a change in pull request #2275: SOLR-15123: Make all Tool option descriptions follow the same general pattern.

2021-02-01 Thread GitBox
epugh commented on a change in pull request #2275: URL: https://github.com/apache/lucene-solr/pull/2275#discussion_r568090848 ## File path: solr/core/src/java/org/apache/solr/util/SolrCLI.java ## @@ -1795,25 +1795,25 @@ public ConfigSetUploadTool(PrintStream stdout) {

[GitHub] [lucene-solr] jtibshirani opened a new pull request #2287: Remove write logic from Lucene70NormsFormat.

2021-02-01 Thread GitBox
jtibshirani opened a new pull request #2287: URL: https://github.com/apache/lucene-solr/pull/2287 Our policy is to not maintain write logic for old formats that can't be written to. The write logic is moved to the test folder to support unit testing.

[jira] [Comment Edited] (LUCENE-9705) Move all codec formats to the o.a.l.codecs.Lucene90 package

2021-02-01 Thread Julie Tibshirani (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17276599#comment-17276599 ] Julie Tibshirani edited comment on LUCENE-9705 at 2/1/21, 7:37 PM: ---

[GitHub] [lucene-solr] epugh commented on a change in pull request #2275: SOLR-15123: Make all Tool option descriptions follow the same general pattern.

2021-02-01 Thread GitBox
epugh commented on a change in pull request #2275: URL: https://github.com/apache/lucene-solr/pull/2275#discussion_r568087950 ## File path: solr/core/src/java/org/apache/solr/util/PackageTool.java ## @@ -261,44 +261,44 @@ protected void runImpl(CommandLine cli) throws

[jira] [Commented] (LUCENE-9705) Move all codec formats to the o.a.l.codecs.Lucene90 package

2021-02-01 Thread Julie Tibshirani (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17276599#comment-17276599 ] Julie Tibshirani commented on LUCENE-9705: -- {quote}It's especially clear here where we must

[GitHub] [lucene-solr] epugh commented on a change in pull request #2275: SOLR-15123: Make all Tool option descriptions follow the same general pattern.

2021-02-01 Thread GitBox
epugh commented on a change in pull request #2275: URL: https://github.com/apache/lucene-solr/pull/2275#discussion_r568087125 ## File path: solr/core/src/java/org/apache/solr/util/ExportTool.java ## @@ -216,32 +216,32 @@ void end() throws IOException {

[GitHub] [lucene-solr] madrob commented on a change in pull request #2284: SOLR-11233: Add optional JAVA8_GC_LOG_FILE_OPTS for bin/solr.

2021-02-01 Thread GitBox
madrob commented on a change in pull request #2284: URL: https://github.com/apache/lucene-solr/pull/2284#discussion_r568085426 ## File path: solr/bin/solr ## @@ -2026,7 +2026,11 @@ if [ "$GC_LOG_OPTS" != "" ]; then if [ "$JAVA_VENDOR" == "IBM J9" ]; then

[jira] [Resolved] (SOLR-14253) Remove Sleeps from OverseerCollectionMessageHandler

2021-02-01 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob resolved SOLR-14253. -- Fix Version/s: master (9.0) Assignee: Mike Drob Resolution: Fixed > Remove Sleeps from

[jira] [Commented] (SOLR-14253) Remove Sleeps from OverseerCollectionMessageHandler

2021-02-01 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17276594#comment-17276594 ] ASF subversion and git services commented on SOLR-14253: Commit

[GitHub] [lucene-solr] madrob merged pull request #1297: SOLR-14253 Replace various sleep calls with ZK waits

2021-02-01 Thread GitBox
madrob merged pull request #1297: URL: https://github.com/apache/lucene-solr/pull/1297 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [lucene-solr] msokolov commented on a change in pull request #2282: LUCENE-9615: Expose HnswGraphBuilder index-time hyperparameters as FieldType attributes

2021-02-01 Thread GitBox
msokolov commented on a change in pull request #2282: URL: https://github.com/apache/lucene-solr/pull/2282#discussion_r568075607 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90VectorWriter.java ## @@ -188,9 +190,29 @@ private void writeGraph(

[GitHub] [lucene-solr] muse-dev[bot] commented on a change in pull request #2285: SOLR-14928: introduce distributed cluster state updates

2021-02-01 Thread GitBox
muse-dev[bot] commented on a change in pull request #2285: URL: https://github.com/apache/lucene-solr/pull/2285#discussion_r568077584 ## File path: solr/core/src/java/org/apache/solr/cloud/Overseer.java ## @@ -1058,10 +1056,29 @@ public ZkStateReader getZkStateReader() { }

[GitHub] [lucene-solr-operator] HoustonPutman commented on a change in pull request #151: Integrate with cert-manager to issue TLS certs for Solr

2021-02-01 Thread GitBox
HoustonPutman commented on a change in pull request #151: URL: https://github.com/apache/lucene-solr-operator/pull/151#discussion_r568020961 ## File path: api/v1beta1/solrcloud_types.go ## @@ -758,8 +770,12 @@ func (sc *SolrCloud) CommonServiceName() string { } //

[jira] [Created] (LUCENE-9721) Hunspell: disallow ONLYINCOMPOUND suffixes at the very end of compound words

2021-02-01 Thread Peter Gromov (Jira)
Peter Gromov created LUCENE-9721: Summary: Hunspell: disallow ONLYINCOMPOUND suffixes at the very end of compound words Key: LUCENE-9721 URL: https://issues.apache.org/jira/browse/LUCENE-9721

[GitHub] [lucene-solr] donnerpeter opened a new pull request #2286: LUCENE-9720: Hunspell: more ways to vary misspelled word variations f…

2021-02-01 Thread GitBox
donnerpeter opened a new pull request #2286: URL: https://github.com/apache/lucene-solr/pull/2286 …or suggestions # Description Work on Hunspell suggestions in progress. # Solution Reimplement most of Hunspell's `suggest` logic, without ngrams so far.

[jira] [Created] (LUCENE-9720) Hunspell: more ways to vary misspelled word variations for suggestions

2021-02-01 Thread Peter Gromov (Jira)
Peter Gromov created LUCENE-9720: Summary: Hunspell: more ways to vary misspelled word variations for suggestions Key: LUCENE-9720 URL: https://issues.apache.org/jira/browse/LUCENE-9720 Project:

[GitHub] [lucene-solr] NazerkeBS commented on a change in pull request #2230: SOLR-15011: /admin/logging handler is configured logs to all nodes

2021-02-01 Thread GitBox
NazerkeBS commented on a change in pull request #2230: URL: https://github.com/apache/lucene-solr/pull/2230#discussion_r568061888 ## File path: solr/webapp/web/js/angular/services.js ## @@ -58,10 +58,10 @@ solrAdminServices.factory('System', }]) .factory('Logging',

[GitHub] [lucene-solr] msokolov commented on a change in pull request #2256: LUCENE-9507 Custom order for leaves in IndexReader and IndexWriter

2021-02-01 Thread GitBox
msokolov commented on a change in pull request #2256: URL: https://github.com/apache/lucene-solr/pull/2256#discussion_r568058172 ## File path: lucene/core/src/java/org/apache/lucene/index/IndexWriter.java ## @@ -941,6 +969,11 @@ public IndexWriter(Directory d,

[jira] [Commented] (LUCENE-9705) Move all codec formats to the o.a.l.codecs.Lucene90 package

2021-02-01 Thread Michael Sokolov (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17276575#comment-17276575 ] Michael Sokolov commented on LUCENE-9705: - Just throwing this out there; I have no real

[jira] [Resolved] (SOLR-15115) Remove unused methods from TestRerankBase

2021-02-01 Thread Christine Poerschke (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christine Poerschke resolved SOLR-15115. Fix Version/s: 8.9 master (9.0) Resolution: Fixed Thanks

[jira] [Commented] (SOLR-15115) Remove unused methods from TestRerankBase

2021-02-01 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17276565#comment-17276565 ] ASF subversion and git services commented on SOLR-15115: Commit

[jira] [Commented] (SOLR-14920) Format code automatically and enforce it in Solr

2021-02-01 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17276559#comment-17276559 ] Jason Gerlowski commented on SOLR-14920: bq. I'm reluctant to do this to the Solr code base until

[GitHub] [lucene-solr] gus-asf commented on pull request #2185: LUCENE-9659 inequality support in payload check query

2021-02-01 Thread GitBox
gus-asf commented on pull request #2185: URL: https://github.com/apache/lucene-solr/pull/2185#issuecomment-771044438 > BTW I saw your relationship Gus but sometimes I enjoy reviewing some code too :-). :) always very welcome of course. I'm slightly irritated with myself for not

[jira] [Commented] (SOLR-15125) Link to docs is brroken

2021-02-01 Thread Gus Heck (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17276537#comment-17276537 ] Gus Heck commented on SOLR-15125: - There has been some difficulty with deploying the docs for the recent

[GitHub] [lucene-solr] jpountz commented on pull request #2186: LUCENE-9334 Consistency of field data structures

2021-02-01 Thread GitBox
jpountz commented on pull request #2186: URL: https://github.com/apache/lucene-solr/pull/2186#issuecomment-771029358 @mayya-sharipova Yes, if the field has been added previously without doc values, then it should be illegal to add it later with doc values indeed.

[GitHub] [lucene-solr] murblanc opened a new pull request #2285: SOLR-14928: introduce distributed cluster state updates

2021-02-01 Thread GitBox
murblanc opened a new pull request #2285: URL: https://github.com/apache/lucene-solr/pull/2285 SOLR-14928: introduce distributed cluster state updates (i.e. not having to go through a ZK queue and Overseer) The motivation behind this PR is to simplify SolrCloud and be the first step

[jira] [Commented] (SOLR-15115) Remove unused methods from TestRerankBase

2021-02-01 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17276516#comment-17276516 ] ASF subversion and git services commented on SOLR-15115: Commit

[jira] [Assigned] (SOLR-15115) Remove unused methods from TestRerankBase

2021-02-01 Thread Christine Poerschke (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christine Poerschke reassigned SOLR-15115: -- Assignee: Christine Poerschke > Remove unused methods from TestRerankBase >

[GitHub] [lucene-solr] cpoerschke merged pull request #2261: SOLR-15115: Remove unused methods from TestRerankBase

2021-02-01 Thread GitBox
cpoerschke merged pull request #2261: URL: https://github.com/apache/lucene-solr/pull/2261 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [lucene-solr] janhoy commented on a change in pull request #2230: SOLR-15011: /admin/logging handler is configured logs to all nodes

2021-02-01 Thread GitBox
janhoy commented on a change in pull request #2230: URL: https://github.com/apache/lucene-solr/pull/2230#discussion_r568007698 ## File path: solr/webapp/web/js/angular/services.js ## @@ -58,10 +58,10 @@ solrAdminServices.factory('System', }]) .factory('Logging',

[jira] [Commented] (SOLR-11233) GC_LOG_OPTS customisation is a little confusing

2021-02-01 Thread Christine Poerschke (Jira)
[ https://issues.apache.org/jira/browse/SOLR-11233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17276513#comment-17276513 ] Christine Poerschke commented on SOLR-11233: {quote}... a new {{GC_LOG_FILE_OPTS}} option ...

[GitHub] [lucene-solr] cpoerschke opened a new pull request #2284: SOLR-11233: Add optional JAVA8_GC_LOG_FILE_OPTS for bin/solr.

2021-02-01 Thread GitBox
cpoerschke opened a new pull request #2284: URL: https://github.com/apache/lucene-solr/pull/2284 https://issues.apache.org/jira/browse/SOLR-11233 * {{bin/solr}} change -- ready for review * {{bin/solr.cmd}} change -- to do (help needed) Since `master` branch does not

[GitHub] [lucene-solr] mayya-sharipova commented on a change in pull request #2256: LUCENE-9507 Custom order for leaves in IndexReader and IndexWriter

2021-02-01 Thread GitBox
mayya-sharipova commented on a change in pull request #2256: URL: https://github.com/apache/lucene-solr/pull/2256#discussion_r567994551 ## File path: lucene/core/src/java/org/apache/lucene/index/IndexWriter.java ## @@ -933,6 +936,31 @@ protected final void ensureOpen() throws

[GitHub] [lucene-solr] mayya-sharipova commented on a change in pull request #2256: LUCENE-9507 Custom order for leaves in IndexReader and IndexWriter

2021-02-01 Thread GitBox
mayya-sharipova commented on a change in pull request #2256: URL: https://github.com/apache/lucene-solr/pull/2256#discussion_r567994353 ## File path: lucene/core/src/java/org/apache/lucene/index/IndexWriter.java ## @@ -941,6 +969,11 @@ public IndexWriter(Directory d,

[GitHub] [lucene-solr] donnerpeter opened a new pull request #2283: LUCENE-9719: Resource files aren't deleted from build directory after…

2021-02-01 Thread GitBox
donnerpeter opened a new pull request #2283: URL: https://github.com/apache/lucene-solr/pull/2283 … being deleted in source # Description e.g. *.sug files used in Hunspell # Solution Make Gradle `Sync` them instead of `Copy` # Tests No

[jira] [Created] (LUCENE-9719) Resource files aren't deleted from build directory after being deleted in source

2021-02-01 Thread Peter Gromov (Jira)
Peter Gromov created LUCENE-9719: Summary: Resource files aren't deleted from build directory after being deleted in source Key: LUCENE-9719 URL: https://issues.apache.org/jira/browse/LUCENE-9719

[GitHub] [lucene-solr] ctargett commented on a change in pull request #2275: SOLR-15123: Make all Tool option descriptions follow the same general pattern.

2021-02-01 Thread GitBox
ctargett commented on a change in pull request #2275: URL: https://github.com/apache/lucene-solr/pull/2275#discussion_r567970635 ## File path: solr/core/src/java/org/apache/solr/util/SolrCLI.java ## @@ -1795,25 +1795,25 @@ public ConfigSetUploadTool(PrintStream stdout) {

[GitHub] [lucene-solr] ctargett commented on a change in pull request #2275: SOLR-15123: Make all Tool option descriptions follow the same general pattern.

2021-02-01 Thread GitBox
ctargett commented on a change in pull request #2275: URL: https://github.com/apache/lucene-solr/pull/2275#discussion_r567970635 ## File path: solr/core/src/java/org/apache/solr/util/SolrCLI.java ## @@ -1795,25 +1795,25 @@ public ConfigSetUploadTool(PrintStream stdout) {

[GitHub] [lucene-solr] ctargett commented on a change in pull request #2275: SOLR-15123: Make all Tool option descriptions follow the same general pattern.

2021-02-01 Thread GitBox
ctargett commented on a change in pull request #2275: URL: https://github.com/apache/lucene-solr/pull/2275#discussion_r567970209 ## File path: solr/core/src/java/org/apache/solr/util/SolrCLI.java ## @@ -1311,13 +1311,13 @@ protected void runCloudTool(CloudSolrClient

[GitHub] [lucene-solr] ctargett commented on a change in pull request #2275: SOLR-15123: Make all Tool option descriptions follow the same general pattern.

2021-02-01 Thread GitBox
ctargett commented on a change in pull request #2275: URL: https://github.com/apache/lucene-solr/pull/2275#discussion_r567969883 ## File path: solr/core/src/java/org/apache/solr/util/SolrCLI.java ## @@ -236,13 +236,13 @@ protected abstract void runCloudTool(CloudSolrClient

[jira] [Resolved] (SOLR-15126) gc log file rotation broken (when using Java8)

2021-02-01 Thread Christine Poerschke (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christine Poerschke resolved SOLR-15126. Resolution: Cannot Reproduce Never mind, apologies for the noise, I must have

[GitHub] [lucene-solr] madrob commented on a change in pull request #2275: SOLR-15123: Make all Tool option descriptions follow the same general pattern.

2021-02-01 Thread GitBox
madrob commented on a change in pull request #2275: URL: https://github.com/apache/lucene-solr/pull/2275#discussion_r567953137 ## File path: solr/core/src/java/org/apache/solr/util/ExportTool.java ## @@ -216,32 +216,32 @@ void end() throws IOException {

[jira] [Commented] (SOLR-15124) Remove node/container level admin handlers from ImplicitPlugins.json (core level).

2021-02-01 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17276436#comment-17276436 ] Mike Drob commented on SOLR-15124: -- Should we consider setting up redirect paths for the old handlers?

[GitHub] [lucene-solr] madrob commented on a change in pull request #2265: SOLR-15119 Add logs and make default splitMethod to be LINK

2021-02-01 Thread GitBox
madrob commented on a change in pull request #2265: URL: https://github.com/apache/lucene-solr/pull/2265#discussion_r567947008 ## File path: solr/core/src/java/org/apache/solr/cloud/api/collections/SplitShardCmd.java ## @@ -580,6 +597,10 @@ public boolean split(ClusterState

[jira] [Created] (SOLR-15126) gc log file rotation broken (when using Java8)

2021-02-01 Thread Christine Poerschke (Jira)
Christine Poerschke created SOLR-15126: -- Summary: gc log file rotation broken (when using Java8) Key: SOLR-15126 URL: https://issues.apache.org/jira/browse/SOLR-15126 Project: Solr

  1   2   >