[GitHub] markusthoemmes opened a new pull request #3359: Change all empty collection creations to an explicit call to `empty`.

markusthoemmes opened a new pull request #3359: Change all empty collection creations to an explicit call to `empty`. URL: https://github.com/apache/incubator-openwhisk/pull/3359 `Collection.empty` is optimized for less allocations, less work in general and more clear to read.

[GitHub] jonpspri opened a new pull request #3360: Set mode of wsk to executable

jonpspri opened a new pull request #3360: Set mode of wsk to executable URL: https://github.com/apache/incubator-openwhisk/pull/3360 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] chetanmeh commented on issue #3356: Add method to delete attachment to ArtifactStore

chetanmeh commented on issue #3356: Add method to delete attachment to ArtifactStore URL: https://github.com/apache/incubator-openwhisk/issues/3356#issuecomment-368923722 Currently when any entity is deleted we do not have entity instance. So this would make it tricky to implement

[GitHub] houshengbo opened a new pull request #50: Add the license header to all the source code files

houshengbo opened a new pull request #50: Add the license header to all the source code files URL: https://github.com/apache/incubator-openwhisk-release/pull/50 This is an automated message from the Apache Git Service. To

[GitHub] tysonnorris commented on a change in pull request #3211: implement ContainerFactory.cpuShare to fix #3110

tysonnorris commented on a change in pull request #3211: implement ContainerFactory.cpuShare to fix #3110 URL: https://github.com/apache/incubator-openwhisk/pull/3211#discussion_r170998685 ## File path:

[GitHub] tysonnorris commented on a change in pull request #154: container network/dns converted to PureConfig

tysonnorris commented on a change in pull request #154: container network/dns converted to PureConfig URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/154#discussion_r171003517 ## File path: kubernetes/invoker/invoker.yml ## @@ -93,12 +93,12 @@ spec:

[GitHub] csantanapr closed pull request #11: Switch to Maven based dependency

csantanapr closed pull request #11: Switch to Maven based dependency URL: https://github.com/apache/incubator-openwhisk-runtime-java/pull/11 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[GitHub] jonpspri commented on issue #3133: Subtle changes to support S390X deployment of OpenWhisk

jonpspri commented on issue #3133: Subtle changes to support S390X deployment of OpenWhisk URL: https://github.com/apache/incubator-openwhisk/pull/3133#issuecomment-368919819 I moved the changes to tools/ubuntu-setup into #3358

[GitHub] kameshsampath opened a new pull request #19: [WIP] Java Improvements

kameshsampath opened a new pull request #19: [WIP] Java Improvements URL: https://github.com/apache/incubator-openwhisk-runtime-java/pull/19 WIP - rebased docker image Signed-off-by: Kamesh Sampath

[GitHub] chetanmeh commented on issue #3356: Add method to delete attachment to ArtifactStore

chetanmeh commented on issue #3356: Add method to delete attachment to ArtifactStore URL: https://github.com/apache/incubator-openwhisk/issues/3356#issuecomment-368923722 Currently when any entity is deleted we do not have entity instance. So this would make it tricky to implement

[GitHub] kameshsampath closed pull request #19: [WIP] Java Improvements

kameshsampath closed pull request #19: [WIP] Java Improvements URL: https://github.com/apache/incubator-openwhisk-runtime-java/pull/19 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] tysonnorris commented on a change in pull request #3211: implement ContainerFactory.cpuShare to fix #3110

tysonnorris commented on a change in pull request #3211: implement ContainerFactory.cpuShare to fix #3110 URL: https://github.com/apache/incubator-openwhisk/pull/3211#discussion_r170996623 ## File path:

[GitHub] markusthoemmes opened a new pull request #3362: Make ActivationId implementation leaner.

markusthoemmes opened a new pull request #3362: Make ActivationId implementation leaner. URL: https://github.com/apache/incubator-openwhisk/pull/3362 ActivationId is today essentially a wrapper around `UUID`. This is not necessary though. Subsequent operations (serdes for instance) are

[GitHub] mrutkows commented on issue #758: Deprecate interactive mode in wskdeploy

mrutkows commented on issue #758: Deprecate interactive mode in wskdeploy URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/758#issuecomment-368945574 @pritidesai we will preserve the interactive flag as a means to stop/verify assets before deployment

[GitHub] csantanapr commented on a change in pull request #3358: Update to tools/ubuntu-setup to support xenial and later Ubuntu releases

csantanapr commented on a change in pull request #3358: Update to tools/ubuntu-setup to support xenial and later Ubuntu releases URL: https://github.com/apache/incubator-openwhisk/pull/3358#discussion_r171008630 ## File path: tools/ubuntu-setup/all.sh ## @@ -10,15 +18,35

[GitHub] rabbah closed pull request #3215: adding namePrefix config to ContainerArgsConfig

rabbah closed pull request #3215: adding namePrefix config to ContainerArgsConfig URL: https://github.com/apache/incubator-openwhisk/pull/3215 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] rabbah commented on issue #3215: adding namePrefix config to ContainerArgsConfig

rabbah commented on issue #3215: adding namePrefix config to ContainerArgsConfig URL: https://github.com/apache/incubator-openwhisk/pull/3215#issuecomment-368943549 @markusthoemmes I'm going to merge this first - you'll need to update your pr.

[GitHub] vvraskin opened a new pull request #3361: Monitor kafka queue for all consumers

vvraskin opened a new pull request #3361: Monitor kafka queue for all consumers URL: https://github.com/apache/incubator-openwhisk/pull/3361 Use internal kafka consumer metrics to monitor kafka queue for a particular topic. @markusthoemmes

[GitHub] rabbah commented on a change in pull request #3357: Remove usages of replace and replaceAll on the hotpath.

rabbah commented on a change in pull request #3357: Remove usages of replace and replaceAll on the hotpath. URL: https://github.com/apache/incubator-openwhisk/pull/3357#discussion_r170959370 ## File path: common/scala/src/main/scala/whisk/core/entity/ActivationId.scala ##

[GitHub] mrutkows commented on issue #758: Deprecate interactive mode in wskdeploy

mrutkows commented on issue #758: Deprecate interactive mode in wskdeploy URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/758#issuecomment-368943641 @csantanapr already gutted 90% of this... the only part left is "report" which we plan to perhaps preserve as part of a

[GitHub] tysonnorris commented on a change in pull request #3211: implement ContainerFactory.cpuShare to fix #3110

tysonnorris commented on a change in pull request #3211: implement ContainerFactory.cpuShare to fix #3110 URL: https://github.com/apache/incubator-openwhisk/pull/3211#discussion_r170996623 ## File path:

[GitHub] markusthoemmes closed pull request #3347: Generic Pooling REST Client

markusthoemmes closed pull request #3347: Generic Pooling REST Client URL: https://github.com/apache/incubator-openwhisk/pull/3347 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] bwmcadams commented on a change in pull request #3338: implement suspend/resume for KubernetesContainer

bwmcadams commented on a change in pull request #3338: implement suspend/resume for KubernetesContainer URL: https://github.com/apache/incubator-openwhisk/pull/3338#discussion_r171044427 ## File path:

[GitHub] bwmcadams commented on a change in pull request #3338: implement suspend/resume for KubernetesContainer

bwmcadams commented on a change in pull request #3338: implement suspend/resume for KubernetesContainer URL: https://github.com/apache/incubator-openwhisk/pull/3338#discussion_r171043184 ## File path:

[GitHub] mdeuser opened a new pull request #3364: Add retries to some entity "update" tests

mdeuser opened a new pull request #3364: Add retries to some entity "update" tests URL: https://github.com/apache/incubator-openwhisk/pull/3364 Fix for the following kind of automated test failure recently observed ``` system.basic.WskBasicTests > Wsk Package REST should create,

[GitHub] csantanapr commented on issue #3335: Allow container tests to run without a proxy.

csantanapr commented on issue #3335: Allow container tests to run without a proxy. URL: https://github.com/apache/incubator-openwhisk/pull/3335#issuecomment-369027354 _?que Dios nos coja confesados!_ merging... This is an

[GitHub] csantanapr closed pull request #3335: Allow container tests to run without a proxy.

csantanapr closed pull request #3335: Allow container tests to run without a proxy. URL: https://github.com/apache/incubator-openwhisk/pull/3335 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] csantanapr commented on issue #3335: Allow container tests to run without a proxy.

csantanapr commented on issue #3335: Allow container tests to run without a proxy. URL: https://github.com/apache/incubator-openwhisk/pull/3335#issuecomment-369027354 _?que Dios nos coja confesados!_ merging... ? This is

[GitHub] csantanapr commented on a change in pull request #3358: Update to tools/ubuntu-setup to support xenial and later Ubuntu releases

csantanapr commented on a change in pull request #3358: Update to tools/ubuntu-setup to support xenial and later Ubuntu releases URL: https://github.com/apache/incubator-openwhisk/pull/3358#discussion_r171020137 ## File path: tools/ubuntu-setup/all.sh ## @@ -10,15 +18,35

[GitHub] mdeuser commented on issue #3364: Add retries to some entity "update" tests

mdeuser commented on issue #3364: Add retries to some entity "update" tests URL: https://github.com/apache/incubator-openwhisk/pull/3364#issuecomment-369017803 @markusthoemmes - here's the update per our discussion. would you mind reviewing when you have the chance. thanks!

[GitHub] jonpspri commented on issue #3358: Update to tools/ubuntu-setup to support xenial and later Ubuntu releases

jonpspri commented on issue #3358: Update to tools/ubuntu-setup to support xenial and later Ubuntu releases URL: https://github.com/apache/incubator-openwhisk/pull/3358#issuecomment-369020284 @csantanapr Please look at latest. OpenJDK 8 seems to be installing for everything now.

[GitHub] jonpspri opened a new pull request #3363: Ansible image name overrides and bump NGinx to 1.13.9

jonpspri opened a new pull request #3363: Ansible image name overrides and bump NGinx to 1.13.9 URL: https://github.com/apache/incubator-openwhisk/pull/3363 Add the ability to override image names to the ansible playbooks. Bump Nginx version to 1.13.9 Move responsiblity for

[GitHub] dgrove-oss commented on a change in pull request #3211: implement ContainerFactory.cpuShare to fix #3110

dgrove-oss commented on a change in pull request #3211: implement ContainerFactory.cpuShare to fix #3110 URL: https://github.com/apache/incubator-openwhisk/pull/3211#discussion_r171016731 ## File path:

[GitHub] jonpspri commented on a change in pull request #3358: Update to tools/ubuntu-setup to support xenial and later Ubuntu releases

jonpspri commented on a change in pull request #3358: Update to tools/ubuntu-setup to support xenial and later Ubuntu releases URL: https://github.com/apache/incubator-openwhisk/pull/3358#discussion_r171019319 ## File path: tools/ubuntu-setup/all.sh ## @@ -10,15 +18,35

[GitHub] dubeejw commented on issue #3347: Generic Pooling REST Client

dubeejw commented on issue #3347: Generic Pooling REST Client URL: https://github.com/apache/incubator-openwhisk/pull/3347#issuecomment-368986256 PG3 1925 ? This is an automated message from the Apache Git Service. To

[GitHub] markusthoemmes commented on issue #3357: Remove usages of replace and replaceAll on the hotpath.

markusthoemmes commented on issue #3357: Remove usages of replace and replaceAll on the hotpath. URL: https://github.com/apache/incubator-openwhisk/pull/3357#issuecomment-369007580 @rabbah updated to only contain removal of `replaceAll` in container naming. Not as pressing but still good

[GitHub] kameshsampath commented on issue #233: Making entrypoint optional for Java Actions

kameshsampath commented on issue #233: Making entrypoint optional for Java Actions URL: https://github.com/apache/incubator-openwhisk-cli/issues/233#issuecomment-368986442 @csantanapr am not sure we can add this issue to java-runtime improvements epic

[GitHub] jthomas commented on issue #100: Add prefix to PROJECT_HOME and CATALOG_HOME

jthomas commented on issue #100: Add prefix to PROJECT_HOME and CATALOG_HOME URL: https://github.com/apache/incubator-openwhisk-devtools/pull/100#issuecomment-368994836 @akrabat Can you update the docs with new var?

[GitHub] pritidesai closed issue #708: redeploy manifest with rule leaves as disables

pritidesai closed issue #708: redeploy manifest with rule leaves as disables URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/708 This is an automated message from the Apache Git Service. To respond to the

[GitHub] pritidesai commented on issue #708: redeploy manifest with rule leaves as disables

pritidesai commented on issue #708: redeploy manifest with rule leaves as disables URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/708#issuecomment-368998586 Just tested against IBM Cloud Functions, this issue has been fixed with:

[GitHub] pritidesai commented on issue #718: Go fmt - please produce the corrupted list of files

pritidesai commented on issue #718: Go fmt - please produce the corrupted list of files URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/718#issuecomment-369014326 Fixed with PR #743 This is an

[GitHub] pritidesai closed issue #718: Go fmt - please produce the corrupted list of files

pritidesai closed issue #718: Go fmt - please produce the corrupted list of files URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/718 This is an automated message from the Apache Git Service. To respond

[GitHub] dgrove-oss commented on a change in pull request #3211: implement ContainerFactory.cpuShare to fix #3110

dgrove-oss commented on a change in pull request #3211: implement ContainerFactory.cpuShare to fix #3110 URL: https://github.com/apache/incubator-openwhisk/pull/3211#discussion_r171016731 ## File path:

[GitHub] bwmcadams commented on a change in pull request #3338: implement suspend/resume for KubernetesContainer

bwmcadams commented on a change in pull request #3338: implement suspend/resume for KubernetesContainer URL: https://github.com/apache/incubator-openwhisk/pull/3338#discussion_r171042727 ## File path:

[GitHub] bwmcadams commented on a change in pull request #3338: implement suspend/resume for KubernetesContainer

bwmcadams commented on a change in pull request #3338: implement suspend/resume for KubernetesContainer URL: https://github.com/apache/incubator-openwhisk/pull/3338#discussion_r171043476 ## File path:

[GitHub] dubeejw closed pull request #20: Defect for delete of preinstalled directory

dubeejw closed pull request #20: Defect for delete of preinstalled directory URL: https://github.com/apache/incubator-openwhisk-package-deploy/pull/20 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] pritidesai commented on issue #694: filesystemreader.go: "searching for Action code.." code block incomplete

pritidesai commented on issue #694: filesystemreader.go: "searching for Action code.." code block incomplete URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/694#issuecomment-369024623 filesystemreader is going away with PR #759

[GitHub] beemarie closed pull request #16: WIP: Basic code cleanup

beemarie closed pull request #16: WIP: Basic code cleanup URL: https://github.com/apache/incubator-openwhisk-package-deploy/pull/16 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] dgrove-oss commented on a change in pull request #154: container network/dns converted to PureConfig

dgrove-oss commented on a change in pull request #154: container network/dns converted to PureConfig URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/154#discussion_r171017930 ## File path: kubernetes/invoker/invoker.yml ## @@ -93,12 +93,12 @@ spec:

[GitHub] markusthoemmes commented on issue #3313: Add the support to package source code

markusthoemmes commented on issue #3313: Add the support to package source code URL: https://github.com/apache/incubator-openwhisk/pull/3313#issuecomment-368989312 @houshengbo is this still valid? This is an automated

[GitHub] markusthoemmes commented on issue #3363: Ansible image name overrides and bump NGinx to 1.13.9

markusthoemmes commented on issue #3363: Ansible image name overrides and bump NGinx to 1.13.9 URL: https://github.com/apache/incubator-openwhisk/pull/3363#issuecomment-368989076 Could you add some context to the description please? What do we gain by this change? I like the

[GitHub] mrutkows closed pull request #50: Add the license header to all the source code files

mrutkows closed pull request #50: Add the license header to all the source code files URL: https://github.com/apache/incubator-openwhisk-release/pull/50 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] markusthoemmes commented on issue #3357: Remove usages of replace and replaceAll on the hotpath.

markusthoemmes commented on issue #3357: Remove usages of replace and replaceAll on the hotpath. URL: https://github.com/apache/incubator-openwhisk/pull/3357#issuecomment-368991313 Superseded by #3362 This is an automated

[GitHub] csantanapr closed pull request #176: Only fetch action code when saving or copying an action

csantanapr closed pull request #176: Only fetch action code when saving or copying an action URL: https://github.com/apache/incubator-openwhisk-cli/pull/176 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] rabbah closed pull request #3326: Make SplunkLogStore tests more resilient.

rabbah closed pull request #3326: Make SplunkLogStore tests more resilient. URL: https://github.com/apache/incubator-openwhisk/pull/3326 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is

[GitHub] pritidesai commented on issue #758: Deprecate interactive mode in wskdeploy

pritidesai commented on issue #758: Deprecate interactive mode in wskdeploy URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/758#issuecomment-369018371 sure @mrutkows we can, in that case, can we rename `--allow-interactive` and `-i` to `--dryrun` (as per

[GitHub] beemarie commented on issue #20: Defect for delete of preinstalled directory

beemarie commented on issue #20: Defect for delete of preinstalled directory URL: https://github.com/apache/incubator-openwhisk-package-deploy/pull/20#issuecomment-368982921 @dubeejw please take a look & merge when you get a chance. Jason reviewed earlier.

[GitHub] jthomas commented on issue #3346: Integrate kube deployment?

jthomas commented on issue #3346: Integrate kube deployment? URL: https://github.com/apache/incubator-openwhisk/issues/3346#issuecomment-368990701 As a short term improvement, should we improve the docs to list all the deployment options and point to the external repos?

[GitHub] pritidesai commented on issue #758: Deprecate interactive mode in wskdeploy

pritidesai commented on issue #758: Deprecate interactive mode in wskdeploy URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/758#issuecomment-369018371 sure @mrutkows we can, in that case, we should rename `--allow-interactive` and `-i` to `--report`. Also, there are

[GitHub] akrabat commented on issue #100: Add prefix to PROJECT_HOME and CATALOG_HOME

akrabat commented on issue #100: Add prefix to PROJECT_HOME and CATALOG_HOME URL: https://github.com/apache/incubator-openwhisk-devtools/pull/100#issuecomment-369004872 @jthomas: https://github.com/apache/incubator-openwhisk-devtools/pull/101

[GitHub] akrabat opened a new pull request #101: Add information on some env variables to README

akrabat opened a new pull request #101: Add information on some env variables to README URL: https://github.com/apache/incubator-openwhisk-devtools/pull/101 PROJECT_HOME is now OPENWHISK_PROJECT_HOME. Also add information about some of the other environment variables that can be set.

[GitHub] akrabat opened a new pull request #100: Add prefix to PROJECT_HOME and CATALOG_HOME

akrabat opened a new pull request #100: Add prefix to PROJECT_HOME and CATALOG_HOME URL: https://github.com/apache/incubator-openwhisk-devtools/pull/100 PROJECT_HOME and CATALOG_HOME are to generic, so make them more specific by changing to OPENWHISK_PROJECT_HOME and

[GitHub] chetanmeh opened a new issue #3355: Add requiredProperties method to ArtifactStore

chetanmeh opened a new issue #3355: Add requiredProperties method to ArtifactStore URL: https://github.com/apache/incubator-openwhisk/issues/3355 Currently required properties related to ArtifactStore is mentioned at various places like. 1. WhiskAuthStore 2. WhiskEntityStore

[GitHub] markusthoemmes commented on issue #3355: Add requiredProperties method to ArtifactStore

markusthoemmes commented on issue #3355: Add requiredProperties method to ArtifactStore URL: https://github.com/apache/incubator-openwhisk/issues/3355#issuecomment-368861156 Alternatively, we should move the ArtifactStore to `pureconfig` which completely localizes the concern to the

[GitHub] dgrove-oss closed pull request #154: container network/dns converted to PureConfig

dgrove-oss closed pull request #154: container network/dns converted to PureConfig URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/154 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] chetanmeh commented on issue #3355: Add requiredProperties method to ArtifactStore

chetanmeh commented on issue #3355: Add requiredProperties method to ArtifactStore URL: https://github.com/apache/incubator-openwhisk/issues/3355#issuecomment-368861843 > we should move the ArtifactStore to pureconfig Eventually yes but I believe such a change would touch multiple

[GitHub] markusthoemmes commented on a change in pull request #3347: Generic Pooling REST Client

markusthoemmes commented on a change in pull request #3347: Generic Pooling REST Client URL: https://github.com/apache/incubator-openwhisk/pull/3347#discussion_r170910893 ## File path: common/scala/src/main/scala/whisk/http/PoolingRestClient.scala ## @@ -0,0 +1,154 @@

[GitHub] markusthoemmes commented on a change in pull request #3347: Generic Pooling REST Client

markusthoemmes commented on a change in pull request #3347: Generic Pooling REST Client URL: https://github.com/apache/incubator-openwhisk/pull/3347#discussion_r170910847 ## File path: common/scala/src/main/scala/whisk/http/PoolingRestClient.scala ## @@ -0,0 +1,154 @@

[GitHub] markusthoemmes commented on a change in pull request #3347: Generic Pooling REST Client

markusthoemmes commented on a change in pull request #3347: Generic Pooling REST Client URL: https://github.com/apache/incubator-openwhisk/pull/3347#discussion_r170910875 ## File path: common/scala/src/main/scala/whisk/http/PoolingRestClient.scala ## @@ -0,0 +1,154 @@

[GitHub] dgrove-oss opened a new issue #160: Invoker: overrides of container network and container dns

dgrove-oss opened a new issue #160: Invoker: overrides of container network and container dns URL: https://github.com/apache/incubator-openwhisk-deploy-kube/issues/160 We need to be able to pass through overrides of CONFIG_whisk_containerFactory_containerArgs_network and

[GitHub] mdeuser commented on a change in pull request #176: Only fetch action code when saving or copying an action

mdeuser commented on a change in pull request #176: Only fetch action code when saving or copying an action URL: https://github.com/apache/incubator-openwhisk-cli/pull/176#discussion_r170913245 ## File path: tests/src/test/scala/system/basic/WskActionTests.scala ## @@

[GitHub] mdeuser commented on a change in pull request #3352: API GW doc update to include path parameter example

mdeuser commented on a change in pull request #3352: API GW doc update to include path parameter example URL: https://github.com/apache/incubator-openwhisk/pull/3352#discussion_r170916148 ## File path: docs/apigateway.md ## @@ -104,52 +103,61 @@ You have a series of

[GitHub] mdeuser commented on a change in pull request #3352: API GW doc update to include path parameter example

mdeuser commented on a change in pull request #3352: API GW doc update to include path parameter example URL: https://github.com/apache/incubator-openwhisk/pull/3352#discussion_r170916694 ## File path: docs/apigateway.md ## @@ -104,52 +103,61 @@ You have a series of

[GitHub] mdeuser commented on issue #3352: API GW doc update to include path parameter example

mdeuser commented on issue #3352: API GW doc update to include path parameter example URL: https://github.com/apache/incubator-openwhisk/pull/3352#issuecomment-368869200 @csantanapr - thanks very much for the review! This

[GitHub] mdeuser commented on a change in pull request #3352: API GW doc update to include path parameter example

mdeuser commented on a change in pull request #3352: API GW doc update to include path parameter example URL: https://github.com/apache/incubator-openwhisk/pull/3352#discussion_r170916708 ## File path: docs/apigateway.md ## @@ -104,52 +103,61 @@ You have a series of

[GitHub] mdeuser commented on a change in pull request #3352: API GW doc update to include path parameter example

mdeuser commented on a change in pull request #3352: API GW doc update to include path parameter example URL: https://github.com/apache/incubator-openwhisk/pull/3352#discussion_r170916687 ## File path: docs/apigateway.md ## @@ -209,8 +224,9 @@ wsk api list /club ```

[GitHub] dgrove-oss commented on a change in pull request #154: container network/dns converted to PureConfig

dgrove-oss commented on a change in pull request #154: container network/dns converted to PureConfig URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/154#discussion_r170909724 ## File path: kubernetes/invoker/invoker.yml ## @@ -93,12 +93,12 @@ spec:

[GitHub] chetanmeh commented on issue #3355: Add requiredProperties method to ArtifactStore

chetanmeh commented on issue #3355: Add requiredProperties method to ArtifactStore URL: https://github.com/apache/incubator-openwhisk/issues/3355#issuecomment-368861843 > we should move the ArtifactStore to pureconfig Eventually yes but I believe such a change would touch multiple

[GitHub] chetanmeh commented on issue #3355: Add requiredProperties method to ArtifactStore

chetanmeh commented on issue #3355: Add requiredProperties method to ArtifactStore URL: https://github.com/apache/incubator-openwhisk/issues/3355#issuecomment-368861843 > we should move the ArtifactStore to pureconfig Eventually yes but I believe such a change would touch multiple

[GitHub] markusthoemmes commented on issue #3355: Add requiredProperties method to ArtifactStore

markusthoemmes commented on issue #3355: Add requiredProperties method to ArtifactStore URL: https://github.com/apache/incubator-openwhisk/issues/3355#issuecomment-368862540 In theory it can but in the past we did all the pureconfig moves by "biting the bullet" and fix every deployment

[GitHub] chetanmeh commented on issue #3355: Add requiredProperties method to ArtifactStore

chetanmeh commented on issue #3355: Add requiredProperties method to ArtifactStore URL: https://github.com/apache/incubator-openwhisk/issues/3355#issuecomment-368865420 Okie would then work on PR which modifies the CouchDBStore to use pureconfig and see if it can be done in backward

[GitHub] mdeuser commented on a change in pull request #176: Only fetch action code when saving or copying an action

mdeuser commented on a change in pull request #176: Only fetch action code when saving or copying an action URL: https://github.com/apache/incubator-openwhisk-cli/pull/176#discussion_r170914861 ## File path: commands/action.go ## @@ -35,27 +35,29 @@ import ( ) const

[GitHub] dgrove-oss commented on a change in pull request #3338: implement suspend/resume for KubernetesContainer

dgrove-oss commented on a change in pull request #3338: implement suspend/resume for KubernetesContainer URL: https://github.com/apache/incubator-openwhisk/pull/3338#discussion_r170916241 ## File path:

[GitHub] dgrove-oss commented on a change in pull request #3338: implement suspend/resume for KubernetesContainer

dgrove-oss commented on a change in pull request #3338: implement suspend/resume for KubernetesContainer URL: https://github.com/apache/incubator-openwhisk/pull/3338#discussion_r170916241 ## File path:

[GitHub] dgrove-oss commented on issue #3346: Integrate kube deployment?

dgrove-oss commented on issue #3346: Integrate kube deployment? URL: https://github.com/apache/incubator-openwhisk/issues/3346#issuecomment-368872097 my 2 cents. Once a deployment has stabilized (isn't being rapidly revved & has basic Travis CI testing), then it seems to me to make sense

[GitHub] mrutkows commented on issue #3346: Integrate kube deployment?

mrutkows commented on issue #3346: Integrate kube deployment? URL: https://github.com/apache/incubator-openwhisk/issues/3346#issuecomment-368879356 FWIW, there should be some community driven criteria on what constitutes a deployment being "ready" for inclusion. That is, we should not be

[GitHub] mrutkows commented on issue #3346: Integrate kube deployment?

mrutkows commented on issue #3346: Integrate kube deployment? URL: https://github.com/apache/incubator-openwhisk/issues/3346#issuecomment-368879356 FWIW, there should be some community driven criteria on what constitutes a deployment being "ready" for inclusion. That is, we should not be

[GitHub] mrutkows commented on issue #3346: Integrate kube deployment?

mrutkows commented on issue #3346: Integrate kube deployment? URL: https://github.com/apache/incubator-openwhisk/issues/3346#issuecomment-368879356 FWIW, there should be some community driven criteria on what constitutes a deployment being "ready" for inclusion. That is, we should not be

[GitHub] csantanapr closed pull request #72: Updated version of PR-15

csantanapr closed pull request #72: Updated version of PR-15 URL: https://github.com/apache/incubator-openwhisk-devtools/pull/72 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] csantanapr commented on issue #72: Updated version of PR-15

csantanapr commented on issue #72: Updated version of PR-15 URL: https://github.com/apache/incubator-openwhisk-devtools/pull/72#issuecomment-368885848 I'm going to assume this is an abandon PR This is an automated message

[GitHub] csantanapr commented on issue #758: Deprecate interactive mode in wskdeploy

csantanapr commented on issue #758: Deprecate interactive mode in wskdeploy URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/758#issuecomment-368847616 +1 This is an automated message from the Apache Git

[GitHub] jonpspri commented on a change in pull request #3133: Subtle changes to support S390X deployment of OpenWhisk

jonpspri commented on a change in pull request #3133: Subtle changes to support S390X deployment of OpenWhisk URL: https://github.com/apache/incubator-openwhisk/pull/3133#discussion_r170897683 ## File path: tools/ubuntu-setup/docker-xenial.sh ## @@ -0,0 +1,49 @@

[GitHub] markusthoemmes commented on a change in pull request #3211: implement ContainerFactory.cpuShare to fix #3110

markusthoemmes commented on a change in pull request #3211: implement ContainerFactory.cpuShare to fix #3110 URL: https://github.com/apache/incubator-openwhisk/pull/3211#discussion_r170877953 ## File path:

[GitHub] markusthoemmes commented on a change in pull request #3211: implement ContainerFactory.cpuShare to fix #3110

markusthoemmes commented on a change in pull request #3211: implement ContainerFactory.cpuShare to fix #3110 URL: https://github.com/apache/incubator-openwhisk/pull/3211#discussion_r170878622 ## File path: core/invoker/src/main/scala/whisk/core/containerpool/ContainerPool.scala

[GitHub] markusthoemmes commented on a change in pull request #3211: implement ContainerFactory.cpuShare to fix #3110

markusthoemmes commented on a change in pull request #3211: implement ContainerFactory.cpuShare to fix #3110 URL: https://github.com/apache/incubator-openwhisk/pull/3211#discussion_r170878764 ## File path:

[GitHub] csantanapr closed pull request #100: Add prefix to PROJECT_HOME and CATALOG_HOME

csantanapr closed pull request #100: Add prefix to PROJECT_HOME and CATALOG_HOME URL: https://github.com/apache/incubator-openwhisk-devtools/pull/100 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] jonpspri opened a new pull request #229: Travis local cli

jonpspri opened a new pull request #229: Travis local cli URL: https://github.com/apache/incubator-openwhisk-cli/pull/229 See https://github.com/apache/incubator-openwhisk/issues/3329 These changes to the travis build script should cause it to exercise the CLI copy logic in the

[GitHub] jonpspri closed pull request #229: Travis local cli

jonpspri closed pull request #229: Travis local cli URL: https://github.com/apache/incubator-openwhisk-cli/pull/229 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[GitHub] chetanmeh opened a new pull request #3366: Adds method deleteAttachments to ArtifactStore

chetanmeh opened a new pull request #3366: Adds method deleteAttachments to ArtifactStore URL: https://github.com/apache/incubator-openwhisk/pull/3366 PR which implements the proposal at #3356 This is an automated message

[GitHub] dubeejw commented on issue #3347: Generic Pooling REST Client

dubeejw commented on issue #3347: Generic Pooling REST Client URL: https://github.com/apache/incubator-openwhisk/pull/3347#issuecomment-368761340 PG2 2862 ? This is an automated message from the Apache Git Service. To

  1   2   >