Github user karanmehta93 commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/425#discussion_r245854871
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/query/GuidePostsCache.java ---
@@ -59,22 +59,36 @@
private final
Github user karanmehta93 commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/425#discussion_r245853048
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/query/PhoenixStatsCacheLoader.java
---
@@ -0,0 +1,73 @@
+/*
+ * Licensed
Github user karanmehta93 commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/425#discussion_r245852592
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/query/GuidePostsCache.java ---
@@ -59,22 +59,36 @@
private final
Github user karanmehta93 commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/425#discussion_r245852009
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/query/PhoenixStatsLoader.java ---
@@ -0,0 +1,47 @@
+/*
+ * Licensed to the Apache
Github user karanmehta93 commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/416#discussion_r244856169
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/query/GuidePostsCache.java ---
@@ -80,38 +94,46 @@ public GuidePostsCache
GitHub user karanmehta93 opened a pull request:
https://github.com/apache/phoenix/pull/422
PHOENIX-5063 Create a new repo for the phoenix query server
@twdsilva Please check. This deletes the project and all relevant files.
You can merge this pull request into a Git repository
Github user karanmehta93 commented on the issue:
https://github.com/apache/phoenix/pull/419
@twdsilva @dbwong @BinShi-SecularBird Please review.
---
Github user karanmehta93 commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/419#discussion_r243720533
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/mapreduce/util/PhoenixConfigurationUtil.java
---
@@ -154,7 +154,8 @@
public
Github user karanmehta93 commented on the issue:
https://github.com/apache/phoenix/pull/419
@gjacoby126 @vincentpoon If you guys have some time.
---
Github user karanmehta93 commented on the issue:
https://github.com/apache/phoenix/pull/419
Design doc: https://salesforce.quip.com/fjMhA2bbBkK4 (is also linked to
Jira)
Jira has more details too https://issues.apache.org/jira/browse/PHOENIX-4009
---
Github user karanmehta93 commented on the issue:
https://github.com/apache/phoenix/pull/419
@twdsilva @ChinmaySKulkarni @joshelser @chrajeshbabu @dbwong
@BinShi-SecularBird
Please review.
---
Github user karanmehta93 commented on the issue:
https://github.com/apache/phoenix/pull/419
_First of all, apologies for lng PR._ (Most of it is refactoring but
still its hard to review)
**Here's the high level idea**
1. 7 classes were inherited from
GitHub user karanmehta93 opened a pull request:
https://github.com/apache/phoenix/pull/419
PHOENIX-4009 Run UPDATE STATISTICS command by using MR integration onâ¦
⦠snapshots
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user karanmehta93 commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/405#discussion_r240013343
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/UpsertWithSCNIT.java ---
@@ -0,0 +1,137 @@
+package org.apache.phoenix.end2end
Github user karanmehta93 commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/410#discussion_r238930264
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/QueryLoggerIT.java ---
@@ -250,7 +250,103 @@ public void testWithLoggingOFF() throws
Github user karanmehta93 commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/410#discussion_r238908527
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/jdbc/PhoenixStatement.java ---
@@ -1774,11 +1778,20 @@ public QueryLogger
createQueryLogger
Github user karanmehta93 commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/410#discussion_r238896069
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/jdbc/PhoenixStatement.java ---
@@ -1774,11 +1778,20 @@ public QueryLogger
createQueryLogger
Github user karanmehta93 commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/410#discussion_r238895706
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/QueryLoggerIT.java ---
@@ -250,7 +250,103 @@ public void testWithLoggingOFF() throws
Github user karanmehta93 commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/410#discussion_r238895603
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/QueryLoggerIT.java ---
@@ -250,7 +250,103 @@ public void testWithLoggingOFF() throws
Github user karanmehta93 commented on the issue:
https://github.com/apache/phoenix/pull/409
Nice work @xcangCRM !
With a few nits and comments addressed, we should be able to commit it.
---
Github user karanmehta93 commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/409#discussion_r238509787
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/log/QueryLogger.java ---
@@ -92,9 +92,17 @@ public boolean isSynced
Github user karanmehta93 commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/409#discussion_r238509758
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/log/QueryLogger.java ---
@@ -92,9 +92,17 @@ public boolean isSynced
Github user karanmehta93 commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/409#discussion_r238508710
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/log/QueryLogger.java ---
@@ -92,9 +92,17 @@ public boolean isSynced
Github user karanmehta93 commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/409#discussion_r238508404
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/jdbc/PhoenixPreparedStatement.java
---
@@ -170,7 +170,7 @@ boolean execute(boolean batched
Github user karanmehta93 commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/409#discussion_r238508341
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/QueryLoggerIT.java ---
@@ -250,7 +250,44 @@ public void testWithLoggingOFF() throws
Github user karanmehta93 commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/409#discussion_r238508192
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/QueryLoggerIT.java ---
@@ -250,7 +250,44 @@ public void testWithLoggingOFF() throws
Github user karanmehta93 closed the pull request at:
https://github.com/apache/phoenix/pull/397
---
Github user karanmehta93 commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/399#discussion_r229504568
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/TaskRegionObserver.java
---
@@ -70,7 +70,11 @@
private long
GitHub user karanmehta93 opened a pull request:
https://github.com/apache/phoenix/pull/400
PHOENIX-5000 Make SecureUserConnectionsTest as Integration test
@twdsilva Please review.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user karanmehta93 commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/399#discussion_r229417331
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/TaskRegionObserver.java
---
@@ -71,6 +71,11 @@
@GuardedBy
Github user karanmehta93 commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/399#discussion_r229401963
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/monitoring/PhoenixMetricsIT.java ---
@@ -232,6 +232,7 @@ private boolean
Github user karanmehta93 commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/397#discussion_r229061395
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/iterate/MapReduceParallelScanGrouper.java
---
@@ -80,18 +83,39 @@ public boolean
Github user karanmehta93 commented on the issue:
https://github.com/apache/phoenix/pull/398
That makes sense. @BinShi-SecularBird
`Those Java equivalents of sizeof() in C/C++, mentioned on the Web, might
be overkilled here`
Can you provide some details on this comment?
---
Github user karanmehta93 commented on the issue:
https://github.com/apache/phoenix/pull/397
@BinShi-SecularBird
---
Github user karanmehta93 commented on the issue:
https://github.com/apache/phoenix/pull/398
It would be good to add a unit test for the size estimator function. We
would know that we need to change how we estimate when we end up changing the
data structure for storing these.
---
Github user karanmehta93 commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/397#discussion_r228699968
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/TableSnapshotReadsMapReduceIT.java
---
@@ -191,31 +192,52 @@ private void upsertData
Github user karanmehta93 commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/397#discussion_r228699931
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/TableSnapshotReadsMapReduceIT.java
---
@@ -66,74 +74,62 @@
private static List
GitHub user karanmehta93 opened a pull request:
https://github.com/apache/phoenix/pull/397
PHOENIX-4997 Phoenix MR on snapshots can produce duplicate rows
@akshita-malhotra @gjacoby126
Could you please review?
You can merge this pull request into a Git repository by running
Github user karanmehta93 commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/359#discussion_r228266727
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/query/QueryServices.java ---
@@ -322,6 +322,12 @@
public static final String
Github user karanmehta93 commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/359#discussion_r225701877
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/TaskRegionObserver.java
---
@@ -0,0 +1,261 @@
+/*
+ * Licensed
Github user karanmehta93 commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/359#discussion_r223898473
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/util/SchemaUtil.java ---
@@ -540,6 +540,12 @@ public static boolean isSequenceTable(byte
Github user karanmehta93 commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/359#discussion_r223898108
--- Diff: phoenix-core/src/main/java/org/apache/phoenix/schema/PTable.java
---
@@ -192,7 +192,39 @@ public static LinkType fromSerializedValue(byte
Github user karanmehta93 commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/359#discussion_r223897753
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java
---
@@ -3206,6 +3219,9 @@ public void
Github user karanmehta93 commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/359#discussion_r223897197
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/TaskRegionObserver.java
---
@@ -0,0 +1,261 @@
+/*
+ * Licensed
Github user karanmehta93 commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/359#discussion_r223897107
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/TaskRegionObserver.java
---
@@ -0,0 +1,261 @@
+/*
+ * Licensed
Github user karanmehta93 commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/359#discussion_r223896074
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/DropTableWithViewsIT.java
---
@@ -0,0 +1,169 @@
+/*
+ * Licensed to the Apache
Github user karanmehta93 commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/359#discussion_r223883668
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/DropTableWithViewsIT.java
---
@@ -0,0 +1,169 @@
+/*
+ * Licensed to the Apache
Github user karanmehta93 commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/359#discussion_r222448206
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/util/SchemaUtil.java ---
@@ -540,6 +540,12 @@ public static boolean isSequenceTable(byte
Github user karanmehta93 commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/359#discussion_r222447782
--- Diff: phoenix-core/src/main/java/org/apache/phoenix/schema/PTable.java
---
@@ -192,7 +192,39 @@ public static LinkType fromSerializedValue(byte
Github user karanmehta93 commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/359#discussion_r222445242
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/query/QueryConstants.java ---
@@ -357,18 +357,28
Github user karanmehta93 commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/359#discussion_r222444777
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/query/QueryConstants.java ---
@@ -357,18 +357,28
Github user karanmehta93 commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/359#discussion_r222444508
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/query/QueryConstants.java ---
@@ -357,18 +357,28
Github user karanmehta93 commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/359#discussion_r222444240
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/query/QueryConstants.java ---
@@ -357,18 +357,28
Github user karanmehta93 commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/359#discussion_r222444065
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java
---
@@ -3206,6 +3219,9 @@ public void
Github user karanmehta93 commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/359#discussion_r222443657
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/TaskRegionObserver.java
---
@@ -0,0 +1,240 @@
+/*
+ * Licensed
Github user karanmehta93 commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/359#discussion_r222443397
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/TaskRegionObserver.java
---
@@ -0,0 +1,261 @@
+/*
+ * Licensed
Github user karanmehta93 commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/359#discussion_r222443224
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/TaskRegionObserver.java
---
@@ -0,0 +1,240 @@
+/*
+ * Licensed
Github user karanmehta93 commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/359#discussion_r222442511
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/TaskRegionObserver.java
---
@@ -0,0 +1,261 @@
+/*
+ * Licensed
Github user karanmehta93 commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/359#discussion_r222442226
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/TaskRegionObserver.java
---
@@ -0,0 +1,261 @@
+/*
+ * Licensed
Github user karanmehta93 commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/359#discussion_r222440911
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/TaskRegionObserver.java
---
@@ -0,0 +1,261 @@
+/*
+ * Licensed
Github user karanmehta93 commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/359#discussion_r222439605
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/TaskRegionObserver.java
---
@@ -0,0 +1,261 @@
+/*
+ * Licensed
Github user karanmehta93 commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/359#discussion_r222438781
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/TaskRegionObserver.java
---
@@ -0,0 +1,261 @@
+/*
+ * Licensed
Github user karanmehta93 commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/359#discussion_r222438220
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/TaskRegionObserver.java
---
@@ -0,0 +1,261 @@
+/*
+ * Licensed
Github user karanmehta93 commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/309#discussion_r219331066
--- Diff: phoenix-core/src/test/java/org/apache/phoenix/query/BaseTest.java
---
@@ -1780,15 +1780,15 @@ private static void verifySequence(String
Github user karanmehta93 commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/309#discussion_r219323543
--- Diff: phoenix-core/src/test/java/org/apache/phoenix/query/BaseTest.java
---
@@ -1780,15 +1780,15 @@ private static void verifySequence(String
Github user karanmehta93 commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/309#discussion_r219312245
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/mapreduce/VerifyReplicationSourceWritable.java
---
@@ -0,0 +1,59 @@
+/*
+ * Licensed
Github user karanmehta93 commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/309#discussion_r219293746
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/mapreduce/util/PhoenixMapReduceUtil.java
---
@@ -17,22 +17,57 @@
*/
package
Github user karanmehta93 commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/309#discussion_r219293615
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/mapreduce/util/PhoenixMapReduceUtil.java
---
@@ -157,6 +192,216 @@ public static void
Github user karanmehta93 commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/309#discussion_r219293433
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/mapreduce/util/PhoenixConfigurationUtil.java
---
@@ -371,20 +396,31 @@ public static void
Github user karanmehta93 commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/309#discussion_r219293081
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/mapreduce/util/PhoenixConfigurationUtil.java
---
@@ -371,20 +396,31 @@ public static void
Github user karanmehta93 commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/351#discussion_r218663829
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java ---
@@ -1279,6 +1279,7 @@ private long updateStatisticsInternal
Github user karanmehta93 commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/351#discussion_r218652492
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/schema/stats/StatsCollectorIT.java
---
@@ -736,6 +737,71 @@ public void
Github user karanmehta93 commented on the issue:
https://github.com/apache/phoenix/pull/351
Patch looks good overall! I have a few nits, please address them and it
should be good to go!
---
Github user karanmehta93 commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/351#discussion_r218635042
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/schema/stats/StatsCollectorIT.java
---
@@ -38,6 +38,7 @@
import java.util.Properties
Github user karanmehta93 commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/347#discussion_r218595912
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/iterate/BaseResultIterators.java
---
@@ -972,32 +977,84 @@ private static boolean
Github user karanmehta93 commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/351#discussion_r218565923
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/schema/stats/StatsCollectorIT.java
---
@@ -38,6 +38,7 @@
import java.util.Properties
Github user karanmehta93 commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/351#discussion_r218230917
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java ---
@@ -1279,6 +1279,7 @@ private long updateStatisticsInternal
GitHub user karanmehta93 opened a pull request:
https://github.com/apache/phoenix/pull/345
PHOENIX-4894 Missing Apache license in two QueryServer classes
@gjacoby126 Quick Review Please?
You can merge this pull request into a Git repository by running:
$ git pull https
Github user karanmehta93 commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/338#discussion_r215432867
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/monitoring/PhoenixLoggingMetricsIT.java
---
@@ -164,13 +167,51 @@ public void
Github user karanmehta93 commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/338#discussion_r215059097
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/jdbc/LoggingPhoenixStatement.java
---
@@ -59,4 +70,17 @@ public ResultSet getGeneratedKeys
Github user karanmehta93 commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/338#discussion_r214222170
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/jdbc/LoggingPhoenixStatement.java
---
@@ -59,4 +70,17 @@ public ResultSet getGeneratedKeys
Github user karanmehta93 commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/338#discussion_r214222059
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/jdbc/LoggingPhoenixStatement.java
---
@@ -59,4 +70,17 @@ public ResultSet getGeneratedKeys
Github user karanmehta93 commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/338#discussion_r214222006
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/jdbc/LoggingPhoenixStatement.java
---
@@ -59,4 +70,17 @@ public ResultSet getGeneratedKeys
Github user karanmehta93 commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/338#discussion_r214200113
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/jdbc/LoggingPhoenixStatement.java
---
@@ -59,4 +70,17 @@ public ResultSet getGeneratedKeys
Github user karanmehta93 commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/338#discussion_r214199911
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/monitoring/PhoenixLoggingMetricsIT.java
---
@@ -154,6 +154,35 @@ private void
Github user karanmehta93 commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/338#discussion_r214199456
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/monitoring/PhoenixLoggingMetricsIT.java
---
@@ -154,6 +154,35 @@ private void
Github user karanmehta93 commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/338#discussion_r214198941
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/monitoring/PhoenixLoggingMetricsIT.java
---
@@ -154,6 +154,35 @@ private void
Github user karanmehta93 commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/336#discussion_r212756649
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/monitoring/PhoenixLoggingMetricsIT.java
---
@@ -91,19 +125,19 @@ public void
GitHub user karanmehta93 opened a pull request:
https://github.com/apache/phoenix/pull/333
PHOENIX-4755 Provide an option to plugin custom avatica server configâ¦
⦠in PQS
@joshelser Please review. I addressed your nits. Will put up patches for
other branches once
GitHub user karanmehta93 opened a pull request:
https://github.com/apache/phoenix/pull/332
PHOENIX-4854 Make LoggingPhoenixResultSet idempotent when logging metâ¦
â¦rics
@twdsilva Please review.
You can merge this pull request into a Git repository by running:
$ git
Github user karanmehta93 commented on the issue:
https://github.com/apache/phoenix/pull/328
Thanks @ankitsinghal, will commit it tomorrow.
---
Github user karanmehta93 closed the pull request at:
https://github.com/apache/phoenix/pull/327
---
Github user karanmehta93 closed the pull request at:
https://github.com/apache/phoenix/pull/322
---
GitHub user karanmehta93 opened a pull request:
https://github.com/apache/phoenix/pull/326
PHOENIX-4851 Update branch names in test-patch.properties for 4.14-HBâ¦
â¦ase-1.4 for Hadoop QA run
You can merge this pull request into a Git repository by running:
$ git pull https
Github user karanmehta93 commented on the issue:
https://github.com/apache/phoenix/pull/322
@joshelser @twdsilva Please review.
---
95 matches
Mail list logo
