[GitHub] sijie commented on a change in pull request #1807: [bookie] Fix sorted ledger storage rotating entry log files too frequent

sijie commented on a change in pull request #1807: [bookie] Fix sorted ledger storage rotating entry log files too frequent URL: https://github.com/apache/bookkeeper/pull/1807#discussion_r232935167 ## File path:

[GitHub] eolivelli commented on issue #1802: [branch 4.8] Fix compilation issue introduced by issue #1791

eolivelli commented on issue #1802: [branch 4.8] Fix compilation issue introduced by issue #1791 URL: https://github.com/apache/bookkeeper/pull/1802#issuecomment-438200254 rerun integration tests This is an automated message

[GitHub] sijie commented on a change in pull request #1802: [branch 4.8] Fix compilation issue introduced by issue #1791

sijie commented on a change in pull request #1802: [branch 4.8] Fix compilation issue introduced by issue #1791 URL: https://github.com/apache/bookkeeper/pull/1802#discussion_r232942674 ## File path:

[GitHub] eolivelli commented on issue #1802: [branch 4.8] Fix compilation issue introduced by issue #1791

eolivelli commented on issue #1802: [branch 4.8] Fix compilation issue introduced by issue #1791 URL: https://github.com/apache/bookkeeper/pull/1802#issuecomment-438211054 rerun integration tests This is an automated message

[GitHub] sijie closed pull request #1786: BP-36: Stats documentation annotation

sijie closed pull request #1786: BP-36: Stats documentation annotation URL: https://github.com/apache/bookkeeper/pull/1786 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[GitHub] sijie commented on issue #1787: [stats] introduce `StatsDoc` annotation for better documenting metrics exposed by bookkeeper

sijie commented on issue #1787: [stats] introduce `StatsDoc` annotation for better documenting metrics exposed by bookkeeper URL: https://github.com/apache/bookkeeper/pull/1787#issuecomment-438186026 IGNORE IT CI This is an

[GitHub] sijie commented on issue #1807: [bookie] Fix sorted ledger storage rotating entry log files too frequent

sijie commented on issue #1807: [bookie] Fix sorted ledger storage rotating entry log files too frequent URL: https://github.com/apache/bookkeeper/pull/1807#issuecomment-438184768 @reddycharan I added a logging message with a reason field. let me know if this approach works for you.

Build failed in Jenkins: bookkeeper_release_branch_47_integrationtests #205

See -- [...truncated 10.94 KB...] root 679 2 0 Jul 25 0.0 0.0 [kworker/14:1H] root 727 1 726 Jul 25 0.0 0.0

[GitHub] eolivelli commented on issue #1802: [branch 4.8] Fix compilation issue introduced by issue #1791

eolivelli commented on issue #1802: [branch 4.8] Fix compilation issue introduced by issue #1791 URL: https://github.com/apache/bookkeeper/pull/1802#issuecomment-438261978 I am running again. The first run failed with an error on smoke tests. I will merge as soon as I have a good run

[GitHub] ivankelly commented on issue #1802: [branch 4.8] Fix compilation issue introduced by issue #1791

ivankelly commented on issue #1802: [branch 4.8] Fix compilation issue introduced by issue #1791 URL: https://github.com/apache/bookkeeper/pull/1802#issuecomment-438248207 @eolivelli did they run ok locally? that script is a jenkins thing

Build failed in Jenkins: bookkeeper_release_branch_48_integrationtests #90

See -- [...truncated 448.27 KB...] 2018-11-13\T\12:50:22.294 [INFO] Downloaded:

Build failed in Jenkins: bookkeeper_release_branch_48_java9 #90

See -- [...truncated 507.25 KB...] 2018-11-13T12:19:49.615 [INFO] Downloading:

Build failed in Jenkins: bookkeeper_postcommit_master_python #35

See Changes: [eolivelli] ISSUE #1799: bkctl is broken with default build options [eolivelli] [tools] package bookkeeper tools into a separated distribution [github] Move version out of

Build failed in Jenkins: bookkeeper_release_branch_48_java8 #90

See -- [...truncated 501.87 KB...] 2018-11-13T12:53:30.418 [INFO] Downloaded:

[GitHub] sijie closed pull request #1787: [stats] introduce `StatsDoc` annotation for better documenting metrics exposed by bookkeeper

sijie closed pull request #1787: [stats] introduce `StatsDoc` annotation for better documenting metrics exposed by bookkeeper URL: https://github.com/apache/bookkeeper/pull/1787 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed

[GitHub] eolivelli commented on issue #1802: [branch 4.8] Fix compilation issue introduced by issue #1791

eolivelli commented on issue #1802: [branch 4.8] Fix compilation issue introduced by issue #1791 URL: https://github.com/apache/bookkeeper/pull/1802#issuecomment-438211679 Integration tests are faling with this error: ``` Cleaning workspace > git rev-parse --verify HEAD #

[GitHub] jvrao commented on issue #1809: Change LedgerManager to use CompletableFuture

jvrao commented on issue #1809: Change LedgerManager to use CompletableFuture URL: https://github.com/apache/bookkeeper/pull/1809#issuecomment-438308479 @reddycharan Please review this. This is an automated message from the

[GitHub] jvrao commented on a change in pull request #1808: Allow to configure sticky reads

jvrao commented on a change in pull request #1808: Allow to configure sticky reads URL: https://github.com/apache/bookkeeper/pull/1808#discussion_r233094985 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/PendingReadOp.java ## @@ -96,13 +96,38

[GitHub] eolivelli commented on a change in pull request #1809: Change LedgerManager to use CompletableFuture

eolivelli commented on a change in pull request #1809: Change LedgerManager to use CompletableFuture URL: https://github.com/apache/bookkeeper/pull/1809#discussion_r233115253 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BKException.java ##

[GitHub] eolivelli commented on issue #1806: Issue 1799: bkctl is broken with default build options

eolivelli commented on issue #1806: Issue 1799: bkctl is broken with default build options URL: https://github.com/apache/bookkeeper/pull/1806#issuecomment-438331118 I will re run integration tests locally. It is a big nuisance for contributors, we should fix this

[GitHub] sijie commented on a change in pull request #1808: Allow to configure sticky reads

sijie commented on a change in pull request #1808: Allow to configure sticky reads URL: https://github.com/apache/bookkeeper/pull/1808#discussion_r233116546 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/PendingReadOp.java ## @@ -96,13 +96,38

[GitHub] reddycharan removed a comment on issue #1807: [bookie] Fix sorted ledger storage rotating entry log files too frequent

reddycharan removed a comment on issue #1807: [bookie] Fix sorted ledger storage rotating entry log files too frequent URL: https://github.com/apache/bookkeeper/pull/1807#issuecomment-438340801 LGTM other than that minor log statement issue -

[GitHub] sijie commented on a change in pull request #1809: Change LedgerManager to use CompletableFuture

sijie commented on a change in pull request #1809: Change LedgerManager to use CompletableFuture URL: https://github.com/apache/bookkeeper/pull/1809#discussion_r233128066 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/MSLedgerManagerFactory.java

[GitHub] sijie commented on a change in pull request #1809: Change LedgerManager to use CompletableFuture

sijie commented on a change in pull request #1809: Change LedgerManager to use CompletableFuture URL: https://github.com/apache/bookkeeper/pull/1809#discussion_r233121099 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeperAdmin.java ##

[GitHub] sijie commented on a change in pull request #1809: Change LedgerManager to use CompletableFuture

sijie commented on a change in pull request #1809: Change LedgerManager to use CompletableFuture URL: https://github.com/apache/bookkeeper/pull/1809#discussion_r233123746 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/AbstractZkLedgerManager.java

[GitHub] sijie commented on a change in pull request #1809: Change LedgerManager to use CompletableFuture

sijie commented on a change in pull request #1809: Change LedgerManager to use CompletableFuture URL: https://github.com/apache/bookkeeper/pull/1809#discussion_r233128211 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/MSLedgerManagerFactory.java

[GitHub] sijie commented on a change in pull request #1809: Change LedgerManager to use CompletableFuture

sijie commented on a change in pull request #1809: Change LedgerManager to use CompletableFuture URL: https://github.com/apache/bookkeeper/pull/1809#discussion_r233120404 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BKException.java ## @@

[GitHub] sijie commented on a change in pull request #1809: Change LedgerManager to use CompletableFuture

sijie commented on a change in pull request #1809: Change LedgerManager to use CompletableFuture URL: https://github.com/apache/bookkeeper/pull/1809#discussion_r233118965 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BookieShell.java ## @@

[GitHub] sijie commented on a change in pull request #1809: Change LedgerManager to use CompletableFuture

sijie commented on a change in pull request #1809: Change LedgerManager to use CompletableFuture URL: https://github.com/apache/bookkeeper/pull/1809#discussion_r233127634 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/CleanupLedgerManager.java ##

[GitHub] sijie commented on a change in pull request #1809: Change LedgerManager to use CompletableFuture

sijie commented on a change in pull request #1809: Change LedgerManager to use CompletableFuture URL: https://github.com/apache/bookkeeper/pull/1809#discussion_r233123083 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/AbstractZkLedgerManager.java

[GitHub] sijie commented on a change in pull request #1809: Change LedgerManager to use CompletableFuture

sijie commented on a change in pull request #1809: Change LedgerManager to use CompletableFuture URL: https://github.com/apache/bookkeeper/pull/1809#discussion_r233124668 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/CleanupLedgerManager.java ##

[GitHub] eolivelli commented on issue #1802: [branch 4.8] Fix compilation issue introduced by issue #1791

eolivelli commented on issue #1802: [branch 4.8] Fix compilation issue introduced by issue #1791 URL: https://github.com/apache/bookkeeper/pull/1802#issuecomment-438321049 IGNORE IT CI This is an automated message from the

[GitHub] eolivelli commented on issue #1806: Issue 1799: bkctl is broken with default build options

eolivelli commented on issue #1806: Issue 1799: bkctl is broken with default build options URL: https://github.com/apache/bookkeeper/pull/1806#issuecomment-438323069 @sijie @ivankelly #1802 has been merged, I have rebased this patch on top of current branch-4.8

[GitHub] eolivelli commented on a change in pull request #1809: Change LedgerManager to use CompletableFuture

eolivelli commented on a change in pull request #1809: Change LedgerManager to use CompletableFuture URL: https://github.com/apache/bookkeeper/pull/1809#discussion_r233115253 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BKException.java ##

[GitHub] eolivelli commented on a change in pull request #1809: Change LedgerManager to use CompletableFuture

eolivelli commented on a change in pull request #1809: Change LedgerManager to use CompletableFuture URL: https://github.com/apache/bookkeeper/pull/1809#discussion_r233115253 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BKException.java ##

[GitHub] reddycharan commented on a change in pull request #1807: [bookie] Fix sorted ledger storage rotating entry log files too frequent

reddycharan commented on a change in pull request #1807: [bookie] Fix sorted ledger storage rotating entry log files too frequent URL: https://github.com/apache/bookkeeper/pull/1807#discussion_r233123238 ## File path:

[GitHub] eolivelli commented on a change in pull request #1808: Allow to configure sticky reads

eolivelli commented on a change in pull request #1808: Allow to configure sticky reads URL: https://github.com/apache/bookkeeper/pull/1808#discussion_r233104196 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/PendingReadOp.java ## @@ -96,13

[GitHub] eolivelli commented on issue #1802: [branch 4.8] Fix compilation issue introduced by issue #1791

eolivelli commented on issue #1802: [branch 4.8] Fix compilation issue introduced by issue #1791 URL: https://github.com/apache/bookkeeper/pull/1802#issuecomment-438321002 I have run the integrations tests locally, compiling the sources with -Dstream and the tests are passing. This

[GitHub] eolivelli closed pull request #1802: [branch 4.8] Fix compilation issue introduced by issue #1791

eolivelli closed pull request #1802: [branch 4.8] Fix compilation issue introduced by issue #1791 URL: https://github.com/apache/bookkeeper/pull/1802 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] reddycharan commented on issue #1807: [bookie] Fix sorted ledger storage rotating entry log files too frequent

reddycharan commented on issue #1807: [bookie] Fix sorted ledger storage rotating entry log files too frequent URL: https://github.com/apache/bookkeeper/pull/1807#issuecomment-438340801 LGTM other than that minor log statement issue -

[GitHub] eolivelli commented on issue #1802: [branch 4.8] Fix compilation issue introduced by issue #1791

eolivelli commented on issue #1802: [branch 4.8] Fix compilation issue introduced by issue #1791 URL: https://github.com/apache/bookkeeper/pull/1802#issuecomment-438281822 My errors without -Dstream, I am now testing with -Dstream: > [INFO] Running

Jenkins build is still unstable: bookkeeper_release_branch_46 #215

See

Jenkins build is back to stable : bookkeeper_release_branch_47_java9 #217

See

[GitHub] jvrao commented on issue #1808: Allow to configure sticky reads

jvrao commented on issue #1808: Allow to configure sticky reads URL: https://github.com/apache/bookkeeper/pull/1808#issuecomment-438312878 @nicmichael can you please look into this too? This is an automated message from the

[GitHub] jvrao commented on a change in pull request #1802: [branch 4.8] Fix compilation issue introduced by issue #1791

jvrao commented on a change in pull request #1802: [branch 4.8] Fix compilation issue introduced by issue #1791 URL: https://github.com/apache/bookkeeper/pull/1802#discussion_r233088381 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java

[GitHub] ivankelly opened a new pull request #1809: Change LedgerManager to use CompletableFuture

ivankelly opened a new pull request #1809: Change LedgerManager to use CompletableFuture URL: https://github.com/apache/bookkeeper/pull/1809 All new uses of LedgerManager are creating GenericCallbackFutures to pass in as the callback. This patch cuts out the middleman, and makes

[GitHub] merlimat commented on a change in pull request #1808: Allow to configure sticky reads

merlimat commented on a change in pull request #1808: Allow to configure sticky reads URL: https://github.com/apache/bookkeeper/pull/1808#discussion_r233167786 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/PendingReadOp.java ## @@ -96,13

[GitHub] merlimat closed pull request #1641: Added module to enable CPU affinity

merlimat closed pull request #1641: Added module to enable CPU affinity URL: https://github.com/apache/bookkeeper/pull/1641 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[GitHub] merlimat commented on issue #1682: Added BlockingQueue implementation based on JCtools

merlimat commented on issue #1682: Added BlockingQueue implementation based on JCtools URL: https://github.com/apache/bookkeeper/pull/1682#issuecomment-438388356 @jvrao @dlg99 @sijie @ivankelly Are we good to merge this one?

[GitHub] merlimat commented on issue #1682: Added BlockingQueue implementation based on JCtools

merlimat commented on issue #1682: Added BlockingQueue implementation based on JCtools URL: https://github.com/apache/bookkeeper/pull/1682#issuecomment-438493846 run integration tests This is an automated message from

[GitHub] reddycharan opened a new pull request #1810: Remove duplication logic for 'minNumRacksPerWriteQuorum' handling in RackawareEnsemblePlacementPolicyImpl

reddycharan opened a new pull request #1810: Remove duplication logic for 'minNumRacksPerWriteQuorum' handling in RackawareEnsemblePlacementPolicyImpl URL: https://github.com/apache/bookkeeper/pull/1810 Descriptions of the changes in this PR: With this change

[GitHub] merlimat commented on issue #1682: Added BlockingQueue implementation based on JCtools

merlimat commented on issue #1682: Added BlockingQueue implementation based on JCtools URL: https://github.com/apache/bookkeeper/pull/1682#issuecomment-438553509 run integration tests This is an automated message from the

[GitHub] eolivelli commented on a change in pull request #1808: Allow to configure sticky reads

eolivelli commented on a change in pull request #1808: Allow to configure sticky reads URL: https://github.com/apache/bookkeeper/pull/1808#discussion_r233328904 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/PendingReadOp.java ## @@ -96,13

[GitHub] eolivelli commented on a change in pull request #1802: [branch 4.8] Fix compilation issue introduced by issue #1791

eolivelli commented on a change in pull request #1802: [branch 4.8] Fix compilation issue introduced by issue #1791 URL: https://github.com/apache/bookkeeper/pull/1802#discussion_r233211173 ## File path:

[GitHub] merlimat commented on issue #1682: Added BlockingQueue implementation based on JCtools

merlimat commented on issue #1682: Added BlockingQueue implementation based on JCtools URL: https://github.com/apache/bookkeeper/pull/1682#issuecomment-438414667 @jvrao all these changes are by default turned off This is an

[GitHub] jvrao commented on issue #1682: Added BlockingQueue implementation based on JCtools

jvrao commented on issue #1682: Added BlockingQueue implementation based on JCtools URL: https://github.com/apache/bookkeeper/pull/1682#issuecomment-438414045 @dlg99 can you please review this? I wish we have some way to validate these perf changes. At lest to make sure it is not

[GitHub] ivankelly commented on a change in pull request #1809: Change LedgerManager to use CompletableFuture

ivankelly commented on a change in pull request #1809: Change LedgerManager to use CompletableFuture URL: https://github.com/apache/bookkeeper/pull/1809#discussion_r233204066 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/CleanupLedgerManager.java

[GitHub] ivankelly commented on a change in pull request #1809: Change LedgerManager to use CompletableFuture

ivankelly commented on a change in pull request #1809: Change LedgerManager to use CompletableFuture URL: https://github.com/apache/bookkeeper/pull/1809#discussion_r233203737 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/AbstractZkLedgerManager.java

[GitHub] sijie commented on issue #1806: Issue 1799: bkctl is broken with default build options

sijie commented on issue #1806: Issue 1799: bkctl is broken with default build options URL: https://github.com/apache/bookkeeper/pull/1806#issuecomment-438419446 branch-4.8 doesn't have `.test-infra/scripts/pre-docker-tests.sh` and `.test-infra/scripts/post-docker-tests.sh` We can

[GitHub] ivankelly commented on a change in pull request #1809: Change LedgerManager to use CompletableFuture

ivankelly commented on a change in pull request #1809: Change LedgerManager to use CompletableFuture URL: https://github.com/apache/bookkeeper/pull/1809#discussion_r233205362 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/CleanupLedgerManager.java

[GitHub] sijie commented on a change in pull request #1809: Change LedgerManager to use CompletableFuture

sijie commented on a change in pull request #1809: Change LedgerManager to use CompletableFuture URL: https://github.com/apache/bookkeeper/pull/1809#discussion_r233207255 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/CleanupLedgerManager.java ##

[GitHub] sijie commented on a change in pull request #1809: Change LedgerManager to use CompletableFuture

sijie commented on a change in pull request #1809: Change LedgerManager to use CompletableFuture URL: https://github.com/apache/bookkeeper/pull/1809#discussion_r233207589 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/CleanupLedgerManager.java ##

[GitHub] eolivelli commented on issue #1806: Issue 1799: bkctl is broken with default build options

eolivelli commented on issue #1806: Issue 1799: bkctl is broken with default build options URL: https://github.com/apache/bookkeeper/pull/1806#issuecomment-438425360 @sijie yes it will be better. I do not have my laptop now, tomorrow I will see the result and eventually commit this

[GitHub] merlimat commented on issue #1682: Added BlockingQueue implementation based on JCtools

merlimat commented on issue #1682: Added BlockingQueue implementation based on JCtools URL: https://github.com/apache/bookkeeper/pull/1682#issuecomment-438408237 run pr validation run integrations tests This is an