subject:"\[jira\] \[Commented\] \(CB\-7179\) \[InAppBrowser\]\[iOS 8\] Update to support WKWebView"

[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2018-10-28 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1580#comment-1580
 ] 

ASF GitHub Bot commented on CB-7179:


jonathanli2 commented on issue #271: CB-7179 (iOS): Add WKWebView support for 
iOS
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/271#issuecomment-433745441
 
 
   I created a simple iOS UIWebView cordova app with just inappbrowser plugin 
added into the project, and it can repeat the same issue.
   
   The project (basictest.zip) is shared at the folder of
   
https://sap-my.sharepoint.com/:f:/p/jonathan_li/EmulfDR6x9RBuQdj5u1-NrwBYchculWO6RAfoC_NTM8XLw?e=YzzUkh
   
   The project (basictest.zip) only has a simple openInappbrowser button, once 
index.html is opened, then clicking toolbar's done button to close the 
inappbrowser. After the inappbrowser is closed. Clicking on the main 
UIWebView's openInappbrowser button again will do nothing, it seems the main 
UIWebView is disabled.
   
   This indicates the issue is in the new inappbrowser plugin's implementation.
   
   Thanks
   Jonathan


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>Priority: Major
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2018-10-27 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1267#comment-1267
 ] 

ASF GitHub Bot commented on CB-7179:


jonathanli2 commented on issue #271: CB-7179 (iOS): Add WKWebView support for 
iOS
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/271#issuecomment-433671846
 
 
   Hi,
   After upgrading our ios Fiori client application to the new inappbrowser, 
somehow, the content in the main webview (UIWebview or WKWebView) is disabled 
and cannot response to user actions. The same app works normal when using 
inappbrowser version 2.0.x.
   
   I submitted an issue for this at
   https://github.com/apache/cordova-plugin-inappbrowser/issues/334

   The testing projects are shared at
   
https://sap-my.sharepoint.com/:f:/p/jonathan_li/EmulfDR6x9RBuQdj5u1-NrwBYchculWO6RAfoC_NTM8XLw?e=YzzUkh
   
   Any idea for this issue?
   
   Thanks
   Jonathan


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>Priority: Major
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2018-10-17 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16653117#comment-16653117
 ] 

ASF GitHub Bot commented on CB-7179:


knight commented on a change in pull request #271: CB-7179 (iOS): Add 
WKWebView support for iOS
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/271#discussion_r225806705
 
 

 ##
 File path: tests/plugin.xml
 ##
 @@ -29,5 +29,12 @@
 
 
 
+
+  
+  
+  https://github.com/knight/cordova-plugin-wkwebview-engine-allowfileaccess.git;
 />
 
 Review comment:
   I have published my plugin 
https://www.npmjs.com/package/cordova-plugin-wkwebview-engine-allowfileaccess . 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>Priority: Major
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2018-10-17 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16653063#comment-16653063
 ] 

ASF GitHub Bot commented on CB-7179:


dpa99c commented on issue #271: CB-7179 (iOS): Add WKWebView support for iOS
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/271#issuecomment-430508737
 
 
   @purplecabbage great, thanks for unblocking this. I will be on standby to 
help resolve any issues with the new implementation. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>Priority: Major
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2018-10-17 Thread ASF subversion and git services (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16653016#comment-16653016
 ] 

ASF subversion and git services commented on CB-7179:
-

Commit 10a06691f94a5ccc76957c48887469aedd4c2e13 in 
cordova-plugin-inappbrowser's branch refs/heads/master from [~purplecabbage]
[ 
https://gitbox.apache.org/repos/asf?p=cordova-plugin-inappbrowser.git;h=10a0669 
]

Merge pull request #271 from dpa99c/CB-7179

CB-7179 (iOS): Add WKWebView support for iOS

> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>Priority: Major
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2018-10-17 Thread ASF subversion and git services (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16653013#comment-16653013
 ] 

ASF subversion and git services commented on CB-7179:
-

Commit 3927b8f2fee8e168bb19de93031b2f930b542b24 in 
cordova-plugin-inappbrowser's branch refs/heads/master from [~dpa99c]
[ 
https://gitbox.apache.org/repos/asf?p=cordova-plugin-inappbrowser.git;h=3927b8f 
]

Merge branch 'CB-7179' of 
https://github.com/dpa99c/cordova-plugin-themeablebrowser into CB-7179


> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>Priority: Major
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2018-10-17 Thread ASF subversion and git services (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16653011#comment-16653011
 ] 

ASF subversion and git services commented on CB-7179:
-

Commit 5d2df218d83bdaae79ca953799ad8d30cf9f2ce9 in 
cordova-plugin-inappbrowser's branch refs/heads/master from [~dpa99c]
[ 
https://gitbox.apache.org/repos/asf?p=cordova-plugin-inappbrowser.git;h=5d2df21 
]

Merge branch 'CB-7179' of https://github.com/dpa99c/cordova-plugin-inappbrowser 
into CB-7179


> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>Priority: Major
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2018-10-17 Thread ASF subversion and git services (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16653017#comment-16653017
 ] 

ASF subversion and git services commented on CB-7179:
-

Commit 10a06691f94a5ccc76957c48887469aedd4c2e13 in 
cordova-plugin-inappbrowser's branch refs/heads/master from [~purplecabbage]
[ 
https://gitbox.apache.org/repos/asf?p=cordova-plugin-inappbrowser.git;h=10a0669 
]

Merge pull request #271 from dpa99c/CB-7179

CB-7179 (iOS): Add WKWebView support for iOS

> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>Priority: Major
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2018-10-17 Thread ASF subversion and git services (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16653010#comment-16653010
 ] 

ASF subversion and git services commented on CB-7179:
-

Commit 5d2df218d83bdaae79ca953799ad8d30cf9f2ce9 in 
cordova-plugin-inappbrowser's branch refs/heads/master from [~dpa99c]
[ 
https://gitbox.apache.org/repos/asf?p=cordova-plugin-inappbrowser.git;h=5d2df21 
]

Merge branch 'CB-7179' of https://github.com/dpa99c/cordova-plugin-inappbrowser 
into CB-7179


> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>Priority: Major
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2018-10-17 Thread ASF subversion and git services (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16653015#comment-16653015
 ] 

ASF subversion and git services commented on CB-7179:
-

Commit 3927b8f2fee8e168bb19de93031b2f930b542b24 in 
cordova-plugin-inappbrowser's branch refs/heads/master from [~dpa99c]
[ 
https://gitbox.apache.org/repos/asf?p=cordova-plugin-inappbrowser.git;h=3927b8f 
]

Merge branch 'CB-7179' of 
https://github.com/dpa99c/cordova-plugin-themeablebrowser into CB-7179


> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>Priority: Major
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2018-10-17 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16653007#comment-16653007
 ] 

ASF GitHub Bot commented on CB-7179:


purplecabbage commented on issue #271: CB-7179 (iOS): Add WKWebView support for 
iOS
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/271#issuecomment-430501417
 
 
   Every other way of doing this is messy and involves crazy git rebasing, so I 
am gonna just merge this as is, and see if I can address my concern about the 
test dependency in another pr.
   Thanks for all you work on this @dpa99c !!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>Priority: Major
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2018-10-17 Thread ASF subversion and git services (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16653012#comment-16653012
 ] 

ASF subversion and git services commented on CB-7179:
-

Commit 19c6dfe1971818789a4b3e83f6f4b0793e401597 in 
cordova-plugin-inappbrowser's branch refs/heads/master from [~dpa99c]
[ 
https://gitbox.apache.org/repos/asf?p=cordova-plugin-inappbrowser.git;h=19c6dfe 
]

Merge branch 'master' into CB-7179


> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>Priority: Major
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2018-10-17 Thread ASF subversion and git services (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16653009#comment-16653009
 ] 

ASF subversion and git services commented on CB-7179:
-

Commit cbfa195f7da3b8307a468c3f50f38de25f38bd8e in 
cordova-plugin-inappbrowser's branch refs/heads/master from Jan Piotrowski
[ 
https://gitbox.apache.org/repos/asf?p=cordova-plugin-inappbrowser.git;h=cbfa195 
]

Merge branch 'master' into CB-7179

> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>Priority: Major
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2018-10-16 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16652862#comment-16652862
 ] 

ASF GitHub Bot commented on CB-7179:


knight commented on a change in pull request #271: CB-7179 (iOS): Add 
WKWebView support for iOS
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/271#discussion_r225763050
 
 

 ##
 File path: tests/plugin.xml
 ##
 @@ -29,5 +29,12 @@
 
 
 
+
+  
+  
+  https://github.com/knight/cordova-plugin-wkwebview-engine-allowfileaccess.git;
 />
 
 Review comment:
   Now I have updated my plugin to change author 'Apache Cordova` and license 
`Apache-2.0`.
   But I think it is better to change github repository before publishing to 
npm. Now I am asking this to cordova members.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>Priority: Major
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2018-10-16 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16652299#comment-16652299
 ] 

ASF GitHub Bot commented on CB-7179:


svanzoest commented on issue #271: CB-7179 (iOS): Add WKWebView support for iOS
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/271#issuecomment-430367152
 
 
   > > So the websites you display in the InAppBrowser were using local 
storage, which was not there after the switch to WKWebView? How did you solve 
this @svanzoest?
   > 
   > We used https://github.com/MaKleSoft/cordova-plugin-migrate-localstorage 
however that did not migrate the inappbrowser localstorage. @geeetarguy plans 
to make a PR against that repo so it will migrate inappbrowser localstorage as 
well.
   
   This PR is now available 
https://github.com/MaKleSoft/cordova-plugin-migrate-localstorage/pull/4


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>Priority: Major
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2018-10-16 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16651485#comment-16651485
 ] 

ASF GitHub Bot commented on CB-7179:


dpa99c commented on a change in pull request #271: CB-7179 (iOS): Add WKWebView 
support for iOS
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/271#discussion_r225491186
 
 

 ##
 File path: tests/plugin.xml
 ##
 @@ -29,5 +29,12 @@
 
 
 
+
+  
+  
+  https://github.com/knight/cordova-plugin-wkwebview-engine-allowfileaccess.git;
 />
 
 Review comment:
   @knight Ken, any preference in Jesse's above options? 
   This isn't something I can resolve myself to unblock this PR: all of the 
above require action on the part of Cordova maintainers and it has wider 
implications in terms of test support for WKWebView on iOS, i.e. for 
`cordova-plugin-wkwebview-engine` and `cordova-ios@5`.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>Priority: Major
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2018-10-15 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16651149#comment-16651149
 ] 

ASF GitHub Bot commented on CB-7179:


purplecabbage commented on a change in pull request #271: CB-7179 (iOS): Add 
WKWebView support for iOS
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/271#discussion_r225402732
 
 

 ##
 File path: tests/plugin.xml
 ##
 @@ -29,5 +29,12 @@
 
 
 
+
+  
+  
+  https://github.com/knight/cordova-plugin-wkwebview-engine-allowfileaccess.git;
 />
 
 Review comment:
   The plugin itself is only 2 lines. There are a couple things we could do.
   
   1. Ask @knight  to publish the allowfileaccess plugin to npm, and have 
our test depend on that published version.
   2. make the wk-allowfileaccess a cordova supported plugin, and also do 
suggestion 1, but replace Ken with 'we'
   3. revisit the decision to not allow file access directly in the wkwebview 
plugin, could we just default to NO, but allow the developer to turn it on? ( 
This would require a firm warning about app store rejection possibilities, so 
it might make things too easy for developers and lead to rejections. )
   4. Include it in the paramedic repo as a spec plugin, as suggested by Ken [1]
   
   
   
   
   [1] https://github.com/apache/cordova-paramedic/issues/52
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>Priority: Major
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2018-10-15 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16651132#comment-16651132
 ] 

ASF GitHub Bot commented on CB-7179:


dpa99c commented on a change in pull request #271: CB-7179 (iOS): Add WKWebView 
support for iOS
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/271#discussion_r225399125
 
 

 ##
 File path: tests/plugin.xml
 ##
 @@ -29,5 +29,12 @@
 
 
 
+
+  
+  
+  https://github.com/knight/cordova-plugin-wkwebview-engine-allowfileaccess.git;
 />
 
 Review comment:
   Without the code in that plugin, `cordova-paramedic` tests fail with 
WKWebView.
   What do you suggest? Bundle the plugin code inside `tests/` within this 
plugin?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>Priority: Major
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2018-10-15 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16651128#comment-16651128
 ] 

ASF GitHub Bot commented on CB-7179:


purplecabbage commented on a change in pull request #271: CB-7179 (iOS): Add 
WKWebView support for iOS
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/271#discussion_r223758316
 
 

 ##
 File path: tests/plugin.xml
 ##
 @@ -29,5 +29,12 @@
 
 
 
+
+  
+  
+  https://github.com/knight/cordova-plugin-wkwebview-engine-allowfileaccess.git;
 />
 
 Review comment:
   We can’t have this dependency, even in a test ... what if knight makes a 
commit to master? It could break our tests ...


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>Priority: Major
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2018-10-15 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16651112#comment-16651112
 ] 

ASF GitHub Bot commented on CB-7179:


dpa99c commented on issue #271: CB-7179 (iOS): Add WKWebView support for iOS
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/271#issuecomment-430099632
 
 
   @shazron @janpio What's now blocking this PR? 
   
   All merge conflicts with master are currently resolved and the Travis CI 
tests are now passing for iOS. The Travis tests for "browser-edge" and 
"android-6.0" failed on the last run due to timeout/connectivity issues, but 
then the tests are currently failing on `master` for similar reasons.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>Priority: Major
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2018-10-09 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16643124#comment-16643124
 ] 

ASF GitHub Bot commented on CB-7179:


dpa99c commented on issue #271: CB-7179 (iOS): Add WKWebView support for iOS
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/271#issuecomment-428152217
 
 
   Thanks to @knight for helping to resolve 
https://github.com/apache/cordova-paramedic/issues/52, Travis tests are [now 
passing for 
iOS](https://travis-ci.org/apache/cordova-plugin-inappbrowser/jobs/439077169).
   
   But [failing on other 
platforms](https://travis-ci.org/apache/cordova-plugin-inappbrowser/builds/439077164)
 for some reason.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>Priority: Major
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2018-10-05 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16640325#comment-16640325
 ] 

ASF GitHub Bot commented on CB-7179:


dpa99c edited a comment on issue #271: CB-7179 (iOS): Add WKWebView support for 
iOS
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/271#issuecomment-427492841
 
 
   @janpio I think I've figured out why the tests are failing in this PR, even 
in Xcode 8.3/iOS 10:
   
   This PR requires that `cordova-plugin-wkwebview-engine` be present in the 
Cordova project so its classes can be used by the WKWebView implementation in 
this PR. This means the main Cordova Webview is using WKWebView instead of 
UIWebView. And this seems to screw up `cordova-paramedic` - it can no longer 
communicate its results back to the local server.
   
   I confirmed this by running `cordova-paramedic` against your 
[janpio-xcode8.3 
branch](https://github.com/apache/cordova-plugin-inappbrowser/tree/janpio-xcode8.3)
 first without `cordova-plugin-wkwebview-engine` present (i.e. using UIWebView):
   
   ![screenshot 2018-10-05 at 21 06 
20](https://user-images.githubusercontent.com/2345062/46558914-90ab9f80-c8e6-11e8-976b-abf4e5578eee.png)

   Then with  `cordova-plugin-wkwebview-engine` present (i.e. using WKWebView):
   
   ![screenshot 2018-10-05 at 21 17 
41](https://user-images.githubusercontent.com/2345062/46558937-a4ef9c80-c8e6-11e8-9cd3-33d19b279b79.png)
   
   As you can see, in this second case the tests timed out while trying to 
connect to the local server, leading to the same error observed in the Travis 
CI logs. However, as you can see from the Simulator screenshot, all the tests 
passed.
   
   I then ran the `cordova-paramedic` against the branch for this PR:
   
   ![screenshot 2018-10-05 at 21 34 
05](https://user-images.githubusercontent.com/2345062/46559031-f13adc80-c8e6-11e8-8486-6d7fef3bbff4.png)
   
   As you can see, a similar result: all tests passed in the Simulator, but 
tests failed due to a timeout connecting to the local server.
   
   The upshot is that it seems currently `cordova-paramedic` is not compatible 
when the main Cordova Webview is WKWebView and this presents a problem for this 
PR which requires it to be so.
   
   I'm guessing since UIWebView is now deprecated in iOS 12, we'll be moving at 
some point to make WKWebView the default Cordova Webview (in `cordova-ios@5` 
??), so at some point `cordova-paramedic` is going to need to be fixed to work 
with WKWebView.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>Priority: Major
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2018-10-05 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16640323#comment-16640323
 ] 

ASF GitHub Bot commented on CB-7179:


dpa99c commented on issue #271: CB-7179 (iOS): Add WKWebView support for iOS
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/271#issuecomment-427492841
 
 
   @janpio I think I've figured out why the tests are failing in this PR, even 
in Xcode 8.3/iOS 10:
   
   This PR requires that `cordova-plugin-wkwebview-engine` be present in the 
Cordova project so its classes can be used by the WKWebView implementation in 
this PR. This means the main Cordova Webview is using WKWebView instead of 
UIWebView. And this seems to screw up `cordova-paramedic` - it can no longer 
communicate its results back to the local server.
   
   I confirmed this by running `cordova-paramedic` against your 
[janpio-xcode8.3 
branch](https://github.com/apache/cordova-plugin-inappbrowser/tree/janpio-xcode8.3)
 first without `cordova-plugin-wkwebview-engine` present (i.e. using UIWebView):
   
   ![screenshot 2018-10-05 at 21 06 
20](https://user-images.githubusercontent.com/2345062/46558914-90ab9f80-c8e6-11e8-976b-abf4e5578eee.png)

   Then with  `cordova-plugin-wkwebview-engine` present (i.e. using WKWebView):
   
   ![screenshot 2018-10-05 at 21 17 
41](https://user-images.githubusercontent.com/2345062/46558937-a4ef9c80-c8e6-11e8-9cd3-33d19b279b79.png)
   
   As you can see, in this second case the tests timed out while trying to 
connect to the local server, leading to the same error observed in the Travis 
CI logs. However, as you can see from the Simulator screenshot, all the tests 
passed.
   
   I then ran the `cordova-paramedic` against the branch for this PR:
   
   ![screenshot 2018-10-05 at 21 34 
05](https://user-images.githubusercontent.com/2345062/46559031-f13adc80-c8e6-11e8-8486-6d7fef3bbff4.png)
   
   As you can see, a similar result: all tests passed in the Simulator, but 
tests failed due to a timeout connecting to the local server.
   
   The upshot it that it seems currently `cordova-paramedic` is not compatible 
when the main Cordova Webview is WKWebView and this presents a problem for this 
PR which requires it to be so.
   
   I'm guessing since UIWebView is now deprecated in iOS 12, we'll be moving at 
some point to make WKWebView the default Cordova Webview (in `cordova-ios@5` 
??), so at some point `cordova-paramedic` is going to need to be fixed to work 
with WKWebView.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>Priority: Major
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2018-10-04 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16638399#comment-16638399
 ] 

ASF GitHub Bot commented on CB-7179:


dpa99c commented on issue #271: CB-7179 (iOS): Add WKWebView support for iOS
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/271#issuecomment-427068453
 
 
   > Confirmed that the switch to Xcode8.3 is not the cause for the test 
failures:
   > #312
   
   OK, there must be something preventing the tests running via 
`cordova-paramedic` because when I manually start them in the Simulator, they 
all pass. Will setup `cordova-paramedic` and investigate.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>Priority: Major
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2018-10-03 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16637563#comment-16637563
 ] 

ASF GitHub Bot commented on CB-7179:


janpio commented on issue #271: CB-7179 (iOS): Add WKWebView support for iOS
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/271#issuecomment-426823874
 
 
   Confirmed that the switch to Xcode8.3 is not the cause for the test failures:
   https://github.com/apache/cordova-plugin-inappbrowser/pull/312


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>Priority: Major
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2018-10-03 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16637262#comment-16637262
 ] 

ASF GitHub Bot commented on CB-7179:


janpio commented on issue #271: CB-7179 (iOS): Add WKWebView support for iOS
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/271#issuecomment-426726557
 
 
   And as it came it's gone - now the tests are just failing because they don't 
get their results from Saucelabs :/


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>Priority: Major
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2018-10-03 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16637119#comment-16637119
 ] 

ASF GitHub Bot commented on CB-7179:


janpio commented on issue #271: CB-7179 (iOS): Add WKWebView support for iOS
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/271#issuecomment-426693917
 
 
   Ok thanks, so the iOS 9.3 test I readded should probably fail.
   
   But currently both are failing:
   ```
   ...
   cordova-paramedic: waiting for test results
   appium: Error: [execute(null,[])] getaddrinfo ENOTFOUND 
ondemand.saucelabs.com ondemand.saucelabs.com:80
   cordova-paramedic: Tests failed to complete; ending appium session. The 
error is:
   Error: waitForTests: Seems like device not connected to local server in 540 
secs
   at null._onTimeout (/private/tmp/paramedic/lib/paramedic.js:467:24)
   at Timer.listOnTimeout (timers.js:92:15)
   ...
   ```
   
   *sigh (Investigating)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>Priority: Major
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2018-10-03 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16637088#comment-16637088
 ] 

ASF GitHub Bot commented on CB-7179:


dpa99c edited a comment on issue #271: CB-7179 (iOS): Add WKWebView support for 
iOS
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/271#issuecomment-426681782
 
 
   > Don't worry - that way I can "abuse" your PR to fix all this stuff ;)
   > 
   > You updated the test configuration from `xcode7.3` to `xcode8.3` - is this 
fully required for this PR? Will people not be able to build with Xcode 7.3 any 
more? (Is Xcode 7.3 related in any way any more?)
   
   Yes, Xcode 8.3 is required for the iOS 10 SDK as some properties/class used 
by this PR don't exist in the iOS 9 SDK, e.g. 
[WKWebViewConfiguration.mediaTypesRequiringUserActionForPlayback](https://developer.apple.com/documentation/webkit/wkwebviewconfiguration/1851524-mediatypesrequiringuseractionfor?language=objc)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>Priority: Major
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2018-10-03 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16637087#comment-16637087
 ] 

ASF GitHub Bot commented on CB-7179:


dpa99c commented on issue #271: CB-7179 (iOS): Add WKWebView support for iOS
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/271#issuecomment-426681782
 
 
   > Don't worry - that way I can "abuse" your PR to fix all this stuff ;)
   > 
   > You updated the test configuration from `xcode7.3` to `xcode8.3` - is this 
fully required for this PR? Will people not be able to build with Xcode 7.3 any 
more? (Is Xcode 7.3 related in any way any more?)
   
   Yes, Xcode 8.3 is required for the iOS 10 SDK as some properties/class used 
by this PR don't exist in the iOS 9 SDK, e.g. 
[WKWebViewConfiguration.ignoresViewportScaleLimits](https://developer.apple.com/documentation/webkit/wkwebviewconfiguration/2274633-ignoresviewportscalelimits?language=objc)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>Priority: Major
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2018-10-03 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16637075#comment-16637075
 ] 

ASF GitHub Bot commented on CB-7179:


janpio commented on issue #271: CB-7179 (iOS): Add WKWebView support for iOS
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/271#issuecomment-426676178
 
 
   Don't worry - that way I can "abuse" your PR to fix all this stuff ;)
   
   You updated the test configuration from `xcode7.3` to `xcode8.3` - is this 
fully required for this PR? Will people not be able to build with Xcode 7.3 any 
more? (Is Xcode 7.3 related in any way any more?)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>Priority: Major
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2018-10-03 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16637072#comment-16637072
 ] 

ASF GitHub Bot commented on CB-7179:


dpa99c commented on issue #271: CB-7179 (iOS): Add WKWebView support for iOS
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/271#issuecomment-426675930
 
 
   > Ok, I found out _any_ commit will trigger a merge and thus use the updated 
test configuration from `master` - so I did a commit on this branch and am now 
waiting for test results ;)
   
   Thanks Jan - sorry been flat out at work so not had time to look into this


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>Priority: Major
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2018-10-03 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16637059#comment-16637059
 ] 

ASF GitHub Bot commented on CB-7179:


janpio commented on issue #271: CB-7179 (iOS): Add WKWebView support for iOS
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/271#issuecomment-426670960
 
 
   Ok, I found out _any_ commit will trigger a merge and thus use the updated 
test configuration from `master` - so I did a commit on this branch and am now 
waiting for test results ;)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>Priority: Major
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2018-10-01 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16634540#comment-16634540
 ] 

ASF GitHub Bot commented on CB-7179:


janpio edited a comment on issue #271: CB-7179 (iOS): Add WKWebView support for 
iOS
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/271#issuecomment-425728887
 
 
   Simplest answer: 
   Because the testing setup for plugins is all messed up, see a WIP issue 
here: https://github.com/apache/cordova/issues/28
   I am working my way through these, but it is _very_ slow going.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>Priority: Major
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2018-10-01 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16633973#comment-16633973
 ] 

ASF GitHub Bot commented on CB-7179:


janpio edited a comment on issue #271: CB-7179 (iOS): Add WKWebView support for 
iOS
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/271#issuecomment-425896071
 
 
   The test failure was caused by a timeout - the test seemed to need a tiny 
bit more than the 5 minutes that were configured as timeout. As I was working 
on similar problems with Android, I just doubled that for now to 10 minutes. 
Didn't help a thing.
   
   Closer look at the tests on Saucelabs show that there is some code looping: 
https://saucelabs.com/beta/tests/04cc3e87441e4252af89a7587e240d73/commands#12 
No idea what and why (yet).
   
   But:
   You could rebase (hopefully) one last time onto `master`, I have re-enabled 
another iOS test on Travis that was disabled for no good reason and most 
importantly fixed the unrelated Android test(s) that are currently failing here 
as well. At least those should be fixed then.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>Priority: Major
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2018-10-01 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16633954#comment-16633954
 ] 

ASF GitHub Bot commented on CB-7179:


janpio commented on issue #271: CB-7179 (iOS): Add WKWebView support for iOS
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/271#issuecomment-425896071
 
 
   The test failure was caused by a timeout - the test seemed to need a tiny 
bit more than the 5 minutes that were configured as timeout. As I was working 
on similar problems with Android, I just doubled that for now to 10 minutes. 
Didn't help a thing.
   
   Closer look at the tests on Saucelabs show that there is some code looping: 
https://saucelabs.com/beta/tests/04cc3e87441e4252af89a7587e240d73/commands#12 
No idea what and why (yet).
   
   But:
   You could rebase (hopefully) one last time onto `master`, I have re-enabled 
another iOS test on Travis that was disabled for no good reason and most 
importantly fixed the unrelated Android test(s) that are failing here as well.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>Priority: Major
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2018-09-30 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16633404#comment-16633404
 ] 

ASF GitHub Bot commented on CB-7179:


janpio edited a comment on issue #271: CB-7179 (iOS): Add WKWebView support for 
iOS
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/271#issuecomment-425728887
 
 
   Simplest answer: 
   Because the testing setup for plugins is all messed up, see a WIP issue 
here: https://github.com/apache/cordova/issues/36
   I am working my way through these, but it is _very_ slow going.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>Priority: Major
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2018-09-30 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16633403#comment-16633403
 ] 

ASF GitHub Bot commented on CB-7179:


janpio commented on issue #271: CB-7179 (iOS): Add WKWebView support for iOS
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/271#issuecomment-425728887
 
 
   Simplest answer: 
   Because the testing setup for plugins is all messed up, see a WIP issue 
here: https://github.com/apache/cordova/issues/36


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>Priority: Major
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2018-09-30 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16633365#comment-16633365
 ] 

ASF GitHub Bot commented on CB-7179:


dpa99c commented on issue #271: CB-7179 (iOS): Add WKWebView support for iOS
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/271#issuecomment-425718642
 
 
   Unsure why the integration tests are [failing on Travis 
CI](https://user-images.githubusercontent.com/2345062/46257772-26929500-c4b7-11e8-9ea5-fca8ae1ea280.png)
 as they are passing locally: 
   
   https://user-images.githubusercontent.com/2345062/46257772-26929500-c4b7-11e8-9ea5-fca8ae1ea280.png;
 width="480" />
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>Priority: Major
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2018-09-29 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16633072#comment-16633072
 ] 

ASF GitHub Bot commented on CB-7179:


dpa99c commented on issue #271: CB-7179 (iOS): Add WKWebView support for iOS
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/271#issuecomment-425662764
 
 
   @daviesdoclc Yes, unfortunately the [WKHTTPCookieStore 
class](https://developer.apple.com/documentation/webkit/wkhttpcookiestore?language=objc)
 which is required to delete session cookies in WKWebView is only present in 
iOS 11+. Devices running iOS 10 don't have that system class available.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>Priority: Major
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2018-09-27 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16630286#comment-16630286
 ] 

ASF GitHub Bot commented on CB-7179:


daviesdoclc commented on issue #271: CB-7179 (iOS): Add WKWebView support for 
iOS
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/271#issuecomment-425068341
 
 
   @dpa99c Awesome! Unfortunately we still need to support iOS 10 devices for 
now.  I assume it's the target OS and not the SDK that is dictating this.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>Priority: Major
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2018-09-27 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16630224#comment-16630224
 ] 

ASF GitHub Bot commented on CB-7179:


rafaelberrocalj edited a comment on issue #271: CB-7179 (iOS): Add WKWebView 
support for iOS
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/271#issuecomment-422186721
 
 
   Everything looks good and works fine.
   
   One thing i've notice is that the window.alert is not blocking/waiting:
   
   Android: show first alert and stop everything untill i click 'ok' then 
inappbrowser open and second alert block everything untill i click 'ok'.
   iOS: show first alert then inappbrowser open and the second alert is behind 
the inappbrowser. 
   
   Same behavior happens when using events (loadstart/loadstop).
   Android: ok
   iOS: alert is behind inappbrowser
   
   Example (after deviceready):
   ```
   window.alert('test');
   var iap = cordova.inAppBrowser.open('url');
   window.alert('another test');
   iap.addEventListener('loadstart', function(){
  alert('loadstart')
   });
   iap.addEventListener('loadstop', function(){
  alert('loadstop')
   });
   ```
   config.xml
   ```
   https://github.com/dpa99c/cordova-plugin-inappbrowser#CB-7179; />
   
   
  
   
   
   ```
   Build with phonegap-version=cli-8.0.0
   Android Phonegap Version = 7.0.0
   iOS Phonegap Version = 4.5.4
   
   This might be some error or this behavior is expected?
   
   edit: it's working  


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>Priority: Major
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2018-09-27 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16630223#comment-16630223
 ] 

ASF GitHub Bot commented on CB-7179:


rafaelberrocalj edited a comment on issue #271: CB-7179 (iOS): Add WKWebView 
support for iOS
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/271#issuecomment-422866201
 
 
   > 
   > 
   > We have been testing this PR and it is working for us, but we did have to 
deal with local storage migration.
   
   Also "executeScript" seens not being working with localStorage, example:
   
   ```
   var APP = window.APP = window.APP || {};
   
   (function (base) {
"use strict";
   
this.isCordova = !!window.cordova;
this.startUrl = 'https://github.com/apache/cordova-plugin-inappbrowser';
this.appWindow = null;
this.popupConfig = 
'hidden=no,location=no,toolbar=no,zoom=no,hidespinner=yes,usewkwebview=true';
   
this.loadUrl = function () {
   
if (APP.isCordova) {
try {
APP.appWindow = 
cordova.InAppBrowser.open(APP.startUrl, '_blank', APP.popupConfig);
} catch (e) {
alert('ERROR.InAppBrowser:' + 
JSON.stringify(e));
};
} else {
try {
APP.appWindow = window.open(APP.startUrl, 
'_blank', APP.popupConfig);
} catch (e) {
alert('ERROR.open:' + JSON.stringify(e));
};
};
   
alert('appWindoe.typeof:' + (typeof APP.appWindow));
   
if (APP.appWindow) {
APP.appWindow.addEventListener('loadstart', function () 
{
alert('loadstart');
});
   
APP.appWindow.addEventListener('loadstop', function () {
alert('loadstop');
   
APP.appWindow.executeScript({
code: "localStorage.setItem('keyTest', 
'keyValue')"
}, function () {}, function () {
alert('setItem=' + 
JSON.stringify(arguments));
   
APP.appWindow.executeScript({
code: 
"localStorage.getItem('keyTest')"
}, function () {}, function () {
alert('getItem=' + 
JSON.stringify(arguments)); //should print something with "keyValue" but prints 
""
   
});
});
   
});
   
APP.appWindow.addEventListener('loaderror', function () 
{
alert('loaderror');
});
   
APP.appWindow.addEventListener('exit', function () {
alert('exit');
});
};
};
   
this.onDeviceReady = function () {
alert('onDeviceReady');
   
try {
APP.loadUrl();
} catch (e) {
alert('ERROR.loadUrl:' + JSON.stringify(e));
};
};
   
var callReady = function () {
try {
APP.onDeviceReady();
} catch (e) {
alert('ERROR.callReady:' + JSON.stringify(e));
};
};
   
var readyTimeout = 3000;
   
if (this.isCordova) {
if (document.addEventListener) {
document.addEventListener('deviceready', function () {
callReady();
}, false);
} else {
setTimeout(function () {
callReady();
}, readyTimeout);
}
} else {
if (window.addEventListener) {
window.addEventListener('load', function () {
callReady();
}, false);
} else {
setTimeout(function () {
callReady();
}, readyTimeout);
};
};
   }).call(window.APP);
   ```
   
   edit: it's working  


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact

[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2018-09-27 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16629969#comment-16629969
 ] 

ASF GitHub Bot commented on CB-7179:


dpa99c commented on issue #271: CB-7179 (iOS): Add WKWebView support for iOS
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/271#issuecomment-425014191
 
 
   @daviesdoclc `clearsessioncache` is now 
[implemented](https://github.com/dpa99c/cordova-plugin-inappbrowser/blob/CB-7179/src/ios/CDVWKInAppBrowser.m#L174)
 on this PR, although note that for WKWebView implementation it only works for 
iOS 11+ (at least I haven't found a way to clear only session cookies in 
WKWebView on iOS 10). CSS and JS injection should work as expected.
   
   FYI I've created [this test app 
project](https://github.com/dpa99c/cordova-plugin-inappbrowser-test/tree/dual_ios_webviews)
 to test the various features.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>Priority: Major
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2018-09-24 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16625866#comment-16625866
 ] 

ASF GitHub Bot commented on CB-7179:


daviesdoclc commented on issue #271: CB-7179 (iOS): Add WKWebView support for 
iOS
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/271#issuecomment-423987053
 
 
   clearsessioncache is a showstopper for me. We require it for our oauth2 
flow. Perhaps we need to rethink whether we should use inappbrowser for the 
purpose, but it sure make loadstop, etc. easier to retrieve token off of. Plus 
we inject css and javascript to make the pages (which we have little control 
over) conform to our app's UI.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>Priority: Major
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2018-09-24 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16625864#comment-16625864
 ] 

ASF GitHub Bot commented on CB-7179:


oclc-mobile-dev removed a comment on issue #271: CB-7179 (iOS): Add WKWebView 
support for iOS
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/271#issuecomment-423986650
 
 
   clearsessioncache is a showstopper for me.  We require it for our oauth2 
flow.  Perhaps we need to rethink whether we should use inappbrowser for the 
purpose, but it sure make loadstop, etc. easier to retrieve token off of.  Plus 
we inject css and javascript to make the pages (which we have little control 
over) conform to our app's UI.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>Priority: Major
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2018-09-24 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16625862#comment-16625862
 ] 

ASF GitHub Bot commented on CB-7179:


oclc-mobile-dev commented on issue #271: CB-7179 (iOS): Add WKWebView support 
for iOS
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/271#issuecomment-423986650
 
 
   clearsessioncache is a showstopper for me.  We require it for our oauth2 
flow.  Perhaps we need to rethink whether we should use inappbrowser for the 
purpose, but it sure make loadstop, etc. easier to retrieve token off of.  Plus 
we inject css and javascript to make the pages (which we have little control 
over) conform to our app's UI.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>Priority: Major
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2018-09-19 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16620977#comment-16620977
 ] 

ASF GitHub Bot commented on CB-7179:


svanzoest commented on issue #271: CB-7179 (iOS): Add WKWebView support for iOS
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/271#issuecomment-422902888
 
 
   > So the websites you display in the InAppBrowser were using local storage, 
which was not there after the switch to WKWebView? How did you solve this 
@svanzoest?
   
   We used https://github.com/MaKleSoft/cordova-plugin-migrate-localstorage 
however that did not migrate the inappbrowser localstorage.  @geeetarguy plans 
to make a PR against that repo so it will migrate inappbrowser localstorage as 
well.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>Priority: Major
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2018-09-19 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16620806#comment-16620806
 ] 

ASF GitHub Bot commented on CB-7179:


rafaelberrocalj commented on issue #271: CB-7179 (iOS): Add WKWebView support 
for iOS
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/271#issuecomment-422866201
 
 
   > 
   > 
   > We have been testing this PR and it is working for us, but we did have to 
deal with local storage migration.
   
   Also "executeScript" seens not being working with localStorage, example:
   
   ```
   var APP = window.APP = window.APP || {};
   
   (function (base) {
"use strict";
   
this.isCordova = !!window.cordova;
this.startUrl = 'https://github.com/apache/cordova-plugin-inappbrowser';
this.appWindow = null;
this.popupConfig = 
'hidden=no,location=no,toolbar=no,zoom=no,hidespinner=yes,usewkwebview=true';
   
this.loadUrl = function () {
   
if (APP.isCordova) {
try {
APP.appWindow = 
cordova.InAppBrowser.open(APP.startUrl, '_blank', APP.popupConfig);
} catch (e) {
alert('ERROR.InAppBrowser:' + 
JSON.stringify(e));
};
} else {
try {
APP.appWindow = window.open(APP.startUrl, 
'_blank', APP.popupConfig);
} catch (e) {
alert('ERROR.open:' + JSON.stringify(e));
};
};
   
alert('appWindoe.typeof:' + (typeof APP.appWindow));
   
if (APP.appWindow) {
APP.appWindow.addEventListener('loadstart', function () 
{
alert('loadstart');
});
   
APP.appWindow.addEventListener('loadstop', function () {
alert('loadstop');
   
APP.appWindow.executeScript({
code: "localStorage.setItem('keyTest', 
'keyValue')"
}, function () {}, function () {
alert('setItem=' + 
JSON.stringify(arguments));
   
APP.appWindow.executeScript({
code: 
"localStorage.getItem('keyTest')"
}, function () {}, function () {
alert('getItem=' + 
JSON.stringify(arguments)); //should print something with "keyValue" but prints 
""
   
});
});
   
});
   
APP.appWindow.addEventListener('loaderror', function () 
{
alert('loaderror');
});
   
APP.appWindow.addEventListener('exit', function () {
alert('exit');
});
};
};
   
this.onDeviceReady = function () {
alert('onDeviceReady');
   
try {
APP.loadUrl();
} catch (e) {
alert('ERROR.loadUrl:' + JSON.stringify(e));
};
};
   
var callReady = function () {
try {
APP.onDeviceReady();
} catch (e) {
alert('ERROR.callReady:' + JSON.stringify(e));
};
};
   
var readyTimeout = 3000;
   
if (this.isCordova) {
if (document.addEventListener) {
document.addEventListener('deviceready', function () {
callReady();
}, false);
} else {
setTimeout(function () {
callReady();
}, readyTimeout);
}
} else {
if (window.addEventListener) {
window.addEventListener('load', function () {
callReady();
}, false);
} else {
setTimeout(function () {
callReady();
}, readyTimeout);
};
};
   }).call(window.APP);
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


>

[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2018-09-19 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16620263#comment-16620263
 ] 

ASF GitHub Bot commented on CB-7179:


janpio commented on issue #271: CB-7179 (iOS): Add WKWebView support for iOS
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/271#issuecomment-422700927
 
 
   So the websites you display in the InAppBrowser were using local storage, 
which was not there after the switch to WKWebView? How did you solve this 
@svanzoest?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>Priority: Major
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2018-09-18 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16619875#comment-16619875
 ] 

ASF GitHub Bot commented on CB-7179:


svanzoest commented on issue #271: CB-7179 (iOS): Add WKWebView support for iOS
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/271#issuecomment-422590225
 
 
   We have been testing this PR and it is working for us, but we did have to 
deal with local storage migration.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>Priority: Major
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2018-09-17 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16618202#comment-16618202
 ] 

ASF GitHub Bot commented on CB-7179:


rafaelberrocalj commented on issue #271: CB-7179 (iOS): Add WKWebView support 
for iOS
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/271#issuecomment-422186721
 
 
   Everything looks good and works fine.
   
   One thing i've notice is that the window.alert is not blocking/waiting:
   
   Android: show first alert and stop everything untill i click 'ok' then 
inappbrowser open and second alert block everything untill i click 'ok'.
   iOS: show first alert then inappbrowser open and the second alert is behind 
the inappbrowser. 
   
   Same behavior happens when using events (loadstart/loadstop).
   Android: ok
   iOS: alert is behind inappbrowser
   
   Example (after deviceready):
   ```
   window.alert('test');
   var iap = cordova.inAppBrowser.open('url');
   window.alert('another test');
   iap.addEventListener('loadstart', function(){
  alert('loadstart')
   });
   iap.addEventListener('loadstop', function(){
  alert('loadstop')
   });
   ```
   config.xml
   ```
   https://github.com/dpa99c/cordova-plugin-inappbrowser#CB-7179; />
   
   
  
   
   
   ```
   Build with phonegap-version=cli-8.0.0
   Android Phonegap Version = 7.0.0
   iOS Phonegap Version = 4.5.4
   
   This might be some error or this behavior is expected?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>Priority: Major
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2018-09-17 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16618012#comment-16618012
 ] 

ASF GitHub Bot commented on CB-7179:


rafaelberrocalj commented on issue #271: CB-7179 (iOS): Add WKWebView support 
for iOS
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/271#issuecomment-422133965
 
 
   Ah ok, i still need to force the use of it.
   Since iOS 12 is out now i thought it was the primary choice.
   Testing :)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>Priority: Major
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2018-09-17 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16617996#comment-16617996
 ] 

ASF GitHub Bot commented on CB-7179:


dpa99c commented on issue #271: CB-7179 (iOS): Add WKWebView support for iOS
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/271#issuecomment-422130207
 
 
   @rafaelberrocalj yes, if you want to use the WKWebView implementation, 
you'll need the WKWebView engine plugin


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>Priority: Major
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2018-09-17 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16617991#comment-16617991
 ] 

ASF GitHub Bot commented on CB-7179:


rafaelberrocalj commented on issue #271: CB-7179 (iOS): Add WKWebView support 
for iOS
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/271#issuecomment-422128475
 
 
   With this changes i still need to use 
https://github.com/apache/cordova-plugin-wkwebview-engine ?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>Priority: Major
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2018-09-17 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16617918#comment-16617918
 ] 

ASF GitHub Bot commented on CB-7179:


NiklasMerz edited a comment on issue #271: CB-7179 (iOS): Add WKWebView support 
for iOS
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/271#issuecomment-422110912
 
 
   You can install the plugin from the branch which this pull request is based 
on via:
   
   `cordova plugin add 
https://github.com/dpa99c/cordova-plugin-inappbrowser#CB-7179`


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>Priority: Major
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2018-09-17 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16617916#comment-16617916
 ] 

ASF GitHub Bot commented on CB-7179:


NiklasMerz commented on issue #271: CB-7179 (iOS): Add WKWebView support for iOS
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/271#issuecomment-422110912
 
 
   Just install the plugin from the branch which this pull request is based on 
via:
   
   `cordova plugin add 
https://github.com/dpa99c/cordova-plugin-inappbrowser#CB-7179`


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>Priority: Major
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2018-09-17 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16617892#comment-16617892
 ] 

ASF GitHub Bot commented on CB-7179:


rafaelberrocalj commented on issue #271: CB-7179 (iOS): Add WKWebView support 
for iOS
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/271#issuecomment-422107711
 
 
   Hi, can i test this pull request somehow in config.xml?
   I know it's possible use a github url/branch but i don't know a pull request.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>Priority: Major
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2018-09-09 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16608633#comment-16608633
 ] 

ASF GitHub Bot commented on CB-7179:


shazron commented on issue #271: CB-7179 (iOS): Add WKWebView support for iOS
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/271#issuecomment-419768395
 
 
   We should update it to test only against the iOS 10 SDK, and make a note of 
it in the release notes, and also bump a minor version at least.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>Priority: Major
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2018-09-09 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16608404#comment-16608404
 ] 

ASF GitHub Bot commented on CB-7179:


dpa99c commented on issue #271: CB-7179 (iOS): Add WKWebView support for iOS
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/271#issuecomment-419703914
 
 
   @shazron you were right - I missed a line from that PR when resolving the 
merge conflict - I've updated this PR branch to correct this and Travis CI 
build is no longer failing because of this.
   
   However, the [Travis job is still 
failing](https://travis-ci.org/apache/cordova-plugin-inappbrowser/jobs/426294527)
 because the tests are building/running against the iOS 9.3 SDK, however the 
new WKWebView implementation [uses some 
properties](https://github.com/dpa99c/cordova-plugin-themeablebrowser/blob/CB-7179/src/ios/CDVWKInAppBrowser.m#L609)
 of the [WKWebViewConfiguration 
class](https://developer.apple.com/documentation/webkit/wkwebviewconfiguration) 
which were only introduced in the iOS 10 SDK, such as 
[ignoresViewportScaleLimits](https://developer.apple.com/documentation/webkit/wkwebviewconfiguration/2274633-ignoresviewportscalelimits).
   Use of these properties is necessary to support options currently supported 
by the UIWebView implementation (`enableviewportscale`, 
`allowinlinemediaplayback`, `mediaplaybackrequiresuseraction `).
   
   Is building against iOS 9 SDK still a mandatory requirement for 
`cordova-plugin-inappbrowser`?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>Priority: Major
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2018-09-08 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16608276#comment-16608276
 ] 

ASF GitHub Bot commented on CB-7179:


shazron commented on issue #271: CB-7179 (iOS): Add WKWebView support for iOS
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/271#issuecomment-419686671
 
 
   @dpa99c Unfortunately the build issue remains, do you have the ability to 
fix it? It might be a merge issue that removed something, not sure what. I 
tested this locally by installing the plugin from your branch and the error is 
still there.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>Priority: Major
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2018-09-08 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16608174#comment-16608174
 ] 

ASF GitHub Bot commented on CB-7179:


dpa99c commented on issue #271: CB-7179 (iOS): Add WKWebView support for iOS
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/271#issuecomment-419665446
 
 
   @shazron This change was added by PR #284 which is present on `master` and I 
have merged into this branch to resolve the merge conflict.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>Priority: Major
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2018-09-08 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16608170#comment-16608170
 ] 

ASF GitHub Bot commented on CB-7179:


janpio commented on issue #271: CB-7179 (iOS): Add WKWebView support for iOS
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/271#issuecomment-419664068
 
 
   (Oh great, I think that is from another PR.)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>Priority: Major
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2018-09-08 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16608131#comment-16608131
 ] 

ASF GitHub Bot commented on CB-7179:


shazron commented on issue #271: CB-7179 (iOS): Add WKWebView support for iOS
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/271#issuecomment-419657448
 
 
   Travis is failing with:
   ```
   
/var/folders/my/m6ynh3bn6tq06h7xr3js0z7rgn/T/tmp-38722rDILqkxoJNN/platforms/ios/HelloCordova/Plugins/cordova-plugin-inappbrowser/CDVUIInAppBrowser.m:255:39:
 error: use of undeclared identifier 'baseWindowLevel'
   
   [tmpWindow setWindowLevel:baseWindowLevel+1];
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>Priority: Major
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2018-09-03 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16602192#comment-16602192
 ] 

ASF GitHub Bot commented on CB-7179:


dpa99c commented on a change in pull request #271: CB-7179 (iOS): Add WKWebView 
support for iOS
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/271#discussion_r214696483
 
 

 ##
 File path: plugin.xml
 ##
 @@ -76,11 +76,31 @@
 
 
 
+
 
 Review comment:
   It just ensures that the default values defined by 
[`pluginInitialize()`](https://github.com/dpa99c/cordova-plugin-inappbrowser/blob/CB-7179/src/ios/CDVInAppBrowser.m#L31)
 are set right away at app startup. 
   I don't remember the exact reason it was needed (it's been a few months 
since I created this PR) but I'm pretty sure it was necessary.
   The change is minimal and will not cause side effects.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>Priority: Major
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2018-09-03 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16602190#comment-16602190
 ] 

ASF GitHub Bot commented on CB-7179:


dpa99c commented on a change in pull request #271: CB-7179 (iOS): Add WKWebView 
support for iOS
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/271#discussion_r214695523
 
 

 ##
 File path: README.md
 ##
 @@ -136,9 +136,10 @@ instance, or the system browser.
 
 iOS supports these additional options:
 
+- __usewkwebview__: set to `yes` to use WKWebView engine for the 
InappBrowser. Omit or set to `no` (default) to use UIWebView. Note: this 
requires that a WKWebView engine plugin be installed in the Cordova project 
(e.g. 
[cordova-plugin-wkwebview-engine](https://github.com/apache/cordova-plugin-wkwebview-engine)
 or 
[cordova-plugin-ionic-webview](https://github.com/ionic-team/cordova-plugin-ionic-webview)).
 
 Review comment:
   OK, I've made tweaks based on those suggestions


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>Priority: Major
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2018-09-03 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16602152#comment-16602152
 ] 

ASF GitHub Bot commented on CB-7179:


janpio commented on a change in pull request #271: CB-7179 (iOS): Add WKWebView 
support for iOS
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/271#discussion_r214684105
 
 

 ##
 File path: plugin.xml
 ##
 @@ -76,11 +76,31 @@
 
 
 
+
 
 Review comment:
   I learned something, thanks ;)
   
   Why this change? Could this have any side effects?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>Priority: Major
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2018-09-03 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16602151#comment-16602151
 ] 

ASF GitHub Bot commented on CB-7179:


janpio commented on a change in pull request #271: CB-7179 (iOS): Add WKWebView 
support for iOS
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/271#discussion_r214684105
 
 

 ##
 File path: plugin.xml
 ##
 @@ -76,11 +76,31 @@
 
 
 
+
 
 Review comment:
   I learned something, thanks ;)
   
   Why this change?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>Priority: Major
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2018-09-03 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16602148#comment-16602148
 ] 

ASF GitHub Bot commented on CB-7179:


janpio commented on a change in pull request #271: CB-7179 (iOS): Add WKWebView 
support for iOS
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/271#discussion_r214684017
 
 

 ##
 File path: README.md
 ##
 @@ -136,9 +136,10 @@ instance, or the system browser.
 
 iOS supports these additional options:
 
+- __usewkwebview__: set to `yes` to use WKWebView engine for the 
InappBrowser. Omit or set to `no` (default) to use UIWebView. Note: this 
requires that a WKWebView engine plugin be installed in the Cordova project 
(e.g. 
[cordova-plugin-wkwebview-engine](https://github.com/apache/cordova-plugin-wkwebview-engine)
 or 
[cordova-plugin-ionic-webview](https://github.com/ionic-team/cordova-plugin-ionic-webview)).
 
 Review comment:
   Ah, got it.
   
   2 suggestions:
   1. Change "this" in the note to "Using `usewkwebview=yes` requires ..."
   2. Change the `loaderror` callback to not refer to the specific plugin, but 
just mention "... but no plugin that supplies a WKWebView engine present" (or 
similar)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>Priority: Major
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2018-09-03 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16602139#comment-16602139
 ] 

ASF GitHub Bot commented on CB-7179:


dpa99c commented on a change in pull request #271: CB-7179 (iOS): Add WKWebView 
support for iOS
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/271#discussion_r214682563
 
 

 ##
 File path: plugin.xml
 ##
 @@ -76,11 +76,31 @@
 
 
 
+
 
 Review comment:
   `onload` specifies whether to initialize the plugin when the app controller 
initializes. There's some [docs about it 
here](https://cordova.apache.org/docs/en/latest/config_ref/index.html#feature).
   It ensures that 
[`pluginInitialize()`](https://github.com/dpa99c/cordova-plugin-inappbrowser/blob/CB-7179/src/ios/CDVInAppBrowser.m#L31)
 is called on app startup, rather than the first plugin invocation.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>Priority: Major
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2018-09-03 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16602127#comment-16602127
 ] 

ASF GitHub Bot commented on CB-7179:


dpa99c commented on a change in pull request #271: CB-7179 (iOS): Add WKWebView 
support for iOS
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/271#discussion_r214681185
 
 

 ##
 File path: README.md
 ##
 @@ -136,9 +136,10 @@ instance, or the system browser.
 
 iOS supports these additional options:
 
+- __usewkwebview__: set to `yes` to use WKWebView engine for the 
InappBrowser. Omit or set to `no` (default) to use UIWebView. Note: this 
requires that a WKWebView engine plugin be installed in the Cordova project 
(e.g. 
[cordova-plugin-wkwebview-engine](https://github.com/apache/cordova-plugin-wkwebview-engine)
 or 
[cordova-plugin-ionic-webview](https://github.com/ionic-team/cordova-plugin-ionic-webview)).
 
 Review comment:
   If `usewkwebview=yes` and no WKWebView plugin is installed, [the `loaderror` 
callback will be 
invoked](https://github.com/dpa99c/cordova-plugin-inappbrowser/blob/CB-7179/src/ios/CDVInAppBrowser.m#L48)
 with the error message "usewkwebview option specified but 
cordova-plugin-wkwebview-engine not present"
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>Priority: Major
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2018-09-03 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16602121#comment-16602121
 ] 

ASF GitHub Bot commented on CB-7179:


janpio commented on a change in pull request #271: CB-7179 (iOS): Add WKWebView 
support for iOS
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/271#discussion_r214673605
 
 

 ##
 File path: plugin.xml
 ##
 @@ -76,11 +76,31 @@
 
 
 
+
 
 Review comment:
   What does this `onload` param do? Couldn't find it anywhere else.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>Priority: Major
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2018-09-03 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16602120#comment-16602120
 ] 

ASF GitHub Bot commented on CB-7179:


janpio commented on a change in pull request #271: CB-7179 (iOS): Add WKWebView 
support for iOS
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/271#discussion_r214673605
 
 

 ##
 File path: plugin.xml
 ##
 @@ -76,11 +76,31 @@
 
 
 
+
 
 Review comment:
   What does this `onload` param do?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>Priority: Major
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2018-09-03 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16602119#comment-16602119
 ] 

ASF GitHub Bot commented on CB-7179:


janpio commented on a change in pull request #271: CB-7179 (iOS): Add WKWebView 
support for iOS
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/271#discussion_r214673155
 
 

 ##
 File path: README.md
 ##
 @@ -136,9 +136,10 @@ instance, or the system browser.
 
 iOS supports these additional options:
 
+- __usewkwebview__: set to `yes` to use WKWebView engine for the 
InappBrowser. Omit or set to `no` (default) to use UIWebView. Note: this 
requires that a WKWebView engine plugin be installed in the Cordova project 
(e.g. 
[cordova-plugin-wkwebview-engine](https://github.com/apache/cordova-plugin-wkwebview-engine)
 or 
[cordova-plugin-ionic-webview](https://github.com/ionic-team/cordova-plugin-ionic-webview)).
 
 Review comment:
   What will happen if no WKWebView plugin is installed?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>Priority: Major
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2018-09-03 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16602098#comment-16602098
 ] 

ASF GitHub Bot commented on CB-7179:


dpa99c commented on issue #271: CB-7179 (iOS): Add WKWebView support for iOS
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/271#issuecomment-418098522
 
 
   I have done my part and resolved the existing merge conflicts. 
   Hopefully the rest of the steps can follow before more conflicts arise.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>Priority: Major
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2018-09-03 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16602069#comment-16602069
 ] 

ASF GitHub Bot commented on CB-7179:


janpio commented on issue #271: CB-7179 (iOS): Add WKWebView support for iOS
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/271#issuecomment-418090998
 
 
   As soon as 1) @dpa99c had the time to fix the conflicts, 2) someone or 
multiple ones from Apache Cordova (or the community, like you 
@rafaelberrocalj!) had time to test and review (hopefully with Approval), 3) 
then someone from Apache Cordova who takes the responsibility of merging the PR 
and finally 4) someone from Apache Cordova creates a new release of the plugin.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>Priority: Major
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2018-09-03 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16602068#comment-16602068
 ] 

ASF GitHub Bot commented on CB-7179:


rafaelberrocalj commented on issue #271: CB-7179 (iOS): Add WKWebView support 
for iOS
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/271#issuecomment-418090242
 
 
   Hi, any news when this PR will be merged and released into a new version?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>Priority: Major
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2018-08-30 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16597176#comment-16597176
 ] 

ASF GitHub Bot commented on CB-7179:


janpio commented on issue #271: CB-7179 (iOS): Add WKWebView support for iOS
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/271#issuecomment-417232889
 
 
   Just an aside: `master` is being updated mainly because other PRs were 
reviewed and merged.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>Priority: Major
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2018-08-30 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16597175#comment-16597175
 ] 

ASF GitHub Bot commented on CB-7179:


dpa99c commented on issue #271: CB-7179 (iOS): Add WKWebView support for iOS
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/271#issuecomment-417231572
 
 
   @christianliebel 
   > Does “shared cookie pool” mean that the IAB can share cookies with the 
WebView as well? 
   
   Yes, it uses the [CDVWKProcessPoolFactory 
class](https://github.com/apache/cordova-plugin-wkwebview-engine/blob/master/src/ios/CDVWKProcessPoolFactory.m)
 from 
[cordova-plugin-wkwebview-engine](https://github.com/apache/cordova-plugin-wkwebview-engine)
 in order to share cookies between the Cordova app Webview and the IAB Webview 
so setting a cookie in one makes it available in the other. This is currently 
enabled by default, but could be made optional.
   
   > Unfortunately, there are new merge conflicts…
   
   Since the master branch is being continually updated, this PR branch will 
undoubtedly get out of sync with it. But there's no point in me continually 
resolving merge conflicts if this PR is never going to be reviewed/merged.
   
   @shazron If `cordova-plugin-wkwebview-engine` is integrated into 
`cordova-ios@5`, maybe it would make sense to align this PR with 
`cordova-ios@5`?
   
   This would eliminate the need for the `__has_include` Objective-C macro 
which is used to detect the conditional presence of the 
`cordova-plugin-wkwebview-engine` classes in the build, but which only appears 
to work in the device environment so is currently causing the Travis CI build 
to fail due to tests failing in the Simulator.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>Priority: Major
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2018-08-30 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16597115#comment-16597115
 ] 

ASF GitHub Bot commented on CB-7179:


christianliebel commented on issue #271: CB-7179 (iOS): Add WKWebView support 
for iOS
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/271#issuecomment-417209574
 
 
   @dpa99c Does “shared cookie pool” mean that the IAB can share cookies with 
the WebView as well? Unfortunately, there are new merge conflicts…
   
   @shazron Do you have any plans on when this should be merged?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>Priority: Major
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2018-07-17 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16547124#comment-16547124
 ] 

ASF GitHub Bot commented on CB-7179:


dpa99c commented on issue #271: CB-7179 (iOS): Add WKWebView support for iOS
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/271#issuecomment-405733131
 
 
   @shazron I've resolved the merge conflicts and rebased to a single commit. 
   Hopefully you have time to review before more conflicts arise with new 
commits to master.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>Priority: Major
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2018-07-16 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16544842#comment-16544842
 ] 

ASF GitHub Bot commented on CB-7179:


shazron commented on issue #271: CB-7179 (iOS): Add WKWebView support for iOS
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/271#issuecomment-405157260
 
 
   Sorry for the late review. Could you resolve the conflicts before review? 
Thanks!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>Priority: Major
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2018-06-07 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16504416#comment-16504416
 ] 

ASF GitHub Bot commented on CB-7179:


dpa99c commented on issue #271: CB-7179 (iOS): Add WKWebView support for iOS
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/271#issuecomment-395340508
 
 
   @infil00p @stevengill @agrieve @shazron @purplecabbage Could you guys review 
this when you get a chance?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>Priority: Major
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2018-06-07 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16504411#comment-16504411
 ] 

ASF GitHub Bot commented on CB-7179:


dpa99c commented on issue #271: CB-7179 (iOS): Add WKWebView support for iOS
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/271#issuecomment-395338674
 
 
   Travis CI build is failing because, as noted above, __has_include macro 
appears to only work in the device environment, so fails when Travis spins up 
the iOS Simulator  


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>Priority: Major
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2018-06-07 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16504412#comment-16504412
 ] 

ASF GitHub Bot commented on CB-7179:


dpa99c commented on issue #271: CB-7179 (iOS): Add WKWebView support for iOS
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/271#issuecomment-395338674
 
 
   Travis CI build is failing because, as noted above, the `__has_include` 
macro appears to only work in the device environment, so fails when Travis 
spins up the iOS Simulator  


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>Priority: Major
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2018-06-06 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16503454#comment-16503454
 ] 

ASF GitHub Bot commented on CB-7179:


dpa99c opened a new pull request #271: CB-7179 (iOS): Add WKWebView support for 
iOS
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/271
 
 
   ### Platforms affected
   iOS
   
   
   ### What does this PR do?
   This PR adds support for WKWebView to the InappBrowser plugin on iOS. 
   It:
   - builds on the initial work done by [Shazron](https://github.com/shazron) 
on the [wkwebview 
branch](https://github.com/apache/cordova-plugin-inappbrowser/tree/wkwebview) 
branch.
   - takes on feedback from #245
   - contains some major changes, but with [UIWebView now deprecated in iOS 
12](https://developer.apple.com/documentation/uikit/uiwebview?changes=_6=objc),
 then getting this plugin to support WKWebView seems now to be a higher 
priority.
   
   Additional changes in this PR include:
   
   - Separate UIWebView and WKWebView implementations which are invoked by an 
intermediate dispatcher dependent on the `usewkwebview` option.
   - Adds shared cookie pool via CDVWKProcessPoolFactory, enabling app Webview 
to share cookies with IAB Webviews (pulled from [Niklas 
Merz](https://github.com/NiklasMerz/cordova-plugin-inappbrowser/tree/add-webview))
   - Implements WKWebView delegates to make event handlers and script injection 
work
   - Replaces iframe bridge with WKScriptMessageHandler bridge
   - Updates the automated and manual tests for this plugin to test both 
webview implementations when running on iOS.
   
   
   Any feedback/suggestions/bug reports/collaboration to improve the 
implementation in this PR would be most welcome.
   
   ### What testing has been done on this change?
   The automated and manual tests have been run as [outlined 
here](https://github.com/apache/cordova-plugin-inappbrowser/blob/master/CONTRIBUTING.md#running-plugin-tests)
 and all tests appear to pass for the iOS platform against both webview 
implementations.
   
   Note: other platforms have not been tested because they have not been 
changed.
   
   ### Notes
   
   - A restructure of the native iOS implementation was necessary in order to 
enable the UIWebView and WKWebView implementations to exist side-by-side.
   - No dependency has been added on 
[cordova-plugin-wkwebview-engine](https://github.com/apache/cordova-plugin-wkwebview-engine)
 for the iOS platform
- If `usewkwebview=yes` is set and the WKWebView engine classes don't 
exist in the project, the 'loaderror' callback will be invoked when attempting 
to call `InappBrowser.open()`. 
- Conditional pre-processor statements [are 
used](https://github.com/dpa99c/cordova-plugin-inappbrowser/blob/CB-7179/src/ios/CDVInAppBrowser.m#L36)
 to detect the presence of WKWebViewEngine classes at build time to prevent 
build errors if not present
- Note: the [__has_include 
macro](https://clang.llvm.org/docs/LanguageExtensions.html#include-file-checking-macros)
 appears to only work in the device environment.
- On the iOS Simulator it always evaluates to false.
- This means the WKWebView implementation only works on 
devices - on the Simulator `usewkwebview=yes` will result in a `loaderror`.
- The same classes exist in 
[cordova-plugin-ionic-webview](https://github.com/ionic-team/cordova-plugin-ionic-webview)
 as in `cordova-plugin-inappbrowser` so `usewkwebview=yes` will work with both.
   - There is currently a fair bit of duplication in the UIWebView vs WKWebView 
implementations. This could be cleaned up with some refactoring using 
inheritance, although this is tricky in Objective-C (not my strongest language).
   - `clearsessioncache` is yet to be implemented in the WKWebView 
implementation. This is because the [httpCookieStore 
interface](https://developer.apple.com/documentation/webkit/wkwebsitedatastore/2881956-httpcookiestore?language=objc)
 was only added in iOS 11 and so to support iOS 10 and below, a different 
mechanism must be used to find and remove session cookies. This is not trivial 
and may not even be possible.
   - The WKWebView implementation was initially developed as a separate 
WKWebView-only version of this plugin: 
[cordova-plugin-inappbrowser-wkwebview](https://github.com/dpa99c/cordova-plugin-inappbrowser-wkwebview)
   - A Cordova test project specifically to test switching between Webview 
implementations can be [found 
here](https://github.com/dpa99c/cordova-plugin-inappbrowser-test/tree/dual_ios_webviews).
   
   ### Checklist
   - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
   - https://issues.apache.org/jira/browse/CB-7179
   - [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID &

[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2018-06-05 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16501398#comment-16501398
 ] 

ASF GitHub Bot commented on CB-7179:


dpa99c commented on issue #245: CB-7179 (iOS): Finish off WKWebView 
implementation
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/245#issuecomment-394606089
 
 
   @infil00p UIWebView deprecated on iOS 12 - OK, time to revive this.
   
   I'll see if I can put together a dual implementation which enables you to 
switch between UIWebView and WKWebView in IAB. I should be able to make that PR 
against master since it will be suitable for mainstream release.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>Priority: Major
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2018-04-17 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16441806#comment-16441806
 ] 

ASF GitHub Bot commented on CB-7179:


infil00p commented on issue #245: CB-7179 (iOS): Finish off WKWebView 
implementation
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/245#issuecomment-382232859
 
 
   @dpa99c We didn't see this comment on the closed commit until someone 
pointed this out on the vote thread.  If you could modify it to conditionally 
switch, that would make it easier, but I'm also not the authority on iOS (I've 
only recently been starting to triage the iOS issues).  I would send the PR as 
is for discussion, or start a discussion on the dev list about this.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>Priority: Major
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2018-04-17 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16441804#comment-16441804
 ] 

ASF GitHub Bot commented on CB-7179:


infil00p commented on issue #245: CB-7179 (iOS): Finish off WKWebView 
implementation
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/245#issuecomment-382232859
 
 
   @dpa99c We didn't see this comment on the closed commit until someone 
pointed this out on the vote thread.  If you could modify it to conditionally 
switch, that would make it easier, but I'm also not the authority on iOS.  I 
would send the PR as is for discussion, or start a discussion on the dev list 
about this.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>Priority: Major
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2018-01-18 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16330262#comment-16330262
 ] 

ASF GitHub Bot commented on CB-7179:


dpa99c commented on issue #245: CB-7179 (iOS): Finish off WKWebView 
implementation
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/245#issuecomment-358581115
 
 
   @infil00p @stevengill @agrieve @shazron @purplecabbage How should I proceed 
with this?
   
   I have a fork of this plugin as 
[cordova-plugin-inappbrowser-wkwebview](https://github.com/dpa99c/cordova-plugin-inappbrowser-wkwebview)
 which implements WKWebview for the InappBrowser for iOS.
   It's fairly battle-hardened now as it's being used by around 1/4 million 
users per month (both Android & iOS) in production apps.
   
   The implementation is based on @shazron's 
[apache/wkwebview](https://github.com/apache/cordova-plugin-inappbrowser/tree/wkwebview)
 branch from 2014, but I've committed it against a fork of 
[apache/master](https://github.com/apache/cordova-plugin-inappbrowser/tree/master)
 since this is much more update-to-date with respect to other platforms than 
[apache/wkwebview](https://github.com/apache/cordova-plugin-inappbrowser/tree/wkwebview).
   
   The current implementation drops support for the UIWebView implementation in 
favour of WKWebView, so relies on `cordova-plugin-wkwebview-engine` to be 
present in the project. 
   Should I attempt to modify it to conditionally switch between the UIWebView 
and WKWebView implementations based on the presence of 
`cordova-plugin-wkwebview-engine`? 
   I think it may be a fair amount of work to do this though...


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>Priority: Major
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2018-01-17 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16329273#comment-16329273
 ] 

ASF GitHub Bot commented on CB-7179:


dpa99c commented on issue #245: CB-7179 (iOS): Finish off WKWebView 
implementation
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/245#issuecomment-358416278
 
 
   @infil00p The [original apache/wkwebview 
branch](https://github.com/apache/cordova-plugin-inappbrowser/tree/wkwebview) 
that I made as the merge target was last updated by @shazron in 2014, so is 
majorly out of date with respect to 
[apache/master](https://github.com/apache/cordova-plugin-inappbrowser/tree/master).
 So my `dpa99c/wkwebview` fork is based on `apache/master` at the time the PR 
was created.
   
   Would you rather I fork the current `apache/master` and apply my WKWebView 
changes to that?
   Because applying them to the 2014 `apache/wkwebview` doesn't seem that 
useful...


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>Priority: Major
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2018-01-17 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16329199#comment-16329199
 ] 

ASF GitHub Bot commented on CB-7179:


infil00p commented on issue #245: CB-7179 (iOS): Finish off WKWebView 
implementation
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/245#issuecomment-358406390
 
 
   This needs to be cleaned up, since there's too many commits from other 
people in this PR.  Can you do this PR again, this time with just the code that 
you authored in the PR?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>Priority: Major
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2017-09-27 Thread Dave Alden (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16182638#comment-16182638
 ] 

Dave Alden commented on CB-7179:


[~shazron] Here's the pull request. 
It brings your 2014 wkwebview branch up-to-date with master with respect to 
other platforms and of course finishes off the implementation of iOS to use 
WKWebView.

> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2017-09-27 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16182628#comment-16182628
 ] 

ASF GitHub Bot commented on CB-7179:


GitHub user dpa99c opened a pull request:

https://github.com/apache/cordova-plugin-inappbrowser/pull/245

CB-7179 (iOS): Finish off WKWebView implementation




### Platforms affected
iOS


### What does this PR do?
This PR builds on the initial work done by 
[Shazron](https://github.com/shazron) in 
https://github.com/apache/cordova-plugin-inappbrowser/tree/wkwebview:

- Adds shared cookie pool via CDVWKProcessPoolFactory, enabling app Webview 
to share cookies with IAB Webviews (pulled from [Niklas 
Merz](https://github.com/NiklasMerz/cordova-plugin-inappbrowser/tree/add-webview))
- Implements WKWebView delegates to make event handlers and script 
injection work
- Replaces iframe bridge with WKScriptMessageHandler bridge
- Adds a dependency on cordova-plugin-wkwebview-engine, since the new 
implementation relies on it to provide a WKWebView.
- Updates other platforms of the wkwebview branch to align with master at 
902427525f896ae80b11cc0061a9e2420a00662d


### What testing has been done on this change?
Run automated tests as [outlined 
here](https://github.com/apache/cordova-plugin-inappbrowser/blob/master/CONTRIBUTING.md#running-plugin-tests).
All tests pass for iOS platform:

https://user-images.githubusercontent.com/2345062/30917703-86c513ac-a394-11e7-8e21-bc642e9df100.png;
 width="300"/>

Note: other platforms not tested because they have not been changed.


### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- https://issues.apache.org/jira/browse/CB-7179
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- CB-7179 (iOS): Rework iOS implementation to use WKWebView instead of 
UIWebView. Adds dependency on cordova-plugin-wkwebview-engine.
- [x] Added automated test coverage as appropriate for this change.
- No additional test coverage needed as no functionality has changed, 
just the implementation.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dpa99c/cordova-plugin-themeablebrowser 
wkwebview

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-inappbrowser/pull/245.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #245


commit ac9c64964e17e66075c8b9170a61916b5ac01acb
Author: SomaticIT 
Date:   2014-07-11T19:43:37Z

Update windows proxy to be both compatible with windows 8 and 8.1

commit ea6a4fc80a2bc5b1cc74964e921df8b367e5876f
Author: SomaticIT 
Date:   2014-07-11T19:48:21Z

Update doc to add Windows 8

commit 6e38667320cda5f5c199a5d6a038a001be491bdd
Author: SomaticIT 
Date:   2014-07-11T19:48:31Z

Update french translation

commit d828197de45f724ad41135c3ca8f0767a0990582
Author: SomaticIT 
Date:   2014-07-11T19:54:25Z

Clean plugin.xml

commit c2c94f315b956a6179d45013b30653b4689ad19d
Author: Tracktl 
Date:   2014-08-05T13:50:49Z

phonegap events supported for _blank target

commit 97e0eac60366fcf22055e7bd23f5bfffe76b7b87
Author: Tracktl 
Date:   2014-08-05T13:53:45Z

inappbrowser _blank target position is fixed

commit 69ca780772b406ab02ec1bd1a8e4dca70052e926
Author: Archana Naik 
Date:   2014-08-14T18:57:00Z

amazon-fireos related changes.

commit 315a0e30db3639a16bbf989bab49d71b5e1cf283
Author: Piotr Zalewa 
Date:   2014-08-26T11:49:51Z

Merge remote-tracking branch 'machard/fixed_position'

commit 2c018a34609d99cb6557c9acf80a7ce41eab58f3
Author: Piotr Zalewa 
Date:   2014-08-27T11:48:50Z

Merge remote-tracking branch 'machard/events_suppport'

commit 683937872dbe9bfb002ed032d5d2c9505fe63830
Author: Staci Cooper 
Date:   2014-07-14T19:21:41Z

CB-7133 port inappbrowser to plugin-test-framework

also added resources and fixed file paths, renamed test dir, added nested 
plugin.xml

github: close 55

commit 81161ebe668a14f87e1ef4b57f2d300a609b9a8b
Author: Marcel Kinard 
Date:   2014-08-27T18:11:43Z

Add just a bit more logging

commit 4f957919c76205e33569c11f0cd71555c9166ec8
Author: Marcel Kinard 
Date:   2014-08-27T19:56:46Z

CB-7133 fix up the tests for Android

- move the resources

[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2017-09-10 Thread Dave Alden (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16160433#comment-16160433
 ] 

Dave Alden commented on CB-7179:


Yes, I will put together a PR. My aim has been not to change the plugin 
functionality, just the implementation.
Main changes are obviously it now depends on cordova-plugin-wkwebview-engine 
and drops support for iOS 8 since I've removed the UIWebView implementation 
entirely, rather than conditionally switched it. It will require a good 
regression test and probably contains bugs somewhere. Some of the changes are 
non-obvious and work around issues that may not be immediately obvious, so I'm 
happy to further comment the code if that helps.

> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2017-09-09 Thread Niklas Merz (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16159864#comment-16159864
 ] 

Niklas Merz commented on CB-7179:
-

Merging Daves changes back to the original plugin would be really cool. From my 
point of view this is not impossible.

> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2017-09-09 Thread Shazron Abdullah (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16159860#comment-16159860
 ] 

Shazron Abdullah commented on CB-7179:
--

[~dpa99c] any chance you can contrib this back as a PR? Not sure how much it 
has diverged...

> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2017-09-08 Thread Dave Alden (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16158663#comment-16158663
 ] 

Dave Alden commented on CB-7179:


I have fixed the remaining known issues in my fork and published it as 
[cordova-plugin-inappbrowser-wkwebview|https://github.com/dpa99c/cordova-plugin-inappbrowser-wkwebview].

Hopefully it will soon become redundant when cordova-plugin-inappbrowser 
officially switches over to WKWebView.

> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2017-08-14 Thread Dave Alden (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16125372#comment-16125372
 ] 

Dave Alden commented on CB-7179:


I'm continuing to push improvements to [my 
branch](https://github.com/dpa99c/cordova-plugin-themeablebrowser/tree/wkwebview)
 to iron out remaining issues I've found with using WKWebView to power the IAB. 

The issues I'm currently aware of in my branch are:
* on changing device orientation, webview content does not resize to fill page
* closing IAB does not full get rid of webview instance (it still remains 
visible in Safari Web Inspector)
* security warnings due to iframe injection - need to replace this with proper 
WKScriptMessageHandler implementation

> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2017-07-22 Thread Niklas Merz (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16097209#comment-16097209
 ] 

Niklas Merz commented on CB-7179:
-

Dave Alden has taken my simple approach and improved it. I am linking the [pull 
request|https://github.com/NiklasMerz/cordova-plugin-inappbrowser/pull/1#pullrequestreview-51619777]
 here, if someone wants to contribute.

> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2017-07-11 Thread Niklas Merz (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16082447#comment-16082447
 ] 

Niklas Merz commented on CB-7179:
-

Please consider that Cordova itself must also run in WKWebview if the 
ressources like cookies should be shared between Cordova and the plugin.

I have managed to get the InAppBrowser in WKWebview running, but this needs 
some work to make it run like UIWebview did. If I find some time, I could 
propose some changes.

> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

1 2 >

1 - 100 of 108 matches

Mail list logo