Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/1398#issuecomment-161412796
Thanks for you patience. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1398
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1398#issuecomment-161304907
Thanks for your feedback!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r46284474
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/wrappers/StormTuple.java
---
@@ -44,16 +47,32 @@
/** The schema (ie, ordered
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r46284171
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/wrappers/BoltWrapper.java
---
@@ -108,16 +114,13 @@ public BoltWrapper(final
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r46284023
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/wrappers/BoltWrapper.java
---
@@ -89,13 +99,9 @@ public BoltWrapper(final IRichBolt
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/1398#issuecomment-160985940
If Travis is green please merge. You can fix the last tiny comments
directly before merging. No need to update this PR.
---
If your project is set up for it, you can
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r46277213
--- Diff:
flink-contrib/flink-storm/src/test/java/org/apache/flink/storm/wrappers/BoltWrapperTest.java
---
@@ -265,12 +264,12 @@ public void testOpen() throws
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r46278994
--- Diff:
flink-contrib/flink-storm/src/test/java/org/apache/flink/storm/wrappers/WrapperSetupHelperTest.java
---
@@ -193,24 +189,22 @@ public void
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r46279370
--- Diff:
flink-contrib/flink-storm-examples/src/main/java/org/apache/flink/storm/exclamation/ExclamationWithBolt.java
---
@@ -72,7 +71,7 @@ public static void
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r46276898
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/wrappers/WrapperSetupHelper.java
---
@@ -224,7 +224,7 @@ static synchronized
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1398#issuecomment-160982088
I've addressed your comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r46281582
--- Diff:
flink-contrib/flink-storm/src/test/java/org/apache/flink/storm/wrappers/BoltWrapperTest.java
---
@@ -265,12 +264,12 @@ public void testOpen() throws
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r46033582
--- Diff:
flink-contrib/flink-storm-examples/src/main/java/org/apache/flink/storm/exclamation/ExclamationWithBolt.java
---
@@ -72,7 +71,7 @@ public static
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r46033705
--- Diff:
flink-contrib/flink-storm-examples/src/main/java/org/apache/flink/storm/split/SpoutSplitExample.java
---
@@ -70,7 +70,7 @@ public static void
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r46033750
--- Diff:
flink-contrib/flink-storm-examples/src/main/java/org/apache/flink/storm/wordcount/BoltTokenizerWordCount.java
---
@@ -64,7 +63,7 @@ public static
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r46033770
--- Diff:
flink-contrib/flink-storm-examples/src/main/java/org/apache/flink/storm/wordcount/BoltTokenizerWordCountPojo.java
---
@@ -71,7 +70,7 @@ public
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r46033787
--- Diff:
flink-contrib/flink-storm-examples/src/main/java/org/apache/flink/storm/wordcount/BoltTokenizerWordCountWithNames.java
---
@@ -75,7 +74,7 @@ public
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r46034951
--- Diff:
flink-contrib/flink-storm/src/test/java/org/apache/flink/storm/wrappers/WrapperSetupHelperTest.java
---
@@ -193,24 +189,22 @@ public void
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r46035118
--- Diff:
flink-contrib/flink-storm/src/test/java/org/apache/flink/storm/wrappers/BoltWrapperTest.java
---
@@ -265,12 +264,12 @@ public void testOpen() throws
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r46035298
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/wrappers/WrapperSetupHelper.java
---
@@ -224,7 +224,7 @@ static synchronized
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45963943
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/wrappers/SpoutWrapper.java
---
@@ -33,7 +30,8 @@
import
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45963933
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/wrappers/StormTuple.java
---
@@ -44,16 +45,30 @@
/** The schema (ie, ordered
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45964023
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/wrappers/SetupOutputFieldsDeclarer.java
---
@@ -17,12 +17,12 @@
package
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45964241
--- Diff:
flink-contrib/flink-storm/src/test/java/org/apache/flink/storm/api/FlinkOutputFieldsDeclarerTest.java
---
@@ -18,9 +18,7 @@
import
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45964610
--- Diff:
flink-contrib/flink-storm/src/test/java/org/apache/flink/storm/api/FlinkTopologyTest.java
---
@@ -14,50 +14,70 @@
* See the License for the
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45964692
--- Diff:
flink-contrib/flink-storm/src/test/java/org/apache/flink/storm/api/FlinkTopologyTest.java
---
@@ -14,50 +14,70 @@
* See the License for the
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45964776
--- Diff:
flink-contrib/flink-storm/src/test/java/org/apache/flink/storm/api/TestBolt.java
---
@@ -16,14 +16,14 @@
*/
package
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45964866
--- Diff:
flink-contrib/flink-storm/src/test/java/org/apache/flink/storm/util/TestDummySpout.java
---
@@ -26,6 +24,8 @@
import backtype.storm.tuple.Values;
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45964832
--- Diff:
flink-contrib/flink-storm/src/test/java/org/apache/flink/storm/api/TestSpout.java
---
@@ -16,13 +16,13 @@
*/
package
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45964853
--- Diff:
flink-contrib/flink-storm/src/test/java/org/apache/flink/storm/util/TestDummyBolt.java
---
@@ -26,6 +24,8 @@
import backtype.storm.tuple.Tuple;
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45964876
--- Diff:
flink-contrib/flink-storm/src/test/java/org/apache/flink/storm/util/TestSink.java
---
@@ -16,16 +16,16 @@
*/
package
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45965316
--- Diff:
flink-contrib/flink-storm-examples/src/main/java/org/apache/flink/storm/print/PrintSampleStream.java
---
@@ -0,0 +1,61 @@
+/**
+ * Licensed
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45965523
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/wrappers/FlinkTopologyContext.java
---
@@ -27,13 +27,12 @@
import
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45966621
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/api/FlinkOutputFieldsDeclarer.java
---
@@ -20,11 +20,9 @@
import
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45967336
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/wrappers/FlinkTopologyContext.java
---
@@ -27,13 +27,12 @@
import
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45970389
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/wrappers/FlinkTopologyContext.java
---
@@ -27,13 +27,12 @@
import
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45971476
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/wrappers/StormTuple.java
---
@@ -44,16 +45,30 @@
/** The schema (ie, ordered
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45971856
--- Diff:
flink-contrib/flink-storm-examples/src/main/java/org/apache/flink/storm/print/PrintSampleStream.java
---
@@ -0,0 +1,61 @@
+/**
+ * Licensed to
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45892009
--- Diff:
flink-contrib/flink-storm/src/test/java/org/apache/flink/storm/api/FlinkTopologyTest.java
---
@@ -14,50 +14,70 @@
* See the License for the
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45893951
--- Diff:
flink-contrib/flink-storm/src/test/java/org/apache/flink/storm/wrappers/SpoutWrapperTest.java
---
@@ -21,7 +21,6 @@
import
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45885626
--- Diff:
flink-contrib/flink-storm-examples/src/main/java/org/apache/flink/storm/split/operators/VerifyAndEnrichBolt.java
---
@@ -17,8 +17,6 @@
*/
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45885529
--- Diff:
flink-contrib/flink-storm-examples/src/main/java/org/apache/flink/storm/print/PrintSampleStream.java
---
@@ -0,0 +1,61 @@
+/**
+ * Licensed
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45885615
--- Diff:
flink-contrib/flink-storm-examples/src/main/java/org/apache/flink/storm/split/operators/RandomSpout.java
---
@@ -17,9 +17,6 @@
*/
package
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45889473
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/wrappers/BoltCollector.java
---
@@ -19,7 +19,6 @@
import
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45890399
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/wrappers/BoltWrapper.java
---
@@ -108,20 +112,19 @@ public BoltWrapper(final
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45890935
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/wrappers/BoltWrapperTwoInput.java
---
@@ -0,0 +1,130 @@
+/*
+ * Licensed to
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45890996
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/wrappers/FlinkTopologyContext.java
---
@@ -27,13 +27,12 @@
import
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45891069
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/wrappers/SpoutCollector.java
---
@@ -18,7 +18,6 @@
package
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45891019
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/wrappers/SetupOutputFieldsDeclarer.java
---
@@ -17,12 +17,12 @@
package
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45892911
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/api/FlinkTopology.java
---
@@ -15,75 +16,474 @@
* See the License for the
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45894573
--- Diff:
flink-contrib/flink-storm/src/test/java/org/apache/flink/storm/wrappers/StormTupleTest.java
---
@@ -613,29 +611,29 @@ public void
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45886387
--- Diff:
flink-contrib/flink-storm-examples/src/main/java/org/apache/flink/storm/wordcount/WordCountLocal.java
---
@@ -57,16 +57,13 @@ public static void
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45887969
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/api/FlinkOutputFieldsDeclarer.java
---
@@ -20,11 +20,9 @@
import
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r4594
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/api/FlinkTopology.java
---
@@ -15,75 +16,474 @@
* See the License for the
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45890269
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/wrappers/BoltWrapper.java
---
@@ -89,17 +94,16 @@ public BoltWrapper(final IRichBolt
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45891849
--- Diff:
flink-contrib/flink-storm/src/test/java/org/apache/flink/storm/api/FlinkOutputFieldsDeclarerTest.java
---
@@ -18,9 +18,7 @@
import
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45889142
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/api/FlinkTopology.java
---
@@ -15,75 +16,474 @@
* See the License for the
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45889260
--- Diff:
flink-contrib/flink-storm-examples/src/main/java/org/apache/flink/storm/print/PrintSampleStream.java
---
@@ -0,0 +1,61 @@
+/**
+ * Licensed to
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45893753
--- Diff:
flink-contrib/flink-storm/src/test/java/org/apache/flink/storm/api/FlinkTopologyTest.java
---
@@ -14,50 +14,70 @@
* See the License for the
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45893790
--- Diff:
flink-contrib/flink-storm/src/test/java/org/apache/flink/storm/api/TestBolt.java
---
@@ -16,14 +16,14 @@
*/
package
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45894174
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/wrappers/StormTuple.java
---
@@ -44,16 +45,30 @@
/** The schema (ie, ordered
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45886597
--- Diff:
flink-contrib/flink-storm-examples/src/main/java/org/apache/flink/storm/wordcount/operators/WordCountDataPojos.java
---
@@ -17,10 +17,10 @@
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45886536
--- Diff:
flink-contrib/flink-storm-examples/src/main/java/org/apache/flink/storm/wordcount/SpoutSourceWordCount.java
---
@@ -19,7 +19,6 @@
import
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45886615
--- Diff:
flink-contrib/flink-storm-examples/src/main/java/org/apache/flink/storm/wordcount/operators/WordCountFileSpout.java
---
@@ -17,10 +17,9 @@
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45890812
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/wrappers/BoltWrapperTwoInput.java
---
@@ -0,0 +1,130 @@
+/*
+ * Licensed to
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45889838
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/wrappers/BoltWrapper.java
---
@@ -53,21 +51,26 @@
private static final long
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45892746
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/api/FlinkTopology.java
---
@@ -15,75 +16,474 @@
* See the License for the
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45893736
--- Diff:
flink-contrib/flink-storm/src/test/java/org/apache/flink/storm/api/FlinkTopologyTest.java
---
@@ -14,50 +14,70 @@
* See the License for the
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45893853
--- Diff:
flink-contrib/flink-storm/src/test/java/org/apache/flink/storm/util/TestDummySpout.java
---
@@ -26,6 +24,8 @@
import
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45886799
--- Diff:
flink-contrib/flink-storm-examples/src/test/java/org/apache/flink/storm/split/SplitBolt.java
---
@@ -17,8 +17,6 @@
*/
package
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45889924
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/wrappers/BoltWrapper.java
---
@@ -77,11 +80,13 @@
*
* @param bolt
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45890041
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/wrappers/BoltWrapper.java
---
@@ -89,17 +94,16 @@ public BoltWrapper(final IRichBolt
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45891117
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/wrappers/SpoutWrapper.java
---
@@ -33,7 +30,8 @@
import
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45891225
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/wrappers/StormTuple.java
---
@@ -44,16 +45,30 @@
/** The schema (ie, ordered
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45893806
--- Diff:
flink-contrib/flink-storm/src/test/java/org/apache/flink/storm/api/TestSpout.java
---
@@ -16,13 +16,13 @@
*/
package
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45893875
--- Diff:
flink-contrib/flink-storm/src/test/java/org/apache/flink/storm/util/TestSink.java
---
@@ -16,16 +16,16 @@
*/
package
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45893834
--- Diff:
flink-contrib/flink-storm/src/test/java/org/apache/flink/storm/util/TestDummyBolt.java
---
@@ -26,6 +24,8 @@
import backtype.storm.tuple.Tuple;
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45888777
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/api/FlinkTopology.java
---
@@ -15,75 +16,474 @@
* See the License for the
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1398#issuecomment-159641971
I've rebased to the latest master and addressed your comments. I would like
to merge this and programmatically fix the multiple inputs issue afterwards.
---
If your
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45887487
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/api/FlinkLocalCluster.java
---
@@ -99,6 +111,7 @@ public void rebalance(final String
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45890289
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/wrappers/BoltWrapper.java
---
@@ -108,20 +112,19 @@ public BoltWrapper(final
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45895556
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/api/FlinkTopology.java
---
@@ -15,75 +16,474 @@
* See the License for the
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45896492
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/api/FlinkTopology.java
---
@@ -15,75 +16,474 @@
* See the License for the
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45854121
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/wrappers/WrapperSetupHelper.java
---
@@ -150,7 +153,7 @@ static synchronized
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45758926
--- Diff:
flink-contrib/flink-storm/src/test/java/org/apache/flink/storm/wrappers/WrapperSetupHelperTest.java
---
@@ -180,8 +178,6 @@ public void
GitHub user mxm opened a pull request:
https://github.com/apache/flink/pull/1398
[FLINK-2837][storm] various improvements for Storm compatibility
This pull request contains various fixes. Most prominently, the parsing
logic for Storm topologies has been changed to support multiple
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45720083
--- Diff: docs/apis/storm_compatibility.md ---
@@ -57,20 +57,22 @@ See *WordCount Storm* within
`flink-storm-examples/pom.xml` for an example how t
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45740238
--- Diff:
flink-contrib/flink-storm-examples/src/main/java/org/apache/flink/storm/join/SingleJoinExample.java
---
@@ -0,0 +1,86 @@
+/**
+ * Licensed to
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45741402
--- Diff:
flink-contrib/flink-storm-examples/src/main/java/org/apache/flink/storm/join/SingleJoinExample.java
---
@@ -0,0 +1,86 @@
+/**
+ * Licensed to
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45742093
--- Diff:
flink-contrib/flink-storm/src/test/java/org/apache/flink/storm/wrappers/WrapperSetupHelperTest.java
---
@@ -180,8 +178,6 @@ public void
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45740805
--- Diff:
flink-contrib/flink-storm-examples/src/main/java/org/apache/flink/storm/join/SingleJoinExample.java
---
@@ -0,0 +1,86 @@
+/**
+ * Licensed
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45741186
--- Diff:
flink-contrib/flink-storm/src/test/java/org/apache/flink/storm/wrappers/WrapperSetupHelperTest.java
---
@@ -180,8 +178,6 @@ public void
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45743505
--- Diff:
flink-contrib/flink-storm/src/test/java/org/apache/flink/storm/wrappers/WrapperSetupHelperTest.java
---
@@ -180,8 +178,6 @@ public void
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45744427
--- Diff:
flink-contrib/flink-storm/src/test/java/org/apache/flink/storm/wrappers/WrapperSetupHelperTest.java
---
@@ -180,8 +178,6 @@ public void
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45747566
--- Diff:
flink-contrib/flink-storm/src/test/java/org/apache/flink/storm/wrappers/WrapperSetupHelperTest.java
---
@@ -180,8 +178,6 @@ public void
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45725806
--- Diff:
flink-contrib/flink-storm-examples/src/main/java/org/apache/flink/storm/util/FileSpout.java
---
@@ -38,6 +38,8 @@
protected String path =
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45726840
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/wrappers/BoltWrapper.java
---
@@ -75,11 +78,13 @@
*
* @param bolt
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45727399
--- Diff:
flink-contrib/flink-storm/src/test/java/org/apache/flink/storm/wrappers/StormTupleTest.java
---
@@ -595,7 +593,7 @@ public void
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45728796
--- Diff:
flink-contrib/flink-storm-examples/src/main/java/org/apache/flink/storm/util/BoltFileSink.java
---
@@ -40,16 +43,17 @@ public BoltFileSink(final
1 - 100 of 155 matches
Mail list logo
