[
https://issues.apache.org/jira/browse/HBASE-4050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13687480#comment-13687480
]
stack commented on HBASE-4050:
--
whhop!
Update HBase metrics framework to
[
https://issues.apache.org/jira/browse/HBASE-4050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13633523#comment-13633523
]
Enis Soztutar commented on HBASE-4050:
--
Last update indicates that there is still
[
https://issues.apache.org/jira/browse/HBASE-4050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13633531#comment-13633531
]
Elliott Clark commented on HBASE-4050:
--
There's an apache blog post explaining all
[
https://issues.apache.org/jira/browse/HBASE-4050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13459386#comment-13459386
]
Elliott Clark commented on HBASE-4050:
--
One of the patches above was the one that
[
https://issues.apache.org/jira/browse/HBASE-4050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13459368#comment-13459368
]
stack commented on HBASE-4050:
--
What is to be done w/ the patches on this issue? They are
[
https://issues.apache.org/jira/browse/HBASE-4050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13448525#comment-13448525
]
Hudson commented on HBASE-4050:
---
Integrated in HBase-TRUNK #3304 (See
[
https://issues.apache.org/jira/browse/HBASE-4050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13448650#comment-13448650
]
Hudson commented on HBASE-4050:
---
Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #160 (See
[
https://issues.apache.org/jira/browse/HBASE-4050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13442830#comment-13442830
]
Hudson commented on HBASE-4050:
---
Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #151 (See
[
https://issues.apache.org/jira/browse/HBASE-4050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13442838#comment-13442838
]
Hudson commented on HBASE-4050:
---
Integrated in HBase-TRUNK #3286 (See
[
https://issues.apache.org/jira/browse/HBASE-4050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13418354#comment-13418354
]
Alex Baranau commented on HBASE-4050:
-
Ok... Added all implementations, see
[
https://issues.apache.org/jira/browse/HBASE-4050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13417793#comment-13417793
]
Alex Baranau commented on HBASE-4050:
-
Looking at adding MetricSources for Master and
[
https://issues.apache.org/jira/browse/HBASE-4050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13417808#comment-13417808
]
Elliott Clark commented on HBASE-4050:
--
# I would like that, except I think that
[
https://issues.apache.org/jira/browse/HBASE-4050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13417816#comment-13417816
]
Zhihong Ted Yu commented on HBASE-4050:
---
Elliot's first patch used ResourceFinder
[
https://issues.apache.org/jira/browse/HBASE-4050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13417819#comment-13417819
]
Alex Baranau commented on HBASE-4050:
-
Let me try to adjust patch to show what I meant
[
https://issues.apache.org/jira/browse/HBASE-4050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13417922#comment-13417922
]
Elliott Clark commented on HBASE-4050:
--
It took me a little to get the patch to
[
https://issues.apache.org/jira/browse/HBASE-4050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13416543#comment-13416543
]
Zhihong Ted Yu commented on HBASE-4050:
---
Would integrate the patch later this
[
https://issues.apache.org/jira/browse/HBASE-4050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13416592#comment-13416592
]
Alex Baranau commented on HBASE-4050:
-
Should I add metric sources for RegionServer
[
https://issues.apache.org/jira/browse/HBASE-4050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13416599#comment-13416599
]
Zhihong Ted Yu commented on HBASE-4050:
---
How long would it take to align them with
[
https://issues.apache.org/jira/browse/HBASE-4050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13416601#comment-13416601
]
Alex Baranau commented on HBASE-4050:
-
Let me try to do that in coming hour or two. If
[
https://issues.apache.org/jira/browse/HBASE-4050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13416602#comment-13416602
]
Elliott Clark commented on HBASE-4050:
--
Lets do those in another issue. I'm planning
[
https://issues.apache.org/jira/browse/HBASE-4050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13416608#comment-13416608
]
Zhihong Ted Yu commented on HBASE-4050:
---
The above is a nice list.
The title of this
[
https://issues.apache.org/jira/browse/HBASE-4050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13416606#comment-13416606
]
Alex Baranau commented on HBASE-4050:
-
This works too.
I was going to add almost
[
https://issues.apache.org/jira/browse/HBASE-4050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13416628#comment-13416628
]
Elliott Clark commented on HBASE-4050:
--
Doesn't matter to me too much
[
https://issues.apache.org/jira/browse/HBASE-4050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13416653#comment-13416653
]
Elliott Clark commented on HBASE-4050:
--
There. After I saw Ted create the first sub
[
https://issues.apache.org/jira/browse/HBASE-4050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13416661#comment-13416661
]
Alex Baranau commented on HBASE-4050:
-
2Elliott, just to understand:
bq.
[
https://issues.apache.org/jira/browse/HBASE-4050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13416664#comment-13416664
]
Alex Baranau commented on HBASE-4050:
-
bq. After I saw Ted create the first sub task I
[
https://issues.apache.org/jira/browse/HBASE-4050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13416665#comment-13416665
]
Elliott Clark commented on HBASE-4050:
--
# Yes that does for sure.
# When replication
[
https://issues.apache.org/jira/browse/HBASE-4050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13416667#comment-13416667
]
Elliott Clark commented on HBASE-4050:
--
s/pre region/per region/g
[
https://issues.apache.org/jira/browse/HBASE-4050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13416681#comment-13416681
]
Alex Baranau commented on HBASE-4050:
-
Looks to me that we are going to copy-paste
[
https://issues.apache.org/jira/browse/HBASE-4050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13416709#comment-13416709
]
Zhihong Ted Yu commented on HBASE-4050:
---
bq. filing JIRA to allow metrics removals
[
https://issues.apache.org/jira/browse/HBASE-4050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13416736#comment-13416736
]
Elliott Clark commented on HBASE-4050:
--
{code}
CollectionMutableMetric metrics()
[
https://issues.apache.org/jira/browse/HBASE-4050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13413535#comment-13413535
]
stack commented on HBASE-4050:
--
I suppose you don't need to set test size annotation on below
[
https://issues.apache.org/jira/browse/HBASE-4050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13413569#comment-13413569
]
Elliott Clark commented on HBASE-4050:
--
bq.I suppose you don't need to set test size
[
https://issues.apache.org/jira/browse/HBASE-4050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13413872#comment-13413872
]
Hadoop QA commented on HBASE-4050:
--
-1 overall. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-4050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13413945#comment-13413945
]
Elliott Clark commented on HBASE-4050:
--
Test failure looks un-related. Works on my
[
https://issues.apache.org/jira/browse/HBASE-4050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13412550#comment-13412550
]
Hadoop QA commented on HBASE-4050:
--
-1 overall. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-4050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13412721#comment-13412721
]
Lars George commented on HBASE-4050:
Just a question, do we still need to use
[
https://issues.apache.org/jira/browse/HBASE-4050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13412762#comment-13412762
]
stack commented on HBASE-4050:
--
Double license in new pom.
Is it right hardcoding the
[
https://issues.apache.org/jira/browse/HBASE-4050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13413121#comment-13413121
]
Elliott Clark commented on HBASE-4050:
--
bq.Just a question, do we still need to use
[
https://issues.apache.org/jira/browse/HBASE-4050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13413197#comment-13413197
]
Zhihong Ted Yu commented on HBASE-4050:
---
Putting patch on review board would help.
[
https://issues.apache.org/jira/browse/HBASE-4050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13413319#comment-13413319
]
Zhihong Ted Yu commented on HBASE-4050:
---
Latest patch didn't compile against hadoop
[
https://issues.apache.org/jira/browse/HBASE-4050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13413328#comment-13413328
]
Elliott Clark commented on HBASE-4050:
--
I put it up on review board.
[
https://issues.apache.org/jira/browse/HBASE-4050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13413356#comment-13413356
]
Zhihong Ted Yu commented on HBASE-4050:
---
{code}
+public interface BaseMetricsSource
[
https://issues.apache.org/jira/browse/HBASE-4050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13413371#comment-13413371
]
Hadoop QA commented on HBASE-4050:
--
-1 overall. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-4050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13413485#comment-13413485
]
Hadoop QA commented on HBASE-4050:
--
-1 overall. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-4050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13411694#comment-13411694
]
Alex Baranau commented on HBASE-4050:
-
If the above correct/sensible, I'd say I'm for
[
https://issues.apache.org/jira/browse/HBASE-4050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13411693#comment-13411693
]
Alex Baranau commented on HBASE-4050:
-
So, about the shim. Haven't done that kind of
[
https://issues.apache.org/jira/browse/HBASE-4050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13411762#comment-13411762
]
Elliott Clark commented on HBASE-4050:
--
The reflection option seems like it would be
[
https://issues.apache.org/jira/browse/HBASE-4050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13411771#comment-13411771
]
Jonathan Hsieh commented on HBASE-4050:
---
Just a few points of data to help make the
[
https://issues.apache.org/jira/browse/HBASE-4050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13411832#comment-13411832
]
Zhihong Ted Yu commented on HBASE-4050:
---
For option #2, looks like we need some
[
https://issues.apache.org/jira/browse/HBASE-4050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13411846#comment-13411846
]
Elliott Clark commented on HBASE-4050:
--
bq.hbase needs to be recompiled to run
[
https://issues.apache.org/jira/browse/HBASE-4050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13411891#comment-13411891
]
Elliott Clark commented on HBASE-4050:
--
[
https://issues.apache.org/jira/browse/HBASE-4050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13411900#comment-13411900
]
Zhihong Ted Yu commented on HBASE-4050:
---
Good idea.
ServiceLoader is used widely in
[
https://issues.apache.org/jira/browse/HBASE-4050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13411949#comment-13411949
]
Jonathan Hsieh commented on HBASE-4050:
---
bq. bq. hbase needs to be recompiled to run
[
https://issues.apache.org/jira/browse/HBASE-4050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13411952#comment-13411952
]
Luke Lu commented on HBASE-4050:
+1 on Alex's option 2 and ServiceLoader. For HBase we
[
https://issues.apache.org/jira/browse/HBASE-4050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13411963#comment-13411963
]
Elliott Clark commented on HBASE-4050:
--
@Jonathan
Thanks.
@Luke Lu
Unfortunately we
[
https://issues.apache.org/jira/browse/HBASE-4050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13411975#comment-13411975
]
Luke Lu commented on HBASE-4050:
@Elliott: MetricsBuilder/Collector is only needed for
[
https://issues.apache.org/jira/browse/HBASE-4050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13411979#comment-13411979
]
Elliott Clark commented on HBASE-4050:
--
@Luke
Yes. We have per region metrics, per
[
https://issues.apache.org/jira/browse/HBASE-4050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13412456#comment-13412456
]
Alex Baranau commented on HBASE-4050:
-
Heh, was about to commit example with
[
https://issues.apache.org/jira/browse/HBASE-4050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13412457#comment-13412457
]
Alex Baranau commented on HBASE-4050:
-
was about to commit read as was about to
[
https://issues.apache.org/jira/browse/HBASE-4050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13412479#comment-13412479
]
Hadoop QA commented on HBASE-4050:
--
-1 overall. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-4050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13412484#comment-13412484
]
Zhihong Ted Yu commented on HBASE-4050:
---
Amazing work !
ReplicationMetricsSource
[
https://issues.apache.org/jira/browse/HBASE-4050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13412503#comment-13412503
]
Luke Lu commented on HBASE-4050:
ResourceFinder seems to have a few nice properties but do
[
https://issues.apache.org/jira/browse/HBASE-4050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13412509#comment-13412509
]
Elliott Clark commented on HBASE-4050:
--
bq.ReplicationMetricsSource javadoc is to be
[
https://issues.apache.org/jira/browse/HBASE-4050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13412513#comment-13412513
]
Elliott Clark commented on HBASE-4050:
--
bq.ResourceFinder seems to have a few nice
[
https://issues.apache.org/jira/browse/HBASE-4050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13412515#comment-13412515
]
Hadoop QA commented on HBASE-4050:
--
-1 overall. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-4050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13410634#comment-13410634
]
Zhihong Ted Yu commented on HBASE-4050:
---
As Todd pointed out on dev mailing list, we
[
https://issues.apache.org/jira/browse/HBASE-4050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13408615#comment-13408615
]
Zhihong Ted Yu commented on HBASE-4050:
---
The reason Hadoop QA didn't get back was
[
https://issues.apache.org/jira/browse/HBASE-4050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13408675#comment-13408675
]
Alex Baranau commented on HBASE-4050:
-
The problem with building against hadoop 2.0
[
https://issues.apache.org/jira/browse/HBASE-4050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13408679#comment-13408679
]
Alex Baranau commented on HBASE-4050:
-
bq. We can introduce metrics2 package and put
[
https://issues.apache.org/jira/browse/HBASE-4050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13408680#comment-13408680
]
Zhihong Ted Yu commented on HBASE-4050:
---
bq. How soon do you think HBase can leave
[
https://issues.apache.org/jira/browse/HBASE-4050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13408580#comment-13408580
]
Zhihong Ted Yu commented on HBASE-4050:
---
{code}
+++
[
https://issues.apache.org/jira/browse/HBASE-4050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13403999#comment-13403999
]
Alex Baranau commented on HBASE-4050:
-
True!
There's an ongoing effort to sum up all
[
https://issues.apache.org/jira/browse/HBASE-4050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13404060#comment-13404060
]
Zhihong Ted Yu commented on HBASE-4050:
---
bq. the effort of this issue would be just
[
https://issues.apache.org/jira/browse/HBASE-4050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13404269#comment-13404269
]
Zhihong Ted Yu commented on HBASE-4050:
---
The following came from Andy under 'Metrics
[
https://issues.apache.org/jira/browse/HBASE-4050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13403542#comment-13403542
]
Zhihong Ted Yu commented on HBASE-4050:
---
3 weeks flew by :-)
[
https://issues.apache.org/jira/browse/HBASE-4050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13286759#comment-13286759
]
Otis Gospodnetic commented on HBASE-4050:
-
Stack mentioned this is critical for
[
https://issues.apache.org/jira/browse/HBASE-4050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13286763#comment-13286763
]
Zhihong Yu commented on HBASE-4050:
---
@Otis:
It has been 11 months.
Please take this if
[
https://issues.apache.org/jira/browse/HBASE-4050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13286810#comment-13286810
]
Alex Baranau commented on HBASE-4050:
-
I'll try to get to this in 3 weeks (we want
79 matches
Mail list logo
