Re: db-create with PostgreSQL fails with user "user"

2020-05-15 Thread Mads Kiilerich
On 5/15/20 10:08 AM, Louis Bertrand wrote: Hi Thomas, Thanks for the prompt reply but it turns out that it's pilot error. The name 'user' came from my.ini, where the postgresql URL was set to default. After setting the URL correctly sqlalchemy.url =

Re: Pull request hooks

2020-05-06 Thread Mads Kiilerich
On 5/3/20 10:40 AM, Eivind Kvedalen wrote: Hi, I'm trying to integrate Kallithea with an issue tracker, and I would like to get notifications (not email, but something I could create an API request from) when a pull request is created or updated. Are there any hooks available for this

Re: Kallithea changeset: 8188:f8314738030a

2020-04-10 Thread Mads Kiilerich
Hi Thanks - we have queued that fix up after it was mentioned on IRC. The extra spaces have been there "forever" without anybody reporting it, so very weird that you see it now. It would be nice to understand that. Is there anything special in which packages or database you use? /Mads On

Re: Editing files on non-branch-heads

2020-04-08 Thread Mads Kiilerich
On 4/8/20 7:26 PM, Thomas De Schampheleire wrote: When a user starts editing on a head but then a new commit on top of that head is pushed before the user finishes editing, should result in a similar confirmation question as above, I think, and not necessarily a refusal to continue. Sure.

Re: Editing files on non-branch-heads

2020-04-08 Thread Mads Kiilerich
On 4/8/20 4:23 PM, Thomas De Schampheleire wrote: Hi, We noticed that the 'Edit' button on the files interface, e.g. /repo/files/branch/pathtofile.txt is only clickable if you are viewing the file at the tip revision of a branch. We would like to be able to edit a file at a non-tip revision,

Re: Issue with AD Authentication in recent conservancy version

2020-03-06 Thread Mads Kiilerich
ffer' On Thu, Mar 5, 2020 at 11:36 AM Mads Kiilerich <mailto:m...@kiilerich.com>> wrote: I'm not familiar with supervisord. I would expect the print output to show up in your stdout_logfile ... but only after a restart of supervisord (or your Kallithea service). Do you see o

Re: Issue with AD Authentication in recent conservancy version

2020-03-05 Thread Mads Kiilerich
it to print my name as a placeholder, but I'm not seeing this in the stdout file (I'm running kallithea using supervisord).  Is there something else I need to do or add to my.ini? Thanks again On Thu, Mar 5, 2020 at 9:48 AM Mads Kiilerich <mailto:m...@kiilerich.com>> wrote: On 3/

Re: Issue with AD Authentication in recent conservancy version

2020-03-05 Thread Mads Kiilerich
On 3/5/20 4:29 PM, Reuben Popp wrote: Good morning Mads (or afternoon as the case may be where you're at). My apologies that the report was so sparse.  When I wrote it, I was neck deep in the middle of trying to get things set up for our architects to trial Kallithea. Yes, this was the

Re: [PATCH 1 of 1] ui: Add support for 'quick' action icons in repo browser

2020-02-12 Thread Mads Kiilerich
I cherry-picked the "follow" changes and pushed it. Thanks! I will keep considering the other changes, trying to settle on a guiding principle for where which repo settings and actions should be available. /Mads ___ kallithea-general mailing list

Re: [PATCH 0 of 1] Enhancement: Repo browser quick action icons

2020-02-12 Thread Mads Kiilerich
On 2/11/20 8:20 PM, Ross Thomas wrote: On 2/11/20 10:27 AM, Ross Thomas wrote: Looking into it here. Yep. I've been bitten by this before. :-p The onClick handler needs to return the result of the called function. A fix patch is attached for illustration as it affects both this enhancement

Re: [PATCH 0 of 1] Enhancement: Repo browser quick action icons

2020-02-11 Thread Mads Kiilerich
Do you also see the repo list scroll to top when toggling "follow"? /Mads ___ kallithea-general mailing list kallithea-general@sfconservancy.org https://lists.sfconservancy.org/mailman/listinfo/kallithea-general

Re: [PATCH 2 of 2] ui: Add support for extra 'quick' icons in repo browser

2020-02-09 Thread Mads Kiilerich
On 2/8/20 11:10 PM, Ross Thomas wrote: On 2/8/20 7:10 AM, Mads Kiilerich wrote: It would be nice to have more details in the commit message explaining what the intent is, so we don't have to reverse engineer it. We want to review that we are aligned on the intent, and that the change

Re: [PATCH 1 of 2] follow: Fix args for $.post() call in toggleFollowingRepo()

2020-02-09 Thread Mads Kiilerich
On 2/8/20 9:21 PM, Ross Thomas wrote: On 2/8/20 6:05 AM, Mads Kiilerich wrote: Thanks. I do agree this is better. But is it fixing an actual problem? The old manual encoding seems to work fine too? Yep, it worked but it was mostly fortunate 'luck'. It ended up using matrix mode instead

Re: [PATCH 2 of 2] ui: Add support for extra 'quick' icons in repo browser

2020-02-08 Thread Mads Kiilerich
On 2/8/20 2:06 AM, Ross Thomas wrote: # HG changeset patch # User Ross Thomas # Date 1581113799 28800 # Fri Feb 07 14:16:39 2020 -0800 # Branch stable # Node ID 504adebdb50183678de362b52bc89a9c082f4ea7 # Parent f273a7b53fe035c12a55b6a3e34f849af245d797 ui: Add support for extra 'quick'

Re: [PATCH 1 of 2] follow: Fix args for $.post() call in toggleFollowingRepo()

2020-02-08 Thread Mads Kiilerich
On 2/8/20 2:06 AM, Ross Thomas wrote: # HG changeset patch # User Ross Thomas # Date 1581112527 28800 # Fri Feb 07 13:55:27 2020 -0800 # Branch stable # Node ID f273a7b53fe035c12a55b6a3e34f849af245d797 # Parent 2571674c4a2fd6247a6dee7d9b4e27df13df1429 follow: Fix args for $.post() call in

Kallithea on Python 3 has landed

2020-02-05 Thread Mads Kiilerich
After a lot of refactoring, reviews and testing, Python 3 migration has landed on the default development branch on https://kallithea-scm.org/repos/kallithea/ . The migration happens in aa6f17a53b49 to 01aca0a4f876, in a series of minimal and as-reviewable-as-possible steps (temporarily

Re: Logging re-initialized in make_app()

2020-01-10 Thread Mads Kiilerich
On 12/12/19 12:34 AM, Wolfgang Scherer wrote: I finished the analysis of logging initialization (http://sw-amt.ws/kallithea-deploy/html/overview.html#bug-logging-re-initialized-in-make-app). Since I don't think that all the packages will be updated any time soon, I will stay with the minimum

Re: upgrading 0.4.x to 0.5 database error.

2020-01-10 Thread Mads Kiilerich
On 12/24/19 3:08 AM, Ed Wong wrote: But it doesn't seem to affect much as I can still run Kallithea and the ssh does seem to work and not to tempt fate with deleting keys... This should be fixed properly on stable branch wtih

Re: KALLITHEA_EXTRAS environment variable missing

2020-01-10 Thread Mads Kiilerich
On 12/25/19 2:52 AM, Edmund Wong wrote: Mads Kiilerich wrote: On 12/24/19 7:49 AM, Ed Wong wrote: Hi, Just managed to work around the database unicode issue and could both clone and push via the ssh:// url; however, pushing to a git repository gave me the following 'error': Total 3 (delta 1

Re: Logging re-initialized in make_app()

2019-12-29 Thread Mads Kiilerich
On 12/12/19 12:34 AM, Wolfgang Scherer wrote: I finished the analysis of logging initialization (http://sw-amt.ws/kallithea-deploy/html/overview.html#bug-logging-re-initialized-in-make-app). Since I don't think that all the packages will be updated any time soon, I will stay with the minimum

Re: KALLITHEA_EXTRAS environment variable missing

2019-12-28 Thread Mads Kiilerich
On 12/25/19 2:52 AM, Edmund Wong wrote: Mads Kiilerich wrote: On 12/24/19 7:49 AM, Ed Wong wrote: Hi, Just managed to work around the database unicode issue and could both clone and push via the ssh:// url; however, pushing to a git repository gave me the following 'error': Total 3 (delta 1

Kallithea port to Python 3

2019-12-28 Thread Mads Kiilerich
Hi After heavy christmas crunch mode, https://kallithea-scm.org/repos/ is now running on Python 3. It generally works, and the test suite pass. The port is using more than 100 changes that haven't landed yet. The changes can be seen on

Re: KALLITHEA_EXTRAS environment variable missing

2019-12-24 Thread Mads Kiilerich
On 12/24/19 7:49 AM, Ed Wong wrote: Hi, Just managed to work around the database unicode issue and could both clone and push via the ssh:// url; however, pushing to a git repository gave me the following 'error': Total 3 (delta 1), reused 0 (delta 0) remote: Traceback (most recent call last):

Re: upgrading 0.4.x to 0.5 database error.

2019-12-23 Thread Mads Kiilerich
On 12/23/19 4:46 PM, Ed Wong wrote: Hi, I'm running Kallithea 0.4.0 and tried to upgrade to 0.5.0; but at the point of running "alembic -c my_new.ini upgrade", I got the following error: 2019-12-23 15:42:42.575 INFO [alembic.runtime.migration] Running upgrade 151b4a4e8c48 -> 4851d15bc437,

Re: Logging re-initialized in make_app()

2019-12-20 Thread Mads Kiilerich
On 12/4/19 1:36 AM, Wolfgang Scherer wrote: When following the instructions for WSGI dispatch at https://kallithea.readthedocs.io/en/latest/setup.html#apache-with-mod-wsgi any attempt to pass defaults to the logging initialization fails later, when logging is initialized again in

Re: Logging re-initialized in make_app()

2019-12-03 Thread Mads Kiilerich
On 12/4/19 1:36 AM, Wolfgang Scherer wrote: When following the instructions for WSGI dispatch at https://kallithea.readthedocs.io/en/latest/setup.html#apache-with-mod-wsgi any attempt to pass defaults to the logging initialization fails later, when logging is initialized again in

Re: Language file `en` missing

2019-12-03 Thread Mads Kiilerich
On 12/2/19 3:08 AM, Wolfgang Scherer wrote: Is your point that the problem would be fixed by providing an empty kallithea/i18n/en/LC_MESSAGES/kallithea.mo (and building a corresponding .po)? Unfortunately, the translation file cannot be empty. Anything missing in the translation file is

Re: Language file `en` missing

2019-12-01 Thread Mads Kiilerich
On 12/1/19 10:10 PM, Wolfgang Scherer wrote: == Accept-Language bug == If there is no language file `en` installed, kallithea does not handle Accept-Language correctly, when `en` is the prioritized

Re: SSH with ed25519

2019-11-30 Thread Mads Kiilerich
Thanks for reporting ... and for the patch. But do you agree that --- a/kallithea/lib/ssh.py +++ b/kallithea/lib/ssh.py @@ -86,7 +86,7 @@ def parse_pub_key(ssh_key): except binascii.Error: raise SshKeyParseError(_("Incorrect SSH key - failed to decode base64 part %r") % keyvalue)

Re: Issue #349: Setup failed at front-end-build (conservancy/kallithea)

2019-11-19 Thread Mads Kiilerich
On 11/18/19 5:10 PM, Nicolas Pinault wrote: I've had a similar problem when I tried to upgrade one of my my Kallithea instance from V 0.3.3 to V 0.4.1. My server is a RaspberryPi running Raspian jessie. I've found that Raspian version was too old. With a newer version of Raspian (buster), it

Re: [PATCH 1 of 3] scripts: new maintainer script validate-minimum-dependency-versions

2019-10-23 Thread Mads Kiilerich
On 10/22/19 9:23 PM, Thomas De Schampheleire wrote: El mar., 22 oct. 2019 a las 13:01, Mads Kiilerich () escribió: On 10/21/19 10:19 PM, Thomas De Schampheleire wrote: +echo "virtualenv: $venv" +echo "log: $log" + +# clean up previous runs +rm -rf "$venv" &qu

Re: [PATCH 1 of 3] scripts: new maintainer script validate-minimum-dependency-versions

2019-10-22 Thread Mads Kiilerich
On 10/21/19 10:19 PM, Thomas De Schampheleire wrote: # HG changeset patch # User Thomas De Schampheleire # Date 1571684857 -7200 # Mon Oct 21 21:07:37 2019 +0200 # Node ID d13fbe9d0a9e6b59e11cf8c546da66672b087c96 # Parent f00117816704857e610250e3ffca987a745a2284 scripts: new maintainer

Re: npm package-lock.json

2019-09-07 Thread Mads Kiilerich
On 9/4/19 9:14 PM, Thomas De Schampheleire wrote: The recommendation is thus to commit this file to the repository, but I assume it also means we should keep it up-to-date frequently for bugfixes. We already lock package.json at specific versions, so I guess we just as well also could pin

Re: Kallithea as a public repo server ?

2019-08-22 Thread Mads Kiilerich
On 8/22/19 8:46 AM, Nicolas Pinault wrote: Hi, I currently use Kallithea (with Mercurial) at work for private projects on a private network. I do the same at home. I also have personal public repos at Bitbucket (still using Mercurial). As you may know, Bitbucket will drop Mercurial  support

Re: sqlite3.ProgrammingError after upgrade to 4.1 from 3.x

2019-07-31 Thread Mads Kiilerich
On 7/31/19 3:17 PM, Carl Boberg wrote: Thank you I had to change L40 -from kallithea.lib.utils2 import safe_str, generate_api_key, get_current_authuser +from kallithea.lib.utils2 import safe_str, safe_unicode, generate_api_key, get_current_authuser And change L148 (i also changed L150) to

Re: sqlite3.ProgrammingError after upgrade to 4.1 from 3.x

2019-07-31 Thread Mads Kiilerich
On 7/31/19 11:37 AM, Carl Boberg wrote: Hi list! We have been using kallithea for quite a while now and are very happy with it. But recently I have upgraded our two instances from 3.x to 4.1. Latest sqlite version is 3.29.0 . Latest Kallithea version is 0.4.1 . Is that the version you are

Re: apply_to_childen in grant_user_group_permission API is gone?

2019-04-24 Thread Mads Kiilerich
On 4/24/19 6:26 PM, Brandon Jones wrote: I've got a C# API I use for Kallithea and I ran my tests after upgrading and said that the apply_to_children argument for that method was unknown - but I'm fairly confident that it existed before. Perhaps it was just a case of un-helpfully ignoring

Re: apply_to_childen in grant_user_group_permission API is gone?

2019-04-24 Thread Mads Kiilerich
On 4/24/19 5:59 PM, Brandon Jones wrote: I noticed that the API changed and no longer has the option for apply_to_children for this method call. What is the default functionality now?  Before there was the option to apply to no children, repos, groups, or all. It seems like

Re: [PATCH 6 of 6 v3] hooks: use /usr/bin/env only when needed

2019-04-09 Thread Mads Kiilerich
On 4/8/19 10:14 PM, Thomas De Schampheleire wrote: # HG changeset patch # User Thomas De Schampheleire # Date 1554753972 -7200 # Mon Apr 08 22:06:12 2019 +0200 # Branch stable # Node ID d02dee3a34716ea8930e366595e613572a3783e7 # Parent cb33fa0fa1551384df6e2f4ab9ddd00d8567c69d hooks: use

Re: [PATCH 3 of 6 v3] scripts/generate-ini: also allow setting mako variables

2019-04-09 Thread Mads Kiilerich
On 4/8/19 10:14 PM, Thomas De Schampheleire wrote: # HG changeset patch # User Thomas De Schampheleire # Date 1554322593 -7200 # Wed Apr 03 22:16:33 2019 +0200 # Branch stable # Node ID 90f704f5372af599838b4a8171790eeb89c9749f # Parent fa06015a39a0d757790a334207b4066beefee64f

Re: [PATCH 2 of 6 v3] ini: introduce setting 'git_hook_interpreter'

2019-04-09 Thread Mads Kiilerich
On 4/8/19 10:14 PM, Thomas De Schampheleire wrote: # HG changeset patch # User Thomas De Schampheleire # Date 1554751977 -7200 # Mon Apr 08 21:32:57 2019 +0200 # Branch stable # Node ID fa06015a39a0d757790a334207b4066beefee64f # Parent a4ad7b50bab39a528ac147ae3f50791434313127 ini:

Re: [PATCH 3 of 3 v2] hooks: fix potentially invalid interpreter in git hooks (Issue #333)

2019-04-07 Thread Mads Kiilerich
On 4/7/19 9:23 AM, Thomas De Schampheleire wrote: Can we somehow make it show a more useful error message in this case? I guess not - none of our code is executed ... Actually, there is some of our code executed: SimpleGit. But, at that point you don't know

Re: [PATCH 1 of 3 v2] hooks: add intermediate function _get_python_executable

2019-04-06 Thread Mads Kiilerich
On 4/6/19 8:25 PM, Thomas De Schampheleire wrote: El jue., 4 abr. 2019 a las 0:41, Mads Kiilerich (<mailto:m...@kiilerich.com>>) escribió: > @@ -734,11 +738,11 @@ class ScmModel(object): >           if not os.path.isdir(loc): >           

Re: [PATCH 3 of 3 v2] hooks: fix potentially invalid interpreter in git hooks (Issue #333)

2019-04-06 Thread Mads Kiilerich
On 4/6/19 9:22 PM, Thomas De Schampheleire wrote: El jue., 4 abr. 2019 a las 0:41, Mads Kiilerich (<mailto:m...@kiilerich.com>>) escribió: > And pushing to such repo would result in following client errors: > >      $ git push >      Password for 'http:

Re: [PATCH 3 of 3 v2] hooks: fix potentially invalid interpreter in git hooks (Issue #333)

2019-04-03 Thread Mads Kiilerich
On 4/3/19 10:28 PM, Thomas De Schampheleire wrote: # HG changeset patch # User Thomas De Schampheleire # Date 1554323208 -7200 # Wed Apr 03 22:26:48 2019 +0200 # Branch stable # Node ID 0d91f710606b72027456a1183794ee38f26fe741 # Parent 06b511848fb1a3ead56de583e19df5f317bdf7e0 hooks: fix

Re: [PATCH 1 of 3 v2] hooks: add intermediate function _get_python_executable

2019-04-03 Thread Mads Kiilerich
On 4/3/19 10:28 PM, Thomas De Schampheleire wrote: # HG changeset patch # User Thomas De Schampheleire # Date 1554320638 -7200 # Wed Apr 03 21:43:58 2019 +0200 # Branch stable # Node ID 8d7e20c6980cd4e27eeafa15f574d929d836dd76 # Parent 953047e8c88a9c5ccaa4ddc1bb417622de37f01f hooks: add

Re: [PATCH 3 of 3] hooks: fix potentially invalid interpreter in git hooks (Issue #333)

2019-04-01 Thread Mads Kiilerich
On 4/1/19 10:25 PM, Thomas De Schampheleire wrote: # HG changeset patch # User Thomas De Schampheleire # Date 1554150088 -7200 # Mon Apr 01 22:21:28 2019 +0200 # Branch stable # Node ID 83678cb1c0fa84473f686d94867c777c2671632b # Parent 953047e8c88a9c5ccaa4ddc1bb417622de37f01f hooks: fix

Re: [PATCH] scripts/validate-minimum-dependency-versions: new maintainer script

2019-03-25 Thread Mads Kiilerich
On 3/25/19 9:41 PM, Thomas De Schampheleire wrote: # HG changeset patch # User Thomas De Schampheleire # Date 1553546343 -3600 # Mon Mar 25 21:39:03 2019 +0100 # Node ID 3dc609012611ce169b997c40ccad8f4e06fbb792 # Parent a031ce26b19133ecd5c96e85121656bfd760a78b

Re: [PATCH 0 of 8] fixes/updates for 0.4.0

2019-03-18 Thread Mads Kiilerich
On 3/18/19 11:09 PM, Thomas De Schampheleire wrote: Hi, Some fixes for 0.4.0. LGTM, with a couple of comments. /Mads ___ kallithea-general mailing list kallithea-general@sfconservancy.org

Re: [PATCH] docs: hint about creating a new virtual environment for major upgrades

2019-03-17 Thread Mads Kiilerich
On 3/15/19 8:05 PM, Thomas De Schampheleire wrote: El dom., 10 mar. 2019 a las 23:10, Mads Kiilerich () escribió: On 3/10/19 8:59 PM, Thomas De Schampheleire wrote: # HG changeset patch # User Thomas De Schampheleire # Date 1552247908 -3600 # Sun Mar 10 20:58:28 2019 +0100 # Node ID

Re: Kallithea 0.4.0rc1 release candidate

2019-03-17 Thread Mads Kiilerich
Thomas, thanks for helping wrapping this up and preparing the release. /Mads ___ kallithea-general mailing list kallithea-general@sfconservancy.org https://lists.sfconservancy.org/mailman/listinfo/kallithea-general

Re: [PATCH] docs: hint about creating a new virtual environment for major upgrades

2019-03-10 Thread Mads Kiilerich
On 3/10/19 8:59 PM, Thomas De Schampheleire wrote: # HG changeset patch # User Thomas De Schampheleire # Date 1552247908 -3600 # Sun Mar 10 20:58:28 2019 +0100 # Node ID e487f7977a4e452ccdf034afb576f5d88ced1e6f # Parent 9f41dc6f328adc06b71b7304f54a164f955fd056 docs: hint about creating a

Re: Kallithea website is down

2019-01-26 Thread Mads Kiilerich
It is up again /Mads On 1/26/19 7:46 PM, Thomas De Schampheleire wrote: Hello, Seems kallithea-scm.org is down, both for web access as repo pulling. /Thomas ___ kallithea-general mailing list kallithea-general@sfconservancy.org

Re: Pull / push locking - does it have any happy users, or can we drop it?

2019-01-20 Thread Mads Kiilerich
On 1/8/19 5:05 PM, Long Vu wrote: At work we have a rather large repo with many active branches. We are about 50ish dev committing to the same repo. Giving the number of active commit users, that locking feature would have been useful if it can lock only 1 single branch, time to stabilize it

Pull / push locking - does it have any happy users, or can we drop it?

2019-01-06 Thread Mads Kiilerich
Hi Kallithea has some inherited "locking" functionality. Something where a "pull" from the repository will lock it, so nobody else can push until the user that pulled has pushed again. There are good use cases for file locking - especially if tracking unmergeable files like binary assets.

Re: [PATCH] scripts: add developer script validate-commits

2019-01-02 Thread Mads Kiilerich
On 1/2/19 7:52 PM, Thomas De Schampheleire wrote: El lun., 31 dic. 2018 a las 1:53, Mads Kiilerich () escribió: +hg log -r "$rev" +hg update "$rev" + +cleanup +virtualenv -p "$(command -v python2)" "$venv" +source "$venv

Re: [PATCH] scripts: add developer script validate-commits

2018-12-30 Thread Mads Kiilerich
On 12/30/18 8:52 PM, Thomas De Schampheleire wrote: # HG changeset patch # User Thomas De Schampheleire # Date 1546198086 -3600 # Sun Dec 30 20:28:06 2018 +0100 # Node ID 08ccc957e6bc3b170ce2c5db4a63574b51528a79 # Parent 42d4c56ad79c4a492b8bc607aa070de32d9c6073 scripts: add developer

Re: [PATCH 3 of 6] scripts: docs-headings: set HGRCPATH to empty

2018-12-29 Thread Mads Kiilerich
On 12/29/18 10:50 PM, Thomas De Schampheleire wrote: # HG changeset patch # User Thomas De Schampheleire # Date 1546111044 -3600 # Sat Dec 29 20:17:24 2018 +0100 # Node ID 60672272cef36dd45594b607036fb5d7eda5b15c # Parent a7df630cfe21e5e66c555b9fa88ef2c3930870b1 scripts: docs-headings:

Re: [PATCH 2 of 6] scripts: docs-headings: distribute over available CPU cores

2018-12-29 Thread Mads Kiilerich
On 12/29/18 10:50 PM, Thomas De Schampheleire wrote: # HG changeset patch # User Thomas De Schampheleire # Date 1546110972 -3600 # Sat Dec 29 20:16:12 2018 +0100 # Node ID a7df630cfe21e5e66c555b9fa88ef2c3930870b1 # Parent 6caed3c13cb8d631430371b8e1141a724c4c4cae scripts: docs-headings:

Re: [PATCH 1 of 6] .coveragerc: fix reporting of coverage

2018-12-29 Thread Mads Kiilerich
On 12/29/18 10:50 PM, Thomas De Schampheleire wrote: # HG changeset patch # User Thomas De Schampheleire # Date 1546111562 -3600 # Sat Dec 29 20:26:02 2018 +0100 # Node ID 6caed3c13cb8d631430371b8e1141a724c4c4cae # Parent 00fad8894f5173171a7ca8aee523eabdfb80e119 .coveragerc: fix reporting

Re: [PATCH 1 of 6] setup.py: allow Paste 3.0.x

2018-12-29 Thread Mads Kiilerich
On 12/29/18 3:51 PM, Thomas De Schampheleire wrote: (Also, "celery" is just an implementation detail. And a quite complex and fragile one - especially if using rabbitmq. But at our scale, it would probably be better to just use a sql database. And most immportant: Our commands and documentation

Re: [PATCH 1 of 6] setup.py: allow Paste 3.0.x

2018-12-29 Thread Mads Kiilerich
On 12/29/18 2:52 PM, Thomas De Schampheleire wrote: El sáb., 29 dic. 2018 a las 0:58, Mads Kiilerich () escribió: # HG changeset patch # User Thomas De Schampheleire # Date 1546030612 -3600 # Fri Dec 28 21:56:52 2018 +0100 # Node ID 43b3bbf90a48adfcfb4837655cffee3a939bf48f # Parent

Re: [PATCH 1 of 6] setup.py: allow Paste 3.0.x

2018-12-28 Thread Mads Kiilerich
# HG changeset patch # User Thomas De Schampheleire > # Date 1546030612 -3600 #      Fri Dec 28 21:56:52 2018 +0100 # Node ID 43b3bbf90a48adfcfb4837655cffee3a939bf48f # Parent  445d6875c2eefdd8d10676e761cfe1e82581f78a setup.py: allow Paste 3.0.x My

Re: Some problem of kallithea searching feature.

2018-12-23 Thread Mads Kiilerich
On 12/21/18 3:44 AM, Zhou, Squall (NSB - CN/Qingdao) wrote: Hi All I am a user of Kallithea, it is a great tool which help me to manage my project and review the code of it. However, I meet some problem when I what to search the commits. It always report “An error occurred during search

Re: errors with cloning remote mercurial that's HTTPS based

2018-12-23 Thread Mads Kiilerich
On 12/21/18 10:33 AM, Ed Wong wrote: Yes, I can confirm it works! But when I click on "add", should it not go to the "Cloning Repository... please wait"(or something like that)? It's currently still at the Add Repository page and the page is Loading. Yes, if using "celery", it should switch

Re: errors with cloning remote mercurial that's HTTPS based

2018-12-20 Thread Mads Kiilerich
On 12/21/18 5:52 AM, Ed Wong wrote: Hi, I've followed the Contribution page [1] page and would like to understand what I might be doing wrong. I've set up the 0.3.99 Kallithea (via [1]) and while the dev site isn't https-based, the remote repos that I clone off of do use HTTPS and the code

Re: Clone repo from remote URL fails

2018-12-20 Thread Mads Kiilerich
On 12/12/18 12:58 PM, Mads Kiilerich wrote: On 12/11/18 5:03 PM, Thomas De Schampheleire wrote: El mar., 11 dic. 2018 a las 12:19, Mads Kiilerich () escribió: It's been a while that I tested this, but I wonder if it could be related to a mercurial version? This instance is running 4.7.2

Re: Clone repo from remote URL fails

2018-12-11 Thread Mads Kiilerich
On 12/11/18 10:13 AM, Thomas De Schampheleire wrote: kallithea_1 | File "./kallithea/lib/vcs/backends/hg/repository.py", line 295, in _check_url kallithea_1 | sshpeer(repoui or ui.ui(), url).lookup('tip') kallithea_1 | TypeError: __init__() takes at least 8 arguments (3 given)

Re: [PATCH 0 of 9] remove UI notification feature

2018-12-06 Thread Mads Kiilerich
On 12/6/18 1:02 PM, Thomas De Schampheleire wrote: And we have so much cruft in upgraded databases anyway. I think we either should accept a bit more tech debt there and rely on a future "only preserve schema things we use now" database migration option, or just add a migration step now to drop

Re: [PATCH 4 of 4] cli: front-end-build: generate pygments.css dynamically

2018-11-26 Thread Mads Kiilerich
On 11/26/2018 09:39 PM, Thomas De Schampheleire wrote: El dom., 25 nov. 2018 a las 3:47, Mads Kiilerich () escribió: On 11/22/2018 10:36 PM, Thomas De Schampheleire wrote: diff --git a/kallithea/bin/kallithea_cli_front_end.py b/kallithea/bin/kallithea_cli_front_end.py --- a/kallithea/bin

Re: [PATCH 4 of 4] cli: front-end-build: generate pygments.css dynamically

2018-11-24 Thread Mads Kiilerich
On 11/22/2018 10:36 PM, Thomas De Schampheleire wrote: diff --git a/kallithea/bin/kallithea_cli_front_end.py b/kallithea/bin/kallithea_cli_front_end.py --- a/kallithea/bin/kallithea_cli_front_end.py +++ b/kallithea/bin/kallithea_cli_front_end.py @@ -48,3 +48,9 @@ def

Re: Kallithea feature: notifications: anyone using it?

2018-11-24 Thread Mads Kiilerich
On 11/24/2018 02:52 PM, Thomas De Schampheleire wrote: Hello, So since apart from Long Vu (thanks!) there was no response, I guess that indeed no-one is really using the Notifications feature in the top-right of the web UI? Mads, do you know of any useful uses? What would you say about

Re: [PATCH 2 of 4] cli: fix celery-run usage text

2018-11-24 Thread Mads Kiilerich
For context, this is how it looks on stable branch, before the change to gearbox "broke" it:   $ paster celeryd development.ini -h   Usage: paster celeryd [options] CONFIG_FILE [celeryd options...] Also, looking more into it, it seems like the full_cmd_name proposed previously is the same as

Re: [PATCH 1 of 4] cli: fix celery-run

2018-11-24 Thread Mads Kiilerich
On 11/22/2018 10:36 PM, Thomas De Schampheleire wrote: diff --git a/kallithea/bin/kallithea_cli_celery.py b/kallithea/bin/kallithea_cli_celery.py --- a/kallithea/bin/kallithea_cli_celery.py +++ b/kallithea/bin/kallithea_cli_celery.py @@ -36,4 +36,4 @@ def celery_run(celery_args): from

Re: [PATCH 12 of 14] controllers: align pullrequests.comment with changeset.comment

2018-11-24 Thread Mads Kiilerich
On 11/24/2018 03:07 PM, Thomas De Schampheleire wrote: @@ -672,26 +676,30 @@ class PullrequestsController(BaseRepoCon comment = create_comment( text, status, +revision=revision, pull_request_id=pull_request_id,

Re: [PATCH 12 of 14] controllers: align pullrequests.comment with changeset.comment

2018-11-23 Thread Mads Kiilerich
On 11/22/2018 09:25 PM, Thomas De Schampheleire wrote: El mié., 21 nov. 2018 a las 12:48, Mads Kiilerich () escribió: On 11/20/2018 09:32 PM, Thomas De Schampheleire wrote: # HG changeset patch # User Thomas De Schampheleire # Date 1542402570 -3600 # Fri Nov 16 22:09:30 2018 +0100 # Node

Re: [PATCH 12 of 14] controllers: align pullrequests.comment with changeset.comment

2018-11-21 Thread Mads Kiilerich
On 11/20/2018 09:32 PM, Thomas De Schampheleire wrote: # HG changeset patch # User Thomas De Schampheleire # Date 1542402570 -3600 # Fri Nov 16 22:09:30 2018 +0100 # Node ID 4e6bfd3650ddfaf9d2bfbb166eaaec15f5194135 # Parent abef10c5c0d21af567d76d6ffaf5356cc3c3be81 controllers: align

Re: [PATCH 11 of 14] controllers: pullrequests: comments are always using AJAX

2018-11-21 Thread Mads Kiilerich
On 11/20/2018 09:32 PM, Thomas De Schampheleire wrote: # HG changeset patch # User Thomas De Schampheleire # Date 1542401121 -3600 # Fri Nov 16 21:45:21 2018 +0100 # Node ID abef10c5c0d21af567d76d6ffaf5356cc3c3be81 # Parent 92773b07e1244a8b1896cbf2cfb5941189112bdb controllers:

Re: [PATCH 06 of 14] controllers: forward pullrequests.delete_comment to changeset

2018-11-21 Thread Mads Kiilerich
On 11/20/2018 09:32 PM, Thomas De Schampheleire wrote: # HG changeset patch # User Thomas De Schampheleire # Date 1541709517 -3600 # Thu Nov 08 21:38:37 2018 +0100 # Node ID 7350230aa3578c3fc3a4aff864e35a02eea216e1 # Parent 57b9fe6c7871e1ee74eca9c6723ccc4a9dfd5c77 controllers: forward

Re: [PATCH 09 of 14] controllers: changeset: always allow status changes

2018-11-21 Thread Mads Kiilerich
: always allow status changes Don't disallow status changes on changesets that are part of a pull request and on which the last status change happened via the pull request. This odd restriction was already previously highlighted by Mads Kiilerich as 'RLY?' in commit

Re: [PATCH 00 of 17 v3] Introduction of kallithea-cli command

2018-10-21 Thread Mads Kiilerich
On 10/18/2018 10:49 PM, Thomas De Schampheleire wrote: This series introduces a kallithea-cli command to replace our custom gearbox commands. At the end of this series, the help text will show: Usage: kallithea-cli [OPTIONS] COMMAND [ARGS]... Various commands to set up a Kallithea

Re: [PATCH 4 of 7 WIPv2] cli: convert 'gearbox ishell' into 'kallithea-cli ishell'

2018-10-12 Thread Mads Kiilerich
On 10/12/18 8:32 PM, Thomas De Schampheleire wrote: El mar., 9 oct. 2018 a las 12:02, Mads Kiilerich () escribió: On 10/8/18 9:57 PM, Thomas De Schampheleire wrote: # HG changeset patch # User Thomas De Schampheleire # Date 1538422696 -7200 # Mon Oct 01 21:38:16 2018 +0200 # Node ID

Re: [PATCH 0 of 7 WIPv2] Introduction of kallithea-cli command

2018-10-09 Thread Mads Kiilerich
On 10/8/18 9:57 PM, Thomas De Schampheleire wrote: Hi, This is v2 of the WIP. Thanks. This looks good. I guess I would have applied it if you didn't call it WIP. Now, see if you want to make additional tweaks based on my minor feedback. I look forward to the final non-WIP series. Perhaps

Re: [PATCH 5 of 7 WIPv2] cli: convert 'gearbox celeryd' into 'kallithea-cli celery run'

2018-10-09 Thread Mads Kiilerich
On 10/8/18 9:57 PM, Thomas De Schampheleire wrote: # HG changeset patch # User Thomas De Schampheleire # Date 1538510861 -7200 # Tue Oct 02 22:07:41 2018 +0200 # Node ID 6ecaf9e33bbfa23943b488cc3a24b69dff6ed1c0 # Parent 14d0a7fc45f3c5dd7333d3f93335d5b556e7c4f0 cli: convert 'gearbox

Re: [PATCH 4 of 7 WIPv2] cli: convert 'gearbox ishell' into 'kallithea-cli ishell'

2018-10-09 Thread Mads Kiilerich
On 10/8/18 9:57 PM, Thomas De Schampheleire wrote: # HG changeset patch # User Thomas De Schampheleire # Date 1538422696 -7200 # Mon Oct 01 21:38:16 2018 +0200 # Node ID 14d0a7fc45f3c5dd7333d3f93335d5b556e7c4f0 # Parent 4208df04508892ce4612b0a392345176fe946e6c cli: convert 'gearbox

Re: [PATCH 3 of 3 PoC] cli: convert 'gearbox make-config' to 'kallithea config create'

2018-09-30 Thread Mads Kiilerich
On 9/26/18 9:46 PM, Thomas De Schampheleire wrote: El mié., 26 sept. 2018 a las 13:01, Mads Kiilerich () escribió: On 9/24/18 10:45 PM, Thomas De Schampheleire wrote: # HG changeset patch # User Thomas De Schampheleire # Date 1537821464 -7200 # Mon Sep 24 22:37:44 2018 +0200 # Node ID

Re: [PATCH 2 of 3 PoC] cli: add commands to handle front-end generation

2018-09-30 Thread Mads Kiilerich
On 9/26/18 9:34 PM, Thomas De Schampheleire wrote: Currently implemented CLI is as follows: Nice and helpful overview! kallithea config create kallithea frontend create and the specific commands that 'frontend create' is wrapping: Should the sub-commands perhaps more be seen as

Re: [PATCH 1 of 3 PoC] cli: initial introduction of 'kallithea' command

2018-09-30 Thread Mads Kiilerich
On 9/26/18 9:03 PM, Thomas De Schampheleire wrote: El mié., 26 sept. 2018 a las 13:00, Mads Kiilerich () escribió: One concern could be that this command "isn't Kallithea". Kallithea "itself" must be run from gearbox or another web/wsgi server. That can be confusing. The c

Re: [PATCH] model/scm: fix incorrect reporting of pull from remote git repo

2018-09-29 Thread Mads Kiilerich
On 9/15/18 8:54 PM, Thomas De Schampheleire wrote: # HG changeset patch # User Thomas De Schampheleire # Date 1537037123 -7200 # Sat Sep 15 20:45:23 2018 +0200 # Node ID 4a55032bdb764b5b93dd7d1d1a18c15bc10e273c # Parent d63018164a308f1005c250a284279fe6f15cf8a3 model/scm: fix incorrect

Re: [PATCH 3 of 3 PoC] cli: convert 'gearbox make-config' to 'kallithea config create'

2018-09-26 Thread Mads Kiilerich
On 9/24/18 10:45 PM, Thomas De Schampheleire wrote: # HG changeset patch # User Thomas De Schampheleire # Date 1537821464 -7200 # Mon Sep 24 22:37:44 2018 +0200 # Node ID 3c33619af70545eb9b3cbba585181094df67afbb # Parent b807b1e90e61d2c8c16c5e3ec5978ef7dd7a2d31 cli: convert 'gearbox

Re: [PATCH 1 of 3 PoC] cli: initial introduction of 'kallithea' command

2018-09-26 Thread Mads Kiilerich
On 9/24/18 10:45 PM, Thomas De Schampheleire wrote: # HG changeset patch # User Thomas De Schampheleire # Date 1537819512 -7200 # Mon Sep 24 22:05:12 2018 +0200 # Node ID dd4da443ed94fd93ca09d5f5fd9cf1b2c72b3cc4 # Parent a73e2822dd99eb5bdc551174d9d4f9c76f8f1667 cli: initial introduction

Re: [PATCH 2 of 3 PoC] cli: add commands to handle front-end generation

2018-09-26 Thread Mads Kiilerich
On 9/24/18 10:45 PM, Thomas De Schampheleire wrote: # HG changeset patch # User Thomas De Schampheleire # Date 1537814676 -7200 # Mon Sep 24 20:44:36 2018 +0200 # Node ID b807b1e90e61d2c8c16c5e3ec5978ef7dd7a2d31 # Parent dd4da443ed94fd93ca09d5f5fd9cf1b2c72b3cc4 cli: add commands to handle

Re: Question add GIT extension into depots

2018-09-26 Thread Mads Kiilerich
On 9/25/18 10:45 PM, Paul Borel wrote: Hello, It is possible to add the extension '.git' to repositories ? Can you say more about the rationale and use case for that? It seems like redundant and unnecessary complexity? /Mads ___

Re: [PATCH 4 of 4] setup: add gearbox command to setup front-end

2018-09-22 Thread Mads Kiilerich
On 9/18/18 10:47 PM, Thomas De Schampheleire wrote: In light of this, will you make another iteration of your proposal? I agree that the discussion is interesting and helps exploring which way we should go. However, in practical terms it is still too broad/vague to me as to what to actually

Re: [PATCH 4 of 4] setup: add gearbox command to setup front-end

2018-09-16 Thread Mads Kiilerich
[It seems like I failed to send this some days ago ... here it comes ...] On 09/11/2018 09:34 PM, Thomas De Schampheleire wrote: The approach implemented by this commit is to add a custom gearbox command 'setup-frontend' to run the required commands. This single user-facing command can

Re: erro 500 when delete

2018-09-14 Thread Mads Kiilerich
On 09/14/2018 11:36 AM, Paul Borel wrote: Hello, When I try to delete groups I've got : 500 Internal Server Error La requête n’a pu être traitée en raison d’une erreur survenue sur le serveur. but when I return to the site it deleted There must be further details in the server

Re: Last version of default branch

2018-09-10 Thread Mads Kiilerich
On 09/10/2018 10:36 PM, Paul Borel wrote: Hello, The version last of branch default is 0.3.99 or 0.3.999 ? For me i have the 0.3.99. But see in exemple in the website is 0.3.999 https://kallithea-scm.org/repos/ has a few extra minor changes and the number is slightly different. In

Re: [PATCH 4 of 4] setup: add gearbox command to setup front-end

2018-09-08 Thread Mads Kiilerich
are coming. # HG changeset patch # User Mads Kiilerich This patch seems to only reuse a few trivial lines from me. There is no need to give me credit for this. The approach implemented by this commit is to add a custom gearbox command 'setup-frontend' to run the required commands. This single u

Re: Question of using bootstrap to mobile

2018-09-06 Thread Mads Kiilerich
On 09/06/2018 09:37 PM, Paul Borel wrote: Hello, Did you consider to adapt the UI to be responsive ? The 'default' branch is using Bootstrap, mostly contributed by Dominik. Thomas recently proposed a solution to the big remaining problem of a good way to use Bootstrap from a GPL

Re: question of configuration of repositories

2018-09-06 Thread Mads Kiilerich
th Apache. Thanks Le jeu. 6 sept. 2018 à 12:03, Mads Kiilerich mailto:m...@kiilerich.com>> a écrit : On 09/06/2018 11:44 AM, Paul Borel wrote: Hello, /What Kallithea version are you using? /*0.3.5 * /Exactly where do you see the strange str

<    1   2   3   4   5   6   >