D11290: [UDevManager] Already filter for subsystem before querying

mpyne added a comment. Any reason not to close the bug 391738? I can do so but wanted to make sure it wasn't intentionally left open. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D11290 To: broulik, #frameworks, davidedmundson Cc: mpyne, ngraham, michaelh

D11298: Optimize highlighting Bash, Cisco, Clipper, Coffee, Gap, Haml, Haskell

vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R216 Syntax Highlighting BRANCH ImproveHlRules (branched from master) REVISION DETAIL https://phabricator.kde.org/D11298 To: dhaumann, vkrause, jpoelen Cc: #frameworks, michaelh

D11298: Optimize highlighting Bash, Cisco, Clipper, Coffee, Gap, Haml, Haskell

This revision was automatically updated to reflect the committed changes. Closed by commit R216:cec763566ca4: Optimize highlighting Bash, Cisco, Clipper, Coffee, Gap, Haml, Haskell (authored by dhaumann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

D10621: Highlighting Indexer: list of suggestions

dhaumann added a comment. @jpoelen What would be interesting is to check which optimizations are really an improvement. Because we should either get a significant speed boost (e.g. RegExpr -> WordDetect), or at least reduce memory allocations (possibly StringDetect -> Detect2Chars and

D11298: Optimize highlighting Bash, Cisco, Clipper, Coffee, Gap, Haml, Haskell

dhaumann created this revision. dhaumann added reviewers: vkrause, jpoelen. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. dhaumann requested review of this revision. REVISION SUMMARY These are some of the optimizations of D10621

Re: D11193: Sonnet : use current hunspell API

You should probably add the sonnet maintainer (or whoever committed the most to the repository in recent months) as the reviewer. Cheers, Ivan On Tue, Mar 13, 2018 at 10:26 AM, René J. V. Bertin wrote: > Silence means acceptance? > -- KDE, ivan.cu...@kde.org,

D10749: Add ECMSetupQtPluginMacroNames

kossebau added a comment. Questions had been: A) names of macro and arguments okay? B) other/similar/related use cases which should be covered? C) how to design argument passing for all the arg1, arg2, arg3? Is the currrent approach sane or how to support someone needing some arg5?

D10749: Add ECMSetupQtPluginMacroNames

kossebau retitled this revision from "[RFC] Add ECMSetupQtPluginMacroNames" to "Add ECMSetupQtPluginMacroNames". kossebau edited the summary of this revision. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D10749 To: kossebau, #build_system, #frameworks Cc:

D11296: Use ecm_setup_qtplugin_macro_names

kossebau created this revision. kossebau added a reviewer: Frameworks. Restricted Application added a project: Frameworks. kossebau requested review of this revision. REVISION SUMMARY Avoids all the explicit boilerplate needed and allows code reusing. Depends on D10749

D10749: [RFC] Add ECMSetupQtPluginMacroNames

kossebau added a dependent revision: D11296: Use ecm_setup_qtplugin_macro_names. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D10749 To: kossebau, #build_system, #frameworks Cc: michaelh

D11295: Use ecm_setup_qtplugin_macro_names

apol added a comment. Looks much better! +1 REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D11295 To: kossebau, #plasma, #frameworks Cc: apol, michaelh

D11295: Use ecm_setup_qtplugin_macro_names

kossebau created this revision. kossebau added reviewers: Plasma, Frameworks. Restricted Application added a project: Frameworks. kossebau requested review of this revision. REVISION SUMMARY Avoids all the explicit boilerplate needed and allows code reusing. Depends on D10749

D10749: [RFC] Add ECMSetupQtPluginMacroNames

kossebau added a dependent revision: D11295: Use ecm_setup_qtplugin_macro_names. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D10749 To: kossebau, #build_system, #frameworks Cc: michaelh

D10749: [RFC] Add ECMSetupQtPluginMacroNames

kossebau added a dependent revision: D11294: Use ecm_setup_qtplugin_macro_names. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D10749 To: kossebau, #build_system, #frameworks Cc: michaelh

D11294: Use ecm_setup_qtplugin_macro_names

kossebau created this revision. kossebau added a reviewer: Frameworks. Restricted Application added a project: Frameworks. kossebau requested review of this revision. REVISION SUMMARY Avoids all the explicit boilerplate needed and allows code reusing. Depends on D10749

D10749: [RFC] Add ECMSetupQtPluginMacroNames

kossebau updated this revision to Diff 29426. kossebau added a comment. update with documentation completed REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10749?vs=27805=29426 BRANCH addECMSetupQtPluginMacroNames REVISION DETAIL

Re: Is it possible to mock an external drive (for unit testing)?

On Dienstag, 13. März 2018 15:38:54 CET Michael Heidelbach wrote: > Thanks for your reply, Roman > I also thought of archivemount but (maybe to early) discarded that idea > because for testing I need control over the device id. > I'm not sure how to make identification more reliable either. If I'm

D11290: [UDevManager] Already filter for subsystem before querying

This revision was automatically updated to reflect the committed changes. Closed by commit R245:3b642556c203: [UDevManager] Already filter for subsystem before querying (authored by broulik). REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11290?vs=29416=29417

D11290: [UDevManager] Already filter for subsystem before querying

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D11290 To: broulik, #frameworks, davidedmundson Cc: ngraham, michaelh

D11290: [UDevManager] Already filter for subsystem before querying

broulik updated this revision to Diff 29416. broulik edited the summary of this revision. broulik added a comment. - Check for usb subsystem also in queryDeviceInterface REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11290?vs=29412=29416 REVISION DETAIL

D11290: [UDevManager] Already filter for subsystem before querying

broulik added a comment. In D11290#224807 , @davidedmundson wrote: > If you can prove that property is only valid for USB subsystems, then you can ship it, otherwise, no. From udev code

D6313: WIP: Support device pixel ratio in icon loader and engine

acrouthamel added a comment. Hey there, any movement on this? I've been submitting some patches to fix icon scaling in apps and have noticed how they switch from monochrome to colored (hires) versions when fixed. Getting the underlying issue fixed would be great as more people buy

D11290: [UDevManager] Already filter for subsystem before querying

davidedmundson added a comment. Copying our IRC chat: I tried something /very very/ similar https://phabricator.kde.org/D8495?vs=on=21368=ignore-most#toc which merges queryDeviceInterface into the earlier query. It didn't work. This patch is a bit different, it does a coarse

D11290: [UDevManager] Already filter for subsystem before querying

ngraham added a comment. Cool! Any chance we can add an autotest? Solid's code seems somewhat fragile, judging by the regressions that were accidentally introduced in https://cgit.kde.org/solid.git/commit/?id=1384f275ab2f1ad1841753ee163af6d1b0bb952b REPOSITORY R245 Solid REVISION DETAIL

D11290: [UDevManager] Already filter for subsystem before querying

broulik edited the summary of this revision. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D11290 To: broulik, #frameworks, davidedmundson Cc: ngraham, michaelh

D11290: [UDevManager] Already filter for subsystem before querying

broulik added a comment. It brings the number of sys calls from 28000 down to 860 here using the first grep command in the comment, could have helped somewhat I guess but the second command is completely bogus for me. needs further investigation. It does give a significant speedup which is

D10078: Add separate lib KF5::DBusRunner

davidedmundson marked an inline comment as done. davidedmundson added a comment. If the config modules and runner executables will always be written by the same dev and shipped together I don't think we gain much by trying to generic-ify it. The config writing and reading and syncing

D11290: [UDevManager] Already filter for subsystem before querying

ngraham added a comment. Any chance this fixes https://bugs.kde.org/show_bug.cgi?id=391738? REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D11290 To: broulik, #frameworks, davidedmundson Cc: ngraham, michaelh

D11290: [UDevManager] Already filter for subsystem before querying

broulik created this revision. broulik added reviewers: Frameworks, davidedmundson. Restricted Application added a project: Frameworks. broulik requested review of this revision. REVISION SUMMARY This does some rough filtering in advance before creating our wrapper items with properties and

D11282: less expensive findByUrl in KCoreDirListerCache

mwolff added a comment. have you considered using a hash map instead? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11282 To: jtamate, #frameworks, dfaure Cc: mwolff, michaelh

D10078: Add separate lib KF5::DBusRunner

kossebau added a comment. @davidedmundson Thanks for blowing new life into this patch :) The OO approach sounds nice and good to have, but no chance yet to look in detail. While I had started some local changes following your feedback/proposals, I had stalled further activity as I got

D11244: Fix text scaling with non-integer scale factors when PLASMA_USE_QT_SCALING=1 is set

ngraham added a comment. So this is weird. I thought this patch fixes those KCMs, because I //can/ get them into a fixed state, but it doesn't persist afte4r a reboot. Steps to reproduce: - Start with no scale factor - Open System Settings > Display & Monitor > Display > Scale and

Re: Is it possible to mock an external drive (for unit testing)?

Thanks for your reply, Roman I also thought of archivemount but (maybe to early) discarded that idea because for testing I need control over the device id. I'm not sure how to make identification more reliable either. If I'm able to read the uuid of a drive or partition it would be small enough

D11244: Fix text scaling with non-integer scale factors when PLASMA_USE_QT_SCALING=1 is set

ngraham edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D11244 To: ngraham, #plasma, davidedmundson Cc: mart, broulik, #frameworks, michaelh

D11213: balooctl: Introduce list command

michaelh abandoned this revision. michaelh added a comment. Superseded by D11285 and D11287 REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11213 To: michaelh, #baloo, #frameworks, smithjd Cc:

D11287: Introduce baloodb CLI tool

michaelh created this revision. michaelh added reviewers: Baloo, Frameworks. Restricted Application added projects: Frameworks, Baloo. michaelh requested review of this revision. REVISION SUMMARY This is the command line interface of database sanitizer TEST PLAN Run on command line

D11287: Introduce baloodb CLI tool

michaelh added a dependency: D11285: Introduce sanitizer class. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11287 To: michaelh, #baloo, #frameworks Cc: ashaposhnikov, michaelh, spoorun, nicolasfella, alexeymin

D11244: Fix text scaling with non-integer scale factors when PLASMA_USE_QT_SCALING=1 is set

ngraham updated this revision to Diff 29408. ngraham added a comment. "You missed a spot" REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11244?vs=29366=29408 BRANCH arcpatch-D11244 REVISION DETAIL https://phabricator.kde.org/D11244

D11285: Introduce sanitizer class

michaelh added a dependent revision: D11287: Introduce baloodb CLI tool. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11285 To: michaelh, #baloo, #frameworks Cc: smithjd, ashaposhnikov, michaelh, spoorun, nicolasfella, alexeymin

D11111: Only show supported schemes in KUrlNavigatorProtocolCombo

mart added a comment. +1 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D1 To: broulik, #frameworks Cc: mart, michaelh

D11112: Hide KUrlNavigatorProtocolCombo if there is just one protocol supported

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D2 To: broulik, #frameworks, mart Cc: michaelh

D11285: Introduce sanitizer class

michaelh created this revision. michaelh added reviewers: Baloo, Frameworks. Restricted Application added projects: Frameworks, Baloo. michaelh requested review of this revision. REVISION SUMMARY Due to device ids being inconstant duplicates are introduced to the database. I. e. multiple

KDE CI: Frameworks ktexteditor kf5-qt5 SUSEQt5.9 - Build # 7 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.9/7/ Project: Frameworks ktexteditor kf5-qt5 SUSEQt5.9 Date of build: Tue, 13 Mar 2018 13:36:35 + Build duration: 24 min and counting JUnit Tests

KDE CI: Frameworks ktexteditor kf5-qt5 SUSEQt5.10 - Build # 51 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.10/51/ Project: Frameworks ktexteditor kf5-qt5 SUSEQt5.10 Date of build: Tue, 13 Mar 2018 13:36:35 + Build duration: 17 min and counting JUnit Tests

KDE CI: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.9 - Build # 37 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.9/37/ Project: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.9 Date of build: Tue, 13 Mar 2018 13:36:35 + Build duration: 7 min 35 sec and counting JUnit

D11278: [KateCompletionWidget] Create configuration interface on demand

This revision was automatically updated to reflect the committed changes. Closed by commit R39:92e21fb03b7f: [KateCompletionWidget] Create configuration interface on demand (authored by broulik). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE

Re: Is it possible to mock an external drive (for unit testing)?

I'm not sure how you're gonna to make identification more reliable, but you can use fuse to create mountpoints in user space. E.g. using archievemount you can mount some archive and the files in the mountpoint will have another device id. Fuse must be available on the target OS of course. On Mon,

D11190: Make sure we are taking into account hte size of the element when styling

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R858 Qt Quick Controls 2: Desktop Style BRANCH master REVISION DETAIL https://phabricator.kde.org/D11190 To: apol, #frameworks, mart Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed,

D11279: [FileIndexerConfig] Delay populating folders until actually used

michaelh accepted this revision. michaelh added a comment. This revision is now accepted and ready to land. Ha! Wonderful, this touches a question I raised on kde-devel ML recently. Say we wanted to test this patch. We would need some kind of mock drive, right? I'd very much appreciate if

D11244: Fix text scaling with non-integer scale factors when PLASMA_USE_QT_SCALING=1 is set

mart added a comment. if they're somewhat related but not risolutive for some of those bugs, use CCBUG: instead REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D11244 To: ngraham, #plasma, davidedmundson Cc: mart, broulik, #frameworks, michaelh

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 154 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/154/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Tue, 13 Mar 2018 10:08:38 + Build duration: 1 hr 14 min and counting JUnit Tests Name:

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 25 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/25/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Tue, 13 Mar 2018 09:53:45 + Build duration: 1 hr 20 min and counting JUnit Tests Name: (root)

D11282: less expensive findByUrl in KCoreDirListerCache

jtamate created this revision. jtamate added reviewers: Frameworks, dfaure. Restricted Application added a project: Frameworks. jtamate requested review of this revision. REVISION SUMMARY From O(n) in the worst case to at most Log2(n) + O(1) comparisons. Unfortunately, fetching the files in a

D11278: [KateCompletionWidget] Create configuration interface on demand

cullmann accepted this revision. cullmann added a comment. I think it is ok that way, too ;=) REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D11278 To: broulik, #ktexteditor, dhaumann, kfunk, cullmann Cc: cullmann, kfunk, #frameworks, michaelh, kevinapavew,

D11278: [KateCompletionWidget] Create configuration interface on demand

kfunk accepted this revision. kfunk added a comment. This revision is now accepted and ready to land. In D11278#224484 , @kfunk wrote: > Looks like you don't need the member at all? Otherwise late-init wouldn't work this way. > >

D11244: Fix text scaling with non-integer scale factors when PLASMA_USE_QT_SCALING=1 is set

davidedmundson added a comment. You've added a load of bug reports about the kcms. This patch won't change them at all. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D11244 To: ngraham, #plasma, davidedmundson Cc: broulik, #frameworks, michaelh

D11279: [FileIndexerConfig] Delay populating folders until actually used

broulik created this revision. broulik added a reviewer: michaelh. Restricted Application added projects: Frameworks, Baloo. Restricted Application added a subscriber: Frameworks. broulik requested review of this revision. REVISION SUMMARY The folder inclusion/exclusion configuration queries

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 153 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/153/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Tue, 13 Mar 2018 08:40:04 + Build duration: 1 hr 27 min and counting JUnit Tests Name:

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 175 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/175/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Tue, 13 Mar 2018 09:32:46 + Build duration: 30 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 24 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/24/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Tue, 13 Mar 2018 08:40:04 + Build duration: 1 hr 13 min and counting JUnit Tests Name: (root)

D10918: taglibextractor: Refactor for better readability

michaelh added a comment. In D10918#224424 , @astippich wrote: > Btw, I'm not opposed anymore for merging before D10803 , as I need some more time to think about the value types and probably also need to

Re: D11183: Sonnet: don't impose the default client

This introduces a subtle change in behaviour so I'd appreciate some feedback!

D10694: epubextractor: Handle multiple subjects better

michaelh added a comment. A Either I'm completely off-track here or `kfilemetadata` is not doing this correctly. I see a lot of statements like `artist += ', ' + value` -> no list! `result->add` calls `QMap->addMulti().` This forces the client to iterate over the map, which is

D11278: [KateCompletionWidget] Create configuration interface on demand

kfunk added a comment. Looks like you don't need the member at all? Otherwise late-init wouldn't work this way. `m_configWidget` seems only used in `showConfig()`. Let's remove the member altogether? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D11278

Re: D11193: Sonnet : use current hunspell API

Silence means acceptance?

D11278: [KateCompletionWidget] Create configuration interface on demand

broulik created this revision. broulik added reviewers: KTextEditor, dhaumann. Restricted Application added projects: Kate, Frameworks. Restricted Application added a subscriber: Frameworks. broulik requested review of this revision. REVISION SUMMARY No need to create it immediately. Saves some

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 174 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/174/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Tue, 13 Mar 2018 08:40:04 + Build duration: 29 min and counting JUnit Tests Name: (root)

D10694: epubextractor: Handle multiple subjects better

mgallien added a comment. In D10694#224465 , @michaelh wrote: > In D10694#224440 , @mgallien wrote: > > > Could you please update your diff and we can land it ? This is a useful improvement. >

D10694: epubextractor: Handle multiple subjects better

michaelh added a comment. In D10694#224440 , @mgallien wrote: > Could you please update your diff and we can land it ? This is a useful improvement. 1. We can't land it yet. baloo searching breaks with this patch. baloo has be adapted

D1231: Add Remote Access interface to KWayland

Kanedias added a comment. In D1231#224441 , @jtamate wrote: > As I don't see anything related to security in this patch, I have two questions. > > Could anyone with access to server:port manage the server wayland sessions or just create a

D1231: Add Remote Access interface to KWayland

jtamate added a comment. As I don't see anything related to security in this patch, I have two questions. Could anyone with access to server:port manage the server wayland sessions or just create a new session? The access control should be done in the firewall? REPOSITORY R127

D10694: epubextractor: Handle multiple subjects better

mgallien added a comment. In D10694#222674 , @michaelh wrote: > @mgallien: I think we have a beautiful misunderstanding here :-) > > In D10694#221719 , @michaelh wrote: > > > This is bad! ...

D10918: taglibextractor: Refactor for better readability

astippich added a comment. Btw, I'm not opposed anymore for merging before D10803 , as I need some more time to think about the value types and probably also need to extend the tests. I will adapt to the changes afterwards. REPOSITORY R286