D14302: Don't block forever in ensureKdeinitRunning

lvsouza added a comment. I think I know what is happening. This line QDeadlineTimer timer(qMax(timeout, -1));// QDT only takes -1 as "forever" passes the result of qMax() to QDeadlineTimer's constructor. That constructor receives a quint64. Since qMax() is a template:

Re: [Kde-hardware-devel] Do we want to drop support for "enterprise" devices in plasma-nm applet?

Hi, I think adding an option in the editor to disable the filters is better than just reverting the patches. Just reverting the patches is going to be another big visual change that might annoy someone else who will ask to change it again. See the picture? Lamarque V. Souza Linux User #57137 -

D6687: Adding support to ipv*.route-metric

lvsouza accepted this revision. This revision is now accepted and ready to land. REPOSITORY R282 NetworkManagerQt REVISION DETAIL https://phabricator.kde.org/D6687 To: pvillani, jgrulich, lvsouza Cc: #frameworks

D6687: Adding support to ipv*.route-metric

lvsouza requested changes to this revision. lvsouza added a comment. This revision now requires changes to proceed. The summary says this patch adds route metric support to IPv4 too, but no IPv4 file is touched by this patch. Have you missed the IPv4 changes? INLINE COMMENTS >

Re: kdereview - xdg-desktop-portal-kde

Hi, My review: . there are several code style inconsistencies, like "QDialog* parent" and "Ui::AppChooserDialog * m_dialog". In some places you use app_id while in other places you use appId. . you use 0 in same places that you should use nullptr. . there is no doxygen documentation at all. .

Re: Review Request 130123: Fix the skip disabled backlight device

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130123/#review103209 --- Ship it! Ship It! - Lamarque Souza On May 10, 2017, 1

Re: Review Request 130123: Fix the skip disabled backlight device

3/#comment68680> return false. daemon/backends/upower/backlighthelper.cpp (line 110) <https://git.reviewboard.kde.org/r/130123/#comment68682> Code style: add a { at the and of this line and a } after the line b

Re: Review Request 130090: Fix incorrect definition of major(3)/minor(3) macros

> On May 4, 2017, 12:40 p.m., Albert Astals Cid wrote: > > Lamarque, you broke the build. > > Lamarque Souza wrote: > Fixed. Thanks for the quick report about the broken build and sorry for > not adding all files to the commit. > > Ben Cooksley wrote: > T

Re: Review Request 130115: skip the disabled backlight device

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130115/#review103191 --- Ship it! Ship It! - Lamarque Souza On May 5, 2017, 1

Re: Review Request 130115: skip the disabled backlight device

irst before calling file.setFileName(): ... file.close(); file.setFileName(BACKLIGHT_SYSFS_PATH + interface + "/type"); ... - Lamarque Souza On May 5, 2017, 7:28 a.m., AceLan Kao wrote: > > --

Re: Review Request 128958: Add application/x-openvpn-profile mime type

> On May 1, 2017, 2:05 p.m., Lamarque Souza wrote: > > ping > > David Faure wrote: > ping? did you see my comment? ;) Yes, I did see your comment. The "ping" was to this review's author to follow your instructions :-) I am one of the Plasma NM developers and th

Re: Review Request 130090: Fix incorrect definition of major(3)/minor(3) macros

> On May 4, 2017, 12:40 p.m., Albert Astals Cid wrote: > > Lamarque, you broke the build. Fixed. Thanks for the quick report about the broken build and sorry for not adding all files to the commit. - Lamarque --- This is an

Re: Review Request 128958: Add application/x-openvpn-profile mime type

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128958/#review103166 --- ping - Lamarque Souza On Sept. 20, 2016, 11:59 a.m., Kai

Re: Review Request 130090: Fix incorrect definition of major(3)/minor(3) macros

> On April 28, 2017, 1:28 p.m., Lamarque Souza wrote: > > Ship It! > > KJ Tsanaktsidis wrote: > Great - thanks for your help and for bearing with my rusty C++! What > happens now? I'm waiting on this patch to land for another patch I submitted

Re: Review Request 130090: Fix incorrect definition of major(3)/minor(3) macros

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130090/#review103148 --- Ship it! Ship It! - Lamarque Souza On April 23, 2017

Re: Review Request 130090: Fix incorrect definition of major(3)/minor(3) macros

> On April 22, 2017, 10:27 a.m., Lamarque Souza wrote: > > autotests/CMakeLists.txt, line 66 > > <https://git.reviewboard.kde.org/r/130090/diff/5/?file=494817#file494817line66> > > > > CMake's developers recommend using else() instead of > > else(). T

Re: Review Request 130090: Fix incorrect definition of major(3)/minor(3) macros

ps://git.reviewboard.kde.org/r/130090/#comment68589> Here too. - Lamarque Souza On April 22, 2017, 12:38 a.m., KJ Tsanaktsidis wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 130090: Fix incorrect definition of major(3)/minor(3) macros

tps://git.reviewboard.kde.org/r/130090/#comment68567> It is common practice to pass QString parameters QString as const &: FakeUdisks2BlockDevice(QObject *parent, const device, quint64 device_number); - Lamarque Souza On April 20, 2017, 8:49 a.m., KJ Tsanakts

Re: Review Request 130090: Fix incorrect definition of major(3)/minor(3) macros

//git.reviewboard.kde.org/r/130090/#comment68564> Code style: remove the extra whitespace at the end of the line. - Lamarque Souza On April 19, 2017, 11:05 a.m., KJ Tsanaktsidis wrote: > > --- > This is an automatically gen

Re: Review Request 130090: Fix incorrect definition of major(3)/minor(3) macros

31) <https://git.reviewboard.kde.org/r/130090/#comment68558> Usually we use uppper case for macros. That would also save some lines in this patch. nitpik: add spaces around >>, like you did for & in the line below. - Lamarque Souza On April 17, 2017, 8:42 a.m.,

Re: Review Request 123534: Add public dependency on ModemManager

n Grulich wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123534/ > --- > > (Updated April 27, 2015, 2:44 p.m.) > > > Review

Re: Review Request 119381: not find ProvidersList

> On Jan. 21, 2017, 1 a.m., Albert Astals Cid wrote: > > this doesn't apply anymore, should it be updated or discarded? Discarded. It was superseded by https://git.reviewboard.kde.org/r/120879/ - Lamarque --- This is an automatically

Re: Review Request 129855: Treat no passphrase as Solid::UserCanceled error

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129855/#review102119 --- Ship it! Ship It! - Lamarque Souza On Jan. 20, 2017

Re: Review Request 129750: Q_ENUMS -> Q_ENUM and Q_FLAGS -> Q_FLAG

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129750/#review101731 --- Ship it! Ship It! - Lamarque Souza On Jan. 2, 2017

Re: Review Request 129607: Display Application version in About dialog header

> On Dec. 3, 2016, 4:48 p.m., Martin Klapetek wrote: > > How about "Using" for the title of the tab and then removing the "Using" > > label from inside the tab? > > > > Also, +1 to putting the version front. > > Thomas Pfeiffer wrote: > Hm, "Using" sounds a bit weird without context, but

Re: Review Request 129293: Add a CMake option to switch between HAL and UDisks managers on FreeBSD.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129293/#review100452 --- Ship it! Ship It! - Lamarque Souza On Oct. 31, 2016

Re: Review Request 129293: Add a CMake option to switch between HAL and UDisks managers on FreeBSD.

tps://git.reviewboard.kde.org/r/129293/#comment67407> I think you should change this description to something like: "Use bsdisks/UDisks2 instead of hal to manage disk devices" - Lamarque Souza On Oct. 31, 2016, 12:58 p.m.,

Re: Review Request 129293: Add a CMake option to switch between HAL and UDisks managers on FreeBSD.

ent67403> Your patch still compiles hal even though it will not be used. - Lamarque Souza On Oct. 31, 2016, 11:25 a.m., Gleb Popov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https:

Re: Configuring Solid Action

Hi, The code that lists devices is in /src/solid/devices/frontend/devicemanager.cpp. Look for Solid::Device::allDevices(). In the example you gave the backend used was udisks2: /src/solid/devices/backends/udisks2/udisksmanager.cpp, which issues a dbus call to udisks and parses its output to get

Re: KDev-Embedded - Identify USB peripherals

Hi, I did not understand what you mean by "programmer". Everybody needs to compare strings when dealing with serial ports. In you case, I think you need more than that to identify JTAGs. USB-Serial ports usually follows the pattern "(ttyS|ttyUSB|ttyACM|ttyAMA|rfcomm|ttyO)[0-9]{1,3}" used in the

Re: Review Request 128750: Fix compilation of kdecore

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128750/#review99830 --- Ship it! Ship It! - Lamarque Souza On Aug. 24, 2016

Re: Review Request 128843: Use standard org.freedesktop.DBus.Properties interfaces for monitoring PropertiesChanged signal for NM 1.4.0+

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128843/#review98937 --- Ship it! Ship It! - Lamarque Souza On Sept. 6, 2016

Re: Review Request 128843: Use standard org.freedesktop.DBus.Properties interfaces for monitoring PropertiesChanged signal for NM 1.4.0+

d-pointer. src/wirelessdevice.cpp (line 71) <https://git.reviewboard.kde.org/r/128843/#comment66611> There is no dbusPropertiesChanged slot in the d-pointer. It's odd not having a propertiesChanged slot for wireless. Is this correct? - Lamarque Souza On Sept. 6, 2016, 11:56 a.m., Jan Grulich wrote: > > --

Re: [Kde-hardware-devel] Review Request 128083: Find CPUs by subsystem rather than driver

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128083/#review96241 --- Ship it! Ship It! - Lamarque Souza On June 3, 2016, 12

Re: Review Request 128083: Find CPUs by subsystem rather than driver

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128083/#review96241 --- Ship it! Ship It! - Lamarque Souza On June 3, 2016, 12

Re: [Kde-hardware-devel] Review Request 128084: Handle reading /proc/cpuinfo for Arm processors

) <https://git.reviewboard.kde.org/r/128084/#comment65041> This extracts the current cpu speed, not the maximum. Is that what you want? Yes then I think you should rename extractCpuSpeed() to extractCurrentCpuSpeed(). - Lamarque Souza On June 3, 2016, 12:15 p.m., David Edmundson

Re: Review Request 128084: Handle reading /proc/cpuinfo for Arm processors

) <https://git.reviewboard.kde.org/r/128084/#comment65041> This extracts the current cpu speed, not the maximum. Is that what you want? Yes then I think you should rename extractCpuSpeed() to extractCurrentCpuSpeed(). - Lamarque Souza On June 3, 2016, 12:15 p.m., David Edmundson

Re: Review Request 128085: Fix check that CPU is a valid CPU

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128085/#review96239 --- Ship it! Ship It! - Lamarque Souza On June 3, 2016, 12

Re: [Kde-hardware-devel] Review Request 128085: Fix check that CPU is a valid CPU

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128085/#review96239 --- Ship it! Ship It! - Lamarque Souza On June 3, 2016, 12

Re: [Kde-hardware-devel] MMQT API - Asynchronous mode

Hi, Jan is right, you have to use Q_OBJECT to use signals/slots in Qt. An asynchronous pseudo code based on the example provided in MMQt source code would look like: SomeQWidget::someMethod() { ModemManager::ModemMessaging::Ptr messaging = modemdevice->messagingInterface();

Re: Broken ABI in networkmanager-qt

On Tue, May 17, 2016 at 8:36 AM, Harald Sitter wrote: > On Tue, May 17, 2016 at 11:06 AM, Jan Grulich wrote: > > Hi, > > > > we decided to drop WiMAX support in nm-qt when it's compiled against NM > 1.2.0, > > but this seems to break binary compatibility

Re: Review Request 127209: Fix some issues found by Coverity

de.org/r/127209/#comment6> Same here. - Lamarque Souza On Feb. 28, 2016, 7:46 p.m., Aleix Pol Gonzalez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: &

Re: [Kde-hardware-devel] Do we want to drop support for "enterprise" devices in plasma-nm applet?

Hi, I am Ok with your both suggestions (dropping support for them from the applet and keeping the support in the editor). I am also Ok if you prefer to also drop the support from the editor. I, for one, have never used those "enterprise" devices myself. Lamarque V. Souza

Re: Review Request 126222: Fix rating widget flickering when selecting rating with mouse

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126222/#review89112 --- Ship it! Ship It! - Lamarque Souza On Dec. 3, 2015, 10:19

Re: Review Request 126222: Fix rating widget flickering when selecting rating with mouse

tps://git.reviewboard.kde.org/r/126222/#comment60992> Code style: move the bracket at the end of this line to the next line. - Lamarque Souza On Dec. 3, 2015, 10:19 a.m., Xuetian Weng wrote: > > --- > This is an automatically generated e

Re: Review Request 126222: Fix rating widget flickering when selecting rating with mouse

> On Dec. 2, 2015, 4:45 p.m., Lamarque Souza wrote: > > That code was added to fix this bug > > https://bugs.kde.org/show_bug.cgi?id=171343#c6 > > Xuetian Weng wrote: > Emm.. interesting feature. But code inside mouseMoveEvent looks fishy, > and this fea

Re: Review Request 126222: Fix rating widget flickering when selecting rating with mouse

/show_bug.cgi?id=171343#c6 - Lamarque Souza On Dec. 2, 2015, 4:34 p.m., Xuetian Weng wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 126161: OS X housekeeping

tps://git.reviewboard.kde.org/r/126161/#comment60862> Please add a copyright header for each new file [1]. If I am not mistaken all frameworks 5 files should use LGLP+ license. [1] https://techbase.kde.org/Policies/Licensing_Policy - Lamarque Souza On Nov. 24, 2015, 11:03 p.m., René J.V.

Re: Review Request 126078: [OS X] modernising the KIdleTime plugin (WIP!)

> On Nov. 17, 2015, 10:58 p.m., Lamarque Souza wrote: > > src/plugins/osx/macpoller.h, line 24 > > <https://git.reviewboard.kde.org/r/126078/diff/6/?file=417216#file417216line24> > > > > Nitpick: this should go after #include > > René J.V. Bertin w

Re: [Kde-hardware-devel] Review Request 126096: Fix memory leak in kscreen backend of libkscreen

h can side effects in the "hack" used in XRandR::screenResources(). - Lamarque --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126096/#review88491 ---

Re: [Kde-hardware-devel] Review Request 126096: Fix memory leak in kscreen backend of libkscreen

of xcb_randr_get_screen_resources_reply. Diffs - backends/xrandr/xrandrscreen.cpp 8df957e Diff: https://git.reviewboard.kde.org/r/126096/diff/ Testing --- No memory leak and everything still works. Thanks, Lamarque Souza ___ Kde-hardware-devel mailing list

[Kde-hardware-devel] Review Request 126096: Fix memory leak in kscreen backend of libkscreen

Description --- libkscreen needs to free memory of xcb_randr_get_screen_resources_reply. Diffs - backends/xrandr/xrandrscreen.cpp 8df957e Diff: https://git.reviewboard.kde.org/r/126096/diff/ Testing --- No memory leak and everything still works. Thanks, Lamarque Souza

Re: Review Request 126078: [OS X] modernising the KIdleTime plugin (WIP!)

g the failure to allocate memory. src/plugins/osx/macpoller_helper.mm (line 78) <https://git.reviewboard.kde.org/r/126078/#comment60682> There is no point in doing this if the next line will delete nativeGrabber. src/plugins/osx/macpoller_helper.mm (line 82) <https://git.reviewboard.kde.org/r/

Re: Review Request 124714: Add support to qmake's options to api.kde.org

- DEFINES += QT_NO_KEYWORDS - PKGCONFIG += libnm Thanks, Lamarque Souza ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 124714: Add support to qmake's options to api.kde.org

Thanks, Lamarque Souza ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 124714: Add support to qmake's options to api.kde.org

- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124714/#review87955 ------- On Nov. 8, 2015, 1:21 a.m., Lamarque Souza wrote: > >

Re: [Kde-br] Cmake error with VTK[Br-Print3D Project]

Hi Lays, It looks like you did not compile qt support in your vtk installation. What parameters did you pass do cmake when you compiled vtk? Lamarque V. Souza http://planetkde.org/pt-br On Fri, Oct 30, 2015 at 8:40 PM, Lays Rodrigues < laysrodriguessi...@gmail.com> wrote: > Hi folks! Good

Re: Documentation on adding new Solid Backends

Hi, The documentation is located in http://techbase.kde.org/Development/Tutorials/Solid_Tutorials. I am afraid it is scarse and in some cases outdated. You can also take a look at available backends in git://anongit.kde.org/solid/src/solid/devices/backends as examples, specially udev and udisks2

Re: RFC: Enabling -DECM_ENABLE_SANITIZERS='address' in jenkins

I agree but there is a problem: it can catch a lot of errors in our dependency libraries (upstream bugs). I had this problem when I used it with a program I develop at my work. Enabling it for all programs at once and fixing all those upstream bugs can be overwhelming. Maybe we should do it for a

Re: Review Request 124963: New widget: KNewPasswordWidget

On Aug. 28, 2015, 11:30 a.m., Lamarque Souza wrote: src/knewpasswordwidget.cpp, line 75 https://git.reviewboard.kde.org/r/124963/diff/1/?file=399453#file399453line75 i18n instead of tr Sune Vuorela wrote: Aren't we in a tier1 framework where i18n and friends aren't available

Re: Review Request 124963: New widget: KNewPasswordWidget

in that particular case? - Lamarque Souza On Aug. 28, 2015, 9:24 a.m., Elvis Angelaccio wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124963

Re: Review Request 124963: New widget: KNewPasswordWidget

On Aug. 28, 2015, 11:30 a.m., Lamarque Souza wrote: src/knewpasswordwidget.cpp, line 92 https://git.reviewboard.kde.org/r/124963/diff/1/?file=399453#file399453line92 Is there any documentation explaining this calculation? Elvis Angelaccio wrote: I don't know, sorry

Re: Using nullptr instead of Q_NULLPTR

On Thu, Aug 13, 2015 at 7:59 AM, Ivan Čukić ivan.cu...@kde.org wrote: I prefer the first option, it's the way forward and if someone was using I'd say that requiring a newer gcc just like that would go against the nature of the KF5 project. I don't really see why it is against the

Review Request 124714: Add support to qmake's options to api.kde.org

/metainfo.html and kapidox created the correct output: qmakepro: - config: link_pkgconfig - defines: QT_NO_KEYWORDS - pkgconfig: libnm Thanks, Lamarque Souza ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman

Re: Review Request 105831: Allow symlink creation for kio protocols that support it

like fish and nfs create symlinks. I am also working on some other changes that could use this feature. Diffs - kio/kio/copyjob.cpp 8dde763 Diff: https://git.reviewboard.kde.org/r/105831/diff/ Testing --- Thanks, Lamarque Souza

Re: Review Request 104526: Make nepomuk runner remove undesired matches

/queryclientwrapper.cpp 0b828b0 Diff: https://git.reviewboard.kde.org/r/104526/diff/ Testing --- Works in my Plasma Active installation. Thanks, Lamarque Souza

Re: [kwallet] /: Updating maintainer name

:16:17 Lamarque Souza wrote: Does the maintainer field accept more than one identity? That's the question. Go ahead and do that, Alex Merry volunteered to fix kapidox if necessary :-) -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

Re: [kwallet] /: Updating maintainer name

Does the maintainer field accept more than one identity? Lamarque V. Souza http://planetkde.org/pt-br On Mon, Aug 3, 2015 at 7:11 AM, Alex Merry alex.me...@kde.org wrote: On Sunday 02 August 2015 19:31:36 David Faure wrote: Are you sure about this? All other frameworks use the identity

Re: Review Request 124413: Enable PAM opening KWallet again

. - Lamarque Souza On July 21, 2015, 3:52 p.m., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124413

Re: Review Request 124413: Enable PAM opening KWallet again

On July 21, 2015, 3:57 p.m., Lamarque Souza wrote: src/runtime/kwalletd/main.cpp, line 113 https://git.reviewboard.kde.org/r/124413/diff/1/?file=386596#file386596line113 You should use strncmp instead of strcmp. Martin Klapetek wrote: Why would you think? The whole string

Re: Review Request 124413: Enable PAM opening KWallet again

On July 21, 2015, 3:57 p.m., Lamarque Souza wrote: src/runtime/kwalletd/main.cpp, line 113 https://git.reviewboard.kde.org/r/124413/diff/1/?file=386596#file386596line113 You should use strncmp instead of strcmp. Martin Klapetek wrote: Why would you think? The whole string

Re: [Kde-hardware-devel] Review Request 102983: Added support for rfkill

RfkillSwitch not supported in this platform - Lamarque Souza On July 11, 2015, 8:43 p.m., Rüdiger Sonderfeld wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/102983

Re: Review Request 124133: Add dedicated Version tab to KAboutApplicationDialog

://git.reviewboard.kde.org/r/124133/#comment56243 Please call QLabel pointer-setTextInteractionFlags(Qt::TextSelectableByMouse) before calling versionLayout-addWidget(QLabel pointer). - Lamarque Souza On June 20, 2015, 4:30 a.m., Martin Gräßlin wrote

Re: Review Request 124133: Add dedicated Version tab to KAboutApplicationDialog

On June 20, 2015, 7:10 p.m., Martin Klapetek wrote: +1 for adding all that info -1 for putting it into its own tab; previously it was visible right away, now an additional click is needed. Maybe it could be stacked all under the application name? I mean it's just 2 more lines to add

Re: Review Request 123533: Add public dependency on NetworkManager

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123533/#review79634 --- Ship it! Ship It! - Lamarque Souza On April 27, 2015, 2

Re: Review Request 123534: Add public dependency on ModemManager

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123534/#review79635 --- Ship it! Ship It! - Lamarque Souza On April 27, 2015, 2

Re: Review Request 123532: Add find modules for ModemManager and NetworkManager

the extra-cmake-module maintainer to give the final ship it. - Lamarque Souza On April 27, 2015, 2:38 p.m., Jan Grulich wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123532

Re: Review Request 123477: Add public dependency on NetworkManager

/ --- (Updated April 23, 2015, 1:01 p.m.) Review request for KDE Frameworks, David Faure, Daniel Vrátil, and Lamarque Souza. Repository: networkmanager-qt Description --- I'm not 100% sure how this should work and I couldn't find another framework doing

Re: [Kde-hardware-devel] Review Request 123263: WIP: KDE Connect backend for Solid

On April 5, 2015, 5:54 p.m., Lamarque Souza wrote: src/solid/devices/backends/kdeconnect/kdeconnectbattery.cpp, line 79 https://git.reviewboard.kde.org/r/123263/diff/1/?file=360131#file360131line79 Is it possible to retrieve a correct value for this and the other values below

Re: [Kde-hardware-devel] Review Request 123388: BluetoothMonitor: Simplify addBluetoothConnection + add haveBluetoothConnection

://git.reviewboard.kde.org/r/123388/#comment54070 Are you sure regular expression rfcomm? does not appear in service variable anymore? Years ago when I tested this it used to appear sometimes. - Lamarque Souza On April 17, 2015, 11:40 a.m., David Rosca wrote

Re: [Kde-hardware-devel] Review Request 123388: BluetoothMonitor: Simplify addBluetoothConnection + add haveBluetoothConnection

On April 17, 2015, 12:41 p.m., Lamarque Souza wrote: kded/bluetoothmonitor.h, line 41 https://git.reviewboard.kde.org/r/123388/diff/2/?file=361568#file361568line41 Is passing connectionName really necessary? The old code queries BlueZ to get the device name and use

Re: [Kde-hardware-devel] Review Request 123388: BluetoothMonitor: Simplify addBluetoothConnection + add haveBluetoothConnection

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123388/#review79126 --- Ship it! Ship It! - Lamarque Souza On April 17, 2015, 11

Re: Review Request 123401: Fix usage of the networkmanagerqt_export.h after commit 9966897

blocks 'git pull' (among serveral other services) so I could not test it myself. Plasma NM can be fixed later. - Lamarque Souza On April 17, 2015, 3:53 p.m., Hrvoje Senjan wrote: --- This is an automatically generated e-mail. To reply

Re: Review Request 123360: Introduce LoopSound flag

On April 14, 2015, 3:50 p.m., Lamarque Souza wrote: src/notifybyaudio.cpp, line 89 https://git.reviewboard.kde.org/r/123360/diff/1/?file=361076#file361076line89 Should not this patch be followed by another patch that set LoopSound flag for Persistant notifications that *really

Re: Review Request 123360: Introduce LoopSound flag

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123360/#review78950 --- Ship it! Ship It! - Lamarque Souza On April 14, 2015, 2

Re: Review Request 123349: NetworkManagerQt: comment out unneeded lines from example/CMakeLists.txt

On April 13, 2015, 7:13 a.m., David Faure wrote: examples/CMakeLists.txt, line 5 https://git.reviewboard.kde.org/r/123349/diff/1/?file=361005#file361005line5 well i thought maybe someone wants to see how to use this in their app... but ok IIRC it also shows that on api.kde.org

Re: Review Request 123349: NetworkManagerQt: comment out unneeded lines from example/CMakeLists.txt

. - Lamarque Souza On April 12, 2015, 7:57 p.m., David Faure wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123349/ --- (Updated

Re: [Kde-hardware-devel] Review Request 123262: ddccontrol support for PowerDevil

On April 5, 2015, 7:28 p.m., Lamarque Souza wrote: daemon/backends/upower/ddchelper.cpp, line 139 https://git.reviewboard.kde.org/r/123262/diff/2/?file=360145#file360145line139 Hmmm I do care about if this worked. People usually complains when changing brightness does not work

Re: [Kde-hardware-devel] Review Request 123262: ddccontrol support for PowerDevil

, or if this QProcess is already finished).. Already finished here is the same as not started yet, you should use if (!dccProcess.waitForStarted() || !dccProcess.waitForFinished()). I must also say that I really do not like synchronous calls in kded or in a plasmoid. - Lamarque Souza On April 5, 2015, 3:44

Re: [Kde-hardware-devel] Review Request 123263: WIP: KDE Connect backend for Solid

On April 5, 2015, 5:54 p.m., Lamarque Souza wrote: src/solid/devices/backends/kdeconnect/kdeconnectmanager.cpp, line 116 https://git.reviewboard.kde.org/r/123263/diff/1/?file=360137#file360137line116 Answering your question from this patch's description: yes, I prefer that you

Re: [Kde-hardware-devel] solid bugzilla product marked obsolete

Hi all, Following the obsolete action, could someone mark Network Management product as obsolete too? It is related to old Plasma NM 0.9.0.x series, which is now unmaintained. Lamarque V. Souza KDE's Network Management maintainer http://planetkde.org/pt-br On Wed, Mar 11, 2015 at 7:57 PM,

Re: [Kde-hardware-devel] Review Request 121677: Fix mobile connection wizard manual apn setting

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121677/#review73828 --- Ship it! Ship It! - Lamarque Souza On Dec. 26, 2014, 7:46

Re: Fwd: Plasma 5.2 bits for kdereview

ModemManagerQt is used by two KDE Applications, Plasma NM and KDE Telepathy. The former uses it to retrieve information about mobile broadband connections (operator and signal quality), unlocking modem's sim card when activating 3G connections, listing available modems in mobile connection wizard

Re: [Kde-hardware-devel] Review Request 121677: Fix mobile connection wizard manual apn setting

is it will always select the plan before the correct one in the list. - Lamarque Souza On Dec. 26, 2014, 7:46 a.m., Xuetian Weng wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121677

Re: [Kde-hardware-devel] Review Request 121606: Port bluetooth connection support to bluez 5

is good to go. Thanks for patch. - Lamarque Souza On Dec. 26, 2014, 7:21 a.m., Xuetian Weng wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121606

Re: [Kde-hardware-devel] Review Request 121606: Port bluetooth connection support to bluez 5

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121606/#review72523 --- Ship it! Ship It! - Lamarque Souza On Dec. 26, 2014, 7:21

Re: [Kde-hardware-devel] Review Request 121606: Port bluetooth connection support to bluez 5

://git.reviewboard.kde.org/r/121606/#comment50554 Code style: prepend new line here and move the closer to the variable name. - Lamarque Souza On Dec. 25, 2014, 2:58 a.m., Xuetian Weng wrote: --- This is an automatically generated e

Re: [Kde-hardware-devel] Review Request 121606: Port bluetooth connection support to bluez 5

if - Lamarque Souza On Dec. 23, 2014, 4:26 p.m., Xuetian Weng wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121606

Re: [Kde-hardware-devel] Review Request 121606: Port bluetooth connection support to bluez 5

the report https://bugzilla.redhat.com/show_bug.cgi?id=1055628. Jan Grulich wrote: Add please Lukáš Tinkl and Lamarque Souza to reviewers. Weng has a point. Only Bluedevil uses this code, if there is a Bluez 5 and Plasma 5 version of Bluedevil available then it makes sense to drop support

[Kde-hardware-devel] Fwd: Review Request 121217: Unbreak hal backend.

Please read [1] to understand why knowing who (real name and valid e-mail) sends patches to upstream is so important. Not that open source projects are sued every year, but we need to know how to contact the person who sends us patches when we need it in a formal way, not just through nicknames.

  1   2   >