D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

2018-02-14 Thread Nathaniel Graham
ngraham added a comment. In D8056#206326 , @simgunz wrote: > I was thinking to discuss the possibility to make a new KDE UI component for collapsible headers so that it can be used in multiple places. Maybe I can open a task for discussing this

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

2018-02-14 Thread Henrik Fehlauer
rkflx added a comment. Great to hear. Hopefully you'll find the right balance between chasing the big goals and doing small changes here and there to learn the trade for achieving the former ;) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8056 To: simgunz, dfaure,

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

2018-02-14 Thread Simone Gaiarin
simgunz added a comment. In D8056#206303 , @rkflx wrote: > @simgunz Thanks again for your patience (first commit in July!). Hope to see more patches from you in the future (both large* like this one, but also smaller things**), as you both have

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

2018-02-14 Thread Henrik Fehlauer
This revision was automatically updated to reflect the committed changes. Closed by commit R241:e3af26bbb1e7: Improve usability of Open With dialog by adding option to filter the… (authored by simgunz, committed by rkflx). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

2018-02-14 Thread Nathaniel Graham
ngraham added a comment. In D8056#206303 , @rkflx wrote: > *) I know Nate would love to get collapsible headers in Dolphin's sidebar… *completely coincidental mention* https://bugs.kde.org/show_bug.cgi?id=389803 :) Allow me to echo

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

2018-02-14 Thread Henrik Fehlauer
rkflx accepted this revision. rkflx added a comment. @simgunz Thanks again for your patience (first commit in July!). Hope to see more patches from you in the future (both large* like this one, but also smaller things**), as you both have a good eye for usability as well as the means to

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

2018-02-13 Thread Simone Gaiarin
simgunz added a comment. > - [↓] to move focus (this breaks with the completion enabled, though) Only for completion: popup. Still works for completion: auto I have changed the tooltip as suggested. I think we are ready to land it. Can't wait to see the gif! REPOSITORY R241

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

2018-02-13 Thread Simone Gaiarin
simgunz updated this revision to Diff 27136. simgunz added a comment. - Improve tooltip to let user know he can type a command REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8056?vs=27084=27136 BRANCH openwithdialog-filter-app-tree REVISION DETAIL

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

2018-02-13 Thread Nathaniel Graham
ngraham added a comment. I'm super excited to see this happening. Fantastic work, @simgunz, and thanks as always for your incredibly thorough review prowess, @rkflx. I'm planning to feature this in the coming Sunday's Usability & Productivity post as it it not only a //serious// improvement

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

2018-02-13 Thread Henrik Fehlauer
rkflx accepted this revision. rkflx added a comment. This revision is now accepted and ready to land. In D8056#205595 , @simgunz wrote: > Fixed the problems reported by @rkflx hopefully without introducing new ones. I did some testing and now

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

2018-02-13 Thread Simone Gaiarin
simgunz added a comment. I rebased to master and updated the review. I hope I didn't messed up anything. In D8056#205621 , @ngraham wrote: > I was under the impression that the text box gave priority to the app filtering unless you checked

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

2018-02-13 Thread Simone Gaiarin
simgunz updated this revision to Diff 27084. simgunz added a comment. - Automatically select first match of the filter - ArrowDown on lineEdit pass focus to QTreeView - Add tooltip to explain how to use the search filter - Fix code styling - Set appModel and proxyModel together, store

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

2018-02-13 Thread Nathaniel Graham
ngraham added a comment. It's been a while since I tested (could you re-based it on current master?), but I was under the impression that the text box gave priority to the app filtering unless you checked the semi-hidden option to enable command-line completion instead. REPOSITORY R241

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

2018-02-13 Thread Simone Gaiarin
simgunz added a comment. In D8056#205614 , @ngraham wrote: > interspersing the CLI command and application filtering would be a mistake. Say I type `kate`. Am I intending to use the `kate` command, or select the "Kate" app? It's ambiguous if we

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

2018-02-13 Thread Nathaniel Graham
ngraham added a comment. interspersing the CLI command and application filtering would be a mistake. Say I type `kate`. Am I intending to use the `kate` command, or select the "Kate" app? It's ambiguous if we use one text field for both. REPOSITORY R241 KIO REVISION DETAIL

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

2018-02-13 Thread Simone Gaiarin
simgunz added a comment. The tooltip of the line edit now says: `Type some text to filter the application tree.\nPress down arrow to navigate the results tree.` I suggest to change it to: `Type to filter the application tree or type the name of a command.\nPress down arrow to navigate the

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

2018-02-13 Thread Simone Gaiarin
simgunz added a comment. Fixed the problems reported by @rkflx hopefully without introducing new ones. I did some testing and now everything seems ok, but please check again. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8056 To: simgunz, dfaure, #frameworks, #vdg,

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

2018-02-13 Thread Simone Gaiarin
simgunz updated this revision to Diff 27079. simgunz added a comment. - Fix OK button not disabled when category is selected - Fix cannot accept selection if filter line edit is empty REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8056?vs=24488=27079 BRANCH

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

2018-02-05 Thread Henrik Fehlauer
rkflx requested changes to this revision. rkflx added a comment. This revision now requires changes to proceed. I rebased and was just about to land this, but found a serious problem: Accepting via OK, double clicking or [Enter] will only work if you have typed at least a single character.

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

2018-02-03 Thread Nathaniel Graham
ngraham added a comment. Needs a rebase on top of master, FWIW. Can't wait to have this! REPOSITORY R241 KIO BRANCH openwithdialog-filter-app-tree REVISION DETAIL https://phabricator.kde.org/D8056 To: simgunz, dfaure, #frameworks, #vdg, ngraham, rkflx Cc: rkflx, romangg, fabianr,

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

2018-02-03 Thread Henrik Fehlauer
rkflx added a comment. In https://phabricator.kde.org/D8056#200013, @simgunz wrote: > I cannot push so someone needs to do it for me. No problem, I can do it for you. REPOSITORY R241 KIO BRANCH openwithdialog-filter-app-tree REVISION DETAIL

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

2018-02-03 Thread Simone Gaiarin
simgunz added a comment. Good! I cannot push so someone needs to do it for me. Soon, I'll have more free time, and I'll try to polish the code (remove fetch more, use Qt 5.10 recursive filtering). REPOSITORY R241 KIO BRANCH openwithdialog-filter-app-tree REVISION DETAIL

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

2018-02-03 Thread David Faure
dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Thanks, looks ok to me now. Well, all that code about incremental fetching (canFetchMore/fetchMore) only to then fetch everything upfront, could be simplified to just create the full

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

2017-12-30 Thread Simone Gaiarin
simgunz added a comment. I found some time to implement the suggestions given by @dfaure and I removed all the static_cast. I haven't implemented any UI change for now. I think that if there are not problems we can land it as it is now, and then improve the UI in a second moment (in few

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

2017-12-30 Thread Simone Gaiarin
simgunz updated this revision to Diff 24488. simgunz marked 8 inline comments as done. simgunz added a comment. - Avoid cast by using member var to proxyModel - Initialize m_proxyModel to null pointer - Add access method to m_proxyModel, use it to avoid cast - Remove unuseful returns,

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

2017-12-07 Thread Henrik Fehlauer
rkflx added a comment. No problem at all :) Good luck with your thesis! REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8056 To: simgunz, dfaure, #frameworks, #vdg, ngraham, rkflx Cc: rkflx, subdiff, fabianr, abetts, ngraham, alexeymin, #frameworks

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

2017-12-07 Thread Simone Gaiarin
simgunz added a comment. The deadline of my PhD thesis is very close, so my free time is basically zero in this period. Unfortunately, I didn't manage to complete these reviews before entering this critical period. In January I should have free time and I'll complete this. I also can't wait

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

2017-12-06 Thread Nathaniel Graham
ngraham added a comment. @simgunz, how are we doing on addressing the latest review comments? I just love this new UI; it's a huge improvement over the status quo IMHO, and it would be nice to get it in sometime soon. REPOSITORY R241 KIO REVISION DETAIL

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

2017-11-16 Thread Henrik Fehlauer
rkflx added a comment. IMHO the problem is not so much in the single text field, but how/where the results are presented. (Sorry I haven't got around to open the task yet. I did not forget, but Okular was more important last weekend…) REPOSITORY R241 KIO REVISION DETAIL

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

2017-11-16 Thread Nathaniel Graham
ngraham added a comment. If the ability to add a custom path is important, maybe we should put that under "Terminal options". I don't think we're ever going to figure out a functional UI for that single text field to work equally well for searching and entering a path with history.

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

2017-11-08 Thread Henrik Fehlauer
rkflx added a comment. In https://phabricator.kde.org/D8056#165453, @simgunz wrote: > Is it there a way to make my contact info in kde identity public? I couldn't find an option for it. There is no such option yet, as far as I know. Turns out as you used `arc` to upload your

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

2017-11-08 Thread David Faure
dfaure added inline comments. INLINE COMMENTS > simgunz wrote in kopenwithdialog.cpp:463 > Segmentation fault happens if I use the member var. Accessing the member var > is the cause of the fault, because even `qDebug() << d->m_proxyModel` > generates the same error. It is not clear to me why.

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

2017-11-08 Thread Simone Gaiarin
simgunz added inline comments. INLINE COMMENTS > dfaure wrote in kopenwithdialog.cpp:463 > Use the member var instead of casting. Segmentation fault happens if I use the member var. Accessing the member var is the cause of the fault, because even `qDebug() << d->m_proxyModel` generates the

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

2017-11-07 Thread David Faure
dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kopenwithdialog.cpp:463 > > -if (d->appModel && !d->appModel->isDirectory(current)) { > -QString exec = d->appModel->execFor(current); > +

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

2017-11-07 Thread David Faure
dfaure added a comment. Yes, feel free to kill the hidden setting for completion, especially if the default value isn't the one that gives the best user experience. REPOSITORY R241 KIO BRANCH openwithdialog-filter-app-tree REVISION DETAIL https://phabricator.kde.org/D8056 To:

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

2017-11-07 Thread Nathaniel Graham
ngraham added a comment. IMO popup completion is rendered obsolete by the new filter behavior, which is much nicer. We might consider just removing it. REPOSITORY R241 KIO BRANCH openwithdialog-filter-app-tree REVISION DETAIL https://phabricator.kde.org/D8056 To: simgunz, dfaure,

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

2017-11-07 Thread Simone Gaiarin
simgunz marked an inline comment as done. simgunz added a comment. > @simgunz If you have no further changes planned for this Diff and https://phabricator.kde.org/D8670, I could land both on your behalf. Contact information of non-developers are private by default on identity.kde.org, but I

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

2017-11-07 Thread Nathaniel Graham
ngraham accepted this revision. REPOSITORY R241 KIO BRANCH openwithdialog-filter-app-tree REVISION DETAIL https://phabricator.kde.org/D8056 To: simgunz, dfaure, #frameworks, #vdg, ngraham, rkflx Cc: rkflx, subdiff, fabianr, abetts, ngraham, alexeymin, #frameworks

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

2017-11-07 Thread Henrik Fehlauer
rkflx accepted this revision. rkflx added a comment. @dfaure Could we get your green (for real, on Phab :) light from a Frameworks point of view for this Diff? @simgunz If you have no further changes planned for this Diff and https://phabricator.kde.org/D8670, I could land both on your

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

2017-11-06 Thread Simone Gaiarin
simgunz marked an inline comment as done. simgunz added a comment. @rkflx I agree on all your points. In general I also prefer to have the categories. Implementing what you propose will require a bit of time. Basically if we want any behavior different from the current one, we need to

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

2017-11-06 Thread Simone Gaiarin
simgunz updated this revision to Diff 21990. simgunz marked an inline comment as done. simgunz added a comment. - Use fixed string case insensitive filter REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8056?vs=21925=21990 BRANCH

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

2017-11-06 Thread Henrik Fehlauer
rkflx added a comment. @abetts @simgunz If you agree with my ideas in general and also with doing those in followup patches, please add a short comment. I'll then open a task on some of Phab's workboards which is better suited for tracking the discussion than some random comment ;)

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

2017-11-06 Thread Nathaniel Graham
ngraham added a comment. In https://phabricator.kde.org/D8056#165014, @rkflx wrote: > That said, I would suggest to just commit this patch as is and work on any further improvements in a followup patch +1, no need to get bogged down making it perfect in the first patch.

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

2017-11-06 Thread Henrik Fehlauer
rkflx added a comment. Gave this a spin, it's a really nice improvement. As for the categories, I do not feel they "get in the way", because: - In most cases, even after only typing three letters there is only one result left, which is already preselected so [Enter] will accept

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

2017-11-05 Thread Simone Gaiarin
simgunz added a comment. I have fixed what dfaure suggested. I couldn't remove the cast at line 463 because a Segmentation fault happens. It is not clear to me why exactly. Regarding removing the categories I need to work on that, because it is not trivial apparently. I thought it was

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

2017-11-05 Thread Simone Gaiarin
simgunz updated this revision to Diff 21925. simgunz marked 4 inline comments as done. simgunz added a comment. - Fix code styling - Set appModel and proxyModel together, store proxyModel in data member - Avoid casts using pointer to proxyModel REPOSITORY R241 KIO CHANGES SINCE LAST

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

2017-11-04 Thread Andres Betts
abetts added a comment. In https://phabricator.kde.org/D8056#164287, @ngraham wrote: > I would say make the categories disappear as soon as that view displays search results. Yeah, because in the end, when you want to narrow down the results, the categories will get in your way

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

2017-11-04 Thread Nathaniel Graham
ngraham added a comment. I would say make the categories disappear as soon as that view displays search results. REPOSITORY R241 KIO BRANCH openwithdialog-filter-app-tree REVISION DETAIL https://phabricator.kde.org/D8056 To: simgunz, dfaure, #frameworks, #vdg, ngraham Cc: subdiff,

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

2017-11-04 Thread Simone Gaiarin
simgunz added a comment. Can you be more specific? Currently, the categories are expanded automatically after 3 characters have been typed. Do you want to make the categories disappear at this point? Or not having them from the beginning? REPOSITORY R241 KIO BRANCH

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

2017-11-04 Thread Nathaniel Graham
ngraham added a comment. In https://phabricator.kde.org/D8056#164283, @abetts wrote: > Can I suggest to maybe simplify even a little more and remove the category separators? AKA, system, internet? +1 totally agree. REPOSITORY R241 KIO BRANCH openwithdialog-filter-app-tree

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

2017-11-04 Thread Andres Betts
abetts added a comment. Can I suggest to maybe simplify even a little more and remove the category separators? AKA, system, internet? REPOSITORY R241 KIO BRANCH openwithdialog-filter-app-tree REVISION DETAIL https://phabricator.kde.org/D8056 To: simgunz, dfaure, #frameworks, #vdg,

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

2017-11-04 Thread Simone Gaiarin
simgunz marked 9 inline comments as done. simgunz added a comment. I fixed most of them. I think I'll have time tomorrow. INLINE COMMENTS > dfaure wrote in kopenwithdialog.cpp:398 > Ah. Filipe and I implemented recursive filtering in QSortFilterProxyModel but > that's only in Qt 5.10. Too

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

2017-11-04 Thread Nathaniel Graham
ngraham edited the summary of this revision. REPOSITORY R241 KIO BRANCH openwithdialog-filter-app-tree REVISION DETAIL https://phabricator.kde.org/D8056 To: simgunz, dfaure, #frameworks, #vdg, ngraham Cc: subdiff, fabianr, abetts, ngraham, alexeymin, #frameworks

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

2017-11-04 Thread Nathaniel Graham
ngraham added a comment. @simgunz have you had a chance to work on @dfaure's comments? It would be great to get this in. REPOSITORY R241 KIO BRANCH openwithdialog-filter-app-tree REVISION DETAIL https://phabricator.kde.org/D8056 To: simgunz, dfaure, #frameworks, #vdg, ngraham Cc:

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

2017-10-29 Thread David Faure
dfaure added a comment. Looks good, just some coding style issues. INLINE COMMENTS > kopenwithdialog.cpp:195 > d->fillNode(QString(), d->root); > +for (int i=0; i +fetchAll(index(i,0)); spaces around '=' and '<' I would put rowCount() into a local var,

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

2017-10-27 Thread Simone Gaiarin
simgunz added a comment. > Can we not just remove the drop down menu and always show the checkbox for terminal? Actually I've just changed that behaviour few months ago to follow the "simple by default, powerful when needed" philosophy. See this review and the related bug for the

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

2017-10-27 Thread Roman Gilg
subdiff added a comment. In https://phabricator.kde.org/D8056#159636, @fabianr wrote: > Not really on topic, but could you change the label for the "Advanced options" to something more meaningful, eg "Terminal options" ? The HIG recommends not to use the label "Advanced options", but "

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

2017-10-27 Thread Simone Gaiarin
simgunz added a comment. @ngraham Great! I don't have commit access. @fabianr I agree on changing that label to "Terminal options". I'll send a new revision request for that. REPOSITORY R241 KIO BRANCH openwithdialog-filter-app-tree REVISION DETAIL

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

2017-10-26 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. This is fantastic work. I'm running with it full time now and can't imagine going back to the old one. Huge +1 from me. Do you have commit access? REPOSITORY R241 KIO BRANCH

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

2017-10-25 Thread Fabian Riethmayer
fabianr added a comment. Not really on topic, but could you change the label for the "Advanced options" to something more meaningful, eg "Terminal options" ? The HIG recommends not to use the label "Advanced options", but " Use a descriptive label so that it reflects the functionality. "

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

2017-10-24 Thread Simone Gaiarin
simgunz added a comment. Ok. Now it should work properly. I've also added a tooltip to the search box to explain the down arrow feature so that it is not hidden. The current text is: "Type some text to filter the application tree.\nPress down arrow to navigate the results tree."

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

2017-10-24 Thread Simone Gaiarin
simgunz updated this revision to Diff 21261. simgunz added a comment. - Automatically select first match of the filter - ArrowDown on lineEdit pass focus to QTreeView - Add tooltip to explain how to use the search filter REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

2017-10-24 Thread Simone Gaiarin
simgunz added a comment. Here is a picture: F5448036: openwith_filter.png REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8056 To: simgunz, dfaure, #frameworks, #vdg, ngraham Cc: abetts, ngraham, alexeymin, #frameworks

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

2017-10-23 Thread Andres Betts
abetts added a comment. Can you guys add a quick picture of what this looks like right now? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8056 To: simgunz, dfaure, #frameworks, #vdg, ngraham Cc: abetts, ngraham, alexeymin, #frameworks

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

2017-10-23 Thread Nathaniel Graham
ngraham added a comment. Sounds great, thanks! REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8056 To: simgunz, dfaure, #frameworks, #vdg, ngraham Cc: ngraham, alexeymin, #frameworks

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

2017-10-23 Thread Simone Gaiarin
simgunz added a comment. In https://phabricator.kde.org/D8056#158939, @ngraham wrote: > @simgunz, have you had a chance to try implementing David's suggestion? Yes. Everything seems to work but I haven't pushed yesterday because I wanted to do an extra test. The current

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

2017-10-23 Thread Nathaniel Graham
ngraham added a comment. @simgunz, have you had a chance to try implementing David's suggestion? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8056 To: simgunz, dfaure, #frameworks, #vdg, ngraham Cc: ngraham, alexeymin, #frameworks

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

2017-10-23 Thread Nathaniel Graham
ngraham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8056 To: simgunz, dfaure, #frameworks, #vdg, ngraham Cc: ngraham, alexeymin, #frameworks

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

2017-10-15 Thread David Faure
dfaure added a comment. You can send (forward) a key event to a widget (like the QTreeView) using qApp->sendEvent(), rather than trying to call the protected method keyPressEvent() directly. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8056 To: simgunz, dfaure,

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

2017-10-15 Thread Nathaniel Graham
ngraham added a comment. No worries, take your time. :) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8056 To: simgunz, dfaure, #frameworks, #vdg, ngraham Cc: ngraham, alexeymin, #frameworks

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

2017-10-15 Thread Simone Gaiarin
simgunz added a comment. In https://phabricator.kde.org/D8056#155537, @ngraham wrote: > Any progress? This is too good a change to not merge. :) Today I finally had the time to work on this and I've implemented the "select first result by default" and it seems to work nicely.

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

2017-10-14 Thread Nathaniel Graham
ngraham added a comment. Any progress? This is too good a change to not merge. :) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8056 To: simgunz, dfaure, #frameworks, #vdg, ngraham Cc: ngraham, alexeymin, #frameworks

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

2017-10-02 Thread Simone Gaiarin
simgunz added a comment. > I see what you mean. How about implementing "down-arrow-changes-focus" only when not using dropdown completion? Seems ok. I'll implement it this way soon. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8056 To: simgunz, dfaure,

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

2017-10-01 Thread Nathaniel Graham
ngraham added a comment. In https://phabricator.kde.org/D8056#151057, @simgunz wrote: > > - When the text field has focus, make the down arrow key move to the list of found results so that you can select one with the keyboard and not have to use the mouse at all > > I like the idea

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

2017-10-01 Thread Simone Gaiarin
simgunz added a comment. > - When the text field has focus, make the down arrow key move to the list of found results so that you can select one with the keyboard and not have to use the mouse at all I like the idea and in my personal opinion it should behave as you suggest, but before

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

2017-09-30 Thread Nathaniel Graham
ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. I gave this a shot and it's an excellent change--a huge improvement over the status quo. I have two suggestions for further ergonomic refinement: - When the text field has

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

2017-09-29 Thread Nathaniel Graham
ngraham added reviewers: Frameworks, VDG. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8056 To: simgunz, dfaure, #frameworks, #vdg Cc: alexeymin, #frameworks

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

2017-09-29 Thread Simone Gaiarin
simgunz edited the test plan for this revision. simgunz added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8056 To: simgunz, dfaure Cc: #frameworks

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

2017-09-29 Thread Simone Gaiarin
simgunz created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY The current "open with" dialog implementation does not follow the KDE principle "Simple by default, powerful when needed" for the following