D7380: KCD: use modern logging classes throughout

[René J . V . Bertin]

rjvbb updated this revision to Diff 45221.
rjvbb added a comment.


  refactored for master/head

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7380?vs=18470&id=45221

REVISION DETAIL
  https://phabricator.kde.org/D7380

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/kcompactdisc.cpp
  src/kcompactdisc_p.cpp
  src/kcompactdisc_p.h
  src/phonon_interface.cpp
  src/wmlib_interface.cpp
  tests/testkcd.cpp

To: rjvbb, #frameworks, davidedmundson, ltoscano
Cc: dfaure, ltoscano, davidedmundson

D7380: KCD: use modern logging classes throughout

[René J . V . Bertin]

rjvbb set the repository for this revision to R349 KCompactDisc Library.

REPOSITORY
  R349 KCompactDisc Library

REVISION DETAIL
  https://phabricator.kde.org/D7380

To: rjvbb, #frameworks, davidedmundson, ltoscano
Cc: dfaure, ltoscano, davidedmundson

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.10 - Build # 125 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.10/125/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 10 Nov 2018 08:54:02 +
 Build duration:
9 min 56 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: TestSuite.scalable
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)78%
(234/300)58%
(106/182)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionals100%
(1/1)100%
(1/1)74%
(42/57)56%
(10/18)autotests100%
(5/5)100%
(5/5)79%
(192/243)59%
(96/164)

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.10 - Build # 126 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.10/126/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 10 Nov 2018 08:55:11 +
 Build duration:
19 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 24 test(s)Failed: TestSuite.kdirwatch_qfswatch_unittestFailed: TestSuite.kdirwatch_stat_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)85%
(69/81)85%
(69/81)75%
(6331/8431)43%
(10151/23429)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(26/28)93%
(26/28)97%
(2701/2777)49%
(5801/11903)src.desktoptojson100%
(2/2)100%
(2/2)78%
(88/113)38%
(123/326)src.lib50%
(1/2)50%
(1/2)61%
(351/572)26%
(243/928)src.lib.caching100%
(2/2)100%
(2/2)45%
(354/784)18%
(184/1044)src.lib.io82%
(9/11)82%
(9/11)68%
(854/1265)37%
(1041/2797)src.lib.jobs71%
(5/7)71%
(5/7)57%
(160/281)38%
(52/138)src.lib.plugin100%
(7/7)100%
(7/7)85%
(654/770)42%
(975/2317)src.lib.randomness100%
(2/2)100%
(2/2)70%
(67/96)58%
(44/76)src.lib.text63%
(5/8)63%
(5/8)48%
(374/784)45%
(864/1927)src.lib.util100%
(10/10)100%
(10/10)81%
(728/904)52%
(824/1575)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/398)

KDE CI: Frameworks » kdoctools » kf5-qt5 SUSEQt5.10 - Build # 64 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdoctools/job/kf5-qt5%20SUSEQt5.10/64/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 10 Nov 2018 08:56:01 +
 Build duration:
20 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 3 test(s)Failed: TestSuite.kdoctools_install
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(1/1)67%
(4/6)67%
(4/6)68%
(335/490)48%
(138/287)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalssrc67%
(4/6)67%
(4/6)68%
(335/490)48%
(138/287)

D16196: add a description property to KFileMetaData

[Alexander Stippich]

astippich added a comment.


  ping

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D16196

To: astippich, mgallien, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

KDE CI: Frameworks » kdelibs4support » kf5-qt5 SUSEQt5.10 - Build # 75 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20SUSEQt5.10/75/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 10 Nov 2018 08:55:35 +
 Build duration:
21 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 39 test(s), Skipped: 0 test(s), Total: 40 test(s)Failed: TestSuite.ktabwidget_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report29%
(4/14)43%
(124/291)43%
(124/291)47%
(21615/45959)38%
(13051/34249)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionals0%
(0/1)0%
(0/1)0%
(0/87)0%
(0/56)autotests98%
(44/45)98%
(44/45)97%
(11364/11759)50%
(7174/14375)src0%
(0/1)0%
(0/1)0%
(0/4)0%
(0/2)src.kdebugdialog0%
(0/7)0%
(0/7)0%
(0/256)0%
(0/73)src.kdecore76%
(65/86)76%
(65/86)53%
(9476/17864)48%
(5546/11459)src.kdeui19%
(13/68)19%
(13/68)8%
(765/9694)6%
(330/5364)src.kio7%
(2/27)7%
(2/27)0%
(10/2258)0%
(1/1238)src.kioslave.metainfo0%
(0/1)0%
(0/1)0%
(0/32)0%
(0/4)src.kparts0%
(0/1)0%
(0/1)0%
(0/24)0%
(0/12)src.kssl0%
(0/8)0%
(0/8)0%
(0/1807)0%
(0/853)src.kssl.kcm0%
(0/3)0%
(0/3)0%
(0/264)0%
(0/145)src.solid0%
(0/3)0%
(0/3)0%
(0/188)0%
(0/87)src.solid-networkstatus.kded0%
(0/6)0%
(0/6)0%
(0/185)0%
(0/94)tests0%
(0/34)0%
(0/34)0%
(0/1537)0%
(0/487)

D7407: audiocd-kio : modernise debugging

[René J . V . Bertin]

rjvbb abandoned this revision.
rjvbb added a comment.


  Done by someone else by now.

REPOSITORY
  R342 KIO AudioCD

REVISION DETAIL
  https://phabricator.kde.org/D7407

To: rjvbb, #frameworks
Cc: ltoscano

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.10 - Build # 87 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.10/87/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 10 Nov 2018 08:57:56 +
 Build duration:
30 min and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 12 test(s)Failed: TestSuite.testfallbackpackage-appstreamFailed: TestSuite.testpackage-appstreamFailed: TestSuite.testpackage-nodisplay-appstream
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(5/5)95%
(18/19)95%
(18/19)72%
(1538/2132)51%
(1075/2120)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(6/6)100%
(6/6)99%
(537/539)51%
(243/472)autotests.mockdepresolver100%
(1/1)100%
(1/1)78%
(14/18)58%
(7/12)src.kpackage75%
(3/4)75%
(3/4)74%
(558/755)64%
(598/935)src.kpackage.private100%
(6/6)100%
(6/6)79%
(284/358)49%
(96/195)src.kpackagetool100%
(2/2)100%
(2/2)31%
(145/462)26%
(131/506)

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 470 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/470/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 10 Nov 2018 08:56:58 +
 Build duration:
31 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 60 test(s), Skipped: 0 test(s), Total: 61 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesviewtest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(262/398)66%
(262/398)53%
(31984/59911)38%
(16521/43948)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9105/9545)48%
(4276/8954)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)58%
(8317/14286)50%
(4660/9247)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)49%
(3884/7926)34%
(1592/4711)src.gui100%
(2/2)100%
(2/2)94%
(103/109)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(525/1019)37%
(315/850)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1344)0%
(0/1416)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1770/4295)35%
(1304/3692)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1331)55%
(626/1135)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
(0/12)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/32)src.ioslaves.trash56%
(5/9)56%
(5/9)50%
 

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.10 - Build # 52 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.10/52/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 10 Nov 2018 08:59:11 +
 Build duration:
33 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 12 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.kwindowsystem-kwindowinfox11testFailed: TestSuite.kwindowsystem-netrootinfotestwm
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(4/6)80%
(43/54)80%
(43/54)75%
(7100/9494)55%
(3472/6353)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests88%
(15/17)88%
(15/17)96%
(3005/3137)51%
(1260/2454)autotests.helper100%
(1/1)100%
(1/1)70%
(7/10)50%
(3/6)src92%
(12/13)92%
(12/13)56%
(774/1377)45%
(293/658)src.platforms.wayland0%
(0/2)0%
(0/2)0%
(0/70)100%
(0/0)src.platforms.xcb94%
(15/16)94%
(15/16)71%
(3314/4657)60%
(1916/3209)tests0%
(0/5)0%
(0/5)0%
(0/243)0%
(0/26)

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.10 - Build # 106 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.10/106/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 10 Nov 2018 08:59:01 +
 Build duration:
33 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 44 test(s), Skipped: 0 test(s), Total: 46 test(s)Failed: TestSuite.kwayland-testPlasmaVirtualDesktopFailed: TestSuite.kwayland-testPlasmaWindowModel
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report63%
(5/8)91%
(234/257)91%
(234/257)85%
(24876/29182)53%
(9893/18812)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client98%
(41/42)98%
(41/42)97%
(11703/12057)49%
(6217/12589)autotests.server100%
(5/5)100%
(5/5)99%
(353/356)49%
(169/344)src.client97%
(71/73)97%
(71/73)83%
(5733/6934)64%
(1506/2370)src.compat100%
(2/2)100%
(2/2)100%
(81/81)100%
(0/0)src.server99%
(115/116)99%
(115/116)85%
(7006/8245)65%
(2001/3094)src.tools0%
(0/2)0%
(0/2)0%
(0/693)0%
(0/272)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/69)0%
(0/10)tests0%
(0/14)0%
(0/14)0%
(0/747)0%
(0/133)

D12114: Revive 'Description' property for DublinCore metadata

[Alexander Stippich]

astippich added inline comments.

INLINE COMMENTS

> bruns wrote in office2007extractortest.cpp:52
> Strictly speaking, this should be part of another commit.
> Feel free to split it off and git push without review.

Just to let you know, I'm currently having issues creating a new test file. 
Saving with LibreOffice to .docx causes an incorrect mime type of the file, 
which is also reflected in this diff (see below). This seems to be a bug in 
LibreOffice. Looks like I have to use MS Word here.

REPOSITORY
  R286 KFileMetaData

BRANCH
  description_dc

REVISION DETAIL
  https://phabricator.kde.org/D12114

To: astippich, #baloo, #frameworks, bruns
Cc: kde-frameworks-devel, bruns, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, abrahams

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.9 - Build # 65 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.9/65/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Sat, 10 Nov 2018 08:57:56 +
 Build duration:
50 min and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 12 test(s)Failed: TestSuite.testfallbackpackage-appstreamFailed: TestSuite.testpackage-appstreamFailed: TestSuite.testpackage-nodisplay-appstream
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(5/5)95%
(18/19)95%
(18/19)72%
(1538/2132)51%
(1075/2120)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(6/6)100%
(6/6)99%
(537/539)51%
(243/472)autotests.mockdepresolver100%
(1/1)100%
(1/1)78%
(14/18)58%
(7/12)src.kpackage75%
(3/4)75%
(3/4)74%
(558/755)64%
(598/935)src.kpackage.private100%
(6/6)100%
(6/6)79%
(284/358)49%
(96/195)src.kpackagetool100%
(2/2)100%
(2/2)31%
(145/462)26%
(131/506)

KDE CI: Frameworks » kauth » kf5-qt5 WindowsMSVCQt5.11 - Build # 14 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kauth/job/kf5-qt5%20WindowsMSVCQt5.11/14/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Sat, 10 Nov 2018 08:54:40 +
 Build duration:
59 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: TestSuite.KAuthHelperTest

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.9 - Build # 69 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.9/69/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Sat, 10 Nov 2018 08:54:02 +
 Build duration:
1 hr 10 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: TestSuite.scalable
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)78%
(234/300)58%
(106/182)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionals100%
(1/1)100%
(1/1)74%
(42/57)56%
(10/18)autotests100%
(5/5)100%
(5/5)79%
(192/243)59%
(96/164)

KDE CI: Frameworks » kdelibs4support » kf5-qt5 SUSEQt5.9 - Build # 49 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20SUSEQt5.9/49/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Sat, 10 Nov 2018 08:55:35 +
 Build duration:
1 hr 18 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 39 test(s), Skipped: 0 test(s), Total: 40 test(s)Failed: TestSuite.ktabwidget_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report29%
(4/14)43%
(124/291)43%
(124/291)47%
(21750/45961)38%
(13184/34249)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionals0%
(0/1)0%
(0/1)0%
(0/87)0%
(0/56)autotests98%
(44/45)98%
(44/45)98%
(11469/11759)50%
(7254/14375)src0%
(0/1)0%
(0/1)0%
(0/4)0%
(0/2)src.kdebugdialog0%
(0/7)0%
(0/7)0%
(0/256)0%
(0/73)src.kdecore76%
(65/86)76%
(65/86)53%
(9506/17866)49%
(5599/11459)src.kdeui19%
(13/68)19%
(13/68)8%
(765/9694)6%
(330/5364)src.kio7%
(2/27)7%
(2/27)0%
(10/2258)0%
(1/1238)src.kioslave.metainfo0%
(0/1)0%
(0/1)0%
(0/32)0%
(0/4)src.kparts0%
(0/1)0%
(0/1)0%
(0/24)0%
(0/12)src.kssl0%
(0/8)0%
(0/8)0%
(0/1807)0%
(0/853)src.kssl.kcm0%
(0/3)0%
(0/3)0%
(0/264)0%
(0/145)src.solid0%
(0/3)0%
(0/3)0%
(0/188)0%
(0/87)src.solid-networkstatus.kded0%
(0/6)0%
(0/6)0%
(0/185)0%
(0/94)tests0%
(0/34)0%
(0/34)0%
(0/1537)0%
(0/487)

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.9 - Build # 70 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.9/70/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Sat, 10 Nov 2018 08:55:11 +
 Build duration:
1 hr 21 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 23 test(s), Skipped: 0 test(s), Total: 24 test(s)Failed: TestSuite.kdirwatch_qfswatch_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)85%
(69/81)85%
(69/81)75%
(6332/8431)43%
(10151/23425)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(26/28)93%
(26/28)97%
(2701/2777)49%
(5802/11905)src.desktoptojson100%
(2/2)100%
(2/2)78%
(88/113)38%
(122/322)src.lib50%
(1/2)50%
(1/2)62%
(352/572)26%
(243/924)src.lib.caching100%
(2/2)100%
(2/2)45%
(354/784)18%
(184/1044)src.lib.io82%
(9/11)82%
(9/11)68%
(854/1265)37%
(1043/2803)src.lib.jobs71%
(5/7)71%
(5/7)57%
(160/281)38%
(52/138)src.lib.plugin100%
(7/7)100%
(7/7)85%
(654/770)42%
(975/2315)src.lib.randomness100%
(2/2)100%
(2/2)70%
(67/96)58%
(44/76)src.lib.text63%
(5/8)63%
(5/8)48%
(374/784)45%
(863/1927)src.lib.util100%
(10/10)100%
(10/10)81%
(728/904)52%
(823/1573)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/398)

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.9 - Build # 40 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.9/40/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Sat, 10 Nov 2018 08:59:11 +
 Build duration:
1 hr 38 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 12 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.kwindowsystem-kwindowinfox11testFailed: TestSuite.kwindowsystem-netrootinfotestwm
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(4/6)80%
(43/54)80%
(43/54)75%
(7101/9494)55%
(3475/6353)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests88%
(15/17)88%
(15/17)96%
(3005/3137)51%
(1262/2454)autotests.helper100%
(1/1)100%
(1/1)70%
(7/10)50%
(3/6)src92%
(12/13)92%
(12/13)56%
(774/1377)45%
(293/658)src.platforms.wayland0%
(0/2)0%
(0/2)0%
(0/70)100%
(0/0)src.platforms.xcb94%
(15/16)94%
(15/16)71%
(3315/4657)60%
(1917/3209)tests0%
(0/5)0%
(0/5)0%
(0/243)0%
(0/26)

D16798: KPluginFactory: fix create() apidox

[Elvis Angelaccio]

elvisangelaccio created this revision.
elvisangelaccio added reviewers: dfaure, apol.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
elvisangelaccio requested review of this revision.

REVISION SUMMARY
  `kFatal()` is long gone and was not ported to `qFatal()`.
  If there are multiple plugin choices without a keyword,
  the function just returns nullptr.

REPOSITORY
  R244 KCoreAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16798

AFFECTED FILES
  src/lib/plugin/kpluginfactory.h

To: elvisangelaccio, dfaure, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16798: KPluginFactory: fix create() apidox

[Elvis Angelaccio]

elvisangelaccio added a comment.


  Note: I'm not 100% the code actually returns `nullptr`, so someone please 
double check.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D16798

To: elvisangelaccio, dfaure, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.9 - Build # 80 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.9/80/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Sat, 10 Nov 2018 08:59:01 +
 Build duration:
1 hr 49 min and counting
   JUnit Tests
  Name: (root) Failed: 4 test(s), Passed: 42 test(s), Skipped: 0 test(s), Total: 46 test(s)Failed: TestSuite.kwayland-testPlasmaVirtualDesktopFailed: TestSuite.kwayland-testPlasmaWindowModelFailed: TestSuite.kwayland-testRemoteAccessFailed: TestSuite.kwayland-testWaylandSurface
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report63%
(5/8)90%
(231/257)90%
(231/257)79%
(22945/29116)47%
(8921/18812)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client93%
(39/42)93%
(39/42)86%
(10309/12050)43%
(5463/12589)autotests.server100%
(5/5)100%
(5/5)99%
(353/356)49%
(169/344)src.client96%
(70/73)96%
(70/73)78%
(5381/6903)57%
(1340/2370)src.compat100%
(2/2)100%
(2/2)100%
(81/81)100%
(0/0)src.server99%
(115/116)99%
(115/116)83%
(6821/8217)63%
(1949/3094)src.tools0%
(0/2)0%
(0/2)0%
(0/693)0%
(0/272)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/69)0%
(0/10)tests0%
(0/14)0%
(0/14)0%
(0/747)0%
(0/133)

KDE CI: Frameworks » knotifications » kf5-qt5 WindowsMSVCQt5.11 - Build # 12 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/knotifications/job/kf5-qt5%20WindowsMSVCQt5.11/12/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Sat, 10 Nov 2018 08:57:46 +
 Build duration:
2 hr 13 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: TestSuite.KNotificationTest

D16798: KPluginFactory: fix create() apidox

[David Faure]

dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> kpluginfactory.h:347
>   * Use this method to create an object. It will try to create an object 
> which inherits
> - * \p T. If it has multiple choices, you will get a fatal error 
> (kFatal()), so be careful
> + * \p T. If it has multiple choices, you will get a @c nullptr, so be 
> careful
>   * to request a unique interface or use keywords.

I don't see that the code returns nullptr in this case, no.

Seems to me that it gets into kpluginfactory.cpp:143 which issues a qWarning 
[git log says I ported from kFatal to qWarning, not sure why, I guess I was 
doing like in Qt, bad API usage = warning, use QT_FATAL_WARNINGS if you want to 
abort on warnings]. The code then returns the last one of the candidates, but 
order is undefined, so the docu should say that it's not defined which object 
is returned.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D16798

To: elvisangelaccio, dfaure, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16801: Fix build on macOS

[Harald Fernengel]

harald created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
harald requested review of this revision.

REVISION SUMMARY
  On macOS, I'm getting the following error:
  
CMake Error at src/runtime/plugins/CMakeLists.txt:1 (if):
  if given arguments:

"AND" "AND"

  Unknown arguments specified
  
  The reason is the double expansion of arguments in CMake, so instead of `if 
(${FOO})` one should write `if(FOO)`.
  
  This patch fixes the build.

TEST PLAN
  Running `cmake` on Mac OS X passes.

REPOSITORY
  R268 KGlobalAccel

REVISION DETAIL
  https://phabricator.kde.org/D16801

AFFECTED FILES
  src/runtime/plugins/CMakeLists.txt

To: harald
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16798: KPluginFactory: fix create() apidox

[Elvis Angelaccio]

elvisangelaccio updated this revision to Diff 45232.
elvisangelaccio added a comment.


  - Address comment

REPOSITORY
  R244 KCoreAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16798?vs=45222&id=45232

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16798

AFFECTED FILES
  src/lib/plugin/kpluginfactory.h

To: elvisangelaccio, dfaure, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16798: KPluginFactory: fix create() apidox

[Elvis Angelaccio]

elvisangelaccio edited the summary of this revision.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D16798

To: elvisangelaccio, dfaure, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16798: KPluginFactory: fix create() apidox

[Elvis Angelaccio]

elvisangelaccio marked an inline comment as done.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D16798

To: elvisangelaccio, dfaure, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D12114: Revive 'Description' property for DublinCore metadata

[Alexander Stippich]

astippich updated this revision to Diff 45234.
astippich added a comment.


  - revert docx test data for now

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12114?vs=44834&id=45234

BRANCH
  description_dc

REVISION DETAIL
  https://phabricator.kde.org/D12114

AFFECTED FILES
  autotests/epubextractortest.cpp
  autotests/odfextractortest.cpp
  autotests/office2007extractortest.cpp
  autotests/samplefiles/test.odt
  src/extractors/dublincoreextractor.cpp
  src/extractors/epubextractor.cpp
  src/extractors/odfextractor.cpp
  src/extractors/office2007extractor.cpp

To: astippich, #baloo, #frameworks, bruns
Cc: kde-frameworks-devel, bruns, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, abrahams

D12114: Revive 'Description' property for DublinCore metadata

[Alexander Stippich]

astippich added a comment.


  I've reverted the test data for docx format for now, since there are 
apparently more issues. Funnily, LibreOffice and MS Word label the description 
property with "Comment".

REPOSITORY
  R286 KFileMetaData

BRANCH
  description_dc

REVISION DETAIL
  https://phabricator.kde.org/D12114

To: astippich, #baloo, #frameworks, bruns
Cc: kde-frameworks-devel, bruns, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, abrahams

D16564: cleanup the test for embedded image extraction

[Alexander Stippich]

This revision was automatically updated to reflect the committed changes.
Closed by commit R286:218f4c51c4db: cleanup the test for embedded image 
extraction (authored by astippich).

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16564?vs=44587&id=45235

REVISION DETAIL
  https://phabricator.kde.org/D16564

AFFECTED FILES
  autotests/embeddedimagedatatest.cpp
  autotests/embeddedimagedatatest.h

To: astippich, #frameworks, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D16671: Refactor embedded image extractor for greater extensibility

[Alexander Stippich]

astippich added inline comments.

INLINE COMMENTS

> bruns wrote in embeddedimagedata.cpp:204
> I know you have only moved this code here ...
> 
> `TagLib::ByteVector::find` returns `-1` on not found, and we add 1, so this 
> is safe here. But maybe we should return `QByteArray()` instead?

The code also works if only the picture data is there without the name.
I could return an empty QByteArray if dataPosition == -1 and pictureData.size 
== 0.
Do you prefer if I do that separately?

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D16671

To: astippich, mgallien, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D16716: skip writing test if mime type is not supported by the extractor

[Alexander Stippich]

astippich added a comment.


  I think that's my fault when I introduced the extractor for test. Apparently 
it is using the system libraries, and I'm looking for a solution.
  I think a skip is still the right thing to do here, since we cannot determine 
if the tags are correctly written.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D16716

To: astippich, mgallien, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D16617: fix extraction of GPS altitude for exif data

[Alexander Stippich]

astippich added inline comments.

INLINE COMMENTS

> bruns wrote in exiv2extractor.cpp:285
> According to:
> https://www.sno.phy.queensu.ca/~phil/exiftool/TagNames/GPS.html
> and
> http://www.cipa.jp/std/documents/e/DC-008-Translation-2016-E.pdf
> 
> the absolute altitude value is a rational, like deg/min/sec.

true, but why not use the converted value directly? Otherwise the conversion 
would have to be made manually by dividing, see fetchGpsDouble()

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D16617

To: astippich, #frameworks, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D8912: Added a set of Game Folder icons

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  Phabricator unfortunately doesn't offer SVG previews, so posting new 
screenshots every time you update the diff is appreciated. :)
  
  Also, if you don't already know about it, let me introduce you to the 
Cuttlefish tool. You can generally find it by searching for "Cuttlefish" in 
Discover. If not, it usually a part of the plasma-sdk package. It's an icon 
visualization app that really makes this workflow a breeze. Here's a screenshot 
of what I can use it to see:
  
  F6410693: icon.png 
  
  Don't worry about the fact that the smallest size is visual mush; that's the 
8px version which in practice won't be used for a folder icon. But there is a 
real problem the small line-art representations don't change their color 
properly in the dark version:
  
  F6410698: icon dark.png 
  
  There's a CSS stylesheet you have to add to it to make this happen. @ndavis 
can help with this.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D8912

To: andreyorst, #vdg, ngraham
Cc: bruns, ngraham, kde-frameworks-devel, ndavis, michaelh

D8912: Added a set of Game Folder icons

[Andrey Orst]

andreyorst added a comment.


  > Phabricator unfortunately doesn't offer SVG previews, so posting new 
screenshots every time you update the diff is appreciated. :)
  
  Got it.
  
  > You can generally find it by searching for "Cuttlefish" in Discover.
  
  I've had so bad times of getting rid of Cuttlefish on my system because there 
was no package with the similar name. I'll install it though. What's a Discover 
anyways? Do I need it to make icons?
  
  > But there is a real problem the small line-art representations don't change 
their color properly in the dark version
  
  I've thought that that's why we have separate breeze and breeze-dark icons. I 
don't know how to make it dynamic in Inkscape. Is there's any guide for this?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D8912

To: andreyorst, #vdg, ngraham
Cc: bruns, ngraham, kde-frameworks-devel, ndavis, michaelh

D16677: Add BrightScript syntax

[Nathaniel Graham]

ngraham added a comment.


  @dlevin
  
  That comment was meant for other KDE developers. :) There's nothing you need 
to do on that front... however, since you submitted the patch using the web 
interface rather than using `arc` 
, your 
authorship information was not included with the patch and we'll need your full 
name and preferred email address before we can land the patch. Can you provide 
that?

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D16677

To: dlevin, #framework_syntax_highlighting, cullmann
Cc: ngraham, dhaumann, cullmann, kwrite-devel, kde-frameworks-devel, michaelh, 
bruns, demsking, sars

D8912: Added a set of Game Folder icons

[Nathaniel Graham]

ngraham added a comment.


  In D8912#357374 , @andreyorst wrote:
  
  > I've had so bad times of getting rid of Cuttlefish on my system because 
there was no package with the similar name. I'll install it though.
  
  
  If you prefer to use a CLi package manager, the package name is generally 
`plasma-sdk` or something like that.
  
  > What's a Discover anyways? Do I need it to make icons?
  
  Discover is KDE's software center/app store. Discover makes it really easy to 
find, install, and remove apps, like Cuttlefish.
  
  >> But there is a real problem the small line-art representations don't 
change their color properly in the dark version
  > 
  > I've thought that that's why we have separate breeze and breeze-dark icons. 
I don't know how to make it dynamic in Inkscape. Is there's any guide for this?
  
  @ndavis can help with this, but yeah, we really need to add this information 
to https://hig.kde.org/style/icon.html. Noah, since you know how to do that, 
would you mind submitting a HIG patch to add it to the Icons page? Thanks!

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D8912

To: andreyorst, #vdg, ngraham
Cc: bruns, ngraham, kde-frameworks-devel, ndavis, michaelh

D16677: Add BrightScript syntax

[Christoph Cullmann]

cullmann added a comment.


  That's all fine, its inside the xml syntax file: "Daniel Levin 
(dendy...@gmail.com)" ;=)
  I will use that for the commit, otherwise I would have asked ;=)

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D16677

To: dlevin, #framework_syntax_highlighting, cullmann
Cc: ngraham, dhaumann, cullmann, kwrite-devel, kde-frameworks-devel, michaelh, 
bruns, demsking, sars

D16677: Add BrightScript syntax

[Daniel Levin]

dlevin added a comment.


  You can find my credentials at the beginning of the file I added in this 
patch: data/syntax/brightscript.xml

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D16677

To: dlevin, #framework_syntax_highlighting, cullmann
Cc: ngraham, dhaumann, cullmann, kwrite-devel, kde-frameworks-devel, michaelh, 
bruns, demsking, sars

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 471 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/471/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 10 Nov 2018 15:48:10 +
 Build duration:
21 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 61 test(s), Skipped: 0 test(s), Total: 61 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(262/398)66%
(262/398)53%
(32002/59910)38%
(16539/43948)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9105/9545)48%
(4281/8954)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)58%
(8310/14285)50%
(4656/9247)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)49%
(3892/7926)34%
(1595/4711)src.gui100%
(2/2)100%
(2/2)94%
(103/109)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(526/1019)37%
(316/850)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1344)0%
(0/1416)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1765/4295)35%
(1306/3692)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1331)55%
(626/1135)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
(0/12)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/32)src.ioslaves.trash56%
(5/9)56%
(5/9)52%
(703/1356)43%

D8912: Added a set of Game Folder icons

[Noah Davis]

ndavis added a comment.


  In D8912#357374 , @andreyorst wrote:
  
  > I've thought that that's why we have separate breeze and breeze-dark icons. 
I don't know how to make it dynamic in Inkscape. Is there's any guide for this?
  
  
  It's a PITA, but to do that right now, you actually need to open up the SVG 
in a text editor and add the code. It's not that hard, but it can be tedious if 
you don't automate it or at least use Search and Replace in Kate. It's also not 
easy to read the code unless you use an SVG optimizer with an option to make 
the code pretty. Usually, I run my icons through `svgo --pretty -i 
some-icon.svg` or SVG Cleaner (package is usually called `svgcleaner`) with 
these settings:
  F6410771: Screenshot_20181110_105723.png 

  F6410767: Screenshot_20181110_105237.png 

  
  Running your SVGs through an SVG optimizer is usually a good thing to do 
anyway since it can reduce the size of your SVGs by 80-90%. Inkscape adds a lot 
of extra data that is useful for editing SVGs, but not for displaying them. 
Sometimes SVG optimizers can also help you get past Inkscape bugs.
  
  As an example of how to do this, I'll use the gray 16px folder-games icon. 
After running it through SVG Cleaner with those settings, I get this:
  
http://www.w3.org/2000/svg";>





  
  First, add the style sheet just under line 1:
  

.ColorScheme-Text {
color:#4d4d4d;
}

  
  Second, add the ColorScheme class. In this case, I'll add it to the existing 
group (`` makes a group) so that it affects everything in the group:
  

  
  Third, change all of the colors to "currentColor":
  
  Use `stroke="currentColor"` for strokes and `fill="currentColor"` for shapes.
  
  In the end, I get this:
  
http://www.w3.org/2000/svg";>

.ColorScheme-Text {
color:#4d4d4d;
}






  
  For the breeze-dark icons, just change `#4d4d4d` in the stylesheet to 
`#f2f2f2`.
  
  You don't need to do any of the stylesheet stuff for color icons, including 
the 32 and 64 px folder-games icons, but you should still run them through an 
SVG optimizer to save space. Also, Inkscape adds all the extra junk back every 
time you save a change in inkscape, so you'll have to make sure you use the SVG 
optimizer again if you make a change in inkscape.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D8912

To: andreyorst, #vdg, ngraham
Cc: bruns, ngraham, kde-frameworks-devel, ndavis, michaelh

D8912: Added a set of Game Folder icons

[Noah Davis]

ndavis added a comment.


  In D8912#357376 , @ngraham wrote:
  
  > @ndavis can help with this, but yeah, we really need to add this 
information to https://hig.kde.org/style/icon.html. Noah, since you know how to 
do that, would you mind submitting a HIG patch to add it to the Icons page? 
Thanks!
  
  
  It's actually already in the HIG, kind of, but it's not obvious. A rewrite 
would help a lot.
  
  > For more technical details of how to use colors in icons see this blog post
  
  It links to http://notmart.org/blog/2016/05/icon-colors/

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D8912

To: andreyorst, #vdg, ngraham
Cc: bruns, ngraham, kde-frameworks-devel, ndavis, michaelh

D16617: fix extraction of GPS altitude for exif data

[Alexander Stippich]

astippich edited the summary of this revision.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D16617

To: astippich, #frameworks, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D8912: Added a set of Game Folder icons

[Noah Davis]

ndavis added a comment.


  Now for some feedback about the latest changes to the icon:
  
  Much better! The area around the joysticks could use some cleaning up though. 
At 100% size, it's not possible to see the joysticks. My suggestion would be to 
remove the joysticks, but keep the bumps that would hold the joysticks. Like so:
  F6410849: Screenshot_20181110_115557.png 

  
  I would suggest converting the stroke to a path since sometimes strokes get 
distorted by some SVG viewers, but I tried it myself and it completely 
butchered your icon. Why? Who knows. Maybe we shouldn't worry too much about it 
for now and if it becomes an issue, I can fix it later.
  
  Lastly, make sure the 16, 22, 32 and 64 px icons are all using the same 
style. The original 64px style looked good, but it did not scale down very 
well. The new style for the smaller icons should scale up easily. In general, I 
find it easier to create a consistent design if I start with the smallest icon 
I need to make.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D8912

To: andreyorst, #vdg, ngraham
Cc: bruns, ngraham, kde-frameworks-devel, ndavis, michaelh

D8912: Added a set of Game Folder icons

[Aaron Honeycutt]

aaronhoneycutt added a comment.


  This looks awesome folks! Great work!

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D8912

To: andreyorst, #vdg, ngraham
Cc: aaronhoneycutt, bruns, ngraham, kde-frameworks-devel, ndavis, michaelh

D16810: Update breeze-light and breeze-dark colorschemes

[Noah Davis]

ndavis created this revision.
ndavis added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  The current colorschemes included in the breeze-light and breeze-dark Plasma 
themes do not completely match the Breeze and BreezeDark colorschemes in the 
breeze repo. Most of the colors are the same, but the breeze-dark Plasma theme 
used an ugly yellow-green for ForegroundNeutral instead of Beware Orange like 
in the Breeze and BreezeDark colorschemes.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  update-colorschemes (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16810

AFFECTED FILES
  src/desktoptheme/breeze-dark/colors
  src/desktoptheme/breeze-light/colors

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16810: Update breeze-light and breeze-dark colorschemes

[Noah Davis]

ndavis edited the summary of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D16810

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16810: Update breeze-light and breeze-dark colorschemes

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D16810

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16810: Update breeze-light and breeze-dark colorschemes

[Noah Davis]

ndavis added reviewers: Breeze, Plasma.
ndavis added projects: VDG, Breeze, Plasma.
ndavis added a subscriber: VDG.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D16810

To: ndavis, #vdg, #breeze, #plasma
Cc: #vdg, kde-frameworks-devel, ggrysuk, alexde, IohannesPetros, ragreen, 
Pitel, michaelh, crozbo, ndavis, ZrenBot, firef, ngraham, bruns, skadinna, 
lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, 
mbohlender, mart

D16810: Update breeze-light and breeze-dark colorschemes

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D16810

To: ndavis, #vdg, #breeze, #plasma
Cc: #vdg, kde-frameworks-devel, ggrysuk, alexde, IohannesPetros, ragreen, 
Pitel, michaelh, crozbo, ndavis, ZrenBot, firef, ngraham, bruns, skadinna, 
lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, 
mbohlender, mart

D16810: Update breeze-light and breeze-dark colorschemes

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D16810

To: ndavis, #vdg, #breeze, #plasma
Cc: #vdg, kde-frameworks-devel, ggrysuk, alexde, IohannesPetros, ragreen, 
Pitel, michaelh, crozbo, ndavis, ZrenBot, firef, ngraham, bruns, skadinna, 
lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, 
mbohlender, mart

D16810: Update breeze-light and breeze-dark colorschemes

[Noah Davis]

ndavis edited the summary of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D16810

To: ndavis, #vdg, #breeze, #plasma
Cc: #vdg, kde-frameworks-devel, ggrysuk, alexde, IohannesPetros, ragreen, 
Pitel, michaelh, crozbo, ndavis, ZrenBot, firef, ngraham, bruns, skadinna, 
lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, 
mbohlender, mart

D16810: Update breeze-light and breeze-dark colorschemes

[Noah Davis]

ndavis edited the summary of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D16810

To: ndavis, #vdg, #breeze, #plasma
Cc: #vdg, kde-frameworks-devel, ggrysuk, alexde, IohannesPetros, ragreen, 
Pitel, michaelh, crozbo, ndavis, ZrenBot, firef, ngraham, bruns, skadinna, 
lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, 
mbohlender, mart

D16810: Update breeze-light and breeze-dark colorschemes

[Noah Davis]

ndavis edited the summary of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D16810

To: ndavis, #vdg, #breeze, #plasma
Cc: #vdg, kde-frameworks-devel, ggrysuk, alexde, IohannesPetros, ragreen, 
Pitel, michaelh, crozbo, ndavis, ZrenBot, firef, ngraham, bruns, skadinna, 
lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, 
mbohlender, mart

D16810: Update breeze-light and breeze-dark colorschemes

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D16810

To: ndavis, #vdg, #breeze, #plasma
Cc: #vdg, kde-frameworks-devel, ggrysuk, alexde, IohannesPetros, ragreen, 
Pitel, michaelh, crozbo, ndavis, ZrenBot, firef, ngraham, bruns, skadinna, 
lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, 
mbohlender, mart

D16677: Add BrightScript syntax

[Christoph Cullmann]

cullmann requested changes to this revision.
cullmann added a comment.
This revision now requires changes to proceed.


  Hi, I tried to land the patch but the consistency checks of the indexer tell 
me:
  
  
"/home/cullmann/local/kde/src/frameworks/syntax-highlighting/data/syntax/brightscript.xml"
 Reference of non-existing itemData attributes: QSet("code")
  
  I think the
  
  
  
  line needs some fix ;=)

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D16677

To: dlevin, #framework_syntax_highlighting, cullmann
Cc: ngraham, dhaumann, cullmann, kwrite-devel, kde-frameworks-devel, michaelh, 
bruns, demsking, sars

D16538: [sftp] Add additional sftpProtocol::openConnection() for libssh 0.8.3+

[Andreas Schneider]

This revision was automatically updated to reflect the committed changes.
Closed by commit R320:5043f66d17e1: [sftp] Add additional 
sftpProtocol::openConnection() for libssh 0.8.3+ (authored by asn).
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16538?vs=44532&id=45249

REVISION DETAIL
  https://phabricator.kde.org/D16538

AFFECTED FILES
  sftp/kio_sftp.cpp

To: asn, broulik, apol, ngraham
Cc: kde-frameworks-devel, kfm-devel, sitter, alexde, sourabhboss, feverfew, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D16798: KPluginFactory: fix create() apidox

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R244 KCoreAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16798

To: elvisangelaccio, dfaure, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D7380: KCD: use modern logging classes throughout

[David Faure]

dfaure added inline comments.

INLINE COMMENTS

> dfaure wrote in testkcd.cpp:64
> There's proper API for setting applications defaults, without the need for 
> env vars.

My comment is still valid: why doesn't this use 
QLoggingCategory::setFilterRules() instead?

> rjvbb wrote in testkcd.cpp:69
> And ditto: why would you write an application that's supposed to print test 
> results and NOT enable the printing by default? 
> (I presume that tests like this would use `QPrint()` if it existed)

In my view, qInfo is exactly meant for this use case, the one you call QPrint().

REPOSITORY
  R349 KCompactDisc Library

REVISION DETAIL
  https://phabricator.kde.org/D7380

To: rjvbb, #frameworks, davidedmundson, ltoscano
Cc: dfaure, ltoscano, davidedmundson

D16770: [ftp kio-slave] Fix deletion of directory with non-latin1/utf8 parent path

[David Faure]

dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> ftp.cpp:1240
>  if (!isfile) {
> -ftpFolder(remoteEncoding()->directory(url), false);// ignore 
> errors
> +const QString parentDir = 
> remoteEncoding()->decode(remoteEncoding()->directory(url));
> +ftpFolder(parentDir, false);// ignore errors

directory() encodes, and then you call decode(). Sounds slow and convoluted.

I would write it like this instead:

  const QString parentDir = 
url.adjusted(QUrl::StripTrailingSlash).adjusted(QUrl::RemoveFilename).path();

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D16770

To: kossebau, dfaure
Cc: aacid, kde-frameworks-devel, michaelh, ngraham, bruns

D14631: Adds a new RenameDialog to KIO with more options for batch renaming

[David Faure]

dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> batchrenamedialog.cpp:38
> +#include 
> +#include 
> +#include 

Remove all the framework prefixes. E.g. this should be .

This way, it fails to find the include if the include path (which comes from 
linking to an imported target, in cmake) for the dependency is missing.

> batchrenamedialog.cpp:259
> +
> +if (!job->error()) {
> +m_renamedItems << newUrl;

My comment still stands: it makes no sense to test for error() before the job's 
`result` signal is emitted.

The comment was marked as done, but there's still no connect to `result`

> batchrenamedialog.h:27
> +
> +#include 
> +#include 

Forward declaration would be enough (`class QCheckBox`).

Same for anything used by pointer (or ref) in this header.

> batchrenamedialog.h:42
> +
> +class KIOWIDGETS_EXPORT BatchRenameDialog : public QDialog
> +{

If you export it in an installed header, you need to document it.

> batchrenamedialog.h:66
> +
> +QList> m_itemsToBeRenamed;
> +QList m_renamedItems;

If you make this class public, you need to move all members to a Private class, 
and keep only a "d" pointer here. See all other public classes...

> batchrenamedialogmodel_p.cpp:30
> +{
> +itemData = new QList;
> +

itemData.reserve(items.count());

> batchrenamedialogmodel_p.cpp:40
> +{
> +Q_UNUSED(parent);
> +

remove this line, it's a lie :)

> batchrenametypes_p.h:20
> +
> +#ifndef KIO_RENAMETYPES
> +#define KIO_RENAMETYPES

doesn't match the name of the header, please adjust

> batchrenametypes_p.h:32
> +
> +class KIOWIDGETS_EXPORT BatchRenameTypes
> +{

why exported? for unit tests? if so, add a comment. If not, remove.

But anyhow this isn't a class, everything is static. To avoid generating a 
constructor and a destructor, make it a namespace (like you did for 
BatchRenameVar) and (if needed) export the individual functions.

> batchrenametypes_p.h:35
> +private:
> +static QStringList capturedGroups;
> +public:

move to .cpp file, it's not needed here at all

> batchrenamevar_p.h:25
> +
> +#include 
> +#include 

not used here, remove

> filenameutils_p.h:20
> +
> +#ifndef KIO_FILENAMEUTILS
> +#define KIO_FILENAMEUTILS

_P_H

> batchrenamedialogtest_gui.cpp:32
> +
> +auto dlg = new KIO::BatchRenameDialog(nullptr, KFileItemList({e1, e2}));
> +dlg->show();

create it on stack to avoid leaking it

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14631

To: emateli, #frameworks, dfaure, mlaurent
Cc: mlaurent, asensi, rkflx, dfaure, aacid, ngraham, kde-frameworks-devel, 
michaelh, bruns

D16674: MTP: fix runtime warning when showing a warning to the user.

[David Faure]

dfaure closed this revision.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D16674

To: dfaure, akrutzler, elvisangelaccio, apol
Cc: kde-frameworks-devel, kfm-devel, alexde, sourabhboss, feverfew, michaelh, 
spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, 
mikesomov

D16815: Rename Sublime Text icon to ensure it works

[TrickyRicky]

trickyricky26 created this revision.
trickyricky26 added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
trickyricky26 requested review of this revision.

REVISION SUMMARY
  Renamed the Sublime Text icon from sublime.svg to sublime-text.svg to ensure 
it is used correctly in docks and everywhere else.

REPOSITORY
  R266 Breeze Icons

BRANCH
  fix-sublime

REVISION DETAIL
  https://phabricator.kde.org/D16815

AFFECTED FILES
  icons-dark/apps/48/sublime-text.svg
  icons-dark/apps/48/sublime.svg
  icons/apps/48/sublime-text.svg
  icons/apps/48/sublime.svg

To: trickyricky26, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16815: Rename Sublime Text icon to ensure it works

[TrickyRicky]

trickyricky26 edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16815

To: trickyricky26, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16815: Rename Sublime Text icon to ensure it works

[Noah Davis]

ndavis accepted this revision.
ndavis added a comment.
This revision is now accepted and ready to land.


  Looks good to me!

REPOSITORY
  R266 Breeze Icons

BRANCH
  fix-sublime

REVISION DETAIL
  https://phabricator.kde.org/D16815

To: trickyricky26, #vdg, ndavis
Cc: ndavis, kde-frameworks-devel, michaelh, ngraham, bruns

D16815: Rename Sublime Text icon to ensure it works

[Noah Davis]

ndavis requested changes to this revision.
ndavis added a comment.
This revision now requires changes to proceed.


  I got an error when I tried to land this patch:
  
remote: Audit failure - Commit 5fa9283264f511edf5678cfd09185a16296c7e71 - 
Non-full name: Rafael
  
  I know it might seem silly, but please change your name to a full name so 
that your patch can pass the audit.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16815

To: trickyricky26, #vdg, ndavis
Cc: ndavis, kde-frameworks-devel, michaelh, ngraham, bruns

D16815: Rename Sublime Text icon to ensure it works

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.


  I know this is a bugfix, but...
  
  IMHO it's really bad form to design a Breeze version of an app icon that has 
a totally different visual style from the original--especially if it completely 
eliminates all the branding elements from the original. This icon should be a 
Breezey version of the original icon, not something totally different that 
erases the Sublime Text brand. This is obviously not your fault, but I'd like 
to see the icon improved before we fix this bug, or else IMHO it will actually 
be a visual regression for Sublime Text users.
  
  Really, the original mostly looks fine. A Breeze version should just 
harmonize the size with other square icons, reduce or eliminate the rounded 
corners, and maybe make some other very subtle changes. If we want to keep the 
parts of the current icon that depict a tabbed view, we could replace the lines 
of text with the orange S logo, or overlay it on top of them or something. I'm 
not sure if the tabbed view iconography is even necessary though.
  
  All of this could be done in the same patch if you have icon design skills 
and want to tackle that, or in a separate one if not.
  
  Oh, and thanks for the patch, and thanks for using `arc` to submit it! :)

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16815

To: trickyricky26, #vdg, ndavis, ngraham
Cc: ngraham, ndavis, kde-frameworks-devel, michaelh, bruns

D16815: Rename Sublime Text icon to ensure it works

[Noah Davis]

ndavis added a comment.


  In D16815#357570 , @ngraham wrote:
  
  > I know this is a bugfix, but...
  >
  > IMHO it's really bad form to design a Breeze version of an app icon that 
has a totally different visual style from the original--especially if it 
completely eliminates all the branding elements from the original. This icon 
should be a Breezey version of the original icon, not something totally 
different that erases the Sublime Text brand. This is obviously not your fault, 
but I'd like to see the icon improved before we fix this bug, or else IMHO it 
will actually be a visual regression for Sublime Text users.
  >
  > Really, the original mostly looks fine. A Breeze version should just 
harmonize the size with other square icons, reduce or eliminate the rounded 
corners, and maybe make some other very subtle changes. If we want to keep the 
parts of the current icon that depict a tabbed view, we could replace the lines 
of text with the orange S logo, or overlay it on top of them or something. I'm 
not sure if the tabbed view iconography is even necessary though.
  >
  > All of this could be done in the same patch if you have icon design skills 
and want to tackle that, or in a separate one if not.
  >
  > Oh, and thanks for the patch, and thanks for using `arc` to submit it! :)
  
  
  I'm guessing it was meant to make the Sublime Text icon look similar in style 
to the Kate and KWrite icons, but you're probably right that using an icon 
completely different from the official one isn't a good idea.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16815

To: trickyricky26, #vdg, ndavis, ngraham
Cc: ngraham, ndavis, kde-frameworks-devel, michaelh, bruns

D16677: Add BrightScript syntax

[Daniel Levin]

dlevin updated this revision to Diff 45260.
dlevin added a comment.


  Replaced missing "code" attribute with "g".

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16677?vs=44885&id=45260

REVISION DETAIL
  https://phabricator.kde.org/D16677

AFFECTED FILES
  autotests/html/brightscript.brs.html
  autotests/input/brightscript.brs
  autotests/input/brightscript.brs.syntax
  autotests/reference/brightscript.brs.ref
  data/syntax/brightscript.xml

To: dlevin, #framework_syntax_highlighting, cullmann
Cc: ngraham, dhaumann, cullmann, kwrite-devel, kde-frameworks-devel, michaelh, 
bruns, demsking, sars

D16677: Add BrightScript syntax

[Daniel Levin]

dlevin added a comment.


  Thanks for catching this. Did re-run tests locally, seems no other issue 
remaining. Please check.

REVISION DETAIL
  https://phabricator.kde.org/D16677

To: dlevin, #framework_syntax_highlighting, cullmann
Cc: ngraham, dhaumann, cullmann, kwrite-devel, kde-frameworks-devel, michaelh, 
bruns, demsking, sars

Re: Regression in Frameworks - DBus Hangs

[Ben Cooksley]

On Thu, Nov 8, 2018 at 8:15 PM Ben Cooksley  wrote:
>
> On Sat, Nov 3, 2018 at 4:41 PM Ben Cooksley  wrote:
> >
> > Hi all,
> >
> > Following commits made to Frameworks somewhere in the October 21 to
> > October 28 time frame, the unit tests of Konsole on the CI system have
> > started to hang following completion.
> >
> > This hang is occurring due to a behaviour of CTest, where it will wait
> > (indefinitely) following the conclusion of a test for processes
> > spawned by that test to exit.
> >
> > Previously, the "konsole --separate" process launched by Konsole's
> > dbus unit test would exit normally, however following the changes in
> > Frameworks it now hangs and does not exit as expected.
> >
> > This is causing quite a bit of trouble as these builds require manual
> > Sysadmin intervention in order to have the jobs complete successfully.
> >
> > Could someone take a look into this regression please?
> >
> > Regretfully it isn't possible to run GDB within the CI system
> > environment (Docker drops CAP_SYS_PTRACE) so i'm unable to get a
> > backtrace out of Konsole to find where it is stuck.
>
> Ping?
>
> Anyone got any idea why this behaviour has regressed?

The complete lack of response to this issue (and any mail to this
mailing list i've noticed, I highly suspect everyone just filters it
into a corner in their mail client and doesn't read it at all) is
really disappointing.

Given that Kurt has disabled the test within Konsole this doesn't have
any urgency anymore.

None the less though the fact a regression with
hang-on-application-close implications was detected by the CI system
and then completely ignored by those who broke it brings up other
concerns, and essentially means the CI system is given no regard by
the Frameworks developers.

As a consequence i'll be terminating CI and Phabricator notification
mails to the Frameworks mailing list, effective immediately.

>
> >
> > Thanks,
> > Ben
>
> Regards,
> Ben

Regards,
Ben Cooksley
KDE Sysadmin