D12149: Improve grid spacing in icons-on-top mode for open/save dialogs

ngraham marked an inline comment as done. REPOSITORY R241 KIO BRANCH arcpatch-D12149 REVISION DETAIL https://phabricator.kde.org/D12149 To: ngraham, #frameworks, #vdg, rkflx, abetts Cc: abetts, cfeck, alexeymin, michaelh, ngraham, bruns

D12149: Improve grid spacing in icons-on-top mode for open/save dialogs

ngraham updated this revision to Diff 32094. ngraham added a comment. Slightly reduce the minimum width REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12149?vs=32017=32094 BRANCH arcpatch-D12149 REVISION DETAIL https://phabricator.kde.org/D12149

D12130: Use the more user-friendly string "File type" in the save dialogs

ngraham added a comment. In D12130#245826 , @rkflx wrote: > > If necessary I can make the string return to "Filter" for these save-with-filter dialogs, but I'm still left wondering what the feature is actually for or if Kate is affected by a

D11569: Improve consistency of "Open With" UI by always showing top app inline

ngraham added a comment. I'll submit some more patches tomorrow. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11569 To: ngraham, rkflx, #vdg, #frameworks, #dolphin, dfaure, elvisangelaccio, abetts Cc: mmustac, davidedmundson, broulik, dfaure, elvisangelaccio,

D12130: Use the more user-friendly string "File type" in the save dialogs

ngraham updated this revision to Diff 32093. ngraham added a comment. First fix the casing REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12130?vs=32030=32093 BRANCH arcpatch-D12130 REVISION DETAIL https://phabricator.kde.org/D12130 AFFECTED FILES

D11470: SQL: various improvements and fix if/case/loop/end detection with SQL (Oracle)

dhaumann requested changes to this revision. dhaumann added a comment. This revision now requires changes to proceed. Looks mostly good, but there are some minor issues we first need to address: - dsControlFlow and similar default styles were added with KDE Frameworks 5, so

D11569: Improve consistency of "Open With" UI by always showing top app inline

rkflx added a comment. In D11569#235002 , @ngraham wrote: > I'll leave the string the way it is for now so this can go into Frameworks 5.45, and change it after the string freeze. @ngraham Are you still planning to do this? Or should I

D12005: Fix merging of terms in the AdvancedQueryParser

This revision was automatically updated to reflect the committed changes. Closed by commit R293:c91c43393c33: Fix merging of terms in the AdvancedQueryParser (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12005?vs=31685=32089 REVISION

D12165: Use QStorageInfo instead of a homegrown implementation

This revision was automatically updated to reflect the committed changes. Closed by commit R293:0491ba6e8e96: Use QStorageInfo instead of a homegrown implementation (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12165?vs=32078=32087

D12034: Use the more appropriate "two sliders" icon for "configure"

ngraham closed this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D12034 To: ngraham, #vdg, #plasma, #breeze, abetts Cc: hein, bruns, abetts, sharvey, #frameworks, michaelh, ngraham

D12130: Use the more user-friendly string "File type" in the save dialogs

rkflx added a comment. Forgot something important: You should look at Okular's Save As too, where the Automatically select filename extension checkbox get's disabled once you deviate from the pre-populated file types, i.e. when you type a custom filter. Obviously you should not change

D12130: Use the more user-friendly string "File type" in the save dialogs

rkflx added a comment. > I wonder if having a filter feature even makes any sense when saving files, and if it does--why only for Kate? Well, you should ask #Kate . I suspect this is because there cannot be a static list of file types, because

D12149: Improve grid spacing in icons-on-top mode for open/save dialogs

rkflx added a comment. Ok, forget about Dolphin, which for small sizes IMO could be much more dense than it is now. However, can we still tweak the file dialog a bit? My issue is that between 16px and 72px there is absolutely no change in both the number of characters displayed, as

D12165: Use QStorageInfo instead of a homegrown implementation

michaelh accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH master REVISION DETAIL https://phabricator.kde.org/D12165 To: bruns, #baloo, michaelh Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, alexeymin

D12005: Fix merging of terms in the AdvancedQueryParser

michaelh accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH baloo_term_cleanup_2 REVISION DETAIL https://phabricator.kde.org/D12005 To: bruns, #baloo, michaelh Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns,

D12165: Use QStorageInfo instead of a homegrown implementation

bruns updated this revision to Diff 32078. bruns added a comment. rebase REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12165?vs=32033=32078 BRANCH master REVISION DETAIL https://phabricator.kde.org/D12165 AFFECTED FILES

D12172: Android: Also install plugins, otherwise they are just not available

apol added a comment. In D12172#245676 , @vkrause wrote: > For Qt < 5.12 this is ok as a temporary solution I think, but with the new androiddeployqt I'd rather add -android-dependencies.xml files for the libraries needing plugins (simple

D12138: Remove FSUtils::getDirectoryFileSystem

michaelh accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH disble_cow_unconditionally REVISION DETAIL https://phabricator.kde.org/D12138 To: bruns, #baloo, #freebsd, michaelh Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun,

D12135: Allow disabling of CoW to fail when not supported by filesystem

michaelh added a comment. +1 LGTM REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12135 To: bruns, #baloo, adridg, #frameworks, michaelh Cc: adridg, #freebsd, #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, alexeymin

D12077: Show view mode buttons in the open/save dialog's toolbar

rkflx added a comment. In D12077#245777 , @rkflx wrote: > The third step would be to look at Dolphin (where I think you should do a poll to gauge usage of what you describe as the "horrible" mode, an assessment which I'd agree with but maybe

D12149: Improve grid spacing in icons-on-top mode for open/save dialogs

rkflx added a comment. @ngraham Before I look at this in detail: Did you aim for a spacing consistent with Dolphin? Because on a short try with different icon sizes in both Dolphin and the file dialog, sometimes one was wider and sometimes the other… REPOSITORY R241 KIO BRANCH

D12077: Show view mode buttons in the open/save dialog's toolbar

rkflx added a comment. Let's do one step at a time ;) First, decide which mode we want to show. Then think about the icon, i.e. either switch icons or redo the icon itself. (Basing the mode on the icon instead of on the behaviour is //very questionable//, I'm surprised you even bring this

D12130: Use the more user-friendly string "File type" in the save dialogs

ngraham planned changes to this revision. ngraham added a comment. In D12130#245721 , @cfeck wrote: > In D12130#245680 , @davidc wrote: > > > "File Type" is a big improvement over "File format." >

D12135: Allow disabling of CoW to fail when not supported by filesystem

bruns added a reviewer: michaelh. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12135 To: bruns, #baloo, adridg, #frameworks, michaelh Cc: adridg, #freebsd, #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, alexeymin

D12135: Allow disabling of CoW to fail when not supported by filesystem

bruns updated this revision to Diff 32074. bruns added a comment. rebase REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12135?vs=31946=32074 BRANCH master REVISION DETAIL https://phabricator.kde.org/D12135 AFFECTED FILES src/engine/fsutils.cpp

D12077: Show view mode buttons in the open/save dialog's toolbar

ngraham added a comment. One reason why I used Detailed Vew instead of Detailed Tree View was honestly because I think it has a better icon. Detailed Tree View's "squares connected with lines" iconography //tolerably// communicates "tree-style view" but not "vertical list of items" and

D12077: Show view mode buttons in the open/save dialog's toolbar

ngraham planned changes to this revision. ngraham added a comment. In D12077#245758 , @rkflx wrote: > I know I already accepted this, but: > > > moves the preview button over to the right so it doesn't compete with the new view mode and

D12077: Show view mode buttons in the open/save dialog's toolbar

rkflx added a comment. I know I already accepted this, but: > moves the preview button over to the right so it doesn't compete with the new view mode and sorting buttons. While you now could remove "sorting" from the summary, I wonder whether it would make sense to revisit moving

D12077: Show view mode buttons in the open/save dialog's toolbar

abetts accepted this revision. REPOSITORY R241 KIO BRANCH show-view-mode-toggles-on-open-save-dialog-toolbar (branched from master) REVISION DETAIL https://phabricator.kde.org/D12077 To: ngraham, #frameworks, rkflx, #vdg, abetts Cc: rkflx, mmustac, broulik, michaelh, ngraham, bruns

D12149: Improve grid spacing in icons-on-top mode for open/save dialogs

abetts accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH tighter-grid-in-icons-view (branched from master) REVISION DETAIL https://phabricator.kde.org/D12149 To: ngraham, #frameworks, #vdg, rkflx, abetts Cc: abetts, cfeck, alexeymin,

D12149: Improve grid spacing in icons-on-top mode for open/save dialogs

abetts added a comment. Can we also create another patch that can add more vertical spacing between the items and the top edge of the field? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12149 To: ngraham, #frameworks, #vdg, rkflx Cc: abetts, cfeck, alexeymin,

D12130: Use the more user-friendly string "File type" in the save dialogs

abetts accepted this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12130 To: ngraham, #frameworks, #vdg, bruns, alexeymin, rkflx, abetts Cc: davidc, ltoscano, cfeck, rkflx, alexeymin, abetts, bruns, michaelh, ngraham

D12034: Use the more appropriate "two sliders" icon for "configure"

abetts accepted this revision as: VDG, abetts. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH more-consistent-configure-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D12034 To: ngraham, #vdg, #plasma, #breeze, abetts Cc:

D12130: Use the more user-friendly string "File type" in the save dialogs

cfeck added a comment. In D12130#245680 , @davidc wrote: > "File Type" is a big improvement over "File format." > > Clear, concise, offers consistent capitalization throughout the window, and aligns well with the "Name" field above it.

D11882: autotests: Use built executable instead of installed

bruns added a comment. In D11882#239725 , @michaelh wrote: > In D11882#239638 , @alexeymin wrote: > > > Code looks fine, but I did not test if it actually works. ;) > > > It's a little hard to

D12130: Use the more user-friendly string "File type" in the save dialogs

davidc added a comment. "File Type" is a big improvement over "File format." Clear, concise, offers consistent capitalization throughout the window, and aligns well with the "Name" field above it. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12130 To: ngraham,

D12172: Android: Also install plugins, otherwise they are just not available

vkrause added a comment. For Qt < 5.12 this is ok as a temporary solution I think, but with the new androiddeployqt I'd rather add -android-dependencies.xml files for the libraries needing plugins (simple example:

D12077: Show view mode buttons in the open/save dialog's toolbar

ngraham added a reviewer: VDG. REPOSITORY R241 KIO BRANCH show-view-mode-toggles-on-open-save-dialog-toolbar (branched from master) REVISION DETAIL https://phabricator.kde.org/D12077 To: ngraham, #frameworks, rkflx, #vdg Cc: rkflx, mmustac, broulik, michaelh, ngraham, bruns

D12172: Android: Also install plugins, otherwise they are just not available

apol created this revision. apol added reviewers: Build System, Frameworks. Restricted Application added projects: Frameworks, Build System. apol requested review of this revision. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D12172

D12150: Make it possible to build several apk out of a project

This revision was automatically updated to reflect the committed changes. Closed by commit R240:cf750d4eeaf7: Make it possible to build several apk out of a project (authored by apol). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE

D11882: autotests: Use built executable instead of installed

michaelh added a comment. Ping REPOSITORY R824 Baloo Widgets REVISION DETAIL https://phabricator.kde.org/D11882 To: michaelh, elvisangelaccio, #baloo, #frameworks Cc: alexeymin, ashaposhnikov, astippich, spoorun

D12164: Add overloads to Value/Unit::toString/toSymbolString taking a QLocale

kossebau added a comment. As discussed on irc with @broulik will give that other patch https://git.reviewboard.kde.org/r/127800/ some look again, as I would agree numbers rather should be localized there. Had considered something like that before as well, but then discarded due to not

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 128 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/128/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Fri, 13 Apr 2018 11:59:10 + Build duration: 9 min 8 sec and counting

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 103 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/103/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 Date of build: Fri, 13 Apr 2018 11:59:10 + Build duration: 6 min 41 sec and counting

D12145: autotests: Do not use QScopedPointer for plugins

michaelh updated this revision to Diff 32052. michaelh added a comment. - Rebase REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12145?vs=31966=32052 BRANCH plugin-simple (branched from master) REVISION DETAIL https://phabricator.kde.org/D12145

D12145: autotests: Do not use QScopedPointer for plugins

This revision was automatically updated to reflect the committed changes. Closed by commit R286:8b8857cb6bc3: autotests: Do not use QScopedPointer for plugins (authored by michaelh). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12145?vs=32052=32053

D12029: taglibextractor: Fix empty genre bug

This revision was automatically updated to reflect the committed changes. Closed by commit R286:d66b9853b55d: taglibextractor: Fix empty genre bug (authored by michaelh). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12029?vs=32050=32051 REVISION

D12029: taglibextractor: Fix empty genre bug

michaelh updated this revision to Diff 32050. michaelh added a comment. - Rebase and adapt REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12029?vs=31617=32050 BRANCH nometa-pass (branched from master) REVISION DETAIL

KDE CI: Frameworks kfilemetadata kf5-qt5 SUSEQt5.9 - Build # 10 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kfilemetadata%20kf5-qt5%20SUSEQt5.9/10/ Project: Frameworks kfilemetadata kf5-qt5 SUSEQt5.9 Date of build: Fri, 13 Apr 2018 10:35:20 + Build duration: 1 min 27 sec and counting JUnit Tests

KDE CI: Frameworks kfilemetadata kf5-qt5 FreeBSDQt5.9 - Build # 20 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kfilemetadata%20kf5-qt5%20FreeBSDQt5.9/20/ Project: Frameworks kfilemetadata kf5-qt5 FreeBSDQt5.9 Date of build: Fri, 13 Apr 2018 10:35:20 + Build duration: 1 min 45 sec and counting JUnit

KDE CI: Frameworks kfilemetadata kf5-qt5 SUSEQt5.10 - Build # 31 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kfilemetadata%20kf5-qt5%20SUSEQt5.10/31/ Project: Frameworks kfilemetadata kf5-qt5 SUSEQt5.10 Date of build: Fri, 13 Apr 2018 10:35:20 + Build duration: 1 min 27 sec and counting JUnit

D12028: taglibextractortest: Add test for files with empty metadata

This revision was automatically updated to reflect the committed changes. Closed by commit R286:1755f07e31f4: taglibextractortest: Add test for files with empty metadata (authored by michaelh). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE

D12028: taglibextractortest: Add test for files with empty metadata

michaelh updated this revision to Diff 32048. michaelh added a comment. - Rebased REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12028?vs=32009=32048 BRANCH nometa REVISION DETAIL https://phabricator.kde.org/D12028 AFFECTED FILES

D12166: sanitizer: Don't rely on fsutils

michaelh abandoned this revision. michaelh added a comment. D12165 is better REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12166 To: michaelh, #baloo, bruns Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham,

D12165: Use QStorageInfo instead of a homegrown implementation

michaelh added a comment. LGTM and works as expected. To make it run I had to manually edit the Raw diff and patch. https://phabricator.kde.org/R293:07601590347f25ec1ec805e7df16e1f2d6badc9c was pulled at around 9:30 CET, but not last night, maybe not even at Fri, Apr 13, 05:10. Please

D12165: Use QStorageInfo instead of a homegrown implementation

michaelh added a task: T8250: Sanitize the database. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12165 To: bruns, #baloo, michaelh Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, alexeymin

D12150: Make it possible to build several apk out of a project

vkrause accepted this revision. vkrause added a comment. This revision is now accepted and ready to land. I very much like that direction. I always found the need to specify platform-independent build properties explicitly on the command line weird, so anything moving towards being able to

D12165: Use QStorageInfo instead of a homegrown implementation

michaelh added a comment. $ arc patch D12165 INFO Base commit is not in local repository; trying to fetch. Created and checked out branch arcpatch-D12165. Created and checked out branch arcpatch-D11285. <== ??? Prüfe Patch src/engine/transaction.h ... ...

D12166: sanitizer: Don't rely on fsutils

michaelh added a comment. Hmmpf... Overlooked D12165 . Looks like it can be done. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12166 To: michaelh, #baloo, bruns Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun,

D12166: sanitizer: Don't rely on fsutils

michaelh retitled this revision from "Don't rely on fsutils" to "sanitizer: Don't rely on fsutils". REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12166 To: michaelh, #baloo, bruns Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, alexeymin

D12166: Don't rely on fsutils

michaelh added a comment. @bruns This works, but it is just a draft. I'll optimize as soon as you confirm that this path is worth following. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12166 To: michaelh, #baloo, bruns Cc: #frameworks, ashaposhnikov, michaelh,

D12166: Don't rely on fsutils

michaelh created this revision. michaelh added reviewers: Baloo, bruns. Restricted Application added projects: Frameworks, Baloo. Restricted Application added a subscriber: Frameworks. michaelh requested review of this revision. REVISION SUMMARY Allow removal of fsutils TEST PLAN $ baloodb

D12164: Add overloads to Value/Unit::toString/toSymbolString taking a QLocale

broulik added a comment. +1 always annoyed me that the converter runner didn't use localed decimal points See also https://git.reviewboard.kde.org/r/127800/ REPOSITORY R292 KUnitConversion REVISION DETAIL https://phabricator.kde.org/D12164 To: kossebau, ilic Cc: broulik,

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 127 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/127/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Fri, 13 Apr 2018 07:05:44 + Build duration: 3 min 1 sec and counting

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 102 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/102/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 Date of build: Fri, 13 Apr 2018 07:05:44 + Build duration: 2 min 50 sec and counting