D12226: balooshow: Colorize only when attached to terminal

tcberner accepted this revision. tcberner added a comment. This revision is now accepted and ready to land. Works as intended on FreeBSD. REPOSITORY R293 Baloo BRANCH no-color (branched from master) REVISION DETAIL https://phabricator.kde.org/D12226 To: michaelh, #baloo, bruns,

KDE CI: Frameworks kservice kf5-qt5 FreeBSDQt5.9 - Build # 21 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kservice%20kf5-qt5%20FreeBSDQt5.9/21/ Project: Frameworks kservice kf5-qt5 FreeBSDQt5.9 Date of build: Mon, 16 Apr 2018 04:47:01 + Build duration: 1 min 23 sec and counting JUnit Tests

KDE CI: Frameworks kservice kf5-qt5 SUSEQt5.10 - Build # 26 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kservice%20kf5-qt5%20SUSEQt5.10/26/ Project: Frameworks kservice kf5-qt5 SUSEQt5.10 Date of build: Mon, 16 Apr 2018 04:47:01 + Build duration: 1 min 47 sec and counting JUnit Tests

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 196 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/196/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Mon, 16 Apr 2018 03:30:56 + Build duration: 15 min and counting JUnit Tests Name:

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 66 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/66/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Mon, 16 Apr 2018 03:30:56 + Build duration: 8 min 25 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 217 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/217/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Mon, 16 Apr 2018 03:30:56 + Build duration: 5 min 3 sec and counting JUnit Tests Name:

D12218: Remove Reload button from the file dialogs' toolbar

ngraham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12218 To: ngraham, #frameworks Cc: rkflx, #dolphin, michaelh, ngraham, bruns

D12206: Don't show top "Open With" app for folders; only for files

ngraham added a comment. Landed and fixed the Konqueror test with https://cgit.kde.org/konqueror.git/commit/?id=83b6aab662eb7f0183d3250e90ed312d81ef0672 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12206 To: ngraham, #frameworks, elvisangelaccio Cc: rkflx,

D12206: Don't show top "Open With" app for folders; only for files

This revision was automatically updated to reflect the committed changes. Closed by commit R241:53d4a4fe67ba: Dont show top Open With app for folders; only for files (authored by ngraham). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12206?vs=32242=32243

D11569: Improve consistency of "Open With" UI by always showing top app inline

ngraham added a comment. In D11569#245900 , @rkflx wrote: > In D11569#235002 , @ngraham wrote: > > > I'll leave the string the way it is for now so this can go into Frameworks 5.45, and change it

D12206: Don't show top "Open With" app for folders; only for files

ngraham updated this revision to Diff 32242. ngraham added a comment. Revert unintantional whitespace change that Phabricator "helpfully" concealed REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12206?vs=32198=32242 BRANCH no-open-with-for-folders (branched

D12221: Fix problem that font/italic/... attributes no longer work with e.g. >= Qt 5.9

ngraham added a subscriber: rjvbb. ngraham added a comment. In D12221#246716 , @dhaumann wrote: > @ngraham So what is the current state of a proper fix in KFontRequester? I have no idea, sorry. The issue is honestly too complicated for me

D11945: Optimize AppArmor & SELinux highlighting and improve regex

nibags updated this revision to Diff 32240. nibags added a comment. - AppArmor 2.13.0 Released: allow 'if exists' in Include rules REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11945?vs=31359=32240 BRANCH opt-apparmor-selinux (branched from

D12234: Update unit tests after removing "this month" and "last month" items

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Thanks, this fixes that test failure for me. Sorry for the breakage! `baloonurl` *cringes* REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12234 To: joselema,

D12239: Create a public writeViewConfig() function so the open/save dialog itself can call it

ngraham added a dependent revision: D12240: Save the dialog view settings when closing the dialog without hitting the cancel button. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12239 To: ngraham, #frameworks Cc: michaelh, ngraham, bruns

D12240: Save the dialog view settings when closing the dialog without hitting the cancel button

ngraham created this revision. ngraham added a reviewer: Frameworks. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Save the view settings when the user closes the dialog using

D12226: balooshow: Colorize only when attached to terminal

bruns accepted this revision. bruns added a comment. LGTM Can somebody FreeBSD folk confirm this works also on FreeBSD? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12226 To: michaelh, #baloo, bruns, #freebsd Cc: #frameworks, ashaposhnikov, michaelh, astippich,

D12239: Create a public writeViewConfig() function so the open/save dialog itself can call it

ngraham created this revision. ngraham added a reviewer: Frameworks. Restricted Application added a project: Frameworks. ngraham requested review of this revision. REVISION SUMMARY D12227 fixes 209559 for the case when the user presses the Cancel button,

D12226: balooshow: Colorize only when attached to terminal

bruns added reviewers: bruns, FreeBSD. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12226 To: michaelh, #baloo, bruns, #freebsd Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, alexeymin

D12235: Add XDG Output Protocol

davidedmundson created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. davidedmundson requested review of this revision. REVISION SUMMARY Done primarily for XWayland which for legacy reasons doesn't assume the logical

D11753: baloodb: Add clean command

bruns added inline comments. INLINE COMMENTS > databasesanitizer.cpp:344 > +} else { > +m_pimpl->m_transaction->removeDocument(info.id); > +out << i18n("Removing:"); do the calls to m_transaction using a wrapper, e.g.

D12233: Avoid manipulation of lists with quadratic complexity

bruns added inline comments. INLINE COMMENTS > fileindexscheduler.cpp:148 > +return file.startsWith(dir); > +}; > + You can put the lambda into the `remove_if` invocation: auto tail = std::remove_if(list.begin(), list.end(), [](const QString& file) {

D12231: Reduce the number of zombies to a minimum

adridg added a comment. Since you're using a global variable to accumulate ${numberOfProcesses} worth of po-files in one go, you should definitely clear out the variable when that bunch has been processed, or you'll grind through each po file more than once (with a growing command-list,

D12234: Update unit tests after removing "this month" and "last month" items

elvisangelaccio added a comment. +1 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12234 To: joselema, davidedmundson Cc: elvisangelaccio, ngraham, rikmills, #frameworks, michaelh, bruns

D12234: Update unit tests after removing "this month" and "last month" items

joselema created this revision. joselema added a reviewer: davidedmundson. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. joselema requested review of this revision. REVISION SUMMARY Hi, I think since this change

D12233: Avoid manipulation of lists with quadratic complexity

michaelh added a comment. If this is correct, I can extend. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12233 To: michaelh, #baloo Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, alexeymin

D12233: Avoid manipulation of lists with quadratic complexity

michaelh created this revision. michaelh added a reviewer: Baloo. Restricted Application added projects: Frameworks, Baloo. Restricted Application added a subscriber: Frameworks. michaelh requested review of this revision. REVISION SUMMARY When removing items from lists Baloo uses an

D12233: Avoid manipulation of lists with quadratic complexity

michaelh added a task: T8502: Avoid manipulation of lists with quadratic complexity. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12233 To: michaelh, #baloo Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, alexeymin

D12135: Allow disabling of CoW to fail when not supported by filesystem

michaelh added a comment. In D12135#246895 , @bcooksley wrote: > If there are multiple reviewers then approval of all reviewers is required which is why your approval was also needed Good to know, thanks. REPOSITORY R293 Baloo

D12135: Allow disabling of CoW to fail when not supported by filesystem

bcooksley added a comment. If there are multiple reviewers then approval of all reviewers is required which is why your approval was also needed REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12135 To: bruns, #baloo, adridg, #frameworks, michaelh Cc: bcooksley,

D12231: Reduce the number of zombies to a minimum

anthonyfieroni added inline comments. INLINE COMMENTS > build-pofiles.cmake:31 > include(ProcessorCount) > ProcessorCount(numberOfProcesses) > you can downgrade by 1 numberOfProcesses, BTW it's best value to have *alive* system. PS: Probably you should check -1 if it's > 1 REPOSITORY

D12231: Reduce the number of zombies to a minimum

tcberner updated this revision to Diff 32216. tcberner added a comment. Simplify the diff. REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12231?vs=32210=32216 BRANCH master REVISION DETAIL https://phabricator.kde.org/D12231 AFFECTED FILES

D12135: Allow disabling of CoW to fail when not supported by filesystem

michaelh added a comment. In D12135#246831 , @bcooksley wrote: > The original author/submitter of a diff for review isn't able to approve their own review, which is why Stefan wasn't permitted to approve this diff. Yes, thanks. That's

D12231: Reduce the number of zombies to a minimum

tcberner added inline comments. INLINE COMMENTS > build-pofiles.cmake:64 > set(i 0) > +set(commands "") > endif() ^ this is probalby the only required change. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D12231 To: tcberner, #freebsd, sitter,

D12138: Remove FSUtils::getDirectoryFileSystem

This revision was automatically updated to reflect the committed changes. Closed by commit R293:91a0e694e766: Remove FSUtils::getDirectoryFileSystem (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12138?vs=31947=32214 REVISION DETAIL

D12044: baloodb: Improve interface

michaelh edited dependencies, added: D1: baloodb: Use complete access filtering for all outputs; removed: D11753: baloodb: Add clean command. REPOSITORY R293 Baloo BRANCH sanitize-improve-ui (branched from master) REVISION DETAIL https://phabricator.kde.org/D12044 To: michaelh,

D11753: baloodb: Add clean command

michaelh removed a dependent revision: D12044: baloodb: Improve interface. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11753 To: michaelh, #baloo, #frameworks, bruns Cc: bruns, cfeck, smithjd, ashaposhnikov, michaelh, astippich, spoorun, ngraham, alexeymin

D12222: baloodb: Use complete access filtering for all outputs

michaelh added a dependent revision: D12044: baloodb: Improve interface. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D1 To: michaelh, #baloo, #frameworks Cc: ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, alexeymin

D12136: Avoid hardcoding of filesystems supporting CoW

This revision was automatically updated to reflect the committed changes. Closed by commit R293:5f3b8ead07eb: Avoid hardcoding of filesystems supporting CoW (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12136?vs=31944=32213 REVISION

D12044: baloodb: Improve interface

michaelh updated this revision to Diff 32212. michaelh added a comment. This revision is now accepted and ready to land. - Rebase on D12044 REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12044?vs=31684=32212 BRANCH

D12135: Allow disabling of CoW to fail when not supported by filesystem

This revision was automatically updated to reflect the committed changes. Closed by commit R293:92ff146f5563: Allow disabling of CoW to fail when not supported by filesystem (authored by bruns). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D12135?vs=32074=32211#toc REPOSITORY R293

D12231: Reduce the number of zombies to a minimum

tcberner created this revision. tcberner added reviewers: FreeBSD, sitter, apol. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. tcberner requested review of this revision. REVISION SUMMARY With Frameworks 5.45 [1] when building for

D12221: Fix problem that font/italic/... attributes no longer work with e.g. >= Qt 5.9

bcooksley added a comment. @dhaumann Please note that Phabricator review closing can take a few minutes to be processed. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D12221 To: cullmann, #frameworks, #kate, dhaumann Cc: bcooksley, ngraham, dhaumann, michaelh,

D12135: Allow disabling of CoW to fail when not supported by filesystem

bcooksley added a comment. The original author/submitter of a diff for review isn't able to approve their own review, which is why Stefan wasn't permitted to approve this diff. REPOSITORY R293 Baloo BRANCH master REVISION DETAIL https://phabricator.kde.org/D12135 To: bruns, #baloo,

D11810: Add Falkon, Kirigami, macOS, Solid, USB, Wayland, X11, SDDM to general entities

lueck added a comment. Please review, thanks REVISION DETAIL https://phabricator.kde.org/D11810 To: lueck, ltoscano, #documentation Cc: #frameworks, michaelh, ngraham, bruns, skadinna

D11753: baloodb: Add clean command

michaelh updated this revision to Diff 32201. michaelh added a comment. - Rebase REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11753?vs=32175=32201 BRANCH sanitize-clean (branched from master) REVISION DETAIL https://phabricator.kde.org/D11753

D11820: Handle properties with multiple values

michaelh added a comment. Surprising! master F5808891: cur-noidx.png patch F5808893: patch.png REPOSITORY R824 Baloo Widgets REVISION DETAIL https://phabricator.kde.org/D11820 To: michaelh, #baloo,

KDE CI: Frameworks kpackage kf5-qt5 SUSEQt5.9 - Build # 25 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20SUSEQt5.9/25/ Project: Frameworks kpackage kf5-qt5 SUSEQt5.9 Date of build: Sun, 15 Apr 2018 16:53:59 + Build duration: 4 min 14 sec and counting JUnit Tests

KDE CI: Frameworks kpackage kf5-qt5 SUSEQt5.10 - Build # 48 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20SUSEQt5.10/48/ Project: Frameworks kpackage kf5-qt5 SUSEQt5.10 Date of build: Sun, 15 Apr 2018 16:53:59 + Build duration: 1 min 11 sec and counting JUnit Tests

KDE CI: Frameworks kpackage kf5-qt5 FreeBSDQt5.9 - Build # 42 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20FreeBSDQt5.9/42/ Project: Frameworks kpackage kf5-qt5 FreeBSDQt5.9 Date of build: Sun, 15 Apr 2018 16:53:59 + Build duration: 53 sec and counting JUnit Tests

D12144: Fix kpackage autotests - add donation url to test data

This revision was automatically updated to reflect the committed changes. Closed by commit R290:84f64a27fa60: Add donate urls to test data (authored by joselema). REPOSITORY R290 KPackage CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12144?vs=31965=32200 REVISION DETAIL

D12228: kdirlister new connect syntax

jtamate created this revision. jtamate added reviewers: dfaure, Frameworks. Restricted Application added a project: Frameworks. jtamate requested review of this revision. REVISION SUMMARY (partial patch) There is a problem converting KCoreDirLister to the new connect syntax: In void

D12206: Don't show top "Open With" app for folders; only for files

ngraham added a comment. Yep, I was planning on it. REPOSITORY R241 KIO BRANCH no-open-with-for-folders (branched from master) REVISION DETAIL https://phabricator.kde.org/D12206 To: ngraham, #frameworks, elvisangelaccio Cc: rkflx, elvisangelaccio, Zren, michaelh, ngraham, bruns

D12227: Save the dialog view settings even when canceling

ngraham created this revision. ngraham added a reviewer: Frameworks. Restricted Application added a project: Frameworks. ngraham requested review of this revision. REVISION SUMMARY Currently, for file Open & Save dialogs, any view settings you've changed are only remembered if you actually

D12206: Don't show top "Open With" app for folders; only for files

elvisangelaccio accepted this revision as: elvisangelaccio. elvisangelaccio added a comment. This revision is now accepted and ready to land. As for D11569 , make sure we don't break the konqueror test before pushing. REPOSITORY R241 KIO BRANCH

D12206: Don't show top "Open With" app for folders; only for files

ngraham updated this revision to Diff 32198. ngraham added a comment. Remove the top separator again REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12206?vs=32197=32198 BRANCH no-open-with-for-folders (branched from master) REVISION DETAIL

D12206: Don't show top "Open With" app for folders; only for files

ngraham updated this revision to Diff 32197. ngraham marked an inline comment as done. ngraham added a comment. Revert unrelated change for another issue that snuck in... REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12206?vs=32196=32197 BRANCH

D12206: Don't show top "Open With" app for folders; only for files

elvisangelaccio added a comment. In D12206#246735 , @ngraham wrote: > Henrik suggested it: > > In D12206#246415 , @rkflx wrote: > > > +1 for only showing the Open With menu, without an additional

D12206: Don't show top "Open With" app for folders; only for files

ngraham updated this revision to Diff 32196. ngraham added a comment. Return the top separator, and let's fix the excessive separator issue in another patch REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12206?vs=32164=32196 BRANCH no-open-with-for-folders

D12206: Don't show top "Open With" app for folders; only for files

ngraham added a comment. Henrik suggested it: In D12206#246415 , @rkflx wrote: > +1 for only showing the Open With menu, without an additional top app. (But make sure to consolidate the number of separators…) But I can do that in

D12206: Don't show top "Open With" app for folders; only for files

elvisangelaccio added inline comments. INLINE COMMENTS > kfileitemactions.cpp:611 > -if (!topMenu->actions().isEmpty()) { > -topMenu->addSeparator(); > -} Why are we removing this separator? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12206

D11820: Handle properties with multiple values

astippich added a comment. Seems to work just fine, see screenshot: F5808864: Screenshot_20180415_181027.png I did a little bit more testing, and in case you didn't already know: It looks like baloo outputs properties with multiple values as a

D12206: Don't show top "Open With" app for folders; only for files

ngraham added a comment. Ok cool. That's what this patch does. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12206 To: ngraham, #frameworks, elvisangelaccio Cc: rkflx, elvisangelaccio, Zren, michaelh, ngraham, bruns

D12206: Don't show top "Open With" app for folders; only for files

elvisangelaccio added a comment. Yes, what I meant was to show only the "Open with" entry for folders. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12206 To: ngraham, #frameworks, elvisangelaccio Cc: rkflx, elvisangelaccio, Zren, michaelh, ngraham, bruns

D7175: Redesign CMake syntax

dhaumann added a comment. Sure? It was reverted a month ago once. Was it applied again? REVISION DETAIL https://phabricator.kde.org/D7175 To: turbov, dhaumann, #kate, #framework_syntax_highlighting, vkrause, cullmann Cc: cullmann, #frameworks, michaelh, ngraham, bruns

D12047: Avoid crash when reading corrupt data from document terms db

michaelh added a comment. > Corrupt the database As described in BUG: 392877? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12047 To: bruns, #baloo, michaelh, ngraham Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, alexeymin

D12221: Fix problem that font/italic/... attributes no longer work with e.g. >= Qt 5.9

dhaumann added a comment. @ngraham So what is the current state of a proper fix in KFontRequester? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D12221 To: cullmann, #frameworks, #kate, dhaumann Cc: ngraham, dhaumann, michaelh, kevinapavew, bruns, demsking,

D12226: balooshow: Colorize only when attached to terminal

michaelh created this revision. michaelh added a reviewer: Baloo. Restricted Application added projects: Frameworks, Baloo. Restricted Application added a subscriber: Frameworks. michaelh requested review of this revision. TEST PLAN $ balooshow otto.txt $ balooshow otto.txt | head -n 12

D12221: Fix problem that font/italic/... attributes no longer work with e.g. >= Qt 5.9

ngraham added a comment. Nice fix, but it would be a shame if every client needs to work around this in the same way. I'm still holding out hope for a fix to KFontRequester, if possible. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D12221 To: cullmann,

D12225: Also make installation of translated docs optional

heikobecker created this revision. heikobecker added reviewers: Frameworks, apol. Restricted Application added a project: Frameworks. heikobecker requested review of this revision. REVISION SUMMARY 76f3f5b541eea8128297e68bd80278e7f525c1aa

D12114: Revive 'Description' property

michaelh planned changes to this revision. michaelh added a comment. Create cross extractor test REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D12114 To: michaelh, #baloo, #frameworks Cc: bruns, ashaposhnikov, michaelh, astippich, spoorun, ngraham, alexeymin

D11882: autotests: Use built executable instead of installed

michaelh added a comment. In D11882#245719 , @bruns wrote: > Maybe we can add a trivial dummy extractor which is used in unittests, but not anywhere else. It could e.g. return the current date, compilation timestamp (i.e. __DATE__), and the KF

D12222: baloodb: Use complete access filtering for all outputs

michaelh added inline comments. INLINE COMMENTS > main.cpp:161 > return i18n("\n\nCommands:\n%1", allCommandsStr); > } > Ideas for better formatting this are welcome. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D1 To: michaelh, #baloo, #frameworks

D11820: Handle properties with multiple values

michaelh added a subscriber: bruns. REPOSITORY R824 Baloo Widgets REVISION DETAIL https://phabricator.kde.org/D11820 To: michaelh, #baloo, #frameworks Cc: bruns, astippich, mgallien, elvisangelaccio, ashaposhnikov, spoorun, alexeymin

D12135: Allow disabling of CoW to fail when not supported by filesystem

michaelh accepted this revision. michaelh added a comment. This revision is now accepted and ready to land. Of course, but what's the logic here? Does it have to be accepted by a member of Baloo other than you? If I had known REPOSITORY R293 Baloo BRANCH master REVISION DETAIL

D12192: Decode more documentUrls

michaelh added a comment. In D12192#246449 , @bruns wrote: > Can you add a little bit more info to the commit message, e.g. an example how the output looks before and after? I don't know... I realized the necessity to

D12192: Decode more documentUrls

michaelh edited the summary of this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12192 To: michaelh, #baloo, bruns Cc: bruns, #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, alexeymin

D7175: Redesign CMake syntax

cullmann closed this revision. cullmann added a comment. This is already pushed ;=) Autor: Alex Turbov 2017-08-07 08:01:46 Eintragender: Alex Turbov 2018-03-28 21:17:34 Eltern: aa5a8e08e0a2004536ab87531ef93217cf4a

D11820: Handle properties with multiple values

michaelh added a comment. In D11820#246525 , @astippich wrote: > Sorry for the late answer. Isn't this already handled in widgetfactory.cpp toString function (line 87)? During my testing with multiple values I've never had issues with

D12197: autotests: Test for multiple values

michaelh edited the summary of this revision. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D12197 To: michaelh, #baloo, #frameworks, mgallien Cc: bruns, ashaposhnikov, michaelh, astippich, spoorun, ngraham, alexeymin

D11820: Handle properties with multiple values

michaelh planned changes to this revision. michaelh added a comment. Due to a bug in calligra `test.odt` file is broken. see D11971 . REPOSITORY R824 Baloo Widgets REVISION DETAIL https://phabricator.kde.org/D11820 To: michaelh, #baloo, #frameworks

D12221: Fix problem that font/italic/... attributes no longer work with e.g. >= Qt 5.9

cullmann added a comment. Perhaps the fix is only a hack, but at least it solves the issue for me on my company workstation ;=) I was confused what did look strange after the upgrade, until I noticed the missing bold keywords. REPOSITORY R39 KTextEditor REVISION DETAIL

D12222: baloodb: Use complete access filtering for all outputs

michaelh added a task: T8250: Sanitize the database. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D1 To: michaelh, #baloo, #frameworks Cc: ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, alexeymin

D11745: databasesanitizer: Use flags for filtering

This revision was automatically updated to reflect the committed changes. Closed by commit R293:6fb268be2c42: databasesanitizer: Use flags for filtering (authored by michaelh). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11745?vs=32147=32178 REVISION DETAIL

D11753: baloodb: Add clean command

michaelh added inline comments. INLINE COMMENTS > bruns wrote in databasesanitizer.cpp:166 > Why do you remove the private: here? 340: m_pimpl->m_transaction->removeDocument(info.id); and more > bruns wrote in databasesanitizer.cpp:343 > remove `sep`, use `QStringLiteral(" device: %1") instead

D12222: baloodb: Use complete access filtering for all outputs

michaelh edited the summary of this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D1 To: michaelh, #baloo, #frameworks Cc: ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, alexeymin

D11753: baloodb: Add clean command

michaelh added a dependent revision: D1: baloodb: Use complete access filtering for all outputs. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11753 To: michaelh, #baloo, #frameworks, bruns Cc: bruns, cfeck, smithjd, ashaposhnikov, michaelh, astippich, spoorun,

D12222: baloodb: Use complete access filtering for all outputs

michaelh added a dependency: D11753: baloodb: Add clean command. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D1 To: michaelh, #baloo, #frameworks Cc: ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, alexeymin

D12222: baloodb: Use complete access filtering for all outputs

michaelh created this revision. michaelh added reviewers: Baloo, Frameworks. Restricted Application added projects: Frameworks, Baloo. michaelh requested review of this revision. REVISION SUMMARY Add `mounted-only` option to 'list' and 'devices' command Use a common function to determine if a

D12221: Fix problem that font/italic/... attributes no longer work with e.g. >= Qt 5.9

dhaumann added a comment. See: - https://bugs.kde.org/show_bug.cgi?id=376094 - https://bugs.kde.org/show_bug.cgi?id=383665 - https://bugs.kde.org/show_bug.cgi?id=387401 - https://bugs.kde.org/show_bug.cgi?id=391040 They all are closed as a general KFontChooser issue. Maybe we

D11745: databasesanitizer: Use flags for filtering

michaelh added inline comments. INLINE COMMENTS > bruns wrote in databasesanitizer.cpp:250 > This line definitely needs a comment why this is here added in D11753 REPOSITORY R293 Baloo BRANCH sanitize-enums (branched from master) REVISION DETAIL

D11753: baloodb: Add clean command

michaelh updated this revision to Diff 32175. michaelh added a comment. - Improve access filtering REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11753?vs=32105=32175 BRANCH sanitize-clean (branched from master) REVISION DETAIL

D12221: Fix problem that font/italic/... attributes no longer work with e.g. >= Qt 5.9

cullmann closed this revision. cullmann added a comment. Git commit 4d91fa7e918d983e6569798dfe20c7c9faf4bb9e by Christoph Cullmann. Committed on 15/04/2018 at 11:36. Pushed by cullmann into branch 'master'. Fix problem that font/italic/... attributes no longer work with e.g. >= Qt 5.9

D12221: Fix problem that font/italic/... attributes no longer work with e.g. >= Qt 5.9

cullmann added a comment. > Btw there are bug reports for this. Could you link the Kate related ones, if existing? I failed to find them :( I remembered that this was brought up some time ago, but I had no time to take a look at that time. And now I no longer find the mails/bugs :P

D12221: Fix problem that font/italic/... attributes no longer work with e.g. >= Qt 5.9

dhaumann added a comment. Btw there are bug reports for this. Could you link the Kate related ones, if existing? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D12221 To: cullmann, #frameworks, #kate, dhaumann Cc: dhaumann, michaelh, kevinapavew, ngraham, bruns,

D12221: Fix problem that font/italic/... attributes no longer work with e.g. >= Qt 5.9

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. A simple fix for a severe issue - please commit! REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D12221 To: cullmann, #frameworks, #kate, dhaumann Cc:

D7175: Redesign CMake syntax

cullmann accepted this revision. cullmann added a comment. Yes, please push your change. Thanks for the work! REVISION DETAIL https://phabricator.kde.org/D7175 To: turbov, dhaumann, #kate, #framework_syntax_highlighting, vkrause, cullmann Cc: cullmann, #frameworks, michaelh, ngraham,

D11851: Add syntax highlighting for Logcat

This revision was automatically updated to reflect the committed changes. Closed by commit R216:9feb73b7222c: Add syntax highlighting for Logcat (authored by nibags, committed by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

D12221: Fix problem that font/italic/... attributes no longer work with e.g. >= Qt 5.9

cullmann created this revision. cullmann added reviewers: Frameworks, Kate. Restricted Application added projects: Kate, Frameworks. cullmann requested review of this revision. REVISION SUMMARY On e.g. openSUSE 15.0, which has 5.9 as default Qt, bold/italic/... styles no longer work. The

D11820: Handle properties with multiple values

astippich added a comment. Sorry for the late answer. Isn't this already handled in widgetfactory.cpp toString function (line 87)? During my testing with multiple values I've never had issues with baloo-widgets, only with baloo itself. If there are still changes required in baloo-widgets, I

  1   2   >