Re: Regression in Frameworks - DBus Hangs

On Thu, Nov 8, 2018 at 8:15 PM Ben Cooksley wrote: > > On Sat, Nov 3, 2018 at 4:41 PM Ben Cooksley wrote: > > > > Hi all, > > > > Following commits made to Frameworks somewhere in the October 21 to > > October 28 time frame, the unit tests of Konsole on the CI system have > > started to hang foll

D16677: Add BrightScript syntax

dlevin added a comment. Thanks for catching this. Did re-run tests locally, seems no other issue remaining. Please check. REVISION DETAIL https://phabricator.kde.org/D16677 To: dlevin, #framework_syntax_highlighting, cullmann Cc: ngraham, dhaumann, cullmann, kwrite-devel, kde-frameworks-de

D16677: Add BrightScript syntax

dlevin updated this revision to Diff 45260. dlevin added a comment. Replaced missing "code" attribute with "g". CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16677?vs=44885&id=45260 REVISION DETAIL https://phabricator.kde.org/D16677 AFFECTED FILES autotests/html/brightscript.b

D16815: Rename Sublime Text icon to ensure it works

ndavis added a comment. In D16815#357570 , @ngraham wrote: > I know this is a bugfix, but... > > IMHO it's really bad form to design a Breeze version of an app icon that has a totally different visual style from the original--especially if it

D16815: Rename Sublime Text icon to ensure it works

ngraham requested changes to this revision. ngraham added a comment. I know this is a bugfix, but... IMHO it's really bad form to design a Breeze version of an app icon that has a totally different visual style from the original--especially if it completely eliminates all the branding el

D16815: Rename Sublime Text icon to ensure it works

ndavis requested changes to this revision. ndavis added a comment. This revision now requires changes to proceed. I got an error when I tried to land this patch: remote: Audit failure - Commit 5fa9283264f511edf5678cfd09185a16296c7e71 - Non-full name: Rafael I know it might seem sil

D16815: Rename Sublime Text icon to ensure it works

ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. Looks good to me! REPOSITORY R266 Breeze Icons BRANCH fix-sublime REVISION DETAIL https://phabricator.kde.org/D16815 To: trickyricky26, #vdg, ndavis Cc: ndavis, kde-frameworks-devel

D16815: Rename Sublime Text icon to ensure it works

trickyricky26 edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16815 To: trickyricky26, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16815: Rename Sublime Text icon to ensure it works

trickyricky26 created this revision. trickyricky26 added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. trickyricky26 requested review of this revision. REVISION SUMMARY Renamed the Sublime Text icon from sublime.svg to sublime-text.svg to e

D16674: MTP: fix runtime warning when showing a warning to the user.

dfaure closed this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D16674 To: dfaure, akrutzler, elvisangelaccio, apol Cc: kde-frameworks-devel, kfm-devel, alexde, sourabhboss, feverfew, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns,

D14631: Adds a new RenameDialog to KIO with more options for batch renaming

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > batchrenamedialog.cpp:38 > +#include > +#include > +#include Remove all the framework prefixes. E.g. this should be . This way, it fails to find the inclu

D16770: [ftp kio-slave] Fix deletion of directory with non-latin1/utf8 parent path

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > ftp.cpp:1240 > if (!isfile) { > -ftpFolder(remoteEncoding()->directory(url), false);// ignore > errors > +const QString parentDir =

D7380: KCD: use modern logging classes throughout

dfaure added inline comments. INLINE COMMENTS > dfaure wrote in testkcd.cpp:64 > There's proper API for setting applications defaults, without the need for > env vars. My comment is still valid: why doesn't this use QLoggingCategory::setFilterRules() instead? > rjvbb wrote in testkcd.cpp:69 >

D16798: KPluginFactory: fix create() apidox

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R244 KCoreAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D16798 To: elvisangelaccio, dfaure, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16538: [sftp] Add additional sftpProtocol::openConnection() for libssh 0.8.3+

This revision was automatically updated to reflect the committed changes. Closed by commit R320:5043f66d17e1: [sftp] Add additional sftpProtocol::openConnection() for libssh 0.8.3+ (authored by asn). Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-de

D16677: Add BrightScript syntax

cullmann requested changes to this revision. cullmann added a comment. This revision now requires changes to proceed. Hi, I tried to land the patch but the consistency checks of the indexer tell me: "/home/cullmann/local/kde/src/frameworks/syntax-highlighting/data/syntax/brightscript.xml

D16810: Update breeze-light and breeze-dark colorschemes

ndavis edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D16810 To: ndavis, #vdg, #breeze, #plasma Cc: #vdg, kde-frameworks-devel, ggrysuk, alexde, IohannesPetros, ragreen, Pitel, michaelh, crozbo, ndavis, ZrenBot,

D16810: Update breeze-light and breeze-dark colorschemes

ndavis edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D16810 To: ndavis, #vdg, #breeze, #plasma Cc: #vdg, kde-frameworks-devel, ggrysuk, alexde, IohannesPetros, ragreen, Pitel, michaelh, crozbo, ndavis, ZrenBot, fi

D16810: Update breeze-light and breeze-dark colorschemes

ndavis edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D16810 To: ndavis, #vdg, #breeze, #plasma Cc: #vdg, kde-frameworks-devel, ggrysuk, alexde, IohannesPetros, ragreen, Pitel, michaelh, crozbo, ndavis, ZrenBot, fi

D16810: Update breeze-light and breeze-dark colorschemes

ndavis edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D16810 To: ndavis, #vdg, #breeze, #plasma Cc: #vdg, kde-frameworks-devel, ggrysuk, alexde, IohannesPetros, ragreen, Pitel, michaelh, crozbo, ndavis, ZrenBot, fi

D16810: Update breeze-light and breeze-dark colorschemes

ndavis edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D16810 To: ndavis, #vdg, #breeze, #plasma Cc: #vdg, kde-frameworks-devel, ggrysuk, alexde, IohannesPetros, ragreen, Pitel, michaelh, crozbo, ndavis, ZrenBot,

D16810: Update breeze-light and breeze-dark colorschemes

ndavis edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D16810 To: ndavis, #vdg, #breeze, #plasma Cc: #vdg, kde-frameworks-devel, ggrysuk, alexde, IohannesPetros, ragreen, Pitel, michaelh, crozbo, ndavis, ZrenBot,

D16810: Update breeze-light and breeze-dark colorschemes

ndavis added reviewers: Breeze, Plasma. ndavis added projects: VDG, Breeze, Plasma. ndavis added a subscriber: VDG. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D16810 To: ndavis, #vdg, #breeze, #plasma Cc: #vdg, kde-frameworks-devel, ggrysuk, alexde

D16810: Update breeze-light and breeze-dark colorschemes

ndavis edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D16810 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16810: Update breeze-light and breeze-dark colorschemes

ndavis edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D16810 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16810: Update breeze-light and breeze-dark colorschemes

ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY The current colorschemes included in the breeze-light and breeze-dark Plasma themes do not

D8912: Added a set of Game Folder icons

aaronhoneycutt added a comment. This looks awesome folks! Great work! REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D8912 To: andreyorst, #vdg, ngraham Cc: aaronhoneycutt, bruns, ngraham, kde-frameworks-devel, ndavis, michaelh

D8912: Added a set of Game Folder icons

ndavis added a comment. Now for some feedback about the latest changes to the icon: Much better! The area around the joysticks could use some cleaning up though. At 100% size, it's not possible to see the joysticks. My suggestion would be to remove the joysticks, but keep the bumps that

D16617: fix extraction of GPS altitude for exif data

astippich edited the summary of this revision. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16617 To: astippich, #frameworks, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D8912: Added a set of Game Folder icons

ndavis added a comment. In D8912#357376 , @ngraham wrote: > @ndavis can help with this, but yeah, we really need to add this information to https://hig.kde.org/style/icon.html. Noah, since you know how to do that, would you mind submitting a HIG

D8912: Added a set of Game Folder icons

ndavis added a comment. In D8912#357374 , @andreyorst wrote: > I've thought that that's why we have separate breeze and breeze-dark icons. I don't know how to make it dynamic in Inkscape. Is there's any guide for this? It's a PITA, but to

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 471 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/471/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 10 Nov 2018 15:48:10 + Build duration: 21 min and counting JUnit Tests Name: (root) Failed: 0 test(

D16677: Add BrightScript syntax

dlevin added a comment. You can find my credentials at the beginning of the file I added in this patch: data/syntax/brightscript.xml REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D16677 To: dlevin, #framework_syntax_highlighting, cullmann Cc: ngraham, d

D16677: Add BrightScript syntax

cullmann added a comment. That's all fine, its inside the xml syntax file: "Daniel Levin (dendy...@gmail.com)" ;=) I will use that for the commit, otherwise I would have asked ;=) REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D16677 To: dlevin, #frame

D8912: Added a set of Game Folder icons

ngraham added a comment. In D8912#357374 , @andreyorst wrote: > I've had so bad times of getting rid of Cuttlefish on my system because there was no package with the similar name. I'll install it though. If you prefer to use a CLi package

D16677: Add BrightScript syntax

ngraham added a comment. @dlevin That comment was meant for other KDE developers. :) There's nothing you need to do on that front... however, since you submitted the patch using the web interface rather than using `arc`

D8912: Added a set of Game Folder icons

andreyorst added a comment. > Phabricator unfortunately doesn't offer SVG previews, so posting new screenshots every time you update the diff is appreciated. :) Got it. > You can generally find it by searching for "Cuttlefish" in Discover. I've had so bad times of getting rid of

D8912: Added a set of Game Folder icons

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Phabricator unfortunately doesn't offer SVG previews, so posting new screenshots every time you update the diff is appreciated. :) Also, if you don't already know about it,

D16617: fix extraction of GPS altitude for exif data

astippich added inline comments. INLINE COMMENTS > bruns wrote in exiv2extractor.cpp:285 > According to: > https://www.sno.phy.queensu.ca/~phil/exiftool/TagNames/GPS.html > and > http://www.cipa.jp/std/documents/e/DC-008-Translation-2016-E.pdf > > the absolute altitude value is a rational, like

D16716: skip writing test if mime type is not supported by the extractor

astippich added a comment. I think that's my fault when I introduced the extractor for test. Apparently it is using the system libraries, and I'm looking for a solution. I think a skip is still the right thing to do here, since we cannot determine if the tags are correctly written. REPOSIT

D16671: Refactor embedded image extractor for greater extensibility

astippich added inline comments. INLINE COMMENTS > bruns wrote in embeddedimagedata.cpp:204 > I know you have only moved this code here ... > > `TagLib::ByteVector::find` returns `-1` on not found, and we add 1, so this > is safe here. But maybe we should return `QByteArray()` instead? The cod

D16564: cleanup the test for embedded image extraction

This revision was automatically updated to reflect the committed changes. Closed by commit R286:218f4c51c4db: cleanup the test for embedded image extraction (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16564?vs=44587&id=45235

D12114: Revive 'Description' property for DublinCore metadata

astippich added a comment. I've reverted the test data for docx format for now, since there are apparently more issues. Funnily, LibreOffice and MS Word label the description property with "Comment". REPOSITORY R286 KFileMetaData BRANCH description_dc REVISION DETAIL https://phabrica

D12114: Revive 'Description' property for DublinCore metadata

astippich updated this revision to Diff 45234. astippich added a comment. - revert docx test data for now REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12114?vs=44834&id=45234 BRANCH description_dc REVISION DETAIL https://phabricator.kde.org/D1

D16798: KPluginFactory: fix create() apidox

elvisangelaccio marked an inline comment as done. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D16798 To: elvisangelaccio, dfaure, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16798: KPluginFactory: fix create() apidox

elvisangelaccio edited the summary of this revision. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D16798 To: elvisangelaccio, dfaure, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16798: KPluginFactory: fix create() apidox

elvisangelaccio updated this revision to Diff 45232. elvisangelaccio added a comment. - Address comment REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16798?vs=45222&id=45232 BRANCH master REVISION DETAIL https://phabricator.kde.org/D16798 AFFECT

D16801: Fix build on macOS

harald created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. harald requested review of this revision. REVISION SUMMARY On macOS, I'm getting the following error: CMake Error at src/runtime/plugins/CMakeLists.txt:1 (if): if given

D16798: KPluginFactory: fix create() apidox

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kpluginfactory.h:347 > * Use this method to create an object. It will try to create an object > which inherits > - * \p T. If it has multiple choice

KDE CI: Frameworks » knotifications » kf5-qt5 WindowsMSVCQt5.11 - Build # 12 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/knotifications/job/kf5-qt5%20WindowsMSVCQt5.11/12/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Sat, 10 Nov 2018 08:57:46 + Build duration: 2 hr 13 min and counting JUnit Tests

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.9 - Build # 80 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.9/80/ Project: kf5-qt5 SUSEQt5.9 Date of build: Sat, 10 Nov 2018 08:59:01 + Build duration: 1 hr 49 min and counting JUnit Tests Name: (root) Failed:

D16798: KPluginFactory: fix create() apidox

elvisangelaccio added a comment. Note: I'm not 100% the code actually returns `nullptr`, so someone please double check. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D16798 To: elvisangelaccio, dfaure, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16798: KPluginFactory: fix create() apidox

elvisangelaccio created this revision. elvisangelaccio added reviewers: dfaure, apol. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. elvisangelaccio requested review of this revision. REVISION SUMMARY `kFatal()` is long gone and was not ported to `qFatal()`.

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.9 - Build # 40 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.9/40/ Project: kf5-qt5 SUSEQt5.9 Date of build: Sat, 10 Nov 2018 08:59:11 + Build duration: 1 hr 38 min and counting JUnit Tests Name: (root) Fa

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.9 - Build # 70 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.9/70/ Project: kf5-qt5 SUSEQt5.9 Date of build: Sat, 10 Nov 2018 08:55:11 + Build duration: 1 hr 21 min and counting JUnit Tests Name: (root) Fail

KDE CI: Frameworks » kdelibs4support » kf5-qt5 SUSEQt5.9 - Build # 49 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20SUSEQt5.9/49/ Project: kf5-qt5 SUSEQt5.9 Date of build: Sat, 10 Nov 2018 08:55:35 + Build duration: 1 hr 18 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.9 - Build # 69 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.9/69/ Project: kf5-qt5 SUSEQt5.9 Date of build: Sat, 10 Nov 2018 08:54:02 + Build duration: 1 hr 10 min and counting JUnit Tests Name: (root) Fai

KDE CI: Frameworks » kauth » kf5-qt5 WindowsMSVCQt5.11 - Build # 14 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kauth/job/kf5-qt5%20WindowsMSVCQt5.11/14/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Sat, 10 Nov 2018 08:54:40 + Build duration: 59 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.9 - Build # 65 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.9/65/ Project: kf5-qt5 SUSEQt5.9 Date of build: Sat, 10 Nov 2018 08:57:56 + Build duration: 50 min and counting JUnit Tests Name: (root) Failed: 3 te

D12114: Revive 'Description' property for DublinCore metadata

astippich added inline comments. INLINE COMMENTS > bruns wrote in office2007extractortest.cpp:52 > Strictly speaking, this should be part of another commit. > Feel free to split it off and git push without review. Just to let you know, I'm currently having issues creating a new test file. Savin

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.10 - Build # 106 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.10/106/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 10 Nov 2018 08:59:01 + Build duration: 33 min and counting JUnit Tests Name: (root) Failed: 2

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.10 - Build # 52 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.10/52/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 10 Nov 2018 08:59:11 + Build duration: 33 min and counting JUnit Tests Name: (root) Faile

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.10 - Build # 87 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.10/87/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 10 Nov 2018 08:57:56 + Build duration: 30 min and counting JUnit Tests Name: (root) Failed: 3

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 470 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/470/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 10 Nov 2018 08:56:58 + Build duration: 31 min and counting JUnit Tests Name: (root) Failed: 1 test

D7407: audiocd-kio : modernise debugging

rjvbb abandoned this revision. rjvbb added a comment. Done by someone else by now. REPOSITORY R342 KIO AudioCD REVISION DETAIL https://phabricator.kde.org/D7407 To: rjvbb, #frameworks Cc: ltoscano

KDE CI: Frameworks » kdoctools » kf5-qt5 SUSEQt5.10 - Build # 64 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdoctools/job/kf5-qt5%20SUSEQt5.10/64/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 10 Nov 2018 08:56:01 + Build duration: 20 min and counting JUnit Tests Name: (root) Failed: 1

D16196: add a description property to KFileMetaData

astippich added a comment. ping REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16196 To: astippich, mgallien, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

KDE CI: Frameworks » kdelibs4support » kf5-qt5 SUSEQt5.10 - Build # 75 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20SUSEQt5.10/75/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 10 Nov 2018 08:55:35 + Build duration: 21 min and counting JUnit Tests Name: (root) Fai

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.10 - Build # 126 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.10/126/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 10 Nov 2018 08:55:11 + Build duration: 19 min and counting JUnit Tests Name: (root) Failed

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.10 - Build # 125 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.10/125/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 10 Nov 2018 08:54:02 + Build duration: 9 min 56 sec and counting JUnit Tests Name: (root)

D7380: KCD: use modern logging classes throughout

rjvbb set the repository for this revision to R349 KCompactDisc Library. REPOSITORY R349 KCompactDisc Library REVISION DETAIL https://phabricator.kde.org/D7380 To: rjvbb, #frameworks, davidedmundson, ltoscano Cc: dfaure, ltoscano, davidedmundson

D7380: KCD: use modern logging classes throughout

rjvbb updated this revision to Diff 45221. rjvbb added a comment. refactored for master/head CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7380?vs=18470&id=45221 REVISION DETAIL https://phabricator.kde.org/D7380 AFFECTED FILES CMakeLists.txt src/CMakeLists.txt src/kcompact