D12389: Filepicker reads thumbs preview from Dolphin settings

elvisangelaccio added a comment. +1 One more reason to move this stuff from the Dolphin settings into a KCM... REPOSITORY R241 KIO BRANCH dolphin_thumbs (branched from master) REVISION DETAIL https://phabricator.kde.org/D12389 To: anemeth, #frameworks, #vdg, ngraham, #dolphin Cc:

D12420: Make the warning text for deletion operations emphasize its permanency and irreversibility

elvisangelaccio added inline comments. INLINE COMMENTS > jobuidelegate.cpp:229 > widget, > - i18np("Do you really want to delete this item?", > "Do you really want to delete these %1 items?", prettyList.count()), > + i18np

D12327: Show Detailed Tree View by default

elvisangelaccio added a comment. In D12327#250786 , @rkflx wrote: > In D12327#250761 , @elvisangelaccio wrote: > > > I'm not sure I agree with this change > > > At least it's not a -1 yet, so m

D12342: Update CMakeLists.txt

elvisangelaccio removed a reviewer: Frameworks. REPOSITORY R824 Baloo Widgets REVISION DETAIL https://phabricator.kde.org/D12342 To: michaelh, #baloo, #dolphin, elvisangelaccio, #frameworks Cc: ashaposhnikov, astippich, spoorun

D12342: Update CMakeLists.txt

elvisangelaccio requested changes to this revision. elvisangelaccio added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > michaelh wrote in CMakeLists.txt:4 > There is not indication that `baloo-widgets` is an Application. Yet it > resides in the `kde/applicatio

D12327: Show Detailed Tree View by default

elvisangelaccio added a comment. I'm not sure I agree with this change, and afaik Windows does not show the tree view by default in its file dialogs (unless you are referring to `FolderBrowserDialog` from .Net) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12327 To:

D12240: Save the dialog view settings when closing the dialog without hitting the cancel button

elvisangelaccio added inline comments. INLINE COMMENTS > kdeplatformfiledialoghelper.cpp:240 > +// Save the view settings before closing the dialog when the Escape key > +// is presed or the close button in the titlebar is clicked > +void KDEPlatformFileDialog::reject() typo: pressed REPOSITORY

D12234: Update unit tests after removing "this month" and "last month" items

elvisangelaccio added a comment. +1 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12234 To: joselema, davidedmundson Cc: elvisangelaccio, ngraham, rikmills, #frameworks, michaelh, bruns

D12206: Don't show top "Open With" app for folders; only for files

elvisangelaccio accepted this revision as: elvisangelaccio. elvisangelaccio added a comment. This revision is now accepted and ready to land. As for D11569 , make sure we don't break the konqueror test before pushing. REPOSITORY R241 KIO BRANCH no-open

D12206: Don't show top "Open With" app for folders; only for files

elvisangelaccio added a comment. In D12206#246735 , @ngraham wrote: > Henrik suggested it: > > In D12206#246415 , @rkflx wrote: > > > +1 for only showing the Open With menu, without an additional

D12206: Don't show top "Open With" app for folders; only for files

elvisangelaccio added inline comments. INLINE COMMENTS > kfileitemactions.cpp:611 > -if (!topMenu->actions().isEmpty()) { > -topMenu->addSeparator(); > -} Why are we removing this separator? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12206

D12206: Don't show top "Open With" app for folders; only for files

elvisangelaccio added a comment. Yes, what I meant was to show only the "Open with" entry for folders. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12206 To: ngraham, #frameworks, elvisangelaccio Cc: rkflx, elvisangelaccio, Zren, michaelh, ngraham, bruns

D10141: Restore Persistence=session for the file ioslave kauth helper

elvisangelaccio added a comment. @fvogt @lbeltrame @davidedmundson Any remaining objections? REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D10141 To: elvisangelaccio, lbeltrame, dfaure, davidedmundson, fvogt, chinmoyr Cc: aacid, #frameworks, michaelh, n

D11569: Improve consistency of "Open With" UI by always showing top app inline

elvisangelaccio added a comment. I didn't notice that this change also affects the context menu of folders. That doesn't make much sense and just clutters the menu, imho. Why would I want an "Open with Gwenview" action if 99% of my folders do not contain pictures? REPOSITORY R241 KIO

D11948: [KFileWidget] Hardcode example user name

elvisangelaccio added a comment. +1 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11948 To: broulik, #frameworks Cc: elvisangelaccio, michaelh, ngraham

D11767: Remove Recently Saved This Month and Recently Saved Last Month entries by default

elvisangelaccio added a comment. +1 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11767 To: ngraham, #dolphin, #gwenview, #frameworks, #vdg Cc: elvisangelaccio, abetts, rizzitello, michaelh, ngraham

D11569: Improve consistency of "Open With" UI by always showing top app inline

elvisangelaccio added a comment. +1 from me, other than the inline comment. INLINE COMMENTS > kfileitemactions.cpp:654 > +// Always show the top app inline > +QAction *act = d->createAppAction(offers.takeFirst(), menu); > +menu->addAction(act); Please use

D11740: ktooltipwidget: Subtract margins from available size

elvisangelaccio accepted this revision as: elvisangelaccio. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D11740 To: michaelh, #frameworks, elvisangelaccio Cc: elvisangelaccio, cfeck, michaelh, ngraham

D11740: ktooltipwidget: Subtract margins from available size

elvisangelaccio removed a reviewer: Frameworks. This revision is now accepted and ready to land. Restricted Application added a subscriber: Frameworks. REPOSITORY R236 KWidgetsAddons BRANCH restrict_size REVISION DETAIL https://phabricator.kde.org/D11740 To: michaelh, elvisangelaccio Cc:

D11740: ktooltipwidget: Subtract margins from available size

elvisangelaccio requested changes to this revision. elvisangelaccio added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > ktooltipwidgettest.cpp:33-37 > +void initStyle() { > +// Change manually to test available styles > +// QApplication::setStyle(QStrin

D11628: Fix remotedirnotify service file

elvisangelaccio accepted this revision as: elvisangelaccio. elvisangelaccio added a comment. This revision is now accepted and ready to land. Good catch, thanks. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D11628 To: valeriymalov, #frameworks, elvisan

D11510: [KPropertiesDialog] Support Checksum tab for any local path

elvisangelaccio accepted this revision as: elvisangelaccio. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11510 To: broulik, #frameworks, dfaure, elvisangelaccio, hein Cc: michaelh, ngraham

D11238: filemetadatawidgettest: Enforce en_US locale

elvisangelaccio accepted this revision as: elvisangelaccio. elvisangelaccio added a comment. This revision is now accepted and ready to land. I still don't understand what's the difference between this test and the kio ones, but this fixes the problem so I'd say let's go with it for now. REPO

D11457: decrease bitrate precision for display

elvisangelaccio accepted this revision as: elvisangelaccio. This revision is now accepted and ready to land. REPOSITORY R824 Baloo Widgets BRANCH bitrate_precision REVISION DETAIL https://phabricator.kde.org/D11457 To: astippich, #frameworks, #baloo, elvisangelaccio Cc: ashaposhnikov, ast

D11360: provide sample rate in kHz

elvisangelaccio removed a reviewer: Frameworks. REPOSITORY R824 Baloo Widgets REVISION DETAIL https://phabricator.kde.org/D11360 To: astippich, #baloo, elvisangelaccio, #frameworks Cc: elvisangelaccio, ashaposhnikov, astippich, spoorun, nicolasfella, alexeymin

D11360: provide sample rate in kHz

elvisangelaccio requested changes to this revision. elvisangelaccio added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > widgetfactory.cpp:122-124 > +if (prop == QLatin1String("duration")) { > valueString = form.formatDuration(value.toInt()

D11360: provide sample rate in kHz

elvisangelaccio added inline comments. INLINE COMMENTS > widgetfactory.cpp:126 > valueString = i18nc("@label bitrate (per second)", "%1/s", > form.formatByteSize(value.toInt(), 1, KFormat::MetricBinaryDialect)); > +} else if (prop == QStringLiteral("sampleRate")) { > +

D11238: filemetadatawidgettest: Enforce en_US locale

elvisangelaccio added a comment. In D11238#223569 , @michaelh wrote: > In D11238#223419 , @elvisangelaccio wrote: > > > Do you know why `qputenv()` doesn't work? > > > Not at all. I'm totally c

D11238: filemetadatawidgettest: Enforce en_US locale

elvisangelaccio added a comment. Do you know why `qputenv()` doesn't work? INLINE COMMENTS > filemetadatawidgettest.cpp:41-44 > +#ifndef Q_OS_WIN > +setenv("LC_ALL", "en_US", 1); > +#endif > +QLocale::setDefault(QLocale("en_US")); Why both? `QLocale::setDefault()` seems to be enough

D11226: autotests: Restructure

elvisangelaccio accepted this revision as: elvisangelaccio. elvisangelaccio added a comment. This revision is now accepted and ready to land. In D11226#223088 , @michaelh wrote: > In D11226#223085 , @elv

D11226: autotests: Restructure

elvisangelaccio added a comment. Doesn't build here: ../autotests/filemetadatawidgettest.cpp:22:10: fatal error: 'config.h' file not found REPOSITORY R824 Baloo Widgets REVISION DETAIL https://phabricator.kde.org/D11226 To: michaelh, elvisangelaccio, #baloo, #frameworks Cc: ashap

D9973: ktooltipwidget: Fix tooltip positioning

elvisangelaccio added a comment. In D9973#223039 , @michaelh wrote: > In D9973#223017 , @elvisangelaccio wrote: > > > Thanks! :) > > > Yeah, same to you: Thanks! I'm learning a lot. > Wrt tool

D9973: ktooltipwidget: Fix tooltip positioning

elvisangelaccio removed reviewers: Frameworks, Dolphin. Restricted Application added a subscriber: Frameworks. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D9973 To: michaelh, elvisangelaccio, ngraham, #dolphin Cc: #frameworks, dfaure, cfeck, michaelh

D9973: ktooltipwidget: Fix tooltip positioning

elvisangelaccio accepted this revision. elvisangelaccio added a comment. This revision is now accepted and ready to land. Thanks! :) REPOSITORY R236 KWidgetsAddons BRANCH tooltip_and_test (branched from master) REVISION DETAIL https://phabricator.kde.org/D9973 To: michaelh, elvisangel

D10312: FileUndoManager: don't delete non-existing local files

This revision was automatically updated to reflect the committed changes. Closed by commit R241:f6a2bb0b6836: FileUndoManager: don't delete non-existing local files (authored by elvisangelaccio). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10312?vs=29183&id=292

D9973: ktooltipwidget: Fix tooltip positioning

elvisangelaccio added a comment. Almost there! Just minor comments. INLINE COMMENTS > ktooltipwidgettest.cpp:195 > +QLabel* contentWidget = new QLabel(content); > +const QSize shrinkSize{2 * m_offset, 2 * m_offset}; > +contentWidget->setMaximumSize(m_screenGeometry.size() - shrink

D10312: FileUndoManager: don't delete non-existing local files

elvisangelaccio updated this revision to Diff 29183. elvisangelaccio added a comment. - QLatin1String for concat REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10312?vs=29182&id=29183 BRANCH undo-deleted-file (branched from master) REVISION DETAIL https:/

D10312: FileUndoManager: don't delete non-existing local files

elvisangelaccio updated this revision to Diff 29182. elvisangelaccio added a comment. - Address comments REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10312?vs=27940&id=29182 BRANCH undo-deleted-file (branched from master) REVISION DETAIL https://phabric

D10312: FileUndoManager: don't delete non-existing local files

elvisangelaccio marked 3 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10312 To: elvisangelaccio, dfaure Cc: ngraham, #frameworks, michaelh

D11204: Support NTFS hidden files

elvisangelaccio added a comment. In D11204#222427 , @rominf wrote: > In D11204#222421 , @broulik wrote: > > > Shouldn't that rather go into the `file` KIO slave so it sets the `UDS_HIDDEN` attribute

D9973: ktooltipwidget: Fix tooltip positioning

elvisangelaccio requested changes to this revision. elvisangelaccio added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > ktooltippositiontest.cpp:39-52 > +void KTooltipPositionTest::init() > +{ > +m_container = new QWidget(); > +m_target = new QLabel(QSt

D9973: ktooltipwidget: Fix tooltip positioning

elvisangelaccio added a comment. @michaelh I'll try to have a look this weekend. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D9973 To: michaelh, elvisangelaccio, #frameworks, #dolphin, ngraham Cc: cfeck, michaelh

D10663: Remove a partially copied file if copyjob was cancelled in the middle of file copying

elvisangelaccio added a comment. @dmitrio: you can click on the "Plan Changes" action, no need to abandon this revision and create a new one. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10663 To: dmitrio, #frameworks, dfaure Cc: elvisangelaccio, ngraham, anthonyfier

D10312: FileUndoManager: don't delete non-existing local files

elvisangelaccio updated this revision to Diff 27940. elvisangelaccio added a comment. - Improved unit test - Replaced slotUnlock() with slotPop() REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10312?vs=26542&id=27940 BRANCH undo-deleted-file (branched from

D10635: Bug 383764: remove last file being copied/moved when the action was canceled or when the disk was full

elvisangelaccio added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10635 To: meven, dfaure Cc: #frameworks, michaelh

D10312: FileUndoManager: don't delete non-existing local files

elvisangelaccio added inline comments. INLINE COMMENTS > dfaure wrote in fileundomanager.cpp:404 > Yep. Ok, that's enough to fix the dolphin side, but now the new unit test doesn't pass... REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10312 To: elvisangelaccio, dfaure

D10617: Fix "ambiguous shortcut" issue introduced with D10314

elvisangelaccio added a comment. In D10617#208513 , @ngraham wrote: > The shortcut won't affect other apps since the file dialog its its own context. Even if the host app uses F12 for something, the file dialog will grab the key first, so there'

D10617: Fix "ambiguous shortcut" issue introduced with D10314

elvisangelaccio added a comment. Would be nice to get more feedback before choosing a shortcut that affects many applications. I don't think that F12 is a good choice. The F keys are few and some of them are already taken (Help, Rename, Reload, Fullscreen - and yes, it's bad that dolphi

D9675: Don't show context menu menu if right-clicking outside

elvisangelaccio added a comment. +1 works for me. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D9675 To: broulik, #frameworks, dfaure Cc: elvisangelaccio, wbauer, michaelh

D9675: Don't show context menu menu if right-clicking outside

elvisangelaccio added a reviewer: dfaure. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D9675 To: broulik, #frameworks, dfaure Cc: wbauer, michaelh

D10340: Clean up old, unreachable code

elvisangelaccio added a reviewer: dfaure. REPOSITORY R306 KParts REVISION DETAIL https://phabricator.kde.org/D10340 To: heikobecker, #frameworks, dfaure Cc: michaelh

D10340: Clean up old, unreachable code

elvisangelaccio added a comment. +1 REPOSITORY R306 KParts REVISION DETAIL https://phabricator.kde.org/D10340 To: heikobecker, #frameworks, dfaure Cc: elvisangelaccio, michaelh

D10312: FileUndoManager: don't delete non-existing local files

elvisangelaccio added inline comments. INLINE COMMENTS > dfaure wrote in fileundomanager.cpp:404 > Where's the corresponding call to slotUnlock? > > I think you only wanted to update the state of the action, maybe better to do > that directly. You mean just an `emit undoAvailable(false);` ? R

D10363: [KIO] Add support for XDG_TEMPLATES_DIR in KNewFileMenu

elvisangelaccio added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10363 To: mmustac, #frameworks, dfaure Cc: broulik, ngraham, michaelh

D10362: Swap reveal password button logic

elvisangelaccio added a comment. Hmm I don't know, that's a button and a button should tell me what happens when I click it (Dolphin is also wrong imho). Would it be possible to implement this feature like in the Windows 10 lock screen? (i.e. don't toggle the state; reveal the password o

D10312: FileUndoManager: don't delete non-existing local files

elvisangelaccio edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10312 To: elvisangelaccio, dfaure Cc: #frameworks, michaelh, ngraham

D10312: FileUndoManager: don't delete non-existing local files

elvisangelaccio created this revision. elvisangelaccio added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. elvisangelaccio requested review of this revision. REVISION SUMMARY After a CopyJob the FileUndoManager reco

D10113: baloo-widgets: Emit metaDataRequestFinished once per request

elvisangelaccio accepted this revision as: elvisangelaccio. This revision is now accepted and ready to land. REPOSITORY R824 Baloo Widgets BRANCH signalavailable (branched from master) REVISION DETAIL https://phabricator.kde.org/D10113 To: michaelh, elvisangelaccio, smithjd, vhanda, ngrah

D10211: Suggestion for emacs icon

elvisangelaccio added a reviewer: andreaska. REVISION DETAIL https://phabricator.kde.org/D10211 To: lshoravi, #breeze, #vdg, ngraham, andreaska Cc: davidc, michaelh, abetts, ngraham, #frameworks

D10212: New virtualbox icon

elvisangelaccio added a reviewer: andreaska. REVISION DETAIL https://phabricator.kde.org/D10212 To: lshoravi, #breeze, ngraham, #vdg, andreaska Cc: ltoscano, davidc, #frameworks, michaelh, ngraham

D10113: baloo-widgets: Emit metaDataRequestFinished once per request

elvisangelaccio added inline comments. INLINE COMMENTS > michaelh wrote in filemetadataprovider.cpp:323 > In that case it might be safer to do > > IndexedDataRetriever *ret = new IndexedDataRetriever(filePath, this); > ​connect(ret, SIGNAL(finished(KJob*)), this, > SLOT(slotLoadi

D10172: KRun: allow executing "add network folder" without confirmation prompt

elvisangelaccio added a comment. +1 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10172 To: dfaure, mwolff, dhaumann Cc: elvisangelaccio, ngraham, #dolphin, #frameworks, michaelh

D10105: baloo-widgets: Refactor filemetadataprovider for better readability

elvisangelaccio accepted this revision as: elvisangelaccio. elvisangelaccio added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > filemetadataprovider.cpp:106 > > + > } unrelated whitespace change > filemetadataprovider.h:119 > > + > +private: u

D10105: baloo-widgets: Refactor filemetadataprovider for better readability

elvisangelaccio added inline comments. INLINE COMMENTS > michaelh wrote in filemetadataprovider.cpp:141 > I've been thinking about this... > > We already have guards against files.isEmpty() in > > 355if (!urls.isEmpty()) { > > and > > 373 } else if (items.size() == 1) { > > Unless

D10105: baloo-widgets: Refactor filemetadataprovider for better readability

elvisangelaccio added inline comments. INLINE COMMENTS > filemetadataprovider.cpp:137 > + > +if (files.size() == 0) { > +emit loadingFinished(); `files.isEmpty()` > michaelh wrote in filemetadataprovider.cpp:141 > We can leave early here, I think. > Without a file > > 149 i

D10113: baloo-widgets: Emit metaDataRequestFinished once per request

elvisangelaccio added a comment. +1, looks good to me. INLINE COMMENTS > michaelh wrote in filemetadataprovider.cpp:323 > Is it guaranteed, that this is emitted before IndexedDataRetriever job is > finished? I don't think so, because `IndexedDataRetriever::start()` does not block. REPOSITO

D10105: baloo-widgets: Refactor filemetadataprovider for better readability

elvisangelaccio edited the summary of this revision. REPOSITORY R824 Baloo Widgets REVISION DETAIL https://phabricator.kde.org/D10105 To: michaelh, elvisangelaccio, ngraham, vhanda, smithjd, #dolphin, #frameworks

D10105: baloo-widgets: Refactor filemetadataprovider for better readability

elvisangelaccio added inline comments. INLINE COMMENTS > filemetadataprovider.cpp:140 > +} else { > m_data = files.first(); > +insertSingleFileBasicData(); This will crash if `files` is empty, I think? > filemetadataprovider.cpp:195 > +allDirectories &= item.isDir()

D10141: Restore Persistence=session for the file ioslave kauth helper

elvisangelaccio created this revision. elvisangelaccio added reviewers: lbeltrame, dfaure, davidedmundson, fvogt, chinmoyr. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. elvisangelaccio requested review of this revision. REVISION SUMMAR

D10105: baloo-widgets: Refactor filemetadataprovider for better readability

elvisangelaccio added a comment. I'd split this into 2 patches: one for the code style changes, and another one for the actual code refactoring. This way if the refactoring breaks something, it will be easier to figure out where the problem is. REPOSITORY R824 Baloo Widgets REVISION DET

D9973: ktooltipwidget: Fix tooltip positioning

elvisangelaccio added inline comments. INLINE COMMENTS > michaelh wrote in ktooltipwidget.cpp:155 > > Are you saying that you don't want to correct it at the second place, just > > because tests did not reveal a bug? > > Yes, but it is rather like this: Due to my lack of my experience I don't

D9973: ktooltipwidget: Fix tooltip positioning

elvisangelaccio added a comment. @michaelh Can you please describe exactly how many bugs are there and how to reproduce them? Also, ideally each bug should be reproduced by a test case in `ktooltipwidgettest.cpp`, but I understand that's a lot to ask (so feel free to ignore it). REPOSI

D9844: Don't stat(/etc/localtime) between read() and write() copying files

elvisangelaccio added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9844 To: jtamate, #frameworks, dfaure Cc: ngraham, #dolphin

Re: [kio] src/ioslaves/file/kauth: Do not cache root password for the whole session

On venerdì 12 gennaio 2018 17:35:30 CET, chinmoy ranjan wrote: I just tested this in my session: kioclient5 copy /mnt Prompt appears, all OK. Now I do this again in the same session, after removing the file: kioclient5 copy /mnt No password prompt and the file is copied anyway. I execute

D9840: Tentative patch to reduce I/O overhead of plasmashell when copying files

elvisangelaccio added a reviewer: dfaure. REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D9840 To: jtamate, #frameworks, dfaure Cc: ngraham, mmustac

Re: [kio] src/ioslaves/file/kauth: Do not cache root password for the whole session

On venerdì 12 gennaio 2018 19:40:50 CET, David Edmundson wrote: Can we keep all messages on the ML. We can only see half a conversation on here. TBH I can't see how any application will bypass the prompt A rogue plugin can call org.kde.kio.file.exec directly with kauth. Or even just use DB

Re: Current security issues with KAuth support in KIO

On sabato 13 gennaio 2018 23:55:16 CET, Luca Beltrame wrote: (please keep Fabian in CC, he's not subscribed and found out most of the issues reported here) At openSUSE we have to request reviews by the security team before new polkit services get accepted. This is the case for the kio kauth he

D9729: [KPropertiesDialog] Enable word wrap for checksum description

elvisangelaccio accepted this revision as: elvisangelaccio. This revision is now accepted and ready to land. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9729 To: broulik, #frameworks, elvisangelaccio

D9712: balooctl status: produce parseable output

elvisangelaccio added inline comments. INLINE COMMENTS > michaelh wrote in statuscommand.cpp:108 > I see. Thank you for the info. > The only thing translated in this function is the filename. I am new to this, > but I think that is the only item that does not need translation. > It should be ex

D8698: Fix KProtocoInfoTest if krusader is installed

elvisangelaccio added a comment. Ping? If there are no objections I'll land this before the next tagging. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8698 To: elvisangelaccio, dfaure Cc: ngraham, #frameworks

D8536: Add more hashing algorithms to KPropertiesDialog

elvisangelaccio requested changes to this revision. elvisangelaccio added a comment. This revision now requires changes to proceed. All right, let's go with the combobox. Before I look into the non-ui code, please update the patch by following the Frameworks coding style: https://communit

D9332: Allow filter places based on alternative application name

elvisangelaccio added inline comments. INLINE COMMENTS > kfileplacesmodeltest.cpp:145 > +KFilePlacesModel *currentModel = model; > +if (currentModel == nullptr) { > +currentModel = m_places; `if (!currentModel)` ? > kfileplacesmodel.h:69 > +/** > +* @brief Construct a ne

D9252: Created 'GroupHiddenRole' for KPlacesModel

elvisangelaccio removed a dependent revision: D9242: Implemented support for hide/show groups. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9252 To: renatoo, mwolff Cc: #frameworks

D8336: Improve apidox of KJobTrackerInterface

This revision was automatically updated to reflect the committed changes. Closed by commit R244:c688a15d871a: Improve apidox of KJobTrackerInterface (authored by elvisangelaccio). REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8336?vs=23725&id=23831 REVIS

D8336: Improve apidox of KJobTrackerInterface

elvisangelaccio updated this revision to Diff 23725. elvisangelaccio added a comment. - Dropped TODO, there is not enough evidence that this method should become protected. REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8336?vs=23105&id=23725 BRANCH

D8336: Improve apidox of KJobTrackerInterface

elvisangelaccio marked an inline comment as done. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D8336 To: elvisangelaccio, kossebau, dfaure Cc: apol, #frameworks

D8698: Fix KProtocoInfoTest if krusader is installed

elvisangelaccio added a comment. Ping? In https://phabricator.kde.org/D8698#165475, @ngraham wrote: > Is the same problem present in the non-test code? I just noticed https://bugs.kde.org/show_bug.cgi?id=384991, which seems to report a similar or identical issue. I replied i

D8697: Don't check whether an empty filename exists

This revision was automatically updated to reflect the committed changes. Closed by commit R241:549fc81e8e8a: Don't check whether an empty filename exists (authored by elvisangelaccio). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8697?vs=22035&id=23106 REVISIO

D8336: Improve apidox of KJobTrackerInterface

elvisangelaccio updated this revision to Diff 23105. elvisangelaccio marked 3 inline comments as done. elvisangelaccio added a comment. - Addressed comments REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8336?vs=20870&id=23105 BRANCH master REVISION

D8536: Add more hashing algorithms to KPropertiesDialog

elvisangelaccio added reviewers: VDG, colomar. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8536 To: petermajchrak, elvisangelaccio, #vdg, colomar Cc: colomar, anthonyfieroni, bcooksley, alexeymin, ngraham, elvisangelaccio, #frameworks

D8536: Add more hashing algorithms to KPropertiesDialog

elvisangelaccio added a subscriber: colomar. elvisangelaccio added a comment. In https://phabricator.kde.org/D8536#165899, @anthonyfieroni wrote: > In https://phabricator.kde.org/D8536#165865, @elvisangelaccio wrote: > > > As I mentioned, using //only// a combobox doesn't work, because

D9005: fix crash during file copy after message box warning

elvisangelaccio added a comment. If this doesn't fix bug #332948, please remove it from the BUG: keyword, otherwise it will be automatically closed when pushing this commit. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9005 To: jtamate, #frameworks, dfaure Cc: elvisa

D8920: Fixes url navigation with relative links on KUrlNavigator

elvisangelaccio added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8920 To: emateli, #frameworks, dfaure Cc: #frameworks

D8851: Set enable_blur_behind hint on demand.

elvisangelaccio accepted this revision. This revision is now accepted and ready to land. REPOSITORY R236 KWidgetsAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D8851 To: davidedmundson, elvisangelaccio Cc: #frameworks

D8837: Fix testtrash with qtbase 5.10 beta 4

elvisangelaccio added a comment. In https://phabricator.kde.org/D8837#168682, @bcooksley wrote: > The reason why I ask is - would it be worth setting up a parallel build against Qt 5.10 on the CI to see what else breaks test wise? Imho yes, better CI coverage is always a good thin

D8847: Depend on KIO::PreviewJob::defaultPlugins() and KF 5.40

elvisangelaccio accepted this revision as: elvisangelaccio. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras BRANCH master REVISION DETAIL https://phabricator.kde.org/D8847 To: ngraham, #frameworks, broulik, elvisangelaccio

D8841: Fix build on FreeBSD

This revision was automatically updated to reflect the committed changes. Closed by commit R241:a208dc70c9a5: Fix build on FreeBSD (authored by elvisangelaccio). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8841?vs=22441&id=22446 REVISION DETAIL https://phabr

D8841: Fix build on FreeBSD

elvisangelaccio created this revision. elvisangelaccio added reviewers: adridg, dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY I broke the build on FreeBSD, this patch should fix it. REPOSITORY R241 KIO BRAN

D8836: Fix KIO::mkpath with qtbase 5.10 beta 4

This revision was automatically updated to reflect the committed changes. Closed by commit R241:2353119aae8f: Fix KIO::mkpath with qtbase 5.10 beta 4 (authored by elvisangelaccio). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8836?vs=22433&id=22436 REVISION DET

D8837: Fix testtrash with qtbase 5.10 beta 4

This revision was automatically updated to reflect the committed changes. Closed by commit R241:05938a167dd4: Fix testtrash with qtbase 5.10 beta 4 (authored by elvisangelaccio). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8837?vs=22431&id=22437 REVISION DETAI

<    1   2   3   4   5   6   7   8   9   10   >