D6800: Add template for a simple kpart-based application

kossebau added a subscriber: ltoscano. kossebau added a comment. In https://phabricator.kde.org/D6800#128256, @aacid wrote: > At least there is a problem l10n wise in which there is a Messages.sh so i guess it will be run and create a "fake" .pot file (and something similar for the

D6772: Fix usage of query_qmake: differ between calls expecting qmake or not

kossebau added a comment. In https://phabricator.kde.org/D6772#129531, @apol wrote: > Works for me. > Are you sure we don't need to include the `TRY` on other calls? Any calls you would be thinking off? The ones where this patch does not add `TRY` are in code which expects

D6772: Fix usage of query_qmake: differ between calls expecting qmake or not

kossebau marked an inline comment as done. kossebau added a comment. If there are no objections, will push on Saturday, 29th July REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D6772 To: kossebau, #frameworks, ltoscano, rdieter, apol Cc: #build_system

D6800: Add template for a simple kpart-based application

This revision was automatically updated to reflect the committed changes. Closed by commit R306:089284db0c0d: Add template for a simple kpart-based application (authored by kossebau). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D6800?vs=16946=17264#toc REPOSITORY R306 KParts

D6772: Fix usage of query_qmake: differ between calls expecting qmake or not

kossebau added a comment. A regression due to https://phabricator.kde.org/R240:8ac7abb78d97210c5cbbc87fba83d58d7b843a8d Seems the "it allows for modules using it to decide what they should do" was never told the modules using it ;) REPOSITORY R240 Extra CMake Modules REVISION DETAIL

D6772: Fix usage of query_qmake: differ between calls expecting qmake or not

kossebau added a reviewer: apol. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D6772 To: kossebau, #frameworks, ltoscano, rdieter, apol Cc: #build_system

D6772: Fix usage of query_qmake: differ between calls expecting qmake or not

kossebau added a comment. In https://phabricator.kde.org/D6772#126799, @apol wrote: > What's the background for the change? When KDE_INSTALL_USE_QT_SYS_PATHS is explicitely set to ON but no qmake-qt5 executable found (like @rdieter reported to be possible on fedora packaging),

D6782: Remove unused init() declaration from K_PLUGIN_FACTORY_DECLARATION_WITH_BASEFACTORY_SKEL

kossebau created this revision. Restricted Application added a project: Frameworks. REVISION SUMMARY Method implementation was removed in https://phabricator.kde.org/R244:b6c7c9b93b8dbb24c4a60e7fe72bb1d561d968a0 so this declaration just adds dead code to the macro expansion. TEST PLAN

D6772: Fix usage of query_qmake: differ between calls expecting qmake or not

kossebau updated this revision to Diff 16912. kossebau added a comment. - use cmake_parse_arguments - fix english grammar in dox REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6772?vs=16880=16912 BRANCH handlenoqmakefound REVISION DETAIL

D6789: API dox: add note about moc include need with K_PLUGIN_FACTORY(_WITH_JSON)

This revision was automatically updated to reflect the committed changes. Closed by commit R244:f0a17af5abd5: API dox: add note about moc include need with K_PLUGIN_FACTORY(_WITH_JSON) (authored by kossebau). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D6789?vs=16929=16951#toc

D6773: Add API dox for KDEInstallDirs' KDE_INSTALL_USE_QT_SYS_PATHS

This revision was automatically updated to reflect the committed changes. Closed by commit R240:f5c11c00198e: Add API dox for KDEInstallDirs' KDE_INSTALL_USE_QT_SYS_PATHS (authored by kossebau). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D6773?vs=16881=16952#toc REPOSITORY R240

D6789: API dox: add note about moc include need with K_PLUGIN_FACTORY(_WITH_JSON)

kossebau created this revision. Restricted Application added a project: Frameworks. REPOSITORY R244 KCoreAddons BRANCH addnoteaboutmocincludewithpluginfactory REVISION DETAIL https://phabricator.kde.org/D6789 AFFECTED FILES src/lib/plugin/kpluginfactory.h To: kossebau, #frameworks

D6338: DOXYGEN_PREPROC -> DOXYGEN_SHOULD_SKIP_THIS, to standardize within KF5

This revision was automatically updated to reflect the committed changes. Closed by commit R249:c0445f0c536b: DOXYGEN_PREPROC -> DOXYGEN_SHOULD_SKIP_THIS, to standardize within KF5 (authored by kossebau). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D6338?vs=15738=15940#toc REPOSITORY

D6339: Remove custom doxygen config files

This revision was automatically updated to reflect the committed changes. Closed by commit R249:f9bd662f22d8: Remove custom doxygen config files (authored by kossebau). REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6339?vs=15739=15939 REVISION DETAIL

D5455: Extend Programmer's Guide with notes about influence of setlocale()

kossebau added a comment. ping? REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D5455 To: kossebau, #frameworks, ilic

D5439: API dox: more info about KAboutData's orgDomain/desktopFileName properties

This revision was automatically updated to reflect the committed changes. Closed by commit R244:f01e8b41f622: API dox: more info about KAboutData's orgDomain/desktopFileName properties (authored by kossebau). REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE

D6772: Fix usage of query_qmake: differ between calls expecting qmake or not

This revision was automatically updated to reflect the committed changes. Closed by commit R240:03fc1de44ef9: Fix usage of query_qmake: differ between calls expecting qmake or not (authored by kossebau). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE

D7011: Extract lineedit password

kossebau added inline comments. INLINE COMMENTS > mlaurent wrote in knewpasswordwidgettest.cpp:63 > Nope as setPassword not authorize to see icon (it's a security when we > setPassword from apps you don't want to see it) Could you add this as comment to this line? it is not directly obvious,

D7011: Extract lineedit password

kossebau added inline comments. INLINE COMMENTS > kpasswordlineedit.cpp:30 > + > +class KPasswordLineEdit::KPasswordLineEditPrivate : public QObject > +{ Make this a normal class KPasswordLineEditPrivate here, following fixes proposed above for the header. > kpasswordlineedit.h:25 > +class

D6841: Use "document-close" as icon for KStandardAction::close

This revision was automatically updated to reflect the committed changes. Closed by commit R265:89b36b21701c: Use "document-close" as icon for KStandardAction::close (authored by kossebau). REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE

D7187: RFC: Make ECMAddTests respect BUILD_TESTING

kossebau added a comment. +1 as well. Please also add a note in the API dox what BUILD_TESTING will do on this macro, so this is not magic behaviour and people can plan with this (like making sure to not `set target_link_libraries(... Qt5::Tests)` separately, but only pass as args in the

D5866: ecm_qt_declare_logging_category(): more unique include guard for header

kossebau created this revision. Restricted Application added projects: Frameworks, Build System. REVISION SUMMARY The old guard was created just from the identifier + _H, which runs the chance to clash in projects which use an identifier matching the project name and which also have a class

D5866: ecm_qt_declare_logging_category(): more unique include guard for header

kossebau added a comment. A different reasoning for why not yet using `#pragma once`: this macro targets users of projects with at least cmake and Qt. Unless Qt itself does not use that pragma, let's not risk to screw over people who try to reuse ECM for some non-mainstream setup, unless we

D5866: ecm_qt_declare_logging_category(): more unique include guard for header

kossebau added a comment. Yes, `#pragma once` might be the nicer solution here. I stayed away from proposing it though, as for one it is not a real standard by specifications and also by KDE coding traditions. And I would not like to be the one adding (and thus being responsible) the

D5867: Add or improve "Generated. Don't edit" messages and make consistent

kossebau created this revision. Restricted Application added projects: Frameworks, Build System. REPOSITORY R240 Extra CMake Modules BRANCH improvegeneratednote REVISION DETAIL https://phabricator.kde.org/D5867 AFFECTED FILES modules/ECMQmLoader.cpp.in

D6279: API dox: add notes to KActionCollection about QAction ownership handling

This revision was automatically updated to reflect the committed changes. kossebau marked 2 inline comments as done. Closed by commit R263:951bc8a9b3c9: API dox: add notes to KActionCollection about QAction ownership handling (authored by kossebau). CHANGED PRIOR TO COMMIT

D6338: DOXYGEN_PREPROC -> DOXYGEN_SHOULD_SKIP_THIS, to standardize within KF5

kossebau added a comment. See current output of kapidox, which has no clue about `DOXYGEN_PREPROC`: https://api.kde.org/frameworks/ki18n/html/klocalizedstring_8h.html ((sadly doxygen has no proper support for global methods, only documents them as part of the file documentation, but

D6339: Remove custom doxygen config files

kossebau added a comment. For some background, files had been added in https://cgit.kde.org/kdelibs.git/commit/staging/ki18n/?h=frameworks=67a945a51440a67e40cf7d0dbde93c5ecc5118c2 REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D6339 To: kossebau, #frameworks, ilic

D6338: DOXYGEN_PREPROC -> DOXYGEN_SHOULD_SKIP_THIS, to standardize within KF5

kossebau created this revision. Restricted Application added a project: Frameworks. REVISION SUMMARY The other KF5 modules use DOXYGEN_SHOULD_SKIP_THIS, picking up the example from the doxygen documentation. So for consistency and current expectations of kapidox (and built-in support of

D6339: Remove custom doxygen config files

kossebau created this revision. Restricted Application added a project: Frameworks. REVISION SUMMARY Are not integrated wih kapidox or ECMAddQch, and the other KF5 modules do not have such files. For custom generation of API dox instead the QCH generation can be used, by the target

D6249: FindQHelpGenerator: avoid picking up Qt4 version

kossebau added a comment. @palimaka You have KDE push rights, correct? Will you have time this week to push this, or do you want someone/me to do that for you? Would be good to have this in as soon as possible, given tagging release is <2 weeks away :) REPOSITORY R240 Extra CMake

D6249: FindQHelpGenerator: avoid picking up Qt4 version

This revision was automatically updated to reflect the committed changes. Closed by commit R240:a13f1dcd2e7b: FindQHelpGenerator: avoid picking up Qt4 version (authored by palimaka, committed by kossebau). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE

D6249: FindQHelpGenerator: avoid picking up Qt4 version

kossebau added a comment. So pushing now myself, so this todo can be checked off :) REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D6249 To: palimaka, #frameworks, kossebau, kfunk Cc: alexeymin, asturmlechner, #build_system

D6394: Add KF6-TODO to make KComboBox::minimumSizeHint() public

kossebau added inline comments. INLINE COMMENTS > apol wrote in kcombobox.h:527 > Why KF6? changing visibility doesn't break ABI, AFAIK. We should just not > reorder them. https://community.kde.org/Policies/Binary_Compatibility_Issues_With_C%2B%2B hints the access rights are mangled into the

D6394: Add KF6-TODO to make KComboBox::minimumSizeHint() public

kossebau created this revision. Restricted Application added a project: Frameworks. REPOSITORY R284 KCompletion BRANCH addkf5todo REVISION DETAIL https://phabricator.kde.org/D6394 AFFECTED FILES src/kcombobox.h To: kossebau, #frameworks

D6279: API dox: add notes to KActionCollection about QAction ownership handling

kossebau created this revision. Restricted Application added a project: Frameworks. REPOSITORY R263 KXmlGui BRANCH apidoxQActionOwnership REVISION DETAIL https://phabricator.kde.org/D6279 AFFECTED FILES src/kactioncollection.h To: kossebau, #frameworks, dfaure

D6279: API dox: add notes to KActionCollection about QAction ownership handling

kossebau updated this revision to Diff 15611. kossebau added a comment. note auto-removal on destroying the action REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6279?vs=15594=15611 BRANCH apidoxQActionOwnership REVISION DETAIL

D6394: Add KF6-TODO to make KComboBox::minimumSizeHint() public

This revision was automatically updated to reflect the committed changes. Closed by commit R284:1910d3ac9b1e: Add KF6-TODO to make KComboBox::minimumSizeHint() public (authored by kossebau). REPOSITORY R284 KCompletion CHANGES SINCE LAST UPDATE

D2854: New: ECMAddQch, for generating qch & doxygen tag files

kossebau updated this revision to Diff 14671. kossebau added a comment. Restricted Application added projects: Frameworks, Build System. Some minor improvements, prepare for release with 5.36 REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE

D3438: Create a QCH file with the API dox, optionally, using ECMAddQCH

kossebau updated this revision to Diff 14667. kossebau added a comment. Restricted Application added a project: Frameworks. Update to latest ECMAddQch REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3438?vs=8791=14667 BRANCH addQCHBuild REVISION

D3458: Create a QCH file with the API dox, optionally, using ECMAddQCH

kossebau updated this revision to Diff 14668. kossebau added a comment. Restricted Application added a project: Frameworks. Update to latest ECMAddQch REPOSITORY R243 KArchive CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3458?vs=8789=14668 BRANCH addQCHBuild REVISION DETAIL

D3439: Create a QCH file with the API dox, optionally, using ECMAddQCH

kossebau updated this revision to Diff 14669. kossebau added a comment. Restricted Application added a project: Frameworks. Update to latest ECMAddQch REPOSITORY R288 KJobWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3439?vs=8792=14669 BRANCH addQCHBuild REVISION

D3609: Create a QCH file with the API dox, optionally, using ECMAddQch

kossebau updated this revision to Diff 14670. kossebau added a comment. Restricted Application added a project: Frameworks. Update to latest ECMAddQch REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3609?vs=8818=14670 BRANCH addQCHBuild

D2854: New: ECMAddQch, for generating qch & doxygen tag files

kossebau updated this revision to Diff 14672. kossebau added a comment. fix lett old "since 5.30" REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2854?vs=14671=14672 BRANCH addApiDox REVISION DETAIL https://phabricator.kde.org/D2854

D2854: New: ECMAddQch, for generating qch & doxygen tag files

kossebau added a comment. If there are no further comments or other feedback, I would like to commit this once 5.35 is tagged. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D2854 To: kossebau, #frameworks, #build_system, staniek Cc: shumski, kfunk,

D5866: ecm_qt_declare_logging_category(): more unique include guard for header

This revision was automatically updated to reflect the committed changes. Closed by commit R240:a959e34971f9: ecm_qt_declare_logging_category(): more unique include guard for header (authored by kossebau). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE

D5866: ecm_qt_declare_logging_category(): more unique include guard for header

kossebau added a comment. If noone objects or has further comments, will commit this Wednesday, 24th. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D5866 To: kossebau, #frameworks, #build_system Cc: elvisangelaccio

D5914: Add template for Plasma QML Applet with QML extension

kossebau created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY Should help people to kick-off plasmoids which also use custom QML classes. TEST PLAN Created new plasmoid from

D5914: Add template for Plasma QML Applet with QML extension

kossebau added a comment. Get created template bundle here: https://share.kde.org/index.php/s/eHJGEku7pw7DotV REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D5914 To: kossebau, #plasma Cc: plasma-devel, #frameworks, ZrenBot, spstarr, progwolff,

D2854: New: ECMAddQch, for generating qch & doxygen tag files

kossebau edited the summary of this revision. kossebau edited the test plan for this revision. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D2854 To: kossebau, #frameworks, #build_system, staniek Cc: shumski, kfunk, staniek, winterz, ochurlaud, #kdevelop

D5867: Add or improve "Generated. Don't edit" messages and make consistent

This revision was automatically updated to reflect the committed changes. Closed by commit R240:b58820c4af64: Add or improve "Generated. Don't edit" messages and make consistent (authored by kossebau). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE

D6053: Use explicit flag values or explicit constructor instead of nullptr

kossebau created this revision. Restricted Application added a project: Frameworks. REVISION SUMMARY The constructor of QFlags which was intended to handle literal "0" as commonly used indicator of no-flags-set has been done with a trick based on pointer types. Which these days of nullptr

D6054: Use explicit flag values or explicit constructor instead of nullptr

kossebau created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY The constructor of QFlags which was intended to handle literal "0" as commonly used indicator of no-flags-set has

D3458: Create a QCH file with the API dox, optionally, using ECMAddQCH

This revision was automatically updated to reflect the committed changes. kossebau marked an inline comment as done. Closed by commit R243:42292d5214c6: [FEATURE] Option to build & install QCH file with the public API dox (authored by kossebau). CHANGED PRIOR TO COMMIT

D3438: Create a QCH file with the API dox, optionally, using ECMAddQCH

This revision was automatically updated to reflect the committed changes. Closed by commit R244:f1ccb8877e78: [FEATURE] Option to build & install QCH file with the public API dox (authored by kossebau). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D3438?vs=14667=15152#toc REPOSITORY

D3609: Create a QCH file with the API dox, optionally, using ECMAddQch

This revision was automatically updated to reflect the committed changes. Closed by commit R216:6891e5a13848: [FEATURE] Option to build & install QCH file with the public API dox (authored by kossebau). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D3609?vs=14670=15153#toc REPOSITORY

D3439: Create a QCH file with the API dox, optionally, using ECMAddQCH

This revision was automatically updated to reflect the committed changes. Closed by commit R288:66510d55dbe0: [FEATURE] Option to build & install QCH file with the public API dox (authored by kossebau). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D3439?vs=14669=15154#toc REPOSITORY

D3458: Create a QCH file with the API dox, optionally, using ECMAddQCH

kossebau added inline comments. INLINE COMMENTS > dfaure wrote in CMakeLists.txt:55 > slightly cryptic for someone who wouldn't know what QCH is. You could add > (for opening in Qt Assistant) or something similar? > > Then again these days people don't know what Assistant is, they use the >

D6053: Use explicit flag values or explicit constructor instead of nullptr

kossebau added inline comments. INLINE COMMENTS > cfeck wrote in kfontrequester.cpp:187 > Does removing the default value mean the flags would be now uninitialized? No, the constructor called would be (as before) `QFlags::QFlags(Zero zero = Q_NULLPTR)`, so still default to 0 internally, so

D6054: Use explicit flag values or explicit constructor instead of nullptr

kossebau added a comment. Checking the diff another time I find it would be even nicer to extend `NET::Property`, `NET::Property2`, `NET::Action` & Co. to have an entry for `0` value, named `NoProperties`, `NoProperties2`, `NoActionFlags` etc. (cmp. e.g. `Qt::ItemFlags`), so those enum

D6053: Use explicit flag values or explicit constructor instead of nullptr

This revision was automatically updated to reflect the committed changes. Closed by commit R236:ff2e1d8e22fe: Use explicit flag values or explicit constructor instead of nullptr (authored by kossebau). REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE

D6054: Use explicit flag values or explicit constructor instead of nullptr

This revision was automatically updated to reflect the committed changes. Closed by commit R278:ccbad906db1b: Use explicit flag values or explicit constructor instead of nullptr (authored by kossebau). REPOSITORY R278 KWindowSystem CHANGES SINCE LAST UPDATE

RFC: Packaging of KF5 API dox QCH files and their devel helper files

Hi packagers, (cc: to kde-frameworks-devel only for heads-up) with ECM/KF5 5.35.0 now snapshot and being prepared for release, a new feature has already been pushed to the master branches of ECM and almost all the non- deprecated KF5 modules, which might need some more fine-tuning in the few

D2854: New: ECMAddQch, for generating qch & doxygen tag files

This revision was automatically updated to reflect the committed changes. Closed by commit R240:c837f58d505b: New: ECMAddQch, for generating qch & doxygen tag files (authored by kossebau). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D2854?vs=14672=15148#toc REPOSITORY R240 Extra

D6249: FindQHelpGenerator: avoid picking up Qt4 version

kossebau requested changes to this revision. kossebau added a comment. This revision now requires changes to proceed. Thanks for the fix. Sadly this fails on my openSUSE TW system with system Qt5 packages, where _path is /usr/lib64/qt5/bin, and while that dir has both qhelpgenerator-qt5 and

D6249: FindQHelpGenerator: avoid picking up Qt4 version

kossebau accepted this revision. kossebau added a comment. This revision is now accepted and ready to land. Ah, PEBKAC, I only added NO_DEFAULT_PATH to the code when manually applying the patch. Fixing also PATH->PATHS improved things, and the executable now is found in ${_path}. No

D5455: Extend Programmer's Guide with notes about influence of setlocale()

kossebau updated this revision to Diff 14158. kossebau added a comment. rework text follwing feedback REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5455?vs=13447=14158 BRANCH addNoteAboutGettextLocaleIssuse REVISION DETAIL

D5455: Extend Programmer's Guide with notes about influence of setlocale()

kossebau added a comment. @ilic Thanks for the comments, agreed. Actually the initial text had some "really?" across it, as I was surprised about the findings stated in there and wanted (your) confirmation. So made this info bit a subsection of the "Writing Messages" part, and changed it

D5455: Extend Programmer's Guide with notes about influence of setlocale()

kossebau added a comment. BTW, the `` and `\ref x` seems not to work (only reused that for consistency), will do a separate patch later which follows instructions from http://doxygen.10944.n7.nabble.com/Creating-links-in-and-between-Markdown-files-pages-td6689.html REPOSITORY R249 KI18n

D5455: Extend Programmer's Guide with notes about influence of setlocale()

kossebau added a comment. In https://phabricator.kde.org/D5455#107095, @kossebau wrote: > BTW, the `` and `\ref x` seems not to work (only reused that for consistency), will do a separate patch later which follows instructions from

D5455: Extend Programmer's Guide with notes about influence of setlocale()

This revision was automatically updated to reflect the committed changes. Closed by commit R249:db45cf7242d7: Extend Programmer's Guide with notes about influence of setlocale() (authored by kossebau). REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE

D5914: Add template for Plasma QML Applet with QML extension

This revision was automatically updated to reflect the committed changes. Closed by commit R242:4d5793c28a3f: Add template for Plasma QML Applet with QML extension (authored by kossebau). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D5914?vs=14681=14687#toc REPOSITORY R242 Plasma

D7580: Support loading by stream and restoring state on reload

This revision was automatically updated to reflect the committed changes. Closed by commit R383:d1ee5a0e3908: Support loading by stream and restoring state on reload (authored by kossebau). REPOSITORY R383 SVGPart CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7580?vs=19446=19814

D7580: Support loading by stream and restoring state on reload

kossebau added a comment. Thanks for quick reaction :) Will push now, even if we discovered another item which needs some more clarification. Would do a follow-up fix then if we find one is needed, INLINE COMMENTS > dfaure wrote in svgpart.cpp:191 > When I reload in konqueror (with KHTML

D7580: Support loading by stream and restoring state on reload

kossebau edited the summary of this revision. kossebau edited the test plan for this revision. REPOSITORY R383 SVGPart BRANCH supportstreamandreload REVISION DETAIL https://phabricator.kde.org/D7580 To: kossebau, #frameworks, dfaure

D7580: Support loading by stream and restoring state on reload

kossebau added a comment. In https://phabricator.kde.org/D7580#145144, @kossebau wrote: > With the latest update then this patch would represent the blue-print for KParts plugins as I see it when it comes to supporting both state restoring and support for streams, at least for what is

D3977: Fix memleak in KDynamicJobTracker, KWidgetJobTracker needs QApplication

kossebau added a comment. In https://phabricator.kde.org/D3977#155721, @elvisangelaccio wrote: > @kossebau > After this change we get the > > Tried to unregister a kio job that hasn't been registered. > > warning with a `KCompositeJob` in Ark (batchextract.cpp). >

D3977: Fix memleak in KDynamicJobTracker, KWidgetJobTracker needs QApplication

kossebau added a comment. In https://phabricator.kde.org/D3977#155973, @elvisangelaccio wrote: > From what I can see, after this change any job registered with > > KIO::getJobTracker()->registerJob(job); > > > no longer needs to be manually unregistered with > >

Re: Running applications and unittests without "make install"

Hi Ben & all, Am Samstag, 19. August 2017, 02:24:21 CEST schrieb Ben Cooksley: > On Wed, Aug 16, 2017 at 3:17 AM, David Faure wrote: > > Hi everyone, > > Hi David, > > > The documentation for how to do that is now up at > > > >

D7580: Support loading by stream and restoring state on reload

kossebau updated this revision to Diff 19446. kossebau added a comment. add support for state restoring via BrowserExtension REPOSITORY R383 SVGPart CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7580?vs=19091=19446 BRANCH supportstreamandreload REVISION DETAIL

D7580: Support loading by stream and restoring state on reload

kossebau added a comment. In https://phabricator.kde.org/D7580#144557, @dfaure wrote: > In https://phabricator.kde.org/D7580#144518, @kossebau wrote: > > > When I read this initially, I guessed this method is just about the view state. But is also bound to data-pulling by the kpart,

D7580: Support loading by stream and restoring state on reload

kossebau created this revision. REVISION SUMMARY The KTextEditor preview plugin* repeatedly feeds new versions to the same kpart instance, to allow instant preview of changes. To avoid stressing of the filesystem the stream API of the kpart is used if available.

D7580: Support loading by stream and restoring state on reload

kossebau updated this revision to Diff 19091. kossebau added a comment. handle repeated closeUrl call REPOSITORY R383 SVGPart CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7580?vs=18868=19091 BRANCH supportstreamandreload REVISION DETAIL https://phabricator.kde.org/D7580

D7580: Support loading by stream and restoring state on reload

kossebau added a comment. > As I see it, it's *either* openUrl/closeUrl *or* openStream/writeStream/closeStream. Hm, when I before did a quick search for how to use the stream API, I came across https://api.kde.org/frameworks/khtml/html/classKHTMLPart.html#details which made me

D7580: Support loading by stream and restoring state on reload

kossebau edited the summary of this revision. REPOSITORY R383 SVGPart REVISION DETAIL https://phabricator.kde.org/D7580 To: kossebau, #frameworks, dfaure

D7198: Set CMAKE_*_OUTPUT_DIRECTORY to run tests without installing.

kossebau reopened this revision. kossebau added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > KDECMakeSettings.cmake:46-47 > +# > +# When find_package(ECM 5.38) or higher is called, this also selects > +# a layout for the build dir that helps running

D8351: API dox: add note about calling setApplicationDomain after QApp creation

kossebau added a comment. Another option might be to split off a data structure where the application domain string is stored separately, and thus delay the initialization of the KLocalizedStringPrivateStatics instance to the first i18n call. Though given that the initialisation sets global

D8351: API dox: add note about calling setApplicationDomain after QApp creation

kossebau created this revision. kossebau added reviewers: Frameworks, ilic, ltoscano. Restricted Application added a project: Frameworks. REVISION SUMMARY The current implementation of KLocalizedString::setApplicationDomain() will trigger the creation of the KLocalizedStringPrivateStatics

D9012: Revert "Detach before setting the d pointer"

kossebau added a comment. In https://phabricator.kde.org/D9012#172387, @leinir wrote: > Quicker is better here, i think... Perhaps it is worth adding the documentation we discussed as well in this review? Thinking about making it easier to track the history and whatnot of what happened

D9012: Revert "Detach before setting the d pointer"

This revision was automatically updated to reflect the committed changes. Closed by commit R304:bcb7dd628811: Revert Detach before setting the d pointer (authored by kossebau). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9012?vs=22979=23055 REVISION

D9012: Revert "Detach before setting the d pointer"

kossebau created this revision. kossebau added reviewers: whiting, leinir, apol. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY This reverts commits

D9012: Revert "Detach before setting the d pointer"

kossebau added a comment. See also discussion at https://phabricator.kde.org/D7194#159565 ff. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D9012 To: kossebau, whiting, leinir, apol Cc: #frameworks

D8336: Improve apidox of KJobTrackerInterface

kossebau added inline comments. INLINE COMMENTS > elvisangelaccio wrote in kjobtrackerinterface.h:73 > Probably yes, should we add a TODO comment for KF6? And for the protected, not sure, it feels unbalanced to me. But something to think about at time of KF6, so yes, add a (non-doxygen)

D8336: Improve apidox of KJobTrackerInterface

kossebau accepted this revision. kossebau added a comment. This revision is now accepted and ready to land. (Sorry, forgot about this one, subscribed too to many diffs in the phabricator view) Looks good to me in general. Added some comments you might want to consider, but are free to

D8728: Install mimetype definitions for kcfg/kcfgc/ui.rc/knotify & qrc files

This revision was automatically updated to reflect the committed changes. Closed by commit R244:dbde1029b3b7: Install mimetype definitions for kcfg/kcfgc/ui.rc/knotify qrc files (authored by kossebau). REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE

D8728: Install mimetype definitions for kcfg/kcfgc/ui.rc/knotify & qrc files

kossebau updated this revision to Diff 22746. kossebau added a comment. - drop qrc mimetype proposal, qt types are to be dealt with upstream - x-vnd -> vnd REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8728?vs=22095=22746 BRANCH

D8728: Install mimetype definitions for kcfg/kcfgc/ui.rc/knotify & qrc files

kossebau added a comment. @dfaure thanks for review. Given these are kf5-specific mimetypes I am unsure whether to propose them also for inclusion in shared-mime-info. What do you think? I have been tempted to also add mimetypes for all the special scripty files (Messages.sh,

D8947: Expose KFilePlacesModel 'iconName' rule

kossebau added inline comments. INLINE COMMENTS > kfileplacesmodel.h:52 > +GroupRole = 0x0a5b64ee, > +// @since 5.41 > +IconNameRole = 0x00a45c00 +1 for adding `@since`. But needs three slashes`///` for doxygen to pick up this comment REPOSITORY R241 KIO REVISION

D9182: return nullptr -> return {} for QFlags

kossebau added a comment. Code change looks good to me. Think I missed that in my clean-up commits to @kfunk 's initial commit as I only compiled the library parts of KDE Frameworks, not the plugin modules. No maintainer of this module though, so just a +1 for now. Commit message

D8728: Install mimetype definitions for kcfg/kcfgc/ui.rc/knotify & qrc files

kossebau added a subscriber: ltoscano. kossebau added a comment. In https://phabricator.kde.org/D8728#174635, @dfaure wrote: > I agree that those are really KF5 specific and developer-oriented, so rather unlikely to be e.g. sent by email to other people. Okay, so for now not

<    1   2   3   4   5   6   7   8   9   10   >