D21632: Add edit-select-text, make 16px draw-text like 22px

2019-06-06 Thread Noah Davis
ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D21632 To: ndavis, #vdg Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21632: Add edit-select-text, make 16px draw-text like 22px

2019-06-06 Thread Noah Davis
ndavis added a dependent revision: D21633: Change Text Selection icon to edit-select-text. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D21632 To: ndavis, #vdg Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21632: Add edit-select-text, make 16px draw-text like 22px

2019-06-06 Thread Noah Davis
This revision was automatically updated to reflect the committed changes. Closed by commit R266:6227d63efa20: Add edit-select-text, make 16px draw-text like 22px (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21632?vs=59283&id=59287

D21656: Create a breeze icon for kfourinline

2019-06-08 Thread Noah Davis
ndavis added a comment. We don't normally do the gloss wave in Breeze. That's more of a Tango/Oxygen thing. How about adding some holes instead to make it look more like the real thing? https://www.gamesworld.com.au/wp-content/uploads/2015/10/cardinal-four-in-a-row.jpg Just some ideas:

D11880: Add firewalld icons

2018-09-19 Thread Noah Davis
ndavis added a comment. In D11880#328623 , @ngraham wrote: > Oops, it looks like this patch totally got missed, sorry! > > Not sure I like that `firewall-applet-error` is linked to `security-low`. To me, a firewall error should have some more

D11880: Add firewalld icons

2018-09-20 Thread Noah Davis
ndavis added a comment. https://developer.gnome.org/icon-naming-spec/ > | security-high | The icon used to indicate that the security level of a connection is known to be secure, using strong encryption and a valid certificate.

D11880: Add firewalld icons

2018-09-20 Thread Noah Davis
ndavis updated this revision to Diff 41971. ndavis added a comment. 1. Updating D11880 : Add firewall-config and firewall-applet icons # 2. Enter a brief description of the changes included in this update. 3. The first line is used as subject, next

D11880: Add firewall-config and firewall-applet icons

2018-09-20 Thread Noah Davis
ndavis retitled this revision from "Add firewalld icons" to "Add firewall-config and firewall-applet icons". REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D11880 To: ndavis, #vdg, #breeze, ngraham Cc: kde-frameworks-devel, ngraham, michaelh, bruns

D11880: Add firewall-config and firewall-applet icons

2018-09-20 Thread Noah Davis
ndavis updated this revision to Diff 41972. ndavis added a comment. 1. Updating D11880 : Add firewall-config and firewall-applet icons # 2. Enter a brief description of the changes included in this update. 3. The first line is used as subject, next

D11880: Add firewall-config and firewall-applet icons

2018-09-20 Thread Noah Davis
ndavis added a comment. Hmm. Something is preventing me from changing the name of firewall-applet to firewall-applet-panic (apps/22) and vice versa. I own all of the files in that directory (noah:users), but the file names keep being reset to their current state. REPOSITORY R266 Breeze Ic

D11880: Add firewall-config and firewall-applet icons

2018-09-20 Thread Noah Davis
ndavis updated this revision to Diff 41973. ndavis added a comment. Fix mixed up firewall-applet and firewall-applet-panic (22px) REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11880?vs=41972&id=41973 BRANCH firewalld-icons (branched from master) R

D11880: Add firewall-config and firewall-applet icons

2018-09-20 Thread Noah Davis
ndavis added a comment. Regular F6275107: Screenshot_20180920_052849.png Panic F6275109: Screenshot_20180920_053034.png Not sure if I want to try to cause an error on my own system just to show how the erro

D11880: Add firewall-config and firewall-applet icons

2018-09-21 Thread Noah Davis
ndavis added a comment. I think I'm confused about the process here. Are we using @bruns's icons now? In D11880#329896 , @bruns wrote: > F6277682: out.png > > How about these - error, "trusted zone",

D11880: Add firewall-config and firewall-applet icons

2018-09-21 Thread Noah Davis
ndavis added a comment. Here are some new styles based on suggestions and @bruns's ideas. I've also tried to make one of the new styles looks similar to the status/*/state-* icons. 16px F6278474: Screenshot_20180921_230725.png 22px F6278475

D11880: Add firewall-config and firewall-applet icons

2018-09-21 Thread Noah Davis
ndavis added a comment. In D11880#329995 , @bruns wrote: > If you use "{xxx, size=full}", you can avoid the scaling (preferable for small inline images). Fixed. Thanks! REPOSITORY R266 Breeze Icons BRANCH firewalld-icons (branched f

D11880: Add firewall-config and firewall-applet icons

2018-09-21 Thread Noah Davis
ndavis updated this revision to Diff 42119. ndavis added a comment. Change to bruns/state-* hybrid style REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11880?vs=41973&id=42119 BRANCH firewalld-icons (branched from master) REVISION DETAIL https://

D11880: Add firewall-config and firewall-applet icons

2018-09-23 Thread Noah Davis
ndavis added a comment. In D11880#330788 , @ngraham wrote: > I like `firewall-config` and `firewall-applet-error` as they are. > > I think that `firewall-applet` looks maybe a bit too plain at its 22px size. The wall seems to need something.

D11880: Add firewall-config and firewall-applet icons

2018-09-23 Thread Noah Davis
ndavis added a comment. Here's how the checkmark idea looks. I prefer the plain wall since it fits in with the other icons better. 16px F6281345: firewall-applet(check)16.svg 22px F6281342: firewall-applet(check)22.svg

D11880: Add firewall-config and firewall-applet icons

2018-09-23 Thread Noah Davis
ndavis added a comment. In D11880#330861 , @ngraham wrote: > For the panic mode icon, how about leaving the wall itself black, and only the lock is orange? Like this? This is #4d4d4d (icon grey), the standard color for small breeze icons

D11880: Add firewall-config and firewall-applet icons

2018-09-23 Thread Noah Davis
ndavis updated this revision to Diff 42212. ndavis added a comment. Change wall color of firewall-applet-panic to \#4d4d4d (breeze) and \#f2f2f2 (breeze-dark) REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11880?vs=42119&id=42212 BRANCH firewalld-i

D15721: Make lock on plasmavault icon visible with breeze-dark

2018-09-23 Thread Noah Davis
ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY Set lock color on Breeze version to #eff0f1 (light2dark script compatibility) and the lock

D15721: Make lock on plasmavault icon visible with breeze-dark

2018-09-23 Thread Noah Davis
ndavis added a comment. 16px F6281723: Screenshot_20180924_005740.png 22px F6281721: Screenshot_20180924_005657.png REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D15721 To:

D11880: Add firewall-config and firewall-applet icons

2018-09-24 Thread Noah Davis
ndavis added a comment. In D11880#330909 , @svenmauch wrote: > In D11880#330788 , @ngraham wrote: > > > I think that `firewall-applet` looks maybe a bit too plain at its 22px size. The wall seems t

D11880: Add firewall-config and firewall-applet icons

2018-09-24 Thread Noah Davis
ndavis updated this revision to Diff 42257. ndavis added a comment. Remove 48px firewall-applet icon REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11880?vs=42212&id=42257 BRANCH firewalld-icons (branched from master) REVISION DETAIL https://phab

D11880: Add firewall-config and firewall-applet icons

2018-09-24 Thread Noah Davis
ndavis added a comment. In D11880#331450 , @ngraham wrote: > FWIW, I'm okay with the existing `firewall-applet`. So here's what we've got now, as viewed with `cuttlefish`: > F6283724: Screenshot_20180924_215450.png

D15721: Make lock on plasmavault icon visible with breeze-dark

2018-09-25 Thread Noah Davis
ndavis added a comment. In D15721#331388 , @ngraham wrote: > Can you provide steps to reproduce the problem so I can test it? In my naive testing, the `plasmavault` icon looks like a lock and shows up fine on both Breeze Light and Breeze Dark.

D15721: Make lock on plasmavault icon visible with breeze-dark

2018-09-25 Thread Noah Davis
ndavis added a comment. In D15721#331723 , @ngraham wrote: > FYI, this earned a place in next week's Usability & Productivity report . :) Thanks, I really like that se

D11880: Add firewall-config and firewall-applet icons

2018-09-26 Thread Noah Davis
ndavis added a comment. I'm down to add a shields-up state icon. REPOSITORY R266 Breeze Icons BRANCH firewalld-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D11880 To: ndavis, #vdg, #breeze, ngraham Cc: bruns, abetts, alex-l, svenmauch, kde-frameworks-devel,

D11880: Add firewall-config and firewall-applet icons

2018-09-26 Thread Noah Davis
ndavis added a comment. How about this? F6286776: firewall-applet-shields_up.png REPOSITORY R266 Breeze Icons BRANCH firewalld-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D11880 To: ndavis, #vdg, #breeze, ngraham Cc:

D11880: Add firewall-config and firewall-applet icons

2018-09-26 Thread Noah Davis
ndavis added a comment. In D11880#332406 , @bruns wrote: > Looks good - can you provide an overview png of the complete firewall-applet icon set? I.e. the (now four) status icons and the config icon? F6286904: firewall_icons.png

D11880: Add firewall-config and firewall-applet icons

2018-09-26 Thread Noah Davis
ndavis updated this revision to Diff 42390. ndavis added a comment. Add firewall-applet-shields_up icon REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11880?vs=42257&id=42390 BRANCH firewalld-icons (branched from master) REVISION DETAIL https://p

D15853: Change drive-harddisk to more adaptable style

2018-09-30 Thread Noah Davis
ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY T9740 The old 16 and 22 px drive-harddisk icons did

D15853: Change drive-harddisk to more adaptable style

2018-09-30 Thread Noah Davis
ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D15853 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15853: Change drive-harddisk to more adaptable style

2018-09-30 Thread Noah Davis
ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D15853 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15853: Change drive-harddisk to more adaptable style

2018-09-30 Thread Noah Davis
ndavis edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D15853 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15853: Change drive-harddisk to more adaptable style

2018-09-30 Thread Noah Davis
ndavis edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D15853 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15853: Change drive-harddisk to more adaptable style

2018-09-30 Thread Noah Davis
ndavis added a comment. I only added 16, 22 and 64 px icons in the current revision, but I also have a 32px version. Is there a reason that there are only 16, 22 and 64 px versions for all device icons? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D15853 To:

D15853: Change drive-harddisk to more adaptable style

2018-09-30 Thread Noah Davis
ndavis added a comment. In D15853#334415 , @pstefan wrote: > In the monochrome icons (size 16px and 22px) you forgot to add the stylesheet. Without it, the monochrome icons won't be able to adapt to a changing color scheme. > You will have t

D15853: Change drive-harddisk to more adaptable style

2018-09-30 Thread Noah Davis
ndavis updated this revision to Diff 42621. ndavis added a comment. Fix stylesheet REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15853?vs=42591&id=42621 BRANCH new-harddisk-icons (branched from master) REVISION DETAIL https://phabricator.kde.org

D15853: Change drive-harddisk to more adaptable style

2018-09-30 Thread Noah Davis
ndavis added a comment. In D15853#334455 , @ngraham wrote: > In D15853#334425 , @ndavis wrote: > > > Ouch, I was not aware of this. All of the other monochrome icons I made that have been committed t

D15866: Reduce emblem size for very small icons to prevent obscuring too much of the icon

2018-09-30 Thread Noah Davis
ndavis added a comment. The emblem for the 16px version is too small to read. What if instead of the emblem being on top of the icon, it was off to the side? Then it wouldn't matter what size the emblem is as long as it looks good where it is. REPOSITORY R302 KIconThemes REVISION DETAIL

D15866: Reduce emblem size for very small icons to prevent obscuring too much of the icon

2018-10-01 Thread Noah Davis
ndavis added a comment. In D15866#334846 , @ngraham wrote: > You mean like this? > > [Icon] [emblem] Label > Yes, like that. REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D15866 To: ngraham, #framew

D15891: Fix monochrome icons missing stylesheets

2018-10-01 Thread Noah Davis
ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY Some icons were lacking compatibility with system color schemes and that was fixed. Nothing

D15934: Add battery and bluetooth icons for other DE compatibility

2018-10-03 Thread Noah Davis
ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY Add 16 and 22 px battery and bluetooth icons with names that should be compatible with othe

D15934: Add battery and bluetooth icons for other DE compatibility

2018-10-03 Thread Noah Davis
ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D15934 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15934: Add battery and bluetooth icons for other DE compatibility

2018-10-03 Thread Noah Davis
ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D15934 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15934: Add battery and bluetooth icons for other DE compatibility

2018-10-03 Thread Noah Davis
ndavis updated this revision to Diff 42829. ndavis added a comment. Change standard name breeze-dark battery icons to symlinks REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15934?vs=42828&id=42829 BRANCH other-desktop-compatibility (branched from m

D15934: Add battery and bluetooth icons for other DE compatibility

2018-10-04 Thread Noah Davis
ndavis added a comment. In D15934#336261 , @ngraham wrote: > How can I test this? Or even, how did you test this? I tested it by comparing the icons and names with Adwaita and Papirus, then asking an Xfce user to see if the icons worked f

D15934: Add battery and bluetooth icons for other DE compatibility

2018-10-04 Thread Noah Davis
ndavis added a comment. In D15934#336349 , @broulik wrote: > For Bluetooth we currently use: > > - disabled: grayed out/softened icon > - active: black icon > - paired: black icon with dots next to each other That "padlock" doesn't commun

D15934: Add battery and bluetooth icons for other DE compatibility

2018-10-04 Thread Noah Davis
ndavis updated this revision to Diff 42846. ndavis added a comment. Add symbolic links REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15934?vs=42829&id=42846 BRANCH other-desktop-compatibility (branched from master) REVISION DETAIL https://phabri

D15934: Add battery and bluetooth icons for other DE compatibility

2018-10-04 Thread Noah Davis
ndavis added a comment. In D15934#336409 , @broulik wrote: > > It is actual part of the Breeze Plasma theme though: > > Interesting. I have never seen it used, though. Then the Bluetooth applet (and likely Network manager applet) need to be f

D11880: Add firewall-config and firewall-applet icons

2018-10-07 Thread Noah Davis
ndavis added a comment. In D11880#337514 , @dfaure wrote: > This commit breaks the unittest "scalabletest" : > > FAIL! : ScalableTest::test_scalable(icons:Applications) The following icons are not available in a scalable directory: > >

D15934: Add battery and bluetooth icons for other DE compatibility

2018-10-08 Thread Noah Davis
ndavis added a comment. @ngraham @broulik Do you have any objections or questions about this commit? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D15934 To: ndavis, #vdg Cc: broulik, ngraham, kde-frameworks-devel, michaelh, bruns

D15934: Add battery and bluetooth icons for other DE compatibility

2018-10-08 Thread Noah Davis
ndavis added a comment. In D15934#339276 , @ngraham wrote: > I have no objection to the concept, but I like to test patches before I approve them, and I'm still not sure how I would satisfactorily test this without taking up an afternoon setting

D16421: Improve emblem contrast, legibility and consistency

2018-10-24 Thread Noah Davis
ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY Added outlines to 16 and 22 px icons Improved the legibility of 8px icons Added new 8, 1

D16421: Improve emblem contrast, legibility and consistency

2018-10-24 Thread Noah Davis
ndavis edited the summary of this revision. ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16421 To: ndavis, #vdg Cc: kde-frameworks-devel, #vdg, michaelh, ngraham, bruns

D16421: Improve emblem contrast, legibility and consistency

2018-10-24 Thread Noah Davis
ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16421 To: ndavis, #vdg Cc: kde-frameworks-devel, #vdg, michaelh, ngraham, bruns

D16421: Improve emblem contrast, legibility and consistency

2018-10-24 Thread Noah Davis
ndavis added a comment. In D16421#348347 , @ngraham wrote: > Wow, these are truly excellent. I think you've done an amazing job! Thanks! > One thing I'd like to discuss is whether or not we want the `emblem-remove` icon to be red. Th

D16421: Improve emblem contrast, legibility and consistency

2018-10-24 Thread Noah Davis
ndavis edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16421 To: ndavis, #vdg Cc: ngraham, bcooksley, kde-frameworks-devel, #vdg, michaelh, bruns

D16421: Improve emblem contrast, legibility and consistency

2018-10-24 Thread Noah Davis
ndavis added a comment. In D16421#348363 , @ngraham wrote: > Yeah I understand. I'm not the hugest fan of the orange either, and now that I think about it, semantically it's not really accurate either since that color is for warning or unusual s

D16421: Improve emblem contrast, legibility and consistency

2018-10-25 Thread Noah Davis
ndavis updated this revision to Diff 44201. ndavis added a comment. Change emblem-remove color to Plasma Blue, Change style of emblem-symbolic-link REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16421?vs=44194&id=44201 BRANCH emblem-outlines (branc

D16421: Improve emblem contrast, legibility and consistency

2018-10-25 Thread Noah Davis
ndavis added a comment. Here are what the changes look like: 8px symlink emblem, 16px emblem-remove: F6349477: Screenshot_20181025_041309.png Pretty crowded. 16px symlink emblem, 16px emblem-remove: F6349480: Screenshot_20181025_041224.png

D16421: Improve emblem contrast, legibility and consistency

2018-10-25 Thread Noah Davis
ndavis added a comment. In D16421#348487 , @bruns wrote: > Can you try the following: > > - Make the center link solid and narower (e.g. 2px height for the 16px one) > - Reduce the height of the right and left links Like this? F635

D16421: Improve emblem contrast, legibility and consistency

2018-10-25 Thread Noah Davis
ndavis added a comment. In D16421#348504 , @bruns wrote: > In D16421#348502 , @ndavis wrote: > > > In D16421#348487 , @bruns wrote: > > > > > Can you tr

D16421: Improve emblem contrast, legibility and consistency

2018-10-25 Thread Noah Davis
ndavis added a comment. In D16421#348506 , @ngraham wrote: > In D16421#348502 , @ndavis wrote: > > > F6350185: Screenshot_20181025_093827.png > > F6350193: S

D16421: Improve emblem contrast, legibility and consistency

2018-10-25 Thread Noah Davis
ndavis updated this revision to Diff 44210. ndavis added a comment. Change style of emblem-symbolic-link REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16421?vs=44201&id=44210 BRANCH emblem-outlines (branched from master) REVISION DETAIL https://

D16421: Improve emblem contrast, legibility and consistency

2018-10-25 Thread Noah Davis
ndavis added a comment. In D16421#348513 , @bruns wrote: > The center link looks slightly too heavy, but imho still better. Might be possible to shave off 1/2 pixel from the link top/bottom. As its a solid area, it should not make it too fuzzy.

D16421: Improve emblem contrast, legibility and consistency

2018-10-25 Thread Noah Davis
ndavis updated this revision to Diff 44211. ndavis added a comment. Change style of emblem-symbolic-link at 22px REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16421?vs=44210&id=44211 BRANCH emblem-outlines (branched from master) REVISION DETAIL

D16421: Improve emblem contrast, legibility and consistency

2018-10-25 Thread Noah Davis
ndavis added a comment. In D16421#348594 , @ngraham wrote: > Now that I stare at the summary graphics again, the white question mark looks a bit wispy and insubstantial at the 16px and 22px sizes. Do you agree? Other than that, everything looks

D16421: Improve emblem contrast, legibility and consistency

2018-10-25 Thread Noah Davis
ndavis added a comment. In D16421#348609 , @ngraham wrote: > JFYI, I dug through `KIconLoader` today and couldn't find anything that explicitly or implicitly trims the bounds of loaded images that could account for the link emblem not having its

D16421: Improve emblem contrast, legibility and consistency

2018-10-25 Thread Noah Davis
ndavis added a comment. In D16421#348702 , @ngraham wrote: > Does this problem still happen after you delete your icon cache? (`rm ~/.cache/icon-cache.kcache`) Yes. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kd

D16421: Improve emblem contrast, legibility and consistency

2018-10-25 Thread Noah Davis
ndavis updated this revision to Diff 44230. ndavis added a comment. Make emblem-question symbol thicker REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16421?vs=44211&id=44230 BRANCH emblem-outlines (branched from master) REVISION DETAIL https://p

D16421: Improve emblem contrast, legibility and consistency

2018-10-26 Thread Noah Davis
ndavis added a comment. In D16421#348825 , @bruns wrote: > In D16421#348664 , @ndavis wrote: > > > In D16421#348594 , @ngraham wrote: > > > > > Now that

D16421: Improve emblem contrast, legibility and consistency

2018-10-26 Thread Noah Davis
ndavis updated this revision to Diff 44248. ndavis added a comment. Widen the circular portion of 16/22 px emblem-question icons REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16421?vs=44230&id=44248 BRANCH emblem-outlines (branched from master) RE

D16421: Improve emblem contrast, legibility and consistency

2018-10-26 Thread Noah Davis
ndavis added a comment. Slight change to make the 16 and 22 px icons look more like the 8px icon: F6363210: Screenshot_20181026_072203.png REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16421 To: ndavis, #vdg Cc: bruns,

D16421: Improve emblem contrast, legibility and consistency

2018-10-26 Thread Noah Davis
ndavis added a comment. In D16421#348857 , @bruns wrote: > In D16421#348826 , @ndavis wrote: > > > I could, but then I'm running into this issue: T9898 > > > >

D16421: Improve emblem contrast, legibility and consistency

2018-10-26 Thread Noah Davis
ndavis added a comment. In D16421#348866 , @bruns wrote: > In D16421#348860 , @ndavis wrote: > > > The other issue with using a font based question mark is I also have to use that for the 8px icon if

D16421: Improve emblem contrast, legibility and consistency

2018-10-26 Thread Noah Davis
ndavis added a comment. In D16421#349075 , @bruns wrote: > @ndavis - can you upload the `git format-patch -1` output somewhere (temporary)? https://hastebin.com/egepiwurab.diff > There may also be a conceptual issue here - previously

D16421: Improve emblem contrast, legibility and consistency

2018-10-26 Thread Noah Davis
ndavis added a comment. Something just occurred to me: Why do we use emblems as if they were action buttons in Dolphin? Would it be so bad if Dolphin used `list-add` and `list-remove` instead of `emblem-added` and `emblem-remove`? REPOSITORY R266 Breeze Icons REVISION DETAIL https://pha

D16421: Improve emblem contrast, legibility and consistency

2018-10-26 Thread Noah Davis
ndavis added a comment. In D16421#349081 , @ngraham wrote: > This would all require some additional changes in Dolphin and Folder view, of course. So should I change `emblem-added` and `emblem-remove` back to their original colors? It wo

D16421: Improve emblem contrast, legibility and consistency

2018-10-26 Thread Noah Davis
ndavis added a comment. In D16421#349083 , @ngraham wrote: > In D16421#349082 , @ndavis wrote: > > > In D16421#349081 , @ngraham wrote: > > > > > This w

D16421: Improve emblem contrast, legibility and consistency

2018-10-27 Thread Noah Davis
ndavis updated this revision to Diff 44304. ndavis added a comment. Improve arrow visibility on vcs emblems Add emblem-encrypted-locked Change emblem-locked back to orange REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16421?vs=44248&id=44304 BRAN

D16421: Improve emblem contrast, legibility and consistency

2018-10-27 Thread Noah Davis
ndavis updated this revision to Diff 44308. ndavis added a comment. Add dark versions of previous change REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16421?vs=44304&id=44308 BRANCH emblem-outlines (branched from master) REVISION DETAIL https://

D16421: Improve emblem contrast, legibility and consistency

2018-10-27 Thread Noah Davis
ndavis updated this revision to Diff 44313. ndavis added a comment. Add 16 and 22 px versions of previous change REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16421?vs=44308&id=44313 BRANCH emblem-outlines (branched from master) REVISION DETAIL

D16421: Improve emblem contrast, legibility and consistency

2018-10-27 Thread Noah Davis
ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16421 To: ndavis, #vdg Cc: bruns, ngraham, bcooksley, kde-frameworks-devel, #vdg, michaelh

D16421: Improve emblem contrast, legibility and consistency

2018-10-27 Thread Noah Davis
ndavis added a comment. In D16421#349331 , @ngraham wrote: > Thanks for the updates. I know it's a PITA, but would you mind updating the image in the Summary section? Done. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabri

D16421: Improve emblem contrast, legibility and consistency

2018-10-27 Thread Noah Davis
ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16421 To: ndavis, #vdg Cc: bruns, ngraham, bcooksley, kde-frameworks-devel, #vdg, michaelh

D16421: Improve emblem contrast, legibility and consistency

2018-10-29 Thread Noah Davis
ndavis updated this revision to Diff 44410. ndavis added a comment. Add emblem-readonly REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16421?vs=44313&id=44410 BRANCH emblem-outlines (branched from master) REVISION DETAIL https://phabricator.kde.o

D16421: Improve emblem contrast, legibility and consistency

2018-10-29 Thread Noah Davis
ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16421 To: ndavis, #vdg Cc: bruns, ngraham, bcooksley, kde-frameworks-devel, #vdg, michaelh

D16514: Re-add monochrome link icon as action

2018-10-29 Thread Noah Davis
ndavis created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY Some action icons were symlinks to `emblem-symbolic-link`. When the new emblem style was applied to `emblem-symbolic-lin

D16514: Re-add monochrome link icon as action

2018-10-29 Thread Noah Davis
ndavis added reviewers: VDG, Breeze. ndavis added a subscriber: VDG. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16514 To: ndavis, #vdg, #breeze Cc: #vdg, kde-frameworks-devel, michaelh, ngraham, bruns

D16588: Change package manager icons to emblems

2018-11-01 Thread Noah Davis
ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY The old package-* icons were hard to read and straddled the line between being symbols f

D16588: Change package manager icons to emblems

2018-11-01 Thread Noah Davis
ndavis added a subscriber: VDG. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16588 To: ndavis, #vdg Cc: #vdg, kde-frameworks-devel, michaelh, ngraham, bruns

D16588: Change package manager icons to emblems

2018-11-01 Thread Noah Davis
ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16588 To: ndavis, #vdg Cc: #vdg, kde-frameworks-devel, michaelh, ngraham, bruns

D16588: Change package manager icons to emblems

2018-11-01 Thread Noah Davis
ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16588 To: ndavis, #vdg Cc: #vdg, kde-frameworks-devel, michaelh, ngraham, bruns

D16588: Change package manager icons to emblems

2018-11-01 Thread Noah Davis
ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16588 To: ndavis, #vdg Cc: #vdg, kde-frameworks-devel, michaelh, ngraham, bruns

D16588: Change package manager icons to emblems

2018-11-02 Thread Noah Davis
ndavis added a comment. In D16588#352554 , @ngraham wrote: > These are pretty darn good. They no longer have package-related iconography, but maybe that's okay and they never needed it in the first place. I can see how it would actually get in t

D16588: Change package manager icons to emblems

2018-11-02 Thread Noah Davis
ndavis updated this revision to Diff 44713. ndavis added a comment. Changed installed.svg symlink to target package-installed-updated.svg The original target was package-reinstall.svg I believe it was the way it was because: The original version of package-reinstall looked more l

D16588: Change package manager icons to emblems

2018-11-02 Thread Noah Davis
ndavis added a comment. In D16588#352847 , @valorie wrote: > Could not Muon be updated in this way as well? It now uses a package icon for all packages which seems a waste of space. Perhaps, and that would be great, but that would have to

D16588: Change package manager icons to emblems

2018-11-02 Thread Noah Davis
ndavis updated this revision to Diff 44736. ndavis added a comment. Removed broken symlink. It was already copied to the emblems/16 directory, but I forgot to remove the old copy. REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16588?vs=44713&id=44736

<    1   2   3   4   5   6   7   8   9   10   >