D17852: ViewInternal: Fix 'Go to matching bracket' in override mode

loh.tar created this revision. loh.tar added a reviewer: KTextEditor. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY BUG: 402594 REPOSITORY R39 KTextEditor REVISION DETAIL

D17730: [WIP] Review KateStatusBar

loh.tar updated this revision to Diff 48334. loh.tar edited the summary of this revision. loh.tar added a comment. - Change to new signal/slot style (Idea how to fix the two missing ones?) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17730?vs=48285=48334 REVISION DETAIL

D17857: DocumentPrivate: Don't scroll view when add auto-bracket at aned of file

loh.tar created this revision. loh.tar added a reviewer: KTextEditor. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY ...when 'Allow scrolling past the end of the document' is set

D12295: Supporting nested brackets for Kate autobrackets

loh.tar added a comment. His original post with some more text/hints/questions https://mail.kde.org/pipermail/kwrite-devel/2018-April/000345.html He got the advice from @brauch to post here. For me a little bit hard to follow, not only there but also here. I could apply this

D17730: [WIP] Review KateStatusBar (based on D17729)

loh.tar added a comment. > ..as soon as you split (and as the statusbar dictates the minimum size), you will get in trouble. My first thought was, "Oops, right!" But while I verifying this I notice that the status bar has the full width of the window, not only the split view.

D17730: Review KateStatusBar

loh.tar updated this revision to Diff 48387. loh.tar retitled this revision from "[WIP] Review KateStatusBar " to "Review KateStatusBar ". loh.tar edited the summary of this revision. loh.tar added a comment. - Remove seemingly unneeded spacing. Well, there is a change but tiny and perhaps

D17459: SearchBar: Add Cancel button to stop long running tasks

loh.tar added a comment. Do I have to revert this d-stuff? If so, some other tweak, or just as it was? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17459 To: loh.tar, #ktexteditor, #vdg, cullmann Cc: anthonyfieroni, brauch, cullmann, abetts, kwrite-devel,

D17857: DocumentPrivate: Don't scroll view when add auto-bracket at end of file

loh.tar added a comment. As always poor tested and only in "normal mode", not vi INLINE COMMENTS > katedocument.cpp:3073 > const auto insertedAt(view->cursorPosition()); > -view->setCursorPosition(cursorPos); >

D17857: DocumentPrivate: Don't scroll view when add auto-bracket at end of file

loh.tar added a comment. In D17857#383865 , @dhaumann wrote: > Is this related to bug https://bugs.kde.org/show_bug.cgi?id=306745 ? I don't think so. Here is it auto-bracket stuff, there general "is visible" stuff :-) (Yeah, my English

D17857: DocumentPrivate: Don't scroll view when add auto-bracket at end of file

loh.tar retitled this revision from "DocumentPrivate: Don't scroll view when add auto-bracket at aned of file" to "DocumentPrivate: Don't scroll view when add auto-bracket at end of file". loh.tar edited the test plan for this revision. REPOSITORY R39 KTextEditor REVISION DETAIL

D17459: SearchBar: Add Cancel button to stop long running tasks

loh.tar updated this revision to Diff 48391. loh.tar added a comment. - Revert d-stuff - Remove BCI stuff I'm still looking for a better name for "m_cancelFindOrReplace", suggestions? CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17459?vs=47966=48391 REVISION DETAIL

D17730: [WIP] Review KateStatusBar

loh.tar updated this revision to Diff 48374. loh.tar set the repository for this revision to R39 KTextEditor. loh.tar added a comment. - Fix remaining signal/slot, Thanks for the hint! :-) > Beside that, I tried the patch, the status bar looks nice ;=) :-) > I would have no

D17128: WIP DocumentPrivate: Remove all from next line which may annoying when joining lines

loh.tar updated this revision to Diff 48486. loh.tar retitled this revision from "DocumentPrivate: Remove comment mark when joining lines" to "WIP DocumentPrivate: Remove all from next line which may annoying when joining lines". loh.tar edited the summary of this revision. loh.tar added a

D17128: WIP DocumentPrivate: Remove all from next line which may annoying when joining lines

loh.tar added a comment. It's almost untested, will try to use it on daily basis. After think a little about it, I came to this variant. Code lines are unlikely to "join", so why test for comments? A little off topic: Would it OK to modify the wrap stuff that it behaves differently?

D17970: Fix broken Emmet

loh.tar added a comment. May I ask a stupid question? Is the entire function needed? That's looks to me somehow like image/picture stuff but I don't find picture stuff in the Tool->Emmet menu. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17970 To: loh.tar,

D17730: Review KateStatusBar

loh.tar added a comment. That can I not really imagine :-/ Wouldn't that not somehow to be notice in normal use? Let's try this. Shot without bar, Now choose "Show bar", The window didn't change. (Sorry, no tool at hand to paste pics together) The bar can shrink almost endless.

D12295: Supporting nested brackets for Kate autobrackets

loh.tar added a comment. I didn't test it even more but think on it from time to time. If my slightly negative comment was OK or too fast judged. And yes it may. On the other hand I ask me if the approach to track each key stroke and change the behavior on that record is right or a

D17999: ViewConfig: Add option to paste at cursor position by mouse

loh.tar added a comment. In D17999#387370 , @dhaumann wrote: > Hm, didn't you switch the meaning... I hope you mean @ngraham :-) I just typed overslept what he wrote...yes he has. Before I only kill that "mouse" I like to ask the native

D17693: DocumentPrivate: Treat angle bracket < and backtick ` also as "auto bracket" when we have a selection

loh.tar added a comment. > Will wait for further advice Still waiting if I have to undo these reference stuff. (Yes your are busy. Just only wanted it to emphasize) Besides, I like to add some more chars to this special handling: _ : # @ ~ * ! $ % / \ Some of these may

D17999: ViewConfig: Add option to paste at cursor position by mouse

loh.tar added a comment. Please provide also a tooltip/whats-this text, if useful. My QtDesigner did not show the needed widget stuff, so the text is not set. A look at that bug report may give more hints/ideas REPOSITORY R39 KTextEditor REVISION DETAIL

D17730: Review KateStatusBar

loh.tar updated this revision to Diff 48781. loh.tar added a comment. Allow StatusBarButton to shrink Ah! Strange! :-/ But somehow the more usual behavior, these "crunching" is unlikely. Couldn't find a hint where it is done in Kate, but after some digging around I have some solution

D17730: Review KateStatusBar

loh.tar added a comment. @zetazeta wrote > I find it annoying that the status bar imposes a limit on the minimum width of the window @dhaumann wrote > Maybe with this patch, the status bar grows and forces a different width me wrote > The bar can shrink almost endless

D17999: ViewConfig: Add option to paste at cursor position by mouse

loh.tar created this revision. loh.tar added a reviewer: KTextEditor. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY With this option is the cursor not moved to the mouse position

D17730: Review KateStatusBar

loh.tar updated this revision to Diff 48813. loh.tar edited the summary of this revision. loh.tar added a comment. - Remove not supported Rich Text from [BLOCK] hint - Add word count info to line label F6530066: pic.png CHANGES SINCE LAST UPDATE

D17310: Use a Kile Icon that is similar to the original

loh.tar added a comment. Yes looks nice. Would be good as icon for the Kile Handbook, for the application I would omit/avoid the "Notebook" look. REPOSITORY R266 Breeze Icons BRANCH improve-kile-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D17310 To:

D18164: Review KateGotoBar

loh.tar updated this revision to Diff 49636. loh.tar added a comment. - Fix typo of member vars - Add missing setView(m_view) - Remove FIXME hint about timer, however would a comment for me nice - Use QString() Things which could be improved or not - The up/down buttons are a

D17852: ViewInternal: Fix 'Go to matching bracket' in override mode

loh.tar updated this revision to Diff 49530. loh.tar added a comment. Add autotest CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17852?vs=48340=49530 REVISION DETAIL https://phabricator.kde.org/D17852 AFFECTED FILES autotests/src/kateview_test.cpp

D18125: KateStatusBar: Add dictionary button

loh.tar added a subscriber: cullmann. loh.tar added a comment. @cullmann @dhaumann A short not how to progress would be nice. - Keep codes as they are - Shorten codes as suggested - Replace codes by flags/ensign (no idea how) - Add (unneeded) label - Show (unneeded long) full name

D18164: Review KateGotoBar

loh.tar updated this revision to Diff 49653. loh.tar edited the summary of this revision. loh.tar set the repository for this revision to R39 KTextEditor. loh.tar added a comment. - Morph updateData() into a slot - connect to Document::textChanged signal REPOSITORY R39 KTextEditor

D18164: Review KateGotoBar

loh.tar updated this revision to Diff 49665. loh.tar added a comment. - Connect/Disconnect - Remove m_gotoRange->setFocus Like this? :-/ I noticed bad behavior and have remove these setFocus, test it if its OK. On edit was always the focus set to the spinbox. CHANGES SINCE LAST

D17459: SearchBar: Add Cancel button to stop long running tasks

loh.tar updated this revision to Diff 49754. loh.tar set the repository for this revision to R39 KTextEditor. loh.tar added a comment. - Fix to pass autotest 97% tests passed, 2 tests failed out of 67 Total Test time (real) = 137.70 sec The following tests FAILED: 24 -

D18317: Don't fail if defaultLanguage dictionary can't be loaded

loh.tar added a comment. Just my thoughts: - I think there shouldn't be the (default) dictionary changed by some smart logic. Just hint the user that the setting is not applicable. - To set the dict to the system locale seems to me the less smartest trick. If everybody want such

D18317: Don't fail if defaultLanguage dictionary can't be loaded

loh.tar added a comment. Well, I'm not a Sonnet Guru, more a normal user. Sorry if it sounds so. I can't give a detailed point how to solve some particular issue. My comment is more about what I would expect or what I would try to achieve. I didn't investigate from where is

D17949: ViewPrivate: Make applyWordWrap() more comfortable

loh.tar added subscribers: cullmann, dhaumann. loh.tar added a comment. > please add proper tests for this functionality No idea how Because there are a couple of bug reports where often the response was like "No, can't be done" need this a closer look from @dhaumann and @cullmann

D17693: DocumentPrivate: Treat some chars also as "auto bracket" only when we have a selection

loh.tar updated this revision to Diff 49452. loh.tar retitled this revision from "DocumentPrivate: Treat angle bracket < and backtick ` also as "auto bracket" when we have a selection" to "DocumentPrivate: Treat some chars also as "auto bracket" only when we have a selection". loh.tar edited

D18164: Review KateGotoBar

loh.tar added a comment. > I have the feeling it adds more clutter than it helps by default: Code clutter or what? The functionality is lovely and I can't see in which way It may someone jar > I thinkis quite fast. For a keyboard-virtuoso for sure. I'm one of those who use

D17949: ViewPrivate: Make applyWordWrap() more comfortable

loh.tar added a comment. Interesting. Didn't know that such function exist. Well, it may help to read the handbook... Is there no GUI way to access such stuff? "Read the handbook" lala... Well, word/text wrapping is a field which has many room for improvements. - Adjust as block

D18116: Don't show document load trouble twice

loh.tar updated this revision to Diff 50027. loh.tar added a comment. - Don't set m_openingErrorMessage in KateBuffer::openFile - m_openingErrorMessage is now nowhere set CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18116?vs=49031=50027 REVISION DETAIL

D17693: DocumentPrivate: Treat some chars also as "auto bracket" only when we have a selection

loh.tar updated this revision to Diff 50061. loh.tar edited the summary of this revision. loh.tar set the repository for this revision to R39 KTextEditor. loh.tar added a comment. - const QChar as value, not reference - Add , ; - + ^ ° § & just for completeness REPOSITORY R39 KTextEditor

D17857: DocumentPrivate: Don't scroll view when add auto-bracket at end of file

loh.tar added a comment. > But on the other side: how does one reproduce this? Hm, I had just follow the descriptions in the report. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17857 To: loh.tar, #ktexteditor Cc: cullmann, dhaumann, kwrite-devel,

D18125: KateStatusBar: Add dictionary button

loh.tar added a comment. > m_dictionaryGroup->checkedAction() might be null. Oops! Thanks. > For the naming: Given we show the encodings with their short-names, too, I can live with de_DE or stuff like that. Is it OK to add some cutting like that? Currently is that extra stuff

D17459: SearchBar: Add Cancel button to stop long running tasks

loh.tar added a comment. > are you interested in that challenge, too? Um...atm? No. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17459 To: loh.tar, #ktexteditor, #vdg, cullmann Cc: dhaumann, anthonyfieroni, brauch, cullmann, abetts, kwrite-devel,

D17949: ViewPrivate: Make 'Apply Word Wrap' more comfortable

loh.tar updated this revision to Diff 50082. loh.tar retitled this revision from "ViewPrivate: Make applyWordWrap() more comfortable" to "ViewPrivate: Make 'Apply Word Wrap' more comfortable". loh.tar added a comment. - Use std::unique_ptr for the cursor - Oops!? Use 'if' instead of

D17128: WIP DocumentPrivate: Remove all from next line which may annoying when joining lines

loh.tar added a comment. > can you please rephrase the title of this review to make it understandable? Of course, if I could, I would have done it :-) "Remove all what is not nice text" ? It may help you to read all posts to get a hint of my intention. It turned out that this here ist

D17949: ViewPrivate: Make 'Apply Word Wrap' more comfortable

loh.tar updated this revision to Diff 50104. loh.tar edited the summary of this revision. loh.tar set the repository for this revision to R39 KTextEditor. loh.tar added a comment. - Update 'What's This' hint to reflect new behaviour and to be more precise - Update 'What's This' hint of dyn

D17459: SearchBar: Add Cancel button to stop long running tasks

loh.tar updated this revision to Diff 47362. loh.tar edited the summary of this revision. loh.tar added a comment. - Code cosmetic - Add singleShot stuff That's my first draft of that requested singleShot approach, help is now appreciated. - Replace crashes due to (I think) these

D17459: SearchBar: Add Cancel button to stop long running tasks

loh.tar added a comment. Hmpf! Some googling didn't help. Just some thoughts. - Adding a couple of checks where ever just to block in case of a running S could be a little cumbersome - What we need would be an QObject::processEvents, so that only the Cancle button is a live but no

D17661: ViewConfig: Add 'Dynamic Wrap At Static Marker' option

loh.tar added a comment. - No sure if there must be something at other places considered - This is my second version where the wrap is done ether at the static setting or the view width, whatever is smaller. At first is was always wrapped at the static setting. Then I thought it may this

D17661: ViewConfig: Add 'Dynamic Wrap At Static Marker' option

loh.tar created this revision. loh.tar added reviewers: KTextEditor, VDG. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY Without this patch is in "Dynamic Wrap Mode" the text

D17693: DocumentPrivate: Treat angle bracket < and backtick ` also as "auto bracket" when we have a selection

loh.tar added a comment. > the change from QChar to const QChar & does not improve the amount of copied data. Argh! OK. Was just an impulse to do it as usual and to follow isStartBracket(..) and isBracket(..) Will wait for further advice REPOSITORY R39 KTextEditor REVISION DETAIL

D17459: SearchBar: Add Cancel button to stop long running tasks

loh.tar updated this revision to Diff 47891. loh.tar added a comment. - Workaround to keep binary compatibility > It's exported class you cannot... Argh! How can I see this quickly the next time? KTEXTEDITOR_EXPORT ? - Seams still to work so far, but looks not so lovely -

D17459: SearchBar: Add Cancel button to stop long running tasks

loh.tar updated this revision to Diff 47907. loh.tar added a comment. Fixed/Simplified as suggested - I noticed a reproducible crash when e.g. Kate will closed while a S is running. Happens also when a split view is closed (so far so good) and then Kate will closed . I will try to solve

D17730: [WIP] Review KateStatusBar (based on D17729)

loh.tar added a comment. Oops, have now the first commit omitted in this update. Perhaps not too bad this way(?) REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17730 To: loh.tar, #ktexteditor Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh,

D17729: KateStatusBar: Reformatted by astyle command to follow coding style

loh.tar created this revision. loh.tar added reviewers: KTextEditor, dhaumann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REPOSITORY R39 KTextEditor REVISION DETAIL

D17730: [WIP] Review KateStatusBar (based on D17729)

loh.tar added a comment. How about to change the "action-labels" to buttons? Thisway would it be less "quirky" and we would have a feedback that there is an action available when hovered by mouse REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17730 To:

D17730: [WIP] Review KateStatusBar (based on D17729)

loh.tar created this revision. loh.tar added a reviewer: KTextEditor. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY - KateStatusBar: Do actions on labels by single click instead

D17730: [WIP] Review KateStatusBar (based on D17729)

loh.tar updated this revision to Diff 47998. loh.tar edited the summary of this revision. loh.tar added a comment. - KateStatusBar: Don't treat click in empty area as click on mode-label REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE

D17729: KateStatusBar: Reformatted by astyle command to follow coding style

loh.tar added a comment. Nothing else was done REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17729 To: loh.tar, #ktexteditor, dhaumann Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D17730: [WIP] Review KateStatusBar (based on D17729)

loh.tar updated this revision to Diff 48000. loh.tar edited the summary of this revision. loh.tar added a comment. - KateStatusBar: Move the modified-label from far right to far left Once again without all other patches REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE

D17733: ViewPrivate: Don't hide 'Clear Dictionary Ranges' action

loh.tar created this revision. loh.tar added reviewers: KTextEditor, VDG. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY Toggle the action instead enable/disable ensure the user

D17729: KateStatusBar: Reformatted by astyle command to follow coding style

loh.tar updated this revision to Diff 48054. loh.tar added a comment. - Run astyle again, this time with "--align-pointer=name" - Omit changes done in the signal/slot connect code because these need a port to the new style. Well, was somehow pointless because these code is changed anyway

D17729: KateStatusBar: Reformatted by astyle command to follow coding style

loh.tar added a comment. - It's a prearrangement for more changes D17730 - In the meantime I noticed that these astyle command did not move/fix to place "*&" to the right. I will update/fix this before someone like to commit REPOSITORY R39

D17730: [WIP] Review KateStatusBar (based on D17729)

loh.tar added a comment. > My main intent is to add somehow a spell check button/hint Here a snapshot how it looks currently F6503235: 1545570321.png Sadly stuck I now, every help is appreciated I like to show on the button the current

D17693: DocumentPrivate: Treat angle bracket < and backtick ` also as "auto bracket" when we have a selection

loh.tar added a comment. > Btw., have you perhaps played a bit with the https://phabricator.kde.org/D12295 patch? No, but noticed it sometime in the past > If you use it, could you try that patch, too? Will try it REPOSITORY R39 KTextEditor REVISION DETAIL

D17730: [WIP] Review KateStatusBar (based on D17729)

loh.tar updated this revision to Diff 48237. loh.tar edited the test plan for this revision. loh.tar set the repository for this revision to R39 KTextEditor. loh.tar added a comment. - All in one diff - Rebased on master - Removed test plan - Will update Summary/Title before you commit

D17730: [WIP] Review KateStatusBar (based on D17729)

loh.tar updated this revision to Diff 48236. loh.tar edited the summary of this revision. loh.tar added a comment. - Only show lineColLabel context menu when click on it and not somewhere on the bar As "usual" without all other patches. > No idea how the spell-checking code handles

D17729: KateStatusBar: Reformatted by astyle command to follow coding style

loh.tar added a comment. @cullmann wrote: > Actually, if there is a astyle commandline that enforces the right style, could you paste it here? Um (?) I had in mind it was on the Kate HP but couln'd find it now. But it's there

D17730: [WIP] Review KateStatusBar (based on D17729)

loh.tar added a comment. > For the "should we use buttons": I think I tried that in the past and it did look horrible in many styles, but perhaps I am wrong ;) I see. May it in the meantime not an issue anymore, due to new designs elsewhere? And what's up with the existing buttons, they

D17459: SearchBar: Add Cancel button to stop long running tasks

loh.tar updated this revision to Diff 47379. loh.tar added a comment. - Fix crash in replace mode CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17459?vs=47362=47379 REVISION DETAIL https://phabricator.kde.org/D17459 AFFECTED FILES src/search/katesearchbar.cpp

D17459: SearchBar: Add Cancel button to stop long running tasks

loh.tar added a comment. > everything could have happened, e.g. the search bar got deleted because the view got delete OK, but I still do not see why that will be different with that singleShot approach. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17459

D17459: SearchBar: Add Cancel button to stop long running tasks

loh.tar added a comment. In D17459#375429 , @cullmann wrote: > I am atm a bit busy Thanks for the hint > For the input range, I think it would make sense to store it as std::unique_ptr to have it taking care of "edits" in-between

D17459: SearchBar: Add Cancel button to stop long running tasks

loh.tar updated this revision to Diff 47380. loh.tar added a comment. - Fix to remember loop state CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17459?vs=47379=47380 REVISION DETAIL https://phabricator.kde.org/D17459 AFFECTED FILES src/search/katesearchbar.cpp

D17459: SearchBar: Add Cancel button to stop long running tasks

loh.tar updated this revision to Diff 47408. loh.tar added a comment. - Use new (dis)connect style in touched functions - Clean-Up no longer needed MovingRange Thanks for the explaining. Sounds like QScopedPointer(?) I have not used any of them now because it looked to me to have not

D17624: KTextEditor::Message: Review documentation

loh.tar created this revision. loh.tar added a reviewer: KTextEditor. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY - Reduce redundant text - Change some argument names in the

D17624: KTextEditor::Message: Review documentation

loh.tar updated this revision to Diff 47673. loh.tar added a comment. - Fix optionally/optional + be I like to suggest that some more eyes take a look at that :-) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17624?vs=47669=47673 REVISION DETAIL

D17310: Improve Kile icon with LaTeX font

loh.tar added a comment. The used traffic cone by VLC is for me also nondescript, but that's their icon and therefore we know it. My point is only that your new icon should be somehow similar to the stuff used by Kile, and not to try to describe what we can do with Kile. Should I miss

D17624: KTextEditor::Message: Review documentation

loh.tar updated this revision to Diff 47678. loh.tar added a comment. -Rename member autoHide->delay to fit accepted change in header file just an offer CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17624?vs=47673=47678 REVISION DETAIL https://phabricator.kde.org/D17624

D17631: class Message: Use inclass member initialization

loh.tar accepted this revision. loh.tar added a comment. This revision is now accepted and ready to land. I'm surprised. Obviously have you change something previous (?) REPOSITORY R39 KTextEditor BRANCH message_inclass_member_initializationa REVISION DETAIL

D17624: KTextEditor::Message: Review documentation

loh.tar added a comment. Sorry for the hassle, will revert the update > Further, I would prefer autoHideDelay instead of just delay. Are you refering here to the header or the code part? The old name in the header was "autoHideTimeR" which is pretty wrong. So have I to change this

D17310: Improve Kile icon with LaTeX font

loh.tar added a comment. For me is these root sign nondescript. When the orig old blue symbol is not desired, how about to freshen it up? How? I don't know. Perhaps Black & White just as all your other offers on these rectangular sheet of paper? Furthermore exist these splash-screen. So

D17609: KTextEditor: Add action for static word wrap

loh.tar created this revision. loh.tar added reviewers: KTextEditor, VDG. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY - Move "Show Static Word Wrap Marker" code some lines up

D17609: KTextEditor: Add action for static word wrap

loh.tar added a comment. - Not well tested - Slot code may not fit coding style but looks not bad to me - No Ampersand & short cut set as done by other actions REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17609 To: loh.tar, #ktexteditor, #vdg Cc:

D17459: SearchBar: Add Cancel button to stop long running tasks

loh.tar added inline comments. INLINE COMMENTS > anthonyfieroni wrote in katesearchbar.cpp:860-865 > Maybe not an issue, but you can try to cache value preventing unwanted lookup > > auto dd = d(this); > dd->... Only here or everywhere? At this particular place may that optimized by the

D17459: SearchBar: Add Cancel button to stop long running tasks

loh.tar updated this revision to Diff 47966. loh.tar added a comment. Improve the readability and prevent unwanted lookup by caching d(this) as dd REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17459?vs=47963=47966 REVISION DETAIL

D17459: SearchBar: Add Cancel button to stop long running tasks

loh.tar added a comment. I have tried to run two S jobs at the same time on the same document, seems to works nicely - view 1 -> S "tab" -> "-" - view 2 -> S "0" -> "+" I had canceled both jobs and then resume, that's why at the pic are already replacents to see while the job is

D17459: SearchBar: Add Cancel button to stop long running tasks

loh.tar updated this revision to Diff 47963. loh.tar set the repository for this revision to R39 KTextEditor. loh.tar added a comment. - Fix crash when the document will closed while a S job is running - Fix crash when the view will closed while a S job is running These fixes seems to

D17028: Loader: Avoid Q_FOREACH

loh.tar added a comment. Well, neither of that. My "online me" is loh.tar but that was rejected by Phabricator, so the dot had to go. Lastly used ngraham uppercase letters, what looks even more strange to me :-) Should you intend to commit this, thanks in advance! May you look at D17055

D17028: Loader: Avoid Q_FOREACH

loh.tar added a comment. @davidedmundson May I ask how does this here will progress? You seemed to request a change which was not clear to me, but it's anyway "green flagged". REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D17028 To: loh.tar, davidedmundson Cc:

D17028: Loader: Avoid Q_FOREACH

loh.tar added a comment. >> @cfeck wrote: > > It looked strange on the list of names of all committers. A look at your page indicates that you are doing some public relations? Should you copy some data from an auto generated list, feel free to remove me. REPOSITORY R246 Sonnet

D17257: KateViewInternal: S

loh.tar added a comment. @cullmann Did you notice this? The other patches did you apply very quick, so I hope I didn't unsettle you with my comments. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17257 To: loh.tar, #ktexteditor, cullmann Cc: kwrite-devel,

D17030: DictionaryComboBox: Keep user preferred dictionaries on top

loh.tar added a comment. #Frameworks Ping! (?) REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D17030 To: loh.tar, #frameworks, #vdg, ngraham Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D9077: Bug 377342 Question

loh.tar added subscribers: cullmann, loh.tar. loh.tar added a comment. Herald edited subscribers, added: kde-frameworks-devel, kwrite-devel; removed: Frameworks. @cullmann I thing you could give a short hint But perhaps is @christofg no longer interested to work on this issue REPOSITORY

D17030: DictionaryComboBox: Keep user preferred dictionaries on top

loh.tar edited the summary of this revision. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D17030 To: loh.tar, #frameworks, #vdg, ngraham Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D17382: KateViewInternal: Rename getMouse/Cursor() => mouse/cursorPosition() to fit coding style

loh.tar added a comment. In D17382#372925 , @dhaumann wrote: > sorry for the delay :( What? No, it was pretty fast :-) But I have a couple of Sonnet stuff where no progress happens :-/ REPOSITORY R39 KTextEditor REVISION DETAIL

D17128: DocumentPrivate: Remove comment mark when joining lines

loh.tar added a comment. Thanks for your input Dominik. In the meanwhile I noticed (again) these "Smart-Return" function (I noticed, and used that a couple of years for a short time period, but forgot that somehow) A reverse version of that should be nice. And somehow the possibility to

D17437: SearchBar: Avoid malfunction with very large files

loh.tar created this revision. loh.tar added reviewers: KTextEditor, VDG. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY This is only a workaround to avoid cases where Kate can

D17437: SearchBar: Avoid malfunction with very large files

loh.tar added a comment. - The mentioned crash could I not reproduce, but after 5 million hits and a felt eternity I had killed Kate - There is an issue now with the wrap message, where is now the same close button. Any ideas what's wrong? - I like to suggest to get rid of most of that S

D17028: Loader: Avoid Q_FOREACH

loh.tar added a comment. > ..but I cannot remember we didn't ask contributors for their real name for contributions. Um, what? I was asked. I hope it's ok as it is. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D17028 To: loh.tar, davidedmundson Cc: cfeck,

D17382: KateViewInternal: Rename getMouse/Cursor() => mouse/cursorPosition() to fit coding style

loh.tar added a comment. Without any special "Oh, that would be nice", I will stop now with further S - I have tried to clean up a little bit the two header files, but that's more difficult than thought - m_cursor => cursorPosition() is also not so easy - There was no comment

D17459: SearchBar: Add Cancel button to stop long running tasks

loh.tar created this revision. loh.tar added reviewers: KTextEditor, VDG. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY Without this patch could it happens that Kate run an

  1   2   3   4   5   >