D25814: [KColorScheme] Add SeparatorColor

2019-12-09 Thread David Faure
dfaure resigned from this revision. dfaure added a comment. This revision now requires review to proceed. Hugo's arguments make sense, removing my approval. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D25814 To: ndavis, #frameworks, #vdg Cc: filipf, cfeck,

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.13 - Build # 55 - Still Unstable!

2019-12-09 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.13/55/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 09 Dec 2019 08:37:17 + Build duration: 2 min 30 sec and counting JUnit Tests Name:

D25814: [KColorScheme] Add SeparatorColor

2019-12-09 Thread Christoph Feck
cfeck added a comment. I also agree with the concerns rised by Hugo. An application will use various frame primitives, and the style decides how to draw them. It doesn't belong in the API, though (but neither do Focus and Hover colors). REPOSITORY R265 KConfigWidgets REVISION DETAIL

D25815: Transmission-Qt tray icon added

2019-12-09 Thread Kai Uwe Broulik
broulik added a comment. I chceked transmission git code and the icon name it uses is actually `transmission-tray-icon`, so you want to have a `transmission.svg` file and the "id" to be `transmission-tray-icon`, then it should work:

KDE CI: Frameworks » kpeople » kf5-qt5 SUSEQt5.12 - Build # 68 - Fixed!

2019-12-09 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kpeople/job/kf5-qt5%20SUSEQt5.12/68/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 09 Dec 2019 10:52:10 + Build duration: 3 min 3 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kpeople » kf5-qt5 WindowsMSVCQt5.13 - Build # 32 - Fixed!

2019-12-09 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kpeople/job/kf5-qt5%20WindowsMSVCQt5.13/32/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Mon, 09 Dec 2019 10:52:10 + Build duration: 2 min 53 sec and counting JUnit Tests

KDE CI: Frameworks » kpeople » kf5-qt5 SUSEQt5.13 - Build # 47 - Fixed!

2019-12-09 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kpeople/job/kf5-qt5%20SUSEQt5.13/47/ Project: kf5-qt5 SUSEQt5.13 Date of build: Mon, 09 Dec 2019 10:52:10 + Build duration: 2 min 32 sec and counting BUILD ARTIFACTS

D25814: [KColorScheme] Add SeparatorColor

2019-12-09 Thread David Edmundson
davidedmundson added a comment. Can we clarify what separators we're referring to. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D25814 To: ndavis, #frameworks, #vdg Cc: davidedmundson, filipf, cfeck, hpereiradacosta, kde-frameworks-devel, LeGast00n, GB_2,

KDE CI: Frameworks » kpeople » kf5-qt5 AndroidQt5.13 - Build # 17 - Fixed!

2019-12-09 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kpeople/job/kf5-qt5%20AndroidQt5.13/17/ Project: kf5-qt5 AndroidQt5.13 Date of build: Mon, 09 Dec 2019 10:52:11 + Build duration: 1 min 16 sec and counting

D25727: Expose enum to the metaobject compiler

2019-12-09 Thread Aleix Pol Gonzalez
apol added a comment. Had to revert the commit, it broke with GCC. https://commits.kde.org/kpeople/b495b1a260cd15463a03ee47614b783ae8c2203d REPOSITORY R307 KPeople REVISION DETAIL https://phabricator.kde.org/D25727 To: apol, jbbgameich, davidedmundson Cc: dfaure, lnj,

KDE CI: Frameworks » kpeople » kf5-qt5 SUSEQt5.13 - Build # 46 - Still Failing!

2019-12-09 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kpeople/job/kf5-qt5%20SUSEQt5.13/46/ Project: kf5-qt5 SUSEQt5.13 Date of build: Mon, 09 Dec 2019 10:39:31 + Build duration: 1 min 17 sec and counting CONSOLE OUTPUT [...truncated

D25814: [KColorScheme] Add SeparatorColor

2019-12-09 Thread Noah Davis
ndavis added a comment. In D25814#574160 , @davidedmundson wrote: > Can we clarify what separators we're referring to. Frames around UI elements and horizontal/vertical lines that separate UI elements. These are the most common

D25814: [KColorScheme] Add SeparatorColor

2019-12-09 Thread Noah Davis
ndavis added a comment. In D25814#574129 , @hpereiradacosta wrote: > Few more comments on this: > > - general: you will never be able to make all the opiniated people happy, and you have to draw a line (otherwise your code will become

D25815: Transmission-Qt tray icon added

2019-12-09 Thread Noah Davis
ndavis added a comment. Here's one way to make a nice looking trapezoid in the Breeze style. I started by making a stroke with end points in the middle of pixels and the other settings I mentioned in my first comment. Then I converted it to a path and I added a 2px high rectangle to

D25815: Transmission-Qt tray icon added

2019-12-09 Thread Noah Davis
ndavis added a comment. In D25815#574150 , @broulik wrote: > I chceked transmission git code and the icon name it uses is actually `transmission-tray-icon`, so you want to have a `transmission.svg` file and the "id" to be

D25699: [PC3 ToolButton] Have the label take into account complementary color schemes

2019-12-09 Thread Filip Fila
filipf added subscribers: davidedmundson, mart. filipf added a comment. Yeah, PC2 ToolButton has this so it loads the arrow: https://github.com/KDE/plasma-framework/blob/master/src/declarativeimports/plasmastyle/ToolButtonStyle.qml#L110 For PC3 I guess we would have to hack it in in the

D25815: Transmission-Qt tray icon added

2019-12-09 Thread Nathaniel Graham
ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. I liked the original design with the trapezoid shape better TBH. The square one does indeed look quite "grave-like" and IMO isn't identifiable as Transmission anymore.

D25814: [KColorScheme] Add SeparatorColor

2019-12-09 Thread Nathaniel Graham
ngraham added a comment. In D25814#574197 , @ndavis wrote: > In D25814#574160 , @davidedmundson wrote: > > > Can we clarify what separators we're referring to. > > > Frames around UI elements

D25682: [WIP] add initial wsdiscovery support

2019-12-09 Thread Harald Sitter
sitter marked 26 inline comments as done. sitter added a comment. Yep, still looking for primarily design input. Thanks for your comments, David! INLINE COMMENTS > dfaure wrote in discovery.h:40 > Why don't these `toEntry()` methods *return* a KIO::UDSEntry instead? > It's always empty

D25440: Set a proper agent string for Attica requests

2019-12-09 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R235 Attica BRANCH set-a-proper-agent-string-with-less-lies (branched from master) REVISION DETAIL https://phabricator.kde.org/D25440 To: leinir, #frameworks, #knewstuff, #plasma, starbuck,

D25822: Add manual test for changing colorscope in components

2019-12-09 Thread Nathaniel Graham
ngraham added a comment. Nice. Does this fix or obsolete D25699 ? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25822 To: davidedmundson, filipf Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D15763: Set correct image attributes on directory thumbnail

2019-12-09 Thread Kai Uwe Broulik
broulik added a comment. @dfaure Ping REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D15763 To: broulik, #frameworks, dfaure, anthonyfieroni, jtamate, ngraham Cc: ngraham, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, MrPepe,

D25371: Remove porting scaffolding, this is entirely on QSslError now

2019-12-09 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R241:3c9bac61808d: Remove porting scaffolding, this is entirely on QSslError now (authored by vkrause). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25371?vs=69940=71133

D25822: Add manual test for changing colorscope in components

2019-12-09 Thread David Edmundson
davidedmundson created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY For quickly other bugs in PC3 TEST PLAN Opened qmlscene on some files It's only for unit tests

D25440: Set a proper agent string for Attica requests

2019-12-09 Thread Dan Leinir Turthra Jensen
This revision was automatically updated to reflect the committed changes. Closed by commit R235:02e10ec078c9: Set a proper agent string for Attica requests (authored by leinir). REPOSITORY R235 Attica CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25440?vs=70345=71124 REVISION

D25441: Send along the config name with requests

2019-12-09 Thread Dan Leinir Turthra Jensen
This revision was automatically updated to reflect the committed changes. Closed by commit R304:2c14de4ea749: Send along the config name with requests (authored by leinir). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25441?vs=70427=71125 REVISION DETAIL

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 217 - Still Unstable!

2019-12-09 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/217/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 09 Dec 2019 17:31:51 + Build duration: 10 min and counting JUnit Tests Name: projectroot

D25682: [WIP] add initial wsdiscovery support

2019-12-09 Thread Harald Sitter
sitter updated this revision to Diff 71121. sitter marked 9 inline comments as done. sitter added a comment. various fixes suggested by dfaure REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25682?vs=70750=71121 BRANCH master REVISION DETAIL

D25814: [KColorScheme] Add SeparatorColor

2019-12-09 Thread Hugo Pereira Da Costa
hpereiradacosta added a comment. In D25814#574197 , @ndavis wrote: > In D25814#574160 , @davidedmundson wrote: > > > Can we clarify what separators we're referring to. > > > Frames around UI

KDE CI: Frameworks » knewstuff » kf5-qt5 SUSEQt5.13 - Build # 78 - Failure!

2019-12-09 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/knewstuff/job/kf5-qt5%20SUSEQt5.13/78/ Project: kf5-qt5 SUSEQt5.13 Date of build: Mon, 09 Dec 2019 16:45:46 + Build duration: 1 min 43 sec and counting CONSOLE OUTPUT [...truncated

KDE CI: Frameworks » knewstuff » kf5-qt5 SUSEQt5.12 - Build # 118 - Failure!

2019-12-09 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/knewstuff/job/kf5-qt5%20SUSEQt5.12/118/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 09 Dec 2019 16:45:46 + Build duration: 1 min 19 sec and counting CONSOLE OUTPUT

D25720: Fix shortcut conflict between Cut and Delete File

2019-12-09 Thread Nathaniel Graham
ngraham added a comment. Good idea, done in 912ec731b8bd9eca12ae21920c81bcddfb46622b . REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D25720 To: ngraham, #frameworks, cfeck Cc: ahmadsamir,

D25824: Support archive installs with adoption commands

2019-12-09 Thread Dan Leinir Turthra Jensen
leinir created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. leinir requested review of this revision. REVISION SUMMARY This previously caused any icon pack installed through the store to not function when the adoption command pointed at a

D25340: Added background colors to active and inactive icon view

2019-12-09 Thread Nathaniel Graham
ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH arcpatch-D25340 (branched from master) REVISION DETAIL https://phabricator.kde.org/D25340 To: ndavis, #vdg, ngraham, niccolove Cc: filipf, manueljlin,

D25701: Use setIconProvider instead of setPixmapProvider for KHistoryComboBox

2019-12-09 Thread Nicolas Fella
This revision was automatically updated to reflect the committed changes. Closed by commit R135:a5bdd39f9355: Use setIconProvider instead of setPixmapProvider for KHistoryComboBox (authored by nicolasfella). REPOSITORY R135 Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE

D25720: Fix shortcut conflict between Cut and Delete File

2019-12-09 Thread Ahmad Samir
ahmadsamir added a comment. In D25720#573926 , @elvisangelaccio wrote: > In D25720#572291 , @ngraham wrote: > > > Though Dolphin seems to have some kind of local hack to make Shift+delete work for

D25822: Add manual test for changing colorscope in components

2019-12-09 Thread David Edmundson
davidedmundson added a reviewer: filipf. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25822 To: davidedmundson, filipf Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25824: Support archive installs with adoption commands

2019-12-09 Thread Dan Leinir Turthra Jensen
leinir edited the test plan for this revision. leinir added reviewers: Frameworks, Plasma, KNewStuff, apol, ngraham. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D25824 To: leinir, #frameworks, #plasma, #knewstuff, apol, ngraham Cc: kde-frameworks-devel, LeGast00n,

D25720: Fix shortcut conflict between Cut and Delete File

2019-12-09 Thread Nathaniel Graham
ngraham abandoned this revision. ngraham added a comment. All right. Thanks for the history! REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D25720 To: ngraham, #frameworks, cfeck Cc: elvisangelaccio, aspotashev, bcooksley, davidedmundson, aacid, apol,

D25814: [KColorScheme] Add SeparatorColor

2019-12-09 Thread Hugo Pereira Da Costa
hpereiradacosta added a comment. > So the background here is that we've gotten a new VDG designer who produced mockups of Breeze dark with dark separators, and some people absolutely fell in love with them, while other people hated them. We could not achieve consensus on moving to use

D25340: Added background colors to active and inactive icon view

2019-12-09 Thread Noah Davis
This revision was automatically updated to reflect the committed changes. Closed by commit R242:7e52c869de2d: Added background colors to active and inactive icon view (authored by ndavis). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D25770: Several enhancements to gitolite syntax definition.

2019-12-09 Thread Michael Hansen
This revision was automatically updated to reflect the committed changes. Closed by commit R216:44baed407ac6: Several enhancements to gitolite syntax definition. (authored by zrax). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

D25814: [KColorScheme] Add SeparatorColor

2019-12-09 Thread Noah Davis
ndavis added a comment. In D25814#574250 , @hpereiradacosta wrote: > - You should add toolbar separators, tabboxes and group boxes to that. For toolbar separators, I wonder how this would play with monochrome (color-themed) icons. I'm

D25822: Add manual test for changing colorscope in components

2019-12-09 Thread Filip Fila
filipf added a comment. Thanks! It will be easier to test now. I noticed some issues with certain tests, although most seem to have already existed: - busyindicator3.qml -> loads, but complains about a binding loop detected for `implicitHeight` - button3.qml -> doesn't load, says

D25822: Add manual test for changing colorscope in components

2019-12-09 Thread Filip Fila
filipf accepted this revision. filipf added a comment. This revision is now accepted and ready to land. Thanks again :) REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D25822 To: davidedmundson, filipf Cc: ngraham,

D25824: Support archive installs with adoption commands

2019-12-09 Thread Aleix Pol Gonzalez
apol added inline comments. INLINE COMMENTS > engine.cpp:744 > +const QDir dir(currentPath); > if (dir.path()==(rootPath+dir.dirName())) { > +qCDebug(KNEWSTUFFCORE) << "Found directory" << dir; Shouldn't we make sure rootPath ends with /? at least with an ASSERT if

D25822: Add manual test for changing colorscope in components

2019-12-09 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R242:a3acfbfce605: Add manual test for changing colorscope in components (authored by davidedmundson). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D25822: Add manual test for changing colorscope in components

2019-12-09 Thread Filip Fila
filipf added a comment. In D25822#574271 , @ngraham wrote: > Nice. Does this fix or obsolete D25699 ? No, this just for easier testing of all the components with the complementary theme. REPOSITORY

D25814: [KColorScheme] Add SeparatorColor

2019-12-09 Thread Hugo Pereira Da Costa
hpereiradacosta added a comment. > I'm not sure what you mean when you wonder how it would play with monochrome icons. It should have nothing to do with them unless you embed stylesheets in the SVGs to use the separator color in breeze icons. I meant: do the "light" (with window

D25814: [KColorScheme] Add SeparatorColor

2019-12-09 Thread Noah Davis
ndavis added a comment. In D25814#574356 , @hpereiradacosta wrote: > I meant: do the "light" (with window text color) toolbar icons play well with dark toolbar separators as opposed to current semi-light toolbar separators I assume you

KDE CI: Frameworks » knewstuff » kf5-qt5 SUSEQt5.13 - Build # 79 - Fixed!

2019-12-09 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/knewstuff/job/kf5-qt5%20SUSEQt5.13/79/ Project: kf5-qt5 SUSEQt5.13 Date of build: Mon, 09 Dec 2019 19:37:14 + Build duration: 4 min 17 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » knewstuff » kf5-qt5 SUSEQt5.12 - Build # 119 - Fixed!

2019-12-09 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/knewstuff/job/kf5-qt5%20SUSEQt5.12/119/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 09 Dec 2019 19:37:13 + Build duration: 3 min 5 sec and counting BUILD ARTIFACTS

D25822: Add manual test for changing colorscope in components

2019-12-09 Thread David Edmundson
davidedmundson updated this revision to Diff 71139. davidedmundson added a comment. Thanks Updated all the things. REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25822?vs=71123=71139 BRANCH master REVISION DETAIL

D25814: [KColorScheme] Add SeparatorColor

2019-12-09 Thread Nathaniel Graham
ngraham added a comment. In D25814#574380 , @ndavis wrote: > FWIW, Adwaita Dark uses dark separators, but GNOME doesn't use nearly as many icons as we do. F7806761: Screenshot_20191209_155912.png

D25820: SimpleScreenRecorder icon added

2019-12-09 Thread Vinzenz Vietzke
vinzenzv added a comment. In D25820#574119 , @ndavis wrote: > Good start! The lens flare looks upside down That was intentionally to make it distinguishable from digiKam. > and the icon needs more pixel alignment. I didn't move

D25814: [KColorScheme] Add SeparatorColor

2019-12-09 Thread Filip Fila
filipf added a comment. In D25814#574389 , @ngraham wrote: > In D25814#574380 , @ndavis wrote: > > > FWIW, Adwaita Dark uses dark separators, but GNOME doesn't use nearly as many icons as we do.

D25815: Transmission-Qt tray icon added

2019-12-09 Thread Noah Davis
ndavis added a comment. wait scratch that, it does work. I had to remove the `22-22-` prefix, which is what you need to do when you have multiple icon sizes. REVISION DETAIL https://phabricator.kde.org/D25815 To: vinzenzv, #vdg, ndavis, ngraham Cc: broulik, ndavis, ngraham, iasensio,

KDE CI: Frameworks » kcalendarcore » kf5-qt5 SUSEQt5.12 - Build # 37 - Still Unstable!

2019-12-09 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20SUSEQt5.12/37/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 09 Dec 2019 23:14:37 + Build duration: 2 min 41 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kcalendarcore » kf5-qt5 SUSEQt5.13 - Build # 39 - Still Unstable!

2019-12-09 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20SUSEQt5.13/39/ Project: kf5-qt5 SUSEQt5.13 Date of build: Mon, 09 Dec 2019 23:14:37 + Build duration: 3 min 33 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kcalendarcore » kf5-qt5 FreeBSDQt5.13 - Build # 37 - Still Unstable!

2019-12-09 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20FreeBSDQt5.13/37/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 09 Dec 2019 23:14:37 + Build duration: 2 min 33 sec and counting JUnit Tests Name:

D25829: kconfig EBN transport protocol cleanup

2019-12-09 Thread John Hayes
jhayes created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. jhayes requested review of this revision. REVISION SUMMARY Change and test transport protocol from http to https while correcting dead link REPOSITORY R237 KConfig BRANCH

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.12 - Build # 118 - Unstable!

2019-12-09 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.12/118/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 09 Dec 2019 23:28:22 + Build duration: 4 min 17 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.13 - Build # 40 - Still Unstable!

2019-12-09 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.13/40/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 09 Dec 2019 23:52:52 + Build duration: 3 min 45 sec and counting JUnit Tests Name:

D25827: kcodecs EBN transport protocol cleanup

2019-12-09 Thread John Hayes
jhayes created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. jhayes requested review of this revision. REVISION SUMMARY Cleaned up transport protocol from http to https and verified addresses worked REPOSITORY R270 KCodecs BRANCH

D24641: Collect more information from version control systems

2019-12-09 Thread Thomas Fischer
thomasfischer updated this revision to Diff 71145. thomasfischer marked 4 inline comments as done. thomasfischer edited the summary of this revision. thomasfischer edited the test plan for this revision. thomasfischer added a comment. I tried to address the most recent comments: - Added

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 66 - Still Unstable!

2019-12-09 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/66/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 09 Dec 2019 23:28:22 + Build duration: 2 min 17 sec and counting JUnit Tests Name:

D25815: Transmission-Qt tray icon added

2019-12-09 Thread Vinzenz Vietzke
vinzenzv added a comment. In D25815#574216 , @ndavis wrote: > Here's one way to make a nice looking trapezoid in the Breeze style. I started by making a stroke with end points in the middle of pixels and the other settings I mentioned in my

D25815: Transmission-Qt tray icon added

2019-12-09 Thread Noah Davis
ndavis added a comment. In D25815#574394 , @vinzenzv wrote: > In D25815#574216 , @ndavis wrote: > > > Here's one way to make a nice looking trapezoid in the Breeze style. I started by making a

D25814: [KColorScheme] Add SeparatorColor

2019-12-09 Thread Noah Davis
ndavis added a comment. In D25814#574395 , @filipf wrote: > Already asked in VDG, but repeating here: how would we handle dark separators on really dark color schemes? > > This is the most downloaded color scheme and it won't work well with

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.13 - Build # 71 - Fixed!

2019-12-09 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.13/71/ Project: kf5-qt5 SUSEQt5.13 Date of build: Mon, 09 Dec 2019 23:28:22 + Build duration: 3 min 31 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.12 - Build # 88 - Fixed!

2019-12-09 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.12/88/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 09 Dec 2019 23:44:17 + Build duration: 6 min 24 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.13 - Build # 41 - Still Unstable!

2019-12-09 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.13/41/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 09 Dec 2019 23:44:17 + Build duration: 7 min 18 sec and counting JUnit Tests Name: