Re: [Libhugetlbfs-devel] [PATCH v2 1/2] ARM support.

2013-02-21 Thread David Gibson
> > Signed-off-by: Steve Capper Looks fine as far as I can tell without knowing arm well. Acked-by: David Gibson -- David Gibson| I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_

Re: [Libhugetlbfs-devel] [PATCH v2 2/2] ARM unit test fix.

2013-02-21 Thread David Gibson
_EIP]; > +#elif defined(__arm__) > + void *pc = (void *)((ucontext_t > *)uc)->uc_mcontext.fault_address; > #endif > > verbose_printf("SIGSEGV at %p, PC=%p (sig_expected=%p)\n", -- David Gibson| I'll have my

Re: [Libhugetlbfs-devel] Fallback is all-or-nothing ?

2012-11-18 Thread David Gibson
On Fri, Nov 16, 2012 at 09:38:55AM +0100, telenn barz wrote: > On Fri, Nov 16, 2012 at 1:13 AM, David Gibson > wrote: > > > On Thu, Nov 15, 2012 at 04:31:44PM -0500, Eric B Munson wrote: > > > On 2012-11-15 14:44, telenn barz wrote: > > > > On Thu, Nov 15, 2012

Re: [Libhugetlbfs-devel] Fallback is all-or-nothing ?

2012-11-15 Thread David Gibson
> huge pages still. In addition I don't think the glibc morecore callback lets us control the fallback that closely. IIRC, we just fail the morecore, and glibc falls back on an mmap(). So even on x86 to do partial fallback we'd need a different (and much more complex) implementa

Re: [Libhugetlbfs-devel] [PATCH] fail test only when MAP_FIXED fails on free slices

2012-09-13 Thread David Gibson
On Thu, Sep 13, 2012 at 02:27:33AM -0400, Jan Stancek wrote: > > > - Original Message - > > From: "David Gibson" > > To: "Jan Stancek" > > Cc: libhugetlbfs-devel@lists.sourceforge.net, an...@redhat.com > > Sent: Thursday, 13 Sept

Re: [Libhugetlbfs-devel] [PATCH] fail test only when MAP_FIXED fails on free slices

2012-09-12 Thread David Gibson
luck. In this case we were unable to test at all. It's a bit of a pain, really, because these were realy bugs and they are still edge cases with interesting complexities and therefore likely sites for bugs. I'm not sure how to get around this. -- David Gibson| I

Re: [Libhugetlbfs-devel] missing man pages?

2012-02-12 Thread David Gibson
n't > found a man page for gethugepagesize.) > > Have I overlooked documentation for the other 6 functions or are > these man pages missing? I don't mind writing these man pages if > they're missing, but I'm asking so I won't duplicate someone else's &

Re: [Libhugetlbfs-devel] [PATCH] Check permissions when selecting mount

2011-12-10 Thread David Gibson
if (stats.st_uid == uid && (stats.st_mode & S_IRWXU)) > + return true; > + > + return false; > +} Couldn't you simplify this logic by using access(2)? -- David Gibson| I'll

Re: [Libhugetlbfs-devel] How to change the hugepagesize?

2011-11-16 Thread David Gibson
though exactly which sizes are supported varies. -- David Gibson| I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http:

Re: [Libhugetlbfs-devel] [PATCH 1/3] Add support for THP in morecore

2011-06-16 Thread David Gibson
nough > issue to justify having thp implement a completely new morecore hook. I really see no reason not to always madvise(), not even as an option. -- David Gibson| I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NO

Re: [Libhugetlbfs-devel] [PATCH 1/3] Add support for THP in morecore

2011-06-13 Thread David Gibson
On Mon, Jun 13, 2011 at 09:06:16AM -0500, Andrew Hastings wrote: > On 06/08/2011 09:40 PM, Eric B Munson wrote: > > On Wed, Jun 8, 2011 at 8:50 PM, David Gibson > > wrote: [snip] > Actually, in thinking about this some more I wonder if the > implementation ought to be using

Re: [Libhugetlbfs-devel] Query about linkhuge test case?

2011-06-13 Thread David Gibson
On Fri, Jun 10, 2011 at 02:54:46PM +0800, bill wrote: > At 2011-06-10 09:28:52,"David Gibson" wrote: > > >On Thu, Jun 09, 2011 at 04:50:50PM +0800, bill wrote: > >> Hi, guys:) > >> > >> > >> In order to run a program based on huge

Re: [Libhugetlbfs-devel] Add MIPS support to libhugetlbfs, the sample testing result

2011-06-13 Thread David Gibson
m 3.29Mop/s to 9.60Mop/s. That's a significant > improvement! Heh, no. 20% is a significant improvement. 200% is a enormous improvement. Although the fact that the change is so huge suggests your MMU sucked rather badly to begin with... -- David Gibson

Re: [Libhugetlbfs-devel] Query about linkhuge test case?

2011-06-09 Thread David Gibson
7;s most technically advanced content > authoring tool. Experience the power of Track Changes, Inline Image > Editing and ensure content is compliant with Accessibility Checking. > http://p.sf.net/sfu/ephox-dev2dev > ___ > Libhugetlbfs-devel

Re: [Libhugetlbfs-devel] [PATCH 1/3] Add support for THP in morecore

2011-06-08 Thread David Gibson
indeed, if you're doing thp without madvise, what is the hugetlbfs morecore actually doing that default morecore wouldn't. -- David Gibson| I'll have my music baroque, and my code david AT gibson.dropbear.id.au | mini

Re: [Libhugetlbfs-devel] Add MIPS support to libhugetlbfs

2011-06-05 Thread David Gibson
On Sun, Jun 05, 2011 at 05:01:46PM +0800, Yu Huang wrote: > 于 2011/6/4 15:22, David Gibson 写道: > > Uh, you need the -u option to diff. Plain-style diffs are more or > > less unusable as patches. > > > Thanks you! Here is a new patch with -u option: > > >

Re: [Libhugetlbfs-devel] Add MIPS support to libhugetlbfs

2011-06-04 Thread David Gibson
--- > > diff -rN libhugetlbfs-2.12-x86/Makefile libhugetlbfs-2.12-mips/Makefile > 20c20 > < LDSCRIPT_DIST_ELF = elf32ppclinux elf64ppc elf_i386 elf_x86_64 Uh, you need the -u option to diff. Plain-style diffs are more or less unusable as patches. -- Davi

Re: [Libhugetlbfs-devel] [PATCH V2] Make calls to strcmp in hugetlb_env_setup consistent

2011-05-25 Thread David Gibson
ll of the > comparisons looking for boolean (yes/no) values to ignore case. > > Signed-off-by: Eric B Munson Acked-by: David Gibson -- David Gibson| I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank

Re: [Libhugetlbfs-devel] [PATCH] Make calls to str[case]cmp in hugetlb_env_setup consistent

2011-05-24 Thread David Gibson
s" or whatever, after this patch it would merely check that the variable starts with "yes", so "yesterday" would match for example. -- David Gibson| I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. N

Re: [Libhugetlbfs-devel] Query about __unmap_hugepage_range

2011-04-12 Thread David Gibson
or write fault on the page we don't clean it but map it without execute permission. We only perform the icache flush when we get an actual execute fault on the page. You will either need to implement similar hacks in ARM, or move the flushing logic into the generic code. -- David Gibson

Re: [Libhugetlbfs-devel] Query about alloc-instantiate-race

2011-03-27 Thread David Gibson
age tables which are shared between the threads. -- David Gibson| I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_

Re: [Libhugetlbfs-devel] Can I add MIPS support to libhugetlbfs?

2011-01-16 Thread David Gibson
e, you'll need to teach the run_tests script to automatically run the old-style link tests only on platforms which support them. -- David Gibson| I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_

Re: [Libhugetlbfs-devel] Can I add MIPS support to libhugetlbfs?

2011-01-12 Thread David Gibson
gt; implementation. If I succeed in doing this, will you accept my > patch and merge it into the mainline of libhugetlbfs sourcecode? Sounds like an excellent idea. -- David Gibson| I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, tha

Re: [Libhugetlbfs-devel] [PATCH] shm.c: Allow static linking with shmget()

2011-01-05 Thread David Gibson
On Wed, Jan 05, 2011 at 06:27:18PM -0600, Andrew Hastings wrote: > David Gibson wrote: > > On Tue, Dec 28, 2010 at 05:37:44PM -0600, Andrew Hastings wrote: > >> libhugetlbfs redefines shmget() so that it can transparently optionally > >> add the hugepage flag. Unfortuna

Re: [Libhugetlbfs-devel] [PATCH] shm.c: Allow static linking with shmget()

2011-01-03 Thread David Gibson
of Cray Inc. I'm mildly surprised there isn't rather more to fix to get libhugetlbfs to work with static executables. A dynamic executable was pretty firmly assumed when it was created. What components of the libary have you tested with a static executable and this patch? -- David Gib

Re: [Libhugetlbfs-devel] [PATCH] Rename variable in inline function

2010-11-17 Thread David Gibson
the test suite and I > figured that it wouldn't the last time. And why would that be a problem? The local scope variable would override the global and the inline would still work correctly. -- David Gibson| I'll have my music baroque, and my code david AT gib

Re: [Libhugetlbfs-devel] Remap shared library into hugepages?

2010-09-16 Thread David Gibson
27;s the last, maybe you could change the library to dynamically allocate space instead of using BSS; then the libhugetlbfs MORECORE option would move the library's allocations to hugepage as well as the main executable's. -- David Gibson| I'll have my music ba

[Libhugetlbfs-devel] Fix bug in gethugepagesizes testcase

2010-05-30 Thread David Gibson
atch makes the correction. --- Signed-off-by: David Gibson diff --git a/tests/gethugepagesizes.c b/tests/gethugepagesizes.c index 8a6d2d6..860b9a5 100644 --- a/tests/gethugepagesizes.c +++ b/tests/gethugepagesizes.c @@ -255,22 +255,29 @@ void cleanup(void) cleanup_fake_data();

Re: [Libhugetlbfs-devel] Compilation on SPARC is incorrect

2010-02-14 Thread David Gibson
On Thu, Feb 11, 2010 at 02:19:49PM +0100, Jan Engelhardt wrote: > > On Thursday 2010-02-11 05:16, David Gibson wrote: > >On Mon, Feb 08, 2010 at 06:41:24PM +0100, Jan Engelhardt wrote: > >> > >> make > >> %ifarch sparc sparcv9 # that's target

Re: [Libhugetlbfs-devel] Compilation on SPARC is incorrect

2010-02-10 Thread David Gibson
orm it to automake, but would need review whether I've > matched everything. Please no. automake is a hideous tangled mess we can really do without. -- David Gibson| I'll have my music baroque, and my code d

Re: [Libhugetlbfs-devel] [PATCH] Fix ALIGN_UP to properly handle finding hugepage boundaries

2010-02-09 Thread David Gibson
Munson It would probably makes sense to define ALIGN_UP in terms of ALIGN, or vice versa. Still, doesn't matter that much. Acked-by: David Gibson -- David Gibson| I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, t

Re: [Libhugetlbfs-devel] [PATCH] Skip memory slice tests on x86[_64]

2010-02-08 Thread David Gibson
On Mon, Feb 08, 2010 at 05:14:59PM +, Mel Gorman wrote: > On Mon, Feb 08, 2010 at 03:24:22PM +1100, David Gibson wrote: > > On Thu, Feb 04, 2010 at 09:02:18PM +, Eric B. Munson wrote: > > > elflink.c tests slice boundaries for all architectures, but this is > > &g

Re: [Libhugetlbfs-devel] [PATCH] Skip memory slice tests on x86[_64]

2010-02-07 Thread David Gibson
p this check on x86[_64] builds. Hrm. The x86 versions of hugetlb_slice_end() and so forth are already supposed to make this check a nop. We shouldn't need to ifdef this out. -- David Gibson| I'll have my music baroque, and my code david AT gibson.dropbear.id.au |

[Libhugetlbfs-devel] Add testcases for buggy mremap() behaviours

2009-12-06 Thread David Gibson
chiefly at the powerpc manifestation, it may or may not also trip on other archs). Since these testcases will crash current kernels, we probably don't want to merge this until we can protect them with a kernel version test, like other dangerous testcases. Signed-off-by: David Gibson Index

[Libhugetlbfs-devel] Don't try to test multiple pagesizes for SysV shm

2009-11-19 Thread David Gibson
pers for shm-fork and shm-getraw are removed. Signed-off-by: David Gibson Index: libhugetlbfs/tests/run_tests.py === --- libhugetlbfs.orig/tests/run_tests.py2009-11-19 15:05:11.352192251 +1100 +++ libhugetlbfs/tests/run_test

[Libhugetlbfs-devel] Add paranoid checking of hugepage pool sizes

2009-11-18 Thread David Gibson
a new hugepage port). Signed-off-by: David Gibson Index: libhugetlbfs/tests/run_tests.py === --- libhugetlbfs.orig/tests/run_tests.py2009-10-02 13:18:48.0 +1000 +++ libhugetlbfs/tests/run_tests.py 2009-10-02 16:

[Libhugetlbfs-devel] Fix for bitrot in linkhuge_nofd

2009-10-15 Thread David Gibson
,7 @@ #include "hugetests.h" /* Override the working version from libhugetlbfs */ -int hugetlbfs_unlinked_fd(void) +int hugetlbfs_unlinked_fd_for_size(long page_size) { return -1; } -- David Gibson| I'll have my music baroque, and my code david AT gibso

[Libhugetlbfs-devel] Bug in gethugepagesizes testcase

2009-09-27 Thread David Gibson
#x27;s failing on the system I'm testing right now. I'll send a patch to fix this if I get to it, but it's not my first priority right now. -- David Gibson| I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _t

Re: [Libhugetlbfs-devel] [RFC] hugetlbfs setup script

2009-09-09 Thread David Gibson
geadm. But I haven't been around much since hugeadm came into existence. If what this script does shouldn't be added to hugeadm, it at least looks as if some of the things it's doing it should do by invoking hugeadm, rather than directly. -- David Gibson| I

Re: [Libhugetlbfs-devel] Booting Linux to *only* use "huge" pages.

2009-08-24 Thread David Gibson
so at >least 2 MB in size ] > > Thanks in advance for any insight provided ... and happy hacking ! This cannot be done. Huge pages are a hack on the side of the Linux MM, and can't be used as a substitute for normal page handling. -- David Gibson| I'l

[Libhugetlbfs-devel] Suppress ld.hugetlbfs warnings when building testsuite

2009-08-23 Thread David Gibson
ectly full and correct build of the testsuite. Therefore, this patch provides an environment variable to suppress those warnings, and uses it from the testsuite makefile to get rid of them in this case. Signed-off-by: David Gibson Index: libhugetlbfs/ld.huge

[Libhugetlbfs-devel] Make tests for SPECIAL in linker scripts safe against cross-compiles

2009-08-23 Thread David Gibson
d-off-by: David Gibson Index: libhugetlbfs/tests/Makefile === --- libhugetlbfs.orig/tests/Makefile2009-08-24 14:45:26.0 +1000 +++ libhugetlbfs/tests/Makefile 2009-08-24 15:10:37.0 +1000 @@ -31,7 +31,7 @@ LDFLAGS32

[Libhugetlbfs-devel] Don't use a shell to invoke testcases

2009-08-23 Thread David Gibson
quot;yes") + do_test("heap-overflow", HUGETLB_VERBOSE="1", HUGETLB_MORECORE="yes") # Run the remapping tests' up-front checks linkhuge_wordsizes = check_linkhuge_tests() # Original elflink t

[Libhugetlbfs-devel] Correctly clean shmoverride_linked.c

2009-08-23 Thread David Gibson
shmoverride_linked.c is auto-generated as a symlink during make, but is not removed during a "make clean". This corrects the error. Signed-off-by: David Gibson Index: libhugetlbfs/tests/Makefile === --- libhugetlbfs.

[Libhugetlbfs-devel] Make run_tests.py set rlimits for mlock and stack_grow_into_huge tests

2009-08-19 Thread David Gibson
arily adjust the relevant rlimits around these testcases. Signed-off-by: David Gibson Index: libhugetlbfs/tests/run_tests.py === --- libhugetlbfs.orig/tests/run_tests.py2009-08-20 12:00:15.0 +1000 +++ libhugetlbfs/

[Libhugetlbfs-devel] libhugetlbfs: Fix some small errors / warts in run_tests.py

2009-08-19 Thread David Gibson
od instead of the manual equivalent. Signed-off-by: David Gibson Index: libhugetlbfs/tests/run_tests.py === --- libhugetlbfs.orig/tests/run_tests.py2009-08-19 13:18:58.0 +1000 +++ libhugetlbfs/tests/run_tests.py

[Libhugetlbfs-devel] Fix inner loop in elflink_and_share_test et al.

2009-08-18 Thread David Gibson
ually what happens. Signed-off-by: David Gibson Index: libhugetlbfs/tests/run_tests.py === --- libhugetlbfs.orig/tests/run_tests.py2009-08-19 15:57:59.0 +1000 +++ libhugetlbfs/tests/run_tests.py 2009-0

Re: [Libhugetlbfs-devel] Trying to run test program

2009-07-28 Thread David Gibson
least. Getting it to worth with another linker could be anywhere between easy and impossible depending on whether that linker has suitable options to alter the segment alignment. -- David Gibson| I'll have my music baroque, and my code david AT gibson.dropbear.id.au | m

Re: [Libhugetlbfs-devel] Trying to run test program

2009-06-30 Thread David Gibson
; libhugetlbfs [dmlb2000ts:15538]: INFO: setup_morecore(): heapaddr = > >>> 0x80e0 > >>> 0 > >>> > >>> > >>> So I'm guessing make check is supposed to be run as root? since there > >>> seems to be mount commands and e

Re: [Libhugetlbfs-devel] Trying to run test program

2009-06-24 Thread David Gibson
80. Not empty? > libhugetlbfs [uber-gamer:31049]: INFO: Mapped hugeseg at > 0x2ac0. Copying 0x220 bytes and 0 extra bytes from > 0x8008a0...done > libhugetlbfs [uber-gamer:31047]: INFO: Prepare succeeded > Failed to map hugepage segment 1: 80-40a0 (errno=12) >

Re: [Libhugetlbfs-devel] Support for Position independent executables.

2009-06-09 Thread David Gibson
orrect at run time when > application is compiled with "pie" flag. Ah, yes of course. In that case, no, libhugetlbfs does not support PIE binaries. Patches welcome, I guess... -- David Gibson| I'll have my music baroque, and my code david AT gibson.d

Re: [Libhugetlbfs-devel] Support for Position independent executables.

2009-05-27 Thread David Gibson
faults while mapping > "writable section" in to hugepage. However without "-pie" flag > program runs. I don't think we've ever considered PIEs, so if anything special needs to be done to support them, then no, they're not supported. -- David Gibson

Re: [Libhugetlbfs-devel] [PATCH] Add -f option to run_test.py to force dangerous tests to run

2009-05-20 Thread David Gibson
ows the user to override this behavior. If -f is specified to > run_tests.py these potentially dangerous tests will be run. Thanks for adding this, Eric. -- David Gibson| I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you

Re: [Libhugetlbfs-devel] [PATCH] Wrapping tests to prevent machinehangs

2009-05-14 Thread David Gibson
On Thu, May 14, 2009 at 08:41:15AM +0100, Eric B. Munson wrote: > On Wed, 13 May 2009, David Gibson wrote: > > > On Wed, May 13, 2009 at 10:35:53AM +0100, Eric B. Munson wrote: > > > The readahead, madvise, and the fadvise tests can all hang the running > > > machin

Re: [Libhugetlbfs-devel] [PATCH] Wrapping tests to prevent machine hangs

2009-05-13 Thread David Gibson
is say something other than just FAIL, as a hint that the tests aren't actually running, just assuming a result from the kernel version. "FAIL (assumed)" maybe? -- David Gibson| I'll have my music baroque, and my code david AT gibson.dropbear.id.au |

Re: [Libhugetlbfs-devel] [PATCH] Rework test suite for multiple huge page size testing

2009-02-01 Thread David Gibson
t came up. Another one which just occurred to me is to have an option for the Python, instead of directly running the testcases to generate a really dumb shell script whose output can then be parsed back into results by the Python (so you can run the Python test script on a full machine, shipping just the

Re: [Libhugetlbfs-devel] Lib hugetlbfs

2009-01-05 Thread David Gibson
y libc functions which would require accessing the PLT. This is sufficient on x86 and powerpc. Apparently there's something different on the MIPS ABI which means that one of the unmapped addresses is being touched in the black-hole zone. We'll have to work out exactly what, and why, a

[Libhugetlbfs-devel] libhugetlbfs: Provide more debug info readback testcase

2008-11-24 Thread David Gibson
x", +i, q[i], RANDOM_CONSTANT ^ i); } PASS(); -- David Gibson| I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_

Re: [Libhugetlbfs-devel] [PATCH] [RFC] Enable automatic testing of multiple huge page sizes

2008-11-19 Thread David Gibson
On Wed, Nov 19, 2008 at 10:19:23AM -0600, Adam Litke wrote: > On Mon, 2008-11-17 at 11:50 +1100, David Gibson wrote: > > On Sat, Nov 15, 2008 at 11:56:54AM +1100, David Gibson wrote: > > > On Fri, Nov 14, 2008 at 10:06:57AM -0600, Adam Litke wrote: > > > > On Fri, 20

Re: [Libhugetlbfs-devel] [PATCH] [RFC] Enable automatic testing of multiple huge page sizes

2008-11-19 Thread David Gibson
On Wed, Nov 19, 2008 at 10:15:13AM -0600, Adam Litke wrote: > On Sat, 2008-11-15 at 11:56 +1100, David Gibson wrote: > > On Fri, Nov 14, 2008 at 10:06:57AM -0600, Adam Litke wrote: > > > On Fri, 2008-11-14 at 17:51 +1100, David Gibson wrote: > > > > On Thu, Nov 13,

Re: [Libhugetlbfs-devel] [PATCH] [RFC] Enable automatic testing of multiple huge page sizes

2008-11-18 Thread David Gibson
ut-down embedded distro for example. > While a dependency on Python could possibly impact a small number of > embedded users, I feel the benefits of a more robust set of tests far > outweigh the downsides of the added dependency. I suspect you're right, but I really want to have

Re: [Libhugetlbfs-devel] [PATCH] [RFC] Enable automatic testing of multiple huge page sizes

2008-11-18 Thread David Gibson
On Mon, Nov 17, 2008 at 04:50:39PM +, Mel Gorman wrote: > On Fri, Nov 14, 2008 at 05:51:29PM +1100, David Gibson wrote: > > On Thu, Nov 13, 2008 at 08:26:12PM +, Adam Litke wrote: [snip] > > Hmm. I was about to say I thought changing to Python was a pretty > > good

Re: [Libhugetlbfs-devel] [PATCH] [RFC] Enable automatic testing of multiple huge page sizes

2008-11-16 Thread David Gibson
On Sat, Nov 15, 2008 at 11:56:54AM +1100, David Gibson wrote: > On Fri, Nov 14, 2008 at 10:06:57AM -0600, Adam Litke wrote: > > On Fri, 2008-11-14 at 17:51 +1100, David Gibson wrote: > > > On Thu, Nov 13, 2008 at 08:26:12PM +, Adam Litke wrote: > [snip] > > > The

Re: [Libhugetlbfs-devel] [PATCH] [RFC] Enable automatic testing of multiple huge page sizes

2008-11-14 Thread David Gibson
On Fri, Nov 14, 2008 at 10:06:57AM -0600, Adam Litke wrote: > On Fri, 2008-11-14 at 17:51 +1100, David Gibson wrote: > > On Thu, Nov 13, 2008 at 08:26:12PM +, Adam Litke wrote: [snip] > > The one big thing that worries me about switching to Python is that it > > introdu

Re: [Libhugetlbfs-devel] [PATCH] [RFC] Enable automatic testing of multiple huge page sizes

2008-11-14 Thread David Gibson
lf. Making it harder to do a thorough test of hugepages on J Random embedded board is a non-trivial drawback. Not sure which way to go on this one. -- David Gibson| I'll have my music baroque, and my code david AT gib

Re: [Libhugetlbfs-devel] [PATCH 1/3] Force get_huge_pages() to only deal with hugepages

2008-11-12 Thread David Gibson
On Wed, Nov 12, 2008 at 12:32:44PM +, Mel Gorman wrote: > On Tue, Nov 11, 2008 at 10:45:08PM +1100, David Gibson wrote: > > On Mon, Nov 10, 2008 at 11:55:31AM +, Mel Gorman wrote: > > > It has been asserted that the name get_huge_pages() implies the API is > > >

Re: [Libhugetlbfs-devel] [PATCH 0/3] Clarify purpose of get_huge_pages() and add get_hugepage_region API V2

2008-11-12 Thread David Gibson
On Wed, Nov 12, 2008 at 12:31:24PM +, Mel Gorman wrote: > On Tue, Nov 11, 2008 at 10:42:02PM +1100, David Gibson wrote: > > On Mon, Nov 10, 2008 at 11:55:30AM +, Mel Gorman wrote: > > > There has been some disagreement on what the exact purpose of > > > get_hu

Re: [Libhugetlbfs-devel] [PATCH 3/3] Use wasted bytes in get_hugepage_region() to place buffers at different cache lines

2008-11-11 Thread David Gibson
would normally be wasted to > offset the buffer by some random cacheline. Effort is made to select a > random cache-line to give good average performance. > > Signed-off-by: Mel Gorman <[EMAIL PROTECTED]> Acked-by: David Gibson <[EMAIL PROTECTED]> -- David Gibson

Re: [Libhugetlbfs-devel] [PATCH 2/3] Add get_hugepage_region() as a malloc-like interface that uses hugepages

2008-11-11 Thread David Gibson
;[EMAIL PROTECTED]> > Acked-by: Adam Litke <[EMAIL PROTECTED]> Apart from the fairly minor naming and description issues discussed in reply to 0/3: Acked-by: David Gibson <[EMAIL PROTECTED]> -- David Gibson| I'll have my music baroque, and my code david AT

Re: [Libhugetlbfs-devel] [PATCH 0/3] Clarify purpose of get_huge_pages() and add get_hugepage_region API V2

2008-11-11 Thread David Gibson
epage malloc() implementation. It's just that this initial version isn't a very good implementationm, at least for space-efficiency. We can fix this deficiency later, if anyone cares enough, without altering the interface. -- David Gibson| I'll have my music ba

Re: [Libhugetlbfs-devel] [PATCH 1/3] Force get_huge_pages() to only deal with hugepages

2008-11-11 Thread David Gibson
s() simple and low-level is why I was dubious about having it fallback to normal pages in the first place. I may not have expressed this thought very well at the time, which might account for why our views of the interface had diverged so greatly this time around. -- David Gibson

Re: [Libhugetlbfs-devel] [PATCH 1/1] Add manual pages for path-related functions

2008-11-09 Thread David Gibson
On Fri, Nov 07, 2008 at 10:08:23AM +, Mel Gorman wrote: > On Fri, Nov 07, 2008 at 09:08:14AM +1100, David Gibson wrote: > > On Thu, Nov 06, 2008 at 11:19:18AM -0600, Adam Litke wrote: > > > On Thu, 2008-11-06 at 16:20 +, Mel Gorman wrote: [snip] > > > I think it

Re: [Libhugetlbfs-devel] [PATCH 2/2] Use wasted bytes in get_huge_pages() to place buffers at different cache lines

2008-11-06 Thread David Gibson
On Thu, Nov 06, 2008 at 10:49:35AM +, Mel Gorman wrote: > On Thu, Nov 06, 2008 at 12:06:23PM +1100, David Gibson wrote: > > On Thu, Nov 06, 2008 at 12:51:54AM +, Mel Gorman wrote: > > > On Thu, Nov 06, 2008 at 10:15:54AM +1100, David Gibson wrote: > > > > On W

Re: [Libhugetlbfs-devel] [PATCH 2/2] Use wasted bytes in get_huge_pages() to place buffers at different cache lines

2008-11-06 Thread David Gibson
be introduced and use of > get_huge_pages deprecated unless you know what you are getting into. That would be just what I'm suggesting... -- David Gibson| I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _

Re: [Libhugetlbfs-devel] [PATCH 1/1] Add manual pages for path-related functions

2008-11-06 Thread David Gibson
ore like anonymous memory (in that the huge > pages are freed after an unmap and the data will not persist) and that > another process cannot open the same fd to snoop data. Uh.. the pages won'tbe freed on unmap, only on close(

Re: [Libhugetlbfs-devel] [PATCH 2/2] Use wasted bytes in get_huge_pages() to place buffers at different cache lines

2008-11-06 Thread David Gibson
On Thu, Nov 06, 2008 at 10:08:27AM -0600, Adam Litke wrote: > On Thu, 2008-11-06 at 10:15 +1100, David Gibson wrote: > > On Wed, Nov 05, 2008 at 09:43:40AM -0600, Adam Litke wrote: > > > On Wed, 2008-11-05 at 14:02 +, Mel Gorman wrote: > > > > @@ -127,6 +140,34

Re: [Libhugetlbfs-devel] [PATCH 2/2] Use wasted bytes in get_huge_pages() to place buffers at different cache lines

2008-11-05 Thread David Gibson
On Thu, Nov 06, 2008 at 12:51:54AM +, Mel Gorman wrote: > On Thu, Nov 06, 2008 at 10:15:54AM +1100, David Gibson wrote: > > On Wed, Nov 05, 2008 at 09:43:40AM -0600, Adam Litke wrote: > > > On Wed, 2008-11-05 at 14:02 +, Mel Gorman wrote: > > > > @@ -127,6 +

Re: [Libhugetlbfs-devel] [PATCH 2/2] Use wasted bytes in get_huge_pages() to place buffers at different cache lines

2008-11-05 Thread David Gibson
() is supposed to be the "raw" low-level interface to just grab some hugepages. Offsetting within the page should be up to the caller, if it cares. -- David Gibson| I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you.

Re: [Libhugetlbfs-devel] [PATCH 2/4] tests: Infrastructure for expected test failures

2008-10-22 Thread David Gibson
as to why things aren't working properly, because you don't see the bogus . directories in ls normally. -- David Gibson| I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_

Re: [Libhugetlbfs-devel] [PATCH 3/3] Get a hugetlbfs fd for a specific page size (V2)

2008-09-10 Thread David Gibson
Removed redundant handling when pagesize argument is zero > > Signed-off-by: Adam Litke <[EMAIL PROTECTED]> Acked-by: David Gibson <[EMAIL PROTECTED]> -- David Gibson| I'll have my music baroque, and my code david AT gibson.dropbear.id.au |

Re: [Libhugetlbfs-devel] [PATCH 2/3] Add new environment variable to specify the default hpage size to use

2008-09-09 Thread David Gibson
s good to me. Acked-by: David Gibson <[EMAIL PROTECTED]> -- David Gibson| I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_

Re: [Libhugetlbfs-devel] [PATCH 1/3] cleanup: Store page sizes in bytes

2008-09-09 Thread David Gibson
TED]> Acked-by: David Gibson <[EMAIL PROTECTED]> -- David Gibson| I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http

Re: [Libhugetlbfs-devel] [PATCH] Get a hugetlbfs fd for a specific page size

2008-09-09 Thread David Gibson
= hpage_sizes[hpage_sizes_default_idx].pagesize; > + > + path = hugetlbfs_find_path_for_size(page_size); Can't you just pass page_size through here, even if it's zero. hugetlbfs_find_path_for_size() already knows how to look up the default page size. -- David Gibson

Re: [Libhugetlbfs-devel] [PATCH] Recover gracefully when ELF remapping fails due to insufficient hugepages

2008-09-08 Thread David Gibson
impact for tests is that remapping tests that > > previously received a SIGKILL or SIGBUS when the hugepage pool was too small > > will instead FAIL with the message "small_bss is not hugepage" or similar. > > > > Signed-off-by: Mel Gorman <[EMAIL PROTECT

[Libhugetlbfs-devel] Cleanup hugepage pagetable allocation for powerpc with 16G pages

2008-09-04 Thread David Gibson
s are allocated at. The new way of formatting the tests should be more robust against changes in pagetable structure, or any newly added hugepage sizes. Signed-off-by: David Gibson <[EMAIL PROTECTED]> --- Paul, please apply for 2.6.28 Index: working-2.6/arch/powerpc/mm/hu

Re: [Libhugetlbfs-devel] Buglet in 16G page handling

2008-09-04 Thread David Gibson
On Thu, Sep 04, 2008 at 04:08:30PM -0500, Jon Tollefson wrote: > Jon Tollefson wrote: > > David Gibson wrote: > > > >> On Tue, Sep 02, 2008 at 12:12:27PM -0500, Jon Tollefson wrote: [snip] > > I have run through the tests twice now with this new patch using a 4k &

Re: [Libhugetlbfs-devel] Buglet in 16G page handling

2008-09-04 Thread David Gibson
On Wed, Sep 03, 2008 at 05:19:27PM -0500, Jon Tollefson wrote: > David Gibson wrote: > > On Tue, Sep 02, 2008 at 12:12:27PM -0500, Jon Tollefson wrote: > > > >> David Gibson wrote: > >> > >>> When BenH and I were looking at the new code for han

Re: [Libhugetlbfs-devel] [PATCH 1/7] Basic support for multiple hugetlbfs mount points

2008-09-02 Thread David Gibson
On Tue, Sep 02, 2008 at 08:54:02AM -0500, Adam Litke wrote: > On Mon, 2008-09-01 at 15:45 +1000, David Gibson wrote: > > On Fri, Aug 29, 2008 at 09:51:35AM -0500, Adam Litke wrote: > > > On Fri, 2008-08-29 at 15:42 +1000, David Gibson wrote: > > > > On Wed, Aug 27,

Re: [Libhugetlbfs-devel] Buglet in 16G page handling

2008-09-02 Thread David Gibson
On Tue, Sep 02, 2008 at 12:12:27PM -0500, Jon Tollefson wrote: > David Gibson wrote: > > When BenH and I were looking at the new code for handling 16G pages, > > we noticed a small bug. It doesn't actually break anything user > > visible, but it's certainly not th

[Libhugetlbfs-devel] Buglet in 16G page handling

2008-09-01 Thread David Gibson
if (!pmd_none(*pm)) @@ -233,7 +241,7 @@ pte_t *huge_pte_alloc(struct mm_struct * addr &= hstate->mask; pg = pgd_offset(mm, addr); - pu = pud_alloc(mm, pg, addr); + pu = hpud_alloc(mm, pg, addr, hstate); if (pu) { pm

Re: [Libhugetlbfs-devel] [PATCH 3/7] tests: Check for mountpoints for 32 and 64 bit apps

2008-09-01 Thread David Gibson
On Fri, Aug 29, 2008 at 09:19:41AM -0500, Adam Litke wrote: > On Fri, 2008-08-29 at 12:25 +1000, David Gibson wrote: > > On Thu, Aug 28, 2008 at 08:51:58AM -0500, Adam Litke wrote: > > > On Thu, 2008-08-28 at 11:44 +1000, David Gibson wrote: > > > > On Wed, Aug 27,

Re: [Libhugetlbfs-devel] [PATCH 1/7] Basic support for multiple hugetlbfs mount points

2008-08-31 Thread David Gibson
On Fri, Aug 29, 2008 at 09:51:35AM -0500, Adam Litke wrote: > On Fri, 2008-08-29 at 15:42 +1000, David Gibson wrote: > > On Wed, Aug 27, 2008 at 06:34:41PM +, Adam Litke wrote: [snip] > > Hrm. Something about the structure of all this bothers me, but I'm > > going

Re: [Libhugetlbfs-devel] [PATCH 2/2] Allow users to override feature detection

2008-08-31 Thread David Gibson
On Fri, Aug 29, 2008 at 09:57:10AM -0500, Adam Litke wrote: > On Fri, 2008-08-29 at 15:43 +1000, David Gibson wrote: > > On Wed, Aug 27, 2008 at 09:39:29PM +, Adam Litke wrote: > > > In some cases (such as a distro kernel with backported features) > > > libhugetlbf

Re: [Libhugetlbfs-devel] [PATCH 2/2] Allow users to override feature detection

2008-08-28 Thread David Gibson
nvironment variable which has a list of those strings to switch the features. -- David Gibson| I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_

Re: [Libhugetlbfs-devel] [PATCH 1/7] Basic support for multiple hugetlbfs mount points

2008-08-28 Thread David Gibson
rsion. Possibly a function to change the default pagesize (from amongst the available ones) at runtime too. Like I say, need to think about this some more. -- David Gibson| I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you.

Re: [Libhugetlbfs-devel] [PATCH 3/7] tests: Check for mountpoints for 32 and 64 bit apps

2008-08-28 Thread David Gibson
On Thu, Aug 28, 2008 at 08:51:58AM -0500, Adam Litke wrote: > On Thu, 2008-08-28 at 11:44 +1000, David Gibson wrote: > > On Wed, Aug 27, 2008 at 06:34:54PM +, Adam Litke wrote: > > > It is now possible for 32 and 64 bit applications to require different > > > mount

Re: [Libhugetlbfs-devel] [PATCH 3/7] tests: Check for mountpoints for 32 and 64 bit apps

2008-08-27 Thread David Gibson
re available. So rather than attempting to find a single pagesize/mountpoint for each wordsize, we should instead attempt to run through the whole testsuite for each pagesize. Then it's just a matter of not running the 32-bit tests when we're doing a run on pagesize that's too big. --

[Libhugetlbfs-devel] Multiple hugepagesize support

2008-08-25 Thread David Gibson
What's the state of the support for multiple hugepage sizes / multiple mountpoints in libhugetlbfs? I remember patches going past, but AFAICT it's not in the mainline git as yet. I'd like to do some testing of the kernel multiple size support using the libhugetlbfs testsuite. -

Re: [Libhugetlbfs-devel] libhugetlbfs: Print summary of testsuite results

2008-08-20 Thread David Gibson
On Wed, Aug 20, 2008 at 11:39:54AM +0100, Mel Gorman wrote: > On (20/08/08 13:59), David Gibson didst pronounce: > > This patch adds some tracking to the run_tests script which counts the > > total number of tests, and the number of passes, failures and other > > results.

[Libhugetlbfs-devel] libhugetlbfs: Print summary of testsuite results

2008-08-19 Thread David Gibson
This patch adds some tracking to the run_tests script which counts the total number of tests, and the number of passes, failures and other results. This is printed as a summary once the script is finished, so you can see at a glance if the tests ran clean or not. Signed-off-by: David Gibson

  1   2   3   4   5   >