[Libreoffice-bugs] [Bug 116944] Firebird-migration must happen only after user consent and advise to backup data prior to migration at 6.1

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116944

--- Comment #20 from V Stuart Foote  ---
(In reply to Florian Reisinger from comment #19)
> 
> Doing to automatically won't work as the user might not have permission to
> create a new file.
> 
> I honestly do not believe that a backup without user involvement is possible
> 
> Still looking forward to answers to #15

Removal of HSQLDB and the Firebird migration was reviewed at ESC today [1] and
backed out [2], if it can be redone near term it will instead be optional at
6.1 with just NEW Base ODF using Firebird. This evenings builds of master have
HSQLDB restored.

=-ref-=
[1]
http://nabble.documentfoundation.org/Libreoffice-qa-minutes-of-ESC-call-td4237769.html
[2] https://gerrit.libreoffice.org/#/c/52731/

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 116944] Firebird-migration must happen only after user consent and advise to backup data prior to migration at 6.1

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116944

--- Comment #20 from V Stuart Foote  ---
(In reply to Florian Reisinger from comment #19)
> 
> Doing to automatically won't work as the user might not have permission to
> create a new file.
> 
> I honestly do not believe that a backup without user involvement is possible
> 
> Still looking forward to answers to #15

Removal of HSQLDB and the Firebird migration was reviewed at ESC today [1] and
backed out [2], if it can be redone near term it will instead be optional at
6.1 with just NEW Base ODF using Firebird. This evenings builds of master have
HSQLDB restored.

=-ref-=
[1]
http://nabble.documentfoundation.org/Libreoffice-qa-minutes-of-ESC-call-td4237769.html
[2] https://gerrit.libreoffice.org/#/c/52731/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 116944] Firebird-migration must happen only after user consent and advise to backup data prior to migration at 6.1

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116944

--- Comment #19 from Florian Reisinger  ---
(In reply to jonathon from comment #18)
> If it is going to automatically convert the database, could the first step
> in the conversion process be copying the file from filename.odb to
> filename.HSQLDB.date.time.odb.
> The second step would be converting filename.odb to
> filename.firebird.date.time.odb.
> The third step would be to copy filename.firebird.date.time.odb to
> filename.odb.
> All done with no user interaction.

Doing to automatically won't work as the user might not have permission to
create a new file.

I honestly do not believe that a backup without user involvement is possible

Still looking forward to answers to #15

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 116944] Firebird-migration must happen only after user consent and advise to backup data prior to migration at 6.1

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116944

--- Comment #19 from Florian Reisinger  ---
(In reply to jonathon from comment #18)
> If it is going to automatically convert the database, could the first step
> in the conversion process be copying the file from filename.odb to
> filename.HSQLDB.date.time.odb.
> The second step would be converting filename.odb to
> filename.firebird.date.time.odb.
> The third step would be to copy filename.firebird.date.time.odb to
> filename.odb.
> All done with no user interaction.

Doing to automatically won't work as the user might not have permission to
create a new file.

I honestly do not believe that a backup without user involvement is possible

Still looking forward to answers to #15

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-commits] core.git: chart2/source cui/source oox/source

[Tomaž Vajngerl]

 chart2/source/controller/chartapiwrapper/WrappedSymbolProperties.cxx |2 --
 cui/source/inc/SvxMenuConfigPage.hxx |1 -
 cui/source/inc/SvxToolbarConfigPage.hxx  |1 -
 oox/source/drawingml/scene3dcontext.cxx  |1 -
 4 files changed, 5 deletions(-)

New commits:
commit 55e84652ae84bd2374462ee19afd359a8cc90b95
Author: Tomaž Vajngerl 
Date:   Thu Apr 12 14:35:51 2018 +0900

Remove XGraphicProvider imports where they aren't needed

Change-Id: Ie4da74e7d58d49aa870a70c4279cbab22f0f7746
Reviewed-on: https://gerrit.libreoffice.org/52805
Tested-by: Jenkins 
Reviewed-by: Tomaž Vajngerl 

diff --git 
a/chart2/source/controller/chartapiwrapper/WrappedSymbolProperties.cxx 
b/chart2/source/controller/chartapiwrapper/WrappedSymbolProperties.cxx
index 8f0986b36d99..a0bd74b8c82b 100644
--- a/chart2/source/controller/chartapiwrapper/WrappedSymbolProperties.cxx
+++ b/chart2/source/controller/chartapiwrapper/WrappedSymbolProperties.cxx
@@ -27,8 +27,6 @@
 #include 
 #include 
 #include 
-#include 
-#include 
 
 #include 
 #include 
diff --git a/cui/source/inc/SvxMenuConfigPage.hxx 
b/cui/source/inc/SvxMenuConfigPage.hxx
index f944ce36161e..ea514712b5cc 100644
--- a/cui/source/inc/SvxMenuConfigPage.hxx
+++ b/cui/source/inc/SvxMenuConfigPage.hxx
@@ -34,7 +34,6 @@
 #include 
 #include 
 #include 
-#include 
 #include 
 #include 
 #include 
diff --git a/cui/source/inc/SvxToolbarConfigPage.hxx 
b/cui/source/inc/SvxToolbarConfigPage.hxx
index 2129db9801cb..f79f3ef0fd4e 100644
--- a/cui/source/inc/SvxToolbarConfigPage.hxx
+++ b/cui/source/inc/SvxToolbarConfigPage.hxx
@@ -34,7 +34,6 @@
 #include 
 #include 
 #include 
-#include 
 #include 
 #include 
 #include 
diff --git a/oox/source/drawingml/scene3dcontext.cxx 
b/oox/source/drawingml/scene3dcontext.cxx
index 32d4702b2dea..056a692f4411 100644
--- a/oox/source/drawingml/scene3dcontext.cxx
+++ b/oox/source/drawingml/scene3dcontext.cxx
@@ -19,7 +19,6 @@
 
 #include 
 #include 
-#include 
 #include 
 #include 
 #include 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 107106] TOC Update while printing / PDF export of document with hidden paraghraphs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107106

--- Comment #5 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 60168] Cursor pauses when navigating within unprotected area surrounded by protected region

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=60168

--- Comment #6 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 68326] FILEOPEN: Bad table in docx generated from bank (" EmptyCellLayoutStyle" not created)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=68326

--- Comment #13 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-6-0' - cui/source include/svtools

[Katarina Behrens]

 cui/source/inc/treeopt.hxx|   13 +++--
 cui/source/options/optjava.cxx|   22 +-
 cui/source/options/optjava.hxx|4 
 cui/source/options/treeopt.cxx|   20 +++-
 include/svtools/restartdialog.hxx |2 ++
 5 files changed, 49 insertions(+), 12 deletions(-)

New commits:
commit f8d654bba844050a01a232eb8013561da57ed6e0
Author: Katarina Behrens 
Date:   Thu Mar 1 12:23:21 2018 +0100

After Java settings have changed, restart LibO for real

Previously restart LibO dialog was shown, but did nothing. I haven't
found an easy way to close all frames with 3 modal dialogs opened, so
now restart dialog simply pops up later (after user bonks OK button
on Tools > Options dialog)

Change-Id: I6e61fa1fc41199c2f16cb80da771202c255f3810
Reviewed-on: https://gerrit.libreoffice.org/50566
Tested-by: Jenkins 
Reviewed-by: Katarina Behrens 
(cherry picked from commit 683a68cb5106e99db0fbe892b5784d837cf8cb27)
Reviewed-on: https://gerrit.libreoffice.org/50829
Reviewed-by: Noel Grandin 
Reviewed-by: Thorsten Behrens 

diff --git a/cui/source/inc/treeopt.hxx b/cui/source/inc/treeopt.hxx
index efad9eb74137..29870a16bc88 100644
--- a/cui/source/inc/treeopt.hxx
+++ b/cui/source/inc/treeopt.hxx
@@ -24,6 +24,8 @@
 
 #include 
 
+#include 
+#include 
 #include 
 
 class SfxModule;
@@ -129,14 +131,16 @@ class SvxColorTabPage;
 class OfaTreeOptionsDialog final: public SfxModalDialog
 {
 private:
-SvTreeListEntry*pCurrentPageEntry;
-
 VclPtr   pOkPB;
 VclPtr pBackPB;
 
 VclPtr  pTreeLB;
 VclPtr pTabBox;
 
+VclPtrm_pParent;
+
+SvTreeListEntry*   pCurrentPageEntry;
+
 OUString   sTitle;
 OUString   sNotLoadedError;
 
@@ -146,6 +150,9 @@ private:
 // check "for the current document only" and set focus to "Western" 
languages box
 bool   bIsForSetDocumentLanguage;
 
+bool   bNeedsRestart;
+svtools::RestartReason eRestartReason;
+
 css::uno::Reference < css::awt::XContainerWindowProvider >
 m_xContainerWinProvider;
 
@@ -192,6 +199,8 @@ public:
 
 // helper functions to call the language settings TabPage from the 
SpellDialog
 static void ApplyLanguageOptions(const SfxItemSet& rSet);
+
+voidSetNeedsRestart( svtools::RestartReason eReason );
 };
 
 // class ExtensionsTabPage ---
diff --git a/cui/source/options/optjava.cxx b/cui/source/options/optjava.cxx
index b3443d7734c4..150a13011480 100644
--- a/cui/source/options/optjava.cxx
+++ b/cui/source/options/optjava.cxx
@@ -26,6 +26,7 @@
 
 #include "optaboutconfig.hxx"
 #include "optjava.hxx"
+#include 
 #include 
 
 #include 
@@ -126,6 +127,7 @@ SvxJavaOptionsPage::SvxJavaOptionsPage( vcl::Window* 
pParent, const SfxItemSet&
 get(m_pExperimentalCB, "experimental");
 get(m_pMacroCB, "macrorecording");
 get(m_pExpertConfigBtn, "expertconfig");
+m_pParentDlg.reset( 
dynamic_cast(getNonLayoutParent(pParent)) );
 m_sAccessibilityText = get("a11y")->GetText();
 m_sAddDialogText = get("selectruntime")->GetText();
 
@@ -192,6 +194,7 @@ void SvxJavaOptionsPage::dispose()
 
 jfw_unlock();
 #endif
+m_pParentDlg.clear();
 m_pJavaEnableCB.clear();
 m_pJavaBox.clear();
 m_pJavaPathText.clear();
@@ -287,8 +290,7 @@ IMPL_LINK_NOARG(SvxJavaOptionsPage, ParameterHdl_Impl, 
Button*, void)
 aParameterList = m_pParamDlg->GetParameters();
 if ( jfw_isVMRunning() )
 {
-SolarMutexGuard aGuard;
-
svtools::executeRestartDialog(comphelper::getProcessComponentContext(), 
nullptr, svtools::RESTART_REASON_ASSIGNING_JAVAPARAMETERS);
+RequestRestart( 
svtools::RESTART_REASON_ASSIGNING_JAVAPARAMETERS );
 }
 }
 }
@@ -327,8 +329,7 @@ IMPL_LINK_NOARG(SvxJavaOptionsPage, ClassPathHdl_Impl, 
Button*, void)
 sClassPath = m_pPathDlg->GetClassPath();
 if ( jfw_isVMRunning() )
 {
-SolarMutexGuard aGuard;
-
svtools::executeRestartDialog(comphelper::getProcessComponentContext(), 
nullptr, svtools::RESTART_REASON_ASSIGNING_FOLDERS);
+RequestRestart( svtools::RESTART_REASON_ASSIGNING_FOLDERS );
 }
 }
 }
@@ -559,6 +560,12 @@ void SvxJavaOptionsPage::AddFolder( const OUString& 
_rFolder )
 #endif
 }
 
+void SvxJavaOptionsPage::RequestRestart( svtools::RestartReason eReason )
+{
+if ( m_pParentDlg )
+m_pParentDlg->SetNeedsRestart( eReason );
+}
+
 
 VclPtr SvxJavaOptionsPage::Create( vcl::Window* pParent, const 
SfxItemSet* rAttrSet )
 {
@@ -575,8 +582,7 @@ bool 

Infra call on Tue, Apr 17 at 16:30 UTC

[Guilhem Moulin]

Hi there,

The next infra call will take place at `date -d 'Tue Apr 17 16:30:00 UTC 2018'`
(18:30:00 Berlin time).

See https://pad.documentfoundation.org/p/infra for details; agenda TBA.

See you there!
Cheers,
-- 
Guilhem.


signature.asc
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 116981] EDITING: Libo6.1 crash when deleting table column

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116981

--- Comment #2 from Drew Jensen  ---
Created attachment 141319
  --> https://bugs.documentfoundation.org/attachment.cgi?id=141319=edit
crash report

Ah, so I remembered where the crash report dump files are. Assuming you still
want those attached.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116981] EDITING: Libo6.1 crash when deleting table column

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116981

--- Comment #1 from Drew Jensen  ---
Created attachment 141318
  --> https://bugs.documentfoundation.org/attachment.cgi?id=141318=edit
file after crash; before recovery

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116981] New: EDITING: Libo6.1 crash when deleting table column

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116981

Bug ID: 116981
   Summary: EDITING: Libo6.1 crash when deleting table column
   Product: LibreOffice
   Version: 6.1.0.0.alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Base
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: drewjensen.in...@gmail.com

Created attachment 141317
  --> https://bugs.documentfoundation.org/attachment.cgi?id=141317=edit
test file to reproduce crash

Testing with 6.1_alpha0 (daily build yesterday), Ubuntu 17.10 64bit

To reproduce: grabbed the first attached file.
Open it.
Open the table TaskEmployees
Select column TaskID (or any other)
Delete the column (delete key or menu delete act the same)
LibO crashes

Tested on Libo6.0.4 w/embedded firebird; No problems.

Second attachment is a copy of the ODB file before recovery. Sent crash
reports, I don't remember how to tie that directly to an issue here.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 92009] WIKIHELP Missing files in help

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=92009

Dennis Roczek  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 80430] [META] LOCALHELP: Features x Documentation gap

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=80430
Bug 80430 depends on bug 92009, which changed state.

Bug 92009 Summary: WIKIHELP Missing files in help
https://bugs.documentfoundation.org/show_bug.cgi?id=92009

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116944] Firebird-migration must happen only after user consent and advise to backup data prior to migration at 6.1

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116944

--- Comment #18 from jonathon  ---
If it is going to automatically convert the database, could the first step in
the conversion process be copying the file from filename.odb to
filename.HSQLDB.date.time.odb.
The second step would be converting filename.odb to
filename.firebird.date.time.odb.
The third step would be to copy filename.firebird.date.time.odb to
filename.odb.
All done with no user interaction.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 116944] Firebird-migration must happen only after user consent and advise to backup data prior to migration at 6.1

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116944

--- Comment #18 from jonathon  ---
If it is going to automatically convert the database, could the first step in
the conversion process be copying the file from filename.odb to
filename.HSQLDB.date.time.odb.
The second step would be converting filename.odb to
filename.firebird.date.time.odb.
The third step would be to copy filename.firebird.date.time.odb to
filename.odb.
All done with no user interaction.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 116961] EDITING - Calc crashes like a blazing blimp when pasting cut cells into whole column.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116961

Xisco Faulí  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||xiscofa...@libreoffice.org
 Ever confirmed|0   |1

--- Comment #1 from Xisco Faulí  ---
I can't reproduce it in

Version: 6.1.0.0.alpha0+
Build ID: dfefe448c41921f2f1e54d3f69b8b9e89031d055
CPU threads: 4; OS: Linux 4.13; UI render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); Calc: group

Could you please paste the info from Help - about LibreOffice ?

I have set the bug's status to 'NEEDINFO'. Please change it back to
'UNCONFIRMED' once the information has been provided

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116957] Necessary correction

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116957

--- Comment #2 from Sergyj  ---
I'm sorry, the software update did not offer updates for this product.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108580] Cannot run LibreOffice, api-ms-win-crt-runtime-l1-1-0.dll is missing ( for local solution see comment 7)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108580

--- Comment #47 from Commit Notification 
 ---
Mike Kaganski committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=1f8a3657216e44796cb94087450552aa977ebdae

tdf#108580 related: improve existing redist detection

It will be available in 6.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: instsetoo_native/inc_openoffice scp2/source solenv/bin

[Mike Kaganski]

 instsetoo_native/inc_openoffice/windows/msi_templates/AppSearc.idt |4 +--
 instsetoo_native/inc_openoffice/windows/msi_templates/DrLocato.idt |2 +
 instsetoo_native/inc_openoffice/windows/msi_templates/Property.idt |2 -
 instsetoo_native/inc_openoffice/windows/msi_templates/RegLocat.idt |2 -
 instsetoo_native/inc_openoffice/windows/msi_templates/Signatur.idt |9 
+++
 scp2/source/ooo/vc_redist.scp  |6 -
 solenv/bin/modules/installer/windows/upgrade.pm|   12 
++
 7 files changed, 27 insertions(+), 10 deletions(-)

New commits:
commit 1f8a3657216e44796cb94087450552aa977ebdae
Author: Mike Kaganski 
Date:   Thu Apr 12 15:18:58 2018 +0300

tdf#108580 related: improve existing redist detection

This uses VC Runtime upgrade code (checked using Upgrade table) to
find installed redist, instead of checking registry keys that change
between versions (while the runtime is still compatible, as with 2015
and 2017).
Also, it checks if UCRT is present. Now, if either VC Runtime or UCRT
is absent, we try to install the redist. This would allow to install
UCRT in scenarios when first install was attempted on a system not
suitable for UCRT (like Win7 w/o SP1, or Win8.1 w/o April 2014 update
rollup), where VC Runtime gets installed, but UCRT is still missing.
We use the ucrtbase.dll version to check that; and as the expected
version is 10.x, we take into account that Win10 lies about versions.

Change-Id: I864dfc09cf1bdc775501729fa2a27dc98295588c
Reviewed-on: https://gerrit.libreoffice.org/52794
Tested-by: Jenkins 
Reviewed-by: Mike Kaganski 

diff --git a/instsetoo_native/inc_openoffice/windows/msi_templates/AppSearc.idt 
b/instsetoo_native/inc_openoffice/windows/msi_templates/AppSearc.idt
index 60793dd69ded..23c2a77c9f5d 100644
--- a/instsetoo_native/inc_openoffice/windows/msi_templates/AppSearc.idt
+++ b/instsetoo_native/inc_openoffice/windows/msi_templates/AppSearc.idt
@@ -5,6 +5,6 @@ INSTALLLOCATION installuser
 INSTALLLOCATIONinstalluser_
 INSTALLLOCATIONinstallmachine
 INSTALLLOCATIONinstallmachine_
-VCREDISTINSTALLED_X86  VCREDISTINSTALLED_X86
-VCREDISTINSTALLED_X64  VCREDISTINSTALLED_X64
 WIN81S14   win81s14
+UCRT_DETECTED  ucrt_detected
+UCRT_DETECTED  ucrt_on_win10
diff --git a/instsetoo_native/inc_openoffice/windows/msi_templates/DrLocato.idt 
b/instsetoo_native/inc_openoffice/windows/msi_templates/DrLocato.idt
index 589ab7c52806..399011e166ca 100644
--- a/instsetoo_native/inc_openoffice/windows/msi_templates/DrLocato.idt
+++ b/instsetoo_native/inc_openoffice/windows/msi_templates/DrLocato.idt
@@ -2,3 +2,5 @@ Signature_  Parent  PathDepth
 s72S72 S255I2
 DrLocator  Signature_  Parent  Path
 win81s14   [SystemFolder]  
+ucrt_detected  [SystemFolder]  
+ucrt_on_win10  [SystemFolder]  
diff --git a/instsetoo_native/inc_openoffice/windows/msi_templates/Property.idt 
b/instsetoo_native/inc_openoffice/windows/msi_templates/Property.idt
index f8eeaf25c105..2b633b8eb37a 100644
--- a/instsetoo_native/inc_openoffice/windows/msi_templates/Property.idt
+++ b/instsetoo_native/inc_openoffice/windows/msi_templates/Property.idt
@@ -44,7 +44,7 @@ ProgressType3 installs
 Quickstarterlinkname   QUICKSTARTERLINKNAMETEMPLATE
 RebootYesNoYes
 ReinstallModeText  omus
-SecureCustomProperties NEWPRODUCTS;OLDPRODUCTS
+SecureCustomProperties NEWPRODUCTS;OLDPRODUCTS;VCRUNTIME_DETECTED
 SetupType  Typical
 SELECT_WORD0
 SELECT_EXCEL   0
diff --git a/instsetoo_native/inc_openoffice/windows/msi_templates/RegLocat.idt 
b/instsetoo_native/inc_openoffice/windows/msi_templates/RegLocat.idt
index 7e59ef3c6663..c082322086ad 100644
--- a/instsetoo_native/inc_openoffice/windows/msi_templates/RegLocat.idt
+++ b/instsetoo_native/inc_openoffice/windows/msi_templates/RegLocat.idt
@@ -5,5 +5,3 @@ installuser 1   
Software\LibreOffice\Layers\[DEFINEDPRODUCT]\[BRANDPACKAGEVERSION]
 installuser_   1   
Software\LibreOffice\Layers_\[DEFINEDPRODUCT]\[BRANDPACKAGEVERSION] 
INSTALLLOCATION 2
 installmachine 2   
Software\LibreOffice\Layers\[DEFINEDPRODUCT]\[BRANDPACKAGEVERSION]  
INSTALLLOCATION 2
 installmachine_2   
Software\LibreOffice\Layers_\[DEFINEDPRODUCT]\[BRANDPACKAGEVERSION] 
INSTALLLOCATION 2
-VCREDISTINSTALLED_X86  2   
Software\Microsoft\VisualStudio\14.0\VC\Runtimes\x86Version 2
-VCREDISTINSTALLED_X64  2   
Software\Microsoft\VisualStudio\14.0\VC\Runtimes\x64Version 2
diff --git a/instsetoo_native/inc_openoffice/windows/msi_templates/Signatur.idt 
b/instsetoo_native/inc_openoffice/windows/msi_templates/Signatur.idt
index d5abd9769125..53615298dc6d 100644
--- a/instsetoo_native/inc_openoffice/windows/msi_templates/Signatur.idt
+++ 

[Libreoffice-commits] core.git: officecfg/registry

[andreas kainz]

 officecfg/registry/data/org/openoffice/Office/UI/CalcCommands.xcu |3 +++
 1 file changed, 3 insertions(+)

New commits:
commit 915533369ed5eec66b641fb961616cc76151ad8d
Author: andreas kainz 
Date:   Thu Apr 12 17:17:55 2018 +0200

NB Implementation: shorter label for conditional formating

Change-Id: Ic4298ad60cb39b5ca844cd47da44f811dd625df7
Reviewed-on: https://gerrit.libreoffice.org/52786
Tested-by: Jenkins 
Reviewed-by: andreas_kainz 

diff --git a/officecfg/registry/data/org/openoffice/Office/UI/CalcCommands.xcu 
b/officecfg/registry/data/org/openoffice/Office/UI/CalcCommands.xcu
index 4b979bf0a607..a01b054f0144 100644
--- a/officecfg/registry/data/org/openoffice/Office/UI/CalcCommands.xcu
+++ b/officecfg/registry/data/org/openoffice/Office/UI/CalcCommands.xcu
@@ -490,6 +490,9 @@
 
   C~onditional Formatting
 
+
+  C~onditional
+
 
   1
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 116944] Firebird-migration must happen only after user consent and advise to backup data prior to migration at 6.1

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116944

--- Comment #17 from rob...@familiegrosskopf.de ---
(In reply to V Stuart Foote from comment #16)
> Who said ANYTHING about the migration engine being backported to a 6.0
> release?
> 
Okay, have understand it the wrong way while reading about bugs migration from
HSQLDB to Firebird. Only 6.1.0.0.alpha0 will automatically migrate the
databases.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 116944] Firebird-migration must happen only after user consent and advise to backup data prior to migration at 6.1

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116944

--- Comment #17 from rob...@familiegrosskopf.de ---
(In reply to V Stuart Foote from comment #16)
> Who said ANYTHING about the migration engine being backported to a 6.0
> release?
> 
Okay, have understand it the wrong way while reading about bugs migration from
HSQLDB to Firebird. Only 6.1.0.0.alpha0 will automatically migrate the
databases.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 103182] [META] GTK3-specific bugs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103182

Xisco Faulí  changed:

   What|Removed |Added

 Depends on|116977  |


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=116977
[Bug 116977] CRASH: LibreOffice crashes being closed with content in the
clipboard
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116977] CRASH: LibreOffice crashes being closed with content in the clipboard

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116977

Xisco Faulí  changed:

   What|Removed |Added

 Blocks|103182  |
Summary|CRASH: LibreOffice crashes  |CRASH: LibreOffice crashes
   |being closed with content   |being closed with content
   |in the clipboard (gtk3) |in the clipboard


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103182
[Bug 103182] [META] GTK3-specific bugs
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116930] Calc crashes when scrolling in a worksheet containing a Chart object

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116930

--- Comment #6 from Xisco Faulí  ---
Please attach a sample document, as this makes it easier for us to verify the
bug. 
(Please note that the attachment will be public, remove any sensitive
information before attaching it. 
See
https://wiki.documentfoundation.org/QA/FAQ#How_can_I_eliminate_confidential_data_from_a_sample_document.3F
for help on how to do so.)

I have set the bug's status to 'NEEDINFO'. Please change it back to
'UNCONFIRMED' once the requested document is provided.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: helpcontent2

[Olivier Hallot]

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 2d128d7373ff7fc7df3bc38c577aff671ba4cd17
Author: Olivier Hallot 
Date:   Thu Apr 12 16:51:24 2018 -0300

Updated core
Project: help  934da888b80ebbf654e6cff797727d332eebaf6a

Better TDF video for new help

Found better TDF video to display in module help entry pages

Change-Id: I0ca17c975e28a20467752fa07d64617ee1c7a2bf
Reviewed-on: https://gerrit.libreoffice.org/52800
Tested-by: Jenkins 
Reviewed-by: Olivier Hallot 
Tested-by: Olivier Hallot 

diff --git a/helpcontent2 b/helpcontent2
index 2c5257ffbfa0..934da888b80e 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 2c5257ffbfa02e432a80f37fdfe6c9aa3280c873
+Subproject commit 934da888b80ebbf654e6cff797727d332eebaf6a
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 116944] Firebird-migration must happen only after user consent and advise to backup data prior to migration at 6.1

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116944

--- Comment #16 from V Stuart Foote  ---
Who said ANYTHING about the migration engine being backported to a 6.0 release?

Deprecation notice needs to have gone in to the 6.0 release notes (and probably
should have gone in to the 5.4 release notes--given the TDF Tender approval).

This change only affects master toward a 6.1.0 (RC1 ~ July 2018).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 116944] Firebird-migration must happen only after user consent and advise to backup data prior to migration at 6.1

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116944

--- Comment #16 from V Stuart Foote  ---
Who said ANYTHING about the migration engine being backported to a 6.0 release?

Deprecation notice needs to have gone in to the 6.0 release notes (and probably
should have gone in to the 5.4 release notes--given the TDF Tender approval).

This change only affects master toward a 6.1.0 (RC1 ~ July 2018).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-commits] help.git: 2 commits - source/text

[Olivier Hallot]

 source/text/sbasic/guide/translation.xhp |4 ++--
 source/text/sbasic/shared/01050300.xhp   |4 ++--
 source/text/scalc/01/12090102.xhp|2 +-
 source/text/schart/01/0403.xhp   |8 
 source/text/schart/01/0405.xhp   |8 
 source/text/schart/01/05020201.xhp   |8 
 source/text/shared/06/youtubevideos.xhp  |2 +-
 7 files changed, 18 insertions(+), 18 deletions(-)

New commits:
commit 934da888b80ebbf654e6cff797727d332eebaf6a
Author: Olivier Hallot 
Date:   Thu Apr 12 16:51:24 2018 -0300

Better TDF video for new help

Found better TDF video to display in module help entry pages

Change-Id: I0ca17c975e28a20467752fa07d64617ee1c7a2bf
Reviewed-on: https://gerrit.libreoffice.org/52800
Tested-by: Jenkins 
Reviewed-by: Olivier Hallot 
Tested-by: Olivier Hallot 

diff --git a/source/text/shared/06/youtubevideos.xhp 
b/source/text/shared/06/youtubevideos.xhp
index 87781279d..b346a5f68 100644
--- a/source/text/shared/06/youtubevideos.xhp
+++ b/source/text/shared/06/youtubevideos.xhp
@@ -17,7 +17,7 @@
 
 
 
-   https://www.youtube-nocookie.com/embed/3KC0ZdcA6s8?rel=0; 
id="vid_id61521568603544" type="video/youtube" width="560" height="315" 
/>
+https://www.youtube-nocookie.com/embed/YHBve8v13VY; 
id="vid_id61521568603544" type="video/youtube" width="560" height="315" 
/>
 
 
 
commit 2c5257ffbfa02e432a80f37fdfe6c9aa3280c873
Author: Olivier Hallot 
Date:   Thu Apr 12 16:50:15 2018 -0300

tdf#94438 disambiguate bookmark branches (iii)

Change-Id: I4953a00750c9f7a5aa65aff01232a66e0ad360fc
Reviewed-on: https://gerrit.libreoffice.org/52799
Tested-by: Jenkins 
Reviewed-by: Olivier Hallot 
Tested-by: Olivier Hallot 

diff --git a/source/text/sbasic/guide/translation.xhp 
b/source/text/sbasic/guide/translation.xhp
index cfc81244c..903a1918d 100644
--- a/source/text/sbasic/guide/translation.xhp
+++ b/source/text/sbasic/guide/translation.xhp
@@ -39,7 +39,7 @@
 By default, 
any dialog that you create only contains string resources for one language. You 
may want to create dialogs that automatically show localized strings according 
to the user's language settings.
 Select the language for the 
strings that you want to edit. Click the Manage Languages icon to add 
languages.Manage Language icon is in 
sbasic/shared/02/2000.xhp
 
-Click a language, then 
click Default to set the language as default, or click Delete to remove the 
language from the list.
+Click a language, then 
click Default to set the language as default, or click Delete to remove the 
language from the list.
 Opens a dialog where you 
can add a language to the list.
 Select a language in the 
list and click Delete to remove that language. When you remove all languages, 
the string resources for localizable dialogs are removed from all dialogs in 
the current library.
 Select a language in the 
list and click Default to set the language as default 
language.
@@ -53,7 +53,7 @@
 If the current 
library already contains a localizable dialog, the Language toolbar is shown 
automatically.
 
 
-Click the 
Manage Languages icon 
+Click the 
Manage Languages icon
 Manage Language 
icon
 on the Language toolbar or on the Toolbox bar.
 You see the 
Manage User Interface Language dialog. The dialog manages languages for the 
current library. The name of the current library is shown on the title 
bar.
diff --git a/source/text/sbasic/shared/01050300.xhp 
b/source/text/sbasic/shared/01050300.xhp
index cc957d5ae..5dbe845c6 100644
--- a/source/text/sbasic/shared/01050300.xhp
+++ b/source/text/sbasic/shared/01050300.xhp
@@ -18,7 +18,7 @@
  *   except in compliance with the License. You may obtain a copy of
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  -->
-   
+
 
 
 
@@ -37,7 +37,7 @@
 Manage 
Breakpoints
 Specifies 
the options for breakpoints.
 
-
+
 Breakpoints
 Enter the line number for a 
new breakpoint, then click New.
 
diff --git a/source/text/scalc/01/12090102.xhp 
b/source/text/scalc/01/12090102.xhp
index 27e92f91e..f7c574b1b 100644
--- a/source/text/scalc/01/12090102.xhp
+++ b/source/text/scalc/01/12090102.xhp
@@ -31,7 +31,7 @@
 pivot table function;drill down
 
 
-
+
 Pivot 
Table
   Specify the layout of the table that is generated by 
the pivot table.
   
diff --git a/source/text/schart/01/0403.xhp 
b/source/text/schart/01/0403.xhp
index 86d507377..16ba92355 100644
--- a/source/text/schart/01/0403.xhp
+++ b/source/text/schart/01/0403.xhp
@@ -1,6 +1,6 @@
 
 
-   
+
 
- 
-   
+
+
 
   
  Data Labels 
@@ -35,7 +35,7 @@
 
 
 
-
+
 
  Data Labels
 
diff --git 

[Libreoffice-commits] core.git: helpcontent2

[Olivier Hallot]

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 8c70bdcb193161d27724893371999c53a5f8d356
Author: Olivier Hallot 
Date:   Thu Apr 12 16:50:15 2018 -0300

Updated core
Project: help  2c5257ffbfa02e432a80f37fdfe6c9aa3280c873

tdf#94438 disambiguate bookmark branches (iii)

Change-Id: I4953a00750c9f7a5aa65aff01232a66e0ad360fc
Reviewed-on: https://gerrit.libreoffice.org/52799
Tested-by: Jenkins 
Reviewed-by: Olivier Hallot 
Tested-by: Olivier Hallot 

diff --git a/helpcontent2 b/helpcontent2
index c81535cf7d90..2c5257ffbfa0 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit c81535cf7d904c8c7625d66d3ba67f36f9d07f59
+Subproject commit 2c5257ffbfa02e432a80f37fdfe6c9aa3280c873
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] help.git: source/text

[Olivier Hallot]

 source/text/shared/00/0001.xhp  |2 
 source/text/shared/00/0101.xhp  |4 
 source/text/shared/01/0207.xhp  |   98 ++--
 source/text/shared/01/0210.xhp  |2 
 source/text/shared/01/0218.xhp  |2 
 source/text/shared/01/0225.xhp  |8 -
 source/text/shared/01/05230500.xhp  |6 -
 source/text/shared/01/06140500.xhp  |2 
 source/text/shared/01/06150120.xhp  |2 
 source/text/shared/01/password_dlg.xhp  |2 
 source/text/shared/explorer/database/menuedit.xhp   |8 -
 source/text/shared/explorer/database/menuinsert.xhp |4 
 source/text/shared/explorer/database/menuview.xhp   |8 -
 13 files changed, 74 insertions(+), 74 deletions(-)

New commits:
commit c81535cf7d904c8c7625d66d3ba67f36f9d07f59
Author: Olivier Hallot 
Date:   Thu Apr 12 16:15:29 2018 -0300

tdf#94438 disambiguate bookmark branch (ii)

Change-Id: I07fa84bb8f04fe7128939d059dc26d580c5881f4
Reviewed-on: https://gerrit.libreoffice.org/52798
Tested-by: Jenkins 
Reviewed-by: Olivier Hallot 
Tested-by: Olivier Hallot 

diff --git a/source/text/shared/00/0001.xhp 
b/source/text/shared/00/0001.xhp
index 2a9a56c5c..8e9696e4c 100644
--- a/source/text/shared/00/0001.xhp
+++ b/source/text/shared/00/0001.xhp
@@ -191,7 +191,7 @@
 
 
 
-
+
 
 
 Next
diff --git a/source/text/shared/00/0101.xhp 
b/source/text/shared/00/0101.xhp
index b086893aa..79874cbb8 100644
--- a/source/text/shared/00/0101.xhp
+++ b/source/text/shared/00/0101.xhp
@@ -18,7 +18,7 @@
  *   except in compliance with the License. You may obtain a copy of
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  -->
-   
+
 
 
 
@@ -42,7 +42,7 @@
 
 
 Assigns a title to a 
selected Gallery object.
-
+
 Deletes the selected graphic after 
confirmation.
 
 
diff --git a/source/text/shared/01/0207.xhp 
b/source/text/shared/01/0207.xhp
index cb9de2b15..b18eea122 100644
--- a/source/text/shared/01/0207.xhp
+++ b/source/text/shared/01/0207.xhp
@@ -1,6 +1,6 @@
 
 
-   
+
 
- 
-   
+
+
 
 
 Paste Special
@@ -31,7 +31,7 @@
 
 
 
-
+
 Paste 
Special
 Inserts the contents 
of the clipboard into the current file in a format that you can specify.
 
@@ -70,92 +70,92 @@
 
 Selection
 Select a format for the clipboard contents that 
you want to paste.
-When you paste HTML data into a text 
document, you can choose "HTML format" or "HTML format without comments". The 
second choice is the default; it pastes all HTML data, but no comments. 
+When you paste HTML data into a text 
document, you can choose "HTML format" or "HTML format without comments". The 
second choice is the default; it pastes all HTML data, but no comments.
 
 
-Paste Special 
+Paste Special
 
-This dialog appears in Calc if the 
clipboard contains spreadsheet cells. 
+This dialog appears in Calc if the 
clipboard contains spreadsheet cells.
 
-Selection 
+Selection
 
-Select a format for the clipboard 
contents that you want to paste. 
+Select a format for the clipboard 
contents that you want to paste.
 
 
-Paste all 
+Paste all
 
 Pastes all cell contents, 
comments, formats, and objects into the current document.
 
 
-Text 
+Text
 i50436
-Inserts cells containing text. 
+Inserts cells containing text.
 
 
-Numbers 
+Numbers
 
-Inserts cells containing numbers. 
+Inserts cells containing numbers.
 
 
-Date  Time 
+Date  Time
 
-Inserts cells containing date and time 
values. 
+Inserts cells containing date and time 
values.
 
 
-Formulas 
+Formulas
 
 Inserts cells containing 
formulae.
 
 
-Comments 
+Comments
 
-Inserts comments that are attached to 
cells. If you want to add the comments to the existing cell content, select the 
"Add" operation. 
+Inserts comments that are attached to 
cells. If you want to add the comments to the existing cell content, select the 
"Add" operation.
 
 
-Formats 
+Formats
 
-Inserts cell format attributes. 
+Inserts cell format attributes.
 
 
-Objects 
+Objects
 
-Inserts objects contained within the 
selected cell range. These can be OLE objects, chart objects, or drawing 
objects. 
+Inserts objects contained within the 
selected cell range. These can be OLE objects, chart objects, or drawing 
objects.
 
-Operations 
+Operations
 
-Select the operation to apply when you 
paste cells into your sheet. 
+Select the operation to apply when you 
paste cells into your sheet.
 
 
-None 
+None
 
-Does not apply an operation when you 
insert the cell range from the clipboard. The contents of the clipboard will 
replace existing cell contents. 
+Does not apply an operation when you 
insert the cell range from the clipboard. The contents of the clipboard will 
replace 

[Libreoffice-commits] core.git: helpcontent2

[Olivier Hallot]

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 7681606be8ff4641f3000107b0d18bf083a383b3
Author: Olivier Hallot 
Date:   Thu Apr 12 16:15:29 2018 -0300

Updated core
Project: help  c81535cf7d904c8c7625d66d3ba67f36f9d07f59

tdf#94438 disambiguate bookmark branch (ii)

Change-Id: I07fa84bb8f04fe7128939d059dc26d580c5881f4
Reviewed-on: https://gerrit.libreoffice.org/52798
Tested-by: Jenkins 
Reviewed-by: Olivier Hallot 
Tested-by: Olivier Hallot 

diff --git a/helpcontent2 b/helpcontent2
index b5aad7c2f22b..c81535cf7d90 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit b5aad7c2f22be97d0d20ca7b31875fcaa55309a3
+Subproject commit c81535cf7d904c8c7625d66d3ba67f36f9d07f59
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 116944] Firebird-migration must happen only after user consent and advise to backup data prior to migration at 6.1

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116944

--- Comment #15 from Florian Reisinger  ---
#11
"It is up to developer to decide what is best" (non 100% quote from the linked
thread) is not always the best solution as backward compatibility takes effort.

As I am doing my master thesis "done correctly" is a very hard term in software
engineering. Ignoring that...

"In the current state, the old HSQLDB data is also kept in the odb file 
after migration. You can revert the migration by unzipping the odb 
file and overwriting the URL in content.xml in tag 
. 

Besides that, the migration will be permanent only if you save the 
document and a red circle on the save button indicates that something 
has been changed."

For how long is it planned that all data is duplicated inside the ODB file?
That's the user-unfriendly way to copy the ODB file and convert the copy.

I do not see a big discussion about the change in DB (or I was not aware of
that). I do not say we should not move to a new database, but I (even as a
developer) do not expect in END USER software to change the file format in an
incompatible way. The current changes feels like having a DOCX file in a DOC
file without viability from outside!

Moreover for people, which are not reading the mailing lists issuing a
deprication notice at least in the release before it will be removed is
necessary. I do not say that we need a perfect convertation tool or a perfect
Firebird driver. However, with so few time for feedback (especially from very
complex DBs) we won't get feedback in time.

Even Robert's DBs from the handbook are not working at the moment.

The user gain time to test the changes and adapt for migration. For end user
facing software it is important to keep the format stable. Therefore switching
from an HSQLDB from 2005 to an up to date one would be as problematic as the
change to firebird.
I do not see parallels with MySQL (or HSQLDB for that purpose) as it can be
expected from developers that such a migration is tested. This care, however,
cannot be expected from end users (which Robert and I try to protect).

Such a transition will always be painful, However doing this in a big-bang
style like this - without urgent need to remove the old DB is not
comprehend-able for me. If you care to explain why

- removing a DB backend without deprication notice
- keeping the HSQLDB data in the ODB file WITHOUT possibility to open it with
an old version of LibreOffice
- hushing the transition to the new database backend

is a good idea.

The next bit is IMHO:

- Putting it in the 6.0 release notes is impossible - already released.
  --> Mark it for removal in 6.1 with removal in 6.2 / 6.3
--> Would give us time to fix corner case bugs
  --> New databases will be created with Firebird (by default?) in 6.1
- Why keep the old data in the file?
  --> Creating a new file with just Firebird data makes more sense as the end
user is not able to recover the data!
- Why do we need to get rid of HSQLDB so quickly?
  --> Is it the last piece of Java code?
  --> Does it solve lots of problems?
--> From Robert's tests it seems that Firebird has some problems
- In the linked thread some typed are declared different in HSQLDB and Firebird
  --> Is it tested that transition even works for these types (even if the data
size only COULD be too large but isn't at the moment.
- Do we have a user friendly document, which explains the possibly needed
manual steps needed to test the success of the conversion?
  --> User can ignore that, but it might help us get to know some bugs.
. How (in theory) is it assured that the conversion is working (I also
mentioned comparing the results of queries for being equal.
--> Can this be automated (and as I said) the conversion to FireBirdDB only
succeed if (specific kinds of) queries are evaluated in exactly the same way as
before.

Thanks for considering and / or answering above statements / questions.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 116944] Firebird-migration must happen only after user consent and advise to backup data prior to migration at 6.1

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116944

--- Comment #15 from Florian Reisinger  ---
#11
"It is up to developer to decide what is best" (non 100% quote from the linked
thread) is not always the best solution as backward compatibility takes effort.

As I am doing my master thesis "done correctly" is a very hard term in software
engineering. Ignoring that...

"In the current state, the old HSQLDB data is also kept in the odb file 
after migration. You can revert the migration by unzipping the odb 
file and overwriting the URL in content.xml in tag 
. 

Besides that, the migration will be permanent only if you save the 
document and a red circle on the save button indicates that something 
has been changed."

For how long is it planned that all data is duplicated inside the ODB file?
That's the user-unfriendly way to copy the ODB file and convert the copy.

I do not see a big discussion about the change in DB (or I was not aware of
that). I do not say we should not move to a new database, but I (even as a
developer) do not expect in END USER software to change the file format in an
incompatible way. The current changes feels like having a DOCX file in a DOC
file without viability from outside!

Moreover for people, which are not reading the mailing lists issuing a
deprication notice at least in the release before it will be removed is
necessary. I do not say that we need a perfect convertation tool or a perfect
Firebird driver. However, with so few time for feedback (especially from very
complex DBs) we won't get feedback in time.

Even Robert's DBs from the handbook are not working at the moment.

The user gain time to test the changes and adapt for migration. For end user
facing software it is important to keep the format stable. Therefore switching
from an HSQLDB from 2005 to an up to date one would be as problematic as the
change to firebird.
I do not see parallels with MySQL (or HSQLDB for that purpose) as it can be
expected from developers that such a migration is tested. This care, however,
cannot be expected from end users (which Robert and I try to protect).

Such a transition will always be painful, However doing this in a big-bang
style like this - without urgent need to remove the old DB is not
comprehend-able for me. If you care to explain why

- removing a DB backend without deprication notice
- keeping the HSQLDB data in the ODB file WITHOUT possibility to open it with
an old version of LibreOffice
- hushing the transition to the new database backend

is a good idea.

The next bit is IMHO:

- Putting it in the 6.0 release notes is impossible - already released.
  --> Mark it for removal in 6.1 with removal in 6.2 / 6.3
--> Would give us time to fix corner case bugs
  --> New databases will be created with Firebird (by default?) in 6.1
- Why keep the old data in the file?
  --> Creating a new file with just Firebird data makes more sense as the end
user is not able to recover the data!
- Why do we need to get rid of HSQLDB so quickly?
  --> Is it the last piece of Java code?
  --> Does it solve lots of problems?
--> From Robert's tests it seems that Firebird has some problems
- In the linked thread some typed are declared different in HSQLDB and Firebird
  --> Is it tested that transition even works for these types (even if the data
size only COULD be too large but isn't at the moment.
- Do we have a user friendly document, which explains the possibly needed
manual steps needed to test the success of the conversion?
  --> User can ignore that, but it might help us get to know some bugs.
. How (in theory) is it assured that the conversion is working (I also
mentioned comparing the results of queries for being equal.
--> Can this be automated (and as I said) the conversion to FireBirdDB only
succeed if (specific kinds of) queries are evaluated in exactly the same way as
before.

Thanks for considering and / or answering above statements / questions.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-commits] core.git: sw/qa writerfilter/source

[Miklos Vajna]

 sw/qa/extras/ooxmlexport/data/tdf116976.docx  |binary
 sw/qa/extras/ooxmlexport/ooxmlexport11.cxx|7 +++
 writerfilter/source/dmapper/GraphicImport.cxx |   10 --
 3 files changed, 15 insertions(+), 2 deletions(-)

New commits:
commit 9691b2fc5d77df41f923722fbaaa512d545a98ca
Author: Miklos Vajna 
Date:   Thu Apr 12 18:39:36 2018 +0200

tdf#116976 DOCX import: fix rel size of shape after bitmap

We have a queue of these odd relative sizes (which are not XML
attributes but text inside the XML element), if the bitmap doesn't pop
the queue, the following shape won't get its size.

Change-Id: I1602208c9509d8889bf0be254f3b25fb25fafca2
Reviewed-on: https://gerrit.libreoffice.org/52791
Reviewed-by: Miklos Vajna 
Tested-by: Jenkins 

diff --git a/sw/qa/extras/ooxmlexport/data/tdf116976.docx 
b/sw/qa/extras/ooxmlexport/data/tdf116976.docx
new file mode 100644
index ..70492a4af2f3
Binary files /dev/null and b/sw/qa/extras/ooxmlexport/data/tdf116976.docx differ
diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport11.cxx 
b/sw/qa/extras/ooxmlexport/ooxmlexport11.cxx
index f290d0aefe15..ea584e6c6ef9 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport11.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport11.cxx
@@ -352,6 +352,13 @@ DECLARE_OOXMLEXPORT_TEST(testTdf112118_DOCX, 
"tdf112118.docx")
 }
 }
 
+DECLARE_OOXMLEXPORT_TEST(testTdf116976, "tdf116976.docx")
+{
+// This was 0, reltive size of shape after bitmap was ignored.
+CPPUNIT_ASSERT_EQUAL(static_cast(40),
+ getProperty(getShape(1), "RelativeWidth"));
+}
+
 CPPUNIT_PLUGIN_IMPLEMENT();
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/writerfilter/source/dmapper/GraphicImport.cxx 
b/writerfilter/source/dmapper/GraphicImport.cxx
index 5847e7d4a324..48c620c54296 100644
--- a/writerfilter/source/dmapper/GraphicImport.cxx
+++ b/writerfilter/source/dmapper/GraphicImport.cxx
@@ -1061,10 +1061,12 @@ void GraphicImport::lcl_sprm(Sprm& rSprm)
 break;
 case NS_ooxml::LN_CT_SizeRelH_pctWidth:
 case NS_ooxml::LN_CT_SizeRelV_pctHeight:
-if (m_xShape.is() && !m_pImpl->m_rPositivePercentages.empty())
+if (m_pImpl->m_rPositivePercentages.empty())
+break;
+
+if (m_xShape.is())
 {
 sal_Int16 nPositivePercentage = 
rtl::math::round(m_pImpl->m_rPositivePercentages.front().toDouble() / 
oox::drawingml::PER_PERCENT);
-m_pImpl->m_rPositivePercentages.pop();
 
 if (nPositivePercentage)
 {
@@ -1073,6 +1075,10 @@ void GraphicImport::lcl_sprm(Sprm& rSprm)
 xPropertySet->setPropertyValue(aProperty, 
uno::makeAny(nPositivePercentage));
 }
 }
+
+// Make sure the token is consumed even if xShape is an empty
+// reference.
+m_pImpl->m_rPositivePercentages.pop();
 break;
 case NS_ooxml::LN_EG_WrapType_wrapNone: // 90944; - doesn't contain 
attributes
 //depending on the behindDoc attribute text wraps through behind 
or in front of the object
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 116944] Firebird-migration must happen only after user consent and advise to backup data prior to migration at 6.1

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116944

--- Comment #14 from rob...@familiegrosskopf.de ---
Firebird has been experimental the whole time. 
Nobody should add a new feature like "Firebird not experimental - Automatic
HSQLDB-migration" during an update from 6.0.3 to 6.0.4. No depecation-note
should be made from one 6.0 to another. This updates are for bugfixes, not for
new features.

I have tried a little bit with the migration and LO 6.1.0.0.alpha0. Thanks to
Drew Jensen to try this first. Many bugs appear. Many parts won't be migrated
(views, relationships ...) Tables won't be created, if relationships are
declared in a HSQLDB-database.

The migration is very experimental!

I have have written about bugs in Base since over 7 years. Open Base-bugs I
reported are 74 at this moment. 
I have written the Base-Handbook and many users will contact me for help with
there databases.
I haven't heard anything about an automatic migration from a working HSQLDB to
an experimental Firebird-DB.

I haven't informed myself at special developer-lists and was very surprised
when Alex wrote about this problem in Global users-list and German
discuss-list.

The expected next step should be:
Firebird shouldn't be an experimental feature in 6.1
Then we will have a look for the incoming bugs. Firebird has to be a better
solution than HSQLDB. If it isn't we couldn't explain users why we should
change from one to the other. 
Next step in 6.2 could be to offer a migration.
Last step in 6.3 should be to change from HSQLDB to Firebird.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 116944] Firebird-migration must happen only after user consent and advise to backup data prior to migration at 6.1

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116944

--- Comment #14 from rob...@familiegrosskopf.de ---
Firebird has been experimental the whole time. 
Nobody should add a new feature like "Firebird not experimental - Automatic
HSQLDB-migration" during an update from 6.0.3 to 6.0.4. No depecation-note
should be made from one 6.0 to another. This updates are for bugfixes, not for
new features.

I have tried a little bit with the migration and LO 6.1.0.0.alpha0. Thanks to
Drew Jensen to try this first. Many bugs appear. Many parts won't be migrated
(views, relationships ...) Tables won't be created, if relationships are
declared in a HSQLDB-database.

The migration is very experimental!

I have have written about bugs in Base since over 7 years. Open Base-bugs I
reported are 74 at this moment. 
I have written the Base-Handbook and many users will contact me for help with
there databases.
I haven't heard anything about an automatic migration from a working HSQLDB to
an experimental Firebird-DB.

I haven't informed myself at special developer-lists and was very surprised
when Alex wrote about this problem in Global users-list and German
discuss-list.

The expected next step should be:
Firebird shouldn't be an experimental feature in 6.1
Then we will have a look for the incoming bugs. Firebird has to be a better
solution than HSQLDB. If it isn't we couldn't explain users why we should
change from one to the other. 
Next step in 6.2 could be to offer a migration.
Last step in 6.3 should be to change from HSQLDB to Firebird.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-commits] online.git: autogen.sh

[Henry Castro]

 autogen.sh |   10 +-
 1 file changed, 9 insertions(+), 1 deletion(-)

New commits:
commit c254cc333b338b71bfd720baa19e313b97a43c7b
Author: Henry Castro 
Date:   Thu Apr 12 15:43:19 2018 -0400

execute autogen.sh from a build directory

Change-Id: Ibd394549366d0059fe27696343870645e1e11947

diff --git a/autogen.sh b/autogen.sh
index bf5655b98..1ce95d840 100755
--- a/autogen.sh
+++ b/autogen.sh
@@ -1,5 +1,11 @@
 #! /bin/bash
 
+srcdir=`dirname $0`
+test -n "$srcdir" || srcdir=.
+
+olddir=`pwd`
+cd "$srcdir"
+
 function failed {
 cat << EOF 1>&2
 
@@ -22,6 +28,8 @@ autoreconf || failed "autoreconf"
 
 cat << EOF
 
-Result: All went OK, please run ./configure (with the appropriate parameters) 
now.
+Result: All went OK, please run $srcdir/configure (with the appropriate 
parameters) now.
 
 EOF
+
+cd "$olddir"
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 116944] Firebird-migration must happen only after user consent and advise to backup data prior to migration at 6.1

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116944

--- Comment #13 from Gerhard Weydt  ---
@ 11: The deprecation notice should have appeared in the release notes for 6.0
from the very beginning. Now it's too late for many people who have already
updated and will not read the release notes again!
And the concept of migrating to Firebird has one capital flaw, as far as can be
seen at present: it supposes that all will work perfectly and without the least
error. We all know that this is wishful thinking, there has to be a possibility
to go back or have a copy of the old situation _and_ a practicable way to get
at least at the data, which the new version 6.1 of LibO does not offer. Even
then a user who encounters a problem when the migration is done cannot use his
database application, which is still bad enough.
Even for changes of much less importance it is indispensable to have a concept
for the case of problems arising. We cannot this change-over without that.
Lionel's statement, which just arrived, is therefore reassuring.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 116944] Firebird-migration must happen only after user consent and advise to backup data prior to migration at 6.1

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116944

--- Comment #13 from Gerhard Weydt  ---
@ 11: The deprecation notice should have appeared in the release notes for 6.0
from the very beginning. Now it's too late for many people who have already
updated and will not read the release notes again!
And the concept of migrating to Firebird has one capital flaw, as far as can be
seen at present: it supposes that all will work perfectly and without the least
error. We all know that this is wishful thinking, there has to be a possibility
to go back or have a copy of the old situation _and_ a practicable way to get
at least at the data, which the new version 6.1 of LibO does not offer. Even
then a user who encounters a problem when the migration is done cannot use his
database application, which is still bad enough.
Even for changes of much less importance it is indispensable to have a concept
for the case of problems arising. We cannot this change-over without that.
Lionel's statement, which just arrived, is therefore reassuring.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 51733] Update icons for high-resolution HiDPI / Retina display

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=51733

--- Comment #20 from Renato S. Yamane  ---
Created attachment 141316
  --> https://bugs.documentfoundation.org/attachment.cgi?id=141316=edit
Screenshot of Writer on Windows 10 (Lenovo L380), VERY pixelated

On my Windows 10, the icons are even more horrible.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 116944] Firebird-migration must happen only after user consent and advise to backup data prior to migration at 6.1

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116944

--- Comment #12 from Lionel Elie Mamane  ---
(In reply to V Stuart Foote from comment #11)

> There is ESC support for the implementation (Lionel is a member)

There is ESC support for the migration, and the change of default,
but not for the timing of it. HSQLDB and Firebird are two different
systems with two different SQL syntaxes, different feature sets, etc.
People that use Base as a development platform to make their own application
need a transition period to adapt their code.

IMO, the timing of the change of default for *new* databases is still not
decided for certain. It might happen for the next release, or later.
Depends on when bugs like 104918, 116935 and 116936 are fixed. See bug
51780 for the tracking of that. We may also want to wait for bug 116936
to be fixed.

Removing HSQLDB needs _time_ from the moment Firebird-in-LibreOffice is
stable, good quality, and has - broadly speaking - feature-parity with
HSQLDB. Bugs like 116936 are blocker for that. See bug 116970 for the
tracking of that.

> rather than stretching out the migration of internal HSQLDB to Firebird
> if the migration code is ready and gets well tested, there really is no
> practical UX reason to stretch out the pain point of the DB transition.

I feel that this POV comes from a view that all SQL engines are
interchangeable, they only differ in on-disk data storage format. For users
that only use Base as a graphical GUI to do stuff, that may even be, to a
moderate to large degree, true. However, for people using Base as an
application development platform, that is very much not true.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 116944] Firebird-migration must happen only after user consent and advise to backup data prior to migration at 6.1

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116944

--- Comment #12 from Lionel Elie Mamane  ---
(In reply to V Stuart Foote from comment #11)

> There is ESC support for the implementation (Lionel is a member)

There is ESC support for the migration, and the change of default,
but not for the timing of it. HSQLDB and Firebird are two different
systems with two different SQL syntaxes, different feature sets, etc.
People that use Base as a development platform to make their own application
need a transition period to adapt their code.

IMO, the timing of the change of default for *new* databases is still not
decided for certain. It might happen for the next release, or later.
Depends on when bugs like 104918, 116935 and 116936 are fixed. See bug
51780 for the tracking of that. We may also want to wait for bug 116936
to be fixed.

Removing HSQLDB needs _time_ from the moment Firebird-in-LibreOffice is
stable, good quality, and has - broadly speaking - feature-parity with
HSQLDB. Bugs like 116936 are blocker for that. See bug 116970 for the
tracking of that.

> rather than stretching out the migration of internal HSQLDB to Firebird
> if the migration code is ready and gets well tested, there really is no
> practical UX reason to stretch out the pain point of the DB transition.

I feel that this POV comes from a view that all SQL engines are
interchangeable, they only differ in on-disk data storage format. For users
that only use Base as a graphical GUI to do stuff, that may even be, to a
moderate to large degree, true. However, for people using Base as an
application development platform, that is very much not true.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: vcl/uiconfig vcl/unx

[Caolán McNamara]

 vcl/uiconfig/ui/cupspassworddialog.ui |   16 ++--
 vcl/unx/generic/printer/cupsmgr.cxx   |   61 --
 2 files changed, 34 insertions(+), 43 deletions(-)

New commits:
commit 1e9e78bde0e659c89ea96b259845539dab500195
Author: Caolán McNamara 
Date:   Thu Apr 12 10:33:34 2018 +0100

weld RTSPWDialog

Change-Id: I822c15bb4326d1b7b96b2af9aefbb3deecc7b229
Reviewed-on: https://gerrit.libreoffice.org/52770
Tested-by: Jenkins 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/vcl/uiconfig/ui/cupspassworddialog.ui 
b/vcl/uiconfig/ui/cupspassworddialog.ui
index 7b2cb5d0232d..9b37d3eacc2d 100644
--- a/vcl/uiconfig/ui/cupspassworddialog.ui
+++ b/vcl/uiconfig/ui/cupspassworddialog.ui
@@ -1,11 +1,14 @@
 
-
+
 
   
   
 False
 6
 Authentication 
Request
+True
+0
+0
 normal
 
   
@@ -66,10 +69,10 @@
   
 True
 False
-1
 _User:
 True
 user
+1
   
   
 0
@@ -80,10 +83,10 @@
   
 True
 False
-1
 _Password:
 True
 pass
+1
   
   
 0
@@ -94,11 +97,11 @@
   
 True
 False
-0
 Please enter your authentication data for 
server “%s”
 True
 True
 56
+0
   
   
 0
@@ -111,6 +114,7 @@
 True
 True
 True
+True
   
   
 1
@@ -123,6 +127,7 @@
 True
 True
 False
+True
   
   
 1
@@ -142,5 +147,8 @@
   ok
   cancel
 
+
+  
+
   
 
diff --git a/vcl/unx/generic/printer/cupsmgr.cxx 
b/vcl/unx/generic/printer/cupsmgr.cxx
index 328e9246e9f5..a6cae038aa36 100644
--- a/vcl/unx/generic/printer/cupsmgr.cxx
+++ b/vcl/unx/generic/printer/cupsmgr.cxx
@@ -34,9 +34,8 @@
 
 #include 
 
-#include 
-#include 
-#include 
+#include 
+#include 
 
 #include 
 
@@ -827,66 +826,50 @@ bool CUPSManager::writePrinterConfig()
 
 namespace
 {
-class RTSPWDialog : public ModalDialog
+class RTSPWDialog : public weld::GenericDialogController
 {
-VclPtr m_pText;
-VclPtr  m_pUserEdit;
-VclPtr  m_pPassEdit;
+std::unique_ptr m_xText;
+std::unique_ptr m_xUserEdit;
+std::unique_ptr m_xPassEdit;
 
 public:
-RTSPWDialog(const OString& rServer, const OString& rUserName, 
vcl::Window* pParent);
-virtual ~RTSPWDialog() override;
-virtual void dispose() override;
+RTSPWDialog(const OString& rServer, const OString& rUserName, 
weld::Window* pParent);
 OString getUserName() const;
 OString getPassword() const;
 };
 
-RTSPWDialog::RTSPWDialog( const OString& rServer, const OString& 
rUserName, vcl::Window* pParent )
-: ModalDialog(pParent, "CUPSPasswordDialog",
-"vcl/ui/cupspassworddialog.ui")
+RTSPWDialog::RTSPWDialog( const OString& rServer, const OString& 
rUserName, weld::Window* pParent )
+: GenericDialogController(pParent, "vcl/ui/cupspassworddialog.ui", 
"CUPSPasswordDialog")
+, m_xText(m_xBuilder->weld_label("text"))
+, m_xUserEdit(m_xBuilder->weld_entry("user"))
+, m_xPassEdit(m_xBuilder->weld_entry("pass"))
 {
-get(m_pText, "text");
-get(m_pUserEdit, "user");
-get(m_pPassEdit, "pass");
-
-OUString aText(m_pText->GetText());
+OUString aText(m_xText->get_label());
 aText = aText.replaceFirst("%s", OStringToOUString(rServer, 
osl_getThreadTextEncoding()));
-m_pText->SetText(aText);
-m_pUserEdit->SetText( OStringToOUString(rUserName, 
osl_getThreadTextEncoding()));
-}
-
-RTSPWDialog::~RTSPWDialog()
-{
-disposeOnce();
-}
-
-void RTSPWDialog::dispose()
-{
-m_pText.clear();
-m_pUserEdit.clear();
-m_pPassEdit.clear();
-ModalDialog::dispose();
+m_xText->set_label(aText);
+m_xUserEdit->set_text(OStringToOUString(rUserName, 
osl_getThreadTextEncoding()));
 }
 
 OString RTSPWDialog::getUserName() const
 {
-return OUStringToOString( m_pUserEdit->GetText(), 
osl_getThreadTextEncoding() );
+return OUStringToOString( m_xUserEdit->get_text(), 
osl_getThreadTextEncoding() );
 }
 
 OString RTSPWDialog::getPassword() const
 {
-return OUStringToOString( m_pPassEdit->GetText(), 

[Libreoffice-bugs] [Bug 116961] EDITING - Calc crashes like a blazing blimp when pasting cut cells into whole column.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116961

Telesto  changed:

   What|Removed |Added

 Status|NEW |UNCONFIRMED
 Ever confirmed|1   |0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116930] Calc crashes when scrolling in a worksheet containing a Chart object

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116930

--- Comment #5 from stevej...@hotmail.co.uk ---
Also I tested this with OpenGL enabled with the same outcome.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116930] Calc crashes when scrolling in a worksheet containing a Chart object

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116930

--- Comment #4 from stevej...@hotmail.co.uk ---
After following the advised steps to verify if this issue is due to a corrupt
user profile, I can confirm that Calc still crashed in Safe Mode and having
reproduced it many times over the crash appears to only occur when the chart
object is forced to be redrawn multiple times and specifically with a vertical
scroll action, it is not reproducible when scrolling horizontally with a chart
object in view.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100925] When overwriting a cell, new content is displayed on top of the old content until finishing the edit

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100925

--- Comment #83 from Buovjaga  ---
(In reply to Caolán McNamara from comment #82)
> Created attachment 141313 [details]
> does this make any difference ?

Now the background turns red immediately upon typing.
In a cell with existing content, old text is not visible when new typing
begins.

With SC_NOINLINETEXT=1, no text (new or old) is visible when typing. Either in
an empty cell or one with content.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116944] Firebird-migration must happen only after user consent and advise to backup data prior to migration at 6.1

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116944

--- Comment #11 from V Stuart Foote  ---
Hate to be the lone voice of dissent here, but Tamás remains under tender from
the foundation to get the HSQLDB migration tool done correctly.

There is ESC support for the implementation (Lionel is a member) and rather
than stretching out the migration of internal HSQLDB to Firebird (that should
have happened long ago starting at bug 38811) if the migration code is ready
and gets well tested--as Tamás requested [1]--there really is no practical UX
reason to stretch out the pain point of the DB transition.

In fact there is much to be said for an ESC led effort to see this conversion
completed, diverting dev cycles where needed to get the DB and the Base UIs
finished. The project--and users--gain little by pushing it down the road with
a "transitional" period. 

Otherwise, deprecation notice for internal HSQLDB should be made now in 6.0
release notes.

=-ref-=
[1]
http://nabble.documentfoundation.org/Database-migration-in-Base-tc4237588.html

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 116944] Firebird-migration must happen only after user consent and advise to backup data prior to migration at 6.1

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116944

--- Comment #11 from V Stuart Foote  ---
Hate to be the lone voice of dissent here, but Tamás remains under tender from
the foundation to get the HSQLDB migration tool done correctly.

There is ESC support for the implementation (Lionel is a member) and rather
than stretching out the migration of internal HSQLDB to Firebird (that should
have happened long ago starting at bug 38811) if the migration code is ready
and gets well tested--as Tamás requested [1]--there really is no practical UX
reason to stretch out the pain point of the DB transition.

In fact there is much to be said for an ESC led effort to see this conversion
completed, diverting dev cycles where needed to get the DB and the Base UIs
finished. The project--and users--gain little by pushing it down the road with
a "transitional" period. 

Otherwise, deprecation notice for internal HSQLDB should be made now in 6.0
release notes.

=-ref-=
[1]
http://nabble.documentfoundation.org/Database-migration-in-Base-tc4237588.html

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 116980] New: FIREBIRD: Migration: No migration possible with data in tables and declared realtionship

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116980

Bug ID: 116980
   Summary: FIREBIRD: Migration: No migration possible with data
in tables and declared realtionship
   Product: LibreOffice
   Version: 6.1.0.0.alpha0+ Master
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Base
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: rob...@familiegrosskopf.de

Created attachment 141315
  --> https://bugs.documentfoundation.org/attachment.cgi?id=141315=edit
Two database for testing: Import of data together with relationship fails

There are two database in the attachment:
First database with declared relationship, second database with the same data
and without declared relationship.

Open the first database HSQLDB_FB_Test.odb with LO 6.1.0.0.alpha.
Change to the section "Tables".
After a while an error appears, something with Value ***null*** of one of the
tables.
No tables will be created.

Open the second database HSQLDB_FB_Test_whithout_relationship.odb.
Change to the section "Tables".
After a while the tables will be created. (The view won't be created because of
another bug).

All tested with 
Version: 6.1.0.0.alpha0+
Build-ID: dc823f5fa4a5d2eca56297b9045e5962536c00f9
CPU-Threads: 4; BS: Linux 4.4; UI-Render: Standard; VCL: kde4; 
TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time:
2018-04-10_23:32:35

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 116944] Firebird-migration must happen only after user consent and advise to backup data prior to migration at 6.1

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116944

--- Comment #10 from Florian Reisinger  ---
I would let the user save a new file. I guess the awareness might be higher
that he is able to use the old file with the old LibreOffice version. Let him
store a new file for the new behavior. The old file for the new behavior would
be strange for me.

Bur I am not an UX expert, just my 2 cents!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 116944] Firebird-migration must happen only after user consent and advise to backup data prior to migration at 6.1

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116944

--- Comment #10 from Florian Reisinger  ---
I would let the user save a new file. I guess the awareness might be higher
that he is able to use the old file with the old LibreOffice version. Let him
store a new file for the new behavior. The old file for the new behavior would
be strange for me.

Bur I am not an UX expert, just my 2 cents!

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 86315] EDITING: Formatting of queries should be saved by base

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=86315

--- Comment #6 from Drew Jensen  ---
So I tried this with Libo6.1 Alpha (daily builds).

It looks to me the problem is that the falg for a query definition requiring
'Run Direct SQL' is not being saved and that is the problem.

To see what I mean grab the test db I attached.

Open the query definition with 'Edit SQL view'
You will see that the comment I added was saved.
Try to run the query and it fails.
Now click on 'Run SQL Command Directly'
Run the query again and it passes.
Save the query.

The 'Run SQL Command Directly' flag is not sticking with the QueryDef.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 86315] EDITING: Formatting of queries should be saved by base

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=86315

Drew Jensen  changed:

   What|Removed |Added

 CC||drewjensen.in...@gmail.com

--- Comment #5 from Drew Jensen  ---
Created attachment 141314
  --> https://bugs.documentfoundation.org/attachment.cgi?id=141314=edit
test db with querydef containing comment

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116944] Firebird-migration must happen only after user consent and advise to backup data prior to migration at 6.1

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116944

--- Comment #9 from Thomas Lendo  ---
>From a UX point of view, we should not suppose that the user is creating a
backup file manually even if we warn him by an info bar.

We should force the user 1) either to save a backup file within an
automatically opened dialog where the user can choose a file name and a
location or 2) to save the new firebird file with an identical dialog.

This user prompted solution prevents failed auto-backups and informs the user
that there is something happen.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 116944] Firebird-migration must happen only after user consent and advise to backup data prior to migration at 6.1

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116944

--- Comment #9 from Thomas Lendo  ---
From a UX point of view, we should not suppose that the user is creating a
backup file manually even if we warn him by an info bar.

We should force the user 1) either to save a backup file within an
automatically opened dialog where the user can choose a file name and a
location or 2) to save the new firebird file with an identical dialog.

This user prompted solution prevents failed auto-backups and informs the user
that there is something happen.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-commits] help.git: source/text

[Olivier Hallot]

 source/text/shared/explorer/database/menuedit.xhp |8 -
 source/text/shared/explorer/database/menuview.xhp |8 -
 source/text/shared/guide/startcenter.xhp  |  101 +-
 source/text/shared/optionen/01010301.xhp  |   10 +-
 source/text/shared/optionen/01110100.xhp  |2 
 source/text/shared/optionen/01150100.xhp  |4 
 source/text/shared/optionen/java.xhp  |4 
 source/text/simpress/01/05120100.xhp  |4 
 source/text/smath/01/03090200.xhp |2 
 source/text/smath/01/0504.xhp |5 -
 source/text/swriter/01/0610.xhp   |2 
 11 files changed, 69 insertions(+), 81 deletions(-)

New commits:
commit b5aad7c2f22be97d0d20ca7b31875fcaa55309a3
Author: Olivier Hallot 
Date:   Thu Apr 12 15:33:57 2018 -0300

tdf#94438 disambiguate bookmark branch id's

part II

Change-Id: Ic6e56307c667023a8892f60c20ef1f79b02b5347
Reviewed-on: https://gerrit.libreoffice.org/52795
Tested-by: Jenkins 
Reviewed-by: Olivier Hallot 
Tested-by: Olivier Hallot 

diff --git a/source/text/shared/explorer/database/menuedit.xhp 
b/source/text/shared/explorer/database/menuedit.xhp
index 9055f74ab..5591cc915 100644
--- a/source/text/shared/explorer/database/menuedit.xhp
+++ b/source/text/shared/explorer/database/menuedit.xhp
@@ -18,7 +18,7 @@
  *   except in compliance with the License. You may obtain a copy of
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  -->
-   
+
 
 
 
@@ -48,7 +48,7 @@
 Opens a window where you can edit the selected table, query, form, or 
report.
 
 
-
+
 Delete
 Deletes the selected table, query, form, or 
report.
 
@@ -62,7 +62,7 @@
 Create 
as View
 Converts the selected query to a view. The original query remains in 
your database file and an additional view is generated on the database server. 
You must have write permission to add a view to a database.
 Most databases use 
queries to filter or to sort database tables to display records on your 
computer. Views offer the same functionality as queries, but on the server 
side. If your database is on a server that supports views, you can use views to 
filter the records on the server to speed up the display time.
-
+
 Form 
Wizard
 Starts the Form 
Wizard for the selected table, query, or view.
 
@@ -79,7 +79,7 @@
 
 Connection Type
 Opens the Connection Type Wizard.shortened the 
paragraph, see i58462
-
+
 Advanced Properties
 Opens the Advanced Properties dialog.
 
diff --git a/source/text/shared/explorer/database/menuview.xhp 
b/source/text/shared/explorer/database/menuview.xhp
index 27fafa2f4..47e58469a 100644
--- a/source/text/shared/explorer/database/menuview.xhp
+++ b/source/text/shared/explorer/database/menuview.xhp
@@ -18,7 +18,7 @@
  *   except in compliance with the License. You may obtain a copy of
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  -->
-   
+
 
 
 
@@ -34,7 +34,7 @@
 View
 
 The View menu of a database window.
-
+
 Database Objects
 Opens a submenu.
 
@@ -49,7 +49,7 @@
 
 Tables
 Selects the tables container and shows all tables in the detail 
view.
-
+
 Sort
 Opens a submenu.
 Ascending
@@ -68,7 +68,7 @@
 
 Document
 The preview displays the document of a form or 
report.
-
+
 Refresh 
Tables
 Refreshes the tables. what happens? cool drinks? 
Icecream?
 
diff --git a/source/text/shared/guide/startcenter.xhp 
b/source/text/shared/guide/startcenter.xhp
index 9d9ad5442..5d54d13bd 100644
--- a/source/text/shared/guide/startcenter.xhp
+++ b/source/text/shared/guide/startcenter.xhp
@@ -25,46 +25,31 @@
  Start Center
  /text/shared/guide/startcenter.xhp
   
-   
-   
+
+
 backing window
-  start center
+start center
 
 
 
 
-Start Center
-
-Welcome to %PRODUCTNAME.
-   Thank you for using the %PRODUCTNAME application help.
-   Press F1 whenever you need help using the %PRODUCTNAME 
software.
-You 
see the Start Center when no document is open in %PRODUCTNAME.
-  It is divided into two panes.  Click a button on the left 
pane to open a new document or a file dialog.
-
+Start 
Center
+Welcome to %PRODUCTNAME. Thank you for using the %PRODUCTNAME 
application help. Press F1 
whenever you need help using the %PRODUCTNAME software.
+You 
see the Start Center when no document is open in %PRODUCTNAME. It is divided 
into two panes.  Click a button on the left pane to open a new 
document or a file dialog.
 Open existing files
-  
- 
-
-The Open File button presents a 
file open 
dialog.
- 
- 
-
-The Remote Files button presents a 
Remote files dialog 
to open files stored on remote servers.
- 
- 
-
-
-
-The Recent Files button shows 

[Libreoffice-commits] core.git: helpcontent2

[Olivier Hallot]

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 47da2b3ef35b87964218374282f6add41076af9a
Author: Olivier Hallot 
Date:   Thu Apr 12 15:33:57 2018 -0300

Updated core
Project: help  b5aad7c2f22be97d0d20ca7b31875fcaa55309a3

tdf#94438 disambiguate bookmark branch id's

part II

Change-Id: Ic6e56307c667023a8892f60c20ef1f79b02b5347
Reviewed-on: https://gerrit.libreoffice.org/52795
Tested-by: Jenkins 
Reviewed-by: Olivier Hallot 
Tested-by: Olivier Hallot 

diff --git a/helpcontent2 b/helpcontent2
index ba894a341a96..b5aad7c2f22b 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit ba894a341a96b89e0dd18161abbd148fb410a389
+Subproject commit b5aad7c2f22be97d0d20ca7b31875fcaa55309a3
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] help.git: source/text

[Olivier Hallot]

 source/text/scalc/01/04060104.xhp |2 +-
 source/text/scalc/01/04060181.xhp |2 +-
 source/text/scalc/01/04060184.xhp |2 +-
 source/text/scalc/01/04060185.xhp |4 ++--
 4 files changed, 5 insertions(+), 5 deletions(-)

New commits:
commit ba894a341a96b89e0dd18161abbd148fb410a389
Author: Olivier Hallot 
Date:   Thu Apr 12 15:01:05 2018 -0300

tdf#94438 Fix dup bookmark branches

Part 1, Calc files

Change-Id: I9a3c1d8f6afac7e693590be9220e811b07d6fd28
Reviewed-on: https://gerrit.libreoffice.org/52793
Tested-by: Jenkins 
Reviewed-by: Olivier Hallot 
Tested-by: Olivier Hallot 

diff --git a/source/text/scalc/01/04060104.xhp 
b/source/text/scalc/01/04060104.xhp
index 116f54e54..66d373db9 100644
--- a/source/text/scalc/01/04060104.xhp
+++ b/source/text/scalc/01/04060104.xhp
@@ -484,7 +484,7 @@
   #N/A error;recognizing
 
 mw added "#N/A ..."
-
+
 
 ISNA
 Returns TRUE if a cell contains the #N/A (value not 
available) error value.
diff --git a/source/text/scalc/01/04060181.xhp 
b/source/text/scalc/01/04060181.xhp
index b0336ac4e..ba890e71d 100644
--- a/source/text/scalc/01/04060181.xhp
+++ b/source/text/scalc/01/04060181.xhp
@@ -683,7 +683,7 @@
   CHISQ.DIST.RT function
 
 
-
+
 
 CHISQ.DIST.RT
 Returns the probability value from the indicated Chi 
square that a hypothesis is confirmed. CHISQ.DIST.RT compares the Chi 
square value to be given for a random sample that is calculated from the sum of 
(observed value-expected value)^2/expected value for all values with the 
theoretical Chi square distribution and determines from this the probability of 
error for the hypothesis to be tested.
diff --git a/source/text/scalc/01/04060184.xhp 
b/source/text/scalc/01/04060184.xhp
index 0572f9e0b..68c7f81d2 100644
--- a/source/text/scalc/01/04060184.xhp
+++ b/source/text/scalc/01/04060184.xhp
@@ -483,7 +483,7 @@
 
 QUARTILE.INC function
 
-
+
 QUARTILE.INC
 Returns the quartile of a data 
set.
 The difference 
between QUARTILE.INC and QUARTILE.EXC is that the QUARTILE.INC function bases its calculation on a percentile 
range of 0 to 1 inclusive, whereas the QUARTILE.EXC 
function bases its calculation on a percentile range of 0 to 1 
exclusive.
diff --git a/source/text/scalc/01/04060185.xhp 
b/source/text/scalc/01/04060185.xhp
index c303f8047..981d9bdba 100644
--- a/source/text/scalc/01/04060185.xhp
+++ b/source/text/scalc/01/04060185.xhp
@@ -690,7 +690,7 @@
 
 WEIBULL.DIST function
 
-
+
 WEIBULL.DIST
 Returns the values of the Weibull 
distribution.
 The Weibull distribution is a continuous probability 
distribution, with parameters Alpha  0 (shape) and Beta  0 (scale). 

@@ -711,4 +711,4 @@
  
   

-
\ No newline at end of file
+
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: helpcontent2

[Olivier Hallot]

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit b882b2453dbd63e1ab9e198b22876fa26c02fbcd
Author: Olivier Hallot 
Date:   Thu Apr 12 15:01:05 2018 -0300

Updated core
Project: help  ba894a341a96b89e0dd18161abbd148fb410a389

tdf#94438 Fix dup bookmark branches

Part 1, Calc files

Change-Id: I9a3c1d8f6afac7e693590be9220e811b07d6fd28
Reviewed-on: https://gerrit.libreoffice.org/52793
Tested-by: Jenkins 
Reviewed-by: Olivier Hallot 
Tested-by: Olivier Hallot 

diff --git a/helpcontent2 b/helpcontent2
index 51f6c350e52b..ba894a341a96 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 51f6c350e52bafc32caec98bf20e3c644c80d936
+Subproject commit ba894a341a96b89e0dd18161abbd148fb410a389
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 116944] Firebird-migration must happen only after user consent and advise to backup data prior to migration at 6.1

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116944

--- Comment #8 from Florian Reisinger  ---
If (as currently built in) the content of the file is changed there is no way
going back!

If (in some way) the conversion is happening in a separate file, the user at
least has the change of moving back to an older (probable insecure) release of
LibreOffice.

I guess we all agree that the currently implemented behavior is not in any way
user friendly. It - in fact - will scare users away.

However, especially if we have a release with both database drivers we can
automatically compare the result of reports. Most read-only reports will change
if executed not in the same moment.

The hardest requirement would be to try converting to a new file and checking
all reports and fail (or give a warning with the name of the reports) when the
result are not identical.

Only with such a dynamic test suite we would have a chance to make the
transition as smooth as possible,

I hope you agree to my statement that the current situation must not be
released and that the conversation must happen to a new file.

Some might complain that this is similar to introducing a new algorithm for
encrypting documents, which also break compatibility with AOO and older
versions of LibO. However the complexity of implementing / using a different
encryption function cannot be compared to switching to a different database
backend. Therefore a staged approach (marking Firebird non-experimental,
creating new ODB files with Firebird, converting old databases OPTIONALLY,
removing HSQLDB) should be spitted up to more than one maybe 3 or more
releases. Bugs will appear and we need to fix them with the fewest impact for
the user. A staged roll-out therefore is from the end user's point of view the
only real option!

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116965] EDITING: firebird: migration: Relationships lost when database converted to firebird

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116965

rob...@familiegrosskopf.de changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||rob...@familiegrosskopf.de
 Ever confirmed|0   |1

--- Comment #1 from rob...@familiegrosskopf.de ---
Could confirm the buggy behavior.

When starting the database under 
Version: 6.1.0.0.alpha0+
Build-ID: dc823f5fa4a5d2eca56297b9045e5962536c00f9
CPU-Threads: 4; BS: Linux 4.4; UI-Render: Standard; VCL: kde4; 
TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time:
2018-04-10_23:32:35

I get this error:

firebird_sdbc error:
*unsuccessful metadata update
*CREATE TABLE Products failed
*Table Products already exists
caused by
'CREATE TABLE "Products" ( "LeadTime" VARCHAR(50), "ProductID" INTEGER NOT NULL
PRIMARY KEY, "UnitPrice" DECIMAL(17), "CategoryID" INTEGER, "SupplierID"
INTEGER, "ProductName" VARCHAR(50), "Discontinued" BOOLEAN, "ReorderLevel"
INTEGER, "Serialnumber" VARCHAR(50), "UnitsInStock" INTEGER, "UnitsOnOrder"
INTEGER, "ProductDescription" VARCHAR(250))'

... but the tables appear, when switching to the "Tables"-section.
Then I opened the relationship and see two tables without any connection. Seems
the GUI has recognized there are two tables for the relationship, but doesn't
know the relation. Created the relation, saved and closed the database -
reopened and the relation has gone again. I have to close the database after
the migration and have to reopen it again. Then I could create the relation
without loosing it.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 116944] Firebird-migration must happen only after user consent and advise to backup data prior to migration at 6.1

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116944

--- Comment #8 from Florian Reisinger  ---
If (as currently built in) the content of the file is changed there is no way
going back!

If (in some way) the conversion is happening in a separate file, the user at
least has the change of moving back to an older (probable insecure) release of
LibreOffice.

I guess we all agree that the currently implemented behavior is not in any way
user friendly. It - in fact - will scare users away.

However, especially if we have a release with both database drivers we can
automatically compare the result of reports. Most read-only reports will change
if executed not in the same moment.

The hardest requirement would be to try converting to a new file and checking
all reports and fail (or give a warning with the name of the reports) when the
result are not identical.

Only with such a dynamic test suite we would have a chance to make the
transition as smooth as possible,

I hope you agree to my statement that the current situation must not be
released and that the conversation must happen to a new file.

Some might complain that this is similar to introducing a new algorithm for
encrypting documents, which also break compatibility with AOO and older
versions of LibO. However the complexity of implementing / using a different
encryption function cannot be compared to switching to a different database
backend. Therefore a staged approach (marking Firebird non-experimental,
creating new ODB files with Firebird, converting old databases OPTIONALLY,
removing HSQLDB) should be spitted up to more than one maybe 3 or more
releases. Bugs will appear and we need to fix them with the fewest impact for
the user. A staged roll-out therefore is from the end user's point of view the
only real option!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 116969] Justification by alternative methods

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116969

V Stuart Foote  changed:

   What|Removed |Added

 OS|Linux (All) |All

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104921] Make Arabic text justification more robust

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104921

V Stuart Foote  changed:

   What|Removed |Added

 Blocks||116969


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=116969
[Bug 116969] Justification by alternative methods
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116969] Justification by alternative methods

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116969

V Stuart Foote  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116969] Justification by alternative methods

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116969

V Stuart Foote  changed:

   What|Removed |Added

URL|https://bugs.documentfounda |
   |tion.org/show_bug.cgi?id=10 |
   |6653|
 CC||vstuart.fo...@utsa.edu
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||6653
 Blocks||71732
 Depends on||104921
   Severity|normal  |enhancement


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=71732
[Bug 71732] [META] Bugs related to text rendering, typography and font features
in LO
https://bugs.documentfoundation.org/show_bug.cgi?id=104921
[Bug 104921] Make Arabic text justification more robust
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106653] RTL Arabic justified text has some gaps between characters

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106653

V Stuart Foote  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=11
   ||6969

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 71732] [META] Bugs related to text rendering, typography and font features in LO

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=71732

V Stuart Foote  changed:

   What|Removed |Added

 Depends on||116969


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=116969
[Bug 116969] Justification by alternative methods
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: oovbaapi/ooo oox/source sfx2/classification sw/uiconfig vcl/source vcl/win

[Andrea Gelmini]

 oovbaapi/ooo/vba/excel/XLineObjects.idl   |2 +-
 oox/source/dump/xlsbdumper.ini|2 +-
 sfx2/classification/xNL.xsd   |2 +-
 sw/uiconfig/swriter/ui/notebookbar_compact.ui |2 +-
 vcl/source/font/fontcache.cxx |2 +-
 vcl/win/app/salinst.cxx   |2 +-
 6 files changed, 6 insertions(+), 6 deletions(-)

New commits:
commit b5a2dbdb7dbe4f9286dee7b451e06e7f82e9e787
Author: Andrea Gelmini 
Date:   Sun Apr 1 16:46:19 2018 +0200

Fix typos

Change-Id: Ie6ce882d5d39cdd24d0647b9fdddabafeee1d25f
Reviewed-on: https://gerrit.libreoffice.org/52277
Tested-by: Jenkins 
Reviewed-by: Julien Nabet 

diff --git a/oovbaapi/ooo/vba/excel/XLineObjects.idl 
b/oovbaapi/ooo/vba/excel/XLineObjects.idl
index a361beb0d2e4..031108cb624c 100644
--- a/oovbaapi/ooo/vba/excel/XLineObjects.idl
+++ b/oovbaapi/ooo/vba/excel/XLineObjects.idl
@@ -30,7 +30,7 @@ module ooo {  module vba { module excel {
 The following sheet symbols represent collections of line objects, and
 therefore implement this interface:
 Arcs: arc objects, and
-Lines: straight line ojects.
+Lines: straight line objects.
 
 This symbol is now deprecated in VBA but kept for compatibility with old
 VBA scripts.
diff --git a/oox/source/dump/xlsbdumper.ini b/oox/source/dump/xlsbdumper.ini
index e4b5f920edc6..4dc5346e3165 100644
--- a/oox/source/dump/xlsbdumper.ini
+++ b/oox/source/dump/xlsbdumper.ini
@@ -934,7 +934,7 @@ end
 
 # PTFITEM 
 
-shortlist=PTFITEM-TYPE,0,data,default,sum,count-all,average,max,min,product,count-mumbers,std-dev,std-dev-p,var,var-p,grand-total,blank
+shortlist=PTFITEM-TYPE,0,data,default,sum,count-all,average,max,min,product,count-numbers,std-dev,std-dev-p,var,var-p,grand-total,blank
 
 flagslist=PTFITEM-FLAGS
   0x0001=hidden
diff --git a/sfx2/classification/xNL.xsd b/sfx2/classification/xNL.xsd
index ce67d6367e26..1e5cafe16bc8 100644
--- a/sfx2/classification/xNL.xsd
+++ b/sfx2/classification/xNL.xsd
@@ -78,7 +78,7 @@



-   Tye of use of this data. e.g. 
data exchange, contact, update, create
+   Type of use of this data. 
e.g. data exchange, contact, update, create



diff --git a/sw/uiconfig/swriter/ui/notebookbar_compact.ui 
b/sw/uiconfig/swriter/ui/notebookbar_compact.ui
index ec1483fe1a04..018bf2abc7df 100644
--- a/sw/uiconfig/swriter/ui/notebookbar_compact.ui
+++ b/sw/uiconfig/swriter/ui/notebookbar_compact.ui
@@ -5454,7 +5454,7 @@
 center
 True
 
-  
+  
 Wrap
 True
 True
diff --git a/vcl/source/font/fontcache.cxx b/vcl/source/font/fontcache.cxx
index 011212fbdde3..f52eb6e30e16 100644
--- a/vcl/source/font/fontcache.cxx
+++ b/vcl/source/font/fontcache.cxx
@@ -217,7 +217,7 @@ LogicalFontInstance* ImplFontCache::GetGlyphFallbackFont( 
PhysicalFontCollection
 //fdo#33898 If someone has EUDC installed then they really want that to
 //be used as the first-choice glyph fallback seeing as it's filled with
 //private area codes with don't make any sense in any other font so
-//prioritise it here if it's available. Ideally we would remove from
+//prioritize it here if it's available. Ideally we would remove from
 //rMissingCodes all the glyphs which it is able to resolve as an
 //optimization, but that's tricky to achieve cross-platform without
 //sufficient heavy-weight code that's likely to undo the value of the
diff --git a/vcl/win/app/salinst.cxx b/vcl/win/app/salinst.cxx
index 02b9e76d65c1..125d375096a9 100644
--- a/vcl/win/app/salinst.cxx
+++ b/vcl/win/app/salinst.cxx
@@ -284,7 +284,7 @@ SalData::SalData()
 mnCacheDCInUse = 0; // count of CacheDC in use
 mbObjClassInit = false; // is SALOBJECTCLASS initialised
 mbInPalChange = false;  // is in WM_QUERYNEWPALETTE
-mnAppThreadId = 0;  // Id from Applikation-Thread
+mnAppThreadId = 0;  // Id from Application-Thread
 mbScrSvrEnabled = FALSE;// ScreenSaver enabled
 mpFirstIcon = nullptr;  // icon cache, points to first icon, NULL if 
none
 mpTempFontItem = nullptr;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sc/source svx/source

[Andrea Gelmini]

 sc/source/ui/view/viewfun7.cxx|2 +-
 svx/source/sdr/properties/attributeproperties.cxx |6 +++---
 svx/source/svdraw/svdobj.cxx  |4 ++--
 3 files changed, 6 insertions(+), 6 deletions(-)

New commits:
commit a65d69179ee0a2b8035746a8e4c8000770758974
Author: Andrea Gelmini 
Date:   Sat Apr 7 14:04:34 2018 +0200

Fix typos

Change-Id: I0c9d917b8673680dbd0729f7f9a4cf5a6e686908
Reviewed-on: https://gerrit.libreoffice.org/52543
Tested-by: Jenkins 
Reviewed-by: Julien Nabet 

diff --git a/sc/source/ui/view/viewfun7.cxx b/sc/source/ui/view/viewfun7.cxx
index 36e9df26a0bd..e92cac423167 100644
--- a/sc/source/ui/view/viewfun7.cxx
+++ b/sc/source/ui/view/viewfun7.cxx
@@ -153,7 +153,7 @@ void ScViewFunc::PasteDraw( const Point& rLogicPos, 
SdrModel* pModel,
 const SdrMark* pM=aMark.GetMark(nm);
 const SdrObject* pObj=pM->GetMarkedSdrObj();
 
-// Directly Clone to taget  SdrModel
+// Directly Clone to target SdrModel
 SdrObject* pNewObj(pObj->Clone(pDrawModel));
 
 if (pNewObj!=nullptr)
diff --git a/svx/source/sdr/properties/attributeproperties.cxx 
b/svx/source/sdr/properties/attributeproperties.cxx
index eab25a1526f8..7367abfbcb3d 100644
--- a/svx/source/sdr/properties/attributeproperties.cxx
+++ b/svx/source/sdr/properties/attributeproperties.cxx
@@ -238,7 +238,7 @@ namespace sdr
 const bool bHadSfxItemSet(HasSfxItemSet());
 
 // call parent - this will then guarantee
-// SfxItemSet existance
+// SfxItemSet existence
 DefaultProperties::GetObjectItemSet();
 
 if(!bHadSfxItemSet)
@@ -249,7 +249,7 @@ namespace sdr
 // it's creation. See copy-constructor and how it remembers
 // the SfxStyleSheet there.
 // It is necessary to reset mpStyleSheet to nullptr to
-// not trigger alarm insde ImpAddStyleSheet (!)
+// not trigger alarm inside ImpAddStyleSheet (!)
 SfxStyleSheet* pNew(mpStyleSheet);
 const_cast< AttributeProperties* >(this)->mpStyleSheet = 
nullptr;
 const_cast< AttributeProperties* >(this)->ImpAddStyleSheet(
@@ -357,7 +357,7 @@ namespace sdr
 
 void AttributeProperties::SetStyleSheet(SfxStyleSheet* pNewStyleSheet, 
bool bDontRemoveHardAttr)
 {
-// guarantee SfxItemSet existance here
+// guarantee SfxItemSet existence here
 if(!HasSfxItemSet())
 {
 GetObjectItemSet();
diff --git a/svx/source/svdraw/svdobj.cxx b/svx/source/svdraw/svdobj.cxx
index 5ec98ef00b9c..9351a676a5c7 100644
--- a/svx/source/svdraw/svdobj.cxx
+++ b/svx/source/svdraw/svdobj.cxx
@@ -227,7 +227,7 @@ sdr::properties::BaseProperties& SdrObject::GetProperties() 
const
 if(!mpProperties)
 {
 // CAUTION(!) Do *not* call this during SdrObject construction,
-// that will lead to wrong type-casts (dependent on costructor-level)
+// that will lead to wrong type-casts (dependent on constructor-level)
 // and thus eventually create the wrong sdr::properties (!). Is there
 // a way to check if on the stack is a SdrObject-constructor (?)
 const_cast< SdrObject* >(this)->mpProperties.reset(
@@ -444,7 +444,7 @@ void SdrObject::SetPage(SdrPage* pNewPage)
 // good to think about if this is really needed - it *seems* to be intended
 // for a xShape being a on-demand-creatable resource - wit hthe argument 
that
 // the SdrPage/UnoPage used influences the SvxShape creation. This uses
-// ressources and would be nice to get rid of anyways.
+// resources and would be nice to get rid of anyways.
 if (pOldPage != pPage && !(pOldPage && pPage && pOldModel == 
()))
 {
 SvxShape* const pShape(getSvxShape());
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 104790] [META] Database connectivity interfaces (ODBC, JDBC..) and external databases

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104790

Thomas Lendo  changed:

   What|Removed |Added

 Depends on||116968


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=116968
[Bug 116968] [META] Migrating existing embedded HSQLDB databases to Firebird
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116968] [META] Migrating existing embedded HSQLDB databases to Firebird

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116968

Thomas Lendo  changed:

   What|Removed |Added

 CC||thomas.le...@gmail.com
 Blocks||104790


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=104790
[Bug 104790] [META] Database connectivity interfaces (ODBC, JDBC..) and
external databases
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 94438] Duplicates of IDs in help files

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=94438

Olivier Hallot  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |olivier.hallot@documentfoun
   |desktop.org |dation.org

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 94438] Duplicates of IDs in help files

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=94438

--- Comment #4 from Olivier Hallot  ---
Changes at 

../helpcontent2/source/text/scalc/01/04060104.xhp   bm_id3159273
../helpcontent2/source/text/scalc/01/04060185.xhp   bm_id3150405
../helpcontent2/source/text/scalc/01/04060181.xhp   bm_id2947521
../helpcontent2/source/text/scalc/01/04060184.xhp   bm_id2950709

are valid. Patch submitted.

Changes in 

../helpcontent2/source/text/scalc/01/statistics.xhp bm_id05004
../helpcontent2/source/text/scalc/01/statistics.xhp bm_id05003
../helpcontent2/source/text/scalc/01/statistics.xhp bm_id05002

are not necessary because the same ID is used in different branch type (hid or
index)

(more to come)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: filter/source solenv/bin

[Andras Timar]

 filter/source/xslt/odf2xhtml/export/xhtml/body.xsl |2 +-
 solenv/bin/modules/installer/windows/file.pm   |4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

New commits:
commit cde434d1f6e611cd35de3595bdfc47769acc5d2d
Author: Andras Timar 
Date:   Thu Apr 12 13:44:28 2018 +0200

typo: requrired -> required

Change-Id: I0cd28356834a14a2f53545fb3c8e87f067eac789
Reviewed-on: https://gerrit.libreoffice.org/52776
Tested-by: Jenkins 
Reviewed-by: Julien Nabet 

diff --git a/filter/source/xslt/odf2xhtml/export/xhtml/body.xsl 
b/filter/source/xslt/odf2xhtml/export/xhtml/body.xsl
index e58da338603a..570c9304af7e 100644
--- a/filter/source/xslt/odf2xhtml/export/xhtml/body.xsl
+++ b/filter/source/xslt/odf2xhtml/export/xhtml/body.xsl
@@ -1948,7 +1948,7 @@
 A numbered label (e.g. 2.C.III) is created for every 
text:list-item/header.
 Above list levels are listed in the label, if the 
list-style requires this. Levels are separated by a '.'
 Formatation is dependent for every list level depth.
-The label is passed from anchestor text:list-item/header 
and if requrired truncated.
+The label is passed from anchestor text:list-item/header 
and if required truncated.
 The prefix/suffix (as well list level dependent) comes 
before and after the complete label (after truncation)
 -->
 
diff --git a/solenv/bin/modules/installer/windows/file.pm 
b/solenv/bin/modules/installer/windows/file.pm
index acd9792b8213..43b2ef3e858f 100644
--- a/solenv/bin/modules/installer/windows/file.pm
+++ b/solenv/bin/modules/installer/windows/file.pm
@@ -32,7 +32,7 @@ use installer::windows::language;
 use installer::windows::component;
 
 ##
-# Assigning one cabinet file to each file. This is requrired,
+# Assigning one cabinet file to each file. This is required,
 # if cabinet files shall be equivalent to packages.
 ##
 
@@ -108,7 +108,7 @@ sub assign_cab_to_files
 }
 
 ##
-# Assigning sequencenumbers to files. This is requrired,
+# Assigning sequencenumbers to files. This is required,
 # if cabinet files shall be equivalent to packages.
 ##
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: external/firebird

[Stephan Bergmann]

 external/firebird/asan.patch |   20 
 1 file changed, 20 insertions(+)

New commits:
commit 7ba4d6f367aacec69b3a3707e55085cc7303e573
Author: Stephan Bergmann 
Date:   Thu Apr 12 15:02:45 2018 +0200

external/firebird: More LIBO_TUNNEL_LIBRARY_PATH

...after 14955ed91b282ccbb395cb47c6d76e3b42b34748 "external/firebird: 
Support
Clang ASan", which was oddly enough only necessary on one machine,
, but not 
on
others.  Maybe the best fix overall would be to just not build examples at 
all,
as is already done in external/firebird/firebird-cygwin-msvc.patch.

Change-Id: I7dd37c93ea5a55cb26a167e52d22a6f50c05494e
Reviewed-on: https://gerrit.libreoffice.org/52779
Tested-by: Jenkins 
Reviewed-by: Stephan Bergmann 

diff --git a/external/firebird/asan.patch b/external/firebird/asan.patch
index 33d418513fba..fa9c4d88b249 100644
--- a/external/firebird/asan.patch
+++ b/external/firebird/asan.patch
@@ -55,6 +55,26 @@
$(CHMOD_6) $@
  
  $(BUILD_FILE):$(BUILD_Objects) $(COMMON_LIB)
+--- builds/posix/Makefile.in.examples
 builds/posix/Makefile.in.examples
+@@ -140,7 +140,7 @@
+ 
+ $(EXAMPLES_DEST)/empbuild.fdb : $(EXAMPLES_DEST)/empddl.sql 
$(EXAMPLES_DEST)/empbld.sql $(EXAMPLES_DEST)/isql$(EXEC_EXT)
+   -$(RM) $(EXAMPLES_DEST)/empbuild.fdb
+-  $(EXAMPLES_DEST)/isql$(EXEC_EXT) -i empbld.sql
++  $(LIBO_TUNNEL_LIBRARY_PATH) $(EXAMPLES_DEST)/isql$(EXEC_EXT) -i 
empbld.sql
+ 
+ # The chain for intlemp.fdb is the same a script file to create an empty 
database
+ # to allow a .e program to be compiled, to then create and populate with data
+@@ -158,7 +158,7 @@
+ 
+ $(EXAMPLES_DEST)/intlbuild.fdb : $(EXAMPLES_DEST)/intlddl.sql 
$(EXAMPLES_DEST)/intlbld.sql $(EXAMPLES_DEST)/isql$(EXEC_EXT)
+   -$(RM) intlbuild.fdb
+-  $(EXAMPLES_DEST)/isql$(EXEC_EXT) -i intlbld.sql
++  $(LIBO_TUNNEL_LIBRARY_PATH) $(EXAMPLES_DEST)/isql$(EXEC_EXT) -i 
intlbld.sql
+ 
+ 
+ $(EXAMPLES_DEST)/%.sql: $(EXAMPLES_SRC)/empbuild/%.sql
 --- builds/posix/make.rules
 +++ builds/posix/make.rules
 @@ -68,17 +68,17 @@
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 116977] CRASH: LibreOffice crashes being closed with content in the clipboard (gtk3)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116977

--- Comment #4 from Telesto  ---
(In reply to Xisco Faulí from comment #3)
> @Telesto, I'm not sure bug 116974 is a dupe of this one.
> I can only reproduce it with GTk3...

I get a crash following the steps of comment 0, so..
Version: 6.1.0.0.alpha0+
Build ID: 84e2614a75a615d6c8584b13a69b3368d2a12a3d
CPU threads: 4; OS: Windows 6.3; UI render: default; 
TinderBox: Win-x86@42, Branch:master, Time: 2018-04-12_09:11:38
Locale: nl-NL (nl_NL); Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 116944] Firebird-migration must happen only after user consent and advise to backup data prior to migration at 6.1

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116944

Gerhard Weydt  changed:

   What|Removed |Added

 CC||gerhard.we...@t-online.de

--- Comment #7 from Gerhard Weydt  ---
I totally agree with comment #6. I just want to point out some more problems.
Showing a warning if the migration didn't work or even before migrating is too
late, because the user has already updated LibreOffice, so he has no chance to
get at his data with that release. Surely, it is possible to do a parallel
installation, but many people will not know that or might not be able to do it
or simply give up, frustrated, and are lost for LibreOffice.
There has to be at least one release, say 6.0, where HSQLDB and Firebird run in
parallel, and informing the user that the database should be migrated to
Firebird for the future, but that he should first try it using a copy of his
database document.
Some might say that we have already had that period of parallel database
systems, but I am sure that most people will not have known that because you
could know about Firebird only if you had activated the experimental features,
or had read it somewhere, for example in Roberts Base handbook. I am using Bae
myself, with MariaDB when it's possible, but also with HSQLDB, but I haven't
yet tried Firebird, because I always heard it still was lacking functionality.
So I underline Florian's remark that the change is too quick.
But even an infobar in 6.0 when opening a database document with HSQLDB that
the database should be migrated to Firebird, because in 6.1 HSQLDB will no
longer be supported (the version nummbers only as an example) will not be
sufficient, there may be people updating from 5.4 to 6.1, they will never have
got that message.
I have no convincing proposal how to cope with this problem, yet, the only idea
I have for the moment is warning at the start of the installation describing
the problem and, if applicable, proposing to update first to the intermediate
version and test the migration before doing the second update. That's not very
comfortable.
All would be easier if someone could guarantee that the migration to Firebird
will always work, but who would be able to do that? Robert's experience shows
that we are far away from that.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 116944] Firebird-migration must happen only after user consent and advise to backup data prior to migration at 6.1

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116944

Gerhard Weydt  changed:

   What|Removed |Added

 CC||gerhard.we...@t-online.de

--- Comment #7 from Gerhard Weydt  ---
I totally agree with comment #6. I just want to point out some more problems.
Showing a warning if the migration didn't work or even before migrating is too
late, because the user has already updated LibreOffice, so he has no chance to
get at his data with that release. Surely, it is possible to do a parallel
installation, but many people will not know that or might not be able to do it
or simply give up, frustrated, and are lost for LibreOffice.
There has to be at least one release, say 6.0, where HSQLDB and Firebird run in
parallel, and informing the user that the database should be migrated to
Firebird for the future, but that he should first try it using a copy of his
database document.
Some might say that we have already had that period of parallel database
systems, but I am sure that most people will not have known that because you
could know about Firebird only if you had activated the experimental features,
or had read it somewhere, for example in Roberts Base handbook. I am using Bae
myself, with MariaDB when it's possible, but also with HSQLDB, but I haven't
yet tried Firebird, because I always heard it still was lacking functionality.
So I underline Florian's remark that the change is too quick.
But even an infobar in 6.0 when opening a database document with HSQLDB that
the database should be migrated to Firebird, because in 6.1 HSQLDB will no
longer be supported (the version nummbers only as an example) will not be
sufficient, there may be people updating from 5.4 to 6.1, they will never have
got that message.
I have no convincing proposal how to cope with this problem, yet, the only idea
I have for the moment is warning at the start of the installation describing
the problem and, if applicable, proposing to update first to the intermediate
version and test the migration before doing the second update. That's not very
comfortable.
All would be easier if someone could guarantee that the migration to Firebird
will always work, but who would be able to do that? Robert's experience shows
that we are far away from that.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116979] [META] Regression introduced by Aw080

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116979

Xisco Faulí  changed:

   What|Removed |Added

 Depends on||116879


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=116879
[Bug 116879] Crash when showing Comment
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116879] Crash when showing Comment

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116879

Xisco Faulí  changed:

   What|Removed |Added

 Blocks||116979


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=116979
[Bug 116979] [META] Regression introduced by Aw080
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116979] [META] Regression introduced by Aw080

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116979

Xisco Faulí  changed:

   What|Removed |Added

 Depends on||116977


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=116977
[Bug 116977] CRASH: LibreOffice crashes being closed with content in the
clipboard (gtk3)
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116977] CRASH: LibreOffice crashes being closed with content in the clipboard (gtk3)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116977

Xisco Faulí  changed:

   What|Removed |Added

 Blocks||116979


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=116979
[Bug 116979] [META] Regression introduced by Aw080
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116974] Crash on closing after copying of a table from Impress to Draw

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116974

Xisco Faulí  changed:

   What|Removed |Added

 Blocks||116979


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=116979
[Bug 116979] [META] Regression introduced by Aw080
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116979] [META] Regression introduced by Aw080

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116979

Xisco Faulí  changed:

   What|Removed |Added

 Depends on||116974


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=116974
[Bug 116974] Crash on closing after copying of a table from Impress to Draw
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116978] No 'Save Changes' dialog after pasting a table to a new draw document

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116978

Xisco Faulí  changed:

   What|Removed |Added

 Blocks||116979


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=116979
[Bug 116979] [META] Regression introduced by Aw080
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116979] [META] Regression introduced by Aw080

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116979

Xisco Faulí  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
URL||https://wiki.openoffice.org
   ||/wiki/Aw080_documentation
 CC||xiscofa...@libreoffice.org
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=95
   ||812
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116979] [META] Regression introduced by Aw080

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116979

Xisco Faulí  changed:

   What|Removed |Added

 Depends on||116978


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=116978
[Bug 116978] No 'Save Changes' dialog after pasting a table to a new draw
document
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116979] [META] Regression introduced by Aw080

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116979

Xisco Faulí  changed:

   What|Removed |Added

  Alias||AW080-Regressions

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116979] New: [META] Regression introduced by Aw080

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116979

Bug ID: 116979
   Summary: [META] Regression introduced by Aw080
   Product: LibreOffice
   Version: 6.1.0.0.alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: xiscofa...@libreoffice.org

Commit so far:

https://cgit.freedesktop.org/libreoffice/core/commit/?id=dfefe448c41921f2f1e54d3f69b8b9e89031d055

More info:
- Bug 95812
- https://wiki.openoffice.org/wiki/Aw080_documentation

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: desktop/source

[Marco Cecchetti]

 desktop/source/lib/init.cxx |7 +--
 1 file changed, 5 insertions(+), 2 deletions(-)

New commits:
commit 2977e8d7c2a0bf62fa70a728a88cc6bddfc87ffd
Author: Marco Cecchetti 
Date:   Sun Apr 8 12:12:27 2018 +0200

lok: sc: clicking outside a pop-up or context menu doesn't close it

Change-Id: Iecf0659467264d921c7c9faddc98fd5519e7db93
Reviewed-on: https://gerrit.libreoffice.org/52617
Reviewed-by: Jan Holesovsky 
Tested-by: Jan Holesovsky 
(cherry picked from commit 1cd76097043a5ece899dd7c9468755dcd961b0eb)
Reviewed-on: https://gerrit.libreoffice.org/52736
Tested-by: Jenkins 

diff --git a/desktop/source/lib/init.cxx b/desktop/source/lib/init.cxx
index 28feff959221..6e4d1cff8556 100644
--- a/desktop/source/lib/init.cxx
+++ b/desktop/source/lib/init.cxx
@@ -80,6 +80,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -3437,10 +3438,12 @@ static void doc_postWindow(LibreOfficeKitDocument* 
/*pThis*/, unsigned nLOKWindo
 return;
 }
 
-if (Dialog* pDialog = dynamic_cast(pWindow.get()))
+if (nAction == LOK_WINDOW_CLOSE)
 {
-if (nAction == LOK_WINDOW_CLOSE)
+if (Dialog* pDialog = dynamic_cast(pWindow.get()))
 pDialog->Close();
+else if (FloatingWindow* pFloatWin = 
dynamic_cast(pWindow.get()))
+pFloatWin->EndPopupMode(FloatWinPopupEndFlags::Cancel | 
FloatWinPopupEndFlags::CloseAll);
 }
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 116974] Crash on closing after copying of a table from Impress to Draw

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116974

--- Comment #4 from Xisco Faulí  ---
Save dialog problem reported in bug 116978

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116978] No 'Save Changes' dialog after pasting a table to a new draw document

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116978

Xisco Faulí  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116978] No 'Save Changes' dialog after pasting a table to a new draw document

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116978

Xisco Faulí  changed:

   What|Removed |Added

   Keywords||bibisected, bisected,
   ||regression
 CC||armin.le.gr...@me.com,
   ||xiscofa...@libreoffice.org

--- Comment #1 from Xisco Faulí  ---
Regression introduced by:

author  Armin Le Grand 2018-03-01 15:54:32
+0100
committer   Armin Le Grand   2018-04-07 00:28:30
+0200
commit  dfefe448c41921f2f1e54d3f69b8b9e89031d055 (patch)
tree1aace31054b5740e2faffcbc5de66a791be27f7d
parent  eba4d5b2b76cefde90cb3d6638c736f435023a45 (diff)
SOSAW080: Added first bunch of basic changes to helpers

Bisected with: bibisect-linux64-6.1

Adding Cc: to Armin Le Grand

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116978] New: No 'Save Changes' dialog after pasting a table to a new draw document

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116978

Bug ID: 116978
   Summary: No 'Save Changes' dialog after pasting a table to a
new draw document
   Product: LibreOffice
   Version: 6.1.0.0.alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Draw
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: xiscofa...@libreoffice.org

Steps to reproduce:
1. Open attachment 141151
2. Select the table clicking in one of its corners
3. Copy it
4. Create a new Draw Document
5. Paste the Table
6. Close the Draw document

-> No 'Do you want to save your chages?' dialog

Reproduced in

Version: 6.1.0.0.alpha0+
Build ID: 24a57e2b854a1b8b3b8533ac72a6614ee29e374a
CPU threads: 4; OS: Linux 4.13; UI render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103182] [META] GTK3-specific bugs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103182

Xisco Faulí  changed:

   What|Removed |Added

 Depends on||116977


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=116977
[Bug 116977] CRASH: LibreOffice crashes being closed with content in the
clipboard (gtk3)
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs