[Libreoffice] [REVIEW] backport NSS build fixes for 3.4

2011-10-18 Thread Michael Stahl
hi all, i need the following commits to build nss and moz on a linux 3.1 kernel: http://cgit.freedesktop.org/libreoffice/core/commit/?id=ab3895465a6cf0a8a41c7432ad9a8f77df7ae572 http://cgit.freedesktop.org/libreoffice/core/commit/?id=fa70d98e729c0dba44e1c8e25fe1323bad918945 please somebody

Re: [Libreoffice] Decoupled NSS and Mozilla in the build

2011-10-18 Thread Michael Stahl
On 18.10.2011 12:20, Jan Holesovsky wrote: After this, I believe the only use of Mozilla (module moz) in our build is the Mozilla address book. Or do you know of any other use? for other vague memories of moz usage see also:

Re: [Libreoffice] Trying to identify a webdav bug fixed in LibreOffice but not in Open Office

2011-10-19 Thread Michael Stahl
On 19/10/11 11:00, Julien Petit wrote: Hello everyone, last year i experienced the following bug with webdav in Open Office : https://issues.apache.org/ooo/show_bug.cgi?id=113354 When saving an already existing document on a wedav server, the file got truncated. A few month ago i changed to

Re: [Libreoffice] Properties not accessible

2011-10-19 Thread Michael Stahl
hi Knut, On 13/10/11 12:09, Knut Olav Bøhmer wrote: Hi, Why is it that some properties on some objects/services are not settable from BASIC? Like for example ThisComponent.getTextSections().getByName(sectionName).IsAutomaticUpdate = True has no effect Is it some way to fix it? it looks like

Re: [Libreoffice] Unexpected failures (eg. segfaults) using PyUNO and LibreOffice/OpenOffice

2011-10-21 Thread Michael Stahl
On 19/10/11 10:17, Dag Wieers wrote: Hi, During the course of the LibreOffice conference in Paris, we (the unoconv and cloudooo projects) found that some of the issues our users were having while doing document conversions using PyUNO and OpenOffice and LibreOffice were not related to our own

[Libreoffice] SolarMutex usage...

2011-10-21 Thread Michael Stahl
is there any authoritative documentation on when exactly the SolarMutex should be locked when coming from the UI? i know that it must be locked on UNO API method entry in the parts of the code that are not otherwise threadsafe, but i have no idea how the UI stuff / VCL works. for example,

[Libreoffice] [PUSHED] Re: [REVIEW-3-4] Fix fdo#41995 fallout - recognize .svg in odf container

2011-10-21 Thread Michael Stahl
On 21/10/11 11:59, Thorsten Behrens wrote: Hi there, it seems, though the filter is there, we don't read .svg files from the Pictures stream inside the odf zip container. Easy fix attached, could someone please review commit to -3-4? Cheers, -- Thorsten have reviewed and pushed to -3-4.

[Libreoffice] Gmane address mangling

2011-10-21 Thread Michael Stahl
hi all, noticed that i just committed thb's patch with a Gmane mangled mail address :( is there a particular reason why this list is using the address mangling? looks like the addresses aren't that well protected in the fd.o web interface anyway e.g. 'mstahl at redhat.com'. and also the

Re: [Libreoffice] gbuild: use gb_CHECKOBJECTOWNER to check for double linked objects

2011-10-21 Thread Michael Stahl
On 21/04/11 18:33, Bjoern Michaelsen wrote: On Tue, 19 Apr 2011 18:24:57 +0100 Michael Meeksmichael.me...@novell.com wrote: If not, it sounds like we should have it always enabled (?), particularly if we can cleanup the issues it finds :-) Enabled by default on master with:

Re: [Libreoffice] unowinreg.dll usage

2011-10-24 Thread Michael Stahl
On 23/10/11 14:10, Tomáš Chvátal wrote: Tor I am not whining because it is dll, I am asking because it is another weird file libreoffice requests me to download, and for this one I was unable to think of any usage. interesting that it is now downloaded; back in OOo it used to be

Re: [Libreoffice] build error in tail_build

2011-10-24 Thread Michael Stahl
On 20/10/11 09:00, Noel Grandin wrote: Hi Building on Windows using Visual Studio, running into a build error in ScriptProviderForJava. Trimmed build log attached. Any ideas? Thanks, Noel Grandin have had this problem myself today, the command for compiling java files does not do the

Re: [Libreoffice] [REVIEW] Cherry-pick to 3-4? commit f33232a3ff67d7a4def830fa6fda78ef5f255ae7

2011-10-25 Thread Michael Stahl
On 25/10/11 09:37, Tor Lillqvist wrote: See fdo#36950 for discussion. It doesn't seem to make sense to push a backport of the commit to the 3-4 branch, as we don't know if it actually helps the problem. OK, now some more people have verified that the fix helps for them in the situation it

Re: [Libreoffice] Cherry-pick request for libreoffice-3-4-4

2011-10-26 Thread Michael Stahl
On 26/10/11 12:00, Fridrich Strba wrote: Hello good people, Could 2 additional people OK this for inclusion in libreoffice-3-4-4 branch? http://cgit.freedesktop.org/libreoffice/bootstrap/commit/?h=libreoffice-3-4id=b1e37e258351a51556d4128d08768edd8fd05d3d

Re: [Libreoffice] [REVIEW-3-4] fix ole automation bridge handling of SAFEARRAY (fdo#38441)

2011-10-26 Thread Michael Stahl
On 26/10/11 18:55, Noel Power wrote: there were at least a few people trying to make this a blocker for 3.4 ( makes ole automation quite broken ), the fix on master I would like to backport is here http://cgit.freedesktop.org/libreoffice/core/commit/?id=3fcb94311fd7dd40c05ca132e3a30a888316cbbe

Re: [Libreoffice] [PUSHED}[PATCH] leaking connection handles

2011-10-28 Thread Michael Stahl
On 28/10/11 16:06, Noel Power wrote: Without getting into a religous war about it I personally don't buy that OSL_ENSURE should abort ( I am though a believer in that behaviour for for OSL_ASSERT ) Perhaps I am abusing the true use for OSL_ENSURE, maybe there is a case for an OSL_WARNING ( but

Re: [Libreoffice] gnu make help needed in localization of extension descriptions

2011-11-02 Thread Michael Stahl
On 02/11/11 11:34, Andras Timar wrote: Hi, I developed a small feature. Now localization tools can extract extension name and description from description.xml of our bundled extensions (dictionaries, PDF Import, etc.). Translators will translate them, so they will be localized in Extension

Re: [Libreoffice] gnu make help needed in localization of extension descriptions

2011-11-07 Thread Michael Stahl
On 03/11/11 00:13, Andras Timar wrote: 2011/11/2 Michael Stahlmst...@redhat.com: On 02/11/11 11:34, Andras Timar wrote: Hi, I developed a small feature. Now localization tools can extract extension name and description from description.xml of our bundled extensions (dictionaries, PDF Import,

Re: [Libreoffice] External versus internal

2011-11-07 Thread Michael Stahl
On 07/11/11 11:36, Matúš Kukan wrote: On 7 November 2011 00:50, Nuzhna Pomoshchnuzhna_pomos...@yahoo.com wrote: Note in particular: --without-system-headers --without-system-libs You don't have to use these, that's default. As you can see, it is attempting to use all external programs. I

Re: [Libreoffice] SDK LibreOffice How to get document as object?

2011-11-08 Thread Michael Stahl
On 08/11/11 15:55, webmas...@csz-online.de wrote: Hi, I'm currently working on some data format exportation tests with the LibreOffice SDK and Java. I want to develop an addon, which can export the current opened file in another dataformat. I already have some converter-methods, which can be

Re: [Libreoffice] [PATCH] Replace command domainname by getdomainname() on Unix

2011-11-14 Thread Michael Stahl
On 14/11/11 12:30, Michael Meeks wrote: On Sun, 2011-11-13 at 12:06 +0200, Tor Lillqvist wrote: But in general we should avoid potentially pointless DNS calls. Let's not risk having to wait for DNS timeouts in badly configured situations. I think there has been bug reports of OOo and/or LO

Re: [Libreoffice] TextSection, TextCursor and component

2011-11-14 Thread Michael Stahl
On 14/11/11 00:02, Knut Olav Bøhmer wrote: Hi, Is it allowed to insert a TextSection in to a document which was created from another document? Like this: doc1 = StarDesktop.loadComponentFromURL(private:factory/swriter, _blank, 0, Array()) doc2 =

Re: [Libreoffice] SDK LibreOffice How to get document as object?

2011-11-14 Thread Michael Stahl
On 08/11/11 20:53, Clemens A. Schulz wrote: Hi Michael, On Tue, 2011-11-08 at 15:55 +0100, webmas...@csz-online.de wrote: I'm currently working on some data format exportation tests with the LibreOffice SDK and Java. I want to develop an addon, which can export the current opened file in

Re: [Libreoffice] [PATCH] Replace command domainname by getdomainname() on Unix

2011-11-14 Thread Michael Stahl
On 14/11/11 14:23, Tor Lillqvist wrote: Considering actual multi-user site scenarios, I think it is fairly useless to have the name of the machine in the lock file. Consider these examples: 1) Alice wants to edit a document. Computer says No. Er, sorry, been watching too much Little Britain. I

Re: [Libreoffice] bug in Jar_ScriptProviderForJava.mk?

2011-11-15 Thread Michael Stahl
On 15/11/11 09:26, Noel Grandin wrote: /scripting/Jar_ScriptProviderForJava.mk has the following lines in it: /31 $(eval $(call gb_Jar_add_jars,ScriptProviderForJava,\ 32 $(OUTDIR)/bin/juh.jar \ 33 $(OUTDIR)/bin/jurt.jar \ 34 $(OUTDIR)/bin/ridl.jar \ 35 $(OUTDIR)/bin/unoil.jar \ 36

Re: [Libreoffice] uno discoverability

2011-11-15 Thread Michael Stahl
On 15/11/11 18:17, Thorsten Behrens wrote: Kevin Hunter wrote: One of the things that I find extremely frustrating is the lack of discoverability from within the Python context. Hi Kevin, beyond the pure python functionality, that would indeed benefit from some insightful help texts, there's

Re: [Libreoffice] uno discoverability

2011-11-15 Thread Michael Stahl
On 15/11/11 19:57, Kevin Hunter wrote: Is it similarly as convoluted and difficult to have an explanation with, say, RuntimeExceptions? For instance, with a document with only one sheet, one should not be able to remove the last sheet, right? doc.Sheets.removeByName('Sheet1')

Re: [Libreoffice] build fail: workdir/wntmsci12.pro/Dep/SdiTarget/basctl/sdi/basslots.d:1: *** target pattern contains no `%'

2011-11-15 Thread Michael Stahl
do you (or anybody else) still have this problem? Fridrich claimed that the new SdiTarget dependencies work for him, so i wonder why they don't work for everyone :) what GNU make do you use? the one from cygwin? c:/libreoffice/libo/workdir/wntmsci12.pro/SdiTarget/basctl/sdi/basslots : \

Re: [Libreoffice] error when building cmis stuff

2011-11-16 Thread Michael Stahl
On 16/11/11 09:13, Noel Grandin wrote: Hi I'm getting a build fail using Cygwin on Windows when building the ucb/cmis module. From a cursory examination it looks like some .. are missing from the path to the cms_provider object files? indeed, it seems the relative path to the objects is

Re: [Libreoffice] uno discoverability

2011-11-16 Thread Michael Stahl
On 16/11/11 11:25, Michael Meeks wrote: On Tue, 2011-11-15 at 20:34 +0100, Michael Stahl wrote: in a lot of UNO API implementations the only form of error reporting used is throw RuntimeException;, which leaves (as you correctly note) a lot to be desired in terms of usability for the hapless

Re: [Libreoffice] bug in Jar_ScriptProviderForJava.mk?

2011-11-16 Thread Michael Stahl
On 16/11/11 12:48, Noel Grandin wrote: Michael Stahl wrote: hmm... if you edit Jar_ScriptProviderForJava.mk, and move ScriptFramework.jar first, what happens then? also you could try to edit solenv/gbuild/JavaClassSet.mk, and in the definition of gb_JavaClassSet_add_jar replace all eval

Re: [Libreoffice] [PATCH] Fix for fdo#42178

2011-11-16 Thread Michael Stahl
On 16/11/11 14:35, Ivan Timofeev wrote: Hi there, I have fixed https://bugs.freedesktop.org/show_bug.cgi?id=42178 :-) , but I think an additional review will not be superfluous, since I am still a newbie. The fact is SwDocShell::GetWrtShell() always returns 0 in page preview. And Writer

Re: [Libreoffice] [PATCH] fix for fdo#40831 - Writer will crash when searching text with using regular expressions

2011-11-16 Thread Michael Stahl
On 12/11/11 08:27, Tomofumi Yagi wrote: Hi All, This patch will fix fdo#40831 Writer will crash when searching text with using regular expressions. Please review my attached patch. Bug URL: https://bugs.freedesktop.org/show_bug.cgi?id=40831 I reproduced this bug on LibO 3.4 and 3.5.

Re: [Libreoffice] [PATCH] Fix for fdo#42178

2011-11-16 Thread Michael Stahl
On 16/11/11 17:15, Ivan Timofeev wrote: 2011/11/16 Michael Stahl mst...@redhat.com: your workaround looks good (but please add an assertion for the case that we don't get any page number, i.e. OSL_ENSURE(pPreView,...)) Ok! isn't m_pPrintUIOptions supposed to be deleted when

Re: [Libreoffice] [PATCH] Fix for fdo#42178

2011-11-16 Thread Michael Stahl
On 16/11/11 17:30, Michael Stahl wrote: On 16/11/11 17:15, Ivan Timofeev wrote: 2011/11/16 Michael Stahl mst...@redhat.com: When canceling in the print dialog, PrinterController::abortJob() is called, and abortJob calls getPageFile. Your code above returns *before* the call to printPage

Re: [Libreoffice] [PATCH/REVIEW-3-4] Backport reading AES-encrypted ODF 1.2 documents (as genereated by LibO 3.5)

2011-11-17 Thread Michael Stahl
On 11/11/11 10:50, Stephan Bergmann wrote: With LO 3.5 by default using (new in ODF 1.2) AES encryption for password-protected documents (instead of Blowfish as used in older versions), people still using LO 3.4 would be unable to open such documents. (And what's really ugly, all they

Re: [Libreoffice] [Patch] Unreachable code ?

2011-11-17 Thread Michael Stahl
On 17/11/11 17:18, Michael Meeks wrote: Hi Muthu, On Wed, 2011-11-16 at 17:34 +0530, Muthu Subramanian K wrote: I have attached a trivial code removal with this mail. I read the code, (since pUndoSet is set to null in the very constructor, I guess this if() would never get executed), but, I

Re: [Libreoffice] [PATCH] Fix for fdo#42178

2011-11-18 Thread Michael Stahl
On 17/11/11 20:11, Ivan Timofeev wrote: 16.11.2011 21:27, Ivan Timofeev пишет: Can not reproduce crash with removed lines. Oh, what a terrible formulation! I mean, Can not reproduce crash, even without the mentioned lines of code. So, should I commit this removal? hi Ivan, certainly,

Re: [Libreoffice] Gmane address mangling

2011-11-18 Thread Michael Stahl
On 21/10/11 13:33, Thorsten Behrens wrote: Michael Stahl wrote: would anybody object to turning it off? Nope, go for it. It has bitten a few others before already... it's disabled since a couple of days now... ___ LibreOffice mailing list

[Libreoffice] [PUSHED] Re: [PATCH] writer AnchoredObjects accessed after deletion under some circumstances

2011-11-18 Thread Michael Stahl
On 10/11/11 17:44, Caolán McNamara wrote: So, I have a document which triggers the attached traces.txt if I close the document before the layout completes. Here's what I think I see. The SwView goes away first, and the writer layout hierarchy goes away with it. Then the SwDoc goes away. The

Re: [Libreoffice] Howto develop an extension with URE?

2011-11-18 Thread Michael Stahl
On 18/11/11 20:41, Christian Ehrlicher wrote: The kde4 plugin for libreoffice has a problem - creating qpixmaps outside the main thread is no allowed - crashes and the other end gives me the error message. in case this is your only problem you can select another VCL plugin: e.g. use this if

[Libreoffice] [PUSHED] Re: [PATCH] fix for fdo#40831 - Writer will crash when searching text with using regular expressions

2011-11-18 Thread Michael Stahl
On 16/11/11 16:08, Tomofumi Yagi wrote: I attached a revised patch. hi Tomofumi, thank you for your patch; i have pushed it, but not as a fix to the bug 40831 :) On 17/11/11 09:27, Cedric Bosdonnat wrote: Hi Michael, On Wed, 2011-11-16 at 16:20 +0100, Michael Stahl wrote: now i

Re: [Libreoffice] [PATCH/REVIEW-3-4] Backport reading AES-encrypted ODF 1.2 documents (as genereated by LibO 3.5)

2011-11-19 Thread Michael Stahl
On 19/11/11 09:40, Cor Nouws wrote: Stephan Bergmann wrote (18-11-11 15:27) On 11/18/2011 02:21 PM, Cor Nouws wrote: So I have to interpret it as: an encrypted document from 3.5 opened in 3.4 will be saved with the old encryption, without notice? Yes. Sorry for my unclear muttering. No

Re: [Libreoffice] Assertions and Logging

2011-11-22 Thread Michael Stahl
On 18/11/11 15:25, Stephan Bergmann wrote: The downside of that mixture is that the useful debugging technique of aborting upon detection of a violated invariant is not available.---If you make OSL_ASSERT (and OSL_ENSURE, OSL_FAIL, etc.) abort, it will abort far too often for mundane

Re: [Libreoffice] how to print into .ps

2011-11-22 Thread Michael Stahl
On 22/11/11 13:02, Petr Mladek wrote: Hi, if you select Print to File check box in the Print dialog, it generates .pdf file. IMHO, if you debug printing bugs, it would be great to see the .ps file that is send to the printer. Is there any easy way how to get it? AFAIK on UNIX we don't

Re: [Libreoffice] Assertions and Logging

2011-11-22 Thread Michael Stahl
On 22/11/11 13:54, Tor Lillqvist wrote: Agree. The only valid reason for not having all debug tools compiled in is runtime performance and binary size. Which brings up the question: Should my attempts to use the MSVC debugging runtime (and debug code in its headers, i.e. -D_DEBUG) when

Re: [Libreoffice] Windows build breakage

2011-11-23 Thread Michael Stahl
On 23/11/11 05:41, Kohei Yoshida wrote: Hi there, So, not having been able to build master on Windows for almost 2 months, I've decided to give it another go. But it fails in scripting this time, and I have no clue. The build log is attached. Hopefully this will ring a bell for

[Libreoffice] sw: serial numbers

2011-11-23 Thread Michael Stahl
hi all, i am currently wondering: in sw, a bunch of classes define serial numbers, e.g. SwIndex, SwNode, etc. in a DBG_UTIL build, there is a global counter, and the ctor increments the counter and assigns its value to a member, so every instance has a unique serial. what is the point of this?

Re: [Libreoffice] help asked/offered for bug 36555

2011-11-23 Thread Michael Stahl
On 23/11/11 11:14, Winfried Donkers wrote: Now I get the following: config.status: executing depfiles commands MAKE version 5.2 Copyright (c) 1987, 2000 Borland Error makefile 871: Colon expected you shouldn't be using Borland make :) *** 1 errors during make *** make: ***

Re: [Libreoffice] errors in idl files

2011-11-23 Thread Michael Stahl
On 23/11/11 18:02, Tomas Hlavaty wrote: Hi all, I would like to report a few errors in idl files, see below. Also, is the binary format of the binary rdb files specified and described somewhere? it is described somewhere on openoffice.org... ...but i can't find the well hidden

Re: [Libreoffice] Need some informations on format attributes

2011-11-24 Thread Michael Stahl
On 23/11/11 19:06, Maxime de Roucy wrote: Hello I am the author of the bug number 43067 ( https://bugs.freedesktop.org/show_bug.cgi?id=43067 ). I am trying to solve that bug. I tried to insert rWrtShell.ResetAttr(); just before the rWrtShell.SetAttr(*pTemplateItemSet); line. It

Re: [Libreoffice] text:class-names and nested text:span/text:style-name

2011-11-24 Thread Michael Stahl
On 24/11/11 16:37, Dag Wieers wrote: On Thu, 24 Nov 2011, Dag Wieers wrote: Case 1: Using text:class-names text:span text:class-names=strongbold text:span text:class-names=strong blueblue/text:span bold/text:span No syles seem to have been applied. i have found some rudimentary

Re: [Libreoffice] minutes of tech. steering call ...

2011-11-25 Thread Michael Stahl
On 24/11/11 21:23, Caolán McNamara wrote: On Thu, 2011-11-24 at 16:26 +, Michael Meeks wrote: + subsequentcheck + number of ways to improve it (Caolan) the way i've always debugged it is something like: DISPLAY=:42 ./soffice --accept=pipe,name=$USER;urp; --norestore

Re: [Libreoffice] [PUSHED][PATCH] SwSelBoxes: svarray - std::map

2011-11-25 Thread Michael Stahl
On 24/11/11 21:35, Caolán McNamara wrote: On Thu, 2011-11-24 at 15:58 +, Caolán McNamara wrote: On Thu, 2011-11-24 at 23:19 +0900, Daisuke Nishino wrote: I'm not sure if this is related to the problem, but I found an obvious mistake. I hope this patch fixes it. I'm sorry for

Re: [Libreoffice] Assertions and Logging

2011-11-28 Thread Michael Stahl
[somehow this mail got eaten somewhere, so i'll send it again...] On 22/11/11 13:15, Bjoern Michaelsen wrote: Hi Michael, Stephan, all, On Tue, Nov 22, 2011 at 12:46:52PM +0100, Michael Stahl wrote: one requirement i would have on conditional compilation is that, whether --disable-dbgutil

Re: [Libreoffice] Possible little code simplification

2011-11-28 Thread Michael Stahl
On 25/11/11 19:05, Ivan Timofeev wrote: Hello Michael, 2011/11/25 Michael Stahl mst...@redhat.com: On 24/11/11 19:07, Ivan Timofeev wrote: [...] What do you think about changing the code so that pSortedObjs will be alive every time? We will be able to return a reference to pSortedObjs

Re: [Libreoffice] minutes of tech. steering call ...

2011-11-28 Thread Michael Stahl
On 25/11/11 15:13, Bjoern Michaelsen wrote: On Fri, Nov 25, 2011 at 11:20:50AM +0100, Michael Stahl wrote: DISPLAY=:42 ./soffice --accept=pipe,name=$USER;urp; --norestore --nologo -env:UserInstallation=file:///tmp/xyz instead of that monster you cant now run: make debugrun on Linux

Re: [Libreoffice] errors in idl files

2011-11-28 Thread Michael Stahl
On 24/11/11 14:16, Tomas Hlavaty wrote: heh, i fixed that a lot on Monday, after discovering that a lot of its files were not listed in the makefile at all; please git pull and try again :) Ah, sorry I didn't have the most recent repo. However, after pulling, it is still not possible to

Re: [Libreoffice] SWT window locks LOo

2011-11-30 Thread Michael Stahl
On 30/11/11 12:27, othman wrote: I'm resisting to do debugging for one reason is that i don't know how to debug Ooo . you are Resisting to ,at least, try the oxt and look to the issue : why ? i have no idea. using non-VCL/UNO dialogs together with LO UI is certainly an obscure use-case, and i

Re: [Libreoffice] concept for c++ based subsequenttests

2011-11-30 Thread Michael Stahl
On 30/11/11 14:59, Markus Mohrhard wrote: after we enabled subsequenttests in sc again we have now a lot of failing tests. Instead of debugging the java based tests I plan to rewrite them in c++ and fix them during that. The test itself is a bit ridiculous so it is a faithful reproduction

Re: [Libreoffice] Even more debugging info

2011-11-30 Thread Michael Stahl
On 30/11/11 21:34, Tom Tromey wrote: Stephan == Stephan Bergmann sberg...@redhat.com writes: Stephan On 11/30/2011 05:37 PM, Lionel Elie Mamane wrote: Any opinion about this patch? I have it in my local repo, and it helps me when running under gdb, as gdb now knows about macros! Stephan

Re: [Libreoffice] I need some advice to fix fdo#40363

2011-12-01 Thread Michael Stahl
On 01/12/11 20:04, Eike Rathke wrote: Hi Michael, On Wednesday, 2011-11-30 18:45:31 +0100, Michael Stahl wrote: On 30/11/11 12:10, Eike Rathke wrote: Also fixed the misrepresentation of years1000 with less than 4 digits we did that? oops. i didn't know that... Yup.. which made we

Re: [Libreoffice] [PATCH 01/11] Replace ScChangeTrackMsgStack with std::stack ScChangeTrackMsgInfo*

2011-12-05 Thread Michael Stahl
On 05/12/11 18:26, Eike Rathke wrote: Hi Marcel, On Thursday, 2011-12-01 11:08:40 +0100, Marcel Metz wrote: this is my first patch series to the lo project. It replaces the use of the tools Stack class and corresponding macros with the std::stack as suggested in in bug #39445 [1] (an easy

[Libreoffice] [PUSHED] Re: [PATCH] Translation of German comments in /svx/source/svdraw (part2)

2011-12-06 Thread Michael Stahl
On 05/12/11 14:27, Stefan Knorr (Astron) wrote: Hello. As promised, here is the second part... a big thanks goes to Eike who... managed to get hold of an intact revision before ooo/DEV300_m101 was merged and converted it from *gasp* cp437 to utf-8 I am still unsure what to make of the

Re: [Libreoffice] [PATCH] Translate German comments and correct some English ones

2011-12-06 Thread Michael Stahl
On 05/12/11 11:10, Michael Meeks wrote: On Sat, 2011-12-03 at 00:08 +0100, Philipp Weissenbacher wrote: But then, what constitutes an old comment? Very often I found that the JP with a date comments were obviously added _after_ the original comment. Really - trying to detect and

Re: [Libreoffice] Make check from master fails in sc_datapilotfieldobj

2011-12-08 Thread Michael Stahl
On 08/12/11 10:41, Stephan Bergmann wrote: On 12/08/2011 09:43 AM, Markus Mohrhard wrote: Can you check that you can open sc/qa/extras/testfiles/datapilotfieldobj.ods and that you don't have any hidden lock files in this directory. It would be great if tests would not write lock files into

[Libreoffice] [REVIEW 3.4] fix for fdo#40831 i#102333

2011-12-08 Thread Michael Stahl
hi all, i'd like to backport the following Writer searchreplace crash fixing commits to 3.4: http://cgit.freedesktop.org/libreoffice/core/commit/?id=e0d4e6f22a4290a4b11a342fd59523b28963838c http://cgit.freedesktop.org/libreoffice/core/commit/?id=82a716f29cc252740c80556f72f9d9e602877918

Re: [Libreoffice] Make check from master fails in sc_datapilotfieldobj

2011-12-08 Thread Michael Stahl
On 08/12/11 11:39, Markus Mohrhard wrote: Hello Michael, of course there is: PropertyValue[] loadProps = new PropertyValue[1]; loadProps[0] = new PropertyValue(); loadProps[0].Name = ReadOnly; loadProps[0].Value = new Boolean(true); now pass

Re: [Libreoffice] Make check from master fails in sc_datapilotfieldobj

2011-12-08 Thread Michael Stahl
On 08/12/11 12:48, Michael Meeks wrote: On Thu, 2011-12-08 at 12:33 +0100, Michael Stahl wrote: there is the following in sfx2/source/doc/docfile.cxx, function IsSystemFileLockingUsed(): And this brings to mind the line in our soffice shell-script: # file locking now enabled

Re: [Libreoffice] [REVIEW 3-4] fdo#42147: fix crash

2011-12-09 Thread Michael Stahl
On 09/12/11 06:44, Ivan Timofeev wrote: Oh no, wait, I was getting all mixed up :( This is not a fix for the mentioned bug, the proper fix was http://cgit.freedesktop.org/libreoffice/core/commit/?id=3524727db0f3cfecf3a47046795c527808c10c3e which is now backported to 3-4. Heh, excuse my

Re: [Libreoffice] odd ND_FOONODE bits was fdo#42147: fix crash

2011-12-09 Thread Michael Stahl
On 09/12/11 12:34, Caolán McNamara wrote: On Fri, 2011-12-09 at 09:44 +0400, Ivan Timofeev wrote: 08.12.2011 23:36, Ivan Timofeev пишет: This is not a fix for the mentioned bug, the proper fix was http://cgit.freedesktop.org/libreoffice/core/commit/?id=3524727db0f3cfecf3a47046795c527808c10c3e

[Libreoffice] [PUSHED] Re: [REVIEW 3.4] fix for fdo#40831 i#102333

2011-12-09 Thread Michael Stahl
On 08/12/11 12:56, Michael Meeks wrote: Hi Michael, On Thu, 2011-12-08 at 11:57 +0100, Michael Stahl wrote: i'd like to backport the following Writer searchreplace crash fixing commits to 3.4: Look fine to me; you're certain that none of the pointers in the 2nd patch are going

Re: [Libreoffice] LibO daily builds on Fedora 16: oxygen GTK undefined cairo symbol

2011-12-12 Thread Michael Stahl
On 12/12/11 15:50, Petr Mladek wrote: Lionel Elie Mamane píše v Ne 11. 12. 2011 v 08:13 +0100: https://bugs.freedesktop.org/show_bug.cgi?id=34432 --- Comment #7 from sasha.libreoff...@gmail.com 2011-12-10 01:08:18 PST --- (In reply to comment #6) I fixed a few ODBC-64bits problem in the past

Re: [Libreoffice] [REVIEW 3.4.5] docx comment export patch fdo#33463 ...

2011-12-13 Thread Michael Stahl
On 13/12/11 10:32, Michael Meeks wrote: Hi guys, I attach a back-port of Lubos' patch from master fixing this for 3.4.5 - I'd love a 2nd review to get it included before Wed ;-) it looks like it doesn't change the DOC/RTF export, so it can go in i'd say :)

Re: [Libreoffice] build failed in lingucomponent on Mac

2011-12-13 Thread Michael Stahl
On 13/12/11 19:33, Matúš Kukan wrote: Hi, I have gbuildified lingucomponent, unfortunately it did not build on Mac. Attached patch could help. +$(eval $(call gb_Library_add_cxxflags,MacOSXSpell,\ + $(gb_LinkTarget_OBJCXXFLAGS) \ +)) wouldn't it be better to simply use

Re: [Libreoffice] What do we want from extensions module?

2011-12-14 Thread Michael Stahl
On 14/12/11 12:34, Matúš Kukan wrote: Hi, I'm going to have a look at converting extensions to gbuild. i have dug out my incomplete patches this afternoon and made them actually build, which took longer than expected :) result of that is in feature/gbuild_extensions branch; ~6 libraries

[Libreoffice] gbuild conversion module status

2011-12-15 Thread Michael Stahl
hi all, if you consider converting a module to gbuild, please first take a look at this brand new Wiki page, and add your name to the remarks column, so we don't end up with 3 people doing the same thing: http://wiki.documentfoundation.org/Development/Build_System/Module_status people who have

[Libreoffice] unit-test dependencies (Re: Tests on release build)

2011-12-15 Thread Michael Stahl
On 15/12/11 11:34, Stephan Bergmann wrote: On 12/15/2011 10:58 AM, Tomáš Chvátal wrote: So unless you can look at one of those traces and tell me that the build should be stopped because it is obvious error in the code (not in the test, the app code) that needs to be fixed I would want you

Re: [Libreoffice] unit-test dependencies (Re: Tests on release build)

2011-12-15 Thread Michael Stahl
On 15/12/11 17:37, Michael Meeks wrote: On Thu, 2011-12-15 at 13:18 +, Caolán McNamara wrote: On Thu, 2011-12-15 at 13:56 +0100, Michael Stahl wrote: we wouldn't have this problem if these were subsequenttests but then no one would run them :-), I still feel its far better to try

Re: [Libreoffice] gbuild'ified salhelper

2011-12-15 Thread Michael Stahl
On 15/12/11 12:24, Stephan Bergmann wrote: http://cgit.freedesktop.org/libreoffice/core/commit/?id=a4312af08cbd8c69ba4bead9608f3bf549caf7a0 converts salhelper to gbuild directly on master (rather than on feature/gbuild branch, should help us find out faster if it breaks on some platform).

Re: [Libreoffice] assertion in SwIndexReg::~SwIndexReg

2011-12-16 Thread Michael Stahl
. Or, coming from the opposite side of the question, why should the destructor expect the container to be empty by that time? Yes. I would assume that the destructor's expectation is legitimate, and that the code keeping the container non-empty is in error. But maybe Michael Stahl can tell you more

Re: [Libreoffice] postgresql bits in minutes of tech. steering call

2011-12-16 Thread Michael Stahl
On 15/12/11 19:46, Michael Meeks wrote: On Thu, 2011-12-15 at 19:11 +0100, Lionel Elie Mamane wrote: On this, someone said on the talk we use only libc (and I implicitly understood: in the binaries we distribute). You have to be quite careful with claims from Fridrich, they are often

Re: [Libreoffice] assertion in SwIndexReg::~SwIndexReg

2011-12-16 Thread Michael Stahl
On 16/12/11 15:04, Terrence Enger wrote: On Fri, 2011-12-16 at 12:05 +0100, Michael Stahl wrote: On 16/12/11 10:52, Stephan Bergmann wrote: Yes. I would assume that the destructor's expectation is legitimate, and that the code keeping the container non-empty is in error. well yes it means

Re: [Libreoffice] unit-test dependencies (Re: Tests on release build)

2011-12-16 Thread Michael Stahl
On 16/12/11 11:05, Stephan Bergmann wrote: On 12/15/2011 07:25 PM, Michael Meeks wrote: Hah :-) so - one thing that I wondered about ... is - is it possible that our gnumake dependencies on .component files do not include dependencies to the libraries they are for ? such that we can build

Re: [Libreoffice] What do we want from extensions module?

2011-12-17 Thread Michael Stahl
On 14/12/11 23:28, Peter Foley wrote: On Wed, 14 Dec 2011, Michael Stahl wrote: result of that is in feature/gbuild_extensions branch; ~6 libraries already converted. I've actually already converted extensions to gbuild. I'm attaching my current patch which should be essentially complete

Re: [Libreoffice] c++ sample for calc add-on

2011-12-19 Thread Michael Stahl
On 17/12/11 21:33, Lars Callenbach wrote: Hello, I have a template for the quantlib addin which works for OO3.2. Unfortunately it does not work for LibreOffice-3.4. i'm not familiar with Calc addins, but in general UNO based extensions are supposed to work with newer versions as well (unless

[Libreoffice] dyld install_name: Re: What do we want from extensions module?

2011-12-19 Thread Michael Stahl
On 18/12/11 12:05, Christian Lohmaier wrote: Hi Michel, *, On Sun, Dec 18, 2011 at 2:39 AM, Michael Stahl mst...@redhat.com wrote: On 14/12/11 23:28, Peter Foley wrote: On Wed, 14 Dec 2011, Michael Stahl wrote: [...] - the spotlight plugin: no idea if that will actually work; i really

[Libreoffice] calc: Re: com.sun.star.container.XNameContainer.removeByName() fails v3.5b0+ (linux)

2011-12-19 Thread Michael Stahl
hi Tomas, you are much more likely to get a reply for this kind of bug on the dev list. On 19/12/11 16:32, Tomas Hlavaty wrote: Hi all, something has changed recently and it is not possible to remove sheets via uno calls anymore. It used to work with v3.4.4 but fails with v3.5b0 and

Re: [Libreoffice] calc: Re: com.sun.star.container.XNameContainer.removeByName() fails v3.5b0+ (linux)

2011-12-20 Thread Michael Stahl
On 20/12/11 15:51, Tomas Hlavaty wrote: Hi Michael, Michael Stahl mst...@redhat.com writes: i guess 3.4.4 is this: libreoffice-3.4.4.2 libreoffice-3.4.4.2 tag doesn't exist:-( Any other ideas? Are there any rules how tags are created and named? And branches? the 3.4 stuff does

[Libreoffice] [REVIEW] fdo#40482 sw: view options changed by printing

2011-12-21 Thread Michael Stahl
i'd like to have the fix for $SUBJECT in 3.4.5, it is a regression introduced in 3.4.2 or 3.4.3, am too lazy to check which. http://cgit.freedesktop.org/libreoffice/core/commit/?id=89d2733e16ae6233deea6bef3193bd45c89b854c ___ LibreOffice mailing list

[Libreoffice] [PUSHED] Re: [PATCH] fdo#38832 Replace ScChangeActionTable with std::map.

2011-12-21 Thread Michael Stahl
On 21/12/11 16:18, Marcel Metz wrote: Hello lo-devs, I've tested the patch with 'make check', but would like to point out that the reviewer should take special care of the change in 'sc/source/core/tool/chgtrack.cxx:3140-3160'. From my understanding of the code the tools Table does not

[Libreoffice] [PUSHED] Re: [PATCH] Replace SwTxtPortionTable with std::map.

2011-12-21 Thread Michael Stahl
On 21/12/11 18:50, Marcel Metz wrote: Hello lo-devs, this patch replaces yet another Table class use. regards Marcel Metz thanks for the patch, pushed to master regards, michael ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

Re: [Libreoffice] bug in post-commit hook

2011-12-22 Thread Michael Stahl
On 22/12/11 16:12, Noel Grandin wrote: there is something wrong with the post-commit hook - I'm getting repeats of the message below every few seconds. are you sure? i guess there should be ~20 of them, one for each bootstrap based repo ___

[Libreoffice] [REVIEW] invalid ODF fdo#37390 fdo#44073 fdo#44082

2011-12-22 Thread Michael Stahl
proposing the following commits for 3.4.5, as they prevent LO from writing invalid ODF: http://cgit.freedesktop.org/libreoffice/core/commit/?id=c1e1ef80e8428514499b061e00801a6a6298d0b0 http://cgit.freedesktop.org/libreoffice/core/commit/?id=59a5c37d0df9b5612552c4b749191385ca0adc80 with the fix

Re: [Libreoffice] [REVIEW-3-4-5] Reverted - Fix overly zealous check in Zip package consistency

2011-12-22 Thread Michael Stahl
On 23/12/11 00:29, Thorsten Behrens wrote: Michael Meeks wrote: can't we just revert the original fix there ? Reverted with Stephan's review in -3-4. Sigh, we had branched off 3-4-5 meanwhile, which needs 3 reviews - Michael, Petr, would you want to approve the revert? i'd say reverting a

[Libreoffice] [PUSHED] Re: [PATCH] (3.5 Beta2) Fix for fdo#44280 [GUI] wrong position of 'Adding extension...' at Extension Manager dialog

2012-01-03 Thread Michael Stahl
On 29/12/11 19:10, Olivier Hallot wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi Please find enclosed a patch to fix fdo#44280 The patch was done in master and should be cerry picked in 3.5 ASAP thanks, looks much better with the patch! pushed to master and libreoffice-3-5.

Re: [Libreoffice] .: sot/Library_sot.mk

2012-01-04 Thread Michael Stahl
On 04/01/12 12:06, Caolán McNamara wrote: On Tue, 2012-01-03 at 17:26 +0100, Michael Stahl wrote: wonder if it would make sense to define NOMINMAX globally in windows.mk probably, unless there is some other godawful chunk of windows specific code hidden somewhere which falls over and dies

[Libreoffice] [PUSHED] Re: [PATCH] Translate German comments to English and correct the English ones

2012-01-04 Thread Michael Stahl
On 04/01/12 12:57, Philipp Weissenbacher wrote: Hi all, Here's another patch that translates the German comments to English and fixes some errors in the English ones. thanks, pushed (tweaked the translations a bit in a follow-up) In htmltbl.cxx: I interpreted 'tab' in some OSL_ENSUREs as

Re: [Libreoffice] feature/gbuild_extensions

2012-01-04 Thread Michael Stahl
On 04/01/12 08:54, Norbert Thiebaud wrote: So, I've run test on MacOSX... I ran in a couple of issues.. I pushed patches for them on the branch The last commit ( 381bed81e43d7fdd541115e0ab4213b0609e7ac0 ) is a hack and is probably wrong... but it get me to the end of the build + package

Re: [Libreoffice] minor idl fixes

2012-01-05 Thread Michael Stahl
On 05/01/12 09:38, Tomas Hlavaty wrote: Hi Stephan, Stephan Bergmann sberg...@redhat.com writes: On 01/04/2012 11:09 PM, Tomas Hlavaty wrote: diff --git a/offapi/com/sun/star/chart/XAxisSupplier.idl b/offapi/com/sun/star/chart/XAxisSupplier.idl ... Are you sure that this is right,

[Libreoffice] [PUSHED] [PATCH] Re: minor idl fixes

2012-01-05 Thread Michael Stahl
On 04/01/12 23:09, Tomas Hlavaty wrote: Also, I attach a few more patches. thanks for these patches, i've pushed 0001-fix-broken-ifndef-define-guard-in-idl.patch, 0002-fix-package-in-idl.patch, 0005-chmod-x-on-java-files.patch. 0003-idl-fix-package-names.patch seems to be wrong, as discussed in

  1   2   3   4   5   6   7   8   9   10   >