Re: rtl8723bu: low signal, fails to associate

On 08/23/2018 09:36 PM, James Cameron wrote: > G'day Carlo, Mylene, and James, > > Thanks for your earlier reports about RTL8723bu. Have you any more > recent experiences you might share? > > I'm evaluating a sample laptop which worked fine with Windows 10, but > not very well with Ubuntu

Re: [PATCH] rtl8xxxu: Fix trailing semicolon

ipermail/driverdev-devel/2018-January/115390.html > > drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Acked-by: Jes Sorensen <jes.soren...@gmail.com> > diff --git a/drivers/net/wireless/realtek/rtl8xxxu/r

Re: RTL8723bu: poor signal and connection troubles

On 01/11/2018 05:30 AM, Barry Day wrote: > On Wed, Jan 10, 2018 at 12:15:51PM +, Carlo Caione wrote: >> Hi, >> this is a follow up email to [0] since the problem was never fully >> investigated / solved and I keep seeing the same problem also on my >> hardware. >> >> Also in my case the

Re: Slow connection with rtl8xxxu and 8192eu chipset

On 11/28/2017 11:49 AM, Nikolay Borisov wrote: > > > On 28.11.2017 18:35, Jes Sorensen wrote: >> On 11/28/2017 11:26 AM, Nikolay Borisov wrote: >>> >>> >>> On 28.11.2017 18:16, Jes Sorensen wrote: >>>> On 11/14/2017 05:39 AM, Nikolay Boriso

Re: Slow connection with rtl8xxxu and 8192eu chipset

On 11/28/2017 11:26 AM, Nikolay Borisov wrote: > > > On 28.11.2017 18:16, Jes Sorensen wrote: >> On 11/14/2017 05:39 AM, Nikolay Borisov wrote: >>> >>> >>> On 14.11.2017 11:26, Nikolay Borisov wrote: >>>> (Please CC as I'm not subscribed) &

Re: Slow connection with rtl8xxxu and 8192eu chipset

On 11/14/2017 05:39 AM, Nikolay Borisov wrote: > > > On 14.11.2017 11:26, Nikolay Borisov wrote: >> (Please CC as I'm not subscribed) >> >> Hello, >> >> I have the tp-link tl-wn822N usb wifi dongle. lsbusb reports it as >> >> Bus 001 Device 003: ID 2357:0108 >> >> Unfortunately with the

Re: Wifi RTL8723bu driver test: failed to scan

On 11/22/2017 04:51 AM, Mylene JOSSERAND wrote: > Hello Jes Sorensen, > > I am currently testing a LM811 Wifi/BT USB dongle [1] on a Sinlinx > SinA33 Allwinner SoC board [2]. I saw that I should use the realtek > driver RTL8723BU for this USB dongle. > > Currently, I am

Re: [PATCH] rtl8xxxu: mark expected switch fall-throughs

On 10/11/2017 04:41 AM, Kalle Valo wrote: Jes Sorensen <jes.soren...@gmail.com> writes: On 10/10/2017 03:30 PM, Gustavo A. R. Silva wrote: In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. While this isn't harmful, to me this

Re: [PATCH] rtl8xxxu: mark expected switch fall-throughs

On 10/10/2017 03:30 PM, Gustavo A. R. Silva wrote: In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. While this isn't harmful, to me this looks like pointless patch churn for zero gain and it's just ugly. Jes Cc: Jes Sorensen

Re: rtlwifi handling of sequence numbers with aggregation

On 08/29/2017 10:18 AM, Larry Finger wrote: On 08/25/2017 09:15 PM, Larry Finger wrote: Based on my prejudices, I would suspect the USB driver before that of the PCI version. I have BCc'd my contact at Realtek to see what he has to say on the issue. My contact at Realtek replies that the PCI

rtlwifi handling of sequence numbers with aggregation

Hi, Looking at some bits in rtlwifi I came across a discrepancy between the PCI and USB code. Consider the following code: In rtl_pci_tx(): if (ieee80211_is_data_qos(fc)) { tid = rtl_get_tid(skb); if (sta) { sta_entry = (struct

Re: [PATCH] rt2x00: improve calling conventions for register accessors

On 05/16/2017 10:19 AM, Arnd Bergmann wrote: On Tue, May 16, 2017 at 3:44 PM, Jes Sorensen <jes.soren...@gmail.com> wrote: On 05/16/2017 07:55 AM, Stanislaw Gruszka wrote: On Mon, May 15, 2017 at 10:39:51AM -0400, David Miller wrote: Passing return values by reference is and always ha

Re: [PATCH] rt2x00: improve calling conventions for register accessors

On 05/16/2017 07:55 AM, Stanislaw Gruszka wrote: On Mon, May 15, 2017 at 10:39:51AM -0400, David Miller wrote: Passing return values by reference is and always has been a really poor way to achieve what these functions are doing. And frankly, whilst the tool could see what's going on here

Re: [PATCH] staging: Add rtl8723bs sdio wifi driver

On 04/06/2017 02:32 PM, Larry Finger wrote: On 04/06/2017 04:49 AM, Hans de Goede wrote: Hi, On 06-04-17 11:04, Bastien Nocera wrote: On Thu, 2017-04-06 at 08:55 +0200, Hans de Goede wrote: Good thank you. So what is the plan with the github version ? Note that my submission contains a

Re: [PATCH] staging: Add rtl8723bs sdio wifi driver

: Bastien Nocera <had...@hadess.net> Cc: Larry Finger <larry.fin...@lwfinger.net> Cc: Jes Sorensen <jes.soren...@gmail.com> Signed-off-by: Hans de Goede <hdego...@redhat.com> Hans, I am still building the driver on my CherryTrail tablet, but I did see some warnings and

Re: TL-WN823N

On 02/16/2017 10:20 AM, madmaxxx wrote: Hi, I have a problem with rtl8xxxu driver, which seems to not work with a dongle tp-link TL-WN823N model. I just filled out a 4.9.10 kernel and the device is not fully recognized .. I can only scan network and not link. Thank you There is nothing in

Re: R92SU - Realtek RTL8192SU/RTL8191SU/RTL8188SU USB Wireless Network Adapters

On 02/14/2017 01:28 PM, poma wrote: Hello fellows! https://github.com/chunkeey/rtl8192su/tree/master/r92su r92su seems like the simplest and most effective replacement for r8712u. https://bugzilla.redhat.com/show_bug.cgi?id=1421383 Christian, I can not add you there, so I'm asking here, is

Re: [PATCH] rtl8xxxu: Add (0x2357 0x0107) to the tested devices list.

On 02/13/2017 04:18 AM, Kalle Valo wrote: Aaryn Coutanche writes: From: Aaryn Coutanche --- drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 3 +++ 1 file changed, 3 insertions(+) Signed-off-by is missing, please read

[PATCH 1/5] rtl8xxxu: Mark 8192eu device 0x0bda:0x818b as tested

From: Jes Sorensen <jes.soren...@redhat.com> Device reported as working fine, so tell the driver not to warn about it being untested. Reported-by: Aex Aey <aex...@gmail.com> Signed-off-by: Jes Sorensen <jes.soren...@gmail.com> --- drivers/net/wireless/realtek/rtl8xxxu/rtl8xx

[PATCH 3/5] rtl8xxxu: Add USB ID for D-Link DWA-131 rev E1 (rtl8192eu)

From: Axel Köllhofer <axelkoellho...@web.de> This was tested by David Patiño. Reported-by: David Patiño <davidpatin...@gmail.com> Signed-off-by: Axel Köllhofer <axelkoellho...@web.de> Signed-off-by: Jes Sorensen <jes.soren...@gmail.com> --- drivers/net/wireless/realtek/

[PATCH 5/5] rtl8xxxu: Update author/maintainer contact info

From: Jes Sorensen <jes.soren...@redhat.com> Update copyright year and email address. Signed-off-by: Jes Sorensen <jes.soren...@gmail.com> --- MAINTAINERS| 2 +- drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.h | 2 +- drivers/

[PATCH 2/5] rtl8xxxu: Add another 8192eu device to the USB list

From: Jes Sorensen <jes.soren...@redhat.com> TP-Link TL-WN822N v4 (2357:0108) Reported-by: Gregory Auzanneau <li...@reolight.net> Signed-off-by: Jes Sorensen <jes.soren...@gmail.com> --- drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 3 +++ 1 file changed, 3 inserti

[PATCH 4/5] rtl8xxxu: Add additional USB IDs for rtl8192eu devices

From: Axel Köllhofer <axelkoellho...@web.de> These IDs originate from the vendor driver Signed-off-by: Axel Köllhofer <axelkoellho...@web.de> Signed-off-by: Jes Sorensen <jes.soren...@gmail.com> --- drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 7 +++ 1 file cha

[PATCH 0/5] Update USB IDs and email adress

From: Jes Sorensen <jes.soren...@gmail.com> Hi, This patchset adds some additional USB IDs for rtl8192eu devices, as well as updates the email address and the copyright. I've been preoccupied with some other stuff the last little while, so I am a little out of touch with w

Re: Support of rtl8723bs

Hanno Zulla writes: > Hi, > > has there been any progress on the rtl8723bs / sdio issue? > > There were no updates to this mailing list or the usual git repositories > since this was last discussed, unless I missed the proper place to look > for this. > > I'm sorry that I can't be

Re: [PATCH] net: wireless: realtek: constify rate_control_ops structures

Larry Finger writes: > On 12/02/2016 03:50 AM, Bhumika Goyal wrote: >> The structures rate_control_ops are only passed as an argument to the >> functions ieee80211_rate_control_{register/unregister}. This argument is >> of type const, so rate_control_ops having this

Re: [PATCH 0/1] rtl8xxxu: Workaround for 8192eu/8723bu not reconnecting

Kalle Valo <kv...@codeaurora.org> writes: > Jes Sorensen <jes.soren...@redhat.com> writes: > >> Luca Coelho <l...@coelho.fi> writes: >>> On Wed, 2016-11-30 at 10:46 +0200, Kalle Valo wrote: >>>> jes.soren...@redhat.com writes: >&

Re: [PATCH 0/1] rtl8xxxu: Workaround for 8192eu/8723bu not reconnecting

Luca Coelho <l...@coelho.fi> writes: > On Wed, 2016-11-30 at 10:46 +0200, Kalle Valo wrote: >> jes.soren...@redhat.com writes: >> >> > From: Jes Sorensen <jes.soren...@redhat.com> >> > >> > Hi, >> > >> > This patch w

[PATCH 1/1] rtl8xxxu: Work around issue with 8192eu and 8723bu devices not reconnecting

From: Jes Sorensen <jes.soren...@redhat.com> The H2C MEDIA_STATUS_RPT command for some reason causes 8192eu and 8723bu devices not being able to reconnect. Reported-by: Barry Day <brise...@gmail.com> Signed-off-by: Jes Sorensen <jes.soren...@redhat.com> --- drivers/net/wireles

Re: [PATCH] rtl8xxxu: Fix fail to reconnect to AP

Barry Day writes: > Removed the report_connect functions as the h2c commands used are > not required for a soft-mac driver and they prevent reconnecting to an > AP for a couple of the chipsets. > > Signed-off-by: Barry Day > --- > rtl8xxxu.h | 6

Re: [PATCH 0/7] rtl8xxxu: Pending patches

Barry Day <brise...@gmail.com> writes: > On Mon, Nov 21, 2016 at 11:59:47AM -0500, Jes Sorensen wrote: >> Barry Day <brise...@gmail.com> writes: >> > Testing is simple. Connect to an AP in the usual >> > manner..disconnect..reconnect. The 8192eu will

Re: [PATCH] rtl8xxxu: fix tx rate debug output

Arnd Bergmann writes: > We accidentally print the rate before we know it for txdesc_v2: Hi Arnd, Thanks for the patch - Barry Day already posted a patch for this which Kalle has applied to the wireless tree. Cheers, Jes > > wireless/realtek/rtl8xxxu/rtl8xxxu_core.c: In

Re: linux-next: build warning after merge of the wireless-drivers-next tree

>>> > access to retry count") >>> > >>> > This is a correct diagnosis. >>> >>> Thanks for the report. Jes, can you send a patch to fix this? (Unless >>> someone else beats to it.) >>> >>> -- >>> Kalle Valo >> >> I posted a patch on the 26th that fixes this > > Thanks, I see it: > > https://patchwork.kernel.org/patch/9448225/ > > The commit log doesn't mention anything about the compilation warning, > I'll add that. Also a Fixes line is nice to have. I'm happy with this fix Acked-by: Jes Sorensen <jes.soren...@redhat.com>

Re: rtl8xxxu: tx rate reported before set

Kalle Valo writes: > Barry Day wrote: >> Move the dev_info call that attempts to show the rate used before it is set. >> >> Signed-off-by: Barry Day > > Jes, I would like to take this directly to fix the compiler warning. Also I'll

Re: [PATCH] rtl8xxxu: Fix failure to reconnect to AP

Barry Day <brise...@gmail.com> writes: > On Mon, Nov 21, 2016 at 11:57:22AM -0500, Jes Sorensen wrote: >> Jes Sorensen <jes.soren...@redhat.com> writes: >> >> void rtl8xxxu_gen1_init_aggregation(struct rtl8xxxu_priv *priv) >> >> @@ -4515,6 +4523,8 @@

Re: [PATCH 0/7] rtl8xxxu: Pending patches

Barry Day <brise...@gmail.com> writes: > On Sat, Nov 19, 2016 at 06:53:42PM -0500, Jes Sorensen wrote: >> Barry Day <brise...@gmail.com> writes: >> > On Fri, Nov 18, 2016 at 09:00:10PM -0500, Jes Sorensen wrote: >> >> Barry Day <brise...@gmail.com&g

Re: [PATCH] rtl8xxxu: Fix failure to reconnect to AP

Jes Sorensen <jes.soren...@redhat.com> writes: > Barry Day <brise...@gmail.com> writes: >> The rtl8192e and rtl8723 fail to reconnect to an AP after being >> disconnected. Ths patch fixes that without affecting the rtl8192cu. >> I don't have a rtl8723 to test but

Re: [PATCH 0/7] rtl8xxxu: Pending patches

Barry Day <brise...@gmail.com> writes: > On Fri, Nov 18, 2016 at 09:00:10PM -0500, Jes Sorensen wrote: >> Barry Day <brise...@gmail.com> writes: >> > On Fri, Nov 18, 2016 at 04:44:21PM -0500, jes.soren...@redhat.com wrote: >> >> From: Jes Sorensen &l

Re: [PATCH 0/7] rtl8xxxu: Pending patches

Barry Day <brise...@gmail.com> writes: > On Fri, Nov 18, 2016 at 04:44:21PM -0500, jes.soren...@redhat.com wrote: >> From: Jes Sorensen <jes.soren...@redhat.com> >> >> Kalle, >> >> Please find attached a number of patches for the rtl8xxxu >> dri

[PATCH 0/7] rtl8xxxu: Pending patches

From: Jes Sorensen <jes.soren...@redhat.com> Kalle, Please find attached a number of patches for the rtl8xxxu driver. The issues reported with wpa_supplicant on 8723bu still needs further investigation. Note the memory leak issue has only been seen with 8188eu devices so far, but it's s

[PATCH 3/7] rtl8xxxu: Fix rtl8723bu driver reload issue

From: Jes Sorensen <jes.soren...@redhat.com> The generic disable_rf() function clears bits 22 and 23 in REG_RX_WAIT_CCA, however we did not re-enable them again in rtl8723b_enable_rf() This resolves the problem for me with 8723bu devices not working again after reloading the driver. Sign

[PATCH 7/7] rtl8xxxu: Fix non static symbol warning

From: Wei Yongjun <weiyongj...@huawei.com> Fixes the following sparse warning: drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8192e.c:1559:6: warning: symbol 'rtl8192eu_power_off' was not declared. Should it be static? Signed-off-by: Wei Yongjun <weiyongj...@huawei.com> Signed

[PATCH 5/7] rtl8xxxu: Obtain RTS rates from mac80211

From: Jes Sorensen <jes.soren...@redhat.com> Use the mac80211 provided rate for RTS rather than the hard coded 24Mbps as suggested by the vendor drivers. Reported-by: Andrea Merello <andrea.mere...@gmail.com> Signed-off-by: Jes Sorensen <jes.soren...@redhat.com> --- drivers/ne

[PATCH 4/7] rtl8xxxu: Fix rtl8192eu driver reload issue

From: Jes Sorensen <jes.soren...@redhat.com> The 8192eu suffered from two issues when reloading the driver. The same problems as with the 8723bu where REG_RX_WAIT_CCA bits 22 and 23 didn't get set in rtl8192e_enable_rf(). In addition it also seems prone to issues when setting REG_RF_CTR

[PATCH 1/7] rtl8xxxu: Fix memory leak in handling rxdesc16 packets

From: Jes Sorensen <jes.soren...@redhat.com> A device running without RX package aggregation could return more data in the USB packet than the actual network packet. In this case the could would clone the skb but then determine that that there was no packet to handle and exit without f

[PATCH 2/7] rtl8xxxu: Fix big-endian problem reporting mactime

From: Jes Sorensen <jes.soren...@redhat.com> The full RX descriptor is converted so converting tsfl again would return it to it's original endian value. Signed-off-by: Jes Sorensen <jes.soren...@redhat.com> --- drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.h | 4 ++-- drivers/

Re: [PATCH] rtl8xxxu: Fix for agressive power saving by rtl8723bu wireless IC

John Heenan writes: > Barry Day has submitted real world reports for the 8192eu and 8192cu. > This needs to be acknowledged. I have submitted real world reports for > the 8723bu. Lets get this a little more clear - first of all, I have asked you to investigate which part resolves

Re: Avery's notes from LPC2016 wireless track (Santa Fe)

Avery Pennarun writes: > On Thu, Nov 3, 2016 at 5:55 PM, Barry Day wrote: >> Thanks for that. Can I take this as meaning there won't be any videos? >> I would like to have seen Jes Sorensen's talk on rtl8xxxu > > As far as I know, no talks at this LPC were

Re: [PATCH] rtl8xxxu: Fix for agressive power saving by rtl8723bu wireless IC

Barry Day <brise...@gmail.com> writes: > On Mon, Oct 31, 2016 at 06:41:30PM -0400, Jes Sorensen wrote: >> Barry Day <brise...@gmail.com> writes: >> > On Mon, Oct 31, 2016 at 05:25:12PM -0400, Jes Sorensen wrote: >> >> As mentioned previou

Re: [PATCH] rtl8xxxu: Fix failure to reconnect to AP

Barry Day <brise...@gmail.com> writes: > On Mon, Nov 14, 2016 at 08:24:45AM -0500, Jes Sorensen wrote: >> Barry Day <brise...@gmail.com> writes: >> > The rtl8192e and rtl8723 fail to reconnect to an AP after being >> > disconnected. Ths patch fixes that

Re: [PATCH] rtl8xxxu: Fix failure to reconnect to AP

Barry Day writes: > The rtl8192e and rtl8723 fail to reconnect to an AP after being > disconnected. Ths patch fixes that without affecting the rtl8192cu. > I don't have a rtl8723 to test but it has been tested on a rtl8192eu. > After going through the orginal realtek code for

Re: [PATCH 2/2] rtl8xxxu: Fix for bogus data used to determine macpower

Dave Jones <s.dave.jo...@gmail.com> writes: > On Fri, Nov 04, 2016 at 09:56:00AM -0400, Jes Sorensen wrote: >> >> Joe Perches <j...@perches.com> writes: >> > On Sun, 2016-10-30 at 19:02 -0400, Jes Sorensen wrote: >> >> Code is 80 characte

Re: [PATCH 2/2] rtl8xxxu: Fix for bogus data used to determine macpower

Joe Perches <j...@perches.com> writes: > On Sun, 2016-10-30 at 19:02 -0400, Jes Sorensen wrote: >> Code is 80 characters wide, and comments are /* */ never the ugly C++ >> crap. > > You might look at the recent Linus Torvalds authored commit > 5e467652ffef (?

Re: [PATCH v2] rtl8xxxu: Fix for agressive power saving by rtl8723bu wireless IC

John Heenan writes: > The rtl8723bu wireless IC shows evidence of a more agressive approach to > power saving, powering down its RF side when there is no wireless > interfacing but leaving USB interfacing intact. This makes the wireless > IC more suitable for use in devices which

Re: [PATCH] rtl8xxxu: Fix for agressive power saving by rtl8723bu wireless IC

Barry Day <brise...@gmail.com> writes: > On Mon, Oct 31, 2016 at 05:25:12PM -0400, Jes Sorensen wrote: >> As mentioned previously, if this is to be changed here, it has to be >> matched in the _stop section too. It also has to be investigated exactly >> why this matters

Re: [PATCH] rtl8xxxu: Fix for agressive power saving by rtl8723bu wireless IC

John Heenan writes: > The rtl8723bu wireless IC shows evidence of a more agressive approach to > power saving, powering down its RF side when there is no wireless > interfacing but leaving USB interfacing intact. This makes the wireless > IC more suitable for use in devices which

Re: [PATCH 2/2] rtl8xxxu: Fix for bogus data used to determine macpower

John Heenan writes: > Thanks for your reply. > > The code was tested on a Cube i9 which has an internal rtl8723bu. > > No other devices were tested. > > I am happy to accept in an ideal context hard coding macpower is > undesirable, the comment is undesirable and it is wrong to

Re: [PATCH 2/2] rtl8xxxu: Fix for bogus data used to determine macpower

John Heenan writes: > Code tests show data returned by rtl8xxxu_read8(priv, REG_CR), used to set > macpower, is never 0xea. It is only ever 0x01 (first time after modprobe) > using wpa_supplicant and 0x00 thereafter using wpa_supplicant. These results > occurs with 'Fix for

Re: [PATCH] rtl8xxxu: Add D-Link DWA-131 rev E1

Barry Day writes: > This is a rtl8192eu dongle and has been tested > > Signed-off-by: Barry Day > --- > drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) Thanks, I'll add it to my queue,

Re: [PATCH 1/2] rtl8xxxu: Fix memory leak in handling rxdesc16 packets

Kalle Valo <kv...@codeaurora.org> writes: > jes.soren...@redhat.com writes: > >> From: Jes Sorensen <jes.soren...@redhat.com> >> >> A device running without RX package aggregation could return more data >> in the USB packet than the actual network pac

Re: [PATCH 2/2] rtl8xxxu: Fix big-endian problem reporting mactime

Kalle Valo <kv...@codeaurora.org> writes: > jes.soren...@redhat.com writes: > >> From: Jes Sorensen <jes.soren...@redhat.com> >> >> The full RX descriptor is converted so converting tsfl again would >> return it to it's original endian value. &g

Re: RTL8192EU on rtl8xxxu driver breaks every few minutes

"Franc[e]sco" writes: > Thanks for the patch, just tested the rtl8xxxu-devel branch and it seems > to have the same exact issue with the same dmesg output with the > addition of "rtl8192eu_active_to_emu: Disabling MAC timed out" when I > disconnect the dongle. > > I

Re: [PATCH] realtek: rtl8xxxu: Use const init arrays

Joe Perches <j...@perches.com> writes: > On Sat, 2016-10-01 at 16:32 -0400, Jes Sorensen wrote: >> Your output shows it moving to the text segment - if it's in a different >> segment, eg. rodata, you should use output demonstrating that to justify >> the change. >

Re: [PATCH] realtek: rtl8xxxu: Use const init arrays

Joe Perches <j...@perches.com> writes: > On Sat, 2016-10-01 at 14:53 -0400, Jes Sorensen wrote: >> Joe Perches <j...@perches.com> writes: >> > Make the init arrays const to reduce data. >> > $ size drivers/net/wireless/realtek/rtl8xxxu/built-in.o* &

Re: [PATCH] realtek: rtl8xxxu: Use const init arrays

Joe Perches writes: > Make the init arrays const to reduce data. > > $ size drivers/net/wireless/realtek/rtl8xxxu/built-in.o* (allyesconfig: > x86-32) >text data bss dec hex filename > 80107 13651 58 93816 16e78 >

Re: [PATCH 1/2] rtl8xxxu: Fix rtl8723bu driver reload issue

Greg KH <g...@kroah.com> writes: > On Fri, Sep 30, 2016 at 07:35:17PM -0400, jes.soren...@redhat.com wrote: >> From: Jes Sorensen <jes.soren...@redhat.com> >> >> The generic disable_rf() function clears bits 22 and 23 in >> REG_RX_WAIT_CCA,

Re: RTL8192EU on rtl8xxxu driver breaks every few minutes

unlisted-recipients to the Cc line and cutting out the person you are responding to is really annoying. >From 93064d0ae3e9d97c03a3aabd71e6048e1ac82f46 Mon Sep 17 00:00:00 2001 From: Jes Sorensen <jes.soren...@redhat.com> Date: Fri, 30 Sep 2016 19:18:34 -0400 Subject: [PATCH 2/2] rtl8xxxu:

[PATCH 1/2] rtl8xxxu: Fix rtl8723bu driver reload issue

From: Jes Sorensen <jes.soren...@redhat.com> The generic disable_rf() function clears bits 22 and 23 in REG_RX_WAIT_CCA, however we did not re-enable them again in rtl8723b_enable_rf() This resolves the problem for me with 8723bu devices not working again after reloading the driver. Sign

[PATCH 2/2] rtl8xxxu: Fix rtl8192eu driver reload issue

From: Jes Sorensen <jes.soren...@redhat.com> The 8192eu suffered from two issues when reloading the driver. The same problems as with the 8723bu where REG_RX_WAIT_CCA bits 22 and 23 didn't get set in rtl8192e_enable_rf(). In addition it also seems prone to issues when setting REG_RF_CTR

[PATCH 0/2] rtl8xxxu: Fix driver reload issues with 8723bu and 8192eu

From: Jes Sorensen <jes.soren...@redhat.com> Hi, These two patches fix issues where rtl8723bu and rtl8192eu dongles would stop receving data if one reloaded the driver module, requiring it to be physically removed and reinserted. Both issues are applicable to 4.9. The first patch for

[PATCH 1/2] rtl8xxxu: Fix memory leak in handling rxdesc16 packets

From: Jes Sorensen <jes.soren...@redhat.com> A device running without RX package aggregation could return more data in the USB packet than the actual network packet. In this case the could would clone the skb but then determine that that there was no packet to handle and exit without f

[PATCH 2/2] rtl8xxxu: Fix big-endian problem reporting mactime

From: Jes Sorensen <jes.soren...@redhat.com> The full RX descriptor is converted so converting tsfl again would return it to it's original endian value. Signed-off-by: Jes Sorensen <jes.soren...@redhat.com> --- drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.h | 4 ++-- drivers/

Re: [PATCHv3] wireless: check A-MSDU inner frame source address on AP interfaces

Johannes Berg <johan...@sipsolutions.net> writes: > On Wed, 2016-09-28 at 11:39 -0400, Jes Sorensen wrote: > >> > No Jes, you're wrong this time - this is changing internal API so >> > it does have to touch all users thereof. >> >> Even in this case, chan

Re: [PATCHv3] wireless: check A-MSDU inner frame source address on AP interfaces

Johannes Berg <johan...@sipsolutions.net> writes: > On Wed, 2016-09-28 at 11:19 -0400, Jes Sorensen wrote: >>  >> I understand the intentions of this patch are all good, but you need >> to not post patches that include both staging and mainline drivers at >&g

Re: [PATCHv3] wireless: check A-MSDU inner frame source address on AP interfaces

Michael Braun writes: > When using WPA security, the station and thus the required key is > identified by its mac address when packets are received. So a > station usually cannot spoof its source mac address. > > But when a station sends an A-MSDU frame, port control

Re: [PATCH] realtek: Add switch variable to 'switch case not processed' messages

Joe Perches writes: > On Sat, 2016-09-24 at 14:06 -0500, Larry Finger wrote: >> On 09/24/2016 12:32 PM, Joe Perches wrote: > [] >> o Reindent all the switch/case blocks to a more normal >> kernel style (git diff -w would show no changes here) >> That sounds like busy work to

Re: [PATCH] realtek: Add switch variable to 'switch case not processed' messages

Larry Finger writes: > On 09/24/2016 12:32 PM, Joe Perches wrote: >> Is there any value in that or is Jes' work going to make >> doing any or all of this unnecessary and futile? > > That is not yet determined. The only driver that is to be replaced at > this point is

[PATCH 4/4] rtl8xxxu: Stop log spam from each successful interrupt

g line in question could probably be deleted. Rather than taking that action, I have changed it to only be printed when the newly added RTL8XXXU_DEBUG_INTERRUPT bit is set in the debug mask. Signed-off-by: Larry Finger <larry.fin...@lwfinger.net> Signed-off-by: Jes Sorensen <jes.soren...@redhat.co

[PATCH 1/4] rtl8xxxu: Fix off by one error calculating pubq

From: Jes Sorensen <jes.soren...@redhat.com> This was detected tracing the 8188eu driver, but doesn't seem to make any difference when using it. Signed-off-by: Jes Sorensen <jes.soren...@redhat.com> --- drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 2 +- 1 file changed,

[PATCH 2/4] rtl8xxxu: Clean up llt_init() API

From: Jes Sorensen <jes.soren...@redhat.com> Remove last_tx_page argument from the llt_init() function. The rtl8xxxu_fileops structure contains the correct TX_TOTAL_PAGE_NUM value for the device, and rtl8xxxu_auto_llt_table() doesn't need to know the value in the first place. Signed-off-b

[PATCH 0/4] rtl8xxxu - four patches for 4.9

From: Jes Sorensen <jes.soren...@redhat.com> Hi, This is a small set of patches, all but one are preparatory for the 8188eu support I am working on. The last is Larry's patch to reduce debug messages. It would be great to get in for 4.9. Cheers, Jes Jes Sorensen (3): rtl8xxxu: F

[PATCH 3/4] rtl8xxxu: Use a struct rtl8xxxu_fileops * in rtl8xxxu_init_device()

From: Jes Sorensen <jes.soren...@redhat.com> This saves some 217, or about, derefences of priv->fops. Signed-off-by: Jes Sorensen <jes.soren...@redhat.com> --- .../net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 37 +++--- 1 file changed, 19 insertions(+), 18 del

Re: RTL8192EU on rtl8xxxu driver breaks every few minutes

"Franc[e]sco" writes: > Hi, I happen to own a RTL8192EU WiFi dongle which is marked as untested > by the rtl8xxxu driver. > > I'm on a linux from scratch system using kernel 4.7.3 and wpa_supplicant > 2.5. > > The dongle appears to connect and work fine, but after around

Re: [PATCH] rtl8xxxu: Stop log spam from each successful interrupt

Kalle Valo <kv...@codeaurora.org> writes: > Jes Sorensen <jes.soren...@redhat.com> writes: > >> Joe Perches <j...@perches.com> writes: >>> I think it'd be nicer to use dev_dbg for all these cases >>> and as well use some new macro that includes

Re: [PATCH] rtl8xxxu: Stop log spam from each successful interrupt

Larry Finger <larry.fin...@lwfinger.net> writes: > On 09/17/2016 03:59 PM, Jes Sorensen wrote: >> Larry Finger <larry.fin...@lwfinger.net> writes: >>> As soon as debugging is turned on, the logs are filled with messages >>> reporting the interrupt s

Re: [PATCH] rtl8xxxu: Stop log spam from each successful interrupt

Larry Finger writes: > As soon as debugging is turned on, the logs are filled with messages > reporting the interrupt status. As this quantity is usually zero, this > output is not needed. In fact, there will be a report if the status is > not zero, thus the debug line

Re: [PATCH] rtl8xxxu: Stop log spam from each successful interrupt

Joe Perches writes: > On Sat, 2016-09-17 at 12:09 -0500, Larry Finger wrote: >> As soon as debugging is turned on, the logs are filled with messages >> reporting the interrupt status. As this quantity is usually zero, this >> output is not needed. In fact, there will be a report

[PATCH 0/1] Fix problem with rtl8192eu firmware reload

From: Jes Sorensen <jes.soren...@redhat.com> Hi, This one goes on top of my previous patches, albeit it probably applies out of order. It resolves the issue where firmware wouldn't load correctly if reloading the driver module. Cheers, Jes Jes Sorensen (1): rtl8xxxu: Implment

[PATCH 1/1] rtl8xxxu: Implement 8192e specific power down sequence

From: Jes Sorensen <jes.soren...@redhat.com> This powers down the 8192e correctly, or at least to the point where the firmware will load again, when reloading the driver module. Signed-off-by: Jes Sorensen <jes.soren...@redhat.com> --- .../net/wireless/realtek/rtl8xxxu/rtl8xxxu_8

Re: [PATCH] staging: squash lines for simple wrapper functions

Masahiro Yamada writes: > Remove unneeded variables and assignments. > > While we are here, clean up the following as well: > - refactor rtl8723a_get_bcn_valid() a bit > - remove unneeded casts in sii164Get{Vendor,Device}ID() > > Signed-off-by: Masahiro Yamada

Re: Support of rtl8723bs

Bastien Nocera writes: > On Mon, 2016-09-12 at 17:48 +0200, Hanno Zulla wrote: >> Hi, >> >> > Longer term I think it makes sense to add SDIO support to rtl8xxxu. >> > The >> > differences between the USB version and the SDIO version are rather >> > small. >> >> >> This is

Re: Support of rtl8723bs

Bastien Nocera writes: > On Mon, 2016-09-12 at 11:20 +0200, Hanno Zulla wrote: >> Hi Jes, >> hello linux-wireless, >> it as a guinea pig to test on my hardware. The newer vendor driver >> crashed on Ubuntu' 4.4 sources and doesn't compile yet on Ubuntu 4.8- >> rc >> sources. >>

[PATCH - FYI - do not apply] staging: Remove rtl8723au driver

From: Jes Sorensen <jes.soren...@redhat.com> Hi, I sent Greg the full version of this patch, removing the old rtl8723au driver. I didn't want to spam the list with a 2M+ patch so this is the summary version. Cheers, Jes This driver is superseded by rtl8xxxu and has been marked as sch

[PATCH 0/2] Fix spelling and reset device on module unload

From: Jes Sorensen <jes.soren...@redhat.com> Hi, Two fixes for the rtl8xxxu driver. I am working on a much larger set which adds 8188eu support, and while it's close to there, I am still chasing one issue where it doesn't come back if reloading the driver module. In the interim, the

[PATCH 2/2] rtl8xxxu: fix spelling mistake "firmare" -> "firmware"

From: Colin Ian King <colin.k...@canonical.com> Trivial fix to spelling mistakes in dev_dbg message. Signed-off-by: Colin Ian King <colin.k...@canonical.com> Signed-off-by: Jes Sorensen <jes.soren...@redhat.com> --- drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 4 ++

[PATCH 1/2] rtl8xxxu: Reset device on module unload if still attached

From: Jes Sorensen <jes.soren...@redhat.com> If the USB dongle is still attached, reset it on module unload to avoid scans failing when reloading the driver. Signed-off-by: Jes Sorensen <jes.soren...@redhat.com> --- drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 5 + 1

Re: rtl8xxxu: fix spelling mistake "firmare" -> "firmware"

Kalle Valo writes: > Colin Ian King wrote: >> From: Colin Ian King >> >> Trivial fix to spelling mistakes in dev_dbg message. >> >> Signed-off-by: Colin Ian King >> Reviewed-by: Julian Calaby

Re: [PATCH 0/5] Some cleanup patches for drivers/staging/rtl8723au/core/rtw_mlme.c

Joe Perches <j...@perches.com> writes: > On Tue, 2016-09-06 at 12:00 -0400, Jes Sorensen wrote: > >> Nothing wrong with these patches, however I intend to post a patch to >> remove this driver soon, so it's kind of a waste of your time to spend >> too many cycles

Re: [PATCH 0/5] Some cleanup patches for drivers/staging/rtl8723au/core/rtw_mlme.c

Matthias Beyer writes: > This patchset fixes some errors and warnings reported by checkpatch.pl. > > Matthias Beyer (5): > drivers: staging: rtl8723au: core: Fix checkpatch.pl errors > drivers: staging: rtl8723au: core: simplify if-break-else > drivers: staging:

Re: fix:rtl8xxxu_core: mark symbols static where possible

Kalle Valo writes: > Baoyou Xie wrote: >> We get 1 warning about global functions without a declaration >> in the rtl8xxxu rtl8xxxu_core.c when building with W=1: >> drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c:898:1: >> warning: no previous

  1   2   3   4   5   6   7   >