On Wed, Nov 08, 2023 at 03:14:06AM +0800, Chwee-Lin Choong wrote:
> The current implementation falls short in detecting duplicate
> pdelay responses, i.e., multiple responses from the same peer.
There can only ever be one peer, and so it is pointless to track the peer.
If more than one peer delay
On Mon, Oct 30, 2023 at 10:44:13AM +, Luca Fancellu wrote:
> This is what I’ve tried:
>
> Makefile:
>
> CC ?= $(CROSS_COMPILE)gcc
and if you add:
export CC
does it work?
Thanks,
Richard
On Thu, Oct 26, 2023 at 08:41:08AM +, Luca Fancellu wrote:
> Any thought about this?
For the sake of consistency, can you please implement something like
this instead?
commit d3dd51ba611802d7cbb28631cb943cb882fa4aac
Author: Changqing Li
Date: Wed Nov 23 08:23:46 2022 +0800
makefile: u
On Fri, Oct 20, 2023 at 12:59:57PM -0700, Richard Cochran wrote:
> On Fri, Oct 20, 2023 at 07:15:59PM +0200, Erez wrote:
>
> > And we can change CC to
> > CC ?= ...
> >
> > In case CC comes from the build, like in Yocto and Debian.
>
> Nah, build system
On Fri, Oct 20, 2023 at 01:24:51PM -0700, Khem Raj wrote:
> Newer compilers complain about missing signatures for stncpy as said in
> subject.
Well, the why not state which compiler was used, and also share the
warning output?
Thanks,
Richard
___
Lin
On Fri, Oct 20, 2023 at 07:15:59PM +0200, Erez wrote:
> And we can change CC to
> CC ?= ...
>
> In case CC comes from the build, like in Yocto and Debian.
Nah, build systems that don't want to use gcc can and should dial what
they want on the command line:
make CC=abcxyz
See:
https://ww
On Fri, Oct 20, 2023 at 07:15:59PM +0200, Erez wrote:
> How about
> $(shell CC=${CC} ./incdefs.sh)
but using makefile $(CC) and not shell script ${CC}
Thanks,
Richard
___
Linuxptp-devel mailing list
Linuxptp-devel@lists.sourceforge.net
https://lists
On Thu, Oct 19, 2023 at 03:50:20PM +0100, Luca Fancellu wrote:
> From: Khem Raj
>
> Signed-off-by: Khem Raj
> ---
> interface.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/interface.c b/interface.c
> index 29229ad6f53d..9a83c36933e7 100644
> --- a/interface.c
> +++ b/interface.c
>
On Tue, Aug 29, 2023 at 02:11:07PM +0200, Miroslav Lichvar wrote:
> When phc2sys in the automatic mode has only one non-CLOCK_REALTIME
> domain, avoid logging the potentially confusing "selecting ... as
> out-of-domain source clock" message. The source clock in the domain is
> already logged. Also,
On Tue, Sep 05, 2023 at 08:03:49AM +0200, Miroslav Lichvar wrote:
> The domain number used for communication with ptp4l specified by the -n
> option is ignored in the non-automatic mode (-w option). Set the domain
> number to the last specified value.
>
> Fixes: 417de97d098b ("phc2sys: Add multi-d
On Mon, Sep 04, 2023 at 01:24:50PM +0200, Miroslav Lichvar wrote:
> Will you submit it as a git-formatted patch with subject and commit
> message, or would you prefer me to do it?
I made a patch so we can get this fix into the Sept 5 quarterly release.
Please take a look.
Thanks,
Richard
__
present on the
command line before changing the UDS address.
Signed-off-by: Richard Cochran
Reported-by: Trey Harrison
---
phc2sys.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/phc2sys.c b/phc2sys.c
index 313cdcf..9d8d42f 100644
--- a/phc2sys.c
+++ b/phc2sys.c
@@ -1490,7
On Fri, Aug 18, 2023 at 09:24:14AM -0700, Jacob Keller wrote:
> This version looks good to me.
>
> Reviewed-by: Jacob Keller
Series applied, but I took the liberty of correcting grammar and
punctuation of the man page text.
Thanks,
Richard
___
Linux
On Mon, Aug 21, 2023 at 11:24:25AM +0200, Luigi Mantellini wrote:
> The PORTS_STATS_NP carries RX/TX counters for each Message Type.
> The following patch fills the spare slots in order to add the following
> counters:
>
> (MSG_TYPES EVENT0x0...0x3)
> RX_BAD_MESSAGE 0x4
>
On Thu, Jun 22, 2023 at 11:00:52PM -0700, Jacob Keller wrote:
> The PTP_CLOCK_GETCAPS ioctl call in phc_ctl has a conditional check for
> whether to report the caps.adjust_phase bit. This is always set for both
> PTP_CLOCK_GETCAPS and PTP_CLOCK_GETCAPS2, and was always zero before the
> bit was mov
On Tue, Aug 08, 2023 at 11:36:52AM +0200, Maciek Machnikowski wrote:
> v2: changed pmc_agent implementation to not use a separate callback
> v3: updated poll thread to use less CPU
> v4: changed sleep routine to usleep, simplified poll thread
You have resent v5, but I see v6 with changes:
26.
On Fri, Aug 11, 2023 at 02:51:23PM +0200, Walfred Tedeschi via Linuxptp-devel
wrote:
> Dear List,
>
> I kindly come to you to ask attention on the patches regarding the
> multi-domain implementation.
I have limited time for reviewing patches, but I will eventually get
to this series.
The CMLDS
On Fri, Jul 28, 2023 at 09:18:12AM +0200, Stephan Wurm wrote:
> I think we need to figure out, how the clock synchronization sections
> are affected by this standards update.
+1
___
Linuxptp-devel mailing list
Linuxptp-devel@lists.sourceforge.net
https
On Tue, Jul 25, 2023 at 09:34:00AM +0200, Lukasz Plachno wrote:
> As tx timestamp timeout is something multiple users encounter,
> provide information for configuring kthread priorities in manual
> for ptp4l where tx_timestamp_timeout is already described.
Nice to have an updated man page, but I h
On Fri, Jun 30, 2023 at 10:14:06AM +0200, Stephan Wurm wrote:
> The PRP trailer detection used a minimum frame size of 70 octets. This
> minimum applies to whole ethernet packet frames, consisting of headers,
> payload and frame check sequence (FCS).
>
> Under Linux, VLAN header and FCS are usuall
On Thu, Jun 22, 2023 at 10:47:54PM -0700, Jacob Keller wrote:
> When building the tlv.c file, the following warning may occur when
> operating in C89 mode:
>
> $make EXTRA_CFLAGS=-std=gnu89
> tlv.c: In function ‘mgt_post_recv’:
> tlv.c:374:17: error: ‘for’ loop initial declarations are only
On Thu, Jul 20, 2023 at 04:33:38PM +0200, Miroslav Lichvar wrote:
> RFC->v1:
> - split into multiple patches
> - fixed non-automatic modes
> - fixed handling of TAI-UTC offset and leap seconds
> - fixed other bugs
> - updated man page
>
> This series improves the automatic mode in phc2sys to suppo
On Tue, Jul 04, 2023 at 12:30:38PM +0200, Stephan Wurm wrote:
> diff --git a/fsm.h b/fsm.h
> index 857af05..919e934 100644
> --- a/fsm.h
> +++ b/fsm.h
> @@ -31,6 +31,7 @@ enum port_state {
> PS_PASSIVE,
> PS_UNCALIBRATED,
> PS_SLAVE,
> + PS_PASSIVE_SLAVE, /*according to IEC 6
On Tue, Jul 04, 2023 at 12:30:37PM +0200, Stephan Wurm wrote:
> This patch series adds support for doubly-attached clocks as described
> in IEC 62439-3:2016 Appendix A.
Without having a copy of that, I'm going to have a hard time
swallowing this patch set.
Overall, I can't see the reason for this
On Tue, Jul 04, 2023 at 12:30:37PM +0200, Stephan Wurm wrote:
> This patch series adds support for doubly-attached clocks as described
> in IEC 62439-3:2016 Appendix A.
According to
https://webstore.iec.ch/publication/24447
this standard has been "Withdrawn" ?
Thanks,
Richard
___
On Fri, Jul 14, 2023 at 08:43:30PM +, Keller, Jacob E wrote:
> > With this patch applied, one will get proper error in last line,
> > "Timer expired", and more modern suggestion about how to approach fixing it
> >
>
>
> I think changing the message about what might be causing timeout is
> un
On Tue, Jun 06, 2023 at 02:25:44PM -0400, Dylan Robinson wrote:
> If the transportSpecific value is configured to be 1, compute t3c using
> the 802.1AS math instead of the 1588 math.
>
> The 1588 defined computation using variable names from this project is:
> D = [(t4 - t1) - (t3 - t2) - c1 -
On Thu, Jun 22, 2023 at 10:09:50AM -0700, Rahul Rameshbabu via Linuxptp-devel
wrote:
> On Thu, 22 Jun, 2023 12:11:05 +0200 Erez wrote:
> > Just add a version tag, please. Whether you add an RFC or not.
> > If you really must , you can add a note in the cover letter for Richard.
>
> Noted for fut
On Mon, May 01, 2023 at 02:22:57PM +0300, Eyal Itkin via Linuxptp-devel wrote:
> When delay_mechanism is set to "E2E" mode in the [global] section,
> it is applied only to non-UDS ports as UDS ports will override the
> delay_mechanism with "DM_AUTO". Still the UDS ports will be checked
> for hybrid
On Mon, Jun 12, 2023 at 10:18:07AM +0200, Jakub Raczyński wrote:
> In master version and 4.0 this patch was not applied. Please apply this when
> possible.
That patch does not apply (as I said back on 07 Dec 2022)
If you want to have it, then please clean it up and re-submit.
Thanks,
Richard
On Tue, Jun 20, 2023 at 04:13:18PM -0700, Rahul Rameshbabu via Linuxptp-devel
wrote:
> > I think Richard wanted to close version 4 first.
>
> Sure, that makes sense. I am hoping RFC patches are not considered for
> merging into releases or the default branch of the project. At the time,
> the ne
On Fri, Jun 16, 2023 at 06:21:57PM -0400, Dylan Robinson wrote:
> I feel bad for how I communicated.
np, I also want to apologize because after re-reading the thread, I
was indeed projecting an "ulterior motive" onto your posts.
Your summary of the different standards is helpful, and I think it
On Thu, Jun 15, 2023 at 05:02:14PM -0400, Dylan Robinson wrote:
> I don't think I'm conflating these things and the problem exists merely
> with properly padded packets. I have been trying to discuss how best to
> be a robust IEEE 802.3 MAC client by examining the standards documents.
I claim that
On Wed, Jun 14, 2023 at 11:48:11AM -0400, Dylan Robinson wrote:
> I don't think you are appreciating how low level this transport actually
> is, when a linuxptp instance sends a 44 byte sync message using the
> layer-2 transport a linuxptp receiver instance will always receive a
> 46 byte sync mes
On Thu, Jun 15, 2023 at 07:49:58AM -0400, Dylan Robinson wrote:
> 4. Enable fcs reception using the following command.
There is no use case for enabling fcs. Really.
(no) Thanks,
Richard
___
Linuxptp-devel mailing list
Linuxptp-devel@lists.sourceforg
On Wed, Jun 14, 2023 at 03:51:08PM +0200, Walfred Tedeschi via Linuxptp-devel
wrote:
> Covering for Industrial/Process automation customers that are willing to use
> PMC interface to gather status of the time synchronization for their stack
> and enable them to take actions upon the values receiv
On Tue, Mar 14, 2023 at 08:20:47AM +, Jürgen Appel via Linuxptp-devel wrote:
> Please ignore/delete my previous email with identical subject,
> line wrapping ruined the formatting.
>
> Purpose of this patch:
> This fixes an issue with transitioning to the transition
> of the servo state from
On Tue, Jun 13, 2023 at 12:57:10PM -0400, Dylan Robinson wrote:
> Definitely. In the audio space where I work there are many examples of
> this. I have seen how being first to market and having wide adoption can
> end up turning "improper" implementations into a de facto standard.
> Based on my re
On Tue, Jun 13, 2023 at 01:01:11PM +0200, Erez wrote:
> Just so I am clear on the matter.
> I simply suggest taking the same test you run with linuxptp-testsuite.
> And run it in a github action. So we can all run it before we send patches.
> In addition to the tests you run :-)
I run the tests _
On Tue, Jun 13, 2023 at 08:02:29AM +0200, Erez wrote:
> Hi,
>
> Using Miroslav's linuxptp-testsuite we can run a simulated HIL in github
> itself.
"Simulated HIL" is an oxymoron. H stand for hardware.
Don't get me wrong, I absolutely love linuxptp-testsuite, and I run it
on every single patch.
On Fri, Jun 09, 2023 at 07:14:31PM -0700, Richard Cochran wrote:
> On Fri, Jun 09, 2023 at 09:44:04AM -0700, Bernie Gmail wrote:
> > It would really be cool to read mode about your HIL setup. I would like to
> > create a similar setup
>
> I'll publish the source
On Mon, Jun 12, 2023 at 09:11:39AM +0200, Miroslav Lichvar wrote:
> With the new schedule, will there be a deadline for submitting new
> features and the rest focused on testing and stabilization?
We can aim for a code freeze on the first of the month, March, June,
September, and December.
Thanks
On Sun, Jun 11, 2023 at 05:51:40PM -0400, Dylan Robinson wrote:
> Use the messageLength header field, rather than the number of bytes
> received from the transport layer, when determining the length of the
> suffix. Check to make sure the transport layer delivered at least
> messageLength number of
On Fri, Jun 09, 2023 at 09:44:04AM -0700, Bernie Gmail wrote:
> It would really be cool to read mode about your HIL setup. I would like to
> create a similar setup
I'll publish the source code. The HIL depends strongly on the actual
hardware that I happen to have, and I'm NOT trying to make a ge
Dear linuxptp users and developers,
Moving forward I am planning on making quarterly releases. The next
target dates are as follows.
September 5 2023
December 5 2023
March 5 2024
June 5 2024
Inspired by Miroslav's wonderful linuxptp-testsuite, for yesterday's
release I developed a har
clock: Fix summary interval in free-running mode.
Nikhil Gupta (1):
lstab: Bring expiration up to date.
Rahul Rameshbabu via Linuxptp-devel (2):
Improve efficiency of nullf servo synchronization
Fix SERVO_JUMP docstring comment
Richard Cochran (78):
Introduce the PMC agent mo
On Thu, Jun 08, 2023 at 10:00:30AM +, Eyal Itkin via Linuxptp-devel wrote:
> Hi,
>
> I know this isn't a critical issue (to say the least), just wanted to check
> if it got missed by mistake or if there was a decision not to include this
> minor bug fix.
The code is frozen ATM.
I'll be anno
On Fri, Jun 02, 2023 at 05:16:29PM -0400, Dylan Robinson wrote:
> @@ -2433,7 +2433,14 @@ static void port_peer_delay(struct port *p)
> t3 = timestamp_to_tmv(fup->ts.pdu);
> c2 = correction_to_tmv(fup->header.correction);
> calc:
> - t3c = tmv_add(t3, tmv_add(c1, c2));
> +
On Thu, Jun 01, 2023 at 03:13:31PM -0400, Dylan Robinson wrote:
> I fully understand, which is why the proposal is to fix the 802.1AS specific
> computation, and use the 802.1AS computation whenever the link is 802.1AS.
The linuxptp code doesn't really have a concept of a link "being
802.1AS" or
On Thu, Jun 01, 2023 at 04:41:48PM -0400, Dylan Robinson wrote:
> On Thu, 1 Jun 2023 15:13:31 -0400, Dylan Robinson wrote:
>
> > On Thu, 1 Jun 2023 06:34:19 -0700, Richard Cochran wrote:
> >
> > > It sounds like 802.1-AS has a bug.
> >
> > I don't thi
On Wed, May 31, 2023 at 12:33:46PM -0400, Dylan Robinson wrote:
> This is generally not an issue, since 802.1AS implementations typically set
> this field to zero, however, there is at least one switch IC on the market,
> the KSZ9567, with a silicon errata that results in a non-zero value in this
On Thu, Jun 01, 2023 at 11:17:48AM +0200, Erez wrote:
> But if your patch follows the IEEE standard, then perhaps Richard will
> apply.
It sounds like 802.1-AS has a bug.
Is there a "Tissue" that addresses this problem?
Why would a peer delay need correction at all?
After all, the messages are
On Wed, May 31, 2023 at 07:33:56PM +0800, Merlin He wrote:
> If the time offset between master(eg, 2023/05/31) and slave(eg, 1970/1/1)
> is very large, then it is 100% reproduced
What is "it" ?
Please write a detailed commit log message that explians:
1. context
2. problem
3. solution
Thanks,
On Mon, May 29, 2023 at 03:43:15PM +0200, Frantisek Rysanek wrote:
> B) the more modern way: Announce+Sync+Follow-up properly tagged,
> running in custom VLAN's, only the PDelay running either tagged with
> the default VLAN, or untagged (on the trunk).
Why would PDelay messages be in a differen
On Fri, May 26, 2023 at 03:02:43PM +0800, egg car wrote:
> It's a bit complicated to use, I see why they use 'struct timecounter'
> instead of hardware PHC
> counter, and in this case all the timestamp regs cannot be used directly.
> Needs more time to find out how to fix this, either the driver o
On Thu, May 18, 2023 at 04:26:54PM +0200, Miroslav Lichvar wrote:
> In the free-running mode the stats are updated only once per the
> frequency estimation interval instead of once per sync message. The
> stats max_count calculation didn't account for that, which caused a
> reduced rate of printed
On Tue, May 16, 2023 at 05:10:07PM +0300, Eyal Itkin via Linuxptp-devel wrote:
> A Boundary Clock might choose to switch a PHC when jbod is active,
> and the transition will be based on the port's phc_index. However,
> when using the slave event monitoring + free_running the phc_index
> is -1, thus
On Sun, Mar 12, 2023 at 09:07:04PM -0400, Vincent Cheng wrote:
> When local clock data set is better than remote server, log message says
> remote
> server is best master.
The message means that the given clock was selected as best from among
the foreign clocks.
> The port states are correct.
>
On Tue, May 16, 2023 at 01:34:56PM +, Eyal Itkin wrote:
> Our use case is using the Slave Event Monitoring feature alongside
> free_running so to implement an external servo - on a BC with jbod.
I would encourage you to contribute the servo. After all, the code is
modular with PI, linear reg
On Tue, Apr 04, 2023 at 12:32:57PM +0800, Merlin He wrote:
> port_nrate_calculate() sampling the first ingress1 before slave clock
> jumping, if the offset of master and slave is too large, this may
> results in an extremly small nrate_ratio value, and cause the nagative
> delay issue.
I don't und
On Mon, May 01, 2023 at 02:17:21PM +0300, Eyal Itkin via Linuxptp-devel wrote:
> A Boundary Clock might choose to switch a PHC when jbod is active,
> and the transition will be based on the port's phc_index. However,
> while free_running the phc_index is -1, thus causing a fault in the
> transition
e issue by assigning the field prior to the first
invocation of the cleanup method.
Signed-off-by: Richard Cochran
---
ts2phc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ts2phc.c b/ts2phc.c
index db5ea3f..3d3 100644
--- a/ts2phc.c
+++ b/ts2phc.c
@@ -577,6 +577,7 @@ in
On Sun, Apr 30, 2023 at 01:50:34PM -0700, Richard Cochran wrote:
> Thanks for finding this. I'd like to fix it in a simpler way.
FWIW I am going ahead with my patch.
@Miroslav it changes the default value for one field, and so the test
suite would need the following change.
Thanks,
On Tue, May 09, 2023 at 09:43:11AM +0800, Tan Tee Min wrote:
> According to IEEE Std 1588-2019 Chapter 6.4 PTP message classes,
> all PTP messages can be extended by means of a standard Type,
> Length, Value (TLV) extension mechanism.
>
> Avnu conformance tests for 802.1AS-2020 do validate whether
On Mon, May 08, 2023 at 05:17:57PM +0800, Hangbin Liu wrote:
> On Tue, May 2, 2023 at 10:56 PM Martin Pecka wrote:
> >
> > Fixes issue "Bug caused by commit afeabf3 "ptp4l: add VLAN over bond
> > support" on kernel 4.9" reported on linuxptp-devel.
> >
> > SIOCGHWTSTAMP ioctl is optional according
On Tue, May 09, 2023 at 02:02:05PM +0200, Andrew Zaborowski wrote:
> Per https://www.kernel.org/doc/Documentation/networking/timestamping.txt
> section 3:
> "User space is responsible to ensure that multiple processes don't interfere
> with each other and that the settings are reset."
>
> Add lock
On Tue, May 09, 2023 at 02:02:05PM +0200, Andrew Zaborowski wrote:
> Per https://www.kernel.org/doc/Documentation/networking/timestamping.txt
> section 3:
> "User space is responsible to ensure that multiple processes don't interfere
> with each other and that the settings are reset."
>
> Add lock
On Tue, May 09, 2023 at 01:35:59PM +, Woojung.Huh--- via Linuxptp-devel
wrote:
> Do I miss or misunderstand something?
The intent of the standards appears to be to allow TLVs on any PTP
message.
Thanks,
Richard
___
Linuxptp-devel mailing list
On Mon, May 08, 2023 at 05:46:30PM +0800, Tan Tee Min wrote:
> We are working towards the Avnu conformance tests for 802.1AS-2020, and
> actually Avnu do validate whether the device can properly ignore unknown
> TLVs in received PTP messages.
>
> Without this implementation, we observe "bad messa
On Mon, May 01, 2023 at 06:29:59PM +0200, Martin Pecka wrote:
> > A driver which supports hardware time stamping must support the
> > SIOCSHWTSTAMP ioctl and update the supplied struct hwtstamp_config with
> > the actual values as described in the section on SIOCSHWTSTAMP. It
> > should also supp
On Wed, Apr 26, 2023 at 02:44:27PM +0200, Miroslav Lichvar wrote:
> When the netlink socket of a port (used for receiving link up/down
> events) had an error (e.g. ENOBUFS due to the kernel sending too many
> messages), ptp4l switched the port to the faulty state, but it kept
> getting POLLERR on t
On Thu, Mar 30, 2023 at 11:16:44AM +0800, Hangbin Liu wrote:
> Richard, what do you think?
This code in hwts_init is wrong:
cfg.flags = HWTSTAMP_FLAG_BONDED_PHC_INDEX;
/* Fall back without flag if user run new build on old kernel */
if (ioctl(fd, SIOCGHWTSTAMP, &ifreq) ==
.grandmasterTimeInaccuracy at line 44
> failed to parse configuration file configs/default.cfg
Jacob,
Thanks for finding this. I'd like to fix it in a simpler way.
Do you agree?
Thanks,
Richard
---
>From 5cfba921f9bf1f97028c5f999c399e9bb554cfd7 Mon Sep 17 00:00:00 2001
From: Richard Cochra
On Wed, Mar 29, 2023 at 11:30:49AM -0700, Jacob Keller wrote:
> This appears to be caused by using a base of 0 to strtol which then
> interprets leading 0 numbers as octal. This is probably done in order to
> get handling of '0x' prefixed numbers as well, but the leading 0 ->
> octal interpretatio
On Tue, Feb 28, 2023 at 01:47:03AM +0100, Andrew Zaborowski wrote:
> Use a lock file to be able to log an error when the UDS socket's path is
> in use by another instance, avoid silently unlink()ing it.
>
> There's no way for multiple instances (e.g. in a multi-domain setup) to
> bind() to the sam
On Thu, Mar 16, 2023 at 03:47:47PM +0100, Maciek Machnikowski wrote:
> The SHM is not cleared upon servo release when exiting the tool. This
> leaves the last update in the shared memory region marked as valid.
>
> Users may not expect such behavior. If the configuration changed, or the
> tool was
On Wed, Mar 01, 2023 at 01:04:34PM +0800, Tan Tee Min wrote:
> According to IEEE Std 1588-2019 Chapter 6.4 PTP message classes,
> all PTP messages can be extended by means of a standard
> Type, Length, Value (TLV) extension mechanism.
Since the present code does not append any TLVs on such message
On Thu, Apr 27, 2023 at 09:58:13AM +0200, Maciek Machnikowski wrote:
> No leap seconds will happen till the end of 2023.
(Only twelve more years of this BS to endure. ;^)
> Update leapfile
> validity accordingly.
>
> Signed-off-by: Maciek Machnikowski
Applied.
Thanks,
Richard
_
On Wed, Mar 15, 2023 at 11:44:11AM +0100, Miroslav Lichvar wrote:
> When ptp4l was configured to use SW timestamping, but the interface
> supported also HW timestamping, ptp4l detected a change of the PHC on
> start, switched to it from the system clock, and tried to control the
> PHC using SW time
On Wed, Apr 26, 2023 at 09:33:05AM +0200, Maciek Machnikowski wrote:
> Is it still possible to get those 2 patches into 4.0?
Yes.
Thanks,
Richard
___
Linuxptp-devel mailing list
Linuxptp-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/
On Tue, Apr 11, 2023 at 03:08:40PM +0200, Maciek Machnikowski wrote:
> Currently ts2phc prints "poll failed" error to the LOG_EMERG when
> the poll for tod fails. This causes error print on all terminals
> when the tool gets terminated using SIGINT (ex. by pressing CTRL+C).
>
> v2: Properly handle
On Mon, Mar 13, 2023 at 09:31:43PM +0100, Maciek Machnikowski wrote:
> An unallocated pmc_agent may be dereferenced in the pmc_agent_destroy
> called by the ts2phc_cleanup().
> Check if the agent was allocated before releasing it.
>
> v2: Fixed coding standard
>
> Signed-off-by: Maciek Machnikows
On Tue, Apr 25, 2023 at 06:23:53PM +0200, Luigi 'Comio' Mantellini wrote:
> Any review on this patchset?
I'm working on releasing v4.0. Once that is done, I'll start
reviewing new stuff once again.
Without having looked at your patch series, I've wanted to convert
from one shot to periodic timer
On Mon, Apr 24, 2023 at 10:45:56AM +0200, Stephan Wurm wrote:
> @@ -210,6 +219,40 @@ enum port_state ptp_fsm(enum port_state state, enum
> fsm_event event, int mdiff)
> + case PS_PASSIVE_SLAVE:
> + switch (event) {
> + case EV_DESIGNATED_DISABLED:
> +
On Mon, Apr 17, 2023 at 11:07:10AM +0200, Miroslav Lichvar wrote:
> As for the 4.0 release, can you please have a look at this bug fix?
> https://www.mail-archive.com/linuxptp-devel@lists.sourceforge.net/msg06420.html
+1
___
Linuxptp-devel mailing lis
On Thu, Mar 16, 2023 at 02:58:33PM +0100, Andrew Zaborowski wrote:
> I was now made aware that Avnu conformance tests for 802.1AS-2011 do
> validate the 3 different values required in the control field in that
> version of IEEE802.1AS. While 1588-2008 did already say that the use
> of this field
Based on Erez's review, I expanded Christopher's patch to remove the
control field codes completely. I've tested this with the following
hardware, and nothing broke:
Intel I210
Intel X550T
LabX Titanium 411 AVB switch
Please give this a try with your favorite hardware time stamping
device. I'd
2019 version")
however, where ptp4l switches the version field to the IEEE1588-2019
value.
[ RPC: Remove every last trace of the control field codes. ]
Signed-off-by: Andrew Zaborowski
Signed-off-by: Richard Cochran
---
msg.h| 9 -
nsm.c| 1 -
pmc_
On Tue, Apr 11, 2023 at 03:16:47PM +0200, Maciek Machnikowski wrote:
> Add tz2alt to .gitignore list
>
> Signed-off-by: Maciek Machnikowski
Applied.
Thanks,
Richard
___
Linuxptp-devel mailing list
Linuxptp-devel@lists.sourceforge.net
https://lists.s
On Mon, Mar 20, 2023 at 09:04:59PM -0700, Kishen Maloor wrote:
> Yes, we would configure CMLDS just once per physical port on a PTP node.
Okay, so the code should check this.
(Haven't reviewed yet, maybe you handle that already?)
Thanks,
Richard
___
On Mon, Mar 20, 2023 at 02:40:30PM -0700, Kishen Maloor wrote:
> On 3/20/23 12:31 PM, Richard Cochran wrote:
> > On Sun, Mar 19, 2023 at 10:36:48PM -0400, Kishen Maloor wrote:
> >
> >> 'run_cmlds': This per-port setting (0/1) declares that a port
> >>
On Sun, Mar 19, 2023 at 10:36:48PM -0400, Kishen Maloor wrote:
> 'run_cmlds': This per-port setting (0/1) declares that a port
> will perform the role of a CMLDS Link Port (IEEE 1588, clause 16.6.1)
> and execute CMLDS Pdelay transactions
How many ports may have run_cmlds == 1 ?
Thanks,
Richard
On Wed, Mar 15, 2023 at 01:14:50PM +0200, Kamil Zaripov wrote:
> The issue is ptp4l does not support out of the box creating two
> ports on the same network interfaces with different
> network_transport configuration values. I want to discuss how
> linuxptp code can be patched so user can do such
On Tue, Mar 14, 2023 at 12:38:06PM +0200, Kamil Zaripov wrote:
> Can you explain the problems you see with timestamping in the interface on
> top of a bridge?
When a MAC joins a bridge, the MAC is no longer avaiable as a network
interface. This is how the bridge thing is implemented in Linux.
T
On Tue, Mar 14, 2023 at 07:42:19PM +0100, Andrew Zaborowski wrote:
> On Tue, 7 Mar 2023 at 16:35, Richard Cochran wrote:
> > On Tue, Mar 07, 2023 at 04:21:52PM +0100, Andrew Zaborowski wrote:
> > > The (minor) problem this attempts to solve, and I didn't state that,
On Mon, Mar 13, 2023 at 12:25:28PM +0200, Kamil Zaripov wrote:
>
> > On 13 Mar 2023, at 03:56, Richard Cochran wrote:
> >
> > We don't support PTP on top of bridge interfaces, because the kernel
> > does not support that, and it would be difficult to add.
>
On Mon, Mar 13, 2023 at 03:07:27PM +0100, Maciek Machnikowski wrote:
> An unallocated pmc_agent may be dereferenced in the pmc_agent_destroy
> called by the ts2phc_cleanup().
> Check if the agent was allocated before releasing it.
>
> Signed-off-by: Maciek Machnikowski
> ---
> ts2phc.c | 3 ++-
>
On Fri, Mar 10, 2023 at 05:31:29PM +0200, Kamil Zaripov wrote:
> However in a bit more complex network configuration when your VLAN
> interface is created on top of bridge that includes “hardware”
We don't support PTP on top of bridge interfaces, because the kernel
does not support that, and it w
On Tue, Feb 28, 2023 at 06:59:17AM -0800, Richard Cochran wrote:
> On Tue, Feb 28, 2023 at 12:03:15PM +0100, Maciek Machnikowski wrote:
> > Can we add it to the configs/ts2phc*.cfg for the 4.0 release?
>
> That is not a critical bug, IMO.
v4.0 is delayed, and so feel free to sub
On Wed, Feb 22, 2023 at 09:51:56PM +0100, Erez wrote:
> Great :-)
> Will your power profile patch be included?
Yes.
Thanks,
Richard
___
Linuxptp-devel mailing list
Linuxptp-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux
101 - 200 of 1895 matches
Mail list logo
