Re: [Linuxptp-devel] [RFC] ptp4l: improved-accuracy hook

2021-08-05 Thread Richard Cochran
On Thu, Aug 05, 2021 at 06:40:35AM -0700, Richard Cochran wrote: > Of course you are welcome to hack it into ptp4l for your research. And once you have the AI algorithm perfected, simply code the result into the device driver as Jacob suggested. Thanks, Rich

Re: [Linuxptp-devel] [RFC] ptp4l: improved-accuracy hook

2021-08-05 Thread Richard Cochran
On Thu, Aug 05, 2021 at 10:50:40AM +0300, Aya Levin wrote: > These AI algorithms frequently tuned and improve over time, hence we don't > think they belong in the driver. Implementing them here allows immediate and > frequent updates of the logic without the heavy operation of driver upgrade.

Re: [Linuxptp-devel] [RFC] ptp4l: improved-accuracy hook

2021-08-07 Thread Richard Cochran
On Tue, Aug 03, 2021 at 02:31:25PM +0300, Aya Levin via Linuxptp-devel wrote: > I would like to push an infra structure hook to the ptp4l. This hook allows > vendors to estimate the HW time-stamp closer to the actual transmission and > reach better accuracy. The hook will receive the HW

[Linuxptp-devel] [PATCH] Rename management ID macros.

2021-08-01 Thread Richard Cochran
The management ID macros are prefixed with TLV. This is confusing, because the true TLV tags have the same prefix. Make the code more readable by using an appropriate prefix the for management IDs. Signed-off-by: Richard Cochran --- clock.c | 130

Re: [Linuxptp-devel] [v2] lstab: update expiration to 28 December 2021

2021-08-04 Thread Richard Cochran
On Mon, Jul 26, 2021 at 05:58:08PM +0800, Yangbo Lu wrote: > Bring the built in leap second table up to date through IERS Bulletin C62. > No new leap seconds have been scheduled for this year. > > Signed-off-by: Yangbo Lu Applied. Thanks, Richard

Re: [Linuxptp-devel] [PATCH] Fix quoting in ptp4l man page.

2021-08-04 Thread Richard Cochran
On Mon, Jul 19, 2021 at 05:22:57PM +0200, Miroslav Lichvar wrote: > In the groff syntax lines starting with a dot or quote are requests. A > line in the servo_offset_threshold description starts with a quote, > which breaks the output. Move a word to the beginning of the line to fix > it. > >

Re: [Linuxptp-devel] [PATCH] lstab: Close file after reading.

2021-08-04 Thread Richard Cochran
On Tue, Jul 20, 2021 at 11:48:56AM +0200, Miroslav Lichvar wrote: > The lstab_read() function opens a file, but doesn't close it after use. > > Signed-off-by: Miroslav Lichvar Applied. Thanks, Richard ___ Linuxptp-devel mailing list

Re: [Linuxptp-devel] [PATCH] config: Add workaround for glibc getopt_long().

2021-08-04 Thread Richard Cochran
On Tue, Jul 13, 2021 at 10:31:16AM +0200, Miroslav Lichvar wrote: > getopt_long() in glibc allows shortened long option names, e.g. > ptp4l --domain works as --domainNumber. When the match is ambiguous, > e.g. --fault matches --fault_badpeernet_interval and > --fault_reset_interval, it is supposed

Re: [Linuxptp-devel] [PATCH v3 0/5] Fixes for sanity clock check

2021-08-04 Thread Richard Cochran
On Mon, May 31, 2021 at 11:07:51AM +0200, Miroslav Lichvar wrote: > v3 > - added patch to avoid slow renewal of raw sockets > - added patch to increase the minimum check interval > > v2 > - improved commit message > - added missing NULL check > > These patches make the clock check more reliable

Re: [Linuxptp-devel] [RFC PATCH 00/10] checksync: new program to wait for a local or remote clock to synchronize

2021-10-13 Thread Richard Cochran
On Wed, Oct 13, 2021 at 08:37:27PM +0300, Vladimir Oltean wrote: > Background: earlier this year I posted this message about how to wait > until phc2sys and ptp4l are synchronized within a given margin: > https://www.mail-archive.com/linuxptp-users@lists.sourceforge.net/msg02121.html > > and it

Re: [Linuxptp-devel] [PATCH] clock: Split update of leap status from clock_time_properties().

2021-10-10 Thread Richard Cochran
On Wed, Oct 06, 2021 at 10:36:28AM +0200, Miroslav Lichvar wrote: > Add a separate function for the update of the grandmaster's state after > a leap second to avoid making modifications in clock_time_properties() > and call it on each master announce tx timeout. > > Suggested-by:

Re: [Linuxptp-devel] [PATCH 2/2] Maintain one Sync sequence counter per destination address.

2021-10-12 Thread Richard Cochran
On Tue, Oct 12, 2021 at 10:47:10AM +0200, Miroslav Lichvar wrote: > There is a missing change in this function for the follow up message. > It needs to use the same sequence ID. Ah, good catch. Thanks, Richard ___ Linuxptp-devel mailing list

Re: [Linuxptp-devel] [RFC PATCH 10/10] checksync: new program to wait for a local or remote clock to synchronize

2021-10-16 Thread Richard Cochran
On Fri, Oct 15, 2021 at 10:48:28PM +, Geva, Erez wrote: > Regarding the "ugly scripting" of pmc. > > I create the http://libpmc.sf.net/ just to work around this issue. > > The libpmc provides a library with pmc tool capabilities, and wrapper for > scripting as Python, Lua and Perl. I just

[Linuxptp-devel] [PATCH 2/2] Maintain one Sync sequence counter per destination address.

2021-10-11 Thread Richard Cochran
. Signed-off-by: Richard Cochran --- port.c| 14 ++ port_private.h| 2 +- unicast_service.c | 4 +++- 3 files changed, 10 insertions(+), 10 deletions(-) diff --git a/port.c b/port.c index eed0293..248d4b0 100644 --- a/port.c +++ b/port.c @@ -1510,7 +1510,7 @@ int

[Linuxptp-devel] [PATCH 1/2] Maintain one Announce sequence counter per destination address.

2021-10-11 Thread Richard Cochran
. Signed-off-by: Richard Cochran --- port.c| 7 --- port_private.h| 2 +- unicast_service.c | 6 +- 3 files changed, 10 insertions(+), 5 deletions(-) diff --git a/port.c b/port.c index 6e6b0aa..eed0293 100644 --- a/port.c +++ b/port.c @@ -1455,7 +1455,7 @@ out

Re: [Linuxptp-devel] [PATCH] Delay Response Timeout Feature addition for PTP4L

2021-09-28 Thread Richard Cochran
On Tue, Sep 28, 2021 at 12:54:55PM +, Karthikkumar Valoor wrote: > Hi Richard, > > Thanks for the modification. With this change, we tested in our setup and we > could find that it works as intended. > Please go ahead and merge this change. Okay, applied it. Thanks, Richard

Re: [Linuxptp-devel] Porting ptp4l for custom timestamp hardware

2021-10-01 Thread Richard Cochran
On Fri, Oct 01, 2021 at 06:49:05PM +0530, Mohan K wrote: > The driver for FPGA is in user-space and it is a memory mapped device. > > Kindly throw some high-level inputs on how this porting can be achieved. Write a proper kernel device driver. Good luck, Richard

Re: [Linuxptp-devel] [PATCH 1/2] [Bug Fix]: gmPresent and gmIdentity is not updated in slaveOnly mode when GM is not reachable.

2021-10-02 Thread Richard Cochran
On Wed, Aug 18, 2021 at 03:31:12PM +, Karthikkumar V via Linuxptp-devel wrote: > This patch addresses the bug observed in ptp4l in slaveOnly mode. When the > upstream master is no longer available (not reachable), the slave moves to > LISTENING state. However, the gmIdentity is not updated in

Re: [Linuxptp-devel] IEEE 1588-2019 -- Backward compatibility

2021-10-02 Thread Richard Cochran
On Thu, Aug 19, 2021 at 07:03:36AM +, ramesh t via Linuxptp-devel wrote: > hi, > > We are planning to upgrade ptp4l to latest version (3.1.1), had few questions > > 1) From which release onwards of ptp4l IEEE 1588-2019 is supported? all published versions from v1 onward > 2) Is IEEE

Re: [Linuxptp-devel] [PATCH 3/4] clock: Clear leap flags after leap second.

2021-10-02 Thread Richard Cochran
On Wed, Sep 15, 2021 at 12:08:03PM +0200, Miroslav Lichvar wrote: > When operating as a grandmaster, clear the programmed leap second and > update the UTC offset when the first announce message after the leap > second is sent. This guarantees the update happens in +/- 2 announce > messages around

Re: [Linuxptp-devel] [PATCH 3/4] clock: Clear leap flags after leap second.

2021-10-04 Thread Richard Cochran
On Mon, Oct 04, 2021 at 09:24:31AM +0200, Miroslav Lichvar wrote: > On Sat, Oct 02, 2021 at 07:09:02AM -0700, Richard Cochran wrote: > > The function, clock_time_properties, is a query that should not change > > the program state. > > So, would you like to move it t

Re: [Linuxptp-devel] [PATCH 3/4] clock: Clear leap flags after leap second.

2021-10-05 Thread Richard Cochran
On Tue, Oct 05, 2021 at 12:27:14PM +0200, Miroslav Lichvar wrote: > On Mon, Oct 04, 2021 at 06:56:50AM -0700, Richard Cochran wrote: > > How about this? > > > > 1. Refactor the setting of clock.tds into a common helper function, as > >you suggest. > >

Re: [Linuxptp-devel] [PATCH 1/4] clock: Accept new UTC offset after leap second.

2021-09-27 Thread Richard Cochran
On Wed, Sep 15, 2021 at 12:08:01PM +0200, Miroslav Lichvar wrote: > When the master updated the UTC offset and leap flags in an announce > message after a leap second, only the new flags were accepted for > synchronization of the local clock, which caused a one-second error to > appear until a

Re: [Linuxptp-devel] [PATCH] Delay Response Timeout Feature addition for PTP4L

2021-09-27 Thread Richard Cochran
4L This code changes brings in the ability to program delay response timeout within which, if the upstream master does not send a valid delay response within the configurable delay response timeout duration, device will move out of lock state.Default delay_response_timeout is 0 (disabled). Signed-off

Re: [Linuxptp-devel] [PATCH 0/4] Leap second fix and improvements.

2021-09-27 Thread Richard Cochran
On Wed, Sep 15, 2021 at 12:08:00PM +0200, Miroslav Lichvar wrote: > I was improving the coverage of the linuxptp testsuite and noticed a bug > that needs to be fixed before the next leap second. That's the first > patch. The others are improvements to better see what is happening > around leap

Re: [Linuxptp-devel] linuxptp performance hit

2021-12-17 Thread Richard Cochran
On Fri, Dec 17, 2021 at 06:34:09PM +, Geva, Erez wrote: > Why not using a global for level, so we can skip the function call? +1 Globals are usually poor design, but this case is the exception. Thanks, Richard ___ Linuxptp-devel mailing list

Re: [Linuxptp-devel] Observing below issue with ptp4l running in BC mode

2022-01-05 Thread Richard Cochran
On Wed, Jan 05, 2022 at 07:34:07PM +, ramesh t wrote: > hi, > > Running ptp4l in BC mode, with clock_type set to BC and boundary_clock_jbod > set to 1. Have connected one NIC port to BC/GM and another NIC port to > testing unit (TU). Following is the ptp4l command. > > ./ptp4l -2 -A -w -i

Re: [Linuxptp-devel] [PATCH v4 0/9] Dynamic sync direction for ts2phc

2021-11-15 Thread Richard Cochran
On Mon, Nov 15, 2021 at 04:28:07PM +0200, Vladimir Oltean wrote: > So we'd have a PPS source, PPS sink, source clock and destination clock, > right? In the code, would "master" become simply "source" or "pps_source"? yes > > I'm not asking you to rename everything, but if you have the time and >

Re: [Linuxptp-devel] [PATCH] util: don't error out in posix_clock_open() if we can't determine PHC index

2021-11-17 Thread Richard Cochran
On Wed, Nov 17, 2021 at 08:54:40AM +, Geva, Erez wrote: > Do you mean? > https://pubs.opengroup.org/onlinepubs/009696799/functions/realpath.html > https://man7.org/linux/man-pages/man3/realpath.3p.html > https://man7.org/linux/man-pages/man3/realpath.3.html Cool. That was easy. Anyone care

Re: [Linuxptp-devel] [PATCH RFC v3 02/10] Introduce the power profile.

2021-11-10 Thread Richard Cochran
On Wed, Nov 10, 2021 at 12:59:33PM +0100, Olivier Dautricourt wrote: > I had the feeling that power profiles attributes such as > totalTimeInaccuracy should be properties of the clock. > In case of a simple BC or jbod, all the ports need to share the > same inaccuracy. If two ports have

Re: [Linuxptp-devel] [PATCH RFC v3 00/10] Profile support for IEEE C37.238-2011 and IEEE C37.238-2017

2021-11-10 Thread Richard Cochran
On Wed, Nov 10, 2021 at 12:11:19PM +, v.nosi...@prosoftsystems.ru wrote: > IEEE C37.238-2017 says that domainNumber value can be 254. Is it possible to > expand the maximum value of this parameter or somehow allow to use of this > single value? Yes. This detail from the profile is silly,

Re: [Linuxptp-devel] [PATCH RFC v3 06/10] Add the ALTERNATE_TIME_OFFSET_PROPERTIES management message.

2021-11-10 Thread Richard Cochran
On Wed, Nov 10, 2021 at 08:57:35AM +, Geva, Erez wrote: > Hi, > > According to IEEE 1588 timeOfNextJump is 48 bits. > The alternate_time_offset_properties structure reserve the full 48 bits. > The pre and the post function do full handle. > But the rest handle only the low 32 bits. > > I can

Re: [Linuxptp-devel] [PATCH] util: don't error out in posix_clock_open() if we can't determine PHC index

2021-11-13 Thread Richard Cochran
On Sat, Nov 13, 2021 at 03:31:27AM +0200, Vladimir Oltean wrote: > Otherwise said, for phc2sys it is an actual regression to require that > the path to the PTP char device be in the "/dev/ptpN" format. As discussed on lkml/netdev, there is no reason to rename the clock character devices. Indeed

Re: [Linuxptp-devel] [PATCH] util: don't error out in posix_clock_open() if we can't determine PHC index

2021-11-13 Thread Richard Cochran
On Sat, Nov 13, 2021 at 06:22:34AM -0800, Richard Cochran wrote: > Indeed phc2sys is correct in requiring that the path to the PTP char > device be in the "/dev/ptpN" format. If ever phc2sys accepted /dev/ptp_kvm or similar, that was simply a bug in phc2sys. > The Debian

Re: [Linuxptp-devel] [PATCH] util: don't error out in posix_clock_open() if we can't determine PHC index

2021-11-13 Thread Richard Cochran
On Sat, Nov 13, 2021 at 06:53:06AM -0800, Richard Cochran wrote: > On Sat, Nov 13, 2021 at 06:22:34AM -0800, Richard Cochran wrote: > > > The Debian KVM script is just plain wrong. > > Or maybe not a bug, but still the script that invokes phc2sys should > simply use `real

Re: [Linuxptp-devel] [PATCH RFC v3 06/10] Add the ALTERNATE_TIME_OFFSET_PROPERTIES management message.

2021-11-13 Thread Richard Cochran
On Wed, Nov 10, 2021 at 04:49:54PM +, Geva, Erez wrote: > I notice that 32 bits are 136 years. > > But as IEEE defined it as 48 bits. > And we try to make the ptp4l compliance with IEEE. How is this patch non-compliant? > I think, we need to support 48 bits in ptp4l and display the proper

Re: [Linuxptp-devel] [PATCH RFC v3 02/10] Introduce the power profile.

2021-11-15 Thread Richard Cochran
On Mon, Nov 15, 2021 at 10:38:53AM +0100, Olivier Dautricourt wrote: > > This series treats the values as static. There is no automatic > > update. The profile does not specify how to automatically calculate > > the values. On the contrary, it recommends a one time calibration > > "during

Re: [Linuxptp-devel] [PATCH v2 1/2] phc2sys: move read_phc into clock_adj.c

2021-11-15 Thread Richard Cochran
On Fri, Oct 22, 2021 at 03:03:58PM -0700, Jacob Keller wrote: > Notice that read_phc returned 0 on failure and 1 on success. This is > fairly non-standard, so lets update clockadj_compare to return 0 on > success and -1 on failure. Fix the call sites to check correctly and > report an error. +1

Re: [Linuxptp-devel] [PATCH v4 2/9] ts2phc: instantiate a full clock structure for every slave PHC

2021-11-15 Thread Richard Cochran
On Sat, Oct 09, 2021 at 05:11:53PM +0300, Vladimir Oltean wrote: > diff --git a/ts2phc.c b/ts2phc.c > index 67df5a532559..ca7684b314a4 100644 > --- a/ts2phc.c > +++ b/ts2phc.c > @@ -7,9 +7,14 @@ > * @note SPDX-License-Identifier: GPL-2.0+ > */ > #include > +#include > +#include >

Re: [Linuxptp-devel] [RFC PATCH 10/10] checksync: new program to wait for a local or remote clock to synchronize

2021-11-15 Thread Richard Cochran
On Fri, Oct 15, 2021 at 10:48:28PM +, Geva, Erez wrote: > Although, I am not oppose your patch. I just find it useless, as I perform > the same result in a Perl script. > And with a much higher flexibility and a better performance. Can you share the equivalent script? It would be

Re: [Linuxptp-devel] [PATCH v4 0/9] Dynamic sync direction for ts2phc

2021-11-15 Thread Richard Cochran
On Sat, Oct 09, 2021 at 05:11:51PM +0300, Vladimir Oltean wrote: > The overall board design for my use case is that there's an SoC with an > embedded DSA switch, and hanging off of 3 ports of that embedded switch > are 3 external switches. Every networking device (the DSA master for the >

Re: [Linuxptp-devel] [PATCH] util: don't error out in posix_clock_open() if we can't determine PHC index

2021-11-16 Thread Richard Cochran
On Tue, Nov 16, 2021 at 10:09:59PM +, Keller, Jacob E wrote: > Is it possible for us to resolve symlinks ourselves before attempting to > check its index value? That would be an added convenience for users. Hm, is there a unix/stdlib C API for realpath? If so, then yes. (I haven't heard of

Re: [Linuxptp-devel] [Linuxptp-users] Sudden phc offset jump

2021-11-02 Thread Richard Cochran
On Tue, Nov 02, 2021 at 03:32:04PM +, ramesh t wrote: > hi, > > Any suggestion for the below mentioned issue? Please let me know. Looks like a HW and/or driver issue. I would start by validating the HW/driver. For example, a long term test of phc_ctl eth0 get HTH, Richard

[Linuxptp-devel] [PATCH RFC v3 00/10] Profile support for IEEE C37.238-2011 and IEEE C37.238-2017

2021-11-09 Thread Richard Cochran
and feedback are much appreciated! Thanks, Richard Richard Cochran (10): tlv: Encode and decode power profile TLVs. Introduce the power profile. Add a custom management message for power profile settings. tlv: Encode and decode alternate time offset indicator TLVs. Prepare clock based

[Linuxptp-devel] [PATCH RFC v3 04/10] tlv: Encode and decode alternate time offset indicator TLVs.

2021-11-09 Thread Richard Cochran
Signed-off-by: Richard Cochran --- tlv.c | 58 ++ tlv.h | 26 ++ 2 files changed, 84 insertions(+) diff --git a/tlv.c b/tlv.c index d9d2846..03faa74 100644 --- a/tlv.c +++ b/tlv.c @@ -77,6 +77,22 @@ static uint16_t

[Linuxptp-devel] [PATCH RFC v3 07/10] Add the ALTERNATE_TIME_OFFSET_NAME management message.

2021-11-09 Thread Richard Cochran
Signed-off-by: Richard Cochran --- clock.c | 21 +++- pmc.c| 9 + pmc_common.c | 56 +++- tlv.c| 11 +++ tlv.h| 5 + 5 files changed, 100 insertions(+), 2 deletions(-) diff --git

[Linuxptp-devel] [PATCH RFC v3 03/10] Add a custom management message for power profile settings.

2021-11-09 Thread Richard Cochran
Signed-off-by: Richard Cochran --- pmc.c| 15 +++ pmc_common.c | 39 ++- port.c | 20 +++- tlv.c| 20 tlv.h| 1 + 5 files changed, 93 insertions(+), 2 deletions(-) diff --git

[Linuxptp-devel] [PATCH RFC v3 05/10] Prepare clock based storage of up to four time zones.

2021-11-09 Thread Richard Cochran
Signed-off-by: Richard Cochran --- clock.c | 22 +- tz.h| 26 ++ 2 files changed, 43 insertions(+), 5 deletions(-) create mode 100644 tz.h diff --git a/clock.c b/clock.c index bbfd1a8..b5b729a 100644 --- a/clock.c +++ b/clock.c @@ -42,6 +42,7

[Linuxptp-devel] [PATCH RFC v3 08/10] Implement the ALTERNATE_TIME_OFFSET_ENABLE management message.

2021-11-09 Thread Richard Cochran
If the local PTP management client enables a time zone, append the matching TLV to outgoing Announce messages. Signed-off-by: Richard Cochran --- clock.c | 77 ++-- clock.h | 8 ++ pmc.c| 8 ++ pmc_common.c | 17

[Linuxptp-devel] [PATCH RFC v3 02/10] Introduce the power profile.

2021-11-09 Thread Richard Cochran
Signed-off-by: Richard Cochran --- config.c| 15 +- port.c | 53 + port_private.h | 3 +++ power_profile.h | 31 + tlv.h | 8 5 files changed, 109 insertions(+), 1

[Linuxptp-devel] [PATCH RFC v3 01/10] tlv: Encode and decode power profile TLVs.

2021-11-09 Thread Richard Cochran
Signed-off-by: Richard Cochran --- tlv.c | 36 tlv.h | 24 2 files changed, 60 insertions(+) diff --git a/tlv.c b/tlv.c index cc8d507..aadfe0a 100644 --- a/tlv.c +++ b/tlv.c @@ -35,6 +35,7 @@ (tlv->length < sizeof(struc

[Linuxptp-devel] [PATCH RFC v3 09/10] pmc: Convert internal helper function into global method.

2021-11-09 Thread Richard Cochran
The function to set the alternate time offset name, a.k.a. time zone, will be used by the time zone stand alone program. Make the function into a public PMC method. Signed-off-by: Richard Cochran --- pmc_common.c | 5 ++--- pmc_common.h | 2 ++ 2 files changed, 4 insertions(+), 3 deletions

[Linuxptp-devel] [PATCH RFC v3 06/10] Add the ALTERNATE_TIME_OFFSET_PROPERTIES management message.

2021-11-09 Thread Richard Cochran
Signed-off-by: Richard Cochran --- clock.c | 66 pmc.c| 13 +++ pmc_common.c | 24 ++- tlv.c| 21 + util.h | 7 ++ 5 files changed, 126 insertions(+), 5 deletions(-) diff

[Linuxptp-devel] [PATCH RFC v3 10/10] Introduce a time zone helper program.

2021-11-09 Thread Richard Cochran
The ptp4l program supports up to four time zones via the ALTERNATE_TIME_OFFSET_INDICATOR TLV. Introduce a helper program that leverages the local time zone database to monitor for changes in daylight savings time and publishing them. Signed-off-by: Richard Cochran --- makefile | 7

Re: [Linuxptp-devel] [PATCH] Signed-off-by: Vladimir Nosikov

2021-11-09 Thread Richard Cochran
On Thu, Nov 04, 2021 at 09:49:14AM +0100, Olivier Dautricourt wrote: > Hello all. > > I just stumbled upon this patch. > > In fact we were working at my company to implement > support for C37.238 power system and 61850-9-3 power utility in > linuxptp. I also implemented the Power Profiles, and

Re: [Linuxptp-devel] [PATCH 2/2] Maintain one Sync sequence counter per destination address.

2021-11-03 Thread Richard Cochran
This is V2, which fixes the incorrect FollowUp sequence number as pointed out by Miroslav. Thanks, Richard ___ Linuxptp-devel mailing list Linuxptp-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxptp-devel

[Linuxptp-devel] [PATCH 1/2] Maintain one Announce sequence counter per destination address.

2021-11-03 Thread Richard Cochran
. Signed-off-by: Richard Cochran --- port.c| 7 --- port_private.h| 2 +- unicast_service.c | 6 +- 3 files changed, 10 insertions(+), 5 deletions(-) diff --git a/port.c b/port.c index 6e6b0aa..eed0293 100644 --- a/port.c +++ b/port.c @@ -1455,7 +1455,7 @@ out

[Linuxptp-devel] [PATCH 2/2] Maintain one Sync sequence counter per destination address.

2021-11-03 Thread Richard Cochran
. Signed-off-by: Richard Cochran --- port.c| 16 +++- port_private.h| 2 +- unicast_service.c | 4 +++- 3 files changed, 11 insertions(+), 11 deletions(-) diff --git a/port.c b/port.c index eed0293..7e51e77 100644 --- a/port.c +++ b/port.c @@ -1510,7 +1510,7 @@ int

Re: [Linuxptp-devel] [PATCH] Set grandmasterIdentity to localClockIdentity

2021-11-08 Thread Richard Cochran
On Mon, Nov 08, 2021 at 09:44:27AM +, Joanna Yurdal wrote: > Without the proposed patch the result of pmc "get time_status" when lost > synchronization with external GM shows: > pmc -u -b 0 'get time_status' : > c86314.fffe.30006e-0 seq 0 RESPONSE MANAGEMENT TIME_STATUS_NP >

Re: [Linuxptp-devel] Need suggestion on step_threshold

2021-11-08 Thread Richard Cochran
On Mon, Nov 08, 2021 at 12:34:08PM +0100, Luigi 'Comio' Mantellini wrote: > (my message was rejected... why?) Looks like both messages were in fact published on the list. Sorry about SF, but I have very little control over the mailing list. I plan to move the project off of SF as soon as I can.

Re: [Linuxptp-devel] [RFC PATCH 00/10] checksync: new program to wait for a local or remote clock to synchronize

2021-11-01 Thread Richard Cochran
On Mon, Nov 01, 2021 at 11:19:15AM +0200, Vladimir Oltean wrote: > For what it's worth, I have solved both my problems (checking ptp4l sync > and phc2sys sync) through alternative methods, How did you do it? Thanks, Richard ___ Linuxptp-devel

Re: [Linuxptp-devel] [PATCH 4/4] ts2phc: Add serial baudrate option

2021-07-18 Thread Richard Cochran
On Sun, Jul 18, 2021 at 07:09:54PM -0700, Richard Cochran wrote: > Otherwise, the patch is fine. I'll fix the order myself. Also, I set a minimum of 300. Thanks, Richard ___ Linuxptp-devel mailing list Linuxptp-devel@lists.sourceforge.net ht

Re: [Linuxptp-devel] [PATCH 2/4] ts2phc: Close socket on peer shutdown

2021-07-18 Thread Richard Cochran
On Fri, May 14, 2021 at 01:33:42PM +0200, Lars Munch wrote: > Read returns 0 (the traditional "end-of-file" return) when a remote > peer performs an orderly shutdown. Hence, ts2phc needs to close the > socket and try to establish a new connection. > > Signed-off-by: Lars Munch Applied. Thanks,

Re: [Linuxptp-devel] [PATCH 1/4] ts2phc: Fix uninitialized variable in nmea_scan_rmc

2021-07-18 Thread Richard Cochran
On Fri, May 14, 2021 at 01:33:41PM +0200, Lars Munch wrote: > tm_isdst needs to be initialized to make sure mktime does not fail > on recent versions of glibc > > See: > https://bugzilla.redhat.com/show_bug.cgi?id=1653340 > https://sourceware.org/bugzilla/show_bug.cgi?id=24630 > > Signed-off-by:

Re: [Linuxptp-devel] [PATCH 3/4] ts2phc: Update leapfile documentation

2021-07-18 Thread Richard Cochran
On Fri, May 14, 2021 at 01:33:43PM +0200, Lars Munch wrote: > Update leapfile documentation to note the file will be > reloaded if modified. > > Signed-off-by: Lars Munch Applied. Thanks, Richard ___ Linuxptp-devel mailing list

Re: [Linuxptp-devel] [PATCH 4/4] ts2phc: Add serial baudrate option

2021-07-18 Thread Richard Cochran
On Fri, May 14, 2021 at 10:16:02AM -0700, Hal Murray wrote: > > > I did think of that, yet of the many serial devices I have used they have > > all > > been running with the setting 8/N/1 and no HW flow control. > > The HP Z3801A is 19200 baud, 7 data bits, odd parity Looks like it is

Re: [Linuxptp-devel] [PATCH v2] Increase the default tx_timestamp_timeout to 10

2021-07-18 Thread Richard Cochran
On Thu, Jul 08, 2021 at 12:59:30PM -0700, Jacob Keller wrote: > The tx_timestamp_timeout configuration defines the number of > milliseconds to wait for a Tx timestamp from the kernel stack. This > delay is necessary as Tx timestamps are captured after a packet is sent > and reported back via the

Re: [Linuxptp-devel] [PATCHv2 RFC 0/6] Support for dropping root privileges

2021-07-18 Thread Richard Cochran
On Tue, Jul 13, 2021 at 05:08:36PM +0200, Miroslav Lichvar wrote: > In the v1 discussion there was a suggestion to not use libcap. I have > not looked into that yet, but I can try it if this whole thing makes > sense otherwise. IIRC, after V1, I looked at avoiding libcap, but I came to the

Re: [Linuxptp-devel] [PATCH 4/4] ts2phc: Add serial baudrate option

2021-07-18 Thread Richard Cochran
On Fri, May 14, 2021 at 01:33:44PM +0200, Lars Munch wrote: > Add serial baudrate configuration option. Default to 9600 bps. > > Signed-off-by: Lars Munch > --- > config.c | 1 + > ts2phc.8 | 23 --- > ts2phc_nmea_master.c | 10 +- > 3 files

Re: [Linuxptp-devel] [PATCH] lstab: update expiration to 28 December 2021

2021-07-18 Thread Richard Cochran
On Tue, Jun 29, 2021 at 11:47:21AM +0800, Yangbo Lu wrote: > Bring the built in leap second table up to date through IERS Bulletin C59. The bulletin is C62, not C59. See: https://datacenter.iers.org/data/html/bulletinc-062.html Thanks, Richard

Re: [Linuxptp-devel] FW: [PATCH] Always send with a unique sequence count from uds. Only forward responses to UDS port with corresponding requests on the UDS port.

2021-07-18 Thread Richard Cochran
On Sat, Jul 03, 2021 at 03:59:24AM +, Eric Decker wrote: > Subject: [PATCH] Always send with a unique sequence count from uds. Only > forward responses to UDS port with corresponding requests on the UDS port. Please format the commit with: 1. A brief, one sentence subject line. 2. A commit

Re: [Linuxptp-devel] [PATCH 4/4] ts2phc: Add serial baudrate option

2021-07-19 Thread Richard Cochran
On Mon, Jul 19, 2021 at 11:00:40AM +, Geva, Erez wrote: > This looks like a call to send the a patch with these options. > > Richard, How do you think these options should be implemented? > A single enumerator, separate integer for each? Whichever is easier. Maybe a single code like 8n1

Re: [Linuxptp-devel] [PATCH] Increase the default tx_timestamp_timeout to 5

2021-07-14 Thread Richard Cochran
On Wed, Jul 14, 2021 at 11:20:23AM +, Keller, Jacob E wrote: > What about at least checking for the case where a timestamp was never > started? Drivers are supposed to set a flag in the SKB when they start a > timestamp (and not set it if they can't start it). How could that happen? Putting

Re: [Linuxptp-devel] [PATCH] Increase the default tx_timestamp_timeout to 5

2021-07-14 Thread Richard Cochran
On Wed, Jul 14, 2021 at 11:20:00AM +, Keller, Jacob E wrote: > I think for Tx the challenges are higher: the timestamp is taken > after we've filled in the descriptor and sent the frame. The only > place it could reasonably be stored again is the descriptor > writeback (since we don't get

Re: [Linuxptp-devel] Observing below issue with ptp4l running in BC mode

2022-01-05 Thread Richard Cochran
On Wed, Jan 05, 2022 at 07:34:07PM +, ramesh t wrote: > On resetting of the testing unit, observing ptp port state of the > interface connected to BC/GM going to PS_FAULTY temporarily though > it shouldn't be impacted due to reset of testing unit. Why does BC/GM port go to PS_FAULTY? Link

Re: [Linuxptp-devel] Observing below issue with ptp4l running in BC mode

2022-01-07 Thread Richard Cochran
On Fri, Jan 07, 2022 at 07:32:39AM +, ramesh t wrote: > ptp4l: [325744.430] clockcheck: clock jumped forward or running faster than > expected! > ptp4l: [325744.430] port 1: SLAVE to UNCALIBRATED on SYNCHRONIZATION_FAULT See this? ^ > Please suggest. I

Re: [Linuxptp-devel] [PATCHv3 2/2] ptp4l: get bond phc directly if kernel support the new hwtstamp flag

2022-01-13 Thread Richard Cochran
On Thu, Jan 13, 2022 at 01:54:51PM +0800, Hangbin Liu wrote: > diff --git a/sk.c b/sk.c > index 8be0708..f832d99 100644 > --- a/sk.c > +++ b/sk.c > @@ -66,6 +66,13 @@ static int hwts_init(int fd, const char *device, int > rx_filter, > > init_ifreq(, , device); > > +#ifdef

Re: [Linuxptp-devel] [PATCHv4 1/2] ptp4l: init iface->ts_label when interface created

2022-01-13 Thread Richard Cochran
On Fri, Jan 14, 2022 at 10:18:48AM +0800, Hangbin Liu wrote: > Then the function interface_ensure_tslabel() could be removed safely. Could you please explain: 1. context for this issue 2. what is the issue/bug 3. how the patch fixes bug Thanks, Richard

Re: [Linuxptp-devel] [PATCHv2 2/2] ptp4l: get bond phc directly if kernel support the new hwtstamp flag

2022-01-12 Thread Richard Cochran
On Wed, Jan 12, 2022 at 12:08:00PM +0100, Miroslav Lichvar wrote: > If the only reason for these ifdefs is an optimization for older > kernels, I think it's ok to remove them as this runs only once on > start. I'd prefer code that is easier to read, even if it does > something unnecessary. +1 >

Re: [Linuxptp-devel] ptp4l issues shall be fixed

2022-01-10 Thread Richard Cochran
On Mon, Jan 10, 2022 at 01:47:45PM +0100, Miroslav Lichvar wrote: > This was proposed several times before. You can search the archives > and see if you have a new argument that could be made. +1 I won't accept patches with custom hardware hacks. You have two choices: 1. Teach your hardware

Re: [Linuxptp-devel] Observing below issue with ptp4l running in BC mode

2022-01-17 Thread Richard Cochran
On Mon, Jan 17, 2022 at 08:25:06AM +, ramesh t wrote: > Please suggest. 1. Make sure your ptp4l has these five patches: a082bcd clockcheck: Increase minimum interval. 6df8425 port: Don't renew raw transport. e117e37 port: Don't check timestamps from non-slave ports. 262a49b

Re: [Linuxptp-devel] [PATCH] Add E2E automotive profile example configs.

2022-03-07 Thread Richard Cochran
On Mon, Mar 07, 2022 at 03:17:23PM +0100, Martin Pecka wrote: > I think automotive profile is defined here: > https://avnu.org/wp-content/uploads/2014/05/Auto-Ethernet-AVB-Func-Interop-Spec_v1.6.pdf > . The document doesn't say anything about transport layer or delay > mechanism. So I just took

Re: [Linuxptp-devel] [PATCH] Add E2E automotive profile example configs.

2022-03-07 Thread Richard Cochran
On Mon, Mar 07, 2022 at 01:39:31PM +0100, Martin Pecka wrote: > This allows running an automotive-like network without a time-aware bridge. > All clients will sync directly with the master e.g. via a simple switch with > Transparent Clock. I didn't know about this profile... can you share a

Re: [Linuxptp-devel] [PATCH] Add E2E automotive profile example configs.

2022-03-07 Thread Richard Cochran
On Mon, Mar 07, 2022 at 03:57:54PM +0100, Martin Pecka wrote: > Ah, okay. By "published" you mean by an industrial standard? I just mean any kind of published standard or profile, like from the IEEE, ITU, AVnu, etc. I'm not saying that your config isn't useful, but I just want to limit the scope

Re: [Linuxptp-devel] [PATCH v5 00/13] Dynamic sync direction for ts2phc

2022-03-07 Thread Richard Cochran
On Mon, Mar 07, 2022 at 11:27:02PM +0200, Vladimir Oltean wrote: > Would you mind taking another look at these patches? I'll do it, but I put it last on my list, because this is more complex than the other open stuff. I usually order the work from easy to hard. Thanks, Richard

Re: [Linuxptp-devel] [PATCH] Add E2E automotive profile example configs.

2022-03-07 Thread Richard Cochran
On Mon, Mar 07, 2022 at 05:14:52PM -0800, Hal Murray wrote: > > richardcoch...@gmail.com said: > > I just mean any kind of published standard or profile, like from the IEEE, > > ITU, AVnu, etc. > > > I'm not saying that your config isn't useful, but I just want to limit the > > scope of the

Re: [Linuxptp-devel] [PATCHv3 0/8] Support for virtual clocks

2022-03-08 Thread Richard Cochran
On Tue, Mar 08, 2022 at 11:46:57AM +0100, Miroslav Lichvar wrote: > v3: > - rebased on current HEAD > - added required ethtool netlink declarations to missing.h to build with > old kernel headers > - fixed return value when netlink socket cannot be opened > - fixed vclock setting to use the

Re: [Linuxptp-devel] [PATCH] Add non-portable management option to query the servo state (via SERVO_STATE_NP).

2022-03-16 Thread Richard Cochran
On Wed, Mar 16, 2022 at 02:02:08PM +, Modrzejewski, Pawel via Linuxptp-devel wrote: > > The servo state is an internal variable has no relevance to outside > > observers. > > Apparently, me and Dale Smith are not the only ones interested in PTP servo > > state. See > >

Re: [Linuxptp-devel] [PATCH] Add non-portable management option to query the servo state (via SERVO_STATE_NP).

2022-03-16 Thread Richard Cochran
On Wed, Mar 16, 2022 at 01:41:13PM +0100, Martin Pecka wrote: > > > The servo state is an internal variable has no relevance to outside > > observers. > Apparently, me and Dale Smith are not the only ones interested in PTP servo > state. See >

Re: [Linuxptp-devel] [PATCH] Add non-portable management option to query the servo state (via SERVO_STATE_NP).

2022-03-16 Thread Richard Cochran
On Wed, Mar 16, 2022 at 04:18:22PM +0100, Martin Pecka wrote: > > > The s3 doesn't mean "the clock of the current device is successfully > > synchronized" > > > > It only means that it converged during the first twenty seconds. > > After that, the state doesn't tell you anything. The actual

Re: [Linuxptp-devel] [PATCH] Add non-portable management option to query the servo state (via SERVO_STATE_NP).

2022-03-16 Thread Richard Cochran
On Wed, Mar 16, 2022 at 11:55:27PM +0100, Martin Pecka wrote: > Well, that is actually what people expect from a time sync daemon. Chrony > has it (* or + in `chronyc sources`), systemd has it ("System clock > synchronized: yes" in timedatectl) etc. Wait, wait, ... did you say systemd? zm,

Re: [Linuxptp-devel] [PATCH] Add non-portable management option to query the servo state (via SERVO_STATE_NP).

2022-03-16 Thread Richard Cochran
On Thu, Mar 17, 2022 at 12:18:35AM +0100, Martin Pecka wrote: > > > > Well, that is actually what people expect from a time sync daemon. Chrony > > > has it (* or + in `chronyc sources`), systemd has it ("System clock > > > synchronized: yes" in timedatectl) etc. > > Wait, wait, ... did you say

Re: [Linuxptp-devel] [PATCH] Add non-portable management option to query the servo state (via SERVO_STATE_NP).

2022-03-08 Thread Richard Cochran
On Tue, Mar 08, 2022 at 04:17:29PM +0100, Martin Pecka wrote: > I've implemented this management option to ease monitoring whether the time > sync is stable or not. Doing it via log parsing doesn't really seem > practical for me. The servo state is an internal variable has no relevance to outside

Re: [Linuxptp-devel] [PATCH] Add non-portable management option to query the servo state (via SERVO_STATE_NP).

2022-03-08 Thread Richard Cochran
On Tue, Mar 08, 2022 at 04:17:29PM +0100, Martin Pecka wrote: > Or is there another way (except watching the master offset via pmc and > trying to re-do the same algorithm that manages the servo state inside > ptp4l?). Use the NSM for more accurate monitoring: NAME nsm - NetSync Monitor

Re: [Linuxptp-devel] [PATCH] Add non-portable management option to query the servo state (via SERVO_STATE_NP).

2022-03-17 Thread Richard Cochran
On Thu, Mar 17, 2022 at 10:16:03AM +, Geva, Erez wrote: > There is no generic sync. > > So each user need to define a 'sync' that match to its system needs. A user-defined sync service could be based off of your pmc lib. Maybe that would be the place to have one or two examples? Thanks,

Re: [Linuxptp-devel] [PATCH v2] Add UNICAST_MASTER_TABLE_NP management TLV

2022-03-06 Thread Richard Cochran
On Fri, Feb 18, 2022 at 10:13:06AM -0800, Alexander Bulimov via Linuxptp-devel wrote: > This change adds new UNICAST_MASTER_TABLE_NP management TLV that > exposes table with details of each gm: identity, IP address, > state, if it's selected as best master, and information from > the latest

Re: [Linuxptp-devel] [PATCH v3 0/2] fix fallback clock_gettime for test_phc

2022-03-06 Thread Richard Cochran
On Tue, Nov 23, 2021 at 02:43:25PM -0800, Jacob Keller wrote: > The current implementation of test_phc cmp has a fallback flow for comparing > the PHC clock to the CLOCK_REAMTIME. This fallback flow calculates the > inverse offset compared to the offsets calculated by the PTP_SYS_OFFSET > ioctls.

Re: [Linuxptp-devel] [PATCHv2 0/8] Support for virtual clocks

2022-03-06 Thread Richard Cochran
On Tue, Feb 15, 2022 at 04:04:43PM +0100, Miroslav Lichvar wrote: > v2->v1: > - rebased on current HEAD > - fixed order of phc_index option in config_tab array > - renamed search_vclocks() to rtnl_search_vclocks() > > rfc->v1: > - fixed rtnl_linkinfo_parse() to make space for the _MAX attrs > -

Re: [Linuxptp-devel] [PATCH] port: Cancel unicast service when closing port.

2022-03-12 Thread Richard Cochran
On Sat, Mar 12, 2022 at 06:07:11PM -0500, vincent.cheng...@renesas.com wrote: > However, because there is no checking of received unicast master to configured > unicast table, ptp4l is quite content with packets from previous master > 10.64.10.13. This patch doesn't actually fix the root cause.

Re: [Linuxptp-devel] fault_reset_interval ASAP seems to ignore link down

2022-02-16 Thread Richard Cochran
On Fri, Sep 24, 2021 at 11:23:10PM +, Keller, Jacob E wrote: > If a port goes down because of loss of link, ptp4l tries to avoid > clearing the fault. However, if you set fault_reset_interval to ASAP, > then ptp4l immediately clears the fault and tries to send and eventually > gets a timeout.

<    12   13   14   15   16   17   18   19   20   21   >