[Linuxptp-devel] [PATCH] The daemon should not downgrade the RX filter. An AVB/TSN application may use it. Follow Cliff Spradlin recommendation and add a configuration option.

2018-06-12 Thread Geva, Erez
Signed-off-by: Erez Geva --- config.c| 9 + ptp4l.8 | 8 raw.c | 6 -- sk.c| 38 -- sk.h| 14 +- transport.c | 11 ++- transport_private.h

[Linuxptp-devel] [PATCH] config: Add hardware time stamp filter setting mode

2018-06-14 Thread Geva, Erez
>From 532e29347d80695db45e5b59e979a954d0e7238b Mon Sep 17 00:00:00 2001 From: Erez Geva Date: Thu, 14 Jun 2018 11:27:45 +0200 Subject: [PATCH] config: Add hardware time stamp filter setting mode Add global option for the hardware time stamp setting. The function could: Normally set the filters

[Linuxptp-devel] [PATCH] The daemon should not downgrade the RX filter. An AVB/TSN application may use it.

2018-06-11 Thread Geva, Erez
Signed-off-by: Erez Geva --- sk.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/sk.c b/sk.c index f18b2bf..de8bf58 100644 --- a/sk.c +++ b/sk.c @@ -55,8 +55,17 @@ static int hwts_init(int fd, const char *device, int rx_filter, int tx_type)

Re: [Linuxptp-devel] [PATCH] config: Add hardware time stamp filter setting mode

2018-06-20 Thread Geva, Erez
Hi, My tabs are been replaced by spaces, do you understand why? Can I send the patch as attachment file? Erez From: Erez [erezge...@gmail.com] Sent: 20 June 2018 15:27 To: linuxptp-devel@lists.sourceforge.net Subject: [Linuxptp-devel] [PATCH] config: Add

Re: [Linuxptp-devel] [PATCH] config: Add hardware time stamp filter setting mode

2018-06-19 Thread Geva, Erez
I'm sorry. It is the Micro$oft Outlock which replace the tabs with spaces. Micro$oft, where do you want to get lost today? I will try later after setting my send mail and send it directly from git. Yours Erez From: [ext] Geva, Erez [erez.geva

[Linuxptp-devel] [PATCH] config: Add hardware time stamp filter setting mode

2018-06-19 Thread Geva, Erez
>From 532e29347d80695db45e5b59e979a954d0e7238b Mon Sep 17 00:00:00 2001 From: Erez Geva Date: Thu, 14 Jun 2018 11:27:45 +0200 Subject: [PATCH] config: Add hardware time stamp filter setting mode Add global option for the hardware time stamp setting. The function could: Normally set the filters

Re: [Linuxptp-devel] [PATCH] config: Add hardware time stamp filter setting mode

2018-08-03 Thread Geva, Erez
Thanks for your input. The code generate error rightfully, the message is misleading. I will correct the code in sk.c to generate a more accurate error messaging. I did saw that the daemon keeps running, is that the correct behaviour for sk_timestamping_init() returning error (err = -1)? I

Re: [Linuxptp-devel] [PATCH v2 0/5] Possibility to use ports in different namespaces

2018-11-13 Thread Geva, Erez
Good explanation. Sound good to me. Erez From: Anders Selhammer [anders.selham...@est.tech] Sent: 13 November 2018 11:34 To: linuxptp-devel@lists.sourceforge.net Subject: [Linuxptp-devel] [PATCH v2 0/5] Possibility to use ports in different namespaces

Re: [Linuxptp-devel] [PATCH 2/6] config: Added network_namespace as config parameter

2018-11-09 Thread Geva, Erez
What about "ip netns exec"? From: Anders Selhammer [anders.selham...@est.tech] Sent: 09 November 2018 10:25 To: linuxptp-devel@lists.sourceforge.net Subject: [Linuxptp-devel] [PATCH 2/6] config: Added network_namespace as config parameter Signed-off-by:

Re: [Linuxptp-devel] [PATCH 2/6] config: Added network_namespace as config parameter

2018-11-09 Thread Geva, Erez
From: Anders Selhammer [anders.selham...@est.tech] Sent: 09 November 2018 14:44 To: Geva, Erez (ext) (PD PA CI R 3) Cc: linuxptp-devel@lists.sourceforge.net Subject: SV: [PATCH 2/6] config: Added network_namespace as config parameter Friday, 9 November, 2018 11:36 AM > What about "

Re: [Linuxptp-devel] linuxptp2.02 processing the extra 4 bytes which is not in PTP length

2019-01-10 Thread Geva, Erez
Hi, It happens with one message "Delay Response" in the length 104 bytes. Did you check your VLAN, may be the VLAN add the 4 bytes? Did you see this behavior without using VLAN? What is your ptp4l configuration? Erez From: Sun, Steven (NSB - CN/Qingdao)

Re: [Linuxptp-devel] ptp4l wrongly takes padding bytes as TLV?

2019-01-31 Thread Geva, Erez
As you feel, I don't care on the Ethernet frame. Nor do I think we should try to fix it or criticize it. If the packet pass the Linux kernel and received by the PTP daemon, we should not care. For me, the only question is, if the Ethernet frame does have padding and the PTP frame is proper. Is

Re: [Linuxptp-devel] ptp4l wrongly takes padding bytes as TLV?

2019-01-31 Thread Geva, Erez
. But, I do respect other opinions. -:) Erez From: Vincent Li X [vincent.x...@ericsson.com] Sent: 31 January 2019 18:14 To: Geva, Erez (ext) (PD PA CI R 3); Jiri Benc Cc: linuxptp-devel@lists.sourceforge.net Subject: RE: [Linuxptp-devel] ptp4l wrongly takes

Re: [Linuxptp-devel] [PATCH v4] sk: Recognize HWTSTAMP_FILTER_SOME

2019-06-12 Thread Geva, Erez
Great patch Good work :-) From: Petr Machata [pe...@mellanox.com] Sent: 11 June 2019 18:35 To: linuxptp-devel@lists.sourceforge.net Cc: Petr Machata; Keller, Jacob E; Geva, Erez (ext) (DI PA CI R 3) Subject: [PATCH v4] sk: Recognize HWTSTAMP_FILTER_SOME

Re: [Linuxptp-devel] [PATCH v2] sk: Recognize HWTSTAMP_FILTER_SOME

2019-06-11 Thread Geva, Erez
Hi, The "cfg.rx_filter != HWTSTAMP_FILTER_ALL)) { " line catch both filter mode is "HWTS_FILTER_FULL, and the fact that the filter could is in a higher state for both HWTS_FILTER_NORMAL, HWTS_FILTER_CHECK. Could you be more specific what does the HWTSTAMP_FILTER_SOME means? For me, the

Re: [Linuxptp-devel] [PATCH v3] sk: Recognize HWTSTAMP_FILTER_SOME

2019-06-11 Thread Geva, Erez
Hi, It make sense for HWTS_FILTER_NORMAL. But for HWTSTAMP_FILTER_ALL, it does not make sense to get HWTSTAMP_FILTER_SOME. Some of what? You ask for all! Neither can you use rx_filter in this case, since it was not used in the SIOCSHWTSTAMP request. Erez

Re: [Linuxptp-devel] [PATCH v2] sk: Recognize HWTSTAMP_FILTER_SOME

2019-06-11 Thread Geva, Erez
ing packet */ HWTSTAMP_FILTER_ALL, As of HWTS_FILTER_NORMAL case, your patch make sense. Thanks Erez From: Petr Machata [pe...@mellanox.com] Sent: 11 June 2019 16:22 To: Geva, Erez (ext) (DI PA CI R 3) Cc: linuxptp-devel@lists.sourceforge.net S

Re: [Linuxptp-devel] LinuxPTP latest revision compatibility

2019-04-26 Thread Geva, Erez
Hi, I have update the Debian package build files. If you wish to build it yourself, I can send you the files. Erez From: Richard Cochran [richardcoch...@gmail.com] Sent: 23 April 2019 15:56 To: Prasanth KV Cc: linuxptp-devel@lists.sourceforge.net

Re: [Linuxptp-devel] Adding libpmc

2020-04-16 Thread Geva, Erez
> > While the Kernel is under GPL 2. > > The headers and system call are under exception, so user can use the > > Kernel with non GPL code. But any changes or addition to the kernel > > itself should be GPL 2. > > This is very different. The Linux kernel is supposed to run any kind of > programs

Re: [Linuxptp-devel] Adding libpmc

2020-04-16 Thread Geva, Erez
that any code that is part of the LinuxPTP must be coverd by GPL. But user may embedded a library in their non GPL application and communicate with the ptp4l. Do you have another suggestion? Erez -Original Message- From: Richard Cochran Sent: Thursday, 16 April 2020 17:09 To: Geva, Erez

Re: [Linuxptp-devel] Adding libpmc

2020-04-16 Thread Geva, Erez
Hi, I see that linux PTP is under GPL 2. I would like to ask your permission to allow using a libpmc library and headers needed by it under LGPL 2. As you are the copywrite holders, we need your explicit consent. Thanks Erez Geva From: Geva, Erez (ext) (DI PA CI R 3) Sent: Thursday

[Linuxptp-devel] Adding libpmc

2020-04-09 Thread Geva, Erez
Hi, As I thought that libpmc could be nice for several application that need to communicate with the ptp4l. I decided to make a short test. First I patch the makefile to create the libpmc.so diff --git a/makefile b/makefile index a23945a..f5e12da 100644 --- a/makefile +++ b/makefile

Re: [Linuxptp-devel] [RFC PATCH v2 2/3] pwm: Add helper apis to control pwm

2020-05-19 Thread Geva, Erez
>From a quick look. It seems that it is 'pwmchip%d' for a long time. https://elixir.bootlin.com/linux/v4.0/source/drivers/pwm/sysfs.c#L314 Erez -Original Message- From: Richard Cochran Sent: Saturday, 16 May 2020 21:15 To: Lokesh Vutla Cc: Sekhar Nori ;

Re: [Linuxptp-devel] [PATCH RFC 0/1] Introduce inclusive terminology

2020-08-19 Thread Geva, Erez
Hi, Personally I prefer leader/followers over source/sink. Source remind me of source code. And sink remind me of where our water goes after we use them. Client/server is good as well. Erez From: Jagmeet Singh Hanspal Sent: Wednesday, 19 August 2020 06:00 To: Richard Cochran Cc:

Re: [Linuxptp-devel] [PATCH RFC 0/1] Introduce inclusive terminology

2020-08-19 Thread Geva, Erez
the leader. Erez -Original Message- From: Richard Cochran Sent: Wednesday, 19 August 2020 17:20 To: Geva, Erez (ext) (DI PA CI R 3) Cc: jagmeet.hans...@gmail.com; linuxptp-devel@lists.sourceforge.net Subject: Re: [Linuxptp-devel] [PATCH RFC 0/1] Introduce inclusive terminology On Wed

Re: [Linuxptp-devel] [PATCH RFC 0/1] Introduce inclusive terminology

2020-08-19 Thread Geva, Erez
P.S. The sink goes in one direction. -Original Message- From: Geva, Erez (ext) (DI PA CI R 3) Sent: Wednesday, 19 August 2020 18:14 To: richardcoch...@gmail.com Cc: jagmeet.hans...@gmail.com; linuxptp-devel@lists.sourceforge.net Subject: RE: [Linuxptp-devel] [PATCH RFC 0/1] Introduce

Re: [Linuxptp-devel] [PATCH V1 2/2] Add support for write phase mode.

2020-05-26 Thread Geva, Erez
Hi, For TSN, we need jitter of ~ 100 nanoseconds, And most interface can issue a jitter of ~10 nanoseconds. So for now TSN does not need fractions of nanosecond. Further more, I do not think there is any Ethernet based traffic that can benefit from such accuracy. As for 1 Gigabits, each bit is

Re: [Linuxptp-devel] [RFC PATCH 01/15] posix_clock_open: derive PHC index from device name if possible

2020-08-13 Thread Geva, Erez
On 12/08/2020 23:40, Keller, Jacob E wrote: >> -Original Message- >> From: Richard Cochran >> Sent: Wednesday, August 12, 2020 8:40 AM >> To: Keller, Jacob E >> Cc: linuxptp-devel@lists.sourceforge.net >> Subject: Re: [Linuxptp-devel] [RFC PATCH 01/15] posix_clock_open: derive PHC >>

[Linuxptp-devel] Intel 210 to Intel 255

2021-06-07 Thread Geva, Erez
Hi, I see an issue with the ptp4l using an Intel I210 connected back to back to an Intel i255. I am not sure if the issue is Intel related or is it ptp4l. Probably something wrong that I did. I use a very simple configuration: On client side: [global] delay_mechanism P2P network_transport L2

Re: [Linuxptp-devel] [PATCH 2/4] ts2phc: Close socket on peer shutdown

2021-05-14 Thread Geva, Erez
Yes. -Original Message- From: Lars Munch Sent: Friday, 14 May 2021 18:20 To: Geva, Erez (ext) (DI PA DCP R 3) Cc: linuxptp-devel@lists.sourceforge.net Subject: Re: [Linuxptp-devel] [PATCH 2/4] ts2phc: Close socket on peer shutdown On Fri, May 14, 2021 at 4:24 PM Geva, Erez wrote

Re: [Linuxptp-devel] [PATCH 2/4] ts2phc: Close socket on peer shutdown

2021-05-14 Thread Geva, Erez
Make sense to handle 0, end of file. But as it is NOT an error, perhaps it should use a proper pr_info(). Erez -Original Message- From: Lars Munch Sent: Friday, 14 May 2021 13:34 To: linuxptp-devel@lists.sourceforge.net Subject: [Linuxptp-devel] [PATCH 2/4] ts2phc: Close socket on peer

Re: [Linuxptp-devel] [PATCH 4/4] ts2phc: Add serial baudrate option

2021-05-14 Thread Geva, Erez
A great idea to add baud-rate. Just a suggestion, As I remember from gtkterm application. It provide setting: port name, Baud rate, parity, bits, stop bit, and flow control. What do you think of adding all of the setting? Erez -Original Message- From: Lars Munch Sent: Friday, 14

Re: [Linuxptp-devel] [PATCH 1/4] ts2phc: Fix uninitialized variable in nmea_scan_rmc

2021-05-14 Thread Geva, Erez
Hi, I think it is better to use a short explanation how does mktime() use the tm_isdst flag, and why should it be set to 0. For me the problem is that we did not comply with proper use of mktime(). Fixing glibc only revealed the bug in linuxptp. So we fix linuxptp, not trying to comply with

Re: [Linuxptp-devel] [PATCH 1/4] ts2phc: Fix uninitialized variable in nmea_scan_rmc

2021-05-14 Thread Geva, Erez
One of my hardest bug was one a single bit. Do not measure bugs by code. Measure by complexity. Erez -Original Message- From: Lars Munch Sent: Friday, 14 May 2021 18:14 To: Geva, Erez (ext) (DI PA DCP R 3) Cc: linuxptp-devel@lists.sourceforge.net Subject: Re: [Linuxptp-devel] [PATCH 1

Re: [Linuxptp-devel] [PATCH 1/4] ts2phc: Fix uninitialized variable in nmea_scan_rmc

2021-05-14 Thread Geva, Erez
m: Lars Munch Sent: Friday, 14 May 2021 19:30 To: Geva, Erez (ext) (DI PA DCP R 3) Cc: linuxptp-devel@lists.sourceforge.net Subject: Re: [Linuxptp-devel] [PATCH 1/4] ts2phc: Fix uninitialized variable in nmea_scan_rmc So how about the following simple explanation? According to POSIX.1-2017 tm_is

Re: [Linuxptp-devel] [PATCH] Add new CLOCK_STATS_NP TLV GET to pmc and clock

2021-05-26 Thread Geva, Erez
In IEEE 1588-2019 I see PARENT_DATA_SET with - observedParentOffsetScaledLogVariance - observedParentClockPhaseChangeRate You use a natural statistics syntax. Perhaps you may use a more coherent phrasing that match the standard. May be something that match the performanceMonitoringDS, like -

Re: [Linuxptp-devel] [PATCH v3 1/1] Add master only management TLV

2021-05-25 Thread Geva, Erez
The value comes from configuration on start up. Our configuration file is read only. The patch only implement a read operation (GET). Erez From: luigi.mantell...@sm-optics.com Sent: Monday, 24 May 2021 08:53 To: linuxptp-devel@lists.sourceforge.net; Geva, Erez (ext) (DI PA DCP R 3) Subject

Re: [Linuxptp-devel] [PATCH] Add new CLOCK_STATS_NP TLV GET to pmc and clock

2021-05-27 Thread Geva, Erez
Hi, I would like to use this opportunity to promote the libpmc library. https://sf.net/p/linuxptp/ The library provide the functionality of the pmc tool. It comes with wrapping for python, Perl, Lua, php, ruby. And runs more then 20 times faster then the original linuxptp pmc tool Query a

Re: [Linuxptp-devel] [PATCH] Add new CLOCK_STATS_NP TLV GET to pmc and clock

2021-05-27 Thread Geva, Erez
IEEE 1558 2019 does define Float64 that follow using the IEEE Std 754 As most hardware that runs Linux already use IEEE Std 754 (on hardware level or library level for hardware lacking floating point). The Float64 match C float on most 64 bits machine. You may need more code to ensure your C

Re: [Linuxptp-devel] [PATCH] Increase the default tx_timestamp_timeout to 5

2021-07-09 Thread Geva, Erez
I do not see any connection of pmc poll time-out to ptp4l waiting for TX time stamp. On my libpmc https://sf.net/p/libpmc I do not use any time out. The libpmc pmc tools works better this way. Erez -Original Message- From: Eric Decker Sent: Friday, 9 July 2021 00:28 To: Richard

Re: [Linuxptp-devel] [PATCH 1/1] Add master only management TLV

2021-04-26 Thread Geva, Erez
On 26/04/2021 00:47, Richard Cochran wrote: > On Thu, Apr 22, 2021 at 03:04:17PM +0200, Erez Geva wrote: > >> diff --git a/pmc.c b/pmc.c >> index a767c8a..00d6014 100644 >> --- a/pmc.c >> +++ b/pmc.c >> @@ -335,6 +335,11 @@ static void pmc_show(struct ptp_message *msg, FILE *fp) >>

Re: [Linuxptp-devel] [PATCH v4] Rework twoStepFlag in order to handle one step on port basis.

2021-04-22 Thread Geva, Erez
On 22/04/2021 09:18, Luigi 'Comio' Mantellini wrote: > With this patch we introduce the twoStepFlag evaluation at port level. > > --- > config.c | 2 +- > port.c | 35 ++- > ptp4l.8 | 9 - > 3 files changed, 39 insertions(+), 7 deletions(-) > >

Re: [Linuxptp-devel] [PATCH 0/1] Add master only management TLV

2021-04-22 Thread Geva, Erez
as the 'master only' is a port action and not clock action as 'slave only', it might be easier to implement and verify. Erez -Original Message- From: Luigi 'Comio' Mantellini Sent: Thursday, 22 April 2021 15:25 To: Geva, Erez (ext) (DI PA DCP R 3) Cc: linuxptp-devel@lists.sourceforge.net

Re: [Linuxptp-devel] pmc is not giving any output without using -d option

2021-04-22 Thread Geva, Erez
No, You must use a proper domain number that match the PTP domain. You can fetch it from 1. A configuration file with domainNumber 2. The – domainNumber option 3. The -d The default is 0. Erez From: Ruby Bhati Sent: Thursday, 22 April 2021 13:40 To:

Re: [Linuxptp-devel] Regarding linuxPTP static analysis..

2021-05-04 Thread Geva, Erez
On 04/05/2021 10:16, Miroslav Lichvar wrote: > On Tue, May 04, 2021 at 04:43:51PM +0900, 박웅섭 wrote: >> 1.In the text->length=c->desc.userDescription.length part of clock.c line >> 368, the length declared in the static_ptp_text structure is of type signed >> int and the length declared in the

Re: [Linuxptp-devel] [PATCH 0/1] Fix SLAVE_ONLY TLV

2021-03-30 Thread Geva, Erez
On 30/03/2021 09:22, Michael Walle wrote: > Hi Erez, > > Am 2021-03-30 01:26, schrieb Erez Geva: >> Confirm to IEEE 1588 SLAVE_ONLY management TLB >> >> Erez Geva (1): >>   Fix SLAVE_ONLY TLV > > I guess this is the new patch version? This should be reflected in the > Subject line, e.g. "[PATCH

Re: [Linuxptp-devel] [PATCH 1/2] Explicit length byte order swap functions.

2021-03-11 Thread Geva, Erez
How do you want to call the 64 bits? I think that naming should be consistence. Erez -Original Message- From: Richard Cochran Sent: Thursday, 11 March 2021 04:12 To: Geva, Erez (ext) (DI PA DCP R 3) Cc: linuxptp-devel@lists.sourceforge.net Subject: Re: [Linuxptp-devel] [PATCH 1/2

[Linuxptp-devel] Quation regarding the new 'uds_ro_address'

2021-03-16 Thread Geva, Erez
Hi, There is a new uds_ro_address with the default file /var/run/ptp4lro. Which allow to read without setting or modifying. Great, Good work -:) What is your view on the files permission? $ ls -l /var/run/ptp4l* srw-rw 1 root root 0 Mar 16 13:21 /var/run/ptp4l srw-rw 1 root root 0 Mar

Re: [Linuxptp-devel] SyncE support

2021-03-18 Thread Geva, Erez
On 18/03/2021 11:57, Frantisek Rysanek wrote: > On 17 Mar 2021 at 18:01, Miroslav Lichvar wrote: > > [on PCI-e PTM] >> >> The switches are supposed to work like NTP server and client at the >> same time (boundary clock in the PTP terminology), so all PCIe links >> have hardware timestamping on

[Linuxptp-devel] First alpha version of libpmc here https://github.com/erezgeva/libpmc

2021-03-10 Thread Geva, Erez
___ Linuxptp-devel mailing list Linuxptp-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxptp-devel

Re: [Linuxptp-devel] PORT_STATS_NP management TLV message

2021-03-10 Thread Geva, Erez
On 10/03/2021 00:38, Keller, Jacob E wrote: >> -Original Message- >> From: Geva, Erez >> Sent: Tuesday, March 09, 2021 2:29 PM >> To: Richard Cochran >> Cc:linuxptp-devel@lists.sourceforge.net >> Subject: Re: [Linuxptp-devel] PORT_STATS_NP manageme

[Linuxptp-devel] PORT_STATS_NP management TLV message

2021-03-09 Thread Geva, Erez
Hi, I am about to release a first version of a new libpmc library under LGPL for all the guys who "parse" pmc output. As I add the PORT_STATS_NP message, I notice that the statistics is stored in unsigned integer 64 bits values, but using host order instead of network order. As I know you

Re: [Linuxptp-devel] [PATCH 1/1] Fix SLAVE_ONLY TLV

2021-03-22 Thread Geva, Erez
On 22/03/2021 16:31, Erez Geva wrote: > According to IEEE 1588 The slave only flag in the SLAVE_ONLY TLV > is bit 0 and not bit 1 as in the DEFAULT_DATA_SET TLV. > > To retain backward compatibility and as bit 1 in SLAVE_ONLY > is not used anyway. Read and set both bits with same value. > ---

Re: [Linuxptp-devel] SyncE support

2021-03-16 Thread Geva, Erez
On 16/03/2021 16:59, Miroslav Lichvar wrote: > On Tue, Mar 16, 2021 at 03:52:36PM +0100, Frantisek Rysanek wrote: >> On 16 Mar 2021 at 11:25, Miroslav Lichvar wrote: >>> >>> In the Intel's igc driver I saw few SYNCE registers defined, >>> but no code using them. >>> >> Whoa. igc ? oh there's an

Re: [Linuxptp-devel] SyncE support

2021-03-16 Thread Geva, Erez
On 16/03/2021 15:52, Frantisek Rysanek wrote: > On 16 Mar 2021 at 11:25, Miroslav Lichvar wrote: >> >> In the Intel's igc driver I saw few SYNCE registers defined, >> but no code using them. >> > Whoa. igc ? oh there's an i225... didn't know about this one, thanks > for the pointer, this

Re: [Linuxptp-devel] PORT_STATS_NP management TLV message

2021-03-09 Thread Geva, Erez
limit this TLV message to UDS only? Since UDS always run on the same machine. Erez -Original Message- From: Richard Cochran Sent: Tuesday, 9 March 2021 17:57 To: Geva, Erez (ext) (DI PA DCP R 3) Cc: linuxptp-devel@lists.sourceforge.net Subject: Re: PORT_STATS_NP management TLV message

Re: [Linuxptp-devel] Get servo state from PMC

2021-04-15 Thread Geva, Erez
Hi, Can you be more explicit? What do you mean by “servo state”? What state you want to query? Erez From: Ruby Bhati Sent: Thursday, 15 April 2021 12:49 To: linuxptp-devel@lists.sourceforge.net Subject: Re: [Linuxptp-devel] Get servo state from PMC Hi, Updating the Qus. Is there any way to

Re: [Linuxptp-devel] Get servo state from PMC

2021-04-15 Thread Geva, Erez
. Is there any way from pmc also I can read this servo state Thanks, Ruby Bhati On Thu, Apr 15, 2021 at 4:31 PM Geva, Erez mailto:erez.geva@siemens.com>> wrote: Hi, Can you be more explicit? What do you mean by “servo state”? What state you want to query? Erez From: Ruby Bhati mailto:ruby

Re: [Linuxptp-devel] [PATCH] Fix uninitialized variable in nmea_scan_rmc

2021-04-21 Thread Geva, Erez
Looks like you daylight time is broken on Arch Linux and Ubuntu 20.04. -1 is error by mktime. Why do you think it is related here? Fix you daylight time setting in your system and open a bug report in the relevant packages/systems. Erez From: Lars Munch Sent: Tuesday, 20 April 2021 22:24

Re: [Linuxptp-devel] [PATCH] Fix uninitialized variable in nmea_scan_rmc

2021-04-21 Thread Geva, Erez
Looks like the man page is not accurate. Looking in https://pubs.opengroup.org/onlinepubs/009695399/functions/mktime.html A positive or 0 value for tm_isdst shall cause mktime() to presume initially that Daylight Savings Time, respectively, is or is not in effect for the specified time. A

Re: [Linuxptp-devel] Propagate management messages from UNIX layer to PTP network

2021-04-21 Thread Geva, Erez
Thanks, Forgot about it. Erez From: Luigi 'Comio' Mantellini Sent: Wednesday, 21 April 2021 18:10 To: Geva, Erez (ext) (DI PA DCP R 3) Cc: linuxptp-devel@lists.sourceforge.net Subject: Re: [Linuxptp-devel] Propagate management messages from UNIX layer to PTP network You should specify 0

[Linuxptp-devel] Propagate management messages from UNIX layer to PTP network

2021-04-21 Thread Geva, Erez
Hi, We notice that when sending Management messages using UNIX socket ('pmc -u'). ptp4l propagate the message to the PTP domain network. We try to set the target using local clock ID. # pmc -u -f /etc/linuxptp/ptp4l.conf 'target xx.fffe.xx-1' 'get CLOCK_DESCRIPTION' Now, we get reply

Re: [Linuxptp-devel] [PATCH] Fix uninitialized variable in nmea_scan_rmc

2021-04-21 Thread Geva, Erez
That make sense. nmea uses UTC. UTC does not use daylight saving. So we should set tm_isdst to zero or negative. I think zero is better as UTC should not use daylight saving. Sound like a good ground for a patch Erez From: Lars Munch Sent: Wednesday, 21 April 2021 15:01 To: Geva, Erez (ext

Re: [Linuxptp-devel] [PATCH] Only forward responses to UDS port with corresponding requests on the UDS port, and always send with a unique sequence count from uds.

2021-08-18 Thread Geva, Erez
Hi, Regarding: "pmc executes as a new process each time it is called". 1. No you can run the pmc tool in interactive mode. Then send new requests, line by line and with increasing the sequence ID. 2. You can use the libpmc library https://sf.net/projects/libpmc/, The library allow you to

[Linuxptp-devel] process ID size in the pmc tool

2021-08-17 Thread Geva, Erez
Hi, In pmc_create(...) if (transport_type == TRANS_UDS) { pmc->port_identity.portNumber = getpid(); When portNumber is UInteger16 However in new Linux systems, I notice that the process ID can be larger than 16 bits. Do you think we need to

Re: [Linuxptp-devel] [PATCH] Only forward responses to UDS port with corresponding requests on the UDS port, and always send with a unique sequence count from uds.

2021-08-19 Thread Geva, Erez
that supports IEEE 1558 management messages. :-) Erez -Original Message- From: Eric Decker Sent: Thursday, 19 August 2021 04:56 To: Geva, Erez (ext) (DI PA DCP R 3) Cc: linuxptp-devel@lists.sourceforge.net; Richard Cochran Subject: RE: [Linuxptp-devel] [PATCH] Only forward responses to UDS port

Re: [Linuxptp-devel] [RFC PATCH 10/10] checksync: new program to wait for a local or remote clock to synchronize

2021-10-19 Thread Geva, Erez
er 0m0.013s sys 0m0.011s = Run tcl = real 0m0.012s user 0m0.007s sys 0m0.007s debian@tsnlaptop:~/TSN/build/libpmc (master)$ From: Erez Sent: Monday, 18 October 2021 10:32 To: Richard Cochran Cc: Geva, Erez (ext) (DI PA DCP R 3) ; linuxptp-devel@lists.sourceforge.net Subject: Re: [Li

Re: [Linuxptp-devel] [RFC PATCH 10/10] checksync: new program to wait for a local or remote clock to synchronize

2021-10-15 Thread Geva, Erez
Regarding the "ugly scripting" of pmc. I create the http://libpmc.sf.net/ just to work around this issue. The libpmc provides a library with pmc tool capabilities, and wrapper for scripting as Python, Lua and Perl. I think pmc is as a testing tool for the linuxptp project, but not a real tool

Re: [Linuxptp-devel] Porting ptp4l for custom timestamp hardware

2021-10-01 Thread Geva, Erez
Hi, The linuxptp needs the driver to register to the PTP layer. You may write a complete kernel driver, or a driver in kernel that register the PTP layer and communicate with the user space driver. Good luck Erez -Original Message- From: Richard Cochran Sent: Friday, 1 October

Re: [Linuxptp-devel] Porting ptp4l for custom timestamp hardware

2021-10-01 Thread Geva, Erez
You may do this too. A legal point, As linuxptp is GPL, any changed code or code you link with it have to be GPL too! And be published according to GPL. Erez From: Luigi 'Comio' Mantellini Sent: Friday, 1 October 2021 16:02 To: Richard Cochran Cc: linuxptp-devel@lists.sourceforge.net

Re: [Linuxptp-devel] linuxptp performance hit

2021-12-17 Thread Geva, Erez
Hi, I like your patch. You follow PRINT_RL, good thinking. I want to recommend: 1. You need to commit the changes locally. You need to sign the patches. And create patches for send with “git format-patch --cover-letter”. You need to fill the cover letter “patch” manually. The cover letter

Re: [Linuxptp-devel] [PATCH] util: don't error out in posix_clock_open() if we can't determine PHC index

2021-11-17 Thread Geva, Erez
Do you mean? https://pubs.opengroup.org/onlinepubs/009696799/functions/realpath.html https://man7.org/linux/man-pages/man3/realpath.3p.html https://man7.org/linux/man-pages/man3/realpath.3.html -Original Message- From: Richard Cochran Sent: Wednesday, 17 November 2021 05:23 To: Keller,

Re: [Linuxptp-devel] Inconsistent remote timestamps in the P2P mode

2021-11-19 Thread Geva, Erez
Is the new IEEE Std 1588-2019 have any updates on that? -Original Message- From: Methlal Pallewatta Sent: Friday, 19 November 2021 12:17 To: linuxptp-devel@lists.sourceforge.net Subject: [Linuxptp-devel] Inconsistent remote timestamps in the P2P mode Hi all, In the section 6.6.4

Re: [Linuxptp-devel] [PATCH RFC v3 06/10] Add the ALTERNATE_TIME_OFFSET_PROPERTIES management message.

2021-11-10 Thread Geva, Erez
, Erez (ext) (DI PA DCP R 3) Cc: linuxptp-devel@lists.sourceforge.net Subject: Re: [Linuxptp-devel] [PATCH RFC v3 06/10] Add the ALTERNATE_TIME_OFFSET_PROPERTIES management message. On Wed, Nov 10, 2021 at 08:57:35AM +, Geva, Erez wrote: > Hi, > > According to IEEE 1588 timeOfNextJ

Re: [Linuxptp-devel] [PATCH RFC v3 06/10] Add the ALTERNATE_TIME_OFFSET_PROPERTIES management message.

2021-11-10 Thread Geva, Erez
Hi, According to IEEE 1588 timeOfNextJump is 48 bits. The alternate_time_offset_properties structure reserve the full 48 bits. The pre and the post function do full handle. But the rest handle only the low 32 bits. I can understand the PMC set use 32 bits only, but the rest? Erez -Original

Re: [Linuxptp-devel] [RFC PATCH 10/10] checksync: new program to wait for a local or remote clock to synchronize

2021-11-16 Thread Geva, Erez
port is synchronise or not based on these values. Erez -Original Message- From: Richard Cochran Sent: Monday, 15 November 2021 14:43 To: Geva, Erez (ext) (DI PA DCP R 3) Cc: Vladimir Oltean ; linuxptp-devel@lists.sourceforge.net Subject: Re: [Linuxptp-devel] [RFC PATCH 10/10] checksync:

Re: [Linuxptp-devel] [PATCH] Signed-off-by: Vladimir Nosikov

2021-11-01 Thread Geva, Erez
Hi, >From IEEE 1588-2019: "This range is to be assigned by an alternate PTP Profile" E000 - FFFE Can you provide the standard reference for this TLV? Erez -Original Message- From: Vladimir Nosikov via Linuxptp-devel Sent: Monday, 1 November 2021 13:45 To:

Re: [Linuxptp-devel] [RFC PATCH 00/10] checksync: new program to wait for a local or remote clock to synchronize

2021-11-04 Thread Geva, Erez
Nice, Your code is GPL, So using your code does not helps, we can simply use linuxptp directly. We can not integrate your code in to our application without GPL our code, or we need to use it through bash script/system and parse the result. Why bother? Enjoy coding Erez P.S. We have

Re: [Linuxptp-devel] [PATCH] Set grandmasterIdentity to localClockIdentity

2021-11-05 Thread Geva, Erez
Hi, I though gmPresent means an external clock, not own clock. If the ptp4l looses sync, how can you have a grand master present? Please explain. Erez -Original Message- From: Joanna Yurdal Sent: Friday, 5 November 2021 12:04 To: linuxptp-devel@lists.sourceforge.net Subject:

Re: [Linuxptp-devel] [PATCH] Signed-off-by: Vladimir Nosikov

2021-11-03 Thread Geva, Erez
value from this range? Except ofc C000, C001, C003 and C006. ____ From: Geva, Erez Sent: Monday, November 1, 2021 9:48:30 PM To: Носиков Владимир Алексеевич Cc: linuxptp-devel@lists.sourceforge.net Subject: RE: [Linuxptp-devel] [PATCH] Signed-off-by: Vladimir

Re: [Linuxptp-devel] [PATCH] Set grandmasterIdentity to localClockIdentity

2021-11-08 Thread Geva, Erez
, 8 November 2021 10:44 To: Geva, Erez (ext) (DI PA DCP R 3) Cc: linuxptp-devel@lists.sourceforge.net Subject: Re: [Linuxptp-devel] [PATCH] Set grandmasterIdentity to localClockIdentity Without the proposed patch the result of pmc "get time_status" when lost synchronization with e

Re: [Linuxptp-devel] [PATCH 4/4] ts2phc: Add serial baudrate option

2021-07-19 Thread Geva, Erez
This looks like a call to send the a patch with these options. Richard, How do you think these options should be implemented? A single enumerator, separate integer for each? Erez -Original Message- From: Hal Murray Sent: Monday, 19 July 2021 12:39 To: Geva, Erez (ext) (DI PA DCP R 3

Re: [Linuxptp-devel] [PATCH 4/4] ts2phc: Add serial baudrate option

2021-07-19 Thread Geva, Erez
Hi, Do you mean this one, page 20? http://www.leapsecond.com/museum/z3801a/097-z3801-01-iss-1.pdf Erez -Original Message- From: Richard Cochran Sent: Monday, 19 July 2021 04:13 To: Hal Murray Cc: linuxptp-devel@lists.sourceforge.net Subject: Re: [Linuxptp-devel] [PATCH 4/4] ts2phc:

Re: [Linuxptp-devel] [PATCH] Add non-portable management option to query the servo state (via SERVO_STATE_NP).

2022-03-17 Thread Geva, Erez
I think Richard is correct. The sync state depends on your system. On my setting a 'sync' is when the correction is bellow 100 nanoseconds, when it is usually bellow 10 nanoseconds and I except to have it stable for 5 seconds long. There is no generic sync. So each user need to define a

Re: [Linuxptp-devel] [PATCH] Add UNICAST_MASTER_TABLE_NP management TLV

2022-02-17 Thread Geva, Erez
Hi, The standard define: UNICAST_MASTER_TABLE ACCEPTABLE_MASTER_TABLE And some more tables. Why do we need a new private management TLV and not use the standard TLVs? Not against adding new management TLV, if we have good reason for. Nor do I think the standard is better. But it seems we skip

Re: [Linuxptp-devel] [PATCH 1/1] Fix management TLV print.

2022-03-22 Thread Geva, Erez
2022 19:54 To: Erez Cc: Geva, Erez (ext) (DI PA DCP R 3) ; linuxptp-devel@lists.sourceforge.net Subject: Re: [Linuxptp-devel] [PATCH 1/1] Fix management TLV print. On Tue, Mar 22, 2022 at 12:54:55PM +0100, Erez wrote: > As actualTableSize name comes from the IEEE standard. UNICAST_MA

Re: [Linuxptp-devel] [PATCH] Add non-portable management option to query the servo state (via SERVO_STATE_NP).

2022-03-24 Thread Geva, Erez
Sent: Thursday, 17 March 2022 21:48 To: Geva, Erez (ext) (DI PA DCP R 3) Cc: Miroslav Lichvar ; Martin Pecka ; linuxptp-devel@lists.sourceforge.net Subject: Re: [Linuxptp-devel] [PATCH] Add non-portable management option to query the servo state (via SERVO_STATE_NP). On Thu, Mar 17, 2022 at 10:16

Re: [Linuxptp-devel] [PATCH] Add non-portable management option to query the servo state (via SERVO_STATE_NP).

2022-03-28 Thread Geva, Erez
t! Thanks for sharing Erez -Original Message- From: Martin Pecka Sent: Monday, 28 March 2022 23:11 To: Richard Cochran ; Geva, Erez (ext) (DI PA DCP R 3) Cc: Miroslav Lichvar ; linuxptp-devel@lists.sourceforge.net Subject: Re: [Linuxptp-devel] [PATCH] Add non-portable managem

Re: [Linuxptp-devel] [PATCH RFC 0/7] Support for virtual clocks

2022-01-20 Thread Geva, Erez
Hi, When we would use multiple PHC per interface (or per bridge/switch). How can we defer a real PHC from virtual PHC? Would not it be easier to simply call then multiple PHC and use the index regardless if it is virtual or not. As for the PORT_PROPERTIES_NP. It is a port TLV not a clock TLV.

Re: [Linuxptp-devel] [PATCH] Add PORT_SERVICE_STATS_NP management TLV

2022-01-25 Thread Geva, Erez
You can add a management set/command operation of the PORT_SERVICE_STATS_NP management TLV. Erez -Original Message- From: Dale Smith Sent: Tuesday, 25 January 2022 23:05 To: Alexander Bulimov Cc: linuxptp-devel@lists.sourceforge.net Subject: Re: [Linuxptp-devel] [PATCH] Add

Re: [Linuxptp-devel] Power profile support in ptp4l

2022-04-15 Thread Geva, Erez
You can find it in the archive https://sourceforge.net/p/linuxptp/mailman/linuxptp-devel/ See: [PATCH RFC v3 00/10] Profile support for IEEE C37.238-2011 and IEEE C37.238-2017 10 patches https://sourceforge.net/p/linuxptp/mailman/linuxptp-devel/?viewmonth=202111=9 Erez From: Vijay Khurdiya

Re: [Linuxptp-devel] [PATCH] sk.c: Unreachable switch case TS_SOFTWARE

2022-07-21 Thread Geva, Erez
Hi, I think the "if (type != TS_SOFTWARE" is wrong. The "type" only refer to TX. But hwts_init() also set the RX. So no reason to skip it. Setting to TS_SOFTWARE means no TX hardware time stamp. I wonder how we miss it? Probably in refactoring of the code. Or is it is a quick work-around? Erez

Re: [Linuxptp-devel] [PATCH 1/4] [Interface Rate TLV] function to support get interface speed via ethtool

2022-07-26 Thread Geva, Erez
Looking in the kernel code. The link mode mask are mandatory for the get_link_ksettings() call-back, the driver is require to fill them. The size is fixed to __ETHTOOL_LINK_MODE_MASK_NU32. >From kernel net/ethtool/ioctl.c:

Re: [Linuxptp-devel] [PATCH] phc_ctl: add pin_cfg command to display pin functions

2022-10-27 Thread Geva, Erez
Already have it in https://github.com/erezgeva/libptpmgmt/blob/master/src/ptp.h Erez  -Original Message- From: Miroslav Lichvar Sent: Thursday, 27 October 2022 17:00 To: Jacob Keller Cc: linuxptp-devel@lists.sourceforge.net Subject: Re: [Linuxptp-devel] [PATCH] phc_ctl: add pin_cfg

Re: [Linuxptp-devel] [PATCH] Fixed time of generic ts2phc master

2022-09-26 Thread Geva, Erez
Hi, I think we should put a comment there. It does looks buzzard to see ' ts->tv_nsec = ntx.time.tv_usec'. Though this is how 'ADJ_NANO' works  Erez -Original Message- From: Miroslav Lichvar Sent: Monday, 26 September 2022 10:57 To: j.raczynski Cc:

Re: [Linuxptp-devel] [PATCH 1/1] clock: Fix stale clock parent pid usage after best master change

2022-12-04 Thread Geva, Erez
On Fri, 2022-12-02 at 15:33 -0500, vincent.cheng...@renesas.com wrote: > From: Vincent Cheng > > In handle_state_decision_event(), the update of the clock's parent > pid after > best master change is non-deterministic. It depends on the port > processing > order and bmc_state_decision() results.

Re: [Linuxptp-devel] [PATCH v3 1/4] [Interface Rate TLV] function to support get interface speed via ethtool

2022-12-09 Thread Geva, Erez
On Wed, 2022-12-07 at 17:34 +0530, SyncMonk Technologies wrote: > When master and slave instance interacting with each other operating > at different interface speed, delay assymetry needs to be compensated > as described in G.8271 appendix V. > > In this patch we are adding changes to get the

Re: [Linuxptp-devel] [PATCH v3 4/4] [Interface Rate TLV] adding delay asymmetry calculation

2022-12-09 Thread Geva, Erez
On Wed, 2022-12-07 at 17:34 +0530, SyncMonk Technologies wrote: > Delay asymmetry calculation based on the PTP port interface speed of > master obtained from TLV and the slave interface rate obtained by > ethtool. > > v3: updating network/host byte order handling. > v1: initial commit > >

Re: [Linuxptp-devel] [PATCH v3 3/4] [Interface Rate TLV] organization TLV support for interface rate

2022-12-09 Thread Geva, Erez
On Wed, 2022-12-07 at 17:34 +0530, SyncMonk Technologies wrote: > adding interface rate TLV as defined by ITU-T G.8275.2 Annex D to > enable master to communicate PTP port interface rate to slave. > > Signed-off-by: Greg Armstrong > Signed-off-by: Leon Goldin > Signed-off-by: Devasish Dey >

Re: [Linuxptp-devel] [PATCH v3 1/4] [Interface Rate TLV] function to support get interface speed via ethtool

2022-12-13 Thread Geva, Erez
On Tue, 2022-12-13 at 17:39 +0100, Erez Geva wrote: On Tue, 2022-12-13 at 10:39 +0530, Devasish Dey wrote: > + goto failed; > + } I think it is better to merge this ioctl and the socket creation with sk_get_ts_info(). No reason for duplication. You can use a static function or

  1   2   >