Re: [Linuxwacom-devel] [PATCH] Check MT_TOOL_FINGER for WCM_2FGT -withdraw

2011-01-18 Thread Ping Cheng
, Ping Cheng pingli...@gmail.com wrote: From: Ping Cheng pi...@wacom.com Only 2FGT devices in relative cursor movement, such as Bamboo, send BTN_TOOL_DOUBLETAP events. Use MT_TOOL_FINGER to cover both Bamboo and 2FGT touch screen devices. Signed-off-by: Ping Cheng pingli...@gmail.copm

Re: [Linuxwacom-devel] Lenovo X201 Tablet troubles

2011-01-18 Thread Ping Cheng
On Tue, Jan 18, 2011 at 1:57 PM, Chris Bagwell ch...@cnpbagwell.com wrote: On Tue, Jan 18, 2011 at 3:49 PM, Ping Cheng pingli...@gmail.com wrote: On Tue, Jan 18, 2011 at 11:32 AM, AndrewP inson...@gmail.com wrote: Updated driver from git, and here's my Xorg.0.log for it http://dpaste.org/D35D

Re: [Linuxwacom-devel] [PATCH] Check MT_TOOL_FINGER for WCM_2FGT -withdraw

2011-01-18 Thread Ping Cheng
to the picture. What do you think? Ping On Tue, Jan 18, 2011 at 3:19 PM, Ping Cheng pingli...@gmail.com wrote: Please ignore this patch. It is taking an EV_ABS (MT_TOOL_FINGER) as an EV_KEY, which is wrong. I'll have to find another way to cover the case. Chris, you worked on this block

Re: [Linuxwacom-devel] [PATCH 10/11] Remove useless else block.

2011-01-18 Thread Ping Cheng
On Tue, Jan 18, 2011 at 5:15 PM, Peter Hutterer peter.hutte...@who-t.net wrote: On Tue, Jan 18, 2011 at 04:29:55PM -0800, Ping Cheng wrote: On Tue, Jan 18, 2011 at 3:32 PM, Peter Hutterer peter.hutte...@who-t.net wrote: This is the most creative way of not changing a value I've seen so far

Re: [Linuxwacom-devel] [PATCH] Check MT_TOOL_FINGER for WCM_2FGT -withdraw

2011-01-18 Thread Ping Cheng
On Tue, Jan 18, 2011 at 5:29 PM, Chris Bagwell ch...@cnpbagwell.com wrote: On Tue, Jan 18, 2011 at 6:16 PM, Ping Cheng pingli...@gmail.com wrote: On Tue, Jan 18, 2011 at 2:02 PM, Chris Bagwell ch...@cnpbagwell.com wrote: What device are you working with that you want this change?  I ask

Re: [Linuxwacom-devel] [PATCH v2 2/3] Add comment describing factorX and factorY

2011-01-17 Thread Ping Cheng
On Sun, Jan 16, 2011 at 7:59 PM, ch...@cnpbagwell.com wrote: From: Chris Bagwell ch...@cnpbagwell.com Signed-off-by: Chris Bagwell ch...@cnpbagwell.com Reviewed-by: Peter Hutterer peter.hutte...@who-t.net ---  src/wcmCommon.c |    5 +  1 files changed, 5 insertions(+), 0 deletions(-)

Re: [Linuxwacom-devel] Lenovo X201 Tablet troubles

2011-01-17 Thread Ping Cheng
use device names instead of device IDs. the ids may change, names stay the same across reboots. Cheers,  Peter On Thu, Jan 13, 2011 at 19:16, Ping Cheng pingli...@gmail.com wrote: On Mon, Jan 10, 2011 at 1:52 PM, AndrewP

Re: [Linuxwacom-devel] [PATCH 2/4] Add comment describing factorX and factorY

2011-01-17 Thread Ping Cheng
On Sun, Jan 16, 2011 at 2:52 PM, Peter Hutterer peter.hutte...@who-t.net wrote: On Fri, Jan 14, 2011 at 08:32:18AM -0600, Chris Bagwell wrote: On Fri, Jan 14, 2011 at 12:10 AM, Ping Cheng pingli...@gmail.com wrote: On Thu, Jan 13, 2011 at 8:17 PM,  ch...@cnpbagwell.com wrote: From: Chris

Re: [Linuxwacom-devel] Lenovo X201 Tablet troubles

2011-01-17 Thread Ping Cheng
On Mon, Jan 17, 2011 at 11:19 AM, AndrewP inson...@gmail.com wrote: sure, I do. If I set it high it works almost like mouse button (without any pressure) if low I get more pressure levels (very sensitive progression), but clicks get very sensitive. I stress I have very low pressure range, if I

[Linuxwacom-devel] [PATCH] Check MT_TOOL_FINGER for WCM_2FGT

2011-01-17 Thread Ping Cheng
From: Ping Cheng pi...@wacom.com Only 2FGT devices in relative cursor movement, such as Bamboo, send BTN_TOOL_DOUBLETAP events. Use MT_TOOL_FINGER to cover both Bamboo and 2FGT touch screen devices. Signed-off-by: Ping Cheng pingli...@gmail.copm --- src/wcmValidateDevice.c |6 +++--- 1

Re: [Linuxwacom-devel] Lenovo X201 Tablet troubles

2011-01-13 Thread Ping Cheng
On Mon, Jan 10, 2011 at 1:52 PM, AndrewP inson...@gmail.com wrote: Happened to boot to Win7 again, and must notice it is wholly different experience there. Any luck with our driver? I found another pen only serial tablet PC (another Toshiba system). I installed Fedora 13 on it. Then I upgraded

Re: [Linuxwacom-devel] Lenovo X201 Tablet troubles

2011-01-13 Thread Ping Cheng
On Thu, Jan 13, 2011 at 11:53 AM, AndrewP inson...@gmail.com wrote: it was more tricky, I've compiled it without debug flag. recompiled the driver and all went well with xsetwacom I got massive log from Xorg. Feared to drop something important so posted most of it http://dpaste.org/4SO3/ In

Re: [Linuxwacom-devel] [PATCH 3/4] Init relative X/Y axis to use tablets min/max size

2011-01-13 Thread Ping Cheng
On Thu, Jan 13, 2011 at 6:33 PM, Chris Bagwell ch...@cnpbagwell.com wrote: On Thu, Jan 13, 2011 at 8:16 PM, Peter Hutterer wait, doesn't the touch tool use the same axis ranges as the other tools? On Bamboo's, the touch tool can use a larger area of tablet then pen/eraser tool can.  This is

Re: [Linuxwacom-devel] [PATCH 4/4] compute factorX/factorY from sizeX/sizeY.

2011-01-13 Thread Ping Cheng
On Thu, Jan 13, 2011 at 8:17 PM, ch...@cnpbagwell.com wrote: From: Chris Bagwell ch...@cnpbagwell.com maxWidth and maxHeight are no longer set and this causes relative devices to not work (factor* = 0 which scales to zero values always). bottomX/bottomY is meant to be a value that

Re: [Linuxwacom-devel] [PATCH 3/4] Make relative movement scaling logic consistent

2011-01-13 Thread Ping Cheng
On Thu, Jan 13, 2011 at 8:17 PM, ch...@cnpbagwell.com wrote: From: Chris Bagwell ch...@cnpbagwell.com X/Y relative events are computed like this: valuators[0] -= priv-oldX; valuators[1] -= priv-oldY; valuators[0] *= priv-factorY / priv-factorX; This diff shows were we were pre-computing

Re: [Linuxwacom-devel] [PATCH 3/4] Init relative X/Y axis to use tablets min/max size

2011-01-12 Thread Ping Cheng
On Wed, Jan 12, 2011 at 9:07 PM, Peter Hutterer peter.hutte...@who-t.net wrote: On Tue, Jan 11, 2011 at 08:07:31PM -0800, Ping Cheng wrote: On Tue, Jan 11, 2011 at 5:52 PM, Chris Bagwell ch...@cnpbagwell.com wrote: On Tue, Jan 11, 2011 at 7:34 PM,  ch...@cnpbagwell.com wrote: From: Chris

Re: [Linuxwacom-devel] Using the pen as Airbrush

2011-01-11 Thread Ping Cheng
On Mon, Jan 10, 2011 at 5:12 PM, Peter Hutterer peter.hutte...@who-t.net wrote: On Mon, Jan 10, 2011 at 11:34:55AM -0800, Ping Cheng wrote: On Mon, Jan 10, 2011 at 3:10 AM, Cedric Sodhi man...@gmx.net wrote: On Mon, Jan 10, 2011 at 09:16:14AM +1000, Peter Hutterer wrote: On Sat, Jan 08, 2011

Re: [Linuxwacom-devel] Using the pen as Airbrush

2011-01-11 Thread Ping Cheng
On Tue, Jan 11, 2011 at 1:37 AM, Nikolai Kondrashov spbn...@gmail.com wrote: On Tue, Jan 11, 2011 at 4:07 AM, Peter Hutterer peter.hutte...@who-t.net wrote: it's a different axis. so instead of x, y, pressure, ... you get x, y, pressure, distance, ... that's the correct integration,

Re: [Linuxwacom-devel] [PATCH 1/4] Init device_type during ABS_MT_TRACKING_ID

2011-01-11 Thread Ping Cheng
device instead of TOUCH and its being discarded until first 2 finger touch occurs. Recent combo of commits caused this discard to start happening. Signed-off-by: Chris Bagwell ch...@cnpbagwell.com Reviewed-by: Ping Cheng pingli...@gmail.com for this one. Thank you, Chris. I have comments

Re: [Linuxwacom-devel] [PATCH 3/4] Init relative X/Y axis to use tablets min/max size

2011-01-11 Thread Ping Cheng
On Tue, Jan 11, 2011 at 5:52 PM, Chris Bagwell ch...@cnpbagwell.com wrote: On Tue, Jan 11, 2011 at 7:34 PM,  ch...@cnpbagwell.com wrote: From: Chris Bagwell ch...@cnpbagwell.com wcmRotateAndScaleCoordinates() uses these values to scale values based on initialized.  The change to use -1..-1

Re: [Linuxwacom-devel] [PATCH 4/4] delete unneeded code in wcmVirtualTabletSize

2011-01-11 Thread Ping Cheng
On Tue, Jan 11, 2011 at 5:34 PM, ch...@cnpbagwell.com wrote: From: Chris Bagwell ch...@cnpbagwell.com Signed-off-by: Chris Bagwell ch...@cnpbagwell.com Reviewed-by: Ping Cheng pingli...@gmail.com Ping ---  src/xf86Wacom.c |    7 ---  1 files changed, 0 insertions(+), 7 deletions

Re: [Linuxwacom-devel] Lenovo X201 Tablet troubles

2011-01-10 Thread Ping Cheng
On Mon, Jan 10, 2011 at 10:52 AM, AndrewP inson...@gmail.com wrote: Happened to boot to Win7 again, and must notice it is wholly different experience there. I know. They meant to be different since we counted on you, the users, as well on Linux ;). Any luck with our driver? Not yet. No time

Re: [Linuxwacom-devel] Using the pen as Airbrush

2011-01-10 Thread Ping Cheng
On Mon, Jan 10, 2011 at 3:10 AM, Cedric Sodhi man...@gmx.net wrote: On Mon, Jan 10, 2011 at 09:16:14AM +1000, Peter Hutterer wrote: On Sat, Jan 08, 2011 at 11:51:41AM +0100, Cedric Sodhi wrote: I'm curious whether it would be possible and make sense to implement the mode in which the pen

Re: [Linuxwacom-devel] [PATCH 3/5] Don't post scroll ring events after proximity events.

2011-01-10 Thread Ping Cheng
On Sun, Jan 9, 2011 at 6:33 PM, Peter Hutterer peter.hutte...@who-t.net wrote: On Fri, Jan 07, 2011 at 11:10:30AM +1000, Peter Hutterer wrote: On Thu, Jan 06, 2011 at 04:46:46PM -0800, Ping Cheng wrote: On Thu, Jan 6, 2011 at 2:56 PM, Peter Hutterer peter.hutte...@who-t.net wrote

Re: [Linuxwacom-devel] [PATCH] Fix comment, XI_STYLUS is not the device name.

2011-01-10 Thread Ping Cheng
-by: Ping Cheng pingli...@gmail.com Ping ---  src/xf86Wacom.h |   10 +-  1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/xf86Wacom.h b/src/xf86Wacom.h index bcc3b73..7b5401e 100644 --- a/src/xf86Wacom.h +++ b/src/xf86Wacom.h @@ -69,11 +69,11

Re: [Linuxwacom-devel] [PATCH] Move the type properties to wacom-properties.h.

2011-01-10 Thread Ping Cheng
On Sun, Jan 9, 2011 at 5:28 PM, Peter Hutterer peter.hutte...@who-t.net wrote: We're using them as type field, clients expect them, so let's export them somewhere more visible. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Acked-by: Ping Cheng pingli...@gmail.com --- This patch

Re: [Linuxwacom-devel] Lenovo X201 Tablet troubles

2011-01-07 Thread Ping Cheng
to 2048 levels and driver cuts the rest? we saw it happening when isdv4-debugger showed pressure level around 100, when xinput was maxed-out to 2048, already. I couldn't find where translation to xinput values takes place. On Tue, Dec 28, 2010 at 01:19, Ping Cheng pingli...@gmail.com wrote

Re: [Linuxwacom-devel] Lenovo X201 Tablet troubles

2011-01-07 Thread Ping Cheng
to 2048 levels and driver cuts the rest? we saw it happening when isdv4-debugger showed pressure level around 100, when xinput was maxed-out to 2048, already. I couldn't find where translation to xinput values takes place. On Tue, Dec 28, 2010 at 01:19, Ping Cheng pingli...@gmail.com wrote

Re: [Linuxwacom-devel] [PATCH v2 2/2] fix logic detecting ABS_MT_SLOT

2011-01-06 Thread Ping Cheng
On Thu, Jan 6, 2011 at 6:56 AM, Chris Bagwell ch...@cnpbagwell.com wrote: On Wed, Jan 5, 2011 at 6:49 PM, Ping Cheng pingli...@gmail.com wrote: Ok, I see the connection between the two patches. That's why 1/2 is the first ;). I reviewed patch one again last evening. With the current kernel

Re: [Linuxwacom-devel] [PATCH v2 0/2] Use previous tools values

2011-01-06 Thread Ping Cheng
in the repo so more people can test it. Acked-by: Ping Cheng pingli...@gmail.com Ping Because of how MT events are sent, its really important to get rid of memset() for it to function correctly. Previously, a bug kept wmUseMT=0.  This meant we were only processing ST ABS_X/Y/Pressure which

Re: [Linuxwacom-devel] [PATCH 5/5] Simplify scroll strip delta calculation.

2011-01-06 Thread Ping Cheng
On Wed, Jan 5, 2011 at 11:00 PM, Peter Hutterer peter.hutte...@who-t.net wrote: Subtracting two values seems to be a far simpler way of calculating a delta. This fixes the jumping strip on the I3 devices, at least for the vertical one. Horizontal one untested for lack of device.

Re: [Linuxwacom-devel] [PATCH 3/5] Don't post scroll ring events after proximity events.

2011-01-06 Thread Ping Cheng
On Wed, Jan 5, 2011 at 11:00 PM, Peter Hutterer peter.hutte...@who-t.net wrote: If we're going out of proximity, don't post an event. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net ---  src/wcmCommon.c |    3 ++-  1 files changed, 2 insertions(+), 1 deletions(-) diff --git

Re: [Linuxwacom-devel] [PATCH 3/5] Don't post scroll ring events after proximity events.

2011-01-06 Thread Ping Cheng
On Thu, Jan 6, 2011 at 2:56 PM, Peter Hutterer peter.hutte...@who-t.net wrote: On Thu, Jan 06, 2011 at 11:23:51AM -0800, Ping Cheng wrote: On Wed, Jan 5, 2011 at 11:00 PM, Peter Hutterer peter.hutte...@who-t.net wrote: If we're going out of proximity, don't post an event. Signed-off

Re: [Linuxwacom-devel] [PATCH v2 2/2] fix logic detecting ABS_MT_SLOT

2011-01-04 Thread Ping Cheng
is clear to me. But I need time to test the other patch (1/2) on protocol 4 (and 5 maybe) devices. It will take sometime. So, I'd like to have this patch in first. Signed-off-by: Chris Bagwell ch...@cnpbagwell.com Reviewed-by: Ping Cheng pingli...@gmail.com Ping ---  src/wcmUSB.c |    2 +-  1

Re: [Linuxwacom-devel] [PATCH 2/2] set 1FGT/2FGT based on wcmKeys instead of hardcode

2010-12-29 Thread Ping Cheng
On Wed, Dec 29, 2010 at 12:38 PM, Chris Bagwell ch...@cnpbagwell.com wrote: On Wed, Dec 29, 2010 at 12:01 PM, Ping Cheng pingli...@gmail.com wrote: Hi Chris, I like the concept of this patchset. Patch one looks fine. I have some comments for this one inline. Thank you. Ping On Tue, Dec

Re: [Linuxwacom-devel] Lenovo X201 Tablet troubles

2010-12-27 Thread Ping Cheng
On Fri, Dec 24, 2010 at 5:08 AM, AndrewP inson...@gmail.com wrote: I also tried Fedora 14 Live USB before, just to be sure it's not my Gentoo messing things up. There I experienced the same. Not sure what versions I used there. Do you incline I need try another distribution again and gather

Re: [Linuxwacom-devel] Lenovo X201 Tablet troubles

2010-12-27 Thread Ping Cheng
On Mon, Dec 27, 2010 at 4:59 AM, AndrewP inson...@gmail.com wrote: Hello,    tried it once more in another distribution with live usb, behaviour is the same. Unfortunately Live media didn't provide xinput or isdv4-debugger, and I can't substantiate my words with their output. here's my

Re: [Linuxwacom-devel] Lenovo X201 Tablet troubles

2010-12-23 Thread Ping Cheng
On Wed, Dec 22, 2010 at 11:25 PM, AndrewP inson...@gmail.com wrote: Greetings everybody, I got Lenovo X201 Tablet which is equipped with Wacom serial tablet device (with no Touch support). I encounter 2 troubles, when trying to use my tablet: 1. Pen is overly sensitive, very

Re: [Linuxwacom-devel] Lenovo X201 Tablet troubles

2010-12-23 Thread Ping Cheng
On Thu, Dec 23, 2010 at 11:15 AM, AndrewP inson...@gmail.com wrote: I have only one pen with my TabletPC, although I can visit some dealer and try there. I have Intous3 pen, which I guess is not compatible, am I right? You are right. Ping On Thu, Dec 23, 2010 at 22:01, Ping Cheng pingli

Re: [Linuxwacom-devel] Lenovo X201 Tablet troubles

2010-12-23 Thread Ping Cheng
is present --- http://dpaste.org/WICO/ do they conflict with each other? On Thu, Dec 23, 2010 at 18:55, Ping Cheng pingli...@gmail.com wrote: Your log file looks fine, except you have CURSOR enabled. But that should not be an issue. How did you let the X server load the driver, I mean do you have

Re: [Linuxwacom-devel] Lenovo X201 Tablet troubles

2010-12-23 Thread Ping Cheng
it is a driver issue either since I have a pen working on my Tablet PC right now. It is a Toshiba laptop though Ping That's why I didn't blame hardware till now. On Thu, Dec 23, 2010 at 22:16, Ping Cheng pingli...@gmail.com wrote: On Thu, Dec 23, 2010 at 11:15 AM, AndrewP inson...@gmail.com

Re: [Linuxwacom-devel] [PATCH] Include stdio.h for asprintf.

2010-12-22 Thread Ping Cheng
Sorry, the warning is still there. Ping On Tue, Dec 21, 2010 at 10:36 PM, Peter Hutterer peter.hutte...@who-t.net wrote:  CC     wcmConfig.lo wcmConfig.c: In function ‘NewWcmPreInit’: wcmConfig.c:515:3: warning: implicit declaration of function ‘asprintf’ wcmConfig.c:515:3: warning: nested

Re: [Linuxwacom-devel] [PATCH] Use AC_USE_SYSTEM_EXTENSIONS for asprintf and friends.

2010-12-22 Thread Ping Cheng
AM_INIT_AUTOMAKE([foreign dist-bzip2]) AM_MAINTAINER_MODE +AC_USE_SYSTEM_EXTENSIONS # Initialize libtool AC_DISABLE_STATIC Reviewed-by: Gaetan Nadon mems...@videotron.ca Tested-by: Ping Cheng pingli...@gmail.com The asprintf warnings are gone. But we got

Re: [Linuxwacom-devel] [PATCH] Use AC_USE_SYSTEM_EXTENSIONS for asprintf and friends.

2010-12-22 Thread Ping Cheng
On Wed, Dec 22, 2010 at 6:20 PM, Peter Hutterer peter.hutte...@who-t.net wrote: On Wed, Dec 22, 2010 at 06:07:42PM -0800, Ping Cheng wrote: On Wed, Dec 22, 2010 at 5:16 PM, Gaetan Nadon mems...@videotron.ca wrote: On Thu, 2010-12-23 at 10:52 +1000, Peter Hutterer wrote: To enable asprintf

Re: [Linuxwacom-devel] [PATCH] Add support for the built-in digitizer in the Lenovo W700

2010-12-21 Thread Ping Cheng
:10 AM, Ping Cheng pingli...@gmail.com wrote: On Sun, Dec 19, 2010 at 1:26 AM, Ajay Ramaswamy linuxwa...@ramaswamy.net wrote: Ping Thanks for your support in getting this done. I have made a patch against xf86-input-wacom master in git for Peter. The patch looks good to me. I thought it would

Re: [Linuxwacom-devel] [PATCH] Use previous tools values when switching tools.

2010-12-21 Thread Ping Cheng
On Mon, Dec 20, 2010 at 5:59 PM, ch...@cnpbagwell.com wrote: From: Chris Bagwell ch...@cnpbagwell.com Kernel side input event filtering forces user land to track previous tools values when switching to new tools.  Sending new-but-duplicate values for new tool would cause confusion. At one

Re: [Linuxwacom-devel] [PATCH] Add support for the built-in digitizer in the Lenovo W700

2010-12-19 Thread Ping Cheng
, Thank you. Ping Hopefully all this will result in fedora 15 having support for my laptop. Thanks best regards Ajay On Sun, Dec 19, 2010 at 6:19 AM, Ping Cheng pingli...@gmail.com wrote: On Thu, Dec 16, 2010 at 6:37 AM, Ajay Ramaswamy aj...@krithika.net wrote: Hello Ping Cheng I have

Re: [Linuxwacom-devel] Support for Lenovo W700 built in digitizer

2010-12-18 Thread Ping Cheng
On Thu, Dec 16, 2010 at 6:37 AM, Ajay Ramaswamy aj...@krithika.net wrote: Hello Ping Cheng I have been using the tablet for the last 4 months without any problems, Today I have updated my patches against the current development series 0.10.10, can you accept these patches now? The xf86-input

Re: [Linuxwacom-devel] [PATCH 00/14] jumping scroll wheel fixes

2010-12-16 Thread Ping Cheng
My testing result and comments are inline. Ping On Wed, Dec 15, 2010 at 9:21 PM, Peter Hutterer peter.hutte...@who-t.net wrote: On Wed, Dec 15, 2010 at 08:50:08PM -0800, Ping Cheng wrote: I've tested the set. The ring (I4) is fine except around the 0 and 71 area. The strips (I3) still emit

Re: [Linuxwacom-devel] [PATCH] Split axis initialization into wcmInitAxes.

2010-12-13 Thread Ping Cheng
On Sun, Dec 12, 2010 at 7:33 PM, Peter Hutterer peter.hutte...@who-t.net wrote: And clean up the code to use less ABI ifdefs. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Reviewed-by: Ping Cheng pingli...@gmail.com with one typo correction and a few minor comments inline. Everything

Re: [Linuxwacom-devel] [PATCH] Split axis initialization into wcmInitAxes.

2010-12-13 Thread Ping Cheng
On Mon, Dec 13, 2010 at 5:15 PM, Peter Hutterer peter.hutte...@who-t.net wrote: On Mon, Dec 13, 2010 at 11:44:07AM -0800, Ping Cheng wrote: On Sun, Dec 12, 2010 at 7:33 PM, Peter Hutterer peter.hutte...@who-t.net wrote: And clean up the code to use less ABI ifdefs. Signed-off-by: Peter

Re: [Linuxwacom-devel] [PATCH] Initialize third axis on pads as unknown relative axis.

2010-12-13 Thread Ping Cheng
On Mon, Dec 13, 2010 at 5:05 PM, Peter Hutterer peter.hutte...@who-t.net wrote: On Mon, Dec 13, 2010 at 12:03:59PM -0800, Ping Cheng wrote: On Sun, Dec 12, 2010 at 7:30 PM, Peter Hutterer peter.hutte...@who-t.net wrote: The pad doesn't actually send events on the third axis, it simply acts

Re: [Linuxwacom-devel] [PATCH v2] Document the tablet feature bitmasks.

2010-12-09 Thread Ping Cheng
On Wed, Dec 8, 2010 at 9:41 PM, Peter Hutterer peter.hutte...@who-t.net wrote: Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Reviewed-by: Ping Cheng pingli...@gmail.com Thank you for the update. Ping --- chagnes to v1: - TPC is always an LCD, note that. - use Wacom's terms

Re: [Linuxwacom-devel] [PATCH] Don't close devices on read error.

2010-12-09 Thread Ping Cheng
added device was unplugged, the user needs to trigger DEVICE_OFF and DEVICE_ON manually to reopen (e.g. VT switch). Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Tested-by: Ping Cheng pingli...@gmail.com --- Slightly simpler fix than the previous one, we just remove the race condition

Re: [Linuxwacom-devel] [PATCH] WCM_TPC also implies WCM_LCD, set the bit accordingly.

2010-12-09 Thread Ping Cheng
On Wed, Dec 8, 2010 at 10:59 PM, Peter Hutterer peter.hutte...@who-t.net wrote: Shuffle PAD up to fill the hole, not that it really matters. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Reviewed-by: Ping Cheng pingli...@gmail.com Ping ---  src/xf86WacomDefs.h |    9 +  1

Re: [Linuxwacom-devel] [PATCH] Resolution needs to be in units/m

2010-12-09 Thread Ping Cheng
On Thu, Dec 9, 2010 at 11:16 AM, Chris Bagwell ch...@cnpbagwell.com wrote: Thanks for the conversion work, Peter. Acked-by: Chris Bagwell ch...@cnpbagwell.com I was to lazy up to this point to compute myself.  I plan on taking the values below, divide by 1000, and submit to kernel drivers as

Re: [Linuxwacom-devel] [PATCH] Touch resolution was incorrectly converted

2010-12-09 Thread Ping Cheng
On Wed, Dec 8, 2010 at 10:45 PM, Peter Hutterer peter.hutte...@who-t.net wrote: On Wed, Dec 08, 2010 at 10:03:36AM -0800, Ping Cheng wrote: On Tue, Dec 7, 2010 at 9:27 PM, Peter Hutterer peter.hutte...@who-t.net wrote: On Tue, Dec 07, 2010 at 01:29:36PM -0800, Ping Cheng wrote

Re: [Linuxwacom-devel] [PATCH] Resolution needs to be in units/m

2010-12-09 Thread Ping Cheng
to linux-input is attached below for your reference. On Sun, Nov 14, 2010 at 12:40 PM, Ping Cheng pingli...@gmail.com wrote: I have thought about the resolution issue for a while. I didn't want to tocuh it since it affects all HID drivers. Resolution has been added to absinfo since kernel 2.6.31

Re: [Linuxwacom-devel] [PATCH] Resolution needs to be in units/m

2010-12-09 Thread Ping Cheng
On Thu, Dec 9, 2010 at 2:16 PM, Chris Bagwell ch...@cnpbagwell.com wrote: I think this works but haven't tested it.  I can point to xf86-input-synaptics.  Its using it in same way we want to. I hope it works too. Last time I checked the kernel code (few weeks ago), I didn't see it gets

Re: [Linuxwacom-devel] [PATCH] Document the tablet feature bitmasks.

2010-12-08 Thread Ping Cheng
On Tue, Dec 7, 2010 at 9:35 PM, Peter Hutterer peter.hutte...@who-t.net wrote: Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- I _think_ this is the correct description for each feature, please check I didn't screw it up. I'm especially not sure about DUALINPUT and ROTATION.  

Re: [Linuxwacom-devel] [PATCH] Touch resolution was incorrectly converted

2010-12-08 Thread Ping Cheng
On Tue, Dec 7, 2010 at 9:27 PM, Peter Hutterer peter.hutte...@who-t.net wrote: On Tue, Dec 07, 2010 at 01:29:36PM -0800, Ping Cheng wrote: The physical size of the touch pad is reported in 1000 cm. The sorry, I'm confused. it's reported in what? 1000 units/cm? You are not alone. I

[Linuxwacom-devel] [PATCH] Log messages specific to the device

2010-12-08 Thread Ping Cheng
No real code change. Only updated xf86Msg so device specific information is posted. Signed-off-by: Ping Cheng pingli...@gmail.com --- src/wcmCommon.c | 10 +- src/xf86Wacom.c |2 +- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/src/wcmCommon.c b/src/wcmCommon.c

[Linuxwacom-devel] [PATCH] Touchcreen includes TabletPC and display tablet

2010-12-07 Thread Ping Cheng
We assumed TPC == LCD in the capacity check. Signed-off-by: Ping Cheng pingli...@gmail.com --- src/wcmUSB.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/wcmUSB.c b/src/wcmUSB.c index 79c05a8..c53ff06 100644 --- a/src/wcmUSB.c +++ b/src/wcmUSB.c @@ -989,7 +989,7

[Linuxwacom-devel] [PATCH] Touch resolution was incorrectly converted

2010-12-07 Thread Ping Cheng
The physical size of the touch pad is reported in 1000 cm. The actual fomula to get points/mm would be: MaxTouch/PhyTouch/100 Signed-off-by: Ping Cheng pingli...@gmail.com --- src/wcmUSB.c |9 + 1 files changed, 5 insertions(+), 4 deletions(-) diff --git a/src/wcmUSB.c b

Re: [Linuxwacom-devel] [RFC PATCH] Filter enhancements

2010-12-06 Thread Ping Cheng
On Sat, Dec 4, 2010 at 8:07 PM, Chris Bagwell ch...@cnpbagwell.com wrote: Storing sample change: Stop storing new X/Y values when no change.  High resolution pressure changes can come in without X/Y changes in greater counts then common-wcmRawSamples which can defeat averaging window and

Re: [Linuxwacom-devel] [PATCH] Use BTN_TOOL_FINGER for generic touch devices

2010-12-04 Thread Ping Cheng
, 2010 at 3:15 PM, Ping Cheng pingli...@gmail.com wrote: Chris, Does the patch below compatibility with your MT patchset or not? I guess Peter, and I, need your ack/nack to move on. Thank you. Ping On Mon, Nov 29, 2010 at 12:41 PM, Ping Cheng pingli...@gmail.com wrote: As discussed

Re: [Linuxwacom-devel] [PATCH] Use BTN_TOOL_FINGER for generic touch devices

2010-12-03 Thread Ping Cheng
Chris, Does the patch below compatibility with your MT patchset or not? I guess Peter, and I, need your ack/nack to move on. Thank you. Ping On Mon, Nov 29, 2010 at 12:41 PM, Ping Cheng pingli...@gmail.com wrote: As discussed at linux-input, BTN_TOOL_FINGER should be used to report single

Re: [Linuxwacom-devel] Kernel driver package supporting xf86-input-wacom has been posted

2010-12-02 Thread Ping Cheng
on an older kernel and provides feedback here. In an idea world, users, who run an distro provided OS, should report driver issues to the distributor. Ping On Wed, Dec 1, 2010 at 6:55 PM, Ping Cheng pingli...@gmail.com wrote: input-wacom-0.10.10 is available for downloading at linuxwacom.sf.net

Re: [Linuxwacom-devel] Kernel driver package supporting xf86-input-wacom has been posted

2010-12-02 Thread Ping Cheng
On Thu, Dec 2, 2010 at 9:35 AM, Ping Cheng pingli...@gmail.com wrote: Hi team, Peter suggested that I should point out the kernel driver we packaged here is for backward support. Any new kernel driver feature and model support should happen at linux-input mailing list. Basically, my

Re: [Linuxwacom-devel] Support for multiple separate pens hotplug in new X driver with wip patch

2010-12-01 Thread Ping Cheng
On Tue, Nov 30, 2010 at 7:56 PM, Peter Hutterer peter.hutte...@who-t.net wrote: On Tue, Nov 30, 2010 at 07:41:01PM -0800, Ping Cheng wrote: On Tue, Nov 30, 2010 at 6:23 PM, Peter Hutterer peter.hutte...@who-t.net wrote: On Sun, Nov 28, 2010 at 03:43:04PM +0200, Alexia Death wrote: diff

Re: [Linuxwacom-devel] Support for multiple separate pens hotplug in new X driver with wip patch

2010-12-01 Thread Ping Cheng
On Wed, Dec 1, 2010 at 10:35 AM, Ping Cheng pingli...@gmail.com wrote: On Tue, Nov 30, 2010 at 7:56 PM, Peter Hutterer peter.hutte...@who-t.net wrote: On Tue, Nov 30, 2010 at 07:41:01PM -0800, Ping Cheng wrote: On Tue, Nov 30, 2010 at 6:23 PM, Peter Hutterer peter.hutte...@who-t.net wrote

Re: [Linuxwacom-devel] [PATCH] xsetwacom: assume xorg.conf format for get all

2010-12-01 Thread Ping Cheng
peter.hutte...@who-t.net Acked-by: Ping Cheng pingli...@gmail.com Ping ---  tools/xsetwacom.c |    3 +++  1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/tools/xsetwacom.c b/tools/xsetwacom.c index afacee0..933e03b 100644 --- a/tools/xsetwacom.c +++ b/tools/xsetwacom.c @@ -2078,6

Re: [Linuxwacom-devel] [PATCH 2/6] Remove display toggle switch.

2010-12-01 Thread Ping Cheng
On Tue, Nov 30, 2010 at 8:25 PM, Peter Hutterer peter.hutte...@who-t.net wrote: On Tue, Nov 30, 2010 at 10:17:11AM -0800, Ping Cheng wrote: Let's not have any multi-monitor handling in the driver, push it to the clients to handle this. We can push the creation of display area to the client

Re: [Linuxwacom-devel] [PATCH] xsetwacom: fix buffer overflow when printing button configurations.

2010-12-01 Thread Ping Cheng
peter.hutte...@who-t.net Acked-by: Ping Cheng pingli...@gmail.com Ping ---  tools/xsetwacom.c |    2 +-  1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tools/xsetwacom.c b/tools/xsetwacom.c index 933e03b..7f48eb8 100644 --- a/tools/xsetwacom.c +++ b/tools/xsetwacom.c @@ -1882,7

[Linuxwacom-devel] [PATCH v2] Don't normalize the abswheel unless it's from an airbrush

2010-11-30 Thread Ping Cheng
Due to the limitation of number of valators we can use, Airbrush wheel and Art Pen rotation share the same fifth valuator. But they do not have the same range of values. So, we normalize the airbrush wheel (0, 1023) to the Art Pen rotation (-900, 899). Signed-off-by: Ping Cheng pingli

Re: [Linuxwacom-devel] Support for multiple separate pens hotplug in new X driver with wip patch

2010-11-30 Thread Ping Cheng
On Tue, Nov 30, 2010 at 6:23 PM, Peter Hutterer peter.hutte...@who-t.net wrote: On Sun, Nov 28, 2010 at 03:43:04PM +0200, Alexia Death wrote: diff --git a/tools/xsetwacom.c b/tools/xsetwacom.c index 84dd188..be5a662 100644 --- a/tools/xsetwacom.c +++ b/tools/xsetwacom.c @@ -571,7 +571,7 @@

[Linuxwacom-devel] [PATCH] Use BTN_TOOL_FINGER for generic touch devices

2010-11-29 Thread Ping Cheng
As discussed at linux-input, BTN_TOOL_FINGER should be used to report single touch events. Update tool type and event process accordingly. Signed-off-by: Ping Cheng pingli...@gmail.com --- src/wcmUSB.c| 32 src/wcmValidateDevice.c | 18

Re: [Linuxwacom-devel] [PATCH] Let PROTOCOL_GENERIC take care of future devices

2010-11-27 Thread Ping Cheng
Cheng pingli...@gmail.com wrote: Kernel input driver does not allow a specific tool type for pad tool. We are forced to move all devices to PROTOCOL_GENERIC in the kernel. Let's plan for the change so the code will cover all affected devices instead of just Bamboos. Signed-off-by: Ping Cheng

Re: [Linuxwacom-devel] [PATCH] Print the type_name for debug messages.

2010-11-25 Thread Ping Cheng
On Wed, Nov 24, 2010 at 9:37 PM, Peter Hutterer peter.hutte...@who-t.net wrote: Instead of a quadruple-nested ternary operator, just print the type_name. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Acked-by: Ping Cheng pingli...@gmail.com Ping ---  src/wcmCommon.c |    5

Re: [Linuxwacom-devel] [PATCH] Print debug level for DBG statement.

2010-11-25 Thread Ping Cheng
On Wed, Nov 24, 2010 at 9:28 PM, Peter Hutterer peter.hutte...@who-t.net wrote: Seeing which message is printed for which level makes it a lot easier to pick a debug level to narrow down on the data that's interesting. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Acked-by: Ping

Re: [Linuxwacom-devel] [PATCH] Update new device types

2010-11-25 Thread Ping Cheng
On Tue, Nov 23, 2010 at 9:31 PM, Peter Hutterer peter.hutte...@who-t.net wrote: On Tue, Nov 23, 2010 at 11:03:18PM -0600, Chris Bagwell wrote: On Tue, Nov 23, 2010 at 10:06 PM, Peter Hutterer peter.hutte...@who-t.net wrote: On Tue, Nov 23, 2010 at 05:30:21PM -0800, Ping Cheng wrote: Added

[Linuxwacom-devel] [PATCH] Normalized the wrong wheel

2010-11-25 Thread Ping Cheng
We wanted to normalize Intuos4 stylus wheel. But I did it on the pad ring instead. Signed-off-by: Ping Cheng pingli...@gmail.com --- src/wcmUSB.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/wcmUSB.c b/src/wcmUSB.c index 51161f0..9305985 100644 --- a/src

Re: [Linuxwacom-devel] [PATCH] Don't allow the deletion of active button action properties.

2010-11-23 Thread Ping Cheng
...@who-t.net Acked-by: Ping Cheng pingli...@gmail.com Ping ---  src/wcmXCommand.c |   21 +  src/xf86Wacom.c   |    2 +-  src/xf86Wacom.h   |    1 +  3 files changed, 23 insertions(+), 1 deletions(-) diff --git a/src/wcmXCommand.c b/src/wcmXCommand.c index b197a62

[Linuxwacom-devel] [PATCH] Skip area check for pad tool

2010-11-23 Thread Ping Cheng
Since Pad tool does not emit motion events, there is no area defined for pad. Skip those steps in commonDispatchDevice. Signed-off: Ping Cheng pingli...@gmail.com --- src/wcmCommon.c |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/src/wcmCommon.c b/src/wcmCommon.c

Re: [Linuxwacom-devel] [PATCH] Skip area check for pad tool

2010-11-23 Thread Ping Cheng
On Tue, Nov 23, 2010 at 3:22 PM, Peter Hutterer peter.hutte...@who-t.net wrote: On Tue, Nov 23, 2010 at 02:29:59PM -0800, Ping Cheng wrote: Since Pad tool does not emit motion events, there is no area defined for pad. Skip those steps in commonDispatchDevice. Signed-off: Ping Cheng pingli

Re: [Linuxwacom-devel] [PATCH 1/4] Set maximum tool button count to correct values

2010-11-21 Thread Ping Cheng
Acked-by: Ping Cheng pingli...@gmail.com for the whole set of 4. Thank you Chris. Ping On Sun, Nov 21, 2010 at 4:13 PM, ch...@cnpbagwell.com wrote: From: Chris Bagwell ch...@cnpbagwell.com The code to set nbuttons for non-pad buttons was checking for a lot of buttons that no current wacom

Re: [Linuxwacom-devel] xf86-input-wacom: wcmValidateDevice.c-add-3-new-bambooPT-models

2010-11-21 Thread Ping Cheng
Acked-by: Ping Cheng pingli...@gmail.com Thank you both, IRIE and Dave. Ping On Sun, Nov 21, 2010 at 7:23 PM, Favux ... favux...@gmail.com wrote: This patch addresses the issue reported by IRIE Shinsuke in Support Requests (tracker ID: 3104500) in his 11-19-10 post.  It prevents the Xorg.0

Re: [Linuxwacom-devel] [PATCH] Use single filter routine for all tools.

2010-11-19 Thread Ping Cheng
On Fri, Nov 19, 2010 at 6:16 AM, Chris Bagwell ch...@cnpbagwell.com wrote: On Thu, Nov 18, 2010 at 10:20 PM,  ch...@cnpbagwell.com wrote: From: Chris Bagwell ch...@cnpbagwell.com -#define DEFINE_MODEL(mname, identifier, protocol, filter) \ +#define DEFINE_MODEL(mname, identifier, protocol) \

Re: [Linuxwacom-devel] [PATCH] Remove BTN_TOOL_FINGER from wcmUSB.c

2010-11-19 Thread Ping Cheng
On Fri, Nov 19, 2010 at 6:18 AM, Chris Bagwell ch...@cnpbagwell.com wrote: On Thu, Nov 18, 2010 at 9:36 PM, Chris Bagwell ch...@cnpbagwell.com wrote: On Thu, Nov 18, 2010 at 3:51 PM, Ping Cheng pingli...@gmail.com wrote: Since it is no longer used for pad, update the comments and code too

Re: [Linuxwacom-devel] [PATCH] Use single filter routine for all tools.

2010-11-19 Thread Ping Cheng
On Fri, Nov 19, 2010 at 1:46 PM, Chris Bagwell ch...@cnpbagwell.com wrote: On Fri, Nov 19, 2010 at 10:53 AM, Ping Cheng pingli...@gmail.com wrote: On Fri, Nov 19, 2010 at 6:16 AM, Chris Bagwell ch...@cnpbagwell.com wrote: On Thu, Nov 18, 2010 at 10:20 PM,  ch...@cnpbagwell.com wrote: From

[Linuxwacom-devel] [PATCH] Remove BTN_TOOL_FINGER from wcmUSB.c

2010-11-18 Thread Ping Cheng
Since it is no longer used for pad, update the comments and code too. Signed-off-by: Ping Cheng pingli...@gmail.com --- src/wcmUSB.c | 19 --- 1 files changed, 8 insertions(+), 11 deletions(-) diff --git a/src/wcmUSB.c b/src/wcmUSB.c index 76d3d10..3d8accf 100644 --- a/src

[Linuxwacom-devel] [PATCH] Add WCM_PAD as a tablet feature

2010-11-18 Thread Ping Cheng
Not all tablets have tablet buttons. Add WAC_PAD so TabletHasFeature can tell us if the tablet has pad tool or not. Signed-off-by: Ping Cheng pingli...@gmail.com --- src/wcmValidateDevice.c |6 ++ src/xf86WacomDefs.h |1 + 2 files changed, 7 insertions(+), 0 deletions(-) diff

Re: [Linuxwacom-devel] [PATCH] xsetwacom: rename ClickForce to Threshold.

2010-11-18 Thread Ping Cheng
is the normalised threshold in a 0-2048 range and the data the device actually puts out. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Acked-by: Ping Cheng pingli...@gmail.com Thank you, Peter. Ping ---  tools/xsetwacom.c |    2 +-  1 files changed, 1 insertions(+), 1 deletions(-) diff

Re: [Linuxwacom-devel] [PATCH] BTN_TOOL_FINGER no longer a valid type for pad tool

2010-11-17 Thread Ping Cheng
On Tue, Nov 16, 2010 at 5:37 PM, Chris Bagwell ch...@cnpbagwell.com wrote: On Tue, Nov 16, 2010 at 7:35 PM, Chris Bagwell ch...@cnpbagwell.com wrote: This change is not super flexible design so maybe not worth it? I mean your patch works fine without this modification.  The change is only

[Linuxwacom-devel] [PATCH] Add 5 new devices

2010-11-17 Thread Ping Cheng
From: Ping Cheng pi...@wacom.com Added DTU2231, DTU1631, Intuos4 WL, and Cintiq 21UX2 tablets. Signed-off-by: Ping Cheng pingli...@gmail.com --- src/wcmUSB.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/src/wcmUSB.c b/src/wcmUSB.c index 98d3c05..76d3d10 100644

[Linuxwacom-devel] [PATCH] Do not initialize (x, y) valuators for pad tool

2010-11-16 Thread Ping Cheng
From: Ping Cheng pi...@wacom.com Pad tool does not emit motion events. Leave (x,y) alone. Other valuators, even the pressure, may be used by pad to pass raw data to clients. Signed-off-by: Ping Cheng pingli...@gmail.com --- src/xf86Wacom.c | 21 - 1 files changed, 12

[Linuxwacom-devel] [PATCH] BTN_TOOL_FINGER no longer a valid type for pad tool

2010-11-16 Thread Ping Cheng
From: Ping Cheng pi...@wacom.com They said using BTN_TOOL_FINGER is too confusing. But we still need to configure those tablet buttons and strips/ring. Let's detect the actual buttons we are going to receive to determine the existence of a pad tool. BTN_0 and BTN_FORWARD are the two unique BTN_s

Re: [Linuxwacom-devel] [PATCH 5/6] move storing of raw samples into wcmFilter filer

2010-11-15 Thread Ping Cheng
On Mon, Nov 15, 2010 at 6:47 AM, Chris Bagwell ch...@cnpbagwell.com wrote: On Sun, Nov 14, 2010 at 11:01 PM, Ping Cheng pingli...@gmail.com wrote: On Sun, Nov 14, 2010 at 9:08 AM,  ch...@cnpbagwell.com wrote: From: Chris Bagwell ch...@cnpbagwell.com This helps abstract out filtering

Re: [Linuxwacom-devel] [PATCH] Clarify comment for touchpad and tablet detection.

2010-11-15 Thread Ping Cheng
buttons work with the new driver. Since I don't have time to look into the code, I can not submit a patch yet For the comment change, Acked-by: Ping Cheng pingli...@gmail.com Thank you Chris, Ping -- Centralized Desktop

Re: [Linuxwacom-devel] [PATCH 5/6] move storing of raw samples into wcmFilter filer

2010-11-14 Thread Ping Cheng
flow difference because RawFilter() and wcmCheckSuppress() needs to be kept in wcmCommon.c, and so outside logic that stores samples, but intent is same results. Signed-off-by: Chris Bagwell ch...@cnpbagwell.com Reviewed-by: Ping Cheng pingli...@gmail.com Ping ---  src/wcmCommon.c |   81

<    1   2   3   4   5   6   7   8   >