[lng-odp] [PATCHv6 7/7] api: buffer: update documentation comments

2014-12-15 Thread Taras Kondratiuk
From: Bill Fischofer bill.fischo...@linaro.org Signed-off-by: Bill Fischofer bill.fischo...@linaro.org Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org --- platform/linux-generic/include/api/odp_buffer.h | 4 ++-- platform/linux-generic/include/api/odp_buffer_pool.h | 13

[lng-odp] [PATCHv6 6/7] api: buffer: add pool info query

2014-12-15 Thread Taras Kondratiuk
From: Bill Fischofer bill.fischo...@linaro.org Signed-off-by: Bill Fischofer bill.fischo...@linaro.org Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org --- .../linux-generic/include/api/odp_buffer_pool.h| 28 ++ platform/linux-generic/odp_buffer_pool.c

[lng-odp] [PATCHv6 3/7] api: buffer: move odp_buffer_pool to odp_buffer.h

2014-12-15 Thread Taras Kondratiuk
From: Bill Fischofer bill.fischo...@linaro.org Signed-off-by: Bill Fischofer bill.fischo...@linaro.org Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org --- platform/linux-generic/include/api/odp_buffer.h | 9 + platform/linux-generic/include/api/odp_buffer_pool.h | 10

[lng-odp] [PATCH] validation: crypto: remove data offset workaround

2014-12-13 Thread Taras Kondratiuk
this workaround. Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org --- This patch should be merged just after Bill's buffer/packet changes for v0.5. --- test/validation/crypto/odp_crypto_test_async_inp.c | 4 +--- test/validation/crypto/odp_crypto_test_sync_inp.c | 4 +--- 2 files

[lng-odp] ODP handles comparison

2014-12-12 Thread Taras Kondratiuk
that point to the same object (queue, pool, etc) can have generation number in it, so direct comparison will return false. Do we need to add corresponding comparison API for each handle type? Or we just say that any two handles of the same ODP object should be equal and == is enough? -- Taras

Re: [lng-odp] [PATCH] configure.ac check for atomic operations support

2014-12-12 Thread Taras Kondratiuk
On 12/12/2014 05:03 PM, Maxim Uvarov wrote: Odp atomic operations based on compiler build-ins. Make sure that compiler supports such operation at configure stage. This check should be limited to platforms that use gcc atomics. ___ lng-odp mailing

Re: [lng-odp] [PATCH] configure.ac check for atomic operations support

2014-12-12 Thread Taras Kondratiuk
On 12/12/2014 05:51 PM, Maxim Uvarov wrote: On 12/12/2014 06:47 PM, Taras Kondratiuk wrote: On 12/12/2014 05:03 PM, Maxim Uvarov wrote: Odp atomic operations based on compiler build-ins. Make sure that compiler supports such operation at configure stage. This check should be limited

[lng-odp] [PATCH 3/3] validation: buffer: add initial packet tests

2014-12-12 Thread Taras Kondratiuk
Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org --- test/validation/Makefile.am| 1 + test/validation/buffer/odp_buffer_testsuites.h | 4 + test/validation/buffer/odp_packet_test.c | 659 + test/validation/odp_buffer.c

[lng-odp] [PATCH 1/3] validation: buffer: add initial buffer pool tests

2014-12-12 Thread Taras Kondratiuk
Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org --- test/validation/.gitignore | 1 + test/validation/Makefile.am| 6 +- test/validation/buffer/odp_buffer_pool_test.c | 212 + test/validation/buffer

[lng-odp] [PATCH 0/3] validation: buffer: add initial tests

2014-12-12 Thread Taras Kondratiuk
Initial version of sunny day buffer pool, buffer and packet API tests. Based on Bill's buffer packets patches for v0.5. linux-generic doesn't support segmented packets in v0.5, so two tests are failing. Taras Kondratiuk (3): validation: buffer: add initial buffer pool tests validation

[lng-odp] [PATCH 0/3] validation: buffer: add initial tests

2014-12-12 Thread Taras Kondratiuk
tests 31 31 29 20 asserts238238236 2 n/a Taras Kondratiuk (3): validation: buffer: add initial buffer pool tests validation: buffer: add initial buffer tests validation: buffer: add initial packet tests test/validation/.gitignore

[lng-odp] [PATCH 2/3] validation: buffer: add initial buffer tests

2014-12-12 Thread Taras Kondratiuk
Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org --- test/validation/Makefile.am| 1 + test/validation/buffer/odp_buffer_test.c | 52 ++ test/validation/buffer/odp_buffer_testsuites.h | 4 ++ test/validation/odp_buffer.c

Re: [lng-odp] [PATCH 0/3] validation: buffer: add initial tests

2014-12-12 Thread Taras Kondratiuk
On 12/12/2014 06:38 PM, Taras Kondratiuk wrote: Initial version of sunny day buffer pool, buffer and packet API tests. Based on Bill's buffer packets patches for v0.5. linux-generic doesn't support segmented packets in v0.5, so two tests are failing. Ugh. This duplicated message is from

[lng-odp] [PATCH 0/3] linux-generic: crypto: fix validation tests failures

2014-12-12 Thread Taras Kondratiuk
Ran Passed Failed Inactive suites 3 3n/a 00 tests 12 12 12 00 asserts299299299 0 n/a Taras Kondratiuk (3): linux-generic: crypto: always make a copy of IV linux-generic: crypto

[lng-odp] [PATCH 1/3] linux-generic: crypto: always make a copy of IV

2014-12-12 Thread Taras Kondratiuk
DES library modifies IV buffer in-place. Current code handles this correctly only in case of encryption operation with session IV. To prevent user buffer modifications always make a copy of a provided IV. Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org --- platform/linux-generic

[lng-odp] [PATCH 2/3] linux-generic: crypto: implement completion event context

2014-12-12 Thread Taras Kondratiuk
Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org --- .../linux-generic/include/odp_crypto_internal.h| 1 + platform/linux-generic/odp_crypto.c| 28 +- 2 files changed, 23 insertions(+), 6 deletions(-) diff --git a/platform/linux-generic/include

Re: [lng-odp] [RFC v2 3/3] Update IPsec example app to use new completion event constructs

2014-12-11 Thread Taras Kondratiuk
On 12/11/2014 04:25 PM, Robbie King (robking) wrote: See [rk] below. -Original Message- From: Taras Kondratiuk [mailto:taras.kondrat...@linaro.org] Sent: Wednesday, December 10, 2014 7:12 PM To: Robbie King (robking); lng-odp@lists.linaro.org Subject: Re: [lng-odp] [RFC v2 3/3

Re: [lng-odp] [RFC v2 1/3] Add completion event updates to odp_crypto.h

2014-12-11 Thread Taras Kondratiuk
from odp_crypto_get_operation_compl_packet() in case of any error. If application is interested in cause of error it can then request a detailed errors status. -Original Message- From: Taras Kondratiuk [mailto:taras.kondrat...@linaro.org] Sent: Thursday, December 11, 2014 8:27 AM

Re: [lng-odp] [PATCHv4] Implement v0.5 buffer pool APIs

2014-12-11 Thread Taras Kondratiuk
On 12/11/2014 07:00 AM, Bill Fischofer wrote: +odp_buffer_pool_t odp_buffer_pool_create(const char *name, + odp_shm_t shm, + odp_buffer_pool_param_t *params) { - odp_buffer_chunk_hdr_t *chunk_hdr; - -

Re: [lng-odp] [PATCHv4] Implement v0.5 buffer pool APIs

2014-12-11 Thread Taras Kondratiuk
On 12/12/2014 12:10 AM, Bill Fischofer wrote: Packet pools support segmentation, however not in v0.5 because odp_packet_socket.c can't deal with segmented I/O so there is currently no way to Rx or Tx a segmented packet. This needs to be addressed prior to v1.0. This is the reason why

Re: [lng-odp] [RFC v2 1/3] Add completion event updates to odp_crypto.h

2014-12-10 Thread Taras Kondratiuk
don't need to pass any completion event on operation submit. Implementation already have all necessary information that need to be stored in a completion event. This gives freedom to implementation to handle completion event in an optimal way. -- Taras Kondratiuk

Re: [lng-odp] [RFC v2 3/3] Update IPsec example app to use new completion event constructs

2014-12-10 Thread Taras Kondratiuk
. -- Taras Kondratiuk ___ lng-odp mailing list lng-odp@lists.linaro.org http://lists.linaro.org/mailman/listinfo/lng-odp

Re: [lng-odp] [RFC v2 0/3] Proposed crypto completion event implementation

2014-12-10 Thread Taras Kondratiuk
describe what advantage does it have over my RFC? As per my understanding they both try to abstracts completion event handling in a portable way. But this one is more complex and it seems to have higher overhead on both implementation and application sides. -- Taras Kondratiuk

Re: [lng-odp] RFC linux-dpdk support for DPDK 1.7.0

2014-12-09 Thread Taras Kondratiuk
On 12/09/2014 03:02 PM, Venkatesh Vivekanandan wrote: Hi All, DPDK changed its way of loading the driver from 1.7.0. We can support this change in ODP in two ways. 1. Wrap intel_dpdk archive with --whole-archive/--no-whole-archive in all odp applications OR 2. Compile DPDK with shared

Re: [lng-odp] [RFC] api: crypto: Move completion event allocation to implementation

2014-12-08 Thread Taras Kondratiuk
On 12/08/2014 10:58 AM, Alexandru Badicioiu wrote: Some comments inline. Alex On 5 December 2014 at 17:45, Taras Kondratiuk taras.kondrat...@linaro.org mailto:taras.kondrat...@linaro.org wrote: On 12/05/2014 04:16 PM, Alexandru Badicioiu wrote: Hi , what this patch wants

Re: [lng-odp] [RFC] api: crypto: Move completion event allocation to implementation

2014-12-08 Thread Taras Kondratiuk
On 12/08/2014 01:30 PM, Bala wrote: On Friday 05 December 2014 10:16 PM, Taras Kondratiuk wrote: On 12/05/2014 04:38 PM, Bala Manoharan wrote: Hi, In case of synchronous crypto operation the completion event is need only in case of an error hence the application can check the return code

Re: [lng-odp] [PATCH] api: move internal debug macros

2014-12-05 Thread Taras Kondratiuk
On 12/05/2014 09:25 AM, Maxim Uvarov wrote: Merged, Maxim. Guys you are too quick in merging this. Most of us even didn't have a chance to look at some of patches merged tonight. On 12/05/2014 01:12 AM, Bill Fischofer wrote: On Thu, Dec 4, 2014 at 4:08 PM, Mike Holmes

Re: [lng-odp] [PATCH] api: odp_align: move internal macros

2014-12-05 Thread Taras Kondratiuk
On 12/04/2014 10:25 PM, Mike Holmes wrote: @@ -138,12 +114,6 @@ extern C { #define ODP_ALIGN_ROUNDDOWN_PTR_POWER_2(x, align)\ ((void *)ODP_ALIGN_ROUNDDOWN_POWER_2((uintptr_t)(x), (uintptr_t)(align))) Only part of internal macros were moved. For example why ODP_ALIGN_ROUNDDOWN_PTR_POWER_2()

Re: [lng-odp] [PATCH] api: move internal debug macros

2014-12-05 Thread Taras Kondratiuk
On 12/05/2014 05:07 PM, Mike Holmes wrote: They were not part of the the API Doc https://docs.google.com/a/linaro.org/document/d/1BRVyW8IIVMTq4nhB_vUz5y-te6TEdu5g1XgolujjY6c/edit#heading=h.98203k4q66lm, happy to do more if approved by Petri Ok I've added also ODP_ASSERT to the document.

Re: [lng-odp] [RFC] api: crypto: Move completion event allocation to implementation

2014-12-05 Thread Taras Kondratiuk
On 12/05/2014 04:38 PM, Bala Manoharan wrote: Hi, In case of synchronous crypto operation the completion event is need only in case of an error hence the application can check the return code for failure and get info from completion event buffer only during that scenario. This will

Re: [lng-odp] [PATCHv2 1/5] validation: shm: move main() to a common place

2014-12-04 Thread Taras Kondratiuk
On 12/03/2014 03:45 PM, Stuart Haslam wrote: On Wed, Dec 03, 2014 at 09:22:17AM +, Taras Kondratiuk wrote: Most of test application will have the same main function. Move main() from odp_shm to a common place where it can be reused by other test applications. Unifying main() will also

Re: [lng-odp] [PATCHv2 0/5] validation: harmonize test applications

2014-12-04 Thread Taras Kondratiuk
On 12/03/2014 09:44 PM, Mike Holmes wrote: I also can add reviewed by with the exception of the 77 issue in main. Maxim for expediency could you alter main to test for non zero and return -1 as you pull the series in ? Taras are you ok with that ? As I've just replied to Stuart, that is an

[lng-odp] [PATCH] validation: common: fix application exit status

2014-12-04 Thread Taras Kondratiuk
An exit status of 77 from a test application will denote a skipped test for automake. So if exactly 77 failed we'd get a wrong result. Just return -1 if any failure detected. Reported-by: Stuart Haslam stuart.has...@arm.com Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org --- Automake

Re: [lng-odp] [PATCHv2 3/5] validation: queue: reuse common main() function

2014-12-04 Thread Taras Kondratiuk
On 12/03/2014 03:35 PM, Taras Kondratiuk wrote: Mike, Yan, Could you please review this patch, to get the series merged? This series needs rebase again, because another test change was just merged. ping ___ lng-odp mailing list lng-odp

Re: [lng-odp] [PATCHv4 1/2] platform: debug: replace fprintf() with odp_override_log()

2014-12-03 Thread Taras Kondratiuk
On 12/02/2014 08:35 PM, Mike Holmes wrote: - * ODP default LOG macro. + * ODP log function + * + * Instead of direct prints to stdout/stderr all logging in ODP implementation + * should be done via this function or its wrappers. + * ODP platform MUST provide a

Re: [lng-odp] [PATCHv4 2/2] platform: debug: Simplify ODP_LOG() macro

2014-12-03 Thread Taras Kondratiuk
On 12/02/2014 07:50 PM, Zoltan Kiss wrote: On 02/12/14 17:07, Taras Kondratiuk wrote: On 12/02/2014 06:42 PM, Zoltan Kiss wrote: Hi, At the moment, the careless developer look at enum odp_log_level and starts using ODP_LOG(ODP_LOG_DBG, ...) instead of ODP_DBG. I think it would be good

Re: [lng-odp] [PATCH 3/5] validation: queue: reuse common main() function

2014-12-03 Thread Taras Kondratiuk
On 12/02/2014 09:08 PM, Mike Holmes wrote: On 1 December 2014 at 12:05, Taras Kondratiuk taras.kondrat...@linaro.org mailto:taras.kondrat...@linaro.org wrote: +CU_SuiteInfo odp_testsuites[] = { + {Queue, init_suite, NULL, NULL, NULL, test_odp_queue}, No need to have init_suite

[lng-odp] [PATCHv2 4/5] validation: crypto: reuse common main() function

2014-12-03 Thread Taras Kondratiuk
Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org Reviewed-by: Mike Holmes mike.hol...@linaro.org --- test/validation/Makefile.am |2 +- test/validation/odp_crypto.c | 43 ++ 2 files changed, 7 insertions(+), 38 deletions(-) diff --git

[lng-odp] [PATCHv2 3/5] validation: queue: reuse common main() function

2014-12-03 Thread Taras Kondratiuk
Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org --- test/validation/Makefile.am |2 +- test/validation/odp_queue.c | 64 +++ 2 files changed, 11 insertions(+), 55 deletions(-) diff --git a/test/validation/Makefile.am b/test/validation

Re: [lng-odp] [PATCHv2 1/3] ODP buffer pool restructure

2014-12-03 Thread Taras Kondratiuk
On 12/03/2014 01:07 PM, Anders Roxell wrote: Hi, This is the proposed way to break up your patch: 1. break circular dependencies 2. move inline functions to a new odp_buffer_inlines.h file. 3. restructuring ODP buffer pool 4. odp_buffer_pool_create 5. odp_buffer_pool_destroy 6.

Re: [lng-odp] [PATCHv4 2/2] platform: debug: Simplify ODP_LOG() macro

2014-12-03 Thread Taras Kondratiuk
On 12/03/2014 04:15 PM, Zoltan Kiss wrote: On 03/12/14 08:41, Taras Kondratiuk wrote: On 12/02/2014 07:50 PM, Zoltan Kiss wrote: And this problem applies to ODP_LOG_ABORT as well: ODP_ABORT will call abort(), while ODP_LOG(ODP_LOG_ABORT, ...) doesn't. I think you can just drop the wholw

[lng-odp] [PATCHv5 1/2] platform: debug: replace fprintf() with odp_override_log()

2014-12-03 Thread Taras Kondratiuk
ODP application may want to override default ODP logging behaviour and use custom logging function. Add a weak odp_override_log() function for this purpose instead of default fprintf(). Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org --- platform/linux-generic/Makefile.am

[lng-odp] [PATCHv5 2/2] platform: debug: Simplify ODP_LOG() macro

2014-12-03 Thread Taras Kondratiuk
Move additional functionality out of ODP_LOG. Keep only logging. Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org --- platform/linux-generic/include/api/odp_debug.h | 43 +--- .../linux-generic/include/odp_debug_internal.h |6 ++- 2 files changed, 15

[lng-odp] [PATCHv5 0/2] Add a way to override default ODP_LOG behavior

2014-12-03 Thread Taras Kondratiuk
in ODP_UNIMPLEMENTED() macro. Taras Kondratiuk (2): platform: debug: replace fprintf() with odp_override_log() platform: debug: Simplify ODP_LOG() macro platform/linux-generic/Makefile.am |3 +- platform/linux-generic/include/api/odp_debug.h | 75

Re: [lng-odp] [PATCH 1/5] validation: shm: move main() to a common place

2014-12-02 Thread Taras Kondratiuk
On 12/01/2014 08:52 PM, Mike Holmes wrote: On 1 December 2014 at 12:05, Taras Kondratiuk taras.kondrat...@linaro.org mailto:taras.kondrat...@linaro.org wrote: + +int main(void) +{ + int ret; + + printf(\tODP API version: %s\n, odp_version_api_str

[lng-odp] [PATCHv4 2/2] platform: debug: Simplify ODP_LOG() macro

2014-12-02 Thread Taras Kondratiuk
Move additional functionality out of ODP_LOG. Keep only logging. Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org --- platform/linux-generic/include/api/odp_debug.h | 43 +--- .../linux-generic/include/odp_debug_internal.h |6 ++- 2 files changed, 15

[lng-odp] [PATCHv2 2/2] platform: implement odp_queue_destroy()

2014-12-02 Thread Taras Kondratiuk
Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org --- .../linux-generic/include/odp_queue_internal.h | 23 +-- platform/linux-generic/odp_queue.c | 72 +++- platform/linux-generic/odp_schedule.c |3 +- 3 files changed, 92

Re: [lng-odp] [PATCHv4 2/2] platform: debug: Simplify ODP_LOG() macro

2014-12-02 Thread Taras Kondratiuk
On 12/02/2014 06:42 PM, Zoltan Kiss wrote: Hi, At the moment, the careless developer look at enum odp_log_level and starts using ODP_LOG(ODP_LOG_DBG, ...) instead of ODP_DBG. I think it would be good to provide either ODP_LOG(loglevel, ...) or ODP_[loglevel](...), but not both. These are

Re: [lng-odp] [PATCH] ODP buffer pool restructure for v1.0 APIs

2014-12-02 Thread Taras Kondratiuk
On 12/01/2014 03:47 AM, Bill Fischofer wrote: +int odp_buffer_pool_destroy(odp_buffer_pool_t pool_hdl) +{ + uint32_t pool_id = pool_handle_to_index(pool_hdl); + pool_entry_t *pool = get_pool_entry(pool_id); - if (chunk-chunk.num_bufs == 0) { - /* give the chunk

Re: [lng-odp] [PATCH v6] cunit: add shm test

2014-12-01 Thread Taras Kondratiuk
function */ +extern int odp_cunit_thread_create(void *func_ptr(void *), pthrd_arg *arg); +extern int odp_cunit_thread_exit(pthrd_arg *); + +#endif /* ODP_COMMON_H */ You have missed a nit from Jerin. s/ODP_COMMON_H/ODP_CUNICT_COMMON_H/ Maybe Maxim can fix it. Rewieved-by: Taras Kondratiuk taras.kondrat

Re: [lng-odp] [PATCH v1] validation: queue: use CU_register_suites() for tests registration

2014-12-01 Thread Taras Kondratiuk
On 12/01/2014 01:58 PM, Maxim Uvarov wrote: Taras, I think you need to send your patch without RFC. Yan, please provide your reviewed-by to Taras patch series. It is RFC, because depends in Yan's shm test patch in-flight. I'll repost it after Yan's patch is merged.

Re: [lng-odp] [PATCH] linux-generic: fix queue handle check in odp_pktio_inq_setdef

2014-12-01 Thread Taras Kondratiuk
On 11/27/2014 11:39 AM, Stuart Haslam wrote: queue_to_qentry doesn't do any validation of the queue handle so will never return NULL and ends up returning an invalid pointer if passed ODP_QUEUE_INVALID. Reviewed-by: Taras Kondratiuk taras.kondrat...@linaro.org

Re: [lng-odp] [PATCH] linux-generic: fix sockfd store and lookup errors

2014-12-01 Thread Taras Kondratiuk
the sequence open-close-open for a single interface results in a stale descriptor Reviewed-by: Taras Kondratiuk taras.kondrat...@linaro.org Wouldn't it be simpler to add refcounting at pktio level and just return the same handle to all threads on odp_pktio_open()? What is the advantage of having

[lng-odp] [PATCH 1/5] validation: shm: move main() to a common place

2014-12-01 Thread Taras Kondratiuk
Most of test application will have the same main function. Move main() from odp_shm to a common place where it can be reused by other test applications. Unifying main() will also simplify transition to a combined single test application in future. Signed-off-by: Taras Kondratiuk taras.kondrat

[lng-odp] [PATCH 0/5] validation: harmonize test applications

2014-12-01 Thread Taras Kondratiuk
Avoid duplicating the same code by using a common main() function in most of test applications. Taras Kondratiuk (5): validation: shm: move main() to a common place validation: common: add tests_global_init() function validation: queue: reuse common main() function validation: crypto

[lng-odp] [PATCH 3/5] validation: queue: reuse common main() function

2014-12-01 Thread Taras Kondratiuk
Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org --- test/validation/Makefile.am |2 +- test/validation/odp_queue.c | 53 --- 2 files changed, 10 insertions(+), 45 deletions(-) diff --git a/test/validation/Makefile.am b/test/validation

[lng-odp] [PATCH 4/5] validation: crypto: reuse common main() function

2014-12-01 Thread Taras Kondratiuk
Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org --- test/validation/Makefile.am |2 +- test/validation/odp_crypto.c | 43 ++ 2 files changed, 7 insertions(+), 38 deletions(-) diff --git a/test/validation/Makefile.am b/test/validation

Re: [lng-odp] [PATCH 1/2] api: queue: add odp_queue_destroy()

2014-11-28 Thread Taras Kondratiuk
On 11/28/2014 06:37 AM, Bill Fischofer wrote: You cannot gracefully destroy a queue without some sort of quiesce function that prohibits further enqueues to the queue while allowing items on the queue to be dequeued until the queue is empty. To position for this, I'd include a check that

Re: [lng-odp] [PATCH 1/5] implement odp_bool type

2014-11-28 Thread Taras Kondratiuk
On 11/27/2014 07:38 PM, Bill Fischofer wrote: I agree. This type is supposed to be just documentation so typedef int odp_bool_t; is simplest and best. Won't enum be more clear? {ODP_FALSE, ODP_TRUE} ___ lng-odp mailing list

Re: [lng-odp] [PATCH v5] cunit: add shm test

2014-11-28 Thread Taras Kondratiuk
On 11/28/2014 05:03 AM, Yan Sonming wrote: Add odp_cunit_common.c for common cunit function and add the cunit test for the api in odp_share_memory.h which include the new api implement odp_shm_free Signed-off-by: Yan Songming yan.songm...@linaro.org --- v5 fix the problem which Jerin and Taras

Re: [lng-odp] [PATCH] linux-generic: pktio: abort on enq to pktin or deq from pktout

2014-11-28 Thread Taras Kondratiuk
On 11/28/2014 01:47 PM, Stuart Haslam wrote: On Fri, Nov 28, 2014 at 09:48:29AM +, Alexandru Badicioiu wrote: On 27 November 2014 at 18:56, Stuart Haslam stuart.has...@arm.commailto:stuart.has...@arm.com wrote: Attempts to enq to a pktin queue or deq from a pktout queue are programming

[lng-odp] [RFC 0/5] validation: harmonize test application

2014-11-28 Thread Taras Kondratiuk
Avoid duplicating the same code by using a common main() function in most of test applications. Series is based on top of Yan's shm test patch [1]. [1] http://lists.linaro.org/pipermail/lng-odp/2014-November/005580.html Taras Kondratiuk (5): validation: shm: move main() to a common place

[lng-odp] [RFC 4/5] validation: crypto: reuse common main() function

2014-11-28 Thread Taras Kondratiuk
Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org --- test/validation/Makefile.am |2 +- test/validation/odp_crypto.c | 43 ++ 2 files changed, 7 insertions(+), 38 deletions(-) diff --git a/test/validation/Makefile.am b/test/validation

Re: [lng-odp] [PATCH 1/2] api: queue: add odp_queue_destroy()

2014-11-27 Thread Taras Kondratiuk
On 11/26/2014 07:11 PM, Mike Holmes wrote: On 26 November 2014 at 12:03, Taras Kondratiuk taras.kondrat...@linaro.org mailto:taras.kondrat...@linaro.org wrote: Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org mailto:taras.kondrat...@linaro.org --- platform

Re: [lng-odp] [PATCH ARCH] api_guide_lines: Internal functions

2014-11-27 Thread Taras Kondratiuk
. -- Taras Kondratiuk ___ lng-odp mailing list lng-odp@lists.linaro.org http://lists.linaro.org/mailman/listinfo/lng-odp

[lng-odp] [PATCHv3 0/2] Add a way to override default ODP_LOG behavior

2014-11-27 Thread Taras Kondratiuk
This series adds a default weak odp_override_log() function which can be replaced by application. v3: Rebased and fixed conflicts with merged patches. v2: Fixed missed comma in ODP_UNIMPLEMENTED() macro. Taras Kondratiuk (2): platform: debug: replace fprintf() with odp_override_log

[lng-odp] [PATCHv3 2/2] platform: debug: Simplify ODP_LOG() macro

2014-11-27 Thread Taras Kondratiuk
Move additional functionality out of ODP_LOG. Move abort() call to odp_override_log(), so application will be able to implement custom abort handling. Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org --- platform/linux-generic/include/api/odp_debug.h | 38

Re: [lng-odp] [PATCH 2/2] platform: implement odp_queue_destroy()

2014-11-27 Thread Taras Kondratiuk
On 11/27/2014 05:57 PM, Ciprian Barbu wrote: On Thu, Nov 27, 2014 at 5:49 PM, Ciprian Barbu ciprian.ba...@linaro.org wrote: On Wed, Nov 26, 2014 at 7:03 PM, Taras Kondratiuk taras.kondrat...@linaro.org wrote: Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org --- platform/linux

Re: [lng-odp] [PATCH] netdev-odp: Use VLOG_ERR instead of ODP_ERR

2014-11-26 Thread Taras Kondratiuk
On 11/25/2014 06:54 PM, Mike Holmes wrote: Taras is submitting a patch that allows you to replace the output stream for ODP_ERR etc with the applications prefered stream - see https://mail.google.com/mail/u/1/#inbox/149e780e4e57d70c Taking into account that ODP_ERR() is not a part of public

Re: [lng-odp] [PATCH] DEPENDENCIES: Update CUnit instructions

2014-11-26 Thread Taras Kondratiuk
On 11/26/2014 12:08 AM, Mike Holmes wrote: Signed-off-by: Mike Holmes mike.hol...@linaro.org --- DEPENDENCIES | 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/DEPENDENCIES b/DEPENDENCIES index f70a1d4..11452ff 100644 --- a/DEPENDENCIES +++ b/DEPENDENCIES

Re: [lng-odp] [PATCH] netdev-odp: Use VLOG_ERR instead of ODP_ERR

2014-11-26 Thread Taras Kondratiuk
On 11/26/2014 02:54 PM, Zoltan Kiss wrote: But independent from this, OVS should overwrite the log function, right? So ODP internal log messages won't be lost. Right. I assume it should direct log messages into its own logging subsystem. ___ lng-odp

Re: [lng-odp] [PATCH 2/2] linux-generic: odp_pktio_open loop0 support

2014-11-26 Thread Taras Kondratiuk
On 11/26/2014 03:23 PM, Jerin Jacob wrote: On Wed, Nov 26, 2014 at 02:53:50PM +0300, Maxim Uvarov wrote: On 11/26/2014 12:25 PM, Ola Liljedahl wrote: On 26 November 2014 at 09:39, Alexandru Badicioiu alexandru.badici...@linaro.org wrote: This patch has no description. The title is not self

Re: [lng-odp] [PATCH 2/2] linux-generic: odp_pktio_open loop0 support

2014-11-26 Thread Taras Kondratiuk
On 11/26/2014 04:05 PM, Maxim Uvarov wrote: On 11/26/2014 04:33 PM, Taras Kondratiuk wrote: On 11/26/2014 03:23 PM, Jerin Jacob wrote: On Wed, Nov 26, 2014 at 02:53:50PM +0300, Maxim Uvarov wrote: On 11/26/2014 12:25 PM, Ola Liljedahl wrote: On 26 November 2014 at 09:39, Alexandru Badicioiu

[lng-odp] [PATCH 2/2] platform: implement odp_queue_destroy()

2014-11-26 Thread Taras Kondratiuk
Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org --- platform/linux-generic/odp_queue.c | 17 + 1 file changed, 17 insertions(+) diff --git a/platform/linux-generic/odp_queue.c b/platform/linux-generic/odp_queue.c index 1318bcd..f44aba0 100644 --- a/platform/linux

[lng-odp] [PATCH 1/2] api: queue: add odp_queue_destroy()

2014-11-26 Thread Taras Kondratiuk
Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org --- platform/linux-generic/include/api/odp_queue.h |9 + 1 file changed, 9 insertions(+) diff --git a/platform/linux-generic/include/api/odp_queue.h b/platform/linux-generic/include/api/odp_queue.h index b8ac4bb..3321950

Re: [lng-odp] [PATCH v2] test: Display implementation version

2014-11-25 Thread Taras Kondratiuk
On 11/24/2014 10:11 PM, Mike Holmes wrote: Signed-off-by: Mike Holmes mike.hol...@linaro.org --- test/validation/odp_crypto.c | 11 +-- test/validation/odp_init.c | 7 --- test/validation/odp_queue.c | 7 +-- 3 files changed, 18 insertions(+), 7 deletions(-) diff --git

Re: [lng-odp] odp_pktio_open(NULL) return default pktio for platform

2014-11-25 Thread Taras Kondratiuk
On 11/25/2014 02:19 PM, Alexandru Badicioiu wrote: I guess any Ethernet interface can be configured to work in loopback mode ( at least with SDK provided tools/functions). Loopback interface applied to HW is confusing - usually loopback is software only; how a HW packet classifier would be

Re: [lng-odp] [PATCH] .gitignore: add CUnit-Memory-Dump.xml

2014-11-25 Thread Taras Kondratiuk
On 11/25/2014 02:43 PM, Mike Holmes wrote: On 25 November 2014 at 07:15, Maxim Uvarov maxim.uva...@linaro.org mailto:maxim.uva...@linaro.org wrote: On 11/25/2014 01:18 AM, Mike Holmes wrote: Does no one else see this ? Files are in the same directory where you run the test.

Re: [lng-odp] [PATCH v0] crypto : cunit test suite for rng

2014-11-25 Thread Taras Kondratiuk
On 11/25/2014 12:21 PM, Alexandru Badicioiu wrote: + +/* + * This test verifies that HW random number generator is able + * to produce an IV for TDES_CBC cipher algorithm. + * */ +#define RNG_GET_SIZE RNG_GET_SIZE +static void rng_get_size(void) +{

Re: [lng-odp] odp_pktio_open(NULL) return default pktio for platform

2014-11-25 Thread Taras Kondratiuk
On 11/25/2014 03:06 PM, Bala Manoharan wrote: Yes. But for testing the basic pktio APIs which I believe is Maxim's requirement it can be done using loopback interface (configuring a HW interface as loop is an implementation detail) so that there is no need for any HW configuration as such while

Re: [lng-odp] odp_pktio_open(NULL) return default pktio for platform

2014-11-25 Thread Taras Kondratiuk
On 11/25/2014 03:30 PM, Alexandru Badicioiu wrote: What is a self-contained application? An application which uses only ODP calls? I mean an application that doesn't need any external equipment. Regarding the classification tests and loopbacks, why there's a need for a special kind of ODP

Re: [lng-odp] [PATCH 2/2] platform: debug: Simplify ODP_LOG() macro

2014-11-25 Thread Taras Kondratiuk
On 11/24/2014 02:05 PM, Maxim Uvarov wrote: Do weak symbols work also for dynamic linking? It does work for dynamic libraries also. I've found an issue in ODP_UNIMPLEMENTED() macro. Will post v2. ___ lng-odp mailing list lng-odp@lists.linaro.org

[lng-odp] [PATCHv2 2/2] platform: debug: Simplify ODP_LOG() macro

2014-11-25 Thread Taras Kondratiuk
Move additional functionality out of ODP_LOG. Move abort() call to odp_override_log(), so application will be able to implement custom abort handling. Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org --- platform/linux-generic/include/api/odp_debug.h | 37

[lng-odp] [PATCHv2 1/2] platform: debug: replace fprintf() with odp_override_log()

2014-11-25 Thread Taras Kondratiuk
ODP application may want to override default ODP logging behaviour and use custom logging function. Add a weak odp_override_log() function for this purpose instead of default fprintf(). Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org --- platform/linux-generic/Makefile.am

Re: [lng-odp] [RFC PATCH 1/2] platform: debug: replace fprintf() with odp_override_log()

2014-11-24 Thread Taras Kondratiuk
On 11/22/2014 12:54 AM, Mike Holmes wrote: On 21 November 2014 04:11, Taras Kondratiuk taras.kondrat...@linaro.org mailto:taras.kondrat...@linaro.org wrote: On 11/20/2014 08:42 PM, Maxim Uvarov wrote: On 11/20/2014 09:36 PM, Maxim Uvarov wrote: On 11/20/2014 08:27 PM

Re: [lng-odp] splitting patches which can not be split

2014-11-24 Thread Taras Kondratiuk
On 11/24/2014 11:31 AM, Anders Roxell wrote: Hi, I still think its better to say no way to all big patches. =) Othervice if we do like this, we create a backdoor for people that doesn't want's to split up their patches or lack the knowledge how to do it. In case of API changes there may

[lng-odp] [PATCH 2/2] platform: debug: Simplify ODP_LOG() macro

2014-11-24 Thread Taras Kondratiuk
Move additional functionality out of ODP_LOG. Move abort() call to odp_override_log(), so application will be able to implement custom abort handling. Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org --- platform/linux-generic/include/api/odp_debug.h | 37

[lng-odp] [PATCH 0/2] Add a way to override default ODP_LOG behavior

2014-11-24 Thread Taras Kondratiuk
This series adds a default weak odp_override_log() function which can be replaced by application. Taras Kondratiuk (2): platform: debug: replace fprintf() with odp_override_log() platform: debug: Simplify ODP_LOG() macro platform/linux-generic/Makefile.am |3 +- platform

[lng-odp] [PATCH 1/2] platform: debug: replace fprintf() with odp_override_log()

2014-11-24 Thread Taras Kondratiuk
ODP application may want to override default ODP logging behaviour and use custom logging function. Add a weak odp_override_log() function for this purpose instead of default fprintf(). Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org --- platform/linux-generic/Makefile.am

Re: [lng-odp] [PATCH v1 1/5] helper: odph_tcp header description

2014-11-24 Thread Taras Kondratiuk
On 11/24/2014 12:42 PM, Maxim Uvarov wrote: Taras, Veky is that good for you? Needed some more review for classification patches. They block packet i/o things which also needed to be delivered on that week. Thanks, Maxim. On 11/21/2014 11:53 AM, Balasubramanian Manoharan wrote: This

Re: [lng-odp] [PATCH v2 4/9] linux-generic: odp_barrier.c use __atomic

2014-11-24 Thread Taras Kondratiuk
On 11/24/2014 12:20 PM, Ola Liljedahl wrote: No, it is still there (slightly changed) in my code (at least after applying all the patches): __atomic_thread_fence(__ATOMIC_SEQ_CST); count = odp_atomic_fetch_inc_u32(barrier-bar); wasless = count barrier-count;

[lng-odp] [PATCH KS2] linux-keystone2: init: update init for McSDK 3.01.01.04

2014-11-24 Thread Taras Kondratiuk
Update initialization to be compatible with a new McSDK release. Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org --- platform/linux-keystone2/mcsdk/mcsdk_init.c | 85 ++- 1 file changed, 58 insertions(+), 27 deletions(-) diff --git a/platform/linux

[lng-odp] [PATCHv2 KS2] linux-keystone2: init: update init for McSDK 3.01.01.04

2014-11-24 Thread Taras Kondratiuk
Update initialization to be compatible with a new McSDK release. Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org --- v2: Fixed NWAL_ENTRY size. platform/linux-keystone2/mcsdk/mcsdk_init.c | 85 ++- 1 file changed, 58 insertions(+), 27 deletions(-) diff

[lng-odp] [PATCH KS2] linux-keystone2: allocate memregion from RM

2014-11-24 Thread Taras Kondratiuk
Instead of hardcoding memory region number and start link memory index allocate them from RM. Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org --- platform/linux-keystone2/include/api/mcsdk_tune.h | 17 - platform/linux-keystone2/include/api/odp_state.h |2

Re: [lng-odp] [RFC PATCH 1/2] platform: debug: replace fprintf() with odp_override_log()

2014-11-21 Thread Taras Kondratiuk
On 11/20/2014 08:42 PM, Maxim Uvarov wrote: On 11/20/2014 09:36 PM, Maxim Uvarov wrote: On 11/20/2014 08:27 PM, Taras Kondratiuk wrote: ODP application may want to override default ODP logging behaviour and use custom logging function. Add a weak odp_override_log() function for this purpose

Re: [lng-odp] [RFC] cunit: add tests for scheduler API

2014-11-21 Thread Taras Kondratiuk
On 11/21/2014 12:18 PM, Alexandru Badicioiu wrote: Hi, the scheduling tests in odp_example were discussed some time ago and there was an agreement, at least for FSL and TI platforms, that fair scheduling assumed by the following loop: for (i = 0; i QUEUE_ROUNDS; i++) { buf =

[lng-odp] [RFC PATCHv2] cunit: buffer: add buffer tests

2014-11-21 Thread Taras Kondratiuk
/validation/Makefile.am instead. [1] http://lists.linaro.org/pipermail/lng-odp/2014-November/004992.html Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org --- test/validation/Makefile.am|8 +- test/validation/buffer/odp_buffer_pool_test.c | 213

Re: [lng-odp] [RFC] cunit: add tests for scheduler API

2014-11-21 Thread Taras Kondratiuk
On 11/20/2014 09:02 PM, Ciprian Barbu wrote: Signed-off-by: Ciprian Barbu ciprian.ba...@linaro.org --- The testcases are based almost entirely on the odp_example. There are no alloc tests and I added a test case for odp_schedule_wait_time. The major differencs between the odp_example and this

Re: [lng-odp] [PATCHv2 1/3] test/example changes for v1.0 buffer pool APIs

2014-11-21 Thread Taras Kondratiuk
On 11/21/2014 02:15 PM, Maxim Uvarov wrote: On 11/21/2014 03:45 AM, Bill Fischofer wrote: OK, I'm confused here. The patches to effect API changes are large because they need to change three things: 1. The .h files that define the API. 2. The revised implementation of the API. 3. The

Re: [lng-odp] [RFC] cunit: add tests for scheduler API

2014-11-21 Thread Taras Kondratiuk
On 11/21/2014 03:44 PM, Ciprian Barbu wrote: On Fri, Nov 21, 2014 at 1:31 PM, Taras Kondratiuk taras.kondrat...@linaro.org wrote: On 11/20/2014 09:02 PM, Ciprian Barbu wrote: Signed-off-by: Ciprian Barbu ciprian.ba...@linaro.org --- The testcases are based almost entirely on the odp_example

<    1   2   3   4   >