Re: Patch test with several minor dialog alignment fixes

2018-12-25 Thread Daniel
On 25/12/2018 18:20, Jürgen Spitzmüller wrote: Am Montag, den 24.12.2018, 22:45 +0100 schrieb Daniel: Thanks. But the buttons are misaligned now (see attachment). Try again with recent master. Jürgen I'll give up. It was fun. Daniel

Re: Patch test with several minor dialog alignment fixes

2018-12-25 Thread Daniel
On 25/12/2018 16:29, Jürgen Spitzmüller wrote: Am Dienstag, den 25.12.2018, 13:56 +0100 schrieb Daniel: Did you check whether those not on the list do actually have GBs? Yes. Daniel And some are missing from your list, like FindAndReplaceUi.ui. Thanks, added. Jürgen Okay, I'll give

Re: Patch test with several minor dialog alignment fixes

2018-12-25 Thread Jürgen Spitzmüller
Am Dienstag, den 25.12.2018, 12:35 +0100 schrieb Jürgen Spitzmüller: > Am Montag, den 24.12.2018, 22:11 +0100 schrieb Daniel: > > Thanks. But I like mine more (see attached screen shot). > > I don't see the misalignment in your screenshot here on Linux. But I > saw a misalignment with your patch.

Re: Patch test with several minor dialog alignment fixes

2018-12-25 Thread Jürgen Spitzmüller
Am Montag, den 24.12.2018, 22:45 +0100 schrieb Daniel: > Thanks. But the buttons are misaligned now (see attachment). Try again with recent master. Jürgen signature.asc Description: This is a digitally signed message part

Re: Patch test with several minor dialog alignment fixes

2018-12-25 Thread Jürgen Spitzmüller
Am Dienstag, den 25.12.2018, 13:56 +0100 schrieb Daniel: > > Did you check whether those not on the list do actually have GBs? Yes. > > > > Daniel > > And some are missing from your list, like FindAndReplaceUi.ui. Thanks, added. Jürgen signature.asc Description: This is a digitally signed

Re: Patch test with several minor dialog alignment fixes

2018-12-25 Thread Jürgen Spitzmüller
Am Dienstag, den 25.12.2018, 13:43 +0100 schrieb Daniel: > > I am probably confused. Do you ask me to recreate my patch with > current > master Yes, please. > which you successfully applied before and found to be misaligned? Yes. Thanks Jürgen > > Daniel > signature.asc Description:

Re: Patch test with several minor dialog alignment fixes

2018-12-25 Thread Daniel
On 25/12/2018 14:10, Daniel wrote: On 25/12/2018 12:51, Daniel wrote: On 25/12/2018 12:26, Jürgen Spitzmüller wrote: Am Montag, den 24.12.2018, 22:45 +0100 schrieb Daniel: Thanks. But the buttons are misaligned now (see attachment). Not for me (see attachment). * the Cancel button needs

Re: Patch test with several minor dialog alignment fixes

2018-12-25 Thread Daniel
On 25/12/2018 12:51, Daniel wrote: On 25/12/2018 12:26, Jürgen Spitzmüller wrote: Am Montag, den 24.12.2018, 22:45 +0100 schrieb Daniel: Thanks. But the buttons are misaligned now (see attachment). Not for me (see attachment). * the Cancel button needs to go on a line of its own. I

Re: Patch test with several minor dialog alignment fixes

2018-12-25 Thread Daniel
On 25/12/2018 13:46, Daniel wrote: On 25/12/2018 13:22, Jürgen Spitzmüller wrote: Am Dienstag, den 25.12.2018, 12:40 +0100 schrieb Daniel: It is not that only some of the GBs are out of line. Almost all are non-flat. I count only a minority where the flat designation was missing. Namely    

Re: Patch test with several minor dialog alignment fixes

2018-12-25 Thread Daniel
On 25/12/2018 13:22, Jürgen Spitzmüller wrote: Am Dienstag, den 25.12.2018, 12:40 +0100 schrieb Daniel: It is not that only some of the GBs are out of line. Almost all are non-flat. I count only a minority where the flat designation was missing. Namely

Re: Patch test with several minor dialog alignment fixes

2018-12-25 Thread Daniel
On 25/12/2018 13:26, Jürgen Spitzmüller wrote: Am Dienstag, den 25.12.2018, 13:08 +0100 schrieb Daniel: Can you show me what my patch looks like on the style you use? Then I could try to figure out what went wrong with it. If you send me a patch that applies to master, sure. Jürgen You

Re: Patch test with several minor dialog alignment fixes

2018-12-25 Thread Jürgen Spitzmüller
Am Dienstag, den 25.12.2018, 13:08 +0100 schrieb Daniel: > Can you show me what my patch looks like on the style you use? Then > I > could try to figure out what went wrong with it. If you send me a patch that applies to master, sure. Jürgen > > Daniel > signature.asc Description: This is

Re: Patch test with several minor dialog alignment fixes

2018-12-25 Thread Jürgen Spitzmüller
Am Dienstag, den 25.12.2018, 12:40 +0100 schrieb Daniel: > > It is not that only some of the GBs are out of line. Almost all are > non-flat. I count only a minority where the flat designation was missing. Namely src/frontends/qt4/ui/CharacterUi.ui src/frontends/qt4/ui/CitationUi.ui

Re: Patch test with several minor dialog alignment fixes

2018-12-25 Thread Daniel
On 25/12/2018 12:35, Jürgen Spitzmüller wrote: Am Montag, den 24.12.2018, 22:11 +0100 schrieb Daniel: Thanks. But I like mine more (see attached screen shot). I don't see the misalignment in your screenshot here on Linux. But I saw a misalignment with your patch. It maybe depends on the Qt

Re: Patch test with several minor dialog alignment fixes

2018-12-25 Thread Daniel
On 25/12/2018 12:26, Jürgen Spitzmüller wrote: Am Montag, den 24.12.2018, 22:45 +0100 schrieb Daniel: Thanks. But the buttons are misaligned now (see attachment). Not for me (see attachment). Sorry, forgot to comment on this. That the misalignment does not happen for you is because text

Re: Patch test with several minor dialog alignment fixes

2018-12-25 Thread Daniel
On 25/12/2018 12:26, Jürgen Spitzmüller wrote: Am Montag, den 24.12.2018, 22:45 +0100 schrieb Daniel: Thanks. But the buttons are misaligned now (see attachment). Not for me (see attachment). * the Cancel button needs to go on a line of its own. I understand that this is a general rule of

Re: Patch test with several minor dialog alignment fixes

2018-12-25 Thread Daniel
On 25/12/2018 12:28, Jürgen Spitzmüller wrote: Am Montag, den 24.12.2018, 22:21 +0100 schrieb Daniel: Thanks. You changed the group box style to flat, right? I still think this isn't LyX standard. It's LyX standard. We changed that some years ago. If some GBs are non- flat, we should change

Re: Patch test with several minor dialog alignment fixes

2018-12-25 Thread Jürgen Spitzmüller
Am Montag, den 24.12.2018, 22:11 +0100 schrieb Daniel: > Thanks. But I like mine more (see attached screen shot). I don't see the misalignment in your screenshot here on Linux. But I saw a misalignment with your patch. It maybe depends on the Qt style. Jürgen signature.asc Description: This is

Re: Patch test with several minor dialog alignment fixes

2018-12-25 Thread Jürgen Spitzmüller
Am Montag, den 24.12.2018, 22:21 +0100 schrieb Daniel: > Thanks. You changed the group box style to flat, right? I still > think > this isn't LyX standard. It's LyX standard. We changed that some years ago. If some GBs are non- flat, we should change that. Jürgen signature.asc Description:

Re: Patch test with several minor dialog alignment fixes

2018-12-25 Thread Jürgen Spitzmüller
Am Montag, den 24.12.2018, 22:45 +0100 schrieb Daniel: > Thanks. But the buttons are misaligned now (see attachment). Not for me (see attachment). > > * the Cancel button needs to go on a line of its own. > > I understand that this is a general rule of dialogs in LyX. However, > please

Re: Patch test with several minor dialog alignment fixes

2018-12-25 Thread Daniel
On 24/12/2018 22:45, Daniel wrote: On 24/12/2018 14:48, Jürgen Spitzmüller wrote: Am Montag, den 29.10.2018, 15:16 +0100 schrieb Daniel: On 29/10/2018 14:12, Daniel wrote: Attached is a patch for the Find & Replace (Quick) dialog for master. If the patch is works, I could proceed with the

Re: Patch test with several minor dialog alignment fixes

2018-12-24 Thread Daniel
On 24/12/2018 14:48, Jürgen Spitzmüller wrote: Am Montag, den 29.10.2018, 15:16 +0100 schrieb Daniel: On 29/10/2018 14:12, Daniel wrote: Attached is a patch for the Find & Replace (Quick) dialog for master. If the patch is works, I could proceed with the other dialog fixes. Sorry, reordered

Re: Patch test with several minor dialog alignment fixes

2018-12-24 Thread Daniel
On 24/12/2018 16:01, Jürgen Spitzmüller wrote: Am Mittwoch, den 31.10.2018, 07:57 +0100 schrieb Daniel: Compare dialog. Reworked version committed. Thanks, Jürgen Thanks. You changed the group box style to flat, right? I still think this isn't LyX standard. It is also not Qt's default.

Re: Patch test with several minor dialog alignment fixes

2018-12-24 Thread Daniel
On 24/12/2018 17:46, Jürgen Spitzmüller wrote: Am Mittwoch, den 24.10.2018, 13:36 +0200 schrieb Daniel: fixed version attached. Please repost as separate patch, should this combined patch include something not yet addressed. Thanks, Jürgen I don't think so. I separated all after being

Re: Patch test with several minor dialog alignment fixes

2018-12-24 Thread Daniel
On 24/12/2018 16:03, Jürgen Spitzmüller wrote: Am Mittwoch, den 31.10.2018, 16:58 +0100 schrieb Daniel: Okay, maybe I should explain a bit, especially if a change might be controversial. I think the checkbox is better placed next to the button box because it makes is more obvious where it

Re: Patch test with several minor dialog alignment fixes

2018-12-24 Thread Jürgen Spitzmüller
Am Mittwoch, den 24.10.2018, 13:36 +0200 schrieb Daniel: > fixed version attached. Please repost as separate patch, should this combined patch include something not yet addressed. Thanks, Jürgen signature.asc Description: This is a digitally signed message part

Re: Patch test with several minor dialog alignment fixes

2018-12-24 Thread Jürgen Spitzmüller
Am Mittwoch, den 31.10.2018, 18:20 +0100 schrieb Daniel: > Search & Replace Advanced. A bit more extensive changes. Slightly modified version committed (additional vspacer added). Thanks, Jürgen signature.asc Description: This is a digitally signed message part

Re: Patch test with several minor dialog alignment fixes

2018-12-24 Thread Jürgen Spitzmüller
Am Donnerstag, den 22.11.2018, 11:03 +0100 schrieb Daniel: > Paragraph dialog fixes attached. Committed minus the group box changes (we use flat GBs in all dialogs). Thanks, Jürgen signature.asc Description: This is a digitally signed message part

Re: Patch test with several minor dialog alignment fixes

2018-12-24 Thread Jürgen Spitzmüller
Am Donnerstag, den 22.11.2018, 10:41 +0100 schrieb Daniel: > > I suggest a fixed minimum height for the Text Properties dialog. > > > > Reasons: > > - It cannot profit from greater height > > - It might not have its minimum height initially and hence look > > awkwardly stretched > > > > Daniel

Re: Patch test with several minor dialog alignment fixes

2018-12-24 Thread Jürgen Spitzmüller
Am Freitag, den 16.11.2018, 15:41 +0100 schrieb Daniel: > Just stumbled upon a misplaced spacer in the Table Insert dialog. > Patch and screen captures attached. Committed. Thanks, Jürgen signature.asc Description: This is a digitally signed message part

Re: Patch test with several minor dialog alignment fixes

2018-12-24 Thread Jürgen Spitzmüller
Am Mittwoch, den 31.10.2018, 17:46 +0100 schrieb Daniel: > Messages Pane. Committed. Thanks, Jürgen signature.asc Description: This is a digitally signed message part

Re: Patch test with several minor dialog alignment fixes

2018-12-24 Thread Jürgen Spitzmüller
Am Mittwoch, den 31.10.2018, 16:58 +0100 schrieb Daniel: > Okay, maybe I should explain a bit, especially if a change might be > controversial. I think the checkbox is better placed next to the > button > box because it makes is more obvious where it belongs to. There is > no > other obvious

Re: Patch test with several minor dialog alignment fixes

2018-12-24 Thread Jürgen Spitzmüller
Am Mittwoch, den 31.10.2018, 07:57 +0100 schrieb Daniel: > Compare dialog. Reworked version committed. Thanks, Jürgen signature.asc Description: This is a digitally signed message part

Re: Patch test with several minor dialog alignment fixes

2018-12-24 Thread Jürgen Spitzmüller
Am Mittwoch, den 31.10.2018, 07:24 +0100 schrieb Daniel: > Thesaurus dialog. Committed. Thanks, Jürgen signature.asc Description: This is a digitally signed message part

Re: Patch test with several minor dialog alignment fixes

2018-12-24 Thread Jürgen Spitzmüller
Am Dienstag, den 30.10.2018, 21:23 +0100 schrieb Daniel: > Spellchecker dialog. Committed. Jürgen signature.asc Description: This is a digitally signed message part

Re: Patch test with several minor dialog alignment fixes

2018-12-24 Thread Jürgen Spitzmüller
Am Montag, den 29.10.2018, 15:16 +0100 schrieb Daniel: > On 29/10/2018 14:12, Daniel wrote: > > Attached is a patch for the Find & Replace (Quick) dialog for > > master. If > > the patch is works, I could proceed with the other dialog fixes. > > Sorry, reordered checkboxes for no good reason...

Re: Patch test with several minor dialog alignment fixes

2018-11-22 Thread Kornel Benko
Am Donnerstag, 22. November 2018 11:03:00 CET schrieb Daniel : > Paragraph dialog fixes attached. > > Daniel +1 Kornel signature.asc Description: This is a digitally signed message part.

Re: Patch test with several minor dialog alignment fixes

2018-11-22 Thread Daniel
On 22/11/2018 10:41, Daniel wrote: On 22/11/2018 10:38, Daniel wrote: On 16/11/2018 15:41, Daniel wrote: On 31/10/2018 18:20, Daniel wrote: On 31/10/2018 17:46, Daniel wrote: On 31/10/2018 15:25, Daniel wrote: On 31/10/2018 07:57, Daniel wrote: On 31/10/2018 07:24, Daniel wrote: On

Re: Patch test with several minor dialog alignment fixes

2018-11-22 Thread Daniel
On 22/11/2018 10:38, Daniel wrote: On 16/11/2018 15:41, Daniel wrote: On 31/10/2018 18:20, Daniel wrote: On 31/10/2018 17:46, Daniel wrote: On 31/10/2018 15:25, Daniel wrote: On 31/10/2018 07:57, Daniel wrote: On 31/10/2018 07:24, Daniel wrote: On 30/10/2018 21:23, Daniel wrote: On

Re: Patch test with several minor dialog alignment fixes

2018-11-22 Thread Daniel
On 16/11/2018 15:41, Daniel wrote: On 31/10/2018 18:20, Daniel wrote: On 31/10/2018 17:46, Daniel wrote: On 31/10/2018 15:25, Daniel wrote: On 31/10/2018 07:57, Daniel wrote: On 31/10/2018 07:24, Daniel wrote: On 30/10/2018 21:23, Daniel wrote: On 30/10/2018 17:37, Daniel wrote: On

Re: Patch test with several minor dialog alignment fixes

2018-11-16 Thread Daniel
On 31/10/2018 18:20, Daniel wrote: On 31/10/2018 17:46, Daniel wrote: On 31/10/2018 15:25, Daniel wrote: On 31/10/2018 07:57, Daniel wrote: On 31/10/2018 07:24, Daniel wrote: On 30/10/2018 21:23, Daniel wrote: On 30/10/2018 17:37, Daniel wrote: On 30/10/2018 16:46, Scott Kostyshak wrote:

Re: Patch test with several minor dialog alignment fixes

2018-11-01 Thread Scott Kostyshak
On Thu, Nov 01, 2018 at 09:35:25PM +0100, Daniel wrote: > On 2018-11-01 21:07, Scott Kostyshak wrote: > > On Thu, Nov 01, 2018 at 05:18:18PM +0100, Daniel wrote: > > > On 01/11/2018 16:58, Scott Kostyshak wrote: > > > > On Thu, Nov 01, 2018 at 06:52:11AM +0100, Daniel wrote: > > > > > > > > >

Re: Patch test with several minor dialog alignment fixes

2018-11-01 Thread Daniel
On 2018-11-01 21:07, Scott Kostyshak wrote: On Thu, Nov 01, 2018 at 05:18:18PM +0100, Daniel wrote: On 01/11/2018 16:58, Scott Kostyshak wrote: On Thu, Nov 01, 2018 at 06:52:11AM +0100, Daniel wrote: Great. And by the way, while I tend to think all the changes I make sense, I can change

Re: Patch test with several minor dialog alignment fixes

2018-11-01 Thread Scott Kostyshak
On Thu, Nov 01, 2018 at 05:18:18PM +0100, Daniel wrote: > On 01/11/2018 16:58, Scott Kostyshak wrote: > > On Thu, Nov 01, 2018 at 06:52:11AM +0100, Daniel wrote: > > > > > Great. And by the way, while I tend to think all the changes I make > > > sense, I > > > can change things on feedback. > >

Re: Patch test with several minor dialog alignment fixes

2018-11-01 Thread Daniel
On 01/11/2018 16:58, Scott Kostyshak wrote: On Thu, Nov 01, 2018 at 06:52:11AM +0100, Daniel wrote: Great. And by the way, while I tend to think all the changes I make sense, I can change things on feedback. Sounds good. One comment which I'm not sure is relevant is: often Qt Creator

Re: Patch test with several minor dialog alignment fixes

2018-11-01 Thread Scott Kostyshak
On Thu, Nov 01, 2018 at 06:52:11AM +0100, Daniel wrote: > Great. And by the way, while I tend to think all the changes I make sense, I > can change things on feedback. Sounds good. One comment which I'm not sure is relevant is: often Qt Creator reformats a bunch of things when you save. I find

Re: Patch test with several minor dialog alignment fixes

2018-11-01 Thread Daniel
On 01/11/2018 12:45, Kornel Benko wrote: Am Donnerstag, 1. November 2018 12:32:13 CET schrieb Daniel : On 01/11/2018 10:42, Kornel Benko wrote: Am Donnerstag, 1. November 2018 06:52:11 CET schrieb Daniel : Thanks for checking. That the left hand labels don't stretch was driven by the

Re: Patch test with several minor dialog alignment fixes

2018-11-01 Thread Kornel Benko
Am Donnerstag, 1. November 2018 12:32:13 CET schrieb Daniel : > On 01/11/2018 10:42, Kornel Benko wrote: > > Am Donnerstag, 1. November 2018 06:52:11 CET schrieb Daniel > > : > > > Thanks for checking. That the left hand labels don't stretch was driven > by > the idea that it

Re: Patch test with several minor dialog alignment fixes

2018-11-01 Thread Daniel
On 01/11/2018 10:42, Kornel Benko wrote: Am Donnerstag, 1. November 2018 06:52:11 CET schrieb Daniel : Thanks for checking. That the left hand labels don't stretch was driven by the idea that it would be easier to match the label and the text boxes. As for the buttons: I have never seen a

Re: Patch test with several minor dialog alignment fixes

2018-11-01 Thread Kornel Benko
Am Donnerstag, 1. November 2018 06:52:11 CET schrieb Daniel : ... > >> Thanks for checking. That the left hand labels don't stretch was driven by > >> the idea that it would be easier to match the label and the text boxes. As > >> for the buttons: I have never seen a (professional) dialog UI where

Re: Patch test with several minor dialog alignment fixes

2018-10-31 Thread Daniel
On 01/11/2018 02:02, Scott Kostyshak wrote: On Wed, Oct 31, 2018 at 04:54:21PM +0100, Daniel wrote: On 31/10/2018 16:05, Scott Kostyshak wrote: On Wed, Oct 31, 2018 at 07:24:46AM +0100, Daniel wrote: On 30/10/2018 21:23, Daniel wrote: On 30/10/2018 17:37, Daniel wrote: On 30/10/2018 16:46,

Re: Patch test with several minor dialog alignment fixes

2018-10-31 Thread Scott Kostyshak
On Wed, Oct 31, 2018 at 04:54:21PM +0100, Daniel wrote: > On 31/10/2018 16:05, Scott Kostyshak wrote: > > On Wed, Oct 31, 2018 at 07:24:46AM +0100, Daniel wrote: > > > On 30/10/2018 21:23, Daniel wrote: > > > > On 30/10/2018 17:37, Daniel wrote: > > > > > On 30/10/2018 16:46, Scott Kostyshak

Re: Patch test with several minor dialog alignment fixes

2018-10-31 Thread Daniel
On 31/10/2018 15:25, Daniel wrote: On 31/10/2018 07:57, Daniel wrote: On 31/10/2018 07:24, Daniel wrote: On 30/10/2018 21:23, Daniel wrote: On 30/10/2018 17:37, Daniel wrote: On 30/10/2018 16:46, Scott Kostyshak wrote: On Tue, Oct 30, 2018 at 04:16:16PM +0100, Daniel wrote: Thanks for

Re: Patch test with several minor dialog alignment fixes

2018-10-31 Thread Daniel
On 31/10/2018 15:25, Daniel wrote: On 31/10/2018 07:57, Daniel wrote: On 31/10/2018 07:24, Daniel wrote: On 30/10/2018 21:23, Daniel wrote: On 30/10/2018 17:37, Daniel wrote: On 30/10/2018 16:46, Scott Kostyshak wrote: On Tue, Oct 30, 2018 at 04:16:16PM +0100, Daniel wrote: Thanks for

Re: Patch test with several minor dialog alignment fixes

2018-10-31 Thread Daniel
On 31/10/2018 16:05, Scott Kostyshak wrote: On Wed, Oct 31, 2018 at 07:24:46AM +0100, Daniel wrote: On 30/10/2018 21:23, Daniel wrote: On 30/10/2018 17:37, Daniel wrote: On 30/10/2018 16:46, Scott Kostyshak wrote: On Tue, Oct 30, 2018 at 04:16:16PM +0100, Daniel wrote: Thanks for checking.

Re: Patch test with several minor dialog alignment fixes

2018-10-31 Thread Scott Kostyshak
On Wed, Oct 31, 2018 at 07:24:46AM +0100, Daniel wrote: > On 30/10/2018 21:23, Daniel wrote: > > On 30/10/2018 17:37, Daniel wrote: > > > On 30/10/2018 16:46, Scott Kostyshak wrote: > > > > On Tue, Oct 30, 2018 at 04:16:16PM +0100, Daniel wrote: > > > > > > > > > Thanks for checking. The minimum

Re: Patch test with several minor dialog alignment fixes

2018-10-31 Thread Daniel
On 31/10/2018 07:24, Daniel wrote: On 30/10/2018 21:23, Daniel wrote: On 30/10/2018 17:37, Daniel wrote: On 30/10/2018 16:46, Scott Kostyshak wrote: On Tue, Oct 30, 2018 at 04:16:16PM +0100, Daniel wrote: Thanks for checking. The minimum height was actually a bit imprecise. I should have

Re: Patch test with several minor dialog alignment fixes

2018-10-31 Thread Daniel
On 30/10/2018 21:23, Daniel wrote: On 30/10/2018 17:37, Daniel wrote: On 30/10/2018 16:46, Scott Kostyshak wrote: On Tue, Oct 30, 2018 at 04:16:16PM +0100, Daniel wrote: Thanks for checking. The minimum height was actually a bit imprecise. I should have written: "fixed at minimum height". In

Re: Patch test with several minor dialog alignment fixes

2018-10-30 Thread Daniel
On 30/10/2018 17:37, Daniel wrote: On 30/10/2018 16:46, Scott Kostyshak wrote: On Tue, Oct 30, 2018 at 04:16:16PM +0100, Daniel wrote: Thanks for checking. The minimum height was actually a bit imprecise. I should have written: "fixed at minimum height". In current master you can increase

Re: Patch test with several minor dialog alignment fixes

2018-10-30 Thread Daniel
On 30/10/2018 16:46, Scott Kostyshak wrote: On Tue, Oct 30, 2018 at 04:16:16PM +0100, Daniel wrote: Thanks for checking. The minimum height was actually a bit imprecise. I should have written: "fixed at minimum height". In current master you can increase the height but I couldn't see what is

Re: Patch test with several minor dialog alignment fixes

2018-10-30 Thread Scott Kostyshak
On Tue, Oct 30, 2018 at 04:16:16PM +0100, Daniel wrote: > Thanks for checking. The minimum height was actually a bit imprecise. I > should have written: "fixed at minimum height". In current master you can > increase the height but I couldn't see what is to be gained by this and many > other apps

Re: Patch test with several minor dialog alignment fixes

2018-10-30 Thread Daniel
On 30/10/2018 16:09, Scott Kostyshak wrote: On Tue, Oct 30, 2018 at 09:07:54AM +0100, Daniel wrote: On 30/10/2018 00:14, Richard Kimberly Heck wrote: On 10/29/18 10:16 AM, Daniel wrote: On 29/10/2018 14:12, Daniel wrote: Attached is a patch for the Find & Replace (Quick) dialog for master.

Re: Patch test with several minor dialog alignment fixes

2018-10-30 Thread Scott Kostyshak
On Tue, Oct 30, 2018 at 09:07:54AM +0100, Daniel wrote: > On 30/10/2018 00:14, Richard Kimberly Heck wrote: > > On 10/29/18 10:16 AM, Daniel wrote: > > > On 29/10/2018 14:12, Daniel wrote: > > > > Attached is a patch for the Find & Replace (Quick) dialog for master. > > > > If the patch is works,

Re: Patch test with several minor dialog alignment fixes

2018-10-30 Thread Daniel
On 30/10/2018 00:14, Richard Kimberly Heck wrote: On 10/29/18 10:16 AM, Daniel wrote: On 29/10/2018 14:12, Daniel wrote: Attached is a patch for the Find & Replace (Quick) dialog for master. If the patch is works, I could proceed with the other dialog fixes. Sorry, reordered checkboxes for

Re: Patch test with several minor dialog alignment fixes

2018-10-29 Thread Richard Kimberly Heck
On 10/29/18 10:16 AM, Daniel wrote: > On 29/10/2018 14:12, Daniel wrote: >> Attached is a patch for the Find & Replace (Quick) dialog for master. >> If the patch is works, I could proceed with the other dialog fixes. > > Sorry, reordered checkboxes for no good reason... Can you say what exactly

Re: Patch test with several minor dialog alignment fixes

2018-10-29 Thread Daniel
On 29/10/2018 14:12, Daniel wrote: Attached is a patch for the Find & Replace (Quick) dialog for master. If the patch is works, I could proceed with the other dialog fixes. Sorry, reordered checkboxes for no good reason... Daniel From 3a91987679bae0211959101a6fd27d7e74c474df Mon Sep 17

Re: Patch test with several minor dialog alignment fixes

2018-10-29 Thread Daniel
Attached is a patch for the Find & Replace (Quick) dialog for master. If the patch is works, I could proceed with the other dialog fixes. Daniel From edca7251626378a5bff5aab0806a0a1689debd0a Mon Sep 17 00:00:00 2001 From: Daniel Ramoeller Date: Mon, 29 Oct 2018 14:08:34 +0100 Subject: [PATCH]

Re: Patch test with several minor dialog alignment fixes

2018-10-27 Thread Richard Kimberly Heck
On 10/27/18 1:43 PM, Daniel wrote: > On 27/10/2018 19:33, Richard Kimberly Heck wrote: >> On 10/24/18 7:36 AM, Daniel wrote: >>> On 24/10/2018 12:20, Daniel wrote: On 24/10/2018 11:40, Daniel wrote: > On 23/10/2018 18:37, Daniel wrote: >> On 23/10/2018 11:21, Daniel wrote: >>

Re: Patch test with several minor dialog alignment fixes

2018-10-27 Thread Daniel
On 27/10/2018 19:33, Richard Kimberly Heck wrote: On 10/24/18 7:36 AM, Daniel wrote: On 24/10/2018 12:20, Daniel wrote: On 24/10/2018 11:40, Daniel wrote: On 23/10/2018 18:37, Daniel wrote: On 23/10/2018 11:21, Daniel wrote: [...] One thing I couldn't try out is the Advanced Search &

Re: Patch test with several minor dialog alignment fixes

2018-10-27 Thread Richard Kimberly Heck
On 10/24/18 7:36 AM, Daniel wrote: > On 24/10/2018 12:20, Daniel wrote: >> On 24/10/2018 11:40, Daniel wrote: >>> On 23/10/2018 18:37, Daniel wrote: On 23/10/2018 11:21, Daniel wrote: [...] > One thing I couldn't try out is the Advanced Search & Replace > dialog when docked to

Re: Patch test with several minor dialog alignment fixes

2018-10-26 Thread Daniel
On 24/10/2018 13:36, Daniel wrote: On 24/10/2018 12:20, Daniel wrote: On 24/10/2018 11:40, Daniel wrote: On 23/10/2018 18:37, Daniel wrote: - There is something strange going on with the size of the Advanced Find and Replace Widget. When docked to the top (or docked to the top and then

Re: Patch test with several minor dialog alignment fixes

2018-10-25 Thread Daniel
On 25/10/2018 20:40, Richard Kimberly Heck wrote: On 10/25/18 5:47 AM, Daniel wrote: The patch was created with 2.3.x checked out. Maybe that is not how one has to do it? I was unable to work on master due to incompatibility with visual studio. These problems are fixed now but I don't know how

Re: Patch test with several minor dialog alignment fixes

2018-10-25 Thread Richard Kimberly Heck
On 10/25/18 5:47 AM, Daniel wrote: > The patch was created with 2.3.x checked out. Maybe that is not how > one has to do it? I was unable to work on master due to > incompatibility with visual studio. These problems are fixed now but I > don't know how to "forport". Any suggestion appreciated. Or

Re: Patch test with several minor dialog alignment fixes

2018-10-25 Thread Daniel
The patch was created with 2.3.x checked out. Maybe that is not how one has to do it? I was unable to work on master due to incompatibility with visual studio. These problems are fixed now but I don't know how to "forport". Any suggestion appreciated. Or is it enough that the patch can be

Re: Patch test with several minor dialog alignment fixes

2018-10-24 Thread Daniel
On 24/10/2018 12:20, Daniel wrote: On 24/10/2018 11:40, Daniel wrote: On 23/10/2018 18:37, Daniel wrote: On 23/10/2018 11:21, Daniel wrote: [...] One thing I couldn't try out is the Advanced Search & Replace dialog when docked to the top or bottom. I remember that this is possible, for

Re: Patch test with several minor dialog alignment fixes

2018-10-24 Thread Daniel
On 24/10/2018 11:40, Daniel wrote: On 23/10/2018 18:37, Daniel wrote: On 23/10/2018 11:21, Daniel wrote: [...] One thing I couldn't try out is the Advanced Search & Replace dialog when docked to the top or bottom. I remember that this is possible, for example, on MacOS but it seems not to be

Re: Patch test with several minor dialog alignment fixes

2018-10-24 Thread Daniel
On 23/10/2018 18:37, Daniel wrote: On 23/10/2018 11:21, Daniel wrote: [...] One thing I couldn't try out is the Advanced Search & Replace dialog when docked to the top or bottom. I remember that this is possible, for example, on MacOS but it seems not to be on Windows. So, it would be great

Re: Patch test with several minor dialog alignment fixes

2018-10-23 Thread Daniel
On 23/10/2018 11:21, Daniel wrote: [...] One thing I couldn't try out is the Advanced Search & Replace dialog when docked to the top or bottom. I remember that this is possible, for example, on MacOS but it seems not to be on Windows. So, it would be great if someone could test what it looks