[MediaWiki-commits] [Gerrit] mediawiki...chromium-render[master]: Hygiene: Upgrade Puppeteer library to v1.0.0

2018-01-18 Thread Pmiazga (Code Review)
Pmiazga has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/405063 ) Change subject: Hygiene: Upgrade Puppeteer library to v1.0.0 .. Hygiene: Upgrade Puppeteer library to v1.0.0 On Jan 11th 2018 Puppeteer

[MediaWiki-commits] [Gerrit] mediawiki...chromium-render[master]: WIP: Allow injecting extra styles

2018-01-18 Thread Pmiazga (Code Review)
Pmiazga has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/405062 ) Change subject: WIP: Allow injecting extra styles .. WIP: Allow injecting extra styles Bug: T181680 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...MinervaNeue[master]: Show Download button only on Android >= 5 & Chrome >= 41

2018-01-12 Thread Pmiazga (Code Review)
Pmiazga has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/403968 ) Change subject: Show Download button only on Android >= 5 & Chrome >= 41 .. Show Download button only on Android >= 5 & Chrome >= 41

[MediaWiki-commits] [Gerrit] mediawiki...WikimediaEvents[master]: Fix incorrectr mediawiki.trackSubscribe() call

2018-01-11 Thread Pmiazga (Code Review)
Pmiazga has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/403765 ) Change subject: Fix incorrectr mediawiki.trackSubscribe() call .. Fix incorrectr mediawiki.trackSubscribe() call The previous patch had

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[specialpages]: Run MobileFrontendFeaturesRegistration only once

2018-01-09 Thread Pmiazga (Code Review)
Pmiazga has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/403304 ) Change subject: Run MobileFrontendFeaturesRegistration only once .. Run MobileFrontendFeaturesRegistration only once Due to T165068 it's

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[specialpages]: Hygiene: Improve infobox detection in MoveLeadParagraphTrans...

2018-01-09 Thread Pmiazga (Code Review)
Pmiazga has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/403223 ) Change subject: Hygiene: Improve infobox detection in MoveLeadParagraphTransform .. Hygiene: Improve infobox detection in

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Hygiene: Introduce a isFeatureAvailableInContext() method

2018-01-09 Thread Pmiazga (Code Review)
Pmiazga has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/403221 ) Change subject: Hygiene: Introduce a isFeatureAvailableInContext() method .. Hygiene: Introduce a isFeatureAvailableInContext() method

[MediaWiki-commits] [Gerrit] mediawiki...WikimediaEvents[master]: Listen to minerva download events and log events accordingly

2018-01-09 Thread Pmiazga (Code Review)
Pmiazga has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/403214 ) Change subject: Listen to minerva download events and log events accordingly .. Listen to minerva download events and log events

[MediaWiki-commits] [Gerrit] mediawiki...MinervaNeue[master]: Send events when user taps download icon

2018-01-09 Thread Pmiazga (Code Review)
Pmiazga has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/403181 ) Change subject: Send events when user taps download icon .. Send events when user taps download icon To track "download" button

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Hygiene: Improve infobox detection in MoveLeadParagraphTrans...

2018-01-09 Thread Pmiazga (Code Review)
Pmiazga has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/403161 ) Change subject: Hygiene: Improve infobox detection in MoveLeadParagraphTransform .. Hygiene: Improve infobox detection in

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Improvements to existing feature management system

2018-01-08 Thread Pmiazga (Code Review)
Pmiazga has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/403073 ) Change subject: Improvements to existing feature management system .. Improvements to existing feature management system Changes: - added

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[specialpages]: Improvements to existing feature management system

2018-01-08 Thread Pmiazga (Code Review)
Pmiazga has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/403071 ) Change subject: Improvements to existing feature management system .. Improvements to existing feature management system Bug: T182362

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[specialpages]: Mobile Frontend feature management system

2018-01-08 Thread Pmiazga (Code Review)
Pmiazga has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/402938 ) Change subject: Mobile Frontend feature management system .. Mobile Frontend feature management system Bug: T182362 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: When showing history include the namespace text

2017-12-21 Thread Pmiazga (Code Review)
Pmiazga has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/399660 ) Change subject: When showing history include the namespace text .. When showing history include the namespace text When user checks the

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[specialpages]: Delay form submit by 0.25s

2017-12-20 Thread Pmiazga (Code Review)
Pmiazga has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/399463 ) Change subject: Delay form submit by 0.25s .. Delay form submit by 0.25s On some Android devices the button toggle gets stuck in middle as

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[specialpages]: Toggle the Beta toggle when user clicks on label

2017-12-18 Thread Pmiazga (Code Review)
Pmiazga has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/398889 ) Change subject: Toggle the Beta toggle when user clicks on label .. Toggle the Beta toggle when user clicks on label The beta checkbox is

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[specialpages]: Show toast messages without 1s delay

2017-12-15 Thread Pmiazga (Code Review)
Pmiazga has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/398530 ) Change subject: Show toast messages without 1s delay .. Show toast messages without 1s delay Toast message should be visible immediately,

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Definition list should be also moved with first paragraph

2017-12-11 Thread Pmiazga (Code Review)
Pmiazga has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/397568 ) Change subject: Definition list should be also moved with first paragraph .. Definition list should be also moved with first paragraph

[MediaWiki-commits] [Gerrit] mediawiki...chromium-render[master]: Puppeteer: update to version 0.13.

2017-11-30 Thread Pmiazga (Code Review)
Pmiazga has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/394341 ) Change subject: Puppeteer: update to version 0.13. .. Puppeteer: update to version 0.13. Bug: T181097 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...chromium-render[master]: Abort render on connection close

2017-11-28 Thread Pmiazga (Code Review)
Pmiazga has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/392932 ) Change subject: Abort render on connection close .. Abort render on connection close When the client closes the connection: - if

[MediaWiki-commits] [Gerrit] mediawiki...chromium-render[master]: Improve logging

2017-11-22 Thread Pmiazga (Code Review)
Pmiazga has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/392713 ) Change subject: Improve logging .. Improve logging Per Marko's comments at https://gerrit.wikimedia.org/r/#/c/392051. Get rid of

[MediaWiki-commits] [Gerrit] mediawiki...chromium-render[master]: Update to service-template-node v0.5.3

2017-11-22 Thread Pmiazga (Code Review)
Pmiazga has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/392060 ) Change subject: Update to service-template-node v0.5.3 .. Update to service-template-node v0.5.3 Bug: T180800 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...chromium-render[master]: Make chromium testing easier

2017-11-17 Thread Pmiazga (Code Review)
Pmiazga has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/392051 ) Change subject: Make chromium testing easier .. Make chromium testing easier Changes: - make logging more verbose - add a

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Rewrite MobileFronted Ruby tests to NodeJS

2017-11-17 Thread Pmiazga (Code Review)
Pmiazga has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/392026 ) Change subject: Rewrite MobileFronted Ruby tests to NodeJS .. Rewrite MobileFronted Ruby tests to NodeJS Changes: - added basic

[MediaWiki-commits] [Gerrit] mediawiki...chromium-render[master]: Add task count limit to requests in the queue

2017-11-15 Thread Pmiazga (Code Review)
Pmiazga has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/389797 ) Change subject: Add task count limit to requests in the queue .. Add task count limit to requests in the queue By default, the

[MediaWiki-commits] [Gerrit] mediawiki...chromium-render[master]: Lower render queue timeout to 60 seconds

2017-11-14 Thread Pmiazga (Code Review)
Pmiazga has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/391072 ) Change subject: Lower render queue timeout to 60 seconds .. Lower render queue timeout to 60 seconds Marco says "90s is too high

[MediaWiki-commits] [Gerrit] mediawiki...chromium-render[master]: Add timeout to requests in the queue

2017-11-13 Thread Pmiazga (Code Review)
Pmiazga has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/387642 ) Change subject: Add timeout to requests in the queue .. Add timeout to requests in the queue By default, tasks that are waiting in

[MediaWiki-commits] [Gerrit] mediawiki...chromium-render[master]: [POC]: An idea to bring QueueManagers into life

2017-11-09 Thread Pmiazga (Code Review)
Pmiazga has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/390294 ) Change subject: [POC]: An idea to bring QueueManagers into life .. [POC]: An idea to bring QueueManagers into life Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...WikimediaEvents[master]: Limit logged skins for print event only to vector and minerva

2017-10-27 Thread Pmiazga (Code Review)
Pmiazga has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/386911 ) Change subject: Limit logged skins for print event only to vector and minerva .. Limit logged skins for print event only to vector and

[MediaWiki-commits] [Gerrit] mediawiki...Collection[master]: [POC] Separation of concerns in BookRenderer

2017-10-05 Thread Pmiazga (Code Review)
Pmiazga has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/382609 ) Change subject: [POC] Separation of concerns in BookRenderer .. [POC] Separation of concerns in BookRenderer Changes: - introduced

[MediaWiki-commits] [Gerrit] mediawiki...Collection[master]: [WIP] Use SessionManager instead of wfSetupSession

2017-10-02 Thread Pmiazga (Code Review)
Pmiazga has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/381806 ) Change subject: [WIP] Use SessionManager instead of wfSetupSession .. [WIP] Use SessionManager instead of wfSetupSession wfSetupSession is

[MediaWiki-commits] [Gerrit] mediawiki...Collection[master]: Show banners about unavability of PDF rendering on error page

2017-10-02 Thread Pmiazga (Code Review)
Pmiazga has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/381804 ) Change subject: Show banners about unavability of PDF rendering on error page .. Show banners about unavability of PDF rendering on error

[MediaWiki-commits] [Gerrit] mediawiki...Collection[master]: DONOTMERGE: Detect book pages

2017-09-28 Thread Pmiazga (Code Review)
Pmiazga has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/381252 ) Change subject: DONOTMERGE: Detect book pages .. DONOTMERGE: Detect book pages Try to detect Book pages and present banners about

[MediaWiki-commits] [Gerrit] mediawiki...Collection[master]: Disable the Download section on Manage Books page

2017-09-25 Thread Pmiazga (Code Review)
Pmiazga has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/380572 ) Change subject: Disable the Download section on Manage Books page .. Disable the Download section on Manage Books page Changes: -

[MediaWiki-commits] [Gerrit] mediawiki...Collection[master]: Fix: Fix php warning for $writer variable

2017-09-25 Thread Pmiazga (Code Review)
Pmiazga has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/380511 ) Change subject: Fix: Fix php warning for $writer variable .. Fix: Fix php warning for $writer variable Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...Collection[master]: WIP: Message boxes about book creator undergoing changes

2017-09-21 Thread Pmiazga (Code Review)
Pmiazga has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/379647 ) Change subject: WIP: Message boxes about book creator undergoing changes .. WIP: Message boxes about book creator undergoing changes While

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Drop mfLazyLoadReferences and mfLazyLoadedImages cookies

2017-09-08 Thread Pmiazga (Code Review)
Pmiazga has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/376733 ) Change subject: Drop mfLazyLoadReferences and mfLazyLoadedImages cookies .. Drop mfLazyLoadReferences and mfLazyLoadedImages cookies The

[MediaWiki-commits] [Gerrit] mediawiki...Collection[master]: [WIP] Introduce extension.json

2017-09-01 Thread Pmiazga (Code Review)
Pmiazga has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/375444 ) Change subject: [WIP] Introduce extension.json .. [WIP] Introduce extension.json Changes: - Moved all necessary config options from

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Hygiene: wfMemcKey is deprectated, use BagOfStuff::makeKey()...

2017-09-01 Thread Pmiazga (Code Review)
Pmiazga has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/375424 ) Change subject: Hygiene: wfMemcKey is deprectated, use BagOfStuff::makeKey() instead .. Hygiene: wfMemcKey is deprectated, use

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Hygiene: cleanup SpecialMobileDiff and InlineDifferenceEngin...

2017-09-01 Thread Pmiazga (Code Review)
Pmiazga has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/375419 ) Change subject: Hygiene: cleanup SpecialMobileDiff and InlineDifferenceEngine classes .. Hygiene: cleanup SpecialMobileDiff and

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Move the mobile revision navigation links to top

2017-09-01 Thread Pmiazga (Code Review)
Pmiazga has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/375411 ) Change subject: Move the mobile revision navigation links to top .. Move the mobile revision navigation links to top To unify the browsing

[MediaWiki-commits] [Gerrit] mediawiki...MinervaNeue[master]: Hygiene: Bring missing SVGO config file from MobileFrontend

2017-08-30 Thread Pmiazga (Code Review)
Pmiazga has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/374827 ) Change subject: Hygiene: Bring missing SVGO config file from MobileFrontend .. Hygiene: Bring missing SVGO config file from MobileFrontend

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: Store map files under .json extension

2017-08-29 Thread Pmiazga (Code Review)
Pmiazga has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/374590 ) Change subject: Store map files under .json extension .. Store map files under .json extension We cannot serve .map files from production

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: Do not use keyword `const` as it's part of ES6 syntax

2017-08-29 Thread Pmiazga (Code Review)
Pmiazga has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/374552 ) Change subject: Do not use keyword `const` as it's part of ES6 syntax .. Do not use keyword `const` as it's part of ES6 syntax Changes:

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Fix incorrect Special:Userlogin name in Popups blacklist

2017-08-24 Thread Pmiazga (Code Review)
Pmiazga has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/373696 ) Change subject: Fix incorrect Special:Userlogin name in Popups blacklist .. Fix incorrect Special:Userlogin name in Popups blacklist

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: Use canonical name for NS_SPECIAL titles when checking the b...

2017-08-24 Thread Pmiazga (Code Review)
Pmiazga has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/373688 ) Change subject: Use canonical name for NS_SPECIAL titles when checking the blacklist .. Use canonical name for NS_SPECIAL titles when

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Verify the existance of `url` key when parsing lang objects

2017-08-17 Thread Pmiazga (Code Review)
Pmiazga has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/372473 ) Change subject: Verify the existance of `url` key when parsing lang objects .. Verify the existance of `url` key when parsing lang objects

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: if preview count stored in localStorage is not a number over...

2017-08-17 Thread Pmiazga (Code Review)
Pmiazga has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/372411 ) Change subject: if preview count stored in localStorage is not a number override it .. if preview count stored in localStorage is not a

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: getPreviewCountBucket should return unknown when no bucket i...

2017-08-15 Thread Pmiazga (Code Review)
Pmiazga has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/372056 ) Change subject: getPreviewCountBucket should return unknown when no bucket is found .. getPreviewCountBucket should return unknown when no

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: Allow 3rd party to check Popups enabled state by accessing m...

2017-08-02 Thread Pmiazga (Code Review)
Pmiazga has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/369711 ) Change subject: Allow 3rd party to check Popups enabled state by accessing mw.popups object .. Allow 3rd party to check Popups enabled

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Hygiene: Interwiki::getAllPrefixes() is deprecated use Media...

2017-08-02 Thread Pmiazga (Code Review)
Pmiazga has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/369657 ) Change subject: Hygiene: Interwiki::getAllPrefixes() is deprecated use MediaWikiServices instead .. Hygiene: Interwiki::getAllPrefixes()

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Hygiene: ParseCache::singleton() is deprecated, use MediaWik...

2017-08-02 Thread Pmiazga (Code Review)
Pmiazga has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/369654 ) Change subject: Hygiene: ParseCache::singleton() is deprecated, use MediaWikiServices instead .. Hygiene: ParseCache::singleton() is

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Hygiene: Stop using deprecated setWarning and dieUsage

2017-08-02 Thread Pmiazga (Code Review)
Pmiazga has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/369650 ) Change subject: Hygiene: Stop using deprecated setWarning and dieUsage .. Hygiene: Stop using deprecated setWarning and dieUsage Changes:

[MediaWiki-commits] [Gerrit] mediawiki...TextExtracts[master]: Hygiene: Remove deprecation and unused import

2017-08-02 Thread Pmiazga (Code Review)
Pmiazga has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/369645 ) Change subject: Hygiene: Remove deprecation and unused import .. Hygiene: Remove deprecation and unused import Changes: -

[MediaWiki-commits] [Gerrit] mediawiki...TextExtracts[master]: When APIParse fails log the warning and return null

2017-08-01 Thread Pmiazga (Code Review)
Pmiazga has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/369549 ) Change subject: When APIParse fails log the warning and return null .. When APIParse fails log the warning and return null API Parse

[MediaWiki-commits] [Gerrit] mediawiki...MinervaNeue[master]: Show cursor:text for JS-only users when hovering over search...

2017-07-31 Thread Pmiazga (Code Review)
Pmiazga has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/368816 ) Change subject: Show cursor:text for JS-only users when hovering over search input .. Show cursor:text for JS-only users when hovering

[MediaWiki-commits] [Gerrit] mediawiki...Vector[master]: Hygiene: Do not use ConfigFactory::getDefaultInstance()

2017-07-28 Thread Pmiazga (Code Review)
Pmiazga has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/368442 ) Change subject: Hygiene: Do not use ConfigFactory::getDefaultInstance() .. Hygiene: Do not use ConfigFactory::getDefaultInstance()

[MediaWiki-commits] [Gerrit] mediawiki...RelatedArticles[master]: ESLint should ignore vendor folder

2017-07-25 Thread Pmiazga (Code Review)
Pmiazga has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/367672 ) Change subject: ESLint should ignore vendor folder .. ESLint should ignore vendor folder On my machine `npm test` fails with a lot

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Allow Hooks::run() to use services.

2017-07-24 Thread Pmiazga (Code Review)
Pmiazga has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/367421 ) Change subject: Allow Hooks::run() to use services. .. Allow Hooks::run() to use services. Currently our hooks system uses lots of static

[MediaWiki-commits] [Gerrit] mediawiki...MinervaNeue[master]: Hygiene: Use ExtensionRegistry to manage skin dependencies

2017-07-24 Thread Pmiazga (Code Review)
Pmiazga has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/367405 ) Change subject: Hygiene: Use ExtensionRegistry to manage skin dependencies .. Hygiene: Use ExtensionRegistry to manage skin dependencies

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: Hygiene: Update required MediaWiki version

2017-07-24 Thread Pmiazga (Code Review)
Pmiazga has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/367402 ) Change subject: Hygiene: Update required MediaWiki version .. Hygiene: Update required MediaWiki version Per

[MediaWiki-commits] [Gerrit] mediawiki...BetaFeatures[master]: Hygiene: Define PHPUnit group for unit tests

2017-07-21 Thread Pmiazga (Code Review)
Pmiazga has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/366891 ) Change subject: Hygiene: Define PHPUnit group for unit tests .. Hygiene: Define PHPUnit group for unit tests While testing different

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: Hygiene: Dependency Injection for Popups

2017-07-21 Thread Pmiazga (Code Review)
Pmiazga has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/366874 ) Change subject: Hygiene: Dependency Injection for Popups .. Hygiene: Dependency Injection for Popups Changes: - removed ugly

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Skip ApiMobileViewTest::testView() as it is not possible to ...

2017-07-19 Thread Pmiazga (Code Review)
Pmiazga has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/366288 ) Change subject: Skip ApiMobileViewTest::testView() as it is not possible to reproduce .. Skip ApiMobileViewTest::testView() as it is not

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Unit tests have to use global RequestContext

2017-07-19 Thread Pmiazga (Code Review)
Pmiazga has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/366249 ) Change subject: Unit tests have to use global RequestContext .. Unit tests have to use global RequestContext ApiMobileView tests use

[MediaWiki-commits] [Gerrit] mediawiki...MinervaNeue[master]: Do not show warning box when LoginForm was posted

2017-07-17 Thread Pmiazga (Code Review)
Pmiazga has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/365871 ) Change subject: Do not show warning box when LoginForm was posted .. Do not show warning box when LoginForm was posted Because there is no

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: PHPUnitTets skins testsuite should pick up skins tests

2017-07-17 Thread Pmiazga (Code Review)
Pmiazga has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/365801 ) Change subject: PHPUnitTets skins testsuite should pick up skins tests .. PHPUnitTets skins testsuite should pick up skins tests CI on

[MediaWiki-commits] [Gerrit] mediawiki...MinervaNeue[master]: Hygiene: Setup and fix MinervaNeue unit tests suite

2017-07-17 Thread Pmiazga (Code Review)
Pmiazga has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/365711 ) Change subject: Hygiene: Setup and fix MinervaNeue unit tests suite .. Hygiene: Setup and fix MinervaNeue unit tests suite Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...MinervaNeue[master]: Hygiene: Introduce phpcs checks for MinervaNeue skin

2017-07-17 Thread Pmiazga (Code Review)
Pmiazga has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/365692 ) Change subject: Hygiene: Introduce phpcs checks for MinervaNeue skin .. Hygiene: Introduce phpcs checks for MinervaNeue skin Changes: -

[MediaWiki-commits] [Gerrit] mediawiki...MinervaNeue[master]: SkinMinerva testGetContextSpecificModule test might use unde...

2017-07-17 Thread Pmiazga (Code Review)
Pmiazga has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/365689 ) Change subject: SkinMinerva testGetContextSpecificModule test might use undefined title .. SkinMinerva testGetContextSpecificModule test

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Make autosuggest wordmatch bold without underline

2017-07-13 Thread Pmiazga (Code Review)
Pmiazga has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/365083 ) Change subject: Make autosuggest wordmatch bold without underline .. Make autosuggest wordmatch bold without underline Changes: - removed

[MediaWiki-commits] [Gerrit] mediawiki...RelatedArticles[master]: Restore default MediaWiki codesniffer configuration

2017-07-13 Thread Pmiazga (Code Review)
Pmiazga has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/365042 ) Change subject: Restore default MediaWiki codesniffer configuration .. Restore default MediaWiki codesniffer configuration Changes: -

[MediaWiki-commits] [Gerrit] mediawiki...PageImages[master]: Set up phpcs to detect all code style violations

2017-07-13 Thread Pmiazga (Code Review)
Pmiazga has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/365028 ) Change subject: Set up phpcs to detect all code style violations .. Set up phpcs to detect all code style violations Bug: T170583

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: Re-enable MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment....

2017-07-12 Thread Pmiazga (Code Review)
Pmiazga has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/364851 ) Change subject: Re-enable MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment sniff .. Re-enable

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: Re-enable MediaWiki.Commenting.FunctionComment.MissingDocume...

2017-07-12 Thread Pmiazga (Code Review)
Pmiazga has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/364850 ) Change subject: Re-enable MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic sniff .. Re-enable

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: Re-enable MediaWiki.Commenting.FunctionComment.MissingReturn...

2017-07-12 Thread Pmiazga (Code Review)
Pmiazga has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/364846 ) Change subject: Re-enable MediaWiki.Commenting.FunctionComment.MissingReturn sniff .. Re-enable

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: Re-enable MediaWiki.Commenting.FunctionComment.MissingParamT...

2017-07-12 Thread Pmiazga (Code Review)
Pmiazga has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/364845 ) Change subject: Re-enable MediaWiki.Commenting.FunctionComment.MissingParamTag sniff .. Re-enable

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: Re-enable MediaWiki.Commenting.FunctionComment.MissingParamC...

2017-07-12 Thread Pmiazga (Code Review)
Pmiazga has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/364843 ) Change subject: Re-enable MediaWiki.Commenting.FunctionComment.MissingParamComment sniff .. Re-enable

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: POC: Send disabled event from JS after Preferences save

2017-07-11 Thread Pmiazga (Code Review)
Pmiazga has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/364455 ) Change subject: POC: Send disabled event from JS after Preferences save .. POC: Send disabled event from JS after Preferences save First

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Remove deprected $wgUseTidy in favour of $wgTidyConfig

2017-07-07 Thread Pmiazga (Code Review)
Pmiazga has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/363863 ) Change subject: Remove deprected $wgUseTidy in favour of $wgTidyConfig .. Remove deprected $wgUseTidy in favour of $wgTidyConfig Bug:

[MediaWiki-commits] [Gerrit] mediawiki...TextExtracts[master]: Remove deprected $wgUseTidy in favour of TidyConfig

2017-07-07 Thread Pmiazga (Code Review)
Pmiazga has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/363860 ) Change subject: Remove deprected $wgUseTidy in favour of TidyConfig .. Remove deprected $wgUseTidy in favour of TidyConfig Bug: T168671

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: Send disabled event when user disables Page Preview

2017-07-06 Thread Pmiazga (Code Review)
Pmiazga has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/363642 ) Change subject: Send disabled event when user disables Page Preview .. Send disabled event when user disables Page Preview Changes: -

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: Remove duplicate events filtering

2017-07-05 Thread Pmiazga (Code Review)
Pmiazga has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/363377 ) Change subject: Remove duplicate events filtering .. Remove duplicate events filtering We had instrumentation for over 4 weeks and

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Pass old user options in PreferencesFormPreSave hook

2017-07-04 Thread Pmiazga (Code Review)
Pmiazga has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/363224 ) Change subject: Pass old user options in PreferencesFormPreSave hook .. Pass old user options in PreferencesFormPreSave hook Changes: -

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: POC: Hack user preferences and trigger event on user prefs save

2017-06-30 Thread Pmiazga (Code Review)
Pmiazga has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/362557 ) Change subject: POC: Hack user preferences and trigger event on user prefs save .. POC: Hack user preferences and trigger event on user

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: Enforce no top margins on lists on page previews

2017-06-30 Thread Pmiazga (Code Review)
Pmiazga has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/362454 ) Change subject: Enforce no top margins on lists on page previews .. Enforce no top margins on lists on page previews Changes: - set

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: Override eventLogging to enabled when debug flag is on

2017-06-30 Thread Pmiazga (Code Review)
Pmiazga has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/362434 ) Change subject: Override eventLogging to enabled when debug flag is on .. Override eventLogging to enabled when debug flag is on In order

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: Send disabled event from settings windows

2017-06-30 Thread Pmiazga (Code Review)
Pmiazga has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/362429 ) Change subject: Send disabled event from settings windows .. Send disabled event from settings windows Changes: - introduced new event

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: Allow events without linkInteractionToken to be logged

2017-06-29 Thread Pmiazga (Code Review)
Pmiazga has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/362315 ) Change subject: Allow events without linkInteractionToken to be logged .. Allow events without linkInteractionToken to be logged Changes:

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: If extract ends with ':' treat it as generic extract

2017-06-20 Thread Pmiazga (Code Review)
Pmiazga has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/360368 ) Change subject: If extract ends with ':' treat it as generic extract .. If extract ends with ':' treat it as generic extract We don't want

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: Do not show empty HTML previews

2017-06-19 Thread Pmiazga (Code Review)
Pmiazga has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/359954 ) Change subject: Do not show empty HTML previews .. Do not show empty HTML previews When HTML doesn't contain text nodes return an empty

[MediaWiki-commits] [Gerrit] mediawiki...ElectronPdfService[master]: Remove phan supress checks annotation

2017-06-19 Thread Pmiazga (Code Review)
Pmiazga has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/359939 ) Change subject: Remove phan supress checks annotation .. Remove phan supress checks annotation Phan configuration is now fixed and it

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Hygiene: Use ServiceWiringFiles extension.json property

2017-06-16 Thread Pmiazga (Code Review)
Pmiazga has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/359495 ) Change subject: Hygiene: Use ServiceWiringFiles extension.json property .. Hygiene: Use ServiceWiringFiles extension.json property Instead

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Remove unused wgPopupsAPIUseRESTBase config variable

2017-06-12 Thread Pmiazga (Code Review)
Pmiazga has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/358415 ) Change subject: Remove unused wgPopupsAPIUseRESTBase config variable .. Remove unused wgPopupsAPIUseRESTBase config variable In T165018 we

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Use the new wgPopupsGateway config variable instead

2017-06-09 Thread Pmiazga (Code Review)
Pmiazga has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/358091 ) Change subject: Use the new wgPopupsGateway config variable instead .. Use the new wgPopupsGateway config variable instead With T165018

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: Handle Restbase HTML response

2017-06-08 Thread Pmiazga (Code Review)
Pmiazga has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/357808 ) Change subject: Handle Restbase HTML response .. Handle Restbase HTML response Implement new Rest gateway that handles HTML responses

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: Extract rendering/parsing mediawiki responses into separate ...

2017-06-08 Thread Pmiazga (Code Review)
Pmiazga has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/357807 ) Change subject: Extract rendering/parsing mediawiki responses into separate class .. Extract rendering/parsing mediawiki responses into

[MediaWiki-commits] [Gerrit] mediawiki...ElectronPdfService[master]: Add warning message to Special:ElectronPdf

2017-06-01 Thread Pmiazga (Code Review)
Pmiazga has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/356776 ) Change subject: Add warning message to Special:ElectronPdf .. Add warning message to Special:ElectronPdf The warning is about the upcoming

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: Generate docs inside doc folder

2017-05-29 Thread Pmiazga (Code Review)
Pmiazga has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/356069 ) Change subject: Generate docs inside doc folder .. Generate docs inside doc folder Currently we have two docs folders: * doc which

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Title is not properly set inside ApiMobileView

2017-05-22 Thread Pmiazga (Code Review)
Pmiazga has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/355168 ) Change subject: Title is not properly set inside ApiMobileView .. Title is not properly set inside ApiMobileView ApiMobileView is creating

  1   2   >