[MediaWiki-commits] [Gerrit] wikimedia...process-control[master]: Organize examples into their own directory

2017-04-05 Thread Awight (Code Review)
Awight has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/346688 ) Change subject: Organize examples into their own directory .. Organize examples into their own directory Change-Id:

[MediaWiki-commits] [Gerrit] wikimedia...process-control[master]: Rename test to match new class name

2017-04-05 Thread Awight (Code Review)
Awight has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/346686 ) Change subject: Rename test to match new class name .. Rename test to match new class name Change-Id:

[MediaWiki-commits] [Gerrit] wikimedia...process-control[master]: make logfile path statically

2017-04-05 Thread Awight (Code Review)
Awight has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/346680 ) Change subject: make logfile path statically .. make logfile path statically This would be useful for reuse. Change-Id:

[MediaWiki-commits] [Gerrit] wikimedia...process-control[master]: Call a slug what it is

2017-04-05 Thread Awight (Code Review)
Awight has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/346679 ) Change subject: Call a slug what it is .. Call a slug what it is Change-Id: Ibe004d848462e58b0fabc974de9474ecf9dd29de --- M bin/run-job 1

[MediaWiki-commits] [Gerrit] wikimedia...process-control[master]: Log actual commandline rather than redundant parent job slug.

2017-04-05 Thread Awight (Code Review)
Awight has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/346681 ) Change subject: Log actual commandline rather than redundant parent job slug. .. Log actual commandline rather than redundant parent job

[MediaWiki-commits] [Gerrit] wikimedia...process-control[master]: [WIP] Implement "description" field

2017-04-05 Thread Awight (Code Review)
Awight has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/346670 ) Change subject: [WIP] Implement "description" field .. [WIP] Implement "description" field Change-Id:

[MediaWiki-commits] [Gerrit] wikimedia...process-control[master]: Handle commandline param like other fields.

2017-04-05 Thread Awight (Code Review)
Awight has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/346667 ) Change subject: Handle commandline param like other fields. .. Handle commandline param like other fields. Change-Id:

[MediaWiki-commits] [Gerrit] wikimedia...process-control[master]: Document a bit

2017-04-05 Thread Awight (Code Review)
Awight has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/346664 ) Change subject: Document a bit .. Document a bit Change-Id: I879936947ff4af826b173059e742637f9aeefaed --- M README.md A job.example.yaml M

[MediaWiki-commits] [Gerrit] wikimedia...process-control[master]: Remove debian metadata from the main repo

2017-04-05 Thread Awight (Code Review)
Awight has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/346643 ) Change subject: Remove debian metadata from the main repo .. Remove debian metadata from the main repo Change-Id:

[MediaWiki-commits] [Gerrit] wikimedia...process-control[master]: add license file

2017-04-05 Thread Awight (Code Review)
Awight has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/346641 ) Change subject: add license file .. add license file Change-Id: I3a8b5cf08749b96b5a784193017efa85e5d59144 --- A LICENSE.md 1 file changed,

[MediaWiki-commits] [Gerrit] wikimedia...process-control[master]: [WIP] Fix double-failmail after timeout.

2017-04-05 Thread Awight (Code Review)
Awight has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/346640 ) Change subject: [WIP] Fix double-failmail after timeout. .. [WIP] Fix double-failmail after timeout. Change-Id:

[MediaWiki-commits] [Gerrit] wikimedia...process-control[master]: Mirror child process output to console

2017-04-05 Thread Awight (Code Review)
Awight has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/346586 ) Change subject: Mirror child process output to console .. Mirror child process output to console Bug: T162294 Change-Id:

[MediaWiki-commits] [Gerrit] wikimedia...process-control[master]: Strip extra newline after job status

2017-04-05 Thread Awight (Code Review)
Awight has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/346585 ) Change subject: Strip extra newline after job status .. Strip extra newline after job status Change-Id:

[MediaWiki-commits] [Gerrit] wikimedia...process-control[master]: Include logfile path in failmails

2017-04-05 Thread Awight (Code Review)
Awight has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/346583 ) Change subject: Include logfile path in failmails .. Include logfile path in failmails Change-Id: I919594c5c1c0f5316038d6ae63267806092c433e

[MediaWiki-commits] [Gerrit] wikimedia...process-control[master]: Split job spec from job runner

2017-04-05 Thread Awight (Code Review)
Awight has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/346574 ) Change subject: Split job spec from job runner .. Split job spec from job runner Change-Id: I44e976f46c7159e02c431c470e74e54f8ad12229 --- M

[MediaWiki-commits] [Gerrit] wikimedia...process-control[master]: Don't log logging settings

2017-04-05 Thread Awight (Code Review)
Awight has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/346571 ) Change subject: Don't log logging settings .. Don't log logging settings Remove a not particularly helpful message. Change-Id:

[MediaWiki-commits] [Gerrit] wikimedia...process-control[master]: Syslogs point at syslogd

2017-04-04 Thread Awight (Code Review)
Awight has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/346480 ) Change subject: Syslogs point at syslogd .. Syslogs point at syslogd Change-Id: I3a9e64b7c0500edb57d2c7565b507770046494fc --- M

[MediaWiki-commits] [Gerrit] wikimedia...process-control[master]: Timeout should be given in minutes

2017-04-04 Thread Awight (Code Review)
Awight has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/346344 ) Change subject: Timeout should be given in minutes .. Timeout should be given in minutes Change-Id:

[MediaWiki-commits] [Gerrit] wikimedia...process-control[master]: Cast environment variables to string

2017-04-04 Thread Awight (Code Review)
Awight has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/346317 ) Change subject: Cast environment variables to string .. Cast environment variables to string execve can't handle numeric types, etc.

[MediaWiki-commits] [Gerrit] wikimedia...process-control[master]: Fix CLI syntax for run-job in the generated crontab

2017-04-04 Thread Awight (Code Review)
Awight has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/346314 ) Change subject: Fix CLI syntax for run-job in the generated crontab .. Fix CLI syntax for run-job in the generated crontab Change-Id:

[MediaWiki-commits] [Gerrit] wikimedia...process-control[master]: Copy logging to stdout when run interactively

2017-04-03 Thread Awight (Code Review)
Awight has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/346230 ) Change subject: Copy logging to stdout when run interactively .. Copy logging to stdout when run interactively Change-Id:

[MediaWiki-commits] [Gerrit] wikimedia...process-control[master]: Protect against symlinks and ".." directory transversal

2017-04-03 Thread Awight (Code Review)
Awight has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/346229 ) Change subject: Protect against symlinks and ".." directory transversal .. Protect against symlinks and ".." directory transversal

[MediaWiki-commits] [Gerrit] wikimedia...process-control[master]: Assert stderr goes to the output file

2017-04-03 Thread Awight (Code Review)
Awight has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/346207 ) Change subject: Assert stderr goes to the output file .. Assert stderr goes to the output file Change-Id:

[MediaWiki-commits] [Gerrit] wikimedia...process-control[master]: Only run jobs as the service user

2017-04-03 Thread Awight (Code Review)
Awight has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/346202 ) Change subject: Only run jobs as the service user .. Only run jobs as the service user Change-Id: Ia12f06f07a1b4d77b6fa3f69fc121ab1c1b10419

[MediaWiki-commits] [Gerrit] wikimedia...process-control[master]: Relax a test until we can fix the potential double-failmail.

2017-03-30 Thread Awight (Code Review)
Awight has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/345781 ) Change subject: Relax a test until we can fix the potential double-failmail. .. Relax a test until we can fix the potential double-failmail.

[MediaWiki-commits] [Gerrit] wikimedia...process-control[master]: Wrap yaml load in file context managers

2017-03-30 Thread Awight (Code Review)
Awight has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/345660 ) Change subject: Wrap yaml load in file context managers .. Wrap yaml load in file context managers Change-Id:

[MediaWiki-commits] [Gerrit] wikimedia...process-control[master]: Document hardcoded /etc path

2017-03-30 Thread Awight (Code Review)
Awight has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/345654 ) Change subject: Document hardcoded /etc path .. Document hardcoded /etc path Change-Id: Id89f919f80724e6955f8480a33801bd672be9c10 --- M

[MediaWiki-commits] [Gerrit] wikimedia...process-control[master]: "make clean" target

2017-03-29 Thread Awight (Code Review)
Awight has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/345482 ) Change subject: "make clean" target .. "make clean" target Change-Id: I9f164531afdd765321dd466372ba7c4be9cd1173 --- M Makefile 1 file

[MediaWiki-commits] [Gerrit] wikimedia...process-control[master]: Remove unnecessary build dependency

2017-03-29 Thread Awight (Code Review)
Awight has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/345483 ) Change subject: Remove unnecessary build dependency .. Remove unnecessary build dependency Note that the deb packaging for precise still

[MediaWiki-commits] [Gerrit] wikimedia...process-control[master]: Short -l flag for --list-jobs

2017-03-29 Thread Awight (Code Review)
Awight has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/345480 ) Change subject: Short -l flag for --list-jobs .. Short -l flag for --list-jobs Change-Id: I9dfa92e0bcad0bb8b5d3206e753261f2aa120a93 --- M

[MediaWiki-commits] [Gerrit] wikimedia...process-control[master]: Force a pythonic build, ignoring the Makefile

2017-03-29 Thread Awight (Code Review)
Awight has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/345479 ) Change subject: Force a pythonic build, ignoring the Makefile .. Force a pythonic build, ignoring the Makefile Note that the deb packaging

[MediaWiki-commits] [Gerrit] wikimedia...process-control[master]: Run commands in sequence

2017-03-29 Thread Awight (Code Review)
Awight has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/345429 ) Change subject: Run commands in sequence .. Run commands in sequence Bug: T161035 Change-Id: I6f4473881da4e81bab1777bf747ee87e6d1d61d1 ---

[MediaWiki-commits] [Gerrit] wikimedia...process-control[master]: Bump version: 0.0.2

2017-03-28 Thread Awight (Code Review)
Awight has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/345273 ) Change subject: Bump version: 0.0.2 .. Bump version: 0.0.2 Change-Id: I2b80ed8663fb1ea8a615da65d5b29ea5dabfbf64 --- M Makefile M

[MediaWiki-commits] [Gerrit] wikimedia...process-control[master]: mini-lock login encapsulation

2017-03-28 Thread Awight (Code Review)
Awight has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/345265 ) Change subject: mini-lock login encapsulation .. mini-lock login encapsulation Change-Id: I432e10c6ec653af7ec49c97aed910c9695285985 --- M

[MediaWiki-commits] [Gerrit] wikimedia...process-control[master]: Nicer log capture

2017-03-28 Thread Awight (Code Review)
Awight has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/345260 ) Change subject: Nicer log capture .. Nicer log capture Change-Id: I9e7d92a75823e3bff80a53694d712ab48fb63a8f --- M tests/test_job_wrapper.py

[MediaWiki-commits] [Gerrit] wikimedia...process-control[master]: Log notable events

2017-03-28 Thread Awight (Code Review)
Awight has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/345236 ) Change subject: Log notable events .. Log notable events Change-Id: I668b70ce8701a4e1ad3de8420b7e49f17190f6dd --- M bin/cron-generate M

[MediaWiki-commits] [Gerrit] wikimedia...process-control[master]: Log, don't print

2017-03-28 Thread Awight (Code Review)
Awight has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/345221 ) Change subject: Log, don't print .. Log, don't print Change-Id: I35f263e6bba7fe4bfa16e5bfba57e39cf436cd18 --- M

[MediaWiki-commits] [Gerrit] wikimedia...process-control[master]: Initialize Python logging from global configuration

2017-03-28 Thread Awight (Code Review)
Awight has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/345202 ) Change subject: Initialize Python logging from global configuration .. Initialize Python logging from global configuration Change-Id:

[MediaWiki-commits] [Gerrit] wikimedia...process-control[master]: Only speak in slugs

2017-03-28 Thread Awight (Code Review)
Awight has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/345094 ) Change subject: Only speak in slugs .. Only speak in slugs Don't use direct job paths, even internally. Slugs are always relative to the

[MediaWiki-commits] [Gerrit] wikimedia...process-control[master]: [WIP] Tests for signal handling

2017-03-28 Thread Awight (Code Review)
Awight has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/345095 ) Change subject: [WIP] Tests for signal handling .. [WIP] Tests for signal handling Change-Id: Ibf6ccd57709c6acae705b450153d067b658695d3 ---

[MediaWiki-commits] [Gerrit] wikimedia...process-control[master]: Configurable working files directory, run_dir

2017-03-27 Thread Awight (Code Review)
Awight has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/345089 ) Change subject: Configurable working files directory, run_dir .. Configurable working files directory, run_dir Change-Id:

[MediaWiki-commits] [Gerrit] wikimedia...process-control[master]: Store job slug

2017-03-27 Thread Awight (Code Review)
Awight has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/345088 ) Change subject: Store job slug .. Store job slug Change-Id: Idd712c33f1f32a64ada876cc988425a39613005e --- M processcontrol/job_wrapper.py 1

[MediaWiki-commits] [Gerrit] wikimedia...process-control[master]: Fix crontab CLI params

2017-03-27 Thread Awight (Code Review)
Awight has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/345071 ) Change subject: Fix crontab CLI params .. Fix crontab CLI params Change-Id: I06307b498a051ec3998ca43e197953358fc9edac --- M

[MediaWiki-commits] [Gerrit] wikimedia...process-control[master]: update README

2017-03-27 Thread Awight (Code Review)
Awight has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/345063 ) Change subject: update README .. update README Change-Id: I7c41c91ae4eb644c6a34414fceca4fdbbd51877c --- M README.md 1 file changed, 7

[MediaWiki-commits] [Gerrit] wikimedia...process-control[master]: --kill-job

2017-03-27 Thread Awight (Code Review)
Awight has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/345062 ) Change subject: --kill-job .. --kill-job Change-Id: Ia181aa495eabf34242293cb60904594ee3766b5c --- M bin/run-job M

[MediaWiki-commits] [Gerrit] wikimedia...process-control[master]: Show job status in --list-jobs

2017-03-27 Thread Awight (Code Review)
Awight has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/345022 ) Change subject: Show job status in --list-jobs .. Show job status in --list-jobs Change-Id: Ie99758202547130b711769a24186c30b67cb9729 --- M

[MediaWiki-commits] [Gerrit] wikimedia...process-control[master]: --list-jobs action

2017-03-27 Thread Awight (Code Review)
Awight has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/345008 ) Change subject: --list-jobs action .. --list-jobs action Change-Id: I0f1b8594d6660e59c69b4cacbd38c82ffbecd018 --- M bin/run-job 1 file

[MediaWiki-commits] [Gerrit] wikimedia...process-control[master]: Makefile for lulz

2017-03-27 Thread Awight (Code Review)
Awight has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/345006 ) Change subject: Makefile for lulz .. Makefile for lulz Change-Id: I1ef204525c452f9b2991031eeb3019d6dbf20587 --- A Makefile 1 file changed,

[MediaWiki-commits] [Gerrit] wikimedia...process-control[master]: ignore build products

2017-03-27 Thread Awight (Code Review)
Awight has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/344980 ) Change subject: ignore build products .. ignore build products Change-Id: Id7238108dc12600f2c7626b2a765c533e27d3198 --- M .gitignore 1 file

[MediaWiki-commits] [Gerrit] wikimedia...process-control[master]: zero-argument mode from cron-generate

2017-03-27 Thread Awight (Code Review)
Awight has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/344979 ) Change subject: zero-argument mode from cron-generate .. zero-argument mode from cron-generate Get all config from config. Change-Id:

[MediaWiki-commits] [Gerrit] wikimedia...vendor[master]: [HOTFIX] Patch orphan rectifier to drop non-cc records

2017-03-23 Thread Awight (Code Review)
Awight has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/344552 ) Change subject: [HOTFIX] Patch orphan rectifier to drop non-cc records .. [HOTFIX] Patch orphan rectifier to drop non-cc records NOTE:

[MediaWiki-commits] [Gerrit] mediawiki...DonationInterface[master]: Patch orphan rectifier to drop non-cc records

2017-03-23 Thread Awight (Code Review)
Awight has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/344545 ) Change subject: Patch orphan rectifier to drop non-cc records .. Patch orphan rectifier to drop non-cc records Bug: T161160 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...DonationInterface[deployment]: Patch orphan rectifier to drop non-cc records

2017-03-23 Thread Awight (Code Review)
Awight has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/344542 ) Change subject: Patch orphan rectifier to drop non-cc records .. Patch orphan rectifier to drop non-cc records Bug: T161160 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...DonationInterface[deployment]: Merge master into deployment

2017-03-23 Thread Awight (Code Review)
Awight has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/344541 ) Change subject: Merge master into deployment .. Merge master into deployment 9b6c8bf9912b143986e8e0a00b0aa6b0f76bdb33 Add composer.json

[MediaWiki-commits] [Gerrit] wikimedia...process-control[master]: Test for environment parameter

2017-03-23 Thread Awight (Code Review)
Awight has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/344501 ) Change subject: Test for environment parameter .. Test for environment parameter Change-Id: I7739f28ca9fd3b11754a5eae0c10ee59a034d384 --- A

[MediaWiki-commits] [Gerrit] wikimedia...process-control[master]: run-job option flag is required now

2017-03-23 Thread Awight (Code Review)
Awight has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/344499 ) Change subject: run-job option flag is required now .. run-job option flag is required now Change-Id:

[MediaWiki-commits] [Gerrit] wikimedia...process-control[master]: Pass environment variables to the subprocess

2017-03-22 Thread Awight (Code Review)
Awight has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/344279 ) Change subject: Pass environment variables to the subprocess .. Pass environment variables to the subprocess Change-Id:

[MediaWiki-commits] [Gerrit] wikimedia...process-control[master]: Copy example configuration to docs during install

2017-03-22 Thread Awight (Code Review)
Awight has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/344273 ) Change subject: Copy example configuration to docs during install .. Copy example configuration to docs during install Change-Id:

[MediaWiki-commits] [Gerrit] wikimedia...process-control[master]: Remove unused config inline defaults

2017-03-22 Thread Awight (Code Review)
Awight has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/344260 ) Change subject: Remove unused config inline defaults .. Remove unused config inline defaults Change-Id:

[MediaWiki-commits] [Gerrit] wikimedia...process-control[master]: More cron syntax checks

2017-03-22 Thread Awight (Code Review)
Awight has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/344189 ) Change subject: More cron syntax checks .. More cron syntax checks Change-Id: I956eae9ffea489c6a82703080ada89fe1826ddbe --- M

[MediaWiki-commits] [Gerrit] wikimedia...process-control[master]: stdout_destination is required. You'll have to say "/dev/nu...

2017-03-22 Thread Awight (Code Review)
Awight has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/344181 ) Change subject: stdout_destination is required. You'll have to say "/dev/null" out loud if you want it. .. stdout_destination is required.

[MediaWiki-commits] [Gerrit] mediawiki...DonationInterface[master]: [WIP] Encapsulate errors

2017-03-21 Thread Awight (Code Review)
Awight has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/344042 ) Change subject: [WIP] Encapsulate errors .. [WIP] Encapsulate errors TODO: * Figure out how to represent validation errors and internal

[MediaWiki-commits] [Gerrit] mediawiki...DonationInterface[master]: Remove an unused default parameter

2017-03-21 Thread Awight (Code Review)
Awight has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/343969 ) Change subject: Remove an unused default parameter .. Remove an unused default parameter Change-Id:

[MediaWiki-commits] [Gerrit] wikimedia...process-control[master]: Fixes suggested by thcipriani

2017-03-21 Thread Awight (Code Review)
Awight has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/343965 ) Change subject: Fixes suggested by thcipriani .. Fixes suggested by thcipriani Change-Id: I03592650c63907ffa4e14a1a136372bff3038f79 --- M

[MediaWiki-commits] [Gerrit] wikimedia...process-control[master]: Use argparse to read the CLI; cron-generate is flaggy rather...

2017-03-21 Thread Awight (Code Review)
Awight has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/343960 ) Change subject: Use argparse to read the CLI; cron-generate is flaggy rather than pipey .. Use argparse to read the CLI; cron-generate is

[MediaWiki-commits] [Gerrit] wikimedia...process-control[master]: target python2 for now

2017-03-21 Thread Awight (Code Review)
Awight has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/343954 ) Change subject: target python2 for now .. target python2 for now Change-Id: I5eaa0aa4380f54263eadfd208584ef9c3bee2c22 --- M

[MediaWiki-commits] [Gerrit] wikimedia...process-control[master]: Merge branch 'debian-packaging' of github.com:adamwight/proc...

2017-03-21 Thread Awight (Code Review)
Awight has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/343921 ) Change subject: Merge branch 'debian-packaging' of github.com:adamwight/process-control into debian-packaging .. Merge branch

[MediaWiki-commits] [Gerrit] mediawiki...DonationInterface[master]: [WIP] Perform currency fallback earlier

2017-03-20 Thread Awight (Code Review)
Awight has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/343795 ) Change subject: [WIP] Perform currency fallback earlier .. [WIP] Perform currency fallback earlier This allows us to validate the changed

[MediaWiki-commits] [Gerrit] wikimedia...process-control[master]: House modules under a package

2017-03-20 Thread Awight (Code Review)
Awight has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/343764 ) Change subject: House modules under a package .. House modules under a package Change-Id: Ifa551b4db4a4e7557c40fbfec4ecf72af8b135b6 --- M

[MediaWiki-commits] [Gerrit] wikimedia...process-control[master]: Only run under python3

2017-03-20 Thread Awight (Code Review)
Awight has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/343763 ) Change subject: Only run under python3 .. Only run under python3 Change-Id: If41707720ee3309241fec3ea5b5d5bd490bffba0 --- M

[MediaWiki-commits] [Gerrit] wikimedia...process-control[master]: Barely functional debian packaging

2017-03-20 Thread Awight (Code Review)
Awight has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/343762 ) Change subject: Barely functional debian packaging .. Barely functional debian packaging Change-Id:

[MediaWiki-commits] [Gerrit] wikimedia...process-control[master]: Create a bin dir

2017-03-20 Thread Awight (Code Review)
Awight has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/343761 ) Change subject: Create a bin dir .. Create a bin dir Change-Id: I7790f12316f0203511ffa82e37521231fa4dca2f --- M README.md R

[MediaWiki-commits] [Gerrit] wikimedia...process-control[master]: [WIP] Debian packaging

2017-03-16 Thread Awight (Code Review)
Awight has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/343218 ) Change subject: [WIP] Debian packaging .. [WIP] Debian packaging Change-Id: Ib4a8481ecc40e72e39c4670bad93786505f8d0d1 TODO: Making empty

[MediaWiki-commits] [Gerrit] wikimedia...process-control[master]: DO NOT MERGE: instrument the damn test

2017-03-16 Thread Awight (Code Review)
Awight has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/343213 ) Change subject: DO NOT MERGE: instrument the damn test .. DO NOT MERGE: instrument the damn test Change-Id:

[MediaWiki-commits] [Gerrit] wikimedia...process-control[master]: Note that you have to quote crontab due to its punctuation

2017-03-16 Thread Awight (Code Review)
Awight has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/343212 ) Change subject: Note that you have to quote crontab due to its punctuation .. Note that you have to quote crontab due to its punctuation

[MediaWiki-commits] [Gerrit] wikimedia...process-control[master]: "disabled" flag

2017-03-16 Thread Awight (Code Review)
Awight has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/343195 ) Change subject: "disabled" flag .. "disabled" flag Change-Id: I055c025544c8f194cd9cfe2d21d43efadb7b5c43 --- M README.md M crontab.py M

[MediaWiki-commits] [Gerrit] wikimedia...process-control[master]: Rough pass at crontab tweezer

2017-03-16 Thread Awight (Code Review)
Awight has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/343171 ) Change subject: Rough pass at crontab tweezer .. Rough pass at crontab tweezer Change-Id: I200787ae2f86e3caacbc02db0f674f3c08755533 --- M

[MediaWiki-commits] [Gerrit] wikimedia...process-control[debian-packaging]: [WIP] Debian packaging

2017-03-16 Thread Awight (Code Review)
Awight has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/343129 ) Change subject: [WIP] Debian packaging .. [WIP] Debian packaging Change-Id: Ib4a8481ecc40e72e39c4670bad93786505f8d0d1 TODO: Making empty

[MediaWiki-commits] [Gerrit] wikimedia...process-control[master]: More docs

2017-03-16 Thread Awight (Code Review)
Awight has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/343124 ) Change subject: More docs .. More docs Change-Id: Id210abfa259c8f3bc2c9e62ba8fc2907554fc70a --- M README.md 1 file changed, 29

[MediaWiki-commits] [Gerrit] wikimedia...process-control[master]: Fix flake8 typos

2017-03-16 Thread Awight (Code Review)
Awight has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/343121 ) Change subject: Fix flake8 typos .. Fix flake8 typos Change-Id: I7b76505cb5c02db1fbe1eb7350f5a3c59d28c459 --- M lock.py M

[MediaWiki-commits] [Gerrit] wikimedia...process-control[master]: Config validation

2017-03-16 Thread Awight (Code Review)
Awight has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/343120 ) Change subject: Config validation .. Config validation Change-Id: Id9783d59eb69c82a1552b6ef330dbed830cefe86 --- M README.md M

[MediaWiki-commits] [Gerrit] integration/config[master]: Run tox for new repo

2017-03-16 Thread Awight (Code Review)
Awight has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/343113 ) Change subject: Run tox for new repo .. Run tox for new repo Change-Id: Iaa04f8cf6bc6dac0c9efc3109b3badea938d2fa8 --- M zuul/layout.yaml 1

[MediaWiki-commits] [Gerrit] wikimedia...process-control[master]: Add .gitreview

2017-03-16 Thread Awight (Code Review)
Awight has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/342967 ) Change subject: Add .gitreview .. Add .gitreview Change-Id: I027ec8c2450799814e2929d6681d15ea1c8ddb8d --- A .gitreview 1 file

[MediaWiki-commits] [Gerrit] wikimedia...process-control[master]: Correct failopen test

2017-03-15 Thread Awight (Code Review)
Awight has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/342970 ) Change subject: Correct failopen test .. Correct failopen test Change-Id: I2316941b63079c8a7845cf957091c72ddfdda8d1 --- M

[MediaWiki-commits] [Gerrit] wikimedia...process-control[master]: test failopen; py3

2017-03-15 Thread Awight (Code Review)
Awight has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/342969 ) Change subject: test failopen; py3 .. test failopen; py3 Change-Id: Id33866f7887aa404f453cf5ced6307fd83e2c2fd --- M lock.py M

[MediaWiki-commits] [Gerrit] wikimedia...process-control[master]: Tests for the lock module

2017-03-15 Thread Awight (Code Review)
Awight has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/342968 ) Change subject: Tests for the lock module .. Tests for the lock module Change-Id: I242a42518e1eaab5c8b039af2ac75615db9d01cc --- M lock.py M

[MediaWiki-commits] [Gerrit] wikimedia...process-control[master]: Add .gitreview

2017-03-15 Thread Awight (Code Review)
Awight has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/342967 ) Change subject: Add .gitreview .. Add .gitreview Change-Id: I027ec8c2450799814e2929d6681d15ea1c8ddb8d --- A .gitreview 1 file changed, 6

[MediaWiki-commits] [Gerrit] wikimedia...process-control[master]: 100% test coverage

2017-03-15 Thread Awight (Code Review)
Awight has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/342971 ) Change subject: 100% test coverage .. 100% test coverage Change-Id: I80fc8f0abf20ec0d0f971f4da3762e4f7a41b448 --- M .gitignore D

[MediaWiki-commits] [Gerrit] mediawiki...DonationInterface[master]: [WIP] A few changes. distinguish between unstaged and norma...

2017-03-13 Thread Awight (Code Review)
Awight has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/342553 ) Change subject: [WIP] A few changes. distinguish between unstaged and normalized, split construct, validate and stage steps. .. [WIP] A

[MediaWiki-commits] [Gerrit] mediawiki...DonationInterface[master]: Comments and todos

2017-03-13 Thread Awight (Code Review)
Awight has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/342547 ) Change subject: Comments and todos .. Comments and todos Change-Id: I16be18f5618cb34b341b6c3b76c730b928f727c9 --- M

[MediaWiki-commits] [Gerrit] mediawiki...DonationInterface[master]: Correct parameters to wfMessage

2017-03-13 Thread Awight (Code Review)
Awight has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/342548 ) Change subject: Correct parameters to wfMessage .. Correct parameters to wfMessage FIXME: Wrap a more sane API than wfMessage. Use the

[MediaWiki-commits] [Gerrit] mediawiki...DonationInterface[master]: [WIP] Play with stringification

2017-03-10 Thread Awight (Code Review)
Awight has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/342176 ) Change subject: [WIP] Play with stringification .. [WIP] Play with stringification Change-Id: Ida2727720bd27eb26d789b026d497cf158fe1540 ---

[MediaWiki-commits] [Gerrit] mediawiki...DonationInterface[master]: Stop prematurely escaping

2017-03-09 Thread Awight (Code Review)
Awight has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/342047 ) Change subject: Stop prematurely escaping .. Stop prematurely escaping Escaping should be done before HTML display, not as

[MediaWiki-commits] [Gerrit] mediawiki...DonationInterface[master]: [WIP] Put the ctor sequence back as it was, fix fatals.

2017-03-08 Thread Awight (Code Review)
Awight has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/341848 ) Change subject: [WIP] Put the ctor sequence back as it was, fix fatals. .. [WIP] Put the ctor sequence back as it was, fix fatals.

[MediaWiki-commits] [Gerrit] mediawiki...DonationInterface[master]: [WIP] Do not pass go. This has gone too far, constructor or...

2017-03-07 Thread Awight (Code Review)
Awight has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/341748 ) Change subject: [WIP] Do not pass go. This has gone too far, constructor order is fragile. .. [WIP] Do not pass go. This has gone too

[MediaWiki-commits] [Gerrit] mediawiki...DonationInterface[master]: [WIP] snippet for grading

2017-03-07 Thread Awight (Code Review)
Awight has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/341726 ) Change subject: [WIP] snippet for grading .. [WIP] snippet for grading Change-Id: Id6fbe69fa1ce2f0575a2deb2c4bbcdf8ab0d6898 --- M

[MediaWiki-commits] [Gerrit] mediawiki...DonationInterface[master]: [WIP] Deprecate "manual" errors

2017-03-07 Thread Awight (Code Review)
Awight has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/341727 ) Change subject: [WIP] Deprecate "manual" errors .. [WIP] Deprecate "manual" errors The original intent may have been a firewall between the

[MediaWiki-commits] [Gerrit] mediawiki...DonationInterface[master]: Remove deprecated function

2017-03-07 Thread Awight (Code Review)
Awight has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/341721 ) Change subject: Remove deprecated function .. Remove deprecated function Change-Id: I2a36b910b7181fc4db101bfd90cdbb41cf372181 --- M

[MediaWiki-commits] [Gerrit] mediawiki...DonationInterface[master]: [WIP] Remove irrelevant test?

2017-03-07 Thread Awight (Code Review)
Awight has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/341722 ) Change subject: [WIP] Remove irrelevant test? .. [WIP] Remove irrelevant test? However, this test is failing on

[MediaWiki-commits] [Gerrit] mediawiki...DonationInterface[master]: [WIP] Form did not validate if manual errors are present

2017-03-07 Thread Awight (Code Review)
Awight has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/341592 ) Change subject: [WIP] Form did not validate if manual errors are present .. [WIP] Form did not validate if manual errors are present TODO:

<    1   2   3   4   5   6   7   8   9   10   >