[MediaWiki-commits] [Gerrit] Organise Flat/ElementLinerData methods and tests - change (mediawiki...VisualEditor)

2013-12-10 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/100596 Change subject: Organise Flat/ElementLinerData methods and tests .. Organise Flat/ElementLinerData methods and tests Move

[MediaWiki-commits] [Gerrit] Add missing tests to FlatLinearData - change (mediawiki...VisualEditor)

2013-12-10 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/100597 Change subject: Add missing tests to FlatLinearData .. Add missing tests to FlatLinearData Change-Id:

[MediaWiki-commits] [Gerrit] Fix paste sequence in Firefox - change (mediawiki...VisualEditor)

2013-12-10 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/100613 Change subject: Fix paste sequence in Firefox .. Fix paste sequence in Firefox It appears that if the pasteTarget is given focus too close

[MediaWiki-commits] [Gerrit] Remove ve-pasteProtect class when falling back to clipboardData - change (mediawiki...VisualEditor)

2013-12-10 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/100624 Change subject: Remove ve-pasteProtect class when falling back to clipboardData .. Remove ve-pasteProtect class when falling back to

[MediaWiki-commits] [Gerrit] Move removeHtmlAttribute into ve.dm.Model - change (mediawiki...VisualEditor)

2013-12-11 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/100773 Change subject: Move removeHtmlAttribute into ve.dm.Model .. Move removeHtmlAttribute into ve.dm.Model Make available as a method and a

[MediaWiki-commits] [Gerrit] Fix issues with copy-pasting MWTransclusionNodes - change (mediawiki...VisualEditor)

2013-12-11 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/100775 Change subject: Fix issues with copy-pasting MWTransclusionNodes .. Fix issues with copy-pasting MWTransclusionNodes

[MediaWiki-commits] [Gerrit] Format MW example HTML - change (mediawiki...VisualEditor)

2013-12-11 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/100774 Change subject: Format MW example HTML .. Format MW example HTML For readability Change-Id: I7e58fd71a0a34e2e11bf93b1f088e4c87795b748 ---

[MediaWiki-commits] [Gerrit] Allow tables to contain captions! - change (mediawiki...VisualEditor)

2013-12-11 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/100792 Change subject: Allow tables to contain captions! .. Allow tables to contain captions! Captions were not in the allowed lists of children

[MediaWiki-commits] [Gerrit] Move resetting of paste state variables to after afterPaste - change (mediawiki...VisualEditor)

2013-12-11 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/100827 Change subject: Move resetting of paste state variables to after afterPaste .. Move resetting of paste state variables to after afterPaste

[MediaWiki-commits] [Gerrit] Strip empty spans after style attributes have been removed - change (mediawiki...VisualEditor)

2013-12-11 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/100912 Change subject: Strip empty spans after style attributes have been removed .. Strip empty spans after style attributes have been removed

[MediaWiki-commits] [Gerrit] Add recursion to removeHtmlAttribute - change (mediawiki...VisualEditor)

2013-12-11 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/100935 Change subject: Add recursion to removeHtmlAttribute .. Add recursion to removeHtmlAttribute This is pretty straightforward because the

[MediaWiki-commits] [Gerrit] Rename getDataFromDom to getDataFromDomSubtree - change (mediawiki...VisualEditor)

2013-12-12 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/100992 Change subject: Rename getDataFromDom to getDataFromDomSubtree .. Rename getDataFromDom to getDataFromDomSubtree To match its inverse

[MediaWiki-commits] [Gerrit] Add getDomSubtreeFromModel to converter API - change (mediawiki...VisualEditor)

2013-12-12 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/100993 Change subject: Add getDomSubtreeFromModel to converter API .. Add getDomSubtreeFromModel to converter API This means we no longer have to

[MediaWiki-commits] [Gerrit] Check InternalList node exists when rendering MWReferenceList - change (mediawiki...VisualEditor)

2013-12-12 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/101131 Change subject: Check InternalList node exists when rendering MWReferenceList .. Check InternalList node exists when rendering

[MediaWiki-commits] [Gerrit] Check values property exists before remove attribute - change (mediawiki...VisualEditor)

2013-12-12 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/101148 Change subject: Check values property exists before remove attribute .. Check values property exists before remove attribute Apparently

[MediaWiki-commits] [Gerrit] Add useful HTML in toDomElements for refs and templates. - change (mediawiki...VisualEditor)

2013-12-13 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/101231 Change subject: Add useful HTML in toDomElements for refs and templates. .. Add useful HTML in toDomElements for refs and templates. For

[MediaWiki-commits] [Gerrit] Fix hashes in MW toDomElement functions - change (mediawiki...VisualEditor)

2013-12-13 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/101228 Change subject: Fix hashes in MW toDomElement functions .. Fix hashes in MW toDomElement functions Hashes weren't using the new [ object,

[MediaWiki-commits] [Gerrit] Move index label generation to the model - change (mediawiki...VisualEditor)

2013-12-13 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/101230 Change subject: Move index label generation to the model .. Move index label generation to the model Also make available as a static

[MediaWiki-commits] [Gerrit] data-ve-ignore attribute for elements to be complete ignored... - change (mediawiki...VisualEditor)

2013-12-13 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/101229 Change subject: data-ve-ignore attribute for elements to be complete ignored by the converter .. data-ve-ignore attribute for elements to

[MediaWiki-commits] [Gerrit] JSCS fixes - change (mediawiki...VisualEditor)

2013-12-13 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/101456 Change subject: JSCS fixes .. JSCS fixes Change-Id: I11032f05eaee1e8c895e06ebbc9c329cbc70c8c0 --- M

[MediaWiki-commits] [Gerrit] Prevent link-annotating MWReferences - change (mediawiki...VisualEditor)

2013-11-19 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/96238 Change subject: Prevent link-annotating MWReferences .. Prevent link-annotating MWReferences As it isn't sensible wikitext. Bug: 56250

[MediaWiki-commits] [Gerrit] Tear down the save dialog and remove it from memory on surfa... - change (mediawiki...VisualEditor)

2013-11-27 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/97913 Change subject: Tear down the save dialog and remove it from memory on surface teardown .. Tear down the save dialog and remove it from

[MediaWiki-commits] [Gerrit] Update OOJ-UI to include GroupButtonWidget - change (mediawiki...VisualEditor)

2013-11-28 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/98097 Change subject: Update OOJ-UI to include GroupButtonWidget .. Update OOJ-UI to include GroupButtonWidget Change-Id:

[MediaWiki-commits] [Gerrit] Show full language names in the MW language dialog - change (mediawiki...VisualEditor)

2013-11-30 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/98284 Change subject: Show full language names in the MW language dialog .. Show full language names in the MW language dialog Bug: 54086

[MediaWiki-commits] [Gerrit] Render MW extension node wikitext with XML - change (mediawiki...VisualEditor)

2013-12-01 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/98392 Change subject: Render MW extension node wikitext with XML .. Render MW extension node wikitext with XML MW extensions are XML not HTML, so

[MediaWiki-commits] [Gerrit] Fix deletion inside a structural node and start/end of document - change (mediawiki...VisualEditor)

2013-12-02 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/98515 Change subject: Fix deletion inside a structural node and start/end of document .. Fix deletion inside a structural node and start/end of

[MediaWiki-commits] [Gerrit] Re-order command registry to match toolbar order - change (mediawiki...VisualEditor)

2013-12-02 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/98516 Change subject: Re-order command registry to match toolbar order .. Re-order command registry to match toolbar order Bonus: fix grammar in

[MediaWiki-commits] [Gerrit] WIP Keyboard shortcuts dialog - change (mediawiki...VisualEditor)

2013-12-02 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/98517 Change subject: WIP Keyboard shortcuts dialog .. WIP Keyboard shortcuts dialog Bug: 52844 Change-Id:

[MediaWiki-commits] [Gerrit] ve.ce.Surface.handleEnter tests - change (mediawiki...VisualEditor)

2013-12-02 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/98529 Change subject: ve.ce.Surface.handleEnter tests .. ve.ce.Surface.handleEnter tests Change-Id: Ic30cd4e116029be85822f73dcb84938e641bc4b9 ---

[MediaWiki-commits] [Gerrit] Genericise runSurfaceHandleDeleteTest to work with other 'ha... - change (mediawiki...VisualEditor)

2013-12-02 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/98528 Change subject: Genericise runSurfaceHandleDeleteTest to work with other 'handle' methods .. Genericise runSurfaceHandleDeleteTest to work

[MediaWiki-commits] [Gerrit] Pressing enter in a list with no nearby content creates a pa... - change (mediawiki...VisualEditor)

2013-12-02 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/98532 Change subject: Pressing enter in a list with no nearby content creates a paragraph .. Pressing enter in a list with no nearby content

[MediaWiki-commits] [Gerrit] Change signature of getDomFromData and rename - change (mediawiki...VisualEditor)

2013-12-04 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/99100 Change subject: Change signature of getDomFromData and rename .. Change signature of getDomFromData and rename Currently it takes 4

[MediaWiki-commits] [Gerrit] getDataFromDom - getModelFromDom - change (mediawiki...VisualEditor)

2013-12-04 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/99168 Change subject: getDataFromDom - getModelFromDom .. getDataFromDom - getModelFromDom Following on from getDomFromModel, this returns a

[MediaWiki-commits] [Gerrit] Always use #getDocumentNode. - change (mediawiki...VisualEditor)

2013-12-04 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/99244 Change subject: Always use #getDocumentNode. .. Always use #getDocumentNode. Because if you only sometimes use a getter you're just wasting

[MediaWiki-commits] [Gerrit] Fix appearance and messages on demo page - change (mediawiki...VisualEditor)

2013-11-04 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/93480 Change subject: Fix appearance and messages on demo page .. Fix appearance and messages on demo page Some 've-ui-toolbar-bar' classes

[MediaWiki-commits] [Gerrit] More CSS fixes to the demo page. - change (mediawiki...VisualEditor)

2013-11-04 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/93482 Change subject: More CSS fixes to the demo page. .. More CSS fixes to the demo page. Some ve-ui classes not converted to oo-ui, and toolbar

[MediaWiki-commits] [Gerrit] Make sure all links have target=_blank in the save dialog - change (mediawiki...VisualEditor)

2013-11-05 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/93749 Change subject: Make sure all links have target=_blank in the save dialog .. Make sure all links have target=_blank in the save dialog

[MediaWiki-commits] [Gerrit] WIP some failing tests in fixUpInsertion - change (mediawiki...VisualEditor)

2013-11-07 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/94241 Change subject: WIP some failing tests in fixUpInsertion .. WIP some failing tests in fixUpInsertion Change-Id:

[MediaWiki-commits] [Gerrit] WIP failing converter tests - change (mediawiki...VisualEditor)

2013-11-07 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/94249 Change subject: WIP failing converter tests .. WIP failing converter tests Change-Id: I39872db46be0dafbd920cf2b4061cfe15d0ded48 --- M

[MediaWiki-commits] [Gerrit] Add shortcut commands for underline sub/superscript. - change (mediawiki...VisualEditor)

2013-11-08 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/94349 Change subject: Add shortcut commands for underline sub/superscript. .. Add shortcut commands for underline sub/superscript. Underline is

[MediaWiki-commits] [Gerrit] Use rare unicode characters for paste placehoders - change (mediawiki...VisualEditor)

2013-11-08 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/94440 Change subject: Use rare unicode characters for paste placehoders .. Use rare unicode characters for paste placehoders Helps with bug

[MediaWiki-commits] [Gerrit] Fix edit source switch in Firefox - change (mediawiki...VisualEditor)

2013-11-09 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/94498 Change subject: Fix edit source switch in Firefox .. Fix edit source switch in Firefox Previously was failing for two reasons: 1. FF

[MediaWiki-commits] [Gerrit] PageLayout - PagedLayout in test/demo - change (mediawiki...VisualEditor)

2013-11-12 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/94882 Change subject: PageLayout - PagedLayout in test/demo .. PageLayout - PagedLayout in test/demo Typo from oojs-ui refactor. Change-Id:

[MediaWiki-commits] [Gerrit] Use a global resizing flag on the surface to hide phantoms - change (mediawiki...VisualEditor)

2013-11-12 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/94884 Change subject: Use a global resizing flag on the surface to hide phantoms .. Use a global resizing flag on the surface to hide phantoms

[MediaWiki-commits] [Gerrit] Fix icon opacities - change (mediawiki...VisualEditor)

2013-11-12 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/94911 Change subject: Fix icon opacities .. Fix icon opacities * parameter.svg had no opacity set * replace.svg had a document opacity of 80% in

[MediaWiki-commits] [Gerrit] Strip trailing linebreaks on paste due to Chrome bug - change (mediawiki...VisualEditor)

2013-12-16 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/101905 Change subject: Strip trailing linebreaks on paste due to Chrome bug .. Strip trailing linebreaks on paste due to Chrome bug When pasting

[MediaWiki-commits] [Gerrit] Fix paste tests to work in phantomJS - change (mediawiki...VisualEditor)

2013-12-17 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/102221 Change subject: Fix paste tests to work in phantomJS .. Fix paste tests to work in phantomJS PhantomJS doesn't play nicely with

[MediaWiki-commits] [Gerrit] Empty empty.html - change (mediawiki...VisualEditor)

2013-12-17 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/102240 Change subject: Empty empty.html .. Empty empty.html Some test data was accidentally commited but this should be empty. Change-Id:

[MediaWiki-commits] [Gerrit] Change label of disabled switch to 'disabled' in demo - change (oojs/ui)

2013-12-17 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/102341 Change subject: Change label of disabled switch to 'disabled' in demo .. Change label of disabled switch to 'disabled' in demo To match

[MediaWiki-commits] [Gerrit] Documetation fix in MWBlockImageNode - change (mediawiki...VisualEditor)

2013-12-19 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/102642 Change subject: Documetation fix in MWBlockImageNode .. Documetation fix in MWBlockImageNode Change-Id:

[MediaWiki-commits] [Gerrit] Layout fixes to BetaFeatures - change (mediawiki...BetaFeatures)

2013-10-21 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/90924 Change subject: Layout fixes to BetaFeatures .. Layout fixes to BetaFeatures * Fix vertical alignment of title, checkbox and links *

[MediaWiki-commits] [Gerrit] New icons - change (mediawiki...BetaFeatures)

2013-10-21 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/91040 Change subject: New icons .. New icons The 'scroll' icon is not very recognisable, and if anything, means 'article', not

[MediaWiki-commits] [Gerrit] Fix border colours in BetaFeatures - change (mediawiki...BetaFeatures)

2013-10-21 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/91049 Change subject: Fix border colours in BetaFeatures .. Fix border colours in BetaFeatures I used the wrong border colour in I3cfb2149ec182.

[MediaWiki-commits] [Gerrit] Recalculate $resizable offset when positioning resize label - change (mediawiki...VisualEditor)

2013-10-22 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/91290 Change subject: Recalculate $resizable offset when positioning resize label .. Recalculate $resizable offset when positioning resize label

[MediaWiki-commits] [Gerrit] Cache multiple requests for $resizable's offset - change (mediawiki...VisualEditor)

2013-10-22 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/91291 Change subject: Cache multiple requests for $resizable's offset .. Cache multiple requests for $resizable's offset Both the resize handles

[MediaWiki-commits] [Gerrit] Use update rather than show in focusable node re-render - change (mediawiki...VisualEditor)

2013-10-23 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/91380 Change subject: Use update rather than show in focusable node re-render .. Use update rather than show in focusable node re-render Update

[MediaWiki-commits] [Gerrit] Remove ve.ce.Surface.static.textPattern - change (mediawiki...VisualEditor)

2013-10-28 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/92311 Change subject: Remove ve.ce.Surface.static.textPattern .. Remove ve.ce.Surface.static.textPattern It hasn't been used for a while.

[MediaWiki-commits] [Gerrit] Tests for paste - change (mediawiki...VisualEditor)

2013-10-28 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/92424 Change subject: Tests for paste .. Tests for paste Simple test for ve.ce.Surface#afterPaste, and more extensive tests for

[MediaWiki-commits] [Gerrit] Standardise and minimise licence headers - change (mediawiki...BetaFeatures)

2013-10-29 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/92525 Change subject: Standardise and minimise licence headers .. Standardise and minimise licence headers Also add AUTHORS file. Bug: 56312

[MediaWiki-commits] [Gerrit] Rename 'formulæ' to 'formulae'. - change (mediawiki...VisualEditor)

2013-10-30 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/92657 Change subject: Rename 'formulæ' to 'formulae'. .. Rename 'formulæ' to 'formulae'. Everyone loves a ligature, but within our codebase we

[MediaWiki-commits] [Gerrit] Fix: files missing from demo and test runner - change (mediawiki...VisualEditor)

2013-10-31 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/92841 Change subject: Fix: files missing from demo and test runner .. Fix: files missing from demo and test runner Change-Id:

[MediaWiki-commits] [Gerrit] Fix: getDataFromDom tests should check for body or head - change (mediawiki...VisualEditor)

2013-10-31 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/92884 Change subject: Fix: getDataFromDom tests should check for body or head .. Fix: getDataFromDom tests should check for body or head This

[MediaWiki-commits] [Gerrit] Store inner whitespace of the body and compare it on conversion - change (mediawiki...VisualEditor)

2013-10-31 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/92885 Change subject: Store inner whitespace of the body and compare it on conversion .. Store inner whitespace of the body and compare it on

[MediaWiki-commits] [Gerrit] Always use current surface on demo page - change (VisualEditor/VisualEditor)

2014-01-06 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/105672 Change subject: Always use current surface on demo page .. Always use current surface on demo page Now that we generate new surfaces on

[MediaWiki-commits] [Gerrit] Replace dump model loop with event triggered dump - change (VisualEditor/VisualEditor)

2014-01-06 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/105673 Change subject: Replace dump model loop with event triggered dump .. Replace dump model loop with event triggered dump Change-Id:

[MediaWiki-commits] [Gerrit] Always use absolute URLs in external links in the clipboard - change (mediawiki...VisualEditor)

2014-01-06 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/105706 Change subject: Always use absolute URLs in external links in the clipboard .. Always use absolute URLs in external links in the clipboard

[MediaWiki-commits] [Gerrit] Always use absolute URLs in external links in the clipboard - change (VisualEditor/VisualEditor)

2014-01-08 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/106253 Change subject: Always use absolute URLs in external links in the clipboard .. Always use absolute URLs in external links in the clipboard

[MediaWiki-commits] [Gerrit] Add method to fully destroy a target - change (VisualEditor/VisualEditor)

2014-01-08 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/106258 Change subject: Add method to fully destroy a target .. Add method to fully destroy a target Destroys the surface, toolbar and removes the

[MediaWiki-commits] [Gerrit] Add paste rules to surface widget config - change (VisualEditor/VisualEditor)

2014-02-03 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/110959 Change subject: Add paste rules to surface widget config .. Add paste rules to surface widget config Change-Id:

[MediaWiki-commits] [Gerrit] Implement surface paste rules for media/ref dialogs - change (mediawiki...VisualEditor)

2014-02-03 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/110960 Change subject: Implement surface paste rules for media/ref dialogs .. Implement surface paste rules for media/ref dialogs Currently they

[MediaWiki-commits] [Gerrit] Don't allow extensions to have no content by default - change (mediawiki...VisualEditor)

2014-02-04 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/78 Change subject: Don't allow extensions to have no content by default .. Don't allow extensions to have no content by default Change-Id:

[MediaWiki-commits] [Gerrit] Always show 'File:' in content language for gallery placeholder - change (mediawiki...VisualEditor)

2014-02-04 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/79 Change subject: Always show 'File:' in content language for gallery placeholder .. Always show 'File:' in content language for gallery

[MediaWiki-commits] [Gerrit] Fix 'use existing reference' list rendering - change (mediawiki...VisualEditor)

2014-02-04 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/111203 Change subject: Fix 'use existing reference' list rendering .. Fix 'use existing reference' list rendering Got broken by mass $ - $element

[MediaWiki-commits] [Gerrit] Fix usage of '$' in MWReferenceSearchWidget - change (mediawiki...VisualEditor)

2014-02-04 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/111205 Change subject: Fix usage of '$' in MWReferenceSearchWidget .. Fix usage of '$' in MWReferenceSearchWidget Easier to just use native

[MediaWiki-commits] [Gerrit] Internal paste rules and type conversions - change (VisualEditor/VisualEditor)

2014-02-05 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/111435 Change subject: Internal paste rules and type conversions .. Internal paste rules and type conversions Separate out paste rules into

[MediaWiki-commits] [Gerrit] Allow style attributes to be pasted from other VE instances - change (VisualEditor/VisualEditor)

2014-02-05 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/111456 Change subject: Allow style attributes to be pasted from other VE instances .. Allow style attributes to be pasted from other VE instances

[MediaWiki-commits] [Gerrit] Hide structure tools in MWReferences - change (mediawiki...VisualEditor)

2014-02-05 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/111507 Change subject: Hide structure tools in MWReferences .. Hide structure tools in MWReferences Technically these are possible to render

[MediaWiki-commits] [Gerrit] Exclude galleries from reference/caption surface tools - change (mediawiki...VisualEditor)

2014-02-05 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/111509 Change subject: Exclude galleries from reference/caption surface tools .. Exclude galleries from reference/caption surface tools Because

[MediaWiki-commits] [Gerrit] Add 'forClipboard' mode to converter - change (VisualEditor/VisualEditor)

2014-02-05 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/111517 Change subject: Add 'forClipboard' mode to converter .. Add 'forClipboard' mode to converter This allows us to generate HTML for the

[MediaWiki-commits] [Gerrit] Only generate transclusion contents for clipboard - change (mediawiki...VisualEditor)

2014-02-05 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/111518 Change subject: Only generate transclusion contents for clipboard .. Only generate transclusion contents for clipboard Parsoid doesn't care

[MediaWiki-commits] [Gerrit] Hide automatic reference names - change (mediawiki...VisualEditor)

2014-02-05 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/111626 Change subject: Hide automatic reference names .. Hide automatic reference names Anything which matches :[0-9]+ is not particularly helpful

[MediaWiki-commits] [Gerrit] Undefined variables first in selectNodes - change (VisualEditor/VisualEditor)

2014-02-06 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/111821 Change subject: Undefined variables first in selectNodes .. Undefined variables first in selectNodes Change-Id:

[MediaWiki-commits] [Gerrit] Don't descend into handlesOwnChildren nodes in selectNodes - change (VisualEditor/VisualEditor)

2014-02-06 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/111822 Change subject: Don't descend into handlesOwnChildren nodes in selectNodes .. Don't descend into handlesOwnChildren nodes in selectNodes

[MediaWiki-commits] [Gerrit] Move paste rules to Target - change (mediawiki...VisualEditor)

2014-02-06 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/111912 Change subject: Move paste rules to Target .. Move paste rules to Target Because ViewPageTarget isn't always loaded. Change-Id:

[MediaWiki-commits] [Gerrit] Simplify toDataElement - change (VisualEditor/VisualEditor)

2014-01-23 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/109091 Change subject: Simplify toDataElement .. Simplify toDataElement Replace 'type': 'foo' with 'type': this.name where applicable. This makes

[MediaWiki-commits] [Gerrit] Simplify toDomElements - change (VisualEditor/VisualEditor)

2014-01-23 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/109092 Change subject: Simplify toDomElements .. Simplify toDomElements If the model matches a single tag name, toDomElements will return a plain

[MediaWiki-commits] [Gerrit] Simplify toDataElement in MW - change (mediawiki...VisualEditor)

2014-01-23 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/109093 Change subject: Simplify toDataElement in MW .. Simplify toDataElement in MW As per I54943588c5cc2 in core. Change-Id:

[MediaWiki-commits] [Gerrit] Fix RDFa attribute protection loop - change (VisualEditor/VisualEditor)

2014-01-23 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/109250 Change subject: Fix RDFa attribute protection loop .. Fix RDFa attribute protection loop Was accidentally set to start at length-2 after

[MediaWiki-commits] [Gerrit] Tests for RDFa attribute preservation - change (VisualEditor/VisualEditor)

2014-01-23 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/109255 Change subject: Tests for RDFa attribute preservation .. Tests for RDFa attribute preservation Probably should've written these first...

[MediaWiki-commits] [Gerrit] Collapse block slugs, and expand on hover/focus - change (VisualEditor/VisualEditor)

2014-01-24 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/109307 Change subject: Collapse block slugs, and expand on hover/focus .. Collapse block slugs, and expand on hover/focus By default collapse the

[MediaWiki-commits] [Gerrit] Make keyboard shortcuts dialog footless - change (VisualEditor/VisualEditor)

2014-01-24 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/109317 Change subject: Make keyboard shortcuts dialog footless .. Make keyboard shortcuts dialog footless Because the footer is empty.

[MediaWiki-commits] [Gerrit] Update VE core submodule to master - change (mediawiki...VisualEditor)

2014-01-24 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/109322 Change subject: Update VE core submodule to master .. Update VE core submodule to master New changes: 49d2fe6 Fixing ButtonWidget call in

[MediaWiki-commits] [Gerrit] Fix typo in ui.MWCategoryItemWidget - change (mediawiki...VisualEditor)

2014-01-24 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/109326 Change subject: Fix typo in ui.MWCategoryItemWidget .. Fix typo in ui.MWCategoryItemWidget Change-Id:

[MediaWiki-commits] [Gerrit] Fix balancing of data in cloneSliceFromRange - change (VisualEditor/VisualEditor)

2014-01-25 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/109481 Change subject: Fix balancing of data in cloneSliceFromRange .. Fix balancing of data in cloneSliceFromRange Optimise case where no

[MediaWiki-commits] [Gerrit] Fix layout of keyboard shortcuts page - change (VisualEditor/VisualEditor)

2014-01-25 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/109483 Change subject: Fix layout of keyboard shortcuts page .. Fix layout of keyboard shortcuts page Add a scrollable panel layout, and improve

[MediaWiki-commits] [Gerrit] Attach container to DOM before initialising target in demo - change (VisualEditor/VisualEditor)

2014-01-25 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/109489 Change subject: Attach container to DOM before initialising target in demo .. Attach container to DOM before initialising target in demo

[MediaWiki-commits] [Gerrit] Fix toolbar margins in vector - change (mediawiki...VisualEditor)

2014-01-25 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/109491 Change subject: Fix toolbar margins in vector .. Fix toolbar margins in vector In HD mode, the left margin was 0.25em off. In narrow

[MediaWiki-commits] [Gerrit] Show % scale on ResizableNodes - change (VisualEditor/VisualEditor)

2014-01-26 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/109519 Change subject: Show % scale on ResizableNodes .. Show % scale on ResizableNodes Requires original dimensions to be provided. Implement

[MediaWiki-commits] [Gerrit] Only call setOriginalDimensions when non-null values are pro... - change (VisualEditor/VisualEditor)

2014-01-26 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/109520 Change subject: Only call setOriginalDimensions when non-null values are provided .. Only call setOriginalDimensions when non-null values

[MediaWiki-commits] [Gerrit] Store original dimensions results in IV store - change (mediawiki...VisualEditor)

2014-01-26 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/109521 Change subject: Store original dimensions results in IV store .. Store original dimensions results in IV store * Remove the this.mediaSize

<    1   2   3   4   5   6   7   8   9   10   >