[MediaWiki-commits] [Gerrit] mediawiki...AdvancedSearch[master]: Replace kittens by boxes

2017-11-07 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/389710 ) Change subject: Replace kittens by boxes .. Replace kittens by boxes Cause some langaues don't have kittens Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...AdvancedSearch[master]: Added extra tests

2017-10-29 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/387159 ) Change subject: Added extra tests .. Added extra tests https://phabricator.wikimedia.org/T173563 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...AdvancedSearch[master]: Recalculate input size when placeholder is changed

2017-10-17 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/384682 ) Change subject: Recalculate input size when placeholder is changed .. Recalculate input size when placeholder is changed Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...AdvancedSearch[master]: Fixed placeholder text not showing properly

2017-10-12 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/383968 ) Change subject: Fixed placeholder text not showing properly .. Fixed placeholder text not showing properly Fix provided by Fisch at

[MediaWiki-commits] [Gerrit] mediawiki...AdvancedSearch[master]: Automawtically mawk boxes when a comma is input

2017-10-12 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/383789 ) Change subject: Automawtically mawk boxes when a comma is input .. Automawtically mawk boxes when a comma is input

[MediaWiki-commits] [Gerrit] mediawiki...AdvancedSearch[master]: CS changes in ArbitraryWordInput

2017-10-12 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/383775 ) Change subject: CS changes in ArbitraryWordInput .. CS changes in ArbitraryWordInput Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...AdvancedSearch[master]: Add placeholder text for comma fields

2017-10-11 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/383772 ) Change subject: Add placeholder text for comma fields .. Add placeholder text for comma fields

[MediaWiki-commits] [Gerrit] mediawiki...AdvancedSearch[master]: Remove dead placeholder code

2017-10-11 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/383771 ) Change subject: Remove dead placeholder code .. Remove dead placeholder code Dead as far as I can tell... Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...AdvancedSearch[master]: Extract new code into dedicated method

2017-10-08 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/383046 ) Change subject: Extract new code into dedicated method .. Extract new code into dedicated method Follow up to

[MediaWiki-commits] [Gerrit] mediawiki...AdvancedSearch[master]: Use variable already in scope

2017-10-08 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/383045 ) Change subject: Use variable already in scope .. Use variable already in scope Change-Id: Ieab09680b5ae509b2d6e77086809c1f9eb82ad48

[MediaWiki-commits] [Gerrit] mediawiki...AdvancedSearch[master]: Pass RTL config to the widgets

2017-09-30 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/381522 ) Change subject: Pass RTL config to the widgets .. Pass RTL config to the widgets This is for

[MediaWiki-commits] [Gerrit] mediawiki...AdvancedSearch[master]: Added a small note on QUnit to README

2017-09-04 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/375947 ) Change subject: Added a small note on QUnit to README .. Added a small note on QUnit to README Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...AdvancedSearch[master]: Add help messages

2017-09-04 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/375946 ) Change subject: Add help messages .. Add help messages https://phabricator.wikimedia.org/T168405 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...AdvancedSearch[master]: Extracted functions in form initialization code

2017-09-04 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/375944 ) Change subject: Extracted functions in form initialization code .. Extracted functions in form initialization code Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...AdvancedSearch[master]: Inline not neede var

2017-08-04 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/370208 ) Change subject: Inline not neede var .. Inline not neede var Change-Id: Id6b76b741d9bd24fa4dc15e70ceb04a93bead166 --- M

[MediaWiki-commits] [Gerrit] mediawiki...AdvancedSearch[master]: T171843: Remove fields for category search and for prefix se...

2017-08-04 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/370207 ) Change subject: T171843: Remove fields for category search and for prefix search .. T171843: Remove fields for category search and

[MediaWiki-commits] [Gerrit] mediawiki...codesniffer[master]: Do not require specific versions of PHPCS

2017-01-19 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/333123 ) Change subject: Do not require specific versions of PHPCS .. Do not require specific versions of PHPCS We keep running into MW

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Make if predicates more explicit

2017-01-06 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/331104 ) Change subject: Make if predicates more explicit .. Make if predicates more explicit Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Inlined return var

2017-01-06 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/331103 ) Change subject: Inlined return var .. Inlined return var Change-Id: I6d9d79fd2d8592acf7f8f65457f0fad5585ce912 --- M

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Simplified if-else

2017-01-06 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/331102 ) Change subject: Simplified if-else .. Simplified if-else Change-Id: Ic20984d51392b35a96cbfb6fb53ef028cffc3472 --- M

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Removed TODO

2017-01-06 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/331101 ) Change subject: Removed TODO .. Removed TODO Change-Id: I42488d6470ac4aa7e350c294c20101eec122215f --- M

[MediaWiki-commits] [Gerrit] mediawiki/vagrant[master]: Added Maps extension role

2016-11-06 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/320158 Change subject: Added Maps extension role .. Added Maps extension role Change-Id: I0db27c4544e111dffdbbfd0553573398b064582f --- A

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Removed dead code

2016-09-01 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/308120 Change subject: Removed dead code .. Removed dead code Change-Id: Iac8b6a59b5cf91e5c69d20a5825a50663273ab85 --- M

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Remove myself from TravisCI email subscriptions

2016-09-01 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/308119 Change subject: Remove myself from TravisCI email subscriptions .. Remove myself from TravisCI email subscriptions Change-Id:

[MediaWiki-commits] [Gerrit] Added missing dependency to composer.json - change (mediawiki...WikibaseMediaInfo)

2016-06-17 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/294886 Change subject: Added missing dependency to composer.json .. Added missing dependency to composer.json Change-Id:

[MediaWiki-commits] [Gerrit] Added missing field to ChangeOpMainSnak - change (mediawiki...Wikibase)

2016-06-17 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/294885 Change subject: Added missing field to ChangeOpMainSnak .. Added missing field to ChangeOpMainSnak Change-Id:

[MediaWiki-commits] [Gerrit] Added missing field in EntityIdReader - change (mediawiki...Wikibase)

2016-06-17 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/294884 Change subject: Added missing field in EntityIdReader .. Added missing field in EntityIdReader Change-Id:

[MediaWiki-commits] [Gerrit] Added missing field in EntityIdRdfBuilder. - change (mediawiki...Wikibase)

2016-06-17 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/294883 Change subject: Added missing field in EntityIdRdfBuilder. .. Added missing field in EntityIdRdfBuilder. Change-Id:

[MediaWiki-commits] [Gerrit] Added missing dependency to composer.json - change (mediawiki...Wikibase)

2016-06-17 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/294882 Change subject: Added missing dependency to composer.json .. Added missing dependency to composer.json Rather surprised no one

[MediaWiki-commits] [Gerrit] Removed dead argument - change (mediawiki...Wikibase)

2016-06-17 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/294881 Change subject: Removed dead argument .. Removed dead argument Change-Id: Iab97a35f697793ef751864cffcc95876b73eec18 --- M

[MediaWiki-commits] [Gerrit] Fixed capitalization in method calls - change (mediawiki...Wikibase)

2016-06-17 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/294879 Change subject: Fixed capitalization in method calls .. Fixed capitalization in method calls Change-Id:

[MediaWiki-commits] [Gerrit] Provide several tweaks - change (mediawiki...SemanticImageInput)

2016-05-03 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Provide several tweaks .. Provide several tweaks * Updated INSTALL file * Updated README file * Formatted COPYING file * Provide license label to show

[MediaWiki-commits] [Gerrit] Fix branch alias - change (mediawiki...SemanticForms)

2016-04-02 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/281233 Change subject: Fix branch alias .. Fix branch alias Change-Id: Id524cef5a281f1e3e58626487ad54bd0d56a3a84 --- M composer.json 1 file

[MediaWiki-commits] [Gerrit] Stop doing $that = $this in Client Tests - change (mediawiki...Wikibase)

2016-02-07 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Stop doing $that = $this in Client Tests .. Stop doing $that = $this in Client Tests Closuers support $this as of 5.4 Change-Id:

[MediaWiki-commits] [Gerrit] Remove string refs to function and make it non-public - change (mediawiki...Wikibase)

2015-12-09 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/257855 Change subject: Remove string refs to function and make it non-public .. Remove string refs to function and make it non-public

[MediaWiki-commits] [Gerrit] Remove dead private method - change (mediawiki...Wikibase)

2015-12-08 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/257579 Change subject: Remove dead private method .. Remove dead private method Change-Id: I3fb75cf2685d7a4ff27d19efeb91b9dafbf8988b --- M

[MediaWiki-commits] [Gerrit] Remove dead argument - change (mediawiki...Wikibase)

2015-12-08 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/257580 Change subject: Remove dead argument .. Remove dead argument Change-Id: Ic084fed1798ac331278ab8c929d1b08aa172c638 --- M

[MediaWiki-commits] [Gerrit] Make sure $revisionId is always set - change (mediawiki...Wikibase)

2015-12-08 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/257585 Change subject: Make sure $revisionId is always set .. Make sure $revisionId is always set Also extracts the revision id extracting

[MediaWiki-commits] [Gerrit] Remove dead priviate test method - change (mediawiki...Wikibase)

2015-12-08 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/257583 Change subject: Remove dead priviate test method .. Remove dead priviate test method Change-Id:

[MediaWiki-commits] [Gerrit] Fully comment code out - change (mediawiki...Wikibase)

2015-12-08 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/257584 Change subject: Fully comment code out .. Fully comment code out When partially done, this shows up when looking for unused code

[MediaWiki-commits] [Gerrit] Remove dead argument - change (mediawiki...Wikibase)

2015-12-08 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/257582 Change subject: Remove dead argument .. Remove dead argument Change-Id: Ia16330c7bc4d69a2d6eb498430d8395d283ed372 --- M

[MediaWiki-commits] [Gerrit] Remove dead var - change (mediawiki...Wikibase)

2015-12-08 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/257578 Change subject: Remove dead var .. Remove dead var Change-Id: If3ae39a941e28c8dbb8cd27a57c0d58a3c2d0c6b --- M

[MediaWiki-commits] [Gerrit] Fix phpcs in TermIndexSearchInteractor & Test - change (mediawiki...Wikibase)

2015-12-04 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Fix phpcs in TermIndexSearchInteractor & Test .. Fix phpcs in TermIndexSearchInteractor & Test Change-Id: I2006ad048be6e40da1e3a9b2ef32960847580d4e

[MediaWiki-commits] [Gerrit] Move statement filtering from GetClaims API to dedicated class - change (mediawiki...Wikibase)

2015-11-25 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/255371 Change subject: Move statement filtering from GetClaims API to dedicated class .. Move statement filtering from GetClaims API to

[MediaWiki-commits] [Gerrit] Demonstrate StatementList::filter utility - change (mediawiki...Wikibase)

2015-11-25 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/255370 Change subject: Demonstrate StatementList::filter utility .. Demonstrate StatementList::filter utility Change-Id:

[MediaWiki-commits] [Gerrit] Move statement filtering from GetClaims API to dedicated class - change (mediawiki...Wikibase)

2015-11-25 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/255374 Change subject: Move statement filtering from GetClaims API to dedicated class .. Move statement filtering from GetClaims API to

[MediaWiki-commits] [Gerrit] Use Composer cache on TravisCI - change (mediawiki...Wikibase)

2015-11-08 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/251923 Change subject: Use Composer cache on TravisCI .. Use Composer cache on TravisCI Change-Id: I21ce71603741317cf75e24d0a3539ccc7e84d4e7

[MediaWiki-commits] [Gerrit] Decrease binding in EntityParserOutputDataUpdater - change (mediawiki...Wikibase)

2015-11-05 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/251260 Change subject: Decrease binding in EntityParserOutputDataUpdater .. Decrease binding in EntityParserOutputDataUpdater And make the

[MediaWiki-commits] [Gerrit] Remove unused imports - change (mediawiki...Wikibase)

2015-11-04 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Remove unused imports .. Remove unused imports Change-Id: I63e5fd4e2887d24514c65f9a3b923d55eab85b8a --- M repo/Wikibase.hooks.php M

[MediaWiki-commits] [Gerrit] Remove unused imports - change (mediawiki...Wikibase)

2015-11-03 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/250725 Change subject: Remove unused imports .. Remove unused imports Change-Id: I63e5fd4e2887d24514c65f9a3b923d55eab85b8a --- M

[MediaWiki-commits] [Gerrit] Do not hide parent constructor - change (mediawiki...Wikibase)

2015-11-03 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/250730 Change subject: Do not hide parent constructor .. Do not hide parent constructor Change-Id: Ic3d7adcc23cc702e72801749ec2062fb1ccddc40

[MediaWiki-commits] [Gerrit] Remove dead argument - change (mediawiki...Wikibase)

2015-11-03 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/250735 Change subject: Remove dead argument .. Remove dead argument Change-Id: Ic81315397493753f48f7373846923608749354f2 --- M

[MediaWiki-commits] [Gerrit] Remove dead code - change (mediawiki...Wikibase)

2015-11-03 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/250729 Change subject: Remove dead code .. Remove dead code Change-Id: Ic4e3e780fe3f9ef1ff548f7f89f714454480b7b3 --- M

[MediaWiki-commits] [Gerrit] Remove dead arrgument from AddUsagesForPageJobTest - change (mediawiki...Wikibase)

2015-11-03 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/250736 Change subject: Remove dead arrgument from AddUsagesForPageJobTest .. Remove dead arrgument from AddUsagesForPageJobTest Change-Id:

[MediaWiki-commits] [Gerrit] Remove dead code - change (mediawiki...Wikibase)

2015-11-03 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/250734 Change subject: Remove dead code .. Remove dead code Dead since 7e9afb6598acde776796639e9ca2102d0ff8860e Change-Id:

[MediaWiki-commits] [Gerrit] Remove unused imports - change (mediawiki...Wikibase)

2015-11-03 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/250731 Change subject: Remove unused imports .. Remove unused imports Change-Id: I1d80e06da47616eff6697f7b59ffcc04029fb1e5 --- M

[MediaWiki-commits] [Gerrit] Remove duplicate array element - change (mediawiki...Wikibase)

2015-11-03 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/250726 Change subject: Remove duplicate array element .. Remove duplicate array element Change-Id: I9553e1e94aabbe6c09f2a2bd86051ae2147194eb

[MediaWiki-commits] [Gerrit] Add jakub-onderka/php-parallel-lint package - change (mediawiki...Wikibase)

2015-11-02 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Add jakub-onderka/php-parallel-lint package .. Add jakub-onderka/php-parallel-lint package This will allow us to test php using composer. This is a

[MediaWiki-commits] [Gerrit] Remove cp error since tag - change (mediawiki...Wikibase)

2015-10-13 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/245951 Change subject: Remove cp error since tag .. Remove cp error since tag Change-Id: I16756c0763f24687db4d275cff6bd4a353a0c79b --- M

[MediaWiki-commits] [Gerrit] Remove not needed support for null in ChangeRow constructor - change (mediawiki...Wikibase)

2015-10-13 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/245984 Change subject: Remove not needed support for null in ChangeRow constructor .. Remove not needed support for null in ChangeRow

[MediaWiki-commits] [Gerrit] Remove dead field - change (mediawiki...Wikibase)

2015-10-13 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/245979 Change subject: Remove dead field .. Remove dead field Change-Id: I77dc4c38ed571d752a027424ae09177d09661e22 --- M

[MediaWiki-commits] [Gerrit] Remove not needed post-construct stuff from ChangeRow - change (mediawiki...Wikibase)

2015-10-13 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/245986 Change subject: Remove not needed post-construct stuff from ChangeRow .. Remove not needed post-construct stuff from ChangeRow

[MediaWiki-commits] [Gerrit] Decrease field visibility - change (mediawiki...Wikibase)

2015-10-13 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/245952 Change subject: Decrease field visibility .. Decrease field visibility Change-Id: I7e80f74d68894cf13cb5718bf4a3afaf03eaeb12 --- M

[MediaWiki-commits] [Gerrit] Remove not needed parameters from ChangeRow constructor - change (mediawiki...Wikibase)

2015-10-13 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/245953 Change subject: Remove not needed parameters from ChangeRow constructor .. Remove not needed parameters from ChangeRow constructor

[MediaWiki-commits] [Gerrit] Remove not used getUser - change (mediawiki...Wikibase)

2015-10-13 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/245954 Change subject: Remove not used getUser .. Remove not used getUser Change-Id: Idab78ea098c766c8464c0512b418848568b9cc7f --- M

[MediaWiki-commits] [Gerrit] Improve method name and make checks explicit - change (mediawiki...Wikibase)

2015-10-12 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/245482 Change subject: Improve method name and make checks explicit .. Improve method name and make checks explicit Change-Id:

[MediaWiki-commits] [Gerrit] Fix PHPDoc for apiSerialize - change (mediawiki...Wikibase)

2015-10-12 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/245481 Change subject: Fix PHPDoc for apiSerialize .. Fix PHPDoc for apiSerialize Change-Id: I9329c79bcacfa8d769cf0916d3b6e566f3d409e7 --- M

[MediaWiki-commits] [Gerrit] Remove not needed state - change (mediawiki...Wikibase)

2015-10-12 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/245602 Change subject: Remove not needed state .. Remove not needed state Change-Id: Ia611f09b29019c07d531bafa98142cb706b1b3e3 --- M

[MediaWiki-commits] [Gerrit] Flip if else - change (mediawiki...Wikibase)

2015-10-12 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/245601 Change subject: Flip if else .. Flip if else Change-Id: I1f4b2efe90be7dfc24296907d15e6a1e262ab161 --- M

[MediaWiki-commits] [Gerrit] Remove not needed and - change (mediawiki...WikibaseQualityExternalValidation)

2015-10-04 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/243491 Change subject: Remove not needed and .. Remove not needed and Change-Id: I06b99bc77318c03595377614ee75715031a60923 --- M

[MediaWiki-commits] [Gerrit] Remove redundant argument - change (mediawiki...WikibaseQualityExternalValidation)

2015-10-04 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/243490 Change subject: Remove redundant argument .. Remove redundant argument Change-Id: Ia74a7b828945e38578885e64d8c2b676695e5eae --- M

[MediaWiki-commits] [Gerrit] Do not lose subtype exception info in RevisionBasedEntityLookup - change (mediawiki...Wikibase)

2015-09-30 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/242766 Change subject: Do not lose subtype exception info in RevisionBasedEntityLookup .. Do not lose subtype exception info in

[MediaWiki-commits] [Gerrit] Simplify switch case in resultOfDiffWithPrecision - change (mediawiki...WikibaseQualityExternalValidation)

2015-09-30 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/242796 Change subject: Simplify switch case in resultOfDiffWithPrecision .. Simplify switch case in resultOfDiffWithPrecision Change-Id:

[MediaWiki-commits] [Gerrit] Renames as suggested by aude in https://gerrit.wikimedia.org... - change (mediawiki...WikibaseQualityExternalValidation)

2015-09-30 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/242785 Change subject: Renames as suggested by aude in https://gerrit.wikimedia.org/r/#/c/232279/8/includes/CrossCheck/CrossCheckInteractor.php

[MediaWiki-commits] [Gerrit] Remove superfluous space - change (mediawiki...WikibaseQualityExternalValidation)

2015-09-30 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/242795 Change subject: Remove superfluous space .. Remove superfluous space Change-Id: Ic4496b04e57a9a6a634db5e05433963fedca48d5 --- M

[MediaWiki-commits] [Gerrit] Remove unused import - change (mediawiki...WikibaseQualityExternalValidation)

2015-09-30 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/242792 Change subject: Remove unused import .. Remove unused import Change-Id: Ie6ff6312a076e796f60e8500d4a478cb0dc5e767 --- M

[MediaWiki-commits] [Gerrit] Remove dead local var - change (mediawiki...WikibaseQualityExternalValidation)

2015-09-30 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/242797 Change subject: Remove dead local var .. Remove dead local var Change-Id: If877fe50434c0695acc7b53002cb937fd8b49147 --- M

[MediaWiki-commits] [Gerrit] Remove dead function argument - change (mediawiki...WikibaseQualityExternalValidation)

2015-09-30 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/242798 Change subject: Remove dead function argument .. Remove dead function argument Change-Id: Iba01944a0a28079aabd6cdf7f6e24587df68cf82

[MediaWiki-commits] [Gerrit] Remove executable bits from files - change (mediawiki...WikibaseQualityExternalValidation)

2015-09-30 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Remove executable bits from files .. Remove executable bits from files with exception of travis build bash scripts Bug: T113751 Change-Id:

[MediaWiki-commits] [Gerrit] Seperate distinct value checks - change (mediawiki...WikibaseQualityExternalValidation)

2015-09-30 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/242786 Change subject: Seperate distinct value checks .. Seperate distinct value checks As partially suggted by aude in

[MediaWiki-commits] [Gerrit] Add type hints to GlobeCoordinateValueComparer - change (mediawiki...WikibaseQualityExternalValidation)

2015-09-30 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/242794 Change subject: Add type hints to GlobeCoordinateValueComparer .. Add type hints to GlobeCoordinateValueComparer Change-Id:

[MediaWiki-commits] [Gerrit] Fix broken import after class got moved from lib to repo - change (mediawiki...WikibaseQualityExternalValidation)

2015-09-30 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/242793 Change subject: Fix broken import after class got moved from lib to repo .. Fix broken import after class got moved from lib to repo

[MediaWiki-commits] [Gerrit] Remove empty commend line - change (mediawiki...Wikibase)

2015-09-29 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/242431 Change subject: Remove empty commend line .. Remove empty commend line Change-Id: I310af07b1ed899877a61bd8327281f2adf93a085 --- M

[MediaWiki-commits] [Gerrit] Revert "Replace deprecated $wgSpecialPageGroups" - change (mediawiki...SemanticWatchlist)

2015-09-25 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/241044 Change subject: Revert "Replace deprecated $wgSpecialPageGroups" .. Revert "Replace deprecated $wgSpecialPageGroups" This breaks

[MediaWiki-commits] [Gerrit] Revert "Replace deprecated $wgSpecialPageGroups" - change (mediawiki...SemanticWatchlist)

2015-09-25 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Revert "Replace deprecated $wgSpecialPageGroups" .. Revert "Replace deprecated $wgSpecialPageGroups" This breaks compatibility with MediaWiki 1.19 and

[MediaWiki-commits] [Gerrit] Remove unused import - change (mediawiki...Wikibase)

2015-09-24 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/240707 Change subject: Remove unused import .. Remove unused import Change-Id: I5c9063914579341cb313220ba0bf816e7d2b337e --- M

[MediaWiki-commits] [Gerrit] Remove usage of deprecated EntityId::getNumericId - change (mediawiki...Wikibase)

2015-09-24 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/240708 Change subject: Remove usage of deprecated EntityId::getNumericId .. Remove usage of deprecated EntityId::getNumericId Change-Id:

[MediaWiki-commits] [Gerrit] Make RevisionBasedEntityLookup adhere to its interfaces cont... - change (mediawiki...Wikibase)

2015-09-24 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/240712 Change subject: Make RevisionBasedEntityLookup adhere to its interfaces contract .. Make RevisionBasedEntityLookup adhere to its

[MediaWiki-commits] [Gerrit] Make WikiPageEntityRedirectLookup adhere to its interfaces c... - change (mediawiki...Wikibase)

2015-09-24 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/240723 Change subject: Make WikiPageEntityRedirectLookup adhere to its interfaces contract .. Make WikiPageEntityRedirectLookup adhere to

[MediaWiki-commits] [Gerrit] Remove dead code in SpecialNewEntity - change (mediawiki...Wikibase)

2015-09-24 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/240737 Change subject: Remove dead code in SpecialNewEntity .. Remove dead code in SpecialNewEntity Change-Id:

[MediaWiki-commits] [Gerrit] PhpStorm says this is better - change (mediawiki...Wikibase)

2015-09-24 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/240738 Change subject: PhpStorm says this is better .. PhpStorm says this is better Change-Id: I0c6cc07c1a26e6e58cb7ebf1869ef20d7ccaf46f ---

[MediaWiki-commits] [Gerrit] Split method in HtmlTableBuilder - change (mediawiki...WikibaseQuality)

2015-09-24 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/240768 Change subject: Split method in HtmlTableBuilder .. Split method in HtmlTableBuilder Also swap out imperative programming for a more

[MediaWiki-commits] [Gerrit] Add type hint - change (mediawiki...WikibaseQuality)

2015-09-24 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/240767 Change subject: Add type hint .. Add type hint Change-Id: I30b3907168d81738695e5d867a4a7143543a3789 --- M

[MediaWiki-commits] [Gerrit] Remove unused code in DirectSqlStore - change (mediawiki...Wikibase)

2015-09-24 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/240739 Change subject: Remove unused code in DirectSqlStore .. Remove unused code in DirectSqlStore Change-Id:

[MediaWiki-commits] [Gerrit] Remove dead code - change (mediawiki/core)

2015-09-24 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/240746 Change subject: Remove dead code .. Remove dead code Change-Id: Iafcb15a8843889bf7fbfb191b64d86e9f8561185 --- M

[MediaWiki-commits] [Gerrit] Remove unused $pageSet var - change (mediawiki/core)

2015-09-24 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/240747 Change subject: Remove unused $pageSet var .. Remove unused $pageSet var Change-Id: Ic9c8bf9ed840703128a4c0e873ef7d70b6155494 --- M

[MediaWiki-commits] [Gerrit] Remove dead argument - change (mediawiki/core)

2015-09-24 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/240748 Change subject: Remove dead argument .. Remove dead argument Change-Id: Icd1584460e68422e50d4391bfbdf0d938ab1c1cf --- M

[MediaWiki-commits] [Gerrit] Remove unused argument - change (mediawiki/core)

2015-09-24 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/240751 Change subject: Remove unused argument .. Remove unused argument Change-Id: I7e7cf2b1f99834a140d0213c39cc67cfbc481ec9 --- M

[MediaWiki-commits] [Gerrit] Fix mistake caused by fail method name - change (mediawiki/core)

2015-09-24 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/240752 Change subject: Fix mistake caused by fail method name .. Fix mistake caused by fail method name Change-Id:

[MediaWiki-commits] [Gerrit] Fix type hint in unprefixRow - change (mediawiki/core)

2015-09-24 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/240754 Change subject: Fix type hint in unprefixRow .. Fix type hint in unprefixRow Change-Id: Iba80cadfdb06b3f9b3f5a6e1d367260405bea1d0 ---

  1   2   3   4   5   6   7   8   9   10   >