D4312: New bookflow extension for bookmark-based branching

smf added a comment. In https://phab.mercurial-scm.org/D4312#79581, @durin42 wrote: > In https://phab.mercurial-scm.org/D4312#79573, @smf wrote: > > > In https://phab.mercurial-scm.org/D4312#79509, @durin42 wrote: > > > > > There's been some good discussion on this. I'm

D4312: New bookflow extension for bookmark-based branching

smf added a comment. In https://phab.mercurial-scm.org/D4312#79509, @durin42 wrote: > There's been some good discussion on this. I'm sympathetic to both arguments here, namely: "we could improve bookmarks and make them less bad" and "bookmarks are a dead end and nobody should use them

D4312: New bookflow extension for bookmark-based branching

smf added a comment. In https://phab.mercurial-scm.org/D4312#77596, @idlsoft wrote: > @smf I just noticed your name on https://www.mercurial-scm.org/wiki/BookmarkUpdatePlan, which puts your comments into a larger context. > This would definitely be an improvement, and reduce the

D4312: New bookflow extension for bookmark-based branching

smf added a comment. Thanks for submitting your patch, it’s clearly a work of passion and I appreciate that. I know feature branches is a much sought-after behavior. However, I must express my objection to this direction in bookmarks. (apologies in advance) I think the core issue at

Re: [PATCH 6 of 6 ctx-minor-fixes] context: define contract for parents

Yuya Nishihara writes: > On Tue, 18 Sep 2018 22:35:48 -0700, Sean Farley wrote: >> # HG changeset patch >> # User Sean Farley >> # Date 1528497109 25200 >> # Fri Jun 08 15:31:49 2018 -0700 >> # Branch ctx-minor-fixes >> # Node ID 58496e395dd32

[PATCH 2 of 6 ctx-minor-fixes] context: fix typo in workingcommitctx

# HG changeset patch # User Sean Farley # Date 1528775327 25200 # Mon Jun 11 20:48:47 2018 -0700 # Branch ctx-minor-fixes # Node ID c21a9a45b1a718d67d294fb822b58c7d6a2aa207 # Parent 03041a020368729345f9b72e6914122c5e88a302 context: fix typo in workingcommitctx This was probably a copy

[PATCH 6 of 6 ctx-minor-fixes] context: define contract for parents

# HG changeset patch # User Sean Farley # Date 1528497109 25200 # Fri Jun 08 15:31:49 2018 -0700 # Branch ctx-minor-fixes # Node ID 58496e395dd324297748551297d1d572ab762496 # Parent 56222df6e5c8738b9b04881477c166540c50b17a context: define contract for parents From now on, context._parents

[PATCH 4 of 6 ctx-minor-fixes] memctx: simplify _manifest with new revlog nodeids

# HG changeset patch # User Sean Farley # Date 1526998571 -7200 # Tue May 22 16:16:11 2018 +0200 # Branch ctx-minor-fixes # Node ID 0173c0dca9d389d55a3f0e8ff3bcf43dc7ef659d # Parent 2a524ac6b6e5da11f0f8ab9c9137d44c16f724b5 memctx: simplify _manifest with new revlog nodeids

[PATCH 3 of 6 ctx-minor-fixes] context: remove unused overlayctx

# HG changeset patch # User Sean Farley # Date 1526985338 -7200 # Tue May 22 12:35:38 2018 +0200 # Branch ctx-minor-fixes # Node ID 2a524ac6b6e5da11f0f8ab9c9137d44c16f724b5 # Parent c21a9a45b1a718d67d294fb822b58c7d6a2aa207 context: remove unused overlayctx It seems that this was maybe used

[PATCH 1 of 6 ctx-minor-fixes] filectx: fix return of renamed

# HG changeset patch # User Sean Farley # Date 1531872982 25200 # Tue Jul 17 17:16:22 2018 -0700 # Branch ctx-minor-fixes # Node ID 03041a020368729345f9b72e6914122c5e88a302 # Parent 3d22aef3ecd5fe02c9411503b04dfbdcb6240cc1 filectx: fix return of renamed How is this not blowing up

[PATCH 5 of 6 ctx-minor-fixes] context: use object-oriented programming

# HG changeset patch # User Sean Farley # Date 1528495331 25200 # Fri Jun 08 15:02:11 2018 -0700 # Branch ctx-minor-fixes # Node ID 56222df6e5c8738b9b04881477c166540c50b17a # Parent 0173c0dca9d389d55a3f0e8ff3bcf43dc7ef659d context: use object-oriented programming We have abstracted methods

Re: [PATCH] about: update URLs and prefer https://

Sean Farley writes: > Augie Fackler writes: > >> (+smf - this is for the website) >> >>> On Sep 6, 2018, at 22:07, Bradley M. Jones wrote: >>> >>> # HG changeset patch >>> # User Bradley Jones >>> # Date 1536285273

Re: [PATCH] about: update URLs and prefer https://

Augie Fackler writes: > (+smf - this is for the website) > >> On Sep 6, 2018, at 22:07, Bradley M. Jones wrote: >> >> # HG changeset patch >> # User Bradley Jones >> # Date 1536285273 -43200 >> # Fri Sep 07 13:54:33 2018 +1200 >> # Node ID 4a6711700f7fb592b18164f1032fabb7c10480ec >> #

Re: Discussion about Mercurial 4.8 Sprint

Augie Fackler writes: >> On Jul 13, 2018, at 09:29, Martin von Zweigbergk via Mercurial-devel >> wrote: >> >> We took people's voices into account. That's why we choose Europe over Asia >> (it felt like people on the committee generally preferred Tokyo). But again, >> I agree that we should

Re: Discussion about Mercurial 4.8 Sprint

Martin von Zweigbergk writes: > On Fri, Jul 13, 2018, 00:32 Sean Farley wrote: > >> >> Martin von Zweigbergk writes: >> >> > On Thu, Jul 12, 2018 at 9:11 PM Sean Farley wrote: >> > >> >> >> >> Martin von Zweigbergk wr

Re: Discussion about Mercurial 4.8 Sprint

Martin von Zweigbergk writes: > On Thu, Jul 12, 2018 at 9:11 PM Sean Farley wrote: > >> >> Martin von Zweigbergk writes: >> >> > On Thu, Jul 12, 2018, 17:41 Sean Farley wrote: >> > >> >> >> >> Martin von Zweigbergk via

Re: Discussion about Mercurial 4.8 Sprint

Martin von Zweigbergk writes: > On Thu, Jul 12, 2018, 17:41 Sean Farley wrote: > >> >> Martin von Zweigbergk via Mercurial-devel < >> mercurial-devel@mercurial-scm.org> writes: >> >> > Since there was no consensus in this thread, we discussed it in

Re: Discussion about Mercurial 4.8 Sprint

Martin von Zweigbergk via Mercurial-devel writes: > Since there was no consensus in this thread, we discussed it in the > steering committee. We decided to do it in Europe this time (i.e. the 4.8 > sprint) since everyone indicated that they could make it there. We also > decided to do it Oct

Re: [PATCH 1 of 3 gca-revset V3] revsets: add commonancestors revset

Yuya Nishihara writes: > On Mon, 09 Jul 2018 17:14:27 -0700, Sean Farley wrote: >> # HG changeset patch >> # User Sean Farley >> # Date 1529376114 25200 >> # Mon Jun 18 19:41:54 2018 -0700 >> # Branch gca-revset >> # Node ID 20b61392326c2

[PATCH 2 of 3 gca-revset V3] revset: add optimization for heads(commonancestors())

# HG changeset patch # User Sean Farley # Date 1530051981 25200 # Tue Jun 26 15:26:21 2018 -0700 # Branch gca-revset # Node ID 31ada9bee6360235a9fb027b867b50fba721ebb7 # Parent 20b61392326c251c5898ab34a610829113e3da0b revset: add optimization for heads(commonancestors()) Previously

[PATCH 3 of 3 gca-revset V3] contrib: add heads(commonancestors(_)) to all-revsets

# HG changeset patch # User Sean Farley # Date 1529539666 25200 # Wed Jun 20 17:07:46 2018 -0700 # Branch gca-revset # Node ID e22217eac5ebb878a7a85d11047f8a367f8f64fe # Parent 31ada9bee6360235a9fb027b867b50fba721ebb7 contrib: add heads(commonancestors(_)) to all-revsets This is mainly

[PATCH 1 of 3 gca-revset V3] revsets: add commonancestors revset

# HG changeset patch # User Sean Farley # Date 1529376114 25200 # Mon Jun 18 19:41:54 2018 -0700 # Branch gca-revset # Node ID 20b61392326c251c5898ab34a610829113e3da0b # Parent c153f440682f6b0d512065a915c9f4909ed05180 revsets: add commonancestors revset This is a method to reproduce &quo

Re: [PATCH 2 of 4] revlog: refactor out the rev-oriented part of commonancestorheads

Yuya Nishihara writes: > On Sun, 01 Jul 2018 08:38:40 +0200, Paul Morelle wrote: >> # HG changeset patch >> # User Boris Feld >> # Date 1529621811 -3600 >> # Thu Jun 21 23:56:51 2018 +0100 >> # Node ID 494f5f95311e3b36a01cca745e52f536c3977a5c >> # Parent

Re: [PATCH 2 of 3 gca-revset V2] revset: add optimization for heads(commonancestors())

Yuya Nishihara writes: > On Tue, 26 Jun 2018 15:40:38 -0700, Sean Farley wrote: >> # HG changeset patch >> # User Sean Farley >> # Date 1530051981 25200 >> # Tue Jun 26 15:26:21 2018 -0700 >> # Branch gca-revset >> # Node ID 0bab83973dbae

Re: [PATCH 1 of 3 gca-revset V2] revsets: add commonancestors revset

Yuya Nishihara writes: > On Tue, 26 Jun 2018 15:40:37 -0700, Sean Farley wrote: >> # HG changeset patch >> # User Sean Farley >> # Date 1529376114 25200 >> # Mon Jun 18 19:41:54 2018 -0700 >> # Branch gca-revset >> # Node ID 6034db436

[PATCH 2 of 3 gca-revset V2] revset: add optimization for heads(commonancestors())

# HG changeset patch # User Sean Farley # Date 1530051981 25200 # Tue Jun 26 15:26:21 2018 -0700 # Branch gca-revset # Node ID 0bab83973dbaecf03167801ddc4550c4b8b581f1 # Parent 6034db436af9b15237bb87f82405eb039dfb revset: add optimization for heads(commonancestors()) Previously

[PATCH 3 of 3 gca-revset V2] contrib: add heads(commonancestors(_)) to all-revsets

# HG changeset patch # User Sean Farley # Date 1529539666 25200 # Wed Jun 20 17:07:46 2018 -0700 # Branch gca-revset # Node ID 89ef7e1c9e733402c0ffdb009da359fde371750f # Parent 0bab83973dbaecf03167801ddc4550c4b8b581f1 contrib: add heads(commonancestors(_)) to all-revsets This is mainly

[PATCH 1 of 3 gca-revset V2] revsets: add commonancestors revset

# HG changeset patch # User Sean Farley # Date 1529376114 25200 # Mon Jun 18 19:41:54 2018 -0700 # Branch gca-revset # Node ID 6034db436af9b15237bb87f82405eb039dfb # Parent 2f5c622fcb739aed795c9ab51ea69c3b46436054 revsets: add commonancestors revset This is a method to reproduce &quo

Re: [PATCH 3 of 3 gca-revset] revset: add a new commonancestorheads method

Yuya Nishihara writes: > On Fri, 15 Jun 2018 11:19:47 -0700, Sean Farley wrote: >> >> # HG changeset patch >> >> # User Sean Farley >> >> # Date 1527357855 -7200 >> >> # Sat May 26 20:04:15 2018 +0200 >> >> # Branch gca-

D3665: graph: improve graph output by using Unicode characters

smf added a comment. In https://phab.mercurial-scm.org/D3665#58976, @smf wrote: > In https://phab.mercurial-scm.org/D3665#58973, @johnstiles wrote: > > > Thanks for the assist, @smf ! I appreciate it. > > > Sure, no problem :-) > > By the way, here's the diff of what I

D3665: graph: improve graph output by using Unicode characters

smf added a comment. In https://phab.mercurial-scm.org/D3665#58973, @johnstiles wrote: > Thanks for the assist, @smf ! I appreciate it. Sure, no problem :-) By the way, here's the diff of what I changed: diff --git a/hgext/beautifygraph.py b/hgext/beautifygraph.py

D3665: graph: improve graph output by using Unicode characters

smf added a comment. Greg and Jun, Before anyone else requests more changes or anything, this is a first time contributor and I was trying to be a bit more flexible as a reviewer. I actually queued the patch yesterday but due to the test failures, I haven't pushed. I'll personally fix

D3665: graph: improve graph output by using Unicode characters

smf added a comment. Could you send me the output of `hg export REV | head` or do you just want me to add your name and not worry about the date/time, etc.? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3665 To: johnstiles, #hg-reviewers, spectral Cc:

Re: D3665: graph: improve graph output by using Unicode characters

johnstiles (John Stiles) writes: > johnstiles added a comment. > > > In https://phab.mercurial-scm.org/D3665#58828, @smf wrote: > > > I've looked this over today and have queued this up :-) Unfortunately, > though, the metadata doesn't seem right? I'm not getting your name or email >

D3665: graph: improve graph output by using Unicode characters

smf added a comment. I've looked this over today and have queued this up :-) Unfortunately, though, the metadata doesn't seem right? I'm not getting your name or email (nor timestamp) for the patch. Do you want me to use the same name from

Re: [PATCH 3 of 3 gca-revset] revset: add a new commonancestorheads method

Yuya Nishihara writes: > On Fri, 15 Jun 2018 00:10:25 -0700, Sean Farley wrote: >> # HG changeset patch >> # User Sean Farley >> # Date 1527357855 -7200 >> # Sat May 26 20:04:15 2018 +0200 >> # Branch gca-revset >> # Node ID d44266127f1a8

Re: D3715: namespaces: allow namespaces whose symbols resolve to many nodes (API)

gt; > > > > martinvonz added a comment. > > > > > > In https://phab.mercurial-scm.org/D3715#58720, @smf wrote: > > > > > > > Sean Farley writes: > > > > > > > > This patch strikes me as a Se

[PATCH 3 of 3 gca-revset] revset: add a new commonancestorheads method

# HG changeset patch # User Sean Farley # Date 1527357855 -7200 # Sat May 26 20:04:15 2018 +0200 # Branch gca-revset # Node ID d44266127f1a86af521df2b2c088528c3f3b803a # Parent ab29cfd39f48432d8e7c38cdceb62980d5c22f09 revset: add a new commonancestorheads method This is a new revset

[PATCH 1 of 3 gca-revset] context: factor out commonancestorsheads calculation

# HG changeset patch # User Sean Farley # Date 1527357492 -7200 # Sat May 26 19:58:12 2018 +0200 # Branch gca-revset # Node ID 6dbbddee08084074fd1a7662e18424a7b70318e2 # Parent c019db5ccfa155de8a98cced1e7f5ddaede439e5 context: factor out commonancestorsheads calculation A future patch

[PATCH 2 of 3 gca-revset] context: add a method to return a list of common ancestor changesets

# HG changeset patch # User Sean Farley # Date 1527357601 -7200 # Sat May 26 20:00:01 2018 +0200 # Branch gca-revset # Node ID ab29cfd39f48432d8e7c38cdceb62980d5c22f09 # Parent 6dbbddee08084074fd1a7662e18424a7b70318e2 context: add a method to return a list of common ancestor changesets

Re: D3715: namespaces: allow namespaces whose symbols resolve to many nodes (API)

--=-=-= Content-Type: text/plain martinvonz (Martin von Zweigbergk) writes: > martinvonz added a comment. > > > In https://phab.mercurial-scm.org/D3715#58720, @smf wrote: > > > Sean Farley writes: > > > > > durin42 (Augie Fackler) writes: >

D3715: namespaces: allow namespaces whose symbols resolve to many nodes (API)

smf added a comment. It seems I'm having email sending trouble ... going to attempt to send again REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3715 To: martinvonz, #hg-reviewers, durin42 Cc: durin42, smf, lothiraldan, mercurial-devel

Re: D3665: graph: improve graph output by using Unicode characters

johnstiles (John Stiles) writes: > johnstiles added a comment. > > > I have put together an album of various fonts from my discussions with > @yuja earlier in the thread: https://imgur.com/a/xFkj4zv > > I'm a Menlo or DejaVu guy myself. Ah, I only just now realized each image had the

Re: D3728: grep: adds unmodified mode

Yuya Nishihara writes: >> > commands.py:2411 >> > _('only search files changed within revision range'), _('REV')), >> > +('', 'unmodified', False, >> > + _('include all files in the changeset while grepping')), >> >> I wonder if `--allfiles` is a better name. `--unmodified`

Re: D3665: graph: improve graph output by using Unicode characters

johnstiles (John Stiles) writes: > johnstiles added a comment. > > > Side note: I'm unfamiliar with the lingo here, what's +0 on a feature? > Indifference? Ah, yeah, sorry. To me, at least, it's a "sure but I don't want to be blamed if it fails" ;-P (basically, "I won't block this"). Maybe

Re: D3665: graph: improve graph output by using Unicode characters

johnstiles (John Stiles) writes: > johnstiles added a comment. > > > It all depends on your terminal font. It looks like the font you're using > now has issues with U+2506 ┆ and is otherwise working as expected. Yeah, that was my fault. I forgot I had a different font for unicode symbols to

Re: D3715: namespaces: allow namespaces whose symbols resolve to many nodes (API)

Sean Farley writes: > durin42 (Augie Fackler) writes: > >> durin42 added subscribers: lothiraldan, smf, durin42. >> durin42 accepted this revision as: durin42. >> durin42 added a comment. >> >> >> I'm in favor, but feel like I've got enough

Re: D3684: shelve: merge in obsshelve changes implemented at facebook

durin42 (Augie Fackler) writes: > durin42 created this revision. > Herald added a subscriber: mercurial-devel. > Herald added a reviewer: hg-reviewers. > > REVISION SUMMARY > test-obsshelve.t could be merged with test-shelve.t at some point, but > for now I want the comprehensive coverage.

Re: D3715: namespaces: allow namespaces whose symbols resolve to many nodes (API)

durin42 (Augie Fackler) writes: > durin42 added subscribers: lothiraldan, smf, durin42. > durin42 accepted this revision as: durin42. > durin42 added a comment. > > > I'm in favor, but feel like I've got enough conflict of interest I > shouldn't land the patches. > > @smf @lothiraldan this

Re: Discussion about Mercurial 4.8 Sprint

Kyle Lippincott writes: > On Thu, Jun 7, 2018 at 9:16 PM, Sean Farley wrote: > >> >> Kyle Lippincott writes: >> >> > On Thu, Jun 7, 2018 at 9:16 AM, Boris FELD >> wrote: >> > >> >> Hello everyone, >> >> >> >&g

Re: Discussion about Mercurial 4.8 Sprint

Augie Fackler writes: >> On Jun 7, 2018, at 14:50, Kyle Lippincott wrote: >> The arguments, as I understood them, for it being NOT Europe taking this >> initial hit was that the Spring 2018 sprint was that there were issues that >> prevented some people who would otherwise have attended it

Re: Discussion about Mercurial 4.8 Sprint

Kyle Lippincott writes: > On Thu, Jun 7, 2018 at 9:16 AM, Boris FELD wrote: > >> Hello everyone, >> >> I have also been in contact with Mercurial contributors, small >> contributors and users from Europe. From what we heard, it's both a >> question of time involvements and energy cost that is

Re: Discussion about Mercurial 4.8 Sprint

Kevin Bullock writes: >> On Jun 5, 2018, at 23:02, Sean Farley wrote: >> >> Hello everyone! >> >> I want to bring up a discussion about the next location for the sprint. >> In my recent travels, I talked with ~10 people who expressed some >> rese

Discussion about Mercurial 4.8 Sprint

Hello everyone! I want to bring up a discussion about the next location for the sprint. In my recent travels, I talked with ~10 people who expressed some reservations about being able to make the next sprint if it is held in Japan. I was a bit bummed out but that was for selfish reasons (because

Re: D3665: graph: improve graph output by using Unicode characters

johnstiles (John Stiles) writes: > johnstiles added a comment. > > > In https://phab.mercurial-scm.org/D3665#57649, @smf wrote: > > > johnstiles (John Stiles) writes: > > > > > johnstiles added a comment. > > > > > > yuya, I believe these patches should address all of your

Re: D3665: graph: improve graph output by using Unicode characters

johnstiles (John Stiles) writes: > johnstiles added a comment. > > > yuya, I believe these patches should address all of your concerns except > for `encoding._wide`. I am not sure what your expectation is for that. I > don't think it would make sense to silently disable the extension if >

Re: [PATCH 3 of 3 RFC] revset: add an 'all' argument to ancestor() to return

Yuya Nishihara writes: > On Mon, 28 May 2018 21:27:40 +0900, Yuya Nishihara wrote: >> On Sun, 27 May 2018 13:48:18 +0200, Sean Farley wrote: >> > # HG changeset patch >> > # User Sean Farley >> > # Date 1527357855 -7200 >> > #

Re: [PATCH 3 of 3 RFC] revset: add an 'all' argument to ancestor() to return

Sean Farley <s...@farley.io> writes: > # HG changeset patch > # User Sean Farley <s...@farley.io> > # Date 1527357855 -7200 > # Sat May 26 20:04:15 2018 +0200 > # Node ID 9fa3f81f4685ca73393f57253f2f05a0d758c022 > # Parent 000e9442997b1c61ae02a27e657ffb34d17

[PATCH 1 of 3 RFC] context: factor out commonancestorsheads calculation

# HG changeset patch # User Sean Farley <s...@farley.io> # Date 1527357492 -7200 # Sat May 26 19:58:12 2018 +0200 # Node ID 6a31ef919a2440e79a1477d428b46408bf3667ab # Parent cc9aa88792fe8daf041521710f52be59c69b79eb # EXP-Topic gca-revset context: factor out commonancestorsheads calcu

[PATCH 3 of 3 RFC] revset: add an 'all' argument to ancestor() to return

# HG changeset patch # User Sean Farley <s...@farley.io> # Date 1527357855 -7200 # Sat May 26 20:04:15 2018 +0200 # Node ID 9fa3f81f4685ca73393f57253f2f05a0d758c022 # Parent 000e9442997b1c61ae02a27e657ffb34d170502b # EXP-Topic gca-revset revset: add an 'all' argument to ancestor() to

[PATCH 2 of 3 RFC] context: add a method to return a list of common ancestor changesets

# HG changeset patch # User Sean Farley <s...@farley.io> # Date 1527357601 -7200 # Sat May 26 20:00:01 2018 +0200 # Node ID 000e9442997b1c61ae02a27e657ffb34d170502b # Parent 6a31ef919a2440e79a1477d428b46408bf3667ab # EXP-Topic gca-revset context: add a method to return a list of

Re: Welcoming Google Summer of Code students.

Pulkit Goyal <7895pul...@gmail.com> writes: > Hey everyone, > > This year we have two students selected for Google Summer of Code. > > * Sangeet Kumar Mishra > > He will be working the GrepPlan, fixing the behavior of `hg grep`. JordiGH > will be primary mentor for him. > > * Sushil Khanchi > >

D2873: remotenames: add functionality to override -B flag of push

smf added a comment. In https://phab.mercurial-scm.org/D2873#52100, @indygreg wrote: > In https://phab.mercurial-scm.org/D2873#52025, @smf wrote: > > > In https://phab.mercurial-scm.org/D2873#52021, @indygreg wrote: > > > > > Looks good! > > > > > > I'm very heavily against

D2873: remotenames: add functionality to override -B flag of push

smf added a comment. In https://phab.mercurial-scm.org/D2873#52021, @indygreg wrote: > Looks good! I'm very heavily against this direction. Changing the behavior of push (even in this extension) is something I've always considered outside the scope of remotenames. Having another

Re: [PATCH 1 of 6 remotenames-ext] Back out "remotenames: push anonymous head if --force is given"

Ryan McElroy <r...@fb.com> writes: > On 2/20/18 11:44 PM, Sean Farley wrote: >> Ryan McElroy <r...@fb.com> writes: >> >>> # HG changeset patch >>> # User Ryan McElroy <rmcel...@fb.com> >>> # Date 1519040197 2

Re: [PATCH 1 of 6 remotenames-ext] Back out "remotenames: push anonymous head if --force is given"

Ryan McElroy writes: > # HG changeset patch > # User Ryan McElroy > # Date 1519040197 28800 > # Mon Feb 19 03:36:37 2018 -0800 > # Node ID 6b80188783ee2626030113a9b2319f2fd14a8119 > # Parent 905b79d62df82d8ca16ecac175e6236fe959f4ed > Back out "remotenames:

Re: D2277: remotenames: don't use the default value of logfmt for namespaces

pulkit (Pulkit Goyal) writes: > pulkit updated this revision to Diff 5777. > pulkit edited the summary of this revision. > > REPOSITORY > rHG Mercurial > > CHANGES SINCE LAST UPDATE > https://phab.mercurial-scm.org/D2277?vs=5756=5777 > > REVISION DETAIL >

Re: D1756: remotenames: introduce class to encapsulate remotenames info in an extension

martinvonz (Martin von Zweigbergk) writes: > martinvonz added inline comments. > > INLINE COMMENTS > >> remotenames.py:23 >> + >> +class remotenames(dict): >> +""" > > Why does this extend dict? Do we expect callers to update bookmarks by doing > something

Re: Ideas and mentors for GSoC 2018.

Pulkit Goyal <7895pul...@gmail.com> writes: > On Wed, Jan 17, 2018 at 1:01 AM, Pulkit Goyal <7895pul...@gmail.com> wrote: >> Hey everyone, >> >> We are taking part in Google Summer of Code from past two years under >> Python Software Foundation and we wish to continue the same this year. >> >>

Re: Bitbucket Topics support (evolve)

James Reynolds writes: > Hello all: > > I was wondering if bitbucket supports Topics from evolve yet? Sort of. > I tried an experimental repo and doing something like: > > hg push -t topic2 > > I get > > abort: push creates new remote head e8901ce212b5! There's some

Re: [PATCH] lfs: add an experimental config to masquerade as git for the blob transfer

Matt Harbison <mharbiso...@gmail.com> writes: > On Thu, 14 Dec 2017 19:51:37 -0500, Sean Farley <s...@farley.io> wrote: > >> >> Augie Fackler <r...@durin42.com> writes: >> >>>> On Dec 13, 2017, at 6:20 PM, Matt Harbison <mharbiso...@gma

Re: [PATCH] lfs: add an experimental config to masquerade as git for the blob transfer

Augie Fackler writes: >> On Dec 13, 2017, at 6:20 PM, Matt Harbison wrote: >> >> >> On Dec 13, 2017, at 9:48 AM, Augie Fackler > > wrote: >> >>> >>> I don't either. Do whichever of the versions that

Re: D1232: rebase: add the --inmemory option flag; assign a wctx object for the rebase

durin42 (Augie Fackler) writes: > durin42 added a comment. > > > Phil is planning to follow up with the config knob, and I hope to test this > aggressively at Google and make it default if we don't find any bugs. Same for me here (it's what we already do

Re: D1232: rebase: add the --inmemory option flag; assign a wctx object for the rebase

dlax (Denis Laxalde) writes: > dlax requested changes to this revision. > dlax added a comment. > This revision now requires changes to proceed. > > > > In the future, the --inmemory flag might be deprecated in favor of > something more intelligent > >

Re: D1607: remotenames: rename related file and storage dir to logexchange

pulkit (Pulkit Goyal) writes: > pulkit updated this revision to Diff 4162. > pulkit edited the summary of this revision. > pulkit retitled this revision from "remotenames: rename the file to > logexchange" to "remotenames: rename related file and storage dir to

Re: D1551: remotenames: consider existing data while storing newer data

durin42 (Augie Fackler) writes: > durin42 added a comment. > > > In https://phab.mercurial-scm.org/D1551#27325, @smf wrote: > > > durin42 (Augie Fackler) writes: > > > > > durin42 added a comment. > > > > > > I'm

Security Disclosures

Steering committee (and others that might have better ideas than I): It was brought to my attention by our security team of how embarrassing it is to report a security bug to Mercurial. For our last security bug, I must agree we really bumbled it. In particular, a user reported this security bug

Re: D1551: remotenames: consider existing data while storing newer data

durin42 (Augie Fackler) writes: > durin42 added a comment. > > > I'm landing this series as-is, even though there are some good ideas for > how we could improve the storage layer. My reasoning is this: we've had this > as a semi-popular extension for literally

Re: [PATCH 02 of 15 V2] bookmark: add methods to binary encode and decode bookmark values

Augie Fackler writes: >> On Nov 13, 2017, at 05:16, Boris Feld wrote: >> >> On Fri, 2017-11-10 at 17:35 -0500, Augie Fackler wrote: >>> (+indygreg, who also is a formats enthusiast) >>> >>> On Thu, Nov 02, 2017 at 02:17:59PM +0100, Boris Feld wrote:

Re: D1358: remotenames: store journal entry for bookmarks if journal is loaded

pulkit (Pulkit Goyal) writes: > pulkit added a comment. > > > In https://phab.mercurial-scm.org/D1358#23866, @smf wrote: > > > pulkit (Pulkit Goyal) writes: > > > > > pulkit added a comment. > > > > > > In

Re: D1358: remotenames: store journal entry for bookmarks if journal is loaded

pulkit (Pulkit Goyal) writes: > pulkit added a comment. > > > In https://phab.mercurial-scm.org/D1358#23388, @smf wrote: > > > > durin42 added a comment. > > > > > > I don't think so. IMO the storage-only parts can and should go > straight in core

Re: D1358: remotenames: store journal entry for bookmarks if journal is loaded

durin42 (Augie Fackler) writes: > durin42 added a comment. > > > In https://phab.mercurial-scm.org/D1358#22899, @smf wrote: > > > pulkit (Pulkit Goyal) writes: > > > > > pulkit created this revision. > > > Herald added a

Re: D1358: remotenames: store journal entry for bookmarks if journal is loaded

pulkit (Pulkit Goyal) writes: > pulkit created this revision. > Herald added a subscriber: mercurial-devel. > Herald added a reviewer: hg-reviewers. > > REPOSITORY > rHG Mercurial > > REVISION DETAIL > https://phab.mercurial-scm.org/D1358 > > AFFECTED FILES >

Re: D937: remotenames: move function to pull remotenames from the remoterepo to core

pulkit (Pulkit Goyal) writes: > pulkit created this revision. > Herald added a subscriber: mercurial-devel. > Herald added a reviewer: hg-reviewers. > > REVISION SUMMARY > This patch moves the functionality to pull branches and bookmarks from a > server from

Re: [PATCH remotenames-ext] remotenames: push anonymous head if --force is given

Pulkit Goyal <7895pul...@gmail.com> writes: > # HG changeset patch > # User Pulkit Goyal <7895pul...@gmail.com> > # Date 1507153197 -19800 > # Thu Oct 05 03:09:57 2017 +0530 > # Node ID b3cf58915bc36b7e01470f6a55dc5bd8b8f4cc9a > # Parent e7cce2b6198ace7769e2c68a5b67eddde794cfeb >

Re: [PATCH remotenames-ext] tests: re-order tags and bookmarks in tracking test

Martijn Pieters writes: > Review handled on Phabricator, at https://phab.mercurial-scm.org/D830 This was incorrectly pushed it seems. I'll fix it locally and re-push. I imagine Ryan messed this up due to his extensions that I assume hide non-bookmarked heads? Anyways, I've

Re: bitbucket issues org-sync

Uwe Brauer writes: >> Uwe Brauer writes: > > >> I suspect I can help you since I work at Bitbucket and am a heavy user >> of org-mode (emacs 4 life). > > Thanks I appreciate that. Right now this week I am very busy, but when I > find the time I

Re: Request of recommendations for public Mercurial repository hosting

Mario Castelán Castro writes: > On 17/09/17 12:04, Mario Castelán Castro wrote: >> My only candidate so far is Bitbucket. I want to know if there are other >> options. I have already discarded SourceForge because it has Google JS. >> All other providers that I know

D612: directaccess: add a hiddenlevel argument to registrar.command

smf added a comment. Has there been discussion around extensions using this? Should there be discussion now? Specifically, I'm trying to figure out how external things will use this feature. Should it be a try/except? Or should modules set the access level before looking for a (potentially)

Re: hg-ssh: add --exclude command line option

Nathan Goldbaum writes: > The patches you're sending in should be sent according to the guidelines > for contributing to mercurial, see: > > https://www.mercurial-scm.org/wiki/ContributingChanges > > As is, these patches will not be applied until you send in patches >

Re: bitbucket issues org-sync

Uwe Brauer writes: > Hi > > That might be a bit off topic, but I hope to find some GNU emacs users > here on that list. I just learned there exist > https://github.com/arbox/org-sync > > A elisp package for emacs which imports and exports issues from github > bb and others to

D464: commit: use an unambiguous path suffix for the commit editor file

smf added inline comments. INLINE COMMENTS > durin42 wrote in cmdutil.py:3214 > I agree with smf: this patch is accomplishing a reasonable thing, but we > should clean up this interface if we're going to use it. Let's add an action= > parameter that's optional in the 4.4 cycle, with a devel

D464: commit: use an unambiguous path suffix for the commit editor file

smf added a comment. Everything I was talking about in https://phab.mercurial-scm.org/D468 was meant to be posted here. (I am not doing well with phabricator it seems) REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D464 To: mbolin, quark, durin42,

D468: util: use ~ as a suffix for a temp file in the same directory as a source file

smf added a comment. In https://phab.mercurial-scm.org/D468#7920, @mbolin wrote: > @smf so are you OK with this patch as-is? Yeah, should be fine. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D468 To: mbolin, #hg-reviewers, quark, durin42 Cc: smf,

D468: util: use ~ as a suffix for a temp file in the same directory as a source file

smf added a comment. In https://phab.mercurial-scm.org/D468#7915, @mbolin wrote: > @smf Personally, I think that https://phab.mercurial-scm.org/D464 is a better place to have that discussion. Sigh. Yes, this is what I was confused about. REPOSITORY rHG Mercurial REVISION

D468: util: use ~ as a suffix for a temp file in the same directory as a source file

smf added a comment. In https://phab.mercurial-scm.org/D468#7916, @durin42 wrote: > In https://phab.mercurial-scm.org/D468#7914, @smf wrote: > > > Basically, I was pondering aloud if '~' would be enough to future-proof us and if we shouldn't just rename all temp files to something

D468: util: use ~ as a suffix for a temp file in the same directory as a source file

smf added a comment. In https://phab.mercurial-scm.org/D468#7912, @mbolin wrote: > @smf As I put in the summary, I think this use of `tempfile.mkstemp()` is different than the others in the codebase because it uses the `dir=` argument to create a file in the working copy. As such, I'd

D468: util: use ~ as a suffix for a temp file in the same directory as a source file

smf added a comment. In https://phab.mercurial-scm.org/D468#7910, @smf wrote: > That seems a bit over complicated to me. Why not just just use the > random tmp as a directory instead of a file while renaming the file at > the same time: > > /tmp/XYZ123/hg-editor (or HG_EDITOR or

D468: util: use ~ as a suffix for a temp file in the same directory as a source file

smf added a comment. In https://phab.mercurial-scm.org/D468#7909, @durin42 wrote: > In https://phab.mercurial-scm.org/D468#7908, @smf wrote: > > > In https://phab.mercurial-scm.org/D468#7836, @quark wrote: > > > > > In https://phab.mercurial-scm.org/D468#7833, @smf wrote: > > >

D468: util: use ~ as a suffix for a temp file in the same directory as a source file

smf added a comment. In https://phab.mercurial-scm.org/D468#7836, @quark wrote: > In https://phab.mercurial-scm.org/D468#7833, @smf wrote: > > > Basically, I'd like a more unified approach for all types of temp files (commit message, histedit, conflicts, etc). > > > I think

  1   2   3   4   5   6   >