Re: [Mesa-dev] [PATCH v2 0/5] i965: ASTC5x5 workaround

2018-02-13 Thread Tapani Pälli
On 14.02.2018 09:54, Tapani Pälli wrote: On 14.02.2018 09:38, Rogovin, Kevin wrote: Hi,   The 3rd patch, "i965: use ASTC5x5 workaround in intel_miptree_texture_aux_usage has issues:     1. Definitely: brw_draw lacks the call to gen9_astc5x5_perform_wa() which generates the needed flush be

Re: [Mesa-dev] [PATCH v2 0/5] i965: ASTC5x5 workaround

2018-02-13 Thread Tapani Pälli
On 14.02.2018 09:38, Rogovin, Kevin wrote: Hi, The 3rd patch, "i965: use ASTC5x5 workaround in intel_miptree_texture_aux_usage has issues: 1. Definitely: brw_draw lacks the call to gen9_astc5x5_perform_wa() which generates the needed flush between batchbuffers Now it happens via i

Re: [Mesa-dev] [PATCH v3] intel/tools: new intel_sanitize_gpu tool

2018-02-13 Thread Rogovin, Kevin
Reviewed by: kevin.rogovin [at] intel.com -Original Message- From: Phillips, Scott D Sent: Friday, February 9, 2018 3:11 AM To: mesa-dev@lists.freedesktop.org; Rogovin, Kevin Subject: [PATCH v3] intel/tools: new intel_sanitize_gpu tool From: Kevin Rogovin Adds a new debug tool to pad

Re: [Mesa-dev] [PATCH v2 0/5] i965: ASTC5x5 workaround

2018-02-13 Thread Rogovin, Kevin
Hi, The 3rd patch, "i965: use ASTC5x5 workaround in intel_miptree_texture_aux_usage has issues: 1. Definitely: brw_draw lacks the call to gen9_astc5x5_perform_wa() which generates the needed flush between batchbuffers 2. Uneasy: I am nervous about hitting intel_miptree_texture_aux_us

Re: [Mesa-dev] [PATCH 1/5] i965/tiled_memcpy: change linear pointer from (0, 0) to (xt1, yt1)

2018-02-13 Thread Kenneth Graunke
On Tuesday, January 9, 2018 11:16:58 PM PST Scott D Phillips wrote: > In all current uses, the linear surface is only allocated starting > at (xt1, yt1) anyway, so this improves the calling ergonomics. > --- > src/mesa/drivers/dri/i965/intel_pixel_read.c | 2 +- > src/mesa/drivers/dri/i965/inte

[Mesa-dev] [PATCH] r600/sb: fix rotated register in while loop

2018-02-13 Thread Dave Airlie
From: Dave Airlie A bunch of CTS tests led me to write tests/shaders/ssa/fs-while-loop-rotate-value.shader_test which r600/sb always fell over on. This patch fixes it, but I'll probably never be 100% sure why. Anyways what appears to be happening is when gcm is scheduling the copy_movs used for

Re: [Mesa-dev] [PATCH 1/2] intel/aubinator: Correctly decode INTERFACE_DESCRIPTOR_DATA

2018-02-13 Thread Kenneth Graunke
On Monday, February 12, 2018 7:35:04 PM PST Jason Ekstrand wrote: > --- > src/intel/tools/gen_batch_decoder.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/intel/tools/gen_batch_decoder.c > b/src/intel/tools/gen_batch_decoder.c > index 78db83b..1a8794c 100644 > ---

Re: [Mesa-dev] [PATCH 2/2] anv/pipeline: Set the correct binding count for compute shaders

2018-02-13 Thread Kenneth Graunke
On Monday, February 12, 2018 7:35:05 PM PST Jason Ekstrand wrote: > --- > src/intel/vulkan/genX_pipeline.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/intel/vulkan/genX_pipeline.c > b/src/intel/vulkan/genX_pipeline.c > index 45ebe31..4aee9ec 100644 > --- a/src/in

Re: [Mesa-dev] [PATCH] i965: Add gl_state_index casts for PATCH_VERTICES_IN

2018-02-13 Thread Kenneth Graunke
On Tuesday, February 13, 2018 2:57:07 PM PST Jason Ekstrand wrote: > This fixes the build in clang > --- > src/mesa/drivers/dri/i965/brw_nir_uniforms.cpp | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/src/mesa/drivers/dri/i965/brw_nir_uniforms.cpp > b/src/mesa/drivers

Re: [Mesa-dev] [PATCH 1/2] nir: retain pixel_center_integer information when lowering gl_FragCoord

2018-02-13 Thread Kenneth Graunke
On Tuesday, February 13, 2018 10:00:44 PM PST Timothy Arceri wrote: > On 14/02/18 16:24, Jason Ekstrand wrote: > > First off, you should add an index to the intrinsic if you're going to > > do this and it should probably be set elsewhere. Otherwise, it becomes > > this magic secret radeonsi thin

[Mesa-dev] [PATCH 5/5] ac: use correct LLVM opcodes for ordered comparisons

2018-02-13 Thread Timothy Arceri
Fixes glsl-1.30/execution/isinf-and-isnan* piglit tests for radeonsi and should fix SPIRV errors when LLVM optimises away the workarounds in vtn_handle_alu() for handling ordered comparisons. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104905 --- src/amd/common/ac_nir_to_llvm.c | 8 +++

[Mesa-dev] [RFC 1/5] nir: add unordered opcode variants of float comparisons

2018-02-13 Thread Timothy Arceri
This will enable the nir->llvm translation to work correctly. --- src/compiler/nir/nir_opcodes.py | 4 1 file changed, 4 insertions(+) diff --git a/src/compiler/nir/nir_opcodes.py b/src/compiler/nir/nir_opcodes.py index 278562b2bd..61c004c6f8 100644 --- a/src/compiler/nir/nir_opcodes.py +++

[Mesa-dev] [RFC 2/5] i965: add support for unordered float comparison opcodes

2018-02-13 Thread Timothy Arceri
--- src/intel/compiler/brw_fs_nir.cpp | 10 +- src/intel/compiler/brw_vec4_nir.cpp | 4 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/src/intel/compiler/brw_fs_nir.cpp b/src/intel/compiler/brw_fs_nir.cpp index 0d77564930..cf3df75cd5 100644 --- a/src/intel/compiler

[Mesa-dev] [RFC 3/5] ac: add support for unordered float comparison opcodes

2018-02-13 Thread Timothy Arceri
--- src/amd/common/ac_nir_to_llvm.c | 12 1 file changed, 12 insertions(+) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index 8d1eed241f..a0c5680205 100644 --- a/src/amd/common/ac_nir_to_llvm.c +++ b/src/amd/common/ac_nir_to_llvm.c @@ -1803,6 +1803,1

[Mesa-dev] [RFC 4/5] spirv: make use of unordered float comparison opcodes

2018-02-13 Thread Timothy Arceri
--- src/compiler/spirv/vtn_alu.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/compiler/spirv/vtn_alu.c b/src/compiler/spirv/vtn_alu.c index d0c9e31693..fd36c6537b 100644 --- a/src/compiler/spirv/vtn_alu.c +++ b/src/compiler/spirv/vtn_alu.c @@ -326,26 +326,26

Re: [Mesa-dev] [PATCH 1/2] nir: retain pixel_center_integer information when lowering gl_FragCoord

2018-02-13 Thread Timothy Arceri
On 14/02/18 16:24, Jason Ekstrand wrote: First off, you should add an index to the intrinsic if you're going to do this and it should probably be set elsewhere.  Otherwise, it becomes this magic secret radeonsi thing. Ah yes that's how it's done, I thought there was a better way to do this th

Re: [Mesa-dev] [PATCH] i965: Add gl_state_index casts for PATCH_VERTICES_IN

2018-02-13 Thread Tapani Pälli
Reviewed-by: Tapani Pälli On 14.02.2018 00:57, Jason Ekstrand wrote: This fixes the build in clang --- src/mesa/drivers/dri/i965/brw_nir_uniforms.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_nir_uniforms.cpp b/src/mesa/drivers/dri/i

Re: [Mesa-dev] [PATCH 1/2] nir: retain pixel_center_integer information when lowering gl_FragCoord

2018-02-13 Thread Jason Ekstrand
First off, you should add an index to the intrinsic if you're going to do this and it should probably be set elsewhere. Otherwise, it becomes this magic secret radeonsi thing. Second, do you really want this on the intrinsic or would it be better as part of shader_info? It's always been weird to

[Mesa-dev] [Bug 104915] Indexed SHADING_LANGUAGE_VERSION query not supported

2018-02-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104915 Tapani Pälli changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

[Mesa-dev] [PATCH 2/2] radeonsi/nir: fix gl_FragCoord for pixel_center_integer

2018-02-13 Thread Timothy Arceri
--- src/gallium/drivers/radeonsi/si_shader_nir.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_shader_nir.c b/src/gallium/drivers/radeonsi/si_shader_nir.c index b46c7dca86..cb4f8e9255 100644 --- a/src/gallium/drivers/radeonsi/si_shader_nir.c +++ b/src/g

[Mesa-dev] [PATCH 1/2] nir: retain pixel_center_integer information when lowering gl_FragCoord

2018-02-13 Thread Timothy Arceri
radeonsi needs to gather this information. --- src/compiler/nir/nir_lower_system_values.c | 9 + 1 file changed, 9 insertions(+) diff --git a/src/compiler/nir/nir_lower_system_values.c b/src/compiler/nir/nir_lower_system_values.c index 3594f4ae5c..f8d8463f7f 100644 --- a/src/compiler/nir

[Mesa-dev] [PATCH] virgl: remap query types to hw support.

2018-02-13 Thread Dave Airlie
From: Dave Airlie The gallium query types changed, so we need to remap from the gallium ones to the virgl ones. Fixes: dEQP-GLES3.functional.transform_feedback.basic_types* Fixes: 3f6b3d9db (gallium: add PIPE_QUERY_OCCLUSION_PREDICATE_CONSERVATIVE) Signed-off-by: Dave Airlie --- src/gallium/

Re: [Mesa-dev] [PATCH 13/14] anv/cmd_buffer: Do subpass image transitions in begin/end_subpass

2018-02-13 Thread Jason Ekstrand
On Tue, Feb 13, 2018 at 5:34 PM, Nanley Chery wrote: > On Mon, Feb 05, 2018 at 02:35:02PM -0800, Jason Ekstrand wrote: > > --- > > src/intel/vulkan/genX_cmd_buffer.c | 190 +- > --- > > 1 file changed, 68 insertions(+), 122 deletions(-) > > > > diff --git a/src/in

Re: [Mesa-dev] [PATCH 07/14] anv/cmd_buffer: Decide whether or not to HiZ clear up-front

2018-02-13 Thread Jason Ekstrand
You're going to want to re-review this one when I send the v2. It changed quite a bit. On Tue, Feb 13, 2018 at 2:44 PM, Jason Ekstrand wrote: > On Tue, Feb 13, 2018 at 11:02 AM, Nanley Chery > wrote: > >> On Mon, Feb 05, 2018 at 02:34:56PM -0800, Jason Ekstrand wrote: >> > This moves the decis

Re: [Mesa-dev] [PATCH 05/16] intel/isl/icl: Build and use gen11 surface state emit functions

2018-02-13 Thread Kenneth Graunke
On Tuesday, February 13, 2018 11:15:05 AM PST Anuj Phogat wrote: > Signed-off-by: Anuj Phogat > --- > src/intel/Android.isl.mk | 20 > src/intel/Makefile.isl.am | 4 > src/intel/Makefile.sources | 4 > src/intel/isl/isl.c| 3 +++ > src/intel/isl/isl_pr

Re: [Mesa-dev] [PATCH 03/16] intel/genxml/icl: Update genx_bits header

2018-02-13 Thread Kenneth Graunke
On Tuesday, February 13, 2018 11:15:03 AM PST Anuj Phogat wrote: > Signed-off-by: Anuj Phogat > --- > src/intel/genxml/gen_bits_header.py | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/intel/genxml/gen_bits_header.py > b/src/intel/genxml/gen_bits_header.py > index 1b3504073b..965a

Re: [Mesa-dev] [PATCH 08/16] i965/icl: Build and use gen11 functions for genxml state-upload and blorp

2018-02-13 Thread Kenneth Graunke
On Tuesday, February 13, 2018 11:15:08 AM PST Anuj Phogat wrote: > Signed-off-by: Anuj Phogat Reviewed-by: Kenneth Graunke signature.asc Description: This is a digitally signed message part. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org ht

Re: [Mesa-dev] [PATCH 07/16] i965/icl: Don't set ResetGatewayTimer

2018-02-13 Thread Kenneth Graunke
On Tuesday, February 13, 2018 11:15:07 AM PST Anuj Phogat wrote: > This field is removed in gen11+ > > Signed-off-by: Anuj Phogat > --- > src/mesa/drivers/dri/i965/genX_state_upload.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/src/mesa/drivers/dri/i965/genX_state_upload.c > b/s

Re: [Mesa-dev] [PATCH 10/16] i965/icl: Define and use icl mocs settings

2018-02-13 Thread Kenneth Graunke
On Tuesday, February 13, 2018 11:15:10 AM PST Anuj Phogat wrote: > Gen11 MOCS settings are duplicate of Gen10 MOCS settings. > > Signed-off-by: Anuj Phogat > --- > src/mesa/drivers/dri/i965/brw_state.h| 6 ++ > src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 2 ++ > src/mesa/d

Re: [Mesa-dev] [PATCH 11/16] i965/icl: Update the assert in brw_memory_barrier()

2018-02-13 Thread Kenneth Graunke
On Tuesday, February 13, 2018 11:15:11 AM PST Anuj Phogat wrote: > Nothing is changed here from gen10 to gen11. So, just update > the assert. > > Signed-off-by: Anuj Phogat > --- > src/mesa/drivers/dri/i965/brw_program.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/s

Re: [Mesa-dev] [PATCH 02/16] intel/genxml/icl: Generate packing headers

2018-02-13 Thread Kenneth Graunke
On Tuesday, February 13, 2018 11:15:02 AM PST Anuj Phogat wrote: > Signed-off-by: Anuj Phogat > --- > src/intel/Android.genxml.mk | 5 + > src/intel/Makefile.sources| 3 ++- > src/intel/genxml/genX_pack.h | 2 ++ > src/intel/genxml/gen_macros.h | 3 +++ > 4 files changed, 12 insertions

Re: [Mesa-dev] [PATCH 13/14] anv/cmd_buffer: Do subpass image transitions in begin/end_subpass

2018-02-13 Thread Nanley Chery
On Mon, Feb 05, 2018 at 02:35:02PM -0800, Jason Ekstrand wrote: > --- > src/intel/vulkan/genX_cmd_buffer.c | 190 > + > 1 file changed, 68 insertions(+), 122 deletions(-) > > diff --git a/src/intel/vulkan/genX_cmd_buffer.c > b/src/intel/vulkan/genX_cmd_buffer

[Mesa-dev] [PATCH] radeonsi/nir: fix si_nir_load_tcs_varyings() for outputs

2018-02-13 Thread Timothy Arceri
We were incorrectly using the input info for outputs. --- src/gallium/drivers/radeonsi/si_shader.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c index 825cb9dd0e..ec03f537d0 10

Re: [Mesa-dev] [PATCH 12/14] anv/cmd_buffer: Mark depth/stencil surfaces written in begin_subpass

2018-02-13 Thread Jason Ekstrand
On Tue, Feb 13, 2018 at 4:47 PM, Nanley Chery wrote: > On Mon, Feb 05, 2018 at 02:35:01PM -0800, Jason Ekstrand wrote: > > --- > > src/intel/vulkan/genX_cmd_buffer.c | 50 ++ > > > 1 file changed, 29 insertions(+), 21 deletions(-) > > > > diff --git a/src/int

Re: [Mesa-dev] [PATCH 11/14] anv/cmd_buffer: Sync clear values in begin_subpass

2018-02-13 Thread Jason Ekstrand
On Tue, Feb 13, 2018 at 4:35 PM, Nanley Chery wrote: > On Mon, Feb 05, 2018 at 02:35:00PM -0800, Jason Ekstrand wrote: > > This is quite a bit cleaner because we now sync the clear values at the > > same time as we do the fast clear. For loading the clear values into > > the surface state, we no

[Mesa-dev] [AppVeyor] mesa master #6908 completed

2018-02-13 Thread AppVeyor
Build mesa 6908 completed Commit f6718baabc by Roland Scheidegger on 2/13/2018 5:56 PM: tgsi: Recognize RET in main for tgsi_transform\n\nShaders coming from dx10 state trackers have a RET before the END.\nAnd the epilog needs to be placed before the RET (other

Re: [Mesa-dev] [PATCH 12/14] anv/cmd_buffer: Mark depth/stencil surfaces written in begin_subpass

2018-02-13 Thread Nanley Chery
On Mon, Feb 05, 2018 at 02:35:01PM -0800, Jason Ekstrand wrote: > --- > src/intel/vulkan/genX_cmd_buffer.c | 50 > ++ > 1 file changed, 29 insertions(+), 21 deletions(-) > > diff --git a/src/intel/vulkan/genX_cmd_buffer.c > b/src/intel/vulkan/genX_cmd_buffer.

[Mesa-dev] [AppVeyor] mesa master #6907 failed

2018-02-13 Thread AppVeyor
Build mesa 6907 failed Commit 7461bd5b8f by Bas Nieuwenhuizen on 2/13/2018 10:25 PM: ac: Use the renumbered const address space for LLVM 7.\n\nThe LLVM AMDGPU backend decided to renumber the constant address\nspace \n\nReviewed-by: Samuel Pitoiset

Re: [Mesa-dev] [PATCH 11/14] anv/cmd_buffer: Sync clear values in begin_subpass

2018-02-13 Thread Nanley Chery
On Mon, Feb 05, 2018 at 02:35:00PM -0800, Jason Ekstrand wrote: > This is quite a bit cleaner because we now sync the clear values at the > same time as we do the fast clear. For loading the clear values into > the surface state, we now do it once when we handle the LOAD_OP_LOAD > instead of every

[Mesa-dev] [PATCH 19/21] vulkan: Add VK_GOOGLE_display_timing extension (x11 and display backends)

2018-02-13 Thread Keith Packard
This adds support for the VK_GOOGLE_display timing extension, which provides two things: 1) Detailed information about when frames are displayed, including slack time between GPU execution and display frame. 2) Absolute time control over swapchain queue processing. This allows the appli

[Mesa-dev] [PATCH 01/21] vulkan: Add KHR_display extension using DRM

2018-02-13 Thread Keith Packard
This adds support for the KHR_display extension support to the vulkan WSI layer. Driver support will be added separately. Signed-off-by: Keith Packard --- configure.ac|1 + meson.build |4 +- src/amd/vulkan/radv_wsi.c |3 +- s

[Mesa-dev] [PATCH 10/21] vulkan: Add VK_EXT_display_surface_counter [v3]

2018-02-13 Thread Keith Packard
This extension is required to support EXT_display_control as it offers a way to query whether the vblank counter is supported. v2: Thanks to kisak Fix spelling of VkSurfaceCapabilities2EXT in wsi_common_wayland.c, it was using ext instead of EXT. Fix spelling of VK_STRUCTURE_TYPE_SUR

[Mesa-dev] [PATCH 18/21] radv: Add new VK_MESA_query_timestamp extension to radv driver

2018-02-13 Thread Keith Packard
This extension adds a single function to query the current GPU timestamp, just like glGetInteger64v(GL_TIMESTAMP, ×tamp). This function is needed to complete the implementation of GOOGLE_display_timing, which needs to be able to coorelate GPU and CPU timestamps. Signed-off-by: Keith Packard ---

[Mesa-dev] [PATCH 20/21] anv: Add VK_GOOGLE_display_timing extension to anv driver

2018-02-13 Thread Keith Packard
This adds support for the VK_GOOGLE_display timing extension. Signed-off-by: Keith Packard --- src/intel/vulkan/anv_extensions.py | 1 + src/intel/vulkan/anv_wsi.c | 29 + 2 files changed, 30 insertions(+) diff --git a/src/intel/vulkan/anv_extensions.py b/s

[Mesa-dev] [PATCH 12/21] radv: Add VK_EXT_display_surface_counter to radv driver

2018-02-13 Thread Keith Packard
This extension is required to support EXT_display_control as it offers a way to query whether the vblank counter is supported. Signed-off-by: Keith Packard --- src/amd/vulkan/radv_extensions.py | 1 + src/amd/vulkan/radv_wsi.c | 12 2 files changed, 13 insertions(+) diff -

[Mesa-dev] [PATCH 21/21] radv: Add VK_GOOGLE_display_timing extension to radv driver

2018-02-13 Thread Keith Packard
This adds support for the VK_GOOGLE_display timing extension. Signed-off-by: Keith Packard --- src/amd/vulkan/radv_extensions.py | 1 + src/amd/vulkan/radv_wsi.c | 32 2 files changed, 33 insertions(+) diff --git a/src/amd/vulkan/radv_extensions.py b/s

[Mesa-dev] [PATCH 09/21] radv: Add EXT_acquire_xlib_display to radv driver

2018-02-13 Thread Keith Packard
This extension adds the ability to borrow an X RandR output for temporary use directly by a Vulkan application to the radv driver. Signed-off-by: Keith Packard --- src/amd/vulkan/Makefile.am| 7 +++ src/amd/vulkan/meson.build| 7 +++ src/amd/vulkan/radv_extensions.py |

[Mesa-dev] [PATCH 13/21] vulkan: add VK_EXT_display_control [v3]

2018-02-13 Thread Keith Packard
This extension provides fences and frame count information to direct display contexts. It uses new kernel ioctls to provide 64-bits of vblank sequence and nanosecond resolution. v2: Remove DRM_CRTC_SEQUENCE_FIRST_PIXEL_OUT flag. This has been removed from the proposed kernel API. Add NULL

[Mesa-dev] [PATCH 06/21] radv: Add EXT_direct_mode_display to radv driver

2018-02-13 Thread Keith Packard
Add support for the EXT_direct_mode_display extension. This just provides the vkReleaseDisplayEXT function. Signed-off-by: Keith Packard --- src/amd/vulkan/radv_extensions.py | 1 + src/amd/vulkan/radv_wsi_display.c | 11 +++ 2 files changed, 12 insertions(+) diff --git a/src/amd/vulka

[Mesa-dev] [PATCH 17/21] anv: Add new VK_MESA_query_timestamp extension to anv driver

2018-02-13 Thread Keith Packard
This extension adds a single function to query the current GPU timestamp, just like glGetInteger64v(GL_TIMESTAMP, ×tamp). This function is needed to complete the implementation of GOOGLE_display_timing, which needs to be able to coorelate GPU and CPU timestamps. Signed-off-by: Keith Packard ---

[Mesa-dev] [PATCH 15/21] radv: add VK_EXT_display_control to radv driver

2018-02-13 Thread Keith Packard
This extension provides fences and frame count information to direct display contexts. It uses new kernel ioctls to provide 64-bits of vblank sequence and nanosecond resolution. Signed-off-by: Keith Packard --- src/amd/vulkan/radv_extensions.py | 1 + src/amd/vulkan/radv_private.h | 11 ++

[Mesa-dev] [PATCH 07/21] vulkan: Add EXT_acquire_xlib_display

2018-02-13 Thread Keith Packard
This extension adds the ability to borrow an X RandR output for temporary use directly by a Vulkan application. For DRM, we use the Linux resource leasing mechanism. Signed-off-by: Keith Packard --- configure.ac| 32 +++ meson.build | 17 ++ meso

[Mesa-dev] [PATCH 11/21] anv: Add VK_EXT_display_surface_counter to anv driver [v4]

2018-02-13 Thread Keith Packard
This extension is required to support EXT_display_control as it offers a way to query whether the vblank counter is supported. v4: Add anv support Signed-off-by: Keith Packard --- src/intel/vulkan/anv_extensions.py | 1 + src/intel/vulkan/anv_wsi.c | 12 2 files changed, 1

[Mesa-dev] [PATCH 16/21] vulkan: Define new VK_MESA_query_timestamp extension

2018-02-13 Thread Keith Packard
This extension adds a single function to query the current GPU timestamp, just like glGetInteger64v(GL_TIMESTAMP, ×tamp). This function is needed to complete the implementation of GOOGLE_display_timing, which needs to be able to coorelate GPU and CPU timestamps. Signed-off-by: Keith Packard ---

[Mesa-dev] [PATCH 04/21] vulkan: Add EXT_direct_mode_display

2018-02-13 Thread Keith Packard
Add support for the EXT_direct_mode_display extension. This just provides the vkReleaseDisplayEXT function. Signed-off-by: Keith Packard --- src/vulkan/wsi/wsi_common_display.c | 17 + src/vulkan/wsi/wsi_common_display.h | 5 + 2 files changed, 22 insertions(+) diff --git a

[Mesa-dev] [PATCH 05/21] anv: Add EXT_direct_mode_display to anv driver

2018-02-13 Thread Keith Packard
Add support for the EXT_direct_mode_display extension. This just provides the vkReleaseDisplayEXT function. Signed-off-by: Keith Packard --- src/intel/vulkan/anv_extensions.py | 1 + src/intel/vulkan/anv_wsi_display.c | 11 +++ 2 files changed, 12 insertions(+) diff --git a/src/intel/v

[Mesa-dev] [PATCH 14/21] anv: add VK_EXT_display_control to anv driver

2018-02-13 Thread Keith Packard
This extension provides fences and frame count information to direct display contexts. It uses new kernel ioctls to provide 64-bits of vblank sequence and nanosecond resolution. Signed-off-by: Keith Packard --- src/intel/vulkan/anv_extensions.py | 1 + src/intel/vulkan/anv_private.h | 4

[Mesa-dev] [PATCH 0/21] Add KHR_display through GOOGLE_display_timing [v2]

2018-02-13 Thread Keith Packard
Dave Airlie asked me to split these up so that the core and anv/radv bits were all in separate patches. There are no code changes here aside from fixing the KHR_display version from 1 to 23. I also fixed the indentation in the changes to the radv driver from spaces to tabs as per convention. -kei

[Mesa-dev] [PATCH 02/21] anv: Add KHR_display extension to anv

2018-02-13 Thread Keith Packard
This adds support for the KHR_display extension to the anv Vulkan driver. The driver now attempts to open the master DRM node when the KHR_display extension is requested so that the common winsys code can perform the necessary operations. Signed-off-by: Keith Packard --- src/intel/Makefile.sourc

[Mesa-dev] [PATCH 03/21] radv: Add KHR_display extension to radv

2018-02-13 Thread Keith Packard
This adds support for the KHR_display extension to the radv Vulkan driver. The driver now attempts to open the master DRM node when the KHR_display extension is requested so that the common winsys code can perform the necessary operations. Signed-off-by: Keith Packard --- src/amd/vulkan/Makefile

[Mesa-dev] [PATCH 08/21] anv: Add EXT_acquire_xlib_display to anv driver

2018-02-13 Thread Keith Packard
This extension adds the ability to borrow an X RandR output for temporary use directly by a Vulkan application to the anv driver. Signed-off-by: Keith Packard --- src/intel/Makefile.vulkan.am | 7 +++ src/intel/vulkan/anv_extensions.py | 1 + src/intel/vulkan/anv_extensions_g

Re: [Mesa-dev] [PATCH 09/14] anv/cmd_buffer: Add a concept of pending load aspects

2018-02-13 Thread Nanley Chery
On Mon, Feb 05, 2018 at 02:34:58PM -0800, Jason Ekstrand wrote: > These are the same as pending clear aspects only for the "load" > operation. > --- > src/intel/vulkan/anv_private.h | 1 + > src/intel/vulkan/genX_cmd_buffer.c | 22 -- > 2 files changed, 17 insertions(+), 6

Re: [Mesa-dev] [PATCH 14/16] i965/icl: Disable HiZ surface sampling

2018-02-13 Thread Kenneth Graunke
On Tuesday, February 13, 2018 11:15:14 AM PST Anuj Phogat wrote: > On gen11+ AUX_HIZ is not a supported value for surfaces being > sampled by the 3D sampler. > > Signed-off-by: Anuj Phogat > --- > src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 delet

Re: [Mesa-dev] [PATCH 10/14] anv/pass: Store usage in each subpass attachment

2018-02-13 Thread Nanley Chery
On Mon, Feb 05, 2018 at 02:34:59PM -0800, Jason Ekstrand wrote: > This requires us to ditch the VkAttachmentReference struct in favor of > an anv-specific struct. However, we can now easily identify from just > the subpass attachment what kind of an attachment it is. This will make > iteration ov

Re: [Mesa-dev] [PATCH 10/14] anv/pass: Store usage in each subpass attachment

2018-02-13 Thread Nanley Chery
On Tue, Feb 13, 2018 at 03:23:42PM -0800, Jason Ekstrand wrote: > On Tue, Feb 13, 2018 at 3:18 PM, Nanley Chery wrote: > > > On Mon, Feb 05, 2018 at 02:34:59PM -0800, Jason Ekstrand wrote: > > > This requires us to ditch the VkAttachmentReference struct in favor of > > > an anv-specific struct.

Re: [Mesa-dev] [PATCH 16/16] i965/icl: Add render target flush after uploading binding table

2018-02-13 Thread Kenneth Graunke
On Tuesday, February 13, 2018 11:15:16 AM PST Anuj Phogat wrote: > From PIPE_CONTROL command description in gfxspecs: > > "Whenever a Binding Table Index (BTI) used by a Render Taget Message > points to a different RENDER_SURFACE_STATE, SW must issue a Render > Target Cache Flush by enabling thi

Re: [Mesa-dev] [PATCH 15/16] i965/icl: Enable float blend optimization and Wa3DStateMode

2018-02-13 Thread Kenneth Graunke
On Tuesday, February 13, 2018 11:15:15 AM PST Anuj Phogat wrote: > Signed-off-by: Anuj Phogat > --- > src/mesa/drivers/dri/i965/brw_state_upload.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/mesa/drivers/dri/i965/brw_state_upload.c > b/src/mesa/drivers/dri/i965/

Re: [Mesa-dev] [PATCH 12/16] i965/icl: Update switch statements

2018-02-13 Thread Kenneth Graunke
On Tuesday, February 13, 2018 11:15:12 AM PST Anuj Phogat wrote: > Signed-off-by: Anuj Phogat > --- > src/mesa/drivers/dri/i965/brw_formatquery.c | 1 + > src/mesa/drivers/dri/i965/intel_screen.c| 1 + > 2 files changed, 2 insertions(+) > > diff --git a/src/mesa/drivers/dri/i965/brw_formatqu

Re: [Mesa-dev] [PATCH 13/16] i965/icl: Add assertions to check dispatch mode is SIMD8

2018-02-13 Thread Kenneth Graunke
On Tuesday, February 13, 2018 11:15:13 AM PST Anuj Phogat wrote: > SIMD4x2 dispatch mode has been removed in GEN11. We're not using > it anyways in Mesa. Adding few asserts to make it explicit. > > Signed-off-by: Anuj Phogat > --- > src/intel/blorp/blorp_genX_exec.h | 4 > src/m

Re: [Mesa-dev] [PATCH 09/16] i965/icl: Update the comment for maximum number of threads per PSD

2018-02-13 Thread Kenneth Graunke
On Tuesday, February 13, 2018 11:15:09 AM PST Anuj Phogat wrote: > Signed-off-by: Anuj Phogat > --- > src/intel/blorp/blorp_genX_exec.h | 9 + > src/mesa/drivers/dri/i965/genX_state_upload.c | 9 + > 2 files changed, 10 insertions(+), 8 deletions(-) Reviewed-by: Kenne

Re: [Mesa-dev] [PATCH 10/14] anv/pass: Store usage in each subpass attachment

2018-02-13 Thread Jason Ekstrand
On Tue, Feb 13, 2018 at 3:18 PM, Nanley Chery wrote: > On Mon, Feb 05, 2018 at 02:34:59PM -0800, Jason Ekstrand wrote: > > This requires us to ditch the VkAttachmentReference struct in favor of > > an anv-specific struct. However, we can now easily identify from just > > the subpass attachment w

Re: [Mesa-dev] [PATCH] ac: Use the renumbered const address space for LLVM 7.

2018-02-13 Thread Samuel Pitoiset
Reviewed-by: Samuel Pitoiset On 02/13/2018 11:41 PM, Bas Nieuwenhuizen wrote: The LLVM AMDGPU backend decided to renumber the constant address space --- src/amd/common/ac_llvm_build.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/amd/common/ac_llvm_build.h b/

Re: [Mesa-dev] [PATCH 10/14] anv/pass: Store usage in each subpass attachment

2018-02-13 Thread Nanley Chery
On Mon, Feb 05, 2018 at 02:34:59PM -0800, Jason Ekstrand wrote: > This requires us to ditch the VkAttachmentReference struct in favor of > an anv-specific struct. However, we can now easily identify from just > the subpass attachment what kind of an attachment it is. This will make > iteration ov

Re: [Mesa-dev] [PATCH 06/16] intel/icl: Do StateCacheInvalidation for indirect clear color

2018-02-13 Thread Kenneth Graunke
On Tuesday, February 13, 2018 11:15:06 AM PST Anuj Phogat wrote: > StateCacheInvalidation is required on all gen7+ platforms. We > don't need to update this check for every new gen h/w unless > this requirement is changed. So, dropping the check for latest > gen h/w. > > Signed-off-by: Anuj Phogat

Re: [Mesa-dev] [PATCH 04/16] intel/isl/icl: Add the maximum surface size limit

2018-02-13 Thread Kenneth Graunke
On Tuesday, February 13, 2018 11:15:04 AM PST Anuj Phogat wrote: > Signed-off-by: Anuj Phogat > --- > src/intel/isl/isl.c | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/src/intel/isl/isl.c b/src/intel/isl/isl.c > index 59f512fc05..c9873d96df 100644 > --- a/src/inte

Re: [Mesa-dev] [PATCH 2/3] anv/gen10: Remove warning message.

2018-02-13 Thread Kenneth Graunke
On Tuesday, February 13, 2018 1:51:54 PM PST Rafael Antognolli wrote: > Gen10 seems pretty stable so far, remove "alpha support" message. > > Signed-off-by: Rafael Antognolli > Cc: Jason Ekstrand > Cc: "18.0" mesa-sta...@lists.freedesktop.org > --- > src/intel/vulkan/anv_device.c | 8 +++- >

Re: [Mesa-dev] [PATCH 08/14] anv/cmd_buffer: Iterate all subpass attachments when clearing

2018-02-13 Thread Jason Ekstrand
On Tue, Feb 13, 2018 at 11:29 AM, Nanley Chery wrote: > On Mon, Feb 05, 2018 at 02:34:57PM -0800, Jason Ekstrand wrote: > > This unifies things a bit because we now handle depth and stencil at the > > same time. It also ensures that clears happen for input attachments. > > As we discussed in ano

Re: [Mesa-dev] [PATCH] swr: bump minimum supported LLVM version to 4.0

2018-02-13 Thread Kyriazis, George
> On Feb 13, 2018, at 4:54 PM, Dylan Baker wrote: > > Quoting Andres Gomez (2018-02-13 14:42:57) > [snip] >> >> -if with_amd_vk or with_gallium_radeonsi >> +if with_amd_vk or with_gallium_radeonsi or with_gallium_swr >> _llvm_version = '>= 4.0.0' >> -elif with_gallium_opencl or with_gallium_s

[Mesa-dev] [PATCH] i965: Add gl_state_index casts for PATCH_VERTICES_IN

2018-02-13 Thread Jason Ekstrand
This fixes the build in clang --- src/mesa/drivers/dri/i965/brw_nir_uniforms.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_nir_uniforms.cpp b/src/mesa/drivers/dri/i965/brw_nir_uniforms.cpp index 10a4ff4..69da83a 100644 --- a/src/mesa/drive

Re: [Mesa-dev] [PATCH] swr: bump minimum supported LLVM version to 4.0

2018-02-13 Thread Kyriazis, George
I am not an expert on all the changes needed for travis and packaging, but the swr changes look good. Reviewed-by: George Kyriazis mailto:george.kyria...@intel.com>> On Feb 13, 2018, at 4:42 PM, Andres Gomez mailto:ago...@igalia.com>> wrote: Since radv and radeonsi removed support for LLVM 3.

Re: [Mesa-dev] [PATCH] swr: bump minimum supported LLVM version to 4.0

2018-02-13 Thread Dylan Baker
Quoting Andres Gomez (2018-02-13 14:42:57) [snip] > > -if with_amd_vk or with_gallium_radeonsi > +if with_amd_vk or with_gallium_radeonsi or with_gallium_swr >_llvm_version = '>= 4.0.0' > -elif with_gallium_opencl or with_gallium_swr or with_gallium_r600 > +elif with_gallium_opencl or with_ga

Re: [Mesa-dev] [PATCH] travis: radeonsi and radv need LLVM 4.0

2018-02-13 Thread Andres Gomez
On Tue, 2018-02-06 at 19:23 +, Kyriazis, George wrote: > SWR is OK with moving to LLVM 4.0 and above. > > Just to clarify: This goes to master, which means mesa 18.0 is not > affected, just 18.1 and later. Correct? That is my understanding. 3bf1e036e8a, which is the one triggering this chan

Re: [Mesa-dev] [PATCH] i965: Add ICL to test_eu_validate.cpp

2018-02-13 Thread Anuj Phogat
Sent this patch to ML by mistake :(. Reviewers can ignore this one for now. Matt can send it out later with rest of his compiler changes. On Tue, Feb 13, 2018 at 2:41 PM, Anuj Phogat wrote: > From: Matt Turner > > --- > src/intel/compiler/test_eu_validate.cpp | 1 + > 1 file changed, 1 insertio

[Mesa-dev] [PATCH 13/31] swr/rast: Cull prims when all verts have negative clip distances

2018-02-13 Thread George Kyriazis
Performance optimization, and fixes some clipping issues. --- src/gallium/drivers/swr/rasterizer/core/clip.h | 4 1 file changed, 4 insertions(+) diff --git a/src/gallium/drivers/swr/rasterizer/core/clip.h b/src/gallium/drivers/swr/rasterizer/core/clip.h index 1d336b6..5193672 100644 --- a/

[Mesa-dev] [PATCH 26/31] swr/rast: Convert C Sampler intrinsics

2018-02-13 Thread George Kyriazis
Convert portions of the C sampler to the rasty SIMD lib. --- src/gallium/drivers/swr/rasterizer/common/intrin.h | 3 +++ .../drivers/swr/rasterizer/common/simdlib_128_avx.inl| 16 2 files changed, 19 insertions(+) diff --git a/src/gallium/drivers/swr/rasterizer/common/

[Mesa-dev] [PATCH 31/31] swr/rast: blend_epi32() should return Integer, not Float

2018-02-13 Thread George Kyriazis
fix gcc8 compiler error for KNL. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105029 --- src/gallium/drivers/swr/rasterizer/common/simdlib_512_avx512.inl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/swr/rasterizer/common/simdlib_512_avx512.inl

Re: [Mesa-dev] [PATCH 07/14] anv/cmd_buffer: Decide whether or not to HiZ clear up-front

2018-02-13 Thread Jason Ekstrand
On Tue, Feb 13, 2018 at 11:02 AM, Nanley Chery wrote: > On Mon, Feb 05, 2018 at 02:34:56PM -0800, Jason Ekstrand wrote: > > This moves the decision out of begin_subpass and into BeginRenderPass > > like the decision for color clears. We use a similar name for the > > function for depth/stencil a

[Mesa-dev] [PATCH] swr: bump minimum supported LLVM version to 4.0

2018-02-13 Thread Andres Gomez
Since radv and radeonsi removed support for LLVM 3.9 the distcheck target got broken because SWR distribution needed 3.9.x. After checking with George Kyriazis, SWR is OK with moving to LLVM 4.0 and above, which will solve this problem. Fixes: 3bf1e036e8a ("amd: remove support for LLVM 3.9") Cc:

[Mesa-dev] [PATCH 19/31] swr/rast: Make GATHER4PS virtual

2018-02-13 Thread George Kyriazis
--- src/gallium/drivers/swr/rasterizer/jitter/builder_mem.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/swr/rasterizer/jitter/builder_mem.h b/src/gallium/drivers/swr/rasterizer/jitter/builder_mem.h index 14dc22d..f31cb4a 100644 --- a/src/gallium/drivers

[Mesa-dev] [PATCH 28/31] swr/rast: Add semantics for translating address

2018-02-13 Thread George Kyriazis
Added support for another full translation path in fetch jitter. --- src/gallium/drivers/swr/rasterizer/jitter/builder_mem.h | 1 + src/gallium/drivers/swr/rasterizer/jitter/fetch_jit.cpp | 4 2 files changed, 5 insertions(+) diff --git a/src/gallium/drivers/swr/rasterizer/jitter/builder_mem

[Mesa-dev] [PATCH 24/31] swr/rast: Make SIMDLib templated types easier to use

2018-02-13 Thread George Kyriazis
"typename SIMD_T::TypeName" --> "TypeName" --- .../drivers/swr/rasterizer/common/simdlib.hpp | 9 + src/gallium/drivers/swr/rasterizer/core/binner.cpp | 338 ++--- src/gallium/drivers/swr/rasterizer/core/binner.h | 18 +- src/gallium/drivers/swr/rasterizer/core/clip.h

[Mesa-dev] [PATCH 15/31] swr/rast: Fix avx version of GATHERPS

2018-02-13 Thread George Kyriazis
GEP was given the wrong type, and asserting. --- src/gallium/drivers/swr/rasterizer/jitter/builder_mem.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/swr/rasterizer/jitter/builder_mem.cpp b/src/gallium/drivers/swr/rasterizer/jitter/builder_mem.cpp in

[Mesa-dev] [PATCH 29/31] swr/rast: Consolidate archrast Draw events

2018-02-13 Thread George Kyriazis
Consolidate archrst draw events into single draw event with an attribute that represents the type of draw - Add handlers for new private proto versions of DrawInstancedEvent, DrawIndexedInstancedEvent, DrawInstancedSplitEvent, and DrawIndexedInstancedSplitEvent - Convert the draw events to gen

[Mesa-dev] [PATCH 30/31] swr/rast: Normalize path for debug metadata

2018-02-13 Thread George Kyriazis
in template gen_llvm.hpp --- src/gallium/drivers/swr/rasterizer/codegen/templates/gen_llvm.hpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/swr/rasterizer/codegen/templates/gen_llvm.hpp b/src/gallium/drivers/swr/rasterizer/codegen/templates/gen_llvm.hp

[Mesa-dev] [PATCH 23/31] swr/rast: Use right type for offset to next component

2018-02-13 Thread George Kyriazis
--- src/gallium/drivers/swr/rasterizer/jitter/builder_mem.cpp | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/swr/rasterizer/jitter/builder_mem.cpp b/src/gallium/drivers/swr/rasterizer/jitter/builder_mem.cpp index 491fb98..617cf33 100644 --- a/src/g

[Mesa-dev] [PATCH 12/31] swr/rast: whitespace cleanup

2018-02-13 Thread George Kyriazis
--- .../drivers/swr/rasterizer/jitter/JitManager.h | 38 +++--- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/src/gallium/drivers/swr/rasterizer/jitter/JitManager.h b/src/gallium/drivers/swr/rasterizer/jitter/JitManager.h index ddd6864..3660249 100644 --- a/s

[Mesa-dev] [PATCH 17/31] swr/rast: Misc cleanup

2018-02-13 Thread George Kyriazis
Together with correct detection of clipDistance NaNs when no cullDistance is set --- src/gallium/drivers/swr/rasterizer/core/clip.h| 2 +- src/gallium/drivers/swr/rasterizer/core/context.h | 26 src/gallium/drivers/swr/rasterizer/core/state.h | 81 +-- 3 files c

[Mesa-dev] [PATCH 27/31] swr/rast: Fix SRL call with a non-immediate

2018-02-13 Thread George Kyriazis
Don't count on the compiler automagically converting an srli call to srl if the shift count isn't an immediate. --- src/gallium/drivers/swr/rasterizer/common/simdlib_128_avx.inl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/swr/rasterizer/common/simdli

[Mesa-dev] [PATCH 11/31] swr/rast: Fix invalid number of attributes

2018-02-13 Thread George Kyriazis
Fix invalid number of attributes passed into tesselation PA. Needs to take into account any offsets from the shader. nnocuous issue, but removes an assert firing in debug. --- src/gallium/drivers/swr/rasterizer/core/frontend.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/s

[Mesa-dev] [PATCH 25/31] swr/rast: Update/add comments

2018-02-13 Thread George Kyriazis
--- src/gallium/drivers/swr/rasterizer/core/api.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/swr/rasterizer/core/api.cpp b/src/gallium/drivers/swr/rasterizer/core/api.cpp index f45da96..99d3cd5 100644 --- a/src/gallium/drivers/swr/rasterizer/core/a

  1   2   >