RE: approval request for JDK-8138906:Test test/script/trusted/JDK-8087292.js intermittently fails

/webrev.00/ Jdk8u webrev: http://cr.openjdk.java.net/~sdama/8138906/8u/webrev.01/ Regards, Srinivas -Original Message- From: Seán Coffey Sent: Monday, May 30, 2016 6:56 PM To: Srinivas Dama Subject: Re: approval request for JDK-8138906:Test test/script/trusted/JDK-8087292.js intermittently

RFR:DK-8148457(Remove jdk.nashorn.tools.FXShell class and associated build.xml cruft)

Hi, Please review: http://cr.openjdk.java.net/~sdama/8148457/webrev.00/ Bug: https://bugs.openjdk.java.net/browse/JDK-8148457 I have verified all debug logs generated out of make targets for jdk9 forest build and nashorn ant targets. Regards, Srinivas

RFR:8158817

Hi, Please review http://cr.openjdk.java.net/~sdama/8158817/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8158817 Regards, Srinivas

approval request for JDK-8138906:Test test/script/trusted/JDK-8087292.js intermittently fails

Hi, Please approve. Bug: https://bugs.openjdk.java.net/browse/JDK-8138906 Jdk9 review thread : http://mail.openjdk.java.net/pipermail/nashorn-dev/2016-February/005991.html Jdk8u-webrev : http://cr.openjdk.java.net/~sdama/8138906/8u/webrev.00/ Regards, Srinivas

Review request for JDK-8138906

Hello All, Please review : Bug : https://bugs.openjdk.java.net/browse/JDK-8138906 Webrev : http://cr.openjdk.java.net/~sdama/8138906/webrev.01 Fix is to pick 'java' from specified JAVA_HOME folder, along with this, I have added some utility functions(can be added more) which can be used in all

Review request for JDK-8138906

Hi, Please review http://cr.openjdk.java.net/~sdama/8138906/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8138906 I did testing with recent $EXEC changes from Michael and very small code cleanup. Regards, Srinivas

Review request for JDK-8147613

Hi, Please review : Webrev : http://cr.openjdk.java.net/~sdama/8147613/webrev.00/ It covers fix for both: https://bugs.openjdk.java.net/browse/JDK-8147613 https://bugs.openjdk.java.net/browse/JDK-8147788 Regards, Srinivas

RE: Review request for JDK-8138906

Dama Cc: nashorn-dev@openjdk.java.net Subject: Re: Review request for JDK-8138906   Hi Srinivas,   Am 29.02.2016 um 17:28 schrieb Srinivas Dama mailto:srinivas.d...@oracle.com"srinivas.d...@oracle.com>: Please review : Bug : https://bugs.openjdk.java.net/browse/JDK-8138906 Webre

RE: RFR(S): 8151291: $EXEC yields "unknown command" on Cygwin

Hi Michael, Looks good. Few limitations with absolute paths. On cmd.exe: jjs -scripting $EXEC("D:\work\nashorn-dev\dev\build\windows-x86_64-normal-server-release\images\jdk\bin\java.exe") Good thing is on cygwin if we give mixed path like:

RE: RFR 8160801 :add documentation for NativeString

Hi Michael,   Thank you for comments .   Please find patch with your suggestions added at http://cr.openjdk.java.net/~sdama/8160801/webrev.00/   Regards, Srinivas   From: Michael Haupt Sent: Tuesday, July 26, 2016 6:06 PM To: Srinivas Dama Cc: Nashorn-dev Subject: Re: RFR 8160801 :add

RFR 8160801 :add documentation for NativeString

Hello, Please review http://cr.openjdk.java.net/~sdama/8160801/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8160801 Regards, Srinivas

RE: RFR: 8134304: NPE in initialization of OptimisticTypesPersistence

Hi, Please review http://cr.openjdk.java.net/~sdama/8134304/webrev.01/ for https://bugs.openjdk.java.net/browse/JDK-8134304 Localized fix only to OptimisticTypesPersistence.java. Regards, Srinivas -Original Message- From: Srinivas Dama Sent: Wednesday, August 10, 2016 2:40 PM

RFR 8142969:Nashorn logging API requires testing

Hi, Please review http://cr.openjdk.java.net/~sdama/8142969/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8142969 Fixed the existing test case and moved it from test/script/currently-failing to test/script/nosecurity directory. Regards, Srinivas

RFR: 8156743: ES6 for..of should work for Java Maps and Sets

Hello, Please review http://cr.openjdk.java.net/~sdama/8156743/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8156743 Regards, Srinivas

RFR 8166296:add documentation for Date,RegExp,Error,JSON objects

Hello, Please review http://cr.openjdk.java.net/~sdama/8166296/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8166296 Regards, Srinivas

RFR:8164618: add documentation for NativeNumber and NativeBoolean

Hi, Please review http://cr.openjdk.java.net/~sdama/8164618/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8164618 Regards, Srinivas

RE: RFR: 8156615:Catch parameter can be a BindingPattern in ES6 mode

or not (e.g. if it just looks like an object/array literal). Attila. > On 10 Nov 2016, at 12:46, Srinivas Dama <srinivas.d...@oracle.com> wrote: > > Hi, > > Please review > Bug: https://bugs.openjdk.java.net/browse/JDK-8156615 > webrev: http://cr.openjdk.java.n

RFR 8168663: Nashorn: ant testng tests doesn't support external java options

Hi, Please review http://cr.openjdk.java.net/~sdama/8168663/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8168663 Added run.test.jvmargs.external property so that we can pass jvm options for complete test run as below. ant -Drun.test.jvmargs.external="-XX:+UseSerialGC

RFR: 8151994 (test/script/basic/JDK-8141209.js fails)

Hi, Please review http://cr.openjdk.java.net/~sdama/8151994/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8151994 Added @fork tag in test case since test runner without fork uses customized output stream to compare output, whereas test case uses System.out. Regards, Srinivas

RE: RFR: 8151994 (test/script/basic/JDK-8141209.js fails)

To: Srinivas Dama Cc: Nashorn-dev Subject: Re: RFR: 8151994 (test/script/basic/JDK-8141209.js fails) +1 Hannes > Am 20.12.2016 um 16:01 schrieb Srinivas Dama <srinivas.d...@oracle.com>: > > Hi, > > Please review http://cr.openjdk.java.net/~sdama/8151994/we

RFR: 8178315: nashorn ant build failure with @moduleGraph javadoc tag

Hi, Please review http://cr.openjdk.java.net/~bgopularam/sdama/8178315/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8178315 . Regards, Srinivas

RE: RFR: 8156743: ES6 for..of should work for Java Maps and Sets

Hi Attila, Thank you for the detailed review. Regards, Srinivas -Original Message- From: Attila Szegedi [mailto:szege...@gmail.com] Sent: Thursday, March 02, 2017 9:01 PM To: Srinivas Dama Cc: Nashorn-dev Subject: Re: RFR: 8156743: ES6 for..of should work for Java Maps and Sets

RFR: 8184239(Fix broken nashorn/samples)

Hi, Please review http://cr.openjdk.java.net/~sdama/8184239/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8184239 Regards, Srinivas

RE: RFR: 8184241(Fix nashorn/samples/filebrowser.js)

in the future?) Hannes > Am 19.07.2017 um 10:45 schrieb Srinivas Dama <srinivas.d...@oracle.com>: > > Hi, > > Please review http://cr.openjdk.java.net/~sdama/8184241/webrev.00/ for > https://bugs.openjdk.java.net/browse/JDK-8184241. > > Regards, > Srinivas

RFR: 8184241(Fix nashorn/samples/filebrowser.js)

Hi, Please review http://cr.openjdk.java.net/~sdama/8184241/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8184241. Regards, Srinivas

RFR: 8180727(Use jdk.editpad to replace jdk.nashorn.tools.jjs.EditPad duplicated class)

Hi, Please review http://cr.openjdk.java.net/~sdama/8180727/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8180727 Regards, Srinivas

RE: [10] RFR: 8184893: jdk8u152 b06 : issues with nashorn when running kraken benchmarks

Hi Hannes, Lower-case thumbs up. -Original Message- From: Hannes Wallnöfer Sent: Tuesday, July 25, 2017 7:14 PM To: Nashorn-dev Subject: [10] RFR: 8184893: jdk8u152 b06 : issues with nashorn when running kraken benchmarks Please review 8184893: jdk8u152 b06 : issues with nashorn when

RE: RFR: 8184239(Fix broken nashorn/samples)

Hi, Please review the updated patch. Sorry I missed one sample earlier. http://cr.openjdk.java.net/~sdama/8184239/webrev.01/ Regards, Srinivas -Original Message- From: Jim Laskey (Oracle) Sent: Wednesday, July 12, 2017 5:34 PM To: Srinivas Dama Cc: Nashorn-Dev Subject: Re: RFR

RFR: 8179891: JavaDoc for for..in is incorrect

Hi, Please review http://cr.openjdk.java.net/~sdama/8179891/webrev.00/index.html for https://bugs.openjdk.java.net/browse/JDK-8179891 Regards, Srinivas

RFR:8186011(Fix samples/java_completion.js and samples/disassemble.js)

Hi, Please review http://cr.openjdk.java.net/~sdama/8186011/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8186011 Regards, Srinivas

RFR: 8185257(Nashorn AST is missing nodes when a for-loop contains a VariableDeclarationList)

Please review http://cr.openjdk.java.net/~sdama/8185257/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8185257 Regards, Srinivas

Re: RFR: 8185257(Nashorn AST is missing nodes when a for-loop contains a VariableDeclarationList)

). Other than that, +1 -Sundar On 12/09/17, 4:58 PM, Srinivas Dama wrote: > Please review http://cr.openjdk.java.net/~sdama/8185257/webrev.00/ > for https://bugs.openjdk.java.net/browse/JDK-8185257 > > Regards, > Srinivas

Re: RFR:8186011(Fix samples/java_completion.js and samples/disassemble.js)

r > > On 19/09/17, 4:03 PM, Srinivas Dama wrote: >> Hi, >> >> Please review http://cr.openjdk.java.net/~sdama/8186011/webrev.00/ >> for https://bugs.openjdk.java.net/browse/JDK-8186011 >> >> Regards, >> Srinivas

RFR:8147076(LinkerCallSite.ARGLIMIT is used incorrectly)

Hi, Please review http://cr.openjdk.java.net/~sdama/8147076/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8147076 Regards, Srinivas

Re: RFR:8147076(LinkerCallSite.ARGLIMIT is used incorrectly)

ult in a double. - I assume eval() in the test is to force this-object and callee to be sent, maybe add a comment about that? - there’s a typo in the test: arguements Hannes > Am 29.09.2017 um 15:34 schrieb Srinivas Dama <srinivas.d...@oracle.com>: > > Hi, >

Re: RFR:8147076(LinkerCallSite.ARGLIMIT is used incorrectly)

lee to be sent, maybe add a comment about that? - there’s a typo in the test: arguements Hannes > Am 29.09.2017 um 15:34 schrieb Srinivas Dama <srinivas.d...@oracle.com>: > > Hi, > > Please review http://cr.openjdk.java.net/~sdama/8147076/webrev.00/ > for https://bugs.

RE: RFR: 8185257(Nashorn AST is missing nodes when a for-loop contains a VariableDeclarationList)

Hi, Please review revised patch after migrating to jdk10/master repo. http://cr.openjdk.java.net/~sdama/8185257/webrev.02/ Regards, Srinivas -Original Message- From: Hannes Wallnöfer Sent: Wednesday, September 13, 2017 1:49 AM To: Srinivas Dama Cc: Nashorn-dev Subject: Re: RFR: 8185257

RE: RFR: 8184720(Nashorn engine in strict mode throws a java.lang.ClassCastException when calling apply() and passing the arguments object)

. Regards, Srinivas -Original Message- From: Hannes Wallnöfer Sent: Wednesday, August 23, 2017 12:15 PM To: Srinivas Dama Cc: Nashorn-Dev Subject: Re: RFR: 8184720(Nashorn engine in strict mode throws a java.lang.ClassCastException when calling apply() and passing the arguments object) Hi Srini

RFR:8073640:Nashorn scripting: here document with only whitespace gives error

Hi, Please review http://cr.openjdk.java.net/~sdama/8073640/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8073640 Regards, srinivas

RFR:8177691:Labeled break in catch and finally works wrongly, when invoked through nashorn

Hi, Please review http://cr.openjdk.java.net/~sdama/8177691/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8177691 Regards, Srinivas

RFR: 8134516(Move getInvokeByName and getDynamicInvoker methods from Global to Context)

Hi, Please review http://cr.openjdk.java.net/~sdama/8134516/webrev.01/ for https://bugs.openjdk.java.net/browse/JDK-8134516 Regards, Srinivas

Re: RFR: 8134516(Move getInvokeByName and getDynamicInvoker methods from Global to Context)

ous e-mail. Attila. > On Dec 6, 2017, at 4:47 PM, Srinivas Dama <srinivas.d...@oracle.com> wrote: > > Hi, > > Please review http://cr.openjdk.java.net/~sdama/8134516/webrev.01/ for > https://bugs.openjdk.java.net/browse/JDK-8134516 > > Regards, > Srinivas