Change in asterixdb[master]: ASTERIXDB-1786: Remove Hyracks Servlets.

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1786: Remove Hyracks Servlets.
..


Patch Set 1:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1899/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1508
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifcd240591d12baab2db4ce3163c635a1dde5c4ba
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: WIP - add result format metadata for result sets

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: WIP - add result format metadata for result sets
..


Patch Set 11: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1898/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1404
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc4eddd23f508962483f3470e88760bf8124dc25
Gerrit-PatchSet: 11
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Fix asterix-docker

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Fix asterix-docker
..


Patch Set 1:

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1897/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1506
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifac17caf603f1d4f1c53413996d833869d68a266
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Jianfeng Jia 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Add integration tests for Hyracks' HTTP APIs

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Add integration tests for Hyracks' HTTP APIs
..


Patch Set 5: BAD-1

BAD Compatibility Tests Failed

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/549/ : FAILURE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1498
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib135ead7896a2b66735eb7325babe15b18a29bed
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Add integration tests for Hyracks' HTTP APIs

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Add integration tests for Hyracks' HTTP APIs
..


Patch Set 5:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/549/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1498
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib135ead7896a2b66735eb7325babe15b18a29bed
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Add integration tests for Hyracks' HTTP APIs

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Add integration tests for Hyracks' HTTP APIs
..


Patch Set 5:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1498
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib135ead7896a2b66735eb7325babe15b18a29bed
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Add integration tests for Hyracks' HTTP APIs

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Add integration tests for Hyracks' HTTP APIs
..


Patch Set 5:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/4298/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1498
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib135ead7896a2b66735eb7325babe15b18a29bed
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Add integration tests for Hyracks' HTTP APIs

[Till Westmann (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1498

to look at the new patch set (#5).

Change subject: Add integration tests for Hyracks' HTTP APIs
..

Add integration tests for Hyracks' HTTP APIs

Change-Id: Ib135ead7896a2b66735eb7325babe15b18a29bed
---
M 
asterixdb/asterix-common/src/test/java/org/apache/asterix/test/aql/ResultExtractor.java
M hyracks-fullstack/hyracks/hyracks-api/pom.xml
M hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/pom.xml
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/dataset/ResultStateSweeper.java
M hyracks-fullstack/hyracks/hyracks-examples/hyracks-integration-tests/pom.xml
A 
hyracks-fullstack/hyracks/hyracks-examples/hyracks-integration-tests/src/test/java/org/apache/hyracks/tests/integration/APIIntegrationTest.java
M 
hyracks-fullstack/hyracks/hyracks-examples/hyracks-integration-tests/src/test/java/org/apache/hyracks/tests/integration/AbstractIntegrationTest.java
A 
hyracks-fullstack/hyracks/hyracks-examples/hyracks-integration-tests/src/test/java/org/apache/hyracks/tests/integration/ApplicationDeploymentAPIIntegrationTest.java
A 
hyracks-fullstack/hyracks/hyracks-examples/hyracks-integration-tests/src/test/java/org/apache/hyracks/tests/integration/JobStatusAPIIntegrationTest.java
A 
hyracks-fullstack/hyracks/hyracks-examples/hyracks-integration-tests/src/test/java/org/apache/hyracks/tests/integration/WaitingOperatorDescriptor.java
M hyracks-fullstack/hyracks/hyracks-server/pom.xml
M hyracks-fullstack/pom.xml
12 files changed, 422 insertions(+), 26 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/98/1498/5
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1498
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib135ead7896a2b66735eb7325babe15b18a29bed
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 

Change in asterixdb[master]: Add integration tests for Hyracks' HTTP APIs

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Add integration tests for Hyracks' HTTP APIs
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/4297/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1498
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib135ead7896a2b66735eb7325babe15b18a29bed
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Add integration tests for Hyracks' HTTP APIs

[Till Westmann (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1498

to look at the new patch set (#4).

Change subject: Add integration tests for Hyracks' HTTP APIs
..

Add integration tests for Hyracks' HTTP APIs

Change-Id: Ib135ead7896a2b66735eb7325babe15b18a29bed
---
M 
asterixdb/asterix-common/src/test/java/org/apache/asterix/test/aql/ResultExtractor.java
M hyracks-fullstack/hyracks/hyracks-api/pom.xml
M hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/pom.xml
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/dataset/ResultStateSweeper.java
M hyracks-fullstack/hyracks/hyracks-examples/hyracks-integration-tests/pom.xml
A 
hyracks-fullstack/hyracks/hyracks-examples/hyracks-integration-tests/src/test/java/org/apache/hyracks/tests/integration/APIIntegrationTest.java
M 
hyracks-fullstack/hyracks/hyracks-examples/hyracks-integration-tests/src/test/java/org/apache/hyracks/tests/integration/AbstractIntegrationTest.java
A 
hyracks-fullstack/hyracks/hyracks-examples/hyracks-integration-tests/src/test/java/org/apache/hyracks/tests/integration/ApplicationDeploymentAPIIntegrationTest.java
A 
hyracks-fullstack/hyracks/hyracks-examples/hyracks-integration-tests/src/test/java/org/apache/hyracks/tests/integration/JobStatusAPIIntegrationTest.java
A 
hyracks-fullstack/hyracks/hyracks-examples/hyracks-integration-tests/src/test/java/org/apache/hyracks/tests/integration/WaitingOperatorDescriptor.java
M hyracks-fullstack/hyracks/hyracks-server/pom.xml
M hyracks-fullstack/pom.xml
12 files changed, 427 insertions(+), 26 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/98/1498/4
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1498
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib135ead7896a2b66735eb7325babe15b18a29bed
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 

Change in asterixdb[master]: Fix for integer numeric overflow in int* constructors

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Fix for integer numeric overflow in int* constructors
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/4296/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1509
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0cb3411bf9a808ee87f4938c60804a8d267c36d0
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ildar Absalyamov 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Fix for integer numeric overflow in int* constructors

[Ildar Absalyamov (Code Review)]

Ildar Absalyamov has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/1509

Change subject: Fix for integer numeric overflow in int* constructors
..

Fix for integer numeric overflow in int* constructors

Change-Id: I0cb3411bf9a808ee87f4938c60804a8d267c36d0
---
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/types/domain_boundaries/domain_boundaries.1.ddl.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/types/domain_boundaries/domain_boundaries.2.ddl.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/types/domain_boundaries/domain_boundaries.3.query.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/types/domain_boundaries_error/domain_boundaries_error.1.ddl.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/types/domain_boundaries_error/domain_boundaries_error.2.ddl.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/types/domain_boundaries_error/domain_boundaries_error.3.ddl.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/types/domain_boundaries_error/domain_boundaries_error.4.ddl.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/types/domain_boundaries_error/domain_boundaries_error.5.ddl.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/types/domain_boundaries/domain_boundaries.1.adm
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite.xml
M 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/constructors/AInt16ConstructorDescriptor.java
M 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/constructors/AInt32ConstructorDescriptor.java
M 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/constructors/AInt8ConstructorDescriptor.java
13 files changed, 338 insertions(+), 9 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/09/1509/1

diff --git 
a/asterixdb/asterix-app/src/test/resources/runtimets/queries/types/domain_boundaries/domain_boundaries.1.ddl.aql
 
b/asterixdb/asterix-app/src/test/resources/runtimets/queries/types/domain_boundaries/domain_boundaries.1.ddl.aql
new file mode 100644
index 000..0885da1
--- /dev/null
+++ 
b/asterixdb/asterix-app/src/test/resources/runtimets/queries/types/domain_boundaries/domain_boundaries.1.ddl.aql
@@ -0,0 +1,32 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+drop dataverse test if exists;
+create dataverse test;
+
+use dataverse test;
+
+create type Type as open {
+  id: int64,
+  int8: int8,
+  int16: int16,
+  int32: int32,
+  int64: int64
+}
+
+create dataset TestDS(Type) primary key id;
diff --git 
a/asterixdb/asterix-app/src/test/resources/runtimets/queries/types/domain_boundaries/domain_boundaries.2.ddl.aql
 
b/asterixdb/asterix-app/src/test/resources/runtimets/queries/types/domain_boundaries/domain_boundaries.2.ddl.aql
new file mode 100644
index 000..551f658
--- /dev/null
+++ 
b/asterixdb/asterix-app/src/test/resources/runtimets/queries/types/domain_boundaries/domain_boundaries.2.ddl.aql
@@ -0,0 +1,37 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+use dataverse test;
+
+insert into dataset TestDS(
+{
+   "id": 1,
+   "int8": int8("-128"),
+   "int16": int16("-32768"),
+   "int32": int32("-2147483648"),
+   "int64": int64("-9223372036854775808")
+})
+
+insert 

Change in asterixdb[master]: ASTERIXDB-1747 Implemented full lifecycle capabilities for p...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1747 Implemented full lifecycle capabilities for 
pre-distributed jobs
..


Patch Set 25: BAD-1

BAD Compatibility Tests Failed

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/548/ : FAILURE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1377
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I59c3422d5c1ab7756a6a4685ac527dfe50434954
Gerrit-PatchSet: 25
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Ildar Absalyamov 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Carey 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Fix asterix-docker

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Fix asterix-docker
..


Patch Set 1:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1897/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1506
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifac17caf603f1d4f1c53413996d833869d68a266
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Jianfeng Jia 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB-1747 Implemented full lifecycle capabilities for p...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1747 Implemented full lifecycle capabilities for 
pre-distributed jobs
..


Patch Set 25:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/548/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1377
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I59c3422d5c1ab7756a6a4685ac527dfe50434954
Gerrit-PatchSet: 25
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Ildar Absalyamov 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Carey 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB-1747 Implemented full lifecycle capabilities for p...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1747 Implemented full lifecycle capabilities for 
pre-distributed jobs
..


Patch Set 25:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1377
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I59c3422d5c1ab7756a6a4685ac527dfe50434954
Gerrit-PatchSet: 25
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Ildar Absalyamov 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Carey 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB-1747 Implemented full lifecycle capabilities for p...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1747 Implemented full lifecycle capabilities for 
pre-distributed jobs
..


Patch Set 25:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/4295/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1377
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I59c3422d5c1ab7756a6a4685ac527dfe50434954
Gerrit-PatchSet: 25
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Ildar Absalyamov 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Carey 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Fix asterix-docker

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Fix asterix-docker
..


Patch Set 1:

BAD Compatibility Tests Failed

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/547/ : FAILURE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1506
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifac17caf603f1d4f1c53413996d833869d68a266
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Jianfeng Jia 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB-1747 Implemented full lifecycle capabilities for p...

[Steven Jacobs (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1377

to look at the new patch set (#25).

Change subject: ASTERIXDB-1747 Implemented full lifecycle capabilities for 
pre-distributed jobs
..

ASTERIXDB-1747 Implemented full lifecycle capabilities for pre-distributed jobs

Added distribute and destroy functionality
Removed serialization and bytes when running pred-distributed jobs
Cleaned up methods
Enabled Mockito testing for CCS and NCS
Added Unit Test for Distributed Jobs

Change-Id: I59c3422d5c1ab7756a6a4685ac527dfe50434954
---
M 
asterixdb/asterix-active/src/main/java/org/apache/asterix/active/ActiveJobNotificationHandler.java
M 
asterixdb/asterix-active/src/main/java/org/apache/asterix/active/ActiveLifecycleListener.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java
M 
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/entities/Dataset.java
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/client/HyracksClientInterfaceFunctions.java
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/client/HyracksClientInterfaceRemoteProxy.java
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/client/HyracksConnection.java
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/client/IHyracksClientConnection.java
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/client/IHyracksClientInterface.java
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/ErrorCode.java
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/job/IJobLifecycleListener.java
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/job/JobFlag.java
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/resources/errormsg/en.properties
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/ClientInterfaceIPCI.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/ClusterControllerIPCI.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/ClusterControllerService.java
A 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/PreDistributedJobStore.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/application/CCApplicationContext.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/dataset/DatasetDirectoryService.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/executor/JobExecutor.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/job/JobManager.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/job/JobRun.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/scheduler/FIFOJobQueue.java
A 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/work/DestroyJobWork.java
A 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/work/DistributeJobWork.java
A 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/work/DistributedJobFailureWork.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/work/JobStartWork.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/test/java/org/apache/hyracks/control/cc/job/JobManagerTest.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/base/IClusterController.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/base/INodeController.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/ipc/CCNCFunctions.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/ipc/ClusterControllerRemoteProxy.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/ipc/NodeControllerRemoteProxy.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/NodeControllerIPCI.java
M 

Change in asterixdb[master]: ASTERIXDB-1747 Implemented full lifecycle capabilities for p...

[Steven Jacobs (Code Review)]

Steven Jacobs has posted comments on this change.

Change subject: ASTERIXDB-1747 Implemented full lifecycle capabilities for 
pre-distributed jobs
..


Patch Set 24:

(4 comments)

"I'm not sure how much those members will affect your testing.
Let's say, if those members still refer to the non-spied NC/CC instance, your 
call count verification will still work?  Did I miss anything?"

The issue is this: The calls that happen to getPreDistributedJobStore() end up 
coming from the IPC's. If these are assigned in the constructor, the "this" 
that's passed isn't a mocked class, so those calls don't register as happening 
in the mocked class which means the call counts stay at 0 (I learned from 
trying this first). The only way to get the calls to be acknowledged is to pass 
"this" when "this" refers to the mocked class (in the start() methods).

https://asterix-gerrit.ics.uci.edu/#/c/1377/24/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/DistributedJobStore.java
File 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/DistributedJobStore.java:

PS24, Line 32: DistributedJobStore
> The prefix "Distributed" is a bit confusing, as
I want to avoid active as this also has specific implications in Asterix. I 
changed to PreDistributed.


https://asterix-gerrit.ics.uci.edu/#/c/1377/24/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/executor/JobExecutor.java
File 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/executor/JobExecutor.java:

PS24, Line 487: byte[] acgBytes = null;
  : if (!predistributed) {
  : acgBytes = 
JavaSerializationUtils.serialize(acg);
  : }
> use a conditional expression?
Done


https://asterix-gerrit.ics.uci.edu/#/c/1377/24/hyracks-fullstack/hyracks/hyracks-examples/hyracks-integration-tests/src/test/java/org/apache/hyracks/tests/integration/DistributedJobsTest.java
File 
hyracks-fullstack/hyracks/hyracks-examples/hyracks-integration-tests/src/test/java/org/apache/hyracks/tests/integration/DistributedJobsTest.java:

PS24, Line 115: finished
> Can you comment in the code why it is times(4) for getDistributedJobStore?
Done


PS24, Line 118: storeActivityClusterGraph
> verify the call count of checkDuplicateXXX ?
Done


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1377
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I59c3422d5c1ab7756a6a4685ac527dfe50434954
Gerrit-PatchSet: 24
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Ildar Absalyamov 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Carey 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: Yes

Change in asterixdb[master]: Fix asterix-docker

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Fix asterix-docker
..


Patch Set 1:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/547/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1506
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifac17caf603f1d4f1c53413996d833869d68a266
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Jianfeng Jia 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Fix asterix-docker

[Ian Maxon (Code Review)]

Ian Maxon has submitted this change and it was merged.

Change subject: Fix asterix-docker
..


Fix asterix-docker

Change-Id: Ifac17caf603f1d4f1c53413996d833869d68a266
Reviewed-on: https://asterix-gerrit.ics.uci.edu/1506
Reviewed-by: Michael Blow 
Integration-Tests: Michael Blow 
Tested-by: Michael Blow 
---
M asterixdb/asterix-docker/docker/supervisord.conf
M asterixdb/asterix-docker/pom.xml
2 files changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Michael Blow: Looks good to me, approved; Verified; Verified



diff --git a/asterixdb/asterix-docker/docker/supervisord.conf 
b/asterixdb/asterix-docker/docker/supervisord.conf
index acce92e..9f70dd1 100644
--- a/asterixdb/asterix-docker/docker/supervisord.conf
+++ b/asterixdb/asterix-docker/docker/supervisord.conf
@@ -26,14 +26,14 @@
 stderr_logfile_maxbytes=0
 
 [program:asterixnc1]
-command=/asterixdb/bin/asterixnc -node-id nc1 -cc-host localhost -iodevices 
/asterixdb/nc1 -cluster-net-ip-address localhost -data-ip-address localhost 
-result-ip-address localhost -- -metadata-port 50031
+command=/asterixdb/bin/asterixnc -node-id nc1 -cc-host localhost -iodevices 
/asterixdb/nc1 -cluster-net-ip-address localhost -data-ip-address localhost 
-result-ip-address localhost --
 stdout_logfile=/dev/stdout
 stdout_logfile_maxbytes=0
 stderr_logfile=/dev/stderr
 stderr_logfile_maxbytes=0
 
 [program:asterixnc2]
-command=/asterixdb/bin/asterixnc -node-id nc2 -cc-host localhost -iodevices 
/asterixdb/nc2 -cluster-net-ip-address localhost -data-ip-address localhost 
-result-ip-address localhost -- -metadata-port 50031
+command=/asterixdb/bin/asterixnc -node-id nc2 -cc-host localhost -iodevices 
/asterixdb/nc2 -cluster-net-ip-address localhost -data-ip-address localhost 
-result-ip-address localhost --
 stdout_logfile=/dev/stdout
 stdout_logfile_maxbytes=0
 stderr_logfile=/dev/stderr
diff --git a/asterixdb/asterix-docker/pom.xml b/asterixdb/asterix-docker/pom.xml
index 6ea0564..c947711 100644
--- a/asterixdb/asterix-docker/pom.xml
+++ b/asterixdb/asterix-docker/pom.xml
@@ -22,7 +22,7 @@
   
 apache-asterixdb
 org.apache.asterix
-0.8.9-SNAPSHOT
+0.9.1-SNAPSHOT
   
   asterix-docker
   

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1506
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ifac17caf603f1d4f1c53413996d833869d68a266
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jianfeng Jia 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: abdullah alamoudi 

Change in asterixdb[master]: Fix asterix-docker

[Michael Blow (Code Review)]

Michael Blow has posted comments on this change.

Change subject: Fix asterix-docker
..


Patch Set 1: Code-Review+2 Integration-Tests+1 Verified+1

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1506
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifac17caf603f1d4f1c53413996d833869d68a266
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Jianfeng Jia 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB-1786: Remove Hyracks Servlets.

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1786: Remove Hyracks Servlets.
..


Patch Set 1: BAD-1

BAD Compatibility Tests Failed

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/546/ : FAILURE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1508
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifcd240591d12baab2db4ce3163c635a1dde5c4ba
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB-1786: Remove Hyracks Servlets.

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1786: Remove Hyracks Servlets.
..


Patch Set 1:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/546/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1508
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifcd240591d12baab2db4ce3163c635a1dde5c4ba
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: WIP - add result format metadata for result sets

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: WIP - add result format metadata for result sets
..


Patch Set 11: BAD-1

BAD Compatibility Tests Failed

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/545/ : FAILURE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1404
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc4eddd23f508962483f3470e88760bf8124dc25
Gerrit-PatchSet: 11
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: WIP - add result format metadata for result sets

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: WIP - add result format metadata for result sets
..


Patch Set 11:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/545/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1404
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc4eddd23f508962483f3470e88760bf8124dc25
Gerrit-PatchSet: 11
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB-1747 Implemented full lifecycle capabilities for p...

[Yingyi Bu (Code Review)]

Yingyi Bu has posted comments on this change.

Change subject: ASTERIXDB-1747 Implemented full lifecycle capabilities for 
pre-distributed jobs
..


Patch Set 24:

"In order to use the mockito library to monitor the method calls on this class, 
the creation of these had to be moved from the constructor to the start() 
method (since they pass "this"). This forces them to become non-final"


I'm not sure how much those members will affect your testing.
Let's say, if those members still refer to the non-spied NC/CC instance, your 
call count verification will still work?  Did I miss anything?

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1377
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I59c3422d5c1ab7756a6a4685ac527dfe50434954
Gerrit-PatchSet: 24
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Ildar Absalyamov 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Carey 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB-1747 Implemented full lifecycle capabilities for p...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1747 Implemented full lifecycle capabilities for 
pre-distributed jobs
..


Patch Set 24:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1896/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1377
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I59c3422d5c1ab7756a6a4685ac527dfe50434954
Gerrit-PatchSet: 24
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Ildar Absalyamov 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Carey 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Add cluster performance testing scripts.

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Add cluster performance testing scripts.
..


Patch Set 5: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1895/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1504
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie17f20dc87694a865aebc561d8eded064c66f5bb
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB-1747 Implemented full lifecycle capabilities for p...

[Yingyi Bu (Code Review)]

Yingyi Bu has posted comments on this change.

Change subject: ASTERIXDB-1747 Implemented full lifecycle capabilities for 
pre-distributed jobs
..


Patch Set 24:

(4 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1377/24/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/DistributedJobStore.java
File 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/DistributedJobStore.java:

PS24, Line 32: DistributedJobStore
The prefix "Distributed" is a bit confusing, as

1.  jobs in hyracks are executed "distributedly".  

2. it could be parsed by a human as distributed JobStore

Could you use another name, e.g., "PreDistributed", "Active", etc to avoid 
confusions for readers?


https://asterix-gerrit.ics.uci.edu/#/c/1377/24/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/executor/JobExecutor.java
File 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/executor/JobExecutor.java:

PS24, Line 487: byte[] acgBytes = null;
  : if (!predistributed) {
  : acgBytes = 
JavaSerializationUtils.serialize(acg);
  : }
use a conditional expression?

byte acgBytes = predistributed? null : JavaSerializationUtils.serialize(acg);


https://asterix-gerrit.ics.uci.edu/#/c/1377/24/hyracks-fullstack/hyracks/hyracks-examples/hyracks-integration-tests/src/test/java/org/apache/hyracks/tests/integration/DistributedJobsTest.java
File 
hyracks-fullstack/hyracks/hyracks-examples/hyracks-integration-tests/src/test/java/org/apache/hyracks/tests/integration/DistributedJobsTest.java:

PS24, Line 115: finished
Can you comment in the code why it is times(4) for getDistributedJobStore?
It's not very obvious to me.


PS24, Line 118: storeActivityClusterGraph
verify the call count of checkDuplicateXXX ?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1377
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I59c3422d5c1ab7756a6a4685ac527dfe50434954
Gerrit-PatchSet: 24
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Ildar Absalyamov 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Carey 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: Yes

Change in asterixdb[master]: ASTERIXDB-1786: Remove Hyracks Servlets.

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1786: Remove Hyracks Servlets.
..


Patch Set 1:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1508
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifcd240591d12baab2db4ce3163c635a1dde5c4ba
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB-1786: Remove Hyracks Servlets.

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1786: Remove Hyracks Servlets.
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/4294/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1508
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifcd240591d12baab2db4ce3163c635a1dde5c4ba
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: WIP - add result format metadata for result sets

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: WIP - add result format metadata for result sets
..


Patch Set 11:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1404
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc4eddd23f508962483f3470e88760bf8124dc25
Gerrit-PatchSet: 11
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB-1786: Remove Hyracks Servlets.

[Till Westmann (Code Review)]

Till Westmann has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/1508

Change subject: ASTERIXDB-1786: Remove Hyracks Servlets.
..

ASTERIXDB-1786: Remove Hyracks Servlets.

Change-Id: Ifcd240591d12baab2db4ce3163c635a1dde5c4ba
---
M asterixdb/asterix-app/pom.xml
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryWebInterfaceServlet.java
M asterixdb/asterix-common/pom.xml
M asterixdb/pom.xml
M hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/pom.xml
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/ClusterControllerService.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/web/JobsRESTAPIFunction.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/web/WebServer.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/web/util/JSONOutputRequestHandler.java
M hyracks-fullstack/hyracks/hyracks-http/pom.xml
M 
hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/AbstractServlet.java
A 
hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/StaticResourceServlet.java
M hyracks-fullstack/pom.xml
14 files changed, 205 insertions(+), 130 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/08/1508/1

diff --git a/asterixdb/asterix-app/pom.xml b/asterixdb/asterix-app/pom.xml
index 99e58df..7ce71b7 100644
--- a/asterixdb/asterix-app/pom.xml
+++ b/asterixdb/asterix-app/pom.xml
@@ -463,7 +463,6 @@
 
   io.netty
   netty-all
-  4.1.6.Final
 
   
 
\ No newline at end of file
diff --git 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ApiServlet.java
 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ApiServlet.java
index 95eb6fb..db824aa 100644
--- 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ApiServlet.java
+++ 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ApiServlet.java
@@ -82,7 +82,7 @@
 this.componentProvider = componentProvider;
 }
 
-public void doPost(IServletRequest request, IServletResponse response) {
+protected void doPost(IServletRequest request, IServletResponse response) {
 // Query language
 ILangCompilationProvider compilationProvider = 
"AQL".equals(request.getParameter("query-language"))
 ? aqlCompilationProvider : sqlppCompilationProvider;
@@ -156,7 +156,7 @@
 }
 }
 
-public void doGet(IServletRequest request, IServletResponse response) {
+protected void doGet(IServletRequest request, IServletResponse response) {
 String resourcePath = null;
 String requestURI = request.getHttpRequest().uri();
 
@@ -188,7 +188,7 @@
 outputStream.close();
 return;
 }
-String type = 
IServlet.ContentType.mime(QueryWebInterfaceServlet.extension(resourcePath));
+String type = IServlet.ContentType.mime(extension(resourcePath));
 ServletUtils.setContentType(response, "".equals(type) ? 
IServlet.ContentType.TEXT_PLAIN : type,
 IServlet.Encoding.UTF8);
 writeOutput(response, is, resourcePath);
@@ -199,6 +199,11 @@
 }
 }
 
+public static String extension(String path) {
+int i = path.lastIndexOf('.');
+return i < 1 ? "" : path.substring(i);
+}
+
 private void writeOutput(IServletResponse response, InputStream is, String 
resourcePath) throws IOException {
 try (InputStreamReader isr = new InputStreamReader(is); BufferedReader 
br = new BufferedReader(isr)) {
 StringBuilder sb = new StringBuilder();
diff --git 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryWebInterfaceServlet.java
 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryWebInterfaceServlet.java
index 96df30f..bc9b115 100644
--- 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryWebInterfaceServlet.java
+++ 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryWebInterfaceServlet.java
@@ -19,8 +19,6 @@
 package org.apache.asterix.api.http.server;
 
 import java.io.IOException;
-import java.io.InputStream;
-import java.io.OutputStream;
 import java.io.PrintWriter;
 import java.util.concurrent.ConcurrentMap;
 import java.util.logging.Level;
@@ -28,85 +26,35 @@
 
 import org.apache.asterix.common.config.ExternalProperties;
 import org.apache.asterix.runtime.utils.AppContextInfo;
-import org.apache.commons.io.IOUtils;
 import 

Change in asterixdb[master]: WIP - add result format metadata for result sets

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: WIP - add result format metadata for result sets
..


Patch Set 11:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/4293/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1404
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc4eddd23f508962483f3470e88760bf8124dc25
Gerrit-PatchSet: 11
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB-1747 Implemented full lifecycle capabilities for p...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1747 Implemented full lifecycle capabilities for 
pre-distributed jobs
..


Patch Set 24: BAD-1

BAD Compatibility Tests Failed

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/544/ : FAILURE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1377
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I59c3422d5c1ab7756a6a4685ac527dfe50434954
Gerrit-PatchSet: 24
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Ildar Absalyamov 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Carey 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB-1747 Implemented full lifecycle capabilities for p...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1747 Implemented full lifecycle capabilities for 
pre-distributed jobs
..


Patch Set 24:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/544/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1377
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I59c3422d5c1ab7756a6a4685ac527dfe50434954
Gerrit-PatchSet: 24
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Ildar Absalyamov 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Carey 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb-bad[master]: Added Procedures to BAD

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Added Procedures to BAD
..


Patch Set 7:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-gerrit/74/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1473
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I03550a74e2c90179e72345103b3d2c4f98148631
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb-bad
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB-1747 Implemented full lifecycle capabilities for p...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1747 Implemented full lifecycle capabilities for 
pre-distributed jobs
..


Patch Set 24:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1377
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I59c3422d5c1ab7756a6a4685ac527dfe50434954
Gerrit-PatchSet: 24
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Ildar Absalyamov 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Carey 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB-1747 Implemented full lifecycle capabilities for p...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1747 Implemented full lifecycle capabilities for 
pre-distributed jobs
..


Patch Set 24:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/4292/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1377
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I59c3422d5c1ab7756a6a4685ac527dfe50434954
Gerrit-PatchSet: 24
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Ildar Absalyamov 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Carey 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb-bad[master]: Added Procedures to BAD

[Steven Jacobs (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1473

to look at the new patch set (#7).

Change subject: Added Procedures to BAD
..

Added Procedures to BAD

Change-Id: I03550a74e2c90179e72345103b3d2c4f98148631
---
M .gitignore
M asterix-bad/pom.xml
M asterix-bad/src/main/java/org/apache/asterix/bad/ChannelJobService.java
R asterix-bad/src/main/java/org/apache/asterix/bad/DistributedJobInfo.java
M asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADLangExtension.java
M 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADQueryTranslatorFactory.java
M 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADStatementExecutor.java
M 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelDropStatement.java
M 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelUnsubscribeStatement.java
M 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/CreateChannelStatement.java
M 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/CreateProcedureStatement.java
A 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ExecuteProcedureStatement.java
A 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ProcedureDropStatement.java
M 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/BADMetadataExtension.java
M 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/BADMetadataRecordTypes.java
D 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/ChannelEventsListener.java
A 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/DataverseProceduresSearchKey.java
A 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/PrecompiledJobEventListener.java
M asterix-bad/src/main/java/org/apache/asterix/bad/metadata/Procedure.java
M 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/ProcedureTupleTranslator.java
D 
asterix-bad/src/main/java/org/apache/asterix/bad/runtime/RepetitiveChannelOperatorDescriptor.java
D 
asterix-bad/src/main/java/org/apache/asterix/bad/runtime/RepetitiveChannelOperatorNodePushable.java
M asterix-bad/src/main/resources/lang-extension/lang.txt
A 
asterix-bad/src/test/resources/runtimets/queries/procedure/delete_procedure/delete_procedure.1.ddl.aql
A 
asterix-bad/src/test/resources/runtimets/queries/procedure/delete_procedure/delete_procedure.2.query.aql
A 
asterix-bad/src/test/resources/runtimets/queries/procedure/delete_procedure/delete_procedure.3.update.aql
A 
asterix-bad/src/test/resources/runtimets/queries/procedure/delete_procedure/delete_procedure.4.query.aql
A 
asterix-bad/src/test/resources/runtimets/queries/procedure/insert_procedure/insert_procedure.1.ddl.aql
A 
asterix-bad/src/test/resources/runtimets/queries/procedure/insert_procedure/insert_procedure.2.update.aql
A 
asterix-bad/src/test/resources/runtimets/queries/procedure/insert_procedure/insert_procedure.3.update.aql
A 
asterix-bad/src/test/resources/runtimets/queries/procedure/insert_procedure/insert_procedure.4.update.aql
A 
asterix-bad/src/test/resources/runtimets/queries/procedure/insert_procedure/insert_procedure.5.ddl.aql
A 
asterix-bad/src/test/resources/runtimets/queries/procedure/insert_procedure/insert_procedure.6.query.aql
A 
asterix-bad/src/test/resources/runtimets/queries/procedure/query_procedure/query_procedure.1.ddl.aql
A 
asterix-bad/src/test/resources/runtimets/queries/procedure/query_procedure/query_procedure.2.update.aql
A 
asterix-bad/src/test/resources/runtimets/queries/procedure/query_procedure/query_procedure.3.update.aql
A 
asterix-bad/src/test/resources/runtimets/queries/procedure/query_procedure/query_procedure.4.update.aql
A 
asterix-bad/src/test/resources/runtimets/queries/procedure/query_procedure/query_procedure.5.update.aql
A 
asterix-bad/src/test/resources/runtimets/queries/procedure/repetitive_insert_procedure/repetitive_insert_procedure.1.ddl.aql
A 
asterix-bad/src/test/resources/runtimets/queries/procedure/repetitive_insert_procedure/repetitive_insert_procedure.2.update.aql
A 
asterix-bad/src/test/resources/runtimets/queries/procedure/repetitive_insert_procedure/repetitive_insert_procedure.3.sleep.aql
A 
asterix-bad/src/test/resources/runtimets/queries/procedure/repetitive_insert_procedure/repetitive_insert_procedure.4.ddl.aql
A 
asterix-bad/src/test/resources/runtimets/queries/procedure/repetitive_insert_procedure/repetitive_insert_procedure.5.query.aql
A 
asterix-bad/src/test/resources/runtimets/results/procedure/delete_procedure/delete_procedure.2.adm
A 
asterix-bad/src/test/resources/runtimets/results/procedure/delete_procedure/delete_procedure.4.adm
A 
asterix-bad/src/test/resources/runtimets/results/procedure/insert_procedure/insert_procedure.6.adm
A 
asterix-bad/src/test/resources/runtimets/results/procedure/query_procedure/query_procedure.3.adm
A 
asterix-bad/src/test/resources/runtimets/results/procedure/query_procedure/query_procedure.5.adm
A 

Change in asterixdb[master]: Add cluster performance testing scripts.

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Add cluster performance testing scripts.
..


Patch Set 5:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1895/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1504
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie17f20dc87694a865aebc561d8eded064c66f5bb
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Fix the names of Let to Servlet

[abdullah alamoudi (Code Review)]

abdullah alamoudi has posted comments on this change.

Change subject: Fix the names of Let to Servlet
..


Patch Set 6:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/1486/6/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/Servlets.java
File 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/Servlets.java:

PS6, Line 23: public static final String AQL = "/aql";
> also string switches I think are less efficient...
You're right but we only do this once during bootstrap


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1486
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2f63f37ee9ef063930478028e3e05ca9dd4742c
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: Yes

Change in asterixdb[master]: Fix the names of Let to Servlet

[Michael Blow (Code Review)]

Michael Blow has posted comments on this change.

Change subject: Fix the names of Let to Servlet
..


Patch Set 6:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/1486/6/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/Servlets.java
File 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/Servlets.java:

PS6, Line 23: public static final String AQL = "/aql";
> because those enums were actually just a wrapper around a string
Is there a compelling reason to revert that?  Enums make switch generation much 
easier.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1486
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2f63f37ee9ef063930478028e3e05ca9dd4742c
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: Yes

Change in incubator-asterixdb-site[asf-site]: Add download links for the server packages.

[Ian Maxon (Code Review)]

Ian Maxon has posted comments on this change.

Change subject: Add download links for the server packages.
..


Patch Set 1:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/1502/1/content/download.html
File content/download.html:

PS1, Line 141: single
> I guess "most suitable for running a sample cluster on a single machine" wi
Well that would still be the case I suppose. It'd just be suitable for other 
things too.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1502
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib852cde3e959f61fc2c95650535333c0b137c843
Gerrit-PatchSet: 1
Gerrit-Project: incubator-asterixdb-site
Gerrit-Branch: asf-site
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Michael Carey 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: Yes

Change in asterixdb[master]: Index-only plan step 3: Top-down Select and Join transformat...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Index-only plan step 3: Top-down Select and Join transformation 
rule
..


Patch Set 46:

Integration Tests Timed Out

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1894/ 
: ABORTED

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1350
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I60a2a61eb46851d4c16c8f17447e3ac9b0aca779
Gerrit-PatchSet: 46
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 2: AQL+ grammar generation and AQLPlusEx...

[Taewoo Kim (Code Review)]

Taewoo Kim has posted comments on this change.

Change subject: AQLPlus Refactoring 2: AQL+ grammar generation and 
AQLPlusExpressionToPlanTranslator
..


Patch Set 17:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/1434/17/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java
File 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java:

PS17, Line 187: .
> Why do you need this new constructor?
In FuzzyJoinRule file, it has its counter and increases it after creating this 
PlanTranslator. So, the PlanTranslator should be able to see the new counter 
value. So, either we need to create setVarCounter() or declare a new 
constructor. I think this new constructor might be better.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1434
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I444dbf4f615c23ccd69a5e4bb1ead300d0a81451
Gerrit-PatchSet: 17
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Carey 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: Yes

Change in incubator-asterixdb-site[asf-site]: Add download links for the server packages.

[Yingyi Bu (Code Review)]

Yingyi Bu has posted comments on this change.

Change subject: Add download links for the server packages.
..


Patch Set 1:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/1502/1/content/download.html
File content/download.html:

PS1, Line 141: single
I guess "most suitable for running a sample cluster on a single machine" will 
be changed sooner or later, it contains opt/aws and will contain opt/ansible?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1502
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib852cde3e959f61fc2c95650535333c0b137c843
Gerrit-PatchSet: 1
Gerrit-Project: incubator-asterixdb-site
Gerrit-Branch: asf-site
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Michael Carey 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: Yes

Change in asterixdb[master]: Add cluster performance testing scripts.

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Add cluster performance testing scripts.
..


Patch Set 5: BAD-1

BAD Compatibility Tests Failed

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/543/ : FAILURE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1504
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie17f20dc87694a865aebc561d8eded064c66f5bb
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Add cluster performance testing scripts.

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Add cluster performance testing scripts.
..


Patch Set 5:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/543/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1504
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie17f20dc87694a865aebc561d8eded064c66f5bb
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Add cluster performance testing scripts.

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Add cluster performance testing scripts.
..


Patch Set 5:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/4291/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1504
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie17f20dc87694a865aebc561d8eded064c66f5bb
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 2: AQL+ grammar generation and AQLPlusEx...

[Yingyi Bu (Code Review)]

Yingyi Bu has posted comments on this change.

Change subject: AQLPlus Refactoring 2: AQL+ grammar generation and 
AQLPlusExpressionToPlanTranslator
..


Patch Set 17:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/1434/17/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java
File 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java:

PS17, Line 187: .
Why do you need this new constructor?

The existing constructor + getVarCounter() cannot serve your need?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1434
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I444dbf4f615c23ccd69a5e4bb1ead300d0a81451
Gerrit-PatchSet: 17
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Carey 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: Yes

Change in asterixdb[master]: Add cluster performance testing scripts.

[Yingyi Bu (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1504

to look at the new patch set (#5).

Change subject: Add cluster performance testing scripts.
..

Add cluster performance testing scripts.

- Wait SSH instead of sleep in the AWS installation script;
- Remove Java code and generate config files in Ansible;
- TPC-H is one benchmark, and more benchmarks could be added into the framework.

Change-Id: Ie17f20dc87694a865aebc561d8eded064c66f5bb
---
A asterixdb/asterix-benchmark/pom.xml
A asterixdb/asterix-benchmark/src/main/assembly/binary-assembly.xml
A asterixdb/asterix-benchmark/src/main/resources/ansible/runquery.yml
A asterixdb/asterix-benchmark/src/main/resources/benchmarks/tpch/gen/compile.yml
A asterixdb/asterix-benchmark/src/main/resources/benchmarks/tpch/gen/gen.yml
A asterixdb/asterix-benchmark/src/main/resources/benchmarks/tpch/gen/gendata.yml
A 
asterixdb/asterix-benchmark/src/main/resources/benchmarks/tpch/gen/genscript.yml
A 
asterixdb/asterix-benchmark/src/main/resources/benchmarks/tpch/gen/settings.yml
A 
asterixdb/asterix-benchmark/src/main/resources/benchmarks/tpch/load/gendml_centralized.yml
A 
asterixdb/asterix-benchmark/src/main/resources/benchmarks/tpch/load/gendml_partitioned.yml
A asterixdb/asterix-benchmark/src/main/resources/benchmarks/tpch/load/load.yml
A 
asterixdb/asterix-benchmark/src/main/resources/benchmarks/tpch/load/loadgen.yml
A 
asterixdb/asterix-benchmark/src/main/resources/benchmarks/tpch/load/settings.yml
A 
asterixdb/asterix-benchmark/src/main/resources/benchmarks/tpch/load/template.sqlpp
A 
asterixdb/asterix-benchmark/src/main/resources/benchmarks/tpch/queries/q1.sqlpp
A 
asterixdb/asterix-benchmark/src/main/resources/benchmarks/tpch/queries/q10.sqlpp
A 
asterixdb/asterix-benchmark/src/main/resources/benchmarks/tpch/queries/q11.sqlpp
A 
asterixdb/asterix-benchmark/src/main/resources/benchmarks/tpch/queries/q12.sqlpp
A 
asterixdb/asterix-benchmark/src/main/resources/benchmarks/tpch/queries/q13.sqlpp
C 
asterixdb/asterix-benchmark/src/main/resources/benchmarks/tpch/queries/q14.sqlpp
A 
asterixdb/asterix-benchmark/src/main/resources/benchmarks/tpch/queries/q15.sqlpp
A 
asterixdb/asterix-benchmark/src/main/resources/benchmarks/tpch/queries/q16.sqlpp
C 
asterixdb/asterix-benchmark/src/main/resources/benchmarks/tpch/queries/q17.sqlpp
A 
asterixdb/asterix-benchmark/src/main/resources/benchmarks/tpch/queries/q18.sqlpp.dis
A 
asterixdb/asterix-benchmark/src/main/resources/benchmarks/tpch/queries/q19.sqlpp
A 
asterixdb/asterix-benchmark/src/main/resources/benchmarks/tpch/queries/q2.sqlpp.dis
A 
asterixdb/asterix-benchmark/src/main/resources/benchmarks/tpch/queries/q20.sqlpp.dis
A 
asterixdb/asterix-benchmark/src/main/resources/benchmarks/tpch/queries/q21.sqlpp.dis
A 
asterixdb/asterix-benchmark/src/main/resources/benchmarks/tpch/queries/q22.sqlpp.dis
C 
asterixdb/asterix-benchmark/src/main/resources/benchmarks/tpch/queries/q3.sqlpp
C 
asterixdb/asterix-benchmark/src/main/resources/benchmarks/tpch/queries/q4.sqlpp
A 
asterixdb/asterix-benchmark/src/main/resources/benchmarks/tpch/queries/q5.sqlpp.dis
R 
asterixdb/asterix-benchmark/src/main/resources/benchmarks/tpch/queries/q6.sqlpp
A 
asterixdb/asterix-benchmark/src/main/resources/benchmarks/tpch/queries/q7.sqlpp.dis
A 
asterixdb/asterix-benchmark/src/main/resources/benchmarks/tpch/queries/q8.sqlpp.dis
A 
asterixdb/asterix-benchmark/src/main/resources/benchmarks/tpch/queries/q9.sqlpp.dis
A 
asterixdb/asterix-benchmark/src/main/resources/benchmarks/tpch/setup/create.sqlpp
A asterixdb/asterix-benchmark/src/main/resources/benchmarks/tpch/setup/setup.yml
A 
asterixdb/asterix-benchmark/src/main/resources/benchmarks/tpch/teardown/drop.sqlpp
A 
asterixdb/asterix-benchmark/src/main/resources/benchmarks/tpch/teardown/teardown.yml
A asterixdb/asterix-benchmark/src/main/resources/bin/runall.sh
A asterixdb/asterix-benchmark/src/main/resources/conf/benchmark_setting.yml
D 
asterixdb/asterix-benchmarks/src/main/resources/tpc-h/queries/q01_pricing_summary_report_nt.3.query.aql
D 
asterixdb/asterix-benchmarks/src/main/resources/tpc-h/queries/q02_minimum_cost_supplier.3.query.aql
D 
asterixdb/asterix-benchmarks/src/main/resources/tpc-h/queries/q03_shipping_priority_nt.3.query.aql
D 
asterixdb/asterix-benchmarks/src/main/resources/tpc-h/queries/q04_order_priority.3.query.aql
D 
asterixdb/asterix-benchmarks/src/main/resources/tpc-h/queries/q05_local_supplier_volume.3.query.aql
D 
asterixdb/asterix-benchmarks/src/main/resources/tpc-h/queries/q07_volume_shipping.3.query.aql
D 
asterixdb/asterix-benchmarks/src/main/resources/tpc-h/queries/q08_national_market_share.3.query.aql
D 
asterixdb/asterix-benchmarks/src/main/resources/tpc-h/queries/q09_product_type_profit_nt.3.query.aql
D 
asterixdb/asterix-benchmarks/src/main/resources/tpc-h/queries/q10_returned_item.3.query.aql
D 

Change in asterixdb[master]: Add cluster performance testing scripts.

[Yingyi Bu (Code Review)]

Yingyi Bu has posted comments on this change.

Change subject: Add cluster performance testing scripts.
..


Patch Set 4:

(4 comments)

1) Reference results were removed from the benchmarks package. Do we still have 
(and use) TPC-H reference results for regression testing?

They were not used and in this change we do not check result correctness.

2) The TPC-H benchmark parameterizes some queries based on the scale factor. 
Should we file an issue to support this as well (doesn't seem to be very 
urgent)?

Filed AsterixDB-1793.

https://asterix-gerrit.ics.uci.edu/#/c/1504/4/asterixdb/asterix-benchmark/src/main/resources/ansible/runquery.yml
File asterixdb/asterix-benchmark/src/main/resources/ansible/runquery.yml:

PS4, Line 61: report
> Can we remove those empty lines at the end?
Done


https://asterix-gerrit.ics.uci.edu/#/c/1504/4/asterixdb/asterix-benchmark/src/main/resources/benchmarks/tpch/queries/q18.sqlpp.dis
File 
asterixdb/asterix-benchmark/src/main/resources/benchmarks/tpch/queries/q18.sqlpp.dis:

PS4, Line 20: Error
> Do we use this information or can we remove it from the file?
Queries with "Error" annotations are disabled.

Later, we will know which queries to re-enable when we fix bugs.


https://asterix-gerrit.ics.uci.edu/#/c/1504/4/asterixdb/asterix-benchmark/src/main/resources/bin/runall.sh
File asterixdb/asterix-benchmark/src/main/resources/bin/runall.sh:

PS4, Line 33: INVENTORY
> Should we validate the inventory before we start running? Or will the ansib
Done


https://asterix-gerrit.ics.uci.edu/#/c/1504/4/asterixdb/asterix-benchmark/src/main/resources/conf/benchmark_setting.yml
File asterixdb/asterix-benchmark/src/main/resources/conf/benchmark_setting.yml:

PS4, Line 33: unhygienix
> This might need to change when Ian get's a new CNAME for the machine, right
Done


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1504
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie17f20dc87694a865aebc561d8eded064c66f5bb
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: Yes

[jira] [Created] (ASTERIXDB-1793) Support parameterization for different scale factor in asterix-benchmark

[Yingyi Bu (JIRA)]

Yingyi Bu created ASTERIXDB-1793:


 Summary: Support parameterization for different scale factor in 
asterix-benchmark
 Key: ASTERIXDB-1793
 URL: https://issues.apache.org/jira/browse/ASTERIXDB-1793
 Project: Apache AsterixDB
  Issue Type: Improvement
  Components: AsterixDB
Reporter: Yingyi Bu
Assignee: Yingyi Bu


Support parameterization for TPC-H queries for various scale factors.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Change in asterixdb[master]: More flexibility for the LangExecutionUtil

[Till Westmann (Code Review)]

Till Westmann has submitted this change and it was merged.

Change subject: More flexibility for the LangExecutionUtil
..


More flexibility for the LangExecutionUtil

Change-Id: Id2632dce25519995798016b5be1ca650f8af9586
Reviewed-on: https://asterix-gerrit.ics.uci.edu/1507
Sonar-Qube: Jenkins 
Tested-by: Jenkins 
Integration-Tests: Jenkins 
Reviewed-by: Yingyi Bu 
---
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/LangExecutionUtil.java
1 file changed, 7 insertions(+), 1 deletion(-)

Approvals:
  Yingyi Bu: Looks good to me, approved
  Jenkins: Verified; No violations found; Verified

Objections:
  Jenkins: Violations found



diff --git 
a/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/LangExecutionUtil.java
 
b/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/LangExecutionUtil.java
index ea7e4d6..a20ecc5 100644
--- 
a/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/LangExecutionUtil.java
+++ 
b/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/LangExecutionUtil.java
@@ -92,13 +92,19 @@
 }
 
 public static void test(TestCaseContext tcCtx) throws Exception {
+test(testExecutor, tcCtx);
+}
+
+public static void test(TestExecutor testExecutor, TestCaseContext tcCtx) 
throws Exception {
 int repeat = LangExecutionUtil.repeat * tcCtx.getRepeat();
 try {
 for (int i = 1; i <= repeat; i++) {
 if (repeat > 1) {
 System.err.print("[" + i + "/" + repeat + "] ");
 }
-librarian.cleanup();
+if (librarian != null) {
+librarian.cleanup();
+}
 testExecutor.executeTest(PATH_ACTUAL, tcCtx, null, false, 
ExecutionTestUtil.FailedGroup);
 try {
 testExecutor.cleanup(tcCtx.toString(), badTestCases);

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1507
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id2632dce25519995798016b5be1ca650f8af9586
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 

Change in asterixdb[master]: More flexibility for the LangExecutionUtil

[Yingyi Bu (Code Review)]

Yingyi Bu has posted comments on this change.

Change subject: More flexibility for the LangExecutionUtil
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1507
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id2632dce25519995798016b5be1ca650f8af9586
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Add cluster performance testing scripts.

[Till Westmann (Code Review)]

Till Westmann has posted comments on this change.

Change subject: Add cluster performance testing scripts.
..


Patch Set 4:

(12 comments)

Looks generally good, I just have a few questions (and I basically don't 
understand the ansible scripts ..):

1) Reference results were removed from the benchmarks package. Do we still have 
(and use) TPC-H reference results for regression testing?

2) The TPC-H benchmark parameterizes some queries based on the scale factor. 
Should we file an issue to support this as well (doesn't seem to be very 
urgent)?

https://asterix-gerrit.ics.uci.edu/#/c/1504/4/asterixdb/asterix-benchmark/src/main/resources/ansible/runquery.yml
File asterixdb/asterix-benchmark/src/main/resources/ansible/runquery.yml:

PS4, Line 61: report
Can we remove those empty lines at the end?


https://asterix-gerrit.ics.uci.edu/#/c/1504/4/asterixdb/asterix-benchmark/src/main/resources/benchmarks/tpch/queries/q18.sqlpp.dis
File 
asterixdb/asterix-benchmark/src/main/resources/benchmarks/tpch/queries/q18.sqlpp.dis:

PS4, Line 20: Error
Do we use this information or can we remove it from the file?


https://asterix-gerrit.ics.uci.edu/#/c/1504/4/asterixdb/asterix-benchmark/src/main/resources/benchmarks/tpch/queries/q2.sqlpp.dis
File 
asterixdb/asterix-benchmark/src/main/resources/benchmarks/tpch/queries/q2.sqlpp.dis:

PS4, Line 20: Error
Do we use this information or can we remove it from the file?


https://asterix-gerrit.ics.uci.edu/#/c/1504/4/asterixdb/asterix-benchmark/src/main/resources/benchmarks/tpch/queries/q20.sqlpp.dis
File 
asterixdb/asterix-benchmark/src/main/resources/benchmarks/tpch/queries/q20.sqlpp.dis:

PS4, Line 20: Error
Do we use this information or can we remove it from the file?


https://asterix-gerrit.ics.uci.edu/#/c/1504/4/asterixdb/asterix-benchmark/src/main/resources/benchmarks/tpch/queries/q21.sqlpp.dis
File 
asterixdb/asterix-benchmark/src/main/resources/benchmarks/tpch/queries/q21.sqlpp.dis:

PS4, Line 20: Error
Do we use this information or can we remove it from the file?


https://asterix-gerrit.ics.uci.edu/#/c/1504/4/asterixdb/asterix-benchmark/src/main/resources/benchmarks/tpch/queries/q22.sqlpp.dis
File 
asterixdb/asterix-benchmark/src/main/resources/benchmarks/tpch/queries/q22.sqlpp.dis:

PS4, Line 20: Error
Do we use this information or can we remove it from the file?


https://asterix-gerrit.ics.uci.edu/#/c/1504/4/asterixdb/asterix-benchmark/src/main/resources/benchmarks/tpch/queries/q5.sqlpp.dis
File 
asterixdb/asterix-benchmark/src/main/resources/benchmarks/tpch/queries/q5.sqlpp.dis:

PS4, Line 20: Error
Do we use this information or can we remove it from the file?


https://asterix-gerrit.ics.uci.edu/#/c/1504/4/asterixdb/asterix-benchmark/src/main/resources/benchmarks/tpch/queries/q7.sqlpp.dis
File 
asterixdb/asterix-benchmark/src/main/resources/benchmarks/tpch/queries/q7.sqlpp.dis:

PS4, Line 20: Error
Do we use this information or can we remove it from the file?


https://asterix-gerrit.ics.uci.edu/#/c/1504/4/asterixdb/asterix-benchmark/src/main/resources/benchmarks/tpch/queries/q8.sqlpp.dis
File 
asterixdb/asterix-benchmark/src/main/resources/benchmarks/tpch/queries/q8.sqlpp.dis:

PS4, Line 20: Error
Do we use this information or can we remove it from the file?


https://asterix-gerrit.ics.uci.edu/#/c/1504/4/asterixdb/asterix-benchmark/src/main/resources/benchmarks/tpch/queries/q9.sqlpp.dis
File 
asterixdb/asterix-benchmark/src/main/resources/benchmarks/tpch/queries/q9.sqlpp.dis:

PS4, Line 20: Error
Do we use this information or can we remove it from the file?


https://asterix-gerrit.ics.uci.edu/#/c/1504/4/asterixdb/asterix-benchmark/src/main/resources/bin/runall.sh
File asterixdb/asterix-benchmark/src/main/resources/bin/runall.sh:

PS4, Line 33: INVENTORY
Should we validate the inventory before we start running? Or will the ansible 
playbooks be NOOPs if the inventory is not set?


https://asterix-gerrit.ics.uci.edu/#/c/1504/4/asterixdb/asterix-benchmark/src/main/resources/conf/benchmark_setting.yml
File asterixdb/asterix-benchmark/src/main/resources/conf/benchmark_setting.yml:

PS4, Line 33: unhygienix
This might need to change when Ian get's a new CNAME for the machine, right?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1504
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie17f20dc87694a865aebc561d8eded064c66f5bb
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: Yes

Change in asterixdb[master]: Index-only plan step 3: Top-down Select and Join transformat...

[Yingyi Bu (Code Review)]

Yingyi Bu has posted comments on this change.

Change subject: Index-only plan step 3: Top-down Select and Join transformation 
rule
..


Patch Set 46:

(6 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1350/45/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AbstractIntroduceAccessMethodRule.java
File 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AbstractIntroduceAccessMethodRule.java:

PS45, Line 389: 
Can we separate the function into two:

boolean analyzeSelectOrJoinOp(...)

void updateAM(...)

In this way, we know the first function does not create side effects and the 
second function is supposed to only update sth.


https://asterix-gerrit.ics.uci.edu/#/c/1350/46/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AccessMethodAnalysisContext.java
File 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AccessMethodAnalysisContext.java:

PS46, Line 85: >
Wrap a get and a put method and encapsulate the map so that we can easily track 
how a map gets inserted and read.


PS46, Line 89: setIndexDatasetMap
This method is not called.


https://asterix-gerrit.ics.uci.edu/#/c/1350/46/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/IntroduceJoinAccessMethodRule.java
File 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/IntroduceJoinAccessMethodRule.java:

PS46, Line 87: isLeftOuterJoin
Now since you're doing top-down traversal, do you still need those states?


PS46, Line 104: Override
should you implement rewritePre(...) if you're doing top-down traversal?


https://asterix-gerrit.ics.uci.edu/#/c/1350/46/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/IntroduceSelectAccessMethodRule.java
File 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/IntroduceSelectAccessMethodRule.java:

PS46, Line 105: public boolean rewritePost(Mutable opRef, 
IOptimizationContext context)
Should you use rewritePre(...) if you're doing top-down traversal?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1350
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I60a2a61eb46851d4c16c8f17447e3ac9b0aca779
Gerrit-PatchSet: 46
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: Yes

Change in asterixdb[master]: Fix the names of Let to Servlet

[abdullah alamoudi (Code Review)]

abdullah alamoudi has posted comments on this change.

Change subject: Fix the names of Let to Servlet
..


Patch Set 6:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/1486/6/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/Servlets.java
File 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/Servlets.java:

PS6, Line 23: public static final String AQL = "/aql";
> Why the change from Enum to Strings?
because those enums were actually just a wrapper around a string


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1486
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2f63f37ee9ef063930478028e3e05ca9dd4742c
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: Yes

Change in asterixdb[master]: Index-only plan step 3: Top-down Select and Join transformat...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Index-only plan step 3: Top-down Select and Join transformation 
rule
..


Patch Set 46:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1894/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1350
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I60a2a61eb46851d4c16c8f17447e3ac9b0aca779
Gerrit-PatchSet: 46
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Fix the names of Let to Servlet

[Michael Blow (Code Review)]

Michael Blow has posted comments on this change.

Change subject: Fix the names of Let to Servlet
..


Patch Set 6:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/1486/6/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/Servlets.java
File 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/Servlets.java:

PS6, Line 23: public static final String AQL = "/aql";
Why the change from Enum to Strings?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1486
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2f63f37ee9ef063930478028e3e05ca9dd4742c
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: Yes

Change in asterixdb[master]: Index-only plan step 3: Top-down Select and Join transformat...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Index-only plan step 3: Top-down Select and Join transformation 
rule
..


Patch Set 46: Integration-Tests-1

Integration Tests Failed

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1893/ 
: UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1350
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I60a2a61eb46851d4c16c8f17447e3ac9b0aca779
Gerrit-PatchSet: 46
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Index-only plan step 3: Top-down Select and Join transformat...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Index-only plan step 3: Top-down Select and Join transformation 
rule
..


Patch Set 46:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1893/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1350
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I60a2a61eb46851d4c16c8f17447e3ac9b0aca779
Gerrit-PatchSet: 46
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Add cluster performance testing scripts.

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Add cluster performance testing scripts.
..


Patch Set 4: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1892/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1504
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie17f20dc87694a865aebc561d8eded064c66f5bb
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Add cluster performance testing scripts.

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Add cluster performance testing scripts.
..


Patch Set 4:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1892/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1504
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie17f20dc87694a865aebc561d8eded064c66f5bb
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: More flexibility for the LangExecutionUtil

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: More flexibility for the LangExecutionUtil
..


Patch Set 1: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1891/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1507
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id2632dce25519995798016b5be1ca650f8af9586
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: More flexibility for the LangExecutionUtil

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: More flexibility for the LangExecutionUtil
..


Patch Set 1:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1891/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1507
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id2632dce25519995798016b5be1ca650f8af9586
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB-1791: Add a sanity check to hashjoin partition rea...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1791: Add a sanity check to hashjoin partition reading
..


Patch Set 2:

Integration Tests Timed Out

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1890/ 
: ABORTED

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1505
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I034691f05e05207b478929d76b02013578eed5ed
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No