Re: [PR] Upgrade Antlr3 and 4. New toml parsing library. [netbeans]

vieiro merged PR #7180: URL: https://github.com/apache/netbeans/pull/7180 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Upgrade Antlr3 and 4. New toml parsing library. [netbeans]

vieiro commented on PR #7180: URL: https://github.com/apache/netbeans/pull/7180#issuecomment-2027971594 > Well I'd keep the `JsonBaseListener` and `JsonBaseVisitor` interfaces, mark them `@Deprecated`, maybe even for removal. Though right now they are just a compatibility layer of the

Re: [PR] Upgrade Antlr3 and 4. New toml parsing library. [netbeans]

lkishalmi commented on PR #7180: URL: https://github.com/apache/netbeans/pull/7180#issuecomment-2027642345 Well I'd keep the `JsonBaseListener` and `JsonBaseVisitor` interfaces, mark them `@Deprecated`, maybe even for removal. Though right now they are just a compatibility layer of the

Re: [PR] Upgrade Antlr3 and 4. New toml parsing library. [netbeans]

vieiro commented on PR #7180: URL: https://github.com/apache/netbeans/pull/7180#issuecomment-2021429066 > Well I was thinking of removing the generated code from the code base. And have the sources generated build time. > > This is fine, just have to be repeated each ANTLR tool

Re: [PR] Upgrade Antlr3 and 4. New toml parsing library. [netbeans]

vieiro commented on PR #7180: URL: https://github.com/apache/netbeans/pull/7180#issuecomment-2020845770 > I think it's good to go. > > The build for `webcommon/javascript2.json` still have to be altered to generate the sources on the fly though. > > I'm traveling today. So a

Re: [PR] Upgrade Antlr3 and 4. New toml parsing library. [netbeans]

vieiro commented on PR #7180: URL: https://github.com/apache/netbeans/pull/7180#issuecomment-2020779962 Rebasing on top of #7189 and #7186 for a final test. If tests pass and nobody opposes this will be merged within in a couple days. -- This is an automated message from the Apache Git

Re: [PR] Upgrade Antlr3 and 4. New toml parsing library. [netbeans]

mbien commented on code in PR #7180: URL: https://github.com/apache/netbeans/pull/7180#discussion_r1538119906 ## ide/libs.tomljava/manifest.mf: ## @@ -0,0 +1,4 @@ +Manifest-Version: 1.0 +OpenIDE-Module: org.netbeans.libs.tomljava/3 +OpenIDE-Module-Localizing-Bundle:

Re: [PR] Upgrade Antlr3 and 4. New toml parsing library. [netbeans]

mbien commented on code in PR #7180: URL: https://github.com/apache/netbeans/pull/7180#discussion_r1537402262 ## ide/libs.tomljava/external/toml-java-13.3.1-license.txt: ## @@ -0,0 +1,208 @@ +Name: TOML parser in Java +Version: 13.3.1 +Description: A parser for Tom's Obvious,

Re: [PR] Upgrade Antlr3 and 4. New toml parsing library. [netbeans]

vieiro commented on code in PR #7180: URL: https://github.com/apache/netbeans/pull/7180#discussion_r1537956750 ## ide/libs.tomljava/external/toml-java-13.3.1-license.txt: ## @@ -0,0 +1,208 @@ +Name: TOML parser in Java +Version: 13.3.1 +Description: A parser for Tom's Obvious,

Re: [PR] Upgrade Antlr3 and 4. New toml parsing library. [netbeans]

vieiro commented on code in PR #7180: URL: https://github.com/apache/netbeans/pull/7180#discussion_r1537956338 ## ide/libs.tomljava/manifest.mf: ## @@ -0,0 +1,4 @@ +Manifest-Version: 1.0 +OpenIDE-Module: org.netbeans.libs.tomljava/3 +OpenIDE-Module-Localizing-Bundle:

Re: [PR] Upgrade Antlr3 and 4. New toml parsing library. [netbeans]

vieiro commented on code in PR #7180: URL: https://github.com/apache/netbeans/pull/7180#discussion_r1537953999 ## ide/languages.toml/src/org/netbeans/modules/languages/toml/semantic/TomlSemanticAnalyzer.java: ## @@ -0,0 +1,112 @@ +/* + * Licensed to the Apache Software

Re: [PR] Upgrade Antlr3 and 4. New toml parsing library. [netbeans]

mbien commented on code in PR #7180: URL: https://github.com/apache/netbeans/pull/7180#discussion_r1537872044 ## ide/libs.tomljava/manifest.mf: ## @@ -0,0 +1,4 @@ +Manifest-Version: 1.0 +OpenIDE-Module: org.netbeans.libs.tomljava/3 +OpenIDE-Module-Localizing-Bundle:

Re: [PR] Upgrade Antlr3 and 4. New toml parsing library. [netbeans]

mbien commented on code in PR #7180: URL: https://github.com/apache/netbeans/pull/7180#discussion_r1537872044 ## ide/libs.tomljava/manifest.mf: ## @@ -0,0 +1,4 @@ +Manifest-Version: 1.0 +OpenIDE-Module: org.netbeans.libs.tomljava/3 +OpenIDE-Module-Localizing-Bundle:

Re: [PR] Upgrade Antlr3 and 4. New toml parsing library. [netbeans]

mbien commented on code in PR #7180: URL: https://github.com/apache/netbeans/pull/7180#discussion_r1537872044 ## ide/libs.tomljava/manifest.mf: ## @@ -0,0 +1,4 @@ +Manifest-Version: 1.0 +OpenIDE-Module: org.netbeans.libs.tomljava/3 +OpenIDE-Module-Localizing-Bundle:

Re: [PR] Upgrade Antlr3 and 4. New toml parsing library. [netbeans]

vieiro commented on code in PR #7180: URL: https://github.com/apache/netbeans/pull/7180#discussion_r1537864789 ## ide/libs.tomljava/manifest.mf: ## @@ -0,0 +1,4 @@ +Manifest-Version: 1.0 +OpenIDE-Module: org.netbeans.libs.tomljava/3 +OpenIDE-Module-Localizing-Bundle:

Re: [PR] Upgrade Antlr3 and 4. New toml parsing library. [netbeans]

neilcsmith-net commented on code in PR #7180: URL: https://github.com/apache/netbeans/pull/7180#discussion_r1537849400 ## ide/libs.tomljava/manifest.mf: ## @@ -0,0 +1,4 @@ +Manifest-Version: 1.0 +OpenIDE-Module: org.netbeans.libs.tomljava/3 +OpenIDE-Module-Localizing-Bundle:

Re: [PR] Upgrade Antlr3 and 4. New toml parsing library. [netbeans]

mbien commented on code in PR #7180: URL: https://github.com/apache/netbeans/pull/7180#discussion_r1537814701 ## ide/libs.tomljava/manifest.mf: ## @@ -0,0 +1,4 @@ +Manifest-Version: 1.0 +OpenIDE-Module: org.netbeans.libs.tomljava/3 +OpenIDE-Module-Localizing-Bundle:

Re: [PR] Upgrade Antlr3 and 4. New toml parsing library. [netbeans]

neilcsmith-net commented on code in PR #7180: URL: https://github.com/apache/netbeans/pull/7180#discussion_r1537437284 ## ide/libs.tomljava/external/toml-java-13.3.1-license.txt: ## @@ -0,0 +1,208 @@ +Name: TOML parser in Java +Version: 13.3.1 +Description: A parser for Tom's

Re: [PR] Upgrade Antlr3 and 4. New toml parsing library. [netbeans]

mbien commented on code in PR #7180: URL: https://github.com/apache/netbeans/pull/7180#discussion_r1537402262 ## ide/libs.tomljava/external/toml-java-13.3.1-license.txt: ## @@ -0,0 +1,208 @@ +Name: TOML parser in Java +Version: 13.3.1 +Description: A parser for Tom's Obvious,

Re: [PR] Upgrade Antlr3 and 4. New toml parsing library. [netbeans]

neilcsmith-net commented on PR #7180: URL: https://github.com/apache/netbeans/pull/7180#issuecomment-2017730958 > However, some lib wrapper modules tend to have a similar version number than the lib they wrap Or take the approach of the FlatLaf wrapper and use the upstream version as

Re: [PR] Upgrade Antlr3 and 4. New toml parsing library. [netbeans]

neilcsmith-net commented on code in PR #7180: URL: https://github.com/apache/netbeans/pull/7180#discussion_r1537352203 ## ide/libs.tomljava/external/toml-java-13.3.1-license.txt: ## @@ -0,0 +1,208 @@ +Name: TOML parser in Java +Version: 13.3.1 +Description: A parser for Tom's

Re: [PR] Upgrade Antlr3 and 4. New toml parsing library. [netbeans]

mbien commented on PR #7180: URL: https://github.com/apache/netbeans/pull/7180#issuecomment-2017670100 > I was wondering if we should also bump the specification version @vieiro the way this works is that the spec version of all modules is bumped once per release in one big PR (last:

Re: [PR] Upgrade Antlr3 and 4. New toml parsing library. [netbeans]

neilcsmith-net commented on code in PR #7180: URL: https://github.com/apache/netbeans/pull/7180#discussion_r1537347691 ## ide/libs.tomljava/manifest.mf: ## @@ -0,0 +1,4 @@ +Manifest-Version: 1.0 +OpenIDE-Module: org.netbeans.libs.tomljava/3 +OpenIDE-Module-Localizing-Bundle:

Re: [PR] Upgrade Antlr3 and 4. New toml parsing library. [netbeans]

neilcsmith-net commented on code in PR #7180: URL: https://github.com/apache/netbeans/pull/7180#discussion_r1536871647 ## ide/libs.tomljava/manifest.mf: ## @@ -0,0 +1,4 @@ +Manifest-Version: 1.0 +OpenIDE-Module: org.netbeans.libs.tomljava/3 +OpenIDE-Module-Localizing-Bundle:

Re: [PR] Upgrade Antlr3 and 4. New toml parsing library. [netbeans]

vieiro commented on PR #7180: URL: https://github.com/apache/netbeans/pull/7180#issuecomment-2017460410 Hi @mbien , @lkishalmi , @lkishalmi , I was wondering if we should also bump the specification version of `ide/libs.antlr4.runtime` and `ide/libs.antlr3.runtime`. -

Re: [PR] Upgrade Antlr3 and 4. New toml parsing library. [netbeans]

vieiro commented on code in PR #7180: URL: https://github.com/apache/netbeans/pull/7180#discussion_r1536894486 ## ide/libs.tomljava/manifest.mf: ## @@ -0,0 +1,4 @@ +Manifest-Version: 1.0 +OpenIDE-Module: org.netbeans.libs.tomljava/3 +OpenIDE-Module-Localizing-Bundle:

Re: [PR] Upgrade Antlr3 and 4. New toml parsing library. [netbeans]

vieiro commented on code in PR #7180: URL: https://github.com/apache/netbeans/pull/7180#discussion_r1536894486 ## ide/libs.tomljava/manifest.mf: ## @@ -0,0 +1,4 @@ +Manifest-Version: 1.0 +OpenIDE-Module: org.netbeans.libs.tomljava/3 +OpenIDE-Module-Localizing-Bundle:

Re: [PR] Upgrade Antlr3 and 4. New toml parsing library. [netbeans]

neilcsmith-net commented on code in PR #7180: URL: https://github.com/apache/netbeans/pull/7180#discussion_r1536885758 ## ide/libs.tomljava/manifest.mf: ## @@ -0,0 +1,4 @@ +Manifest-Version: 1.0 +OpenIDE-Module: org.netbeans.libs.tomljava/3 +OpenIDE-Module-Localizing-Bundle:

Re: [PR] Upgrade Antlr3 and 4. New toml parsing library. [netbeans]

mbien commented on code in PR #7180: URL: https://github.com/apache/netbeans/pull/7180#discussion_r1536866419 ## ide/languages.toml/src/org/netbeans/modules/languages/toml/semantic/TomlSemanticAnalyzer.java: ## @@ -0,0 +1,112 @@ +/* + * Licensed to the Apache Software

Re: [PR] Upgrade Antlr3 and 4. New toml parsing library. [netbeans]

neilcsmith-net commented on code in PR #7180: URL: https://github.com/apache/netbeans/pull/7180#discussion_r1536871647 ## ide/libs.tomljava/manifest.mf: ## @@ -0,0 +1,4 @@ +Manifest-Version: 1.0 +OpenIDE-Module: org.netbeans.libs.tomljava/3 +OpenIDE-Module-Localizing-Bundle:

Re: [PR] Upgrade Antlr3 and 4. New toml parsing library. [netbeans]

vieiro commented on code in PR #7180: URL: https://github.com/apache/netbeans/pull/7180#discussion_r1536871361 ## ide/libs.tomljava/manifest.mf: ## @@ -0,0 +1,4 @@ +Manifest-Version: 1.0 +OpenIDE-Module: org.netbeans.libs.tomljava/3 +OpenIDE-Module-Localizing-Bundle:

Re: [PR] Upgrade Antlr3 and 4. New toml parsing library. [netbeans]

neilcsmith-net commented on code in PR #7180: URL: https://github.com/apache/netbeans/pull/7180#discussion_r1536867258 ## ide/libs.tomljava/manifest.mf: ## @@ -0,0 +1,4 @@ +Manifest-Version: 1.0 +OpenIDE-Module: org.netbeans.libs.tomljava/3 +OpenIDE-Module-Localizing-Bundle:

Re: [PR] Upgrade Antlr3 and 4. New toml parsing library. [netbeans]

vieiro commented on PR #7180: URL: https://github.com/apache/netbeans/pull/7180#issuecomment-2016879675 > There are a few places in the IDE where the ANTLR generated java files are in the codebase. These are not re-generated during build time. and would cause warnings on the output: >

Re: [PR] Upgrade Antlr3 and 4. New toml parsing library. [netbeans]

mbien commented on code in PR #7180: URL: https://github.com/apache/netbeans/pull/7180#discussion_r1536867798 ## ide/libs.tomljava/manifest.mf: ## @@ -0,0 +1,4 @@ +Manifest-Version: 1.0 +OpenIDE-Module: org.netbeans.libs.tomljava/3 +OpenIDE-Module-Localizing-Bundle:

Re: [PR] Upgrade Antlr3 and 4. New toml parsing library. [netbeans]

neilcsmith-net commented on code in PR #7180: URL: https://github.com/apache/netbeans/pull/7180#discussion_r1536867258 ## ide/libs.tomljava/manifest.mf: ## @@ -0,0 +1,4 @@ +Manifest-Version: 1.0 +OpenIDE-Module: org.netbeans.libs.tomljava/3 +OpenIDE-Module-Localizing-Bundle:

Re: [PR] Upgrade Antlr3 and 4. New toml parsing library. [netbeans]

mbien commented on code in PR #7180: URL: https://github.com/apache/netbeans/pull/7180#discussion_r1536866419 ## ide/languages.toml/src/org/netbeans/modules/languages/toml/semantic/TomlSemanticAnalyzer.java: ## @@ -0,0 +1,112 @@ +/* + * Licensed to the Apache Software

Re: [PR] Upgrade Antlr3 and 4. New toml parsing library. [netbeans]

matthiasblaesing commented on PR #7180: URL: https://github.com/apache/netbeans/pull/7180#issuecomment-2016876289 > so the antlr3 (3.5.2->3.5.3) update was a patch update and should be fine, however the antlr4 (4.11.1->4.13.1) update might need regen. So every minor update is an API

Re: [PR] Upgrade Antlr3 and 4. New toml parsing library. [netbeans]

mbien commented on code in PR #7180: URL: https://github.com/apache/netbeans/pull/7180#discussion_r1536865614 ## ide/libs.tomljava/manifest.mf: ## @@ -0,0 +1,4 @@ +Manifest-Version: 1.0 +OpenIDE-Module: org.netbeans.libs.tomljava/3 +OpenIDE-Module-Localizing-Bundle:

Re: [PR] Upgrade Antlr3 and 4. New toml parsing library. [netbeans]

vieiro commented on code in PR #7180: URL: https://github.com/apache/netbeans/pull/7180#discussion_r1536865305 ## ide/libs.tomljava/manifest.mf: ## @@ -0,0 +1,4 @@ +Manifest-Version: 1.0 +OpenIDE-Module: org.netbeans.libs.tomljava/3 +OpenIDE-Module-Localizing-Bundle:

Re: [PR] Upgrade Antlr3 and 4. New toml parsing library. [netbeans]

vieiro commented on code in PR #7180: URL: https://github.com/apache/netbeans/pull/7180#discussion_r1536865193 ## ide/languages.toml/src/org/netbeans/modules/languages/toml/semantic/TomlSemanticAnalyzer.java: ## @@ -0,0 +1,112 @@ +/* + * Licensed to the Apache Software

Re: [PR] Upgrade Antlr3 and 4. New toml parsing library. [netbeans]

lkishalmi commented on PR #7180: URL: https://github.com/apache/netbeans/pull/7180#issuecomment-2016860647 Referencing the previous upgrade from 4.7.2 -> 4.11.1 #4845 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] Upgrade Antlr3 and 4. New toml parsing library. [netbeans]

mbien commented on PR #7180: URL: https://github.com/apache/netbeans/pull/7180#issuecomment-2016857468 good that you mentioned this since this reminded me of the note on the antlr4 page: >- minor version updates may include minor breaking changes, the policy is to regenerate parsers

Re: [PR] Upgrade Antlr3 and 4. New toml parsing library. [netbeans]

lkishalmi commented on PR #7180: URL: https://github.com/apache/netbeans/pull/7180#issuecomment-2016854971 There are a few places in the IDE where the ANTLR generated java files are in the codebase. These are not re-generated during build time. and would cause warnings on the output:

Re: [PR] Upgrade Antlr3 and 4. New toml parsing library. [netbeans]

mbien commented on code in PR #7180: URL: https://github.com/apache/netbeans/pull/7180#discussion_r1536779223 ## ide/languages.toml/src/org/netbeans/modules/languages/toml/semantic/TomlSemanticAnalyzer.java: ## @@ -0,0 +1,112 @@ +/* + * Licensed to the Apache Software

Re: [PR] Upgrade Antlr3 and 4. New toml parsing library. [netbeans]

vieiro commented on PR #7180: URL: https://github.com/apache/netbeans/pull/7180#issuecomment-2016559865 So let's deprectate `libs.tomlj` then. It's currently used in the `rust` cluster only and will be replaced later on (and possibly by platform users). -- This is an automated message

Re: [PR] Upgrade Antlr3 and 4. New toml parsing library. [netbeans]

mbien commented on PR #7180: URL: https://github.com/apache/netbeans/pull/7180#issuecomment-2016508088 > Keeps the existing `ide/tomlj`, that should be marked as deprecated (how is this done?) and possibly removed in the future. I am not sure but probably over the module manifest,

Re: [PR] Upgrade Antlr3 and 4. New toml parsing library. [netbeans]

mbien commented on PR #7180: URL: https://github.com/apache/netbeans/pull/7180#issuecomment-2016476311 all green! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Upgrade Antlr3 and 4. New toml parsing library. [netbeans]

vieiro commented on PR #7180: URL: https://github.com/apache/netbeans/pull/7180#issuecomment-2016450836 Yep, I've also added two more images to `licenseinfo.xml`, and updated `javac.target` in antlr4 runtime lib (antlr4.13.1 is compiled with JDK11). Let's see how it goes with full tests

Re: [PR] Upgrade Antlr3 and 4. New toml parsing library. [netbeans]

mbien commented on PR #7180: URL: https://github.com/apache/netbeans/pull/7180#issuecomment-2016444615 added all-tests label just to be sure. If it was green once, feel free to remove it again. -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] Upgrade Antlr3 and 4. New toml parsing library. [netbeans]

mbien commented on code in PR #7180: URL: https://github.com/apache/netbeans/pull/7180#discussion_r1536611197 ## ide/languages.toml/nbproject/project.properties: ## @@ -14,6 +14,6 @@ # KIND, either express or implied. See the License for the # specific language governing

Re: [PR] Upgrade Antlr3 and 4. New toml parsing library. [netbeans]

vieiro commented on PR #7180: URL: https://github.com/apache/netbeans/pull/7180#issuecomment-2016415827 It seems our `ValidateClassFilesTest` is complaining about `libs/tomljava` not being marked as Java 11. Will fix as time permits. -- This is an automated message from the Apache Git