[GitHub] [logging-log4j2] rgoers commented on issue #351: LOG4J2-1360 - Provide a Log4j implementation of System.Logger

2020-04-05 Thread GitBox
rgoers commented on issue #351: LOG4J2-1360 - Provide a Log4j implementation of System.Logger URL: https://github.com/apache/logging-log4j2/pull/351#issuecomment-609552898 This was merged. This is an automated message from th

[GitHub] [logging-log4j2] rgoers closed pull request #351: LOG4J2-1360 - Provide a Log4j implementation of System.Logger

2020-04-05 Thread GitBox
rgoers closed pull request #351: LOG4J2-1360 - Provide a Log4j implementation of System.Logger URL: https://github.com/apache/logging-log4j2/pull/351 This is an automated message from the Apache Git Service. To respond to th

[GitHub] [logging-log4j2] rgoers commented on a change in pull request #335: Import of LogstashLayout as JsonTemplateLayout

2020-04-05 Thread GitBox
rgoers commented on a change in pull request #335: Import of LogstashLayout as JsonTemplateLayout URL: https://github.com/apache/logging-log4j2/pull/335#discussion_r403825698 ## File path: src/site/markdown/manual/cloud.md ## @@ -118,76 +118,69 @@ being configured with a l

[GitHub] [logging-log4j2] rgoers commented on a change in pull request #335: Import of LogstashLayout as JsonTemplateLayout

2020-04-05 Thread GitBox
rgoers commented on a change in pull request #335: Import of LogstashLayout as JsonTemplateLayout URL: https://github.com/apache/logging-log4j2/pull/335#discussion_r403826313 ## File path: src/site/markdown/manual/cloud.md ## @@ -118,76 +118,69 @@ being configured with a l

[GitHub] [logging-log4j2] rgoers commented on a change in pull request #335: Import of LogstashLayout as JsonTemplateLayout

2020-04-05 Thread GitBox
rgoers commented on a change in pull request #335: Import of LogstashLayout as JsonTemplateLayout URL: https://github.com/apache/logging-log4j2/pull/335#discussion_r403820364 ## File path: log4j-core/src/test/java/org/apache/logging/log4j/core/GcFreeLoggingTestUtil.java ##

[GitHub] [logging-log4j2] rgoers commented on a change in pull request #335: Import of LogstashLayout as JsonTemplateLayout

2020-04-05 Thread GitBox
rgoers commented on a change in pull request #335: Import of LogstashLayout as JsonTemplateLayout URL: https://github.com/apache/logging-log4j2/pull/335#discussion_r403819822 ## File path: log4j-api/src/main/java/org/apache/logging/log4j/util/Strings.java ## @@ -55,14 +55,

[GitHub] [logging-log4j2] vy commented on issue #335: Import of LogstashLayout as JsonTemplateLayout

2020-04-08 Thread GitBox
vy commented on issue #335: Import of LogstashLayout as JsonTemplateLayout URL: https://github.com/apache/logging-log4j2/pull/335#issuecomment-610976180 > The logging in the cloud docs need to be discussed or reverted. How shall we proceed? Do you want to discuss in the mailing list o

[GitHub] [logging-log4j2] rgoers commented on issue #335: Import of LogstashLayout as JsonTemplateLayout

2020-04-08 Thread GitBox
rgoers commented on issue #335: Import of LogstashLayout as JsonTemplateLayout URL: https://github.com/apache/logging-log4j2/pull/335#issuecomment-611028572 mailing list. This is already too long. This is an automated message

[GitHub] [logging-log4j2] carterkozak commented on a change in pull request #335: Import of LogstashLayout as JsonTemplateLayout

2020-04-08 Thread GitBox
carterkozak commented on a change in pull request #335: Import of LogstashLayout as JsonTemplateLayout URL: https://github.com/apache/logging-log4j2/pull/335#discussion_r405623558 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/util/Throwables.java ##

[GitHub] [logging-log4j2] carterkozak commented on a change in pull request #335: Import of LogstashLayout as JsonTemplateLayout

2020-04-08 Thread GitBox
carterkozak commented on a change in pull request #335: Import of LogstashLayout as JsonTemplateLayout URL: https://github.com/apache/logging-log4j2/pull/335#discussion_r405621721 ## File path: log4j-api/src/main/java/org/apache/logging/log4j/util/Strings.java ## @@ -55,14

[GitHub] [logging-log4j2] carterkozak commented on a change in pull request #335: Import of LogstashLayout as JsonTemplateLayout

2020-04-08 Thread GitBox
carterkozak commented on a change in pull request #335: Import of LogstashLayout as JsonTemplateLayout URL: https://github.com/apache/logging-log4j2/pull/335#discussion_r405628150 ## File path: log4j-layout-json-template/src/main/java/org/apache/logging/log4j/layout/json/template/J

[GitHub] [logging-log4j2] carterkozak commented on a change in pull request #335: Import of LogstashLayout as JsonTemplateLayout

2020-04-08 Thread GitBox
carterkozak commented on a change in pull request #335: Import of LogstashLayout as JsonTemplateLayout URL: https://github.com/apache/logging-log4j2/pull/335#discussion_r405619866 ## File path: log4j-api/src/main/java/org/apache/logging/log4j/util/Strings.java ## @@ -286,4

[GitHub] [logging-log4cxx] aallrd opened a new pull request #22: Only exporting the log4cxx symbols by default

2020-04-09 Thread GitBox
aallrd opened a new pull request #22: Only exporting the log4cxx symbols by default URL: https://github.com/apache/logging-log4cxx/pull/22 Adding a linker version script to only make the log4cxx symbols visible in the log4cxx shared library. The exported defined symbols on the installed

[GitHub] [logging-log4cxx] rm5248 commented on issue #22: Only exporting the log4cxx symbols by default

2020-04-09 Thread GitBox
rm5248 commented on issue #22: Only exporting the log4cxx symbols by default URL: https://github.com/apache/logging-log4cxx/pull/22#issuecomment-611719069 I'm not all that familiar with this, so out of curiosity what problem does this attempt to solve? I've never had an issue with this on

[GitHub] [logging-log4cxx] ams-tschoening commented on issue #22: Only exporting the log4cxx symbols by default

2020-04-09 Thread GitBox
ams-tschoening commented on issue #22: Only exporting the log4cxx symbols by default URL: https://github.com/apache/logging-log4cxx/pull/22#issuecomment-611735726 I was about to ask the same question about what problem the PR actually solves and which compilers it supports. --

[GitHub] [logging-log4cxx] ams-tschoening commented on a change in pull request #22: Only exporting the log4cxx symbols by default

2020-04-09 Thread GitBox
ams-tschoening commented on a change in pull request #22: Only exporting the log4cxx symbols by default URL: https://github.com/apache/logging-log4cxx/pull/22#discussion_r406457285 ## File path: CMakeLists.txt ## @@ -18,6 +18,13 @@ if(NOT BUILD_SHARED_LIBS) set(LOG4CXX_

[GitHub] [logging-log4cxx] ams-tschoening commented on a change in pull request #22: Only exporting the log4cxx symbols by default

2020-04-09 Thread GitBox
ams-tschoening commented on a change in pull request #22: Only exporting the log4cxx symbols by default URL: https://github.com/apache/logging-log4cxx/pull/22#discussion_r406459039 ## File path: src/site/apt/building/cmake.apt ## @@ -39,24 +39,26 @@ $ sudo make install

[GitHub] [logging-log4cxx] ams-tschoening commented on a change in pull request #22: Only exporting the log4cxx symbols by default

2020-04-09 Thread GitBox
ams-tschoening commented on a change in pull request #22: Only exporting the log4cxx symbols by default URL: https://github.com/apache/logging-log4cxx/pull/22#discussion_r406458095 ## File path: CMakeLists.txt ## @@ -18,6 +18,13 @@ if(NOT BUILD_SHARED_LIBS) set(LOG4CXX_

[GitHub] [logging-log4cxx] aallrd commented on issue #22: Only exporting the log4cxx symbols by default

2020-04-10 Thread GitBox
aallrd commented on issue #22: Only exporting the log4cxx symbols by default URL: https://github.com/apache/logging-log4cxx/pull/22#issuecomment-611983430 Hello, Sorry for the incomplete PR, I wanted really to open an issue but I could not find how to to that on this project.

[GitHub] [logging-log4cxx] aallrd commented on a change in pull request #22: Only exporting the log4cxx symbols by default

2020-04-10 Thread GitBox
aallrd commented on a change in pull request #22: Only exporting the log4cxx symbols by default URL: https://github.com/apache/logging-log4cxx/pull/22#discussion_r406709509 ## File path: CMakeLists.txt ## @@ -18,6 +18,13 @@ if(NOT BUILD_SHARED_LIBS) set(LOG4CXX_COMPILE_

[GitHub] [logging-log4cxx] aallrd commented on a change in pull request #22: Only exporting the log4cxx symbols by default

2020-04-10 Thread GitBox
aallrd commented on a change in pull request #22: Only exporting the log4cxx symbols by default URL: https://github.com/apache/logging-log4cxx/pull/22#discussion_r406709605 ## File path: CMakeLists.txt ## @@ -18,6 +18,13 @@ if(NOT BUILD_SHARED_LIBS) set(LOG4CXX_COMPILE_

[GitHub] [logging-log4cxx] aallrd commented on a change in pull request #22: Only exporting the log4cxx symbols by default

2020-04-10 Thread GitBox
aallrd commented on a change in pull request #22: Only exporting the log4cxx symbols by default URL: https://github.com/apache/logging-log4cxx/pull/22#discussion_r406709783 ## File path: src/site/apt/building/cmake.apt ## @@ -39,24 +39,26 @@ $ sudo make install * ccmake

[GitHub] [logging-log4cxx] rm5248 commented on issue #22: Only exporting the log4cxx symbols by default

2020-04-10 Thread GitBox
rm5248 commented on issue #22: Only exporting the log4cxx symbols by default URL: https://github.com/apache/logging-log4cxx/pull/22#issuecomment-612049860 In that case, there's probably an easier way to do this. Since the symbols already need to be marked as exported for Windows builds, th

[GitHub] [logging-log4cxx] rm5248 edited a comment on issue #22: Only exporting the log4cxx symbols by default

2020-04-10 Thread GitBox
rm5248 edited a comment on issue #22: Only exporting the log4cxx symbols by default URL: https://github.com/apache/logging-log4cxx/pull/22#issuecomment-612049860 In that case, there's probably an easier way to do this. Since the symbols already need to be marked as exported for Windows bu

[GitHub] [logging-log4j2] rgoers commented on a change in pull request #335: Import of LogstashLayout as JsonTemplateLayout

2020-04-11 Thread GitBox
rgoers commented on a change in pull request #335: Import of LogstashLayout as JsonTemplateLayout URL: https://github.com/apache/logging-log4j2/pull/335#discussion_r40703 ## File path: log4j-layout-json-template/src/main/java/org/apache/logging/log4j/layout/json/template/resolv

[GitHub] [logging-log4j2] rgoers commented on issue #214: LOG4J2-1002 - ThrowablePatternConverter should preserve EOF

2020-04-11 Thread GitBox
rgoers commented on issue #214: LOG4J2-1002 - ThrowablePatternConverter should preserve EOF URL: https://github.com/apache/logging-log4j2/pull/214#issuecomment-612548823 I tried applying this and it caused unit test failures in log4j-taglib.

[GitHub] [logging-log4j2] rgoers merged pull request #346: LOG4J2-2794 - Make unit test more resilient to environment differences.

2020-04-11 Thread GitBox
rgoers merged pull request #346: LOG4J2-2794 - Make unit test more resilient to environment differences. URL: https://github.com/apache/logging-log4j2/pull/346 This is an automated message from the Apache Git Service. To res

[GitHub] [logging-log4j2] rgoers commented on a change in pull request #348: LOG4J2-2793 - Unable to parse the log LEVEL when it ends with SPACE.

2020-04-11 Thread GitBox
rgoers commented on a change in pull request #348: LOG4J2-2793 - Unable to parse the log LEVEL when it ends with SPACE. URL: https://github.com/apache/logging-log4j2/pull/348#discussion_r407133516 ## File path: log4j-api/src/main/java/org/apache/logging/log4j/Level.java ##

[GitHub] [logging-log4j2] rgoers commented on a change in pull request #348: LOG4J2-2793 - Unable to parse the log LEVEL when it ends with SPACE.

2020-04-11 Thread GitBox
rgoers commented on a change in pull request #348: LOG4J2-2793 - Unable to parse the log LEVEL when it ends with SPACE. URL: https://github.com/apache/logging-log4j2/pull/348#discussion_r407133486 ## File path: log4j-api/src/main/java/org/apache/logging/log4j/Level.java ##

[GitHub] [logging-log4j2] rgoers merged pull request #349: Fix erroneous usage of default locale

2020-04-11 Thread GitBox
rgoers merged pull request #349: Fix erroneous usage of default locale URL: https://github.com/apache/logging-log4j2/pull/349 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [logging-log4cxx] ams-tschoening commented on issue #22: Only exporting the log4cxx symbols by default

2020-04-12 Thread GitBox
ams-tschoening commented on issue #22: Only exporting the log4cxx symbols by default URL: https://github.com/apache/logging-log4cxx/pull/22#issuecomment-612593743 @aallrd > Sorry for the incomplete PR, I wanted really to open an issue but I could not find how to to that on this proj

[GitHub] [logging-log4cxx] ams-tschoening commented on a change in pull request #22: Only exporting the log4cxx symbols by default

2020-04-12 Thread GitBox
ams-tschoening commented on a change in pull request #22: Only exporting the log4cxx symbols by default URL: https://github.com/apache/logging-log4cxx/pull/22#discussion_r407178479 ## File path: CMakeLists.txt ## @@ -18,6 +18,13 @@ if(NOT BUILD_SHARED_LIBS) set(LOG4CXX_

[GitHub] [logging-log4cxx] ams-tschoening commented on a change in pull request #22: Only exporting the log4cxx symbols by default

2020-04-12 Thread GitBox
ams-tschoening commented on a change in pull request #22: Only exporting the log4cxx symbols by default URL: https://github.com/apache/logging-log4cxx/pull/22#discussion_r407178479 ## File path: CMakeLists.txt ## @@ -18,6 +18,13 @@ if(NOT BUILD_SHARED_LIBS) set(LOG4CXX_

[GitHub] [logging-log4cxx] ams-tschoening commented on a change in pull request #22: Only exporting the log4cxx symbols by default

2020-04-12 Thread GitBox
ams-tschoening commented on a change in pull request #22: Only exporting the log4cxx symbols by default URL: https://github.com/apache/logging-log4cxx/pull/22#discussion_r407178479 ## File path: CMakeLists.txt ## @@ -18,6 +18,13 @@ if(NOT BUILD_SHARED_LIBS) set(LOG4CXX_

[GitHub] [logging-log4cxx] ams-tschoening edited a comment on issue #22: Only exporting the log4cxx symbols by default

2020-04-12 Thread GitBox
ams-tschoening edited a comment on issue #22: Only exporting the log4cxx symbols by default URL: https://github.com/apache/logging-log4cxx/pull/22#issuecomment-612593743 @aallrd > Sorry for the incomplete PR, I wanted really to open an issue but I could not find how to to that on th

[GitHub] [logging-log4cxx] ams-tschoening commented on issue #22: Only exporting the log4cxx symbols by default

2020-04-12 Thread GitBox
ams-tschoening commented on issue #22: Only exporting the log4cxx symbols by default URL: https://github.com/apache/logging-log4cxx/pull/22#issuecomment-612594950 @aallrd How about updating your branch to master and including the attached changes to `changes.xml` in this PR? I've changed t

[GitHub] [logging-log4cxx] rm5248 commented on issue #22: Only exporting the log4cxx symbols by default

2020-04-12 Thread GitBox
rm5248 commented on issue #22: Only exporting the log4cxx symbols by default URL: https://github.com/apache/logging-log4cxx/pull/22#issuecomment-612645586 > I'm just trying to understand things, so: Why do you consider your approach easier? Having a well documented cmake-option doesn't seem

[GitHub] [logging-log4j2] rgoers merged pull request #345: LOG4J2-2791 - Correct JsonLayout timestamp sorting issue

2020-04-12 Thread GitBox
rgoers merged pull request #345: LOG4J2-2791 - Correct JsonLayout timestamp sorting issue URL: https://github.com/apache/logging-log4j2/pull/345 This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [logging-log4j2] rgoers commented on issue #158: [LOG4J2-2280] Introduce an Apache Pulsar log4j appender

2020-04-12 Thread GitBox
rgoers commented on issue #158: [LOG4J2-2280] Introduce an Apache Pulsar log4j appender URL: https://github.com/apache/logging-log4j2/pull/158#issuecomment-612674046 Closing this since virtually the same code by the same author is now part of Pulsar itself. ---

[GitHub] [logging-log4j2] rgoers closed pull request #158: [LOG4J2-2280] Introduce an Apache Pulsar log4j appender

2020-04-12 Thread GitBox
rgoers closed pull request #158: [LOG4J2-2280] Introduce an Apache Pulsar log4j appender URL: https://github.com/apache/logging-log4j2/pull/158 This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [logging-log4j2] rgoers commented on issue #163: Add KeyValueLayout which outputs log messages as key/value pairs.

2020-04-12 Thread GitBox
rgoers commented on issue #163: Add KeyValueLayout which outputs log messages as key/value pairs. URL: https://github.com/apache/logging-log4j2/pull/163#issuecomment-612674358 In addition to no Jira issue, this PR doesn't include any documentation on the Layout. --

[GitHub] [logging-log4j2] rgoers commented on issue #210: [LOG4J2-2391] Lazily initialize ThrowableProxy data

2020-04-12 Thread GitBox
rgoers commented on issue #210: [LOG4J2-2391] Lazily initialize ThrowableProxy data URL: https://github.com/apache/logging-log4j2/pull/210#issuecomment-612674786 @carterkozak What is the status of this PR? This is an automate

[GitHub] [logging-log4j2] rgoers commented on issue #274: [LOG4J2-2600] Add declarative Groovy configuration DSL

2020-04-12 Thread GitBox
rgoers commented on issue #274: [LOG4J2-2600] Add declarative Groovy configuration DSL URL: https://github.com/apache/logging-log4j2/pull/274#issuecomment-612675042 Closing per @jvz so I don't keep looking at it. This is an a

[GitHub] [logging-log4j2] rgoers closed pull request #274: [LOG4J2-2600] Add declarative Groovy configuration DSL

2020-04-12 Thread GitBox
rgoers closed pull request #274: [LOG4J2-2600] Add declarative Groovy configuration DSL URL: https://github.com/apache/logging-log4j2/pull/274 This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [logging-log4cxx] ams-tschoening commented on issue #22: Only exporting the log4cxx symbols by default

2020-04-14 Thread GitBox
ams-tschoening commented on issue #22: Only exporting the log4cxx symbols by default URL: https://github.com/apache/logging-log4cxx/pull/22#issuecomment-613274847 So what's the strategy then? @aallrd Do you want to give the approach of @rm5248 a try and see if it fixes your concrete proble

[GitHub] [logging-log4j2] carterkozak commented on issue #210: [LOG4J2-2391] Lazily initialize ThrowableProxy data

2020-04-14 Thread GitBox
carterkozak commented on issue #210: [LOG4J2-2391] Lazily initialize ThrowableProxy data URL: https://github.com/apache/logging-log4j2/pull/210#issuecomment-613486202 Sorry, this has gotten stale and I need to come back to the problem when I have some time. I'm not confident this is the be

[GitHub] [logging-log4cxx] rm5248 commented on issue #22: Only exporting the log4cxx symbols by default

2020-04-14 Thread GitBox
rm5248 commented on issue #22: Only exporting the log4cxx symbols by default URL: https://github.com/apache/logging-log4cxx/pull/22#issuecomment-613730871 > OTOH, the changed implementation of CMAKE doesn't look too invasive and can easily be disabled if it makes problems in future by all u

[GitHub] [logging-log4cxx] aallrd commented on issue #22: Only exporting the log4cxx symbols by default

2020-04-15 Thread GitBox
aallrd commented on issue #22: Only exporting the log4cxx symbols by default URL: https://github.com/apache/logging-log4cxx/pull/22#issuecomment-613895179 Hello, Thank you for your comments, and for the interesting [GCC bugzilla report](https://gcc.gnu.org/bugzilla/show_bug.cgi?id=36022)

[GitHub] [logging-log4cxx] ams-tschoening commented on issue #22: Only exporting the log4cxx symbols by default

2020-04-15 Thread GitBox
ams-tschoening commented on issue #22: Only exporting the log4cxx symbols by default URL: https://github.com/apache/logging-log4cxx/pull/22#issuecomment-613915308 > I will keep this patch on my internal project for the moment, try to implement the visibility macros for GCC in the project a

[GitHub] [logging-log4cxx] rm5248 commented on issue #22: Only exporting the log4cxx symbols by default

2020-04-15 Thread GitBox
rm5248 commented on issue #22: Only exporting the log4cxx symbols by default URL: https://github.com/apache/logging-log4cxx/pull/22#issuecomment-614097241 > I will keep this patch on my internal project for the moment, try to implement the visibility macros for GCC in the project and test i

[GitHub] [logging-log4j2] rgoers merged pull request #348: LOG4J2-2793 - Unable to parse the log LEVEL when it ends with SPACE.

2020-04-16 Thread GitBox
rgoers merged pull request #348: LOG4J2-2793 - Unable to parse the log LEVEL when it ends with SPACE. URL: https://github.com/apache/logging-log4j2/pull/348 This is an automated message from the Apache Git Service. To respon

[GitHub] [logging-log4j2] rgoers commented on issue #308: LOG4J2-1192 (support dynamic Subject)

2020-04-16 Thread GitBox
rgoers commented on issue #308: LOG4J2-1192 (support dynamic Subject) URL: https://github.com/apache/logging-log4j2/pull/308#issuecomment-615013554 Closing at authors request This is an automated message from the Apache Git Se

[GitHub] [logging-log4j2] rgoers closed pull request #308: LOG4J2-1192 (support dynamic Subject)

2020-04-16 Thread GitBox
rgoers closed pull request #308: LOG4J2-1192 (support dynamic Subject) URL: https://github.com/apache/logging-log4j2/pull/308 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [logging-log4j2] CrazyBills opened a new pull request #357: Support Location Info in GELF Layout

2020-04-19 Thread GitBox
CrazyBills opened a new pull request #357: URL: https://github.com/apache/logging-log4j2/pull/357 GELF Layout supports message pattern but couldn't print location info So I created this PR to fix this issue, it will check if the message pattern contains location info. -

[GitHub] [logging-log4j2] rgoers commented on issue #357: Support Location Info in GELF Layout

2020-04-20 Thread GitBox
rgoers commented on issue #357: URL: https://github.com/apache/logging-log4j2/pull/357#issuecomment-616824127 Code was merged. This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [logging-log4net] ghboca opened a new pull request #58: Create modern style project file.

2020-04-23 Thread GitBox
ghboca opened a new pull request #58: URL: https://github.com/apache/logging-log4net/pull/58 Rename NETSTANDARD1_3 to NETSTANDARD update readme.txt update version to 2.1.0.0 This is an automated message from the Apache

[GitHub] [logging-log4cxx] stephen-webb opened a new pull request #23: Static linking support for non windows systems

2020-04-23 Thread GitBox
stephen-webb opened a new pull request #23: URL: https://github.com/apache/logging-log4cxx/pull/23 This PR implements the documented behavior of the cmake options APR_STATIC=yes, APU_STATIC=yes and BUILD_SHARED_LIBS=no for non-windows systems. Using the APR_STATIC=yes (not the defaul

[GitHub] [logging-log4j2] asbachb opened a new pull request #358: LOG4J2-2832: Updated strategy name to existing strategy

2020-04-27 Thread GitBox
asbachb opened a new pull request #358: URL: https://github.com/apache/logging-log4j2/pull/358 Instead of using a hard coded name the class name of the interface was used which a) Increases visibility where the interface is referenced b) Prevents that the message needs to be adjusted

[GitHub] [logging-log4cxx] stephen-webb commented on a change in pull request #23: Static linking support for non windows systems

2020-05-01 Thread GitBox
stephen-webb commented on a change in pull request #23: URL: https://github.com/apache/logging-log4cxx/pull/23#discussion_r418442671 ## File path: src/cmake/FindAPR-Util.cmake ## @@ -34,7 +34,14 @@ find_program(APR_UTIL_CONFIG_EXECUTABLE mark_as_advanced(APR_UTIL_CONFIG_EXECUT

[GitHub] [logging-log4cxx] stephen-webb commented on a change in pull request #23: Static linking support for non windows systems

2020-05-01 Thread GitBox
stephen-webb commented on a change in pull request #23: URL: https://github.com/apache/logging-log4cxx/pull/23#discussion_r418442671 ## File path: src/cmake/FindAPR-Util.cmake ## @@ -34,7 +34,14 @@ find_program(APR_UTIL_CONFIG_EXECUTABLE mark_as_advanced(APR_UTIL_CONFIG_EXECUT

[GitHub] [logging-log4cxx] stephen-webb commented on a change in pull request #23: Static linking support for non windows systems

2020-05-01 Thread GitBox
stephen-webb commented on a change in pull request #23: URL: https://github.com/apache/logging-log4cxx/pull/23#discussion_r418443118 ## File path: src/cmake/FindAPR-Util.cmake ## @@ -48,5 +55,5 @@ else() endif() endif() -find_package_handle_standard_args(APR-Util DEFAUL

[GitHub] [logging-log4cxx] stephen-webb commented on a change in pull request #23: Static linking support for non windows systems

2020-05-01 Thread GitBox
stephen-webb commented on a change in pull request #23: URL: https://github.com/apache/logging-log4cxx/pull/23#discussion_r418444913 ## File path: src/cmake/FindAPR.cmake ## @@ -33,7 +33,14 @@ find_program(APR_CONFIG_EXECUTABLE mark_as_advanced(APR_CONFIG_EXECUTABLE) if(EXIST

[GitHub] [logging-log4cxx] stephen-webb commented on a change in pull request #23: Static linking support for non windows systems

2020-05-01 Thread GitBox
stephen-webb commented on a change in pull request #23: URL: https://github.com/apache/logging-log4cxx/pull/23#discussion_r418444913 ## File path: src/cmake/FindAPR.cmake ## @@ -33,7 +33,14 @@ find_program(APR_CONFIG_EXECUTABLE mark_as_advanced(APR_CONFIG_EXECUTABLE) if(EXIST

[GitHub] [logging-log4cxx] stephen-webb commented on a change in pull request #23: Static linking support for non windows systems

2020-05-01 Thread GitBox
stephen-webb commented on a change in pull request #23: URL: https://github.com/apache/logging-log4cxx/pull/23#discussion_r418451027 ## File path: src/cmake/FindAPR-Util.cmake ## @@ -34,7 +34,14 @@ find_program(APR_UTIL_CONFIG_EXECUTABLE mark_as_advanced(APR_UTIL_CONFIG_EXECUT

[GitHub] [logging-log4cxx] ams-tschoening commented on a change in pull request #23: Static linking support for non windows systems

2020-05-03 Thread GitBox
ams-tschoening commented on a change in pull request #23: URL: https://github.com/apache/logging-log4cxx/pull/23#discussion_r419100116 ## File path: src/cmake/FindAPR-Util.cmake ## @@ -34,7 +34,14 @@ find_program(APR_UTIL_CONFIG_EXECUTABLE mark_as_advanced(APR_UTIL_CONFIG_EXEC

[GitHub] [logging-log4cxx] ams-tschoening commented on a change in pull request #23: Static linking support for non windows systems

2020-05-03 Thread GitBox
ams-tschoening commented on a change in pull request #23: URL: https://github.com/apache/logging-log4cxx/pull/23#discussion_r419100116 ## File path: src/cmake/FindAPR-Util.cmake ## @@ -34,7 +34,14 @@ find_program(APR_UTIL_CONFIG_EXECUTABLE mark_as_advanced(APR_UTIL_CONFIG_EXEC

[GitHub] [logging-log4cxx] stephen-webb commented on a change in pull request #23: Static linking support for non windows systems

2020-05-03 Thread GitBox
stephen-webb commented on a change in pull request #23: URL: https://github.com/apache/logging-log4cxx/pull/23#discussion_r419184713 ## File path: src/cmake/FindAPR-Util.cmake ## @@ -34,7 +34,14 @@ find_program(APR_UTIL_CONFIG_EXECUTABLE mark_as_advanced(APR_UTIL_CONFIG_EXECUT

[GitHub] [logging-log4j2] dengliming opened a new pull request #359: LOG4J2-2344: Fix exception message in PropertiesConfigurationBuilder.createFilter

2020-05-15 Thread GitBox
dengliming opened a new pull request #359: URL: https://github.com/apache/logging-log4j2/pull/359 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [logging-log4net] fluffynuts opened a new pull request #59: Update build system

2020-05-16 Thread GitBox
fluffynuts opened a new pull request #59: URL: https://github.com/apache/logging-log4net/pull/59 - Updates build system to use gulp-based build - builds .nupkg and release binaries zip latest build is here: https://ci.appveyor.com/project/fluffynuts/logging-log4net/builds/32915894

[GitHub] [logging-log4net] rgoers commented on pull request #59: Update build system

2020-05-16 Thread GitBox
rgoers commented on pull request #59: URL: https://github.com/apache/logging-log4net/pull/59#issuecomment-629685793 For the CLA see https://www.apache.org/licenses/contributor-agreements.html. In particular you need to fill out the ICLA and send it in according to the instructions. That is

[GitHub] [logging-log4net] rgoers edited a comment on pull request #59: Update build system

2020-05-16 Thread GitBox
rgoers edited a comment on pull request #59: URL: https://github.com/apache/logging-log4net/pull/59#issuecomment-629685793 For the CLA see https://www.apache.org/licenses/contributor-agreements.html. In particular you need to fill out the ICLA and send it in according to the instructions.

[GitHub] [logging-log4net] rgoers commented on pull request #59: Update build system

2020-05-16 Thread GitBox
rgoers commented on pull request #59: URL: https://github.com/apache/logging-log4net/pull/59#issuecomment-629714275 How can I validate this PR? Are there build instructions somewhere? I assume it requires Windows? Any particular version required? Are there prerequisites that have to be ins

[GitHub] [logging-log4net] fluffynuts commented on pull request #59: Update build system

2020-05-18 Thread GitBox
fluffynuts commented on pull request #59: URL: https://github.com/apache/logging-log4net/pull/59#issuecomment-629987619 @rgoers good idea about standalone build instructions. I've added a BUILDING.md document which should hopefully be helpful. Feedback appreciated. ---

[GitHub] [logging-log4j2] sebthom opened a new pull request #360: LOG4J2-2847 - Extend Log4j-config.xsd

2020-05-20 Thread GitBox
sebthom opened a new pull request #360: URL: https://github.com/apache/logging-log4j2/pull/360 This commit modifies the Log4j-config.xsd in the following ways: a) the type elements are re-order in a way that related types are physically close to each other b) the Configuration type is

[GitHub] [logging-log4j-kotlin] qoomon edited a comment on pull request #10: feat: static loggers initialisation

2020-05-20 Thread GitBox
qoomon edited a comment on pull request #10: URL: https://github.com/apache/logging-log4j-kotlin/pull/10#issuecomment-631645657 when do you plan to merge and release? This is an automated message from the Apache Git Service.

[GitHub] [logging-log4j-kotlin] qoomon commented on pull request #10: feat: static loggers initialisation

2020-05-20 Thread GitBox
qoomon commented on pull request #10: URL: https://github.com/apache/logging-log4j-kotlin/pull/10#issuecomment-631645657 when you plan to merge and release? This is an automated message from the Apache Git Service. To respon

[GitHub] [logging-log4j-kotlin] jvz commented on pull request #10: feat: static loggers initialisation

2020-05-20 Thread GitBox
jvz commented on pull request #10: URL: https://github.com/apache/logging-log4j-kotlin/pull/10#issuecomment-631656325 @rocketraman can merge this as he's been the main developer in this component. As for a release, we'd likely need a volunteer to help do that. I have a release guide writt

[GitHub] [logging-log4j-kotlin] rocketraman commented on pull request #10: feat: static loggers initialisation

2020-05-20 Thread GitBox
rocketraman commented on pull request #10: URL: https://github.com/apache/logging-log4j-kotlin/pull/10#issuecomment-631673194 Actually @jvz I don't think I have push rights to this repository. I did modify @qoomon 's branch a little bit so if you do decide to push this yourself, let me kn

[GitHub] [logging-log4j-kotlin] jvz commented on pull request #10: feat: static loggers initialisation

2020-05-20 Thread GitBox
jvz commented on pull request #10: URL: https://github.com/apache/logging-log4j-kotlin/pull/10#issuecomment-631676713 Alright, I'll merge this for you. Let me look into the permissions thing. This is an automated message fro

[GitHub] [logging-log4j-kotlin] jvz merged pull request #10: feat: static loggers initialisation

2020-05-20 Thread GitBox
jvz merged pull request #10: URL: https://github.com/apache/logging-log4j-kotlin/pull/10 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [logging-log4j-kotlin] rocketraman commented on pull request #10: feat: static loggers initialisation

2020-05-20 Thread GitBox
rocketraman commented on pull request #10: URL: https://github.com/apache/logging-log4j-kotlin/pull/10#issuecomment-631677410 > Alright, I'll merge this for you. Let me look into the permissions thing. Ok you merged the branch as-is, with the back-and-forth, whereas I was gonna merg

[GitHub] [logging-log4j-kotlin] rocketraman edited a comment on pull request #10: feat: static loggers initialisation

2020-05-20 Thread GitBox
rocketraman edited a comment on pull request #10: URL: https://github.com/apache/logging-log4j-kotlin/pull/10#issuecomment-631677410 > Alright, I'll merge this for you. Let me look into the permissions thing. Ok you merged the branch as-is, with the back-and-forth on the code changes

[GitHub] [logging-log4j-kotlin] jvz commented on pull request #10: feat: static loggers initialisation

2020-05-20 Thread GitBox
jvz commented on pull request #10: URL: https://github.com/apache/logging-log4j-kotlin/pull/10#issuecomment-631679428 You're a committer on the project, so you should be able to merge. Make sure you have two-factor auth set up for you github account. -

[GitHub] [logging-log4j-kotlin] rocketraman commented on pull request #10: feat: static loggers initialisation

2020-05-20 Thread GitBox
rocketraman commented on pull request #10: URL: https://github.com/apache/logging-log4j-kotlin/pull/10#issuecomment-631680543 > You're a committer on the project, so you should be able to merge. Make sure you have two-factor auth set up for you github account. I do. --

[GitHub] [logging-log4j-kotlin] jvz commented on pull request #10: feat: static loggers initialisation

2020-05-20 Thread GitBox
jvz commented on pull request #10: URL: https://github.com/apache/logging-log4j-kotlin/pull/10#issuecomment-631683840 I filed https://issues.apache.org/jira/browse/INFRA-20289 to get that looked at. This is an automated mes

[GitHub] [logging-log4j-kotlin] jvz commented on pull request #10: feat: static loggers initialisation

2020-05-20 Thread GitBox
jvz commented on pull request #10: URL: https://github.com/apache/logging-log4j-kotlin/pull/10#issuecomment-631696152 @rocketraman check your account settings on https://gitbox.apache.org/setup/ and report back in that INFRA ticket I linked. --

[GitHub] [logging-log4j-kotlin] rocketraman commented on pull request #12: Initial benchmark module

2020-05-20 Thread GitBox
rocketraman commented on pull request #12: URL: https://github.com/apache/logging-log4j-kotlin/pull/12#issuecomment-631728782 @jvz /review please. This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [logging-log4j-kotlin] rocketraman edited a comment on pull request #8: LOG4J2-2433 Coroutines Support

2020-05-20 Thread GitBox
rocketraman edited a comment on pull request #8: URL: https://github.com/apache/logging-log4j-kotlin/pull/8#issuecomment-631738478 > I'm curious about the garbage generating behavior of suspending and resuming the map and stack. Good question. I added JMH in https://github.com/apac

[GitHub] [logging-log4j-kotlin] rocketraman commented on pull request #8: LOG4J2-2433 Coroutines Support

2020-05-20 Thread GitBox
rocketraman commented on pull request #8: URL: https://github.com/apache/logging-log4j-kotlin/pull/8#issuecomment-631738478 > I'm curious about the garbage generating behavior of suspending and resuming the map and stack. Good question. Probably needs a benchmark. I added JMH in ht

[GitHub] [logging-log4j-kotlin] rocketraman merged pull request #11: LOG4J2-2843 Kotlin 1.3.72

2020-05-20 Thread GitBox
rocketraman merged pull request #11: URL: https://github.com/apache/logging-log4j-kotlin/pull/11 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [logging-log4j-kotlin] rocketraman closed pull request #8: LOG4J2-2433 Coroutines Support

2020-05-20 Thread GitBox
rocketraman closed pull request #8: URL: https://github.com/apache/logging-log4j-kotlin/pull/8 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [logging-log4j-kotlin] rocketraman commented on pull request #8: LOG4J2-2433 Coroutines Support

2020-05-20 Thread GitBox
rocketraman commented on pull request #8: URL: https://github.com/apache/logging-log4j-kotlin/pull/8#issuecomment-631743569 Rebased and merged to `master`. This is an automated message from the Apache Git Service. To respond

[GitHub] [logging-log4j-kotlin] qoomon commented on pull request #10: feat: static loggers initialisation

2020-05-20 Thread GitBox
qoomon commented on pull request #10: URL: https://github.com/apache/logging-log4j-kotlin/pull/10#issuecomment-631819079 thx guys This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [logging-log4j-kotlin] jvz commented on a change in pull request #12: Initial benchmark module

2020-05-21 Thread GitBox
jvz commented on a change in pull request #12: URL: https://github.com/apache/logging-log4j-kotlin/pull/12#discussion_r428972107 ## File path: log4j-api-kotlin-benchmark/src/main/kotlin/org/apache/logging/log4j/kotlin/benchmark/LoggingBenchmark.kt ## @@ -0,0 +1,66 @@ +package

[GitHub] [logging-log4j-kotlin] rocketraman commented on a change in pull request #12: Initial benchmark module

2020-05-21 Thread GitBox
rocketraman commented on a change in pull request #12: URL: https://github.com/apache/logging-log4j-kotlin/pull/12#discussion_r429032213 ## File path: log4j-api-kotlin-benchmark/src/main/kotlin/org/apache/logging/log4j/kotlin/benchmark/LoggingBenchmark.kt ## @@ -0,0 +1,66 @@

[GitHub] [logging-log4j2] vy merged pull request #335: Import of LogstashLayout as JsonTemplateLayout

2020-05-26 Thread GitBox
vy merged pull request #335: URL: https://github.com/apache/logging-log4j2/pull/335 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [logging-log4net] XenoAmess opened a new pull request #60: fix typo

2020-05-26 Thread GitBox
XenoAmess opened a new pull request #60: URL: https://github.com/apache/logging-log4net/pull/60 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [logging-log4net] garydgregory merged pull request #60: fix typo

2020-05-26 Thread GitBox
garydgregory merged pull request #60: URL: https://github.com/apache/logging-log4net/pull/60 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [logging-log4j2] stepan2271 opened a new pull request #361: LOG4J2-2858: More flexible configuration of WaitStrategy of Disruptor

2020-05-29 Thread GitBox
stepan2271 opened a new pull request #361: URL: https://github.com/apache/logging-log4j2/pull/361 LOG4J2-2858: added additional properties for setting sleepTimeNs and retries parameters of SleepingWaitStrategy This is an aut

[GitHub] [logging-log4j2] gagoman opened a new pull request #362: LOG4J2-2749 - fix JSON Layout output containing empty values while configured otherwise

2020-05-29 Thread GitBox
gagoman opened a new pull request #362: URL: https://github.com/apache/logging-log4j2/pull/362 ### Description `Log4jJsonObjectMapper` [has `JsonInclude.Include.NON_EMPTY` enabled](https://github.com/apache/logging-log4j2/blob/log4j-2.13.3/log4j-core/src/main/java/org/apache/logging/

  1   2   3   4   5   6   7   8   9   10   >