[GitHub] [incubator-superset] ArchanaSekhar20 opened a new issue #9453: Apache-superset exception - click on chart gives exception

2020-04-02 Thread GitBox
ArchanaSekhar20 opened a new issue #9453: Apache-superset exception - click on chart gives exception URL: https://github.com/apache/incubator-superset/issues/9453 "/chart/add" is showing exception cursor.execute(statement, parameters) psycopg2.errors.UndefinedColumn: column

[GitHub] [incubator-superset] villebro opened a new pull request #9451: release: Add support for ZSH in RELEASING and add tagging instructions

2020-04-02 Thread GitBox
villebro opened a new pull request #9451: release: Add support for ZSH in RELEASING and add tagging instructions URL: https://github.com/apache/incubator-superset/pull/9451 ### CATEGORY Choose one - [x] Bug Fix - [x] Enhancement (new features, refinement) - [ ] Refactor

[GitHub] [incubator-superset] codecov-io commented on issue #9451: release: Add support for ZSH in RELEASING and add tagging instructions

2020-04-02 Thread GitBox
codecov-io commented on issue #9451: release: Add support for ZSH in RELEASING and add tagging instructions URL: https://github.com/apache/incubator-superset/pull/9451#issuecomment-607801448 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9451?src=pr=h1) Report >

[GitHub] [incubator-superset] villebro commented on a change in pull request #9403: [query] New, readonly API

2020-04-02 Thread GitBox
villebro commented on a change in pull request #9403: [query] New, readonly API URL: https://github.com/apache/incubator-superset/pull/9403#discussion_r402277498 ## File path: tests/queries/api_tests.py ## @@ -0,0 +1,247 @@ +# Licensed to the Apache Software Foundation

[GitHub] [incubator-superset] Nathandrake01 opened a new issue #9452: How to download more than 1000 rows in a csv

2020-04-02 Thread GitBox
Nathandrake01 opened a new issue #9452: How to download more than 1000 rows in a csv URL: https://github.com/apache/incubator-superset/issues/9452 I am unable to download more than 1000 rows (though table has more than that, even the display is more than that). How to do it. Please

[GitHub] [incubator-superset] villebro commented on a change in pull request #9440: Migrating unique bigNumber(total) controls

2020-04-02 Thread GitBox
villebro commented on a change in pull request #9440: Migrating unique bigNumber(total) controls URL: https://github.com/apache/incubator-superset/pull/9440#discussion_r402255418 ## File path: superset-frontend/src/explore/controlPanels/Shared_BigNumber.js ## @@ -0,0

[GitHub] [incubator-superset] villebro commented on a change in pull request #9418: [mypy] Enforcing typing for superset.dashboards

2020-04-02 Thread GitBox
villebro commented on a change in pull request #9418: [mypy] Enforcing typing for superset.dashboards URL: https://github.com/apache/incubator-superset/pull/9418#discussion_r402267027 ## File path: superset/dashboards/commands/delete.py ## @@ -40,7 +41,7 @@ def

[GitHub] [incubator-superset] villebro commented on a change in pull request #9418: [mypy] Enforcing typing for superset.dashboards

2020-04-02 Thread GitBox
villebro commented on a change in pull request #9418: [mypy] Enforcing typing for superset.dashboards URL: https://github.com/apache/incubator-superset/pull/9418#discussion_r402258288 ## File path: superset/charts/commands/delete.py ## @@ -39,7 +39,7 @@ class

[GitHub] [incubator-superset] villebro commented on a change in pull request #9418: [mypy] Enforcing typing for superset.dashboards

2020-04-02 Thread GitBox
villebro commented on a change in pull request #9418: [mypy] Enforcing typing for superset.dashboards URL: https://github.com/apache/incubator-superset/pull/9418#discussion_r402267368 ## File path: superset/dashboards/commands/update.py ## @@ -43,9 +44,9 @@ def

[GitHub] [incubator-superset] villebro commented on a change in pull request #9418: [mypy] Enforcing typing for superset.dashboards

2020-04-02 Thread GitBox
villebro commented on a change in pull request #9418: [mypy] Enforcing typing for superset.dashboards URL: https://github.com/apache/incubator-superset/pull/9418#discussion_r402264733 ## File path: superset/dashboards/commands/create.py ## @@ -38,7 +39,7 @@ def

[GitHub] [incubator-superset] villebro commented on a change in pull request #9418: [mypy] Enforcing typing for superset.dashboards

2020-04-02 Thread GitBox
villebro commented on a change in pull request #9418: [mypy] Enforcing typing for superset.dashboards URL: https://github.com/apache/incubator-superset/pull/9418#discussion_r402258513 ## File path: superset/charts/commands/update.py ## @@ -46,7 +46,7 @@ def

[GitHub] [incubator-superset] ArchanaSekhar20 commented on issue #7308: Click charts got exception

2020-04-02 Thread GitBox
ArchanaSekhar20 commented on issue #7308: Click charts got exception URL: https://github.com/apache/incubator-superset/issues/7308#issuecomment-607827219 Click on chart give exception still exist. chart/add gives internal server error. please help with a solution

[GitHub] [incubator-superset] francishemingway opened a new issue #9457: Can't log in using 0.36.0rc3

2020-04-02 Thread GitBox
francishemingway opened a new issue #9457: Can't log in using 0.36.0rc3 URL: https://github.com/apache/incubator-superset/issues/9457 A clear and concise description of what the bug is. ### Expected results I'm able to log in. ### Actual results Login page comes up,

[GitHub] [incubator-superset] gaurav1999 commented on a change in pull request #9458: [WIP]: Simplify superset permissions

2020-04-02 Thread GitBox
gaurav1999 commented on a change in pull request #9458: [WIP]: Simplify superset permissions URL: https://github.com/apache/incubator-superset/pull/9458#discussion_r402644586 ## File path: superset/views/annotations.py ## @@ -46,6 +46,9 @@ class AnnotationModelView(

[GitHub] [incubator-superset] gaurav1999 commented on a change in pull request #9458: [WIP]: Simplify superset permissions

2020-04-02 Thread GitBox
gaurav1999 commented on a change in pull request #9458: [WIP]: Simplify superset permissions URL: https://github.com/apache/incubator-superset/pull/9458#discussion_r402644586 ## File path: superset/views/annotations.py ## @@ -46,6 +46,9 @@ class AnnotationModelView(

[GitHub] [incubator-superset] ktmud commented on a change in pull request #9427: feat: Add post processing to QueryObject

2020-04-02 Thread GitBox
ktmud commented on a change in pull request #9427: feat: Add post processing to QueryObject URL: https://github.com/apache/incubator-superset/pull/9427#discussion_r402569893 ## File path: superset/utils/pandas_postprocessing.py ## @@ -0,0 +1,210 @@ +# Licensed to the

[GitHub] [incubator-superset] micimize opened a new pull request #9456: Disable save button when can_add: false, can_overwrite: false

2020-04-02 Thread GitBox
micimize opened a new pull request #9456: Disable save button when can_add: false, can_overwrite: false URL: https://github.com/apache/incubator-superset/pull/9456 fix #8302 (except the hotkey part) I put off fixing the hotkey copy because it isn't quite accurate anyways. For

[GitHub] [incubator-superset] francishemingway commented on issue #9457: Can't log in using 0.36.0rc3

2020-04-02 Thread GitBox
francishemingway commented on issue #9457: Can't log in using 0.36.0rc3 URL: https://github.com/apache/incubator-superset/issues/9457#issuecomment-608117137 @villebro I tested the latest release candidate and I got stuck here.

[GitHub] [incubator-superset] rusackas opened a new pull request #9454: Migrating NVD3 Area's stacked_style config

2020-04-02 Thread GitBox
rusackas opened a new pull request #9454: Migrating NVD3 Area's stacked_style config URL: https://github.com/apache/incubator-superset/pull/9454 ### CATEGORY Choose one - [ ] Bug Fix - [ ] Enhancement (new features, refinement) - [x] Refactor - [ ] Add tests - [ ]

[GitHub] [incubator-superset] villebro commented on a change in pull request #9427: feat: Add post processing to QueryObject

2020-04-02 Thread GitBox
villebro commented on a change in pull request #9427: feat: Add post processing to QueryObject URL: https://github.com/apache/incubator-superset/pull/9427#discussion_r402564275 ## File path: superset/utils/pandas_postprocessing.py ## @@ -0,0 +1,210 @@ +# Licensed to the

[GitHub] [incubator-superset] gaurav1999 commented on a change in pull request #9458: [WIP]: Simplify superset permissions

2020-04-02 Thread GitBox
gaurav1999 commented on a change in pull request #9458: [WIP]: Simplify superset permissions URL: https://github.com/apache/incubator-superset/pull/9458#discussion_r402644192 ## File path: superset/views/chart/views.py ## @@ -33,6 +33,7 @@ class SliceModelView(

[GitHub] [incubator-superset] ktmud commented on a change in pull request #9378: chore: bump black to 19.10b0 and mypy to 0.770

2020-04-02 Thread GitBox
ktmud commented on a change in pull request #9378: chore: bump black to 19.10b0 and mypy to 0.770 URL: https://github.com/apache/incubator-superset/pull/9378#discussion_r402694035 ## File path: superset/views/core.py ## @@ -188,7 +188,10 @@ def check_datasource_perms(

[GitHub] [incubator-superset] villebro commented on a change in pull request #9427: feat: Add post processing to QueryObject

2020-04-02 Thread GitBox
villebro commented on a change in pull request #9427: feat: Add post processing to QueryObject URL: https://github.com/apache/incubator-superset/pull/9427#discussion_r402564275 ## File path: superset/utils/pandas_postprocessing.py ## @@ -0,0 +1,210 @@ +# Licensed to the

[GitHub] [incubator-superset] ktmud commented on a change in pull request #9427: feat: Add post processing to QueryObject

2020-04-02 Thread GitBox
ktmud commented on a change in pull request #9427: feat: Add post processing to QueryObject URL: https://github.com/apache/incubator-superset/pull/9427#discussion_r402570228 ## File path: superset/utils/pandas_postprocessing.py ## @@ -0,0 +1,210 @@ +# Licensed to the

[GitHub] [incubator-superset] gaurav1999 commented on a change in pull request #9458: [WIP]: Simplify superset permissions

2020-04-02 Thread GitBox
gaurav1999 commented on a change in pull request #9458: [WIP]: Simplify superset permissions URL: https://github.com/apache/incubator-superset/pull/9458#discussion_r402643623 ## File path: superset/views/schedules.py ## @@ -47,6 +47,9 @@ class EmailScheduleView(

[GitHub] [incubator-superset] rusackas opened a new pull request #9455: [WiP] Migrating shared DeckGL controls

2020-04-02 Thread GitBox
rusackas opened a new pull request #9455: [WiP] Migrating shared DeckGL controls URL: https://github.com/apache/incubator-superset/pull/9455 ### CATEGORY Choose one - [ ] Bug Fix - [ ] Enhancement (new features, refinement) - [x] Refactor - [ ] Add tests - [ ]

[GitHub] [incubator-superset] ktmud commented on a change in pull request #9378: chore: bump black to 19.10b0 and mypy to 0.770

2020-04-02 Thread GitBox
ktmud commented on a change in pull request #9378: chore: bump black to 19.10b0 and mypy to 0.770 URL: https://github.com/apache/incubator-superset/pull/9378#discussion_r402694528 ## File path: superset/views/core.py ## @@ -188,7 +188,10 @@ def check_datasource_perms(

[GitHub] [incubator-superset] gaurav1999 commented on a change in pull request #7501: [WiP] Simplify Superset's permissions

2020-04-02 Thread GitBox
gaurav1999 commented on a change in pull request #7501: [WiP] Simplify Superset's permissions URL: https://github.com/apache/incubator-superset/pull/7501#discussion_r402627851 ## File path: superset/views/core.py ## @@ -1175,11 +1186,9 @@ def explore(self,

[GitHub] [incubator-superset] ktmud commented on issue #9378: chore: bump black to 19.10b0 and mypy to 0.770

2020-04-02 Thread GitBox
ktmud commented on issue #9378: chore: bump black to 19.10b0 and mypy to 0.770 URL: https://github.com/apache/incubator-superset/pull/9378#issuecomment-608178113 > @ktmud let me know if you need help with the `mypy` work. I'm happy to create a separate PR which bumps the `mypy` version

[GitHub] [incubator-superset] ktmud commented on a change in pull request #9378: chore: bump black to 19.10b0 and mypy to 0.770

2020-04-02 Thread GitBox
ktmud commented on a change in pull request #9378: chore: bump black to 19.10b0 and mypy to 0.770 URL: https://github.com/apache/incubator-superset/pull/9378#discussion_r402690756 ## File path: tests/superset_test_config.py ## @@ -14,9 +14,10 @@ # KIND, either express

[GitHub] [incubator-superset] gaurav1999 opened a new pull request #9458: [WIP]: Simplify superset permissions

2020-04-02 Thread GitBox
gaurav1999 opened a new pull request #9458: [WIP]: Simplify superset permissions URL: https://github.com/apache/incubator-superset/pull/9458 Coming from #7501 . This is an automated message from the Apache Git Service. To

[GitHub] [incubator-superset] gaurav1999 commented on a change in pull request #9458: [WIP]: Simplify superset permissions

2020-04-02 Thread GitBox
gaurav1999 commented on a change in pull request #9458: [WIP]: Simplify superset permissions URL: https://github.com/apache/incubator-superset/pull/9458#discussion_r402645003 ## File path: superset/connectors/sqla/views.py ## @@ -167,6 +170,9 @@ class

[GitHub] [incubator-superset] ktmud commented on a change in pull request #9378: chore: bump black to 19.10b0 and mypy to 0.770

2020-04-02 Thread GitBox
ktmud commented on a change in pull request #9378: chore: bump black to 19.10b0 and mypy to 0.770 URL: https://github.com/apache/incubator-superset/pull/9378#discussion_r402693030 ## File path: superset/connectors/druid/models.py ## @@ -941,23 +941,24 @@ def

[GitHub] [incubator-superset] rusackas commented on issue #9445: Migrating unique NVD3 viz controls

2020-04-02 Thread GitBox
rusackas commented on issue #9445: Migrating unique NVD3 viz controls URL: https://github.com/apache/incubator-superset/pull/9445#issuecomment-608089062 > @kristw something puzzling about this one... > > As you can see I added/reverted a commit a couple of times. Long story short,

[GitHub] [incubator-superset] gaurav1999 edited a comment on issue #9458: [WIP]: Simplify superset permissions

2020-04-02 Thread GitBox
gaurav1999 edited a comment on issue #9458: [WIP]: Simplify superset permissions URL: https://github.com/apache/incubator-superset/pull/9458#issuecomment-608133313 Right now, I can see the permissions which I added/edited but problem is, the older permissions still exists, they are not

[GitHub] [incubator-superset] gaurav1999 commented on issue #9458: [WIP]: Simplify superset permissions

2020-04-02 Thread GitBox
gaurav1999 commented on issue #9458: [WIP]: Simplify superset permissions URL: https://github.com/apache/incubator-superset/pull/9458#issuecomment-608132955 @mistercrunch , I wish to finish the TODO's in #7501 , also will remove my author name from commit, as this is your work. If you say

[GitHub] [incubator-superset] gaurav1999 commented on issue #9458: [WIP]: Simplify superset permissions

2020-04-02 Thread GitBox
gaurav1999 commented on issue #9458: [WIP]: Simplify superset permissions URL: https://github.com/apache/incubator-superset/pull/9458#issuecomment-608133313 Right now, I can see the permissions which I added/edited but problem is, the older permissions still exists, they are not removed

[GitHub] [incubator-superset] john-bodley commented on a change in pull request #9378: chore: bump black to 19.10b0 and mypy to 0.770

2020-04-02 Thread GitBox
john-bodley commented on a change in pull request #9378: chore: bump black to 19.10b0 and mypy to 0.770 URL: https://github.com/apache/incubator-superset/pull/9378#discussion_r402689857 ## File path: tests/superset_test_config_sqllab_backend_persist.py ## @@ -15,10

[GitHub] [incubator-superset] john-bodley commented on a change in pull request #9378: chore: bump black to 19.10b0 and mypy to 0.770

2020-04-02 Thread GitBox
john-bodley commented on a change in pull request #9378: chore: bump black to 19.10b0 and mypy to 0.770 URL: https://github.com/apache/incubator-superset/pull/9378#discussion_r402689524 ## File path: superset/views/core.py ## @@ -188,7 +188,10 @@ def

[GitHub] [incubator-superset] john-bodley commented on a change in pull request #9378: chore: bump black to 19.10b0 and mypy to 0.770

2020-04-02 Thread GitBox
john-bodley commented on a change in pull request #9378: chore: bump black to 19.10b0 and mypy to 0.770 URL: https://github.com/apache/incubator-superset/pull/9378#discussion_r402688153 ## File path: superset/connectors/druid/models.py ## @@ -941,23 +941,24 @@ def

[GitHub] [incubator-superset] john-bodley commented on a change in pull request #9378: chore: bump black to 19.10b0 and mypy to 0.770

2020-04-02 Thread GitBox
john-bodley commented on a change in pull request #9378: chore: bump black to 19.10b0 and mypy to 0.770 URL: https://github.com/apache/incubator-superset/pull/9378#discussion_r402689813 ## File path: tests/superset_test_config.py ## @@ -14,9 +14,10 @@ # KIND, either

[GitHub] [incubator-superset] codecov-io edited a comment on issue #9445: Migrating unique NVD3 viz controls

2020-04-02 Thread GitBox
codecov-io edited a comment on issue #9445: Migrating unique NVD3 viz controls URL: https://github.com/apache/incubator-superset/pull/9445#issuecomment-607617786 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9445?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] ktmud commented on a change in pull request #9378: chore: bump black to 19.10b0 and mypy to 0.770

2020-04-02 Thread GitBox
ktmud commented on a change in pull request #9378: chore: bump black to 19.10b0 and mypy to 0.770 URL: https://github.com/apache/incubator-superset/pull/9378#discussion_r402693030 ## File path: superset/connectors/druid/models.py ## @@ -941,23 +941,24 @@ def

[GitHub] [incubator-superset] codecov-io commented on issue #9455: [WiP] Migrating shared DeckGL controls

2020-04-02 Thread GitBox
codecov-io commented on issue #9455: [WiP] Migrating shared DeckGL controls URL: https://github.com/apache/incubator-superset/pull/9455#issuecomment-608243567 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9455?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] ArchanaSekhar20 commented on issue #9453: Apache-superset exception - click on chart gives exception

2020-04-02 Thread GitBox
ArchanaSekhar20 commented on issue #9453: Apache-superset exception - click on chart gives exception URL: https://github.com/apache/incubator-superset/issues/9453#issuecomment-608236175 Still am facing the issue . please help

[GitHub] [incubator-superset] jayhjha commented on issue #6930: How to configure a datasource Extra parameter?

2020-04-02 Thread GitBox
jayhjha commented on issue #6930: How to configure a datasource Extra parameter? URL: https://github.com/apache/incubator-superset/issues/6930#issuecomment-608241231 @lhyundeadsoul were you able to figure this out? I'm having the same issue on Superset v0.35.1. When I use

[GitHub] [incubator-superset] codecov-io commented on issue #9378: chore: bump black to 19.10b0 and mypy to 0.770

2020-04-02 Thread GitBox
codecov-io commented on issue #9378: chore: bump black to 19.10b0 and mypy to 0.770 URL: https://github.com/apache/incubator-superset/pull/9378#issuecomment-608197128 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9378?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] codecov-io edited a comment on issue #9445: [WiP] Migrating NVD3 viz controls, take 2

2020-04-02 Thread GitBox
codecov-io edited a comment on issue #9445: [WiP] Migrating NVD3 viz controls, take 2 URL: https://github.com/apache/incubator-superset/pull/9445#issuecomment-607617786 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9445?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] john-bodley commented on a change in pull request #9444: Implement dttm column configuration through db extra config

2020-04-02 Thread GitBox
john-bodley commented on a change in pull request #9444: Implement dttm column configuration through db extra config URL: https://github.com/apache/incubator-superset/pull/9444#discussion_r402070128 ## File path: docs/installation.rst ## @@ -1379,8 +1379,14 @@ Prior to

[GitHub] [incubator-superset] john-bodley commented on a change in pull request #9444: Implement dttm column configuration through db extra config

2020-04-02 Thread GitBox
john-bodley commented on a change in pull request #9444: Implement dttm column configuration through db extra config URL: https://github.com/apache/incubator-superset/pull/9444#discussion_r402070128 ## File path: docs/installation.rst ## @@ -1379,8 +1379,14 @@ Prior to

[GitHub] [incubator-superset] stale[bot] closed issue #9022: Internet Explorer 11 does not load Apache superset URL

2020-04-02 Thread GitBox
stale[bot] closed issue #9022: Internet Explorer 11 does not load Apache superset URL URL: https://github.com/apache/incubator-superset/issues/9022 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-superset] villebro commented on issue #9366: deprecate groupby controls in query_obj

2020-04-02 Thread GitBox
villebro commented on issue #9366: deprecate groupby controls in query_obj URL: https://github.com/apache/incubator-superset/pull/9366#issuecomment-607652322 @john-bodley that's a good idea, I'll look into adding a feature flag for these changes.

[GitHub] [incubator-superset] Nathandrake01 opened a new issue #9447: How to increase max rows download in csv (not retrieval but download)

2020-04-02 Thread GitBox
Nathandrake01 opened a new issue #9447: How to increase max rows download in csv (not retrieval but download) URL: https://github.com/apache/incubator-superset/issues/9447 I am unable to download more than 1000 rows (though table has more than that, even the display is more than that).

[GitHub] [incubator-superset] john-bodley commented on a change in pull request #9444: Implement dttm column configuration through db extra config

2020-04-02 Thread GitBox
john-bodley commented on a change in pull request #9444: Implement dttm column configuration through db extra config URL: https://github.com/apache/incubator-superset/pull/9444#discussion_r402066069 ## File path: docs/installation.rst ## @@ -1379,8 +1379,14 @@ Prior to

[GitHub] [incubator-superset] john-bodley commented on a change in pull request #9444: Implement dttm column configuration through db extra config

2020-04-02 Thread GitBox
john-bodley commented on a change in pull request #9444: Implement dttm column configuration through db extra config URL: https://github.com/apache/incubator-superset/pull/9444#discussion_r402066069 ## File path: docs/installation.rst ## @@ -1379,8 +1379,14 @@ Prior to

[GitHub] [incubator-superset] stevensotelo commented on issue #8983: Docker build image from Windows

2020-04-02 Thread GitBox
stevensotelo commented on issue #8983: Docker build image from Windows URL: https://github.com/apache/incubator-superset/issues/8983#issuecomment-607896520 @willbarrett, sure, how I can contribute? This is an automated

[GitHub] [incubator-superset] jayhjha opened a new issue #9448: Customizing User model to add more details

2020-04-02 Thread GitBox
jayhjha opened a new issue #9448: Customizing User model to add more details URL: https://github.com/apache/incubator-superset/issues/9448 The user model in Superset only contains the following fields: ``` username firstName lastName userId isActive email ``` If I

[GitHub] [incubator-superset] jayhjha opened a new issue #9449: Timestamps are only displayed in UTC and not in local timezone

2020-04-02 Thread GitBox
jayhjha opened a new issue #9449: Timestamps are only displayed in UTC and not in local timezone URL: https://github.com/apache/incubator-superset/issues/9449 All timestamps are only displayed in UTC and not in the local timezone. I found this issue from 2 years ago regarding this, but

[GitHub] [incubator-superset] mohan770 commented on issue #2524: Are there any ways to set the color for the chart specifically

2020-04-02 Thread GitBox
mohan770 commented on issue #2524: Are there any ways to set the color for the chart specifically URL: https://github.com/apache/incubator-superset/issues/2524#issuecomment-607941532 HI @mistercrunch I have tried ur method but it is showing an error has occurred I have given exactly

[GitHub] [incubator-superset] willbarrett commented on issue #8983: Docker build image from Windows

2020-04-02 Thread GitBox
willbarrett commented on issue #8983: Docker build image from Windows URL: https://github.com/apache/incubator-superset/issues/8983#issuecomment-607944941 @stevensotelo glad you're interested! Currently, most Apache projects use Travis for CI. Travis has limited support for Windows

[GitHub] [incubator-superset] rusackas merged pull request #9446: Migrating unique DeckGL controls

2020-04-02 Thread GitBox
rusackas merged pull request #9446: Migrating unique DeckGL controls URL: https://github.com/apache/incubator-superset/pull/9446 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-superset] willbarrett commented on issue #9447: How to increase max rows download in csv (not retrieval but download)

2020-04-02 Thread GitBox
willbarrett commented on issue #9447: How to increase max rows download in csv (not retrieval but download) URL: https://github.com/apache/incubator-superset/issues/9447#issuecomment-607952493 @Nathandrake01 if you're downloading via SQL Lab, you'll want to set a LIMIT on the query.

[GitHub] [incubator-superset] willbarrett commented on issue #8302: Chart "save" behaviors not permission controlled

2020-04-02 Thread GitBox
willbarrett commented on issue #8302: Chart "save" behaviors not permission controlled URL: https://github.com/apache/incubator-superset/issues/8302#issuecomment-607957503 Awesome, thanks! This is an automated message from

[GitHub] [incubator-superset] rusackas commented on issue #9445: Migrating unique NVD3 viz controls

2020-04-02 Thread GitBox
rusackas commented on issue #9445: Migrating unique NVD3 viz controls URL: https://github.com/apache/incubator-superset/pull/9445#issuecomment-607967275 @kristw something puzzling about this one... As you can see I added/reverted a commit a couple of times. Long story short, [this

[GitHub] [incubator-superset] john-bodley commented on issue #9444: Implement dttm column configuration through db extra config

2020-04-02 Thread GitBox
john-bodley commented on issue #9444: Implement dttm column configuration through db extra config URL: https://github.com/apache/incubator-superset/pull/9444#issuecomment-607943599 @bkyryliuk one other question I had, and maybe the community should weigh in here, is whether i) defaults

[GitHub] [incubator-superset] rusackas commented on a change in pull request #9440: Migrating unique bigNumber(total) controls

2020-04-02 Thread GitBox
rusackas commented on a change in pull request #9440: Migrating unique bigNumber(total) controls URL: https://github.com/apache/incubator-superset/pull/9440#discussion_r402446690 ## File path: superset-frontend/src/explore/controlPanels/Shared_BigNumber.js ## @@ -0,0

[GitHub] [incubator-superset] rusackas closed pull request #9407: Migrating unique NVD3 controls (phase 1)

2020-04-02 Thread GitBox
rusackas closed pull request #9407: Migrating unique NVD3 controls (phase 1) URL: https://github.com/apache/incubator-superset/pull/9407 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-superset] rusackas commented on issue #9407: Migrating unique NVD3 controls (phase 1)

2020-04-02 Thread GitBox
rusackas commented on issue #9407: Migrating unique NVD3 controls (phase 1) URL: https://github.com/apache/incubator-superset/pull/9407#issuecomment-607952229 Closing in favor of #9445 This is an automated message from the

[GitHub] [incubator-superset] willbarrett commented on a change in pull request #9444: Implement dttm column configuration through db extra config

2020-04-02 Thread GitBox
willbarrett commented on a change in pull request #9444: Implement dttm column configuration through db extra config URL: https://github.com/apache/incubator-superset/pull/9444#discussion_r402461099 ## File path: tests/core_tests.py ## @@ -1171,6 +1171,78 @@ def

[GitHub] [incubator-superset] willbarrett commented on a change in pull request #9444: Implement dttm column configuration through db extra config

2020-04-02 Thread GitBox
willbarrett commented on a change in pull request #9444: Implement dttm column configuration through db extra config URL: https://github.com/apache/incubator-superset/pull/9444#discussion_r402460714 ## File path: tests/core_tests.py ## @@ -1171,6 +1171,78 @@ def

[GitHub] [incubator-superset] rusackas commented on issue #9440: Migrating unique bigNumber(total) controls

2020-04-02 Thread GitBox
rusackas commented on issue #9440: Migrating unique bigNumber(total) controls URL: https://github.com/apache/incubator-superset/pull/9440#issuecomment-607965638 > Just a small question/comment, in general LGTM. I like the approach of sharing commonly used controls somehow if they truly

[GitHub] [incubator-superset] rusackas merged pull request #9356: Enforcing linting of LESS

2020-04-02 Thread GitBox
rusackas merged pull request #9356: Enforcing linting of LESS URL: https://github.com/apache/incubator-superset/pull/9356 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-superset] micimize commented on issue #8302: Chart "save" behaviors not permission controlled

2020-04-02 Thread GitBox
micimize commented on issue #8302: Chart "save" behaviors not permission controlled URL: https://github.com/apache/incubator-superset/issues/8302#issuecomment-607955594 @willbarrett sure! I [narrowed the commit

[GitHub] [incubator-superset] rusackas edited a comment on issue #9445: Migrating unique NVD3 viz controls

2020-04-02 Thread GitBox
rusackas edited a comment on issue #9445: Migrating unique NVD3 viz controls URL: https://github.com/apache/incubator-superset/pull/9445#issuecomment-607967275 @kristw something puzzling about this one... As you can see I added/reverted a commit a couple of times. Long story short,

[GitHub] [incubator-superset] gaurav1999 commented on issue #9452: How to download more than 1000 rows in a csv

2020-04-02 Thread GitBox
gaurav1999 commented on issue #9452: How to download more than 1000 rows in a csv URL: https://github.com/apache/incubator-superset/issues/9452#issuecomment-607969425 Working for me fine here, wondering if you can share the logs. For example when you superset load_example you get this

[GitHub] [incubator-superset] toop opened a new issue #9450: npm run prod error at 0.36.0rc3

2020-04-02 Thread GitBox
toop opened a new issue #9450: npm run prod error at 0.36.0rc3 URL: https://github.com/apache/incubator-superset/issues/9450 superset version: 0.36.rc2 python version: 3.7.7 node.js version: 12.16.1 npm version: 6.11.3 F:\superset-dev\superset-frontend>npm run prod >

[GitHub] [incubator-superset] codecov-io commented on issue #9440: Migrating unique bigNumber(total) controls

2020-04-02 Thread GitBox
codecov-io commented on issue #9440: Migrating unique bigNumber(total) controls URL: https://github.com/apache/incubator-superset/pull/9440#issuecomment-607990217 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9440?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] etr2460 commented on a change in pull request #9444: Implement dttm column configuration through db extra config

2020-04-02 Thread GitBox
etr2460 commented on a change in pull request #9444: Implement dttm column configuration through db extra config URL: https://github.com/apache/incubator-superset/pull/9444#discussion_r402511181 ## File path: superset/connectors/sqla/models.py ## @@ -145,6 +146,17 @@

[GitHub] [incubator-superset] john-bodley commented on issue #9427: feat: Add post processing to QueryObject

2020-04-02 Thread GitBox
john-bodley commented on issue #9427: feat: Add post processing to QueryObject URL: https://github.com/apache/incubator-superset/pull/9427#issuecomment-608001520 cc @ktmud This is an automated message from the Apache Git

[GitHub] [incubator-superset] rusackas merged pull request #9440: Migrating unique bigNumber(total) controls

2020-04-02 Thread GitBox
rusackas merged pull request #9440: Migrating unique bigNumber(total) controls URL: https://github.com/apache/incubator-superset/pull/9440 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-superset] codecov-io edited a comment on issue #9451: release: Add support for ZSH in RELEASING and add tagging instructions

2020-04-02 Thread GitBox
codecov-io edited a comment on issue #9451: release: Add support for ZSH in RELEASING and add tagging instructions URL: https://github.com/apache/incubator-superset/pull/9451#issuecomment-607801448 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9451?src=pr=h1) Report

[GitHub] [incubator-superset] ktmud commented on a change in pull request #9427: feat: Add post processing to QueryObject

2020-04-02 Thread GitBox
ktmud commented on a change in pull request #9427: feat: Add post processing to QueryObject URL: https://github.com/apache/incubator-superset/pull/9427#discussion_r402554088 ## File path: superset/utils/pandas_postprocessing.py ## @@ -0,0 +1,210 @@ +# Licensed to the