[GitHub] [superset] codecov[bot] edited a comment on pull request #15146: fix(native-filters): Don't send unnecessary PUT request on dashboard render

codecov[bot] edited a comment on pull request #15146: URL: https://github.com/apache/superset/pull/15146#issuecomment-860587822 #

[GitHub] [superset] villebro opened a new pull request #15149: feat(dao): admin can remove self from object owners

villebro opened a new pull request #15149: URL: https://github.com/apache/superset/pull/15149 ### SUMMARY Currently it is impossible for users to remove themselves from the list of users. This is to avoid the risk of a user mistakenly being "locked out" of a chart/dashboard/etc. This

[GitHub] [superset] zhaoyongjie merged pull request #15139: fix: improve dashboard fullscreen text

zhaoyongjie merged pull request #15139: URL: https://github.com/apache/superset/pull/15139 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [superset] kgabryje opened a new pull request #15146: fix(native-filters): Don't send unnecessary PUT request on dashboard render

kgabryje opened a new pull request #15146: URL: https://github.com/apache/superset/pull/15146 ### SUMMARY When dashboard first renders, we calculate tabs and charts in scope of each native filter. Before, we used to send a PUT request with the results, which also modified dashboard's

[GitHub] [superset] kgabryje commented on a change in pull request #15146: fix(native-filters): Don't send unnecessary PUT request on dashboard render

kgabryje commented on a change in pull request #15146: URL: https://github.com/apache/superset/pull/15146#discussion_r650876813 ## File path: superset-frontend/src/dashboard/actions/nativeFilters.ts ## @@ -49,6 +49,11 @@ export interface SetFilterConfigFail { type: typeof

[GitHub] [superset] michael-s-molina commented on issue #14791: [native filter] filter component can not force refresh options

michael-s-molina commented on issue #14791: URL: https://github.com/apache/superset/issues/14791#issuecomment-860652318 > think the best solution here is adding a  type of button next to the filter to make it possible to Did you mean to create a button specifically for this page?

[GitHub] [superset] villebro commented on issue #14791: [native filter] filter component can not force refresh options

villebro commented on issue #14791: URL: https://github.com/apache/superset/issues/14791#issuecomment-860728371 Ah, right. If we add it as a native feature, we need to make sure we make it possible to pad selects that don't have the refresh enabled to align them with others that have it,

[GitHub] [superset] aonurdemir opened a new issue #15144: Sort descending checkbox in line chart is not working as expected with druid database

aonurdemir opened a new issue #15144: URL: https://github.com/apache/superset/issues/15144 Although I am not checking `sort by descending` checkbox, it sorts series limit data by desc. ### Expected results It is expected to be sorted by asc and query should be like below:

[GitHub] [superset] codecov[bot] commented on pull request #15139: fix: improve dashboard fullscreen text

codecov[bot] commented on pull request #15139: URL: https://github.com/apache/superset/pull/15139#issuecomment-860555609 #

[GitHub] [superset] villebro commented on issue #15125: [native-filters] interacting w native filter sidebar should not change dashboard ownership

villebro commented on issue #15125: URL: https://github.com/apache/superset/issues/15125#issuecomment-860610412 Re-adding the label and issue to the native filter board due to the problem being related to a native filter feature PR (apologies for the label/project board flip-flop) --

[GitHub] [superset] codecov[bot] edited a comment on pull request #15146: fix(native-filters): Don't send unnecessary PUT request on dashboard render

codecov[bot] edited a comment on pull request #15146: URL: https://github.com/apache/superset/pull/15146#issuecomment-860587822 #

[GitHub] [superset] kgabryje closed issue #15125: [native-filters] interacting w native filter sidebar should not change dashboard ownership

kgabryje closed issue #15125: URL: https://github.com/apache/superset/issues/15125 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [superset] kgabryje merged pull request #15146: fix(native-filters): Don't send unnecessary PUT request on dashboard render

kgabryje merged pull request #15146: URL: https://github.com/apache/superset/pull/15146 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [superset] kgabryje edited a comment on pull request #15115: chore: Improves the native filters bar layout

kgabryje edited a comment on pull request #15115: URL: https://github.com/apache/superset/pull/15115#issuecomment-860693649 Wow, that looks SO much better than before! Thanks for that change. Could we move the "expand" icon up when filters are collapsed? I don't think it should change

[GitHub] [superset] pritypriya25 commented on issue #15118: How to compute and cache a screenshot using rest api in superset

pritypriya25 commented on issue #15118: URL: https://github.com/apache/superset/issues/15118#issuecomment-860698820 thank you @zhaoyongjie . Now I know what is the slice id. But still I can't get my output for from hitting the api chart/{pk}/cache_screenshot.

[GitHub] [superset] pritypriya25 edited a comment on issue #15118: How to compute and cache a screenshot using rest api in superset

pritypriya25 edited a comment on issue #15118: URL: https://github.com/apache/superset/issues/15118#issuecomment-860698820 thank you @zhaoyongjie . Now I know what is the slice id. But still I can't get my output from hitting the api chart/{pk}/cache_screenshot.

[GitHub] [superset] codecov[bot] commented on pull request #15146: fix(native-filters): Don't send unnecessary PUT request on dashboard render

codecov[bot] commented on pull request #15146: URL: https://github.com/apache/superset/pull/15146#issuecomment-860587822 #

[GitHub] [superset] michael-s-molina commented on pull request #15117: feat(native-filters): add optional time col to time range

michael-s-molina commented on pull request #15117: URL: https://github.com/apache/superset/pull/15117#issuecomment-860659082 One nit: the sort type and sort metric have different widths. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [superset] kgabryje commented on a change in pull request #15141: chore: Scrolls top when opening a select filter

kgabryje commented on a change in pull request #15141: URL: https://github.com/apache/superset/pull/15141#discussion_r650949325 ## File path: superset-frontend/src/filters/components/Select/SelectFilterPlugin.tsx ## @@ -275,14 +292,15 @@ export default function

[GitHub] [superset] villebro commented on pull request #15115: chore: Improves the native filters bar layout

villebro commented on pull request #15115: URL: https://github.com/apache/superset/pull/15115#issuecomment-860692386 The expand arrow here looks slightly lonely after the "Superset" header has scrolled out of view: 1) unscrolled (looks ok):

[GitHub] [superset] krish7919 commented on issue #6834: Apache Reverse Proxy

krish7919 commented on issue #6834: URL: https://github.com/apache/superset/issues/6834#issuecomment-860692234 Dupe of https://github.com/apache/superset/issues/15089 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [superset] villebro commented on pull request #15115: chore: Improves the native filters bar layout

villebro commented on pull request #15115: URL: https://github.com/apache/superset/pull/15115#issuecomment-860698170 When the "Superset" header has scrolled out of view, a grey area is exposed on the bottom. This grey space could potentially show additional native filters that are now

[GitHub] [superset] villebro commented on issue #14791: [native filter] filter component can not force refresh options

villebro commented on issue #14791: URL: https://github.com/apache/superset/issues/14791#issuecomment-860711399 > > think the best solution here is adding a  type of button next to the filter to make it possible to > > Did you mean to create a button specifically for this page? How

[GitHub] [superset] kgabryje edited a comment on pull request #14933: feat(dashboard/native-filters): Hide filters out of scope of current tab

kgabryje edited a comment on pull request #14933: URL: https://github.com/apache/superset/pull/14933#issuecomment-860579891 @graceguo-supercat Thank you for raising those issues and providing context. PR https://github.com/apache/superset/pull/15146 solves part of the problem, another

[GitHub] [superset] MatanBobi opened a new pull request #15147: refactor: remove side effect in render from calednarframe

MatanBobi opened a new pull request #15147: URL: https://github.com/apache/superset/pull/15147 ### SUMMARY The code before was creating a side effect within the render phase which isn't recommended. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF No changes. ### TESTING

[GitHub] [superset] beltramem opened a new issue #15148: Adding custom viz plugin bug

beltramem opened a new issue #15148: URL: https://github.com/apache/superset/issues/15148 I add trubles to install a custom viz plugin. I followed the documentation here : https://superset.apache.org/docs/installation/building-custom-viz-plugins every steps are looking good and I

[GitHub] [superset] michael-s-molina commented on issue #14791: [native filter] filter component can not force refresh options

michael-s-molina commented on issue #14791: URL: https://github.com/apache/superset/issues/14791#issuecomment-860723849 > > > think the best solution here is adding a  type of button next to the filter to make it possible to > > > > > > Did you mean to create a button

[GitHub] [superset] codecov[bot] edited a comment on pull request #15046: feat(dashboard): Let users download full CSV of a table

codecov[bot] edited a comment on pull request #15046: URL: https://github.com/apache/superset/pull/15046#issuecomment-859152185 #

[GitHub] [superset] stevensuting commented on issue #8322: An unknown error occurred. Please contact your Superset administrator

stevensuting commented on issue #8322: URL: https://github.com/apache/superset/issues/8322#issuecomment-860530701 @dpgaspar This issue still seems to persist in v1.1.0 **Logs** It does a series of `INFO:superset.datasets.commands.importers.v0:Importing col` successfully Then

[GitHub] [superset] codecov[bot] edited a comment on pull request #15146: fix(native-filters): Don't send unnecessary PUT request on dashboard render

codecov[bot] edited a comment on pull request #15146: URL: https://github.com/apache/superset/pull/15146#issuecomment-860587822 #

[GitHub] [superset] michael-s-molina commented on a change in pull request #15117: feat(native-filters): add optional time col to time range

michael-s-molina commented on a change in pull request #15117: URL: https://github.com/apache/superset/pull/15117#discussion_r650916244 ## File path: superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/ColumnSelect.test.tsx ## @@

[GitHub] [superset] kgabryje merged pull request #15140: fix: Filter overlay in dashboard when scrolling

kgabryje merged pull request #15140: URL: https://github.com/apache/superset/pull/15140 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [superset] kgabryje closed issue #14828: [native-filter]Filter indicator overlay in Dashboard on scroll

kgabryje closed issue #14828: URL: https://github.com/apache/superset/issues/14828 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [superset] kanchansapkota27 opened a new issue #15145: Seperate login page layout based on roles

kanchansapkota27 opened a new issue #15145: URL: https://github.com/apache/superset/issues/15145 It would be better if users can set the landing page based on which role is logging in. Suppose a public or gamma user not being able to see all the recent activities and charts along with

[GitHub] [superset] kgabryje commented on pull request #14933: feat(dashboard/native-filters): Hide filters out of scope of current tab

kgabryje commented on pull request #14933: URL: https://github.com/apache/superset/pull/14933#issuecomment-860579891 @graceguo-supercat Thank you for raising those issues. PR https://github.com/apache/superset/pull/15146 solves part of the problem, another part will be fixed in a separate

[GitHub] [superset] villebro commented on a change in pull request #15146: fix(native-filters): Don't send unnecessary PUT request on dashboard render

villebro commented on a change in pull request #15146: URL: https://github.com/apache/superset/pull/15146#discussion_r650867699 ## File path: superset-frontend/src/dashboard/actions/nativeFilters.ts ## @@ -49,6 +49,11 @@ export interface SetFilterConfigFail { type: typeof

[GitHub] [superset] kgabryje commented on pull request #15115: chore: Improves the native filters bar layout

kgabryje commented on pull request #15115: URL: https://github.com/apache/superset/pull/15115#issuecomment-860693649 Wow, that looks SO much better than before! Thanks for that change. Could we move the "expand" icon up when filters are collapsed? I don't think it should change it's

[GitHub] [superset] michael-s-molina commented on a change in pull request #15141: chore: Scrolls top when opening a select filter

michael-s-molina commented on a change in pull request #15141: URL: https://github.com/apache/superset/pull/15141#discussion_r650989455 ## File path: superset-frontend/src/filters/components/Select/SelectFilterPlugin.tsx ## @@ -275,14 +292,15 @@ export default function

[GitHub] [superset] pkdotson closed issue #14887: [home page] favorite tab in dashboard section is not showing favorite dashboard

pkdotson closed issue #14887: URL: https://github.com/apache/superset/issues/14887 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [superset] codecov[bot] edited a comment on pull request #15150: fix(db-connection-ui): Additional Query Parameters render

codecov[bot] edited a comment on pull request #15150: URL: https://github.com/apache/superset/pull/15150#issuecomment-860779500 #

[GitHub] [superset] betodealmeida commented on a change in pull request #15151: feat: adding server-side validation and unmasked password on create

betodealmeida commented on a change in pull request #15151: URL: https://github.com/apache/superset/pull/15151#discussion_r651118522 ## File path: superset/db_engine_specs/base.py ## @@ -1438,7 +1438,7 @@ def validate_parameters( return errors port =

[GitHub] [superset] betodealmeida edited a comment on pull request #15151: feat: adding server-side validation and unmasked password on create

betodealmeida edited a comment on pull request #15151: URL: https://github.com/apache/superset/pull/15151#issuecomment-860861291 > @betodealmeida the best way of doing that, that comes to mind for me, is to add in a validation test w/ a string in the api_tests? Should also check with a

[GitHub] [superset] codecov[bot] edited a comment on pull request #14881: feat: Database Connection UI

codecov[bot] edited a comment on pull request #14881: URL: https://github.com/apache/superset/pull/14881#issuecomment-849871089 #

[GitHub] [superset] codecov[bot] edited a comment on pull request #15151: feat: adding server-side validation and unmasked password on create

codecov[bot] edited a comment on pull request #15151: URL: https://github.com/apache/superset/pull/15151#issuecomment-860840728 #

[GitHub] [superset] codecov[bot] edited a comment on pull request #15046: feat(dashboard): Let users download full CSV of a table

codecov[bot] edited a comment on pull request #15046: URL: https://github.com/apache/superset/pull/15046#issuecomment-859152185 #

[GitHub] [superset] pkdotson closed issue #14670: [homescreen] Make all Home Page tabs "sticky"

pkdotson closed issue #14670: URL: https://github.com/apache/superset/issues/14670 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [superset] codecov[bot] edited a comment on pull request #15150: fix(db-connection-ui): Additional Query Parameters render

codecov[bot] edited a comment on pull request #15150: URL: https://github.com/apache/superset/pull/15150#issuecomment-860779500 #

[GitHub] [superset] cccs-RyanS opened a new pull request #15153: [WIP] Adding a show all button to the column/metrics list in the explore view (Allow more than 50 columns to be shown)

cccs-RyanS opened a new pull request #15153: URL: https://github.com/apache/superset/pull/15153 ### SUMMARY This is a simple addition to the explore view. The explore view limits the amount of data / columns displayed at once to 50. We wish to have the option of showing all of the

[GitHub] [superset] codecov[bot] commented on pull request #15151: feat: adding server-side validation and unmasked password on create

codecov[bot] commented on pull request #15151: URL: https://github.com/apache/superset/pull/15151#issuecomment-860840728 #

[GitHub] [superset] codecov[bot] edited a comment on pull request #15151: feat: adding server-side validation and unmasked password on create

codecov[bot] edited a comment on pull request #15151: URL: https://github.com/apache/superset/pull/15151#issuecomment-860840728 #

[GitHub] [superset] AAfghahi commented on a change in pull request #15151: feat: adding server-side validation and unmasked password on create

AAfghahi commented on a change in pull request #15151: URL: https://github.com/apache/superset/pull/15151#discussion_r651120746 ## File path: superset/db_engine_specs/base.py ## @@ -1438,7 +1438,7 @@ def validate_parameters( return errors port =

[GitHub] [superset] codecov[bot] edited a comment on pull request #15150: fix(db-connection-ui): Additional Query Parameters render

codecov[bot] edited a comment on pull request #15150: URL: https://github.com/apache/superset/pull/15150#issuecomment-860779500 #

[GitHub] [superset] codecov[bot] edited a comment on pull request #14881: feat: Database Connection UI

codecov[bot] edited a comment on pull request #14881: URL: https://github.com/apache/superset/pull/14881#issuecomment-849871089 #

[GitHub] [superset] codecov[bot] edited a comment on pull request #15141: chore: Scrolls top when opening a select filter

codecov[bot] edited a comment on pull request #15141: URL: https://github.com/apache/superset/pull/15141#issuecomment-860252515 #

[GitHub] [superset] codecov[bot] edited a comment on pull request #14881: feat: Database Connection UI

codecov[bot] edited a comment on pull request #14881: URL: https://github.com/apache/superset/pull/14881#issuecomment-849871089 #

[GitHub] [superset] eschutho commented on a change in pull request #15143: feat(db-connection-ui): Move fields from Extra section and split engine and metadata

eschutho commented on a change in pull request #15143: URL: https://github.com/apache/superset/pull/15143#discussion_r651162123 ## File path: superset-frontend/src/views/CRUD/data/database/DatabaseModal/ExtraOptions.tsx ## @@ -59,20 +60,21 @@ const ExtraOptions = ({

[GitHub] [superset] cccs-rc commented on a change in pull request #15153: [WIP] Adding a show all button to the column/metrics list in the explore view (Allow more than 50 columns to be shown)

cccs-rc commented on a change in pull request #15153: URL: https://github.com/apache/superset/pull/15153#discussion_r651180481 ## File path: superset-frontend/src/explore/components/DatasourcePanel/index.tsx ## @@ -113,6 +125,11 @@ export default function DataSourcePanel({

[GitHub] [superset] geido edited a comment on pull request #15121: feature: Select component

geido edited a comment on pull request #15121: URL: https://github.com/apache/superset/pull/15121#issuecomment-860916782 > @geido First thoughts: > > * You can rename `AntdSelect` and `AntSelect.stories` to `Select` and `Select.stories` using the `index` to resolve any name

[GitHub] [superset] betodealmeida opened a new pull request #15155: fix: validate DB-specific parameters

betodealmeida opened a new pull request #15155: URL: https://github.com/apache/superset/pull/15155 ### SUMMARY The `validate_parameters` endpoint was not performing the DB-specific Marshmallow validation (based on `parameters_schema`), but only the validation from the

[GitHub] [superset] codecov[bot] commented on pull request #15138: fix(dashboard): avoid duplicated toast component

codecov[bot] commented on pull request #15138: URL: https://github.com/apache/superset/pull/15138#issuecomment-860784894 #

[GitHub] [superset] codecov[bot] edited a comment on pull request #15150: fix(db-connection-ui): Additional Query Parameters render

codecov[bot] edited a comment on pull request #15150: URL: https://github.com/apache/superset/pull/15150#issuecomment-860779500 #

[GitHub] [superset] stellalc7 opened a new pull request #15152: fix(typo): in contributing.md

stellalc7 opened a new pull request #15152: URL: https://github.com/apache/superset/pull/15152 ### SUMMARY ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF ### TESTING INSTRUCTIONS ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ]

[GitHub] [superset] hughhhh merged pull request #15150: fix(db-connection-ui): Additional Query Parameters render

hug merged pull request #15150: URL: https://github.com/apache/superset/pull/15150 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [superset] michael-s-molina commented on a change in pull request #14872: feat(Explore): add sort to edit dataset modal

michael-s-molina commented on a change in pull request #14872: URL: https://github.com/apache/superset/pull/14872#discussion_r651135259 ## File path: superset-frontend/src/CRUD/CollectionTable.tsx ## @@ -42,12 +42,27 @@ interface CRUDCollectionProps { ) => ReactNode)[];

[GitHub] [superset] hughhhh commented on pull request #15151: feat: adding server-side validation and unmasked password on create

hug commented on pull request #15151: URL: https://github.com/apache/superset/pull/15151#issuecomment-860856893 LGTM! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [superset] betodealmeida commented on pull request #15151: feat: adding server-side validation and unmasked password on create

betodealmeida commented on pull request #15151: URL: https://github.com/apache/superset/pull/15151#issuecomment-860861291 > @betodealmeida the best way of doing that, that comes to mind for me, is to add in a validation test w/ a string in the api_tests? Should also check with a port that

[GitHub] [superset] betodealmeida edited a comment on pull request #15151: feat: adding server-side validation and unmasked password on create

betodealmeida edited a comment on pull request #15151: URL: https://github.com/apache/superset/pull/15151#issuecomment-860861291 > @betodealmeida the best way of doing that, that comes to mind for me, is to add in a validation test w/ a string in the api_tests? Should also check with a

[GitHub] [superset] etr2460 merged pull request #15093: chore: update documentation for frontend feature flags

etr2460 merged pull request #15093: URL: https://github.com/apache/superset/pull/15093 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [superset] geido commented on pull request #15121: feature: Select component

geido commented on pull request #15121: URL: https://github.com/apache/superset/pull/15121#issuecomment-860916782 > @geido First thoughts: > > * You can rename `AntdSelect` and `AntSelect.stories` to `Select` and `Select.stories` using the `index` to resolve any name conflicts.

[GitHub] [superset] cccs-RyanS opened a new pull request #15154: [WIP] Feature/buisness type database changes

cccs-RyanS opened a new pull request #15154: URL: https://github.com/apache/superset/pull/15154 ### SUMMARY ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF ### TESTING INSTRUCTIONS ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ]

[GitHub] [superset] rosemarie-chiu commented on pull request #15015: fix(native-filters): remove hard-coded default time range

rosemarie-chiu commented on pull request #15015: URL: https://github.com/apache/superset/pull/15015#issuecomment-860836901 2021.23 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [superset] codecov[bot] edited a comment on pull request #15151: feat: adding server-side validation and unmasked password on create

codecov[bot] edited a comment on pull request #15151: URL: https://github.com/apache/superset/pull/15151#issuecomment-860840728 #

[GitHub] [superset] codecov[bot] edited a comment on pull request #14881: feat: Database Connection UI

codecov[bot] edited a comment on pull request #14881: URL: https://github.com/apache/superset/pull/14881#issuecomment-849871089 #

[GitHub] [superset] codecov[bot] edited a comment on pull request #15143: feat(db-connection-ui): Move fields from Extra section and split engine and metadata

codecov[bot] edited a comment on pull request #15143: URL: https://github.com/apache/superset/pull/15143#issuecomment-860343905 #

[GitHub] [superset] codecov[bot] edited a comment on pull request #15143: feat(db-connection-ui): Move fields from Extra section and split engine and metadata

codecov[bot] edited a comment on pull request #15143: URL: https://github.com/apache/superset/pull/15143#issuecomment-860343905 #

[GitHub] [superset] codecov[bot] edited a comment on pull request #15150: fix(db-connection-ui): Additional Query Parameters render

codecov[bot] edited a comment on pull request #15150: URL: https://github.com/apache/superset/pull/15150#issuecomment-860779500 #

[GitHub] [superset] hughhhh commented on pull request #14881: feat: Database Connection UI

hug commented on pull request #14881: URL: https://github.com/apache/superset/pull/14881#issuecomment-860806465 /testenv up -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [superset] codecov[bot] edited a comment on pull request #15046: feat(dashboard): Let users download full CSV of a table

codecov[bot] edited a comment on pull request #15046: URL: https://github.com/apache/superset/pull/15046#issuecomment-859152185 #

[GitHub] [superset] hughhhh merged pull request #15152: fix(typo): in contributing.md

hug merged pull request #15152: URL: https://github.com/apache/superset/pull/15152 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [superset] codecov[bot] edited a comment on pull request #14881: feat: Database Connection UI

codecov[bot] edited a comment on pull request #14881: URL: https://github.com/apache/superset/pull/14881#issuecomment-849871089 #

[GitHub] [superset] codecov[bot] edited a comment on pull request #14881: feat: Database Connection UI

codecov[bot] edited a comment on pull request #14881: URL: https://github.com/apache/superset/pull/14881#issuecomment-849871089 #

[GitHub] [superset] cccs-rc commented on a change in pull request #15153: [WIP] Adding a show all button to the column/metrics list in the explore view (Allow more than 50 columns to be shown)

cccs-rc commented on a change in pull request #15153: URL: https://github.com/apache/superset/pull/15153#discussion_r651182354 ## File path: superset-frontend/src/explore/components/DatasourcePanel/index.tsx ## @@ -219,6 +240,15 @@ export default function DataSourcePanel({

[GitHub] [superset] hughhhh opened a new pull request #15150: fix(db-connection-ui): Additional Query Parameters render

hug opened a new pull request #15150: URL: https://github.com/apache/superset/pull/15150 ### SUMMARY Fix rendering the query parameters on edit. Before the field would render an object instead of the query params formatted. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

[GitHub] [superset] codecov[bot] edited a comment on pull request #15150: fix(db-connection-ui): Additional Query Parameters render

codecov[bot] edited a comment on pull request #15150: URL: https://github.com/apache/superset/pull/15150#issuecomment-860779500 #

[GitHub] [superset] codecov[bot] edited a comment on pull request #15150: fix(db-connection-ui): Additional Query Parameters render

codecov[bot] edited a comment on pull request #15150: URL: https://github.com/apache/superset/pull/15150#issuecomment-860779500 #

[GitHub] [superset] github-actions[bot] commented on pull request #14881: feat: Database Connection UI

github-actions[bot] commented on pull request #14881: URL: https://github.com/apache/superset/pull/14881#issuecomment-860807905 @hug Ephemeral environment spinning up at http://34.215.160.254:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and

[GitHub] [superset] codecov[bot] edited a comment on pull request #15046: feat(dashboard): Let users download full CSV of a table

codecov[bot] edited a comment on pull request #15046: URL: https://github.com/apache/superset/pull/15046#issuecomment-859152185 #

[GitHub] [superset] codecov[bot] edited a comment on pull request #15151: feat: adding server-side validation and unmasked password on create

codecov[bot] edited a comment on pull request #15151: URL: https://github.com/apache/superset/pull/15151#issuecomment-860840728 #

[GitHub] [superset] AAfghahi commented on a change in pull request #15151: feat: adding server-side validation and unmasked password on create

AAfghahi commented on a change in pull request #15151: URL: https://github.com/apache/superset/pull/15151#discussion_r651150751 ## File path: superset/db_engine_specs/base.py ## @@ -1438,7 +1438,7 @@ def validate_parameters( return errors port =

[GitHub] [superset] codecov[bot] edited a comment on pull request #15143: feat(db-connection-ui): Move fields from Extra section and split engine and metadata

codecov[bot] edited a comment on pull request #15143: URL: https://github.com/apache/superset/pull/15143#issuecomment-860343905 #

[GitHub] [superset] codecov[bot] edited a comment on pull request #15143: feat(db-connection-ui): Move fields from Extra section and split engine and metadata

codecov[bot] edited a comment on pull request #15143: URL: https://github.com/apache/superset/pull/15143#issuecomment-860343905 #

[GitHub] [superset] codecov[bot] edited a comment on pull request #15150: fix(db-connection-ui): Additional Query Parameters render

codecov[bot] edited a comment on pull request #15150: URL: https://github.com/apache/superset/pull/15150#issuecomment-860779500 #

[GitHub] [superset] codecov[bot] edited a comment on pull request #15150: fix(db-connection-ui): Additional Query Parameters render

codecov[bot] edited a comment on pull request #15150: URL: https://github.com/apache/superset/pull/15150#issuecomment-860779500 #

[GitHub] [superset] AAfghahi opened a new pull request #15151: feat: adding server-side validation and unmasked password on create

AAfghahi opened a new pull request #15151: URL: https://github.com/apache/superset/pull/15151 ### SUMMARY This is part of polishing up the db-connection-ui. We are creating server-side validation so that port cannot be string, also 'unmasking' password on the creation of a db.

[GitHub] [superset] hughhhh merged pull request #15100: fix: Test connection before starting on create transaction

hug merged pull request #15100: URL: https://github.com/apache/superset/pull/15100 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [superset] codecov[bot] edited a comment on pull request #14881: feat: Database Connection UI

codecov[bot] edited a comment on pull request #14881: URL: https://github.com/apache/superset/pull/14881#issuecomment-849871089 #

[GitHub] [superset] AAfghahi commented on pull request #15151: feat: adding server-side validation and unmasked password on create

AAfghahi commented on pull request #15151: URL: https://github.com/apache/superset/pull/15151#issuecomment-860859002 @betodealmeida the best way of doing that, that comes to mind for me, is to add in a validation test w/ a string in the api_tests? -- This is an automated message from

[GitHub] [superset] AAfghahi edited a comment on pull request #15151: feat: adding server-side validation and unmasked password on create

AAfghahi edited a comment on pull request #15151: URL: https://github.com/apache/superset/pull/15151#issuecomment-860859002 @betodealmeida the best way of doing that, that comes to mind for me, is to add in a validation test w/ a string in the api_tests? Should also check with a port that

[GitHub] [superset] betodealmeida commented on a change in pull request #15151: feat: adding server-side validation and unmasked password on create

betodealmeida commented on a change in pull request #15151: URL: https://github.com/apache/superset/pull/15151#discussion_r651139543 ## File path: superset/db_engine_specs/base.py ## @@ -1438,7 +1438,7 @@ def validate_parameters( return errors port =

[GitHub] [superset] dpgaspar commented on a change in pull request #15149: feat(dao): admin can remove self from object owners

dpgaspar commented on a change in pull request #15149: URL: https://github.com/apache/superset/pull/15149#discussion_r651153610 ## File path: tests/charts/api_tests.py ## @@ -564,12 +564,13 @@ def test_update_chart_new_owner(self): gamma = self.get_user("gamma")

  1   2   3   4   5   >