Ack with comments.
Regards, Vu
From: Thien Minh Huynh
Sent: Friday, July 10, 2020 8:53 AM
To: Thuan Tran ; Thang Duc Nguyen
; Vu Minh Nguyen
Cc: opensaf-devel@lists.sourceforge.net ;
Thien Minh Huynh
Subject: [PATCH 1/1] saflogger: correct wait time
Hi Thang,
I think you need to update the README for this change too.
Regards, Vu
From: thang.d.nguyen
Sent: Thursday, July 2, 2020 2:26 PM
To: Thuan Tran ; Thien Minh Huynh
; Minh Hon Chau
Cc: opensaf-devel@lists.sourceforge.net
Subject: [devel] [PATCH 1/1]
Hi Phuc,
Ack with minor comments below. Thanks!
Regards, Vu
From: phuc.h.chau
Sent: Monday, March 2, 2020 9:14 AM
To: Thang Duc Nguyen
Cc: opensaf-devel@lists.sourceforge.net
Subject: [devel] [PATCH 1/1] imm: imm_list tool add new option --delimiter
[#3155]
Hi Phuc,
See my comments inline.
Regards, Vu
From: Phuc Hoang Chau
Sent: Friday, February 28, 2020 2:01 PM
To: Vu Minh Nguyen ; Thuan Tran
Cc: opensaf-devel@lists.sourceforge.net ;
Phuc Hoang Chau
Subject: [PATCH 1/1] imm: imm_list tool add new option
Hi Thien,
Ack.
Thanks, Vu
From: Thien Minh Huynh
Sent: Friday, February 28, 2020 10:17 AM
To: Vu Minh Nguyen
Cc: opensaf-devel@lists.sourceforge.net ;
Thien Minh Huynh
Subject: [PATCH 1/1] log: standby node is rebooted when nfs is unresponsive
[#3161
Hi Thien,
Ack with comments inline. Thanks.
Regards, Vu
From: Thien Minh Huynh
Sent: Friday, February 21, 2020 5:09 PM
To: Thuan Tran ; Vu Minh Nguyen
Cc: opensaf-devel@lists.sourceforge.net ;
Thien Minh Huynh
Subject: [PATCH 1/1] imm: fix non-local user
---
src/log/logd/lgs_evt.cc | 3 +++
src/log/logd/lgs_mbcsv_cache.cc | 2 ++
2 files changed, 5 insertions(+)
diff --git a/src/log/logd/lgs_evt.cc b/src/log/logd/lgs_evt.cc
index 7501a282b..f169ea1e9 100644
--- a/src/log/logd/lgs_evt.cc
+++ b/src/log/logd/lgs_evt.cc
@@ -1348,6 +1348,7 @@
TCH SERIES HERE ***
revision 740100f2ebfb5458a8052dea29b5583b3dc8df5a
Author: Vu Minh Nguyen
Date: Thu, 9 Jan 2020 17:06:05 +0700
log: fix memory leak that was introduced in 3116 [#3138]
Complete diffstat:
--
src/log/logd/lgs_evt.cc | 3 +++
src/log/logd/lgs_mbcsv_ca
ERIES HERE ***
revision d3b3bd1fb4bb3afe5d8252641bc68029f91b69b3
Author: Vu Minh Nguyen
Date: Mon, 6 Jan 2020 11:38:27 +0700
log: fix segmentation fault in log agent [#3137]
log agent did not protect the resource `unacked_invocations_ list` from
accessing by multiple threads, so caused segmenta
log agent did not protect the resource `unacked_invocations_ list` from
accessing by multiple threads, so caused segmentation fault.
This patch introduces a mutex in order to synchronize the access to that
common resource.
---
src/log/agent/lga_client.cc | 2 +-
src/log/agent/lga_client.h | 16
ERIES HERE ***
revision 184d67c1e6b896d69f9bd2cd353ae02699bcae55
Author: Vu Minh Nguyen
Date: Mon, 6 Jan 2020 10:12:56 +0700
log: fix segmentation fault in log agent [#3137]
log agent did not protect the resource `unacked_invocations_ list` from
accessing by multiple threads, so caused segmenta
log agent did not protect the resource `unacked_invocations_ list` from
accessing by multiple threads, so caused segmentation fault.
This patch introduces a mutex in order to synchronize the access to that
common resource.
---
src/log/agent/lga_client.h | 12 +++-
1 file changed, 11
In order to improve resilience of OpenSAF LOG service when underlying
file system is unresponsive, a queue is introduced to hold async
write request up to an configurable time that is around 15 - 30 seconds.
The readiness of the I/O thread will periodically check, and if it turns
to ready state,
Adding 08 new test cases into 02 suites:
1) Suite 20 with 07 test cases, including:
- Test changing queue size & resilient timeout;
- Test if a write async is dropped if its timeout setting is overdue,
also verify if log server has kept the request in proper time.
- Test if getting write callback
This change introduces a light list keeping all invocations that not yet
get the acknowledgement from log server. If the server is disappeared
in case of headless, log agent will notify all lost invocations to log client
with error code SA_AIS_ERR_TRY_AGAIN.
---
src/log/agent/lga_agent.cc | 2
---
src/log/README | 38 ++
1 file changed, 38 insertions(+)
diff --git a/src/log/README b/src/log/README
index b83d472e4..ab96a8157 100644
--- a/src/log/README
+++ b/src/log/README
@@ -764,3 +764,41 @@ on AMF role is unnecessary delay the CLM state of a Node
uot; above):
-
*** EXPLAIN/COMMENT THE PATCH SERIES HERE ***
revision 2643f8f829bb7ba638193df19cc6f20f86acb497
Author: Vu Minh Nguyen
Date: Thu, 28 Nov 2019 15:19:58 +0700
log: add test cases of improving the log resilience [#3116]
Adding 08 new test cases into 02 suites:
1
THE PATCH SERIES HERE ***
revision c9e55e13f42a571a109c3d5e0484c58d3791dadb
Author: Vu Minh Nguyen
Date: Mon, 25 Nov 2019 13:41:43 +0700
nid: fix unable to start UML cluster with tipc transport [#3122]
Complete diffstat:
--
src/nid/configure_tipc.in | 10 ++
1 file
---
src/nid/configure_tipc.in | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/src/nid/configure_tipc.in b/src/nid/configure_tipc.in
index a63c97046..43ddb06e1 100644
--- a/src/nid/configure_tipc.in
+++ b/src/nid/configure_tipc.in
@@ -221,11 +221,13 @@ function
To avoid the risk of losing traces, logtrace server should flush traces
as soon as possible when logtrace owner is terminated.
This patch also refactors LogServer::Run().
---
src/dtm/transport/log_server.cc | 123
src/dtm/transport/log_server.h | 7 ++
2 files
THE PATCH SERIES HERE ***
revision c0017b9a45f49468a60fc493eae2d62c60b3958a
Author: Vu Minh Nguyen
Date: Fri, 25 Oct 2019 15:19:59 +0700
dtm: flush logtrace asap when logtrace owner is terminated [#3106]
To avoid the risk of losing traces, logtrace server should flush traces
as soon as pos
revision ccddf032be710dadf0e3218a99b74112ab2f7eb5
Author: Vu Minh Nguyen
Date: Fri, 4 Oct 2019 17:24:04 +0700
dtm: rotate logtraces on demand [#3086]
Introducing a new option '--rotate' to rotate given logtrace stream(s).
This patch also cleans the code of LogServer::ExecuteCommand().
Introducing a new option '--rotate' to rotate given logtrace stream(s).
This patch also cleans the code of LogServer::ExecuteCommand().
---
src/base/log_writer.h | 2 +-
src/dtm/tools/osaflog.cc| 25 ++-
src/dtm/transport/log_server.cc | 125
Providing a new option '--max-idle' to configure the maximum idle time
of logtrace streams. If a stream has not been used for such time, logtrace
server will close the stream from its database.
This patch also corrects wrong indentation in osaflog.cc file.
---
src/dtm/Makefile |
ERIES HERE ***
revision 7fe52542e82d4e9de969011d48f1c1805cb44f68
Author: Vu Minh Nguyen
Date: Tue, 24 Sep 2019 09:47:45 +0700
dtm: close unused log streams [#2642]
Providing a new option '--max-idle' to configure the maximum idle time
of logtrace streams. If a stream has not been used for such time
uot; above):
-
*** EXPLAIN/COMMENT THE PATCH SERIES HERE ***
revision 7b839ea48b0c48802a13ce2713b4b1daf9e274c0
Author: Vu Minh Nguyen
Date: Thu, 8 Aug 2019 11:45:41 +0700
scripts: use tipc instead of obsolute tipc-config in opensaf_reboot [#3066]
The tipc-config command is obsolete and no longer being maintained. We should
switch to using the "tipc" command instead
---
Makefile.am | 3 ++-
opensaf.spec.in | 1 +
.../archive/scripts => scripts}/tipc-config | 15
uot; above):
-
*** EXPLAIN/COMMENT THE PATCH SERIES HERE ***
revision 78619e9f226b8cf20e11c837332c0c582ffbd0ad
Author: Vu Minh Nguyen
Date: Thu, 1 Aug 2019 09:41:18 +0700
nid: use the tipc command instead of tipc-config [#2104]
The tipc-config command is obsolete and no lo
uot; above):
-
*** EXPLAIN/COMMENT THE PATCH SERIES HERE ***
revision 011c1cc1dbb12840fdaec159dc15a0b46e7d26e2
Author: Vu Minh Nguyen
Date: Mon, 15 Jul 2019 09:40:51 +0700
nid: use the tipc command instead of tipc-config [#2104]
The tipc-config command is obsolete and no lo
The tipc-config command is obsolete and no longer being maintained. We should
switch to using the "tipc" command instead
---
Makefile.am | 3 ++-
opensaf.spec.in | 1 +
.../archive/scripts => scripts}/tipc-config | 2 +-
Ack with a minor comment.
Regards, Vu
> -Original Message-
> From: thang.d.nguyen
> Sent: Thursday, June 20, 2019 10:42 AM
> To: vu.m.ngu...@dektech.com.au; hans.nordeb...@ericsson.com;
> lennart.l...@ericsson.com
> Cc: opensaf-devel@lists.sourceforge.net; thang.d.nguyen
>
> Subject:
Hi Canh,
Ack with minor comments.
Regards, Vu
> -Original Message-
> From: Canh Van Truong
> Sent: Friday, June 14, 2019 10:21 PM
> To: lennart.l...@ericsson.com; vu.m.ngu...@dektech.com.au
> Cc: opensaf-devel@lists.sourceforge.net; Canh Van Truong
>
> Subject: [PATCH 1/1] log: Delete
Hi Canh,
Ack with minor comments.
Regards, Vu
> -Original Message-
> From: Canh Van Truong
> Sent: Monday, June 3, 2019 6:18 PM
> To: lennart.l...@ericsson.com; vu.m.ngu...@dektech.com.au
> Cc: opensaf-devel@lists.sourceforge.net; Canh Van Truong
>
> Subject: [PATCH 1/1] log: Delete
Hi Canh,
Ack with minor comments.
Regards, Vu
> -Original Message-
> From: Canh Van Truong
> Sent: Thursday, May 30, 2019 3:10 PM
> To: lennart.l...@ericsson.com; vu.m.ngu...@dektech.com.au
> Cc: opensaf-devel@lists.sourceforge.net; Canh Van Truong
>
> Subject: [PATCH 1/1] log: fix to
Hi all,
Any comments on this document update? I will push it on tomorrow if no
comments. Thanks.
Regards, Vu
From: Vu Minh Nguyen
Sent: Monday, April 22, 2019 10:46 AM
To: 'hans.nordeb...@ericsson.com' ;
'lennart.l...@ericsson.com' ;
'gary@dektech.com.au'
Cc: 'opensaf-devel
Hi Hans,
Probably you were looking at code that included this Thuan's patch.
In legacy code, only mdtm_sendto() is called inside the function
mdtm_frag_and_send().
Regards, Vu
> -Original Message-
> From: Hans Nordebäck
> Sent: Thursday, April 25, 2019 6:10 PM
> To: Vu
Hi Hans,
See my responses inline.
Regards, Vu
> -Original Message-
> From: Hans Nordebäck
> Sent: Thursday, April 25, 2019 4:28 PM
> To: Thuan Tran ; Vu Minh Nguyen
> ; Minh Hon Chau
>
> Cc: opensaf-devel@lists.sourceforge.net
> Subject: Re: [PATCH 0/1] Review
Hi Thuan,
Ack with minor comments below.
Regards, Vu
> -Original Message-
> From: thuan.tran
> Sent: Wednesday, April 24, 2019 6:06 PM
> To: 'Vu Minh Nguyen' ;
> hans.nordeb...@ericsson.com; Minh Hon Chau
>
> Cc: opensaf-devel@lists.sourceforge.net; thuan.tran
>
won't cause memleak since I break after
> m_MMGR_REMOVE_FROM_START()
> free(body)
>
> Best Regards,
> ThuanTr
>
> -Original Message-
> From: Vu Minh Nguyen
> Sent: Wednesday, April 24, 2019 1:45 PM
> To: 'thuan.tran' ;
> hans.nordeb...@ericsson.com;
> 'Minh Hon Chau
Hi Thuan,
Tested broadcasting with large packages (each 1M).
Ack with below comments.
Regards, Vu
> -Original Message-
> From: thuan.tran
> Sent: Wednesday, April 24, 2019 12:00 PM
> To: hans.nordeb...@ericsson.com; Vu Minh Nguyen
> ; Minh Hon Chau c...@users.source
Hi Canh,
Ack with minor comments.
Regards, Vu
> -Original Message-
> From: Canh Van Truong
> Sent: Tuesday, April 16, 2019 3:27 PM
> To: lennart.l...@ericsson.com; vu.m.ngu...@dektech.com.au
> Cc: opensaf-devel@lists.sourceforge.net; Canh Van Truong
>
> Subject: [PATCH 1/1] log: Log
TCH SERIES HERE ***
revision 7c90172e2fc6ff1700668db98063a9253ec71a0e
Author: Vu Minh Nguyen
Date: Wed, 17 Apr 2019 16:09:57 +0700
imm: fix coredump on immnd during upgrade [#3030]
The assertion about the existence of the new added attribute
`saImmFileSystemStatus` should be done if the admOp ID
The assertion about the existence of the new added attribute
`saImmFileSystemStatus` should be done if the admOp ID is
either 400 or 401.
---
src/imm/common/immsv_api.h | 2 +-
src/imm/config/immsv_classes.xml | 1 -
src/imm/immnd/ImmModel.cc| 7 ---
3 files changed, 5
t;> with SA_AIS_OK (the transaction has been committed).
> >> >>The additional apply should get FAILED_OPERATION as the CCB has
> been
> >> applied.
> >> >>
> >> >>2) "Additional Apply requests" are invoked after the first apply
t; >>>
> >>> Hi,
> >>>
> >>> I think this ticket (#3019) is erroneous and dangerous.
> >>> If you currently have an apply in progress (a commit of a transaction)
> that
> >>> means you DONT KNOW if the operation will/has succeede
sts.sourceforge.net
> >Ämne : Re: [devel] [PATCH 1/1] imm: return try-again on write requests
> while fs is unavailable [#3019]
> >
> >Hi all,
> >
> >Have you had time to review the patch? I will push this ticket by this
> >Wednesday if there is no comment/feedback.
&g
Hi all,
Have you had time to review the patch? I will push this ticket by this
Wednesday if there is no comment/feedback.
Regards, Vu
> -Original Message-
> From: Vu Minh Nguyen
> Sent: Tuesday, March 26, 2019 1:19 PM
> To: hans.nordeb...@ericsson.com; lennart.l...@ericsson
Ack
Regards, Vu
> -Original Message-
> From: canht32
> Sent: Thursday, March 28, 2019 1:15 PM
> To: lennart.l...@ericsson.com; vu.m.ngu...@dektech.com.au
> Cc: opensaf-devel@lists.sourceforge.net; canht32
>
> Subject: [PATCH 1/1] log: fix logd crash due to well known stream has
>
When underlying file system is unresponsive to pbe write request, all IMM
requests that required to be persistent such as creating an IMM object or
creating an IMM class likely gets SA_AIS_ERR_TIMEOUT.
This changeset introduces two administrative operations which are provided to
let user inform
uot; above):
-
*** EXPLAIN/COMMENT THE PATCH SERIES HERE ***
revision 3b1c3551f74290e1eda711f7136a40d2168ab375
Author: Vu Minh Nguyen
Date: Tue, 26 Mar 2019 13:13:46 +0700
imm: return try-again on write requests while fs is unavailable [#3019]
When under
t: Friday, March 22, 2019 12:01 PM
To: 'Vu Minh Nguyen' ; lennart.l...@ericsson.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: RE: [PATCH 1/1] log: logd crash due to well known stream has
numOpeners = 0 [#3018]
Hi Lennart and aVu,
Thanks for your review.
I check the code again
Hi Canh,
Log stream is allocated with brackets, (), going with new operator; It means
numOpeners field is already zero-initialized.
log_stream_t *stream = new (std::nothrow) log_stream_t();
So, I don't think your change will address the issue. The bug may locate at
another place.
Hi Canh,
Ack. Thanks.
Regards, Vu
> -Original Message-
> From: Canh Van Truong
> Sent: Friday, March 1, 2019 5:36 PM
> To: lennart.l...@ericsson.com; vu.m.ngu...@dektech.com.au
> Cc: opensaf-devel@lists.sourceforge.net; Canh Van Truong
>
> Subject: [PATCH 1/1] log: Fix the last value
There is a dependency b/w svc_monitor_thread and spawn_services.
The coredump happens when spawn_services is executed while
the thread has not yet started. In this case, data is sent to the
pipe but no one consumed it. When it comes to consume the data,
will get unexpected data and crash the
ERIES HERE ***
revision 89751e679b5eb9230214414ca44410620d72af39
Author: Vu Minh Nguyen
Date: Fri, 1 Mar 2019 16:05:12 +0700
nid: fix opensafd crashed during start-up [#3013]
There is a dependency b/w svc_monitor_thread and spawn_services.
The coredump happens when spawn_services is executed while
the
Thanks Hans. I will send the V2 for these updates.
Regards, Vu
From: Hans Nordebäck
Sent: Thursday, February 28, 2019 2:16 PM
To: Vu Minh Nguyen ; Gary Lee
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [PATCH 1/1] nid: fix opensafd crashed during start-up [#3013]
Hi Vu,
you
> -Original Message-
> From: Hans Nordebäck
> Sent: Wednesday, February 27, 2019 8:23 PM
> To: Vu Minh Nguyen ; Gary Lee
>
> Cc: opensaf-devel@lists.sourceforge.net; Vu Minh Nguyen
>
> Subject: RE: [PATCH 1/1] nid: fix opensafd crashed during start-up [#3013]
>
&
ERIES HERE ***
revision 4bfd21acce133e2b5bbb83ec42e36682f4ac4c77
Author: Vu Minh Nguyen
Date: Wed, 27 Feb 2019 17:43:21 +0700
nid: fix opensafd crashed during start-up [#3013]
There is a dependency b/w svc_monitor_thread and spawn_services.
The coredump happens when spawn_services is executed while
There is a dependency b/w svc_monitor_thread and spawn_services.
The coredump happens when spawn_services is executed while
the thread has not yet started. In this case, data is sent to the
pipe but no one consumed it. Later on, reading data from the pipe,
will get unexpected data and crash the
At the time of spliting the cluster into 02 partitions but keeping a node
such as PL-3 connecting with both partitions, just IMMND on PL-3 will get
discard-node messages from both active IMMD on partition #1 and from standby
IMMD on partition #2.
That race later on caused IMMND on PL-3 crashed
IN/COMMENT THE PATCH SERIES HERE ***
revision 827a1d4c9c4708776cb67dd27e984368c089f232
Author: Vu Minh Nguyen
Date: Mon, 25 Feb 2019 14:27:33 +0700
imm: fix racing in sending discard-node during network split [#3012]
At the time of spliting the cluster into 02 partitions but keeping a node
su
Hi Lennart,
This happens when shutting down log application and causing coredump for the
application.
The coredump backtrace can be found in the ticket.
Regards, Vu
From: Lennart Lund
Sent: Wednesday, January 30, 2019 5:04 PM
To: Vu Minh Nguyen ; Canh Van Truong
Cc: opensaf
Hi,
Have you had time to review this ticket? Thanks.
Regards, Vu
> -Original Message-
> From: Vu Minh Nguyen
> Sent: Thursday, January 24, 2019 5:15 PM
> To: lennart.l...@ericsson.com; canh.v.tru...@dektech.com.au
> Cc: opensaf-devel@lists.sourceforge.net; Vu Minh Nguy
Hi all,
Any comment for this update? Will push the documentation E/today if getting
no comment/response.
Regards, Vu
From: Vu Minh Nguyen
Sent: Thursday, January 17, 2019 9:44 AM
To: 'Lennart Lund'
Cc: 'opensaf-devel@lists.sourceforge.net'
Subject: [devel] Review request imm
Hi Hans,
Thanks for your comments. See my comment inline. Thanks
Regards, Vu
> -Original Message-
> From: Hans Nordebäck
> Sent: Monday, January 28, 2019 4:37 PM
> To: Hans Nordebäck ; Vu Minh Nguyen
> ; Gary Lee ;
> Minh Hon Chau
> Cc: opensaf-devel@lists.sour
---
scripts/opensaf_reboot | 33 +++--
src/amf/amfd/ndproc.cc | 4 ++--
src/base/ncssysf_def.h | 6 ++
src/base/sysf_def.c | 10 ++
src/fm/fmd/fm_main.cc| 6 +++---
src/fm/fmd/fm_rda.cc | 5 ++---
src/rde/rded/rde_main.cc | 6 ++
THE PATCH SERIES HERE ***
revision 906f36a82e75898783d38f3e9d55b87a62c0bb38
Author: Vu Minh Nguyen
Date: Fri, 25 Jan 2019 18:30:12 +0700
osaf: do quick local node reboot when split network [#3001]
Complete diffstat:
--
scripts/opensaf_reb
There is a race in using singleton-static class object b/w mds thread
and application thread - caller of exit() api.
This patch still uses singleton but making the instance shared_ptr
to ensure the resource will not be destroyed if it is being used.
---
src/log/agent/lga_agent.cc | 7 ++-
ERIES HERE ***
revision 160735e4879ee3482170795f6247b71980a0d598
Author: Vu Minh Nguyen
Date: Thu, 24 Jan 2019 17:11:45 +0700
log: fix coredump at log agent application [#3002]
There is a race in using singleton-static class object b/w mds thread
and application thread - caller of exit() api.
During runtime, when replacing value of an attribute which has default-value
tag with NULL, this NULL value is not persistent after cluster is rebooted -
NULL value will be automatically replaced with its default value by IMM.
This behavior causes several unexpected results. Below is an use case:
uot; above):
-
*** EXPLAIN/COMMENT THE PATCH SERIES HERE ***
revision 67b1566d66cbeb2a066ae283a406a122f7168ae5
Author: Vu Minh Nguyen
Date: Tue, 15 Jan 2019 10:29:26 +0700
imm: allow empty-value attribute with default-tag persisted [#2985]
During runtime, when
ue so values larger than that max are
> invalid) and if the value is invalid it could be replaced by a default
value.
>
> Thanks
> Lennart
>
> -Original Message-
> From: Vu Minh Nguyen
> Sent: den 10 januari 2019 03:56
> To: Hans Nordebäck ; Lennart Lund
>
Hi,
Any comment from you? I will push this ticket B/next week if no comment.
Regards, Vu
> -Original Message-
> From: Vu Minh Nguyen
> Sent: Wednesday, December 19, 2018 6:11 PM
> To: hans.nordeb...@ericsson.com; lennart.l...@ericsson.com;
> gary@dektech.com.au
>
Hi Canh,
Ack for the patch. However, I think the ticket slogan should be updated to
reflect the case. Thanks.
Regards, Vu
> -Original Message-
> From: Canh Van Truong
> Sent: Thursday, December 27, 2018 3:10 PM
> To: vu.m.ngu...@dektech.com.au
> Cc: opensaf-devel@lists.sourceforge.net;
Ack
Thanks, Vu
> -Original Message-
> From: khanh.h.dang
> Sent: Wednesday, December 19, 2018 4:53 PM
> To: vu.m.ngu...@dektech.com.au
> Cc: opensaf-devel@lists.sourceforge.net; khanh.h.dang
>
> Subject: [PATCH 1/1] imm: correct mismatched log info showing resources in
> displayverbose
uot; above):
-
*** EXPLAIN/COMMENT THE PATCH SERIES HERE ***
revision 39f46dd06f7705929c293d00b48443570b6af235
Author: Vu Minh Nguyen
Date: Wed, 19 Dec 2018 18:00:48 +0700
imm: allow empty-value attribute with default-tag persisted [#2985]
During runtime, when
During runtime, when replacing value of an attribute which has default-value
tag with NULL, this NULL value is not persistent after cluster is rebooted -
NULL value will be automatically replaced with its default value by IMM.
This behavior causes several unexpected results. Below is a use case.
When replacing value of an attribute which has default-value tag with NULL
during runtime, NULL value will be replaced with its default value after
cluster is rebooted; in other words, that value is not persisted.
This patch makes some changes in immdump/immloader/imm om library/immnd
to handle
uot; above):
-
*** EXPLAIN/COMMENT THE PATCH SERIES HERE ***
revision ae02c3dcafe8934eb73887ce8e1f02be83cd6942
Author: Vu Minh Nguyen
Date: Wed, 19 Dec 2018 16:13:47 +0700
imm: allow empty-value attribute with default-tag persisted [#2985]
When repla
With SaAnyT value, imm import passed wrong memory pointer to free().
---
src/imm/tools/imm_import.cc | 16 ++--
1 file changed, 2 insertions(+), 14 deletions(-)
diff --git a/src/imm/tools/imm_import.cc b/src/imm/tools/imm_import.cc
index ba5023b17..32a3f5424 100644
---
IN/COMMENT THE PATCH SERIES HERE ***
revision 7a2b68423960faf56983bc69995dc09a284f56e7
Author: Vu Minh Nguyen
Date: Wed, 19 Dec 2018 14:10:49 +0700
imm: coredump when importing object having SaAnyT type value [#2988]
With SaAnyT value, imm import passed wrong memory pointer to free().
With SaAnyT value, imm import passed wrong memory pointer to free().
---
src/imm/tools/imm_import.cc | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/src/imm/tools/imm_import.cc b/src/imm/tools/imm_import.cc
index ba5023b17..46dd32072 100644
---
IN/COMMENT THE PATCH SERIES HERE ***
revision a8fa9340bc3d3062df422672d4872f53c67aaf7e
Author: Vu Minh Nguyen
Date: Wed, 19 Dec 2018 11:33:49 +0700
imm: coredump when importing object having SaAnyT type value [#2988]
With SaAnyT value, imm import passed wrong memory pointer to free().
Ack. Thanks.
I am going to push this today.
Regards, Vu
> -Original Message-
> From: Mohan Kanakam
> Sent: Monday, December 17, 2018 3:16 PM
> To: vu.m.ngu...@dektech.com.au; hans.nordeb...@ericsson.com
> Cc: opensaf-devel@lists.sourceforge.net; Mohan Kanakam
>
> Subject: [PATCH 1/1]
Ack.
Thanks, Vu
> -Original Message-
> From: Mohan Kanakam
> Sent: Friday, November 30, 2018 1:04 PM
> To: vu.m.ngu...@dektech.com.au; hans.nordeb...@ericsson.com
> Cc: opensaf-devel@lists.sourceforge.net; Mohan Kanakam
>
> Subject: [PATCH 1/1] imm: add new test cases in imm apitest
Hi Mohan,
Ack with a minor comment. Thanks.
Regards, Vu
> -Original Message-
> From: Mohan Kanakam
> Sent: Friday, November 2, 2018 2:08 PM
> To: vu.m.ngu...@dektech.com.au; hans.nordeb...@ericsson.com
> Cc: opensaf-devel@lists.sourceforge.net; Mohan Kanakam
>
> Subject: [PATCH 2/3]
Hi Mohan,
Ack with minor comments.
Regards, Vu
> -Original Message-
> From: Mohan Kanakam
> Sent: Friday, November 2, 2018 2:08 PM
> To: vu.m.ngu...@dektech.com.au; hans.nordeb...@ericsson.com
> Cc: opensaf-devel@lists.sourceforge.net; Mohan Kanakam
>
> Subject: [PATCH 3/3] imm: add
Hi Mohan,
Ack with minor comments.
Regards, Vu
> -Original Message-
> From: Mohan Kanakam
> Sent: Friday, November 2, 2018 2:08 PM
> To: vu.m.ngu...@dektech.com.au; hans.nordeb...@ericsson.com
> Cc: opensaf-devel@lists.sourceforge.net; Mohan Kanakam
>
> Subject: [PATCH 1/3] imm: add
Hi Mohan,
Ack for this patch with a minor comment. Thanks.
Regards, Vu
> -Original Message-
> From: Mohan Kanakam
> Sent: Thursday, November 1, 2018 3:28 PM
> To: vu.m.ngu...@dektech.com.au; hans.nordeb...@ericsson.com
> Cc: opensaf-devel@lists.sourceforge.net; Mohan Kanakam
>
>
Hi Mohan,
Ack for this patch with a minor comment.
Regards, Vu
> -Original Message-
> From: Mohan Kanakam
> Sent: Thursday, November 1, 2018 3:28 PM
> To: vu.m.ngu...@dektech.com.au; hans.nordeb...@ericsson.com
> Cc: opensaf-devel@lists.sourceforge.net; Mohan Kanakam
>
> Subject:
Hi Mohan,
Ack for this patch.
Thanks.
Regards, Vu
> -Original Message-
> From: Mohan Kanakam
> Sent: Thursday, November 1, 2018 3:28 PM
> To: vu.m.ngu...@dektech.com.au; hans.nordeb...@ericsson.com
> Cc: opensaf-devel@lists.sourceforge.net; Mohan Kanakam
>
> Subject: [PATCH 3/3]
It is expected that resending introduceMsg should happen every 05 seconds
if the previous send has not yet received the response e.g because of having
network issue or having the active IMMD unresponsive. However, in some cases,
the re-send is done every 0.1 second.
This patch adds a few code to
uot; above):
-
*** EXPLAIN/COMMENT THE PATCH SERIES HERE ***
revision ae7c71cf5621e78fbeffece3b65184d5829938ac
Author: Vu Minh Nguyen
Date: Tue, 13 Nov 2018 17:50:18 +0700
imm: fix introduceMsg resent in every 0.1 second [#2959]
It is expected that resending introduceMsg sho
ERIES HERE ***
revision 16722697b993da76fb4212105bd1b9b7cc35424c
Author: Vu Minh Nguyen
Date: Tue, 6 Nov 2018 17:42:59 +0700
smf: add retry machanism to adminop utils [#2956]
Execution of the campaign will get failed if getting timeout
during performing admin operation.
This ticket adds so
Execution of the campaign will get failed if getting timeout
during performing admin operation.
This ticket adds some retries in such case or in case of getting
SA_AIS_ERR_BAD_HANDLE.
---
src/smf/smfd/SmfUtils.cc | 12
1 file changed, 12 insertions(+)
diff --git
The coredump is generated in the context of processing the message type
"IMMND_EVT_D2ND_IMPLDELETE" because the memory is corrupted at the time
of decoding that message.
It allocated 'size' bytes of memory with the boundary in range [0 - 'size - 1'],
but modified - added null terminated, the
uot; above):
-
*** EXPLAIN/COMMENT THE PATCH SERIES HERE ***
revision eed9bb36e13f6c884fbee57e207d7591c5b5e72f
Author: Vu Minh Nguyen
Date: Mon, 29 Oct 2018 16:09:43 +0700
imm: fix osafimmnd coredump genereted during sanity test [#2947]
The coredump is generated in t
Hi all,
Do you have any comment for this patch? Thanks.
Regards, Vu
> -Original Message-
> From: Vu Minh Nguyen
> Sent: Tuesday, October 23, 2018 11:31 AM
> To: hans.nordeb...@ericsson.com; lennart.l...@ericsson.com;
> gary@dektech.com.au
> Cc: opensaf-devel@lis
THE PATCH SERIES HERE ***
revision c756ce4a0861176c58f9cc76bec3de2ac579b72f
Author: Vu Minh Nguyen
Date: Tue, 23 Oct 2018 10:31:16 +0700
imm: fix coredump generated during roaming test [#2943]
The fix of ticket [#2934] was not covered the roaming SC case.
With roaming, IMMND veteran could run
The fix of ticket [#2934] was not covered the roaming SC case.
With roaming, IMMND veteran could run on system controller node type.
Instead of going to accept_node directly in previous fix, it should go to
update_node_type.
---
src/imm/immd/immd_evt.c | 3 ++-
1 file changed, 2 insertions(+), 1
1 - 100 of 614 matches
Mail list logo
