[devel] [PATCH 0 of 1] Review Request for log: fix issue with priority of messages adding to mailbox in the server[#1396]

n Other n Comments (indicate scope for each "y" above): - <> changeset e64bdc66985a2b57d4bd2f284ce8b900c919eed2 Author: Canh Van Truong <canh.v.tru...@dektech.com.au> Date: Fri, 10 J

[devel] [PATCH 1 of 1] log: fix issue with priority of messages adding to mailbox in the server[1396]

osaf/libs/agents/saf/lga/lga_api.c | 3 ++- osaf/libs/agents/saf/lga/lga_util.c | 21 - tests/logsv/logtest.h | 1 + tests/logsv/tet_saLogStreamOpen_2.c | 29 + 4 files changed, 44 insertions(+), 10 deletions(-) Sometimes, Log

[devel] [PATCH 1 of 1] log: fix log file size is bigger than saLogStreamMaxLogFileSize [#1438]

osaf/services/saf/logsv/lgs/lgs_stream.cc | 40 +--- tests/logsv/tet_LogOiOps.c| 128 ++ 2 files changed, 153 insertions(+), 15 deletions(-) The issue is that the log file size is bigger than MAX_FILE_SIZE value. Log server should close the

[devel] [PATCH 0 of 1] Review Request for log: fix log file size is bigger than saLogStreamMaxLogFileSize [#1438]

Summary: log: fix log file size is bigger than saLogStreamMaxLogFileSize [#1438] Review request for Trac Ticket(s): #1438 Peer Reviewer(s): Lennart, Mathi, Vu Pull request to: Vu Affected branch(es): opensaf-4.7.x, opensaf-5.0.x, default(5.1) Development branch: default

[devel] [PATCH 0 of 1] Review Request for log: fix ER in syslog if changing saLogStreamFileName and other atrributes[#1887]

n Tests n Other n Comments (indicate scope for each "y" above): - <> changeset 17eedafb8a4d9df8fe145f48dc4b9278dd8a1214 Author: Canh Van Truong <canh.v.tru...@dektech.com.au> Date: Thu

[devel] [PATCH 0 of 1] Review Request for log: improve test cases for log service [#1913]

n Comments (indicate scope for each "y" above): - <> changeset 694beaad940f47f447feee6a65877af4504dcdfc Author: Canh Van Truong <canh.v.tru...@dektech.com.au> Date: Fri, 05 Aug 2016 15:21:55 +0700 log: impr

[devel] [PATCH 0 of 1] Review Request for log: improve test cases for log service [#1913]

n Comments (indicate scope for each "y" above): - <> changeset 66ce76934620ec6230cfc90da3082167d72392b6 Author: Canh Van Truong <canh.v.tru...@dektech.com.au> Date: Fri, 05 Aug 2016 15:21:55 +0700 log: impr

[devel] [PATCH 2 of 3] log: Add minor version checking in log server [#2146]

src/log/Makefile.am |3 + src/log/common/lgsv_defs.h |4 + src/log/common/lgsv_msg.h|2 +- src/log/logd/lgs_cb.h|2 + src/log/logd/lgs_evt.cc | 93 - src/log/logd/lgs_mbcsv.cc| 181 ++

[devel] [PATCH 3 of 3] log: fix checking version in log agent [#2146]

src/log/agent/lga_api.c | 58 ++ src/log/apitest/tet_saLogFilterSetCallbackT.c | 53 src/log/apitest/tet_saLogInitialize.c | 24 +++ 3 files changed, 126 insertions(+), 9 deletions(-) Fix checking version

[devel] [PATCH 1 of 3] log: implement SaLogFilterSetCallbackT [#2146]

src/log/agent/lga.h |4 + src/log/agent/lga_mds.c | 71 + src/log/agent/lga_util.c | 64 - src/log/apitest/logtest.c |3 +- src/log/apitest/logtestfr.c |3 +-

[devel] [PATCH 0 of 3] Review Request for log: implement SaLogFilterSetCallbackT and version handling V4 [#2146]

n Other n Comments (indicate scope for each "y" above): - <> changeset 05726400fc1a27cf50255b70bb7f952156cbe68f Author: Canh Van Truong <canh.v.tru...@dektech.com.au> Date: Mon, 21 Nov 2016 17:19

[devel] [PATCH 0 of 1] Review Request for ntf: workaround to fix failed upgrade [#2300]

n Comments (indicate scope for each "y" above): - <> changeset 11eb25dbd7f33a5f68b5e6266e9b017cb5ee53bf Author: Canh Van Truong <canh.v.tru...@dektech.com.au> Date: Sat, 11 Feb 2017 03:51:36 +0700 ntf: wo

[devel] [PATCH 0 of 3] Review Request for log: implement SaLogFilterSetCallbackT and version handling V3 [#2146]

n Other n Comments (indicate scope for each "y" above): - <> changeset d16fa068cf35374106ab5b841f414c6515e0284a Author: Canh Van Truong <canh.v.tru...@dektech.com.au> Date: Mon, 21 Nov 2016 17:19

[devel] [PATCH 1 of 3] log: implement SaLogFilterSetCallbackT [#2146]

src/log/agent/lga.h |3 + src/log/agent/lga_mds.c | 70 + src/log/agent/lga_util.c | 63 - src/log/apitest/logtest.c |2 +- src/log/apitest/logtestfr.c |2 +-

[devel] [PATCH 2 of 3] log: Add minor version checking in log server [#2146]

src/log/Makefile.am |2 + src/log/common/lgsv_defs.h |4 + src/log/common/lgsv_msg.h|2 +- src/log/logd/lgs_cb.h|1 + src/log/logd/lgs_evt.cc | 92 - src/log/logd/lgs_mbcsv.cc| 176 ++

[devel] [PATCH 3 of 3] log: fix checking version in log agent [#2146]

src/log/agent/lga_api.c | 55 -- src/log/apitest/tet_saLogFilterSetCallbackT.c | 53 ++ src/log/apitest/tet_saLogInitialize.c | 23 +++ 3 files changed, 117 insertions(+), 14 deletions(-) Fix checking

[devel] [PATCH 1 of 1] ntf: fix to keep MDS connection when last client finalize [#1895]

osaf/libs/agents/saf/ntfa/ntfa_api.c | 1 + osaf/libs/agents/saf/ntfa/ntfa_util.c | 19 - tests/ntfsv/tet_saNtfFinalize.c | 36 -- 3 files changed, 43 insertions(+), 13 deletions(-) Currently, when finalizing the last client, ntfa

[devel] [PATCH 0 of 1] Review Request for ntf: fix to keep MDS connection when last client finalize [#1895]

n Tests n Other n Comments (indicate scope for each "y" above): - <> changeset 784fee5121ce68004d8cf54ac2a44d7ee1010610 Author: Canh Van Truong <canh.v.tru...@dektech.com.au> Date: Thu

[devel] [PATCH 0 of 1] Review Request for log: fix errors reported by cppcheck version 1.75 [#1985]

n Other n Comments (indicate scope for each "y" above): - <> changeset 4e9e6609b7e9e19ce3a7b58a6addc51ce030df90 Author: Canh Van Truong <canh.v.tru...@dektech.com.au> Date: Tue, 30 Aug 2016 18:13:01 +

[devel] [PATCH 1 of 1] log: fix errors reported by cppcheck version 1.75 [#1985]

osaf/services/saf/logsv/lgs/lgs_clm.cc | 2 +- osaf/services/saf/logsv/lgs/lgs_evt.cc | 3 ++- tests/logsv/tet_LogOiOps.c | 4 ++-- tests/logsv/tet_log_longDN.c | 2 +- 4 files changed, 6 insertions(+), 5 deletions(-) Fix errors, reported by cppcheck:

[devel] [PATCH 0 of 1] Review Request for log: fix cppcheck with performance severity [#1975]

n Comments (indicate scope for each "y" above): - <> changeset b0e067eac8805b29ff6ae0c7be278dc6b4b29da3 Author: Canh Van Truong <canh.v.tru...@dektech.com.au> Date: Wed, 31 Aug 2016 14:02:16 +0700

[devel] [PATCH 1 of 1] log: fix cppcheck with performance severity [#1975]

osaf/services/saf/logsv/lgs/lgs_config.cc | 35 -- osaf/services/saf/logsv/lgs/lgs_file.cc | 4 +- 2 files changed, 16 insertions(+), 23 deletions(-) Fix performance reported by cppcheck. diff --git a/osaf/services/saf/logsv/lgs/lgs_config.cc

[devel] [PATCH 1 of 1] log: fix ER syslog when running logtest 5 2 [#1864]

tests/logsv/tet_LogOiOps.c | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-) Not wait for apply callback in logtest 5 2 done before removing test directory (in this test case, it changes 'logRootDirectory' attribute, then there are action of renames files) The patch adds a

[devel] [PATCH 0 of 1] Review Request for log: fix ER syslog when running logtest 5 2 [#1864]

y Other n Comments (indicate scope for each "y" above): - <> changeset 3e9c9af1418505eef1fd5165dbec9d10d5e9ff7b Author: Canh Van Truong <canh.v.tru...@dektech.com.au> Date: Fri, 16 Sep 2016 14:44:01 +070

[devel] [PATCH 0 of 1] Review Request for ntf: convert LOG_ER to LOG_WA [#1895]

n Comments (indicate scope for each "y" above): - <> changeset 90bbf4c9edf89d76c1dadc3992ee50891a6a39ba Author: Canh Van Truong <canh.v.tru...@dektech.com.au> Date: Thu, 22 Sep 2016 14:12:01 +0700 ntf: co

[devel] [PATCH 1 of 1] ntf: convert LOG_ER to LOG_WA [#1895]

osaf/services/saf/ntfsv/ntfs/NtfAdmin.cc | 2 +- osaf/services/saf/ntfsv/ntfs/NtfClient.cc | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) When unsubscribe() and finalize() do in parallel, ntfd may process finalize request first. It delete client and anything relate to this client.

[devel] [PATCH 1 of 1] ntf: fix ntfa does not remove subscriber in subscriberNoList at finalize [#1978]

osaf/libs/agents/saf/ntfa/ntfa_api.c | 2 + osaf/libs/agents/saf/ntfa/ntfa_util.c| 68 +++ tests/ntfsv/tet_saNtfNotificationSubscribe.c | 32 + 3 files changed, 81 insertions(+), 21 deletions(-) In finalize(), ntfa deletes client and does

[devel] [PATCH 0 of 1] Review Request for ntf: fix ntfa does not remove subscriber in subscriberNoList at finalize [#1978]

n Tests n Other n Comments (indicate scope for each "y" above): - <> changeset 888330024955b7d2b56b5cbca1222f34c6e0cba9 Author: Canh Van Truong <canh.v.tru...@dektech.com.au> Date: Mon

[devel] [PATCH 1 of 1] log: fix the usage of command saflogger [#2073]

osaf/tools/saflog/saflogger/saf_logger.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) The runtime app stream name must start with "safLgStr=", not "safLgStrCfg=". So, creating app stream name with "safLgStrCfg=" will result "SA_AIS_ERR_INVALID_PARAM". diff --git

[devel] [PATCH 0 of 1] Review Request for log: improve test cases for log service [#1913] V3

n Comments (indicate scope for each "y" above): - <> changeset 8e2f140baa544f82c11a1661bfe9c7e9ca4cc3b4 Author: Canh Van Truong <canh.v.tru...@dektech.com.au> Date: Thu, 13 Oct 2016 15:19:50 +0700 log: impr

[devel] [PATCH 1 of 1] log: implement SaLogFilterSetCallbackT [#2146]

osaf/libs/agents/saf/lga/lga.h|7 +- osaf/libs/agents/saf/lga/lga_api.c|4 +- osaf/libs/agents/saf/lga/lga_mds.c| 72 +- osaf/libs/agents/saf/lga/lga_util.c | 58 - osaf/libs/common/logsv/include/lgsv_msg.h |8 +

[devel] [PATCH 0 of 1] Review Request for log: implement SaLogFilterSetCallbackT [#2146]

n Comments (indicate scope for each "y" above): - <> changeset 88c5d5c965a8d4df1a07ad9a2ca62f27a452bc5b Author: Canh Van Truong <canh.v.tru...@dektech.com.au> Date: Wed, 09 Nov 2016 17:05:11 +0700

[devel] [PATCH 0 of 1] Review Request for log: improve test cases for log service [#1913] V2

n Comments (indicate scope for each "y" above): - <> changeset 2fd2c08225292a0afe38a583bf71fbde137909a8 Author: Canh Van Truong <canh.v.tru...@dektech.com.au> Date: Thu, 06 Oct 2016 18:55:51 +0700 log: impr

[devel] [PATCH 1 of 1] log: fix bad file discriptor error when changing imm attributes[#2215]

osaf/services/saf/logsv/lgs/lgs_imm.cc| 14 +- osaf/services/saf/logsv/lgs/lgs_mbcsv.cc | 2 +- osaf/services/saf/logsv/lgs/lgs_stream.cc | 38 ++ 3 files changed, 26 insertions(+), 28 deletions(-) Issues: This is happen when changing IMM attribute

[devel] [PATCH 0 of 1] Review Request for log: fix bad file discriptor error when changing imm attributes[#2215]

n Other n Comments (indicate scope for each "y" above): - <> changeset 66accd7c9d76e86e51bdd6fb54735e48669c9e16 Author: Canh Van Truong <canh.v.tru...@dektech.com.au> Date: Fri, 02 Dec 2016 12:02:20 +

[devel] [PATCH 0 of 1] Review Request for log: implement SaLogFilterSetCallbackT [#2146] V2

n Comments (indicate scope for each "y" above): - <> changeset b185bb5573f918100ca64e4c69e7d26c55bf5cfc Author: Canh Van Truong <canh.v.tru...@dektech.com.au> Date: Mon, 21 Nov 2016 17:19:56 +0700

[devel] [PATCH 1 of 1] log: implement SaLogFilterSetCallbackT [#2146]

src/log/agent/lga.h |3 + src/log/agent/lga_api.c |2 +- src/log/agent/lga_mds.c | 70 + src/log/agent/lga_util.c | 60 - src/log/apitest/logtest.c |2 +-

[devel] [PATCH 0 of 1] Review Request for log: fix log file is changed during si-swap [#2247]

n Comments (indicate scope for each "y" above): - <> changeset a65658906da03af4c737cb361846f4be2b77c74e Author: Canh Van Truong <canh.v.tru...@dektech.com.au> Date: Fri, 30 Dec 2016 05:11:55 +0700

[devel] [PATCH 1 of 1] log: fix log file is changed during si-swap [#2247]

osaf/services/saf/logsv/lgs/lgs_stream.cc | 5 - 1 files changed, 4 insertions(+), 1 deletions(-) The log file is changed during si-swap after patch for #2215 is applied. This patch fix to reopen the old log file after si-swap diff --git a/osaf/services/saf/logsv/lgs/lgs_stream.cc

[devel] [PATCH 1 of 1] log: fix log file size is not reset to zero (0) when log file is created [#1439]

src/log/apitest/tet_LogOiOps.c | 92 ++ src/log/logd/lgs_stream.cc | 3 + 2 files changed, 95 insertions(+), 0 deletions(-) When updating attributes of log file, the log server closes the opening cfg/log log files and creates new ones. The problem

[devel] [PATCH 0 of 1] Review Request for log: fix log file size is not reset to zero (0) when log file is created [#1439]

Tests n Other n Comments (indicate scope for each "y" above): - <> changeset 52e2c5055538c858149ad0fb9a730119d90ff137 Author: Canh Van Truong <canh.v.tru...@dektech.com.au> Date: Wed, 22 M

Re: [devel] [PATCH 1 of 1] log: fix both active and standby sites own the same log file name [#2383]

: Thursday, March 23, 2017 4:40 AM To: Canh Van Truong <canh.v.tru...@dektech.com.au>; lennart.l...@ericsson.com; vu.m.ngu...@dektech.com.au Cc: opensaf-devel@lists.sourceforge.net Subject: Re: [PATCH 1 of 1] log: fix both active and standby sites own the same log file name [#2383] Hi Canh, On 3/1

[devel] [PATCH 1 of 1] log: fix both active and standby sites own the same log file name [#2383]

src/log/logd/lgs_amf.cc| 4 +--- src/log/logd/lgs_evt.cc| 9 + src/log/logd/lgs_stream.cc | 4 ++-- 3 files changed, 12 insertions(+), 5 deletions(-) The issues: It's happen because when switchover, active side switch to quiesced. For short period (MDS's quiesced

[devel] [PATCH 0 of 1] Review Request for log: fix both active and standby sites own the same log file name [#2383]

n Other n Comments (indicate scope for each "y" above): - <> changeset f0480d40a0a89b3523dd4dcbc45c91e47a335da4 Author: Canh Van Truong <canh.v.tru...@dektech.com.au> Date: Thu, 16 Mar 2017 14:55

[devel] [PATCH 0/1] Review Request for log: fix checkpoint dest_names in open stream request [#2434]

revision 6611e01803e6550db3c341f53ce01f326435cc73 Author: Canh Van Truong <canh.v.tru...@dektech.com.au> Date: Thu, 20 Apr 2017 17:12:27 +0200 log: fix checkpoint dest_names in open stream request [#2434] The patch add dest_names in checkpointing at open stream request. C

[devel] [PATCH 1/1] log: fix checkpoint dest_names in open stream request [#2434]

The patch add dest_names in checkpointing at open stream request. --- src/log/logd/lgs_evt.cc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/log/logd/lgs_evt.cc b/src/log/logd/lgs_evt.cc index 6972efe55..fcc02de63 100644 --- a/src/log/logd/lgs_evt.cc +++ b/src/log/logd/lgs_evt.cc @@

[devel] [PATCH 0 of 1] Review Request for log: fix logd crash on Active side [#2362] V1

n Comments (indicate scope for each "y" above): - <> changeset 6b6162e1155fe44e87a1a38599acfdd49128a909 Author: Canh Van Truong <canh.v.tru...@dektech.com.au> Date: Mon, 13 Mar 2017 12:10:19 +0100 log: fix log

[devel] [PATCH 1 of 1] log: fix logd crash on Active side [#2362]

src/log/logd/lgs_filehdl.cc | 21 + 1 files changed, 13 insertions(+), 8 deletions(-) The cause of issue is free cfg_namelist while struct dirent **cfg_namelist unallocated diff --git a/src/log/logd/lgs_filehdl.cc b/src/log/logd/lgs_filehdl.cc ---

[devel] [PATCH 1 of 1] log: fix logd crash on Active side [#2362]

src/log/logd/lgs_filehdl.cc | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) The cause of issue is free cfg_namelist while struct dirent **cfg_namelist unallocated diff --git a/src/log/logd/lgs_filehdl.cc b/src/log/logd/lgs_filehdl.cc --- a/src/log/logd/lgs_filehdl.cc +++

[devel] [PATCH 0 of 1] Review Request for log: fix logd crash on Active side [#2362]

n Comments (indicate scope for each "y" above): - <> changeset 7e1a154d16851cdbfc3999eda94bf053d30d89f2 Author: Canh Van Truong <canh.v.tru...@dektech.com.au> Date: Fri, 10 Mar 2017 20:37:52 +0700 log: fix logd crash

Re: [devel] [PATCH 1 of 1] log: fix leak memory in socket destination handler [#2344]

Hi aVu, Ack Thanks Canh -Original Message- From: Vu Minh Nguyen [mailto:vu.m.ngu...@dektech.com.au] Sent: Monday, March 6, 2017 1:11 PM To: lennart.l...@ericsson.com; mahesh.va...@oracle.com; canh.v.tru...@dektech.com.au Cc: opensaf-devel@lists.sourceforge.net Subject: [PATCH 1 of 1]

Re: [devel] [PATCH 1 of 1] log: Fix all Cppcheck 1.77 issues [#2326] V1

Hi Mahesh, Ack from me. Thanks Canh -Original Message- From: mahesh.va...@oracle.com [mailto:mahesh.va...@oracle.com] Sent: Thursday, March 2, 2017 5:16 AM To: canh.v.tru...@dektech.com.au; lennart.l...@ericsson.com; vu.m.ngu...@dektech.com.au Cc: opensaf-devel@lists.sourceforge.net

[devel] [PATCH 1 of 1] log: fix to remove a redundant double quotation [#1463]

src/log/logd/lgs_fmt.cc | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-) When sending a log record which is longer than limited quota, there will be a double quotation mark although there is not double quotation in token format. The patch remove it. diff --git

[devel] [PATCH 0 of 1] Review Request for log: fix to remove a redundant double quotation [#1463]

Other n Comments (indicate scope for each "y" above): - <> changeset 646d0c9da4b6753a271cb17746d53243bd5522ee Author: Canh Van Truong <canh.v.tru...@dektech.com.au> Date: Mon, 27 Feb 2017 19:15:03 +0700

Re: [devel] Review request log: Update LOG PR document with version 5.2 enhancements [#2200]

<vu.m.ngu...@dektech.com.au>; Canh Van Truong <canh.v.tru...@dektech.com.au>; 'A V Mahesh' <mahesh.va...@oracle.com>; opensaf-devel@lists.sourceforge.net Subject: RE: Review request log: Update LOG PR document with version 5.2 enhancements [#2200] Hi I have done a number of

[devel] [PATCH 1 of 1] log: fix the problem cause the logtest 5 17 failed [#2328]

src/log/apitest/tet_cfg_destination.c | 249 ++--- 1 files changed, 136 insertions(+), 113 deletions(-) Some test cases in test suite 18 has not cleared logRecordDestinationConfiguratin attribute that causes the test case logtest 5 17 fail after running test suite

[devel] [PATCH 0 of 1] Review Request for log: fix the problem cause the logtest 5 17 failed [#2328] V1

n Other n Comments (indicate scope for each "y" above): - <> changeset c94514159f88fbd3a741a45330c42d96722ffba5 Author: Canh Van Truong <canh.v.tru...@dektech.com.au> Date: Fri, 03 Mar 2017 08:43:22 +

[devel] [PATCH 0/1] Review Request for log: fix log supported maximum 2047 characters for long DN [#2525]

ERIES HERE *** revision 81ba7f3323ab58677b706ca60075cf5b031cc4db Author: Canh Van Truong <canh.v.tru...@dektech.com.au> Date: Wed, 12 Jul 2017 14:56:34 +0700 log: fix log supported maximum 2047 characters for long DN [#2525] Currently, log support maximum 2047 characters for long DN. it should supp

Re: [devel] [PATCH 0/1] Review Request for log: fix log supported maximum 2047 characters for long DN [#2525]

Hi Mahesh, Could you help look at this patch? Thanks, Canh -Original Message- From: Canh Van Truong [mailto:canh.v.tru...@dektech.com.au] Sent: Wednesday, July 12, 2017 3:11 PM To: lennart.l...@ericsson.com; vu.m.ngu...@dektech.com.au; mahesh.va...@oracle.com Cc: opensaf-devel

[devel] [PATCH 0/1] Review Request for log: fix cppcheck, cpplint and reorganize headers - part 1 [#2445]

revision 8a7192da8b78065734da197211f19d4914706926 Author: Canh Van Truong <canh.v.tru...@dektech.com.au> Date: Thu, 20 Jul 2017 13:21:52 +0700 log: fix cppcheck, cpplint and reorganize headers - part 1 [#2445] Fix cppcheck, cpplint, replace nullptr for following files: - lgs_amf.*, lgs_co

Re: [devel] [PATCH 1/1] log: fix coredump generated by referencing to un-initialized pointer [#2534]

Ack from me. Thanks, Canh -Original Message- From: Vu Minh Nguyen [mailto:vu.m.ngu...@dektech.com.au] Sent: Tuesday, July 25, 2017 3:09 PM To: mahesh.va...@oracle.com; lennart.l...@ericsson.com; canh.v.tru...@dektech.com.au Cc: opensaf-devel@lists.sourceforge.net; Vu Minh Nguyen

[devel] [PATCH 0/1] Review Request for log: update test case logtest 2 51 [#2515]

revision 53c037454566f1858ce68266af3f1397171089c6 Author: Canh Van Truong <canh.v.tru...@dektech.com.au> Date: Fri, 30 Jun 2017 13:49:42 +0700 log: update test case logtest 2 51 [#2515] Test case logtest 2 51 takes more than 3 minutes. The patch updates this test case as following: 1/ Thread reports fail

Re: [devel] [PATCH 1/1] log: fix checkpoint dest_names in open stream request [#2434]

for checkpoint data. In "proc_stream_close_msg", the valid client_id was updated for checkpoint data when check-pointing. Thanks Canh -Original Message- From: A V Mahesh [mailto:mahesh.va...@oracle.com] Sent: Thursday, April 27, 2017 10:35 AM To: Canh Van Truong <canh.v.tru...@dektech.co

Re: [devel] [PATCH 1/1] log: fix checkpoint dest_names in open stream request [#2434]

Hi Mahesh, Handling of checkpoint for stream close is in several places. Maybe we could refactor to handle in one place to make clean code. But it is not related to this ticket. We could refactor it in later ? Regards Canh -Original Message- From: Canh Van Truong [mailto:canh.v.tru

Re: [devel] [PATCH 1/1] log: fix checkpoint dest_names in open stream request [#2434]

- From: A V Mahesh [mailto:mahesh.va...@oracle.com] Sent: Thursday, April 27, 2017 8:20 AM To: Canh Van Truong <canh.v.tru...@dektech.com.au>; lennart.l...@ericsson.com; vu.m.ngu...@dektech.com.au Cc: opensaf-devel@lists.sourceforge.net Subject: Re: [PATCH 1/1] log: fix checkpoint dest_names i

[devel] [PATCH 0/1] Review Request for log: fix checkpoint dest_names in open stream request [#2434] V2

revision 1d2ac4af3b9f8a423de7a01969871432fce7e20c Author: Canh Van Truong <canh.v.tru...@dektech.com.au> Date: Tue, 25 Apr 2017 15:19:47 +0200 log: fix checkpoint dest_names in open stream request [#2434] Handling of checkpoint for stream open is in serveral places. Handling of chec

[devel] [PATCH 1/1] log: fix checkpoint dest_names in open stream request [#2434]

Handling of checkpoint for stream open is in serveral places. Handling of checkpoint is called in proc_stream_open_msg forgot to add checkpoint of destination name. Refactor so that handling of checkpoint data for stream open is done in one place and destination name was already added in

Re: [devel] [PATCH 1/1] log: fix agent gets TRY_AGAIN instead TIMEOUT during failover [#2411]

Hi Mahesh, We will check your concern and reply to you later Thanks Canh -Original Message- From: A V Mahesh [mailto:mahesh.va...@oracle.com] Sent: Thursday, May 11, 2017 5:36 AM To: Lennart Lund <lennart.l...@ericsson.com>; Canh Van Truong <canh.v.tru...@dektech.com.au&

Re: [devel] [PATCH 1/1] log: fix agent gets TRY_AGAIN instead TIMEOUT during failover [#2411]

Hi Mahesh, Thanks for your update. Please check my comments. Regards Canh -Original Message- From: A V Mahesh [mailto:mahesh.va...@oracle.com] Sent: Wednesday, May 10, 2017 6:21 AM To: Canh Van Truong <canh.v.tru...@dektech.com.au>; lennart.l...@ericsson.com; vu

[devel] [PATCH 1/1] log: fix log agent does not use client version when recovery [#2457]

When log agent recover the client, it uses the highest version that log agent supported to re-intialize client. It should use the client version to re-initialize client. --- src/log/agent/lga_state.cc | 14 +- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git

[devel] [PATCH 0/1] Review Request for log: fix log agent does not use client version when recovery [#2457]

ERIES HERE *** revision 79219dd149035c2c54433c0f81fb3f7c2ac727be Author: Canh Van Truong <canh.v.tru...@dektech.com.au> Date: Wed, 24 May 2017 13:48:34 +0200 log: fix log agent does not use client version when recovery [#2457] When log agent recover the client, it uses the highest version that log

[devel] [PATCH 0/1] Review Request for log: process TRY AGAIN in logtest 2 40 and logtest 2 41 [#2453] V2

revision 5343e617f72b4f3569ff1def7ddb2bb888bc1705 Author: Canh Van Truong <canh.v.tru...@dektech.com.au> Date: Mon, 8 May 2017 09:29:49 +0200 log: process TRY AGAIN in logtest 2 40 and logtest 2 41 [#2453] Re-write again in case test cases receive write ack with TRY AGAIN error C

[devel] [PATCH 1/1] log: process TRY AGAIN in logtest 2 40 and logtest 2 41 [#2453]

Re-write again in case test cases receive write ack with TRY AGAIN error --- src/log/apitest/tet_saLogStreamOpen_2.c | 1 - src/log/apitest/tet_saLogWriteLogCallbackT.c | 49 +--- 2 files changed, 37 insertions(+), 13 deletions(-) diff --git

[devel] [PATCH 0/1] Review Request for log: process TRY AGAIN in logtest 2 40 and logtest 2 41 [#2453]

revision c5051f74c3556b19f4a13d0460312dc393de3a8f Author: Canh Van Truong <canh.v.tru...@dektech.com.au> Date: Fri, 5 May 2017 09:55:57 +0200 log: process TRY AGAIN in logtest 2 40 and logtest 2 41 [#2453] Re-write again in case test cases receive write ack with TRY AGAIN error C

[devel] [PATCH 1/1] log: process TRY AGAIN in logtest 2 40 and logtest 2 41 [#2453]

Re-write again in case test cases receive write ack with TRY AGAIN error --- src/log/apitest/logutil.c| 11 + src/log/apitest/logutil.h| 3 +++ src/log/apitest/tet_saLogStreamOpen_2.c | 1 - src/log/apitest/tet_saLogWriteLogCallbackT.c | 34

[devel] [PATCH 1/1] log: fix agent gets TRY_AGAIN instead TIMEOUT during failover [#2411]

During testing, e.g: use saflogger in loop to send a log record to log service during failover, we frequently encounter saLogStreamClose() or saLogFinalize() get SA_AIS_ERR_TIMEOUT as active LOG service is shutdown while agent requests still remain in mailbox. The close request has come to active

[devel] [PATCH 0/1] Review Request for log: fix agent gets TRY_AGAIN instead TIMEOUT during failover [#2411]

revision 02bc316879a3d94aa3653ff07af17ea9a967bde1 Author: Canh Van Truong <canh.v.tru...@dektech.com.au> Date: Fri, 5 May 2017 13:32:49 +0200 log: fix agent gets TRY_AGAIN instead TIMEOUT during failover [#2411] During testing, e.g: use saflogger in loop to send a log record to lo

[devel] [PATCH 1/1] log: fix test case logtest 5 2 failed due to logsv is busy [#2600]

When changing root directory (immcfg -a logRootDirectory=NEW_ROOT logConfig=1,safApp=safLogService), The "NEW_ROOT" need to be verify if it is writeable in ccb_completed_callback by log server. But log server is busy in sometimes cause test case fails. The patch fixes test case do retry the

[devel] [PATCH 0/1] Review Request for log: fix test case logtest 5 2 failed due to logsv is busy [#2600]

revision 7cc46b6b70e55140c1f979935eacd68cd2d3d536 Author: Canh Van Truong <canh.v.tru...@dektech.com.au> Date: Mon, 9 Oct 2017 18:14:10 +0700 log: fix test case logtest 5 2 failed due to logsv is busy [#2600] When changing root directory (immcfg -a logRootDirectory=NEW_ROOT logConfig=1,safA

Re: [devel] [PATCH 1/1] log: update target log file location [#2635]

Ack (the test case passed with new changes) Thanks Canh -Original Message- From: Vu Minh Nguyen [mailto:vu.m.ngu...@dektech.com.au] Sent: Thursday, October 19, 2017 2:28 PM To: lennart.l...@ericsson.com; canh.v.tru...@dektech.com.au Cc: opensaf-devel@lists.sourceforge.net; Vu Minh

[devel] [PATCH 0/1] Review Request for log: fix coredump when stop cluster [#2700]

revision 7ccc061660d5bd3f395954915f6879fba38474a2 Author: Canh Van Truong <canh.v.tru...@dektech.com.au> Date: Thu, 23 Nov 2017 17:32:05 +0700 log: fix coredump when stop cluster [#2700] The problem happen because the iterator after erasing the element will be invalid. The patch fix to increase the iterat

[devel] [PATCH 1/1] log: fix coredump when stop cluster [#2700]

The problem happen because the iterator after erasing the element will be invalid. The patch fix to increase the iterator before delete client --- src/log/logd/lgs_evt.cc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/log/logd/lgs_evt.cc b/src/log/logd/lgs_evt.cc

[devel] [PATCH 0/1] Review Request for ntf: fix ntfd remove client in standby node while not finalize in active node [#2705]

ERIES HERE *** revision 000f9f9a3d698db90278f2b7b2b9eeeaf9b9accf Author: Canh Van Truong <canh.v.tru...@dektech.com.au> Date: Fri, 1 Dec 2017 12:16:43 +0700 ntf: fix ntfd remove client in standby node while not finalize in active node [#2705] The issue happen because the clients are remove

[devel] [PATCH 1/1] ntf: fix ntfd remove client in standby node while not finalize in active node [#2705]

The issue happen because the clients are removed in both active and standby node when getting NCSMDS_DOWN event. In standby node, ntfd get NCSMDS_DOWN event is slower than next initialize request. This cause the ntfd will removed all client from data base including new client of next initialze.

[devel] [PATCH 0/1] Review Request for ntf: fix [fix ntfd remove client in standby node while not finalize in active node V2 [#2705]

ERIES HERE *** revision 0e18a731840dfa2240ccdafc23f0ccbfdc9e81f7 Author: Canh Van Truong <canh.v.tru...@dektech.com.au> Date: Mon, 18 Dec 2017 11:41:12 +0700 ntf: fix [fix ntfd remove client in standby node while not finalize in active node [#2705] The issue happen because the clients are

[devel] [PATCH 0/1] Review Request for log: fix log agent may crash after recovery fails [#2670]

revision 980226974b1ab266b068eded487e6ce26b9645c0 Author: Canh Van Truong <canh.v.tru...@dektech.com.au> Date: Thu, 9 Nov 2017 10:14:53 +0700 log: fix log agent may crash after recovery fails [#2670] In log api, the client is deleted from the list in the agent after recovery fails. there is no chec

[devel] [PATCH 1/1] log: fix log agent may crash after recovery fails [#2670]

In log api, the client is deleted from the list in the agent after recovery fails. there is no check if this client is used by other user. The patch fix to make sure that the deletion is just processed when it is not being used. --- src/log/agent/lga_agent.cc | 62

Re: [devel] [PATCH 1/1] log: fix coredump when stop cluster [#2700]

...@ericsson.com] Sent: Thursday, December 7, 2017 8:25 PM To: Canh Van Truong <canh.v.tru...@dektech.com.au>; Vu Minh Nguyen <vu.m.ngu...@dektech.com.au>; srinivas.mangip...@oracle.com Cc: opensaf-devel@lists.sourceforge.net; Canh Van Truong <canh.v.tru...@dektech.com.au> Subject: R

Re: [devel] [PATCH 1/1] ntf: fix ntfd remove client in standby node while not finalize in active node [#2705]

Hi aMinh, Please see my comment. Regards Canh From: Minh Hon Chau [mailto:minh.c...@dektech.com.au] Sent: Wednesday, December 6, 2017 7:20 AM To: Canh Van Truong <canh.v.tru...@dektech.com.au> Cc: opensaf-devel@lists.sourceforge.net Subject: Re: [PATCH 1/1] ntf: fix ntfd

[devel] [PATCH 0/1] Review Request for log: fix cpplint, cppcheck, replace NULL - Part2 [#2445]

revision 10e839bc7c0a7a5cd9ba1f0a495e6c15dc86b8b7 Author: Canh Van Truong <canh.v.tru...@dektech.com.au> Date: Mon, 30 Oct 2017 17:59:58 +0700 log: fix cpplint, cppcheck, replace NULL - Part2 [#2445] Fix cppcheck, cpplint, replace nullptr for following files: lgs_stream.*, lgs_recov.*, lgs_mds.*, lgs_imm.*, lgs

[devel] [PATCH 0/1] Review Request for fix logtest 4 56 fail because egrep log file fail [#2662]

revision 3e6d9287e23a523f650a5be71aeb628aa8011963 Author: Canh Van Truong <canh.v.tru...@dektech.com.au> Date: Tue, 31 Oct 2017 14:33:01 +0700 log: fix logtest 4 56 fail because egrep log file fail [#2662] In test case logtest 4 56, it verifies that whether written log file format is reflected cor

[devel] [PATCH 1/1] log: fix logtest 4 56 fail because egrep log file fail [#2662]

In test case logtest 4 56, it verifies that whether written log file format is reflected correctly. It finds and checks the log file that has been closed (FILENAME_MMDD_HHMMSS_MMDD_HHMMSS.log). But sometimes the log file has not been closed successfully due to timeout reason, this cause

[devel] [PATCH 1/1] ntf: remove sending SIGTERM and SIGABRT when killing osafntfimcnd [#2851]

The handler of SIGTERM is just _Exit, so using SIGTERM/SIGABRT is not needed. The patch changes to send SIGKILL when terminating osafntfimcnd process. --- src/ntf/ntfd/ntfs_imcnutil.c| 136 +++- src/ntf/ntfimcnd/ntfimcn_main.c | 18 -- 2 files

Re: [devel] [PATCH 1/1] ntf: remove sending SIGTERM and SIGABRT when killing osafntfimcnd [#2851]

) ? Regards Canh -Original Message- From: Vu Minh Nguyen <vu.m.ngu...@dektech.com.au> Sent: Wednesday, May 9, 2018 4:33 PM To: 'Canh Van Truong' <canh.v.tru...@dektech.com.au>; lennart.l...@ericsson.com; minh.c...@dektech.com.au Cc: opensaf-devel@lists.sourceforge.net Subject: RE:

[devel] [PATCH 0/1] Review Request for ntf: remove sending SIGTERM and SIGABRT when killing osafntfimcnd [#2851]

ERIES HERE *** revision 54579eaa3f6cd05492e0f13f7e3c7835168cc81f Author: Canh Van Truong <canh.v.tru...@dektech.com.au> Date: Wed, 9 May 2018 15:16:25 +0700 ntf: remove sending SIGTERM and SIGABRT when killing osafntfimcnd [#2851] The handler of SIGTERM is just _Exit, so using SIGTERM/SIGAB

[devel] [PATCH 1/1] ntf: remove sending SIGTERM and SIGABRT when killing osafntfimcnd [#2851]

The handler of SIGTERM is just _Exit, so using SIGTERM/SIGABRT is not needed. The patch changes to send SIGKILL when terminating osafntfimcnd process. --- src/ntf/ntfd/ntfs_imcnutil.c| 100 src/ntf/ntfimcnd/ntfimcn_main.c | 18 2 files

[devel] [PATCH 0/1] Review Request for ntf: remove sending SIGTERM and SIGABRT when killing osafntfimcnd V2 [#2851]

ERIES HERE *** revision 6f811f16f7bcaca6b67dd624f8a184ca4135ab9d Author: Canh Van Truong <canh.v.tru...@dektech.com.au> Date: Wed, 9 May 2018 21:32:48 +0700 ntf: remove sending SIGTERM and SIGABRT when killing osafntfimcnd [#2851] The handler of SIGTERM is just _Exit, so using SIGTERM/SIGAB

Re: [devel] [PATCH 1/1] ntf: fix ntfimcnd issue with empty SaNameT [#2854]

Hi aHoa, Ack Thanks Canh -Original Message- From: Hoa Le Sent: Saturday, May 19, 2018 3:18 PM To: minh.c...@dektech.com.au; lennart.l...@ericsson.com; srinivas.mangip...@oracle.com; canh.v.tru...@dektech.com.au Cc: opensaf-devel@lists.sourceforge.net; Hoa Le

[devel] [PATCH 1/1] log: fix saLogFilterSetCallbackT_03 fails [#2875]

When using immadm command to change saLogStreamSeverityFilter attribute in runtime object, the adminOperationCallback is called to update the attribute value to imm then send the filter callback to user. sometimes the return of command immadm come before the filter callback. if user poll the

[devel] [PATCH 0/1] Review Request for log: fix saLogFilterSetCallbackT_03 fails [#2875]

revision 86a719f65a401ab51b6b60e110dd97ea395080d8 Author: Canh Van Truong Date: Wed, 13 Jun 2018 17:23:22 +0700 log: fix saLogFilterSetCallbackT_03 fails [#2875] When using immadm command to change saLogStreamSeverityFilter attribute in runtime object, the adminOperationCallback is called to update the attribute va

  1   2   3   >