[Openvpn-devel] [PATCH applied] Re: Combine extra_tun/frame parameter of frame_calculate_payload_overhead

2023-02-14 Thread Gert Doering
-devel@lists.sourceforge.net/msg26223.html Signed-off-by: Gert Doering -- kind regards, Gert Doering ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Re: [Openvpn-devel] [PATCH v3 2/3] Build unit tests in mingw Windows build

2023-02-14 Thread Gert Doering
Hi, On Sat, Feb 11, 2023 at 01:44:04PM -0500, Selva Nair wrote: > On Sat, Feb 11, 2023 at 1:32 PM Gert Doering wrote: > > > /bin/bash ../../../libtool --tag=CC --mode=link i686-w64-mingw32-gcc > > This is a 32 bit build which I never tried. Maybe cmocka is not built for &g

[Openvpn-devel] [PATCH applied] Re: dco-win: use proper calling convention on x86

2023-02-13 Thread Gert Doering
Acked-by: Gert Doering I'm no windows expert, but googling says "this is what you do for windows function calls". MinGW compiles without complaints, as does GHA. The GetOverlappedResultEx() can be cleaned up as soon as we drop Windows 7 support, not sure about the IsWow64Process

[Openvpn-devel] [PATCH applied] Re: Build unit tests in mingw Windows build

2023-02-13 Thread Gert Doering
abe Message-Id: <20230208005925.393200-1-selva.n...@gmail.com> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg26188.html Signed-off-by: Gert Doering -- kind regards, Gert Doering ___ Openvpn-devel

Re: [Openvpn-devel] [PATCH v3 2/3] Build unit tests in mingw Windows build

2023-02-11 Thread Gert Doering
libtool command line, but the error never changes... *scratch head* Need to debug this more tonight... gert -- "If was one thing all people took for granted, was conviction that if you feed honest figures into a computer, honest figures come out. Never doubted it myself till I

Re: [Openvpn-devel] [PATCH v3 2/3] Build unit tests in mingw Windows build

2023-02-10 Thread Gert Doering
rt -- "If was one thing all people took for granted, was conviction that if you feed honest figures into a computer, honest figures come out. Never doubted it myself till I met a computer with a sense of humor." Robert A. Heinlein, The Moo

[Openvpn-devel] [PATCH applied] Re: Add missing stdint.h includes in unit tests files

2023-02-10 Thread Gert Doering
9.org> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg26182.html Signed-off-by: Gert Doering -- kind regards, Gert Doering ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sour

[Openvpn-devel] [PATCH applied] Re: Get rid of unused 'bool tuntap_buffer' arguments.

2023-02-10 Thread Gert Doering
This time, it actually compiles on Linux *and* Windows... (GH says so :-) ). Patch has been applied to the master and release/2.6 branch. commit 092ceadb762a42a50191e38bd7cf0fe9f6528a59 (master) commit eca101ac4426442c1ad17e6a706d84c7960a8262 (release/2.6) Author: Gert Doering Date: Wed Feb 1

[Openvpn-devel] [PATCH applied] Re: Conditionally add subdir-objects option to automake

2023-02-10 Thread Gert Doering
<20230204004512.250271-1-selva.n...@gmail.com> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg26147.html Signed-off-by: Gert Doering -- kind regards, Gert Doering ___ Openvpn-devel mailing list Openvpn-de

[Openvpn-devel] [PATCH applied] Re: Allow certain DHCP options to be used without DHCP server

2023-02-10 Thread Gert Doering
envpn-devel@lists.sourceforge.net/msg26169.html Signed-off-by: Gert Doering -- kind regards, Gert Doering ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Re: [Openvpn-devel] [PATCH] get_addr_generic: fix server crash in freeaddrinfo on musl libc

2023-02-09 Thread Gert Doering
Hi, On Thu, Feb 09, 2023 at 10:09:45PM +0200, Mykhailo Mishchenko wrote: > On 09.02.23 21:38, Gert Doering wrote: > > (There is an old Trac ticket about it, but nobody went out and fixed > > the code yet - which is tricky, as you can't just change the format > > of ifc

Re: [Openvpn-devel] [PATCH] get_addr_generic: fix server crash in freeaddrinfo on musl libc

2023-02-09 Thread Gert Doering
you feed honest figures into a computer, honest figures come out. Never doubted it myself till I met a computer with a sense of humor." Robert A. Heinlein, The Moon is a Harsh Mistress Gert Doering - Munich, Germany g...@greenie

[Openvpn-devel] [PATCH applied] Re: Fix LibreSSL not building in Github Actions

2023-02-09 Thread Gert Doering
Acked-by: Gert Doering Arne has said I should not look at this patch. So I'm despearately looking elsewhere. I do not want to know. (Github says "it builds with this change") Your patch has been applied to the master branch. commit 589cca156357e05c6c3f07517184157585c8e9fc

Re: [Openvpn-devel] [PATCH] get_addr_generic: fix server crash in freeaddrinfo on musl libc

2023-02-09 Thread Gert Doering
nest figures come out. Never doubted it myself till I met a computer with a sense of humor." Robert A. Heinlein, The Moon is a Harsh Mistress Gert Doering - Munich, Germany g...@greenie.muc.de signature.asc Description: PGP sign

[Openvpn-devel] [PATCH applied] Re: Windows: fix unused variable in win32_get_arch

2023-02-07 Thread Gert Doering
Signed-off-by: Gert Doering -- kind regards, Gert Doering ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel

[Openvpn-devel] [PATCH applied] Re: Windows: fix wrong printf format in x_check_status

2023-02-07 Thread Gert Doering
Stipakov Message-Id: <20230207134333.52221-1-fr...@lichtenheld.com> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg26166.html Signed-off-by: Gert Doering -- kind regards, Gert Doering ___ Openvpn-d

[Openvpn-devel] [PATCH applied] Re: Windows: fix unused variables in delete_route_ipv6

2023-02-07 Thread Gert Doering
100 Windows: fix unused variables in delete_route_ipv6 Signed-off-by: Frank Lichtenheld Acked-by: Lev Stipakov Message-Id: <20230203191440.136050-3-fr...@lichtenheld.com> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg26140.html Signed-off-

[Openvpn-devel] [PATCH applied] Re: Windows: fix unused function setenv_foreign_option

2023-02-07 Thread Gert Doering
w.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg26145.html Signed-off-by: Gert Doering -- kind regards, Gert Doering ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Re: [Openvpn-devel] [PATCH 4/4] cryptoapi.c: simplify parsing of thumbprint hex string

2023-02-04 Thread Gert Doering
nlein, The Moon is a Harsh Mistress Gert Doering - Munich, Germany g...@greenie.muc.de signature.asc Description: PGP signature ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel

[Openvpn-devel] [PATCH applied] Re: block-dns using iservice: fix a potential double free

2023-02-02 Thread Gert Doering
://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg26130.html Signed-off-by: Gert Doering -- kind regards, Gert Doering ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel

[Openvpn-devel] [PATCH applied] Re: Changes.rst: document removal of --keysize

2023-02-01 Thread Gert Doering
Acked-by: Gert Doering Does what it says on the lid, not much to test here :-) Your patch has been applied to the master branch. commit b2e49465e6b837d97ecb3a4edbc06aba00584381 (master) commit c8e94242e31cf94a12f6e897191548be5c4893fe (release/2.6) Author: Frank Lichtenheld Date: Wed Feb 1 14

[Openvpn-devel] [PATCH applied] Re: Add printing USAN stack trace on github actions

2023-02-01 Thread Gert Doering
-by: Frank Lichtenheld Message-Id: <20230130172936.3444840-4-a...@rfc2549.org> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg26102.html Signed-off-by: Gert Doering -- kind regards, Gert Doering ___ Openv

[Openvpn-devel] [PATCH applied] Re: Update LibreSSL to 3.7.0 in Github actions

2023-02-01 Thread Gert Doering
Signed-off-by: Arne Schwabe Acked-by: Frank Lichtenheld Message-Id: <20230130172936.3444840-3-a...@rfc2549.org> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg26105.html Signed-off-by: Gert Doering -- kind regards, Gert D

[Openvpn-devel] [PATCH applied] Re: Fix unaligned access in auth-token

2023-02-01 Thread Gert Doering
-a...@rfc2549.org> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg26103.html Signed-off-by: Gert Doering -- kind regards, Gert Doering ___ Openvpn-devel mailing list Openvpn-devel@lists.sourc

[Openvpn-devel] [PATCH v3] Get rid of unused 'bool tuntap_buffer' arguments.

2023-02-01 Thread Gert Doering
m socket.c Signed-off-by: Gert Doering Acked-by: Arne Schwabe Message-Id: <20230130161730.110021-1-g...@greenie.muc.de> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg26099.html Signed-off-by: Gert Doering (cherry picked from commit bdc842d72e92995261bac357

Re: [Openvpn-devel] [PATCH v2] Get rid of unused 'bool tuntap_buffer' arguments.

2023-01-31 Thread Gert Doering
Hi, On Mon, Jan 30, 2023 at 04:17:30PM +, Gert Doering wrote: > overlapped_io_init() has a "bool tuntap_buffer" argument which is only > passed onwards to alloc_buf_sock_tun(), which does nothing with it. > > Remove from both functions. > > While at it, move all

Re: [Openvpn-devel] [PATCH v15] Add DNS SRV remote host discovery support

2023-01-31 Thread Gert Doering
feed honest figures into a computer, honest figures come out. Never doubted it myself till I met a computer with a sense of humor." Robert A. Heinlein, The Moon is a Harsh Mistress Gert Doering - Munich, Germany g...@greenie.muc.d

[Openvpn-devel] [PATCH v2] Get rid of unused 'bool tuntap_buffer' arguments.

2023-01-30 Thread Gert Doering
ed from win32.c / overlapped_io_init(). v2: move alloc_buf_sock_tun() to win32.c Signed-off-by: Gert Doering --- src/openvpn/mtu.c| 13 - src/openvpn/mtu.h| 7 --- src/openvpn/socket.c | 4 ++-- src/openvpn/tun.c| 4 ++-- src/openvpn/win32.c | 17 ++--- src/openvp

[Openvpn-devel] [PATCH] Get rid of unused 'bool tuntap_buffer' arguments.

2023-01-30 Thread Gert Doering
overlapped_io_init() has a "bool tuntap_buffer" argument which is only passed onwards to alloc_buf_sock_tun(), which does nothing with it. Remove from both functions. Signed-off-by: Gert Doering --- src/openvpn/mtu.c| 3 +-- src/openvpn/mtu.h| 3 +-- src/openvpn/socket.c | 4

[Openvpn-devel] [PATCH applied] Re: make dist: Ship ovpn_dco_freebsd.h, too

2023-01-28 Thread Gert Doering
Acked-by: Gert Doering To see the actual failure, one needs to build a tarball ("make dist"), and from that tarball, compile with "configure --enable-dco", on FreeBSD - so a pure "make distcheck" did not see it. Apologies for that oversight. Your patch has

[Openvpn-devel] [PATCH applied] Re: dco_linux: update license for ovpn_dco_linux.h

2023-01-25 Thread Gert Doering
Acked-by: Gert Doering (Formally I have no say in this, but someone has to say "yes, this is an acceptable change" - it's an import from ovpn-dco, Antonio is the author, and this was discussed before - so, in it goes) Your patch has been applied to the master and release/2.6

[Openvpn-devel] [PATCH applied] Re: openvpnmsica: fix adapters discovery logic for DCO

2023-01-25 Thread Gert Doering
DCO Signed-off-by: Lev Stipakov Acked-by: Selva Nair Message-Id: <20230124142316.441-1-lstipa...@gmail.com> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg26072.html Signed-off-by: Gert Doering -- k

[Openvpn-devel] [PATCH applied] Re: openvpnmsica: remove unused declarations

2023-01-24 Thread Gert Doering
Acked-by: Gert Doering Quite straightforward - "if the code is gone, we do not need prototypes in .h files either" :-) Not tested anything (beyond "push to mygithub" to be sure I did not overlook a ";" or anything). Your patch has been applied to the master a

[Openvpn-devel] [PATCH applied] Re: Fix one more 'existing route may get deleted' case

2023-01-23 Thread Gert Doering
Acked-by: Gert Doering This is identical to the "I already tested these" bits of v1, so didn't do more than "compare diffs" and "basic linux compile test" (with --enable-iproute2) plus "run binary once to see if errors are detected" (they are) toda

Re: [Openvpn-devel] [PATCH] Fix more "existing route may get deleted" cases

2023-01-21 Thread Gert Doering
eed honest figures into a computer, honest figures come out. Never doubted it myself till I met a computer with a sense of humor." Robert A. Heinlein, The Moon is a Harsh Mistress Gert Doering - Munich, Germany g...@greenie.muc.de sig

[Openvpn-devel] [PATCH applied] Re: Cleanup route error and debug logging on Windows

2023-01-20 Thread Gert Doering
58.html Signed-off-by: Gert Doering -- kind regards, Gert Doering ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel

[Openvpn-devel] [PATCH applied] Re: Warn when pkcs11-id or pkcs11-id-management options are ignored

2023-01-20 Thread Gert Doering
...@gmail.com> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg26056.html Signed-off-by: Gert Doering -- kind regards, Gert Doering ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://l

Re: [Openvpn-devel] [PATCH 2/2] Cleanup route error and debug logging on Windows

2023-01-20 Thread Gert Doering
r with a sense of humor." Robert A. Heinlein, The Moon is a Harsh Mistress Gert Doering - Munich, Germany g...@greenie.muc.de signature.asc Description: PGP signature ___ Openvpn-devel mailing list Openvpn

[Openvpn-devel] [PATCH applied] Re: openvpnmsica: remove dco installer custom actions

2023-01-19 Thread Gert Doering
Acked-by: Gert Doering As you all guessed, I'm a big fan of ripping out large chunks of stuff that I have no use for ;-) - seriously, moving windco into a MSM is the right thing, so we do not need the installer code here anymore. (I do not fully understand all the details in the grand sche

[Openvpn-devel] [PATCH applied] Re: Workaround: make ovpn-dco more reliable

2023-01-19 Thread Gert Doering
7.1240059-1-a...@rfc2549.org> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg25988.html Signed-off-by: Gert Doering -- kind regards, Gert Doering ___ Openvpn-devel mailing list Openvpn-devel@lists.sourc

[Openvpn-devel] [PATCH applied] Re: Don't clear capability bounding set on capng_change_id

2023-01-19 Thread Gert Doering
Acked-by: Gert Doering Thanks for so quickly coming to help with investigating the issue and providing a fix :-) I have not tested this myself, but the code change is trivial, and the positive effects have been verified in the GH issue. I have tested that "running a DCO p2mp instance as

[Openvpn-devel] [PATCH applied] Re: Repair special-casing of EEXIST for Linux/SITNL route install

2023-01-18 Thread Gert Doering
uot;) was also very straightforward. Patch has been applied to the master and release/2.6 branch. commit adc54f483b210484ff1488e01c8aee1b2b0ea477 (master) commit eb85961e72c927256ce9267a43f3519d3ab4edcb (release/2.6) Author: Gert Doering Date: Wed Jan 18 08:46:33 2023 +0100 Repair spe

Re: [Openvpn-devel] [Openvpn-users] 2.6rc2 server with DCO and 2.6rc2 client with DCO: not working

2023-01-18 Thread Gert Doering
ion to peer Signalling server->client is limited at this point, but maybe we could find a way to make this "AUTH_FAILED:server options incompatible with DCO" or so. Arne? gert -- "If was one thing all people took for granted, was conviction that if you feed honest figu

[Openvpn-devel] [PATCH v2] Repair special-casing of EEXIST for Linux/SITNL route install

2023-01-17 Thread Gert Doering
- so this change has no impact for the "delete" case) v2: use RTA_ macros, also adjust add_route_ipv6() Signed-off-by: Gert Doering --- src/openvpn/networking_sitnl.c | 6 +- src/openvpn/route.c| 24 ++-- 2 files changed, 19 insertions(+), 11 delet

[Openvpn-devel] [PATCH applied] Re: Define and use macros for route addition status code

2023-01-16 Thread Gert Doering
Acked-by: Gert Doering Thanks for this. I think it makes the code easier to read and understand, and having "the same constructs" used everywhere also helps with this (and thus, hopefully, less platform specific confusion in future ;-) ). I have stared at the code, manually double-

Re: [Openvpn-devel] Amend OpenVPN license to allow continued mbed TLS support (allow mbed TLS 3.x linking)

2023-01-15 Thread Gert Doering
Robert A. Heinlein, The Moon is a Harsh Mistress Gert Doering - Munich, Germany g...@greenie.muc.de signature.asc Description: PGP signature ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists

Re: [Openvpn-devel] [PATCH 1/2] Define and use macros for route addition status code

2023-01-15 Thread Gert Doering
t an extra return code variable... I'm fine with both approaches, but if we touch all these places at the same time, let's decide for one approach :-) - given the line length, using the "bool ret" approach for Android too sounds like a good choice. gert -- "If was o

Re: [Openvpn-devel] Amend OpenVPN license to allow continued mbed TLS support (allow mbed TLS 3.x linking)

2023-01-15 Thread Gert Doering
"If was one thing all people took for granted, was conviction that if you feed honest figures into a computer, honest figures come out. Never doubted it myself till I met a computer with a sense of humor." Robert A. Heinlein, The Moon is a Harsh Mistress Ge

Re: [Openvpn-devel] Amend OpenVPN license to allow continued mbed TLS support (allow mbed TLS 3.x linking)

2023-01-15 Thread Gert Doering
gures come out. Never doubted it myself till I met a computer with a sense of humor." Robert A. Heinlein, The Moon is a Harsh Mistress Gert Doering - Munich, Germany g...@greenie.muc.de signat

Re: [Openvpn-devel] Amend OpenVPN license to allow continued mbed TLS support (allow mbed TLS 3.x linking)

2023-01-15 Thread Gert Doering
was conviction that if you feed honest figures into a computer, honest figures come out. Never doubted it myself till I met a computer with a sense of humor." Robert A. Heinlein, The Moon is a Harsh Mistress Gert Doering - Munich, Germany

Re: [Openvpn-devel] Amend OpenVPN license to allow continued mbed TLS support (allow mbed TLS 3.x linking)

2023-01-15 Thread Gert Doering
exception. gert -- "If was one thing all people took for granted, was conviction that if you feed honest figures into a computer, honest figures come out. Never doubted it myself till I met a computer with a sense of humor." Robert A. Heinlein, The Moon is a Ha

Re: [Openvpn-devel] Amend OpenVPN license to allow continued mbed TLS support (allow mbed TLS 3.x linking)

2023-01-15 Thread Gert Doering
obert A. Heinlein, The Moon is a Harsh Mistress Gert Doering - Munich, Germany g...@greenie.muc.de signature.asc Description: PGP signature ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Re: [Openvpn-devel] Amend OpenVPN license to allow continued mbed TLS support (allow mbed TLS 3.x linking)

2023-01-15 Thread Gert Doering
a computer, honest figures come out. Never doubted it myself till I met a computer with a sense of humor." Robert A. Heinlein, The Moon is a Harsh Mistress Gert Doering - Munich, Germany g...@greenie.mu

[Openvpn-devel] [PATCH applied] Re: Fix OVPN_DEL_PEER_REASON_TRANSPORT_DISCONNECT breakage on FreeBSD+DCO

2023-01-13 Thread Gert Doering
(master) commit 480ad2a84e2983e8a1b61d537cf82da5c5141853 (release/2.6) Author: Gert Doering Date: Fri Jan 13 09:07:45 2023 +0100 Fix OVPN_DEL_PEER_REASON_TRANSPORT_DISCONNECT breakage on FreeBSD+DCO Signed-off-by: Gert Doering Acked-by: Antonio Quartulli Message-Id: <202301

Re: [Openvpn-devel] [PATCH] dco: print proper message in case of transport disconnection

2023-01-13 Thread Gert Doering
Robert A. Heinlein, The Moon is a Harsh Mistress Gert Doering - Munich, Germany g...@greenie.muc.de signature.asc Description: PGP signature ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel

[Openvpn-devel] [PATCH] Fix OVPN_DEL_PEER_REASON_TRANSPORT_DISCONNECT breakage on FreeBSD+DCO

2023-01-13 Thread Gert Doering
termediate bandaid, making the offending code in multi.c "linux only" while a better solution is discussed. Signed-off-by: Gert Doering --- src/openvpn/multi.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/openvpn/multi.c b/src/openvpn/multi.c index 99123c39..f2559016 1006

Re: [Openvpn-devel] [PATCH] dco: print proper message in case of transport disconnection

2023-01-12 Thread Gert Doering
omputer with a sense of humor." Robert A. Heinlein, The Moon is a Harsh Mistress Gert Doering - Munich, Germany g...@greenie.muc.de signature.asc Description: PGP signature ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Re: [Openvpn-devel] [PATCH] dco: send SIGUSR1 upon ping timeout

2023-01-12 Thread Gert Doering
puter, honest figures come out. Never doubted it myself till I met a computer with a sense of humor." Robert A. Heinlein, The Moon is a Harsh Mistress Gert Doering - Munich, Germany g...@greenie.muc.de signature.asc Description: PGP s

[Openvpn-devel] [PATCH applied] Re: dco: print proper message in case of transport disconnection

2023-01-12 Thread Gert Doering
proper message in case of transport disconnection Signed-off-by: Antonio Quartulli Acked-by: Lev Stipakov Message-Id: <20230111235052.24855-...@unstable.cc> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg25977.html Signed-off-by: Gert Do

Re: [Openvpn-devel] [PATCH] Repair special-casing of EEXIST for Linux/SITNL route install

2023-01-11 Thread Gert Doering
es into a computer, honest figures come out. Never doubted it myself till I met a computer with a sense of humor." Robert A. Heinlein, The Moon is a Harsh Mistress Gert Doering - Munich, Germany g...@greenie.m

[Openvpn-devel] [PATCH] Repair special-casing of EEXIST for Linux/SITNL route install

2023-01-11 Thread Gert Doering
s, never return EEXIST (see "man netlink(7)") - add detailed return code handling to route_add(), assign "2" on "-EEXIST" (and log appropriate message). (Note: sitnl_route_set() is a common function for sitnl route add and delete, but EEXIST can not happen on delete

[Openvpn-devel] [PATCH applied] Re: Deprecate OCC checking

2023-01-11 Thread Gert Doering
Acked-by: Gert Doering I have stared-at-code a bit (looks reasonable) and ran a few manual tests - without the patch, one of my t_client instances triggers this (with verb 3): 2023-01-11 15:42:41 WARNING: 'link-mtu' is used inconsistently, local='link-mtu 1542', remote=&

[Openvpn-devel] [PATCH applied] Re: documentation: update 'unsupported options' section

2023-01-11 Thread Gert Doering
Acked-by: Gert Doering "Seems to match my memories" :) Your patch has been applied to the master and release/2.6 branch. commit ee0a6026af9c47fe21217f57ab04b9cc2cc193f1 (master) commit 4674d69c630e92d2f5ae1537ab63f8e6b9bca041 (release/2.6) Author: Frank Lichtenheld Date: Wed Jan 1

[Openvpn-devel] [PATCH applied] Re: check_engine_keys: make pass with OpenSSL 3

2023-01-11 Thread Gert Doering
Acked-by: Gert Doering Looking more closely I can see that I misread the regex, and it's all fine indeed. Passing the test on my test candidates (ossl 1.1.x, ossl 3.0.x but no engine support) and also on the GHA actions with both ossl versions. Your patch has been applied to the master b

[Openvpn-devel] [PATCH applied] Re: options: Always define options->management_flags

2023-01-11 Thread Gert Doering
tions: Always define options->management_flags Signed-off-by: Frank Lichtenheld Acked-by: Arne Schwabe Message-Id: <20221127142506.41986-1-fr...@lichtenheld.com> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg25554.html Signed-off-by: Ge

Re: [Openvpn-devel] [PATCH] check_engine_keys: make pass with OpenSSL 3

2023-01-10 Thread Gert Doering
f you feed honest figures into a computer, honest figures come out. Never doubted it myself till I met a computer with a sense of humor." Robert A. Heinlein, The Moon is a Harsh Mistress Gert Doering - Munich, Germany g...@greeni

[Openvpn-devel] [PATCH applied] Re: Include CE_DISABLED status of remote in remote-entry-get response

2023-01-10 Thread Gert Doering
Acked-by: Gert Doering This is really straightforward. Tested with my .ovpn full with generated "remote" lines, some of them changed to "tcp", and "--proto-force tcp-client" .. 190,1185.server.org,1185,udp,disabled 191,1186.server.org,1186,udp,disabled 192,118

Re: [Openvpn-devel] Conditions under which a connection entry could be disabled

2023-01-10 Thread Gert Doering
doubted it myself till I met a computer with a sense of humor." Robert A. Heinlein, The Moon is a Harsh Mistress Gert Doering - Munich, Germany g...@greenie.muc.de signature.asc Description: PGP signature __

Re: [Openvpn-devel] [PATCH v15] Add DNS SRV remote host discovery support

2023-01-10 Thread Gert Doering
desired end state. gert -- "If was one thing all people took for granted, was conviction that if you feed honest figures into a computer, honest figures come out. Never doubted it myself till I met a computer with a sense of humor." Robert A. Heinlein

[Openvpn-devel] [PATCH applied] Re: xkey_pkcs11h_sign: fix dangling pointer

2023-01-10 Thread Gert Doering
rge.net/msg25942.html Signed-off-by: Gert Doering -- kind regards, Gert Doering ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel

[Openvpn-devel] [PATCH applied] Re: Update copyright year to 2023

2023-01-10 Thread Gert Doering
Acked-by: Gert Doering "Automatic and really easy to verify" ("git show -I Copyright") The patch seems to be too big for mail-archive.com to archive it (wat?) - it's not visible there, so pointing URL: to patchwork. Your patch has been applied to the master and re

[Openvpn-devel] [PATCH applied] Re: Log peer-id if loglevel is D_DCO_DEBUG and dco is enabled

2023-01-10 Thread Gert Doering
Acked-by: Gert Doering Works and helps with DCO debugging. Some of the messages look a bit stupid now... so we might want to go and polish :-) .. gremlin14943/194.97.140.21:12404 peer-id=9 dco_update_keys: peer_id=9 .. gremlin14833/194.97.140.21:11036 peer-id=11 dco_update_keys: peer_id=11

[Openvpn-devel] [PATCH applied] Re: Reduce logspam about 'dco_update_keys: peer_id=-1' in p2p server mode

2023-01-10 Thread Gert Doering
85e0df6b493396d9d1d9030c4018f67037d2f12b (master) commit 9bc2dfea0e1f643b2a02b61455e1845ae83f7518 (release/2.6) Author: Gert Doering Date: Mon Jan 9 21:00:11 2023 +0100 Reduce logspam about 'dco_update_keys: peer_id=-1' in p2p server mode Signed-off-by: Gert Doering Acked-by: Antonio

Re: [Openvpn-devel] [PATCH v2 4/4] Log peer-id if loglevel is D_DCO_DEBUG and dco is enabled

2023-01-10 Thread Gert Doering
Hi, On Tue, Dec 27, 2022 at 11:12:44AM +0100, Gert Doering wrote: > Playing around with the patch a bit, the offending piece seems to be > "mi->context.options.verbosity >= D_DCO_DEBUG" - which is unsurprising, > as D_DCO_DEBUG is not "6" but "LOGLEV

[Openvpn-devel] [PATCH applied] Re: Propagate route error to initialization_completed()

2023-01-10 Thread Gert Doering
Acked-by: Gert Doering We discussed this previously, and it makes sense to take "route addition errors" into account, even if we consciously decided (long before I got involved...) that we consider these non-fatal, unlike ifconfig errors. I have stared at the code, and it looks reas

[Openvpn-devel] [PATCH applied] Re: Add connect-freq-initial option to limit initial connection responses

2023-01-09 Thread Gert Doering
Acked-by: Gert Doering The following tests were all done on v4. diff v4->v5 is only the extra MSVC build files, so I did not completely re-test v5. Stare-at-code looks good now (thanks). Fixed a bit of wording in the commit message and reflect_filter.h comments. Tested on the Linux ser

Re: [Openvpn-devel] [PATCH v4] Add connect-freq-initial option to limit initial connection responses

2023-01-09 Thread Gert Doering
eople took for granted, was conviction that if you feed honest figures into a computer, honest figures come out. Never doubted it myself till I met a computer with a sense of humor." Robert A. Heinlein, The Moon is a Harsh Mistress Gert Doering - Munich, Germa

[Openvpn-devel] [PATCH] Reduce logspam about 'dco_update_keys: peer_id=-1' in p2p server mode

2023-01-09 Thread Gert Doering
p2p --tls-server with no active client/peer logs once per second "dco_update_keys: peer_id=-1" which does exactly nothing, except fill the disk. So skip the call to dco_update_keys() if peer_id == -1. Signed-off-by: Gert Doering --- src/openvpn/forward.c | 6 ++ 1 file

[Openvpn-devel] [PATCH applied] Re: Undo FreeBSD 12.x workaround on IPv6 ifconfig for 12.4 and up

2023-01-09 Thread Gert Doering
Thanks for the review and for fixing my fat fingers :-) Patch has been applied to the master and release/2.6 branch. commit 16d7f2cd4d904274580b2f031e92dde2f7f260c9 (master) commit d9906d1523a8ed46fce81cb8d559279e345bf849 (release/2.6) Author: Gert Doering Date: Sat Jan 7 17:25:58 2023 +0100

[Openvpn-devel] [PATCH applied] Re: Distinguish route addition errors from route already exists

2023-01-09 Thread Gert Doering
Acked-by: Gert Doering Lev has also ACKed, but since I did some previous digging into the code, I gave it an extra-hard stare and can confirm that it looks very reasonable. That said, I have a dislike for magic "0", "1" and "2" constants appearing with no explan

Re: [Openvpn-devel] [PATCH v2 2/3] Distinguish route addition errors from route already exists

2023-01-09 Thread Gert Doering
n that if you feed honest figures into a computer, honest figures come out. Never doubted it myself till I met a computer with a sense of humor." Robert A. Heinlein, The Moon is a Harsh Mistress Gert Doering - Munich, Germany g..

[Openvpn-devel] [PATCH applied] Re: tun: move print_windows_driver() out of tun.h

2023-01-09 Thread Gert Doering
Acked-by: Gert Doering Thanks. Compile-tested on MinGW, it compiles and the warnings are gone. Your patch has been applied to the master and release/2.6 branch. commit a0eb1f764df39d9447b666e5a2cbd3aa01b41983 (master) commit 9dd0bfb5983fdfbbb9e1fe2195642fbc4cc5f200 (release/2.6) Author: Lev

Re: [Openvpn-devel] [PATCH v2] Add connect-freq-initial option to limit initial connection responses

2023-01-09 Thread Gert Doering
come out. Never doubted it myself till I met a computer with a sense of humor." Robert A. Heinlein, The Moon is a Harsh Mistress Gert Doering - Munich, Germany g...@greenie.muc.de signature.asc Description: PGP s

Re: [Openvpn-devel] [PATCH v2 5/5] Improve signal handling using POSIX sigaction

2023-01-08 Thread Gert Doering
it myself till I met a computer with a sense of humor." Robert A. Heinlein, The Moon is a Harsh Mistress Gert Doering - Munich, Germany g...@greenie.muc.de signature.asc Description: PGP signature ___

[Openvpn-devel] [PATCH applied] Re: Assign and honour signal priority order

2023-01-08 Thread Gert Doering
our signal priority order Signed-off-by: Selva Nair Acked-by: Arne Schwabe Message-Id: <20230101215109.1521549-4-selva.n...@gmail.com> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg25871.html Signed-off-by: Gert Doering

[Openvpn-devel] [PATCH applied] Re: Fix signal handling on Windows

2023-01-08 Thread Gert Doering
64046-1-selva.n...@gmail.com> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg25895.html Signed-off-by: Gert Doering -- kind regards, Gert Doering ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforg

[Openvpn-devel] [PATCH applied] Re: Use IPAPI for setting ipv6 routes when iservice not available

2023-01-08 Thread Gert Doering
ev Stipakov Message-Id: <20230105022718.1641751-1-selva.n...@gmail.com> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg25886.html Signed-off-by: Gert Doering -- kind regards, Gert Doering ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel

[Openvpn-devel] [PATCH applied] Re: dco: improve comment about hidden debug message

2023-01-07 Thread Gert Doering
ked-by: Arne Schwabe Message-Id: <20230103202330.1835-...@unstable.cc> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg25883.html Signed-off-by: Gert Doering -- kind regards, Gert Doering ___ Openvpn-

[Openvpn-devel] [PATCH applied] Re: dco: bail out when no peer-specific message is delivered

2023-01-07 Thread Gert Doering
ivered Signed-off-by: Antonio Quartulli Acked-by: Arne Schwabe Message-Id: <20230103202330.1835-...@unstable.cc> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg25882.html Signed-off-by: Gert Doering -- kind regards, Gert Doering __

[Openvpn-devel] [PATCH applied] Re: dco: properly re-initialize dco_del_peer_reason

2023-01-07 Thread Gert Doering
: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg25881.html Signed-off-by: Gert Doering -- kind regards, Gert Doering ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel

[Openvpn-devel] [PATCH v2] Undo FreeBSD 12.x workaround on IPv6 ifconfig for 12.4 and up

2023-01-07 Thread Gert Doering
workaround on "12.0..12.3", to be fully removed later when 12.3 is also running out of support. v2: fix version number comparison Trac: 1226 Signed-off-by: Gert Doering --- src/openvpn/tun.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/openvpn/tun.c b/s

Re: [Openvpn-devel] [PATCH 1/3] Use IPAPI for setting ipv6 routes when iservice not available

2023-01-07 Thread Gert Doering
ld have different MAC addresses, and more ND activity would happen - but "--dev tun" mode never is (--dev tap on a --server would be). gert -- "If was one thing all people took for granted, was conviction that if you feed honest figures into a computer, honest figures come o

Re: [Openvpn-devel] [PATCH 1/3] Use IPAPI for setting ipv6 routes when iservice not available

2023-01-06 Thread Gert Doering
out. Never doubted it myself till I met a computer with a sense of humor." Robert A. Heinlein, The Moon is a Harsh Mistress Gert Doering - Munich, Germany g...@greenie.muc.de signature.asc Description: PGP signature _

Re: [Openvpn-devel] [PATCH] Undo FreeBSD 12.x workaround on IPv6 ifconfig for 12.4 and up

2023-01-06 Thread Gert Doering
test on FreeBSD 13... but it seems I forgot to re-test on 12.2/12.3) v2 RSN. gert -- "If was one thing all people took for granted, was conviction that if you feed honest figures into a computer, honest figures come out. Never doubted it myself till I met a computer with a sense of humor.&q

Re: [Openvpn-devel] [PATCH] Add connect-freq-initial option to limit initial connection responses

2023-01-05 Thread Gert Doering
bit) "int" would overflow at about 430 million packets per seconds - which is, I think, way beyond what any reasonable system can handle (10G ethernet saturates at 15 Mpps). But if you are really worried about overflows - why not use a (64bit) long here? gert -- "If was one thing all people took

[Openvpn-devel] [PATCH applied] Re: Refactor signal handling in openvpn_getaddrinfo

2023-01-05 Thread Gert Doering
Acked-by: Gert Doering This is basically the same thing as 1/5, just for the getaddrinfo() related functions. And no, I have no idea why they are treated "special", and getaddrinfo() is not a syscall. OTOH, getaddrinfo() spends most of its time in "waiting for DNS packets"

[Openvpn-devel] [PATCH applied] Re: Preparing for better signal handling: some code refactoring

2023-01-05 Thread Gert Doering
Acked-by: Gert Doering (Lightly) tested on Linux, FreeBSD - namely, does it compile, pass t_client tests (which send SIGTERM), pass t_server tests (which uses per-instance SIGUSR1/SIGTERM). Plus "push to github, does it break windows?". Stared at the code for a long time - most of it

Re: [Openvpn-devel] [OpenVPN/openvpn-gui] UI showing green connected status despite not beeing able to create a route (#9)

2023-01-02 Thread Gert Doering
Hi, On Sat, Dec 31, 2022 at 05:40:49PM +0100, Gert Doering wrote: > On Sat, Dec 17, 2022 at 07:09:34PM -0500, Selva Nair wrote: > > tldr: Can we get CONNECTED,ERROR instead of CONNECTED,SUCCESS on route > > errors? > > I think this makes sense. Not sure how complicated i

Re: [Openvpn-devel] [OpenVPN/openvpn-gui] UI showing green connected status despite not beeing able to create a route (#9)

2022-12-31 Thread Gert Doering
quot;If was one thing all people took for granted, was conviction that if you feed honest figures into a computer, honest figures come out. Never doubted it myself till I met a computer with a sense of humor." Robert A. Heinlein, The Moon is a Harsh Mistr

[Openvpn-devel] [PATCH applied] Re: Use undo_lists for saving ring-buffer handles in interactive service

2022-12-31 Thread Gert Doering
9.1477336-1-selva.n...@gmail.com> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg25864.html Signed-off-by: Gert Doering -- kind regards, Gert Doering ___ Openvpn-devel mailing list Openvpn-devel@lists.sourcef

<    2   3   4   5   6   7   8   9   10   11   >