Re: [OpenWrt-Devel] [PATCH] ath79: add support for Sitecom WLR-7100

2019-10-14 Thread Adrian Schmutzler
Hi, > diff --git a/target/linux/ath79/dts/ar1022_sitecom_wlr-7100.dts > b/target/linux/ath79/dts/ar1022_sitecom_wlr-7100.dts > new file mode 100644 > index 00..8a70b597b0 > --- /dev/null > +++ b/target/linux/ath79/dts/ar1022_sitecom_wlr-7100.dts You are using ar1022 here, but do not

Re: [OpenWrt-Devel] [PATCH] ath79: add support for UniFi AC-LR

2019-10-14 Thread Adrian Schmutzler
Hi, the device name is inconsistent in model string and DEVICE_MODEL (hyphens...). However, as this is only the friendly name, it is not really important. On their homepage, Ubiquiti never uses hyphens on product names, only for the abbreviations: UniFi AC Pro vs. UAP-AC-PRO-5 UniFi AC Lite

Re: [OpenWrt-Devel] [PATCH] ath79: correct ar71xx boardname for UniFi AC Lite

2019-10-14 Thread Adrian Schmutzler
r UniFi AC > Lite > > This corrects the additional boardname for the image metadata to the one > used in ar71xx. The previously present additional entry was never used > on a running system. > > Signed-off-by: David Bauer Reviewed-by: Adrian Schmutzler Best Adrian op

[OpenWrt-Devel] [PATCH v2] ath79: fix patching ath9k MAC address for MyNet WiFi Range Extender

2019-10-14 Thread Adrian Schmutzler
Net Wi-Fi Range Extender"). This patch just removes the "$mac" argument, leaving a formally valid line. (No on-device test has been performed.) Cc: Christian Lamparter Signed-off-by: Adrian Schmutzler --- v2: Rebased on master (due to caldata patchset) --- .../ath79/base-files/e

[OpenWrt-Devel] [PATCH v3 1/2] treewide: use a single ath10k MAC patching function with checksum

2019-10-14 Thread Adrian Schmutzler
patching for current and future ath10k devices should be ensured. This patch adds checksum adjustments for several targets on ath79 and lantiq. Signed-off-by: Adrian Schmutzler --- v3: Merged ath79 and lantiq patches, rename function to be consistent --- .../base-files/files/lib/functions/caldata.sh

[OpenWrt-Devel] [PATCH v3 2/2] lantiq: modify ath9k caldata extraction to reuse caldata.sh

2019-10-14 Thread Adrian Schmutzler
for the special case. Note that while the parameter for switching between normal and swab is removed, the size of the caldata is added to the function calls to stay consistent. Signed-off-by: Adrian Schmutzler --- v2: - Added this patch (previously separate [5/5] lantiq: modify ath9k caldata

Re: [OpenWrt-Devel] [PATCH] mpc85xx: correct TP-LINK TL-WDR4900 MAC addresses

2019-10-14 Thread Adrian Schmutzler
led on the device. > > Switch the MAC address source to the U-Boot partition, where the MAC > address is always present at a fixed partition. The partition was > previously already used for the WiFi MAC-addresses. > > Signed-off-by: David Bauer Reviewed-by: Adrian Schmutzler

Re: [OpenWrt-Devel] [PATCH 1/2] ath79: add support for Netgear WNDR4300

2019-10-11 Thread Adrian Schmutzler
Hi, > > Have you checked that there are no usable addresses in 0x1002 and > > 0x5006? > > > Yes, there are wireless addresses inside calibration data at offsets you > provided, and they are both equal to LAN MAC. Okay, so for that would mean it should correctly read the address from

Re: [OpenWrt-Devel] OpenWrt 19.07 release schedule ?

2019-10-11 Thread Adrian Schmutzler
Hi, > Question: How long would it take to stabilize/test a fresh fork from today's > Master branch instead? I assume none of these issues > apply to master or need to be solved in master as well? Remember that 19.07 is a kernel 4.14 release, while many targets on master already switched to

Re: [OpenWrt-Devel] [PATCH 1/2] ath79: add support for Netgear WNDR4300

2019-10-11 Thread Adrian Schmutzler
Hi, just some MAC related comments below: > @@ -403,6 +404,10 @@ ath79_setup_macs() > netgear,wndr3800) > lan_mac=$(macaddr_setbit_la "$(mtd_get_mac_binary art 0x0)") > ;; > + netgear,wndr4300) > + lan_mac=$(mtd_get_mac_binary caldata 0x0) > +

Re: [OpenWrt-Devel] [PATCH v3] ramips: add support for JS76x8 series DEV boards

2019-10-10 Thread Adrian Schmutzler
Hi again, > @@ -543,7 +546,10 @@ ramips_setup_macs() > hilink,hlk-rm04|\ > nexaira,bc2|\ > petatel,psr-680w|\ > - skyline,sl-r7205) > + skyline,sl-r7205|\ > + zhuotk,js76x8-16m|\ > + zhuotk,js76x8-32m|\ > + zhuotk,js76x8-8m) >

Re: [OpenWrt-Devel] RE:RE: [PATCH v4 1/3] ramips: add support for JS7628 development board

2019-10-09 Thread Adrian Schmutzler
Ah, sorry, too late. Didn't realize you already sent a patch as you started with v1 again ... > -Original Message- > From: openwrt-devel [mailto:openwrt-devel-boun...@lists.openwrt.org] On > Behalf Of Adrian Schmutzler > Sent: Mittwoch, 9. Oktober 2019 13:48 > To: '且听风吟'

Re: [OpenWrt-Devel] RE:RE: [PATCH v4 1/3] ramips: add support for JS7628 development board

2019-10-09 Thread Adrian Schmutzler
expect comments from other people or further waiting. Best Adrian Schmutzler openpgp-digital-signature.asc Description: PGP signature ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

[OpenWrt-Devel] [PATCH] ath79: fix patching ath9k MAC address for MyNet WiFi Range Extender

2019-10-08 Thread Adrian Schmutzler
Net Wi-Fi Range Extender"). This patch just removes the "$mac" argument, leaving a formally valid line. (No on-device test has been performed.) Cc: Christian Lamparter Signed-off-by: Adrian Schmutzler --- .../ath79/base-files/etc/hotplug.d/firmware/10-ath9k-eeprom | 2 +- 1 f

Re: [OpenWrt-Devel] [PATCH v4 1/3] ramips: add support for JS7628 development board

2019-10-08 Thread Adrian Schmutzler
Hi again, > + m25p80@0 { You should use a generic node name like "flash" here. https://github.com/devicetree-org/devicetree-specification/blob/master/source/devicetree-basics.rst#generic-names-recommendation Best Adrian Schmutzler openpgp-digital-signature.asc Description:

Re: [OpenWrt-Devel] [PATCH v4 1/3] ramips: add support for JS7628 development board

2019-10-08 Thread Adrian Schmutzler
een usability and codebase tidiness. Best Adrian Schmutzler openpgp-digital-signature.asc Description: PGP signature ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH v2 0/7] Move caldata extraction and MAC patching to common file

2019-10-07 Thread Adrian Schmutzler
extraction and MAC > patching to common file > > > -Original Message- > > From: openwrt-devel [mailto:openwrt-devel-boun...@lists.openwrt.org] > > On Behalf Of Adrian Schmutzler > > Sent: Sonntag, 22. September 2019 11:57 > > To: openwrt-devel@lists.

[OpenWrt-Devel] [PATCH] ipq40xx: add label MAC address for Netgear EX6150v2

2019-10-07 Thread Adrian Schmutzler
ac1 also has a local-mac-address assigned. This has the same vendor part as the other addresses, but completely different data for the device part.) Signed-off-by: Adrian Schmutzler --- .../files-4.19/arch/arm/boot/dts/qcom-ipq4018-ex6150v2.dts| 4 1 file changed, 4 insertions(+) diff -

[OpenWrt-Devel] [PATCH v2] ipq40xx: add label MAC address for FritzBox 4040

2019-10-07 Thread Adrian Schmutzler
The CWMP-Account on the device's label contains the eth0 MAC address. This only changes 4.19 files as label-mac-device is introduced after 19.07 branch, so there won't be a 4.14 release anymore. Signed-off-by: Adrian Schmutzler --- Resend, so DTS approach is v2 --- .../files-4.19/arch/arm

Re: [OpenWrt-Devel] [PATCH] ath79: make UBNT Nano/Loco AC factory images reproducible

2019-10-07 Thread Adrian Schmutzler
Hi Petr, > -Original Message- > From: openwrt-devel [mailto:openwrt-devel-boun...@lists.openwrt.org] On > Behalf Of Petr Štetiar > Sent: Montag, 7. Oktober 2019 10:22 > To: openwrt-devel@lists.openwrt.org > Cc: Petr Štetiar > Subject: [OpenWrt-Devel] [PATCH] ath79: make UBNT Nano/Loco

[OpenWrt-Devel] [PATCH] ath79: fix SUPPORTED_DEVICES for ubnt_nanostation-m

2019-10-04 Thread Adrian Schmutzler
r71xx to ath79. Ref: openwrt#2418 Signed-off-by: Adrian Schmutzler --- target/linux/ath79/image/generic-ubnt.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/linux/ath79/image/generic-ubnt.mk b/target/linux/ath79/image/generic-ubnt.mk index 4b2cee215c..09d8d90d2e 10064

[OpenWrt-Devel] [PATCH 19.07] ath79: add SUPPORTED_DEVICES to ubnt_nanostation-m-xw

2019-10-04 Thread Adrian Schmutzler
etr Štetiar (cherry picked from commit 6dda2ea6ad133705d243d3cc626779ee24bdc88d) Signed-off-by: Adrian Schmutzler --- target/linux/ath79/image/generic-ubnt.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/linux/ath79/image/generic-ubnt.mk b/target/linux/ath79/image/g

Re: [OpenWrt-Devel] [PATCH 19.07] ar71xx: fix sysupgrade to ath79 for wndr3700v2 and wndr3800

2019-10-01 Thread Adrian Schmutzler
Hi, > -Original Message- > From: openwrt-devel [mailto:openwrt-devel-boun...@lists.openwrt.org] On > Behalf Of Petr Štetiar > Sent: Dienstag, 1. Oktober 2019 06:50 > To: m...@adrianschmutzler.de > Cc: openwrt-devel@lists.openwrt.org > Subject: Re: [OpenWrt-Devel] [PATCH 19.07] ar71xx:

[OpenWrt-Devel] [PATCH] ipq40xx: add label MAC address for FritzBox 4040

2019-09-29 Thread Adrian Schmutzler
The CWMP-Account on the device's label contains the eth0 MAC address. This only changes 4.19 files as label-mac-device is introduced after 19.07 branch, so there won't be a 4.14 release anymore. Signed-off-by: Adrian Schmutzler --- .../files-4.19/arch/arm/boot/dts/qcom-ipq4018-fritz4040.dts

[OpenWrt-Devel] [PATCH] ramips: add label MAC address for Asus RT-AC85P

2019-09-27 Thread Adrian Schmutzler
The label shows the MAC address of 2.4 GHz WiFi. Signed-off-by: Adrian Schmutzler --- target/linux/ramips/base-files/etc/board.d/02_network | 1 + 1 file changed, 1 insertion(+) diff --git a/target/linux/ramips/base-files/etc/board.d/02_network b/target/linux/ramips/base-files/etc/board.d

[OpenWrt-Devel] [PATCH v2 1/2] ramips: harmonize device vendor Zbtlink

2019-09-26 Thread Adrian Schmutzler
-by: Adrian Schmutzler --- v2: No changes, just added second patch --- .../linux/ramips/dts/mt7620a_zbtlink_we1026-5g-16m.dts | 2 +- .../linux/ramips/dts/mt7620a_zbtlink_zbt-ape522ii.dts | 2 +- .../linux/ramips/dts/mt7620a_zbtlink_zbt-we826-16m.dts | 2 +- .../linux/ramips/dts

[OpenWrt-Devel] [PATCH v2 2/2] ramips: apply consistent device name/compatible to ZBT-WE1026-5G

2019-09-26 Thread Adrian Schmutzler
All Zbtlink ramips devices except the ZBT-WE1026-5G include the zbt-/ZBT- prefix in their model name. This changes ZBT-WE1026-5G to also follow that scheme. The patch moves some block to keep alphatical order. Signed-off-by: Adrian Schmutzler --- v2: new in v2 This is not tested on device

[OpenWrt-Devel] [PATCH] ramips: harmonize device vendor Zbtlink

2019-09-25 Thread Adrian Schmutzler
-by: Adrian Schmutzler --- .../linux/ramips/dts/mt7620a_zbtlink_we1026-5g-16m.dts | 2 +- .../linux/ramips/dts/mt7620a_zbtlink_zbt-ape522ii.dts | 2 +- .../linux/ramips/dts/mt7620a_zbtlink_zbt-we826-16m.dts | 2 +- .../linux/ramips/dts/mt7620a_zbtlink_zbt-we826-32m.dts | 2 +- .../linux/ramips

Re: [OpenWrt-Devel] [PATCH v2 2/2] ramips: Add support for ZBT WE1026-H

2019-09-24 Thread Adrian Schmutzler
vice. However, the files are structured so that adding support for the > 16MB version should be easy. > > * Only the LAN port is accessible from the outside of the casing and LEDs > are not visible. > > v1->v2: > * Rebased on top of master. > * Read correct WAN address from flash

Re: [OpenWrt-Devel] [PATCH v2 1/2] ramips: Update ZBT WE1026 DTS-files

2019-09-24 Thread Adrian Schmutzler
Hi, don't know whether that's required as I only did the DTS file rename, but you can also add my Acked-by: Adrian Schmutzler Some optional nitpicks: > diff --git a/target/linux/ramips/dts/mt7620a_zbtlink_we1026-5g.dtsi > b/target/linux/ramips/dts/mt7620a_zbtlink_we1026-5g.dtsi &

Re: [OpenWrt-Devel] [PATCH] ipq40xx: remove redundant ucidef_set_interfaces_* in 02_network

2019-09-23 Thread Adrian Schmutzler
Hi Dmitry, > -Original Message- > From: openwrt-devel [mailto:openwrt-devel-boun...@lists.openwrt.org] On > Behalf Of Dmitry Tunin > Sent: Montag, 23. September 2019 17:12 > To: Adrian Schmutzler > Cc: OpenWrt Development List > Subject: Re: [OpenWrt-Devel] [P

[OpenWrt-Devel] [PATCH] ipq40xx: add label MAC address for FritzBox 4040

2019-09-23 Thread Adrian Schmutzler
This adds label MAC address for the AVM FritzBox 4040, the first device in ipq40xx target. Signed-off-by: Adrian Schmutzler --- target/linux/ipq40xx/base-files/etc/board.d/02_network | 4 1 file changed, 4 insertions(+) diff --git a/target/linux/ipq40xx/base-files/etc/board.d/02_network

[OpenWrt-Devel] [PATCH] ipq40xx: remove redundant ucidef_set_interfaces_* in 02_network

2019-09-23 Thread Adrian Schmutzler
If already included in ucidef_add_switch, you do not have to additionally set the interface mode in ucidef_set_interfaces_* functions. This patch removes/adjusts such redundant cases. Signed-off-by: Adrian Schmutzler --- This is not tested on the affected devices. However, the same approach

[OpenWrt-Devel] [PATCH v2] treewide: remove kmod-usb-core from DEVICE_PACKAGES

2019-09-22 Thread Adrian Schmutzler
Signed-off-by: Adrian Schmutzler --- v2: rebase --- .../ar71xx/generic/profiles/00-default.mk | 2 +- .../ar71xx/image/generic-legacy-devices.mk| 90 +-- target/linux/ar71xx/image/generic-tp-link.mk | 44 +++--- target/linux/ar71xx/image/generic-ubnt.mk | 6 +- target

[OpenWrt-Devel] [PATCH] ramips: initialize youhua, wr1200js WAN MAC addresses from flash

2019-09-22 Thread Adrian Schmutzler
This patch changes wan MAC address setup for youhua,wr1200js from retrieving it by calculation to reading it from flash. This has been checked on-device. Signed-off-by: Adrian Schmutzler --- target/linux/ramips/base-files/etc/board.d/02_network | 1 + 1 file changed, 1 insertion(+) diff --git

[OpenWrt-Devel] [PATCH v2 3/7] treewide: move calibration data extraction function to library

2019-09-22 Thread Adrian Schmutzler
find_mtd_chardev, while some used find_mtd_part inside the extraction code. To merge them, the more abundant version with find_mtd_chardev is used in the common code. Signed-off-by: Adrian Schmutzler --- Open questions: 1. I tested find_mtd_chardev and find_mtd_part on mpc85xx, both gave

[OpenWrt-Devel] [PATCH v2 5/7] ath79: set checksum when patching MAC address on ath10k

2019-09-22 Thread Adrian Schmutzler
the correct checksum is in place. Signed-off-by: Adrian Schmutzler --- v2: New patch --- .../etc/hotplug.d/firmware/11-ath10k-caldata | 30 +-- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/target/linux/ath79/base-files/etc/hotplug.d/firmware/11-ath10k-caldata b

[OpenWrt-Devel] [PATCH v2 1/7] treewide: fix hex2dec conversion for MAC address checksum offset

2019-09-22 Thread Adrian Schmutzler
but only when it's used in dd. No conversion is done for use in hexdump, as this can deal with hex value offsets. Fixes: b133e466b08e ("treewide: convert WiFi caldata size and offset to hexadecimal") Signed-off-by: Adrian Schmutzler --- This is also sent as separate patch, as it is a fi

[OpenWrt-Devel] [PATCH v2 4/7] treewide: move MAC address patch functions to common library

2019-09-22 Thread Adrian Schmutzler
This unifies MAC address patch functions and moves them to a common script. While those were implemented differently for different targets, they all seem to do the same. The number of different variants is significantly reduced by this patch. Signed-off-by: Adrian Schmutzler --- v2: rebased

[OpenWrt-Devel] [PATCH v2 0/7] Move caldata extraction and MAC patching to common file

2019-09-22 Thread Adrian Schmutzler
despite that also included several variations of the same approach. This has been tested on: - ath79/ath9k: WDR4300 v1 - ath79/ath10k: Archer C60 v2 - ipq806x: TP-Link C2600 I would be happy about other tests, especially for ramips and lantiq. # #*** BLURB HERE *** # Adrian Schmutzler (7

[OpenWrt-Devel] [PATCH v2 7/7] lantiq: modify ath9k caldata extraction to reuse caldata.sh

2019-09-22 Thread Adrian Schmutzler
for the special case. Note that while the parameter for switching between normal and swab is removed, the size of the caldata is added to the function calls to stay consistent. Signed-off-by: Adrian Schmutzler --- v2: - Added this patch (previously separate [5/5] lantiq: modify ath9k caldata

[OpenWrt-Devel] [PATCH v2 6/7] lantiq: set checksum when patching MAC address on ath10k

2019-09-22 Thread Adrian Schmutzler
the correct checksum is in place. Signed-off-by: Adrian Schmutzler --- v2: New patch --- .../lantiq/base-files/etc/hotplug.d/firmware/11-ath10k-caldata | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/linux/lantiq/base-files/etc/hotplug.d/firmware/11-ath10k-caldata b

[OpenWrt-Devel] [PATCH v2 2/7] base-files: move xor() from caldata extraction to functions.sh

2019-09-22 Thread Adrian Schmutzler
The xor() function is defined in each of the caldata extraction scripts for several targets. Move it to functions.sh to reduce duplicate code. Signed-off-by: Adrian Schmutzler --- v2: rebase --- package/base-files/files/lib/functions.sh | 16 .../etc/hotplug.d/firmware

[OpenWrt-Devel] [PATCH v3] ramips: replace backticks by $(...)

2019-09-20 Thread Adrian Schmutzler
This replaces deprecated backticks by more versatile $(...) syntax. While at it, remove some useless cat commands and deprecated egrep commands. Signed-off-by: Adrian Schmutzler --- v3: rebase --- target/linux/ramips/base-files/etc/board.d/02_network | 6 +++--- .../base-files/lib

[OpenWrt-Devel] [PATCH v2 2/2] ramips: fix whitespace issues in DTS files

2019-09-20 Thread Adrian Schmutzler
This is the result of grepping/searching for several common whitespace issues like double empty lines, leading spaces, etc. This patch fixes them for the ramips target. Signed-off-by: Adrian Schmutzler --- v2: rebase, added fixes for EnGenius ESR600, AsiaRF AP7621 DTSI --- target/linux

[OpenWrt-Devel] [PATCH v2 1/2] ramips/mt762x: convert devices to interrupt-driven gpio-keys

2019-09-20 Thread Adrian Schmutzler
This converts all remaining devices to use interrupt-driven gpio-keys compatible instead of gpio-keys-polled. The poll-interval is removed. While at it, add/remove newlines in keys and leds node where necessary. Signed-off-by: Adrian Schmutzler --- v2: rebase --- target/linux/ramips/dts

Re: [OpenWrt-Devel] [PATCH 1/2] ramips: Update ZBT WE1026 DTS-files

2019-09-20 Thread Adrian Schmutzler
> -Original Message- > From: openwrt-devel [mailto:openwrt-devel-boun...@lists.openwrt.org] On > Behalf Of Petr Štetiar > Sent: Freitag, 20. September 2019 09:56 > To: Kristian Evensen > Cc: openwrt-devel@lists.openwrt.org > Subject: Re: [OpenWrt-Devel] [PATCH 1/2] ramips: Update ZBT

Re: [OpenWrt-Devel] [PATCH 1/3] ramips/mt762x: convert devices to interrupt-driven gpio-keys

2019-09-20 Thread Adrian Schmutzler
Hi, > -Original Message- > From: Petr Štetiar [mailto:yn...@true.cz] > Sent: Freitag, 20. September 2019 08:45 > To: Adrian Schmutzler > Cc: openwrt-devel@lists.openwrt.org > Subject: Re: [OpenWrt-Devel] [PATCH 1/3] ramips/mt762x: convert devices to > inter

Re: [OpenWrt-Devel] Negative offset for checksum in ath79's 10-ath9k-eeprom

2019-09-18 Thread Adrian Schmutzler
Hi, > -Original Message- > From: openwrt-devel [mailto:openwrt-devel-boun...@lists.openwrt.org] On > Behalf Of David Bauer > Sent: Mittwoch, 18. September 2019 17:04 > To: Adrian Schmutzler > Cc: openwrt-devel@lists.openwrt.org; 'Chuanhong Guo' ; > 'Sebastian K

[OpenWrt-Devel] [PATCH] ath79: remove invalid uses of ath9k_patch_fw_mac_crc

2019-09-18 Thread Adrian Schmutzler
devices. Signed-off-by: Adrian Schmutzler --- This should be backported, too, as the negative offset for hexdump and dd might do interesting things. --- .../ath79/base-files/etc/hotplug.d/firmware/10-ath9k-eeprom | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/target

Re: [OpenWrt-Devel] Negative offset for checksum in ath79's 10-ath9k-eeprom

2019-09-18 Thread Adrian Schmutzler
Hi, that's interesting. > BTW there's another misuse in ath10k-caldata: All ath10k eeproms have > checksum fields and should use ath10k_patch_mac_crc, ath10k_patch_mac > exists only because ath10k firmware doesn't verify it. So, let me repeat this to check whether I understood it: From a

[OpenWrt-Devel] Negative offset for checksum in ath79's 10-ath9k-eeprom

2019-09-18 Thread Adrian Schmutzler
Hi, I've encountered the following issue, for which I would like a second opinion. In ath79's 10-ath9k-eeprom, in addition to patching the firmware MAC address, some devices also need a checksum adjustment:

[OpenWrt-Devel] [PATCH] treewide: fix hex2dec conversion for MAC address checksum offset

2019-09-18 Thread Adrian Schmutzler
but only when it's used in dd. No conversion is done for use in hexdump, as this can deal with hex value offsets. Fixes: b133e466b08e ("treewide: convert WiFi caldata size and offset to hexadecimal") Signed-off-by: Adrian Schmutzler --- .../ath79/base-files/etc/hotplug.d/firmware/10-ath9k-

Re: [OpenWrt-Devel] [PATCH] ath79: add support for TP-Link TL-MR6400

2019-09-17 Thread Adrian Schmutzler
Hi, > -Original Message- > From: Enrico Mioso [mailto:mrkiko...@gmail.com] > Sent: Dienstag, 17. September 2019 18:57 > To: Filip Moc > Cc: Adrian Schmutzler ; > openwrt-devel@lists.openwrt.org; Piotr Dymacz > Subject: Re: [OpenWrt-Devel] [PATCH] ath79: add s

Re: [OpenWrt-Devel] [PATCH] ath79: add support for TP-Link TL-MR6400

2019-09-17 Thread Adrian Schmutzler
Hi, > -Original Message- > From: Filip Moc [mailto:l...@moc6.cz] > Sent: Dienstag, 17. September 2019 15:52 > To: Enrico Mioso > Cc: Adrian Schmutzler ; > openwrt-devel@lists.openwrt.org; Piotr Dymacz > Subject: Re: [OpenWrt-Devel] [PATCH] ath79: add support

Re: [OpenWrt-Devel] [PATCH] ath79: Add LED migration for several Archer Cxx devices

2019-09-17 Thread Adrian Schmutzler
> Sent: Dienstag, 3. September 2019 01:09 > To: Adrian Schmutzler > Cc: openwrt-devel@lists.openwrt.org > Subject: Re: [OpenWrt-Devel] [PATCH] ath79: Add LED migration for several > Archer Cxx devices > > Hello Adrian > > On 9/2/19 11:10 AM, Adrian Schmutzler wrote: > >

[OpenWrt-Devel] [PATCH v2 2/2] ath79: add LED migration for several Archer Cxx devices

2019-09-17 Thread Adrian Schmutzler
Several Archer Cxx devices were using board-specific LED names in ar71xx, which were changed to "tp-link:*" in ath79. This patch adds migration for them. Signed-off-by: Adrian Schmutzler --- v2: Added C59v2, use new concept --- .../base-files/etc/uci-defaults/04_led_migratio

[OpenWrt-Devel] [PATCH v2 1/2] ath79: use board name in LED migrations

2019-09-17 Thread Adrian Schmutzler
"^" to the regex, so the match is more specific. Signed-off-by: Adrian Schmutzler --- .../ath79/base-files/etc/uci-defaults/04_led_migration | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/target/linux/ath79/base-files/etc/uci-defaults/04_led_migration

[OpenWrt-Devel] [PATCH] ath79: fix whitespace issues in DTS files

2019-09-17 Thread Adrian Schmutzler
This is the result of grepping/searching for several common whitespace issues like double empty lines, leading spaces, etc. This patch fixes them for the ath79 target. Signed-off-by: Adrian Schmutzler --- target/linux/ath79/dts/ar7161_dlink_dir-825-b1.dts| 2 -- target/linux/ath79

[OpenWrt-Devel] [PATCH 1/3] ramips/mt762x: convert devices to interrupt-driven gpio-keys

2019-09-17 Thread Adrian Schmutzler
This converts all remaining devices to use interrupt-driven gpio-keys compatible instead of gpio-keys-polled. The poll-interval is removed. While at it, add/remove newlines in keys and leds node where necessary. Signed-off-by: Adrian Schmutzler --- target/linux/ramips/dts/mt7620a_aigale_ai

[OpenWrt-Devel] [PATCH 2/3] ramips: fix whitespace issues in DTS files

2019-09-17 Thread Adrian Schmutzler
This is the result of grepping/searching for several common whitespace issues like double empty lines, leading spaces, etc. This patch fixes them for the ramips target. Signed-off-by: Adrian Schmutzler --- target/linux/ramips/dts/mt7620a_dlink_dir-510l.dts | 1 - target/linux/ramips

[OpenWrt-Devel] [PATCH 3/3] ramips: rearrange LEDs for ZBT-WE826 devices to prevent delete-node

2019-09-17 Thread Adrian Schmutzler
the use of delete-node. This seems more logical than created the config and then deleting it again. Signed-off-by: Adrian Schmutzler --- .../dts/mt7620a_zbtlink_zbt-we826-16m.dts | 21 +++ .../dts/mt7620a_zbtlink_zbt-we826-32m.dts | 21 +++ .../dts

Re: [OpenWrt-Devel] [PATCH] ath79: add support for TP-Link TL-MR6400

2019-09-17 Thread Adrian Schmutzler
Hi, > -Original Message- > From: openwrt-devel [mailto:openwrt-devel-boun...@lists.openwrt.org] On > Behalf Of Enrico Mioso > Sent: Dienstag, 17. September 2019 02:21 > To: openwrt-devel@lists.openwrt.org > Cc: Filip Moc ; Piotr Dymacz ; Enrico Mioso > > Subject: [OpenWrt-Devel]

Re: [OpenWrt-Devel] [ramips] Linkit Smart 7688 kmod-sdhci-mt7620

2019-09-13 Thread Adrian Schmutzler
Hi, > -Original Message- > From: openwrt-devel [mailto:openwrt-devel-boun...@lists.openwrt.org] On > Behalf Of Ivan Hörler > Sent: Freitag, 13. September 2019 22:32 > To: openwrt-devel@lists.openwrt.org > Subject: [OpenWrt-Devel] [ramips] Linkit Smart 7688 kmod-sdhci-mt7620 > > Hi > I

[OpenWrt-Devel] [PATCH] brcm63xx: remove redundant variable definition in Makefile

2019-09-11 Thread Adrian Schmutzler
For devices inheriting from bcm63xx_netgear, the IMAGES variable is overwritten with the same values as defined in the parent definition. So, remove the unnecessary overwrite. Signed-off-by: Adrian Schmutzler --- target/linux/brcm63xx/image/bcm63xx.mk | 3 --- 1 file changed, 3 deletions

Re: [OpenWrt-Devel] [PATCH 3/3] treewide: sysupgrade: use $UPGRADE_BACKUP to check for backup

2019-09-11 Thread Adrian Schmutzler
Hi, when looking at the merged patch (unfortunately only then), I found some "issues" (see below): > -Original Message- > From: openwrt-devel [mailto:openwrt-devel-boun...@lists.openwrt.org] On > Behalf Of Rafal Milecki > Sent: Freitag, 6. September 2019 07:11 > To:

[OpenWrt-Devel] [PATCH 5/5] lantiq: modify ath9k caldata extraction to reuse caldata.sh

2019-09-08 Thread Adrian Schmutzler
special case. Note that the size of the caldata needs to be included into the call for functions located in caldata.sh. Signed-off-by: Adrian Schmutzler --- This patch is a late addition to the caldata.sh patchset and has to be applied last. --- .../etc/hotplug.d/firmware/12-

[OpenWrt-Devel] [PATCH 2/4] treewide: move calibration data extraction function to library

2019-09-08 Thread Adrian Schmutzler
find_mtd_chardev, while some used find_mtd_part inside the extraction code. To merge them, the more abundant version with find_mtd_chardev is used in the common code. Signed-off-by: Adrian Schmutzler --- Open questions: 1. I tested find_mtd_chardev and find_mtd_part on mpc85xx, both gave

[OpenWrt-Devel] [PATCH 3/4] treewide: move MAC address patch functions to common library

2019-09-08 Thread Adrian Schmutzler
This unifies MAC address patch functions and moves them to a common script. While those were implemented differently for different targets, they all seem to do the same. The number of different variants is significantly reduced by this patch. Signed-off-by: Adrian Schmutzler --- .../base-files

[OpenWrt-Devel] [PATCH 4/4] base-files: fix hex2dec conversion for checksum offset

2019-09-08 Thread Adrian Schmutzler
o conversion is done for use in hexdump, as this can deal with hex values. Fixes: b133e466b08e ("treewide: convert WiFi caldata size and offset to hexadecimal") Signed-off-by: Adrian Schmutzler --- If this patchset is not accepted, one would have to fix this in the original positions anyway.

[OpenWrt-Devel] [PATCH 1/4] base-files: move xor() from caldata extraction to functions.sh

2019-09-08 Thread Adrian Schmutzler
The xor() function is defined in each of the caldata extraction scripts for several targets. Move it to functions.sh to reduce duplicate code. Signed-off-by: Adrian Schmutzler --- package/base-files/files/lib/functions.sh | 16 .../etc/hotplug.d/firmware/10-ath9k-eeprom

[OpenWrt-Devel] [PATCH 0/4] Move caldata extraction and MAC patching to common file

2019-09-08 Thread Adrian Schmutzler
plan to address the special situation in lantiq when a find some additional time. Note that the current state is only slightly above RFC quality. It has not been tested so far on any target. Adrian Schmutzler (4): base-files: move xor() from caldata extraction to functions.sh treewide: move

[OpenWrt-Devel] [PATCH 18.06 3/3] ramips: fix duplicate network setup for dlink, dir-615-h1

2019-09-07 Thread Adrian Schmutzler
y inversed that order.) Anyway, just remove the wrong case now. Signed-off-by: Adrian Schmutzler (cherry picked from commit e35e4a996e26f17b69d200505ecea78af96a2704) --- target/linux/ramips/base-files/etc/board.d/02_network | 1 - 1 file changed, 1 deletion(-) diff --git a/target/linux/ramips/base

[OpenWrt-Devel] [PATCH 18.06 1/3] ramips: remove duplicate case for MAC setup of freestation5

2019-09-07 Thread Adrian Schmutzler
out it). Signed-off-by: Adrian Schmutzler (cherry picked from commit ad4eb2241b33b05b0942a3fa7ed2e53fb6e84386) --- target/linux/ramips/base-files/etc/board.d/02_network | 1 - 1 file changed, 1 deletion(-) diff --git a/target/linux/ramips/base-files/etc/board.d/02_network b/target/linux/ramips/b

[OpenWrt-Devel] [PATCH 18.06 2/3] ramips: fix D-Link DIR-615 H1 switch port mapping

2019-09-07 Thread Adrian Schmutzler
From: Mirko Parthey Reuse a device-specific switch port mapping which also applies to the D-Link DIR-615 H1. Signed-off-by: Mirko Parthey [cherry-pick/rebase] Signed-off-by: Adrian Schmutzler (cherry picked from commit 555ca422d1cbc2db354c0ed03d1a79650f590859) --- target/linux/ramips/base

[OpenWrt-Devel] [PATCH 19.07 3/3] ramips: fix ethernet MAC address of ASUS RT-AC57U

2019-09-07 Thread Adrian Schmutzler
This backports the only non-cosmetic fix from 6640e1c3681b ("ramips: clean and improve MAC address setup in 02_network"). Signed-off-by: Adrian Schmutzler --- target/linux/ramips/dts/RT-AC57U.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/linux/ram

[OpenWrt-Devel] [PATCH 19.07 2/3] ramips: fix duplicate network setup for dlink, dir-615-h1

2019-09-07 Thread Adrian Schmutzler
y inversed that order.) Anyway, just remove the wrong case now. Signed-off-by: Adrian Schmutzler (cherry picked from commit e35e4a996e26f17b69d200505ecea78af96a2704) --- target/linux/ramips/base-files/etc/board.d/02_network | 1 - 1 file changed, 1 deletion(-) diff --git a/target/linux/ramips/base

[OpenWrt-Devel] [PATCH 19.07 1/3] ramips: remove duplicate case for MAC setup of freestation5

2019-09-07 Thread Adrian Schmutzler
out it). Signed-off-by: Adrian Schmutzler (cherry picked from commit ad4eb2241b33b05b0942a3fa7ed2e53fb6e84386) --- target/linux/ramips/base-files/etc/board.d/02_network | 1 - 1 file changed, 1 deletion(-) diff --git a/target/linux/ramips/base-files/etc/board.d/02_network b/target/linux/ramips/b

[OpenWrt-Devel] [PATCH 2/2] ath79: refactor ath9k/ath10k caldata functions into library

2019-09-06 Thread Adrian Schmutzler
different from each other. Having the functions in a library file will also help to reuse them after the nand subtarget has been reworked. Signed-off-by: Adrian Schmutzler --- This has not been device-tested yet. --- .../etc/hotplug.d/firmware/10-ath9k-eeprom| 125 -- .../etc

[OpenWrt-Devel] [PATCH 1/2] base-files: move xor() from caldata extraction to functions.sh

2019-09-06 Thread Adrian Schmutzler
The xor() function is defined in each of the caldata extraction scripts for several targets. Move it to functions.sh to reduce duplicate code. Signed-off-by: Adrian Schmutzler --- package/base-files/files/lib/functions.sh | 16 .../etc/hotplug.d/firmware/10-ath9k-eeprom

[OpenWrt-Devel] [PATCH 19.07] base-files: use get_mac_binary() in mtd_get_mac_binary_ubi()

2019-09-06 Thread Adrian Schmutzler
with the similar mtd_get_mac_binary(). Signed-off-by: Adrian Schmutzler (cherry picked from commit 45600124fcbd14ece6e289cb59b318ea44c598fe) --- The enhanced path check in get_mac_binary has been backported a while ago. Enable mtd_get_mac_binary_ubi to use it also on 19.07. --- package/base-files/files

Re: [OpenWrt-Devel] [PATCH 3/3] treewide: sysupgrade: use $UPGRADE_BACKUP to check for backup

2019-09-06 Thread Adrian Schmutzler
> -Original Message- > From: Rafał Miłecki [mailto:ra...@milecki.pl] > Sent: Freitag, 6. September 2019 15:13 > To: Adrian Schmutzler > Cc: 'Rafał Miłecki' ; openwrt-devel@lists.openwrt.org; > 'Jonas Gorski' ; 'Jo-Philipp Wich' > ; 'John Crispin' > Subject: Re:

Re: [OpenWrt-Devel] [PATCH 3/3] treewide: sysupgrade: use $UPGRADE_BACKUP to check for backup

2019-09-06 Thread Adrian Schmutzler
Hi, just a nitpick: > diff --git a/target/linux/ipq40xx/base-files/lib/upgrade/openmesh.sh > b/target/linux/ipq40xx/base-files/lib/upgrade/openmesh.sh > index e313562017..8e02186eb8 100644 > --- a/target/linux/ipq40xx/base-files/lib/upgrade/openmesh.sh > +++

[OpenWrt-Devel] [PATCH] ath79: really fix invalid UPGRADE_OPT_SAVE_CONFIG spellings

2019-09-05 Thread Adrian Schmutzler
gs") Signed-off-by: Adrian Schmutzler --- This fix and previous patches need to be backported to 19.07, since the initial introduction of the UPGRADE_OPT_SAVE_CONFIG variable has already been backported there. --- target/linux/ath79/base-files/lib/upgrade/platform.sh | 4 ++-- 1 file changed

[OpenWrt-Devel] Migration in ath79 for swapped ethernet

2019-09-05 Thread Adrian Schmutzler
Hi, if I remember correctly, there is still no mechanism to fix eth0/eth1 for devices where those have been swapped from ar71xx to ath79. In principle, this can be done with a relatively small piece of code (not tested): diff --git

[OpenWrt-Devel] [PATCH 2/3] ath79: remove empty default case in 10_fix_wifi_mac

2019-09-05 Thread Adrian Schmutzler
This removes a useless empty default case. Signed-off-by: Adrian Schmutzler --- .../ath79/base-files/etc/hotplug.d/ieee80211/10_fix_wifi_mac| 2 -- 1 file changed, 2 deletions(-) diff --git a/target/linux/ath79/base-files/etc/hotplug.d/ieee80211/10_fix_wifi_mac b/target/linux/ath79/base

[OpenWrt-Devel] [PATCH 3/3] ath79: apply alphabetical sorting to entries in 10_fix_wifi_mac

2019-09-05 Thread Adrian Schmutzler
Signed-off-by: Adrian Schmutzler --- .../base-files/etc/hotplug.d/ieee80211/10_fix_wifi_mac| 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/target/linux/ath79/base-files/etc/hotplug.d/ieee80211/10_fix_wifi_mac b/target/linux/ath79/base-files/etc/hotplug.d

[OpenWrt-Devel] [PATCH 1/3] ath79: fix whitespaces in 10_fix_wifi_mac

2019-09-05 Thread Adrian Schmutzler
This converts leading whitespaces to tabs and removes a double newline at the end of the file. Signed-off-by: Adrian Schmutzler --- .../etc/hotplug.d/ieee80211/10_fix_wifi_mac | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/target/linux/ath79/base

[OpenWrt-Devel] [PATCH] base-files: use get_mac_binary() in mtd_get_mac_binary_ubi()

2019-09-05 Thread Adrian Schmutzler
with the similar mtd_get_mac_binary(). Signed-off-by: Adrian Schmutzler --- This is not tested at all, since I do not own an ubi device myself! --- package/base-files/files/lib/functions/system.sh | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/package/base-files/files/lib

Re: [OpenWrt-Devel] [PATCH] base-files: fix get_mac_address not accepting hex offsets

2019-09-05 Thread Adrian Schmutzler
Hi David, > -Original Message- > From: David Bauer [mailto:m...@david-bauer.net] > Sent: Mittwoch, 4. September 2019 23:07 > To: m...@adrianschmutzler.de > Cc: openwrt-devel@lists.openwrt.org > Subject: Re: [OpenWrt-Devel] [PATCH] base-files: fix get_mac_address not > accepting hex

[OpenWrt-Devel] [PATCH 2/2] ramips: fix duplicate network setup for dlink, dir-615-h1

2019-09-05 Thread Adrian Schmutzler
y inversed that order.) Anyway, just remove the wrong case now. Signed-off-by: Adrian Schmutzler --- This should also be backported to 19.07. Due to the ramips rename this will need a different patch which I will send if this one is accepted. --- target/linux/ramips/base-files/etc/board.d/02_networ

[OpenWrt-Devel] [PATCH 1/2] ramips: remove duplicate case for MAC setup of freestation5

2019-09-05 Thread Adrian Schmutzler
out it). Signed-off-by: Adrian Schmutzler --- This should be backported to 19.07 and 18.06. --- target/linux/ramips/base-files/etc/board.d/02_network | 1 - 1 file changed, 1 deletion(-) diff --git a/target/linux/ramips/base-files/etc/board.d/02_network b/target/linux/ramips/base-files/etc/boar

Re: [OpenWrt-Devel] [PATCH] ath79: Add LED migration for several Archer Cxx devices

2019-09-03 Thread Adrian Schmutzler
st Adrian > -Original Message- > From: openwrt-devel [mailto:openwrt-devel-boun...@lists.openwrt.org] On > Behalf Of David Bauer > Sent: Dienstag, 3. September 2019 01:09 > To: Adrian Schmutzler > Cc: openwrt-devel@lists.openwrt.org > Subject: Re: [OpenWrt-Devel] [

[OpenWrt-Devel] mtd-mac-address on MT7610E chip

2019-09-02 Thread Adrian Schmutzler
Hi, we just have encountered the case of a 5 GHz radio on a MT7610E chip that does not provide its MAC address via caldata. We tried the following: { wifi@0,0 { reg = <0x 0 0 0 0>; mediatek,mtd-eeprom = < 0x8000>;

[OpenWrt-Devel] [PATCH] ath79: Add LED migration for several Archer Cxx devices

2019-09-02 Thread Adrian Schmutzler
Several Archer Cxx devices were using board-specific LED names in ar71xx, which were changed to "tp-link:*" in ath79. This patch adds migration for them. Signed-off-by: Adrian Schmutzler --- .../base-files/etc/uci-defaults/04_led_migration | 15 +++ 1 file changed, 15

[OpenWrt-Devel] [PATCH] treewide: Remove kmod-usb-core from DEVICE_PACKAGES

2019-08-31 Thread Adrian Schmutzler
Signed-off-by: Adrian Schmutzler --- .../ar71xx/generic/profiles/00-default.mk | 2 +- .../ar71xx/image/generic-legacy-devices.mk| 90 +-- target/linux/ar71xx/image/generic-tp-link.mk | 44 +++--- target/linux/ar71xx/image/generic-ubnt.mk | 6 +- target/linux/ar71xx/image

[OpenWrt-Devel] [PATCH] ramips: merge cases in 02_network

2019-08-31 Thread Adrian Schmutzler
This merges three cases with a single switch port. 6t@eth0 and 6@eth0 should be equivalent. Signed-off-by: Adrian Schmutzler --- .../linux/ramips/base-files/etc/board.d/02_network | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/target/linux/ramips/base-files

Re: [OpenWrt-Devel] [PATCH] ipq40xx: Add support for Unielec U4019

2019-08-26 Thread Adrian Schmutzler
> + unielec,u4019*) Please don't do that, but use the full identifier(s). Wildcards are really painful if you ever want to change anything and grep/look for all locations of a specific device in the code. Best Adrian ___ openwrt-devel mailing

[OpenWrt-Devel] [PATCH] ath79: sort device definitions in image/*

2019-08-22 Thread Adrian Schmutzler
This applies alphabetic sorting to devices in image/* files. For certain cases, this patch deviates from strict sorting, e.g. to ensure that v10 comes after v9. While at it, fix an indent and remove some useless empty lines. Signed-off-by: Adrian Schmutzler --- It would be nice

[OpenWrt-Devel] [PATCH] lantiq: sort device definitions in image/Makefile

2019-08-22 Thread Adrian Schmutzler
This sorts the device definitions in image/Makefile alphabetically for each subtarget/block. The order of blocks has not been touched. Signed-off-by: Adrian Schmutzler --- During updating lantiq to DEVICE_VENDOR/DEVICE_MODEL scheme, it became obvious that there is almost no sorting left

<    5   6   7   8   9   10   11   12   >