[ovs-dev] [PATCH] nsh: Avoid zero-length array.

MSVC allows [] but not [0] for arrays in struct definitions. Reported-by: Alin Serdean Signed-off-by: Ben Pfaff --- include/openvswitch/nsh.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/openvswitch/nsh.h

Re: [ovs-dev] [PATCH] m4: Add pkg.m4 from pkg-config.

Thanks, applied to master and branch-2.8. On Tue, Aug 08, 2017 at 09:59:38PM +, Alin Serdean wrote: > Acked-by: Alin Gabriel Serdean > > > -Original Message- > > From: Ben Pfaff [mailto:b...@ovn.org] > > Sent: Wednesday, August 9, 2017 12:57 AM > >

[ovs-dev] [PATCH v2] nsh: Avoid zero-length array.

MSVC allows [] but not [0] for arrays in struct definitions, and does not allow nested [] inside a union. Reported-by: Alin Serdean Signed-off-by: Ben Pfaff --- v1->v2: Avoid [] in nested union also. include/openvswitch/nsh.h | 6 +++---

Re: [ovs-dev] [PATCH] ofp-print: #include its own header first.

On 8 August 2017 at 16:11, Ben Pfaff wrote: > The OVS coding style document says that a .c file should include the > corresponding .h file first, to ensure that the .h file includes all of > its dependencies, but this file didn't do that. > > Signed-off-by: Ben Pfaff

Re: [ovs-dev] ovs delete flow slowly when there are many the flows

On Mon, Jul 24, 2017 at 10:09:39AM +0800, 刘文学 wrote: > In ovs 2.4.0, I run ovs with over thirty thousands of flows added > duration several seconds, and it need nearly several minutes to remove the > flows when the flows expired. > the problem is that the flow delete action is only

Re: [ovs-dev] [PATCH] include: Add struct declaration to ofp-print.h.

On 8 August 2017 at 16:10, Ben Pfaff wrote: > On Tue, Aug 08, 2017 at 02:30:28PM -0700, Joe Stringer wrote: >> If a libopenvswitch user includes ofp-print.h before ofp-util.h (which >> is standard alphabetical order), and turns on -Werror, then they would >> hit this compilation

[ovs-dev] [PATCH] netdev-dummy: Close pcap files when dummy device is closed.

Fixes a fd leak. Reported-by: Alin Gabriel Serdean Signed-off-by: Ben Pfaff --- lib/netdev-dummy.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/lib/netdev-dummy.c b/lib/netdev-dummy.c index 752f15765bb2..62ddd0c67834 100644 ---

Re: [ovs-dev] [PATCH v3] netdev: check for NULL fields in netdev_get_addrs

On Fri, Jul 21, 2017 at 03:28:24PM +, Daniel Alvarez wrote: > When the interfaces list is retrieved through getiffaddrs(), there > might be elements with iface_name set to NULL. > > This patch checks ifa_name to be not NULL before comparing it to the > actual device name in the loop that

[ovs-dev] [PATCH] m4: Add pkg.m4 from pkg-config.

This way, users do not have to install the m4 file from pkg-config, which was not previously a requirement. Without this change, "configure" fails when pkg.m4 is not available via aclocal: ./configure: line 26189: `    PKG_CHECK_MODULES(DPDK, libdpdk,' Reported-by: Alin Serdean

Re: [ovs-dev] [PATCH] include: Add struct declaration to ofp-print.h.

On Tue, Aug 08, 2017 at 02:30:28PM -0700, Joe Stringer wrote: > If a libopenvswitch user includes ofp-print.h before ofp-util.h (which > is standard alphabetical order), and turns on -Werror, then they would > hit this compilation error in the include: > > error: 'struct ofputil_port_map'

Re: [ovs-dev] [PATCH v2] nsh: Avoid zero-length array.

Thanks for the review. Applied to master and branch-2.8. On Tue, Aug 08, 2017 at 11:12:01PM +, Alin Serdean wrote: > Thanks a lot for the patch! > > Acked-by: Alin Gabriel Serdean > > > > -Original Message- > > From: Ben Pfaff

Re: [ovs-dev] [PATCH] netdev-dummy: Close pcap files when dummy device is closed.

Acked-by: Alin Gabriel Serdean > -Original Message- > From: Ben Pfaff [mailto:b...@ovn.org] > Sent: Wednesday, August 9, 2017 2:37 AM > To: d...@openvswitch.org > Cc: Ben Pfaff ; Alin Serdean > > Subject:

[ovs-dev] [patch_v4] dp-packet: Reset DPDK HWOL checksum flags on init.

Reset the DPDK HWOL checksum flags in dp_packet_init_. The new HWOL bad checksum flag is uninitialized on non-dpdk ports and this is noticed as test failures using netdev-dummy ports where the bad checksum flag is checked. Fixes: 7451af618e0d ("dp-packet : Update DPDK rx checksum validation

Re: [ovs-dev] DNS support options

On Tue, Aug 08, 2017 at 04:59:10PM -0400, Lance Richardson wrote: > > > - Original Message - > > From: "Ben Pfaff" > > To: "Lance Richardson" > > Cc: d...@openvswitch.org > > Sent: Tuesday, August 8, 2017 4:49:52 PM > > Subject: Re: [ovs-dev] DNS

Re: [ovs-dev] [PATCH] m4: Add pkg.m4 from pkg-config.

Acked-by: Alin Gabriel Serdean > -Original Message- > From: Ben Pfaff [mailto:b...@ovn.org] > Sent: Wednesday, August 9, 2017 12:57 AM > To: d...@openvswitch.org > Cc: Ben Pfaff ; Alin Serdean > > Subject:

[ovs-dev] [PATCH] ofproto-dpif: Mark packets as "untracked" after call to ct().

Packet and Connection state is only available to the processing path that follows the "recirc_table" argument of the ct() action. The previous behavior made these states available until the end of the pipeline. This commit changes the behavior so that the Packet and Connection state are cleared

Re: [ovs-dev] [patch_v4] dp-packet: Reset DPDK HWOL checksum flags on init.

On 8 August 2017 at 16:39, Darrell Ball wrote: > Reset the DPDK HWOL checksum flags in dp_packet_init_. > The new HWOL bad checksum flag is uninitialized on non-dpdk ports and > this is noticed as test failures using netdev-dummy ports where the bad > checksum flag is checked. >

Re: [ovs-dev] [PATCH 2/3] ovsdb-idl: Avoid new expression.

On 8 August 2017 at 00:46, Gao Zhenyu wrote: > Thanks for working on it! > > I think new_ is not a good name. Could you please try to revise it? > like: old --> old_datum >new -->new_datum Sure thing, that's a better name. > BTW, you also need to update 'new'

Re: [ovs-dev] [RFC] Basic active-active HA for ovn-northd

On Mon, Jul 31, 2017 at 04:53:03PM -0400, Russell Bryant wrote: > I wanted to share the idea before I code it to see if it makes sense. > I imagine the patch would be small, though. > > We currently provide HA for ovn-northd by using Pacemaker to ensure > that ovn-northd is running only one time

[ovs-dev] [PATCHv3 2/2] dpif: Clean up netdev_ports map on dpif_close().

Commit 32b77c316d9982("dpif: Save added ports in a port map.") introduced tracking of all dpif ports by taking a reference on each available netdev when the dpif is opened, but it failed to clear out and release references to these netdevs when the dpif is closed. One of the problems introduced

[ovs-dev] [PATCHv3 1/2] netdev: Free ifidx mapping in netdev_ports_remove().

Previously, netdev_ports_insert() would allocate and insert an ifindex->odp_port mapping, but netdev_ports_remove() would never remove the mapping or free the mapping structure. This patch fixes these up. Fixes: 32b77c316d9982("dpif: Save added ports in a port map.") Reported-by: Andy Zhou

[ovs-dev] Money is ready for pick up

WESTERN UNION MONEY TRANSFER FOREIGN CONTRACTOR PAYMENT OFFICE Corporate Contact Information Corporate Headquarters 12500 E. Bel-ford Avenue Greenwood, CO 80112, USA Direct Contact Email: transferonwesternun...@gmail.com +1 (607) 238 4001 Good Day Beneficiary: I write to inform you that we

Re: [ovs-dev] [PATCHv2 2/2] dpif: Fix clean up of dpif_ports on dpif_close().

On 8 August 2017 at 13:48, Andy Zhou wrote: > On Tue, Aug 8, 2017 at 11:23 AM, Joe Stringer wrote: >> Commit 32b77c316d9982("dpif: Save added ports in a port map.") >> introduced tracking of all dpif ports by taking a reference on each >> available netdev when the

[ovs-dev] [PATCH] ofp-print: #include its own header first.

The OVS coding style document says that a .c file should include the corresponding .h file first, to ensure that the .h file includes all of its dependencies, but this file didn't do that. Signed-off-by: Ben Pfaff --- Depends on https://patchwork.ozlabs.org/patch/799445/.

Re: [ovs-dev] [PATCH v2] nsh: Avoid zero-length array.

Thanks a lot for the patch! Acked-by: Alin Gabriel Serdean > -Original Message- > From: Ben Pfaff [mailto:b...@ovn.org] > Sent: Wednesday, August 9, 2017 2:05 AM > To: d...@openvswitch.org > Cc: Ben Pfaff ; Alin Serdean >

Re: [ovs-dev] [PATCH] ofp-print: #include its own header first.

On Tue, Aug 08, 2017 at 04:23:10PM -0700, Joe Stringer wrote: > On 8 August 2017 at 16:11, Ben Pfaff wrote: > > The OVS coding style document says that a .c file should include the > > corresponding .h file first, to ensure that the .h file includes all of > > its dependencies, but

Re: [ovs-dev] [PATCH] netdev-dummy: Close pcap files when dummy device is closed.

Thanks for the review, I applied this to master, branch-2.8, and branch-2.7. On Tue, Aug 08, 2017 at 11:38:35PM +, Alin Serdean wrote: > Acked-by: Alin Gabriel Serdean > > > > -Original Message- > > From: Ben Pfaff [mailto:b...@ovn.org] > > Sent:

Re: [ovs-dev] [PATCH] ofproto-dpif: Mark packets as "untracked" after call to ct().

With this patch applied: I get 4 failures in kernel system tests and 8 failures in userspace system tests. -Original Message- From: on behalf of Justin Pettit Date: Tuesday, August 8, 2017 at 4:12 PM To: "d...@openvswitch.org"

[ovs-dev] [PATCH] include: Add struct declaration to ofp-print.h.

If a libopenvswitch user includes ofp-print.h before ofp-util.h (which is standard alphabetical order), and turns on -Werror, then they would hit this compilation error in the include: error: 'struct ofputil_port_map' declared inside parameter list will not be visible outside of this definition

Re: [ovs-dev] [PATCH] ovs-ofctl: Avoid unnecessary flow replacement in "replace-flows" command.

Hi Ben, I’ve confirmed that the patch fixed my issue. —Kevin > On Aug 3, 2017, at 1:57 PM, Ben Pfaff wrote: > > On Thu, Aug 03, 2017 at 01:35:50PM -0700, Andy Zhou wrote: >> On Wed, Aug 2, 2017 at 2:13 PM, Ben Pfaff wrote: >>> This bug fix still needs a review.

Re: [ovs-dev] [PATCH] ofproto-dpif: Mark packets as "untracked" after call to ct().

Can you share them? I don't see them on my system or our internal system tester that runs the kernel and user space tests. --Justin > On Aug 8, 2017, at 5:46 PM, Darrell Ball wrote: > > With this patch applied: > > I get 4 failures in kernel system tests and 8 failures

Re: [ovs-dev] [PATCH v3] tnl-ports: Remove netdevs in netdev_hash when deleted

> -Original Message- > From: Ben Pfaff [mailto:b...@ovn.org] > Sent: Wednesday, August 09, 2017 4:06 AM > To: fukaige > Cc: d...@openvswitch.org; Zhaoshenglong > Subject: Re: [PATCH v3] tnl-ports: Remove netdevs in netdev_hash when > deleted > > On Thu, Jul 13, 2017 at 02:04:53AM +,

Re: [ovs-dev] [PATCH] ofproto-dpif: Mark packets as "untracked" after call to ct().

I just rebased about 15 minutes ago: Kernel: 53, 58, 69, 70 Userspace: 57, 58, 63, 69, 70, 71, 72, 73 -Original Message- From: Justin Pettit Date: Tuesday, August 8, 2017 at 5:48 PM To: Darrell Ball Cc: Justin Pettit ,

Re: [ovs-dev] [PATCH v3 1/2] dpif-netdev: Decrease range of values for EMC probability.

-Original Message- From: Ilya Maximets Date: Monday, August 7, 2017 at 4:54 AM To: "Wang, Yipeng1" , Darrell Ball , "ovs-dev@openvswitch.org" Cc: Heetae Ahn , Kevin

Re: [ovs-dev] [PATCH v3 0/6] netdev-dpdk: Use intermediate queue during packet transmission.

Hi Darrell, >Sorry, I was multitasking last week and did not get a chance to finish the >responses on Friday > >I looked thru. the code for all the patches The last 3 patches of V3 needed a >manual merge; as you know, the series needs a rebase after recent commits. I will rebase and send out

Re: [ovs-dev] [PATCH v3 2/6] netdev-dpdk: Add netdev_dpdk_txq_flush function.

>Hi Bhanu > >Would it be possible to combine patches 1 and 2, rather than initially defining >an empty netdev_txq_flush for dpdk ? I think the combined patch would have >more context. No problem Darrell . I will merge 1 & 2 in V4. - Bhanuprakash. > > >-Original Message- >From:

[ovs-dev] [PATCH] Remove duplicate description about Experimenter classes

commit 3d2fbd70bda514f7327970b859663f34f994290c brought duplicate description about Experimenter classes ONFOXM_ET and NXOXM_NSH in lib/meta-flow.xml, branch-2.8 has the same issue. Signed-off-by: Yi Yang --- lib/meta-flow.xml | 23 ++- 1 file changed, 2

Re: [ovs-dev] [PATCH v3 1/2] dpif-netdev: Decrease range of values for EMC probability.

> -Original Message- > From: Darrell Ball [mailto:db...@vmware.com] > Sent: Tuesday, August 8, 2017 8:12 AM > To: Ilya Maximets ; Wang, Yipeng1 > ; ovs-dev@openvswitch.org > Cc: Heetae Ahn ; Kevin Traynor >

Re: [ovs-dev] [PATCH v3 4/6] netdev-dpdk: Add intermediate queue support.

> >This commit introduces netdev_dpdk_eth_tx_queue() function that >implements intermediate queue and packet buffering. The packets get >buffered till the threshold 'INTERIM_QUEUE_BURST_THRESHOLD[32] is >reached and eventually gets transmitted. > >To handle the case(eg: ping)

Re: [ovs-dev] [PATCH v1] netdev-dpdk: Execute QoS Checking before copying to mbuf

Hi Darrell, I am, I've had a cursory look over it already but was planning to do a deeper dive later this week as I have a few concerns about the approach. Ian > -Original Message- > From: Darrell Ball [mailto:db...@vmware.com] > Sent: Tuesday, August 8, 2017 3:07 AM > To: Gao Zhenyu

Re: [ovs-dev] [PATCH v2 2/2] dpif-netdev: Fix emc replacement policy.

Hi Antonio Would you mind sharing your distribution algorithm ? I would like to understand how you saw some benefit in the 1000-5000 range. 1000| 1000, 999 7.85, 8.09 | 1000, 1000 8.77, 8.91 3000| 2993, 2987 7.61, 7.87 | 3000, 3000 8.58, 7.89 5000| 4336, 4872

Re: [ovs-dev] [PATCH 0/7] Add offload support for ip ttl and tcp flags

On Mon, Aug 07, 2017 at 06:19:04PM +0300, Roi Dayan wrote: > Hi, > > This series adds support for offloading ip ttl and tcp flags > using tc interface. This looks nice, thanks. Acked-by: Simon Horman I'm also happy to apply this if someone else provides a review.

Re: [ovs-dev] [PATCH 2/3] ovsdb-idl: Avoid new expression.

Thanks for working on it! I think new_ is not a good name. Could you please try to revise it? like: old --> old_datum new -->new_datum BTW, you also need to update 'new' in the description of struct ovsdb_idl_row which in the top of lib/ovsdb-idl-provider.h Thanks Zhenyu Gao

Re: [ovs-dev] [PATCH 1/2] netdev-vport: Always implement get_ifindex for netdev-vport

On Tue, Aug 08, 2017 at 07:36:25AM +0300, Roi Dayan wrote: > > > On 07/08/2017 20:05, Ben Pfaff wrote: > >On Mon, Aug 07, 2017 at 07:00:31AM -0700, Ben Pfaff wrote: > >>On Mon, Aug 07, 2017 at 07:32:02AM +0300, Roi Dayan wrote: > >>>From: Paul Blakey > >>> > >>>Always

Re: [ovs-dev] [PATCH] dp-packet: Introduce dp_packet_batch_add_unsafe().

On 07.08.2017 23:24, Andy Zhou wrote: > On Mon, Aug 7, 2017 at 8:50 AM, Ilya Maximets wrote: >> Almost all batch usecases covered by the new API introduced >> in commit 72c84bc2db23 ("dp-packet: Enhance packet batch APIs.") >> except unsafe batch addition. It used in

[ovs-dev] About " openvswitch " Name Internationally

(Please forward this to your CEO or President, because this is urgent. ) Dear President & CEO, We mainly deal with domain name and trademark registration in international. There are some things to confirm with you: We received an application from ZJ Investment Co., Ltd. They want to register

Re: [ovs-dev] [patch_v4] dp-packet: Reset DPDK HWOL checksum flags on init.

Thanks Joe I forgot to add your Tested-by to V5; I have been testing this myself; but let me know if you would like it added – I can send a V6. Darrell -Original Message- From: on behalf of Joe Stringer Date: Tuesday, August 8, 2017 at

Re: [ovs-dev] [PATCH net-next] openvswitch: add NSH support

To be clear, the OVS implementation is a placeholder. It will get replaced by whatever netdev implements, and that's OK. I didn't focus on making it perfect because I knew that. Instead, I just made sure it was good enough for an internal OVS implementation that doesn't fix any ABI or API. OVS

Re: [ovs-dev] [PATCH] ofproto-dpif: Mark packets as "untracked" after call to ct().

I just did a second round One correction for first round 73 should have been 79 First round: Kernel: 53, 58, 69, 70 Userspace: 57, 58, 63, 69, 70, 71, 72, 79 Second Round: Kernel: 53, 58, 69, 70 Userspace: 58, 63, 69, 70, 71, 72, 79 Without patch, no failures on both. -Original

Re: [ovs-dev] [PATCHv3 2/2] dpif: Clean up netdev_ports map on dpif_close().

On Tue, Aug 8, 2017 at 5:10 PM, Joe Stringer wrote: > Commit 32b77c316d9982("dpif: Save added ports in a port map.") > introduced tracking of all dpif ports by taking a reference on each > available netdev when the dpif is opened, but it failed to clear out and > release references

Re: [ovs-dev] [PATCH net-next] openvswitch: add NSH support

Hi, Jiri Thank you for your comments. __be32 c[4] is the name Ben Pfaff suggested, the original name is c1, c2, c3, c4, they are context data, so c seems ok, too :-) OVS has merged it and has the same name, maybe the better way is adding comment /* Context data */ after it. For MD type 2,

Re: [ovs-dev] [PATCHv3 1/2] netdev: Free ifidx mapping in netdev_ports_remove().

On Tue, Aug 8, 2017 at 5:10 PM, Joe Stringer wrote: > Previously, netdev_ports_insert() would allocate and insert an > ifindex->odp_port mapping, but netdev_ports_remove() would never remove > the mapping or free the mapping structure. This patch fixes these up. > > Fixes:

Re: [ovs-dev] [RFC] Basic active-active HA for ovn-northd

On Tue, Aug 8, 2017 at 8:04 PM, Ben Pfaff wrote: > On Mon, Jul 31, 2017 at 04:53:03PM -0400, Russell Bryant wrote: >> I wanted to share the idea before I code it to see if it makes sense. >> I imagine the patch would be small, though. >> >> We currently provide HA for ovn-northd by

[ovs-dev] [patch_v5] dp-packet: Reset DPDK HWOL checksum flags on init.

Reset the DPDK HWOL checksum flags in dp_packet_init_. The new HWOL bad checksum flag is uninitialized for non-dpdk ports and this is noticed as test failures using netdev-dummy ports, when built with the --with-dpdk flag set. Hence, in this case, packets may be marked as having a bad checksum.

Re: [ovs-dev] [ovs-discuss] Regarding CFM/OAM support in Openvswitch

Thanks a lot Ben Pfaff for prompt response. Both BFD and CFM (CCM) can be used to monitor connectivity between a pair of Ethernet devices., Could you please share the major differences between BFD & CFM CCM in openvswitch. Kindly share/point me if you have any link/document which describes

Re: [ovs-dev] [ovs-discuss] Regarding CFM/OAM support in Openvswitch

Thanks a lot Ben. Thanks, Anki -Original Message- From: Ben Pfaff [mailto:b...@ovn.org] Sent: Wednesday, August 9, 2017 9:11 AM To: Ankaiah Nallamekala (MFG & Tech) Cc: ovs-dev@openvswitch.org; ovs-disc...@openvswitch.org Subject: Re: [ovs-discuss]

Re: [ovs-dev] [ovs-discuss] Regarding CFM/OAM support in Openvswitch

On Wed, Aug 09, 2017 at 03:12:22AM +, ankaiah.nallamek...@wipro.com wrote: > Both BFD and CFM (CCM) can be used to monitor connectivity between a > pair of Ethernet devices., Could you please share the major > differences between BFD & CFM CCM in openvswitch. They're both about the same.

Re: [ovs-dev] [PATCH] ovs-ofctl: Avoid unnecessary flow replacement in "replace-flows" command.

That's great, thanks for the note. On Tue, Aug 08, 2017 at 05:13:41PM -0700, Kevin Lin wrote: > Hi Ben, > > I’ve confirmed that the patch fixed my issue. > > —Kevin > > > On Aug 3, 2017, at 1:57 PM, Ben Pfaff wrote: > > > > On Thu, Aug 03, 2017 at 01:35:50PM -0700, Andy Zhou

Re: [ovs-dev] [patch_v4] dp-packet: Reset DPDK HWOL checksum flags on init.

I added a “Reported-at:” in a V5 Darrell -Original Message- From: on behalf of Darrell Ball Date: Tuesday, August 8, 2017 at 4:39 PM To: "dlu...@gmail.com" , "d...@openvswitch.org" Subject:

Re: [ovs-dev] [RFC] Basic active-active HA for ovn-northd

On Tue, Aug 08, 2017 at 09:32:03PM -0400, Russell Bryant wrote: > On Tue, Aug 8, 2017 at 8:04 PM, Ben Pfaff wrote: > > On Mon, Jul 31, 2017 at 04:53:03PM -0400, Russell Bryant wrote: > >> I wanted to share the idea before I code it to see if it makes sense. > >> I imagine the patch

[ovs-dev] [PATCHv2 2/2] dpif: Fix clean up of dpif_ports on dpif_close().

Commit 32b77c316d9982("dpif: Save added ports in a port map.") introduced tracking of all dpif ports by taking a reference on each available netdev when the dpif is opened, but it failed to clear out and release references to these netdevs when the dpif is closed. One of the problems introduced

Re: [ovs-dev] [PATCH] rhel: Add support for "systemctl reload openvswitch"

On 8 August 2017 at 11:05, Russell Bryant wrote: > On Tue, Aug 8, 2017 at 1:32 PM, Guru Shetty wrote: > > On 8 August 2017 at 07:42, Timothy Redaelli > wrote: > > > >> The reload procedure will trigger a script that saves the flows and tlv >

Re: [ovs-dev] [PATCH v2] acinclude: netdev-dpdk: use pkg-config of libdpdk

On Tue, Aug 08, 2017 at 07:52:13AM +0200, Christian Ehrhardt wrote: > On Mon, Aug 7, 2017 at 8:42 PM, Ben Pfaff wrote: > > > On Fri, Jul 14, 2017 at 08:36:39AM +0200, Christian Ehrhardt wrote: > > > If available use dpdk pkg-config info of libdpdk to set the right > > > include

Re: [ovs-dev] [PATCH] dp-packet: Introduce dp_packet_batch_add_unsafe().

On Mon, Aug 7, 2017 at 11:01 PM, Ilya Maximets wrote: > On 07.08.2017 23:24, Andy Zhou wrote: >> On Mon, Aug 7, 2017 at 8:50 AM, Ilya Maximets wrote: >>> Almost all batch usecases covered by the new API introduced >>> in commit 72c84bc2db23

[ovs-dev] [RFC_patch_v2] dp-packet: Reset DPDK HWOL bad checksum flags on init.

Reset the DPDK HWOL checksum bad flags on dp_packet_init_. This is an RFC as these flags should be managed by DPDK. Signed-off-by: Darrell Ball --- lib/dp-packet.c | 1 + lib/dp-packet.h | 13 + 2 files changed, 14 insertions(+) diff --git a/lib/dp-packet.c

[ovs-dev] [PATCH] python: make python idl unicode-tolerant

Ensure that JSON is utf-8 encoded and that bytes sent/received on the stream sockets are in utf-8 form. Add a test case to verify that unicode column data can be sent/received successfully using Python module. JSON encoder magic to ensure utf-8 encoding suggested by Terry Wilson. Suggested-by:

Re: [ovs-dev] DNS support options

> From: "Ben Pfaff" > To: d...@openvswitch.org > Sent: Tuesday, August 8, 2017 2:43:17 PM > Subject: [ovs-dev] DNS support options > > Open vSwitch currently supports only IP addresses for specifying > OpenFlow and OVSDB remotes. It would be nice to support DNS names. > Open

[ovs-dev] DNS support options

Open vSwitch currently supports only IP addresses for specifying OpenFlow and OVSDB remotes. It would be nice to support DNS names. Open vSwitch can't afford to let DNS resolution block processing, so it needs some way to resolve DNS asynchronously. I've come up with the following solutions so

[ovs-dev] [PATCH v4 3/5] netdev-dpdk: Add intermediate queue support.

This commit introduces netdev_dpdk_eth_tx_queue() function that implements intermediate queue and packet buffering. The packets get buffered till the threshold 'INTERIM_QUEUE_BURST_THRESHOLD[32] is reached and eventually gets transmitted. Signed-off-by: Bhanuprakash Bodireddy

[ovs-dev] [PATCH v4 4/5] netdev-dpdk: Enable intermediate queue for vHost User port.

This commit refactors the __netdev_dpdk_vhost_send() and enables intermediate queue where in the packets are buffered till the threshold 'INTERIM_QUEUE_BURST_THRESHOLD[32] is hit and eventually gets transmitted. This commit improves the throughput as reported below in simple Physical to virtual

Re: [ovs-dev] [PATCH v1] netdev-dpdk: Implement TCP/UDP TX cksum in ovs-dpdk side

> > Hi Loftus, > > Thanks for testing and the comments! > Can you show more details about your phy-vm-phy,phy-phy setup and > testing steps? Then I can reproduce it to see if I can solve this pps problem. You're welcome. I forgot to mention my tests were with 64B packets. For phy-phy the setup

Re: [ovs-dev] [PATCH v1] netdev-dpdk: Execute QoS Checking before copying to mbuf

Thanks for the review. Please let me know if you have any concern on it. :) Thanks Zhenyu Gao 2017-08-08 17:08 GMT+08:00 Stokes, Ian : > Hi Darrell, > > I am, I've had a cursory look over it already but was planning to do a > deeper dive later this week as I have a few

Re: [ovs-dev] [PATCH v3 6/6] dpif-netdev: Flush the packets in intermediate queue.

Hi Darrell, > >Under low rate traffic conditions, there can be 2 issues. > (1) Packets potentially can get stuck in the intermediate queue. > (2) Latency of the packets can increase significantly due to > buffering in intermediate queue. > >This commit handles the (1)

Re: [ovs-dev] [PATCH v3 00/19] Add OVS DPDK keep-alive functionality.

HI Ilya, >I understand that using rte_keepalive library was worth in the early RFC >because size of RFC was comparable with the size of rte_keepalive library. >But now, as so many generic things was implemented in lib/keepalive.{c,h} >and the size of the patch-set is pretty large, IMHO, it's

[ovs-dev] Hi dear

Good day dear, i hope this mail meets you well? my name is Jack, from the U.S. I know this may seem inappropriate so i ask for your forgiveness but i wish to get to know you better, if I may be so bold. I consider myself an easy-going man, adventurous, honest and fun loving person but I am

Re: [ovs-dev] [PATCH 1/2] netdev-vport: Always implement get_ifindex for netdev-vport

On 08/08/2017 11:04, Simon Horman wrote: On Tue, Aug 08, 2017 at 07:36:25AM +0300, Roi Dayan wrote: On 07/08/2017 20:05, Ben Pfaff wrote: On Mon, Aug 07, 2017 at 07:00:31AM -0700, Ben Pfaff wrote: On Mon, Aug 07, 2017 at 07:32:02AM +0300, Roi Dayan wrote: From: Paul Blakey

Re: [ovs-dev] [PATCH v2 2/2] dpif-netdev: Fix emc replacement policy.

> -Original Message- > From: Darrell Ball [mailto:db...@vmware.com] > Sent: Tuesday, August 8, 2017 8:16 AM > To: Fischetti, Antonio ; Ilya Maximets > ; ovs-dev@openvswitch.org > Cc: Heetae Ahn > Subject: Re:

Re: [ovs-dev] [ovs-tests] Questions about ovs tests

On Mon, Aug 7, 2017 at 9:04 PM Sam wrote: > Hi all, > > I'm working on ovs tests, and I want to add my test, so I have few > questions: > > 1. what testing frame work does ovs-tests use, as I have seen

[ovs-dev] [PATCH V3 2/2] netdev-vport: Always implement get_ifindex for netdev-vport

From: Paul Blakey Always implement get_ifindex without checking if offload is enabled or not as this should not be related. From ovs-dpctl we cannot tell if offload is enabled or not as other_config is not being read. Signed-off-by: Paul Blakey

[ovs-dev] [PATCH V3 0/2] Fix for dumping vxlan flows from ovs-dpctl

Hi, The first patch is to avoid false errors about getting ifindex as the device might disappear already. The second patch is a fix for dumping vxlan rules with ovs-dpctl. V2->V3 - Reorder patches V1->V2 - Bring back ratelimiting Thanks, Roi Paul Blakey (1): netdev-vport: Always

[ovs-dev] [PATCH 0/4] Add offload support for action set

Hi, This series adds support for offloading action set using tc interface. Thanks, Roi Paul Blakey (4): compat: Add act_pedit compatibility for old kernels odp-util: Expose ovs flow key attr len table for reuse tc: Add header rewrite using tc pedit action netdev-tc-offloads: Add

[ovs-dev] [PATCH 1/4] compat: Add act_pedit compatibility for old kernels

From: Paul Blakey Added compatibility for action pedit. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan --- acinclude.m4| 7 include/linux/automake.mk | 1 + include/linux/tc_act/tc_pedit.h | 72

[ovs-dev] [PATCH 2/4] odp-util: Expose ovs flow key attr len table for reuse

From: Paul Blakey Make ovs_flow_key_attr_lens() public to be reused by other modules. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan --- lib/odp-util.c | 11 +-- lib/odp-util.h | 11 +++ 2 files changed, 12

[ovs-dev] [PATCH V3 1/2] netdev-linux: Reduce log level for ENODEV errors getting ifindex

These are normal and unavoidable, because the vifs disappear from the kernel before they are removed them from the OVS database. Signed-off-by: Roi Dayan Reviewed-by: Paul Blakey --- lib/netdev-linux.c | 8 ++-- 1 file changed, 6 insertions(+), 2

[ovs-dev] [PATCH 4/4] netdev-tc-offloads: Add support for action set

From: Paul Blakey Implement support for offloading ovs action set using tc header rewrite action. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan --- lib/netdev-tc-offloads.c | 180 +-- 1

[ovs-dev] [PATCH 3/4] tc: Add header rewrite using tc pedit action

From: Paul Blakey To be later used to implement ovs action set offloading. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan --- lib/tc.c | 372 ++- lib/tc.h | 12 +++ 2

Re: [ovs-dev] [ovs-discuss] Regarding CFM/OAM support in Openvswitch

On Tue, Aug 08, 2017 at 02:07:25PM +, ankaiah.nallamek...@wipro.com wrote: > Ethernet CFM/OAM supports Loopback protocol(LBM) and Link Trace > protocol(LTM), Is ovs is supporting these two protocols as well, if so > could you please describe how to use these two protocols. OVS doesn't support

Re: [ovs-dev] 答复: Re: 答复: Re: 答复: Re: 答复: Re: [PATCH] ovn: Support for taas(tap-as-a-service) function

No problem. Thanks for considering the alternative approach! On Mon, Aug 7, 2017 at 9:12 PM, wrote: > Ok, I will make a new version which have no mirror switch. This may need > some days. > > Thanks > > > > > > Gao Zhenyu > 2017/08/07 22:34 > >

Re: [ovs-dev] DPDK build errors on travis

We ran these builds many times with 17.05.1 and they were fine. Is Travis switching over to a new build environment ? I saw a notification “This job ran on our Trusty environment, which is gradually becoming our default Linux environment. Read all about this in our blog: Trusty as a default

[ovs-dev] [PATCH v4 1/5] netdev: Add netdev_txq_flush function.

Add netdev_txq_flush(), that flush packets on a queue. This is needed to transmit packets on the intermediate queue. This commit also implements netdev_dpdk_txq_flush() function. If there are any packets waiting in the queue, they are transmitted instantly using the rte_eth_tx_burst function. In

Re: [ovs-dev] DNS support options

From: ovs-dev-boun...@openvswitch.org on behalf of Lance Richardson Sent: Tuesday, August 8, 2017 11:59 AM To: Ben Pfaff Cc: d...@openvswitch.org Subject: Re: [ovs-dev] DNS support options >

Re: [ovs-dev] [PATCHv2 2/2] dpif: Fix clean up of dpif_ports on dpif_close().

Seems good to me! Acked-by: Paul Blakey Thanks On 08/08/2017 21:23, Joe Stringer wrote: Commit 32b77c316d9982("dpif: Save added ports in a port map.") introduced tracking of all dpif ports by taking a reference on each available netdev when the dpif is opened, but it

Re: [ovs-dev] [PATCH v3] tnl-ports: Remove netdevs in netdev_hash when deleted

On Thu, Jul 13, 2017 at 02:04:53AM +, fukaige wrote: > > > > -Original Message- > > From: fukaige > > Sent: Tuesday, July 11, 2017 3:34 PM > > To: 'Ben Pfaff' > > Cc: d...@openvswitch.org; Zhaoshenglong > > Subject: RE: [PATCH v3] tnl-ports: Remove netdevs in netdev_hash when > >

Re: [ovs-dev] [PATCH v2] ovsschema: Fix line lengths.

On Thu, Jul 13, 2017 at 02:29:39AM +0100, Bhanuprakash Bodireddy wrote: > According to coding style the line lengths should be <=79. Fix the > schema file and update the checksum and version number to reflect the > change. > > Signed-off-by: Bhanuprakash Bodireddy

[ovs-dev] [RFC_patch_v3] dp-packet: Reset DPDK HWOL checksum flags on init.

Reset the DPDK HWOL checksum flags on dp_packet_init_. This is an RFC as these flags should be managed by DPDK. Signed-off-by: Darrell Ball --- v2->v3: Use existing API to reset both bad and good HWOL checksum flags. lib/dp-packet.c | 1 + 1 file changed, 1

Re: [ovs-dev] DNS support options

On Tue, Aug 08, 2017 at 07:15:26PM +, Shashank Ram wrote: > > Open vSwitch currently supports only IP addresses for specifying > > OpenFlow and OVSDB remotes. It would be nice to support DNS names. > > Open vSwitch can't afford to let DNS resolution block processing, so it > > needs some way

Re: [ovs-dev] [PATCH v5 1/2] OF support and translation of generic encap and decap

We can add the additional syntax at the same time we add something that has the need for it. On Tue, Aug 08, 2017 at 03:52:32PM +, Jan Scheurich wrote: > I know this comment is late as the patch has been merged already, but I just > returned from vacation and only found today: > > I agree

Re: [ovs-dev] DNS support options

On Tue, Aug 08, 2017 at 02:59:21PM -0400, Lance Richardson wrote: > > From: "Ben Pfaff" > > To: d...@openvswitch.org > > Sent: Tuesday, August 8, 2017 2:43:17 PM > > Subject: [ovs-dev] DNS support options > > > > Open vSwitch currently supports only IP addresses for specifying > >

Re: [ovs-dev] [RFC v2] [OVS/NOVA] Vhost-user backends cross-version migration support

On Tue, Jul 18, 2017 at 03:42:08PM +0200, Maxime Coquelin wrote: > This is an revival from a thread I initiated earlier this year [0], that > I had to postpone due to other priorities. > > First, I'd like to thanks reviewers of my first proposal, this new > version tries to address the comments

Re: [ovs-dev] [PATCH v3 1/2] ovn-controller: readonly mode binding_run and get_br_int

On Thu, Jul 13, 2017 at 03:54:01PM -0700, Han Zhou wrote: > This change is to prepare for the future change for multi-threading. > Both binding_run() and get_br_int() are needed by pinctrl thread, > but we don't want to update SB DB or create bridges in that scenario, > so need "readonly" mode for

  1   2   >