Re: [pgadmin-hackers] [PATCH] Tables node (pgAdmin4)

On 26 May 2016 at 11:20, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA patch for RM#1231 & RM#1237. > > Additionally I have shifted 'Advanced tab' after columns & constraint tab. > > > @Thom, > > Reading "Of type" drop-down, We borrowed sql query from pgadmin3 to >

Re: [pgadmin-hackers] [PATCH] Tables node (pgAdmin4)

s://redmine.postgresql.org/projects/pgadmin4/; for the > same. > > -- > > Thanks & Regards, > > Ashesh Vashi > EnterpriseDB INDIA: Enterprise PostgreSQL Company > <http://www.enterprisedb.com> > > > *http://www.linkedin.com/in/asheshvashi* > <http://www.l

Re: [pgadmin-hackers] [PATCH] Tables node (pgAdmin4)

On 25 May 2016 at 02:00, Thom Brown <t...@linux.com> wrote: > On 25 May 2016 at 00:29, Thom Brown <t...@linux.com> wrote: >> On 24 May 2016 at 19:09, Ashesh Vashi <ashesh.va...@enterprisedb.com> wrote: >>> >>> On Mon, May 23, 2016 at 6

Re: [pgadmin-hackers] [PATCH] Tables node (pgAdmin4)

On 25 May 2016 at 00:29, Thom Brown <t...@linux.com> wrote: > On 24 May 2016 at 19:09, Ashesh Vashi <ashesh.va...@enterprisedb.com> wrote: >> >> On Mon, May 23, 2016 at 6:35 PM, Murtuza Zabuawala >> <murtuza.zabuaw...@enterprisedb.com> wrote: >>> &

Re: [pgadmin-hackers] [PATCH] Tables node (pgAdmin4)

On 27 April 2016 at 14:34, Thom Brown <t...@linux.com> wrote: > On 27 April 2016 at 13:43, Thom Brown <t...@linux.com> wrote: >> On 27 April 2016 at 10:22, Harshal Dhumal >> <harshal.dhu...@enterprisedb.com> wrote: >>> >>> Hi, >>> >&

Re: [pgadmin-hackers] [PATCH] Tables node (pgAdmin4)

On 27 April 2016 at 13:43, Thom Brown <t...@linux.com> wrote: > On 27 April 2016 at 10:22, Harshal Dhumal > <harshal.dhu...@enterprisedb.com> wrote: >> >> Hi, >> >> PFA attached patches for table node and all table child nodes. >> >>

Re: [pgadmin-hackers] [PATCH] Tables node (pgAdmin4)

On 27 April 2016 at 10:22, Harshal Dhumal wrote: > > Hi, > > PFA attached patches for table node and all table child nodes. > > This patch includes below nodes, > > 1) Table node -- Initial patch by Murtuza, > constraints

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Functions/Procedures Module

On 5 April 2016 at 17:20, Dave Page <dp...@pgadmin.org> wrote: > On Tue, Apr 5, 2016 at 5:18 PM, Thom Brown <t...@linux.com> wrote: >> I'm getting weirdness with this node. See the attached picture, where >> it shows the servers node appearing under functions. >

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Functions/Procedures Module

I'm getting weirdness with this node. See the attached picture, where it shows the servers node appearing under functions. Thom On 5 April 2016 at 16:21, Dave Page wrote: > Thanks - committed. > > On Mon, Mar 28, 2016 at 8:26 AM, Khushboo Vashi >

[pgadmin-hackers] Speed up node animation in pgAdmin4

Hi, I've attached a patch to speed up the expansion/collapsing of nodes. I've found it sluggish when testing, so I suggest we make it feel more responsive. I've also changed the speed of scrolling to an item. I don't know if we use this anywhere, but in case we do, I don't think we want it as

[pgadmin-hackers] pgAdmin4 HTML5 corrections

Hi, Attached are various HTML5 markup fixes for pgAdmin4. Regards Thom diff --git a/web/pgadmin/browser/templates/browser/body.html b/web/pgadmin/browser/templates/browser/body.html index 29ea474..211b7e1 100644 --- a/web/pgadmin/browser/templates/browser/body.html +++

Re: [pgadmin-hackers] Materialized View Patch File

On 29 May 2013 10:40, Neel Patel neel.pa...@enterprisedb.com wrote: Hi Dave, Please find the updated patch after fixing some of the issues and comments given by Ashesh. Just realised this reply has been in my draft folder for over a month... This comment appears to be incomplete: //While

[pgadmin-hackers] Indexed constraint comments not working

Hi all, Comments on indexed constraints (primary keys, exclusion constraints etc.) are failing due to referencing the wrong alias of the relevant pg_description join in the join clause. Test case: CREATE TABLE test (id int); ALTER TABLE test ADD CONSTRAINT cnt_x_test EXCLUDE USING btree (id

Re: [pgadmin-hackers] Indexed constraint comments not working

On 26 May 2013 18:20, Thom Brown t...@linux.com wrote: Hi all, Comments on indexed constraints (primary keys, exclusion constraints etc.) are failing due to referencing the wrong alias of the relevant pg_description join in the join clause. Test case: CREATE TABLE test (id int); ALTER

Re: [pgadmin-hackers] pgAdmin III commit: Add support for range types (9.2+)

On 30 April 2012 15:44, Guillaume Lelarge guilla...@lelarge.info wrote: On Sun, 2012-04-29 at 22:22 +0100, Thom Brown wrote: On 29 April 2012 21:56, Guillaume Lelarge guilla...@lelarge.info wrote: Add support for range types (9.2+) Range types aren't added to the type drop-down and instead

Re: [pgadmin-hackers] pgAdmin III commit: Add support for range types (9.2+)

On 30 April 2012 15:57, Guillaume Lelarge guilla...@lelarge.info wrote: On Mon, 2012-04-30 at 15:47 +0100, Thom Brown wrote: On 30 April 2012 15:44, Guillaume Lelarge guilla...@lelarge.info wrote: On Sun, 2012-04-29 at 22:22 +0100, Thom Brown wrote: On 29 April 2012 21:56, Guillaume Lelarge

Re: [pgadmin-hackers] pgAdmin III commit: Add support for range types (9.2+)

On 29 April 2012 21:56, Guillaume Lelarge guilla...@lelarge.info wrote: Add support for range types (9.2+) Range types aren't added to the type drop-down and instead only show the array-equivalents. -- Thom -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make

Re: [pgadmin-hackers] Incorrect domain logic for 9.1

On 24 April 2012 16:53, Dave Page dp...@pgadmin.org wrote: Done - thanks Thom. Cheers Dave. -- Thom -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] Incorrect domain logic for 9.1

Hi, I noticed that if I create a domain based on an array data type, it doesn't get listed in the Domains node if the server is 9.1. This is because the query that gets the domains says that if the number of dimensions used is greater than 0 (which it will be if it's an array), then it must

Re: [pgadmin-hackers] Problem building pgadmin

On 4 March 2012 16:03, Dave Page dp...@pgadmin.org wrote: On Sun, Mar 4, 2012 at 3:48 PM, Thom Brown t...@linux.com wrote: Hi all, I haven't tried building PgAdmin in quite a while now, so have started from scratch again.  I seem to be getting the following problem: make  install-data-hook

Re: [pgadmin-hackers] pgAdmin III commit: Update serbian translation

On 2 March 2012 15:38, Guillaume Lelarge guilla...@lelarge.info wrote: Update serbian translation Can someone confirm whether this is really correct? Клијенстки фајл са кључом Should this instead be: Клијентског фајл са кључом -- Thom -- Sent via pgadmin-hackers mailing list

Re: [pgadmin-hackers] pgAdmin III commit: Update serbian translation

2012/3/2 Magnus Hagander mag...@hagander.net: 2012/3/2 Thom Brown t...@linux.com: On 2 March 2012 15:38, Guillaume Lelarge guilla...@lelarge.info wrote: Update serbian translation Can someone confirm whether this is really correct? Клијенстки фајл са кључом Should this instead

Re: [pgadmin-hackers] pgAdmin III commit: Update serbian translation

On 2 March 2012 16:02, Guillaume Lelarge guilla...@lelarge.info wrote: On Fri, 2012-03-02 at 16:56 +0100, Magnus Hagander wrote: 2012/3/2 Thom Brown t...@linux.com: On 2 March 2012 15:38, Guillaume Lelarge guilla...@lelarge.info wrote: Update serbian translation Can someone confirm

Re: [pgadmin-hackers] pgAdmin III commit: Update serbian translation

On 3 March 2012 07:02, Guillaume Lelarge guilla...@lelarge.info wrote: On Fri, 2012-03-02 at 17:01 +0100, Guillaume Lelarge wrote: On Fri, 2012-03-02 at 15:53 +, Thom Brown wrote: On 2 March 2012 15:38, Guillaume Lelarge guilla...@lelarge.info wrote: Update serbian translation Can

Re: [pgadmin-hackers] New options dialog

them all in one tab, or having dozens of tabs to scroll through. +1 So this is effectively the same way that LibreOffice/OpenOffice does it :) -- Thom Brown Twitter: @darkixion IRC (freenode): dark_ixion Registered Linux user: #516935 EnterpriseDB UK: http://www.enterprisedb.com The Enterprise

Re: [pgadmin-hackers] Patch to add support for not valid domain and check constraint

. I'm using latest master. -- Thom Brown Twitter: @darkixion IRC (freenode): dark_ixion Registered Linux user: #516935 EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your

Re: [pgadmin-hackers] Altering column collation

On 21 July 2011 21:58, Guillaume Lelarge guilla...@lelarge.info wrote: On Thu, 2011-07-21 at 22:54 +0200, Guillaume Lelarge wrote: On Thu, 2011-07-21 at 21:44 +0200, Guillaume Lelarge wrote: On Wed, 2011-07-20 at 10:56 +0100, Thom Brown wrote: On 19 July 2011 21:04, Guillaume Lelarge guilla

Re: [pgadmin-hackers] Altering column collation

On 19 July 2011 21:04, Guillaume Lelarge guilla...@lelarge.info wrote: On Tue, 2011-07-19 at 20:43 +0100, Thom Brown wrote: On 19 July 2011 08:32, Guillaume Lelarge guilla...@lelarge.info wrote: On Tue, 2011-07-19 at 00:48 +0100, Thom Brown wrote: [...] Attached is a patch which fixes #328

Re: [pgadmin-hackers] Altering column collation

On 19 July 2011 08:32, Guillaume Lelarge guilla...@lelarge.info wrote: On Tue, 2011-07-19 at 00:48 +0100, Thom Brown wrote: [...] Attached is a patch which fixes #328.  Currently if you change a column's collation, it actually drops the column.  This changes it so that it issues an ALTER TYPE

Re: [pgadmin-hackers] Prevent duplicate attributes

On 14 July 2011 10:31, Thom Brown t...@linux.com wrote: On 14 July 2011 10:24, Guillaume Lelarge guilla...@lelarge.info wrote: So, you're working on fixing it, right? Possibly ;)  : http://code.pgadmin.org/trac/ticket/329 I haven't had time to look at fixing various bugs over the last couple

Re: [pgadmin-hackers] Prevent duplicate attributes

On 18 July 2011 21:55, Guillaume Lelarge guilla...@lelarge.info wrote: On Mon, 2011-07-18 at 21:06 +0100, Thom Brown wrote: On 14 July 2011 10:31, Thom Brown t...@linux.com wrote: On 14 July 2011 10:24, Guillaume Lelarge guilla...@lelarge.info wrote: So, you're working on fixing it, right

Re: [pgadmin-hackers] Prevent duplicate attributes

On 18 July 2011 22:25, Guillaume Lelarge guilla...@lelarge.info wrote: On Mon, 2011-07-18 at 22:15 +0100, Thom Brown wrote: On 18 July 2011 21:55, Guillaume Lelarge guilla...@lelarge.info wrote: On Mon, 2011-07-18 at 21:06 +0100, Thom Brown wrote: On 14 July 2011 10:31, Thom Brown t

Re: [pgadmin-hackers] Prevent duplicate attributes

On 14 July 2011 10:24, Guillaume Lelarge guilla...@lelarge.info wrote: On Tue, 2011-07-12 at 11:17 +0100, Thom Brown wrote: On 12 July 2011 11:11, Guillaume Lelarge guilla...@lelarge.info wrote: On Tue, 2011-07-12 at 10:55 +0100, Thom Brown wrote: On 12 July 2011 10:53, Dave Page dp

Re: [pgadmin-hackers] Overhaul of type attributes modification

On 14 July 2011 10:28, Dave Page dp...@pgadmin.org wrote: On Thu, Jul 14, 2011 at 10:22 AM, Guillaume Lelarge guilla...@lelarge.info wrote: On Mon, 2011-07-11 at 15:29 +0100, Thom Brown wrote: On 11 July 2011 15:21, Guillaume Lelarge guilla...@lelarge.info wrote: On Sun, 2011-07-10 at 01:05

Re: [pgadmin-hackers] Prevent duplicate attributes

On 12 July 2011 10:53, Dave Page dp...@pgadmin.org wrote: On Sat, Jul 9, 2011 at 9:02 PM, Thom Brown t...@linux.com wrote: Hi (yes, me... again), Tiny patch attached to prevent adding attributes with a duplicate name to a type.  It seems previous versions prevented this, but must have been

Re: [pgadmin-hackers] New key shortcuts for query window

On 12 July 2011 10:59, Dave Page dp...@pgadmin.org wrote: On Sun, Jul 10, 2011 at 1:45 PM, Thom Brown t...@linux.com wrote: Hi all, I think the SQL query window should have a File Close menu item, which maps to Ctrl+W (or Apple+W in the case of a Mac).  This is easy to add. We already

Re: [pgadmin-hackers] Prevent duplicate attributes

On 12 July 2011 11:11, Guillaume Lelarge guilla...@lelarge.info wrote: On Tue, 2011-07-12 at 10:55 +0100, Thom Brown wrote: On 12 July 2011 10:53, Dave Page dp...@pgadmin.org wrote: On Sat, Jul 9, 2011 at 9:02 PM, Thom Brown t...@linux.com wrote: Hi (yes, me... again), Tiny patch

Re: [pgadmin-hackers] New key shortcuts for query window

On 12 July 2011 11:11, Dave Page dp...@pgadmin.org wrote: On Tue, Jul 12, 2011 at 11:03 AM, Thom Brown t...@linux.com wrote: On 12 July 2011 10:59, Dave Page dp...@pgadmin.org wrote: On Sun, Jul 10, 2011 at 1:45 PM, Thom Brown t...@linux.com wrote: Hi all, I think the SQL query window should

Re: [pgadmin-hackers] Overhaul of type attributes modification

On 11 July 2011 15:21, Guillaume Lelarge guilla...@lelarge.info wrote: On Sun, 2011-07-10 at 01:05 +0100, Thom Brown wrote: On 9 July 2011 23:58, Thom Brown t...@linux.com wrote: I've found a corner-case bug btw, which requires a tiny amendment. But I'm also rebasing the patch for current

[pgadmin-hackers] New key shortcuts for query window

item. You can add another menu item for the additional key binding, but that looks rubbish. Any idea if it's possible to show both key bindings on the same item? e.g. Execute F5/Ctrl+R Thanks Thom Brown Twitter: @darkixion IRC (freenode): dark_ixion Registered Linux user: #516935

Re: [pgadmin-hackers] [FEATURE] Add schema option to all relevant objects

On 9 July 2011 09:28, Guillaume Lelarge guilla...@lelarge.info wrote: On Sat, 2011-07-09 at 00:23 +0100, Thom Brown wrote: On 9 July 2011 00:12, Guillaume Lelarge guilla...@lelarge.info wrote: On Fri, 2011-07-08 at 21:55 +0200, Guillaume Lelarge wrote: On Fri, 2011-07-08 at 20:06 +0100, Thom

Re: [pgadmin-hackers] Overhaul of type attributes modification

the alter attribute capabilities. We can just do: ALTER TYPE s1.ty2 ALTER ATTRIBUTE c3 TYPE xml; That will preserve its position without ever having to drop it. I'm not sure why I didn't see it before. -- Thom Brown Twitter: @darkixion IRC (freenode): dark_ixion Registered Linux user: #516935

Re: [pgadmin-hackers] Overhaul of type attributes modification

On 9 July 2011 13:25, Guillaume Lelarge guilla...@lelarge.info wrote: On Sat, 2011-07-09 at 13:14 +0100, Thom Brown wrote: The major issue is why we use the drop all, add all method.  Let's say I have a composite type declared like this: CREATE TYPE s1.ty2 AS   (c1 integer,    c2

Re: [pgadmin-hackers] [FEATURE] Add schema option to all relevant objects

On 9 July 2011 12:56, Guillaume Lelarge guilla...@lelarge.info wrote: On Sat, 2011-07-09 at 10:33 +0100, Thom Brown wrote: On 9 July 2011 09:28, Guillaume Lelarge guilla...@lelarge.info wrote: On Sat, 2011-07-09 at 00:23 +0100, Thom Brown wrote: On 9 July 2011 00:12, Guillaume Lelarge guilla

Re: [pgadmin-hackers] Overhaul of type attributes modification

On 9 July 2011 13:26, Thom Brown t...@linux.com wrote: On 9 July 2011 13:25, Guillaume Lelarge guilla...@lelarge.info wrote: On Sat, 2011-07-09 at 13:14 +0100, Thom Brown wrote: The major issue is why we use the drop all, add all method.  Let's say I have a composite type declared like

Re: [pgadmin-hackers] [FEATURE] Add schema option to all relevant objects

On 9 July 2011 20:55, Guillaume Lelarge guilla...@lelarge.info wrote: On Sat, 2011-07-09 at 15:14 +0100, Thom Brown wrote: BTW, just commited and pushed your patch. Thanks again. \o/ Thanks again Guillaume. -- Thom Brown Twitter: @darkixion IRC (freenode): dark_ixion Registered Linux user

[pgadmin-hackers] Prevent duplicate attributes

Hi (yes, me... again), Tiny patch attached to prevent adding attributes with a duplicate name to a type. It seems previous versions prevented this, but must have been allowed in a commit since the last release. Regards Thom Brown Twitter: @darkixion IRC (freenode): dark_ixion Registered Linux

Re: [pgadmin-hackers] Overhaul of type attributes modification

On 9 July 2011 21:07, Guillaume Lelarge guilla...@lelarge.info wrote: On Sat, 2011-07-09 at 17:54 +0100, Thom Brown wrote: On 9 July 2011 13:26, Thom Brown t...@linux.com wrote: On 9 July 2011 13:25, Guillaume Lelarge guilla...@lelarge.info wrote: On Sat, 2011-07-09 at 13:14 +0100, Thom

Re: [pgadmin-hackers] Overhaul of type attributes modification

On 9 July 2011 21:11, Thom Brown t...@linux.com wrote: On 9 July 2011 21:07, Guillaume Lelarge guilla...@lelarge.info wrote: On Sat, 2011-07-09 at 17:54 +0100, Thom Brown wrote: On 9 July 2011 13:26, Thom Brown t...@linux.com wrote: On 9 July 2011 13:25, Guillaume Lelarge guilla

Re: [pgadmin-hackers] Overhaul of type attributes modification

On 9 July 2011 23:58, Thom Brown t...@linux.com wrote: I've found a corner-case bug btw, which requires a tiny amendment. But I'm also rebasing the patch for current master and 1.14_patches (or whatever it's called), so you'll get these shortly Okay, here are the two rebased patches, both

[pgadmin-hackers] Overhaul of type attributes modification

the collation condition was based on the precision being present for some reason. And if you actually assigned a collation for a valid data type, it wouldn't appear at all, so that's fixed too. -- Thom Brown Twitter: @darkixion IRC (freenode): dark_ixion Registered Linux user: #516935 EnterpriseDB UK

Re: [pgadmin-hackers] Overhaul of type attributes modification

On 8 July 2011 15:19, Thom Brown t...@linux.com wrote: Hi all, I noticed that if you add, delete, rename or change the type, collation or precision of a composite type attribute, it deletes all of them then adds them all back in.  Obviously attribute additions, deletions and modifications

Re: [pgadmin-hackers] Overhaul of type attributes modification

On 8 July 2011 15:38, Thom Brown t...@linux.com wrote: On 8 July 2011 15:19, Thom Brown t...@linux.com wrote: Hi all, I noticed that if you add, delete, rename or change the type, collation or precision of a composite type attribute, it deletes all of them then adds them all back

Re: [pgadmin-hackers] [FEATURE] Add schema option to all relevant objects

On 8 July 2011 19:46, Guillaume Lelarge guilla...@lelarge.info wrote: On Thu, 2011-07-07 at 23:24 +0100, Thom Brown wrote: On 7 July 2011 23:20, Guillaume Lelarge guilla...@lelarge.info wrote: On Wed, 2011-07-06 at 11:59 +0100, Thom Brown wrote: add_schemas_to_all_items_filtered.patch - same

Re: [pgadmin-hackers] [FEATURE] Add schema option to all relevant objects

started looking at code really so wouldn't have seen the issue first-hand. Extensions are a weird case for me since you can assign them to a schema, but they are immune to being hidden by the search path. -- Thom Brown Twitter: @darkixion IRC (freenode): dark_ixion Registered Linux user: #516935

Re: [pgadmin-hackers] [FEATURE] Add schema option to all relevant objects

On 8 July 2011 20:52, Guillaume Lelarge guilla...@lelarge.info wrote: On Fri, 2011-07-08 at 20:46 +0200, Guillaume Lelarge wrote: On Thu, 2011-07-07 at 23:24 +0100, Thom Brown wrote: On 7 July 2011 23:20, Guillaume Lelarge guilla...@lelarge.info wrote: On Wed, 2011-07-06 at 11:59 +0100

Re: [pgadmin-hackers] [FEATURE] Add schema option to all relevant objects

, so now if the name of a text search configuration is changed, it appears in the SQL output twice. My original patch moved a whole section of code, but now the removal of the original copy is missing. Everything else seems to work fine though. -- Thom Brown Twitter: @darkixion IRC (freenode

Re: [pgadmin-hackers] [FEATURE] Add schema option to all relevant objects

On 9 July 2011 00:12, Guillaume Lelarge guilla...@lelarge.info wrote: On Fri, 2011-07-08 at 21:55 +0200, Guillaume Lelarge wrote: On Fri, 2011-07-08 at 20:06 +0100, Thom Brown wrote: On 8 July 2011 19:46, Guillaume Lelarge guilla...@lelarge.info wrote: On Thu, 2011-07-07 at 23:24 +0100

Re: [pgadmin-hackers] [FEATURE] Add schema option to all relevant objects

On 7 July 2011 23:20, Guillaume Lelarge guilla...@lelarge.info wrote: On Wed, 2011-07-06 at 11:59 +0100, Thom Brown wrote: add_schemas_to_all_items_filtered.patch - same patch as before, but with the above patch contents removed or adjusted to assume the fixes have been applied. Not yet

[pgadmin-hackers] Prevent function rewrite when changing owner

Hi all, Tiny patch attached to prevent a function being completely rewritten when just the owner changes. Not sure if you regard it as a bug fix or merely an efficiency feature. -- Thom Brown Twitter: @darkixion IRC (freenode): dark_ixion Registered Linux user: #516935 EnterpriseDB UK: http

Re: [pgadmin-hackers] Prevent function rewrite when changing owner

On 8 July 2011 01:18, Dave Page dp...@pgadmin.org wrote: Thanks - patch applied. Cheers! Thom -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [FEATURE] Add schema option to all relevant objects

On 5 July 2011 20:47, Guillaume Lelarge guilla...@lelarge.info wrote: Hi Thom, On Tue, 2011-07-05 at 20:23 +0100, Thom Brown wrote: [...] I noticed that objects which can be moved to different schemas can't be moved in PgAdmin, so I looked to see if there was any request to have

Re: [pgadmin-hackers] [FEATURE] Add schema option to all relevant objects

to think I may have unleashed some sort of rampant patch beast... :/ BTW, are you going to char(11)? Are you? Did we have that conversation already? :-) No, and no. :( -- Thom Brown Twitter: @darkixion IRC (freenode): dark_ixion Registered Linux user: #516935 EnterpriseDB UK: http

Re: [pgadmin-hackers] [FEATURE] Add schema option to all relevant objects

so I don't know how easy it is to do that. -- Thom Brown Twitter: @darkixion IRC (freenode): dark_ixion Registered Linux user: #516935 EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make

Re: [pgadmin-hackers] [FEATURE] Add schema option to all relevant objects

On 5 July 2011 21:08, Guillaume Lelarge guilla...@lelarge.info wrote: On Tue, 2011-07-05 at 21:01 +0100, Thom Brown wrote: On 5 July 2011 20:47, Guillaume Lelarge guilla...@lelarge.info wrote: Hi Thom, On Tue, 2011-07-05 at 20:23 +0100, Thom Brown wrote: [...] I noticed that objects

Re: [pgadmin-hackers] Changing extension schema silently fails

On 5 July 2011 21:23, Thom Brown t...@linux.com wrote: Hi, I'm using the latest head and I created the file_fdw extension, then attempted to change its schema.  No error was returned, but it remained in the same schema. I then dropped the extension and created it again specifying the new

[pgadmin-hackers] Changing extension schema silently fails

missing something, or does this fail silently? -- Thom Brown Twitter: @darkixion IRC (freenode): dark_ixion Registered Linux user: #516935 EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org

Re: [pgadmin-hackers] [FEATURE] OIDs check box to enable OIDs

On 2 July 2011 21:26, Thom Brown t...@linux.com wrote: On 2 July 2011 20:20, Guillaume Lelarge guilla...@lelarge.info wrote: Great patch. It even helped me find a bug. Anyway, commited and pushed. Thank you. Thanks for committing it. :) I personally prefer the ones with newlines, especially

[pgadmin-hackers] Updated sequence syntax

this won't enable anything to work that didn't previously, but just thought it would be nice to use more suitable syntax. -- Thom Brown Twitter: @darkixion IRC (freenode): dark_ixion Registered Linux user: #516935 EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git

Re: [pgadmin-hackers] Updated sequence syntax

On 3 July 2011 22:40, Guillaume Lelarge guilla...@lelarge.info wrote: On Sun, 2011-07-03 at 19:23 +0100, Thom Brown wrote: [...] I noticed that altering sequences still uses the old ALTER TABLE syntax.  While that's required for older versions, it's not anymore. Attached a patch to use most

[pgadmin-hackers] [BUG] Meaningless dialogue when deleting foreign key

fk_name? - No / Yes Is this a known bug? Thom Brown Twitter: @darkixion IRC (freenode): dark_ixion Registered Linux user: #516935 EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company attachment: delete_foreign_key.png -- Sent via pgadmin-hackers mailing list (pgadmin

Re: [pgadmin-hackers] [BUG] Meaningless dialogue when deleting foreign key

On 2 July 2011 13:08, Guillaume Lelarge guilla...@lelarge.info wrote: On Sat, 2011-07-02 at 12:12 +0100, Thom Brown wrote: Hi, I'm using PgAdmin III 1.14 beta 2 on OSX.  When attempting to delete a foreign key on a table, a dialogue comes up saying Foreign Key - Foreign Key - No / Yes

[pgadmin-hackers] [FEATURE] OIDs check box to enable OIDs

statements require lots of horizontal scrolling on the SQL tab to see what the action will be. Could we harmonise these? Note that I didn't change the format for OIDs when I added the WITH OIDS variant. Thanks -- Thom Brown Twitter: @darkixion IRC (freenode): dark_ixion Registered Linux user: #516935

Re: [pgadmin-hackers] [FEATURE] OIDs check box to enable OIDs

long names, and some of the above statements require lots of horizontal scrolling on the SQL tab to see what the action will be.  Could we harmonise these? Yes, we should. Could you provide a patch? Sure, I'll take a look at it. -- Thom Brown Twitter: @darkixion IRC (freenode): dark_ixion

Re: [pgadmin-hackers] pgAdmin III commit: Update CHANGELOG and make style.

+- 5 files changed, 9 insertions(+), 6 deletions(-) You appear to have added an entry for the fill factor patch twice. -- Thom Brown Twitter: @darkixion IRC (freenode): dark_ixion Registered Linux user: #516935 EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: [pgadmin-hackers] Proportional font in messages tab on OSX

On 1 July 2011 12:06, Dave Page dp...@pgadmin.org wrote: On Fri, Jul 1, 2011 at 1:28 AM, Thom Brown t...@linux.com wrote: Hi, I notice that on OSX using PgAdmin 1.14 beta 2 the messages tab are showing in a proportional font if an error occurs more than once.  The first time it displays

[pgadmin-hackers] Proportional font in messages tab on OSX

, and on the preferences tab it shows as Lucida Grande, 11. The query I've been using to force an error is just: SELECT DELETE; Thanks Thom Brown Twitter: @darkixion IRC (freenode): dark_ixion Registered Linux user: #516935 EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: [pgadmin-hackers] pgAdmin III commit: Rename Replication to Slony Replication

deletions(-) Minor point but in pgadmin/ui/dlgAggregate.xrc, Slony doesn't have an uppercase 'S', but does everywhere else. -- Thom Brown Twitter: @darkixion IRC (freenode): dark_ixion Registered Linux user: #516935 EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

[pgadmin-hackers] Bug with Foreign table interface

any dependency on the foreign server, and the foreign server shows no dependency on the file_fdw extension. Regards -- Thom Brown Twitter: @darkixion IRC (freenode): dark_ixion Registered Linux user: #516935 EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent

[pgadmin-hackers] Insufficient description in collation mismatch error

in the SELECT. -- Thom Brown Twitter: @darkixion IRC (freenode): dark_ixion Registered Linux user: #516935 EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http

Re: [pgadmin-hackers] Insufficient description in collation mismatch error

On 19 April 2011 23:57, Thom Brown t...@linux.com wrote: Hi, I tried applying a collation to a GROUP BY clause without applying the collation to the corresponding column in the SELECT clause. postgres=# SELECT things, count(*) FROM stuff GROUP BY things COLLATE C; ERROR:  column

Re: [pgadmin-hackers] User mapping

think it's more intuitive. -- Thom Brown Twitter: @darkixion IRC (freenode): dark_ixion Registered Linux user: #516935 EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your

Re: [pgadmin-hackers] pgAdmin III commit: Fix selection of objects in backup/restore dialogs

if in there, or is one of them misnamed? Cheers -- Thom Brown Twitter: @darkixion IRC (freenode): dark_ixion Registered Linux user: #516935 EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes

[pgadmin-hackers] Remove name as valid parameter for catalog functions

Patch attached which corrects the docs where catalog functions no longer accept values of type name. Originally a note submitted by someone on the docs, but this affects more than just the one they mentioned. -- Thom Brown Twitter: @darkixion IRC (freenode): dark_ixion Registered Linux user

Re: [pgadmin-hackers] [DOCS] Remove name as valid parameter for catalog functions

On 7 March 2011 20:49, Tom Lane t...@sss.pgh.pa.us wrote: Thom Brown t...@linux.com writes: Patch attached which corrects the docs where catalog functions no longer accept values of type name.  Originally a note submitted by someone on the docs, but this affects more than just the one

Re: [pgadmin-hackers] pgAdmin III commit: Somehow forgot to commit this.

Modified Files -- acinclude.m4                |    4 ++-- pgadmin/frm/frmQuery.cpp    |    4 ++-- pgadmin/utils/sysLogger.cpp |    3 +++ 3 files changed, 7 insertions(+), 4 deletions(-) And what is this? -- Thom Brown Twitter: @darkixion IRC (freenode): dark_ixion Registered

Re: [pgadmin-hackers] pgAdmin III commit: Somehow forgot to commit this.

On 16 February 2011 13:03, Dave Page dp...@pgadmin.org wrote: On Wed, Feb 16, 2011 at 12:56 PM, Thom Brown t...@linux.com wrote: On 16 February 2011 12:54, Dave Page dp...@pgadmin.org wrote: Somehow forgot to commit this. Branch -- master Details --- http://git.postgresql.org

Re: [pgadmin-hackers] pgAdmin III commit: Unbreak the windows installer (grrrr Magnus!)

On 2 February 2011 12:49, Magnus Hagander mag...@hagander.net wrote: Ooh, nice. Sorry about that one. //Magnus No you're not. -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] Restore database form button

On 28 October 2010 13:57, Thom Brown t...@linux.com wrote: Could you change the OK button on the Restore database form to Restore? I still press OK even after restoring a database as I see the log messages, and naturally assume OK will close the window. Actually, I've noticed the restore

Re: [pgadmin-hackers] Restore database form button

On 29 October 2010 15:34, Guillaume Lelarge guilla...@lelarge.info wrote: Le 29/10/2010 06:16, Thom Brown a écrit : On 28 October 2010 13:57, Thom Brown t...@linux.com wrote: Could you change the OK button on the Restore database form to Restore? I still press OK even after restoring

[pgadmin-hackers] Restore database form button

Could you change the OK button on the Restore database form to Restore? I still press OK even after restoring a database as I see the log messages, and naturally assume OK will close the window. Cheers -- Thom Brown Twitter: @darkixion IRC (freenode): dark_ixion Registered Linux user: #516935

Re: [pgadmin-hackers] wrong indexes sizes on index page

On 13 October 2010 08:30, Guillaume Lelarge guilla...@lelarge.info wrote: Le 13/10/2010 00:35, Thom Brown a écrit : On 12 October 2010 16:19, Guillaume Lelarge guilla...@lelarge.info wrote: Le 12/10/2010 14:37, Thom Brown a écrit : On 12 October 2010 11:01, Timon timo...@gmail.com wrote: 2010

Re: [pgadmin-hackers] wrong indexes sizes on index page

On 13 October 2010 09:27, Thom Brown t...@linux.com wrote: On 13 October 2010 08:30, Guillaume Lelarge guilla...@lelarge.info wrote: Le 13/10/2010 00:35, Thom Brown a écrit : On 12 October 2010 16:19, Guillaume Lelarge guilla...@lelarge.info wrote: Le 12/10/2010 14:37, Thom Brown a écrit

Re: [pgadmin-hackers] wrong indexes sizes on index page

PostgreSQL 8.3.1, and PostgreSQL 9.0.0. -- Thom Brown Twitter: @darkixion IRC (freenode): dark_ixion Registered Linux user: #516935 -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] wrong indexes sizes on index page

On 12 October 2010 16:19, Guillaume Lelarge guilla...@lelarge.info wrote: Le 12/10/2010 14:37, Thom Brown a écrit : On 12 October 2010 11:01, Timon timo...@gmail.com wrote: 2010/10/12 Guillaume Lelarge guilla...@lelarge.info: Le 12/10/2010 11:47, Thom Brown a écrit : On 12 October 2010 10:29

Re: [pgadmin-hackers] wrong indexes sizes on index page

On 12 October 2010 16:19, Guillaume Lelarge guilla...@lelarge.info wrote: Le 12/10/2010 14:37, Thom Brown a écrit : On 12 October 2010 11:01, Timon timo...@gmail.com wrote: 2010/10/12 Guillaume Lelarge guilla...@lelarge.info: Le 12/10/2010 11:47, Thom Brown a écrit : On 12 October 2010 10:29

Re: [pgadmin-hackers] Documentation

select “Store password”, pgAdmin stores passwords you enter in the ~/.pgpass file under Unix or :file:%APPDATA%postgresqlpgpass.conf --- That's because those paragraphs are justified. Just alter the css to use text-align: left; instead. -- Thom Brown Twitter: @darkixion IRC (freenode

Re: [pgadmin-hackers] Documentation

the screenshots too, so it includes the mystery history box! :D (although no textual references to it ATM) -- Thom Brown Twitter: @darkixion IRC (freenode): dark_ixion Registered Linux user: #516935 -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your

Re: [pgadmin-hackers] Documentation

On 27 September 2010 09:26, Dave Page dp...@pgadmin.org wrote: On Mon, Sep 27, 2010 at 9:11 AM, Thom Brown t...@linux.com wrote: On 27 September 2010 09:00, Dave Page dp...@pgadmin.org wrote: Wow, that was quick (and unexpected!). There's some weirdness here, but maybe that's just a markup

Re: [pgadmin-hackers] pgAdmin III commit: Fix a couple of minor UI layout issues.

-- pgadmin/ui/dlgEditGridOptions.xrc |  317 +- pgadmin/ui/frmOptions.xrc         | 1985 +- pgadmin/ui/xrcDialogs.cpp         |60290 +++-- 3 files changed, 31293 insertions(+), 31299 deletions(-) What a ridiculously large diff that produces! -- Thom Brown

  1   2   >