Re: [HACKERS] Try to fix endless loop in ecpg with informix mode

decide which to return. Ah, now I understand. Sorry, I completely misunderstood your prior email. Yes, you're right, I will change the code accordingly. Thanks. Michael -- Michael Meskes Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org) Meskes at (Debian|Postgresql) dot

Re: [HACKERS] Try to fix endless loop in ecpg with informix mode

t; false) > ... >return false; > +} while (isdigit(**scan_length)); Yes, this is certainly correct and better than what I committed. What was I thinking yesterday? I think the same function is used for identifying garbage in floats which might ask for different log

Re: [HACKERS] Try to fix endless loop in ecpg with informix mode

x27;\0'. > > > > The first patch will reproduce the problem in ecpg's regress test. > > The second patch tries to fix it in simple way. Thanks for spotting and fixing. I changed your patch slightly and made it check if the rest of the data is indeed digits, or else it w

Re: [HACKERS] [bug fix] ECPG: fails to recognize embedded parameters

h to master and backported to 9.4, 9.5, 9.6 and 10. It doesn't apply cleanly to 9.3. But then it might not be important enough to investigate and backported to this old a version. Michael -- Michael Meskes Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org) Meskes at (Debian|Postgr

Re: [HACKERS] datetime.h defines like PM conflict with external libraries

> Isn't pgtypeslib/*.h exposed to ecpg-using applications? No, the public interface is is include/*.h, pgtypeslib/*.h is only internal. Michael -- Michael Meskes Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org) Meskes at (Debian|Postgresql) dot Org Jabber: michael

Re: [HACKERS] datetime.h defines like PM conflict with external libraries

y whatever we can. The fewer manual sync we need, the better. Michael -- Michael Meskes Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org) Meskes at (Debian|Postgresql) dot Org Jabber: michael at xmpp dot meskes dot org VfL Borussia! Força Barça! SF 49ers! Use Debian GNU/Linux, Post

Re: [HACKERS] 【ECPG】strncpy function does not set the end character '\0'

ecause there is a reason why we, and other databases, define it that way. Michael -- Michael Meskes Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org) Meskes at (Debian|Postgresql) dot Org Jabber: michael at xmpp dot meskes dot org VfL Borussia! Força Barça! SF 49ers! Use Debi

Re: [HACKERS] 【ECPG】strncpy function does not set the end character '\0'

e > sure that the last byte gets set to 0. I doubt it'll be a lot. However, it would make us differ, albeit very slightly, from what others do. I haven't come up with a practical problem coming from that difference though. Michael -- Michael Meskes Michael at Fam-Meskes dot De, Michael a

Re: [HACKERS] 【ECPG】strncpy function does not set the end character '\0'

do you think there should be one? My memory might be wrong but I don't think it's supposed to be a null terminated string. Michael -- Michael Meskes Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org) Meskes at (Debian|Postgresql) dot Org Jabber: michael at xmpp dot mesk

Re: [HACKERS] Build failure on thrips

> woodlouse does not do ecpg-check, and Tom is right anyway. I need to > get a large sign nailed to my forehead that says "Postgres is C, and > declarations must come first." I didn't notice either. I guess /me is getting rusty, sigh. Michael -- Michael Meskes Mich

Re: [HACKERS] Build failure on thrips

> Unless someone has a better idea, I'd suggest working around > that like so: > > #ifdef WIN32 > #ifdef _MSC_VER/* requires MSVC */ >    _configthreadlocale(_ENABLE_PER_THREAD_LOCALE); > #endif > #endif Let's try, committed, thanks again Tom.

Re: [HACKERS] Build failure on thrips

pg check (... I wonder > why). I would assume it works on woodlouse as the patch has been submitted by woodlouse's owner. Michael -- Michael Meskes Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org) Meskes at (Debian|Postgresql) dot Org Jabber: michael at xmpp dot mesk

[HACKERS] Build failure on thrips

chael -- Michael Meskes Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org) Meskes at (Debian|Postgresql) dot Org Jabber: michael at xmpp dot meskes dot org VfL Borussia! Força Barça! Go SF 49ers! Use Debian GNU/Linux, PostgreSQL -- Sent via pgsql-hackers mailing list (pgsql-ha

Re: [HACKERS] Not listed as committer

> Ha, that's interesting. > > Should be fixed now, please try again.  Works, thanks Magnus. Michael -- Michael Meskes Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org) Meskes at (Debian|Postgresql) dot Org Jabber: michael at xmpp dot meskes dot org VfL Borussi

Re: [HACKERS] ECPG: WHENEVER statement with DO CONTINUE action

> Given that it's Friday evening in Europe, I'm betting Michael is gone > for the day.  In the interests of getting the buildfarm back to > green, > I'll see if I can fix this. Correct, thanks Tom. Michael -- Michael Meskes Michael at Fam-Meskes dot De, Michael at

[HACKERS] Not listed as committer

All, I just committed a patch that is listed in the CF and had to put somebody (I chose you Bruce :)) in as a committer because I was not listed. Do I have to register somewhere? Michael -- Michael Meskes Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org) Meskes at (Debian

Re: [HACKERS] ECPG: WHENEVER statement with DO CONTINUE action

> The v3 patch looks good to me. I've changed this patch status to Ready > for Committer. Thank you all, committed. Michael -- Michael Meskes Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org) Meskes at (Debian|Postgresql) dot Org Jabber: michael at xmpp dot mes

Re: [HACKERS] assorted code cleanup

> And there are many "(0)" "S_ANYTHING" in src/interfaces/ecpg/test/ and > src/interfaces/ecpg/preproc/. I might have missed something here, but where/why is S_ANYTHING a problem? Michael -- Michael Meskes Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|

Re: [HACKERS] Rust bindings to pgtypes lib

gtypeslib. > > Some people use http://libpqtypes.esilo.com/ Never before saw this. It does not seem to have more in common than the name, though. Michael -- Michael Meskes Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org) Meskes at (Debian|Postgresql) dot Org Jabber: michael at xmpp do

Re: [HACKERS] Rust bindings to pgtypes lib

e would I have to carve out? > Or from another perspective; how do other language (if any) solve this? I'm not aware of any other language binding for pgtypeslib. Michael -- Michael Meskes Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org) Meskes at (Debian|Postgresql)

Re: [HACKERS] ECPG: WHENEVER statement with DO CONTINUE action

e add a "DO CONTINUE" case to one of the test cases? Or add a new one? We would need a test case IMO. Thanks Michael -- Michael Meskes Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org) Meskes at (Debian|Postgresql) dot Org Jabber: michael at xmpp dot meskes dot or

Re: [HACKERS] Is ECPG's SET CONNECTION really not thread-aware?

ely before backporting. Obviously this doesn't make any sense for a doc patch, sigh. Michael -- Michael Meskes Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org) Meskes at (Debian|Postgresql) dot Org Jabber: michael at xmpp dot meskes dot org VfL Borussia! Força Barça! Go SF 49ers

Re: [HACKERS] Is ECPG's SET CONNECTION really not thread-aware?

o the doc seems to need fix. The patch is attached. Thanks, applied. Michael -- Michael Meskes Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org) Meskes at (Debian|Postgresql) dot Org Jabber: michael at xmpp dot meskes dot org VfL Borussia! Força Barça! Go SF 49ers! Use Debian G

Re: [HACKERS] ECPG: pg_type.h file is not synced

regards, tom lane Agreed. We will only run into problems with ecpg if some of the existing oids change. Newly added ones will not be referenced unless ecpg receives changes, too. Michael -- Michael Meskes Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org) Meskes at (Debian|Po

Re: [HACKERS] ECPG: pg_type.h file is not synced

e file should be up to date. Thanks for the patch, committed. Michael -- Michael Meskes Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org) Meskes at (Debian|Postgresql) dot Org Jabber: michael at xmpp dot meskes dot org VfL Borussia! Força Barça! Go SF 49ers! Use Debian GNU/Lin

Re: [HACKERS] Host variables corresponding bytea type in ecpg

> > > I attach modified patch. > > Thank you, committed. > > I don't see a git push for this? Oops, should be there now. Michael -- Michael Meskes Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org) Meskes at (Debian|Postgresql) dot Org Jabber: mich

Re: [HACKERS] Host variables corresponding bytea type in ecpg

> I attach modified patch. Thank you, committed. Michael -- Michael Meskes Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org) Meskes at (Debian|Postgresql) dot Org Jabber: michael at xmpp dot meskes dot org VfL Borussia! Força Barça! SF 49ers! Use Debian GNU/Linux, Postgre

Re: [HACKERS] Two phase commit in ECPG

> Yes. I added two-phase commit test to "make check" test schedule > while > adding new two type of test. Thank you, committed. Michael -- Michael Meskes Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org) Meskes at (Debian|Postgresql) dot Org Jabber: michael

Re: [HACKERS] Two phase commit in ECPG

twophase > from schedule file and add new type of regression test. Would it be possible to include it in "make check"? Any check that needs manual interaction will not be executed nearly is often as the others and become much less useful imo. Michael -- Michael Meskes Michael at F

Re: [HACKERS] Two phase commit in ECPG

> Previous 002 patch lacked to add describing PREPARE TRANSACTION. > Attached updated 002 patch. I just committed both patches and a backport of the bug fix itself. Thanks again for finding and fixing. Michael -- Michael Meskes Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|N

Re: [HACKERS] Two phase commit in ECPG

me time it became the cause of this > behavior. > Is this a bug? I'd say so, yes. As soon as I find time I'll get to it including back porting your patch. Thank you very much for spotting and fixing. Michael -- Michael Meskes Michael at Fam-Meskes dot De, Michael at Meskes dot

Re: [HACKERS] Keep ECPG comment for log_min_duration_statement

> Michael Meskes wrote: > > The other option I can see, albeit without looking into details, is > > allowing all comments and then testing it for the right syntax > > after > > parsing. This could potentially also solve the above mentioned > > option > > prob

Re: [HACKERS] Keep ECPG comment for log_min_duration_statement

ntially also solve the above mentioned option problem. Michael -- Michael Meskes Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org) Meskes at (Debian|Postgresql) dot Org Jabber: michael at xmpp dot meskes dot org VfL Borussia! Força Barça! SF 49ers! Use Debian GNU/Linux, Postgre

Re: [HACKERS] Keep ECPG comment for log_min_duration_statement

parse-comment" version the default without a new option? Michael -- Dr. Michael Meskes, Geschaeftsfuehrer/CEO Tel.: +49 (0)2166 / 99 01 0 E-Mail: michael.mes...@credativ.com IM: m...@jabber.credativ.com PGP: BBBC 58B4 5994 CF9C CC56  BCDA DF23 DA33 9697 8EB3 credativ international

Re: [WIP] RE: [HACKERS] DECLARE STATEMENT setting up a connection in ECPG

ostgreSQL addon. However, I think other databases do have the same statement, or don't they?  Michael -- Michael Meskes Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org) Meskes at (Debian|Postgresql) dot Org Jabber: michael at xmpp dot meskes dot org VfL Borussia! Força Barça!

Re: [HACKERS] [bug fix] Trivial ecpg bug which can cause memory overrun

Hi, > While investigating some other issue, we found a trivial bug of > ecpg.  The attached is a fix for that. > ... Thanks for spotting and fixing. Committed. Michael -- Michael Meskes Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org) Meskes at (Debian|Postgresql

Re: [HACKERS] Fix typo in ecpg.sgml

> there is a missing "EXEC" in ecpg.sgml in the list of transaction > management commands. Right, and the "SQL" was missing, too. Thanks for spotting, fixed in HEAD. Michael -- Michael Meskes Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org) Meskes

Re: [HACKERS] DECLARE STATEMENT setting up a connection in ECPG

gt; by statement_name. Ah, now I understand. Thank you for your explanation. I'm looking forward to seeing your patch. Michael -- Michael Meskes Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org) Meskes at (Debian|Postgresql) dot Org Jabber: michael at xmpp dot meskes dot org

Re: [HACKERS] DECLARE STATEMENT setting up a connection in ECPG

ely declarative, i.e. not executed at run time? Michael -- Michael Meskes Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org) Meskes at (Debian|Postgresql) dot Org Jabber: michael at xmpp dot meskes dot org VfL Borussia! Força Barça! Go SF 49ers! Use Debian GNU/Linux, Postgr

Re: [HACKERS] Let's get rid of the separate minor version numbers for shlibs

the PG version makes much more sense IMO. Michael -- Michael Meskes Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org) Meskes at (Debian|Postgresql) dot Org Jabber: michael at xmpp dot meskes dot org VfL Borussia! Força Barça! SF 49ers! Use Debian GNU/Linux, PostgreSQL --

Re: [HACKERS] Question and suggestion about application binary compatibility policy

er, I'd prefer a technical solution over a documentation one. Michael -- Michael Meskes Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org) Meskes at (Debian|Postgresql) dot Org Jabber: michael at xmpp dot meskes dot org VfL Borussia! Força Barça! SF 49ers! Use Debian GNU/L

Re: [HACKERS] Question and suggestion about application binary compatibility policy

brary names like libpq5.dll and > libecpg6.dll, so that the application can fail to run with the > incompatible versions of libpq and libecpg.  FYI: Does this mean you cannot have to versions of libpq installed on the same Windows system at the same time? Michael --  Michael Meskes Michael a

Re: [HACKERS] Question and suggestion about application binary compatibility policy

ing the application binary compatibility > policy in the PostgreSQL manual.  What do you think about it? Couldn't you point your customer to the system documentation? Personally I don't think standard system behavior should be documented for each application relying on it but ymmv

Re: [HACKERS] Question and suggestion about application binary compatibility policy

reSQL topic, but a general system one as for instance the same holds for libc. Michael -- Michael Meskes Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org) Meskes at (Debian|Postgresql) dot Org Jabber: michael at xmpp dot meskes dot org VfL Borussia! Força Barça! SF 49ers!

Re: [HACKERS] NOT EXIST for PREPARE

pt exactly the same SQL. And we spend quite a bit of effort to make it auto-build from the backend parser to make sure we don't lose any changes.  Michael -- Michael Meskes Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org) Meskes at (Debian|Postgresql) dot Org Jabber:

Re: [HACKERS] NOT EXIST for PREPARE

> PS Who use ecpg? For me it's like hell.  More than you think. I doubt you want to propose removing features that make developing new features harder, or do you? :) Michael -- Michael Meskes Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org) Meskes at (Debian|Postgre

Re: [HACKERS] backpatch for REL9_4_STABLE of commit 40482e606733675eb9e5b2f7221186cf81352da1

On Mon, Feb 08, 2016 at 09:20:46AM +, Huong Dangminh wrote: > I think this fixed is also required for REL9_4_STABLE. > Please confirm the attached patch. Sure thing, no idea where that cherry-pick got lost. Thanks. Michael -- Michael Meskes Michael at Fam-Meskes dot De, Michael at

Re: [HACKERS] Warnings around booleans

ber that it used to be bool back in the day. > Does this look right to you? If so, will you apply it? Yes and yes. Thanks for spotting, fixed in master and the back branches. Michael -- Michael Meskes Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org) Meskes at (Debian|P

Re: [HACKERS] Collection of memory leaks for ECPG driver

something locally consistent ;) Thanks, committed. Michael -- Michael Meskes Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org) Meskes at (Debian|Postgresql) dot Org Jabber: michael.meskes at gmail dot com VfL Borussia! Força Barça! Go SF 49ers! Use Debian GNU/Linux, PostgreS

Re: [HACKERS] Collection of memory leaks for ECPG driver

L). There's also the point that changing longstanding code > creates back-patching hazards, so unless there's a clear gain it's best > not to. Makes sense, but there is no point in adding hos if-guards to old code that doesn't have it either,right? Michael -- Micha

Re: [HACKERS] Collection of memory leaks for ECPG driver

impact is minimal > there then I am fine to not modify descriptor.c. Sorry, I wasn't referring to descriptor.c but to the whole preproc/ subtree. But as I already said, since we went through the effort we can of course apply it. Will be in my next push. Thanks. Michael -- Michael Meskes

Re: [HACKERS] Collection of memory leaks for ECPG driver

ike a precompiler, particularly if they add more than a simple free() command? But then, you already did the work, so why not. Anyway, please tell me if you want to update the patch or if I should commit whatever is clear already. Michael -- Michael Meskes Michael at Fam-Meskes dot De, Michael at Mes

Re: [HACKERS] Problems with question marks in operators (JDBC, ECPG, ...)

t it *is* their problem, as they should be using > the standard Postgres way for placeholders, which is $1, $2, $3... As Bruno already pointed out one could also argue that they just try to accept what the standard asked them for. I fail to see how such a way of arguing brings us closer to a sol

Re: [HACKERS] Problems with question marks in operators (JDBC, ECPG, ...)

it means breaking the standard? Michael -- Michael Meskes Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org) Meskes at (Debian|Postgresql) dot Org Jabber: michael.meskes at gmail dot com VfL Borussia! Força Barça! Go SF 49ers! Use Debian GNU/Linux, PostgreSQL -- Sent via pgsq

Re: [HACKERS] Problems with question marks in operators (JDBC, ECPG, ...)

rver.) Indeed it is. The question mark is used in ecpg to denote a variable to be filled-in by the process. I'm not completely sure if this was in the standard or only implemented because several (not sure if all) other precompiler used it as well. Michael -- Michael Meskes Michael at Fam-Me

Re: [HACKERS] Object files generated by ecpg test suite not ignored on Windows

he ecpg > tests there. Completely agreed. >> Since we have a global ignore rule for .o >> files it makes plenty of sense to have one for .obj files also. >> Certainly better than have one rule for each ecpg test case. > > Agreed. So we should revert the previous patc

Re: [HACKERS] Object files generated by ecpg test suite not ignored on Windows

I don't have a Windows system to test on, but how come these files were only created in the ecpg testsuite? With the global .gitignore not mentioning *.obj it appears those files are not created anywhere else. Is the build process different for the rest of the tree? Michael -- Michael Meske

Re: [HACKERS] Object files generated by ecpg test suite not ignored on Windows

> When running the test suite of ecpg, build generates a set of obj > files and it happens that those files are not ignored in the code > tree. Applied, thanks. Michael -- Michael Meskes Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org) Michael at BorussiaFan dot D

Re: [HACKERS] Dereferenced pointer checks in data.c of ECPG

> A patch is attached, and the issue has been spotted by Coverity. > Regards, Thanks, committed. Michael -- Michael Meskes Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org) Michael at BorussiaFan dot De, Meskes at (Debian|Postgresql) dot Org Jabber: michael.meskes at

Re: [HACKERS] ecpg array support, or lack thereof

On Wed, Feb 04, 2015 at 10:07:07AM -0500, Tom Lane wrote: > Michael Meskes would be the authority on that question, so I've cc'd > him to make sure he notices this thread ... Thanks Tom. > > The leaks were in the code that takes a host variable, and converts it > >

Re: [HACKERS] Unlikely-to-happen crash in ecpg driver caused by NULL-pointer check not done

On Tue, Feb 03, 2015 at 10:44:17PM +0900, Michael Paquier wrote: > All those things are addressed in the patch attached. Fixed a typo and commited. Thanks Michael for fixing and Heikki for reviewing. Michael -- Michael Meskes Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|

Re: [HACKERS] Proposal for better support of time-varying timezone abbreviations

t that doesn't matter that much as the codes won't be used by the server anyway. Besides, they may eventually change and then we have to make sure to remember ecpg's copy again. Michael -- Michael Meskes Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org) Mich

Re: [HACKERS] Proposal for better support of time-varying timezone abbreviations

meaning has actually changed over time. Eventually that > might be all of them ... but in the meantime, we could at least > argue that we weren't breaking any case that worked well before. This is what your patch did, right? Michael -- Michael Meskes Michael at Fam-Meskes dot De, Mich

Re: [HACKERS] Proposal for better support of time-varying timezone abbreviations

, that might break some applications, but then the server doesn't know these either, so the applications might break anyway. Michael -- Michael Meskes Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org) Michael at BorussiaFan dot De, Meskes at (Debian|Postgresql) dot Org Ja

Re: [HACKERS] using array of char pointers gives wrong results

> PFA patch ecpg_char_ptr_arr.patch to fix this issue. It has changes as > follows > ... Thanks for finding and fixing the problem. Patch applied to complete 9 series with only a minor change. Michael -- Michael Meskes Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Co

Re: [HACKERS] Review: ECPG FETCH readahead

a look at it. Zoltan, could you send a new version by end of day tomorrow? I'll be sitting on a plane for a longer time again on Saturday. :) Michael -- Michael Meskes Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org) Michael at BorussiaFan dot De, Meskes at (Debian|Postgresql)

Re: [HACKERS] Pointer to structure in ECPG

Thanks Ashutosh, both patches committed and backported to the whole 9.* series. Michael -- Michael Meskes Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org) Michael at BorussiaFan dot De, Meskes at (Debian|Postgresql) dot Org Jabber: michael.meskes at gmail dot com VfL

Re: [HACKERS] using arrays within structure in ECPG

s over the years this test isn't needed anymore. The regression suite works without just nicely. To be honest, the whole type.c code needs a real rewrite to be better legible. Michael -- Michael Meskes Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org) Michael at Borussi

Re: [HACKERS] using arrays within structure in ECPG

On Wed, Apr 02, 2014 at 09:33:15AM +0530, Ashutosh Bapat wrote: > So, you are saying that we should try to catch such errors and report > during pre-compile time. That's better than silently corrupting the data. Well, I think this goes without saying. Michael -- Michael Meskes Mic

Re: [HACKERS] using arrays within structure in ECPG

e the implementation is nevertheless lacking. I'm sorry, but this sounds like a missing feature bug. Michael -- Michael Meskes Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org) Michael at BorussiaFan dot De, Meskes at (Debian|Postgresql) dot Org Jabber: michael.meskes at gm

Re: [HACKERS] using arrays within structure in ECPG

next row > onwards, the calculated offset of arr_col member would not coincide with > the real arr_col member's address. > > Am I missing something here? No, this looks like a bug to me. I haven't had time to look into the source codebut the offset definitely is off. Michael --

Re: [HACKERS] ECPG regression tests generating warnings

On Sun, Jan 12, 2014 at 08:28:57AM -0800, Kevin Grittner wrote: > desc.pgc:55: WARNING: descriptor ""outdesc"" does not exist > desc.pgc:86: WARNING: descriptor ""outdesc"" does not exist Thanks, I didn't notice, fixed. Michael -- Michael Mes

Re: [HACKERS] [bug fix] ECPG app crashes due to SIGBUS on SPARC Solaris

Michael -- Michael Meskes Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org) Michael at BorussiaFan dot De, Meskes at (Debian|Postgresql) dot Org Jabber: michael.meskes at gmail dot com VfL Borussia! Força Barça! Go SF 49ers! Use Debian GNU/Linux, PostgreSQL -- Sent via pgsq

Re: [HACKERS] preproc.c compilation error

You have to rebuild the auto-generated pgc.c, preproc.c and preproc.y or simply remove them to force a rebuild. Michael -- Michael Meskes Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org) Michael at BorussiaFan dot De, Meskes at (Debian|Postgresql) dot Org Jabber

Re: [HACKERS] [bug fix] connection service file doesn't take effect with ECPG apps

not creating an empty host variable instead of checking for it after the fact. But I take it you don't mind that. Fixed in HEAD and all back branches. Thanks for the report. Michael -- Michael Meskes Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org) Michael at BorussiaFan

Re: [HACKERS] [bug fix] ECPG app crashes due to SIGBUS on SPARC Solaris

On Sat, Dec 28, 2013 at 08:04:09AM +0900, MauMau wrote: > OK, I'll run the ECPG regression test on Solaris without the patch. > Please wait until Jan 6 2014 or so, because we've just entered new > year holidays here in Japan. Sure, we're no in a particular hurry. Mi

Re: [HACKERS] [bug fix] connection service file doesn't take effect with ECPG apps

still like to figure out why I don't see the same behaviour. Michael -- Michael Meskes Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org) Michael at BorussiaFan dot De, Meskes at (Debian|Postgresql) dot Org Jabber: michael.meskes at gmail dot com VfL Borussia! Força Barç

Re: [HACKERS] [bug fix] ECPG app crashes due to SIGBUS on SPARC Solaris

o ECPGdo() > with non-zero lengths. How did you decide which values to put in? I fail to see a reason for choosing exactly these values. Mkichael -- Michael Meskes Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org) Michael at BorussiaFan dot De, Meskes at (Debian|Po

Re: [HACKERS] [bug fix] connection service file doesn't take effect with ECPG apps

y string as the value for "host" connection parameter > to PQconnectdbParams(). Interestingly enough it works flawlessly on my system. Any idea where the empoty host name comes from? Before accepting the patch I'd like to find out why you got an empty host variable and I don't. M

Re: [HACKERS] Modify the DECLARE CURSOR command tag depending on the scrollable flag

way, is explicitly adding NO SCROLL the preferred solution for everyone? +1 from me. Michael -- Michael Meskes Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org) Michael at BorussiaFan dot De, Meskes at (Debian|Postgresql) dot Org Jabber: michael.meskes at gmail dot com V

Re: [HACKERS] Building on S390

said: It uses -fpic instead of -fPIC. No, I'm not shortening that email reply here. :) Checking the Debian logs it appears that all calls use *both* which seems to do the right thing. And yes, it appears there is a change in XC that makes it break. But still, I would think there has to be a c

[HACKERS] Building on S390

,$(host_cpu))" "s390" CFLAGS_SL = -fPIC else before setting CFLAGS_SL = -fpic et voila XC builds just fine on S390. So I wonder shouldn't we use -fPIC instead of -fpic for S390 in general? Michael -- Michael Meskes Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Or

Re: [HACKERS] [PATCH] ecpg: Split off mmfatal() from mmerror()

#x27;t tried it, but it sure looks good to me. Feel free to commit. Michael -- Michael Meskes Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org) Michael at BorussiaFan dot De, Meskes at (Debian|Postgresql) dot Org Jabber: michael.meskes at gmail dot com VfL Borussia! Força Bar

Re: [HACKERS] gcc 4.8 compiler warning in ecpg check

On Sat, Nov 02, 2013 at 02:25:17PM -0400, Peter Eisentraut wrote: > This could be removed, but is it something that is actually part of what > is being tested? Thanks for spotting Peter. Yes, this should have been used. I just committed a fix. Michael -- Michael Meskes Michael at Fam-

Re: [HACKERS] [9.3 bug fix] ECPG does not escape backslashes

up any problem with chars below 0x20. If anybody sees another character breaking ecpg, please tell me and I'll fix it. Michael -- Michael Meskes Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org) Michael at BorussiaFan dot De, Meskes at (Debian|Postgresql) dot Org Jabber:

Re: [HACKERS] [9.3 bug fix] ECPG does not escape backslashes

On Fri, Jul 05, 2013 at 09:41:26AM -0400, Tom Lane wrote: > Um ... 9.3 is a separate branch now, please fix it there also. Done. Seems I missed a new branch - yet again. Sorry and thanks for pointing it out to me. michael -- Michael Meskes Michael at Fam-Meskes dot De, Michael at Meskes dot

Re: [HACKERS] [9.3 bug fix] ECPG does not escape backslashes

ere are surely more characters that need to be escaped. Gotta dig into this. Thanks for pointing this out. Michael -- Michael Meskes Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org) Michael at BorussiaFan dot De, Meskes at (Debian|Postgresql) dot Org Jabber: michael.meskes at gmail d

Re: [HACKERS] [9.3 bug fix] ECPG does not escape backslashes

On Wed, Jul 03, 2013 at 07:22:48PM +0900, MauMau wrote: > not specific to 9.3. Could you commit and backport this? Committed to 8.4, 9.0, 9.1, 9.2 and HEAD. Michael -- Michael Meskes Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org) Michael at BorussiaFan dot De, Meskes

Re: [HACKERS] [9.3 bug fix] ECPG does not escape backslashes

e escaped in filenames in #line directives, right? Apparently my examples were badly chosen as I didn't see an error no matter how many backslashes I had. Michael -- Michael Meskes Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org) Michael at BorussiaFan dot De, Mes

Re: [HACKERS] [9.3 bug fix] ECPG does not escape backslashes

lashes come are two that are escaped for shell usage. The directory name is in my example was "test\\a". What did I miss? Michael -- Michael Meskes Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org) Michael at BorussiaFan dot De, Meskes at (Debian|Postgresql) dot O

Re: [HACKERS] [9.3 bug fix] ECPG does not escape backslashes

clude/postgresql/ -l ecpg michael@feivel:~$ This seems to suggest that it works nicely on Linux. So what do ou mean when saying the problem also occurs on Linux? Michael -- Michael Meskes Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org) Michael at BorussiaFan dot De, Mesk

Re: [HACKERS] [9.4 CF 1] The Commitfest Slacker List

ask people who are listed on the project > developers page as major contributors to review one patch per CommitFest > most of the time. If they did just *one* it would substantially > decrease the workload on the people who are currently doing the vast > majority of review and commi

Re: [HACKERS] [9.4 CF 1] The Commitfest Slacker List

ce this email in the first hand until I was approached from other people and called a slacker in communication not related to the CF at all. Michael -- Michael Meskes Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org) Michael at BorussiaFan dot De, Meskes at (Debian|Postgresql

Re: [HACKERS] [9.4 CF 1] The Commitfest Slacker List

m him but ... Michael -- Michael Meskes Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org) Michael at BorussiaFan dot De, Meskes at (Debian|Postgresql) dot Org Jabber: michael.meskes at gmail dot com VfL Borussia! Força Barça! Go SF 49ers! Use Debian GNU/Linux, PostgreSQL -- Sent via

Re: [HACKERS] [9.4 CF 1] The Commitfest Slacker List

at is not true, at least for some on your list. I think I better not bring up the word I would describe your email with, just for the fear of mistranslating it. Michael -- Michael Meskes Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org) Michael at BorussiaFan dot De, Meskes at (D

Re: [HACKERS] [9.4 CF 1] The Commitfest Slacker List

On Tue, Jul 02, 2013 at 04:00:22PM -0400, Robert Haas wrote: > make you review patches against your will. Don't take it for more > than what Josh meant it as. And that was what? Michael -- Michael Meskes Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)

Re: [HACKERS] [9.4 CF 1] The Commitfest Slacker List

d in the discussion. Michael -- Michael Meskes Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org) Michael at BorussiaFan dot De, Meskes at (Debian|Postgresql) dot Org Jabber: michael.meskes at gmail dot com VfL Borussia! Força Barça! Go SF 49ers! Use Debian GNU/Linux, PostgreSQL

Re: [HACKERS] [9.3 doc fix] ECPG VAR command does not describe the actual specification

> Looking around the 9.3 doc, I found a small, but not-insignificant > error in the documentation. Thanks for finding and fixing. Patch committed. Michael -- Michael Meskes Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org) Michael at BorussiaFan dot De, Meskes at (

Re: [HACKERS] Bug in tm2timestamp

hat does "the right thing" for ecpg? Michael -- Michael Meskes Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org) Michael at BorussiaFan dot De, Meskes at (Debian|Postgresql) dot Org Jabber: michael.meskes at gmail dot com VfL Borussia! Força Barça! Go SF 49ers! Use

Re: [HACKERS] Bug in tm2timestamp

gtypes was taken from the backend back when it was developed. Michael -- Michael Meskes Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org) Michael at BorussiaFan dot De, Meskes at (Debian|Postgresql) dot Org Jabber: michael.meskes at gmail dot com VfL Borussia! Força Barça! Go

  1   2   3   4   5   6   7   >